diff
stringlengths
65
26.7k
message
stringlengths
7
9.92k
diff --git a/spec/models/github_utils_spec.rb b/spec/models/github_utils_spec.rb index abc1234..def5678 100644 --- a/spec/models/github_utils_spec.rb +++ b/spec/models/github_utils_spec.rb @@ -0,0 +1,20 @@+require "spec_helper" + +describe GithubUtils do + let(:token) { 'x' * 30 } + let(:user) { double(github_id: 'te...
Add first spec around GithubUtils
diff --git a/object_patch.gemspec b/object_patch.gemspec index abc1234..def5678 100644 --- a/object_patch.gemspec +++ b/object_patch.gemspec @@ -18,7 +18,7 @@ spec.test_files = spec.files.grep(%r{^(test|spec|features)/}) spec.require_paths = ["lib"] - spec.add_development_dependency "bundler", "~> 1.3" + sp...
Allow for older version of Gemfile
diff --git a/app/controllers/admins_controller.rb b/app/controllers/admins_controller.rb index abc1234..def5678 100644 --- a/app/controllers/admins_controller.rb +++ b/app/controllers/admins_controller.rb @@ -8,7 +8,13 @@ def show user = User.find(params[:id]) - @productions = user.productions + puts use...
Add routing to productions view from Admin show one user's productions
diff --git a/app/controllers/events_controller.rb b/app/controllers/events_controller.rb index abc1234..def5678 100644 --- a/app/controllers/events_controller.rb +++ b/app/controllers/events_controller.rb @@ -5,7 +5,13 @@ end def create - Event.create(event_params) + @event = Event.new(event_params) + b...
Add flash messages for event form
diff --git a/app/controllers/robots_controller.rb b/app/controllers/robots_controller.rb index abc1234..def5678 100644 --- a/app/controllers/robots_controller.rb +++ b/app/controllers/robots_controller.rb @@ -16,7 +16,7 @@ "Allow: /home", "Allow: /about", "Allow: /collections", - ...
Remove empty slug pages. Fix /resources/ URL. [#147440453]
diff --git a/app/models/concerns/capybara/guides/screenshotable.rb b/app/models/concerns/capybara/guides/screenshotable.rb index abc1234..def5678 100644 --- a/app/models/concerns/capybara/guides/screenshotable.rb +++ b/app/models/concerns/capybara/guides/screenshotable.rb @@ -3,8 +3,8 @@ module Screenshotable ...
Handle device pixel ratio for screenshots
diff --git a/app/workers/asset_manager_attachment_delete_worker.rb b/app/workers/asset_manager_attachment_delete_worker.rb index abc1234..def5678 100644 --- a/app/workers/asset_manager_attachment_delete_worker.rb +++ b/app/workers/asset_manager_attachment_delete_worker.rb @@ -1,8 +1,7 @@ class AssetManagerAttachmentDel...
Tidy up attachment delete worker
diff --git a/lib/event_calendar/engine.rb b/lib/event_calendar/engine.rb index abc1234..def5678 100644 --- a/lib/event_calendar/engine.rb +++ b/lib/event_calendar/engine.rb @@ -5,7 +5,9 @@ class Engine < ::Rails::Engine initializer 'event_calendar.setup_view_helpers' do |app| app.config.to_prepare d...
Fix to helper work with 3.* rails app
diff --git a/lib/heroics/configuration.rb b/lib/heroics/configuration.rb index abc1234..def5678 100644 --- a/lib/heroics/configuration.rb +++ b/lib/heroics/configuration.rb @@ -12,6 +12,7 @@ def initialize @options = {} @options[:cache] = 'Moneta.new(:Memory)' + @options[:default_headers] = {} ...
Handle case where headers are not provided in config
diff --git a/demo/streamer_app.rb b/demo/streamer_app.rb index abc1234..def5678 100644 --- a/demo/streamer_app.rb +++ b/demo/streamer_app.rb @@ -10,7 +10,7 @@ class StreamerApp < Sinatra::Base get '/demo/:shop_id/products.:format/?' do |shop_id, format| - ids = repository(:products).adapter.query('SELECT id FRO...
Use datamapper.select instead of .query.
diff --git a/lib/rasti/web/application.rb b/lib/rasti/web/application.rb index abc1234..def5678 100644 --- a/lib/rasti/web/application.rb +++ b/lib/rasti/web/application.rb @@ -33,7 +33,7 @@ env[PATH_PARAMS] = route.extract_params env['PATH_INFO'] route.endpoint.call env else - no...
Improve page not found info
diff --git a/cocoapods.gemspec b/cocoapods.gemspec index abc1234..def5678 100644 --- a/cocoapods.gemspec +++ b/cocoapods.gemspec @@ -6,7 +6,7 @@ s.version = Pod::VERSION s.date = "2011-09-17" s.license = "MIT" - s.summary = "A simple Objective-C library package manager." + s.summary = "A simple Object...
Add MacRuby note to gemspec summary
diff --git a/lib/support_engine/engine.rb b/lib/support_engine/engine.rb index abc1234..def5678 100644 --- a/lib/support_engine/engine.rb +++ b/lib/support_engine/engine.rb @@ -7,6 +7,12 @@ g.fixture_replacement :factory_girl, :dir => 'spec/factories' g.assets false g.helper false + + initializ...
Add widget helper to actionview
diff --git a/cookbooks/chef/attributes/default.rb b/cookbooks/chef/attributes/default.rb index abc1234..def5678 100644 --- a/cookbooks/chef/attributes/default.rb +++ b/cookbooks/chef/attributes/default.rb @@ -5,4 +5,4 @@ default[:chef][:server][:version] = "12.17.33" # Set the default client version -default[:chef][...
Update chef client to 16.6.14
diff --git a/config/metrics.rb b/config/metrics.rb index abc1234..def5678 100644 --- a/config/metrics.rb +++ b/config/metrics.rb @@ -31,8 +31,8 @@ code: code, method: env['REQUEST_METHOD'].downcase, host: env['HTTP_HOST'].to_s, - path: env['PATH_INFO'], - ...
Use aggregation function to reduce cardinality in labels like path and querystring
diff --git a/spec/base_spec.rb b/spec/base_spec.rb index abc1234..def5678 100644 --- a/spec/base_spec.rb +++ b/spec/base_spec.rb @@ -1,7 +1,9 @@ require File.dirname(__FILE__) + '/spec_helper' describe Resourceful::Base, ".made_resourceful" do + before(:all) { @original_blocks = Resourceful::Base.made_resourceful....
Fix a nasty test bug that caused the integration tests to fail under ill-defined circumstances. git-svn-id: 30fef0787527f3d4b2d3639a5d6955e4dc84682e@160 c18eca5a-f828-0410-9317-b2e082e89db6
diff --git a/lib/coinmux/http.rb b/lib/coinmux/http.rb index abc1234..def5678 100644 --- a/lib/coinmux/http.rb +++ b/lib/coinmux/http.rb @@ -31,7 +31,7 @@ info "HTTP GET Response #{response.code}" raise Coinmux::Error, "Invalid response code: #{response.code}" if response.code.to_s != '200' - debug "HTTP ...
Comment out loud debug message appending request body.
diff --git a/lib/maia/message.rb b/lib/maia/message.rb index abc1234..def5678 100644 --- a/lib/maia/message.rb +++ b/lib/maia/message.rb @@ -59,7 +59,7 @@ }.compact } - hash.merge!(priority: priority) if priority + hash.merge!(priority: priority.to_s) if priority hash.merge!(dry_run: t...
Call to_s on priority so symbols are supported
diff --git a/lib/resque/tasks.rb b/lib/resque/tasks.rb index abc1234..def5678 100644 --- a/lib/resque/tasks.rb +++ b/lib/resque/tasks.rb @@ -42,10 +42,13 @@ # Preload app files if this is Rails task :preload => :setup do - if defined?(Rails) && Rails.env == 'production' - Dir["#{Rails.root}/app/**/*.rb"]...
Use Rails eager loading for resque:preload
diff --git a/lib/rom-relation.rb b/lib/rom-relation.rb index abc1234..def5678 100644 --- a/lib/rom-relation.rb +++ b/lib/rom-relation.rb @@ -20,7 +20,7 @@ ManyTuplesError = Class.new(RuntimeError) # Represent an undefined argument - Undefined = Object.new.freeze + Undefined = Class.new.freeze # An empty f...
Use an instance of class to represent Undefined This gives nicer output for Undefined#inspect
diff --git a/lib/tasks/data.rake b/lib/tasks/data.rake index abc1234..def5678 100644 --- a/lib/tasks/data.rake +++ b/lib/tasks/data.rake @@ -10,6 +10,7 @@ Proposal.all.rename(:word_id => :wordset_id) Seq.all.rename(:word_id => :wordset_id) Proposal.where(_type: "ProposeNewWord").update_all(_type: "Propose...
Rename rake task should assign language to all wordsets
diff --git a/lib/tracking_fwz.rb b/lib/tracking_fwz.rb index abc1234..def5678 100644 --- a/lib/tracking_fwz.rb +++ b/lib/tracking_fwz.rb @@ -1,5 +1,13 @@ require "tracking_fwz/version" module TrackingFwz - # Your code goes here... + class Engine < ::Rails::Engine + end + + mattr_accessor :model_devise + @@model...
Update module, defined model_devise for config
diff --git a/config/sitemap.rb b/config/sitemap.rb index abc1234..def5678 100644 --- a/config/sitemap.rb +++ b/config/sitemap.rb @@ -1,5 +1,7 @@ # Set the host name for URL creation -SitemapGenerator::Sitemap.default_host = "http://www.example.com" +SitemapGenerator::Sitemap.default_host = "https://yande.re" +SitemapGe...
Fix indentation and move irrelevant configs.
diff --git a/Framezilla.podspec b/Framezilla.podspec index abc1234..def5678 100644 --- a/Framezilla.podspec +++ b/Framezilla.podspec @@ -1,6 +1,6 @@ Pod::Spec.new do |spec| spec.name = "Framezilla" - spec.version = "2.8.0" + spec.version = "2.9.0" spec.summary = "Comfortab...
Change the podspec version -> 2.9.0
diff --git a/spec/acceptance/support/test_ui.rb b/spec/acceptance/support/test_ui.rb index abc1234..def5678 100644 --- a/spec/acceptance/support/test_ui.rb +++ b/spec/acceptance/support/test_ui.rb @@ -3,7 +3,7 @@ METHODS = [:clear_line, :report_progress, :warn, :error, :info, :success] - def initialize(resource ...
Fix TestUI to work with Vagrant 1.2+
diff --git a/spec/aruba-doubles/history_spec.rb b/spec/aruba-doubles/history_spec.rb index abc1234..def5678 100644 --- a/spec/aruba-doubles/history_spec.rb +++ b/spec/aruba-doubles/history_spec.rb @@ -1,35 +1,37 @@ require 'spec_helper' -describe ArubaDoubles::History do - before do - PStore.stub(:new) - @his...
Move history examples into module
diff --git a/spec/factories/contacts_factory.rb b/spec/factories/contacts_factory.rb index abc1234..def5678 100644 --- a/spec/factories/contacts_factory.rb +++ b/spec/factories/contacts_factory.rb @@ -8,11 +8,11 @@ end trait :with_email_address do - email_address { "eleanor@liverpool.uk" } + email_...
Use random email and phone for mock contacts
diff --git a/spec/features/benchmarking_spec.rb b/spec/features/benchmarking_spec.rb index abc1234..def5678 100644 --- a/spec/features/benchmarking_spec.rb +++ b/spec/features/benchmarking_spec.rb @@ -3,7 +3,7 @@ describe 'benchmarking' do def do_things visit root_path - 1.times do + 5.times do fin...
Set repetitions to a big enough number
diff --git a/spec/features/user_account_spec.rb b/spec/features/user_account_spec.rb index abc1234..def5678 100644 --- a/spec/features/user_account_spec.rb +++ b/spec/features/user_account_spec.rb @@ -5,14 +5,12 @@ it "Persists the user in the database" do visit root_path click_link_or_button "create_...
Bring account creation test in line with devise defaults Since I didn't remember what Devise does by default, I had to change my test to match the form that it presents. To get these I used my browsers debugger tools to find the `id` attribute on each of the form fields. While you *can* use the content of the label ...
diff --git a/spec/lib/octonore/template_spec.rb b/spec/lib/octonore/template_spec.rb index abc1234..def5678 100644 --- a/spec/lib/octonore/template_spec.rb +++ b/spec/lib/octonore/template_spec.rb @@ -48,7 +48,7 @@ template.should respond_to :update end - it "should get update data from Github" do + ...
Reword it block of test.
diff --git a/spec/unit/custom_formatter_spec.rb b/spec/unit/custom_formatter_spec.rb index abc1234..def5678 100644 --- a/spec/unit/custom_formatter_spec.rb +++ b/spec/unit/custom_formatter_spec.rb @@ -1,14 +1,12 @@ # coding: utf-8 -require 'spec_helper' - -RSpec.describe TTY::ProgressBar, 'custom' do +RSpec.describe ...
Change spec to properly handle constant.
diff --git a/lib/servitude/configuration.rb b/lib/servitude/configuration.rb index abc1234..def5678 100644 --- a/lib/servitude/configuration.rb +++ b/lib/servitude/configuration.rb @@ -37,6 +37,10 @@ end def from_file( file_path ) + unless File.exists?( file_path ) + raise "Configuration ...
Add error handling in Configuration::from_file and set the config_loaded flag to true.
diff --git a/lib/cannon/app.rb b/lib/cannon/app.rb index abc1234..def5678 100644 --- a/lib/cannon/app.rb +++ b/lib/cannon/app.rb @@ -37,8 +37,8 @@ end def define_root - root_wd = @app_binding.eval("Dir.getwd()") - Cannon.send(:define_method, :root, -> { root_wd }) + root_dir = @app_binding.eva...
Improve Cannon.root ability to get root directory
diff --git a/LayerUIKit.podspec b/LayerUIKit.podspec index abc1234..def5678 100644 --- a/LayerUIKit.podspec +++ b/LayerUIKit.podspec @@ -22,5 +22,5 @@ s.ios.frameworks = 'UIKit' s.ios.deployment_target = '7.0' - s.dependency 'LayerKit', git: 'git@github.com:layerhq/LayerKit.git', :tag => 'v0.9.0-pre3 ' + s.dep...
Use a valid version dependency for Podspec
diff --git a/gov_uk_date_fields.gemspec b/gov_uk_date_fields.gemspec index abc1234..def5678 100644 --- a/gov_uk_date_fields.gemspec +++ b/gov_uk_date_fields.gemspec @@ -8,7 +8,7 @@ s.name = "gov_uk_date_fields" s.version = GovUkDateFields::VERSION s.authors = ["Stephen Richards"] - s.email ...
Change email address on gemspec
diff --git a/app/controllers/api/v1/customers.rb b/app/controllers/api/v1/customers.rb index abc1234..def5678 100644 --- a/app/controllers/api/v1/customers.rb +++ b/app/controllers/api/v1/customers.rb @@ -38,6 +38,17 @@ current_customer.as_json(include: { discount_cards: { include: :barcode } })....
Add customer update API method
diff --git a/app/controllers/shows_controller.rb b/app/controllers/shows_controller.rb index abc1234..def5678 100644 --- a/app/controllers/shows_controller.rb +++ b/app/controllers/shows_controller.rb @@ -1,6 +1,6 @@ class ShowsController < ApplicationController def index - @year = params[:year] || DateTime.now.y...
Set year to a string for now
diff --git a/app/controllers/users_controller.rb b/app/controllers/users_controller.rb index abc1234..def5678 100644 --- a/app/controllers/users_controller.rb +++ b/app/controllers/users_controller.rb @@ -1,7 +1,50 @@ class UsersController < ApplicationController def edit - redirect_to new_user_session_path unles...
Update Users Controller for icon Update Add actions to the Users controller to handle updating the User's icon.
diff --git a/app/controllers/users_controller.rb b/app/controllers/users_controller.rb index abc1234..def5678 100644 --- a/app/controllers/users_controller.rb +++ b/app/controllers/users_controller.rb @@ -2,6 +2,7 @@ def show + @user = current_user @trips = @user.trips end
Fix typo in user controller
diff --git a/app/models/action_text/rich_text.rb b/app/models/action_text/rich_text.rb index abc1234..def5678 100644 --- a/app/models/action_text/rich_text.rb +++ b/app/models/action_text/rich_text.rb @@ -8,6 +8,6 @@ has_many_attached :embeds after_save do - self.embeds_attachments_blobs = body.attachments.ma...
Use the correct API for blob assignment
diff --git a/lib/avoid_metreon/haml_renderer.rb b/lib/avoid_metreon/haml_renderer.rb index abc1234..def5678 100644 --- a/lib/avoid_metreon/haml_renderer.rb +++ b/lib/avoid_metreon/haml_renderer.rb @@ -0,0 +1,18 @@+require 'haml' + +module AvoidMetreon + # A simple HAML renderer, that takes a template name and data. + ...
Add extremely simple HAML renderer. Allows you to render a file from the specified templates directory. Since it passes itself in as the render context, this allows partials to be rendered as well from within a template.
diff --git a/lib/chef/knife/node_environment.rb b/lib/chef/knife/node_environment.rb index abc1234..def5678 100644 --- a/lib/chef/knife/node_environment.rb +++ b/lib/chef/knife/node_environment.rb @@ -0,0 +1,55 @@+# +# Author:: Jimmy McCrory (<jimmy.mccrory@gmail.com>) +# Copyright:: Copyright (c) 2014 Jimmy McCrory +#...
[CHEF-1910] Manage node environments with knife
diff --git a/lib/graphql/types/iso_8601_date.rb b/lib/graphql/types/iso_8601_date.rb index abc1234..def5678 100644 --- a/lib/graphql/types/iso_8601_date.rb +++ b/lib/graphql/types/iso_8601_date.rb @@ -6,7 +6,7 @@ # # Use it for fields or arguments as follows: # - # field :created_at, GraphQL::Types...
Change misleading field name [ci skip]
diff --git a/jekyll-index-pages.gemspec b/jekyll-index-pages.gemspec index abc1234..def5678 100644 --- a/jekyll-index-pages.gemspec +++ b/jekyll-index-pages.gemspec @@ -22,7 +22,7 @@ spec.require_paths = ["lib"] spec.add_dependency("i18n", "~> 0.8") - spec.add_dependency("jekyll", "~> 3.3") + spec.add_depende...
Fix Jekyll version below 3.5.0
diff --git a/lib/omise/util.rb b/lib/omise/util.rb index abc1234..def5678 100644 --- a/lib/omise/util.rb +++ b/lib/omise/util.rb @@ -7,7 +7,7 @@ module Util module_function def typecast(object) klass = begin - const_get(object["object"].capitalize) + Omise.const_get(object["object"].capitali...
Fix const_get is looking at the wrong place
diff --git a/rspec_test/spec/calc_spec.rb b/rspec_test/spec/calc_spec.rb index abc1234..def5678 100644 --- a/rspec_test/spec/calc_spec.rb +++ b/rspec_test/spec/calc_spec.rb @@ -1,17 +1,15 @@ require 'calc' RSpec.describe Calc do - before do - @calc = Calc.new - end + subject(:calc) { Calc.new } it "given ...
Change before def to subject
diff --git a/rubicure_fuzzy_match.gemspec b/rubicure_fuzzy_match.gemspec index abc1234..def5678 100644 --- a/rubicure_fuzzy_match.gemspec +++ b/rubicure_fuzzy_match.gemspec @@ -18,7 +18,7 @@ spec.executables = spec.files.grep(%r{^exe/}) { |f| File.basename(f) } spec.require_paths = ["lib"] - spec.add_dependen...
Upgrade rubicure version to 0.2.7
diff --git a/pandoc-ruby.gemspec b/pandoc-ruby.gemspec index abc1234..def5678 100644 --- a/pandoc-ruby.gemspec +++ b/pandoc-ruby.gemspec @@ -6,8 +6,6 @@ Gem::Specification.new do |s| s.name = 'pandoc-ruby' s.version = '2.0.2' - - s.required_rubygems_version = Gem::Requirement.new('>= 0') if s.respond_to? :requir...
Remove some optional attributes from gemspec. Remove unnecessary attributes to reduce maintenance overhead.
diff --git a/lib/berks_to_rightscale.rb b/lib/berks_to_rightscale.rb index abc1234..def5678 100644 --- a/lib/berks_to_rightscale.rb +++ b/lib/berks_to_rightscale.rb @@ -25,4 +25,6 @@ require 'fog' require 'thor' -require 'berks_to_rightscale/cli'+SafeYAML::OPTIONS[:deserialize_symbols] = true if defined? SafeYAML::O...
Work around safe_yaml's evil breakage of fog by setting SafeYAML::OPTIONS[:deserialize_symbols] if SafeYAML::OPTIONS is defined.
diff --git a/lib/cms_tags/categories.rb b/lib/cms_tags/categories.rb index abc1234..def5678 100644 --- a/lib/cms_tags/categories.rb +++ b/lib/cms_tags/categories.rb @@ -6,9 +6,7 @@ end def form_field(object_name, view, index) - options = { id: form_field_id, class: "form-control" } - - input = view.col...
Remove option code that wasn't being applied and isn't required
diff --git a/spec/centos/network_spec.rb b/spec/centos/network_spec.rb index abc1234..def5678 100644 --- a/spec/centos/network_spec.rb +++ b/spec/centos/network_spec.rb @@ -8,7 +8,9 @@ it { should be_resolvable } end - +# With newer builds using sdc-vmtools these files are always created at boot +# Also, you would...
Update network tests for sdc-vmtools and new build process
diff --git a/spec/data_set/sleep_spec.rb b/spec/data_set/sleep_spec.rb index abc1234..def5678 100644 --- a/spec/data_set/sleep_spec.rb +++ b/spec/data_set/sleep_spec.rb @@ -1,5 +1,29 @@ require 'spec_helper' describe RubyJawbone::DataSet::Sleep do - # + let(:date) { Date.new(2014, 1, 21) } + let(:bed_time) { Time...
Add spec to describe initializing a sleep data set object with sleep values.
diff --git a/spec/geometry/point_spec.rb b/spec/geometry/point_spec.rb index abc1234..def5678 100644 --- a/spec/geometry/point_spec.rb +++ b/spec/geometry/point_spec.rb @@ -11,5 +11,13 @@ expect(point.abscissa).to eq(5) expect(point.ordinate).to eq(8) end + + it "should not be writeable" do + ...
Write spec to Point class to check for read only
diff --git a/spec/models/project_spec.rb b/spec/models/project_spec.rb index abc1234..def5678 100644 --- a/spec/models/project_spec.rb +++ b/spec/models/project_spec.rb @@ -0,0 +1,30 @@+require 'rails_helper' + +describe Project do + + describe "next" do + before do + @first = create(:project) + @second ...
Add tests for project sorting
diff --git a/spec/models/session_spec.rb b/spec/models/session_spec.rb index abc1234..def5678 100644 --- a/spec/models/session_spec.rb +++ b/spec/models/session_spec.rb @@ -11,13 +11,13 @@ describe 'validate device_token presence' do context 'device present' do - subject { stub_model Session, device: :ios...
Replace stub_model with real instance
diff --git a/spec/pagetience/dsl_spec.rb b/spec/pagetience/dsl_spec.rb index abc1234..def5678 100644 --- a/spec/pagetience/dsl_spec.rb +++ b/spec/pagetience/dsl_spec.rb @@ -6,8 +6,6 @@ include PageObject include Pagetience end - -class SecondPage < FirstPage; end describe Pagetience::DSL do let(:browser) { ...
Remove unused class in dsl spec
diff --git a/lib/geocoder/ip_address.rb b/lib/geocoder/ip_address.rb index abc1234..def5678 100644 --- a/lib/geocoder/ip_address.rb +++ b/lib/geocoder/ip_address.rb @@ -1,7 +1,8 @@ module Geocoder class IpAddress < String + def loopback? - (self == "0.0.0.0" or self.match(/\A127/)) + valid? and (self ...
Include validity as criterion for loopback.
diff --git a/jqgrid_rails.gemspec b/jqgrid_rails.gemspec index abc1234..def5678 100644 --- a/jqgrid_rails.gemspec +++ b/jqgrid_rails.gemspec @@ -11,6 +11,7 @@ s.require_path = 'lib' s.has_rdoc = true s.extra_rdoc_files = ['README.rdoc', 'LICENSE.rdoc', 'CHANGELOG.rdoc'] + s.add_dependency 'rails_javascript_hel...
Add dependency for javascript helpers
diff --git a/db/migrate/023_non_nullable_associations_timestamps.rb b/db/migrate/023_non_nullable_associations_timestamps.rb index abc1234..def5678 100644 --- a/db/migrate/023_non_nullable_associations_timestamps.rb +++ b/db/migrate/023_non_nullable_associations_timestamps.rb @@ -0,0 +1,11 @@+class NonNullableAssociati...
Add migration: Make non nullable timestamp of associtation tables
diff --git a/drugs.gemspec b/drugs.gemspec index abc1234..def5678 100644 --- a/drugs.gemspec +++ b/drugs.gemspec @@ -15,7 +15,7 @@ spec.license = "MIT" spec.files = `git ls-files -z`.split("\x0").reject do |f| - f.match(%r{^(test|spec|features)/}) + f.match(%r{^(test/|spec/|features/|\.gitign...
Exclude Node.js specific file from gemspec
diff --git a/FeedBunch-app/config/initializers/aws-sdk.rb b/FeedBunch-app/config/initializers/aws-sdk.rb index abc1234..def5678 100644 --- a/FeedBunch-app/config/initializers/aws-sdk.rb +++ b/FeedBunch-app/config/initializers/aws-sdk.rb @@ -1,18 +1,20 @@ # frozen_string_literal: true -require 'aws-sdk-s3' +if Rails.e...
Initialize AWS-S3 only in production environment
diff --git a/app/models/game.rb b/app/models/game.rb index abc1234..def5678 100644 --- a/app/models/game.rb +++ b/app/models/game.rb @@ -3,5 +3,5 @@ had_many :venues, through: :gamevenues has_many :usergames has_many :users, through: :usergames - belongs_to :users + belongs_to :user end
Change users to user on belongs_to
diff --git a/app/models/page.rb b/app/models/page.rb index abc1234..def5678 100644 --- a/app/models/page.rb +++ b/app/models/page.rb @@ -5,6 +5,9 @@ named_scope :header_links, :conditions => ["show_in_header = ?", true], :order => 'position' named_scope :footer_links, :conditions => ["show_in_footer = ?", true], :...
Add link method to Page model. Signed-off-by: Peter Berkenbosch <51b70fe95cd023174431b055755b7ef384a4462b@me.com>
diff --git a/app/models/post.rb b/app/models/post.rb index abc1234..def5678 100644 --- a/app/models/post.rb +++ b/app/models/post.rb @@ -10,7 +10,12 @@ post = user.posts.new post.message_id = mitt.message_id post.title = mitt.subject - post.body = mitt.body + post.body = if mitt...
Choose between html and text body
diff --git a/app/models/user.rb b/app/models/user.rb index abc1234..def5678 100644 --- a/app/models/user.rb +++ b/app/models/user.rb @@ -5,7 +5,7 @@ after_create :create_club - attr_accessible :name, :description, :email, :password, :password_confirmation, :remember_me + attr_accessible :name, :description, :em...
Add icon as attr_accessible for User Update the User model to make the icon attribute attr_accessible for updates.
diff --git a/test/features/submit_event_test.rb b/test/features/submit_event_test.rb index abc1234..def5678 100644 --- a/test/features/submit_event_test.rb +++ b/test/features/submit_event_test.rb @@ -0,0 +1,73 @@+require 'test_helper' + +class SubmitEventTest < Capybara::Rails::TestCase + include CapybaraHelper + + ...
Add test for submitter sign up, create event and availability
diff --git a/test/integration/home_page_test.rb b/test/integration/home_page_test.rb index abc1234..def5678 100644 --- a/test/integration/home_page_test.rb +++ b/test/integration/home_page_test.rb @@ -44,9 +44,7 @@ with_current_site(site) do visit @path - assert has_link?("By signing up you agree to t...
Change test of subscription box in footer layout The test must be changed because bd2bc92a89 disables subscription box
diff --git a/asset_hash.gemspec b/asset_hash.gemspec index abc1234..def5678 100644 --- a/asset_hash.gemspec +++ b/asset_hash.gemspec @@ -3,7 +3,7 @@ Gem::Specification.new do |s| s.name = "asset_hash" s.summary = "Asset hasher for Cloudfront custom origin domain asset hosting." - s.description = "This gem allows...
Update the description of the gemspec
diff --git a/serverspec/spec/ap/ap_configure_spec.rb b/serverspec/spec/ap/ap_configure_spec.rb index abc1234..def5678 100644 --- a/serverspec/spec/ap/ap_configure_spec.rb +++ b/serverspec/spec/ap/ap_configure_spec.rb @@ -1,5 +1,4 @@ require 'spec_helper' -require 'mysql2' require 'cloud_conductor_utils/consul' desc...
Fix db server connection example, use the hping3 instead mysql2 gem
diff --git a/brid.gemspec b/brid.gemspec index abc1234..def5678 100644 --- a/brid.gemspec +++ b/brid.gemspec @@ -4,8 +4,8 @@ Gem::Specification.new do |gem| gem.authors = ["Halan Pinheiro"] gem.email = ["halan.pinheiro@gmail.com"] - gem.description = %q{Brazilian identifications like CPF, CNPJ, T...
Cut off accents on gem descriptions
diff --git a/recipes/data_bag.rb b/recipes/data_bag.rb index abc1234..def5678 100644 --- a/recipes/data_bag.rb +++ b/recipes/data_bag.rb @@ -21,7 +21,7 @@ users = begin data_bag(bag) rescue => ex - Chef::Log.info("Data bag #{bag.join('/')} not found (#{ex}), so skipping") + Chef::Log.info("Data bag #{bag} not fou...
Fix data bag missing error message.
diff --git a/recipes/firewall.rb b/recipes/firewall.rb index abc1234..def5678 100644 --- a/recipes/firewall.rb +++ b/recipes/firewall.rb @@ -41,3 +41,11 @@ action :allow notifies :enable, 'firewall[ufw]' end + +bash 'allow connections from docker0' do + user 'root' + cwd '/tmp' + code <<-EOH + /usr/sbin/ufw...
Allow connections in on docker0.
diff --git a/lib/adapters/base.rb b/lib/adapters/base.rb index abc1234..def5678 100644 --- a/lib/adapters/base.rb +++ b/lib/adapters/base.rb @@ -9,7 +9,7 @@ end def dry? - @dry ||= @options.fetch(:dry) + @dry ||= @options.fetch(:dry, false) end end end
Fix adapters work without `dry` option
diff --git a/spec/appsignal/inactive_railtie_spec.rb b/spec/appsignal/inactive_railtie_spec.rb index abc1234..def5678 100644 --- a/spec/appsignal/inactive_railtie_spec.rb +++ b/spec/appsignal/inactive_railtie_spec.rb @@ -3,22 +3,26 @@ describe "Inactive Appsignal::Railtie" do it "should not insert itself into the mi...
Disable inactive test for JRuby
diff --git a/spec/features/create_a_question_spec.rb b/spec/features/create_a_question_spec.rb index abc1234..def5678 100644 --- a/spec/features/create_a_question_spec.rb +++ b/spec/features/create_a_question_spec.rb @@ -0,0 +1,33 @@+require 'rails_helper' + +describe "Create a quetsion", type: :feature do + let(:ques...
Add test to 'create test case' feature
diff --git a/lib/dough/helpers.rb b/lib/dough/helpers.rb index abc1234..def5678 100644 --- a/lib/dough/helpers.rb +++ b/lib/dough/helpers.rb @@ -6,31 +6,33 @@ module Dough module Helpers def method_missing(method_name, *args, &block) - helper = "Dough::Helpers::Renderer".constantize if args.first.cl...
Improve the readability of Dough::Helpers
diff --git a/lib/error_handler.rb b/lib/error_handler.rb index abc1234..def5678 100644 --- a/lib/error_handler.rb +++ b/lib/error_handler.rb @@ -19,9 +19,24 @@ def handle_standard_error(exception) if %w(production staging).include?(Rails.env) require "sentry-raven" + if publisher = introspect_publish...
Add Publisher sentry context to ErrorHandler
diff --git a/lib/tasks/users.rake b/lib/tasks/users.rake index abc1234..def5678 100644 --- a/lib/tasks/users.rake +++ b/lib/tasks/users.rake @@ -20,4 +20,16 @@ user.update!(username: new_username) end end + + desc 'Renames users with id-like usernames' + task remove_id_like_usernames: :environment do + ...
Add a task to change id-like usernames
diff --git a/zxcvbn-ruby.gemspec b/zxcvbn-ruby.gemspec index abc1234..def5678 100644 --- a/zxcvbn-ruby.gemspec +++ b/zxcvbn-ruby.gemspec @@ -20,4 +20,12 @@ gem.add_development_dependency 'therubyracer' gem.add_development_dependency 'rspec' + + gem.metadata = { + "bug_tracker_uri" => "https://github.com/enva...
Add gem metadata for unwrappr - https://guides.rubygems.org/specification-reference/#metadata - https://github.com/envato/unwrappr
diff --git a/lib/xapi/homework.rb b/lib/xapi/homework.rb index abc1234..def5678 100644 --- a/lib/xapi/homework.rb +++ b/lib/xapi/homework.rb @@ -1,5 +1,7 @@ module Xapi - # Homework gets all of a user's currently pending problems. + # Homework gets all of a user's currently pending problems, + # marking any new ones...
Add note to self about refactoring Homework
diff --git a/hutch.gemspec b/hutch.gemspec index abc1234..def5678 100644 --- a/hutch.gemspec +++ b/hutch.gemspec @@ -1,7 +1,13 @@ require File.expand_path('../lib/hutch/version', __FILE__) Gem::Specification.new do |gem| - gem.add_runtime_dependency 'bunny', '>= 1.7.0' + if defined?(JRUBY_VERSION) + gem.platfor...
Add march_hare as a runtime dependency if running under jruby
diff --git a/roles/nchc.rb b/roles/nchc.rb index abc1234..def5678 100644 --- a/roles/nchc.rb +++ b/roles/nchc.rb @@ -11,7 +11,7 @@ :hosted_by => "NCHC", :location => "Hsinchu, Taiwan", :networking => { - :nameservers => ["8.8.8.8", "8.8.4.4"], + :nameservers => ["140.110.16.1", "140.110.4.1"], :roles...
Use local name servers on longma
diff --git a/spec/views/ideas_views_spec.rb b/spec/views/ideas_views_spec.rb index abc1234..def5678 100644 --- a/spec/views/ideas_views_spec.rb +++ b/spec/views/ideas_views_spec.rb @@ -19,6 +19,7 @@ describe "ideas/show.html.haml" do it "renders ideas/show" do + @idea = create(:idea) render :templa...
Create an idea to show in idea view test. When the idea 'show' page is implemented, it will need an idea to show. Otherwise, everything on the page will be nil when trying to display idea information.
diff --git a/lib/earth/electricity/electric_utility.rb b/lib/earth/electricity/electric_utility.rb index abc1234..def5678 100644 --- a/lib/earth/electricity/electric_utility.rb +++ b/lib/earth/electricity/electric_utility.rb @@ -4,7 +4,7 @@ self.primary_key = "eia_id" belongs_to :state, :foreign_key => 'state_...
Fix ElectricMarket => ElectricUtility relationship
diff --git a/lib/kubernetes-deploy/formatted_logger.rb b/lib/kubernetes-deploy/formatted_logger.rb index abc1234..def5678 100644 --- a/lib/kubernetes-deploy/formatted_logger.rb +++ b/lib/kubernetes-deploy/formatted_logger.rb @@ -19,8 +19,6 @@ end "[#{context}][#{namespace}]" - else - "" ...
Remove superfluous else clause when logging with a prefix
diff --git a/lib/locomotive/common/plugins/notifier.rb b/lib/locomotive/common/plugins/notifier.rb index abc1234..def5678 100644 --- a/lib/locomotive/common/plugins/notifier.rb +++ b/lib/locomotive/common/plugins/notifier.rb @@ -4,10 +4,10 @@ class Notifier def initialize(exception) - exceptio...
Change name of plugin sample
diff --git a/lib/stl_public_services/cli_controller.rb b/lib/stl_public_services/cli_controller.rb index abc1234..def5678 100644 --- a/lib/stl_public_services/cli_controller.rb +++ b/lib/stl_public_services/cli_controller.rb @@ -1,3 +1,19 @@ class StlPublicServices::CliController + def call + start + end + + def sta...
Update Cli Class to include several methods to test that spec is working.
diff --git a/config/initializers/carrierwave.rb b/config/initializers/carrierwave.rb index abc1234..def5678 100644 --- a/config/initializers/carrierwave.rb +++ b/config/initializers/carrierwave.rb @@ -3,7 +3,6 @@ config.storage :fog config.fog_public = false ...
Remove URL expiry config value
diff --git a/lib/discordrb/errors.rb b/lib/discordrb/errors.rb index abc1234..def5678 100644 --- a/lib/discordrb/errors.rb +++ b/lib/discordrb/errors.rb @@ -11,14 +11,6 @@ end end - # Raised when a HTTP status code indicates a failure - class HTTPStatusError < RuntimeError - attr_reader :status ...
Remove HTTPStatusError as it's used nowhere anymore
diff --git a/lib/designernews/core_ext/string.rb b/lib/designernews/core_ext/string.rb index abc1234..def5678 100644 --- a/lib/designernews/core_ext/string.rb +++ b/lib/designernews/core_ext/string.rb @@ -1,7 +1,7 @@ class String - def truncate(position, omission = '…') + def truncate(position) if self.length > ...
Set ellipsis as the only truncation character
diff --git a/lib/geocoder/railtie.rb b/lib/geocoder/railtie.rb index abc1234..def5678 100644 --- a/lib/geocoder/railtie.rb +++ b/lib/geocoder/railtie.rb @@ -4,7 +4,7 @@ if defined? Rails::Railtie require 'rails' class Railtie < Rails::Railtie - initializer 'geocoder.insert_into_active_record' do + ...
Update Railtie initializer to run before config intializers
diff --git a/lib/excon/middlewares/idempotent.rb b/lib/excon/middlewares/idempotent.rb index abc1234..def5678 100644 --- a/lib/excon/middlewares/idempotent.rb +++ b/lib/excon/middlewares/idempotent.rb @@ -7,8 +7,8 @@ # reduces remaining retries, reset connection, and restart request_call datum[:ret...
Revert "avoid mutating datum in idempontent" This reverts commit dc635a574ab70385e2fecc05d41a67e4b2636214.
diff --git a/lib/pacto/core/contract_registry.rb b/lib/pacto/core/contract_registry.rb index abc1234..def5678 100644 --- a/lib/pacto/core/contract_registry.rb +++ b/lib/pacto/core/contract_registry.rb @@ -1,6 +1,6 @@ module Pacto class ContractRegistry - def register_contract(contract = nil, *tags) + def regis...
Remove default value for register_contract There is no need to register a nil contract
diff --git a/lib/pebbles/tokyu_ruby_kaigi/cli.rb b/lib/pebbles/tokyu_ruby_kaigi/cli.rb index abc1234..def5678 100644 --- a/lib/pebbles/tokyu_ruby_kaigi/cli.rb +++ b/lib/pebbles/tokyu_ruby_kaigi/cli.rb @@ -10,7 +10,7 @@ puts "#{date.strftime("%Y/%m/%d(%a)")}" end - desc "take LIMIT", "show target d...
Add default setting to help of take command.
diff --git a/lib/rorvswild/plugin/action_view.rb b/lib/rorvswild/plugin/action_view.rb index abc1234..def5678 100644 --- a/lib/rorvswild/plugin/action_view.rb +++ b/lib/rorvswild/plugin/action_view.rb @@ -17,6 +17,8 @@ RorVsWild::Section.stop do |section| section.kind = "view".freeze secti...
Replace view file by relative path.
diff --git a/lib/tasks/jmd_seed_rw_contests.rake b/lib/tasks/jmd_seed_rw_contests.rake index abc1234..def5678 100644 --- a/lib/tasks/jmd_seed_rw_contests.rake +++ b/lib/tasks/jmd_seed_rw_contests.rake @@ -0,0 +1,45 @@+namespace :jmd do + namespace :contests do + desc "Seed first-round (RW) contests for all hosts" +...
Add rake task for seeding RW contests + contest categories for a season
diff --git a/lib/rdf/myrepository.rb b/lib/rdf/myrepository.rb index abc1234..def5678 100644 --- a/lib/rdf/myrepository.rb +++ b/lib/rdf/myrepository.rb @@ -6,6 +6,8 @@ def initialize(options = {}) #TODO: Configure initialization + # + # @statements = [] raise NotImplementedError end ...
Add a sample array implementation, commented out.
diff --git a/lib/rom/sql/commands.rb b/lib/rom/sql/commands.rb index abc1234..def5678 100644 --- a/lib/rom/sql/commands.rb +++ b/lib/rom/sql/commands.rb @@ -13,8 +13,8 @@ validation = validator.call(attributes) if validation.success? - id = relation.insert(attributes.to_h) - relation.where(...
Use primary_key for create/update rather than hardcoded :id
diff --git a/lib/support/requires.rb b/lib/support/requires.rb index abc1234..def5678 100644 --- a/lib/support/requires.rb +++ b/lib/support/requires.rb @@ -2,6 +2,7 @@ require 'optparse' require 'raml_parser' require 'json' +require 'fileutils' module RamlPoliglota module Support
Add source requirement to fileutils module.
diff --git a/lib/snmpjr.rb b/lib/snmpjr.rb index abc1234..def5678 100644 --- a/lib/snmpjr.rb +++ b/lib/snmpjr.rb @@ -1,5 +1,20 @@ require "snmpjr/version" +require "snmpjr/pdu" +require "snmpjr/session" +require "snmpjr/target" -module Snmpjr - # Your code goes here... +class Snmpjr + + def initialize options = {} ...
Implement get top level method