diff
stringlengths
65
26.7k
message
stringlengths
7
9.92k
diff --git a/config/application.rb b/config/application.rb index abc1234..def5678 100644 --- a/config/application.rb +++ b/config/application.rb @@ -21,5 +21,6 @@ # Settings in config/environments/* take precedence over those specified here. # Application configuration should go into files in config/initialize...
Add a quick hack to deal with timezone schenanigans.
diff --git a/config/environment.rb b/config/environment.rb index abc1234..def5678 100644 --- a/config/environment.rb +++ b/config/environment.rb @@ -26,4 +26,8 @@ PHONE_HOME_FOR_VERSION_INFO = true unless defined? PHONE_HOME_FOR_VERSION_INFO -Setting.update_all if Setting.table_exists? +begin + Setting.update_all ...
Fix bug keeping setup mode from running.
diff --git a/spec/features/step_definitions/guest_views_project_steps.rb b/spec/features/step_definitions/guest_views_project_steps.rb index abc1234..def5678 100644 --- a/spec/features/step_definitions/guest_views_project_steps.rb +++ b/spec/features/step_definitions/guest_views_project_steps.rb @@ -17,5 +17,5 @@ end ...
Fix failing test (asset tag cache-busting code)
diff --git a/lib/tasks/simple_sanity_check.rake b/lib/tasks/simple_sanity_check.rake index abc1234..def5678 100644 --- a/lib/tasks/simple_sanity_check.rake +++ b/lib/tasks/simple_sanity_check.rake @@ -0,0 +1,26 @@+namespace :simple_sanity_check do + task run: :environment do + connection = ActiveRecord::Base.connec...
Add simple sanity check rake task.
diff --git a/test/test_helper.rb b/test/test_helper.rb index abc1234..def5678 100644 --- a/test/test_helper.rb +++ b/test/test_helper.rb @@ -4,7 +4,7 @@ require 'plugin_test_helper' # Run the migrations -ActiveRecord::Migrator.migrate("#{RAILS_ROOT}/db/migrate") +ActiveRecord::Migrator.migrate("#{Rails.root}/db/migr...
Use Rails.root instead of RAILS_ROOT in preparation for the Rails 2.1 release
diff --git a/test/test_helper.rb b/test/test_helper.rb index abc1234..def5678 100644 --- a/test/test_helper.rb +++ b/test/test_helper.rb @@ -4,7 +4,7 @@ SimpleCov.start do add_group "Main", "lib" add_group "Tests", "test" - enable_coverage :branch + enable_coverage :branch unless RUBY_ENGINE == "jruby" end ...
Disable broken SimpleCov branch coverage on JRuby
diff --git a/manageiq-appliance-dependencies.rb b/manageiq-appliance-dependencies.rb index abc1234..def5678 100644 --- a/manageiq-appliance-dependencies.rb +++ b/manageiq-appliance-dependencies.rb @@ -1,3 +1,3 @@ # Add gems here, in Gemfile syntax, which are dependencies of the appliance itself rather than a part of th...
Update manageiq-appliance_console to minimum v1.2.3 Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1527915 Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1530722
diff --git a/check_if_learn_is_not_down.rb b/check_if_learn_is_not_down.rb index abc1234..def5678 100644 --- a/check_if_learn_is_not_down.rb +++ b/check_if_learn_is_not_down.rb @@ -0,0 +1,42 @@+require 'rubygems' +require 'mechanize' +require 'gmail' + +print "Please enter your gmail address: " +address = gets.chomp +`...
Add code to check if Learn is not down
diff --git a/config.rb b/config.rb index abc1234..def5678 100644 --- a/config.rb +++ b/config.rb @@ -1,3 +1,3 @@ # Docker Host. Default is core-docker (CoreOS) -# String: core-docker|centos-docker +# String: core-docker|centos-docker|centos-atomic $docker_host_vm_name = "core-docker"
Add centos-atomic name to list.
diff --git a/config.ru b/config.ru index abc1234..def5678 100644 --- a/config.ru +++ b/config.ru @@ -2,6 +2,10 @@ require "app" App.set :run, false + +unless File.directory?('log/main.log') + FileUtils.mkdir_p('log/main.log') +end logger = ::File.open("log/main.log", "a+")
Create log dir if doesn't exist
diff --git a/lib/bundler/environment_preserver.rb b/lib/bundler/environment_preserver.rb index abc1234..def5678 100644 --- a/lib/bundler/environment_preserver.rb +++ b/lib/bundler/environment_preserver.rb @@ -14,6 +14,7 @@ PATH RUBYLIB RUBYOPT + RB_USER_INSTALL ].map(&:freeze).freeze ...
Add RB_USER_INSTALL to preserved ENV keys - see #6103
diff --git a/lib/gds_api/test_helpers/need_api.rb b/lib/gds_api/test_helpers/need_api.rb index abc1234..def5678 100644 --- a/lib/gds_api/test_helpers/need_api.rb +++ b/lib/gds_api/test_helpers/need_api.rb @@ -7,9 +7,9 @@ # you could redefine/override the constant or stub directly. NEED_API_ENDPOINT = Plek....
Rename method parameter to highlight organisation ids expected.
diff --git a/test/tests/test_rake_task.rb b/test/tests/test_rake_task.rb index abc1234..def5678 100644 --- a/test/tests/test_rake_task.rb +++ b/test/tests/test_rake_task.rb @@ -0,0 +1,62 @@+require 'fileutils' +require 'tmpdir' + +class RakeTaskTests < Test::Unit::TestCase + def setup + # Brakeman is noisy on error...
Add tests for Rake task creation
diff --git a/lib/logidze/versioned_association.rb b/lib/logidze/versioned_association.rb index abc1234..def5678 100644 --- a/lib/logidze/versioned_association.rb +++ b/lib/logidze/versioned_association.rb @@ -1,4 +1,15 @@ # frozen_string_literal: true + +# `inversed` attr_accessor has been removed in Rails 5.2.1 +# See...
Fix rails 5.2.1 compatibility in versioned association
diff --git a/lib/mutually_exclusive_collection.rb b/lib/mutually_exclusive_collection.rb index abc1234..def5678 100644 --- a/lib/mutually_exclusive_collection.rb +++ b/lib/mutually_exclusive_collection.rb @@ -1,33 +1,33 @@-# A collection of mutually exclusive events. +# A collection of mutually exclusive odds for diffe...
Rename from events to odds
diff --git a/lib/pacer/route/mixin/graph_route.rb b/lib/pacer/route/mixin/graph_route.rb index abc1234..def5678 100644 --- a/lib/pacer/route/mixin/graph_route.rb +++ b/lib/pacer/route/mixin/graph_route.rb @@ -28,6 +28,16 @@ def vertex_name=(a_proc) @vertex_name = a_proc + end + + # The proc used to n...
Define the edge_name callback on graph.
diff --git a/lib/united_workers/worker_spawner.rb b/lib/united_workers/worker_spawner.rb index abc1234..def5678 100644 --- a/lib/united_workers/worker_spawner.rb +++ b/lib/united_workers/worker_spawner.rb @@ -20,12 +20,16 @@ def self.register(bootstrap, pid, channel_id) UnitedWorkers::Queue.new_fanout_queue(...
Add support for shutdown in WorkerSpawner
diff --git a/test/integration/lib/interactor/clicker.rb b/test/integration/lib/interactor/clicker.rb index abc1234..def5678 100644 --- a/test/integration/lib/interactor/clicker.rb +++ b/test/integration/lib/interactor/clicker.rb @@ -6,11 +6,7 @@ include Shared def click_on(position) - run("xdotool...
Use xdotool click instead of mousedown and mouseup Trying to fix the issue of not opening the burguer menu on thunderbird beta.
diff --git a/test/integration/user/confirmation_test.rb b/test/integration/user/confirmation_test.rb index abc1234..def5678 100644 --- a/test/integration/user/confirmation_test.rb +++ b/test/integration/user/confirmation_test.rb @@ -25,7 +25,7 @@ fill_in :user_confirmation_name, with: "user@email.dev" fill...
Fix confirmation year in test
diff --git a/support/rspec2_formatter.rb b/support/rspec2_formatter.rb index abc1234..def5678 100644 --- a/support/rspec2_formatter.rb +++ b/support/rspec2_formatter.rb @@ -36,12 +36,11 @@ }) end - def example_pending example, message, deprecated_pending_location=nil + def example_pen...
Fix pending specs under rspec2 runner The method signature for example_pending has changed between rspec1 and rspec2. The rspec2 formatter wasn't aware of this change, causing specs marked as pending to appear to be failing. Change-Id: Ib591e46b14d86a4fa8a5bd35dbc766675df2ae09 Reviewed-on: https://gerrit.causes.com/4...
diff --git a/config.ru b/config.ru index abc1234..def5678 100644 --- a/config.ru +++ b/config.ru @@ -1,13 +1,22 @@ require 'video_conference/app' require 'faye' require 'newrelic_rpm' +require 'new_relic/agent/instrumentation/rack' NewRelic::Agent.after_fork(:force_reconnect => true) GC::Profiler.enable Faye::We...
Add some NewRelic. Cause metrics are awesome
diff --git a/config.ru b/config.ru index abc1234..def5678 100644 --- a/config.ru +++ b/config.ru @@ -7,5 +7,5 @@ use Rack::ShowExceptions -Shwedagon::App.set :blog, '../example-jekyll/' +Shwedagon::App.set :blog, '../blog/' run Shwedagon::App.new
Put back blog url. My instance was breaking
diff --git a/seven-languages/ruby/day1-guesser.rb b/seven-languages/ruby/day1-guesser.rb index abc1234..def5678 100644 --- a/seven-languages/ruby/day1-guesser.rb +++ b/seven-languages/ruby/day1-guesser.rb @@ -0,0 +1,22 @@+def str_to_int_safe(i) + return Integer(i) +rescue + return nil +end + + +target = rand(10) + ...
Add day 1 exercise for 7-languages
diff --git a/vagrant-dns.gemspec b/vagrant-dns.gemspec index abc1234..def5678 100644 --- a/vagrant-dns.gemspec +++ b/vagrant-dns.gemspec @@ -7,6 +7,7 @@ gem.description = %q{vagrant-dns is a vagrant plugin that manages DNS records associated with local machines.} gem.summary = %q{vagrant-dns manages DNS re...
Add “MIT” license to gemspec
diff --git a/files/default/tests/minitest/default_test.rb b/files/default/tests/minitest/default_test.rb index abc1234..def5678 100644 --- a/files/default/tests/minitest/default_test.rb +++ b/files/default/tests/minitest/default_test.rb @@ -3,7 +3,7 @@ class TestDotNet4Install < MiniTest::Chef::TestCase def test_d...
Use single-quoted strings per extended foodcritic.
diff --git a/guard-foreman.gemspec b/guard-foreman.gemspec index abc1234..def5678 100644 --- a/guard-foreman.gemspec +++ b/guard-foreman.gemspec @@ -5,6 +5,7 @@ s.name = "guard-foreman" s.version = "0.0.1" s.authors = ["Andrei Maxim", "Jonathan Arnett"] + s.licenses = ['MIT'] s.email ...
Update Gemspec to notice license, have modern Guard dependency
diff --git a/lib/gish/concerns/findable.rb b/lib/gish/concerns/findable.rb index abc1234..def5678 100644 --- a/lib/gish/concerns/findable.rb +++ b/lib/gish/concerns/findable.rb @@ -3,6 +3,8 @@ module Findable # IMPROVE: Permit the query to be more complex (e.g.: a regex) def fuzzy_find(files, query, o...
Return an empty array if the query is empty in the fuzzy_find method
diff --git a/henkilotunnus.gemspec b/henkilotunnus.gemspec index abc1234..def5678 100644 --- a/henkilotunnus.gemspec +++ b/henkilotunnus.gemspec @@ -18,10 +18,10 @@ spec.executables = spec.files.grep(%r{^exe/}) { |f| File.basename(f) } spec.require_paths = ["lib"] - spec.add_development_dependency "bundler", ...
Allow multiple mainline versions of dependencies For more widespread use, the same version can now be used with multiple mainline versions of the dependencies.
diff --git a/ical_importer.gemspec b/ical_importer.gemspec index abc1234..def5678 100644 --- a/ical_importer.gemspec +++ b/ical_importer.gemspec @@ -12,6 +12,7 @@ gem.files = `git ls-files`.split("\n") gem.test_files = `git ls-files -- {test,spec,features}/*`.split("\n") gem.name = "ical_imp...
Add license to the gemspec
diff --git a/opal/opal-firebase/firebase.rb b/opal/opal-firebase/firebase.rb index abc1234..def5678 100644 --- a/opal/opal-firebase/firebase.rb +++ b/opal/opal-firebase/firebase.rb @@ -23,8 +23,19 @@ end - # TODO + # Based on + # https://github.com/opal/opal-jquery/blob/master/opal/opal-jquery/element.rb#L279 ...
Add on handler based on opal-jquery
diff --git a/spec/spectator/specs_matcher_spec.rb b/spec/spectator/specs_matcher_spec.rb index abc1234..def5678 100644 --- a/spec/spectator/specs_matcher_spec.rb +++ b/spec/spectator/specs_matcher_spec.rb @@ -0,0 +1,18 @@+require 'spec_helper' +require 'spectator' +require 'spectator/specs_matcher' +require 'pathname' ...
Add some specs for the specs matcher
diff --git a/Casks/tex-live-utility.rb b/Casks/tex-live-utility.rb index abc1234..def5678 100644 --- a/Casks/tex-live-utility.rb +++ b/Casks/tex-live-utility.rb @@ -1,8 +1,8 @@ cask :v1 => 'tex-live-utility' do - version '1.19' - sha256 'ef6beecc42d6b194f18795b46951bf274a5c838d8192f56e4437225af56e2820' + version '1....
Update TeX Live Utility to v1.21
diff --git a/buildserver/cookbooks/fdroidbuild-general/recipes/default.rb b/buildserver/cookbooks/fdroidbuild-general/recipes/default.rb index abc1234..def5678 100644 --- a/buildserver/cookbooks/fdroidbuild-general/recipes/default.rb +++ b/buildserver/cookbooks/fdroidbuild-general/recipes/default.rb @@ -5,7 +5,7 @@ c...
Fix imagemagick (broken in d9bbb507)
diff --git a/lib/generators/styleguide/styleguide_generator.rb b/lib/generators/styleguide/styleguide_generator.rb index abc1234..def5678 100644 --- a/lib/generators/styleguide/styleguide_generator.rb +++ b/lib/generators/styleguide/styleguide_generator.rb @@ -13,6 +13,7 @@ copy_file 'styleguide.html.erb', 'app/vie...
Create place to put widget styles
diff --git a/s3direct.gemspec b/s3direct.gemspec index abc1234..def5678 100644 --- a/s3direct.gemspec +++ b/s3direct.gemspec @@ -19,8 +19,8 @@ spec.require_paths = ["lib"] spec.add_dependency 'activesupport', '>= 3.2.0' - spec.add_dependency 'coffee-rails', '~> 3.2.1' spec.add_dependency 'jquery-fileupload-r...
Remove version from coffee-rails dep
diff --git a/specs/ishigaki-internal/controls/tidy_files.rb b/specs/ishigaki-internal/controls/tidy_files.rb index abc1234..def5678 100644 --- a/specs/ishigaki-internal/controls/tidy_files.rb +++ b/specs/ishigaki-internal/controls/tidy_files.rb @@ -46,7 +46,7 @@ end %w[src.zip demo man sample].each do |cruft| - ...
Fix location of deleted JDK files in test
diff --git a/.delivery/build/attributes/default.rb b/.delivery/build/attributes/default.rb index abc1234..def5678 100644 --- a/.delivery/build/attributes/default.rb +++ b/.delivery/build/attributes/default.rb @@ -1,3 +1,3 @@ include_attribute 'delivery-red-pill' -default['delivery-red-pill']['acceptance']['matrix'] =...
Add upgrade case to attribute file.
diff --git a/app/helpers/application_helper.rb b/app/helpers/application_helper.rb index abc1234..def5678 100644 --- a/app/helpers/application_helper.rb +++ b/app/helpers/application_helper.rb @@ -1,6 +1,6 @@ module ApplicationHelper def bootstrap_class_for flash_type - { "success" => "alert-success", "error" => ...
Change notice flash to success.
diff --git a/app/mailers/application_mailer.rb b/app/mailers/application_mailer.rb index abc1234..def5678 100644 --- a/app/mailers/application_mailer.rb +++ b/app/mailers/application_mailer.rb @@ -1,4 +1,4 @@ class ApplicationMailer < ActionMailer::Base - default from: "Rails Girls Kraków <#{Rails.application.secrets....
Fix issue with retrieving email sender from secrets
diff --git a/app/models/ci/trigger_schedule.rb b/app/models/ci/trigger_schedule.rb index abc1234..def5678 100644 --- a/app/models/ci/trigger_schedule.rb +++ b/app/models/ci/trigger_schedule.rb @@ -14,32 +14,12 @@ validates :cron, cron: true, presence: { unless: :importing? } validates :cron_time_zone, presence...
Remove less_than_1_hour_from_now comments. Dry up def schedule_next_run!
diff --git a/test/taverna_player_test.rb b/test/taverna_player_test.rb index abc1234..def5678 100644 --- a/test/taverna_player_test.rb +++ b/test/taverna_player_test.rb @@ -4,10 +4,4 @@ test "truth" do assert_kind_of Module, TavernaPlayer end - - test "taverna_player_hostname_setting" do - TavernaPlayer.p...
Remove forgotten test for setting hostname. No longer needed.
diff --git a/KKColorListPicker.podspec b/KKColorListPicker.podspec index abc1234..def5678 100644 --- a/KKColorListPicker.podspec +++ b/KKColorListPicker.podspec @@ -9,4 +9,5 @@ s.ios.deployment_target = '7.0' s.source = { :git => "https://github.com/leoru/KKColorListPicker.git", :tag => "v0.2.2" } s.sourc...
Update podspec to fix broken nib dependencies
diff --git a/lib/head_music/style/annotations/avoid_overlapping_voices.rb b/lib/head_music/style/annotations/avoid_overlapping_voices.rb index abc1234..def5678 100644 --- a/lib/head_music/style/annotations/avoid_overlapping_voices.rb +++ b/lib/head_music/style/annotations/avoid_overlapping_voices.rb @@ -15,25 +15,21 @@...
Refactor duplication in overlapping logic.
diff --git a/lib/json_expressions/rspec/matchers/match_json_expression.rb b/lib/json_expressions/rspec/matchers/match_json_expression.rb index abc1234..def5678 100644 --- a/lib/json_expressions/rspec/matchers/match_json_expression.rb +++ b/lib/json_expressions/rspec/matchers/match_json_expression.rb @@ -24,6 +24,10 @@ ...
Add description to support RSpec's attribute of subject
diff --git a/app/api/tutorial_enrolments_api.rb b/app/api/tutorial_enrolments_api.rb index abc1234..def5678 100644 --- a/app/api/tutorial_enrolments_api.rb +++ b/app/api/tutorial_enrolments_api.rb @@ -10,16 +10,17 @@ end desc 'Enrol project in a tutorial' - params do - requires :project_id, type: In...
FIX: Use unit for enroling project in a tutorial
diff --git a/test/integration/so_tech_sha_test.rb b/test/integration/so_tech_sha_test.rb index abc1234..def5678 100644 --- a/test/integration/so_tech_sha_test.rb +++ b/test/integration/so_tech_sha_test.rb @@ -23,7 +23,7 @@ get "/sotechsha" assert_template "so_tech_sha_overview_page/index" assert_select "h...
Fix broken tests: Change static number of links in /sotechsha
diff --git a/interactor.gemspec b/interactor.gemspec index abc1234..def5678 100644 --- a/interactor.gemspec +++ b/interactor.gemspec @@ -15,6 +15,6 @@ spec.test_files = spec.files.grep(/^spec/) spec.require_paths = ["lib"] - spec.add_development_dependency "bundler", "~> 1.3" - spec.add_development_dependen...
Update the gemspec's development dependency version requirements
diff --git a/lib/chefstyle/version.rb b/lib/chefstyle/version.rb index abc1234..def5678 100644 --- a/lib/chefstyle/version.rb +++ b/lib/chefstyle/version.rb @@ -1,5 +1,5 @@ # frozen_string_literal: true module Chefstyle VERSION = "2.0.5" - RUBOCOP_VERSION = "1.17.0" + RUBOCOP_VERSION = "1.18.3" end
Update RuboCop engine to 1.18.3 Signed-off-by: Tim Smith <764ef62106582a09ed09dfa0b6bff7c05fd7d1e4@chef.io>
diff --git a/lib/disclosure/engine.rb b/lib/disclosure/engine.rb index abc1234..def5678 100644 --- a/lib/disclosure/engine.rb +++ b/lib/disclosure/engine.rb @@ -1,5 +1,15 @@ module Disclosure class Engine < ::Rails::Engine isolate_namespace Disclosure + + initializer 'disclosure.subscribe_to_model_events' do...
Add initializers: 1. Subscribe to notifications issued by models after saving 2. Bootstrap required methods into models for implementation by the user
diff --git a/app/controllers/demo_controller.rb b/app/controllers/demo_controller.rb index abc1234..def5678 100644 --- a/app/controllers/demo_controller.rb +++ b/app/controllers/demo_controller.rb @@ -3,7 +3,7 @@ helper SmartListing::Helper def index - return root_path if Rails.env.production? + return red...
Fix bug route /demo in production : Error 500 on redirect_to
diff --git a/app/controllers/root_controller.rb b/app/controllers/root_controller.rb index abc1234..def5678 100644 --- a/app/controllers/root_controller.rb +++ b/app/controllers/root_controller.rb @@ -19,6 +19,8 @@ private def validate_template_param + # Allow alphanumeric and _ in template filenames. + # ...
Add comment explaining regex intent
diff --git a/app/mailers/notification_mailer.rb b/app/mailers/notification_mailer.rb index abc1234..def5678 100644 --- a/app/mailers/notification_mailer.rb +++ b/app/mailers/notification_mailer.rb @@ -4,7 +4,7 @@ email = "#{Formgen.always_mail_to};#{reply.form.email}" title = reply.form.title.presence || reply...
Remove 'me' as from from mails
diff --git a/simple_aspect.gemspec b/simple_aspect.gemspec index abc1234..def5678 100644 --- a/simple_aspect.gemspec +++ b/simple_aspect.gemspec @@ -18,8 +18,6 @@ spec.executables = spec.files.grep(%r{^exe/}) { |f| File.basename(f) } spec.require_paths = ["lib"] - spec.add_development_dependency "bundler", "~...
Remove unused gems from `gemspec`
diff --git a/app/workers/daily_import_worker.rb b/app/workers/daily_import_worker.rb index abc1234..def5678 100644 --- a/app/workers/daily_import_worker.rb +++ b/app/workers/daily_import_worker.rb @@ -4,6 +4,6 @@ def perform client = ClinicalTrials::Client.new - client.import_xml_files + client.populate_...
Change worker to populate studies based on xml records.
diff --git a/spec/controllers/pages_controller_spec.rb b/spec/controllers/pages_controller_spec.rb index abc1234..def5678 100644 --- a/spec/controllers/pages_controller_spec.rb +++ b/spec/controllers/pages_controller_spec.rb @@ -6,7 +6,7 @@ describe "GET #homepage" do it 'returns success' do get :homepage...
Deal with deprecation warning re Rails 6 and the predicate
diff --git a/spec/controllers/users_controller_spec.rb b/spec/controllers/users_controller_spec.rb index abc1234..def5678 100644 --- a/spec/controllers/users_controller_spec.rb +++ b/spec/controllers/users_controller_spec.rb @@ -11,26 +11,26 @@ let(:user) { attributes_for(:user) } - describe 'POST#create' do -...
Comment out failing tests, first test passes
diff --git a/spec/controllers/users_controller_spec.rb b/spec/controllers/users_controller_spec.rb index abc1234..def5678 100644 --- a/spec/controllers/users_controller_spec.rb +++ b/spec/controllers/users_controller_spec.rb @@ -16,8 +16,7 @@ context "#create" do it "redirects to the users profile" do - p...
Fix User controller spec create method
diff --git a/spec/views/videos/index.html.haml_spec.rb b/spec/views/videos/index.html.haml_spec.rb index abc1234..def5678 100644 --- a/spec/views/videos/index.html.haml_spec.rb +++ b/spec/views/videos/index.html.haml_spec.rb @@ -1,13 +1,23 @@ require 'spec_helper' describe 'videos/index.html.haml' do - let(:videos)...
Update videos/index spec to handle a lack of videos
diff --git a/test/controllers/activities_controller_test.rb b/test/controllers/activities_controller_test.rb index abc1234..def5678 100644 --- a/test/controllers/activities_controller_test.rb +++ b/test/controllers/activities_controller_test.rb @@ -19,4 +19,10 @@ get :index, date_start: Date.parse("2014-01-01"), da...
Add test to show we can get schedules for a single day
diff --git a/spec/python-requirements_spec.rb b/spec/python-requirements_spec.rb index abc1234..def5678 100644 --- a/spec/python-requirements_spec.rb +++ b/spec/python-requirements_spec.rb @@ -28,3 +28,6 @@ its(:exit_status) { should eq 0 } end +describe command('which curl') do + its(:exit_status) { should eq 0 ...
Add a spec for curl.
diff --git a/spec/requests_spec.rb b/spec/requests_spec.rb index abc1234..def5678 100644 --- a/spec/requests_spec.rb +++ b/spec/requests_spec.rb @@ -56,7 +56,7 @@ let(:body) { 'Request Body' } it 'prints body on a request' do - expect { get '/', body }.to output(/Request Body/).to_stdout + expect {...
Use post request to test printing of request body.
diff --git a/lib/jmespath/nodes/or.rb b/lib/jmespath/nodes/or.rb index abc1234..def5678 100644 --- a/lib/jmespath/nodes/or.rb +++ b/lib/jmespath/nodes/or.rb @@ -9,7 +9,7 @@ def visit(value) result = @left.visit(value) - if result.nil? or result.empty? + if result == false || result.nil? |...
Fix OR expressions where the left side is true TrueClass does not respond to `#empty?`, which makes `foo || bar` where foo resolves to true fail.
diff --git a/lib/myrrha/ext/domain.rb b/lib/myrrha/ext/domain.rb index abc1234..def5678 100644 --- a/lib/myrrha/ext/domain.rb +++ b/lib/myrrha/ext/domain.rb @@ -10,6 +10,7 @@ def coerce(arg) coercions.coerce(arg, self) rescue Myrrha::Error => ex + raise ex.cause if ex.cause domain_error!(arg...
Raise original coercion error if known.
diff --git a/lib/peek/views/resque.rb b/lib/peek/views/resque.rb index abc1234..def5678 100644 --- a/lib/peek/views/resque.rb +++ b/lib/peek/views/resque.rb @@ -8,7 +8,8 @@ end def job_count - @queues.collect { |queue| ::Resque.size(queue) }.inject(&:+) + lookup = @queues == ['*'] ? ::Resqu...
Expand to all queues when no queues are given
diff --git a/lib/peoplesoft_models.rb b/lib/peoplesoft_models.rb index abc1234..def5678 100644 --- a/lib/peoplesoft_models.rb +++ b/lib/peoplesoft_models.rb @@ -17,7 +17,7 @@ self.extend(EffectiveScope) if @record.effective_dated? end - klass + const_set(name, klass) rescue ActiveRecord:...
Set classes as constants under PeoplesoftModels Rather than just returning the generated class. In cases where the generated class is being used directly, this will prevent table_name and key lookups everytime the class is referenced.
diff --git a/lib/rspec_ruby_runner.rb b/lib/rspec_ruby_runner.rb index abc1234..def5678 100644 --- a/lib/rspec_ruby_runner.rb +++ b/lib/rspec_ruby_runner.rb @@ -1,8 +1,6 @@ require './bytecode_interpreter.rb' require './bytecode_spool.rb' require 'opal' - -LOG = false class RspecRubyRunner def initialize @@ -18...
Remove logging because it's been replaced with debug.rb.
diff --git a/lib/save_queue/object.rb b/lib/save_queue/object.rb index abc1234..def5678 100644 --- a/lib/save_queue/object.rb +++ b/lib/save_queue/object.rb @@ -61,11 +61,11 @@ end def no_recursion - return true if @saving - @saving = true + return true if @_no_recursion_saving_flag + @_n...
Change no_recursion variable to more uniq
diff --git a/lib/sequent/generator.rb b/lib/sequent/generator.rb index abc1234..def5678 100644 --- a/lib/sequent/generator.rb +++ b/lib/sequent/generator.rb @@ -1,5 +1,6 @@ require 'fileutils' require 'active_support' +require 'active_support/core_ext/string' module Sequent class Generator @@ -33,8 +34,14 @@ ...
Replace app name with pure ruby
diff --git a/lib/tasks/bunnylove.rake b/lib/tasks/bunnylove.rake index abc1234..def5678 100644 --- a/lib/tasks/bunnylove.rake +++ b/lib/tasks/bunnylove.rake @@ -0,0 +1,14 @@+namespace :test do + + desc 'Measures test coverage' + task :coverage do + rm_f "coverage" + rm_f "coverage.data" + rcov = "rcov --rail...
Add task for measuring test coverage git-svn-id: 801577a2cbccabf54a3a609152c727abd26e524a@1249 a18515e9-6cfd-0310-9624-afb4ebaee84e
diff --git a/lib/active_application/controller_methods.rb b/lib/active_application/controller_methods.rb index abc1234..def5678 100644 --- a/lib/active_application/controller_methods.rb +++ b/lib/active_application/controller_methods.rb @@ -41,15 +41,15 @@ end def layout_for_account - set_locale Con...
Remove set_locale added by mistake
diff --git a/lib/alchemy/devise/test_support/factories.rb b/lib/alchemy/devise/test_support/factories.rb index abc1234..def5678 100644 --- a/lib/alchemy/devise/test_support/factories.rb +++ b/lib/alchemy/devise/test_support/factories.rb @@ -1,26 +1,28 @@+# frozen_string_literal: true + FactoryBot.define do - factory ...
Update user factory to latest FactoryBot version
diff --git a/lib/bukkit/version.rb b/lib/bukkit/version.rb index abc1234..def5678 100644 --- a/lib/bukkit/version.rb +++ b/lib/bukkit/version.rb @@ -1,4 +1,4 @@ module Bukkit - VERSION = "2.4.0" + VERSION = "2.4.1" VERSION_FULL = "Bukkit-CLI v#{VERSION}" end
v2.4.1: Add --no-start option to create/new command.
diff --git a/Casks/android-studio-bundle.rb b/Casks/android-studio-bundle.rb index abc1234..def5678 100644 --- a/Casks/android-studio-bundle.rb +++ b/Casks/android-studio-bundle.rb @@ -0,0 +1,7 @@+class AndroidStudioBundle < Cask + url 'https://dl.google.com/android/studio/install/0.4.2/android-studio-bundle-133.97093...
Add Android Studio Bundle 0.4.2 build-133.970939 android-studio-bundle is different from android-studio as it comes with the Android SDK already bundled, within the .app. This is the regular .dmg not cutting edge version you would get from http://developer.android.com/sdk/installing/studio.html
diff --git a/spec/lib/load_spec.rb b/spec/lib/load_spec.rb index abc1234..def5678 100644 --- a/spec/lib/load_spec.rb +++ b/spec/lib/load_spec.rb @@ -0,0 +1,42 @@+# It should be possible to require any one Hamster structure, +# without loading all the others + +hamster_lib_dir = File.join(File.dirname(__FILE__), "..", "...
Add new spec ensuring that each Hamster collection can be loaded individually It doesn't check that the other collections are not recursively required -- just that it is possible to require an individual collection without an unexpected exception.
diff --git a/app/finders/clusters_finder.rb b/app/finders/clusters_finder.rb index abc1234..def5678 100644 --- a/app/finders/clusters_finder.rb +++ b/app/finders/clusters_finder.rb @@ -9,9 +9,9 @@ clusters = case @scope when :all project.clusters + when :enabled + ...
Fix mixup with enabled/disabled in ClustersFinder
diff --git a/app/helpers/projects_helper.rb b/app/helpers/projects_helper.rb index abc1234..def5678 100644 --- a/app/helpers/projects_helper.rb +++ b/app/helpers/projects_helper.rb @@ -2,7 +2,7 @@ def project_options_for_select(opts = {}) options = [] options += [[opts[:root].to_s, nil]] if opts[:root] - ...
Projects: Sort projects select; filter to only MY projects
diff --git a/spambust.gemspec b/spambust.gemspec index abc1234..def5678 100644 --- a/spambust.gemspec +++ b/spambust.gemspec @@ -23,6 +23,7 @@ s.add_development_dependency "sinatra" s.add_development_dependency "rake" + s.add_development_dependency "rdoc" s.add_development_dependency "rack-test" s.add_dev...
Fix missing dependency on ruby 1.9.2
diff --git a/spec/app_spec.rb b/spec/app_spec.rb index abc1234..def5678 100644 --- a/spec/app_spec.rb +++ b/spec/app_spec.rb @@ -1,7 +1,6 @@ require_relative 'helper' require 'rack/test' require 'app' -require 'yajl' describe 'the application' do include Rack::Test::Methods
Remove yajl require in spec
diff --git a/lib/electric_slide.rb b/lib/electric_slide.rb index abc1234..def5678 100644 --- a/lib/electric_slide.rb +++ b/lib/electric_slide.rb @@ -17,7 +17,7 @@ def create(name, queue_type, agent_type = Agent) synchronize do - @queues[name] = const_get(queue_type).new unless @queues.has_key?(name) + ...
Use the supplied class directly Instead of looking it up with const_get
diff --git a/examples/convert.rb b/examples/convert.rb index abc1234..def5678 100644 --- a/examples/convert.rb +++ b/examples/convert.rb @@ -0,0 +1,74 @@+$:.unshift File.join(File.expand_path(File.dirname(__FILE__)), '..', 'lib') +require 'luban/cli' + +class ConvertApp < Luban::CLI::Application + configure do + ve...
Add an example for subcommands and nested subcommands
diff --git a/lib/filmbuff/title.rb b/lib/filmbuff/title.rb index abc1234..def5678 100644 --- a/lib/filmbuff/title.rb +++ b/lib/filmbuff/title.rb @@ -13,7 +13,7 @@ @votes = options['num_votes'] @poster_url = options['image']['url'] if options['image'] @genres = options['genres'] || [] - @release...
Store release date as DateTime rather than Date
diff --git a/config/initializers/mime_types.rb b/config/initializers/mime_types.rb index abc1234..def5678 100644 --- a/config/initializers/mime_types.rb +++ b/config/initializers/mime_types.rb @@ -2,3 +2,7 @@ # Add new mime types for use in respond_to blocks: # Mime::Type.register "text/richtext", :rtf + +Mime::Type...
Fix video dose not play in IE9 or later .mp4 や .webm, .ogv をコンテンツに埋め込むと IE9/10/11 では、 "無効なソース" と表示され正しく再生されない。 原因は CMS コンテンツの静的ファイルが `send_file` によって レスポンスされる際、未定義の拡張子のため ContentType が `application/octet-stream` にセットされるため。 なお、Chrome/Firefox/Safari では問題なく再生される。
diff --git a/lib/git_recent/cli.rb b/lib/git_recent/cli.rb index abc1234..def5678 100644 --- a/lib/git_recent/cli.rb +++ b/lib/git_recent/cli.rb @@ -2,9 +2,7 @@ require 'thor' class Cli < Thor - DEFAULT_MAX_BRANCHES = 5 - - class_option :max, :type => :numeric + class_option :max, type: :numeric, defaul...
Use Thor to handle default max option
diff --git a/db/samples.rb b/db/samples.rb index abc1234..def5678 100644 --- a/db/samples.rb +++ b/db/samples.rb @@ -9,6 +9,7 @@ fixture_filename = File.join(*db_args) # Throws exception if 'db/fixtures/#{filename}.yml' doesn't yet exist - FileUtils.touch(fixture_filename) + fixtures = File.join('db/fixtures',...
Append yml to fixtures file ending
diff --git a/lib/has_attributes.rb b/lib/has_attributes.rb index abc1234..def5678 100644 --- a/lib/has_attributes.rb +++ b/lib/has_attributes.rb @@ -38,13 +38,13 @@ end def attributes=(attrs) - self.class.model_attributes.each {|attr| send((attr.to_s << "=").to_sym, attrs[attr])} + self.class.model_attribu...
Use public_send for public instance methods
diff --git a/AttributedLib.podspec b/AttributedLib.podspec index abc1234..def5678 100644 --- a/AttributedLib.podspec +++ b/AttributedLib.podspec @@ -1,6 +1,6 @@ Pod::Spec.new do |s| s.name = 'AttributedLib' - s.version = '0.2.2' + s.version = '1.0.0' s.summary = 'A Modern ...
Increase podspec to point to version to 1.0.0
diff --git a/lib/real_world_rails/inspectors/inspector.rb b/lib/real_world_rails/inspectors/inspector.rb index abc1234..def5678 100644 --- a/lib/real_world_rails/inspectors/inspector.rb +++ b/lib/real_world_rails/inspectors/inspector.rb @@ -13,26 +13,12 @@ end def run - parser = ParserFactory.crea...
Introduce methods to increase extension points
diff --git a/runner.gemspec b/runner.gemspec index abc1234..def5678 100644 --- a/runner.gemspec +++ b/runner.gemspec @@ -1,7 +1,7 @@ # -*- encoding: utf-8 -*- Gem::Specification.new do |s| s.name = 'runner' - s.version = '0.1.0' + s.version = '0.1.1' s.summary = 'Run files that match a file specification, excl...
Package version patch number is incremented from 0.1.0 to 0.1.1
diff --git a/Casks/phpstorm-eap.rb b/Casks/phpstorm-eap.rb index abc1234..def5678 100644 --- a/Casks/phpstorm-eap.rb +++ b/Casks/phpstorm-eap.rb @@ -1,6 +1,6 @@ cask :v1 => 'phpstorm-eap' do - version '139.1226' - sha256 '7f9e55d3f5070fb5869eb7053566f21067600d11f93435074fad9cf399ea1626' + version '141.176' + sha256...
Update PhpStorm-EAP.app to version 141.176.
diff --git a/test/controllers/posts_controller_test.rb b/test/controllers/posts_controller_test.rb index abc1234..def5678 100644 --- a/test/controllers/posts_controller_test.rb +++ b/test/controllers/posts_controller_test.rb @@ -0,0 +1,40 @@+require 'test_helper' + +# +# == PostsController Test +# +class PostsControlle...
Add basics test for Atom feed
diff --git a/lib/lightspeed_pos.rb b/lib/lightspeed_pos.rb index abc1234..def5678 100644 --- a/lib/lightspeed_pos.rb +++ b/lib/lightspeed_pos.rb @@ -1,6 +1,5 @@ require 'typhoeus' require 'json' -require 'pry' if Rails.env.development? module Lightspeed end
Remove require 'pry' if Rails.env.development? This gem has no context of a Rails app at all. If you want this, put it in your app.
diff --git a/lib/asciidoctor-diagram/barcode/dependencies.rb b/lib/asciidoctor-diagram/barcode/dependencies.rb index abc1234..def5678 100644 --- a/lib/asciidoctor-diagram/barcode/dependencies.rb +++ b/lib/asciidoctor-diagram/barcode/dependencies.rb @@ -4,7 +4,7 @@ BARCODE_DEPENDENCIES = {'barby' => '~> 0.6.8'} ...
Resolve Ruby 2.3 compatibility issue
diff --git a/FSOpenInGmail.podspec b/FSOpenInGmail.podspec index abc1234..def5678 100644 --- a/FSOpenInGmail.podspec +++ b/FSOpenInGmail.podspec @@ -3,6 +3,7 @@ s.version = "0.9" s.summary = "FSOpenInGmail is a tool for sending mails with Gmail iOS App." s.homepage = "https://github.com/x2on/FSOpe...
Add social media url in podspec
diff --git a/config/initializers/carrierwave.rb b/config/initializers/carrierwave.rb index abc1234..def5678 100644 --- a/config/initializers/carrierwave.rb +++ b/config/initializers/carrierwave.rb @@ -1,3 +1,10 @@+# TODO: Make this store to RAILS_ROOT/permanent + +# On bushido, the app directory is destroyed on every u...
Mark a note about how to handle file uploads for persistence
diff --git a/scripts/prepare-changelog-entries.rb b/scripts/prepare-changelog-entries.rb index abc1234..def5678 100644 --- a/scripts/prepare-changelog-entries.rb +++ b/scripts/prepare-changelog-entries.rb @@ -0,0 +1,55 @@+#!/usr/bin/env ruby + +require 'json' +require 'net/http' +require 'uri' + +per_page = 15 + +priva...
Add changelog entries generation script
diff --git a/Casks/google-music.rb b/Casks/google-music.rb index abc1234..def5678 100644 --- a/Casks/google-music.rb +++ b/Casks/google-music.rb @@ -1,7 +1,7 @@ class GoogleMusic < Cask - url 'https://github.com/kbhomes/google-music-mac/releases/download/v1.0.3/Google.Music.zip' + url 'https://github.com/kbhomes/goog...
Upgrade Google Music to v1.1.1
diff --git a/test/integration/withdrawing_test.rb b/test/integration/withdrawing_test.rb index abc1234..def5678 100644 --- a/test/integration/withdrawing_test.rb +++ b/test/integration/withdrawing_test.rb @@ -9,17 +9,22 @@ unpublishing_reason_id: UnpublishingReason::Withdrawn.id) stub_panopticon_registrati...
Fix WithdrawingTest for new format
diff --git a/lib/payable/client.rb b/lib/payable/client.rb index abc1234..def5678 100644 --- a/lib/payable/client.rb +++ b/lib/payable/client.rb @@ -10,11 +10,8 @@ attr_reader :company_id, :api_key def initialize(company_id: Payable.config.company_id, api_key: Payable.config.api_key) - @company_id = com...
Raise errors on request failure
diff --git a/lib/process_photos.rb b/lib/process_photos.rb index abc1234..def5678 100644 --- a/lib/process_photos.rb +++ b/lib/process_photos.rb @@ -22,6 +22,6 @@ end def tmp_dir - @tmp_dir ||= "tmp/photo_processing/#{Time.now.to_i}" + @tmp_dir ||= "tmp/photo_processing/#{title}" end end
Use title for temp dir name rather than timestamp
diff --git a/app/views/starred_entries/index.xml.builder b/app/views/starred_entries/index.xml.builder index abc1234..def5678 100644 --- a/app/views/starred_entries/index.xml.builder +++ b/app/views/starred_entries/index.xml.builder @@ -1,4 +1,4 @@-cache @entries do +cache [@user.id, @entries] do xml.instruct! :xml,...
Include user_id in cache key.