diff
stringlengths
65
26.7k
message
stringlengths
7
9.92k
diff --git a/semian.gemspec b/semian.gemspec index abc1234..def5678 100644 --- a/semian.gemspec +++ b/semian.gemspec @@ -16,7 +16,7 @@ s.email = 'scott.francis@shopify.com' s.license = 'MIT' - s.files = `git ls-files`.split("\n") + s.files = Dir['{lib,ext}/**/**/*.{rb,h,c}'] s.extensions = ['ext/semian/extc...
Use glob instead of git for gemspec file list
diff --git a/lib/setebos/config.rb b/lib/setebos/config.rb index abc1234..def5678 100644 --- a/lib/setebos/config.rb +++ b/lib/setebos/config.rb @@ -13,7 +13,7 @@ # Config.parse(./setebos.yml) # # => Hash # - # Returns an HashWithIndifferentAccess. + # Returns an HashWithIndifferentAccess or nil. def s...
Config: Add a rescue if error.
diff --git a/lib/tasks/travis.rake b/lib/tasks/travis.rake index abc1234..def5678 100644 --- a/lib/tasks/travis.rake +++ b/lib/tasks/travis.rake @@ -1,2 +1,11 @@-task :travis => %w[check db:drop db:migrate spec:all js:test js:lint spec:coverage:ensure] +task :travis => %w[ + check + db:drop + db:migrate + tmp:creat...
Create tmp dirs on Travis.
diff --git a/lib/tasks/warmup.rake b/lib/tasks/warmup.rake index abc1234..def5678 100644 --- a/lib/tasks/warmup.rake +++ b/lib/tasks/warmup.rake @@ -1,11 +1,15 @@ namespace :db_memoize do - desc "generates memoized values (pass e.g. 'class=Product methods=to_document,to_hash')" + desc "generates memoized values (pass...
Adjust rake task to read UPPERCASE environment values ..since this is the default on unixes anyway. Also warms up *all* memoized methods that are configured on that class by default.
diff --git a/config.rb b/config.rb index abc1234..def5678 100644 --- a/config.rb +++ b/config.rb @@ -17,6 +17,7 @@ } proxy "/faq/index.html", "faq.html" +ignore "/test.html" if build? (1..4).to_a.each do |i| proxy "/examples/#{i}/index.html", "/examples/index.html", :locals => { :example => i }, ignore: true
Remove test suite from build
diff --git a/lib/vim-flavor/cli.rb b/lib/vim-flavor/cli.rb index abc1234..def5678 100644 --- a/lib/vim-flavor/cli.rb +++ b/lib/vim-flavor/cli.rb @@ -35,6 +35,10 @@ ENV['HOME'].to_vimfiles_path end end + + def self.exit_on_failure? + true + end end end end
Exit with failure code for any error
diff --git a/lib/oshpark/ext.rb b/lib/oshpark/ext.rb index abc1234..def5678 100644 --- a/lib/oshpark/ext.rb +++ b/lib/oshpark/ext.rb @@ -0,0 +1,121 @@+module OshparkArrayExtensions + def to_multipart key + prefix = "#{key}[]" + collect {|a| a.to_multipart(prefix)}.flatten.compact + end + + def to_query key + ...
Add query params monkey patches.
diff --git a/lib/poke/window.rb b/lib/poke/window.rb index abc1234..def5678 100644 --- a/lib/poke/window.rb +++ b/lib/poke/window.rb @@ -7,8 +7,8 @@ attr_accessor :paused def initialize - @width = WIDTH * GRID - @height = HEIGHT * GRID + @width = WIDTH + @height = HEIGHT super(@width, @heigh...
Update Window to use pixel dimensions
diff --git a/lib/pronto/haml.rb b/lib/pronto/haml.rb index abc1234..def5678 100644 --- a/lib/pronto/haml.rb +++ b/lib/pronto/haml.rb @@ -26,7 +26,7 @@ def new_message(lint, line) path = line.patch.delta.new_file[:path] - Message.new(path, line, lint.severity, lint.message) + Message.new(path, lin...
Add the runner class into the report message
diff --git a/lib/yarn/server.rb b/lib/yarn/server.rb index abc1234..def5678 100644 --- a/lib/yarn/server.rb +++ b/lib/yarn/server.rb @@ -5,7 +5,7 @@ include Logging - attr_accessor :host, :port, :socket + attr_accessor :host, :port, :socket, :workers def initialize(app=nil,options={}) # merg...
Save worker pid's for better management
diff --git a/api/lib/spree/api/controller_setup.rb b/api/lib/spree/api/controller_setup.rb index abc1234..def5678 100644 --- a/api/lib/spree/api/controller_setup.rb +++ b/api/lib/spree/api/controller_setup.rb @@ -21,9 +21,6 @@ include CanCan::ControllerAdditions include Spree::Core::ControllerHelpe...
Remove append_view_path from api ControllerSetup That line was preventing us from overriding templates within other application or extensions Fixes #3450
diff --git a/lib/knife-cloudformation/utils/ssher.rb b/lib/knife-cloudformation/utils/ssher.rb index abc1234..def5678 100644 --- a/lib/knife-cloudformation/utils/ssher.rb +++ b/lib/knife-cloudformation/utils/ssher.rb @@ -14,10 +14,13 @@ # @param ssh_opts [Hash] # @return [String, NilClass] def remot...
Add path check to prevent hang on cat
diff --git a/app/controllers/welcome_controller.rb b/app/controllers/welcome_controller.rb index abc1234..def5678 100644 --- a/app/controllers/welcome_controller.rb +++ b/app/controllers/welcome_controller.rb @@ -1,5 +1,7 @@ class WelcomeController < ApplicationController - def index - + def signin + if user_sign...
Change method index to signin
diff --git a/lib/onebox/engine/github_gist_onebox.rb b/lib/onebox/engine/github_gist_onebox.rb index abc1234..def5678 100644 --- a/lib/onebox/engine/github_gist_onebox.rb +++ b/lib/onebox/engine/github_gist_onebox.rb @@ -15,7 +15,7 @@ end def to_html - "<script src=\"http://gist.github.com/#{match...
Use schemaless URL for GitHub's gists
diff --git a/lib/rautomation/adapter/win_32/mouse.rb b/lib/rautomation/adapter/win_32/mouse.rb index abc1234..def5678 100644 --- a/lib/rautomation/adapter/win_32/mouse.rb +++ b/lib/rautomation/adapter/win_32/mouse.rb @@ -25,9 +25,11 @@ def press send_input down_event + send_input down_even...
Send press/release twice since the first event seems to be ignored
diff --git a/site-cookbooks/manchesterio/recipes/molly.rb b/site-cookbooks/manchesterio/recipes/molly.rb index abc1234..def5678 100644 --- a/site-cookbooks/manchesterio/recipes/molly.rb +++ b/site-cookbooks/manchesterio/recipes/molly.rb @@ -5,6 +5,14 @@ directory "#{node.manchesterio.root}/compiled_media" do user no...
Include additional Python dependencies for Molly
diff --git a/app/controllers/expenses_controller.rb b/app/controllers/expenses_controller.rb index abc1234..def5678 100644 --- a/app/controllers/expenses_controller.rb +++ b/app/controllers/expenses_controller.rb @@ -16,7 +16,8 @@ def create find_user - expense = @user.expenses.build(expenses_params) + p...
Change expense create method to accept multiple expenses
diff --git a/app/controllers/messages_controller.rb b/app/controllers/messages_controller.rb index abc1234..def5678 100644 --- a/app/controllers/messages_controller.rb +++ b/app/controllers/messages_controller.rb @@ -28,7 +28,7 @@ Analytics.track(user_id: current_user.id, event: 'Sent New Message',...
Revert notification text change from merge
diff --git a/app/controllers/sessions_controller.rb b/app/controllers/sessions_controller.rb index abc1234..def5678 100644 --- a/app/controllers/sessions_controller.rb +++ b/app/controllers/sessions_controller.rb @@ -3,6 +3,7 @@ skip_before_action :authorize def new + @user = current_user end def cr...
Make sure @user is set.
diff --git a/app/controllers/api/users/profile_controller.rb b/app/controllers/api/users/profile_controller.rb index abc1234..def5678 100644 --- a/app/controllers/api/users/profile_controller.rb +++ b/app/controllers/api/users/profile_controller.rb @@ -19,21 +19,23 @@ @profile = Profile.find_by!( user_id: params[...
Edit de profile de user funcionando ok
diff --git a/test/helper.rb b/test/helper.rb index abc1234..def5678 100644 --- a/test/helper.rb +++ b/test/helper.rb @@ -3,16 +3,16 @@ # Test coverage if enabled. if ENV[ 'COVERAGE' ] - require "simplecov" + require 'simplecov' SimpleCov.start end begin - require "codeclimate-test-reporter" + require 'cod...
Disable coverage in JRuby tests.
diff --git a/app/helpers/s3_relay/uploads_helper.rb b/app/helpers/s3_relay/uploads_helper.rb index abc1234..def5678 100644 --- a/app/helpers/s3_relay/uploads_helper.rb +++ b/app/helpers/s3_relay/uploads_helper.rb @@ -5,7 +5,7 @@ file_field = file_field_tag(:file, opts.merge(class: "s3r-field")) progres...
Fix order of string casing.
diff --git a/RoundaboutKit.podspec b/RoundaboutKit.podspec index abc1234..def5678 100644 --- a/RoundaboutKit.podspec +++ b/RoundaboutKit.podspec @@ -16,7 +16,7 @@ s.ios.deployment_target = '6.0' s.osx.deployment_target = '10.8' - s.source = { :git => "https://github.com/decarbonization/RoundaboutKit.git",...
Update Podspec to point to LN repo
diff --git a/app/presenters/tree_builder_storage.rb b/app/presenters/tree_builder_storage.rb index abc1234..def5678 100644 --- a/app/presenters/tree_builder_storage.rb +++ b/app/presenters/tree_builder_storage.rb @@ -24,8 +24,13 @@ end def x_get_tree_custom_kids(object, count_only, options) - return count_onl...
Make visible My Filters in Datastores fixing https://bugzilla.redhat.com/show_bug.cgi?id=1398748 https://bugzilla.redhat.com/show_bug.cgi?id=1382768 Make created filters (not global) in Compute -> Infrastructure -> -> Datastores visible under My Filters in accordion.
diff --git a/app/presenters/tree_builder_storage.rb b/app/presenters/tree_builder_storage.rb index abc1234..def5678 100644 --- a/app/presenters/tree_builder_storage.rb +++ b/app/presenters/tree_builder_storage.rb @@ -7,7 +7,7 @@ def set_locals_for_render locals = super - locals.merge!(:autoload => true) + ...
Allow reselect for nodes in TreeBuilderStorage
diff --git a/week-6/nested_data_solution.rb b/week-6/nested_data_solution.rb index abc1234..def5678 100644 --- a/week-6/nested_data_solution.rb +++ b/week-6/nested_data_solution.rb @@ -0,0 +1,68 @@+# RELEASE 2: NESTED STRUCTURE GOLF +# Hole 1 +# Target element: "FORE" + +array = [[1,2], ["inner", ["eagle", "par", ["FOR...
Add the Pairing exercise 6.5 bested arrays
diff --git a/spec/fixtures/rails_app/config/initializers/new_framework_defaults.rb b/spec/fixtures/rails_app/config/initializers/new_framework_defaults.rb index abc1234..def5678 100644 --- a/spec/fixtures/rails_app/config/initializers/new_framework_defaults.rb +++ b/spec/fixtures/rails_app/config/initializers/new_frame...
Fix warning in fixture application
diff --git a/spec/helpers/application_helper/buttons/svc_catalog_provision_spec.rb b/spec/helpers/application_helper/buttons/svc_catalog_provision_spec.rb index abc1234..def5678 100644 --- a/spec/helpers/application_helper/buttons/svc_catalog_provision_spec.rb +++ b/spec/helpers/application_helper/buttons/svc_catalog_p...
Create spec examples for SvcCatalogProvision button class
diff --git a/app/models/album.rb b/app/models/album.rb index abc1234..def5678 100644 --- a/app/models/album.rb +++ b/app/models/album.rb @@ -0,0 +1,20 @@+require 'pink_spider' +class Album < Enclosure + def get_content + PinkSpider.new.fetch_album(id) + end + + def fetch_content + @content = get_content + end...
Add Album model that inherits Enclosure
diff --git a/app/models/right.rb b/app/models/right.rb index abc1234..def5678 100644 --- a/app/models/right.rb +++ b/app/models/right.rb @@ -20,13 +20,14 @@ # map all available controller actions to CRUD operations OPERATION_MAPPINGS = { - new: 'CREATE', - create: 'CREATE', - edit: 'UPDATE', ...
Use strings instead of symbols
diff --git a/spec/mobility/plugins/sequel_spec.rb b/spec/mobility/plugins/sequel_spec.rb index abc1234..def5678 100644 --- a/spec/mobility/plugins/sequel_spec.rb +++ b/spec/mobility/plugins/sequel_spec.rb @@ -2,10 +2,10 @@ return unless defined?(Sequel) +require "mobility/plugins/sequel" + describe Mobility::Plugi...
Add missing require in sequel plugin spec
diff --git a/everyunicode.rb b/everyunicode.rb index abc1234..def5678 100644 --- a/everyunicode.rb +++ b/everyunicode.rb @@ -13,7 +13,9 @@ every = file.read.split("\t") # tweet next character and remove it from array - Twitter.update(every.shift) + char = every.shift + # add zero width space character to char...
Fix no Tweeting of certain characters https://dev.twitter.com/issues/137
diff --git a/spec/unit/ldap/filter_parser_spec.rb b/spec/unit/ldap/filter_parser_spec.rb index abc1234..def5678 100644 --- a/spec/unit/ldap/filter_parser_spec.rb +++ b/spec/unit/ldap/filter_parser_spec.rb @@ -5,7 +5,7 @@ describe "#parse" do context "Given ASCIIs as filter string" do - let(:filter_string)...
Simplify an example for FilterParser
diff --git a/app/helpers/geo_helper.rb b/app/helpers/geo_helper.rb index abc1234..def5678 100644 --- a/app/helpers/geo_helper.rb +++ b/app/helpers/geo_helper.rb @@ -2,7 +2,7 @@ module GeoHelper def self.get_ip_address request - ip_address = Rails.application.secrets["debug_ip_address"] != "" ? Rails.applicatio...
Make debug_ip_address account for the nil case Otherwise we get a nil ip address in the localhost case and the link suggestion breaks (it shows "you're next to es/location/change2").
diff --git a/SPTDataLoader.podspec b/SPTDataLoader.podspec index abc1234..def5678 100644 --- a/SPTDataLoader.podspec +++ b/SPTDataLoader.podspec @@ -19,6 +19,6 @@ s.source_files = "include/SPTDataLoader/*.h", "SPTDataLoader/*.{h,m}" s.public_header_files = "include/SPTDataLoader/*.h" s.xcconfig = { 'OTHER...
Fix extra backquotes in pod spec
diff --git a/artifactory.gemspec b/artifactory.gemspec index abc1234..def5678 100644 --- a/artifactory.gemspec +++ b/artifactory.gemspec @@ -22,4 +22,7 @@ spec.add_dependency 'httpclient', '~> 2.3' spec.add_dependency 'i18n', '~> 0.5' + + spec.add_development_dependency 'bundler' + spec.add_development_d...
Add rake and bundler to the gemspec
diff --git a/app/controllers/external_users/litigators/interim_claims_controller.rb b/app/controllers/external_users/litigators/interim_claims_controller.rb index abc1234..def5678 100644 --- a/app/controllers/external_users/litigators/interim_claims_controller.rb +++ b/app/controllers/external_users/litigators/interim_...
Fix building of associations on interim claims controller
diff --git a/app/controllers/aliases_controller.rb b/app/controllers/aliases_controller.rb index abc1234..def5678 100644 --- a/app/controllers/aliases_controller.rb +++ b/app/controllers/aliases_controller.rb @@ -1,3 +1,5 @@+# Encoding: utf-8 +# Alias Controller class AliasesController < ApplicationController def i...
Clean up alias controller script
diff --git a/app/controllers/welcome_controller.rb b/app/controllers/welcome_controller.rb index abc1234..def5678 100644 --- a/app/controllers/welcome_controller.rb +++ b/app/controllers/welcome_controller.rb @@ -6,4 +6,9 @@ def show end + + def search + @questions = Question.search(params[:words]) + rend...
Add search method in welcome controller.
diff --git a/app/queries/get_content_collection.rb b/app/queries/get_content_collection.rb index abc1234..def5678 100644 --- a/app/queries/get_content_collection.rb +++ b/app/queries/get_content_collection.rb @@ -12,7 +12,7 @@ content_items.map do |content_item| hash = content_item.as_json(only: fields...
Make the GetContentCollection support live items without drafts… Previously, the query made an assumption that every live content item would have an associated draft. This is no longer the case, so update the query accordingly.
diff --git a/spec/asset_trip/compressor_spec.rb b/spec/asset_trip/compressor_spec.rb index abc1234..def5678 100644 --- a/spec/asset_trip/compressor_spec.rb +++ b/spec/asset_trip/compressor_spec.rb @@ -16,7 +16,25 @@ compressor.compress("a { color: red }") end - it "returns the STDOUT from the java proce...
Add missing specs for Compressor
diff --git a/spec/features/translations_spec.rb b/spec/features/translations_spec.rb index abc1234..def5678 100644 --- a/spec/features/translations_spec.rb +++ b/spec/features/translations_spec.rb @@ -0,0 +1,31 @@+RSpec.feature "Translations" do + context 'product' do + let!(:product) do + create(:product, nam...
Add spec for product pages translation
diff --git a/spec/instrumentation/mongo_spec.rb b/spec/instrumentation/mongo_spec.rb index abc1234..def5678 100644 --- a/spec/instrumentation/mongo_spec.rb +++ b/spec/instrumentation/mongo_spec.rb @@ -10,19 +10,19 @@ it 'Mongo should have oboe methods defined' do Oboe::Inst::Mongo::DB_OPS.each do |m| - ::...
Fix the tested method names
diff --git a/spec/models/group_pref_spec.rb b/spec/models/group_pref_spec.rb index abc1234..def5678 100644 --- a/spec/models/group_pref_spec.rb +++ b/spec/models/group_pref_spec.rb @@ -13,5 +13,17 @@ require 'spec_helper' describe GroupPref do - pending "add some examples to (or delete) #{__FILE__}" + it { should ...
Add some simple tests for group prefs.
diff --git a/spec/watirspec/spec/spec_helper.rb b/spec/watirspec/spec/spec_helper.rb index abc1234..def5678 100644 --- a/spec/watirspec/spec/spec_helper.rb +++ b/spec/watirspec/spec/spec_helper.rb @@ -11,7 +11,7 @@ Thread.abort_on_exception = true require "#{File.dirname(__FILE__)}/../watirspec" -hook = File.expand_...
Use .rb since we're checking if File.exist?
diff --git a/url_request.rb b/url_request.rb index abc1234..def5678 100644 --- a/url_request.rb +++ b/url_request.rb @@ -1,27 +1,37 @@ require 'net/http' class UrlRequest + def initialize (url) @uri = URI.parse(url) end def get - Net::HTTP.get_response(@uri) - end - - def is_redirected? - get...
Add private methods to the controller
diff --git a/cookbooks/travis_system_info/recipes/default.rb b/cookbooks/travis_system_info/recipes/default.rb index abc1234..def5678 100644 --- a/cookbooks/travis_system_info/recipes/default.rb +++ b/cookbooks/travis_system_info/recipes/default.rb @@ -14,10 +14,7 @@ checksum node['travis_system_info']['gem_sha256sum...
Install system-info local gem manually as chef 12.10+ automatically adds `--local` when using `gem_package` with a local source, which is a design decision ... that doesn't work for this case.
diff --git a/test/lib/typus/actions_test.rb b/test/lib/typus/actions_test.rb index abc1234..def5678 100644 --- a/test/lib/typus/actions_test.rb +++ b/test/lib/typus/actions_test.rb @@ -0,0 +1,75 @@+require "test_helper" + +class ActionsTest < ActiveSupport::TestCase + + include Typus::Actions + + context "add_resourc...
Test for actions stuff ...
diff --git a/lib/has_remote/tasks.rb b/lib/has_remote/tasks.rb index abc1234..def5678 100644 --- a/lib/has_remote/tasks.rb +++ b/lib/has_remote/tasks.rb @@ -3,10 +3,7 @@ desc 'Synchronizes all attributes locally cached by has_remote' task :sync => :environment do models = ENV['MODELS'].nil? ? HasRemote.models...
Allow any parameters to be specified via an env.variable for hr:sync rake task.
diff --git a/lib/apipie-rails.rb b/lib/apipie-rails.rb index abc1234..def5678 100644 --- a/lib/apipie-rails.rb +++ b/lib/apipie-rails.rb @@ -21,3 +21,11 @@ if Rails.version.start_with?("3.0") warn 'Warning: apipie-rails is not going to support Rails 3.0 anymore in future versions' end + +module Apipie + + def self...
Add root path accessor to base module
diff --git a/lib/binco/engine.rb b/lib/binco/engine.rb index abc1234..def5678 100644 --- a/lib/binco/engine.rb +++ b/lib/binco/engine.rb @@ -1,3 +1,5 @@+require 'jquery-rails' +require 'bootstrap' require 'select2-rails' require 'will_paginate' require 'bootstrap-datepicker-rails'
Add missing require for new depedencies
diff --git a/lib/rip/compiler/ast.rb b/lib/rip/compiler/ast.rb index abc1234..def5678 100644 --- a/lib/rip/compiler/ast.rb +++ b/lib/rip/compiler/ast.rb @@ -4,14 +4,18 @@ class AST < Parslet::Transform attr_reader :origin - def initialize(origin) + def initialize(origin = nil, &block) @origin = or...
Change expectations to match reality
diff --git a/lib/dcell/server.rb b/lib/dcell/server.rb index abc1234..def5678 100644 --- a/lib/dcell/server.rb +++ b/lib/dcell/server.rb @@ -20,7 +20,7 @@ # Wait for incoming 0MQ messages def run - while true; handle_message @socket.read; end + while true; handle_message! @socket.read; end end...
Fix "ZMQ error: got read event without associated reader"
diff --git a/lib/workbench/engine.rb b/lib/workbench/engine.rb index abc1234..def5678 100644 --- a/lib/workbench/engine.rb +++ b/lib/workbench/engine.rb @@ -9,5 +9,10 @@ module Workbench class Engine < ::Rails::Engine isolate_namespace Workbench + + initializer :assets do |config| + Rails.application.co...
Add asset precompilation for all assets
diff --git a/lib/nehm/artwork.rb b/lib/nehm/artwork.rb index abc1234..def5678 100644 --- a/lib/nehm/artwork.rb +++ b/lib/nehm/artwork.rb @@ -4,7 +4,7 @@ @track = track end - def dl_url + def url hash = @track.hash url = if hash['artwork_url'].nil?
Rename dl_url to url in Artwork
diff --git a/lib/setty/loader.rb b/lib/setty/loader.rb index abc1234..def5678 100644 --- a/lib/setty/loader.rb +++ b/lib/setty/loader.rb @@ -1,5 +1,6 @@ require 'erb' require 'yaml' +require 'pathname' require 'active_support/core_ext/hash/keys.rb' require 'active_support/core_ext/string/inflections.rb' @@ -8,7 +9...
Use pathname for file loading
diff --git a/lib/slack-notify.rb b/lib/slack-notify.rb index abc1234..def5678 100644 --- a/lib/slack-notify.rb +++ b/lib/slack-notify.rb @@ -12,7 +12,7 @@ @username = options[:username] || "webhookbot" @channel = options[:channel] || "#general" - raise ArgumentError, "Subdomain required" if @team.n...
Change error message for missing team name
diff --git a/lib/temple/utils.rb b/lib/temple/utils.rb index abc1234..def5678 100644 --- a/lib/temple/utils.rb +++ b/lib/temple/utils.rb @@ -16,5 +16,14 @@ # That has to be the only token. lexer.token.nil? end + + def empty_exp?(exp) + case exp[0] + when :multi + exp[1..-1].all? { ...
Utils: Add a method for checking if an expression is empty
diff --git a/mandrill_dm.gemspec b/mandrill_dm.gemspec index abc1234..def5678 100644 --- a/mandrill_dm.gemspec +++ b/mandrill_dm.gemspec @@ -13,10 +13,10 @@ s.require_path = 'lib' s.required_ruby_version = '>= 2.0' + s.add_dependency 'mail', '~> 2.6' s.add_dependency 'mandrill-api', ...
Move mail gem to runtime dependencies
diff --git a/app/models/application.rb b/app/models/application.rb index abc1234..def5678 100644 --- a/app/models/application.rb +++ b/app/models/application.rb @@ -2,7 +2,7 @@ belongs_to :offer, required: true belongs_to :candidate, required: true has_one :company, through: :offer - scope :unread, -> { where(...
Refactor Offer unread scope to use 'NOT read'
diff --git a/app/models/basket_item.rb b/app/models/basket_item.rb index abc1234..def5678 100644 --- a/app/models/basket_item.rb +++ b/app/models/basket_item.rb @@ -1,5 +1,5 @@ class BasketItem < ActiveRecord::Base - validates_numericality_of :quantity, greater_than_or_equal_to: 1 + validates_numericality_of :quantit...
Allow positive fractions less than 1
diff --git a/0_code_wars/which_triangle_is_that.rb b/0_code_wars/which_triangle_is_that.rb index abc1234..def5678 100644 --- a/0_code_wars/which_triangle_is_that.rb +++ b/0_code_wars/which_triangle_is_that.rb @@ -0,0 +1,24 @@+# http://www.codewars.com/kata/564d398e2ecf66cec00000a9 +# --- iteration 1 --- +def type_of_tr...
Add code wars (7) - which triangle is that?
diff --git a/db/migrate/20120531114009_add_slug_to_people.rb b/db/migrate/20120531114009_add_slug_to_people.rb index abc1234..def5678 100644 --- a/db/migrate/20120531114009_add_slug_to_people.rb +++ b/db/migrate/20120531114009_add_slug_to_people.rb @@ -4,6 +4,11 @@ add_index :people, :slug, unique: true Person...
Fix migrations to run from blank database.
diff --git a/spec/features/signup_spec.rb b/spec/features/signup_spec.rb index abc1234..def5678 100644 --- a/spec/features/signup_spec.rb +++ b/spec/features/signup_spec.rb @@ -0,0 +1,21 @@+require 'rails_helper' +require 'capybara/rspec' + +RSpec.describe 'the signup process', type: :feature do + fixtures :users + + ...
Add initial spec for signup workflow.
diff --git a/config.rb b/config.rb index abc1234..def5678 100644 --- a/config.rb +++ b/config.rb @@ -6,6 +6,7 @@ css_dir = "css" sass_dir = "scss" images_dir = "images" +generated_images_dir = images_dir + "/generated" javascripts_dir = "js" # You can select your preferred output style here (can be overridden via...
Configure subdir for generated images.
diff --git a/config.rb b/config.rb index abc1234..def5678 100644 --- a/config.rb +++ b/config.rb @@ -11,7 +11,7 @@ images_dir = "img" javascripts_dir = "js" fonts_dir = "fonts" - +disable_warnings = true output_style = :compact # To enable relative paths to assets via compass helper functions. Uncomment: @@ -26,4...
Stop wasting time with warnings in compass
diff --git a/app/presenters/source_suggestion_browse_row_presenter.rb b/app/presenters/source_suggestion_browse_row_presenter.rb index abc1234..def5678 100644 --- a/app/presenters/source_suggestion_browse_row_presenter.rb +++ b/app/presenters/source_suggestion_browse_row_presenter.rb @@ -12,6 +12,7 @@ journal: su...
Add source_type to source suggestion datatable
diff --git a/lib/geocoder/lookups/maxmind.rb b/lib/geocoder/lookups/maxmind.rb index abc1234..def5678 100644 --- a/lib/geocoder/lookups/maxmind.rb +++ b/lib/geocoder/lookups/maxmind.rb @@ -27,11 +27,6 @@ end def parse_raw_data(raw_data) - # Maxmind just returns text/plain as csv format but according to ...
Remove MaxMind character encoding conversion. Either do it consistently across Ruby versions, or don't do it at all. Plus, it didn't seem to work.
diff --git a/lib/gitlab/git/remote_mirror.rb b/lib/gitlab/git/remote_mirror.rb index abc1234..def5678 100644 --- a/lib/gitlab/git/remote_mirror.rb +++ b/lib/gitlab/git/remote_mirror.rb @@ -0,0 +1,75 @@+module Gitlab + module Git + class RemoteMirror + def initialize(repository, ref_name) + @repository =...
Move git operations for UpdateRemoteMirrorService into Gitlab::Git
diff --git a/tasks/buildr_artifact_patch.rake b/tasks/buildr_artifact_patch.rake index abc1234..def5678 100644 --- a/tasks/buildr_artifact_patch.rake +++ b/tasks/buildr_artifact_patch.rake @@ -0,0 +1,46 @@+raise 'Patch already integrated into buildr code' unless Buildr::VERSION.to_s == '1.5.6' + +class URI::HTTP + pri...
Apply patch to work around Buildr password encoding issue
diff --git a/attributes/agent.rb b/attributes/agent.rb index abc1234..def5678 100644 --- a/attributes/agent.rb +++ b/attributes/agent.rb @@ -8,6 +8,6 @@ default['gocd']['agent']['autoregister']['environments'] = %w() default['gocd']['agent']['autoregister']['resources'] = %w() default['gocd']['agent']['autoregiste...
Fix the search query used to perform a search for a go server
diff --git a/ffxiv.gemspec b/ffxiv.gemspec index abc1234..def5678 100644 --- a/ffxiv.gemspec +++ b/ffxiv.gemspec @@ -1,6 +1,6 @@ Gem::Specification.new do |s| s.name = "ffxiv" - s.version = "0.9.0" + s.version = "0.9.1" s.date = "2014-09-29" s.summary = "An unofficial FFXIV ARR tool...
[0.9.1] Change homepage to GitHub repo
diff --git a/files2gist.rb b/files2gist.rb index abc1234..def5678 100644 --- a/files2gist.rb +++ b/files2gist.rb @@ -27,7 +27,14 @@ end end -data = Hash.new +data = { + 'login' => `git config --global github.user`.strip, + 'token' => `git config --global github.token`.strip, +} +if priv + data[ 'private' ] ...
Use github.user and github.token if available. Use --private switch if given. Show res.body.
diff --git a/test/commands/untracevar_test.rb b/test/commands/untracevar_test.rb index abc1234..def5678 100644 --- a/test/commands/untracevar_test.rb +++ b/test/commands/untracevar_test.rb @@ -0,0 +1,17 @@+# frozen_string_literal: true + +require "test_helper" + +module Byebug + # + # Tests gloabal variable untracing...
Add missing coverage to `help untracevar` command
diff --git a/app/controllers/api/balances_controller.rb b/app/controllers/api/balances_controller.rb index abc1234..def5678 100644 --- a/app/controllers/api/balances_controller.rb +++ b/app/controllers/api/balances_controller.rb @@ -5,6 +5,12 @@ def index begin account = Account.find(params[:account...
Set date range metadata for balances.
diff --git a/actionview/lib/action_view/buffers.rb b/actionview/lib/action_view/buffers.rb index abc1234..def5678 100644 --- a/actionview/lib/action_view/buffers.rb +++ b/actionview/lib/action_view/buffers.rb @@ -13,10 +13,6 @@ end alias :append= :<< - def safe_concat(value) - return self if value.ni...
Stop nil checking on safe_append= ERB compiler guarantees safe_append= will be called with a string, so nil checks don't make sense. Anything else calling this method should check for nil themselves before calling
diff --git a/levels.rb b/levels.rb index abc1234..def5678 100644 --- a/levels.rb +++ b/levels.rb @@ -1,35 +1,37 @@ require 'csv' -class Array - def col(name) - offset = self.class.column(name) - self[offset] + +class Levels + attr_accessor :levels + + def initialize(file) + csv = CSV.open(file, 'r', "\t") +...
Put all level logic in the Levels class
diff --git a/examples/04_webkit.rb b/examples/04_webkit.rb index abc1234..def5678 100644 --- a/examples/04_webkit.rb +++ b/examples/04_webkit.rb @@ -0,0 +1,16 @@+# Based on http://www.idle-hacking.com/2010/02/webkit-ruby-and-gtk/ +$LOAD_PATH.unshift File.join(File.dirname(__FILE__), '..', 'lib') +require 'gir_ffi' + +G...
Add extremely basic WebKit example.
diff --git a/app/inputs/character_limited_input.rb b/app/inputs/character_limited_input.rb index abc1234..def5678 100644 --- a/app/inputs/character_limited_input.rb +++ b/app/inputs/character_limited_input.rb @@ -2,4 +2,14 @@ def input_html_options super.merge(maxlength: Student::CHARACTER_LIMIT) end + + def...
WIP: Add a counter DOM element
diff --git a/config/initializers/attachment_api.rb b/config/initializers/attachment_api.rb index abc1234..def5678 100644 --- a/config/initializers/attachment_api.rb +++ b/config/initializers/attachment_api.rb @@ -1,9 +1,7 @@-# This file is overwritten on deployment. In order to authenticate in dev -# environment with a...
Use the asset manager bearer token from ENV
diff --git a/lib/stellae/request/import_line_list_request.rb b/lib/stellae/request/import_line_list_request.rb index abc1234..def5678 100644 --- a/lib/stellae/request/import_line_list_request.rb +++ b/lib/stellae/request/import_line_list_request.rb @@ -2,7 +2,7 @@ module Request class ImportLineListRequest ...
Fix argument error in request
diff --git a/state_machine.gemspec b/state_machine.gemspec index abc1234..def5678 100644 --- a/state_machine.gemspec +++ b/state_machine.gemspec @@ -14,4 +14,6 @@ s.test_files = `git ls-files -- test/*`.split("\n") s.rdoc_options = %w(--line-numbers --inline-source --title state_machine --main README.r...
Add missing dependencies to gemspec
diff --git a/features/support/router_helper.rb b/features/support/router_helper.rb index abc1234..def5678 100644 --- a/features/support/router_helper.rb +++ b/features/support/router_helper.rb @@ -0,0 +1,4 @@+require 'gds_api/router' +# We never have to go to the Router during Feature tests. Disable. +GdsApi::Router.an...
Disable the Router API client during Cucumber
diff --git a/db/migrate/20140520143420_add_upload_usage_data_delayed_job.rb b/db/migrate/20140520143420_add_upload_usage_data_delayed_job.rb index abc1234..def5678 100644 --- a/db/migrate/20140520143420_add_upload_usage_data_delayed_job.rb +++ b/db/migrate/20140520143420_add_upload_usage_data_delayed_job.rb @@ -0,0 +1,...
Add migration to set up delayed job
diff --git a/test/integration/multi_instance/default_spec.rb b/test/integration/multi_instance/default_spec.rb index abc1234..def5678 100644 --- a/test/integration/multi_instance/default_spec.rb +++ b/test/integration/multi_instance/default_spec.rb @@ -3,16 +3,23 @@ it { should be_owned_by 'tomcat_helloworld' } end ...
Expand tests for the tomcat_docs install
diff --git a/test/document_test.rb b/test/document_test.rb index abc1234..def5678 100644 --- a/test/document_test.rb +++ b/test/document_test.rb @@ -12,7 +12,7 @@ def test_with_no_title d = Asciidoctor::Document.new("Snorf") - assert_equal '', d.title + assert_nil d.title end def test_is_section_...
Fix doc_test_with_no_title to expect nil
diff --git a/vendor/plugins/sfu_course_copy_importer/init.rb b/vendor/plugins/sfu_course_copy_importer/init.rb index abc1234..def5678 100644 --- a/vendor/plugins/sfu_course_copy_importer/init.rb +++ b/vendor/plugins/sfu_course_copy_importer/init.rb @@ -0,0 +1,20 @@+# CANVAS-240 Add WebCT wording to new Import Content p...
Add WebCT wording to new Import Content page CANVAS-240
diff --git a/railties/lib/rails/generators/rails/plugin_new/templates/%name%.gemspec b/railties/lib/rails/generators/rails/plugin_new/templates/%name%.gemspec index abc1234..def5678 100644 --- a/railties/lib/rails/generators/rails/plugin_new/templates/%name%.gemspec +++ b/railties/lib/rails/generators/rails/plugin_new/...
Add folders app and config to the engine's gemspec if they're available
diff --git a/app/models/competitions/blind_date_at_the_dairy_overall.rb b/app/models/competitions/blind_date_at_the_dairy_overall.rb index abc1234..def5678 100644 --- a/app/models/competitions/blind_date_at_the_dairy_overall.rb +++ b/app/models/competitions/blind_date_at_the_dairy_overall.rb @@ -6,25 +6,25 @@ def...
Update Blind Date categories for 2016
diff --git a/app/admin/delivery_update.rb b/app/admin/delivery_update.rb index abc1234..def5678 100644 --- a/app/admin/delivery_update.rb +++ b/app/admin/delivery_update.rb @@ -8,4 +8,15 @@ filter :study filter :user filter :created + + index do + selectable_column + column :study + column :user + ...
Improve the columns show on delivery update admin
diff --git a/lib/guard/jekyll.rb b/lib/guard/jekyll.rb index abc1234..def5678 100644 --- a/lib/guard/jekyll.rb +++ b/lib/guard/jekyll.rb @@ -46,11 +46,12 @@ end def create_site - options = { - 'source' => @working_path, - 'destination' => File.join(@working_path, '_site'), - 'p...
Allow 'destination' and 'plugins' directories to be set in _config.yml
diff --git a/lib/hashid/rails.rb b/lib/hashid/rails.rb index abc1234..def5678 100644 --- a/lib/hashid/rails.rb +++ b/lib/hashid/rails.rb @@ -56,7 +56,7 @@ private def model_reload? - caller.first(3).any?{|s| s =~ /active_record\/persistence.*reload/} + caller.any? {|s| s =~ /active_record\/...
Remove model reload scope of first since persistance fell outside
diff --git a/spec/fc-reminder/providers/livescore_spec.rb b/spec/fc-reminder/providers/livescore_spec.rb index abc1234..def5678 100644 --- a/spec/fc-reminder/providers/livescore_spec.rb +++ b/spec/fc-reminder/providers/livescore_spec.rb @@ -26,20 +26,16 @@ before { fake_page_with_match(provider.url) } subj...
Change a day with a match LiveScore test
diff --git a/lib/locotimezone.rb b/lib/locotimezone.rb index abc1234..def5678 100644 --- a/lib/locotimezone.rb +++ b/lib/locotimezone.rb @@ -12,7 +12,7 @@ end def self.locotime(options = {}) - set_default_configuration if configuration.nil? + configure_with_defaults if configuration.nil? Locotime.new(...
Change name to configure_with_defaults for clarity
diff --git a/lib/mongodoc.rb b/lib/mongodoc.rb index abc1234..def5678 100644 --- a/lib/mongodoc.rb +++ b/lib/mongodoc.rb @@ -6,7 +6,7 @@ gem 'leshill-will_paginate', '2.3.11' require 'mongo' -require 'activesupport' +require 'active_support' require 'validatable' require 'will_paginate/collection'
Fix Rails 3 deprecation warning
diff --git a/actionmailer/lib/action_mailer/log_subscriber.rb b/actionmailer/lib/action_mailer/log_subscriber.rb index abc1234..def5678 100644 --- a/actionmailer/lib/action_mailer/log_subscriber.rb +++ b/actionmailer/lib/action_mailer/log_subscriber.rb @@ -8,7 +8,7 @@ def deliver(event) info do reci...
Remove newlines from start of logs Currently if using a single line logger, this causes the time stamp and log message to be on separate lines which is not common to how most other logging works.
diff --git a/lib/tasks/brew.rake b/lib/tasks/brew.rake index abc1234..def5678 100644 --- a/lib/tasks/brew.rake +++ b/lib/tasks/brew.rake @@ -14,7 +14,7 @@ def brew_outdated? `brew update` output = `brew outdated` - puts "#{time}: About to upgrade: #{output}" unless output == '' + puts "#{time}: *** Up...
Make upgrades easier to see in output.
diff --git a/Casks/tg-pro.rb b/Casks/tg-pro.rb index abc1234..def5678 100644 --- a/Casks/tg-pro.rb +++ b/Casks/tg-pro.rb @@ -1,6 +1,6 @@ cask :v1 => 'tg-pro' do - version '2.7.1' - sha256 'b44547b1c76eb69441c3f41eb3975301ec59c405b645f16d835c4243b82031eb' + version '2.7.2' + sha256 '6708a9762a62d30e2e83b37cd6c7597d0...
Update TG Pro.app to v2.7.2
diff --git a/client/ruby/flare/app/controllers/application.rb b/client/ruby/flare/app/controllers/application.rb index abc1234..def5678 100644 --- a/client/ruby/flare/app/controllers/application.rb +++ b/client/ruby/flare/app/controllers/application.rb @@ -12,7 +12,7 @@ def query queries = session[:queries] ...
Switch all-docs query to new *:* syntax git-svn-id: 3b1ff1236863b4d63a22e4dae568675c2e247730@510345 13f79535-47bb-0310-9956-ffa450edef68
diff --git a/test/relation_test.rb b/test/relation_test.rb index abc1234..def5678 100644 --- a/test/relation_test.rb +++ b/test/relation_test.rb @@ -2,7 +2,9 @@ describe ActiveRecord::Relation do let(:relation) { - if ActiveRecord::VERSION::MAJOR > 4 + if ActiveRecord.gem_version >= Gem::Version.new("5.2") +...
Support rails 5.2 relation signature