diff
stringlengths
65
26.7k
message
stringlengths
7
9.92k
diff --git a/app/decorators/project_decorator.rb b/app/decorators/project_decorator.rb index abc1234..def5678 100644 --- a/app/decorators/project_decorator.rb +++ b/app/decorators/project_decorator.rb @@ -46,8 +46,9 @@ def progress_bar + width = source.progress > 100 ? 100 : source.progress content_tag(:d...
Fix progress bar in the project box.
diff --git a/spec/integration/auth_spec.rb b/spec/integration/auth_spec.rb index abc1234..def5678 100644 --- a/spec/integration/auth_spec.rb +++ b/spec/integration/auth_spec.rb @@ -13,6 +13,20 @@ click_button 'Register' expect(page).to have_content 'You have signed up successfully' + end + + it 'should let...
Write test for current login scenario
diff --git a/spec/presenters/tree_node/pxe_image_type_spec.rb b/spec/presenters/tree_node/pxe_image_type_spec.rb index abc1234..def5678 100644 --- a/spec/presenters/tree_node/pxe_image_type_spec.rb +++ b/spec/presenters/tree_node/pxe_image_type_spec.rb @@ -3,5 +3,5 @@ let(:object) { FactoryBot.create(:pxe_image_type)...
Adjust spec for TreeNode::PxeImageType after the decorator icon change
diff --git a/app/api/v1/defaults.rb b/app/api/v1/defaults.rb index abc1234..def5678 100644 --- a/app/api/v1/defaults.rb +++ b/app/api/v1/defaults.rb @@ -31,6 +31,11 @@ JWT::VerificationError do |e| error!({ errors: Array(e.message) }, 400) end + + # Global handler for any ...
Add global error handler for unexpected exceptions
diff --git a/striped.gemspec b/striped.gemspec index abc1234..def5678 100644 --- a/striped.gemspec +++ b/striped.gemspec @@ -21,6 +21,7 @@ gem.add_development_dependency 'rspec', '~> 2.12' gem.add_development_dependency 'webmock', '~> 1.9' + gem.add_development_dependency 'vcr', '~> 2.4' gem.add_development_...
Add vcr as a development dependency
diff --git a/spec/space2underscore_spec.rb b/spec/space2underscore_spec.rb index abc1234..def5678 100644 --- a/spec/space2underscore_spec.rb +++ b/spec/space2underscore_spec.rb @@ -5,8 +5,4 @@ expect(Space2underscore.convert(['fuga hoge foo'])).to include('_') # String case expect(Space2underscore.convert(%w(f...
Remove an example, It is needless
diff --git a/lib/capones_recipes/tasks/airbrake/symlink.rb b/lib/capones_recipes/tasks/airbrake/symlink.rb index abc1234..def5678 100644 --- a/lib/capones_recipes/tasks/airbrake/symlink.rb +++ b/lib/capones_recipes/tasks/airbrake/symlink.rb @@ -7,4 +7,4 @@ run "ln -nfs #{shared_path}/config/initializers/airbrake....
Add missing newline to EOF.
diff --git a/update.rb b/update.rb index abc1234..def5678 100644 --- a/update.rb +++ b/update.rb @@ -19,10 +19,11 @@ end end.parse! -debline = open(options[:config]).read.split(/\n/)[0] - db = SQLite3::Database.new(options[:database]) db.execute("CREATE TABLE IF NOT EXISTS packages (package TEXT PRIMARY KEY, vers...
Support updating from multiple repositories.
diff --git a/lib/instana/frameworks/rails.rb b/lib/instana/frameworks/rails.rb index abc1234..def5678 100644 --- a/lib/instana/frameworks/rails.rb +++ b/lib/instana/frameworks/rails.rb @@ -5,7 +5,7 @@ ::Instana.logger = ::Rails.logger if ::Rails.logger if ::Rails::VERSION::MAJOR < 3 - ::Rails.configuration.af...
Fix Rails 2 initialization block
diff --git a/thailang4r.gemspec b/thailang4r.gemspec index abc1234..def5678 100644 --- a/thailang4r.gemspec +++ b/thailang4r.gemspec @@ -6,7 +6,7 @@ s.description = "Thai language tools for Ruby, i.e. a word tokenizer, a character level indentifier, and a romanization tool" s.homepage = "https://github.com/veer66/...
Downgrade Ruby version requirement to >= 2.0.0
diff --git a/lib/bootstrap_validator_rails/form_builder.rb b/lib/bootstrap_validator_rails/form_builder.rb index abc1234..def5678 100644 --- a/lib/bootstrap_validator_rails/form_builder.rb +++ b/lib/bootstrap_validator_rails/form_builder.rb @@ -20,7 +20,8 @@ options[:data] ||= {} attribute = @attributes.va...
Exclude hidden field from check_box
diff --git a/lib/selenium/webdriver/common/element_mini.rb b/lib/selenium/webdriver/common/element_mini.rb index abc1234..def5678 100644 --- a/lib/selenium/webdriver/common/element_mini.rb +++ b/lib/selenium/webdriver/common/element_mini.rb @@ -3,15 +3,16 @@ module Selenium module WebDriver - ## - # Monkey P...
[JT][111704448] Add ie_safe_checkbox_click to webdriver monkey patch
diff --git a/library/socket/socket/udp_server_recv_spec.rb b/library/socket/socket/udp_server_recv_spec.rb index abc1234..def5678 100644 --- a/library/socket/socket/udp_server_recv_spec.rb +++ b/library/socket/socket/udp_server_recv_spec.rb @@ -20,15 +20,8 @@ @client.write('hello') - # FreeBSD sockets are no...
Make sure to wait for socket to be readable. git-svn-id: ab86ecd26fe50a6a239cacb71380e346f71cee7d@67004 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
diff --git a/Formula/imdb-tags.rb b/Formula/imdb-tags.rb index abc1234..def5678 100644 --- a/Formula/imdb-tags.rb +++ b/Formula/imdb-tags.rb @@ -9,6 +9,7 @@ def install ENV["GOPATH"] = "#{buildpath}/Godeps/_workspace" + system("mkdir -p #{buildpath}/Godeps/_workspace/src/github.com/dillonhafer/imdb-tags") ...
Add mkdir command to imdb
diff --git a/core/lib/spree/core/testing_support/factories/product_factory.rb b/core/lib/spree/core/testing_support/factories/product_factory.rb index abc1234..def5678 100644 --- a/core/lib/spree/core/testing_support/factories/product_factory.rb +++ b/core/lib/spree/core/testing_support/factories/product_factory.rb @@ ...
Fix model references in product factory
diff --git a/Nacre.gemspec b/Nacre.gemspec index abc1234..def5678 100644 --- a/Nacre.gemspec +++ b/Nacre.gemspec @@ -16,6 +16,7 @@ gem.version = Nacre::VERSION gem.add_dependency 'faraday' + gem.add_dependency 'json' gem.add_dependency 'active_support' gem.add_development_dependency 'rspec' gem.a...
Add json dependency to gemspec
diff --git a/templates/spec_helper.rb b/templates/spec_helper.rb index abc1234..def5678 100644 --- a/templates/spec_helper.rb +++ b/templates/spec_helper.rb @@ -20,6 +20,8 @@ config.example_status_persistence_file_path = "tmp/rspec_examples.txt" config.order = :random + + config.default_formatter = 'doc' if con...
Use doc formatter for rspec, when rspec is run with one file
diff --git a/test/models/user_test.rb b/test/models/user_test.rb index abc1234..def5678 100644 --- a/test/models/user_test.rb +++ b/test/models/user_test.rb @@ -1,7 +1,39 @@ require 'test_helper' class UserTest < ActiveSupport::TestCase - # test "the truth" do - # assert true - # end + test "should not save us...
Add test for user models
diff --git a/post-clean.rb b/post-clean.rb index abc1234..def5678 100644 --- a/post-clean.rb +++ b/post-clean.rb @@ -2,11 +2,11 @@ # doc/*.rb.html # doc/ex/* (!rb) # Bug #246: Don't use chdir! -require 'ftools' +require 'fileutils' targets = Dir['doc/*.rb.html'] -File.safe_unlink(*targets) unless targets.empty? +F...
Use "fileutils" instead of "ftools"
diff --git a/recurly_event.gemspec b/recurly_event.gemspec index abc1234..def5678 100644 --- a/recurly_event.gemspec +++ b/recurly_event.gemspec @@ -13,14 +13,6 @@ spec.homepage = "https://github.com/ejaypcanaria/recurly_event" spec.license = "MIT" - # Prevent pushing this gem to RubyGems.org by sett...
Remove some unnecessary stuff in gemspec
diff --git a/color-scheme-validator.gemspec b/color-scheme-validator.gemspec index abc1234..def5678 100644 --- a/color-scheme-validator.gemspec +++ b/color-scheme-validator.gemspec @@ -22,5 +22,5 @@ spec.add_development_dependency "bundler", "~> 1.10" spec.add_development_dependency "rake", "~> 10.0" - spec.add...
Upgrade test-unit version to "~> 3.2.1"
diff --git a/lib/buildr/version.rb b/lib/buildr/version.rb index abc1234..def5678 100644 --- a/lib/buildr/version.rb +++ b/lib/buildr/version.rb @@ -14,5 +14,5 @@ # the License. module Buildr - VERSION = '1.4.11.dev'.freeze + VERSION = '1.4.11'.freeze end
Remove suffix in preparation for release git-svn-id: d8f3215415546ce936cf3b822120ca56e5ebeaa0@1456386 13f79535-47bb-0310-9956-ffa450edef68
diff --git a/lib/endi_feed/util.rb b/lib/endi_feed/util.rb index abc1234..def5678 100644 --- a/lib/endi_feed/util.rb +++ b/lib/endi_feed/util.rb @@ -1,3 +1,4 @@+# encoding: utf-8 require 'uri' require 'rss' require 'time' @@ -12,9 +13,10 @@ module_function # Fetches and parses RSS feed + # @param [Stri...
Add url parameter to parse_feed method
diff --git a/lib/proxy_rb/setup.rb b/lib/proxy_rb/setup.rb index abc1234..def5678 100644 --- a/lib/proxy_rb/setup.rb +++ b/lib/proxy_rb/setup.rb @@ -59,7 +59,11 @@ runtime.event_bus.register( :after_resource_fetched, proc do |event| - runtime.announcer.announce :http_response_headers, e...
Handle unsupported response headers method
diff --git a/lib/remedy/console.rb b/lib/remedy/console.rb index abc1234..def5678 100644 --- a/lib/remedy/console.rb +++ b/lib/remedy/console.rb @@ -9,11 +9,11 @@ module_function def input - STDIN + @input ||= $stdin end def output - STDOUT + @output ||= $stdout end ...
Replace STDIN with and use an instance variable to provide for switchable IO.
diff --git a/library/pp/pp_spec.rb b/library/pp/pp_spec.rb index abc1234..def5678 100644 --- a/library/pp/pp_spec.rb +++ b/library/pp/pp_spec.rb @@ -2,14 +2,6 @@ require 'pp' describe "PP.pp" do - before :each do - @original_stdout = $stdout - end - - after :each do - $stdout = @original_stdout - end - ...
Use the output matcher in PP.pp to avoid touching $stdout directly
diff --git a/app/models/document.rb b/app/models/document.rb index abc1234..def5678 100644 --- a/app/models/document.rb +++ b/app/models/document.rb @@ -9,10 +9,22 @@ } def draft - content_items.find_by(state: "draft") + draft_items = content_items.where(state: "draft") + + if draft_items.size > 1 + ...
Add checks for draft and live content items
diff --git a/db/migrate/20130614175900_empty_exercises.rb b/db/migrate/20130614175900_empty_exercises.rb index abc1234..def5678 100644 --- a/db/migrate/20130614175900_empty_exercises.rb +++ b/db/migrate/20130614175900_empty_exercises.rb @@ -0,0 +1,13 @@+class EmptyExercises < ActiveRecord::Migration + def up + crea...
Include exercises table just in case we're not linking the site to a student-checklist web app.
diff --git a/scraper_tools.gemspec b/scraper_tools.gemspec index abc1234..def5678 100644 --- a/scraper_tools.gemspec +++ b/scraper_tools.gemspec @@ -2,14 +2,15 @@ $:.unshift lib unless $:.include?(lib) require 'scraper_tools/version' - + Gem::Specification.new do |s| s.name = "scraper_tools" s.version...
Add required summary to gemspec
diff --git a/test/parser/macro_expander_test.rb b/test/parser/macro_expander_test.rb index abc1234..def5678 100644 --- a/test/parser/macro_expander_test.rb +++ b/test/parser/macro_expander_test.rb @@ -6,11 +6,27 @@ def setup @expander = MacroExpander.new + test_returning_macro = Macro.build_macro_from_str...
Write a test to make sure that the last child of an ExpansionBlock knows its an arg if the ExpansionBlock is expected to return.
diff --git a/test/writers/html/tc_html_document.rb b/test/writers/html/tc_html_document.rb index abc1234..def5678 100644 --- a/test/writers/html/tc_html_document.rb +++ b/test/writers/html/tc_html_document.rb @@ -23,8 +23,6 @@ writer: 'html', showAllTags: false) got = metadata[:writerOutput] - Fi...
Remove write test from html writer
diff --git a/test/unit/chart_done_ratio_test.rb b/test/unit/chart_done_ratio_test.rb index abc1234..def5678 100644 --- a/test/unit/chart_done_ratio_test.rb +++ b/test/unit/chart_done_ratio_test.rb @@ -1,6 +1,6 @@ require File.dirname(__FILE__) + '/../test_helper' -class ChartTimeEntryTest < ActiveSupport::TestCase +c...
Rename test case name for ChartDoneRatio
diff --git a/fakeetc.gemspec b/fakeetc.gemspec index abc1234..def5678 100644 --- a/fakeetc.gemspec +++ b/fakeetc.gemspec @@ -21,6 +21,8 @@ gem.require_paths = ['lib'] gem.version = FakeEtc::VERSION + gem.required_ruby_version = '>= 1.9.3' + gem.add_development_dependency 'rake', '~> 10.4.2' gem.add_...
Add required Ruby version to gemspec
diff --git a/faraday.gemspec b/faraday.gemspec index abc1234..def5678 100644 --- a/faraday.gemspec +++ b/faraday.gemspec @@ -5,7 +5,7 @@ Gem::Specification.new do |spec| spec.specification_version = 2 if spec.respond_to? :specification_version= - spec.required_rubygems_version = Gem::Requirement.new(">= 1.3.5") i...
Use of custom objects is not necessary here
diff --git a/spec/acceptance/basic_neutron_spec.rb b/spec/acceptance/basic_neutron_spec.rb index abc1234..def5678 100644 --- a/spec/acceptance/basic_neutron_spec.rb +++ b/spec/acceptance/basic_neutron_spec.rb @@ -28,7 +28,8 @@ it 'should list OVS bridges' do shell("ovs-vsctl show") do |r| expe...
Remove br-tun check from beaker Currently this check is flapping because the ovs agent is hitting timeouts when trying to get a response from the neutron-server. This is likely because we start all the services at the same time and if neutron-server takes too long to start as well as the exponential timeout calculatio...
diff --git a/spec/features/listing_coaches_spec.rb b/spec/features/listing_coaches_spec.rb index abc1234..def5678 100644 --- a/spec/features/listing_coaches_spec.rb +++ b/spec/features/listing_coaches_spec.rb @@ -0,0 +1,10 @@+require 'spec_helper' + +feature 'when visiting the coaches page' do + let!(:coach) { Fabrica...
Add wall_of_fame action test to bump coverage
diff --git a/spec/octokit/client/downloads_spec.rb b/spec/octokit/client/downloads_spec.rb index abc1234..def5678 100644 --- a/spec/octokit/client/downloads_spec.rb +++ b/spec/octokit/client/downloads_spec.rb @@ -23,7 +23,7 @@ end end # .download - describe ".delete_download", :vcr do + describe ".delete_dow...
Remove vcr tag from stubbed test in downloads spec
diff --git a/jekyll-theme-tactile.gemspec b/jekyll-theme-tactile.gemspec index abc1234..def5678 100644 --- a/jekyll-theme-tactile.gemspec +++ b/jekyll-theme-tactile.gemspec @@ -4,7 +4,7 @@ s.name = "jekyll-theme-tactile" s.version = "0.0.1" s.authors = ["Jason Long"] - s.email = ["...
Update contact email in Gemspec
diff --git a/test/cache_fetch_includes_test.rb b/test/cache_fetch_includes_test.rb index abc1234..def5678 100644 --- a/test/cache_fetch_includes_test.rb +++ b/test/cache_fetch_includes_test.rb @@ -0,0 +1,46 @@+require "test_helper" + +class CacheFetchIncludesTest < IdentityCache::TestCase + def setup + super + end...
Add a separate set of test cases for the cache_fetch_includes traversal
diff --git a/rbcoremidi.rb b/rbcoremidi.rb index abc1234..def5678 100644 --- a/rbcoremidi.rb +++ b/rbcoremidi.rb @@ -12,6 +12,7 @@ end def create_input_port(client_name, port_name, &proc) + # AFAIK this is the only way to pass the proc to a C function API.create_input_port(client_name, port_name, proc)...
Use the correct comment character
diff --git a/routes.rb b/routes.rb index abc1234..def5678 100644 --- a/routes.rb +++ b/routes.rb @@ -19,40 +19,32 @@ DataMapper.auto_upgrade! get '/' do - if logged_in? - posts = Posts.getAll() - else - posts = Posts.getAll().delete_if { |x| x.hidden == true } - end - erb :index, :locals => { - :posts...
Refactor auth check and add user list
diff --git a/app/controllers/passwords_controller.rb b/app/controllers/passwords_controller.rb index abc1234..def5678 100644 --- a/app/controllers/passwords_controller.rb +++ b/app/controllers/passwords_controller.rb @@ -1,10 +1,10 @@ class PasswordsController < Devise::PasswordsController - def create - self.resou...
Fix broken password reset controller tests Until recently, this code was never actually running. It appears that wiring it up broke some functionality. Further to that, the duplicated Devise code didn't match. I decided to avoid copying code entirely, and instead use a before_filter.
diff --git a/app/decorators/miq_request_decorator.rb b/app/decorators/miq_request_decorator.rb index abc1234..def5678 100644 --- a/app/decorators/miq_request_decorator.rb +++ b/app/decorators/miq_request_decorator.rb @@ -7,15 +7,4 @@ "pficon pficon-error-circle-o" end end - - def fileicon - case reque...
Drop fileicon decorator from MiqRequestDecorator https://bugzilla.redhat.com/show_bug.cgi?id=1514620
diff --git a/black_list.rb b/black_list.rb index abc1234..def5678 100644 --- a/black_list.rb +++ b/black_list.rb @@ -4,6 +4,7 @@ BlackList = [ ["coq-compcert.3.1.0", "Error: Corrupted compiled interface"], # flaky Makefile + ["coq-compcert.3.2.0", "Error: Corrupted compiled interface"], # flaky Makefile ["coq-...
Add CompCert 3.2.0 to the black-list for flaky Makefile
diff --git a/calculators/bmi/bmi.rb b/calculators/bmi/bmi.rb index abc1234..def5678 100644 --- a/calculators/bmi/bmi.rb +++ b/calculators/bmi/bmi.rb @@ -1,11 +1,9 @@ name :bmi +require_helpers :get_field_as_float execute do - raise FieldError.new("weight", "weight must be a number") if !field_weight.is_float? -...
Use new helper methods for getting fields
diff --git a/catarse_stripe.gemspec b/catarse_stripe.gemspec index abc1234..def5678 100644 --- a/catarse_stripe.gemspec +++ b/catarse_stripe.gemspec @@ -20,7 +20,7 @@ s.add_dependency "activemerchant", ">= 1.17.0" s.add_dependency "stripe", :git => 'https://github.com/stripe/stripe-ruby' s.add_dependency "omnia...
Fix new dependencies and Migrations
diff --git a/fastlane-plugin-github_status.gemspec b/fastlane-plugin-github_status.gemspec index abc1234..def5678 100644 --- a/fastlane-plugin-github_status.gemspec +++ b/fastlane-plugin-github_status.gemspec @@ -6,12 +6,12 @@ Gem::Specification.new do |spec| spec.name = 'fastlane-plugin-github_status' s...
Add homepage url to gemspec
diff --git a/clock.gemspec b/clock.gemspec index abc1234..def5678 100644 --- a/clock.gemspec +++ b/clock.gemspec @@ -2,7 +2,7 @@ Gem::Specification.new do |s| s.name = 'clock' s.summary = 'Clock interface with support for dependency configuration for real and null object implementations' - s.version = '0.0.2.0' ...
Package version is incremented from 0.0.2.0 to 0.0.3.0
diff --git a/attributes/datastax.rb b/attributes/datastax.rb index abc1234..def5678 100644 --- a/attributes/datastax.rb +++ b/attributes/datastax.rb @@ -1,5 +1,5 @@ -default['cassandra']['package_name'] = 'dsc20' +default['cassandra']['package_name'] = 'dsc21' default['cassandra']['release'] = '1' default[...
Update package name for 2.1.x
diff --git a/ios-ntp.podspec b/ios-ntp.podspec index abc1234..def5678 100644 --- a/ios-ntp.podspec +++ b/ios-ntp.podspec @@ -4,7 +4,7 @@ s.summary = 'SNTP implementation for iOS.' s.homepage = 'https://github.com/jbenet/ios-ntp' s.license = { :type => 'MIT', :file => 'LICENSE' } - s.source ...
Correct the "version tag" in the podspec. Also waiting for the pod people to let me claim this software.
diff --git a/spec/comments_spec.rb b/spec/comments_spec.rb index abc1234..def5678 100644 --- a/spec/comments_spec.rb +++ b/spec/comments_spec.rb @@ -25,6 +25,17 @@ expect(comments.length).to eq(count) end + it "comments are unique" do + comments_api = RedditApi::Comments.new + user = RedditApi...
Add uniqueness expectation to RedditApi::Comments RedditApi::Comments#most_recent_comments
diff --git a/spec/unit/sub_spec.rb b/spec/unit/sub_spec.rb index abc1234..def5678 100644 --- a/spec/unit/sub_spec.rb +++ b/spec/unit/sub_spec.rb @@ -0,0 +1,76 @@+ +# +# specifying flor +# +# Mon Jan 9 07:54:05 JST 2017 +# + +require 'spec_helper' + + +describe 'Flor unit' do + + before :each do + + @unit = Flor::U...
Add routine check for nested cmaps subids
diff --git a/Casks/balsamiq-mockups.rb b/Casks/balsamiq-mockups.rb index abc1234..def5678 100644 --- a/Casks/balsamiq-mockups.rb +++ b/Casks/balsamiq-mockups.rb @@ -1,6 +1,6 @@ cask :v1 => 'balsamiq-mockups' do - version '3.1.5' - sha256 '738c986bc3d43d6a9cd0bbef9e8bd50edf5b5e7b865ff72c8fa9fe9048c662d8' + version '3...
Update Balsamiq Mockups to 3.1.6.
diff --git a/examples/build-catalog-from-epub.rb b/examples/build-catalog-from-epub.rb index abc1234..def5678 100644 --- a/examples/build-catalog-from-epub.rb +++ b/examples/build-catalog-from-epub.rb @@ -0,0 +1,61 @@+# This is an example that aggregates info from EPUB files and build OPDS catalog feed using them +# +...
Add sample script to build OPDS catalog from EPUB files
diff --git a/Casks/thunderbird-beta.rb b/Casks/thunderbird-beta.rb index abc1234..def5678 100644 --- a/Casks/thunderbird-beta.rb +++ b/Casks/thunderbird-beta.rb @@ -1,8 +1,8 @@ class ThunderbirdBeta < Cask - version '31.0b3' - sha256 '82cf13b42f72a660920cfd025220d2ce9ddfb56327b01721b4b02e065752061d' + version '32.0b...
Update Thunderbird Beta to 32.0b1
diff --git a/debugger-ruby_core_source.gemspec b/debugger-ruby_core_source.gemspec index abc1234..def5678 100644 --- a/debugger-ruby_core_source.gemspec +++ b/debugger-ruby_core_source.gemspec @@ -12,7 +12,7 @@ s.description = %q{Provide Ruby core source files for C extensions that need them.} s.required_rubygems_...
Allow the .gemspec to be used by Bundler. Shelling out to git presumes that you're generating a gem from the current directory.
diff --git a/app/models/gobierto_data/cached_data.rb b/app/models/gobierto_data/cached_data.rb index abc1234..def5678 100644 --- a/app/models/gobierto_data/cached_data.rb +++ b/app/models/gobierto_data/cached_data.rb @@ -3,6 +3,11 @@ module GobiertoData class CachedData CACHED_DATA_BASE_PATH = "gobierto_data/ca...
Include content_type and disposition in CachedData upload service
diff --git a/db/seeds/demo/events/rabbit.rb b/db/seeds/demo/events/rabbit.rb index abc1234..def5678 100644 --- a/db/seeds/demo/events/rabbit.rb +++ b/db/seeds/demo/events/rabbit.rb @@ -8,7 +8,9 @@ event_type_id: 19, description: "meeting with family in clinic", notes: "anxious about medication chang...
Update events sample seeds for RABBIT
diff --git a/app/mailers/meeting_invitation_mailer.rb b/app/mailers/meeting_invitation_mailer.rb index abc1234..def5678 100644 --- a/app/mailers/meeting_invitation_mailer.rb +++ b/app/mailers/meeting_invitation_mailer.rb @@ -8,7 +8,7 @@ @member = member @meeting = meeting @host_address = AddressDecorator....
Use meeting_url instead of path
diff --git a/lib/capistrano/puma/nginx.rb b/lib/capistrano/puma/nginx.rb index abc1234..def5678 100644 --- a/lib/capistrano/puma/nginx.rb +++ b/lib/capistrano/puma/nginx.rb @@ -3,10 +3,10 @@ include PumaCommon def set_defaults # Nginx and puma configuration - set_if_empty :nginx_config_name, "#{fet...
Fix vars loading issue during plugin initialization
diff --git a/lib/cloudstrap/amazon/elb.rb b/lib/cloudstrap/amazon/elb.rb index abc1234..def5678 100644 --- a/lib/cloudstrap/amazon/elb.rb +++ b/lib/cloudstrap/amazon/elb.rb @@ -20,6 +20,16 @@ Tags = HashOf[String, String] + Contract Args[String] => HashOf[String, Tags] + def tags(*elb_names) + ...
Add method to extract tags from descriptions
diff --git a/app/workers/discourse_sign_out_worker.rb b/app/workers/discourse_sign_out_worker.rb index abc1234..def5678 100644 --- a/app/workers/discourse_sign_out_worker.rb +++ b/app/workers/discourse_sign_out_worker.rb @@ -5,7 +5,7 @@ for_each_tenant(user_id) do |u,t| client(t) do |c| discourse_us...
Fix NPE if user does not exist in discourse instance
diff --git a/spec/dummy/app/controllers/semi_protected_resources_controller.rb b/spec/dummy/app/controllers/semi_protected_resources_controller.rb index abc1234..def5678 100644 --- a/spec/dummy/app/controllers/semi_protected_resources_controller.rb +++ b/spec/dummy/app/controllers/semi_protected_resources_controller.rb...
Undo behavior change on specs. See https://github.com/doorkeeper-gem/doorkeeper/pull/448/files#diff-403546b64759d2fcb933e8345a827403L2.
diff --git a/lib/nest_wrapper.rb b/lib/nest_wrapper.rb index abc1234..def5678 100644 --- a/lib/nest_wrapper.rb +++ b/lib/nest_wrapper.rb @@ -13,12 +13,7 @@ def self.login(email, password) self.nest = NestThermostat::Nest.new({ email: email, password: password }) - set_status - - self.device = NestWrapper...
Tweak some assignments in the initialize.
diff --git a/lib/rubbr/change.rb b/lib/rubbr/change.rb index abc1234..def5678 100644 --- a/lib/rubbr/change.rb +++ b/lib/rubbr/change.rb @@ -8,9 +8,10 @@ require 'yaml' def self.d? + sums = inventory + return true if Rubbr.options[:force] - sums = inventory if changes?(sums) ...
Create file hashes on forced execution aswell. This way the next unforced run can take advantage of the hashes.
diff --git a/lib/slack-notify.rb b/lib/slack-notify.rb index abc1234..def5678 100644 --- a/lib/slack-notify.rb +++ b/lib/slack-notify.rb @@ -10,7 +10,7 @@ @subdomain = subdomain @token = token @username = options[:username] || "webhookbot" - @channel = options[:channel] || "general" + ...
Use pound for channel names
diff --git a/lib/tasks/spec.rake b/lib/tasks/spec.rake index abc1234..def5678 100644 --- a/lib/tasks/spec.rake +++ b/lib/tasks/spec.rake @@ -0,0 +1,8 @@+require 'rspec-puppet' + +desc "Run any defined tests" +RSpec::Core::RakeTask.new(:spec) do |t| + t.pattern = 'spec/*.rb' + t.ruby_opts = '-W0' + t.rspec_opts = '--...
Add example test runner rake command Encourage testing via providing a default spec running command
diff --git a/lib/sub_diff/diff_builder.rb b/lib/sub_diff/diff_builder.rb index abc1234..def5678 100644 --- a/lib/sub_diff/diff_builder.rb +++ b/lib/sub_diff/diff_builder.rb @@ -13,11 +13,11 @@ end def push(*args) - tap do - if args.compact.any? - diffs << Diff.new(*args) - end + ...
Return `self` instead of using `tap` for clarity
diff --git a/lib/sunspot/queue/helpers.rb b/lib/sunspot/queue/helpers.rb index abc1234..def5678 100644 --- a/lib/sunspot/queue/helpers.rb +++ b/lib/sunspot/queue/helpers.rb @@ -3,21 +3,19 @@ module Sunspot::Queue module Helpers def without_proxy + proxy = nil + # Pop off the queueing proxy for the b...
Refactor without_proxy so it returns the result of the block.
diff --git a/lib/tiki/torch/connection.rb b/lib/tiki/torch/connection.rb index abc1234..def5678 100644 --- a/lib/tiki/torch/connection.rb +++ b/lib/tiki/torch/connection.rb @@ -33,7 +33,11 @@ uri = URI.parse url options = settings - options[:host] = uri.host || '127.0.0.1' + if ...
Use a convention to allow multiple hosts on a ENV url.
diff --git a/lib/unparser/emitter/args.rb b/lib/unparser/emitter/args.rb index abc1234..def5678 100644 --- a/lib/unparser/emitter/args.rb +++ b/lib/unparser/emitter/args.rb @@ -7,9 +7,7 @@ def emit_block_arguments delimited(normal_arguments) - if normal_arguments.one? - write(',') if n_...
Change to aggregate boolean expression
diff --git a/spec/butler_spec.rb b/spec/butler_spec.rb index abc1234..def5678 100644 --- a/spec/butler_spec.rb +++ b/spec/butler_spec.rb @@ -1,3 +1,9 @@+class Butler + def list + ['command1', 'command2', 'command3'] + end +end + RSpec.describe "Butler" do describe '#list' do it 'returns a list of availabl...
Add Butler class & dummy method list
diff --git a/app/controllers/users/registrations_controller.rb b/app/controllers/users/registrations_controller.rb index abc1234..def5678 100644 --- a/app/controllers/users/registrations_controller.rb +++ b/app/controllers/users/registrations_controller.rb @@ -1,7 +1,7 @@ class Users::RegistrationsController < Devise::...
Stop error when param not supplied Fixes https://rollbar.com/cyclestreets/cyclescape/items/132/
diff --git a/spec/spec_helper.rb b/spec/spec_helper.rb index abc1234..def5678 100644 --- a/spec/spec_helper.rb +++ b/spec/spec_helper.rb @@ -6,5 +6,4 @@ config.color = true config.platform = 'ubuntu' config.version = '18.04' - config.log_level = :fatal end
Drop specifying log level for unit tests
diff --git a/spec/spec_helper.rb b/spec/spec_helper.rb index abc1234..def5678 100644 --- a/spec/spec_helper.rb +++ b/spec/spec_helper.rb @@ -7,9 +7,9 @@ puts "Skipping SimpleCov" end -require File.expand_path("../dummy/config/environment.rb", __FILE__) +# require File.expand_path("../dummy/config/environment.rb",...
Reset configuration after tests so we can use a real configuration for testing
diff --git a/spec/spec_helper.rb b/spec/spec_helper.rb index abc1234..def5678 100644 --- a/spec/spec_helper.rb +++ b/spec/spec_helper.rb @@ -27,7 +27,11 @@ # Monkeypatch to mutant .rc3 fixing double diffs error. # +# Also does run all mutations. +# # TODO: Use master once it supports configurable implicit coverage....
Add monkeypatch for full implicit coverage
diff --git a/spec/spec_helper.rb b/spec/spec_helper.rb index abc1234..def5678 100644 --- a/spec/spec_helper.rb +++ b/spec/spec_helper.rb @@ -1,3 +1,5 @@+$LOAD_PATH.unshift File.expand_path('../../lib', __FILE__) + require "rspec" require "converse"
Add converse to the load path
diff --git a/spec/spec_helper.rb b/spec/spec_helper.rb index abc1234..def5678 100644 --- a/spec/spec_helper.rb +++ b/spec/spec_helper.rb @@ -1,7 +1,6 @@ require "rubygems" require "spec" require "rr" -require "ruby-debug" project_root = File.expand_path("#{__FILE__}/../..") $LOAD_PATH << "#{project_root}/lib"
Remove needless inclusion of "ruby-debug".
diff --git a/spec/spec_helper.rb b/spec/spec_helper.rb index abc1234..def5678 100644 --- a/spec/spec_helper.rb +++ b/spec/spec_helper.rb @@ -1,3 +1,5 @@+# coding: utf-8 + if ENV['COV'] require 'simplecov' SimpleCov.start
Add back encoding comment in for JRuby
diff --git a/spec/spec_helper.rb b/spec/spec_helper.rb index abc1234..def5678 100644 --- a/spec/spec_helper.rb +++ b/spec/spec_helper.rb @@ -14,9 +14,8 @@ require 'rspec/core' require 'rspec/expectations' -Mongoid.configure do |config| - config.connect_to("mongoid-rspec-test") -end +Mongoid::Config.connect_to('mong...
Update RSpec configuration. Set mongoid log level to debug in order to prevent poluting RSpec's output
diff --git a/spec/spec_helper.rb b/spec/spec_helper.rb index abc1234..def5678 100644 --- a/spec/spec_helper.rb +++ b/spec/spec_helper.rb @@ -19,6 +19,3 @@ require "paperclip/storage/ftp" Paperclip.options[:log] = false - -# https://github.com/thoughtbot/cocaine#caveat -Cocaine::CommandLine.runner = Cocaine::CommandL...
Remove obsolete tweak for JRuby We are not testing against JRuby anymore
diff --git a/spec/spec_helper.rb b/spec/spec_helper.rb index abc1234..def5678 100644 --- a/spec/spec_helper.rb +++ b/spec/spec_helper.rb @@ -3,6 +3,7 @@ PROJECT_ROOT = File.expand_path(File.join(File.dirname(__FILE__), '..')).freeze $LOAD_PATH << File.join(PROJECT_ROOT, 'lib') +require 'active_support/core_ext/modul...
Fix test suite for Paperclip 5.1 Ensure Active Support `delegate`, which is used by paperclip, is present.
diff --git a/spec/spec_helper.rb b/spec/spec_helper.rb index abc1234..def5678 100644 --- a/spec/spec_helper.rb +++ b/spec/spec_helper.rb @@ -1,5 +1,7 @@ require 'coveralls' Coveralls.wear! + +require 'pry-byebug' require_relative 'togglv8_spec_helper' require_relative '../lib/togglv8' @@ -29,7 +31,9 @@ end clas...
Add ability to override Testing values w/ environment variables.
diff --git a/spec/support/vcr.rb b/spec/support/vcr.rb index abc1234..def5678 100644 --- a/spec/support/vcr.rb +++ b/spec/support/vcr.rb @@ -5,5 +5,5 @@ c.hook_into :webmock c.default_cassette_options = { serialize_with: :json, record: :once } c.debug_logger = File.open(Rails.root.join('log', 'vcr.log'), 'a') -...
Use curly braces for cassette filter to please URI parser
diff --git a/app/controllers/expensesheets_controller.rb b/app/controllers/expensesheets_controller.rb index abc1234..def5678 100644 --- a/app/controllers/expensesheets_controller.rb +++ b/app/controllers/expensesheets_controller.rb @@ -1,5 +1,4 @@ class ExpensesheetsController < ApplicationController - before_actio...
Remove before expense, find user
diff --git a/test/support/drivers.rb b/test/support/drivers.rb index abc1234..def5678 100644 --- a/test/support/drivers.rb +++ b/test/support/drivers.rb @@ -13,6 +13,8 @@ Capybara::Selenium::Driver.new( app, browser: :chrome, - desired_capabilities: capabilities + desired_capabilities: capabilities, +...
Clear session on each test
diff --git a/test/twine_test_case.rb b/test/twine_test_case.rb index abc1234..def5678 100644 --- a/test/twine_test_case.rb +++ b/test/twine_test_case.rb @@ -31,7 +31,7 @@ end def fixture(filename) - File.join __dir__, 'fixtures', filename + File.join File.dirname(__FILE__), 'fixtures', filename end a...
Fix broken unit tests in Ruby < 2.0.
diff --git a/spec/import/zendesk/ticket/comment/attachment_factory_spec.rb b/spec/import/zendesk/ticket/comment/attachment_factory_spec.rb index abc1234..def5678 100644 --- a/spec/import/zendesk/ticket/comment/attachment_factory_spec.rb +++ b/spec/import/zendesk/ticket/comment/attachment_factory_spec.rb @@ -10,10 +10,9...
Test was not in sync with latest changes to prevent duplicate import.
diff --git a/ruby/gherkin3.gemspec b/ruby/gherkin3.gemspec index abc1234..def5678 100644 --- a/ruby/gherkin3.gemspec +++ b/ruby/gherkin3.gemspec @@ -16,7 +16,7 @@ s.add_development_dependency 'rspec', '~> 3.3' # For coverage reports - s.add_development_dependency 'coveralls', '~> 0.8' + s.add_development_d...
Set an upper limit on the coveralls version in the gemspec coveralls 0.8.8 have the dependency tins ~> 1.6.0, and tins 1.7.0 required Ruby version >= 2.0. Fixes #127.
diff --git a/sampling-hash.gemspec b/sampling-hash.gemspec index abc1234..def5678 100644 --- a/sampling-hash.gemspec +++ b/sampling-hash.gemspec @@ -5,11 +5,11 @@ Gem::Specification.new do |gem| gem.name = "sampling-hash" gem.version = SamplingHash::VERSION - gem.authors = ['Malte Rohde'] - ...
Set authorship to FlavourSys Technology.
diff --git a/spec/jobs/stats_report_generation_job_spec.rb b/spec/jobs/stats_report_generation_job_spec.rb index abc1234..def5678 100644 --- a/spec/jobs/stats_report_generation_job_spec.rb +++ b/spec/jobs/stats_report_generation_job_spec.rb @@ -1,15 +1,16 @@ require 'rails_helper' RSpec.describe StatsReportGeneratio...
Remove spec of returned result from job The jobs returned result is not important and prevents adding logging for job completion.
diff --git a/spec/strong_routes/rails/route_mapper_spec.rb b/spec/strong_routes/rails/route_mapper_spec.rb index abc1234..def5678 100644 --- a/spec/strong_routes/rails/route_mapper_spec.rb +++ b/spec/strong_routes/rails/route_mapper_spec.rb @@ -4,15 +4,16 @@ require 'strong_routes/rails/route_mapper' describe ::Stro...
Use shallow routes in specs Verify that shallow routes do, in fact, work by adding specs. Closes #1
diff --git a/lib/minitest/guard_minitest_plugin.rb b/lib/minitest/guard_minitest_plugin.rb index abc1234..def5678 100644 --- a/lib/minitest/guard_minitest_plugin.rb +++ b/lib/minitest/guard_minitest_plugin.rb @@ -1,5 +1,8 @@-minitest_version = ::MiniTest::Unit::VERSION.split(/\./) -if minitest_version[0].to_i >= 5 && (...
Use Gem::Requirement for checking versions
diff --git a/lib/podio/models/contract_price_v2.rb b/lib/podio/models/contract_price_v2.rb index abc1234..def5678 100644 --- a/lib/podio/models/contract_price_v2.rb +++ b/lib/podio/models/contract_price_v2.rb @@ -2,6 +2,7 @@ has_one :employee, :class => 'ContractPriceItemV2' has_one :external, :class => 'Contrac...
Add item property to ContractPriceV2
diff --git a/lib/processor/data/batch_processor.rb b/lib/processor/data/batch_processor.rb index abc1234..def5678 100644 --- a/lib/processor/data/batch_processor.rb +++ b/lib/processor/data/batch_processor.rb @@ -19,6 +19,7 @@ def fetch_batch @fetcher ||= query.each_slice(batch_size) + # TODO ge...
Add TODO comment to remove .next enumeration
diff --git a/lib/rakuten_web_service/kobo/genre.rb b/lib/rakuten_web_service/kobo/genre.rb index abc1234..def5678 100644 --- a/lib/rakuten_web_service/kobo/genre.rb +++ b/lib/rakuten_web_service/kobo/genre.rb @@ -1,24 +1,15 @@-require 'rakuten_web_service/resource' +require 'rakuten_web_service/genre' module Rakuten...
Define Kogo::Genre class inheriting BaseGenre
diff --git a/app/controllers/email_controller.rb b/app/controllers/email_controller.rb index abc1234..def5678 100644 --- a/app/controllers/email_controller.rb +++ b/app/controllers/email_controller.rb @@ -3,6 +3,7 @@ layout 'no_js' before_filter :ensure_logged_in, only: :preferences_redirect + skip_before_filte...
FIX: Allow users to unsubscribe to digests while not logged in if `login_required` is set to true.
diff --git a/app/controllers/pages_controller.rb b/app/controllers/pages_controller.rb index abc1234..def5678 100644 --- a/app/controllers/pages_controller.rb +++ b/app/controllers/pages_controller.rb @@ -17,6 +17,7 @@ page.update_content(params[:content]) page.save! + cookies['editing'] = false rend...
Set cookie['editing'] to false after mercury update.
diff --git a/app/controllers/users_controller.rb b/app/controllers/users_controller.rb index abc1234..def5678 100644 --- a/app/controllers/users_controller.rb +++ b/app/controllers/users_controller.rb @@ -1,6 +1,7 @@ class UsersController < ApplicationController before_action :set_user, only: [:edit, :update, :d...
Add security level to the user controller Create require_user_owner method to verify who is the current user (if exists in session) and verify too if they can edit the account
diff --git a/app/controllers/users_controller.rb b/app/controllers/users_controller.rb index abc1234..def5678 100644 --- a/app/controllers/users_controller.rb +++ b/app/controllers/users_controller.rb @@ -1,37 +1,6 @@ require_relative 'application_controller' class UsersController < ApplicationController - get '/lo...
Add missed change from UsersController