diff
stringlengths
65
26.7k
message
stringlengths
7
9.92k
diff --git a/app/helpers/load_balancer_helper.rb b/app/helpers/load_balancer_helper.rb index abc1234..def5678 100644 --- a/app/helpers/load_balancer_helper.rb +++ b/app/helpers/load_balancer_helper.rb @@ -21,7 +21,7 @@ def self.display_port_range(r) if r.nil? "nil" - elsif r.size == 0 # rubocop:disable...
Fix rubocop warning in LoadBalancerHelper
diff --git a/db/migrate/20150112212957_create_schools.rb b/db/migrate/20150112212957_create_schools.rb index abc1234..def5678 100644 --- a/db/migrate/20150112212957_create_schools.rb +++ b/db/migrate/20150112212957_create_schools.rb @@ -1,10 +1,14 @@ class CreateSchools < ActiveRecord::Migration def change crea...
Update migration file for schools to add additional fields for new data
diff --git a/spec/helpers/google_analytics_spec.rb b/spec/helpers/google_analytics_spec.rb index abc1234..def5678 100644 --- a/spec/helpers/google_analytics_spec.rb +++ b/spec/helpers/google_analytics_spec.rb @@ -0,0 +1,17 @@+require "spec_helper" +include Nanoc::Toolbox::Helpers::GoogleAnalytics + +describe Nanoc::Too...
Add the spec for the google analytics helper
diff --git a/app/controllers/schools_controller.rb b/app/controllers/schools_controller.rb index abc1234..def5678 100644 --- a/app/controllers/schools_controller.rb +++ b/app/controllers/schools_controller.rb @@ -1,7 +1,6 @@ class SchoolsController < ApplicationController # skip_before_action :verify_authenticity_tok...
REmove commented out code setting all schools to @school
diff --git a/app/controllers/uploads_controller.rb b/app/controllers/uploads_controller.rb index abc1234..def5678 100644 --- a/app/controllers/uploads_controller.rb +++ b/app/controllers/uploads_controller.rb @@ -1,7 +1,9 @@ class UploadsController < ApplicationController def upload file = params[:files].first -...
Make response from upload an array
diff --git a/test/unit/ontology_parser/distributed_test.rb b/test/unit/ontology_parser/distributed_test.rb index abc1234..def5678 100644 --- a/test/unit/ontology_parser/distributed_test.rb +++ b/test/unit/ontology_parser/distributed_test.rb @@ -22,7 +22,7 @@ end should 'found all symbols' do - ...
Update the number of symbols in the ontology
diff --git a/rb/spec/integration/selenium/webdriver/mouse_spec.rb b/rb/spec/integration/selenium/webdriver/mouse_spec.rb index abc1234..def5678 100644 --- a/rb/spec/integration/selenium/webdriver/mouse_spec.rb +++ b/rb/spec/integration/selenium/webdriver/mouse_spec.rb @@ -25,9 +25,7 @@ text = droppable.find_e...
JariBakken: Enable double/context click specs for IE. git-svn-id: 4179480af2c2519a5eb5e1e9b541cbdf5cf27696@13526 07704840-8298-11de-bf8c-fd130f914ac9
diff --git a/app/controllers/accounts_controller.rb b/app/controllers/accounts_controller.rb index abc1234..def5678 100644 --- a/app/controllers/accounts_controller.rb +++ b/app/controllers/accounts_controller.rb @@ -15,6 +15,6 @@ def update @account = Account.find(params[:id]) @account.update based_on: @ac...
Use delayed_job for archive downloading
diff --git a/app/controllers/comments_controller.rb b/app/controllers/comments_controller.rb index abc1234..def5678 100644 --- a/app/controllers/comments_controller.rb +++ b/app/controllers/comments_controller.rb @@ -10,15 +10,23 @@ end def new - @comment = Comment.new + if current_user + @comment = C...
Check if user is logged in before executing certain actions
diff --git a/app/controllers/job_task_controller.rb b/app/controllers/job_task_controller.rb index abc1234..def5678 100644 --- a/app/controllers/job_task_controller.rb +++ b/app/controllers/job_task_controller.rb @@ -1,5 +1,7 @@ class JobTaskController < ApplicationController layout "default" + + before_filter :adm...
r1901: Access control for job task restart/destroy --HG-- branch : moe extra : convert_revision : svn%3A2d28d66d-8d94-df11-8c86-00306ef368cb/trunk/moe%40279
diff --git a/app/controllers/sessions_controller.rb b/app/controllers/sessions_controller.rb index abc1234..def5678 100644 --- a/app/controllers/sessions_controller.rb +++ b/app/controllers/sessions_controller.rb @@ -1,22 +1,20 @@ class SessionsController < ApplicationController - def new end - # def create - ...
Add correct has_secure_password implementation of sessions with Rails 4 and the latest Bcrypt gem methods.
diff --git a/app/controllers/webhooks_controller.rb b/app/controllers/webhooks_controller.rb index abc1234..def5678 100644 --- a/app/controllers/webhooks_controller.rb +++ b/app/controllers/webhooks_controller.rb @@ -1,9 +1,11 @@ class WebhooksController < ApplicationController def mailchimp - user = User.find_by...
Add extra if statement so mailchimp doesn't get pissed off.
diff --git a/core/lib/generators/spree/custom_user/custom_user_generator.rb b/core/lib/generators/spree/custom_user/custom_user_generator.rb index abc1234..def5678 100644 --- a/core/lib/generators/spree/custom_user/custom_user_generator.rb +++ b/core/lib/generators/spree/custom_user/custom_user_generator.rb @@ -2,7 +2,...
Remove unused module include from custom user generator This include exists since this generator was introduced but no method is ever called on that module.
diff --git a/src/controllers/systems_controller.rb b/src/controllers/systems_controller.rb index abc1234..def5678 100644 --- a/src/controllers/systems_controller.rb +++ b/src/controllers/systems_controller.rb @@ -26,8 +26,12 @@ post '/' do system = System.new permit_params - system.save + unless system.s...
Switch status code and response body by validation result
diff --git a/spec/sastrawi_spec.rb b/spec/sastrawi_spec.rb index abc1234..def5678 100644 --- a/spec/sastrawi_spec.rb +++ b/spec/sastrawi_spec.rb @@ -32,4 +32,16 @@ expect((base_form - stemming_result).empty?).to eq(true) end + + it 'should stem "-ku, -mu, -nya" suffixes' do + suffixed_words = %w[jubahku ba...
Add test for "-ku, -mu, -nya" suffixes
diff --git a/spree_temando.gemspec b/spree_temando.gemspec index abc1234..def5678 100644 --- a/spree_temando.gemspec +++ b/spree_temando.gemspec @@ -16,6 +16,7 @@ s.files = Dir["{app,config,db,lib}/**/*"] + ["MIT-LICENSE", "Rakefile", "README.rdoc"] s.test_files = Dir["test/**/*"] + s.add_dependency 'spree_core...
Add spree_core as a dependency
diff --git a/test/form_forms/form_registry_test.rb b/test/form_forms/form_registry_test.rb index abc1234..def5678 100644 --- a/test/form_forms/form_registry_test.rb +++ b/test/form_forms/form_registry_test.rb @@ -10,7 +10,7 @@ FormRegistry['foo'] = form assert_equal FormRegistry['foo'], form assert_...
Fix assertion for Ruby 1.8 which doesn't ship MiniTest
diff --git a/test/integration/test_return_codes.rb b/test/integration/test_return_codes.rb index abc1234..def5678 100644 --- a/test/integration/test_return_codes.rb +++ b/test/integration/test_return_codes.rb @@ -0,0 +1,38 @@+require_relative '../test_helper' + +# NOTE: These tests depend on the OpenLDAP retcode overla...
Add return code integration tests
diff --git a/spec/models/manageiq/providers/hawkular/middleware_manager_spec.rb b/spec/models/manageiq/providers/hawkular/middleware_manager_spec.rb index abc1234..def5678 100644 --- a/spec/models/manageiq/providers/hawkular/middleware_manager_spec.rb +++ b/spec/models/manageiq/providers/hawkular/middleware_manager_spe...
Add a middleware manager spec (transferred from ManageIQ/manageiq@157973577dbd2e7db105e305e25f5ff408907bbd)
diff --git a/lib/three_scale_api/resources/oauth_dev_portal.rb b/lib/three_scale_api/resources/oauth_dev_portal.rb index abc1234..def5678 100644 --- a/lib/three_scale_api/resources/oauth_dev_portal.rb +++ b/lib/three_scale_api/resources/oauth_dev_portal.rb @@ -3,8 +3,8 @@ require 'three_scale_api/resources/default' mo...
Fix resource for OAuth for Devel portal
diff --git a/app/serializers/material_serializer.rb b/app/serializers/material_serializer.rb index abc1234..def5678 100644 --- a/app/serializers/material_serializer.rb +++ b/app/serializers/material_serializer.rb @@ -1,5 +1,6 @@ class MaterialSerializer < ActiveModel::Serializer attributes( + :id, :original_...
Add id attribute to material serializer
diff --git a/Library/Homebrew/test/test_sandbox.rb b/Library/Homebrew/test/test_sandbox.rb index abc1234..def5678 100644 --- a/Library/Homebrew/test/test_sandbox.rb +++ b/Library/Homebrew/test/test_sandbox.rb @@ -25,4 +25,30 @@ end refute_predicate @file, :exist? end + + def test_complains_on_failure + ...
Test that sandbox complains correctly Test that sandbox does not complain about bogus .pyc errors and does complain about other failures. Closes #684.
diff --git a/Casks/intellij-idea.rb b/Casks/intellij-idea.rb index abc1234..def5678 100644 --- a/Casks/intellij-idea.rb +++ b/Casks/intellij-idea.rb @@ -1,6 +1,6 @@ cask :v1 => 'intellij-idea' do - version '15.0' - sha256 'a195493e2c4a1b55f76d9784ef2d8815bffb46d6b4a1b11a8000489a011097b6' + version '15.0.1' + sha256...
Upgrade IntelliJ IDEA to 15.0.1.
diff --git a/virtual.gemspec b/virtual.gemspec index abc1234..def5678 100644 --- a/virtual.gemspec +++ b/virtual.gemspec @@ -1,7 +1,7 @@ # -*- encoding: utf-8 -*- Gem::Specification.new do |s| s.name = 'virtual' - s.version = '0.1.0' + s.version = '0.1.1' s.summary = 'Virtual method declaration' s.descripti...
Package version is increased from 0.1.0 to 0.1.1
diff --git a/benchmarks/class_exec_vs_klass_exec.rb b/benchmarks/class_exec_vs_klass_exec.rb index abc1234..def5678 100644 --- a/benchmarks/class_exec_vs_klass_exec.rb +++ b/benchmarks/class_exec_vs_klass_exec.rb @@ -0,0 +1,43 @@+require 'benchmark/ips' +require 'rspec/support' +require 'rspec/support/with_keywords_whe...
Add bench mark for keywords class exec
diff --git a/app/helpers/application_helper.rb b/app/helpers/application_helper.rb index abc1234..def5678 100644 --- a/app/helpers/application_helper.rb +++ b/app/helpers/application_helper.rb @@ -17,7 +17,7 @@ end def link_header(text, level) - %Q(<h#{level} id="#{text.parameterize}">#{link_to(text.html_sa...
Fix ampersands in link_header helper
diff --git a/app/helpers/switch_user_helper.rb b/app/helpers/switch_user_helper.rb index abc1234..def5678 100644 --- a/app/helpers/switch_user_helper.rb +++ b/app/helpers/switch_user_helper.rb @@ -35,7 +35,7 @@ end def tag_label(user, name) - name.respond_to?(:call) ? name.call(user) : user.send(name) + us...
Revert "select option label can now specify a proc." This reverts commit 66adcf11ab5a5a55777f41fb6e29badd04e7509f.
diff --git a/app/helpers/system_note_helper.rb b/app/helpers/system_note_helper.rb index abc1234..def5678 100644 --- a/app/helpers/system_note_helper.rb +++ b/app/helpers/system_note_helper.rb @@ -7,7 +7,7 @@ 'closed' => 'icon_status_closed', 'time_tracking' => 'icon_stopwatch', 'assignee' => 'icon_user',...
Update MR title change icon
diff --git a/cookbooks/sudo/recipes/default.rb b/cookbooks/sudo/recipes/default.rb index abc1234..def5678 100644 --- a/cookbooks/sudo/recipes/default.rb +++ b/cookbooks/sudo/recipes/default.rb @@ -18,7 +18,7 @@ # package "sudo" do - action :upgrade + action :install end template "/etc/sudoers" do
Change the sudo recipe so it doesn't try to do an upgrade on every run. This takes forever on CentOS Former-commit-id: bf91f36cda6822d668e733832811ad3305067aea [formerly 7f6332604b3c3657d74ac86ae38a0a03f392ed59] [formerly 9aa9e35ec4bd39dfde0f4f71b80ab66b064d17b5 [formerly 2fd6c1c31794e680c19d5d6015d84c02dcd2d3ad [fo...
diff --git a/roboter.gemspec b/roboter.gemspec index abc1234..def5678 100644 --- a/roboter.gemspec +++ b/roboter.gemspec @@ -14,4 +14,9 @@ gem.name = "roboter" gem.require_paths = ["lib"] gem.version = Roboter::VERSION + + gem.add_development_dependency "rspec" + gem.add_development_dependency ...
Add blather, rspec and guard dependencies.
diff --git a/lib/arrthorizer/rspec/matchers.rb b/lib/arrthorizer/rspec/matchers.rb index abc1234..def5678 100644 --- a/lib/arrthorizer/rspec/matchers.rb +++ b/lib/arrthorizer/rspec/matchers.rb @@ -19,7 +19,7 @@ "Expected role #{@role.name} to apply in context #{context.inspect}\nfor user #{user.inspect}, bu...
Move to newer RSpec matcher syntax
diff --git a/Mapzen-ios-sdk.podspec b/Mapzen-ios-sdk.podspec index abc1234..def5678 100644 --- a/Mapzen-ios-sdk.podspec +++ b/Mapzen-ios-sdk.podspec @@ -23,6 +23,6 @@ cs.dependency 'OnTheRoad', '~> 1.0.0-beta' cs.dependency 'Tangram-es', '~> 0.4' cs.source_files = "src/*.swift" - cs.resources = 'images...
Update podspec to include bubble-wrap bundled style
diff --git a/api/app/controllers/v1/analytics_controller.rb b/api/app/controllers/v1/analytics_controller.rb index abc1234..def5678 100644 --- a/api/app/controllers/v1/analytics_controller.rb +++ b/api/app/controllers/v1/analytics_controller.rb @@ -11,7 +11,7 @@ end def page - segment(:page, %w(user_id ...
Add page properties in analytics
diff --git a/lib/onebox/engine/image_onebox.rb b/lib/onebox/engine/image_onebox.rb index abc1234..def5678 100644 --- a/lib/onebox/engine/image_onebox.rb +++ b/lib/onebox/engine/image_onebox.rb @@ -7,7 +7,7 @@ def to_html # Fix Dropbox image links - if /^https:\/\/www.dropbox.com/.match @url + ...
Make dropbox image matching more strict
diff --git a/db/migrate/20170224053931_add_used_column_to_user_invitations.rb b/db/migrate/20170224053931_add_used_column_to_user_invitations.rb index abc1234..def5678 100644 --- a/db/migrate/20170224053931_add_used_column_to_user_invitations.rb +++ b/db/migrate/20170224053931_add_used_column_to_user_invitations.rb @@ ...
Fix error in updating existing user invites
diff --git a/lib/ruboty/gitlab/actions/base.rb b/lib/ruboty/gitlab/actions/base.rb index abc1234..def5678 100644 --- a/lib/ruboty/gitlab/actions/base.rb +++ b/lib/ruboty/gitlab/actions/base.rb @@ -41,7 +41,7 @@ end def search_project - client.projects({ search: given_project }).first + ...
Fix bug; mistake same prefix project name
diff --git a/app/presenters/tree_builder_service_catalog.rb b/app/presenters/tree_builder_service_catalog.rb index abc1234..def5678 100644 --- a/app/presenters/tree_builder_service_catalog.rb +++ b/app/presenters/tree_builder_service_catalog.rb @@ -21,7 +21,7 @@ end def x_get_tree_roots(count_only, _options) - ...
Include :service_templates to remove N+1 query service_templates is loaded here: https://github.com/ManageIQ/manageiq-ui-classic/blob/master/app/presenters/tree_builder_service_catalog.rb#L35
diff --git a/lib/spectrum/config/field_list.rb b/lib/spectrum/config/field_list.rb index abc1234..def5678 100644 --- a/lib/spectrum/config/field_list.rb +++ b/lib/spectrum/config/field_list.rb @@ -10,6 +10,7 @@ __getobj__.values.each do |f| return f if f.uid == uid end + nil en...
Return nil on not found.
diff --git a/PINRemoteImage.podspec b/PINRemoteImage.podspec index abc1234..def5678 100644 --- a/PINRemoteImage.podspec +++ b/PINRemoteImage.podspec @@ -9,12 +9,12 @@ Pod::Spec.new do |s| s.name = "PINRemoteImage" - s.version = "1.0" + s.version = "1.1" s.summary = "A th...
Update podspec for 1.1 release
diff --git a/jekyll-agency.gemspec b/jekyll-agency.gemspec index abc1234..def5678 100644 --- a/jekyll-agency.gemspec +++ b/jekyll-agency.gemspec @@ -1,18 +1,16 @@ Gem::Specification.new do |spec| - spec.name = "jekyll-agency" - spec.version = "1.0.7" - spec.authors = ["Ravi Riley"] - - spec.sum...
Add ruby >=2.5.0 required min version
diff --git a/seo_cms.gemspec b/seo_cms.gemspec index abc1234..def5678 100644 --- a/seo_cms.gemspec +++ b/seo_cms.gemspec @@ -21,5 +21,5 @@ s.add_development_dependency 'sqlite3' s.add_development_dependency 'ancestry', '>= 0', '>= 0' - s.add_development_dependency 'test-unit' + # s.add_development_dependency '...
Remove ancestry from dev gems
diff --git a/Casks/charles.rb b/Casks/charles.rb index abc1234..def5678 100644 --- a/Casks/charles.rb +++ b/Casks/charles.rb @@ -1,6 +1,6 @@ cask :v1 => 'charles' do - version '3.10.2' - sha256 'd68be46d7dc9654b4b3b094a2f451226376d7bf3c5d401aecba082b27e0b8b6a' + version '3.11' + sha256 'b31efe7c80464a92984d7a76e8a4...
Update Charles to version 3.11
diff --git a/app/serializers/sprangular/taxon_serializer.rb b/app/serializers/sprangular/taxon_serializer.rb index abc1234..def5678 100644 --- a/app/serializers/sprangular/taxon_serializer.rb +++ b/app/serializers/sprangular/taxon_serializer.rb @@ -1,6 +1,6 @@ module Sprangular class TaxonSerializer < BaseSerializer...
Use default attributes which allows for easier overriding
diff --git a/plugin/hammer.vim/lib/vim/improvedbuffer.rb b/plugin/hammer.vim/lib/vim/improvedbuffer.rb index abc1234..def5678 100644 --- a/plugin/hammer.vim/lib/vim/improvedbuffer.rb +++ b/plugin/hammer.vim/lib/vim/improvedbuffer.rb @@ -17,11 +17,11 @@ end def basename - File.basename self.name + F...
Make sure we're passing a string to File methods.
diff --git a/mcagents/execute_shell_command.rb b/mcagents/execute_shell_command.rb index abc1234..def5678 100644 --- a/mcagents/execute_shell_command.rb +++ b/mcagents/execute_shell_command.rb @@ -20,9 +20,9 @@ class Execute_shell_command < RPC::Agent action 'execute' do - reply[:exit_code], reply[:...
Fix problem with empty stdout/stderr answer for shell magent Change-Id: I76e2c984bf86aa0df3ec1762df52cb1533ad7665 Closes-Bug: #1322475
diff --git a/spec/battlenetapi_spec.rb b/spec/battlenetapi_spec.rb index abc1234..def5678 100644 --- a/spec/battlenetapi_spec.rb +++ b/spec/battlenetapi_spec.rb @@ -8,10 +8,5 @@ config.region = :eu end end - - it "should escape spaces in realm names" do - c = Battlenet::Client.new({domain: ...
Remove an incorrect endpoint test
diff --git a/spec/bsf/database_spec.rb b/spec/bsf/database_spec.rb index abc1234..def5678 100644 --- a/spec/bsf/database_spec.rb +++ b/spec/bsf/database_spec.rb @@ -34,6 +34,15 @@ end + describe 'method_missing' do + + it 'invocates the method on the Sequel database connection' do + database = described_...
Add method_missing test for Bsf::Database class Add a test to make sure method_missing is working as intended. To do this call a method that should exist on an instance of the Sequel::SQLite::Database class and check that the return value is what we would expect from that call.
diff --git a/assignments/ruby/robot-name/robot-name_test.rb b/assignments/ruby/robot-name/robot-name_test.rb index abc1234..def5678 100644 --- a/assignments/ruby/robot-name/robot-name_test.rb +++ b/assignments/ruby/robot-name/robot-name_test.rb @@ -8,24 +8,22 @@ end def test_name_sticks - skip robot = Ro...
Improve test suite for ruby:robot-name
diff --git a/spec/orm/active_record.rb b/spec/orm/active_record.rb index abc1234..def5678 100644 --- a/spec/orm/active_record.rb +++ b/spec/orm/active_record.rb @@ -1,3 +1,8 @@ ActiveRecord::Migration.verbose = false -ActiveRecord::Migrator.migrate(File.expand_path('../../rails_app/db/migrate/', __FILE__)) +migration...
Fix specs on Rails 5.2
diff --git a/Library/Homebrew/cask/spec/cask/artifact/uninstall_no_zap_spec.rb b/Library/Homebrew/cask/spec/cask/artifact/uninstall_no_zap_spec.rb index abc1234..def5678 100644 --- a/Library/Homebrew/cask/spec/cask/artifact/uninstall_no_zap_spec.rb +++ b/Library/Homebrew/cask/spec/cask/artifact/uninstall_no_zap_spec.rb...
Add test to ensure `Zap` does not have an `uninstall_phase`.
diff --git a/spec/features/guest_can_not_see_dashboard_spec.rb b/spec/features/guest_can_not_see_dashboard_spec.rb index abc1234..def5678 100644 --- a/spec/features/guest_can_not_see_dashboard_spec.rb +++ b/spec/features/guest_can_not_see_dashboard_spec.rb @@ -4,7 +4,7 @@ scenario 'Guests are asked to log in first' d...
Use page object and corresponding matchers rather than looking at URL
diff --git a/spec/unit/facter/haveged_startup_provider_spec.rb b/spec/unit/facter/haveged_startup_provider_spec.rb index abc1234..def5678 100644 --- a/spec/unit/facter/haveged_startup_provider_spec.rb +++ b/spec/unit/facter/haveged_startup_provider_spec.rb @@ -1,26 +1,25 @@ require 'spec_helper' describe 'Facter::Ut...
Update fact testing to use rspec-mock
diff --git a/bosh-dev/lib/bosh/dev/stemcell_rake_methods.rb b/bosh-dev/lib/bosh/dev/stemcell_rake_methods.rb index abc1234..def5678 100644 --- a/bosh-dev/lib/bosh/dev/stemcell_rake_methods.rb +++ b/bosh-dev/lib/bosh/dev/stemcell_rake_methods.rb @@ -1,7 +1,6 @@ require 'bosh/dev/build_from_spec' require 'bosh/dev/stemc...
Remove unused method and require
diff --git a/app/controllers/articles_controller.rb b/app/controllers/articles_controller.rb index abc1234..def5678 100644 --- a/app/controllers/articles_controller.rb +++ b/app/controllers/articles_controller.rb @@ -5,4 +5,8 @@ def index @articles = Article.all end + + def show + @article = Article...
Define show action for articles controller
diff --git a/app/controllers/sessions_controller.rb b/app/controllers/sessions_controller.rb index abc1234..def5678 100644 --- a/app/controllers/sessions_controller.rb +++ b/app/controllers/sessions_controller.rb @@ -3,8 +3,17 @@ end def create + user = User.find_by(name: params[:name]) + if user and user....
Implement login in and out by storing the user_id in the session.
diff --git a/Casks/comma-chameleon.rb b/Casks/comma-chameleon.rb index abc1234..def5678 100644 --- a/Casks/comma-chameleon.rb +++ b/Casks/comma-chameleon.rb @@ -2,6 +2,7 @@ version '0.4.0' sha256 '63d39758bad01bc439b55f53d377121e3d0e6159aef4551058d311033ee49bd8' + # github.com/theodi/comma-chameleon was verifie...
Fix `url` stanza comment for Comma Chameleon.
diff --git a/spec/unit/setting_spec.rb b/spec/unit/setting_spec.rb index abc1234..def5678 100644 --- a/spec/unit/setting_spec.rb +++ b/spec/unit/setting_spec.rb @@ -1,7 +1,21 @@ require 'spec_helper' -class SettingTest < ActiveSupport::TestCase - # test "the truth" do - # assert true - # end +describe Setting do...
Add unit tests or setting
diff --git a/sponges.gemspec b/sponges.gemspec index abc1234..def5678 100644 --- a/sponges.gemspec +++ b/sponges.gemspec @@ -11,7 +11,7 @@ s.homepage = "https://github.com/AF83/sponges" s.summary = "Turn any ruby object in a daemons controlling an army of sponges." s.description = "When I build som...
Add the readme and license files to the gem
diff --git a/spec/unit/endpoint/builds_spec.rb b/spec/unit/endpoint/builds_spec.rb index abc1234..def5678 100644 --- a/spec/unit/endpoint/builds_spec.rb +++ b/spec/unit/endpoint/builds_spec.rb @@ -1,5 +1,42 @@ require 'spec_helper' describe Travis::Api::App::Endpoint::Builds do - it 'has to be tested' + include Tr...
Add specs for pretty print JSON They only check that the response includes `\n`, which should not happen otherwise.
diff --git a/app/decorators/person_decorator.rb b/app/decorators/person_decorator.rb index abc1234..def5678 100644 --- a/app/decorators/person_decorator.rb +++ b/app/decorators/person_decorator.rb @@ -24,6 +24,10 @@ # end def profile_url(size: 'w300') - "#{h.configuration.base_url}#{size}#{object["profile_pat...
Add N/A default profile for missing person profiles
diff --git a/strong_json.gemspec b/strong_json.gemspec index abc1234..def5678 100644 --- a/strong_json.gemspec +++ b/strong_json.gemspec @@ -10,7 +10,7 @@ spec.email = ["matsumoto@soutaro.com"] spec.summary = "Type check JSON objects" spec.description = "Type check JSON objects" - spec.homepage...
Add homepage URL to the gemspec By this change: 1. Users can jump to this repository on GitHub from rubygems.org 2. Maybe users can jump to this repository on GitHub from deppbot
diff --git a/Casks/actprinter.rb b/Casks/actprinter.rb index abc1234..def5678 100644 --- a/Casks/actprinter.rb +++ b/Casks/actprinter.rb @@ -1,6 +1,6 @@ cask :v1 => 'actprinter' do - version '3.2.1' - sha256 '979768faafd99b5714d3397ef7dd29ff085b3f7c7aac59ea6c96c4f15f0ceb6d' + version '3.2.2' + sha256 '6e49ac75f8a66...
Upgrade ACTPrinter for Mac.app to v3.2.2
diff --git a/config/initializers/client_side_validations.rb b/config/initializers/client_side_validations.rb index abc1234..def5678 100644 --- a/config/initializers/client_side_validations.rb +++ b/config/initializers/client_side_validations.rb @@ -18,3 +18,35 @@ %{<div class="field_with_errors">#{html_tag}</div>}....
Customize client_side_validation gem by changed ‘validation_hash[attr] => validation_hash[attr.to_sym]’ << due to value of option_hash return 'Symbol', meanwhile value of validation_hash return 'String'>>
diff --git a/app/validators/schema_validator.rb b/app/validators/schema_validator.rb index abc1234..def5678 100644 --- a/app/validators/schema_validator.rb +++ b/app/validators/schema_validator.rb @@ -28,7 +28,7 @@ attr_reader :payload, :type def schema - @schema || JSON.load(File.read(schema_filepath)) + ...
Use schema gem to find schemas
diff --git a/app/workers/travis_build_killer.rb b/app/workers/travis_build_killer.rb index abc1234..def5678 100644 --- a/app/workers/travis_build_killer.rb +++ b/app/workers/travis_build_killer.rb @@ -10,14 +10,25 @@ if !first_unique_worker? logger.info "#{self.class} is already running, skipping" else ...
Fix issue where TravisBuildKiller blows up when manageiq repo is missing.
diff --git a/spec/features/admin_sends_sms_spec.rb b/spec/features/admin_sends_sms_spec.rb index abc1234..def5678 100644 --- a/spec/features/admin_sends_sms_spec.rb +++ b/spec/features/admin_sends_sms_spec.rb @@ -1,7 +1,11 @@ require 'spec_helper' -describe 'foo' do - it 'foo' do - expect(true).to be_true +descri...
Add test for sending an sms
diff --git a/spec/requests/preview_request_spec.rb b/spec/requests/preview_request_spec.rb index abc1234..def5678 100644 --- a/spec/requests/preview_request_spec.rb +++ b/spec/requests/preview_request_spec.rb @@ -13,7 +13,7 @@ it "renders markdown content" do sign_in rory post preview_path, params: va...
Fix request spec for header id attributes Added the id attributes to the headings in html so we can link directly to section, this spec was updated to include the section name.
diff --git a/spec/support/shared_contexts/aruba.rb b/spec/support/shared_contexts/aruba.rb index abc1234..def5678 100644 --- a/spec/support/shared_contexts/aruba.rb +++ b/spec/support/shared_contexts/aruba.rb @@ -8,7 +8,7 @@ def create_test_files(files, data = 'a') Array(files).each do |s| next if s.to_s[...
Make create_test_files use correct path expansion
diff --git a/appengine/cloudsql/app.rb b/appengine/cloudsql/app.rb index abc1234..def5678 100644 --- a/appengine/cloudsql/app.rb +++ b/appengine/cloudsql/app.rb @@ -17,10 +17,12 @@ require "sinatra" require "sequel" +# [START connect] DB = Sequel.mysql2 user: ENV["MYSQL_USER"], password: ENV...
Add doc region showing connecting to MySQL database
diff --git a/spec/convection/model/template/resource/aws_efs_file_system_spec.rb b/spec/convection/model/template/resource/aws_efs_file_system_spec.rb index abc1234..def5678 100644 --- a/spec/convection/model/template/resource/aws_efs_file_system_spec.rb +++ b/spec/convection/model/template/resource/aws_efs_file_system...
Fix lint errors in tests.
diff --git a/lib/georgia_mailer.rb b/lib/georgia_mailer.rb index abc1234..def5678 100644 --- a/lib/georgia_mailer.rb +++ b/lib/georgia_mailer.rb @@ -10,12 +10,14 @@ Georgia.navigation += %w(messages) Georgia.permissions.merge!(inbox: { - read_messages: { guest: false, contributor: false, editor: true...
Add communications role for messages
diff --git a/lib/grease/adapter.rb b/lib/grease/adapter.rb index abc1234..def5678 100644 --- a/lib/grease/adapter.rb +++ b/lib/grease/adapter.rb @@ -7,8 +7,9 @@ def call(input) context = input[:environment].context_class.new(input) template = @engine.new { input[:data] } - output = template.rende...
Fix TypeError raised by ActiveSupport::SafeBuffer
diff --git a/has_public_id.gemspec b/has_public_id.gemspec index abc1234..def5678 100644 --- a/has_public_id.gemspec +++ b/has_public_id.gemspec @@ -17,7 +17,7 @@ s.test_files = Dir["test/**/*"] s.licenses = ['MIT'] - s.add_dependency "rails", "~> 4.0" + s.add_dependency "rails", "~> 5.0" s.add_develop...
Update rails restriction to 5
diff --git a/app/controllers/admin/companies/contacts_controller.rb b/app/controllers/admin/companies/contacts_controller.rb index abc1234..def5678 100644 --- a/app/controllers/admin/companies/contacts_controller.rb +++ b/app/controllers/admin/companies/contacts_controller.rb @@ -3,6 +3,6 @@ actions :index, :show ...
Order company contacts by newer first
diff --git a/lib/tasks/router.rake b/lib/tasks/router.rake index abc1234..def5678 100644 --- a/lib/tasks/router.rake +++ b/lib/tasks/router.rake @@ -12,6 +12,7 @@ task :register_routes => :router_environment do @router_api.add_route('/guidance/employment-income-manual', 'prefix', 'manuals-frontend') + @rout...
Fix for immigration placeholder manual 404ing
diff --git a/lib/webrat/sinatra.rb b/lib/webrat/sinatra.rb index abc1234..def5678 100644 --- a/lib/webrat/sinatra.rb +++ b/lib/webrat/sinatra.rb @@ -5,11 +5,13 @@ module Webrat class SinatraSession < RackSession #:nodoc: include Sinatra::Test::Methods + + attr_reader :request, :response %w(get hea...
Allow accessing the request and response from SinatraSession
diff --git a/support/go_build.rb b/support/go_build.rb index abc1234..def5678 100644 --- a/support/go_build.rb +++ b/support/go_build.rb @@ -12,7 +12,8 @@ GO_ENV = { 'GOPATH' => BUILD_DIR, - 'GO15VENDOREXPERIMENT' => '1' + 'GO15VENDOREXPERIMENT' => '1', + 'GO111MODULE' => 'off' }.freeze def cr...
Set Go111MODULE to 'off' during compilation Given more to the Go community moves to Go modules, one might default to GO111MODULE to on in their environment. If this is done, this project fails to compile. By setting the environment for the compilation this is fixed.
diff --git a/config/environments/development.rb b/config/environments/development.rb index abc1234..def5678 100644 --- a/config/environments/development.rb +++ b/config/environments/development.rb @@ -10,7 +10,7 @@ config.assets.compress = false config.assets.debug = true config.cache_classes = false - config....
Change the cache store to a memory store so that caching will be performed if it is turned on
diff --git a/db/migrate/20120809184458_longer_url_fields.rb b/db/migrate/20120809184458_longer_url_fields.rb index abc1234..def5678 100644 --- a/db/migrate/20120809184458_longer_url_fields.rb +++ b/db/migrate/20120809184458_longer_url_fields.rb @@ -0,0 +1,11 @@+class LongerUrlFields < ActiveRecord::Migration + def up ...
Expand URL fields from 255 to 2048 * discussions and pages
diff --git a/src/controllers/systems_controller.rb b/src/controllers/systems_controller.rb index abc1234..def5678 100644 --- a/src/controllers/systems_controller.rb +++ b/src/controllers/systems_controller.rb @@ -23,4 +23,11 @@ get '/:id' do json System.find(params[:id]) end + + post '/' do + system = Sys...
Add API as "POST /systems" to create system entry.
diff --git a/test/test_helper.rb b/test/test_helper.rb index abc1234..def5678 100644 --- a/test/test_helper.rb +++ b/test/test_helper.rb @@ -4,6 +4,8 @@ require_relative "../test/dummy/config/environment" ActiveRecord::Migrator.migrations_paths = [File.expand_path("../test/dummy/db/migrate", __dir__)] require "rails/...
Make debugger available in testing
diff --git a/core/app/models/spree/log_entry.rb b/core/app/models/spree/log_entry.rb index abc1234..def5678 100644 --- a/core/app/models/spree/log_entry.rb +++ b/core/app/models/spree/log_entry.rb @@ -1,5 +1,16 @@ module Spree class LogEntry < ActiveRecord::Base belongs_to :source, :polymorphic => true + + #...
Save LogEntry records if they are being rolled back Related to #1767
diff --git a/lib/react_on_rails/git_utils.rb b/lib/react_on_rails/git_utils.rb index abc1234..def5678 100644 --- a/lib/react_on_rails/git_utils.rb +++ b/lib/react_on_rails/git_utils.rb @@ -2,8 +2,8 @@ module GitUtils def self.uncommitted_changes?(message_handler) return false if ENV["COVERAGE"] - sta...
Check uncommited code in a project.
diff --git a/app/controllers/problem_reports_controller.rb b/app/controllers/problem_reports_controller.rb index abc1234..def5678 100644 --- a/app/controllers/problem_reports_controller.rb +++ b/app/controllers/problem_reports_controller.rb @@ -17,7 +17,7 @@ end def current_user_params - if logged_in? + if...
Fix report problem form for readonly user
diff --git a/core/lib/spree/localized_number.rb b/core/lib/spree/localized_number.rb index abc1234..def5678 100644 --- a/core/lib/spree/localized_number.rb +++ b/core/lib/spree/localized_number.rb @@ -8,7 +8,9 @@ separator, delimiter = I18n.t([:'number.currency.format.separator', :'number.currency.format.delimite...
Fix of bug in `Spree::LocalizedNumber.parse`, which mangles object passed as an argument.
diff --git a/test/config_test.rb b/test/config_test.rb index abc1234..def5678 100644 --- a/test/config_test.rb +++ b/test/config_test.rb @@ -0,0 +1,9 @@+require 'minitest/autorun' +require_relative '../lib/tritium/config' + +class ConfigTest < MiniTest::Unit::TestCase + + def test_functional_location + assert File....
Write a test for the functional_test_location
diff --git a/picturefill.gemspec b/picturefill.gemspec index abc1234..def5678 100644 --- a/picturefill.gemspec +++ b/picturefill.gemspec @@ -16,4 +16,8 @@ gem.executables = gem.files.grep(%r{^bin/}).map{ |f| File.basename(f) } gem.test_files = gem.files.grep(%r{^(test|spec|features)/}) gem.require_paths = ...
Add spec dependencies to gemspec
diff --git a/examples/watir/features/steps/stories_steps.rb b/examples/watir/features/steps/stories_steps.rb index abc1234..def5678 100644 --- a/examples/watir/features/steps/stories_steps.rb +++ b/examples/watir/features/steps/stories_steps.rb @@ -9,7 +9,7 @@ Watir::Browser = Watir::IE when /java/ require 'celer...
Make Watir example run on Celerity again (broken by 9d00123).
diff --git a/lib/tasks/octopress_import.rake b/lib/tasks/octopress_import.rake index abc1234..def5678 100644 --- a/lib/tasks/octopress_import.rake +++ b/lib/tasks/octopress_import.rake @@ -25,7 +25,7 @@ paths.each do |name| album_data = YAML.load_file(File.join(root_path, name, index_filename)) photo ...
Fix album import error message
diff --git a/test/test_helper.rb b/test/test_helper.rb index abc1234..def5678 100644 --- a/test/test_helper.rb +++ b/test/test_helper.rb @@ -6,7 +6,7 @@ $:.unshift File.expand_path("../../lib") require 'beaneater' require 'timeout' -require 'mocha' +require 'mocha/setup' rescue require 'mocha' require 'json' clas...
Fix mocha initialization deprecation warning Maintains compatability with all versions of mocha
diff --git a/test/test_helper.rb b/test/test_helper.rb index abc1234..def5678 100644 --- a/test/test_helper.rb +++ b/test/test_helper.rb @@ -1,8 +1,8 @@+require 'coveralls' +Coveralls.wear! + require 'ruby-bbcode' require "minitest/autorun" -require 'coveralls' - -Coveralls.wear! # This hack allows us to make all ...
Make sure coveralls is initialized before anything else
diff --git a/test/test_helper.rb b/test/test_helper.rb index abc1234..def5678 100644 --- a/test/test_helper.rb +++ b/test/test_helper.rb @@ -19,4 +19,9 @@ ActiveRecord::Migrator.migrate File.expand_path("../dummy/db/migrate/", __FILE__) # Load support files -Dir["#{File.dirname(__FILE__)}/support/**/*.rb"].each { |f...
Clean mongo db before running tests
diff --git a/spec/unit/veritas/relation/materialized/class_methods/new_spec.rb b/spec/unit/veritas/relation/materialized/class_methods/new_spec.rb index abc1234..def5678 100644 --- a/spec/unit/veritas/relation/materialized/class_methods/new_spec.rb +++ b/spec/unit/veritas/relation/materialized/class_methods/new_spec.rb...
Add spec for direction coercion in a materialized relation
diff --git a/lib/doorkeeper_sso_client/mixins/controller_helpers.rb b/lib/doorkeeper_sso_client/mixins/controller_helpers.rb index abc1234..def5678 100644 --- a/lib/doorkeeper_sso_client/mixins/controller_helpers.rb +++ b/lib/doorkeeper_sso_client/mixins/controller_helpers.rb @@ -9,11 +9,10 @@ unless option...
Use superclassing instead of alias method as it breaks loading (routes defined way later)
diff --git a/lib/array_cartesian_product.rb b/lib/array_cartesian_product.rb index abc1234..def5678 100644 --- a/lib/array_cartesian_product.rb +++ b/lib/array_cartesian_product.rb @@ -17,7 +17,7 @@ end def minimum_length_cartesian_terms(b) - carts = self.cartesian_product(b).map { |a| a.flatten.uniq }.uniq +...
Fix cartesian product to sort terms to avoid dups like [a,b],[b,a]
diff --git a/lib/coverband/utils/railtie.rb b/lib/coverband/utils/railtie.rb index abc1234..def5678 100644 --- a/lib/coverband/utils/railtie.rb +++ b/lib/coverband/utils/railtie.rb @@ -2,6 +2,18 @@ Coverband.eager_loading_coverage! module Coverband + module RailsEagerLoad + def eager_load! + Coverband.confi...
Set to eager_loading when rails eager_load! called
diff --git a/lib/netsuite/support/fields.rb b/lib/netsuite/support/fields.rb index abc1234..def5678 100644 --- a/lib/netsuite/support/fields.rb +++ b/lib/netsuite/support/fields.rb @@ -60,13 +60,6 @@ read_only_fields << name_sym field name end - - # a bit of trickery: this is for cl...
Remove class inheritance instance variable hack
diff --git a/lib/refinery/tasks/refinery.rb b/lib/refinery/tasks/refinery.rb index abc1234..def5678 100644 --- a/lib/refinery/tasks/refinery.rb +++ b/lib/refinery/tasks/refinery.rb @@ -2,7 +2,7 @@ # So here, we find them (if there are any) and include them into rake. extra_rake_tasks = [] if defined?(Refinery) && Ref...
Fix pathname because of different interface in 1.9.x
diff --git a/lib/tasks/mnemosyne/clean.rake b/lib/tasks/mnemosyne/clean.rake index abc1234..def5678 100644 --- a/lib/tasks/mnemosyne/clean.rake +++ b/lib/tasks/mnemosyne/clean.rake @@ -19,9 +19,9 @@ end ActiveRecord::Base.connection.execute <<~SQL - SELECT drop_chunks(#{cutoff}, 'traces', NULL); - ...
Use another internal impl as drop_chunks does not accept BIGINT
diff --git a/spec/spec_helper.rb b/spec/spec_helper.rb index abc1234..def5678 100644 --- a/spec/spec_helper.rb +++ b/spec/spec_helper.rb @@ -4,6 +4,6 @@ RSpec.configure do |c| c.before(:each) do redis = Forgetsy.redis - redis.flushdb + redis.redis.flushdb # Avoid blind passthrough end end
Fix redis-namespace blind passthrough deprecation