diff
stringlengths
65
26.7k
message
stringlengths
7
9.92k
diff --git a/lib/hide/server.rb b/lib/hide/server.rb index abc1234..def5678 100644 --- a/lib/hide/server.rb +++ b/lib/hide/server.rb @@ -22,6 +22,7 @@ post '/update' do begin + STDERR.puts "Starting the update process..." json = Yajl::Parser.parse(params[:payload]) before, after = ...
Print debug info at the beginning of the /update process
diff --git a/lib/library_hlb.rb b/lib/library_hlb.rb index abc1234..def5678 100644 --- a/lib/library_hlb.rb +++ b/lib/library_hlb.rb @@ -8,7 +8,7 @@ module Library::HLB class IllegalLC < ArgumentError;end - SOURCE_URL = 'https://www.lib.umich.edu/browse/categories/xml.php' + SOURCE_URL = ENV['HLB_XML_ENDPOINT'] ...
Allow ENV['HLB_XML_ENDPOINT'] to override URL
diff --git a/lib/polyamorous.rb b/lib/polyamorous.rb index abc1234..def5678 100644 --- a/lib/polyamorous.rb +++ b/lib/polyamorous.rb @@ -5,7 +5,6 @@ JoinDependency = ::ActiveRecord::Associations::JoinDependency JoinAssociation = ::ActiveRecord::Associations::JoinDependency::JoinAssociation - JoinBase = :...
Remove unused constant alias for `JoinBase` `JoinBase#active_record` no longer exist since Rails 4.0. See https://github.com/rails/rails/pull/10151
diff --git a/lib/rb-readline.rb b/lib/rb-readline.rb index abc1234..def5678 100644 --- a/lib/rb-readline.rb +++ b/lib/rb-readline.rb @@ -2,6 +2,6 @@ # It forces require of bundled readline instead of any already existing # in your Ruby installation. It will avoid any possible warning caused # by double require. -unle...
Check against RbReadline been defined Since other projects might have readline.rb files loaded before. That check was stupid. (I need to stop coding late at night)
diff --git a/messaging.gemspec b/messaging.gemspec index abc1234..def5678 100644 --- a/messaging.gemspec +++ b/messaging.gemspec @@ -1,7 +1,7 @@ # -*- encoding: utf-8 -*- Gem::Specification.new do |s| s.name = 'evt-messaging' - s.version = '1.3.0.2' + s.version = '1.3.1.0' s.summary = 'Common primitives for pl...
Package version is increased from 1.3.0.2 to 1.3.1.0
diff --git a/config/routes.rb b/config/routes.rb index abc1234..def5678 100644 --- a/config/routes.rb +++ b/config/routes.rb @@ -5,5 +5,5 @@ resources :builds, only: [:index, :show, :create, :update, :destroy] end - resources :events, only: :index + resources :events, only: :index if Rails.configuration.cach...
Enable /events endpoints under cache_classes
diff --git a/config/routes.rb b/config/routes.rb index abc1234..def5678 100644 --- a/config/routes.rb +++ b/config/routes.rb @@ -1,3 +1,9 @@-Rails.application.routes.prepend do - post "operator/:queue" => "operator/messages#create", :as => :process_message +if Operator::Engine.respond_to?(:routes) + Operator::Engine....
Make the gem mountable in rails with `mount Operator::Engine => '/operator'`
diff --git a/zip-zip.gemspec b/zip-zip.gemspec index abc1234..def5678 100644 --- a/zip-zip.gemspec +++ b/zip-zip.gemspec @@ -19,7 +19,8 @@ spec.require_paths = ['lib'] spec.add_runtime_dependency 'rubyzip', '>= 1.0.0' - spec.add_development_dependency 'bundler', '~> 1.6' + spec.add_development_dependency 'bund...
Add test-unit as a development dependency And remove versions
diff --git a/rufus-scheduler.gemspec b/rufus-scheduler.gemspec index abc1234..def5678 100644 --- a/rufus-scheduler.gemspec +++ b/rufus-scheduler.gemspec @@ -21,9 +21,11 @@ #s.files = `git ls-files`.split("\n") s.files = Dir[ + 'README.{md,txt}', 'Makefile', 'lib/**/*.rb', #'spec/**/*.rb', 'test/**/*...
Make .gemspec {.md,.txt} inclusion more strict
diff --git a/activerecord/test/cases/query_logs_formatter_test.rb b/activerecord/test/cases/query_logs_formatter_test.rb index abc1234..def5678 100644 --- a/activerecord/test/cases/query_logs_formatter_test.rb +++ b/activerecord/test/cases/query_logs_formatter_test.rb @@ -7,7 +7,7 @@ assert_raises(ArgumentError) do...
Address `warning: mismatched indentations` at test_factory_invalid_formatter This commit addresses the `warning: mismatched indentations` below. ```ruby $ bundle exec ruby -w -Itest test/cases/query_logs_formatter_test.rb -n test_factory_invalid_formatter test/cases/query_logs_formatter_test.rb:10: warning: mismatche...
diff --git a/app/helpers/application_helper/button/basic_image.rb b/app/helpers/application_helper/button/basic_image.rb index abc1234..def5678 100644 --- a/app/helpers/application_helper/button/basic_image.rb +++ b/app/helpers/application_helper/button/basic_image.rb @@ -1,7 +1,6 @@ class ApplicationHelper::Button::Ba...
Use x_node instead of inspecting sandbox
diff --git a/app/models/login_page.rb b/app/models/login_page.rb index abc1234..def5678 100644 --- a/app/models/login_page.rb +++ b/app/models/login_page.rb @@ -1,5 +1,5 @@ class LoginPage < Obj - attribute :title, :string - attribute :body, :widgetlist + attribute :title, :string + attribute :body, :w...
Tweak indent in LoginPage model
diff --git a/bm/bm_template_parse.rb b/bm/bm_template_parse.rb index abc1234..def5678 100644 --- a/bm/bm_template_parse.rb +++ b/bm/bm_template_parse.rb @@ -0,0 +1,17 @@+require 'krypt' +require_relative 'resources' +require 'stringio' +require 'openssl' +require 'benchmark' + +Benchmark.bm do |bm| + + cert = Resource...
Add benchmark for Krypt::X509::Certificate parsing
diff --git a/brain/lib/crm_neuron.rb b/brain/lib/crm_neuron.rb index abc1234..def5678 100644 --- a/brain/lib/crm_neuron.rb +++ b/brain/lib/crm_neuron.rb @@ -11,6 +11,6 @@ futuresimple_token = message.user["profile"]["futuresimple_token"] session = Pipejump::Session.new token: futuresimple_token contact = ...
[BRAIN] Use phone/email address from data rather than static in CRM neuron
diff --git a/Argo.podspec b/Argo.podspec index abc1234..def5678 100644 --- a/Argo.podspec +++ b/Argo.podspec @@ -1,6 +1,6 @@ Pod::Spec.new do |spec| spec.name = 'Argo' - spec.version = '0.2.2' + spec.version = '0.3.2' spec.summary = 'Functional JSON parsing library for Swift.' spec.homepage = 'https://github...
Update Podspec with Runes dependency Since Runes is now available in CocoaPods Trunk, we can depend on it here and bump the version to the most recent.
diff --git a/functional_ruby.gemspec b/functional_ruby.gemspec index abc1234..def5678 100644 --- a/functional_ruby.gemspec +++ b/functional_ruby.gemspec @@ -25,17 +25,6 @@ s.require_paths = ['lib'] s.required_ruby_version = '>= 1.9.2' - s.post_install_message = <<-MSG - hello() -> io:format("Hello, World...
Remove (unnecessary) gem post-install message.
diff --git a/cookbooks/lib/languages/python_spec.rb b/cookbooks/lib/languages/python_spec.rb index abc1234..def5678 100644 --- a/cookbooks/lib/languages/python_spec.rb +++ b/cookbooks/lib/languages/python_spec.rb @@ -1,6 +1,6 @@+include Support::Python + describe 'python environment' do - include Support::Python - ...
Include python support bits in the right place
diff --git a/Casks/appcode.rb b/Casks/appcode.rb index abc1234..def5678 100644 --- a/Casks/appcode.rb +++ b/Casks/appcode.rb @@ -1,6 +1,6 @@ cask :v1 => 'appcode' do - version '3.1.3' - sha256 '36a7429ae57d7855a83b2d7d461c3ccf2d61b125249c532a254e6625746561c6' + version '3.1.4' + sha256 'ca623c106337dd355732200d25f2...
Update AppCode to version 3.1.4 This commit also updates the SHA for the download.
diff --git a/Casks/aquaskk.rb b/Casks/aquaskk.rb index abc1234..def5678 100644 --- a/Casks/aquaskk.rb +++ b/Casks/aquaskk.rb @@ -3,6 +3,8 @@ sha256 'fd29284c76ddc361506ad887be3868bc8e020d6424d818e5365d7d9148d19fcc' url "https://github.com/codefirst/aquaskk/releases/download/#{version}/AquaSKK-#{version}.dmg" + ...
Add an appcast to AquaSKK's cask
diff --git a/post-processing.rb b/post-processing.rb index abc1234..def5678 100644 --- a/post-processing.rb +++ b/post-processing.rb @@ -9,6 +9,7 @@ # line filters line.gsub!(/\s*\n$/, "\n") line.gsub!("'", '"') + line.gsub!('u"', '"') buffer += line end
Remove all the pesky u"..." in comments generated by codegen.py
diff --git a/db/migrate/20200103121539_create_gdata_favorites.rb b/db/migrate/20200103121539_create_gdata_favorites.rb index abc1234..def5678 100644 --- a/db/migrate/20200103121539_create_gdata_favorites.rb +++ b/db/migrate/20200103121539_create_gdata_favorites.rb @@ -0,0 +1,12 @@+# frozen_string_literal: true + +class...
Add migration to create gdata_favorites
diff --git a/DeskAPIClient.podspec b/DeskAPIClient.podspec index abc1234..def5678 100644 --- a/DeskAPIClient.podspec +++ b/DeskAPIClient.podspec @@ -5,7 +5,7 @@ s.license = { :type => 'BSD 3-Clause', :file => 'LICENSE.txt' } s.homepage = "https://github.com/forcedotcom/DeskApiClient-ObjC" s.author ...
Change pod spec to point to ticket branch.
diff --git a/db/seeds.rb b/db/seeds.rb index abc1234..def5678 100644 --- a/db/seeds.rb +++ b/db/seeds.rb @@ -1,5 +1,5 @@ #Create Admin For the Site -User.create(email:'nzeplowitz@gmail.com', name: 'admin', access: 'admin') +User.create(email:'nzeplowitz@gmail.com', name: 'Nathan Zeplowitz', access: 'admin') #Create ...
Fix Seed to Check New Features
diff --git a/db/seeds.rb b/db/seeds.rb index abc1234..def5678 100644 --- a/db/seeds.rb +++ b/db/seeds.rb @@ -8,6 +8,7 @@ user = User.find_by email:'foo@bar.com' user = User.create! email:'foo@bar.com', password:'12345678' unless user +user.update_attributes(admin: true) event = Event.find_or_create_by! name...
Make seed user an admin
diff --git a/db/seeds.rb b/db/seeds.rb index abc1234..def5678 100644 --- a/db/seeds.rb +++ b/db/seeds.rb @@ -0,0 +1,35 @@+ +city_models = {} +county_models = {} +state_models = {} + +f = File.new(File.dirname(__FILE__) + '/../db/seeds.rb') +f.each do |line| + + fields = line.split(/\|\|/) + next if fields.size != 6...
Add seed data based on data in text file.
diff --git a/core/app/interactors/interactors/groups/create.rb b/core/app/interactors/interactors/groups/create.rb index abc1234..def5678 100644 --- a/core/app/interactors/interactors/groups/create.rb +++ b/core/app/interactors/interactors/groups/create.rb @@ -0,0 +1,31 @@+module Interactors + module Groups + class...
Create interactor for group creation
diff --git a/db/seeds.rb b/db/seeds.rb index abc1234..def5678 100644 --- a/db/seeds.rb +++ b/db/seeds.rb @@ -8,7 +8,7 @@ constant = Constants.create \ :site_title => "Everyday City People", - :goal => 1000 + :goal => 10 p = Petition.create :title => "Bro Code #2345207", :statement => "No fucking bitches befor...
Add new petition and resident for testing
diff --git a/db/seeds.rb b/db/seeds.rb index abc1234..def5678 100644 --- a/db/seeds.rb +++ b/db/seeds.rb @@ -14,6 +14,6 @@ end -session = Session.create(duration: 60, pause_time: 30, work_time: 30, user1_driver_time: 15, user2_driver_time: 15, user1: 2, user2: 1) +session = Session.create(duration: 60, pause_time: ...
Fix Session Created in Seed
diff --git a/ivy-serializers.gemspec b/ivy-serializers.gemspec index abc1234..def5678 100644 --- a/ivy-serializers.gemspec +++ b/ivy-serializers.gemspec @@ -20,5 +20,5 @@ spec.add_development_dependency 'json-schema-rspec', '~> 0.0.4' spec.add_development_dependency 'rake' spec.add_development_dependency 'rspec...
Update simplecov requirement from ~> 0.18.5 to ~> 0.19.0 Updates the requirements on [simplecov](https://github.com/simplecov-ruby/simplecov) to permit the latest version. - [Release notes](https://github.com/simplecov-ruby/simplecov/releases) - [Changelog](https://github.com/simplecov-ruby/simplecov/blob/main/CHANGEL...
diff --git a/test/bank-account-statement_test.rb b/test/bank-account-statement_test.rb index abc1234..def5678 100644 --- a/test/bank-account-statement_test.rb +++ b/test/bank-account-statement_test.rb @@ -4,7 +4,7 @@ describe "BankAccountStatement::VERSION" do it "uses major.minor.patch" do - ::BankAccountState...
Fix warning test ambiguous / .
diff --git a/lib/vendorificator/hooks/chef_cookbook.rb b/lib/vendorificator/hooks/chef_cookbook.rb index abc1234..def5678 100644 --- a/lib/vendorificator/hooks/chef_cookbook.rb +++ b/lib/vendorificator/hooks/chef_cookbook.rb @@ -16,7 +16,7 @@ next if ignored.include?(name) work_dirs = Vendorificator:...
Use File.expand_path for 1.8.7 compat.
diff --git a/config/initializers/messaging.rb b/config/initializers/messaging.rb index abc1234..def5678 100644 --- a/config/initializers/messaging.rb +++ b/config/initializers/messaging.rb @@ -1,11 +1,13 @@ # This configuration is suitable for development, it should be managed by puppet -# in production. +# in product...
Use the correct client name
diff --git a/lib/capybara/rails.rb b/lib/capybara/rails.rb index abc1234..def5678 100644 --- a/lib/capybara/rails.rb +++ b/lib/capybara/rails.rb @@ -2,6 +2,12 @@ require 'capybara/dsl' Capybara.app = Rack::Builder.new do + # Work around an issue where rails allows concurrency in test mode even though eager_load + ...
Use Rack::Lock to prevent concurrency when eager_load is false
diff --git a/db/migrate/20160424000002_create_external_sync.rb b/db/migrate/20160424000002_create_external_sync.rb index abc1234..def5678 100644 --- a/db/migrate/20160424000002_create_external_sync.rb +++ b/db/migrate/20160424000002_create_external_sync.rb @@ -9,7 +9,7 @@ t.timestamps null: false end ad...
Fixed: Index name 'index_external_syncs_on_source_and_source_id_and_object_and_o_id' on table 'external_syncs' is too long; the limit is 63 characters.
diff --git a/test/system/methods/with_no_args/returning_nil/output-truth/SUITE.rb b/test/system/methods/with_no_args/returning_nil/output-truth/SUITE.rb index abc1234..def5678 100644 --- a/test/system/methods/with_no_args/returning_nil/output-truth/SUITE.rb +++ b/test/system/methods/with_no_args/returning_nil/output-tr...
Fix pattern for finding test files
diff --git a/unpoly-rails.gemspec b/unpoly-rails.gemspec index abc1234..def5678 100644 --- a/unpoly-rails.gemspec +++ b/unpoly-rails.gemspec @@ -22,4 +22,7 @@ spec.add_dependency 'memoized' spec.add_development_dependency "bundler", "~> 1.3" spec.add_development_dependency "rake" + + # We use Module#prepend + ...
Add minimum Ruby version in gemspec
diff --git a/spec/lib/chamber/commands/secure_spec.rb b/spec/lib/chamber/commands/secure_spec.rb index abc1234..def5678 100644 --- a/spec/lib/chamber/commands/secure_spec.rb +++ b/spec/lib/chamber/commands/secure_spec.rb @@ -5,27 +5,31 @@ module Chamber module Commands describe Secure do - let(:rootpath) ...
Tests: Fix spec that wasn't cleaning up after itself if it failed
diff --git a/spec/lib/chamber/commands/secure_spec.rb b/spec/lib/chamber/commands/secure_spec.rb index abc1234..def5678 100644 --- a/spec/lib/chamber/commands/secure_spec.rb +++ b/spec/lib/chamber/commands/secure_spec.rb @@ -5,27 +5,31 @@ module Chamber module Commands describe Secure do - let(:rootpath) ...
Tests: Fix spec that wasn't cleaning up after itself if it failed
diff --git a/spec/spec_helper_acceptance.rb b/spec/spec_helper_acceptance.rb index abc1234..def5678 100644 --- a/spec/spec_helper_acceptance.rb +++ b/spec/spec_helper_acceptance.rb @@ -18,6 +18,7 @@ # Install module and dependencies hosts.each do |host| copy_module_to(host, source: proj_root, module_nam...
Add missing dependency for Beaker tests
diff --git a/core/exception/interrupt_spec.rb b/core/exception/interrupt_spec.rb index abc1234..def5678 100644 --- a/core/exception/interrupt_spec.rb +++ b/core/exception/interrupt_spec.rb @@ -33,3 +33,19 @@ end end end + +describe "Interrupt" do + # This spec is basically the same as above, + # but it does n...
Add extra spec for the default SIGINT handler raising Interrupt
diff --git a/spec/factories.rb b/spec/factories.rb index abc1234..def5678 100644 --- a/spec/factories.rb +++ b/spec/factories.rb @@ -13,6 +13,16 @@ context 'Quote context' language 'english' user + + factory :quote_with_photos do + ignore do + photos_count 1 + end + + after(:creat...
Add factory :quote_with_photos, nice DSL
diff --git a/lib/airbrake/rails/middleware/exceptions_catcher.rb b/lib/airbrake/rails/middleware/exceptions_catcher.rb index abc1234..def5678 100644 --- a/lib/airbrake/rails/middleware/exceptions_catcher.rb +++ b/lib/airbrake/rails/middleware/exceptions_catcher.rb @@ -17,7 +17,7 @@ controller = env['action_co...
Fix Airbrake so it actually reports data.
diff --git a/lib/metasploit_data_models/db_manager/db_objects.rb b/lib/metasploit_data_models/db_manager/db_objects.rb index abc1234..def5678 100644 --- a/lib/metasploit_data_models/db_manager/db_objects.rb +++ b/lib/metasploit_data_models/db_manager/db_objects.rb @@ -1,45 +1,19 @@ module Msf - ## - # - # This m...
Remove old connection flushing code (triggers warnings in AR 3.2)
diff --git a/lib/vagrant/smartos/zones/commands/multi_command.rb b/lib/vagrant/smartos/zones/commands/multi_command.rb index abc1234..def5678 100644 --- a/lib/vagrant/smartos/zones/commands/multi_command.rb +++ b/lib/vagrant/smartos/zones/commands/multi_command.rb @@ -29,7 +29,7 @@ command_method = subcomma...
Fix issue with undefined local variable or method `ui'
diff --git a/test/gtk_overrides_test.rb b/test/gtk_overrides_test.rb index abc1234..def5678 100644 --- a/test/gtk_overrides_test.rb +++ b/test/gtk_overrides_test.rb @@ -1,4 +1,5 @@ require File.expand_path('test_helper.rb', File.dirname(__FILE__)) +require 'gir_ffi/overrides/gtk' class GtkOverridesTest < MiniTest::S...
Make sure overrides file for Gtk has been required in tests.
diff --git a/test/test_ebs_name_sync.rb b/test/test_ebs_name_sync.rb index abc1234..def5678 100644 --- a/test/test_ebs_name_sync.rb +++ b/test/test_ebs_name_sync.rb @@ -8,4 +8,8 @@ def test_that_it_is_a_class assert_equal EbsNameSync.class, Class end + + def test_that_it_has_fog_required + assert defined?(...
Test if fog is required
diff --git a/test/unit/donation_test.rb b/test/unit/donation_test.rb index abc1234..def5678 100644 --- a/test/unit/donation_test.rb +++ b/test/unit/donation_test.rb @@ -7,6 +7,7 @@ assert_not_nil d.amount assert d.amount > 0 assert d.amount < Rails.application.config.max_donation + assert_not_equal d.a...
Test Donation.amount set to randomly generated float instead of integer Not the best test, will have false failures every so often
diff --git a/lib/ember_cli/engine.rb b/lib/ember_cli/engine.rb index abc1234..def5678 100644 --- a/lib/ember_cli/engine.rb +++ b/lib/ember_cli/engine.rb @@ -1,10 +1,7 @@ module EmberCli class Engine < Rails::Engine initializer "ember-cli-rails.setup" do - require "ember_cli/ember_controller" require...
Fix autoload deprecation in Rails 6 After upgrading an application to Rails 6, I noticed the following deprecation warning: > DEPRECATION WARNING: Initialization autoloaded the constants ApplicationController This appears to be due to the initializer requiring `EmberController`, which shouldn't be necessary since th...
diff --git a/lib/env_bang/classes.rb b/lib/env_bang/classes.rb index abc1234..def5678 100644 --- a/lib/env_bang/classes.rb +++ b/lib/env_bang/classes.rb @@ -16,9 +16,9 @@ end def Array(value, options) - options.delete(:class) - options[:class] = options[:of] if options[:of] - value.s...
Remove in-place modification of options when casting to Array. This was causing the :class option to be lost, which meant the first access to an Array value would work correctly, while subsequent accesses would return a String.
diff --git a/lib/espresso/concern.rb b/lib/espresso/concern.rb index abc1234..def5678 100644 --- a/lib/espresso/concern.rb +++ b/lib/espresso/concern.rb @@ -17,13 +17,18 @@ super base.extend const_get('ClassMethods') if const_defined?('ClassMethods') base.send :include, const_get('InstanceMeth...
Make Espresso::Concern work with many included blocks
diff --git a/lib/mws-rb/api/feeds.rb b/lib/mws-rb/api/feeds.rb index abc1234..def5678 100644 --- a/lib/mws-rb/api/feeds.rb +++ b/lib/mws-rb/api/feeds.rb @@ -12,7 +12,7 @@ end def submit_feed(params={}) - xml_envelope = Envelope.new(params) + xml_envelope = Envelope.new(params.merge!(merchan...
Remove the need of passing merchant_id to submit_feed
diff --git a/examples.rb b/examples.rb index abc1234..def5678 100644 --- a/examples.rb +++ b/examples.rb @@ -1,7 +1,25 @@ require File.join(File.dirname(__FILE__), 'lib', 'tickle') -['May 30', '6:30 PM', 'tomorrow at 6:00', 'June 18, 2011',].each {|s| - print "s: ", s, " ", Tickle.parse(s) - puts +=begin + +T...
Add timezone notes to example.rb
diff --git a/recipes/haproxy.rb b/recipes/haproxy.rb index abc1234..def5678 100644 --- a/recipes/haproxy.rb +++ b/recipes/haproxy.rb @@ -22,6 +22,7 @@ cn "Tester" bits 4096 days 365 + not_if do ::File.exists?(node['haproxy']['cert']) end end template "#{node['haproxy']['conf_dir']}/haproxy.cfg" do
Add constraint to cert resource
diff --git a/lib/ssh_key_hub/exporter/authorized_keys_users.rb b/lib/ssh_key_hub/exporter/authorized_keys_users.rb index abc1234..def5678 100644 --- a/lib/ssh_key_hub/exporter/authorized_keys_users.rb +++ b/lib/ssh_key_hub/exporter/authorized_keys_users.rb @@ -0,0 +1,28 @@+module SSHKeyHub::Exporter + # Simple key exp...
Add simple OpenSSH style home directory key export
diff --git a/lib/webmock/http_lib_adapters/http_rb/response.rb b/lib/webmock/http_lib_adapters/http_rb/response.rb index abc1234..def5678 100644 --- a/lib/webmock/http_lib_adapters/http_rb/response.rb +++ b/lib/webmock/http_lib_adapters/http_rb/response.rb @@ -14,8 +14,18 @@ def from_webmock(webmock_response, req...
Support correct encoding parameter for HTTP.rb 2.x and earlier
diff --git a/lib/vmdb/deprecation.rb b/lib/vmdb/deprecation.rb index abc1234..def5678 100644 --- a/lib/vmdb/deprecation.rb +++ b/lib/vmdb/deprecation.rb @@ -1,5 +1,19 @@-Vmdb::Deprecation ||= begin - deprecator = ActiveSupport::Deprecation.new("D-release", "ManageIQ") - deprecator.behavior = [:stderr, :log] - deprec...
Fix rubocop error "Syntax - dynamic constant assignment"
diff --git a/lib/yelp/deep_struct.rb b/lib/yelp/deep_struct.rb index abc1234..def5678 100644 --- a/lib/yelp/deep_struct.rb +++ b/lib/yelp/deep_struct.rb @@ -3,37 +3,30 @@ # This is some code to create nested Structs from nested hash tables. # Code written by Andrea Pavoni, more information here: # http://andreapavoni...
Clean up DeepStruct a little bit
diff --git a/spec/acceptance/support/sphinx_controller.rb b/spec/acceptance/support/sphinx_controller.rb index abc1234..def5678 100644 --- a/spec/acceptance/support/sphinx_controller.rb +++ b/spec/acceptance/support/sphinx_controller.rb @@ -40,7 +40,7 @@ end def index(*indices) - config.controller.index *indi...
Use the commander for indexing in acceptance specs
diff --git a/spec/controllers/contacts_controller_spec.rb b/spec/controllers/contacts_controller_spec.rb index abc1234..def5678 100644 --- a/spec/controllers/contacts_controller_spec.rb +++ b/spec/controllers/contacts_controller_spec.rb @@ -14,5 +14,13 @@ it { expect(response).to be_success } end + desc...
Fix spec for previous commit
diff --git a/spec/integration/match_either_result_spec.rb b/spec/integration/match_either_result_spec.rb index abc1234..def5678 100644 --- a/spec/integration/match_either_result_spec.rb +++ b/spec/integration/match_either_result_spec.rb @@ -1,29 +1,93 @@ RSpec.describe "MatchEitherResult" do - subject(:match) { - M...
Add specs to cover class enhancement
diff --git a/spec/lib/danica/variable_spec.rb b/spec/lib/danica/variable_spec.rb index abc1234..def5678 100644 --- a/spec/lib/danica/variable_spec.rb +++ b/spec/lib/danica/variable_spec.rb @@ -10,7 +10,9 @@ let(:value) { 100 } let(:subject) { described_class.new(value: value) } - it { expect(subject...
Correct spec description to variable spec
diff --git a/spec/centos/interfaces_spec.rb b/spec/centos/interfaces_spec.rb index abc1234..def5678 100644 --- a/spec/centos/interfaces_spec.rb +++ b/spec/centos/interfaces_spec.rb @@ -0,0 +1,24 @@+require 'spec_helper' + +# This test requires a VM to be provision with two IPs, preferably one public +# and one private....
Test to ensure the VM has two interfaces, eth0 and eth1 This test requires a VM to be provision with two IPs, preferably one public and one private.
diff --git a/spec/api_mock_spec.rb b/spec/api_mock_spec.rb index abc1234..def5678 100644 --- a/spec/api_mock_spec.rb +++ b/spec/api_mock_spec.rb @@ -0,0 +1,11 @@+require 'discordrb' +require 'mock/api_mock' +using APIMock + +describe APIMock do + it 'stores the used method' do + Discordrb::API.raw_request(:get, [])...
Write a short spec for APIMock
diff --git a/spec/models/restaurant_spec.rb b/spec/models/restaurant_spec.rb index abc1234..def5678 100644 --- a/spec/models/restaurant_spec.rb +++ b/spec/models/restaurant_spec.rb @@ -3,9 +3,8 @@ RSpec.describe Restaurant, type: :model do describe "attributes" do it { should have_db_column(:name) } - it { s...
Fix rspec tests to pass new restaurants table
diff --git a/NoticeView.podspec b/NoticeView.podspec index abc1234..def5678 100644 --- a/NoticeView.podspec +++ b/NoticeView.podspec @@ -0,0 +1,14 @@+Pod::Spec.new do |s| + s.name = 'NoticeView' + s.version = '2.4' + s.license = 'MIT' + s.summary = 'A TweetBot-like notice component for iOS.' ...
Add podspec to support :local installation
diff --git a/spec/double-create.rb b/spec/double-create.rb index abc1234..def5678 100644 --- a/spec/double-create.rb +++ b/spec/double-create.rb @@ -0,0 +1,11 @@+require_relative 'spec_helper' + +describe "Noodle" do + it "should fail to create a node with the same name as an existing node" do + post '/nodes/jojo.e...
Add test for creating a node that already exists
diff --git a/spec/support/authentication.rb b/spec/support/authentication.rb index abc1234..def5678 100644 --- a/spec/support/authentication.rb +++ b/spec/support/authentication.rb @@ -24,6 +24,15 @@ let(:current_user) { membership.user } end +shared_context "signed in as a group member" do + include_context "sig...
Add group member sign in context.
diff --git a/Titanium.podspec b/Titanium.podspec index abc1234..def5678 100644 --- a/Titanium.podspec +++ b/Titanium.podspec @@ -18,7 +18,7 @@ s.platform = :ios, '7.0' - s.source = { :git => "git@github.com:quri/Titanium.git", :tag => "#{s.version}" } + s.source = { :git => "https://github.com/q...
Change to https in podspec to pass linter
diff --git a/spec/time_helpers_spec.rb b/spec/time_helpers_spec.rb index abc1234..def5678 100644 --- a/spec/time_helpers_spec.rb +++ b/spec/time_helpers_spec.rb @@ -5,6 +5,11 @@ it do expect(Time.current.year).to eq 2004 + expect(Time.now.year).to eq 2004 + + # ensure knapsack_pro adds raw method...
Add additional tests to ensure the knapsack_pro detects time correctly
diff --git a/lib/hensel/helpers.rb b/lib/hensel/helpers.rb index abc1234..def5678 100644 --- a/lib/hensel/helpers.rb +++ b/lib/hensel/helpers.rb @@ -3,7 +3,7 @@ module Hensel module Helpers def breadcrumbs - @breadcrumbs ||= Builder.new + @__breadcrumbs ||= Builder.new end end end
Fix an instance variable name
diff --git a/rails-data-explorer.gemspec b/rails-data-explorer.gemspec index abc1234..def5678 100644 --- a/rails-data-explorer.gemspec +++ b/rails-data-explorer.gemspec @@ -17,7 +17,7 @@ gem.test_files = `git ls-files -- {test,spec,features}/*`.split("\n") # really it's only ActiveSupport and ActionView - gem.a...
Adjust rails dependencies to what's needed only
diff --git a/spree_cdyne_pav.gemspec b/spree_cdyne_pav.gemspec index abc1234..def5678 100644 --- a/spree_cdyne_pav.gemspec +++ b/spree_cdyne_pav.gemspec @@ -16,7 +16,7 @@ s.require_path = 'lib' s.requirements << 'none' - s.add_dependency 'spree_core', '~> 1.2' + s.add_dependency 'spree_core', '>= 2.0.0.beta' ...
Update gemspec to support spree 2.0
diff --git a/rakuten_web_service.gemspec b/rakuten_web_service.gemspec index abc1234..def5678 100644 --- a/rakuten_web_service.gemspec +++ b/rakuten_web_service.gemspec @@ -17,7 +17,7 @@ spec.require_paths = ['lib'] spec.required_ruby_version = '>= 2.3.0' - spec.add_development_dependency 'bundler', '~> 1.3' + ...
Use the latest version of bundler
diff --git a/lib/mactag/builder.rb b/lib/mactag/builder.rb index abc1234..def5678 100644 --- a/lib/mactag/builder.rb +++ b/lib/mactag/builder.rb @@ -43,7 +43,7 @@ if builder.has_gems? Mactag::Ctags.new(@builder.files, Mactag::Config.tags_file).create - puts "Successfully generated #{Mactag...
Update message when creation of tags file is done.
diff --git a/lib/install/template.rb b/lib/install/template.rb index abc1234..def5678 100644 --- a/lib/install/template.rb +++ b/lib/install/template.rb @@ -10,7 +10,7 @@ /node_modules EOS -run './bin/yarn add --dev webpack webpack-merge webpack-dev-server path-complete-extname babel-loader babel-core babel-preset-l...
Add compression-webpack-plugin as a dependency
diff --git a/clever_tap.gemspec b/clever_tap.gemspec index abc1234..def5678 100644 --- a/clever_tap.gemspec +++ b/clever_tap.gemspec @@ -14,8 +14,6 @@ spec.description = 'Gem providing easy access to the CleverTap API' spec.files = Dir['lib/**/*', 'LICENSE.txt', 'Rakefile', 'README.md', 'Gemfile'] spec.test_fil...
Fix gem warning for wrong bin folder
diff --git a/lib/mas/firm_indexer.rb b/lib/mas/firm_indexer.rb index abc1234..def5678 100644 --- a/lib/mas/firm_indexer.rb +++ b/lib/mas/firm_indexer.rb @@ -16,6 +16,13 @@ index_firm(aggregate.firm) if firm_exists?(aggregate.firm) end + def firm_exists?(firm) + return false if (firm.nil? || firm.de...
Make store_firm and delete_firm private
diff --git a/lib/camaraderie/user.rb b/lib/camaraderie/user.rb index abc1234..def5678 100644 --- a/lib/camaraderie/user.rb +++ b/lib/camaraderie/user.rb @@ -10,7 +10,7 @@ Camaraderie.membership_types.each do |type| class_eval <<-RUBY, __FILE__, __LINE__ + 1 def #{type}_of?(organization) - ...
Fix bug with ActiveRecord 3
diff --git a/lib/podio/areas/news.rb b/lib/podio/areas/news.rb index abc1234..def5678 100644 --- a/lib/podio/areas/news.rb +++ b/lib/podio/areas/news.rb @@ -5,7 +5,7 @@ def create(attributes) response = Podio.connection.post do |req| - req.url = '/news' + req.url '/news/' req.body = attributes en...
Fix syntax error in create method on News area
diff --git a/db/seeds.rb b/db/seeds.rb index abc1234..def5678 100644 --- a/db/seeds.rb +++ b/db/seeds.rb @@ -1,3 +1,12 @@ dian = User.create(name: "Dian", email: "dian@example.com", password: "abc123") julianna = User.create(name: "Julianna", email: "juls@example.com", password: "123456") jenny = User.create(name: "J...
Add expense type seed data
diff --git a/db/seeds.rb b/db/seeds.rb index abc1234..def5678 100644 --- a/db/seeds.rb +++ b/db/seeds.rb @@ -1 +1,29 @@-# Nothing to see here, yet. +# I fear my lack of imagination for this. + +pseudonyms = %w(svankmajer ricatorta tinchox jp_kakaroto ak|ra codefolk frankie norman leech nonce) + +titles = [ + 'absolute...
Add seed data for development.
diff --git a/db/seeds.rb b/db/seeds.rb index abc1234..def5678 100644 --- a/db/seeds.rb +++ b/db/seeds.rb @@ -1,3 +1,6 @@+User.create(username: 'admin', password: 'admin', + password_confirmation: 'admin', email: 'admin@admin.com') + 5.times do passphrase_generator = Faker::Internet.password
Add admin user for testing
diff --git a/spec/controllers/no_response_if_performed_spec.rb b/spec/controllers/no_response_if_performed_spec.rb index abc1234..def5678 100644 --- a/spec/controllers/no_response_if_performed_spec.rb +++ b/spec/controllers/no_response_if_performed_spec.rb @@ -3,46 +3,34 @@ module NoResponseIfPerformedSpec # example...
Simplify spec, less method tracing, more response checking
diff --git a/lib/thank_you_mailer.rb b/lib/thank_you_mailer.rb index abc1234..def5678 100644 --- a/lib/thank_you_mailer.rb +++ b/lib/thank_you_mailer.rb @@ -3,14 +3,12 @@ require 'mail' class ThankYouMailer - class << self - def send_email(recipient, first_name) - Mail.deliver do - to recipient - ...
Make the class method syntax more explicit and readable We only have one class method and there is a lot of indentation making the code difficult to scan. Using the class << self syntax is a premature optimization in this case.
diff --git a/db/seeds.rb b/db/seeds.rb index abc1234..def5678 100644 --- a/db/seeds.rb +++ b/db/seeds.rb @@ -0,0 +1,5 @@+unless Role.count > 0 + Role.create!(:name => "Administrator", :kind => Role::KIND_ADMIN) + Role.create!(:name => "Committer", :kind => Role::KIND_MEMBER) +end +
Fix db:setup task to allow team creation Seed data should go to db/seeds.rb instead of being on migrations.
diff --git a/BVLinearGradient.podspec b/BVLinearGradient.podspec index abc1234..def5678 100644 --- a/BVLinearGradient.podspec +++ b/BVLinearGradient.podspec @@ -3,6 +3,8 @@ s.name = "BVLinearGradient" s.version = "1.5.2" s.homepage = "https://github.com/brentvatne/react-native-linear-gradient" ...
Add required fields to podspec Cocoapods >= 1 requires `summary` and `author`
diff --git a/app/controllers/chapters_controller.rb b/app/controllers/chapters_controller.rb index abc1234..def5678 100644 --- a/app/controllers/chapters_controller.rb +++ b/app/controllers/chapters_controller.rb @@ -4,7 +4,7 @@ caches_action :show def show - @chapter = @book.chapters.detect { |chapter| cha...
Use for finding a chapter for a given position rather than the array version
diff --git a/spec/lib/tasks/dev_seed_spec.rb b/spec/lib/tasks/dev_seed_spec.rb index abc1234..def5678 100644 --- a/spec/lib/tasks/dev_seed_spec.rb +++ b/spec/lib/tasks/dev_seed_spec.rb @@ -1,5 +1,7 @@+require 'rake' require 'rails_helper' -require 'rake' +Rake::Task.define_task(:environment) +Rake.application.rake_req...
Add missing require for dev_seeds rake task spec
diff --git a/app/controllers/projects_controller.rb b/app/controllers/projects_controller.rb index abc1234..def5678 100644 --- a/app/controllers/projects_controller.rb +++ b/app/controllers/projects_controller.rb @@ -5,16 +5,16 @@ @project = Project.new end - def create - @user = User.find(params[:user_id]...
Add create mvp action in ProjectsController.
diff --git a/app/controllers/requests_controller.rb b/app/controllers/requests_controller.rb index abc1234..def5678 100644 --- a/app/controllers/requests_controller.rb +++ b/app/controllers/requests_controller.rb @@ -25,7 +25,9 @@ end def update - + request = Request.find_by(params[:id]) + request.responde...
Add update logic to add responder
diff --git a/lib/ruboty/jira/actions/associate_user.rb b/lib/ruboty/jira/actions/associate_user.rb index abc1234..def5678 100644 --- a/lib/ruboty/jira/actions/associate_user.rb +++ b/lib/ruboty/jira/actions/associate_user.rb @@ -20,8 +20,8 @@ end def reply_message - if associate_name.nil? - ...
Change assciate user error message
diff --git a/entry_types/scrolled/app/helpers/pageflow_scrolled/react_server_side_rendering_helper.rb b/entry_types/scrolled/app/helpers/pageflow_scrolled/react_server_side_rendering_helper.rb index abc1234..def5678 100644 --- a/entry_types/scrolled/app/helpers/pageflow_scrolled/react_server_side_rendering_helper.rb ++...
Remove renderer memoization in development Having to restart the Rails server to synchronize server- and client-side JS introduces an additional error source in many development scenarios that otherwise don't have anything to do with the SSR/CSR distinction. To avoid this, we only memoize the renderer in environments...
diff --git a/lib/tasks/ffcrm/missing_translations.rake b/lib/tasks/ffcrm/missing_translations.rake index abc1234..def5678 100644 --- a/lib/tasks/ffcrm/missing_translations.rake +++ b/lib/tasks/ffcrm/missing_translations.rake @@ -4,25 +4,25 @@ # See MIT-LICENSE file or http://www.opensource.org/licenses/mit-license.php ...
Fix relative path issue when running ffcrm as an engine.
diff --git a/lib/tasks/ffcrm/missing_translations.rake b/lib/tasks/ffcrm/missing_translations.rake index abc1234..def5678 100644 --- a/lib/tasks/ffcrm/missing_translations.rake +++ b/lib/tasks/ffcrm/missing_translations.rake @@ -4,25 +4,25 @@ # See MIT-LICENSE file or http://www.opensource.org/licenses/mit-license.php ...
Fix relative path issue when running ffcrm as an engine.
diff --git a/lib/dotenv/rails-now.rb b/lib/dotenv/rails-now.rb index abc1234..def5678 100644 --- a/lib/dotenv/rails-now.rb +++ b/lib/dotenv/rails-now.rb @@ -6,5 +6,15 @@ # gem "gem-that-requires-env-variables" # +# Needed for dotenv to work in Rails 3.0 +# https://github.com/bkeepers/dotenv/issues/151 +module Ra...
Add Rails 3 monkey patch to deal with missing ivar prior to load. * Can't put this in application.rb since dotenv needs to set env before loading other gems. * Rails environment must be set prior to load for rspec tests or else the development db is configured * https://github.com/bkeepers/dotenv/issues/45
diff --git a/spree_i18n.gemspec b/spree_i18n.gemspec index abc1234..def5678 100644 --- a/spree_i18n.gemspec +++ b/spree_i18n.gemspec @@ -16,7 +16,7 @@ s.add_dependency 'i18n', '~> 0.6.1' s.add_dependency 'rails-i18n', '~> 0.7.3' - s.add_dependency 'spree_core', '~> 2.1.0.beta' + s.add_dependency 'spree_core', ...
Make master branch less restrict on spree versions No need to force to 2.1.0.beta as master branch should work as well spree 2.0.x releases
diff --git a/lib/gir_ffi-gst/base.rb b/lib/gir_ffi-gst/base.rb index abc1234..def5678 100644 --- a/lib/gir_ffi-gst/base.rb +++ b/lib/gir_ffi-gst/base.rb @@ -24,7 +24,7 @@ # Overrides for Gst module functions module Gst - setup_method 'init' + setup_method! 'init' include GirFFIGst::AutoArgv end
Use exception-raising method setup functions
diff --git a/lib/mutant/delegator.rb b/lib/mutant/delegator.rb index abc1234..def5678 100644 --- a/lib/mutant/delegator.rb +++ b/lib/mutant/delegator.rb @@ -11,9 +11,7 @@ # @api private # def delegate(*names) - names.each do |name| - define_delegator(name) - end + names...
Use simpler enumerated method call
diff --git a/ohm-validations.gemspec b/ohm-validations.gemspec index abc1234..def5678 100644 --- a/ohm-validations.gemspec +++ b/ohm-validations.gemspec @@ -11,7 +11,7 @@ s.files = Dir["LICENSE", "README.md", "lib/**/*.rb"] s.test_files = Dir["test/**/*.rb"] - s.add_dependency "ohm", "~> 2.0" + s.add_depe...
Enable use with Ohm 3.x
diff --git a/lib/tairu/coordinate.rb b/lib/tairu/coordinate.rb index abc1234..def5678 100644 --- a/lib/tairu/coordinate.rb +++ b/lib/tairu/coordinate.rb @@ -7,5 +7,51 @@ @column = Integer(column) @zoom = Integer(zoom) end + + def x + @column + end + + def y + @row + end + + de...
Add bounds to Tile Coordinate