diff
stringlengths
65
26.7k
message
stringlengths
7
9.92k
diff --git a/nagios_parser.gemspec b/nagios_parser.gemspec index abc1234..def5678 100644 --- a/nagios_parser.gemspec +++ b/nagios_parser.gemspec @@ -22,6 +22,7 @@ s.executables = `git ls-files -- bin/*`.split("\n").map{ |f| File.basename(f) } s.require_paths = ["lib"] + s.add_development_dependency "rake" ...
Add rake to development dependencies.
diff --git a/lib/telebot/bot.rb b/lib/telebot/bot.rb index abc1234..def5678 100644 --- a/lib/telebot/bot.rb +++ b/lib/telebot/bot.rb @@ -13,7 +13,10 @@ def run(&block) loop do - updates = @client.get_updates(offset: @processed_update_ids.last) + # Note: https://core.telegram.org/bots/api#getu...
Mark updates as confirmed using offset + 1 as described in Bot API
diff --git a/lib/tent-client.rb b/lib/tent-client.rb index abc1234..def5678 100644 --- a/lib/tent-client.rb +++ b/lib/tent-client.rb @@ -1,5 +1,6 @@ require 'tent-client/version' require 'faraday' +require 'tent-client/middleware/content_type_header' require 'tent-client/middleware/encode_json' require 'tent-client/...
Fix last commit: require content type header middleware
diff --git a/test/helper.rb b/test/helper.rb index abc1234..def5678 100644 --- a/test/helper.rb +++ b/test/helper.rb @@ -21,4 +21,4 @@ include Rack::Test::Methods end -Protest.report_with(:turn) +ENV["PROTEST_REPORT"] ||= "turn"
Allow change protest report type by enviroment.
diff --git a/logstash-client.gemspec b/logstash-client.gemspec index abc1234..def5678 100644 --- a/logstash-client.gemspec +++ b/logstash-client.gemspec @@ -17,7 +17,7 @@ spec.executables = spec.files.grep(%r{^bin/}) { |f| File.basename(f) } spec.test_files = spec.files.grep(%r{^(test|spec|features)/}) spe...
Fix Faraday version to 0.9.0 or later
diff --git a/lib/game.rb b/lib/game.rb index abc1234..def5678 100644 --- a/lib/game.rb +++ b/lib/game.rb @@ -1,5 +1,4 @@ require_relative 'tic_tac_toe' -# decisions vs dependency class Game
Remove comments from Game class
diff --git a/lib/game.rb b/lib/game.rb index abc1234..def5678 100644 --- a/lib/game.rb +++ b/lib/game.rb @@ -9,19 +9,6 @@ @gametype = args.fetch(:gametype, nil) end - def user_move - index_position = get_user_input - if gametype.valid_move?(index_position) - @gametype = gametype.move(index_position...
Fix bug where invalid inputs were accepted by the Game, the issue was that after taking in user input the program will continue to let the computer move instead of asking the user for input again
diff --git a/lib/game.rb b/lib/game.rb index abc1234..def5678 100644 --- a/lib/game.rb +++ b/lib/game.rb @@ -7,29 +7,6 @@ def initialize(gametype = nil, ui = nil) @ui = ui @gametype = gametype - end - - # def display_intro_msg - # puts "Welcome to #{gametype.desc[:name]} \n#{gametype.desc[:instructions...
Remove method that relates to stdin and stdout
diff --git a/lib/gday.rb b/lib/gday.rb index abc1234..def5678 100644 --- a/lib/gday.rb +++ b/lib/gday.rb @@ -3,11 +3,11 @@ module Gday class Greeting def hi - puts "G'day!" + "G'day!" end def bye - puts "Cheerio" + "Cheerio" end end end
Remove puts from methods in Gday class to return string instead of nil.
diff --git a/minitest-around.gemspec b/minitest-around.gemspec index abc1234..def5678 100644 --- a/minitest-around.gemspec +++ b/minitest-around.gemspec @@ -14,5 +14,4 @@ s.add_development_dependency 'rdoc' s.add_development_dependency 'rake' s.add_development_dependency 'cucumber' - s.add_development_dependen...
Drop duplicate dependency on minitest
diff --git a/lib/shiv.rb b/lib/shiv.rb index abc1234..def5678 100644 --- a/lib/shiv.rb +++ b/lib/shiv.rb @@ -14,7 +14,7 @@ end def self.nodes - Chef::Node.list.keys + Chef::Node.list.keys.sort.reverse end def self.hostname_from(node)
Sort node names in reverse alphabetical order so nodes that are substrings of each other dont get replaced first
diff --git a/memcached_store.gemspec b/memcached_store.gemspec index abc1234..def5678 100644 --- a/memcached_store.gemspec +++ b/memcached_store.gemspec @@ -17,10 +17,10 @@ gem.version = MemcachedStore::VERSION gem.add_runtime_dependency "activesupport", ">= 3.2" gem.add_runtime_dependency "snappy", "0.0...
Remove memcache-client as we dont need it anymore
diff --git a/trasto.gemspec b/trasto.gemspec index abc1234..def5678 100644 --- a/trasto.gemspec +++ b/trasto.gemspec @@ -12,6 +12,7 @@ gem.description = 'Translatable columns for Rails 4, directly stored in a Postgres hstore in the model table.' gem.summary = 'Use PostgreSQL hstore to keep column translati...
[TASK] Add license information to gemspec
diff --git a/middleman-title.gemspec b/middleman-title.gemspec index abc1234..def5678 100644 --- a/middleman-title.gemspec +++ b/middleman-title.gemspec @@ -13,9 +13,9 @@ s.email = 'jcypret@gmail.com' s.homepage = 'https://github.com/jcypret/middleman-title' - spec.files = `git ls-files`.split(...
Fix gemset passed in block variable name
diff --git a/freckles.gemspec b/freckles.gemspec index abc1234..def5678 100644 --- a/freckles.gemspec +++ b/freckles.gemspec @@ -10,7 +10,7 @@ s.summary = 'Ruby client for Version 2 of the Freckle API' s.files = Dir.glob('{lib,test}/**/*') + %w(LICENSE.txt README.md freckles.gemspec) s.required_ruby_version = '...
Fix open-ended dependency on rake warning from gemspec
diff --git a/Library/Formula/asterisk.rb b/Library/Formula/asterisk.rb index abc1234..def5678 100644 --- a/Library/Formula/asterisk.rb +++ b/Library/Formula/asterisk.rb @@ -1,40 +1,20 @@ require 'formula' class Asterisk < Formula - url 'http://downloads.asterisk.org/pub/telephony/asterisk/releases/asterisk-1.6.1.6....
Update Asterisk from 1.6.1.6 to 1.8.3.2. * Added the '--with-sample-config' option. This will generate the sample Asterisk config files in /usr/local/etc/asterisk. It creates backups of any existing files first. * Removed the patch that used curl instead of wget to download the sound files. This doesn't appear ...
diff --git a/gherkin3.gemspec b/gherkin3.gemspec index abc1234..def5678 100644 --- a/gherkin3.gemspec +++ b/gherkin3.gemspec @@ -16,7 +16,7 @@ s.add_development_dependency 'rspec', '~> 3.3' # For coverage reports - s.add_development_dependency 'coveralls', '~> 0.8' + s.add_development_dependency 'coveralls...
Set an upper limit on the coveralls version in the gemspec coveralls 0.8.8 have the dependency tins ~> 1.6.0, and tins 1.7.0 required Ruby version >= 2.0. Fixes #127.
diff --git a/spec/controllers/rules_controller_spec.rb b/spec/controllers/rules_controller_spec.rb index abc1234..def5678 100644 --- a/spec/controllers/rules_controller_spec.rb +++ b/spec/controllers/rules_controller_spec.rb @@ -0,0 +1,35 @@+require 'rails_helper' + +module Toritsugi + describe RulesController do + ...
Add specs to ensure the given after redirection call is called
diff --git a/spec/uniara_virtual_parser/client_spec.rb b/spec/uniara_virtual_parser/client_spec.rb index abc1234..def5678 100644 --- a/spec/uniara_virtual_parser/client_spec.rb +++ b/spec/uniara_virtual_parser/client_spec.rb @@ -2,7 +2,7 @@ module UniaraVirtualParser describe Client do - before :each do + af...
Fix the reset Client status in client
diff --git a/spec/unit/nutrella/developer_keys_spec.rb b/spec/unit/nutrella/developer_keys_spec.rb index abc1234..def5678 100644 --- a/spec/unit/nutrella/developer_keys_spec.rb +++ b/spec/unit/nutrella/developer_keys_spec.rb @@ -0,0 +1,29 @@+module Nutrella + extend DeveloperKeys + + RSpec.describe DeveloperKeys do +...
Add a specification for the DeveloperKeys module. Note: reduces the mutations that survive.
diff --git a/spec/lib/wiki_edits_spec.rb b/spec/lib/wiki_edits_spec.rb index abc1234..def5678 100644 --- a/spec/lib/wiki_edits_spec.rb +++ b/spec/lib/wiki_edits_spec.rb @@ -2,27 +2,35 @@ require "#{Rails.root}/lib/wiki_edits" describe WikiEdits do + # We're not testing any of the network stuff, nor whether the requ...
Extend WikiEdits test to superficially cover the entire class.
diff --git a/Parse-RACExtensions.podspec b/Parse-RACExtensions.podspec index abc1234..def5678 100644 --- a/Parse-RACExtensions.podspec +++ b/Parse-RACExtensions.podspec @@ -6,10 +6,10 @@ s.license = { :type => 'MIT', :file => 'LICENSE.txt' } s.author = { "Dave Lee" => "dave@kastiglione.com" } s.sourc...
Update Parse version to 1.3.0.1.
diff --git a/serverspec/spec/all/all_configure_spec.rb b/serverspec/spec/all/all_configure_spec.rb index abc1234..def5678 100644 --- a/serverspec/spec/all/all_configure_spec.rb +++ b/serverspec/spec/all/all_configure_spec.rb @@ -10,8 +10,8 @@ describe 'connect jmx_server' do servers = property[:servers] - svr['ro...
Modify logic of spec test files.
diff --git a/acts_as_paranoid.gemspec b/acts_as_paranoid.gemspec index abc1234..def5678 100644 --- a/acts_as_paranoid.gemspec +++ b/acts_as_paranoid.gemspec @@ -25,5 +25,5 @@ spec.add_development_dependency "bundler", "~> 1.5" spec.add_development_dependency "rake" spec.add_development_dependency "rdoc" - spec...
Allow broad range of minitest versions This is to avoid conflict with minitest versions required by the different versions of Rails.
diff --git a/spec/lint_trappings/document_spec.rb b/spec/lint_trappings/document_spec.rb index abc1234..def5678 100644 --- a/spec/lint_trappings/document_spec.rb +++ b/spec/lint_trappings/document_spec.rb @@ -2,17 +2,17 @@ RSpec.describe LintTrappings::Document do let(:config) { double } + let(:options) { {} } + ...
Increase Document test coverage to 100%
diff --git a/spec/process_watcher/monitor_spec.rb b/spec/process_watcher/monitor_spec.rb index abc1234..def5678 100644 --- a/spec/process_watcher/monitor_spec.rb +++ b/spec/process_watcher/monitor_spec.rb @@ -0,0 +1,59 @@+#-- +# Copyright: Copyright (c) 2010 RightScale, Inc. +# +# Permission is hereby granted, free of ...
Add test cases for ProcessWatcher::ProcessMonitor.
diff --git a/app/controllers/adhoq/current_tables_controller.rb b/app/controllers/adhoq/current_tables_controller.rb index abc1234..def5678 100644 --- a/app/controllers/adhoq/current_tables_controller.rb +++ b/app/controllers/adhoq/current_tables_controller.rb @@ -8,7 +8,7 @@ hidden_model_names << 'ApplicationRec...
Fix show table feature error(a case where there is an anonymous class inherited ActiveRecord::Base) If there is an anonymous class inherited ActiveRecord::Base(e.g. SwitchPoint), the show table feature fails. Because the name is nil in anonymous classes, it fails sorting by table name. So I excluded anonymous classes....
diff --git a/db/migrate/20170413195527_follow_all_creators_rpc.rb b/db/migrate/20170413195527_follow_all_creators_rpc.rb index abc1234..def5678 100644 --- a/db/migrate/20170413195527_follow_all_creators_rpc.rb +++ b/db/migrate/20170413195527_follow_all_creators_rpc.rb @@ -0,0 +1,40 @@+class FollowAllCreatorsRpc < Activ...
Add follow all creators rpc
diff --git a/app/validators/francis_cms/webmention_validator.rb b/app/validators/francis_cms/webmention_validator.rb index abc1234..def5678 100644 --- a/app/validators/francis_cms/webmention_validator.rb +++ b/app/validators/francis_cms/webmention_validator.rb @@ -1,13 +1,9 @@ module FrancisCms class WebmentionValid...
Revert conditional logic bug introduced in 0d5ee8c
diff --git a/app/controllers/api/application_controller.rb b/app/controllers/api/application_controller.rb index abc1234..def5678 100644 --- a/app/controllers/api/application_controller.rb +++ b/app/controllers/api/application_controller.rb @@ -1,5 +1,7 @@ class Api::ApplicationController < ActionController::Base pr...
Add missing `private` specification to internal method
diff --git a/app/helpers/textual_mixins/textual_os_info.rb b/app/helpers/textual_mixins/textual_os_info.rb index abc1234..def5678 100644 --- a/app/helpers/textual_mixins/textual_os_info.rb +++ b/app/helpers/textual_mixins/textual_os_info.rb @@ -9,7 +9,7 @@ h[:value] = os h[:title] = _("Show OS container in...
Address rubocop comments for TextualMixins::TextualOsInfo
diff --git a/app/services/projects/participants_service.rb b/app/services/projects/participants_service.rb index abc1234..def5678 100644 --- a/app/services/projects/participants_service.rb +++ b/app/services/projects/participants_service.rb @@ -4,7 +4,7 @@ @target = get_target(note_type, note_id) participa...
Update method name and remove unneeded params
diff --git a/log.gemspec b/log.gemspec index abc1234..def5678 100644 --- a/log.gemspec +++ b/log.gemspec @@ -1,7 +1,7 @@ # -*- encoding: utf-8 -*- Gem::Specification.new do |s| s.name = 'log' - s.version = '0.4.0.0' + s.version = '0.4.0.1' s.summary = 'Logging to STD IO with levels, tagging, and coloring' s...
Package version is increased from 0.4.0.0 to 0.4.0.1
diff --git a/test/lib/fixtures_test.rb b/test/lib/fixtures_test.rb index abc1234..def5678 100644 --- a/test/lib/fixtures_test.rb +++ b/test/lib/fixtures_test.rb @@ -32,7 +32,7 @@ FileUtils.rm_rf(host_path) end - def test_import_all_with_no_site + def test_export_all_with_no_site comfy_cms_sites(:defau...
Rename test to unique and correct name
diff --git a/test/integration/default/activemq_spec.rb b/test/integration/default/activemq_spec.rb index abc1234..def5678 100644 --- a/test/integration/default/activemq_spec.rb +++ b/test/integration/default/activemq_spec.rb @@ -1,6 +1,3 @@-describe 'ActiveMQ server' do - it 'should be running the activemq server' do ...
Check process vs. service check Signed-off-by: Tim Smith <764ef62106582a09ed09dfa0b6bff7c05fd7d1e4@chef.io>
diff --git a/config/initializers/delayed_job_config.rb b/config/initializers/delayed_job_config.rb index abc1234..def5678 100644 --- a/config/initializers/delayed_job_config.rb +++ b/config/initializers/delayed_job_config.rb @@ -1,2 +1,22 @@ Delayed::Worker.max_attempts = 100 Delayed::Worker.max_run_time = 1.week + +r...
Patch queue adapter for better reporting in AppSignal Currently all the jobs are reported under the same name in AppSignal. This is a dirty way to fix it but there is no other option as adding a `appsignal_name` method to the job class doesn't work since that's not the object that gets passed to AppSignal's Delayed Jo...
diff --git a/app/models/dump_importer.rb b/app/models/dump_importer.rb index abc1234..def5678 100644 --- a/app/models/dump_importer.rb +++ b/app/models/dump_importer.rb @@ -35,7 +35,7 @@ location: row['Address'], coordinates: row['Geo'].split(",") source_url: row['Sour...
ADD ALL OF THE THINGS
diff --git a/app/models/event_history.rb b/app/models/event_history.rb index abc1234..def5678 100644 --- a/app/models/event_history.rb +++ b/app/models/event_history.rb @@ -0,0 +1,11 @@+class EventHistory < ApplicationRecord + belongs_to :dojo + + validates :dojo_name, presence: true + validates :service_name, prese...
Create a model named `EventHistory`
diff --git a/app/models/page_template.rb b/app/models/page_template.rb index abc1234..def5678 100644 --- a/app/models/page_template.rb +++ b/app/models/page_template.rb @@ -25,7 +25,7 @@ def render_terms_of_service_template(site) template = File.read('lib/assets/terms_template.json.erb') - hosting_organizat...
Fix for running the sample task on an empty database
diff --git a/app/views/projects/index.rb b/app/views/projects/index.rb index abc1234..def5678 100644 --- a/app/views/projects/index.rb +++ b/app/views/projects/index.rb @@ -15,7 +15,7 @@ :description => project.description(:en_US), :project_dom_id => project_dom_id(project), :github_u...
Add a comma to the last entry in the Hash * This is more a case of preference. Including the comma on the last entry makes it so you can more easily reorder the entries. It also allows you to add new entries without worrying about modifying any further code, aside from the lines being added.
diff --git a/app/views/api/v1/commodity_merchandising/contracts/index.json.jbuilder b/app/views/api/v1/commodity_merchandising/contracts/index.json.jbuilder index abc1234..def5678 100644 --- a/app/views/api/v1/commodity_merchandising/contracts/index.json.jbuilder +++ b/app/views/api/v1/commodity_merchandising/contracts...
Implement the missing fields in the contract reponse
diff --git a/db/migrate/20130328151958_add_status_string_indices.rb b/db/migrate/20130328151958_add_status_string_indices.rb index abc1234..def5678 100644 --- a/db/migrate/20130328151958_add_status_string_indices.rb +++ b/db/migrate/20130328151958_add_status_string_indices.rb @@ -0,0 +1,8 @@+class AddStatusStringIndice...
Make sure active record filters that are often used are indexed
diff --git a/Bugsnag.podspec b/Bugsnag.podspec index abc1234..def5678 100644 --- a/Bugsnag.podspec +++ b/Bugsnag.podspec @@ -5,30 +5,15 @@ s.summary = "Cocoa notifier for SDK for bugsnag.com" s.homepage = "https://bugsnag.com" s.license = 'MIT' - s.author = { "Bugsnag" => "notifiers@bugsnag...
Remove KSCrash source, settings from podspec
diff --git a/app/concerns/viewable.rb b/app/concerns/viewable.rb index abc1234..def5678 100644 --- a/app/concerns/viewable.rb +++ b/app/concerns/viewable.rb @@ -42,6 +42,7 @@ private def view_for(user) + raise("view_for(#{user.id}) but @view.user_id is #{@view.user_id}") if @view && user.id != @view.use...
Throw in a sanity check for Viewable's view_for caching
diff --git a/lib/cdc_migration_testing/fixtures/web_conference.rb b/lib/cdc_migration_testing/fixtures/web_conference.rb index abc1234..def5678 100644 --- a/lib/cdc_migration_testing/fixtures/web_conference.rb +++ b/lib/cdc_migration_testing/fixtures/web_conference.rb @@ -19,6 +19,7 @@ module CdcFixtures def self.cr...
spec: Set empty settings hash when creating a PluginSetting Plugin.enabled? will return false if the PluginSetting has an empty settings hash, even if PluginSetting.disabled is false. A conference-type plugin needs to be enabled before a WebConference can be created. And a WebConference needs to be created to test th...
diff --git a/lib/maskable_attribute/acts_as_maskable_attribute.rb b/lib/maskable_attribute/acts_as_maskable_attribute.rb index abc1234..def5678 100644 --- a/lib/maskable_attribute/acts_as_maskable_attribute.rb +++ b/lib/maskable_attribute/acts_as_maskable_attribute.rb @@ -6,6 +6,14 @@ end module ClassMethods...
Add Rdoc Comment to maskable_attribute Method
diff --git a/FeedKit.podspec b/FeedKit.podspec index abc1234..def5678 100644 --- a/FeedKit.podspec +++ b/FeedKit.podspec @@ -1,6 +1,6 @@ Pod::Spec.new do |s| s.name = 'FeedKit' - s.version = '9.0.1' + s.version = '9.1.0' s.license = 'MIT' s.summary = 'An RSS, Atom and JSON Feed parser written in Swift' s....
Fix podspec version to 9.1.0
diff --git a/spec/rspec/expectations/minitest_integration_spec.rb b/spec/rspec/expectations/minitest_integration_spec.rb index abc1234..def5678 100644 --- a/spec/rspec/expectations/minitest_integration_spec.rb +++ b/spec/rspec/expectations/minitest_integration_spec.rb @@ -10,12 +10,12 @@ context "once required", :s...
Improve our spec for minitest integration.
diff --git a/modules/auxiliary/scanner/http/wordpress/wp_ninja_forms_xss_scanner.rb b/modules/auxiliary/scanner/http/wordpress/wp_ninja_forms_xss_scanner.rb index abc1234..def5678 100644 --- a/modules/auxiliary/scanner/http/wordpress/wp_ninja_forms_xss_scanner.rb +++ b/modules/auxiliary/scanner/http/wordpress/wp_ninja_...
Add WP Ninja Forms XSS Vulnerability Module
diff --git a/lib/engineyard-serverside-adapter/version.rb b/lib/engineyard-serverside-adapter/version.rb index abc1234..def5678 100644 --- a/lib/engineyard-serverside-adapter/version.rb +++ b/lib/engineyard-serverside-adapter/version.rb @@ -1,7 +1,7 @@ module EY module Serverside class Adapter - VERSION = ...
Add .pre for next release
diff --git a/lib/html/pipeline/syntax_highlight_filter.rb b/lib/html/pipeline/syntax_highlight_filter.rb index abc1234..def5678 100644 --- a/lib/html/pipeline/syntax_highlight_filter.rb +++ b/lib/html/pipeline/syntax_highlight_filter.rb @@ -1,8 +1,7 @@ begin require 'linguist' rescue LoadError - $stderr.puts "You ...
Raise the roof---I mean, error
diff --git a/lib/generators/knock/token_controller_generator.rb b/lib/generators/knock/token_controller_generator.rb index abc1234..def5678 100644 --- a/lib/generators/knock/token_controller_generator.rb +++ b/lib/generators/knock/token_controller_generator.rb @@ -13,7 +13,7 @@ end def add_route - route...
Add missing quote in generated route
diff --git a/lib/local_transaction_location_identifier.rb b/lib/local_transaction_location_identifier.rb index abc1234..def5678 100644 --- a/lib/local_transaction_location_identifier.rb +++ b/lib/local_transaction_location_identifier.rb @@ -40,7 +40,7 @@ case type when 'DIS' then 'district' when 'CTY' the...
Add LGD to the area types that we support We support Northern Ireland councils now, but we need to allow them to be found. This area type is already supported in [find-local-council](https://github.com/alphagov/frontend/blob/master/app/controllers/find_local_council_controller.rb#L8) and by adding it to the list here,...
diff --git a/lib/metacrunch/job/dsl/dependency_support.rb b/lib/metacrunch/job/dsl/dependency_support.rb index abc1234..def5678 100644 --- a/lib/metacrunch/job/dsl/dependency_support.rb +++ b/lib/metacrunch/job/dsl/dependency_support.rb @@ -1,3 +1,5 @@+require "rubygems/dependency_installer" + module Metacrunch cla...
Use Gem::DependecyInstaller to install gems.
diff --git a/lib/metal_archives/concerns/initializable.rb b/lib/metal_archives/concerns/initializable.rb index abc1234..def5678 100644 --- a/lib/metal_archives/concerns/initializable.rb +++ b/lib/metal_archives/concerns/initializable.rb @@ -19,7 +19,7 @@ # Set properties # def set(**attributes) - ...
Use setter instead of instance_variable_set
diff --git a/lib/netsuite/records/deposit_payment_list.rb b/lib/netsuite/records/deposit_payment_list.rb index abc1234..def5678 100644 --- a/lib/netsuite/records/deposit_payment_list.rb +++ b/lib/netsuite/records/deposit_payment_list.rb @@ -1,35 +1,15 @@ module NetSuite module Records - class DepositPaymentList -...
Use sublist on deposit payment sublist This may be a breaking change for some people!
diff --git a/app/models/paper_role.rb b/app/models/paper_role.rb index abc1234..def5678 100644 --- a/app/models/paper_role.rb +++ b/app/models/paper_role.rb @@ -6,6 +6,8 @@ validates :paper, presence: true after_save :assign_tasks_to_editor, if: -> { user_id_changed? && role == 'editor' } + + validates_uniquene...
Validate uniqueness of collaborator paper roles.
diff --git a/app/models/repository.rb b/app/models/repository.rb index abc1234..def5678 100644 --- a/app/models/repository.rb +++ b/app/models/repository.rb @@ -37,13 +37,14 @@ end def best_record(metric) - sort_metric_scores(metric, 'desc').first + sort_metric_scores(metric, 'desc').first.to_hash end ...
Add to_hash to best and worst record methods Similar to the previous commit I have added the to_hash conversion to the methods for retrieving the best and worst record with respect to a certain metric. Signed-off-by: Konrad Reiche <4ff0213f56e2082fcd8c882d04c546881c579ce4@gmail.com>
diff --git a/lib/game.rb b/lib/game.rb index abc1234..def5678 100644 --- a/lib/game.rb +++ b/lib/game.rb @@ -3,12 +3,17 @@ class Game + attr_accessor :ttt + def initialize(tictactoe = nil) @ttt = tictactoe end + def prompt_user_for_input + return "Enter a number #{@ttt.valid_slots.join(", ")} to p...
Refactor for single responsibility of methods for get_user_input
diff --git a/lib/checks/check_response_splitting.rb b/lib/checks/check_response_splitting.rb index abc1234..def5678 100644 --- a/lib/checks/check_response_splitting.rb +++ b/lib/checks/check_response_splitting.rb @@ -0,0 +1,18 @@+require 'checks/base_check' +require 'processors/lib/find_call' + +#Warn about response sp...
Check for response splitting vulnerability http://groups.google.com/group/rubyonrails-security/t/6ffc93bde0298768
diff --git a/metadata.rb b/metadata.rb index abc1234..def5678 100644 --- a/metadata.rb +++ b/metadata.rb @@ -4,11 +4,11 @@ license "Apache 2.0" description "Sets up a shared admin user to manage the system" long_description IO.read(File.join(File.dirname(__FILE__), 'README.md')) -version "1.1.0...
Remove version constraint on sudo cookbook
diff --git a/lib/hyper_admin/resource_controller.rb b/lib/hyper_admin/resource_controller.rb index abc1234..def5678 100644 --- a/lib/hyper_admin/resource_controller.rb +++ b/lib/hyper_admin/resource_controller.rb @@ -1,6 +1,7 @@ module HyperAdmin class ResourceController < ActionController::Base before_action :...
Create resources when submitted through new view
diff --git a/lib/pier.rb b/lib/pier.rb index abc1234..def5678 100644 --- a/lib/pier.rb +++ b/lib/pier.rb @@ -1,3 +1,4 @@+require 'English' require 'pier/moor' require 'pier/pier' require 'pier/version'
Fix undefined CHILD_STATUS variable error ``` lib/pier.rb:16: warning: global variable `$CHILD_STATUS' not initialized ```
diff --git a/app/models/project.rb b/app/models/project.rb index abc1234..def5678 100644 --- a/app/models/project.rb +++ b/app/models/project.rb @@ -14,7 +14,7 @@ acts_as_followable acts_as_taggable # Alias for acts_as_taggable_on :tags - scope :with_github_url, -> { where( "github_url <> ''" ) } + scope :with...
Make scope in Project model clearer
diff --git a/app/models/section.rb b/app/models/section.rb index abc1234..def5678 100644 --- a/app/models/section.rb +++ b/app/models/section.rb @@ -6,4 +6,7 @@ field :sort, type: Integer, default: 0 has_many :nodes, dependent: :destroy + + default_scope { desc(:sort) } + end
Use the default_scope macro to set a default scope for all operations on the model.
diff --git a/lib/rlrw.rb b/lib/rlrw.rb index abc1234..def5678 100644 --- a/lib/rlrw.rb +++ b/lib/rlrw.rb @@ -7,9 +7,9 @@ def self.all(key, nodes) res = [] nodes.each do |node| - res << [node, self.phash(key, node)] + res << { node: node, weight: self.phash(key, node) } end - ...
Return a list of results, where each result is a hash with node and weight.
diff --git a/lib/metacrunch/ubpb/record/zählung.rb b/lib/metacrunch/ubpb/record/zählung.rb index abc1234..def5678 100644 --- a/lib/metacrunch/ubpb/record/zählung.rb +++ b/lib/metacrunch/ubpb/record/zählung.rb @@ -1,4 +1,45 @@ require_relative "./generisches_element" class Metacrunch::UBPB::Record::Zählung < Metacrun...
Add RDA Support for field 596
diff --git a/lib/modules/adapters/simple_adapter.rb b/lib/modules/adapters/simple_adapter.rb index abc1234..def5678 100644 --- a/lib/modules/adapters/simple_adapter.rb +++ b/lib/modules/adapters/simple_adapter.rb @@ -1,5 +1,14 @@ class Adapters::SimpleAdapter < Adapters::Base + #Example on how to invoke the adapter ...
Comment about how to invoke the adapter
diff --git a/lib/sastrawi/stemmer/cached_stemmer.rb b/lib/sastrawi/stemmer/cached_stemmer.rb index abc1234..def5678 100644 --- a/lib/sastrawi/stemmer/cached_stemmer.rb +++ b/lib/sastrawi/stemmer/cached_stemmer.rb @@ -1,3 +1,5 @@+require 'filter/text_normalizer' + module Sastrawi module Stemmer class CachedStem...
Call "TextNormalizer" to normalize text
diff --git a/lib/toy_robot_simulator/application.rb b/lib/toy_robot_simulator/application.rb index abc1234..def5678 100644 --- a/lib/toy_robot_simulator/application.rb +++ b/lib/toy_robot_simulator/application.rb @@ -1,4 +1,3 @@-require 'pry' require_relative 'factory' require_relative 'command/matcher/matcher' @@ ...
Remove production dependancy on 'pry'
diff --git a/crack.gemspec b/crack.gemspec index abc1234..def5678 100644 --- a/crack.gemspec +++ b/crack.gemspec @@ -9,8 +9,7 @@ gem.homepage = "http://github.com/jnunemaker/crack" gem.executables = `git ls-files -- bin/*`.split("\n").map{ |f| File.basename(f) } - gem.files = `git ls-files`.split...
Exclude tests (and fixtures) from bundled gem
diff --git a/lib/metasploit_data_models/active_record_models/ref.rb b/lib/metasploit_data_models/active_record_models/ref.rb index abc1234..def5678 100644 --- a/lib/metasploit_data_models/active_record_models/ref.rb +++ b/lib/metasploit_data_models/active_record_models/ref.rb @@ -2,6 +2,7 @@ def self.included(base) ...
Add missing has_many back to the model
diff --git a/metadata.rb b/metadata.rb index abc1234..def5678 100644 --- a/metadata.rb +++ b/metadata.rb @@ -9,7 +9,7 @@ supports 'ubuntu' # Compat resource is required for 12.5+ as resource API changed between 12.4 and 12.5 -supports 'compat_resource' +depends 'compat_resource' depends 'java' depends 'authbind'...
Move to Chef 12 support
diff --git a/proxy/recipes/deploy.rb b/proxy/recipes/deploy.rb index abc1234..def5678 100644 --- a/proxy/recipes/deploy.rb +++ b/proxy/recipes/deploy.rb @@ -10,16 +10,5 @@ command "/usr/sbin/proxy2ensite #{application} #{deploy[:deploy_to]} #{deploy[:domains].join(',')}" notifies :reload, "service[nginx]" end - ...
Remove automatically restart nodeJs App
diff --git a/lib/action_controller/parents.rb b/lib/action_controller/parents.rb index abc1234..def5678 100644 --- a/lib/action_controller/parents.rb +++ b/lib/action_controller/parents.rb @@ -1,7 +1,4 @@ require 'active_support/core_ext/string/conversions' -require 'action_controller/parents/finder' -require 'action_c...
Fix 'superclass mismatch for class Parents' error
diff --git a/metadata.rb b/metadata.rb index abc1234..def5678 100644 --- a/metadata.rb +++ b/metadata.rb @@ -4,7 +4,7 @@ source_url 'https://github.com/osuosl-cookbooks/resource_from_hash' issues_url 'https://github.com/osuosl-cookbooks/resource_from_hash/issues' license 'Apache-2.0' -chef_versio...
Update Chef dependency to >= 16
diff --git a/metadata.rb b/metadata.rb index abc1234..def5678 100644 --- a/metadata.rb +++ b/metadata.rb @@ -16,7 +16,7 @@ depends '7-zip', '~> 1.0' depends 'build-essential', '~> 2.0' -depends 'chef-sugar', '~> 1.1' +depends 'chef-sugar', '~> 2.0' depends 'homebrew', '~> 1.5' depends 'w...
Update Chef Sugar to v2.0.0 to fix an installation bug
diff --git a/metadata.rb b/metadata.rb index abc1234..def5678 100644 --- a/metadata.rb +++ b/metadata.rb @@ -7,6 +7,8 @@ %w{ debian ubuntu + centos + redhat }.each do |os| supports os end
Add centos and redhat to supported platforms
diff --git a/neighborly-balanced-creditcard.gemspec b/neighborly-balanced-creditcard.gemspec index abc1234..def5678 100644 --- a/neighborly-balanced-creditcard.gemspec +++ b/neighborly-balanced-creditcard.gemspec @@ -22,4 +22,5 @@ spec.add_dependency 'rails' spec.add_development_dependency 'rspec-rails' + spec....
Add sqlite3 as dependency to development
diff --git a/lib/mail_room/mailbox_watcher.rb b/lib/mail_room/mailbox_watcher.rb index abc1234..def5678 100644 --- a/lib/mail_room/mailbox_watcher.rb +++ b/lib/mail_room/mailbox_watcher.rb @@ -60,10 +60,10 @@ def connection @connection ||= - if @mailbox.imap? + if @mailbox.microsoft_graph? + ...
Swap connection to check for Microsoft Graph first
diff --git a/lib/puppet/type/file_fragment.rb b/lib/puppet/type/file_fragment.rb index abc1234..def5678 100644 --- a/lib/puppet/type/file_fragment.rb +++ b/lib/puppet/type/file_fragment.rb @@ -9,8 +9,16 @@ desc "TODO" end + newparam(:target) do + desc "Deprecated. Use *path* instead." + end + ...
Support target parameter as an alias for path "path" defaults to "target" for easier transition from R.I.Pienaar's concat module: https://github.com/ripienaar/puppet-concat
diff --git a/lib/nehm.rb b/lib/nehm.rb index abc1234..def5678 100644 --- a/lib/nehm.rb +++ b/lib/nehm.rb @@ -43,7 +43,7 @@ end def initialized? - File.exist?(Cfg::FILE_PATH) + Cfg.exist? end end
Use Cfg method for check of existence of Cfg file
diff --git a/lib/dap/input.rb b/lib/dap/input.rb index abc1234..def5678 100644 --- a/lib/dap/input.rb +++ b/lib/dap/input.rb @@ -64,8 +64,7 @@ begin json = Oj.load(line.strip, mode: :strict) rescue - $stderr.puts "\nRecord is not valid JSON and will be skipped." - $stderr.puts line +...
Improve logging for invalid JSON
diff --git a/lib/likes/set.rb b/lib/likes/set.rb index abc1234..def5678 100644 --- a/lib/likes/set.rb +++ b/lib/likes/set.rb @@ -1,7 +1,7 @@ module Likes # Job: Understands patterns in people likings class Set - # Default engine - simplest one + # Default engine - a fast one # # @see Engines::Fast...
Update default engine constant description
diff --git a/lib/rapns/app.rb b/lib/rapns/app.rb index abc1234..def5678 100644 --- a/lib/rapns/app.rb +++ b/lib/rapns/app.rb @@ -4,7 +4,7 @@ attr_accessible :name, :environment, :certificate, :password, :connections, :auth_key - has_many :notifications + has_many :notifications, :class_name => 'Rapns::Not...
Add explicit class_name to properly handle introspection.
diff --git a/lib/sg_mailer.rb b/lib/sg_mailer.rb index abc1234..def5678 100644 --- a/lib/sg_mailer.rb +++ b/lib/sg_mailer.rb @@ -11,7 +11,7 @@ def configure(delivery_processor: default_delivery_processor, test_client: false, **client_options) - self.client = test_client ? TestClient.new : Client...
Fix the clients options typo
diff --git a/lib/syoboemon.rb b/lib/syoboemon.rb index abc1234..def5678 100644 --- a/lib/syoboemon.rb +++ b/lib/syoboemon.rb @@ -4,6 +4,7 @@ require 'rubygems' require 'faraday' require 'happymapper' +require "json" # syoboemon ruby files # version file
Add gem to require rubygems list
diff --git a/mrbgem.rake b/mrbgem.rake index abc1234..def5678 100644 --- a/mrbgem.rake +++ b/mrbgem.rake @@ -1,4 +1,6 @@ MRuby::Gem::Specification.new('mruby-singleton') do |spec| spec.license = 'MIT' spec.author = 'ksss <co000ri@gmail.com>' + + spec.add_test_dependency 'mruby-metaprog', core: 'mruby-metaprog' ...
Fix test failure on mruby-2.0.0.
diff --git a/metadata.rb b/metadata.rb index abc1234..def5678 100644 --- a/metadata.rb +++ b/metadata.rb @@ -4,7 +4,7 @@ license "Apache 2.0" description "Installs/Configures td-agent" long_description IO.read(File.join(File.dirname(__FILE__), 'README.md')) -version "2.0.3" +version "2...
Fix version to be released as 2.1.0
diff --git a/metadata.rb b/metadata.rb index abc1234..def5678 100644 --- a/metadata.rb +++ b/metadata.rb @@ -4,7 +4,7 @@ license 'Apache-2.0' description 'Manages unbound DNS resolver' long_description IO.read(File.join(File.dirname(__FILE__), 'README.md')) -version '0.1.0' +version '0...
Move to Sous Chefs organistaion Release 0.1.1 - see changelog.md for more information
diff --git a/lib/spdx.rb b/lib/spdx.rb index abc1234..def5678 100644 --- a/lib/spdx.rb +++ b/lib/spdx.rb @@ -8,6 +8,7 @@ end def self.closest(name) + name.gsub!(/software|license/i, '') match = names.sort_by do |key| Text::Levenshtein.distance(name, key) end.first
Remove a couple stop words before searching
diff --git a/lib/booking_locations/location.rb b/lib/booking_locations/location.rb index abc1234..def5678 100644 --- a/lib/booking_locations/location.rb +++ b/lib/booking_locations/location.rb @@ -52,11 +52,7 @@ end def name_for(location_id) - if id == location_id - name - else - loca...
Refactor to use newly introduced helper
diff --git a/lib/gitlab/tasks/purge_cache.rake b/lib/gitlab/tasks/purge_cache.rake index abc1234..def5678 100644 --- a/lib/gitlab/tasks/purge_cache.rake +++ b/lib/gitlab/tasks/purge_cache.rake @@ -11,10 +11,6 @@ "/var/cache/omnibus/src/gitlab-shell", "/var/cache/omnibus/src/gitlab-workhorse", - # Fo...
Remove cacerts.pem from list of files to be purged
diff --git a/lib/helios/static_color_effect.rb b/lib/helios/static_color_effect.rb index abc1234..def5678 100644 --- a/lib/helios/static_color_effect.rb +++ b/lib/helios/static_color_effect.rb @@ -10,13 +10,9 @@ def change! @lights = Array(@lights) - t = [] @lights.each do |light| - t <<...
Remove threads because it makes the lights jittery
diff --git a/recipes/spark_worker.rb b/recipes/spark_worker.rb index abc1234..def5678 100644 --- a/recipes/spark_worker.rb +++ b/recipes/spark_worker.rb @@ -24,14 +24,14 @@ action :install end -if node['spark'].key? 'spark_env' and node['spark']['spark_env'].key? 'spark_worker_dir' +if node['spark'].key?('spark_en...
Use && instead of and
diff --git a/lib/middleman-deploy/extension.rb b/lib/middleman-deploy/extension.rb index abc1234..def5678 100644 --- a/lib/middleman-deploy/extension.rb +++ b/lib/middleman-deploy/extension.rb @@ -17,8 +17,11 @@ options = Options.new(options_hash) yield options if block_given? + # Default opti...
Comment and separate default options.
diff --git a/lib/quesadilla/core_ext/string.rb b/lib/quesadilla/core_ext/string.rb index abc1234..def5678 100644 --- a/lib/quesadilla/core_ext/string.rb +++ b/lib/quesadilla/core_ext/string.rb @@ -9,15 +9,20 @@ def q_truncate(truncate_at, options = {}) return dup unless length > truncate_at + # Default omis...
Clean up truncate a bit
diff --git a/lib/rake/ruby182_test_unit_fix.rb b/lib/rake/ruby182_test_unit_fix.rb index abc1234..def5678 100644 --- a/lib/rake/ruby182_test_unit_fix.rb +++ b/lib/rake/ruby182_test_unit_fix.rb @@ -1,3 +1,5 @@+# TODO: Remove in rake 11 + # Local Rake override to fix bug in Ruby 0.8.2 module Test # ...
Mark the 1.8.2 test/unit fix for removal in Rake 11
diff --git a/lib/rspec/requestable-examples.rb b/lib/rspec/requestable-examples.rb index abc1234..def5678 100644 --- a/lib/rspec/requestable-examples.rb +++ b/lib/rspec/requestable-examples.rb @@ -31,15 +31,11 @@ end def requestable_describe(description, options={}, &blk) - requestable_describes << de...
Use proper describe label text when doing requestable_describe.
diff --git a/test/spec/configured.rb b/test/spec/configured.rb index abc1234..def5678 100644 --- a/test/spec/configured.rb +++ b/test/spec/configured.rb @@ -1,22 +1,43 @@ require_relative 'spec_init' -module ConfiguredRandomUUID - class Example - attr_accessor :uuid +module Configured + module UUID + class Ex...
Test coverage for configuration is improved