diff
stringlengths
65
26.7k
message
stringlengths
7
9.92k
diff --git a/core/db/default/spree/zones.rb b/core/db/default/spree/zones.rb index abc1234..def5678 100644 --- a/core/db/default/spree/zones.rb +++ b/core/db/default/spree/zones.rb @@ -1,7 +1,7 @@ eu_vat = Spree::Zone.find_or_create_by!(name: "EU_VAT", description: "Countries that make up the EU VAT zone.") north_amer...
Add Croatia, Czech Republic and Greece to EU_VAT This change was already merged on Sep 17, 2015: e645b8c6d318b639bb3bbc5d507c6212565fb1a But was overwritten/lost by commit on Dec 3, 2015: b08f40eefe670ad07dc0019f8ba7c49d6ab4dcc4
diff --git a/ffi-proj4.gemspec b/ffi-proj4.gemspec index abc1234..def5678 100644 --- a/ffi-proj4.gemspec +++ b/ffi-proj4.gemspec @@ -18,7 +18,7 @@ s.require_paths = ["lib"] s.add_dependency("ffi", [">= 1.0.0"]) - s.add_dependency("rdoc") - s.add_dependency("rake", ["~> 0.9"]) + s.add_development_dependency("r...
Make these gems into development dependencies.
diff --git a/app/controllers/api/jwts_controller.rb b/app/controllers/api/jwts_controller.rb index abc1234..def5678 100644 --- a/app/controllers/api/jwts_controller.rb +++ b/app/controllers/api/jwts_controller.rb @@ -1,7 +1,8 @@ class Api::JwtsController < Api::ApiApplicationController def show - token = AuthTo...
Refresh JWT with existing jwt data When a JWT is refreshed, we currently loose all the custom data that was added to it. This fixes it so all existing data is kept in the refreshed JWT.
diff --git a/db/migrate/20120524151543_ensure_documents_can_only_belong_to_a_single_organisation.rb b/db/migrate/20120524151543_ensure_documents_can_only_belong_to_a_single_organisation.rb index abc1234..def5678 100644 --- a/db/migrate/20120524151543_ensure_documents_can_only_belong_to_a_single_organisation.rb +++ b/db...
Fix data-correction migration to work where no data needs fixing.
diff --git a/app/models/member.rb b/app/models/member.rb index abc1234..def5678 100644 --- a/app/models/member.rb +++ b/app/models/member.rb @@ -23,8 +23,8 @@ # TODO: only required for ISIC validates :phone, :presence => true - def serializable_hash(options = {}) - super(options.merge({ + def serializable_h...
Revert "this code makes more sense imo" This reverts commit bbf58114408dc5d9c6c0e2a92b7464cfdb7d2353.
diff --git a/app/inputs/rich_picker_input.rb b/app/inputs/rich_picker_input.rb index abc1234..def5678 100644 --- a/app/inputs/rich_picker_input.rb +++ b/app/inputs/rich_picker_input.rb @@ -15,7 +15,13 @@ input_wrapping do label_html << - builder.text_field(method, local_input_options.merge...
Add :hidden_field config option for the input to use a hidden field instead of text_field
diff --git a/config/deploy.rb b/config/deploy.rb index abc1234..def5678 100644 --- a/config/deploy.rb +++ b/config/deploy.rb @@ -5,7 +5,7 @@ set :host, "wompt.com" set :scm, :git -set :repository, "git@github.com:abtinf/wompt.git" +set :repository, "git@github.com:Wompt/wompt.com.git" set :git_enable_submodules, tr...
Change git repo to wompt/wompt.com
diff --git a/config/deploy.rb b/config/deploy.rb index abc1234..def5678 100644 --- a/config/deploy.rb +++ b/config/deploy.rb @@ -23,6 +23,7 @@ end end +set :deploy_via, :export namespace :rake do desc "Generate a sitemap on a remote server."
Make Capistrano take longer, by doing an export Former-commit-id: ad47e44e2e7b57de2900fd01bf33b69e5598c2b8
diff --git a/app/graphql/types/query_type.rb b/app/graphql/types/query_type.rb index abc1234..def5678 100644 --- a/app/graphql/types/query_type.rb +++ b/app/graphql/types/query_type.rb @@ -3,19 +3,13 @@ # Add root-level fields here. # They will be entry points for queries on your schema. - field :lives, L...
Remove arg `year` from graphql `lives` query
diff --git a/config/routes.rb b/config/routes.rb index abc1234..def5678 100644 --- a/config/routes.rb +++ b/config/routes.rb @@ -1,7 +1,11 @@ Rails.application.routes.draw do - devise_for :users, path: 'user' + devise_for :users, path: 'user', :skip => [:registrations] + as :user do + get 'users/edit' => '...
Add back some registrations paths to allow users to update themselves
diff --git a/config/routes.rb b/config/routes.rb index abc1234..def5678 100644 --- a/config/routes.rb +++ b/config/routes.rb @@ -20,7 +20,7 @@ get :search_relatable_items, constraints: { format: :json } end end - + resources :tags do member do put :publish @@ -28,4 +28,6 @@ end roo...
Include admin template style guide * Keep a reference to admin design patterns * Show how local styles may have affected those patterns
diff --git a/Casks/acorn3.rb b/Casks/acorn3.rb index abc1234..def5678 100644 --- a/Casks/acorn3.rb +++ b/Casks/acorn3.rb @@ -2,8 +2,8 @@ version '3.5.2' sha256 'ffc4cd551b9eb2ebadfe8e59c95e84b1f59538d7915eff63dd6c3efdca7858e6' - url "http://flyingmeat.com/download/Acorn-#{version}.zip" - homepage 'http://flyin...
Update Acorn3 URL and hompage
diff --git a/Casks/bitpim.rb b/Casks/bitpim.rb index abc1234..def5678 100644 --- a/Casks/bitpim.rb +++ b/Casks/bitpim.rb @@ -2,6 +2,7 @@ version '1.0.7' sha256 '567d41ececc8c416746c3aa9365182797b339001d255dc4da7acc285bb289880' + # sourceforge.net/project/bitpim was verified as official when first introduced to ...
Fix `url` stanza comment for BitPim.
diff --git a/Casks/marked.rb b/Casks/marked.rb index abc1234..def5678 100644 --- a/Casks/marked.rb +++ b/Casks/marked.rb @@ -9,5 +9,7 @@ homepage 'http://marked2app.com' license :commercial + auto_updates true + app 'Marked 2.app' end
Add auto_updates flag to Marked
diff --git a/plugins/docker/check-container.rb b/plugins/docker/check-container.rb index abc1234..def5678 100644 --- a/plugins/docker/check-container.rb +++ b/plugins/docker/check-container.rb @@ -0,0 +1,59 @@+#!/usr/bin/env ruby +# +# Checks that a given Docker container is running +# === +# +# This is a simple check ...
Add a check to verify a Docker container is running
diff --git a/plugins/interview_gear_scanner.rb b/plugins/interview_gear_scanner.rb index abc1234..def5678 100644 --- a/plugins/interview_gear_scanner.rb +++ b/plugins/interview_gear_scanner.rb @@ -18,7 +18,7 @@ [:before_post_write] end - def process(event, interview, &block) + def process(event, interview) ...
Remove the block from the process method
diff --git a/db/migrate/20190212150445_change_agreement_transaction_id_to_bigint.rb b/db/migrate/20190212150445_change_agreement_transaction_id_to_bigint.rb index abc1234..def5678 100644 --- a/db/migrate/20190212150445_change_agreement_transaction_id_to_bigint.rb +++ b/db/migrate/20190212150445_change_agreement_transac...
Update agreement_transaction_id primary and foreign keys to bigint
diff --git a/spec/unit/client_spec.rb b/spec/unit/client_spec.rb index abc1234..def5678 100644 --- a/spec/unit/client_spec.rb +++ b/spec/unit/client_spec.rb @@ -0,0 +1,78 @@+require "spec_helper" + +module Vault + describe Client do + let(:client) { subject } + + context "configuration" do + it "is a config...
Add unit tests for client
diff --git a/business.gemspec b/business.gemspec index abc1234..def5678 100644 --- a/business.gemspec +++ b/business.gemspec @@ -23,5 +23,5 @@ spec.add_development_dependency "gc_ruboconfig", "~> 2.23.0" spec.add_development_dependency "rspec", "~> 3.1" spec.add_development_dependency "rspec_junit_formatter", "...
Update rubocop requirement from ~> 1.8.0 to ~> 1.9.1 Updates the requirements on [rubocop](https://github.com/rubocop-hq/rubocop) to permit the latest version. - [Release notes](https://github.com/rubocop-hq/rubocop/releases) - [Changelog](https://github.com/rubocop-hq/rubocop/blob/master/CHANGELOG.md) - [Commits](htt...
diff --git a/test/fixtures/cookbooks/selenium_test/recipes/node.rb b/test/fixtures/cookbooks/selenium_test/recipes/node.rb index abc1234..def5678 100644 --- a/test/fixtures/cookbooks/selenium_test/recipes/node.rb +++ b/test/fixtures/cookbooks/selenium_test/recipes/node.rb @@ -4,15 +4,14 @@ capabilities = [] -unless...
Allow firefox install on debian platform
diff --git a/event_store-messaging.gemspec b/event_store-messaging.gemspec index abc1234..def5678 100644 --- a/event_store-messaging.gemspec +++ b/event_store-messaging.gemspec @@ -2,7 +2,7 @@ Gem::Specification.new do |s| s.name = 'event_store-messaging' s.summary = 'Messaging primitives for EventStore using the...
Package version is increased from 0.1.17 to 0.1.18
diff --git a/lita-hipchat.gemspec b/lita-hipchat.gemspec index abc1234..def5678 100644 --- a/lita-hipchat.gemspec +++ b/lita-hipchat.gemspec @@ -13,7 +13,7 @@ spec.test_files = spec.files.grep(%r{^(test|spec|features)/}) spec.require_paths = ["lib"] - spec.add_runtime_dependency "lita", "~> 2.0" + spec.add_...
Support newer versions of lita
diff --git a/test/retry_queue_test.rb b/test/retry_queue_test.rb index abc1234..def5678 100644 --- a/test/retry_queue_test.rb +++ b/test/retry_queue_test.rb @@ -13,4 +13,13 @@ perform_next_job(@worker) end + + def test_retry_delayed_failed_jobs_in_dynamic_queue + queue_name = "dynamic_queue_#{Time.now.to_i...
Test for specifying retry queue dynamically
diff --git a/Casks/appium.rb b/Casks/appium.rb index abc1234..def5678 100644 --- a/Casks/appium.rb +++ b/Casks/appium.rb @@ -1,6 +1,6 @@ cask :v1 => 'appium' do - version '1.3.5' - sha256 '88fb3d798e3a28452d8477f78d182b035116dcd1569e444bdf08603c927b73d7' + version '1.3.6' + sha256 '76bc810e07aa629f4dbf07c37d46e7a94...
Update Appium version to 1.3.6 This commit updates the version variable and the download SHA
diff --git a/Casks/openlp.rb b/Casks/openlp.rb index abc1234..def5678 100644 --- a/Casks/openlp.rb +++ b/Casks/openlp.rb @@ -1,10 +1,11 @@ class Openlp < Cask - version '2.0.4' - sha256 '24850da1e2d75b17d76cf102721d4c5e56d8faaa97ce1194577264c8edc6cc70' + version '2.0.5' + sha256 '0ba5a37c359394c277e221f8ca74191d342...
Fix OpenLP.app & upgrade to 2.0.5 Closes #7310.
diff --git a/Casks/vienna.rb b/Casks/vienna.rb index abc1234..def5678 100644 --- a/Casks/vienna.rb +++ b/Casks/vienna.rb @@ -1,12 +1,18 @@ cask :v1 => 'vienna' do - version '3.0.0' - sha256 'e61f44b7be0f1f49cf6c735d8e03071141ddaca1d5ff65db29f786ee3dfeded3' + version '3.0.1' + sha256 'f6f89ebdf76b120fea7fa4b18ce26f2...
Upgrade Vienna.app to v3.0.1 and add zap support
diff --git a/bots/digg_scraper.rb b/bots/digg_scraper.rb index abc1234..def5678 100644 --- a/bots/digg_scraper.rb +++ b/bots/digg_scraper.rb @@ -0,0 +1,46 @@+#!/usr/bin/ruby + +require 'rubygems' +require 'open-uri' +require 'hpricot' + +def BuildURL(query, pagenumber) + return "http://digg.com/search/page" + pagenu...
Add a digg scraping tool. WARNING: Currently does not work!
diff --git a/core/app/helpers/form_helper.rb b/core/app/helpers/form_helper.rb index abc1234..def5678 100644 --- a/core/app/helpers/form_helper.rb +++ b/core/app/helpers/form_helper.rb @@ -1,7 +1,7 @@ module FormHelper def possible_error_for_field(resource, fieldname) if resource.errors[fieldname].any? - c...
Use semicolon to separate error messages.
diff --git a/core/string/try_convert_spec.rb b/core/string/try_convert_spec.rb index abc1234..def5678 100644 --- a/core/string/try_convert_spec.rb +++ b/core/string/try_convert_spec.rb @@ -15,7 +15,7 @@ String.try_convert(obj).should equal(str) end - it "returns nil when there is no :to_ary" do + ...
String.try_convert: Fix typo: :to_ary -> :to_str
diff --git a/main.rb b/main.rb index abc1234..def5678 100644 --- a/main.rb +++ b/main.rb @@ -21,17 +21,23 @@ svs = MultiJson.load(ENV["VCAP_SERVICES"]) uri = svs["rabbitmq-1.0"].first["credentials"]["uri"] conn = Bunny.new(uri) - conn.start + begin + conn.start - ch = con...
Handle authentication failures more gracefully
diff --git a/samples/contrib/collections_demo.rb b/samples/contrib/collections_demo.rb index abc1234..def5678 100644 --- a/samples/contrib/collections_demo.rb +++ b/samples/contrib/collections_demo.rb @@ -0,0 +1,61 @@+#!/usr/bin/env jruby +=begin +Original Java source from: http://docs.oracle.com/javafx/2/collections/j...
Add of JavaFX Collections example
diff --git a/spec/tag_spec.rb b/spec/tag_spec.rb index abc1234..def5678 100644 --- a/spec/tag_spec.rb +++ b/spec/tag_spec.rb @@ -0,0 +1,47 @@+require "rspec" +require "gmail/tag" + +class DataError < Exception; end + +describe Tag do + + before(:all) do + @tags = [ "Perso", "Perso/Foo" ] + @tag1 = Tag.new(@tags[...
Add specs for class Tag.
diff --git a/rails-embryo.gemspec b/rails-embryo.gemspec index abc1234..def5678 100644 --- a/rails-embryo.gemspec +++ b/rails-embryo.gemspec @@ -12,7 +12,7 @@ s.required_rubygems_version = ">= 1.3.6" s.files = Dir.glob("lib/**/*") + ["README.md", "History.md", "License.txt"] s.require_path = "lib" - s.add_depe...
Make Rails version dependency open-ended
diff --git a/rakelib/metrics.rake b/rakelib/metrics.rake index abc1234..def5678 100644 --- a/rakelib/metrics.rake +++ b/rakelib/metrics.rake @@ -1,7 +1,8 @@ METRICS_FILES = FileList['lib/**/*.rb'] -task :flog do - sh "flog #{METRICS_FILES}" +task :flog, [:all] do |t, args| + flags = args.all ? "--all" : "" + sh "f...
Add optional all flag to flog task.
diff --git a/config/initializers/need_api.rb b/config/initializers/need_api.rb index abc1234..def5678 100644 --- a/config/initializers/need_api.rb +++ b/config/initializers/need_api.rb @@ -1,4 +1,4 @@ require 'gds_api/need_api' Whitehall.need_api = GdsApi::NeedApi.new(Plek.current.find('need-api'), - ...
Fix to the Need API client config
diff --git a/plot.rb b/plot.rb index abc1234..def5678 100644 --- a/plot.rb +++ b/plot.rb @@ -0,0 +1,49 @@+require "pry" +require "json" + +def sorted_dup_hash(array) + Hash[*array.inject(Hash.new(0)) { |h,e| h[e] += 1; h }. + select { |k,v| v > 1 }.inject({}) { |r, e| r[e.first] = e.last; r }. + sort_by {|_,v| v}.re...
Create simple cytoscape graph processing script Motivation: -wanted to view the results visually Change Explanation: -format a list of points into data for a http://www.cytoscape.org/ graph
diff --git a/config/routes.rb b/config/routes.rb index abc1234..def5678 100644 --- a/config/routes.rb +++ b/config/routes.rb @@ -12,4 +12,4 @@ resources :public_keys, :controller => 'gitolite_public_keys' end -get "gitolite_hook" => "gitolite_hook#index" +post "gitolite_hook", :to => "gitolite_hook#index"
[ROUTES] Use POST method for hook
diff --git a/contrib/requirements-warning.rb b/contrib/requirements-warning.rb index abc1234..def5678 100644 --- a/contrib/requirements-warning.rb +++ b/contrib/requirements-warning.rb @@ -1,24 +1,19 @@-DEBUG = false - # Get the commits before the merge # ex. heads = ["<latest commit of master>", "<previous commit ...
Fix requirements hook falsy test
diff --git a/lib/a_b_plugin/helper.rb b/lib/a_b_plugin/helper.rb index abc1234..def5678 100644 --- a/lib/a_b_plugin/helper.rb +++ b/lib/a_b_plugin/helper.rb @@ -9,7 +9,7 @@ if category || test || extra Test.new(category, test, extra) - elsif ABPlugin.tests && Config.url + elsif ABPlugin...
Check for ABPlugin.categories instead of tests in Helper
diff --git a/search_amazon.rb b/search_amazon.rb index abc1234..def5678 100644 --- a/search_amazon.rb +++ b/search_amazon.rb @@ -15,6 +15,17 @@ def search(key_word) @search_result = @mechanize.get("#{SEARCH_URL}#{URI.escape(key_word)}")) + + @search_result = @limit.map do |i| + product ...
Add scrape from search result and regained an end
diff --git a/lib/crawler_detection.rb b/lib/crawler_detection.rb index abc1234..def5678 100644 --- a/lib/crawler_detection.rb +++ b/lib/crawler_detection.rb @@ -1,5 +1,5 @@ module CrawlerDetection def self.crawler?(user_agent) - !/Googlebot|Mediapartners|AdsBot|curl|Twitterbot|facebookexternalhit|bingbot|Baiduspi...
Add archive.org to crawler list to serve no-js to
diff --git a/spec/acceptance/acceptance_helper.rb b/spec/acceptance/acceptance_helper.rb index abc1234..def5678 100644 --- a/spec/acceptance/acceptance_helper.rb +++ b/spec/acceptance/acceptance_helper.rb @@ -9,13 +9,14 @@ Capybara.default_driver = :selenium Capybara.default_wait_time = 10 -Capybara.default_host ...
Use Chrome as browser in acceptance specs
diff --git a/spec/requests/authentication_spec.rb b/spec/requests/authentication_spec.rb index abc1234..def5678 100644 --- a/spec/requests/authentication_spec.rb +++ b/spec/requests/authentication_spec.rb @@ -1,22 +1,9 @@ require "spec_helper" RSpec.describe "POST /users/sign_in" do - let(:user) { - User.create!...
Use new helpers in other specs
diff --git a/spec/bundler/path_preserver_spec.rb b/spec/bundler/path_preserver_spec.rb index abc1234..def5678 100644 --- a/spec/bundler/path_preserver_spec.rb +++ b/spec/bundler/path_preserver_spec.rb @@ -0,0 +1,54 @@+# frozen_string_literal: true +require "spec_helper" + +describe Bundler::PathPreserver do + describe...
Add unit tests for `Bundler::PathPreserver` module
diff --git a/spec/models/section_edition_spec.rb b/spec/models/section_edition_spec.rb index abc1234..def5678 100644 --- a/spec/models/section_edition_spec.rb +++ b/spec/models/section_edition_spec.rb @@ -6,4 +6,24 @@ it 'stores data in the manual_section_editions collection' do expect(subject.collection.name).t...
Add tests for SectionEdition validation To give me some additional confidence when I come to rename `SectionEdition#section_id`.
diff --git a/exceptions_to_hipchat.gemspec b/exceptions_to_hipchat.gemspec index abc1234..def5678 100644 --- a/exceptions_to_hipchat.gemspec +++ b/exceptions_to_hipchat.gemspec @@ -14,5 +14,5 @@ gem.require_paths = ["lib"] gem.version = ExceptionsToHipchat::VERSION - gem.add_dependency("hipchat", "~> 0.4....
Upgrade hipchat dependency to ~> 0.8
diff --git a/db/seeds/routes_from_varnish.rb b/db/seeds/routes_from_varnish.rb index abc1234..def5678 100644 --- a/db/seeds/routes_from_varnish.rb +++ b/db/seeds/routes_from_varnish.rb @@ -12,7 +12,6 @@ backends = { 'canary-frontend' => {'tls' => false}, 'licensify' => {'tls' => true}, - 'tariff' => {'tls' => fa...
Remove the trade tariff prefix route registration. This is now handled via trade tariff frontend: https://github.com/alphagov/trade-tariff-frontend/pull/189
diff --git a/turbo-sprockets-rails4.gemspec b/turbo-sprockets-rails4.gemspec index abc1234..def5678 100644 --- a/turbo-sprockets-rails4.gemspec +++ b/turbo-sprockets-rails4.gemspec @@ -7,6 +7,7 @@ s.authors = ['Cameron Dutro'] s.email = ['camertron@gmail.com'] s.homepage = 'http://github.com/camertron/turbo...
Add licence declaration to gemspec.
diff --git a/lib/rom/http/handlers.rb b/lib/rom/http/handlers.rb index abc1234..def5678 100644 --- a/lib/rom/http/handlers.rb +++ b/lib/rom/http/handlers.rb @@ -1,3 +1,5 @@+# frozen_string_literal: true + require "rom/http/handlers/json" module ROM
Add missing frozen-string literal comment
diff --git a/lib/tasks/downloads.rake b/lib/tasks/downloads.rake index abc1234..def5678 100644 --- a/lib/tasks/downloads.rake +++ b/lib/tasks/downloads.rake @@ -14,7 +14,6 @@ .exclude_unregistered_packages .active_batch_scope .order(:name) - .select(package_attributes) package_list.each_...
Remove download select b/c it was causing a bug
diff --git a/app/models/asset_file.rb b/app/models/asset_file.rb index abc1234..def5678 100644 --- a/app/models/asset_file.rb +++ b/app/models/asset_file.rb @@ -8,6 +8,7 @@ # It is used much like an active record model. # class AssetFile < FlexCommerceApi::ApiBase + has_one :asset_folder def self.path(p...
Update `asset_folder` association to `has_one`
diff --git a/app/models/forem/post.rb b/app/models/forem/post.rb index abc1234..def5678 100644 --- a/app/models/forem/post.rb +++ b/app/models/forem/post.rb @@ -25,11 +25,7 @@ self.user == other_user || other_user.forem_admin? end - private - - def subscribe_replier - topic.subscribe_user(user.i...
Use protected, not private keyword in Post model
diff --git a/app/decorators/controllers/action_controller_base_decorator.rb b/app/decorators/controllers/action_controller_base_decorator.rb index abc1234..def5678 100644 --- a/app/decorators/controllers/action_controller_base_decorator.rb +++ b/app/decorators/controllers/action_controller_base_decorator.rb @@ -26,16 +...
Refactor load_schema to support multiple tld_length
diff --git a/lib/trlo/models/board.rb b/lib/trlo/models/board.rb index abc1234..def5678 100644 --- a/lib/trlo/models/board.rb +++ b/lib/trlo/models/board.rb @@ -3,7 +3,7 @@ include DataMapper::Resource property :id, Serial - property :name, String + property :name, ...
Fix titles that are longer than 50 characters.
diff --git a/lib/walmart_open/item.rb b/lib/walmart_open/item.rb index abc1234..def5678 100644 --- a/lib/walmart_open/item.rb +++ b/lib/walmart_open/item.rb @@ -16,7 +16,7 @@ "productUrl" => "url" } - API_ATTRIBUTES_MAPPING.each_key do |attr_name| + API_ATTRIBUTES_MAPPING.each_value do |attr_name| ...
Use the values, not the keys
diff --git a/test/cookbooks/test/metadata.rb b/test/cookbooks/test/metadata.rb index abc1234..def5678 100644 --- a/test/cookbooks/test/metadata.rb +++ b/test/cookbooks/test/metadata.rb @@ -1,7 +1,7 @@ name 'test' maintainer 'Chef Software, Inc.' maintainer_email 'cookbooks@chef.io' -license 'Apache 2.0' +license 'Apa...
Use a SPDX standard license string Signed-off-by: Tim Smith <764ef62106582a09ed09dfa0b6bff7c05fd7d1e4@chef.io>
diff --git a/lib/xpathquery/engine.rb b/lib/xpathquery/engine.rb index abc1234..def5678 100644 --- a/lib/xpathquery/engine.rb +++ b/lib/xpathquery/engine.rb @@ -23,7 +23,7 @@ begin results = perform_query(q, ns) - rescue Exception + rescue Exception => ex raise XPathQuery::Error.new(@db_url, q) e...
Save exception in local variable
diff --git a/app/controllers/forem/application_controller.rb b/app/controllers/forem/application_controller.rb index abc1234..def5678 100644 --- a/app/controllers/forem/application_controller.rb +++ b/app/controllers/forem/application_controller.rb @@ -4,7 +4,7 @@ def authenticate_forem_user if !forem_user - ...
Use user_return_to rather than just 'return_to' Devise now requires the scope to be prefixed to the return_to session variable when using it as a location store Fixes #58
diff --git a/lib/gimli/path.rb b/lib/gimli/path.rb index abc1234..def5678 100644 --- a/lib/gimli/path.rb +++ b/lib/gimli/path.rb @@ -21,10 +21,8 @@ target = File.join(target, '*') end end - files = Dir.glob(target).keep_if { |file| MarkupFile.new(file).valid? } - files = [files] unle...
Remove unnecessary check for array
diff --git a/test/unit/lib/rake_task_test.rb b/test/unit/lib/rake_task_test.rb index abc1234..def5678 100644 --- a/test/unit/lib/rake_task_test.rb +++ b/test/unit/lib/rake_task_test.rb @@ -1,7 +1,22 @@ # frozen_string_literal: true require 'test_helper' +require 'database_cleaner' +DatabaseCleaner.strategy = :transact...
Fix seed issue with rakeTaskTest regression test Signed-off-by: Jason Dossett <e6f895edd39634df23774f0615e338f58a73f02c@utdallas.edu>
diff --git a/app/overrides/layouts_admin_print_buttons_decorator.rb b/app/overrides/layouts_admin_print_buttons_decorator.rb index abc1234..def5678 100644 --- a/app/overrides/layouts_admin_print_buttons_decorator.rb +++ b/app/overrides/layouts_admin_print_buttons_decorator.rb @@ -1,4 +1,4 @@-Deface::Override.new(:virtu...
Correct virtual_path for print buttons override Fixes #34
diff --git a/lib/phpcop/cli.rb b/lib/phpcop/cli.rb index abc1234..def5678 100644 --- a/lib/phpcop/cli.rb +++ b/lib/phpcop/cli.rb @@ -7,7 +7,7 @@ class CLI attr_reader :config_store - MSG_END = '%s fichier traité. %s erreurs.' + MSG_END = '%s fichiers traités. %s erreurs.' def initialize @co...
Add space to result if number of file and error is big
diff --git a/spec/unit/stash/harvester_spec.rb b/spec/unit/stash/harvester_spec.rb index abc1234..def5678 100644 --- a/spec/unit/stash/harvester_spec.rb +++ b/spec/unit/stash/harvester_spec.rb @@ -13,7 +13,7 @@ expect(logged).to include(msg) timestamp_str = logged.split[0] timestamp = Da...
Make sure we're comparing UTC with UTC
diff --git a/lib/slatan/ear.rb b/lib/slatan/ear.rb index abc1234..def5678 100644 --- a/lib/slatan/ear.rb +++ b/lib/slatan/ear.rb @@ -8,16 +8,15 @@ class << self ## register subscriber # @param concern subscriber - # @param options option - # cond: <Kernel.#lambda> call hear method o...
Change arg from Karnel.lambda to block of Slatan::Ear.register
diff --git a/db/migrate/20130918163100_create_open_id_authentications_from_existing_users.rb b/db/migrate/20130918163100_create_open_id_authentications_from_existing_users.rb index abc1234..def5678 100644 --- a/db/migrate/20130918163100_create_open_id_authentications_from_existing_users.rb +++ b/db/migrate/201309181631...
[migration] Create OpenID authentications from existing users
diff --git a/config/sitemap.rb b/config/sitemap.rb index abc1234..def5678 100644 --- a/config/sitemap.rb +++ b/config/sitemap.rb @@ -18,10 +18,10 @@ SitemapGenerator::Sitemap.create do site.posts.find_each do |post| - add post_url(post), changefreq: 'weekly', priority: 0.8 + add post_path(post), changefreq: ...
Use `xxx_path` instead of `xxx_url` In `config/sitemap.rb`, it is enough only path. The host is filled by sitemap_generator.
diff --git a/contracts.gemspec b/contracts.gemspec index abc1234..def5678 100644 --- a/contracts.gemspec +++ b/contracts.gemspec @@ -3,7 +3,6 @@ Gem::Specification.new do |s| s.name = "contracts" s.version = Contracts::VERSION - s.date = "2014-05-08" s.summary = "Contracts for Ruby." ...
Remove explicit date from gemspec It creates very weird history on rubygems if one forget to update it when releasing new version, like this: https://rubygems.org/gems/contracts ``` 0.5 - May 8, 2014 (24.5 KB) ``` even so, it was released recently. Removing this field from gemspec allows rubygems to automa...
diff --git a/lib/coresys/commands/edit.rb b/lib/coresys/commands/edit.rb index abc1234..def5678 100644 --- a/lib/coresys/commands/edit.rb +++ b/lib/coresys/commands/edit.rb @@ -1,4 +1,3 @@-formula = Coresys::Formula.find(ARGV[0]) error!("EDITOR environment variable is not set") unless ENV['EDITOR'] -file = (Coresys.fo...
Edit shouldn't require formula to be valid
diff --git a/lita-xkcd.gemspec b/lita-xkcd.gemspec index abc1234..def5678 100644 --- a/lita-xkcd.gemspec +++ b/lita-xkcd.gemspec @@ -1,6 +1,6 @@ Gem::Specification.new do |spec| spec.name = "lita-xkcd" - spec.version = "0.0.4" + spec.version = "0.0.5" spec.authors = ["Mitch Dempsey"] ...
Update gemspec for Lita 3.0 compatibility.
diff --git a/stash_datacite/app/controllers/stash_datacite/application_controller.rb b/stash_datacite/app/controllers/stash_datacite/application_controller.rb index abc1234..def5678 100644 --- a/stash_datacite/app/controllers/stash_datacite/application_controller.rb +++ b/stash_datacite/app/controllers/stash_datacite/a...
Revert "trying to add catching of annoying Bing js error" We will need to use Rack or HoneyBader to do this. This reverts commit 63ea5fd7c7840db3119e7f97a3c0bc02c1189d77.
diff --git a/src/spec/factories/metadata_object.rb b/src/spec/factories/metadata_object.rb index abc1234..def5678 100644 --- a/src/spec/factories/metadata_object.rb +++ b/src/spec/factories/metadata_object.rb @@ -6,6 +6,6 @@ Factory.define :default_zone_metadata, :parent => :metadata_object do |o| o.key 'default_...
Fix metadata object factory so it doesnt load zone before it exists.
diff --git a/test/factories/cms_graphql_queries.rb b/test/factories/cms_graphql_queries.rb index abc1234..def5678 100644 --- a/test/factories/cms_graphql_queries.rb +++ b/test/factories/cms_graphql_queries.rb @@ -21,7 +21,7 @@ FactoryBot.define do factory :cms_graphql_query do sequence(:identifier) { |n| "graph...
Update query used in test case
diff --git a/test/features/can_access_home_test.rb b/test/features/can_access_home_test.rb index abc1234..def5678 100644 --- a/test/features/can_access_home_test.rb +++ b/test/features/can_access_home_test.rb @@ -23,7 +23,7 @@ fill_in 'Password', :with => "password" click_button 'Sign in' - page.must_have...
Make can access home page test more robust by referring to devise internationalization
diff --git a/lib/figaro/cli/heroku_set.rb b/lib/figaro/cli/heroku_set.rb index abc1234..def5678 100644 --- a/lib/figaro/cli/heroku_set.rb +++ b/lib/figaro/cli/heroku_set.rb @@ -10,7 +10,7 @@ private def command - "heroku config:set #{for_app} #{vars}" + "heroku config:set #{vars} #{for_app}...
Switch the order of "heroku config:set" arguments to read better
diff --git a/lib/heroku/kensa/manifest.rb b/lib/heroku/kensa/manifest.rb index abc1234..def5678 100644 --- a/lib/heroku/kensa/manifest.rb +++ b/lib/heroku/kensa/manifest.rb @@ -7,34 +7,25 @@ end def self.skeleton - Yajl::Parser.parse(skeleton_str) + { 'id' => 'myaddon', + 'name'...
Refactor Manifest.skeleton to use a hash.
diff --git a/lib/htty/cli/input_device.rb b/lib/htty/cli/input_device.rb index abc1234..def5678 100644 --- a/lib/htty/cli/input_device.rb +++ b/lib/htty/cli/input_device.rb @@ -2,7 +2,27 @@ module HTTY::CLI::InputDevice def self.new(display) - TTY.new(display) + if STDIN.tty? + TTY.new(display) + els...
Support for input from pipe
diff --git a/agharta.gemspec b/agharta.gemspec index abc1234..def5678 100644 --- a/agharta.gemspec +++ b/agharta.gemspec @@ -13,6 +13,8 @@ gem.homepage = "" gem.add_runtime_dependency 'thor', '~> 0.16' + gem.add_runtime_dependency 'oauth', '~> 0.4' + gem.add_runtime_dependency 'twitter', '~> 4.4' gem.a...
Add oauth & twitter to dependency.
diff --git a/lib/schema/data_structure.rb b/lib/schema/data_structure.rb index abc1234..def5678 100644 --- a/lib/schema/data_structure.rb +++ b/lib/schema/data_structure.rb @@ -6,6 +6,7 @@ extend Build extend Virtual::Macro virtual :configure_dependencies + alias :configure :configure_d...
Configure is an alias for configure_dependencies
diff --git a/app/services/organisational_manual_document_service_registry.rb b/app/services/organisational_manual_document_service_registry.rb index abc1234..def5678 100644 --- a/app/services/organisational_manual_document_service_registry.rb +++ b/app/services/organisational_manual_document_service_registry.rb @@ -1,6...
Use Ruby keyword args in OrganisationalManualDocumentServiceRegistry I think that using language features instead of custom code makes this easier to understand.
diff --git a/lib/spring/commands/rspec.rb b/lib/spring/commands/rspec.rb index abc1234..def5678 100644 --- a/lib/spring/commands/rspec.rb +++ b/lib/spring/commands/rspec.rb @@ -14,7 +14,7 @@ end def call - ::RSpec.configuration.start_time = Time.now if defined?(::RSpec.configuration) + ::RS...
Fix compatibility with RSpec 2.x ::RSpec.configuration.start_time= was added in RSpec 3.0.0. This method doesn't exist in RSpec 2.x, so the binstub fails with `spring-commands-rspec-1.0.3/lib/spring/commands/rspec.rb:17:in `call': undefined method `start_time=' for #<RSpec::Core::Configuration:0x007f6d388dcf00> (NoM...
diff --git a/lib/byebug/commands/display.rb b/lib/byebug/commands/display.rb index abc1234..def5678 100644 --- a/lib/byebug/commands/display.rb +++ b/lib/byebug/commands/display.rb @@ -9,10 +9,7 @@ include Helpers::EvalHelper self.allow_in_post_mortem = false - - def self.always_run - 2 - end + ...
Use attribute writer instead of redefining it
diff --git a/lib/facter/interface_driver.rb b/lib/facter/interface_driver.rb index abc1234..def5678 100644 --- a/lib/facter/interface_driver.rb +++ b/lib/facter/interface_driver.rb @@ -0,0 +1,30 @@+require 'facter' +require 'facter/util/ip' +require 'json' +Facter::Util::IP.get_interfaces.each do |interface| + next if...
Add custom facts enabling finding the driver version
diff --git a/lib/i18n_alchemy/attributes.rb b/lib/i18n_alchemy/attributes.rb index abc1234..def5678 100644 --- a/lib/i18n_alchemy/attributes.rb +++ b/lib/i18n_alchemy/attributes.rb @@ -34,6 +34,7 @@ raise(::ActiveRecord::UnknownAttributeError, "unknown attribute: #{key}") end end + ...
Return self instead a Hash Signed-off-by: Tomas D'Stefano <f3cc27b85963f4808a0977f988249a2986cfd0e8@successoft.com>
diff --git a/libraries/nodejs_helper.rb b/libraries/nodejs_helper.rb index abc1234..def5678 100644 --- a/libraries/nodejs_helper.rb +++ b/libraries/nodejs_helper.rb @@ -35,7 +35,7 @@ def npm_package_installed?(package, version = nil, path = nil) list = npm_list(path)['dependencies'] # Return true if p...
Correct order of arguments when detecting installed packages
diff --git a/lib/tasks/search_analyzer.rake b/lib/tasks/search_analyzer.rake index abc1234..def5678 100644 --- a/lib/tasks/search_analyzer.rake +++ b/lib/tasks/search_analyzer.rake @@ -1,6 +1,7 @@ namespace :search_analyzer do desc 'Determine failed searches from Google Analytics CSV and output to new CSV' task f...
Add where to find search data
diff --git a/test/test_css.rb b/test/test_css.rb index abc1234..def5678 100644 --- a/test/test_css.rb +++ b/test/test_css.rb @@ -12,21 +12,28 @@ App.new end + def assert_css(css) + left = last_response.body.gsub(/[ \r\n\t]+/m, '') + right = css.gsub(/[ \r\n\t]+/m, '') + + assert_equal left, right + ...
Update the CSS test to be more robust.
diff --git a/diff_set.gemspec b/diff_set.gemspec index abc1234..def5678 100644 --- a/diff_set.gemspec +++ b/diff_set.gemspec @@ -24,5 +24,5 @@ spec.add_development_dependency 'rake-compiler', '~> 0.9.2' spec.add_development_dependency 'rspec' spec.add_development_dependency 'pry' - spec.add_runtime_dependency ...
Update to use ruby 2.2.0 compatible rice
diff --git a/test/lib/howell/notice_test.rb b/test/lib/howell/notice_test.rb index abc1234..def5678 100644 --- a/test/lib/howell/notice_test.rb +++ b/test/lib/howell/notice_test.rb @@ -1,5 +1,7 @@ require 'test_helper' +# TODO: +# * Add a test to check the content of what is being sent in a notice class HowellNotice...
TODO: Add test for Howell::Notice that checks the content being sent in a notice
diff --git a/Casks/pycharm-ce-bundled-jdk.rb b/Casks/pycharm-ce-bundled-jdk.rb index abc1234..def5678 100644 --- a/Casks/pycharm-ce-bundled-jdk.rb +++ b/Casks/pycharm-ce-bundled-jdk.rb @@ -0,0 +1,22 @@+cask :v1 => 'pycharm-ce-bundled-jdk' do + version '4.5.1' + sha256 '8929fa6e995a895244731a1ac2ab888593decb7d0592ba56...
Add PyCharm Community Edition 4.5.1 with bundled JDK 1.8
diff --git a/mrblib/rack_r3.rb b/mrblib/rack_r3.rb index abc1234..def5678 100644 --- a/mrblib/rack_r3.rb +++ b/mrblib/rack_r3.rb @@ -1,13 +1,13 @@ module Rack module R3 METHODS = { - get: ::R3::Method::GET, - post: ::R3::Method::POST, - put: ::R3::Method::PUT, - delete: ::R3::Method::DELETE,...
Use capitalized symbol for keys of METHODS
diff --git a/core/lib/generators/spree/install/templates/config/initializers/spree.rb b/core/lib/generators/spree/install/templates/config/initializers/spree.rb index abc1234..def5678 100644 --- a/core/lib/generators/spree/install/templates/config/initializers/spree.rb +++ b/core/lib/generators/spree/install/templates/...
Add static gateway example to config initializer
diff --git a/lib/webmock/http_lib_adapters/http_rb/client.rb b/lib/webmock/http_lib_adapters/http_rb/client.rb index abc1234..def5678 100644 --- a/lib/webmock/http_lib_adapters/http_rb/client.rb +++ b/lib/webmock/http_lib_adapters/http_rb/client.rb @@ -4,7 +4,11 @@ def perform(request, options) return __pe...
Adjust `perform` override and call HTTP features wrapping request/response pairs. The change helps reduce differences between mocking and not mocking to successfully test e.g. instrumentation which the `http` gem exposes through said features.
diff --git a/app/api/news.rb b/app/api/news.rb index abc1234..def5678 100644 --- a/app/api/news.rb +++ b/app/api/news.rb @@ -1,6 +1,7 @@ module News class API < Grape::API prefix 'api' + format :json resource :links do get do
Set JSON as default format
diff --git a/examples/ring.rb b/examples/ring.rb index abc1234..def5678 100644 --- a/examples/ring.rb +++ b/examples/ring.rb @@ -2,6 +2,7 @@ $:.unshift(File.join(File.dirname(__FILE__), '..', 'lib')) require 'minx' +require 'benchmark' # Number of rounds. M = ARGV[0] ? Integer(ARGV[0]) : 1000 @@ -18,12 +19,15 @@...
Add more granular Ring benchmark
diff --git a/Library/Homebrew/cask/lib/hbc/container/cab.rb b/Library/Homebrew/cask/lib/hbc/container/cab.rb index abc1234..def5678 100644 --- a/Library/Homebrew/cask/lib/hbc/container/cab.rb +++ b/Library/Homebrew/cask/lib/hbc/container/cab.rb @@ -8,7 +8,7 @@ def self.me?(criteria) cabextract = which("c...
Fix detection of self-extracting `.exe` files.
diff --git a/test/test_chinese_faker_address.rb b/test/test_chinese_faker_address.rb index abc1234..def5678 100644 --- a/test/test_chinese_faker_address.rb +++ b/test/test_chinese_faker_address.rb @@ -0,0 +1,24 @@+# encoding: utf-8 +require 'test_helper' + +class TestChineseFakerAddress < Test::Unit::TestCase + def se...
Add test suite for address
diff --git a/lib/action_cost/middleware.rb b/lib/action_cost/middleware.rb index abc1234..def5678 100644 --- a/lib/action_cost/middleware.rb +++ b/lib/action_cost/middleware.rb @@ -2,6 +2,7 @@ class Middleware attr_reader :request_stats, :stats_collector + cattr_accessor :singleton def initialize(app...
Use cattr_accessor for @@singleton class variable
diff --git a/betamax.gemspec b/betamax.gemspec index abc1234..def5678 100644 --- a/betamax.gemspec +++ b/betamax.gemspec @@ -16,5 +16,6 @@ s.executables = `git ls-files -- bin/*`.split("\n").map{ |f| File.basename(f) } s.require_paths = ["lib"] + s.add_development_dependency "rake" s.add_development_depend...
Add Rake as a dependency
diff --git a/Casks/netbeans-php-beta8.rb b/Casks/netbeans-php-beta8.rb index abc1234..def5678 100644 --- a/Casks/netbeans-php-beta8.rb +++ b/Casks/netbeans-php-beta8.rb @@ -0,0 +1,13 @@+class NetbeansPhpBeta8 < Cask + url 'http://dlc.sun.com.edgesuite.net/netbeans/8.0/beta/bundles/netbeans-8.0beta-php-macosx.dmg' + h...
Add NetBeans PHP Beta 8.0
diff --git a/lib/fog/vcloud_director/models/compute/disks.rb b/lib/fog/vcloud_director/models/compute/disks.rb index abc1234..def5678 100644 --- a/lib/fog/vcloud_director/models/compute/disks.rb +++ b/lib/fog/vcloud_director/models/compute/disks.rb @@ -33,7 +33,8 @@ items end - # Fil...
Make comment more explicit about OVF