diff
stringlengths
65
26.7k
message
stringlengths
7
9.92k
diff --git a/app/models/concerns/has_tags.rb b/app/models/concerns/has_tags.rb index abc1234..def5678 100644 --- a/app/models/concerns/has_tags.rb +++ b/app/models/concerns/has_tags.rb @@ -2,7 +2,7 @@ extend ActiveSupport::Concern included do - scope :with_tag, -> (key) { where("tags ? '#{key}'") } - scope...
Use table_name in tags where clause
diff --git a/spec/factories/conferences.rb b/spec/factories/conferences.rb index abc1234..def5678 100644 --- a/spec/factories/conferences.rb +++ b/spec/factories/conferences.rb @@ -2,5 +2,10 @@ factory :conference do name { [FFaker::CheesyLingo.title, 'Conf'].join ' ' } tickets 2 + + trait :current_seaso...
Add factory trait for current season's conference
diff --git a/rails_master_gemfile.rb b/rails_master_gemfile.rb index abc1234..def5678 100644 --- a/rails_master_gemfile.rb +++ b/rails_master_gemfile.rb @@ -3,11 +3,11 @@ <<-GEMFILE source 'http://gemcutter.org' +git 'git://github.com/carlhuda/bundler.git' + +gem 'bundler' + git 'git://github.com/rails/rails.git' -...
Add carlhuda/bundler/master to rails master gemfile
diff --git a/spec/lib/ezapi_client_spec.rb b/spec/lib/ezapi_client_spec.rb index abc1234..def5678 100644 --- a/spec/lib/ezapi_client_spec.rb +++ b/spec/lib/ezapi_client_spec.rb @@ -14,6 +14,7 @@ password: "password", eks_path: CONFIG[:eks_path], prv_path: CONFIG[:prv_path], + ho...
Fix spec - set host
diff --git a/spec/link_shrink/isgd_spec.rb b/spec/link_shrink/isgd_spec.rb index abc1234..def5678 100644 --- a/spec/link_shrink/isgd_spec.rb +++ b/spec/link_shrink/isgd_spec.rb @@ -0,0 +1,43 @@+require 'spec_helper' + +describe LinkShrink::Shrinkers::IsGd do + include_examples 'shared_examples' + + let(:link_shrink) ...
Add spec for is.gd shrinker api
diff --git a/recipes/hbase_master.rb b/recipes/hbase_master.rb index abc1234..def5678 100644 --- a/recipes/hbase_master.rb +++ b/recipes/hbase_master.rb @@ -24,6 +24,28 @@ action :install end +# HBase can use a local directory or an HDFS directory for its rootdir... +# if HDFS, create execute block with action :no...
Create HBase's rootdir, either in HDFS or the local filesystem, depending on configuration
diff --git a/spec/poodr_rspec/gear_spec.rb b/spec/poodr_rspec/gear_spec.rb index abc1234..def5678 100644 --- a/spec/poodr_rspec/gear_spec.rb +++ b/spec/poodr_rspec/gear_spec.rb @@ -13,7 +13,7 @@ ) end - describe 'wheel double passes interface' do + describe 'wheel_double' do it_should_behave_like 'a dia...
Update spec description to be easier to read. Why: * The name in the spec was confusing. This change addresses the need by: * Update the spec describe string.
diff --git a/lib/ruuid/uuid.rb b/lib/ruuid/uuid.rb index abc1234..def5678 100644 --- a/lib/ruuid/uuid.rb +++ b/lib/ruuid/uuid.rb @@ -34,10 +34,12 @@ "<#{self.class}:0x#{object_id} data=#{to_s}>" end + # @private def marshal_dump data end + # @private def marshal_load(data) ...
doc: Mark RUUID::UUID marshal methods private
diff --git a/app/services/datapoints_sync.rb b/app/services/datapoints_sync.rb index abc1234..def5678 100644 --- a/app/services/datapoints_sync.rb +++ b/app/services/datapoints_sync.rb @@ -37,6 +37,6 @@ end def overlapping_timestamps(new_datapoints, stored) - new_datapoints.map(&:timestamp) & stored.map(&:tim...
Reduce complexity of sync algorithm
diff --git a/spree_email_to_friend.gemspec b/spree_email_to_friend.gemspec index abc1234..def5678 100644 --- a/spree_email_to_friend.gemspec +++ b/spree_email_to_friend.gemspec @@ -15,8 +15,7 @@ s.require_paths = ["lib"] s.requirements << 'none' - s.add_dependency 'spree_core', '>= 1.0.0' - s.add_dependency 's...
Update gemspec to support spree 1-2-stable
diff --git a/lib/tasks/db.rake b/lib/tasks/db.rake index abc1234..def5678 100644 --- a/lib/tasks/db.rake +++ b/lib/tasks/db.rake @@ -22,7 +22,7 @@ end def self.db_config_file_data - if defined?(ActiveRecord::Base) + if defined?(ActiveRecord::Base) && ActiveRecord::Base.configurations.present? ...
Add guard against empty AR configs Sometimes when Rake is loaded for loading tasks AR is loaded, but its config is not. This now checks for empty config and bails to reading the YAML file if loaded config is empty.
diff --git a/app.rb b/app.rb index abc1234..def5678 100644 --- a/app.rb +++ b/app.rb @@ -1,15 +1,16 @@ require 'sinatra' -# [Redis To Go | Heroku Dev Center](https://devcenter.heroku.com/articles/redistogo) configure do + # [Redis To Go | Heroku Dev Center](https://devcenter.heroku.com/articles/redistogo) requir...
Fix syntax to Ruby 2.0.0
diff --git a/app.rb b/app.rb index abc1234..def5678 100644 --- a/app.rb +++ b/app.rb @@ -1,13 +1,12 @@ # encoding: utf-8 -require 'sinatra' +require 'sinatra/base' -class Grokily < Sinatra::Application +class Grokily < Sinatra::Base # Not using the API? Just redirect to Github. get '/' do redirect 'https...
Switch to the simpler Sinatra Base style - let's keep it simple for now and remove unnecessary complexity.
diff --git a/app.rb b/app.rb index abc1234..def5678 100644 --- a/app.rb +++ b/app.rb @@ -28,7 +28,7 @@ currency = currencies[symbol] if currency - respond_message "#{currency['name']} is currently valued at #{currency['price']} and the market cap is at #{currency['marketcap']}." + respond_message "#{curren...
REmove the marketcap from message.
diff --git a/test/test.rb b/test/test.rb index abc1234..def5678 100644 --- a/test/test.rb +++ b/test/test.rb @@ -7,7 +7,7 @@ client = Riak::Client.new(:http_backend => :Excon) # Automatically balance between multiple nodes -client = Riak::Client.new(:host => '127.0.0.1', :http_port => 8100) +client = Riak::Client.ne...
Update IP to point to host-only IP used in bosh-solo
diff --git a/test/data_structures/association_column_test.rb b/test/data_structures/association_column_test.rb index abc1234..def5678 100644 --- a/test/data_structures/association_column_test.rb +++ b/test/data_structures/association_column_test.rb @@ -18,8 +18,9 @@ end def test_searching - # right now, there...
Fix testing default search for association columns
diff --git a/test/models/notifiers_test.rb b/test/models/notifiers_test.rb index abc1234..def5678 100644 --- a/test/models/notifiers_test.rb +++ b/test/models/notifiers_test.rb @@ -0,0 +1,7 @@+require 'test_helper' + +class NotifiersTest < ActiveSupport::TestCase + test 'pushbullet' do + assert Notifiers.new(:pushb...
Create test for `Notifiers` module
diff --git a/core/db/migrate/20091209202200_make_state_events_polymorphic.rb b/core/db/migrate/20091209202200_make_state_events_polymorphic.rb index abc1234..def5678 100644 --- a/core/db/migrate/20091209202200_make_state_events_polymorphic.rb +++ b/core/db/migrate/20091209202200_make_state_events_polymorphic.rb @@ -1,4...
Add a legacy model to make_states_events_polymorphic migration
diff --git a/config/initializers/jira.rb b/config/initializers/jira.rb index abc1234..def5678 100644 --- a/config/initializers/jira.rb +++ b/config/initializers/jira.rb @@ -0,0 +1,11 @@+# frozen_string_literal: true + +# Changes JIRA DVCS user agent requests in order to be successfully handled +# by our API. +# +# Gitl...
Load 'Gitlab::Jira::Middleware' if it exists Loads 'Gitlab::Jira::Middleware' only if it exists so this initializer can be backported to CE.
diff --git a/app/models/snapshot_diff_cluster.rb b/app/models/snapshot_diff_cluster.rb index abc1234..def5678 100644 --- a/app/models/snapshot_diff_cluster.rb +++ b/app/models/snapshot_diff_cluster.rb @@ -1,8 +1,8 @@ # Contains information about a cluster of differences for a snapshot diff class SnapshotDiffCluster < ...
Use the new "sexy" validations for SnapshotDiffCluster As pointed out by Rubocop. This resolves all of the cops for this file. Change-Id: I51fa7444f9f717f3f2848ff1bb87bd409ebbbe7b
diff --git a/lib/cucumber/a11y/a11y_steps.rb b/lib/cucumber/a11y/a11y_steps.rb index abc1234..def5678 100644 --- a/lib/cucumber/a11y/a11y_steps.rb +++ b/lib/cucumber/a11y/a11y_steps.rb @@ -1,5 +1,9 @@ Then(/^the page should be accessible$/) do expect(page).to be_accessible +end + +Then(/^the page should not be acces...
Add Cucumber page not accessible
diff --git a/lib/active_interaction/filters/array_filter.rb b/lib/active_interaction/filters/array_filter.rb index abc1234..def5678 100644 --- a/lib/active_interaction/filters/array_filter.rb +++ b/lib/active_interaction/filters/array_filter.rb @@ -27,7 +27,7 @@ raise InvalidFilter.new('multiple nested filter...
Switch to better error type
diff --git a/lib/ids_please/grabbers/base.rb b/lib/ids_please/grabbers/base.rb index abc1234..def5678 100644 --- a/lib/ids_please/grabbers/base.rb +++ b/lib/ids_please/grabbers/base.rb @@ -29,6 +29,18 @@ "#{self.class}##{self.object_id} #{line[1..-1]}" end + def to_h + { + avatar: ...
Add to_h method for grabbers
diff --git a/lib/jiraSOAP/entities/entity.rb b/lib/jiraSOAP/entities/entity.rb index abc1234..def5678 100644 --- a/lib/jiraSOAP/entities/entity.rb +++ b/lib/jiraSOAP/entities/entity.rb @@ -11,7 +11,7 @@ # @return [Array<String,Symbol,Class>] returns what you gave it def add_attributes *attributes superc...
Allow classes to have attributes added more than once In case they change things and a third party wants to monkey patch.
diff --git a/foreigner.gemspec b/foreigner.gemspec index abc1234..def5678 100644 --- a/foreigner.gemspec +++ b/foreigner.gemspec @@ -16,6 +16,6 @@ s.extra_rdoc_files = %w(README.rdoc) s.files = %w(MIT-LICENSE Rakefile README.rdoc) + Dir['lib/**/*.rb'] + Dir['test/**/*.rb'] - s.add_dependency('activerecord', '>=...
Decrease active_record requirement from 3.1 to 3.0
diff --git a/lib/did_you_mean/finders/name_error_finders.rb b/lib/did_you_mean/finders/name_error_finders.rb index abc1234..def5678 100644 --- a/lib/did_you_mean/finders/name_error_finders.rb +++ b/lib/did_you_mean/finders/name_error_finders.rb @@ -5,17 +5,14 @@ end def self.new(exception) - klass = if ...
Replace an if statement with when/case
diff --git a/lib/generators/responders/install_generator.rb b/lib/generators/responders/install_generator.rb index abc1234..def5678 100644 --- a/lib/generators/responders/install_generator.rb +++ b/lib/generators/responders/install_generator.rb @@ -11,9 +11,13 @@ include Responders::FlashResponder include Responde...
Update the install generator to add the new location responder commented out
diff --git a/lib/octodown/support/helpers.rb b/lib/octodown/support/helpers.rb index abc1234..def5678 100644 --- a/lib/octodown/support/helpers.rb +++ b/lib/octodown/support/helpers.rb @@ -6,7 +6,7 @@ # TODO: Find a better home for this logic def self.markdown_to_html(content, options, path) html ...
Add an html extension to the temp file An extension can be added to the temp file (created behind the scene by `Tempfile.new`). It helps Safari recognize that the file is an HTML document. It is a possible solution for https://github.com/ianks/octodown/issues/34
diff --git a/lib/stackmate/stack_executor.rb b/lib/stackmate/stack_executor.rb index abc1234..def5678 100644 --- a/lib/stackmate/stack_executor.rb +++ b/lib/stackmate/stack_executor.rb @@ -0,0 +1,52 @@+require 'ruote' +require 'json' +require 'stackmate/stack' +require 'stackmate/logging' +require 'stackmate/classmap' ...
Refactor stack parsing and engine interaction
diff --git a/firmata.gemspec b/firmata.gemspec index abc1234..def5678 100644 --- a/firmata.gemspec +++ b/firmata.gemspec @@ -15,5 +15,8 @@ gem.require_paths = ["lib"] gem.version = Firmata::VERSION + gem.add_development_dependency("pry") + gem.add_runtime_dependency("serialport", ["~> 1.1.0"]) + end
Add a dev gem dependency.
diff --git a/api.rb b/api.rb index abc1234..def5678 100644 --- a/api.rb +++ b/api.rb @@ -17,7 +17,7 @@ unless File.exists?(directory) p = Pathname.new(directory) - p.mkdir + p.mkpath end File.open(destination, 'w') do |f|
Create the entire path if needed.
diff --git a/lib/bummr/updater.rb b/lib/bummr/updater.rb index abc1234..def5678 100644 --- a/lib/bummr/updater.rb +++ b/lib/bummr/updater.rb @@ -14,7 +14,7 @@ def update_gem(gem, index) puts "Updating #{gem[:name]}: #{index+1} of #{@outdated_gems.count}" - system("bundle update --source #{gem[:name]}"...
Drop --source flag from update
diff --git a/lib/druid/console.rb b/lib/druid/console.rb index abc1234..def5678 100644 --- a/lib/druid/console.rb +++ b/lib/druid/console.rb @@ -12,8 +12,10 @@ include_timestamp = query.properties[:granularity] != 'all' + keys = result.empty? ? [] : result.last.keys + Terminal::Table.new({ - headin...
Fix a nullpointer exception on empty result set
diff --git a/lib/ghn/collector.rb b/lib/ghn/collector.rb index abc1234..def5678 100644 --- a/lib/ghn/collector.rb +++ b/lib/ghn/collector.rb @@ -14,7 +14,7 @@ @count = notifications.count notifications.map { |notification| Notification.new(notification).to_url - } + }.compact end ...
Remove `nil` from collected URLs
diff --git a/templates/collection_view_controller/app/stylesheets/name_controller_stylesheet.rb b/templates/collection_view_controller/app/stylesheets/name_controller_stylesheet.rb index abc1234..def5678 100644 --- a/templates/collection_view_controller/app/stylesheets/name_controller_stylesheet.rb +++ b/templates/coll...
Fix a typo in the CollectionView template.
diff --git a/lib/model_patches.rb b/lib/model_patches.rb index abc1234..def5678 100644 --- a/lib/model_patches.rb +++ b/lib/model_patches.rb @@ -3,13 +3,14 @@ # Doing so in init/environment.rb wouldn't work in development, since # classes are reloaded, but initialization is not run each time. # See http://stackoverfl...
Add intro paragraph to new request template
diff --git a/lib/rip/nodes/try.rb b/lib/rip/nodes/try.rb index abc1234..def5678 100644 --- a/lib/rip/nodes/try.rb +++ b/lib/rip/nodes/try.rb @@ -1,15 +1,21 @@ module Rip::Nodes class Try < Base - attr_reader :body + attr_reader :attempt_body + attr_reader :catch_blocks + attr_reader :finally_block - ...
Refactor Rip::Nodes::Try to accept catches and finally
diff --git a/lib/tasks/slack.rake b/lib/tasks/slack.rake index abc1234..def5678 100644 --- a/lib/tasks/slack.rake +++ b/lib/tasks/slack.rake @@ -10,15 +10,15 @@ namespace :slack do desc "Send an update about the CFP status" task send_cfp_status_update: :environment do - MESSAGE = "We had %d new CFP submissions...
Fix new submissions not being reported to Slack The scheduled job that reports new submissions to Slack on a weekly basis was reporting 0 new submissions, despite there being two. This was caused by the query checking the `created_at` (a `DateTime`) against an array of `Date`s. This change fixes that.
diff --git a/purchase.gemspec b/purchase.gemspec index abc1234..def5678 100644 --- a/purchase.gemspec +++ b/purchase.gemspec @@ -24,6 +24,6 @@ s.add_runtime_dependency 'earth', '~>0.12.0' s.add_dependency 'emitter', '~> 1.0.0' - s.add_development_dependency 'sniff', '~>0.11.3' + s.add_development_dependenc...
Update sniff dependency to 1.x
diff --git a/Forecastr.podspec b/Forecastr.podspec index abc1234..def5678 100644 --- a/Forecastr.podspec +++ b/Forecastr.podspec @@ -5,7 +5,7 @@ s.homepage = "https://github.com/iwasrobbed/Forecastr" s.license = { :type => 'MIT', :file => 'LICENSE' } s.author = 'Rob Phillips' - s.source = ...
Update the commit hash in the podspec to work and pass validation.
diff --git a/spec/features/dashboard_spec.rb b/spec/features/dashboard_spec.rb index abc1234..def5678 100644 --- a/spec/features/dashboard_spec.rb +++ b/spec/features/dashboard_spec.rb @@ -9,7 +9,7 @@ it "should show dashboard" do expect(current_path.to_s).to match dashboards_path - expect(page).to have_tex...
Fix test fallout from dashboard cleanup
diff --git a/spec/lib/nala/publisher_spec.rb b/spec/lib/nala/publisher_spec.rb index abc1234..def5678 100644 --- a/spec/lib/nala/publisher_spec.rb +++ b/spec/lib/nala/publisher_spec.rb @@ -12,28 +12,47 @@ end end +class MultipleArgsClass + include Nala::Publisher + + def call(_, _, _) + end +end + RSpec.descri...
Refactor specs to remove duplication
diff --git a/spec/qml/signal_connect_spec.rb b/spec/qml/signal_connect_spec.rb index abc1234..def5678 100644 --- a/spec/qml/signal_connect_spec.rb +++ b/spec/qml/signal_connect_spec.rb @@ -0,0 +1,27 @@+require 'spec_helper' + +describe "QML signal connection" do + + let(:component) do + QML::Component.new(data: <<-...
Add test for QML signal connect
diff --git a/spec/unit/adapter/bacon_spec.rb b/spec/unit/adapter/bacon_spec.rb index abc1234..def5678 100644 --- a/spec/unit/adapter/bacon_spec.rb +++ b/spec/unit/adapter/bacon_spec.rb @@ -25,6 +25,20 @@ evaluate_expr("describe('test') { describe_cli('test') {}.is_a? Bacon::Context }").should.success? end ...
Check if methods are available
diff --git a/Casks/font-fontawesome.rb b/Casks/font-fontawesome.rb index abc1234..def5678 100644 --- a/Casks/font-fontawesome.rb +++ b/Casks/font-fontawesome.rb @@ -2,6 +2,6 @@ url 'http://fortawesome.github.io/Font-Awesome/assets/font-awesome-4.0.3.zip' homepage 'http://fortawesome.github.io/Font-Awesome/' ver...
Update Fontawesome to sha256 checksums
diff --git a/test/controllers/accounts_controller_test.rb b/test/controllers/accounts_controller_test.rb index abc1234..def5678 100644 --- a/test/controllers/accounts_controller_test.rb +++ b/test/controllers/accounts_controller_test.rb @@ -21,4 +21,10 @@ assert_not_nil assigns(:account) assert_redirected_to a...
Add a test case for show action in account controller.
diff --git a/savon-multipart.gemspec b/savon-multipart.gemspec index abc1234..def5678 100644 --- a/savon-multipart.gemspec +++ b/savon-multipart.gemspec @@ -20,6 +20,7 @@ s.add_development_dependency "rake" s.add_development_dependency "rspec" s.add_development_dependency "autotest" + s.add_development_depende...
Add transpec as a development dependency
diff --git a/app/services/dwp_monitor.rb b/app/services/dwp_monitor.rb index abc1234..def5678 100644 --- a/app/services/dwp_monitor.rb +++ b/app/services/dwp_monitor.rb @@ -17,7 +17,7 @@ private def dwp_results - @checks = BenefitCheck.pluck(:dwp_result, :error_message).last(20) + @checks = BenefitCheck.or...
Order benefit checks by ID
diff --git a/perfecta.gemspec b/perfecta.gemspec index abc1234..def5678 100644 --- a/perfecta.gemspec +++ b/perfecta.gemspec @@ -16,4 +16,7 @@ gem.executables = gem.files.grep(%r{^bin/}).map{ |f| File.basename(f) } gem.test_files = gem.files.grep(%r{^(test|spec|features)/}) gem.require_paths = ["lib"] + + ...
Add runtime and development dependencies
diff --git a/spec/integration/rspec_booster/empty_split_configuration_spec.rb b/spec/integration/rspec_booster/empty_split_configuration_spec.rb index abc1234..def5678 100644 --- a/spec/integration/rspec_booster/empty_split_configuration_spec.rb +++ b/spec/integration/rspec_booster/empty_split_configuration_spec.rb @@ ...
Make sure that rspec booster works even if the split config is empty
diff --git a/features/support/aruba.rb b/features/support/aruba.rb index abc1234..def5678 100644 --- a/features/support/aruba.rb +++ b/features/support/aruba.rb @@ -1 +1,7 @@ require 'aruba/cucumber' + +Before do + # ensure Cucumber's Ruby process can require the plugin as though it were a gem + path = File.expand_pa...
Fix paths so that the tests can require the formatter
diff --git a/test/lib/hector/test_case.rb b/test/lib/hector/test_case.rb index abc1234..def5678 100644 --- a/test/lib/hector/test_case.rb +++ b/test/lib/hector/test_case.rb @@ -9,6 +9,7 @@ def run(*) Hector.logger.info "--- #@method_name ---" super + ensure Hector.logger.info " " end
Fix test runner output on 1.9
diff --git a/spec/spec_helper/pre_flight.rb b/spec/spec_helper/pre_flight.rb index abc1234..def5678 100644 --- a/spec/spec_helper/pre_flight.rb +++ b/spec/spec_helper/pre_flight.rb @@ -18,15 +18,13 @@ ::Pod::UI.output = '' # The following prevents a nasty behaviour where the increments are not - # b...
[Specs] Fix issue with missing tmp dir
diff --git a/spec/support/metal_archives.rb b/spec/support/metal_archives.rb index abc1234..def5678 100644 --- a/spec/support/metal_archives.rb +++ b/spec/support/metal_archives.rb @@ -20,5 +20,5 @@ ## Custom logger (optional) c.logger = Logger.new $stdout - c.logger.level = Logger::INFO + c.logger.level = Log...
Set test logger level to WARN
diff --git a/app/controllers/claims_controller.rb b/app/controllers/claims_controller.rb index abc1234..def5678 100644 --- a/app/controllers/claims_controller.rb +++ b/app/controllers/claims_controller.rb @@ -17,16 +17,10 @@ def update resource.assign_attributes params[current_step] - saved = resource.save ...
Remove return params check as is no longer required due to save and complete button being removed
diff --git a/app/controllers/manage_controller.rb b/app/controllers/manage_controller.rb index abc1234..def5678 100644 --- a/app/controllers/manage_controller.rb +++ b/app/controllers/manage_controller.rb @@ -24,16 +24,16 @@ register Sinatra::Twitter::Bootstrap::Assets get '/jobs' do - case params...
[ManageController] Refactor how PushJobs are loaded. (Not working yet as the class methods are not working)
diff --git a/app/controllers/search_controller.rb b/app/controllers/search_controller.rb index abc1234..def5678 100644 --- a/app/controllers/search_controller.rb +++ b/app/controllers/search_controller.rb @@ -17,13 +17,17 @@ else return_to = sections_path end - anchor = if par...
Fix error when anchor is undefined in params
diff --git a/app/models/service_retire_request.rb b/app/models/service_retire_request.rb index abc1234..def5678 100644 --- a/app/models/service_retire_request.rb +++ b/app/models/service_retire_request.rb @@ -1,6 +1,7 @@ class ServiceRetireRequest < MiqRetireRequest TASK_DESCRIPTION = 'Service Retire'.freeze SOU...
Add retired to service active states
diff --git a/app/models/statisfaction/activity.rb b/app/models/statisfaction/activity.rb index abc1234..def5678 100644 --- a/app/models/statisfaction/activity.rb +++ b/app/models/statisfaction/activity.rb @@ -11,6 +11,14 @@ self.watched_class == other.watched_class && self.watched_activity == other.watched_activi...
Make Activity objects serializable for db-storage
diff --git a/RKTableController.podspec b/RKTableController.podspec index abc1234..def5678 100644 --- a/RKTableController.podspec +++ b/RKTableController.podspec @@ -15,5 +15,5 @@ s.source_files = 'Code/*.{h,m}' s.ios.framework = 'QuartzCore' - s.dependency 'RestKit', '>= 0.20.0' + s.dependency 'RestKit', ...
Set dependency to match >= 0.20.0dev
diff --git a/spec/moneta/adapters/memory/standard_memory_with_prefix_spec.rb b/spec/moneta/adapters/memory/standard_memory_with_prefix_spec.rb index abc1234..def5678 100644 --- a/spec/moneta/adapters/memory/standard_memory_with_prefix_spec.rb +++ b/spec/moneta/adapters/memory/standard_memory_with_prefix_spec.rb @@ -1,8...
Add spec for a shared backend with other prefixes
diff --git a/app/views/poems_number_badge_item.rb b/app/views/poems_number_badge_item.rb index abc1234..def5678 100644 --- a/app/views/poems_number_badge_item.rb +++ b/app/views/poems_number_badge_item.rb @@ -14,8 +14,12 @@ def create_base_button(title) set_title = title ? title : '' UIButton.alloc.in...
Set color of 'Save' button on PoemPicker
diff --git a/lib/aasm/graph.rb b/lib/aasm/graph.rb index abc1234..def5678 100644 --- a/lib/aasm/graph.rb +++ b/lib/aasm/graph.rb @@ -5,7 +5,7 @@ def initialize(class_name, options = {}) options = {path: '.'}.merge(options) - @file_path = File.join(options[:path], "#{class_name.parameterize('_')}_aasm....
Change call to parameterize to use Rails 5 syntax
diff --git a/lib/srt/parser.rb b/lib/srt/parser.rb index abc1234..def5678 100644 --- a/lib/srt/parser.rb +++ b/lib/srt/parser.rb @@ -1,29 +1,31 @@ module SRT class Parser - def self.framerate(framerate_string) - mres = framerate_string.match(/(?<fps>\d+((\.)?\d+))(fps)/) - mres ? mres["fps"].to_f : nil ...
Declare methods in a singleton class, removing redundant calls in self
diff --git a/lib/tasks/db.rake b/lib/tasks/db.rake index abc1234..def5678 100644 --- a/lib/tasks/db.rake +++ b/lib/tasks/db.rake @@ -4,7 +4,7 @@ namespace :db do task :seed_words, [:directory] => :environment do |args| - CSV.foreach(File.open(Rails.root + "test/testdata/words.csv", "r"), col_sep: ';', headers:t...
Change csv separation to 'tab'
diff --git a/lib/tasks/db.rake b/lib/tasks/db.rake index abc1234..def5678 100644 --- a/lib/tasks/db.rake +++ b/lib/tasks/db.rake @@ -23,4 +23,14 @@ SetAssetSizeWorker.perform_async(asset_id) end end + + desc "Transform all redirect chains into one-step redirects" + task resolve_redirect_chains: :environ...
Add a rake task to resolve all redirect chains
diff --git a/lib/tasks/go.rake b/lib/tasks/go.rake index abc1234..def5678 100644 --- a/lib/tasks/go.rake +++ b/lib/tasks/go.rake @@ -1,2 +1,5 @@ desc "Run the exercise specs" -task :go => "spec:exercises" +RSpec::Core::RakeTask.new(:go => "spec:prepare") do |t| + t.pattern = "./exercises/**/*_spec.rb" + t.rspec_opts ...
Make Rspec fail on first error (--fail-fast) so as to not overwhelm gym members
diff --git a/spec/cli/deploy_spec.rb b/spec/cli/deploy_spec.rb index abc1234..def5678 100644 --- a/spec/cli/deploy_spec.rb +++ b/spec/cli/deploy_spec.rb @@ -0,0 +1,60 @@+require 'spec_helper' + +describe Hanzo::CLI do + describe :deploy do + let(:env) { 'production' } + let(:branch) { '1.0.0' } + let(:deploy!...
Add test for Hanzo::Deploy module
diff --git a/app/models/authenticated_user.rb b/app/models/authenticated_user.rb index abc1234..def5678 100644 --- a/app/models/authenticated_user.rb +++ b/app/models/authenticated_user.rb @@ -1,11 +1,8 @@+# This enables us to return private fields, like mfa_level, to an authenticated user +# so that they may retrieve ...
Call super and add a comment
diff --git a/AEXML.podspec b/AEXML.podspec index abc1234..def5678 100644 --- a/AEXML.podspec +++ b/AEXML.podspec @@ -7,6 +7,8 @@ s.source = { :git => 'https://github.com/tadija/AEXML.git', :tag => s.version } s.source_files = 'Sources/AEXML/*.swift' + +s.swift_version = '5.0' s.ios.deployment_target = '8.0' s.os...
Fix warnings from `pod lib lint`
diff --git a/app/services/publisher_update.rb b/app/services/publisher_update.rb index abc1234..def5678 100644 --- a/app/services/publisher_update.rb +++ b/app/services/publisher_update.rb @@ -1,15 +1,30 @@ module Georelevent module Services class PublisherUpdate < Struct.new(:features, :publisher) + inclu...
Refactor PublisherUpdate to be enumerable Also, comment to steps performed on each feature.
diff --git a/lib/commands.rb b/lib/commands.rb index abc1234..def5678 100644 --- a/lib/commands.rb +++ b/lib/commands.rb @@ -0,0 +1,6 @@+require File.expand_path(File.join(File.dirname(__FILE__), 'commands', 'base')) +require File.expand_path(File.join(File.dirname(__FILE__), 'commands', 'pick')) +require File.expand_p...
Add convenience loader for Commands
diff --git a/site-cookbooks/basic_config/recipes/default.rb b/site-cookbooks/basic_config/recipes/default.rb index abc1234..def5678 100644 --- a/site-cookbooks/basic_config/recipes/default.rb +++ b/site-cookbooks/basic_config/recipes/default.rb @@ -13,7 +13,7 @@ # Set up app-specific user, group and home directory ...
Comment out password line. Not using text passwords for now.
diff --git a/paper_ticket.gemspec b/paper_ticket.gemspec index abc1234..def5678 100644 --- a/paper_ticket.gemspec +++ b/paper_ticket.gemspec @@ -19,7 +19,8 @@ s.add_dependency "rails", "~> 4.0.2" s.add_dependency "formtastic" s.add_dependency "formtastic-bootstrap" - s.add_dependency "mongoid", "~> 4.0.0alpha1...
Remove dependency on alpha cut
diff --git a/app/controllers/exceptionally_beautiful/application_controller.rb b/app/controllers/exceptionally_beautiful/application_controller.rb index abc1234..def5678 100644 --- a/app/controllers/exceptionally_beautiful/application_controller.rb +++ b/app/controllers/exceptionally_beautiful/application_controller.rb...
Allow application routes to work within custom layouts. * Changed `ExceptionallyBeautiful::ApplicationController` to inherit from `::ApplicationController`. * Include `Rails.application.routes.url_helpers` as a helper in our `ExceptionallyBeautiful::ApplicationController` so named route helpers are available in views ...
diff --git a/premiere-webm.rb b/premiere-webm.rb index abc1234..def5678 100644 --- a/premiere-webm.rb +++ b/premiere-webm.rb @@ -1,4 +1,4 @@-cask :v1 => 'photoshop-webm' do +cask :v1 => 'premiere-webm' do version '1.0.1' sha256 '68a2d856d545a4b7e3ccc39f5cbf635ed97d33322eac494b121c40bb32a69688'
Fix typo in package name.
diff --git a/app/controllers/home_controller.rb b/app/controllers/home_controller.rb index abc1234..def5678 100644 --- a/app/controllers/home_controller.rb +++ b/app/controllers/home_controller.rb @@ -1,6 +1,6 @@ class HomeController < ApplicationController def index - @count = Rubygem.total_count + @count = V...
Use Version.latest.count instead of total_count since AR hates DISTINCT
diff --git a/app/controllers/root_controller.rb b/app/controllers/root_controller.rb index abc1234..def5678 100644 --- a/app/controllers/root_controller.rb +++ b/app/controllers/root_controller.rb @@ -14,7 +14,11 @@ redirect_to administrations_path else - @latest_release = Github::Releases.latest + ...
Fix bug @latest_release for Github
diff --git a/app/policies/application_policy.rb b/app/policies/application_policy.rb index abc1234..def5678 100644 --- a/app/policies/application_policy.rb +++ b/app/policies/application_policy.rb @@ -1,4 +1,6 @@ class ApplicationPolicy + + include Pundit::Serializer attr_reader :user, :record
Include the pundit serializer in the ApplicationPolicy class.
diff --git a/lib/active_admin/dependency_checker.rb b/lib/active_admin/dependency_checker.rb index abc1234..def5678 100644 --- a/lib/active_admin/dependency_checker.rb +++ b/lib/active_admin/dependency_checker.rb @@ -10,7 +10,7 @@ end end - unless pry_rails_0_1_6? + if pry_rails_befor...
Fix the logic for pry-rails dependency checking The check was just backwards so I made the name of the method more explicit and changed the if to an unless.
diff --git a/lib/finite_machine/transition_event.rb b/lib/finite_machine/transition_event.rb index abc1234..def5678 100644 --- a/lib/finite_machine/transition_event.rb +++ b/lib/finite_machine/transition_event.rb @@ -17,11 +17,11 @@ # @return [self] # # @api private - def self.build(transition) + de...
Change to pass data to transition event.
diff --git a/lib/panther/representer/timestamped.rb b/lib/panther/representer/timestamped.rb index abc1234..def5678 100644 --- a/lib/panther/representer/timestamped.rb +++ b/lib/panther/representer/timestamped.rb @@ -3,18 +3,18 @@ module Representer module Timestamped def self.included(klass) - kla...
Use class_eval with block in Representer::Timestamped
diff --git a/test/cli/command/test_todo.rb b/test/cli/command/test_todo.rb index abc1234..def5678 100644 --- a/test/cli/command/test_todo.rb +++ b/test/cli/command/test_todo.rb @@ -0,0 +1,85 @@+# frozen_string_literal: true + +require "helpers" + +# Tests for KBSecret::CLI::Command::Todo +class KBSecretCommandTodoTest ...
test/cli: Add tests for `kbsecret todo`
diff --git a/GAuth.podspec b/GAuth.podspec index abc1234..def5678 100644 --- a/GAuth.podspec +++ b/GAuth.podspec @@ -12,7 +12,7 @@ spec.watchos.deployment_target = '2.0' spec.requires_arc = true - spec.source = { git: "https://www.github.com/fabiomassimo/GAuth", tag: "v#{spec.version}", submodules: true } + ...
Update Podspec by removing "v" prefix in pod tag.
diff --git a/rails/install.rb b/rails/install.rb index abc1234..def5678 100644 --- a/rails/install.rb +++ b/rails/install.rb @@ -1,8 +1,9 @@ # copy migrations +FileUtils.mkdir_p("#{Rails.root}/db/migrate") Dir["#{Rails.root}/vendor/plugins/simple_metrics_engine/db/migrate/*.rb"].each do |file| puts "Copying #{Fil...
Make sure db/migrate exists before copying to it.
diff --git a/kramdown-rfc2629.gemspec b/kramdown-rfc2629.gemspec index abc1234..def5678 100644 --- a/kramdown-rfc2629.gemspec +++ b/kramdown-rfc2629.gemspec @@ -1,10 +1,10 @@ spec = Gem::Specification.new do |s| s.name = 'kramdown-rfc2629' - s.version = '1.0.12' + s.version = '1.0.13' s.summary = "Kramdown exte...
1.0.13: Update to kramdown-1.4; include LICENSE file in gem
diff --git a/test/cases/migration_test_sqlserver.rb b/test/cases/migration_test_sqlserver.rb index abc1234..def5678 100644 --- a/test/cases/migration_test_sqlserver.rb +++ b/test/cases/migration_test_sqlserver.rb @@ -21,7 +21,7 @@ begin ActiveRecord::Migrator.up(SQLSERVER_MIGRATIONS_ROOT+'/transaction_ta...
Fix test for DDL transactions. (better regex for DDL specific message)
diff --git a/lib/inline_svg/static_asset_finder.rb b/lib/inline_svg/static_asset_finder.rb index abc1234..def5678 100644 --- a/lib/inline_svg/static_asset_finder.rb +++ b/lib/inline_svg/static_asset_finder.rb @@ -1,7 +1,9 @@+require "pathname" + # Naive fallback asset finder for when sprockets >= 3.0 && # config.asse...
Fix bad reference to Sprockets::Asset.pathname
diff --git a/lib/rails-footnotes/notes/log_note.rb b/lib/rails-footnotes/notes/log_note.rb index abc1234..def5678 100644 --- a/lib/rails-footnotes/notes/log_note.rb +++ b/lib/rails-footnotes/notes/log_note.rb @@ -19,18 +19,22 @@ end def title - "Log (#{log.count("\n")})" + "Log (#{log.count...
Fix count in log note and use tables
diff --git a/lib/roleify/roleifyable_controller.rb b/lib/roleify/roleifyable_controller.rb index abc1234..def5678 100644 --- a/lib/roleify/roleifyable_controller.rb +++ b/lib/roleify/roleifyable_controller.rb @@ -9,7 +9,7 @@ def allowed? # action marked 'public', allow access even when not logged in - ...
Use :try to catch missing :public role.
diff --git a/lib/roleify/roleifyable_controller.rb b/lib/roleify/roleifyable_controller.rb index abc1234..def5678 100644 --- a/lib/roleify/roleifyable_controller.rb +++ b/lib/roleify/roleifyable_controller.rb @@ -9,7 +9,7 @@ def allowed? # action marked 'public', allow access even when not logged in - ...
Use :try to catch missing :public role.
diff --git a/POSRx.podspec b/POSRx.podspec index abc1234..def5678 100644 --- a/POSRx.podspec +++ b/POSRx.podspec @@ -1,11 +1,11 @@ Pod::Spec.new do |s| s.name = 'POSRx' - s.version = '0.6.4' + s.version = '0.6.5' s.license = 'MIT' s.summary = 'Utilities around ReactiveCocoa.' s...
Update podspec version: 0.6.4 -> 0.6.5
diff --git a/sensu-extensions-statsd.gemspec b/sensu-extensions-statsd.gemspec index abc1234..def5678 100644 --- a/sensu-extensions-statsd.gemspec +++ b/sensu-extensions-statsd.gemspec @@ -13,7 +13,7 @@ spec.add_dependency 'sensu-extension' - spec.add_development_dependency 'bundler', '~> 1.6' + spec.add_develo...
Update bundler requirement from ~> 1.6 to ~> 2.1 Updates the requirements on [bundler](https://github.com/bundler/bundler) to permit the latest version. - [Release notes](https://github.com/bundler/bundler/releases) - [Changelog](https://github.com/bundler/bundler/blob/master/CHANGELOG.md) - [Commits](https://github.c...
diff --git a/lib/vagrant-vbguest/vagrant_compat.rb b/lib/vagrant-vbguest/vagrant_compat.rb index abc1234..def5678 100644 --- a/lib/vagrant-vbguest/vagrant_compat.rb +++ b/lib/vagrant-vbguest/vagrant_compat.rb @@ -7,9 +7,11 @@ } compat_version = supported_version.find { |requirement, version| Gem::Requirement.new(re...
Fix `nil[]` error with unknown Vagrant version
diff --git a/test/integration/oauth_test.rb b/test/integration/oauth_test.rb index abc1234..def5678 100644 --- a/test/integration/oauth_test.rb +++ b/test/integration/oauth_test.rb @@ -14,13 +14,26 @@ end end + context "access with invalid API key" do + setup do + @token = create(:access_token, applic...
Test with invalid API key
diff --git a/lib/libvirt-ruby/util.rb b/lib/libvirt-ruby/util.rb index abc1234..def5678 100644 --- a/lib/libvirt-ruby/util.rb +++ b/lib/libvirt-ruby/util.rb @@ -27,7 +27,7 @@ private def self.not_direct_call? - caller[1][/`.*'/][1..-2] == 'method_missing' + caller[1][/`.*'/] and caller[1][/...
Fix Bug for ruby 1.8.7
diff --git a/lib/mathmagic/integer.rb b/lib/mathmagic/integer.rb index abc1234..def5678 100644 --- a/lib/mathmagic/integer.rb +++ b/lib/mathmagic/integer.rb @@ -32,4 +32,16 @@ return true end + def divisible? n + (self % n).zero? + end + + def up + self + 1 + end + + def down + self - 1 + end + end
Add methods to Integer: divisible?, up, down
diff --git a/lib/modalsupport/file.rb b/lib/modalsupport/file.rb index abc1234..def5678 100644 --- a/lib/modalsupport/file.rb +++ b/lib/modalsupport/file.rb @@ -1,12 +1,7 @@ def File.relative_path(path, base=nil) base ||= '.' casefold = File::ALT_SEPARATOR=='\\' - # Note: currently Rubinius differs from MRI i...
Remove ugly & incomplete fix for Rubinius File.relative_path
diff --git a/lib/pry/terminal_info.rb b/lib/pry/terminal_info.rb index abc1234..def5678 100644 --- a/lib/pry/terminal_info.rb +++ b/lib/pry/terminal_info.rb @@ -21,6 +21,6 @@ ENV['ANSICON'] =~ /\((.*)x(.*)\)/ && [$2, $1] ].detect do |(_, cols)| cols.to_i > 0 - end + end.map!(&:to_i) end end
Return numbers from screen_size, kthxbai...
diff --git a/lib/shipitron/s3_copy.rb b/lib/shipitron/s3_copy.rb index abc1234..def5678 100644 --- a/lib/shipitron/s3_copy.rb +++ b/lib/shipitron/s3_copy.rb @@ -27,8 +27,6 @@ if $? != 0 fail_with_error!(message: 'Failed to transfer to/from s3.') end - - Logger.info "S3 result: #{Pathn...
Remove debug logging that broke stuff