diff
stringlengths
65
26.7k
message
stringlengths
7
9.92k
diff --git a/spec/controllers/course/video/submission/submissions_controller_spec.rb b/spec/controllers/course/video/submission/submissions_controller_spec.rb index abc1234..def5678 100644 --- a/spec/controllers/course/video/submission/submissions_controller_spec.rb +++ b/spec/controllers/course/video/submission/submis...
Add specs for Submission redirect Signed-off-by: Shen Yichen <be3bb257ef8d73236feaba36cd3e5ee9095e6819@gmail.com>
diff --git a/spec/controllers/ajax/anonymous_block_controller_spec.rb b/spec/controllers/ajax/anonymous_block_controller_spec.rb index abc1234..def5678 100644 --- a/spec/controllers/ajax/anonymous_block_controller_spec.rb +++ b/spec/controllers/ajax/anonymous_block_controller_spec.rb @@ -0,0 +1,59 @@+# frozen_string_li...
Add test for creating anonymous blocks
diff --git a/app/helpers/courses_helper.rb b/app/helpers/courses_helper.rb index abc1234..def5678 100644 --- a/app/helpers/courses_helper.rb +++ b/app/helpers/courses_helper.rb @@ -8,7 +8,7 @@ end def bust_course_list_cache(user) - #Rails.cache.delete_matched "#{:current_user_current_courses}*" - #Rails.ca...
Expire the fragment cache keys instead of manually deleting the cache
diff --git a/app/controllers/admin/banners_controller.rb b/app/controllers/admin/banners_controller.rb index abc1234..def5678 100644 --- a/app/controllers/admin/banners_controller.rb +++ b/app/controllers/admin/banners_controller.rb @@ -2,7 +2,6 @@ has_filters %w{all with_active with_inactive}, only: :index - be...
Remove duplicated code in Admin::BannersController
diff --git a/app/prawn/payslip_document.rb b/app/prawn/payslip_document.rb index abc1234..def5678 100644 --- a/app/prawn/payslip_document.rb +++ b/app/prawn/payslip_document.rb @@ -1,25 +1,15 @@ class PayslipDocument < LetterDocument def salary_table(salary) - head = [ - t_attr(:code, LineItem), - t_att...
Drop heading and code from payslip.
diff --git a/app/controllers/user_sessions_controller.rb b/app/controllers/user_sessions_controller.rb index abc1234..def5678 100644 --- a/app/controllers/user_sessions_controller.rb +++ b/app/controllers/user_sessions_controller.rb @@ -18,7 +18,7 @@ def create redirect_to root_url and return if current_user.pre...
Add .to_h to suppress deprecation warning
diff --git a/app/graphql/mutations/create_team_member.rb b/app/graphql/mutations/create_team_member.rb index abc1234..def5678 100644 --- a/app/graphql/mutations/create_team_member.rb +++ b/app/graphql/mutations/create_team_member.rb @@ -2,7 +2,7 @@ field :team_member, Types::TeamMemberType, null: false field :tick...
Use the right field name
diff --git a/lib/bundle/cask_dumper.rb b/lib/bundle/cask_dumper.rb index abc1234..def5678 100644 --- a/lib/bundle/cask_dumper.rb +++ b/lib/bundle/cask_dumper.rb @@ -11,7 +11,7 @@ def casks return [] unless Bundle.cask_installed? - @casks ||= `brew list --cask 2>/dev/null`.split("\n") + @casks ||=...
Switch to getting cask names from Cask module Originally the cask names were obtained by running `brew list --cask` and parsing the output. Now we're getting the cask with the `Cask::Caskroom.casks` method and stripping out the name.
diff --git a/pg_examiner.gemspec b/pg_examiner.gemspec index abc1234..def5678 100644 --- a/pg_examiner.gemspec +++ b/pg_examiner.gemspec @@ -18,6 +18,8 @@ spec.test_files = spec.files.grep(%r{^(test|spec|features)/}) spec.require_paths = ['lib'] + spec.add_dependency 'pg' + spec.add_development_dependency...
Add pg as a dependency.
diff --git a/lib/vagrant-hostsupdater/Action/RemoveHosts.rb b/lib/vagrant-hostsupdater/Action/RemoveHosts.rb index abc1234..def5678 100644 --- a/lib/vagrant-hostsupdater/Action/RemoveHosts.rb +++ b/lib/vagrant-hostsupdater/Action/RemoveHosts.rb @@ -5,15 +5,16 @@ def run(env) machine_action = env[:m...
Clean this up now that it will only be run once This seemed to be coded in a format to accommodate it being called many times.. now we will only call it once by design so clean it up.
diff --git a/db/migrate/20171130201127_assign_default_value_to_playlist_tags.rb b/db/migrate/20171130201127_assign_default_value_to_playlist_tags.rb index abc1234..def5678 100644 --- a/db/migrate/20171130201127_assign_default_value_to_playlist_tags.rb +++ b/db/migrate/20171130201127_assign_default_value_to_playlist_tag...
Migrate old playlists so they sort properly on the tags field
diff --git a/app/workers/pubsubhubbub/delivery_worker.rb b/app/workers/pubsubhubbub/delivery_worker.rb index abc1234..def5678 100644 --- a/app/workers/pubsubhubbub/delivery_worker.rb +++ b/app/workers/pubsubhubbub/delivery_worker.rb @@ -22,6 +22,7 @@ .headers(headers) .post(subscr...
Remove PuSH subscriptions when delivery is answered with a 4xx error
diff --git a/lib/filterrific/engine.rb b/lib/filterrific/engine.rb index abc1234..def5678 100644 --- a/lib/filterrific/engine.rb +++ b/lib/filterrific/engine.rb @@ -1,3 +1,7 @@+require 'filterrific/param_set' +require 'filterrific/action_view_extension' +require 'filterrific/active_record_extension' + module Filterrif...
Change how we load code: Need to extend ActiveRecord outside of initializer block. Otherwise we get exceptions when another library tries to load a class that uses filterrific. `filterrific` won't be known yet and raises an exception.
diff --git a/hyperfeed.gemspec b/hyperfeed.gemspec index abc1234..def5678 100644 --- a/hyperfeed.gemspec +++ b/hyperfeed.gemspec @@ -10,7 +10,7 @@ gem.email = ["guilherme.kato@abril.com.br"] gem.description = %q{An adapter to plug feeds content on hypermedia engines} gem.summary = %q{An adapter ...
Add homepage to show on rubygems
diff --git a/lib/metybur/collection.rb b/lib/metybur/collection.rb index abc1234..def5678 100644 --- a/lib/metybur/collection.rb +++ b/lib/metybur/collection.rb @@ -9,7 +9,7 @@ end def on(event, &block) - callback_for(event: event) << block + callbacks_for(event) << block self end @@ -18,10 +18,1...
Fix for Ruby < 2.1.0.
diff --git a/lib/tasks/shellcheck.rake b/lib/tasks/shellcheck.rake index abc1234..def5678 100644 --- a/lib/tasks/shellcheck.rake +++ b/lib/tasks/shellcheck.rake @@ -0,0 +1,28 @@+namespace :shell do + desc "Run Shellcheck against shell scripts; optional commit range confines checks to scripts that have changed." + + t...
Add Rake task to run Shellcheck Only consider added or modified scripts by using `git diff --name-status` and selecting files with status A or M. This avoids trying to run shellcheck on a file that's been deleted. Skip running shellcheck if no files are matched.
diff --git a/spec/support/helpers/general_system_spec_helpers.rb b/spec/support/helpers/general_system_spec_helpers.rb index abc1234..def5678 100644 --- a/spec/support/helpers/general_system_spec_helpers.rb +++ b/spec/support/helpers/general_system_spec_helpers.rb @@ -2,18 +2,16 @@ module GeneralSystemSpecHelpers ...
Revert "Specify locale when registering a user" This reverts commit 5ee41eabf8c991ad76f34a14cc97aeea876250c9.
diff --git a/Casks/truecrypt.rb b/Casks/truecrypt.rb index abc1234..def5678 100644 --- a/Casks/truecrypt.rb +++ b/Casks/truecrypt.rb @@ -11,4 +11,5 @@ http://truecrypt.sourceforge.net/ EOS end + uninstall :pkgutil => 'org.TrueCryptFoundation.TrueCrypt' end
Add uninstall stanza for TrueCrypt
diff --git a/lib/almanack/version.rb b/lib/almanack/version.rb index abc1234..def5678 100644 --- a/lib/almanack/version.rb +++ b/lib/almanack/version.rb @@ -1,6 +1,6 @@ module Almanack CODENAME = "Garlick" - VERSION = "1.0.4" - HOMEPAGE = "https://github.com/Aupajo/sinatra-gcal" - ISSUES = "https://github.com/...
Update homepage and issues URLs
diff --git a/lib/client_data/builder.rb b/lib/client_data/builder.rb index abc1234..def5678 100644 --- a/lib/client_data/builder.rb +++ b/lib/client_data/builder.rb @@ -16,7 +16,7 @@ def self.property(prop) define_method(prop) do - if controller.respond_to?(prop) + if controller.respond_to?(p...
Check if property responds to protected methods
diff --git a/lib/last_modified_at.rb b/lib/last_modified_at.rb index abc1234..def5678 100644 --- a/lib/last_modified_at.rb +++ b/lib/last_modified_at.rb @@ -2,8 +2,8 @@ class LastModifiedAtTag < Liquid::Tag def render(context) article_file = context.environments.first["page"]["path"] - article_file_p...
Fix article_file_path lookup and git invocation
diff --git a/lib/hlspider/downloader.rb b/lib/hlspider/downloader.rb index abc1234..def5678 100644 --- a/lib/hlspider/downloader.rb +++ b/lib/hlspider/downloader.rb @@ -43,7 +43,7 @@ if responses[:callback].size == urls.size responses[:callback].collect { |k,v| v } else - raise ConnectionEr...
Fix wording on connection error
diff --git a/Framezilla.podspec b/Framezilla.podspec index abc1234..def5678 100644 --- a/Framezilla.podspec +++ b/Framezilla.podspec @@ -1,6 +1,6 @@ Pod::Spec.new do |spec| spec.name = "Framezilla" - spec.version = "2.2.0" + spec.version = "2.2.1" spec.summary = "Comfortab...
Change podspec version -> 2.2.1
diff --git a/lib/regexpert/generator.rb b/lib/regexpert/generator.rb index abc1234..def5678 100644 --- a/lib/regexpert/generator.rb +++ b/lib/regexpert/generator.rb @@ -10,8 +10,12 @@ expression = regex.to_s str = "" - str << regex.split.each do |el| - expr = Regexpert::Regex.matchers.find ...
Revert accidental commit that broke stuff This reverts commit dd5736802eadca86537734f4f63dc17dc4e2cf95.
diff --git a/lib/walmart_open/client.rb b/lib/walmart_open/client.rb index abc1234..def5678 100644 --- a/lib/walmart_open/client.rb +++ b/lib/walmart_open/client.rb @@ -10,12 +10,11 @@ class Client attr_reader :connection attr_reader :config + attr_reader :auth_token def initialize(config_attrs = ...
Move authentication into its own method
diff --git a/test/integration/default/serverspec/spec_helper.rb b/test/integration/default/serverspec/spec_helper.rb index abc1234..def5678 100644 --- a/test/integration/default/serverspec/spec_helper.rb +++ b/test/integration/default/serverspec/spec_helper.rb @@ -5,7 +5,6 @@ RSpec.configure do |c| c.before :all d...
Remove superfluous line from serverspec spec helper
diff --git a/lib/heroku_rails_deflate/railtie.rb b/lib/heroku_rails_deflate/railtie.rb index abc1234..def5678 100644 --- a/lib/heroku_rails_deflate/railtie.rb +++ b/lib/heroku_rails_deflate/railtie.rb @@ -3,16 +3,17 @@ module HerokuRailsDeflate class Railtie < Rails::Railtie - initializer "heroku_rails_deflate....
Make sure deflater is inserted into the right place
diff --git a/lib/reek/ast/reference_collector.rb b/lib/reek/ast/reference_collector.rb index abc1234..def5678 100644 --- a/lib/reek/ast/reference_collector.rb +++ b/lib/reek/ast/reference_collector.rb @@ -6,8 +6,6 @@ # of an abstract syntax tree. # class ReferenceCollector - STOP_NODES = [:class, :mo...
Remove completely untested stop nodes list
diff --git a/rack-honeytoken.gemspec b/rack-honeytoken.gemspec index abc1234..def5678 100644 --- a/rack-honeytoken.gemspec +++ b/rack-honeytoken.gemspec @@ -6,7 +6,7 @@ Gem::Specification.new do |spec| spec.name = "rack-honeytoken" spec.version = Rack::Honeytoken::VERSION - spec.license = ["...
Fix license statement for single license only
diff --git a/rails-footnotes.gemspec b/rails-footnotes.gemspec index abc1234..def5678 100644 --- a/rails-footnotes.gemspec +++ b/rails-footnotes.gemspec @@ -18,7 +18,6 @@ s.add_development_dependency "rspec-rails" s.add_development_dependency "capybara" - s.add_development_dependency "pry-byebug" s.files ...
Remove pry-byebug from gemspec since it's not compatible with all rubies
diff --git a/db/migrate/20180728095650_drop_issues_and_scopes.rb b/db/migrate/20180728095650_drop_issues_and_scopes.rb index abc1234..def5678 100644 --- a/db/migrate/20180728095650_drop_issues_and_scopes.rb +++ b/db/migrate/20180728095650_drop_issues_and_scopes.rb @@ -0,0 +1,23 @@+# frozen_string_literal: true + +class...
Add migration to drop issues and scopes tables
diff --git a/db/migrate/20220407162133_add_secret_to_settings.rb b/db/migrate/20220407162133_add_secret_to_settings.rb index abc1234..def5678 100644 --- a/db/migrate/20220407162133_add_secret_to_settings.rb +++ b/db/migrate/20220407162133_add_secret_to_settings.rb @@ -0,0 +1,27 @@+# frozen_string_literal: true + +# +# ...
Add `secret` column to Settings In a subsequent commit, this will allow a setting to be marked as "secret", and its value redacted in the forthcoming Settings UI. refs DE-1138 flag=none test plan: - verify the column is added, and `setting=` is successful Change-Id: I0dfad0ea584e199828ff04fabe91964069d3e676 Reviewe...
diff --git a/lib/flipper/feature_check_context.rb b/lib/flipper/feature_check_context.rb index abc1234..def5678 100644 --- a/lib/flipper/feature_check_context.rb +++ b/lib/flipper/feature_check_context.rb @@ -1,6 +1,10 @@ module Flipper class FeatureCheckContext + # Public: The name of the feature. attr_read...
Add docs for feature check context methods
diff --git a/lib/git_time_machine/time_machine.rb b/lib/git_time_machine/time_machine.rb index abc1234..def5678 100644 --- a/lib/git_time_machine/time_machine.rb +++ b/lib/git_time_machine/time_machine.rb @@ -18,12 +18,21 @@ delorean.accelerate(88) end - def back_to(time_string) - raise "BOOM" + ...
Implement the back_to method for full time travel experience
diff --git a/db/migrate/20160112153334_change_community_center_to_community_centre.rb b/db/migrate/20160112153334_change_community_center_to_community_centre.rb index abc1234..def5678 100644 --- a/db/migrate/20160112153334_change_community_center_to_community_centre.rb +++ b/db/migrate/20160112153334_change_community_c...
Use temporary model in migration
diff --git a/cookbooks/cumulus/test/cookbooks/cumulus-test/recipes/default.rb b/cookbooks/cumulus/test/cookbooks/cumulus-test/recipes/default.rb index abc1234..def5678 100644 --- a/cookbooks/cumulus/test/cookbooks/cumulus-test/recipes/default.rb +++ b/cookbooks/cumulus/test/cookbooks/cumulus-test/recipes/default.rb @@ ...
Install ifupdown2 inside the test instance
diff --git a/spec/lib/utusemi/configuration_spec.rb b/spec/lib/utusemi/configuration_spec.rb index abc1234..def5678 100644 --- a/spec/lib/utusemi/configuration_spec.rb +++ b/spec/lib/utusemi/configuration_spec.rb @@ -1,23 +1,27 @@ describe Utusemi::Configuration do + let(:product) { FactoryGirl.build(:product) } + ...
Add a test for options argument
diff --git a/spec/scss_lint/linter_registry_spec.rb b/spec/scss_lint/linter_registry_spec.rb index abc1234..def5678 100644 --- a/spec/scss_lint/linter_registry_spec.rb +++ b/spec/scss_lint/linter_registry_spec.rb @@ -2,22 +2,31 @@ describe SCSSLint::LinterRegistry do context 'when including the LinterRegistry modu...
Fix LinterRegistry specs to not pollute actual registry In the process of writing some other specs, there was a problem where the linters inserted into the registry by this spec were breaking other specs. Fix by modifying the specs to not modify the global linter registry. Change-Id: I22c0e282003da4f6ebc8f52758654f3...
diff --git a/spec/views/batch/edit.html.erb_spec.rb b/spec/views/batch/edit.html.erb_spec.rb index abc1234..def5678 100644 --- a/spec/views/batch/edit.html.erb_spec.rb +++ b/spec/views/batch/edit.html.erb_spec.rb @@ -1,8 +1,12 @@ require 'spec_helper' describe 'batch/edit.html.erb' do - let(:batch) { stub_model(Bat...
Use real objects for view test
diff --git a/db/migrate/096_create_translation_tables.rb b/db/migrate/096_create_translation_tables.rb index abc1234..def5678 100644 --- a/db/migrate/096_create_translation_tables.rb +++ b/db/migrate/096_create_translation_tables.rb @@ -14,10 +14,11 @@ publicbody.translated_attributes.each do |a, default| ...
Save the default translated values for publicbody entities.
diff --git a/ext/hiredis_ext/extconf.rb b/ext/hiredis_ext/extconf.rb index abc1234..def5678 100644 --- a/ext/hiredis_ext/extconf.rb +++ b/ext/hiredis_ext/extconf.rb @@ -10,8 +10,13 @@ RbConfig::CONFIG['configure_args'] =~ /with-make-prog\=(\w+)/ make_program = $1 || ENV['make'] -unless make_program then - make_prog...
Add default for BSD and Solaris to gmake
diff --git a/tasks/valgrind.rake b/tasks/valgrind.rake index abc1234..def5678 100644 --- a/tasks/valgrind.rake +++ b/tasks/valgrind.rake @@ -0,0 +1,3 @@+task :valgrind do + `valgrind --suppressions=gir_ffi-ruby1.9.1.supp --leak-check=full ruby1.9.1 -Ilib -e "require 'ffi-gobject_introspection'"` +end
Add task to simplify Valgrind run.
diff --git a/httparty.gemspec b/httparty.gemspec index abc1234..def5678 100644 --- a/httparty.gemspec +++ b/httparty.gemspec @@ -19,7 +19,7 @@ s.add_dependency 'multi_xml', ">= 0.5.2" # If this line is removed, all hard partying will cease. - s.post_install_message = "When you HTTParty, you must party hard! 🎉"...
Remove high-byte emoji from post-install message Since @jnunemaker will never remove the message (even though he never sees it because he runs with `--quiet`), at least make it so that the regular output is ASCII.
diff --git a/app/controllers/casts_controller.rb b/app/controllers/casts_controller.rb index abc1234..def5678 100644 --- a/app/controllers/casts_controller.rb +++ b/app/controllers/casts_controller.rb @@ -2,10 +2,10 @@ def index @anime = Anime.find(params[:anime_id]) @casting = @anime.castings.includes(:cha...
Fix duplicate suggestions in the character name typeahead.
diff --git a/app/controllers/items_controller.rb b/app/controllers/items_controller.rb index abc1234..def5678 100644 --- a/app/controllers/items_controller.rb +++ b/app/controllers/items_controller.rb @@ -2,7 +2,7 @@ helper_method :display_user_votes_for, :new_item_for_current_user def index - @items = Item.all.p...
Add Includes User Votes When Getting Items
diff --git a/rails_event_store-rspec/rails_event_store-rspec.gemspec b/rails_event_store-rspec/rails_event_store-rspec.gemspec index abc1234..def5678 100644 --- a/rails_event_store-rspec/rails_event_store-rspec.gemspec +++ b/rails_event_store-rspec/rails_event_store-rspec.gemspec @@ -25,4 +25,6 @@ spec.add_developmen...
Revert rspec as runtime dependency Without rspec gem tests are failing with LoadError: cannot load such file -- rspec Regression fix #115
diff --git a/app/controllers/users_controller.rb b/app/controllers/users_controller.rb index abc1234..def5678 100644 --- a/app/controllers/users_controller.rb +++ b/app/controllers/users_controller.rb @@ -10,11 +10,21 @@ @user = User.find_or_create_by(email: user_params[:email]) if @user.update(user_params) ...
Add initial Api handling with respond_to
diff --git a/GrowthPush.podspec b/GrowthPush.podspec index abc1234..def5678 100644 --- a/GrowthPush.podspec +++ b/GrowthPush.podspec @@ -12,7 +12,7 @@ s.author = { "SIROK, Inc." => "support@growthpush.com" } s.source = { :git => "https://github.com/SIROK/growthpush-ios.git", :tag => "#{s.version}...
Modify podspec file to pass lint.
diff --git a/app/helpers/forums/forums_helper.rb b/app/helpers/forums/forums_helper.rb index abc1234..def5678 100644 --- a/app/helpers/forums/forums_helper.rb +++ b/app/helpers/forums/forums_helper.rb @@ -7,7 +7,7 @@ # @param title The title to make into a reply. # @returns string def replize_title(title) - ...
Fix case insensitive match for reply detection.
diff --git a/app/models/archived_pull_request.rb b/app/models/archived_pull_request.rb index abc1234..def5678 100644 --- a/app/models/archived_pull_request.rb +++ b/app/models/archived_pull_request.rb @@ -1,5 +1,5 @@ class ArchivedPullRequest < ApplicationRecord - PAST_YEARS = [2014, 2013, 2012] + PAST_YEARS = [2015,...
Add 2015 to previous archived years
diff --git a/lib/config/wdtk-routes.rb b/lib/config/wdtk-routes.rb index abc1234..def5678 100644 --- a/lib/config/wdtk-routes.rb +++ b/lib/config/wdtk-routes.rb @@ -7,7 +7,7 @@ get '/reset' => 'user#survey_reset', :as => :survey_reset end - get "/help/ico-guidance-for-authorities" => redirect("https://ico.org...
Update ico-guidance-for-authorities link to point to new pdf
diff --git a/capistrano-jenkins.gemspec b/capistrano-jenkins.gemspec index abc1234..def5678 100644 --- a/capistrano-jenkins.gemspec +++ b/capistrano-jenkins.gemspec @@ -1,7 +1,7 @@ # -*- encoding: utf-8 -*- Gem::Specification.new do |s| s.name = "capistrano-jenkins" - s.version = "0.1.3" + s.version ...
Add license to gemspec and bump version.
diff --git a/lib/oauth2/provider/rack/authentication_mediator.rb b/lib/oauth2/provider/rack/authentication_mediator.rb index abc1234..def5678 100644 --- a/lib/oauth2/provider/rack/authentication_mediator.rb +++ b/lib/oauth2/provider/rack/authentication_mediator.rb @@ -1,6 +1,5 @@ module OAuth2::Provider::Rack class ...
Remove unused accessor from the AuthenticationMediator
diff --git a/test/test_helper.rb b/test/test_helper.rb index abc1234..def5678 100644 --- a/test/test_helper.rb +++ b/test/test_helper.rb @@ -4,6 +4,7 @@ require File.expand_path("../../test/dummy/config/environment.rb", __FILE__) ActiveRecord::Migrator.migrations_paths = [File.expand_path("../../test/dummy/db/migrate...
Add a minitest fun colors
diff --git a/app/workers/scheduled_machine_update_worker.rb b/app/workers/scheduled_machine_update_worker.rb index abc1234..def5678 100644 --- a/app/workers/scheduled_machine_update_worker.rb +++ b/app/workers/scheduled_machine_update_worker.rb @@ -2,33 +2,20 @@ include Sidekiq::Worker def perform - if IDB.co...
Revert "also query oxidized when updating" This reverts commit 89e9cf6e9aaa0f9cde58ffbdfc1caadaafa94032.
diff --git a/lib/arel-ltree/ltree/predications.rb b/lib/arel-ltree/ltree/predications.rb index abc1234..def5678 100644 --- a/lib/arel-ltree/ltree/predications.rb +++ b/lib/arel-ltree/ltree/predications.rb @@ -9,10 +9,14 @@ Arel::Ltree::Nodes::DescendantOf.new(self, other) end - def matches(*args) ...
Allow use array as an argument of .matches method
diff --git a/lib/conjur/appliance/logging/railtie.rb b/lib/conjur/appliance/logging/railtie.rb index abc1234..def5678 100644 --- a/lib/conjur/appliance/logging/railtie.rb +++ b/lib/conjur/appliance/logging/railtie.rb @@ -1,11 +1,26 @@ module Conjur module Appliance module Logging + + # The current version ...
Add Rack::CommonLogger to the app's middleware
diff --git a/lib/lita/handlers/wotd.rb b/lib/lita/handlers/wotd.rb index abc1234..def5678 100644 --- a/lib/lita/handlers/wotd.rb +++ b/lib/lita/handlers/wotd.rb @@ -1,10 +1,6 @@ require 'net/http' require 'uri' -require 'pry' require 'rexml/document' -require 'json' - - module Lita module Handlers
Remove cruft from initial development
diff --git a/lib/media_magick/model.rb b/lib/media_magick/model.rb index abc1234..def5678 100644 --- a/lib/media_magick/model.rb +++ b/lib/media_magick/model.rb @@ -2,6 +2,28 @@ require 'carrierwave/mongoid' require 'media_magick/attachment_uploader' require 'mongoid' + +module CarrierWave + module Uploader + mod...
Fix a CarrierWave 0.5.8 problem.
diff --git a/lib/sass/script/string_interpolation.rb b/lib/sass/script/string_interpolation.rb index abc1234..def5678 100644 --- a/lib/sass/script/string_interpolation.rb +++ b/lib/sass/script/string_interpolation.rb @@ -0,0 +1,36 @@+module Sass::Script + class StringInterpolation < Node + def initialize(before, mi...
[Sass] Add the StringInterpolation file. Blah.
diff --git a/timeline_fu.gemspec b/timeline_fu.gemspec index abc1234..def5678 100644 --- a/timeline_fu.gemspec +++ b/timeline_fu.gemspec @@ -7,7 +7,7 @@ s.version = TimelineFu::VERSION s.authors = ["James Golick", "Mathieu Martin", "Francois Beausoleil"] s.email = "james@giraffesoft.ca" - s.homepage = "http://...
Change homepage to correct one.
diff --git a/app/models/five_colors_data.rb b/app/models/five_colors_data.rb index abc1234..def5678 100644 --- a/app/models/five_colors_data.rb +++ b/app/models/five_colors_data.rb @@ -0,0 +1,7 @@+module FiveColors + YELLOW = [2, 7, 10, 18, 32, 33, 37, 39, 46, 47, 55, 60, 78, 79, 81, 85, 87, 89, 94, 96] + PINK = [1...
Add module FiveColors for 五色百人一首
diff --git a/app/reports/integrity_check.rb b/app/reports/integrity_check.rb index abc1234..def5678 100644 --- a/app/reports/integrity_check.rb +++ b/app/reports/integrity_check.rb @@ -16,12 +16,15 @@ raise "no educators" unless Educator.count > 0 end + def models_to_check + [StudentAssessment, Assessment,...
Make data integrity check more verbose + We get a stack trace and error message if there's a data problem ... + ... but we also need some output if there are no errors
diff --git a/lib/matron/git.rb b/lib/matron/git.rb index abc1234..def5678 100644 --- a/lib/matron/git.rb +++ b/lib/matron/git.rb @@ -3,17 +3,19 @@ module Matron class Git attr_reader :repo + attr_accessor :diff_against def self.from_path( path ) new Grit::Repo.new( path ) end - def in...
Allow diff version to be customized
diff --git a/abfab.gemspec b/abfab.gemspec index abc1234..def5678 100644 --- a/abfab.gemspec +++ b/abfab.gemspec @@ -14,4 +14,8 @@ gem.name = "abfab" gem.require_paths = ["lib"] gem.version = ABFab::VERSION + + gem.add_dependency "redis", "~> 2.2.2" + + gem.add_development_dependency "rspec", "...
Add redis and rspec gems as dependencies.
diff --git a/lib/origami/s3_package.rb b/lib/origami/s3_package.rb index abc1234..def5678 100644 --- a/lib/origami/s3_package.rb +++ b/lib/origami/s3_package.rb @@ -25,7 +25,7 @@ protected def package_key - "#{version}/#{version}.apk" + "#{version}/Kickstarter-#{version}.apk" end end end
Append "Kickstarter-" to package name Friendlier than just the number jumble
diff --git a/lib/dcenv/cli.rb b/lib/dcenv/cli.rb index abc1234..def5678 100644 --- a/lib/dcenv/cli.rb +++ b/lib/dcenv/cli.rb @@ -11,11 +11,15 @@ desc "install", "Install container" def install(*args) - name = args[0] - cname = to_cname(name) + if args.length >= 2 + cname = to_cname(args...
Support second argument of install command $ dcenv install rust schickling/rust
diff --git a/lib/tasks/db.rake b/lib/tasks/db.rake index abc1234..def5678 100644 --- a/lib/tasks/db.rake +++ b/lib/tasks/db.rake @@ -2,7 +2,7 @@ module RakeHelpers def self.db_config - @config ||= YAML.load_file("config/database.yml")[ENV['RAILS_ENV'] || 'development'] || {} + @config ||= db_config_f...
Fix bug causing Rake task failure when no DB config The entire `rake` command should not fail because some introspection failed due to a missing file. This was a pretty glaring bug.
diff --git a/lib/tasks/db.rake b/lib/tasks/db.rake index abc1234..def5678 100644 --- a/lib/tasks/db.rake +++ b/lib/tasks/db.rake @@ -12,6 +12,8 @@ 'wb_indc:import', 'adaptation:import', 'wri_metadata:import' + 'adaptation:import', + 'wb_extra:import' ] desc 'Imports all data in correct order...
Add wb_extra import task to the main import task
diff --git a/lib/simple-conf/loader.rb b/lib/simple-conf/loader.rb index abc1234..def5678 100644 --- a/lib/simple-conf/loader.rb +++ b/lib/simple-conf/loader.rb @@ -1,4 +1,5 @@ require 'ostruct' +require 'yaml' module SimpleConf class Loader
Add require yaml library for parsing configuration files
diff --git a/lib/snapme/cli/options.rb b/lib/snapme/cli/options.rb index abc1234..def5678 100644 --- a/lib/snapme/cli/options.rb +++ b/lib/snapme/cli/options.rb @@ -6,12 +6,13 @@ DEFAULT_HOST = 'http://snapme.herokuapp.com' DEFAULT_INTERVAL = 30 #seconds - attr_reader :daemon, :host, :interval +...
Add --version option to cli
diff --git a/lib/table_data_service.rb b/lib/table_data_service.rb index abc1234..def5678 100644 --- a/lib/table_data_service.rb +++ b/lib/table_data_service.rb @@ -42,6 +42,6 @@ end def self.transaction_is_income?(transaction) - transaction.metadata['is_topup'] == 'true' + transaction.amount.positive? ...
Fix bug in defining income vs expenditure
diff --git a/lib/timetress.rb b/lib/timetress.rb index abc1234..def5678 100644 --- a/lib/timetress.rb +++ b/lib/timetress.rb @@ -6,6 +6,7 @@ require 'timetress/norway' require 'timetress/usa' +require 'timetress/scotland' module Timetress class BeMoreSpecific < RuntimeError; end
Include the Scotland module in the gem entry point.
diff --git a/config/initializers/devise.rb b/config/initializers/devise.rb index abc1234..def5678 100644 --- a/config/initializers/devise.rb +++ b/config/initializers/devise.rb @@ -6,8 +6,13 @@ OmniAuth.logger.progname = 'omniauth' OmniAuth.config.on_failure = proc do |env| - env['devise.mapping'] = Devise.mappings...
Fix OmniAuth auth failure proc Currently we configure OmniAuth so that if the authorization step fails, the `failure` action in Spree::OmniauthCallbacksController is called. This controller is obtained by taking the configured Spree user class (Spree::User), asking for its table name (`spree_users`), then looking up t...
diff --git a/spec/factories/posts.rb b/spec/factories/posts.rb index abc1234..def5678 100644 --- a/spec/factories/posts.rb +++ b/spec/factories/posts.rb @@ -1,5 +1,5 @@ FactoryGirl.define do factory :post do - title { Faker::Lorem.sentence(2) } + title { Faker::Lorem.sentence(2)[0..60] } end end
Add length constraints to title in Post model factory Signed-off-by: Max Fierke <0706025b2bbcec1ed8d64822f4eccd96314938d0@maxfierke.com>
diff --git a/lib/acts_as_flying_saucer_view.rb b/lib/acts_as_flying_saucer_view.rb index abc1234..def5678 100644 --- a/lib/acts_as_flying_saucer_view.rb +++ b/lib/acts_as_flying_saucer_view.rb @@ -5,7 +5,7 @@ alias_method :old_stylesheet_link_tag, :stylesheet_link_tag - def stylesheet_link_tag(...
Rename ActionView::Helpers::AssetTagHelper.stylesheet_link_tag to print_stylesheet_link_tag (stringify_keys doesn't work for rails3)
diff --git a/lib/autoprefixer-rails/railtie.rb b/lib/autoprefixer-rails/railtie.rb index abc1234..def5678 100644 --- a/lib/autoprefixer-rails/railtie.rb +++ b/lib/autoprefixer-rails/railtie.rb @@ -5,29 +5,42 @@ class Railtie < ::Rails::Railtie rake_tasks do |app| require 'rake/autoprefixer_tasks' - ...
Support autoprefixer.yml's provided by engines
diff --git a/lib/azure/profile/subscription.rb b/lib/azure/profile/subscription.rb index abc1234..def5678 100644 --- a/lib/azure/profile/subscription.rb +++ b/lib/azure/profile/subscription.rb @@ -12,5 +12,6 @@ def initialize yield self if block_given? + @management_endpoint ||= DEFAULT_MANAGEMENT_ENDPOINT ...
Set a default endpoint in the constructor if one isn't set.
diff --git a/lib/bunny/concurrent/condition.rb b/lib/bunny/concurrent/condition.rb index abc1234..def5678 100644 --- a/lib/bunny/concurrent/condition.rb +++ b/lib/bunny/concurrent/condition.rb @@ -5,13 +5,16 @@ # Akin to java.util.concurrent.Condition and intrinsic object monitors (Object#wait, Object#notify, Objec...
Make it possible to [optionally] annotate Bunny::Concurrent::Condition for ease of debugging
diff --git a/libPusher.podspec b/libPusher.podspec index abc1234..def5678 100644 --- a/libPusher.podspec +++ b/libPusher.podspec @@ -5,7 +5,7 @@ s.summary = 'An Objective-C client for the Pusher.com service' s.homepage = 'https://github.com/lukeredpath/libPusher' s.author = 'Luke Redpath...
Update git tag in podspec
diff --git a/lib/jrb/rails/template_handler.rb b/lib/jrb/rails/template_handler.rb index abc1234..def5678 100644 --- a/lib/jrb/rails/template_handler.rb +++ b/lib/jrb/rails/template_handler.rb @@ -7,7 +7,10 @@ [ "class_eval { def <<(out); @output_buffer << out; end; alias_method :write, :<< }", ...
Write last result of template.
diff --git a/lib/log_memory_consumption_job.rb b/lib/log_memory_consumption_job.rb index abc1234..def5678 100644 --- a/lib/log_memory_consumption_job.rb +++ b/lib/log_memory_consumption_job.rb @@ -1,8 +1,6 @@ class LogMemoryConsumptionJob < Struct.new(:last_stat) # Number of entries do display N = 20 - # In seco...
Remove peridicity on log_memory_consumption job
diff --git a/lib/metal_archives/cache/redis.rb b/lib/metal_archives/cache/redis.rb index abc1234..def5678 100644 --- a/lib/metal_archives/cache/redis.rb +++ b/lib/metal_archives/cache/redis.rb @@ -28,11 +28,11 @@ end def include?(key) - redis.exists? key + redis.exists? cache_key_for(key) ...
Fix cache key not called
diff --git a/lib/rest-core/client/yahoo_buy.rb b/lib/rest-core/client/yahoo_buy.rb index abc1234..def5678 100644 --- a/lib/rest-core/client/yahoo_buy.rb +++ b/lib/rest-core/client/yahoo_buy.rb @@ -7,6 +7,7 @@ Client = Builder.client(:api_key) do use Timeout , 10 + use DefaultQuery use Sig...
Add default query (api key and timestamp) to yahoo buy
diff --git a/libraries/provider_cpan_module.rb b/libraries/provider_cpan_module.rb index abc1234..def5678 100644 --- a/libraries/provider_cpan_module.rb +++ b/libraries/provider_cpan_module.rb @@ -5,6 +5,8 @@ class Provider # Provider for cpan_module lwrp class CpanModule < Chef::Provider::LWRPBase + p...
Resolve Chef 13 deprecation warning
diff --git a/sprockets-rails.gemspec b/sprockets-rails.gemspec index abc1234..def5678 100644 --- a/sprockets-rails.gemspec +++ b/sprockets-rails.gemspec @@ -9,7 +9,7 @@ s.summary = "Sprockets Rails integration" s.license = "MIT" - s.files = Dir["README.md", "lib/**/*.rb", "LICENSE"] + s.files = Dir["README.m...
Fix the name of the license file Closes #296
diff --git a/lib/avalon/workflow/workflow_model_mixin.rb b/lib/avalon/workflow/workflow_model_mixin.rb index abc1234..def5678 100644 --- a/lib/avalon/workflow/workflow_model_mixin.rb +++ b/lib/avalon/workflow/workflow_model_mixin.rb @@ -18,7 +18,7 @@ module Avalon::Workflow module WorkflowModelMixin def self.in...
Use Hydra 10 style datastream declaration
diff --git a/lib/captain_hook/dsl/handle_post_receive.rb b/lib/captain_hook/dsl/handle_post_receive.rb index abc1234..def5678 100644 --- a/lib/captain_hook/dsl/handle_post_receive.rb +++ b/lib/captain_hook/dsl/handle_post_receive.rb @@ -6,7 +6,6 @@ end def message - puts "post-receive: #{@post_rec...
Remove debug puts for post-receive.
diff --git a/lib/perus/pinger/commands/chrome_execute.rb b/lib/perus/pinger/commands/chrome_execute.rb index abc1234..def5678 100644 --- a/lib/perus/pinger/commands/chrome_execute.rb +++ b/lib/perus/pinger/commands/chrome_execute.rb @@ -17,6 +17,9 @@ else result = false ...
Clean up memory used during chrome js executions
diff --git a/lib/suspenders/generators/lint_generator.rb b/lib/suspenders/generators/lint_generator.rb index abc1234..def5678 100644 --- a/lib/suspenders/generators/lint_generator.rb +++ b/lib/suspenders/generators/lint_generator.rb @@ -8,9 +8,12 @@ gem 'rubocop-rails', require: false, group: :development ...
Use a recent version of overcommit, otherwise --sign is broken
diff --git a/spec/spec_helper.rb b/spec/spec_helper.rb index abc1234..def5678 100644 --- a/spec/spec_helper.rb +++ b/spec/spec_helper.rb @@ -4,8 +4,8 @@ require 'vcr' require 'pry' require 'byebug' +require 'simplecov' -require 'simplecov' SimpleCov.start do add_group 'API', 'lib/evertrue/api' end @@ -25,9 +25...
Remove unused Faraday stubbing method
diff --git a/spec/spec_helper.rb b/spec/spec_helper.rb index abc1234..def5678 100644 --- a/spec/spec_helper.rb +++ b/spec/spec_helper.rb @@ -1,7 +1,10 @@ # coding: utf-8 -require 'coveralls' -Coveralls.wear! +# Disable code coverage for JRuby because it always reports 0% coverage. +if RUBY_ENGINE != 'jruby' + requir...
Disable code coverage for JRuby
diff --git a/spec/spec_helper.rb b/spec/spec_helper.rb index abc1234..def5678 100644 --- a/spec/spec_helper.rb +++ b/spec/spec_helper.rb @@ -1,3 +1,12 @@ # encoding: utf-8 -require 'jara'+require 'jara' + +RSpec.configure do |config| + config.expect_with :rspec do |c| + c.syntax = [:should, :expect] + end + con...
Configure RSpec 3.x to support the old RSpec syntax
diff --git a/spec/spec_helper.rb b/spec/spec_helper.rb index abc1234..def5678 100644 --- a/spec/spec_helper.rb +++ b/spec/spec_helper.rb @@ -33,6 +33,10 @@ end end +def T(*args) + ROM::Processor::Transproc::Functions[*args] +end + RSpec.configure do |config| config.after do Test.remove_constants
[WIP] Update to new transproc API
diff --git a/spec/spec_helper.rb b/spec/spec_helper.rb index abc1234..def5678 100644 --- a/spec/spec_helper.rb +++ b/spec/spec_helper.rb @@ -1,6 +1,8 @@ require 'rubygems' require 'rspec' require 'active_zuora' + +I18n.enforce_available_locales = true ActiveZuora.configure( :log => ENV['DEBUG'],
Enforce locale to get rid of deprecation warning
diff --git a/spec/spec_helper.rb b/spec/spec_helper.rb index abc1234..def5678 100644 --- a/spec/spec_helper.rb +++ b/spec/spec_helper.rb @@ -17,6 +17,35 @@ File.should_receive(:readable?).at_least(:once).with(dotfile).and_return(false) end -# Infinity Test runs tests as subprocesses, which sets STDOUT.tty? to fals...
Add missing String methods to make all specs pass with Ruby 1.8.6
diff --git a/spec/spec_helper.rb b/spec/spec_helper.rb index abc1234..def5678 100644 --- a/spec/spec_helper.rb +++ b/spec/spec_helper.rb @@ -0,0 +1,6 @@+$:.unshift File.expand_path('..', __FILE__) +$:.unshift File.expand_path('../../lib', __FILE__) +require 'coveralls' +Coveralls.wear! +require 'rspec' +require 'pry'
Add the spec helper file
diff --git a/spec/spec_helper.rb b/spec/spec_helper.rb index abc1234..def5678 100644 --- a/spec/spec_helper.rb +++ b/spec/spec_helper.rb @@ -26,11 +26,26 @@ example.run } end + + # Remove all indexes setup in this run in local or CI + c.after(:suite) do + safe_index_list.each do |index| + Algoli...
Add safe index name prefix and after suite index deletion
diff --git a/spec/spec_helper.rb b/spec/spec_helper.rb index abc1234..def5678 100644 --- a/spec/spec_helper.rb +++ b/spec/spec_helper.rb @@ -1,8 +1,10 @@+ # Configure Rails Envinronment ENV["RAILS_ENV"] = "test" require File.expand_path("../dummy/config/environment.rb", __FILE__) require 'rspec/rails' + ENGIN...
Set up test class on every spec run to ensure clean slate
diff --git a/spec/spec_helper.rb b/spec/spec_helper.rb index abc1234..def5678 100644 --- a/spec/spec_helper.rb +++ b/spec/spec_helper.rb @@ -1,2 +1,7 @@ require 'minitest/autorun' require 'minitest/pride' + +# For my rspec poisoned brain. ;) +module Kernel + alias_method :context, :describe +end
Add context alias for describe.