diff
stringlengths
65
26.7k
message
stringlengths
7
9.92k
diff --git a/spec/pptx/smoke/api_shape_spec.rb b/spec/pptx/smoke/api_shape_spec.rb index abc1234..def5678 100644 --- a/spec/pptx/smoke/api_shape_spec.rb +++ b/spec/pptx/smoke/api_shape_spec.rb @@ -0,0 +1,30 @@+require 'spec_helper' +describe 'ApiShape section tests' do + it 'ApiShape | GetClassType method' do + ppt...
Add shape test for presentation.
diff --git a/spec/services/next_player_spec.rb b/spec/services/next_player_spec.rb index abc1234..def5678 100644 --- a/spec/services/next_player_spec.rb +++ b/spec/services/next_player_spec.rb @@ -0,0 +1,18 @@+require "rails_helper" + +RSpec.describe NextPlayer, type: :service do + fixtures :all + let(:find_next_play...
Add basic spec for next_player
diff --git a/spec/watirspec/checkboxes_spec.rb b/spec/watirspec/checkboxes_spec.rb index abc1234..def5678 100644 --- a/spec/watirspec/checkboxes_spec.rb +++ b/spec/watirspec/checkboxes_spec.rb @@ -24,6 +24,7 @@ count = 0 browser.checkboxes.each_with_index do |c, index| + c.should be_instance_of(Ch...
Make sure CheckBoxCollection enumerates ChecBox instances.
diff --git a/week-4/triangle-side/my_solution.rb b/week-4/triangle-side/my_solution.rb index abc1234..def5678 100644 --- a/week-4/triangle-side/my_solution.rb +++ b/week-4/triangle-side/my_solution.rb @@ -1,4 +1,4 @@-# I worked on this challenge [by myself, with: ]. +# I worked on this challenge [by myself, with: Kevin...
Add triangle-side challenge edit typo
diff --git a/ticket_gate.gemspec b/ticket_gate.gemspec index abc1234..def5678 100644 --- a/ticket_gate.gemspec +++ b/ticket_gate.gemspec @@ -22,4 +22,6 @@ spec.add_development_dependency "rake" spec.add_development_dependency "rspec" spec.add_development_dependency "rocket_pants" + + spec.add_runtime_depende...
Add rocket_pants as runtime dependency
diff --git a/sprout-osx-apps/attributes/vlc.rb b/sprout-osx-apps/attributes/vlc.rb index abc1234..def5678 100644 --- a/sprout-osx-apps/attributes/vlc.rb +++ b/sprout-osx-apps/attributes/vlc.rb @@ -0,0 +1,2 @@+node.default["vlc_version"]="2.0.8" +node.default["vlc_checksum"]="bbfdc6d10d9f3a4d357d276d9c6db9c049e637fa2cc5...
Copy VLC attributes into sprout-osx-apps, update to version 2.08
diff --git a/_plugins/jekyll_slideshow.rb b/_plugins/jekyll_slideshow.rb index abc1234..def5678 100644 --- a/_plugins/jekyll_slideshow.rb +++ b/_plugins/jekyll_slideshow.rb @@ -9,10 +9,11 @@ def generate(site) + config = Jekyll.configuration({})['slideshow'] site.static_files.each do |file| ...
Set thumbnail size based on config
diff --git a/sonos_wailer.rb b/sonos_wailer.rb index abc1234..def5678 100644 --- a/sonos_wailer.rb +++ b/sonos_wailer.rb @@ -18,4 +18,7 @@ upstairs_speaker.play end +# Set reasonable volume +upstairs_speaker.volume = 50 +
Set fixed volume for Sonos wailer
diff --git a/ellen-syoboi_calendar.gemspec b/ellen-syoboi_calendar.gemspec index abc1234..def5678 100644 --- a/ellen-syoboi_calendar.gemspec +++ b/ellen-syoboi_calendar.gemspec @@ -16,6 +16,8 @@ spec.test_files = spec.files.grep(%r{^(test|spec|features)/}) spec.require_paths = ["lib"] + spec.add_dependency "...
Add gem dependencies, we will use them later
diff --git a/spec/classes/consul_exporter_spec.rb b/spec/classes/consul_exporter_spec.rb index abc1234..def5678 100644 --- a/spec/classes/consul_exporter_spec.rb +++ b/spec/classes/consul_exporter_spec.rb @@ -0,0 +1,30 @@+require 'spec_helper' + +describe 'prometheus::consul_exporter' do + on_supported_os.each do |os,...
Add unit test for consul_exporter
diff --git a/db/migrate/20171017190006_create_user_emails.rb b/db/migrate/20171017190006_create_user_emails.rb index abc1234..def5678 100644 --- a/db/migrate/20171017190006_create_user_emails.rb +++ b/db/migrate/20171017190006_create_user_emails.rb @@ -8,7 +8,13 @@ end User.find_each(batch_size: 100) do |use...
Fix migration in case of duplicate preexisting users
diff --git a/spec/controllers/categories_controller_spec.rb b/spec/controllers/categories_controller_spec.rb index abc1234..def5678 100644 --- a/spec/controllers/categories_controller_spec.rb +++ b/spec/controllers/categories_controller_spec.rb @@ -1,19 +1,36 @@ require 'spec_helper' describe CategoriesController do...
Update specs to test if controllers return json
diff --git a/app/models/event_instance.rb b/app/models/event_instance.rb index abc1234..def5678 100644 --- a/app/models/event_instance.rb +++ b/app/models/event_instance.rb @@ -22,10 +22,11 @@ class EventInstance < ApplicationRecord belongs_to :address belongs_to :event - has_many :attendees + belongs_to :quest...
Allow to delete event instance
diff --git a/spec/dummy/config/environments/development.rb b/spec/dummy/config/environments/development.rb index abc1234..def5678 100644 --- a/spec/dummy/config/environments/development.rb +++ b/spec/dummy/config/environments/development.rb @@ -24,4 +24,7 @@ # Do not compress assets config.assets.compress = fals...
Add default host in spec/dummy
diff --git a/app/services/level_access.rb b/app/services/level_access.rb index abc1234..def5678 100644 --- a/app/services/level_access.rb +++ b/app/services/level_access.rb @@ -2,6 +2,7 @@ def can_access?(level) return true if level == 1 + return true if level == 2 score = get_score_for(level-1) r...
Enable level 2 for everyone
diff --git a/spec/requests/expanded_links_endpoint_spec.rb b/spec/requests/expanded_links_endpoint_spec.rb index abc1234..def5678 100644 --- a/spec/requests/expanded_links_endpoint_spec.rb +++ b/spec/requests/expanded_links_endpoint_spec.rb @@ -0,0 +1,58 @@+require "rails_helper" + +RSpec.describe "GET /v2/expanded-lin...
Add test for expanded links endpoint This endpoint used to be internal for testing, but we will now use it from other apps. It needs some tests.
diff --git a/spec/unit/virtus/attribute/comparison_spec.rb b/spec/unit/virtus/attribute/comparison_spec.rb index abc1234..def5678 100644 --- a/spec/unit/virtus/attribute/comparison_spec.rb +++ b/spec/unit/virtus/attribute/comparison_spec.rb @@ -0,0 +1,23 @@+require 'spec_helper' + +describe Virtus::Attribute, '#== (def...
Add specs for attributes comparison (based on latest Equalizer gem working version)
diff --git a/lib/subscriptions/concerns/models/subscription_template_group.rb b/lib/subscriptions/concerns/models/subscription_template_group.rb index abc1234..def5678 100644 --- a/lib/subscriptions/concerns/models/subscription_template_group.rb +++ b/lib/subscriptions/concerns/models/subscription_template_group.rb @@ ...
Add acts_as_list to subscription template groups
diff --git a/annotate_models.gemspec b/annotate_models.gemspec index abc1234..def5678 100644 --- a/annotate_models.gemspec +++ b/annotate_models.gemspec @@ -6,7 +6,7 @@ spec.name = "annotate_models" spec.version = AnnotateModels::VERSION - spec.date = "2015-02-08" + spec.date = "2018-0...
Update release date of gem.
diff --git a/app/models/recipe.rb b/app/models/recipe.rb index abc1234..def5678 100644 --- a/app/models/recipe.rb +++ b/app/models/recipe.rb @@ -1,9 +1,9 @@ class Recipe < ActiveRecord::Base has_many :comments validates_presence_of :api_id - def self.get_recipes_by_ingredient(ingredient, limit) - - respon...
Add handling for multi-word and multi-ingredient searching
diff --git a/app/lib/audit_logger.rb b/app/lib/audit_logger.rb index abc1234..def5678 100644 --- a/app/lib/audit_logger.rb +++ b/app/lib/audit_logger.rb @@ -12,13 +12,11 @@ end def error(msg, exception = nil) - airbrake_params = { - :error_message => msg.dup, - :environment_name => Rails.env - } ...
Make AuditLogger talk to NewRelic, not Airbrake We removed Airbrake in 480b55289725eebd3cd15977f229f298c1cbdf7d but didn't stop the logger from talking to it. We can achieve the same thing with the ``NewRelic::Agent.notice_error`` api (although we can't provide quite as much information).
diff --git a/app/models/alumni.rb b/app/models/alumni.rb index abc1234..def5678 100644 --- a/app/models/alumni.rb +++ b/app/models/alumni.rb @@ -2,6 +2,9 @@ has_one :AlumniStatus has_one :AlumniData after_create :build_other_records + before_destroy { |record| AlumniStatus.destroy_all "Alumni_id = #{record.id}" ...
Add the before_destroy callback in Alumni model - Before destroying an Alumni, always destroy the associated AlumniStatus, AlumniData and the TieAlumni records too. Signed-off-by: Siddharth Kannan <805f056820c7a1cecc4ab591b8a0a604b501a0b7@gmail.com>
diff --git a/app/models/review.rb b/app/models/review.rb index abc1234..def5678 100644 --- a/app/models/review.rb +++ b/app/models/review.rb @@ -3,7 +3,9 @@ belongs_to :restaurant has_many :review_cuisines has_many :cuisines, through: :review_cuisines - + + before_save { self.restaurant_name = restaurant_nam...
Add before_save { self.restaurant_name to capitalize first letter
diff --git a/test/dummy/config/boot.rb b/test/dummy/config/boot.rb index abc1234..def5678 100644 --- a/test/dummy/config/boot.rb +++ b/test/dummy/config/boot.rb @@ -6,5 +6,3 @@ require 'bundler' Bundler.setup end - -$:.unshift File.expand_path('../../../../lib', __FILE__)
Remove glow lib from dummy load path
diff --git a/spec/configuration_spec.rb b/spec/configuration_spec.rb index abc1234..def5678 100644 --- a/spec/configuration_spec.rb +++ b/spec/configuration_spec.rb @@ -0,0 +1,14 @@+require 'spec_helper' + +describe MetaTags::Configuration do + it 'should be returned by MetaTags.config' do + expect(MetaTags.config)...
Make sure MetaTags.config/configuration work as expected
diff --git a/spec/isolation/rom_spec.rb b/spec/isolation/rom_spec.rb index abc1234..def5678 100644 --- a/spec/isolation/rom_spec.rb +++ b/spec/isolation/rom_spec.rb @@ -3,14 +3,14 @@ describe ROM, '.finalize' do subject(:env) { ROM.finalize.env } - before { ROM.setup(:sql, 'sqlite::memory') } + before { ROM.setu...
Use memory adapter for rom isolation specs
diff --git a/features/support/env.rb b/features/support/env.rb index abc1234..def5678 100644 --- a/features/support/env.rb +++ b/features/support/env.rb @@ -11,9 +11,10 @@ Before('@events') do - @app = Flapjack::Executive.run - @app.process_events - @redis = Redis.new + # Use a separate database whilst testing ...
Use a different redis database while testing
diff --git a/app/controllers/locations_controller.rb b/app/controllers/locations_controller.rb index abc1234..def5678 100644 --- a/app/controllers/locations_controller.rb +++ b/app/controllers/locations_controller.rb @@ -15,8 +15,8 @@ def nyc_index @location = Location.find_by(loc_code:"nyc") @location_name = @l...
Fix calculation issue with nyc totals
diff --git a/app/controllers/positions_controller.rb b/app/controllers/positions_controller.rb index abc1234..def5678 100644 --- a/app/controllers/positions_controller.rb +++ b/app/controllers/positions_controller.rb @@ -1,9 +1,9 @@ class PositionsController < ApplicationController respond_to :json + rescue_from ...
Fix rescue_from order in PositionsController
diff --git a/app/controllers/team_name_controller.rb b/app/controllers/team_name_controller.rb index abc1234..def5678 100644 --- a/app/controllers/team_name_controller.rb +++ b/app/controllers/team_name_controller.rb @@ -2,22 +2,6 @@ skip_before_action :verify_authenticity_token, only: [:create] def create - ...
Make @colour_palette accessible to all methods
diff --git a/test/substitution_test.rb b/test/substitution_test.rb index abc1234..def5678 100644 --- a/test/substitution_test.rb +++ b/test/substitution_test.rb @@ -0,0 +1,12 @@+require 'test_helper' + +context "Substitions" do + setup do + @rendered = render_string(":frog: Yo, I am a frog.\n\nA frog says, '{fro...
Add basic test for substitutions
diff --git a/modules/govuk/spec/defines/govuk_app_package_spec.rb b/modules/govuk/spec/defines/govuk_app_package_spec.rb index abc1234..def5678 100644 --- a/modules/govuk/spec/defines/govuk_app_package_spec.rb +++ b/modules/govuk/spec/defines/govuk_app_package_spec.rb @@ -19,9 +19,11 @@ } end - it { sho...
Refactor test to only do one it
diff --git a/config.ru b/config.ru index abc1234..def5678 100644 --- a/config.ru +++ b/config.ru @@ -6,7 +6,7 @@ use Rack::ShowExceptions -if ENV.has_key 'HTTP_MESSAGE' +if ENV.has_key? 'HTTP_MESSAGE' message = ENV['HTTP_MESSAGE'] else message = "Private Blog"
Use a question mark for checkign in hash
diff --git a/config.ru b/config.ru index abc1234..def5678 100644 --- a/config.ru +++ b/config.ru @@ -27,5 +27,32 @@ end end +class InsertTags < Struct.new(:app) + def call(env) + status, headers, body = app.call(env) + + Rack::Response.new(body, status, headers) do |response| + if media_type(response) ...
Add middleware to insert <script> tag
diff --git a/app/controllers/bunny_sessions_controller.rb b/app/controllers/bunny_sessions_controller.rb index abc1234..def5678 100644 --- a/app/controllers/bunny_sessions_controller.rb +++ b/app/controllers/bunny_sessions_controller.rb @@ -5,10 +5,6 @@ def create self.current_bunny = Bunny.authenticate(params[:...
Remove unused 'remember me' code git-svn-id: 801577a2cbccabf54a3a609152c727abd26e524a@1250 a18515e9-6cfd-0310-9624-afb4ebaee84e
diff --git a/Specta.podspec b/Specta.podspec index abc1234..def5678 100644 --- a/Specta.podspec +++ b/Specta.podspec @@ -17,4 +17,5 @@ s.tvos.deployment_target = '9.0' s.pod_target_xcconfig = { 'ENABLE_BITCODE' => 'NO' } + s.user_target_xcconfig = { 'FRAMEWORK_SEARCH_PATHS' => '$(PLATFORM_DIR)/Developer/Library...
Handle the custom search path for XCTest
diff --git a/test/controllers/labelings_controller_test.rb b/test/controllers/labelings_controller_test.rb index abc1234..def5678 100644 --- a/test/controllers/labelings_controller_test.rb +++ b/test/controllers/labelings_controller_test.rb @@ -24,6 +24,22 @@ sign_in users(:alice) end + test 'should create la...
Add tests for creating labelings
diff --git a/app/mailers/course_invitation_mailer.rb b/app/mailers/course_invitation_mailer.rb index abc1234..def5678 100644 --- a/app/mailers/course_invitation_mailer.rb +++ b/app/mailers/course_invitation_mailer.rb @@ -8,8 +8,6 @@ @member = member @invitation = invitation - load_attachments - subje...
Remove codebar logo from course invitation attachments
diff --git a/NSData+TDTImageMIMEDetection.podspec b/NSData+TDTImageMIMEDetection.podspec index abc1234..def5678 100644 --- a/NSData+TDTImageMIMEDetection.podspec +++ b/NSData+TDTImageMIMEDetection.podspec @@ -4,7 +4,7 @@ s.summary = "Category on NSData to check if it represents PNG or JPEG." s.homepage ...
Update author name and email
diff --git a/spec/cli_spec.rb b/spec/cli_spec.rb index abc1234..def5678 100644 --- a/spec/cli_spec.rb +++ b/spec/cli_spec.rb @@ -2,8 +2,8 @@ describe Tracking::CLI do - before :each { backup_data } - after :each { restore_data } + before(:all) { backup_data } + after(:all) { restore_data } it 'performs a few ...
Tests: Use before/after :all, not before/after :each
diff --git a/spec/ghe_spec.rb b/spec/ghe_spec.rb index abc1234..def5678 100644 --- a/spec/ghe_spec.rb +++ b/spec/ghe_spec.rb @@ -0,0 +1,68 @@+describe '...' do + + MOCK_GHE_HOST = 'ghe.example.com' + MOCK_USER = 'foo' + MOCK_PASSWORD = 'bar' + MOCK_AUTHZ_GHE_URL = "http://#{MOCK_USER}:#{MOCK_PASSWORD}@#{MOCK_GHE_HO...
Add a spec for GitHub Enterprise support
diff --git a/app/services/ci/update_build_queue_service.rb b/app/services/ci/update_build_queue_service.rb index abc1234..def5678 100644 --- a/app/services/ci/update_build_queue_service.rb +++ b/app/services/ci/update_build_queue_service.rb @@ -6,6 +6,12 @@ runner.tick_runner_queue end end + +...
Fix shared runners queue update
diff --git a/rack-reverse-proxy.gemspec b/rack-reverse-proxy.gemspec index abc1234..def5678 100644 --- a/rack-reverse-proxy.gemspec +++ b/rack-reverse-proxy.gemspec @@ -1,11 +1,11 @@ Gem::Specification.new do |s| s.name = 'rack-reverse-proxy' s.version = "0.8.1" - s.authors = ["Jon Swope", "...
Add author and change homepage to reflect maintainer change
diff --git a/app/views/api/visits/show.json.jbuilder b/app/views/api/visits/show.json.jbuilder index abc1234..def5678 100644 --- a/app/views/api/visits/show.json.jbuilder +++ b/app/views/api/visits/show.json.jbuilder @@ -6,6 +6,8 @@ json.contact_email_address @visit.contact_email_address json.slots @visit.slots.ma...
Add cancellation reason, timestamps to visit API So that PVB Public can build a visit show page with the reason.
diff --git a/lib/terraforming/resource/db_parameter_group.rb b/lib/terraforming/resource/db_parameter_group.rb index abc1234..def5678 100644 --- a/lib/terraforming/resource/db_parameter_group.rb +++ b/lib/terraforming/resource/db_parameter_group.rb @@ -1,12 +1,10 @@ module Terraforming::Resource class DBParameterGro...
Remove TODO comments from DBParameterGroup
diff --git a/db/seeds.rb b/db/seeds.rb index abc1234..def5678 100644 --- a/db/seeds.rb +++ b/db/seeds.rb @@ -5,12 +5,19 @@ # name = shell.ask("What's your name?") # shell.say name # -email = shell.ask "Which email do you want use for logging into admin?" -password = shell.ask "Tell me the password to use:", ...
Allow seed to take admin credentials from env
diff --git a/db/seeds.rb b/db/seeds.rb index abc1234..def5678 100644 --- a/db/seeds.rb +++ b/db/seeds.rb @@ -0,0 +1,56 @@+# Users + +User.create( + username: "evan", + email: "evan@email.com", + password: "000000", + password_confirmation: "000000" +) + +User.create( + username: "mphelps", + email: "mphelps@email...
Add seed data from users and list of genres
diff --git a/spec/controllers/api/v1/invoices_controller_spec.rb b/spec/controllers/api/v1/invoices_controller_spec.rb index abc1234..def5678 100644 --- a/spec/controllers/api/v1/invoices_controller_spec.rb +++ b/spec/controllers/api/v1/invoices_controller_spec.rb @@ -4,6 +4,11 @@ include Randomness include Respon...
Clean up before starting the spec
diff --git a/spec/organic_sitemap/middleware/url_capture_spec.rb b/spec/organic_sitemap/middleware/url_capture_spec.rb index abc1234..def5678 100644 --- a/spec/organic_sitemap/middleware/url_capture_spec.rb +++ b/spec/organic_sitemap/middleware/url_capture_spec.rb @@ -0,0 +1,52 @@+require 'spec_helper' +require 'rack' ...
Add first Middleware tests :D
diff --git a/sample/spec/spec_helper.rb b/sample/spec/spec_helper.rb index abc1234..def5678 100644 --- a/sample/spec/spec_helper.rb +++ b/sample/spec/spec_helper.rb @@ -23,14 +23,14 @@ c.syntax = :expect end - config.before(:suite) do + config.before(:each) do DatabaseCleaner.clean_with(:truncation) ...
Switch sample spec to truncation Postgresql was experiencing "No live threads left. Deadlock?" under Rails 5.1.
diff --git a/core/lib/spree/money.rb b/core/lib/spree/money.rb index abc1234..def5678 100644 --- a/core/lib/spree/money.rb +++ b/core/lib/spree/money.rb @@ -7,9 +7,9 @@ def initialize(amount, options={}) @money = ::Money.parse([amount, (options[:currency] || Spree::Config[:currency])].join) @options =...
Refactor Spree::Money's with_currency and no_cents option settings
diff --git a/config/schedule.rb b/config/schedule.rb index abc1234..def5678 100644 --- a/config/schedule.rb +++ b/config/schedule.rb @@ -17,7 +17,7 @@ # Learn more: http://github.com/javan/whenever -job_type :rake, "cd :path && RAILS_ENV=:environment /usr/local/bin/rake :task :output" +job_type :rake, "cd :path && ...
Update our cron job format.
diff --git a/BVLinearGradient.podspec b/BVLinearGradient.podspec index abc1234..def5678 100644 --- a/BVLinearGradient.podspec +++ b/BVLinearGradient.podspec @@ -16,6 +16,6 @@ s.preserve_paths = "**/*.js" s.frameworks = 'UIKit', 'QuartzCore', 'Foundation' - s.dependency 'React' + s.dependency 'React-Core' e...
Update React dependency in podspec
diff --git a/lib/generators/templates/component/model/spec/models/%file_name%_spec.rb b/lib/generators/templates/component/model/spec/models/%file_name%_spec.rb index abc1234..def5678 100644 --- a/lib/generators/templates/component/model/spec/models/%file_name%_spec.rb +++ b/lib/generators/templates/component/model/spe...
[merb-gen] Fix for generation of namespaced model specs [#1233 state:resolved]
diff --git a/alphagov/vagrant-govuk/load_nodes.rb b/alphagov/vagrant-govuk/load_nodes.rb index abc1234..def5678 100644 --- a/alphagov/vagrant-govuk/load_nodes.rb +++ b/alphagov/vagrant-govuk/load_nodes.rb @@ -1,37 +1,60 @@-require 'json' +require 'yaml' -# Load node definitions from the JSON in the vcloud-templates r...
Use vcloud-launcher configs in govuk-provisioning vcloud-templates and vcloud-box-spinner are dead. This is a simpler version of Nicola's yaml_input branch which: - Uses the updated syntax of vcloud-launcher - Only takes the required items out of each vApp entry - Doesn't add disks - I'll create a separate story for ...
diff --git a/templates/spec_helper.rb b/templates/spec_helper.rb index abc1234..def5678 100644 --- a/templates/spec_helper.rb +++ b/templates/spec_helper.rb @@ -9,6 +9,8 @@ require 'capybara/poltergeist' Dir[Rails.root.join('spec/support/**/*.rb')].each { |file| require file } + +ActiveRecord::Migration.maintain_tes...
Maintain db schema from spec helper
diff --git a/halide.rb b/halide.rb index abc1234..def5678 100644 --- a/halide.rb +++ b/halide.rb @@ -1,9 +1,9 @@ class Halide < Formula desc "The Halide image processing language" homepage "http://halide-lang.org" - url "https://github.com/halide/Halide/releases/download/release_2016_03_02/halide-mac-64-trunk-65...
Update tarball URL and sha256 to 2016.10.25
diff --git a/lib/generators/spree_related_products/install/install_generator.rb b/lib/generators/spree_related_products/install/install_generator.rb index abc1234..def5678 100644 --- a/lib/generators/spree_related_products/install/install_generator.rb +++ b/lib/generators/spree_related_products/install/install_generato...
Remove unused & incorrect copy/pasted code.
diff --git a/app/controllers/filters_controller.rb b/app/controllers/filters_controller.rb index abc1234..def5678 100644 --- a/app/controllers/filters_controller.rb +++ b/app/controllers/filters_controller.rb @@ -9,7 +9,7 @@ # @sexual_preferences = Filter.where(filterable_type:"SexualPreference") @sexual_prefe...
Fix minor bug in filter controller
diff --git a/lib/vagrant-multiprovider-snap/providers/virtualbox/driver/base.rb b/lib/vagrant-multiprovider-snap/providers/virtualbox/driver/base.rb index abc1234..def5678 100644 --- a/lib/vagrant-multiprovider-snap/providers/virtualbox/driver/base.rb +++ b/lib/vagrant-multiprovider-snap/providers/virtualbox/driver/bas...
Check if VM is already powered off before halting Before this commit, rolling back a snapshot from a VM in a poweroff state results in the below error: Stderr: VBoxManage: error: Invalid machine state: PoweredOff (must be Running, Paused or Stuck) This commit adds a check to skip the halting step if the machine is a...
diff --git a/test/mathematical/mathjax_test.rb b/test/mathematical/mathjax_test.rb index abc1234..def5678 100644 --- a/test/mathematical/mathjax_test.rb +++ b/test/mathematical/mathjax_test.rb @@ -1,4 +1,5 @@ require 'test_helper' +require 'nokogiri' class Mathematical::MathJaxTest < Test::Unit::TestCase @@ -10,7 ...
Check that MathJax SVGs are actually valid
diff --git a/app/serializers/chapter_serializer.rb b/app/serializers/chapter_serializer.rb index abc1234..def5678 100644 --- a/app/serializers/chapter_serializer.rb +++ b/app/serializers/chapter_serializer.rb @@ -1,4 +1,4 @@ class ChapterSerializer < ActiveModel::Serializer - attributes :id, :created_at, :completed_at...
Complete reducing page load time by updating JSON serializers
diff --git a/app/controllers/topics_controller.rb b/app/controllers/topics_controller.rb index abc1234..def5678 100644 --- a/app/controllers/topics_controller.rb +++ b/app/controllers/topics_controller.rb @@ -38,6 +38,6 @@ private def instantiate_latest_editions - @latest_editions = Guide.all.includes(:latest_e...
Order editions by title in the topics manager
diff --git a/tasks/spec.rake b/tasks/spec.rake index abc1234..def5678 100644 --- a/tasks/spec.rake +++ b/tasks/spec.rake @@ -17,7 +17,7 @@ t.spec_opts = ['--format', 'html:doc/spec/index.html', '--color'] # t.out = 'doc/spec/index.html' t.rcov = true - t.rcov_opts = ['--html', '--exclude', "#{ENV['HOME'...
Exclude /usr/lib/ruby from RCov C0 code coverage report
diff --git a/core/app/models/spree/payment_method.rb b/core/app/models/spree/payment_method.rb index abc1234..def5678 100644 --- a/core/app/models/spree/payment_method.rb +++ b/core/app/models/spree/payment_method.rb @@ -1,5 +1,7 @@ module Spree class PaymentMethod < ActiveRecord::Base + + attr_accessible :name, ...
Make name, active, environment and description attributes on payment method mass-assignable by internal calls
diff --git a/validate_as_email.gemspec b/validate_as_email.gemspec index abc1234..def5678 100644 --- a/validate_as_email.gemspec +++ b/validate_as_email.gemspec @@ -18,6 +18,7 @@ gem.add_dependency 'activemodel', '~> 3' gem.add_dependency 'mail', '~> 2' + gem.add_development_dependency 'rake', '~> 0.9.2' gem...
Add rake to development dependencies
diff --git a/lib/mailboxer/engine.rb b/lib/mailboxer/engine.rb index abc1234..def5678 100644 --- a/lib/mailboxer/engine.rb +++ b/lib/mailboxer/engine.rb @@ -3,7 +3,6 @@ require 'carrierwave' begin require 'sunspot_rails' - Logger.new(STDOUT).debug 'The sunspot_rails gem is present. Loading it into mailboxer. You ...
Remove unnecessary trash in stdout.
diff --git a/lib/raml_models/body.rb b/lib/raml_models/body.rb index abc1234..def5678 100644 --- a/lib/raml_models/body.rb +++ b/lib/raml_models/body.rb @@ -15,11 +15,11 @@ def example if body.example - body.example + eval(body.example) elsif body.schema - JSON.parse...
Make sure all output is Ruby (will be converted by generator)
diff --git a/lib/urban_dictionary.rb b/lib/urban_dictionary.rb index abc1234..def5678 100644 --- a/lib/urban_dictionary.rb +++ b/lib/urban_dictionary.rb @@ -1,4 +1,25 @@+require 'uri' +require 'net/http' + require 'urban_dictionary/version' +require 'urban_dictionary/word' +require 'urban_dictionary/entry' module U...
Add static methods to UrbanDictionary
diff --git a/lib/whatsnew/project.rb b/lib/whatsnew/project.rb index abc1234..def5678 100644 --- a/lib/whatsnew/project.rb +++ b/lib/whatsnew/project.rb @@ -28,7 +28,7 @@ def matched_from_git_repository Dir.chdir(Pathname(@path).to_path) do `git config --get remote.origin.url`.match( - ...
Fix hardcoded RegExp when matching git repository
diff --git a/app/helpers/noodall/components_helper.rb b/app/helpers/noodall/components_helper.rb index abc1234..def5678 100644 --- a/app/helpers/noodall/components_helper.rb +++ b/app/helpers/noodall/components_helper.rb @@ -9,27 +9,22 @@ # render each slot in the row args.map do |slot_code| index = arg...
Make component row html safe
diff --git a/test/activerecord_test.rb b/test/activerecord_test.rb index abc1234..def5678 100644 --- a/test/activerecord_test.rb +++ b/test/activerecord_test.rb @@ -0,0 +1,17 @@+# coding: utf-8 +require 'test_helper' +require 'models/utilisateur' +class ActiverecordTest < Test::Unit::TestCase + + def test_human_attrib...
Add translation test for activerecord
diff --git a/spec/acceptance_helper.rb b/spec/acceptance_helper.rb index abc1234..def5678 100644 --- a/spec/acceptance_helper.rb +++ b/spec/acceptance_helper.rb @@ -1,6 +1,6 @@ # encoding: utf-8 require_relative './spec_helper' -require "steak" +#require "steak" require 'capybara/rails' require "capybara/dsl" requi...
Remove steak from acceptance helper
diff --git a/spec/installation_spec.rb b/spec/installation_spec.rb index abc1234..def5678 100644 --- a/spec/installation_spec.rb +++ b/spec/installation_spec.rb @@ -26,11 +26,13 @@ it { should be_mode 755 } end - describe command('vagrant plugin list') do - its(:stdout) { - should ma...
Disable plugin test for Travis, need investigation
diff --git a/spec/models/entry_spec.rb b/spec/models/entry_spec.rb index abc1234..def5678 100644 --- a/spec/models/entry_spec.rb +++ b/spec/models/entry_spec.rb @@ -11,7 +11,7 @@ nickname: "The Science Guy", provider: "foo", image: "bar", - uid: "baz" + uid: 12345 ) c = Challenge...
Make uid a numeric type to pass validation
diff --git a/spec/money_column_spec.rb b/spec/money_column_spec.rb index abc1234..def5678 100644 --- a/spec/money_column_spec.rb +++ b/spec/money_column_spec.rb @@ -0,0 +1,32 @@+require File.expand_path(File.dirname(__FILE__) + '/spec_helper') + +class MoneyRecord < ActiveRecord::Base + money_column :price +end + +des...
Add basic tests for money column
diff --git a/spec/rspec/sitemap/matchers/include_url_spec.rb b/spec/rspec/sitemap/matchers/include_url_spec.rb index abc1234..def5678 100644 --- a/spec/rspec/sitemap/matchers/include_url_spec.rb +++ b/spec/rspec/sitemap/matchers/include_url_spec.rb @@ -4,14 +4,14 @@ include RSpec::Sitemap::Matchers context "on a...
Use `let` instead of `subject` in the tests and make them more descriptive.
diff --git a/spec/configuration_spec.rb b/spec/configuration_spec.rb index abc1234..def5678 100644 --- a/spec/configuration_spec.rb +++ b/spec/configuration_spec.rb @@ -1,28 +1,34 @@ require "helper" describe SimpleCov::Configuration do + let(:config_class) do + Class.new do + include SimpleCov::Configurati...
Adjust spec to not modify global state This way the second context is also truly unconfigured, plus no possible test order shenanigans/global influence.
diff --git a/spec/models/person_spec.rb b/spec/models/person_spec.rb index abc1234..def5678 100644 --- a/spec/models/person_spec.rb +++ b/spec/models/person_spec.rb @@ -16,4 +16,12 @@ it 'creates a name from first and last names' do expect(build(:person, first_name: 'Roger', last_name: 'Smith').name).to eq('Roge...
Test that the jsonb storage of arbitrary fields works.
diff --git a/spec/models/update_spec.rb b/spec/models/update_spec.rb index abc1234..def5678 100644 --- a/spec/models/update_spec.rb +++ b/spec/models/update_spec.rb @@ -19,7 +19,9 @@ :body => "They leave slime everywhere", :user_id => @id time = update.created_at datestr = time.strftime("%Y%m%d") - d...
Fix Y10K bug in update tests, at @zoeimogen's insistence. See https://twitter.com/zoeimogen/status/280699989674577921
diff --git a/lib/cocoapods/command/push.rb b/lib/cocoapods/command/push.rb index abc1234..def5678 100644 --- a/lib/cocoapods/command/push.rb +++ b/lib/cocoapods/command/push.rb @@ -1,7 +1,7 @@ module Pod class Command class Push < Command - self.summary = 'Temporary placeholder for the `pod repo push` comm...
[Command::Push] Add temporary foward command 2
diff --git a/lib/git_crecord/hunks/file.rb b/lib/git_crecord/hunks/file.rb index abc1234..def5678 100644 --- a/lib/git_crecord/hunks/file.rb +++ b/lib/git_crecord/hunks/file.rb @@ -50,6 +50,19 @@ def highlightable_subs @hunks end + + def generate_diff + return unless selected + ...
Implement generate_diff method for FileHunk
diff --git a/lib/globot/plugins/welcome.rb b/lib/globot/plugins/welcome.rb index abc1234..def5678 100644 --- a/lib/globot/plugins/welcome.rb +++ b/lib/globot/plugins/welcome.rb @@ -7,7 +7,8 @@ 'Welcome to the room, %s.', 'Back again hey, %s?', '%s! Good to see you!' - ] + # Plugins c...
Stop warnings about redefining constants when reloading plugins.
diff --git a/lib/formaggio/capistrano/cleanup.rb b/lib/formaggio/capistrano/cleanup.rb index abc1234..def5678 100644 --- a/lib/formaggio/capistrano/cleanup.rb +++ b/lib/formaggio/capistrano/cleanup.rb @@ -1,3 +1,9 @@ Capistrano::Configuration.instance(:must_exist).load do after "deploy:restart", "deploy:cleanup" + ...
Make sure latest release is the most recently modified release
diff --git a/lib/mongomodel/support/reference.rb b/lib/mongomodel/support/reference.rb index abc1234..def5678 100644 --- a/lib/mongomodel/support/reference.rb +++ b/lib/mongomodel/support/reference.rb @@ -9,6 +9,8 @@ def to_s id.to_s end + + alias :to_str :to_s def hash id.hash
Add implicit cast method to Reference
diff --git a/lib/nutils/filters/yuicompressor.rb b/lib/nutils/filters/yuicompressor.rb index abc1234..def5678 100644 --- a/lib/nutils/filters/yuicompressor.rb +++ b/lib/nutils/filters/yuicompressor.rb @@ -28,6 +28,8 @@ # It fallbacks to `:type => :js` because backwards compatibility w/ # prior vers...
Add an error when no type defined for YUICompressor filter
diff --git a/download.rb b/download.rb index abc1234..def5678 100644 --- a/download.rb +++ b/download.rb @@ -14,19 +14,18 @@ def download create_directory - puts "------ Start downloading ------" @rss.items.each do |item| Dir.chdir(download_directory) do - next if File.exist?("#{item.title}.mp3"...
Use title instead of item.title
diff --git a/spec/rails_helper.rb b/spec/rails_helper.rb index abc1234..def5678 100644 --- a/spec/rails_helper.rb +++ b/spec/rails_helper.rb @@ -18,4 +18,14 @@ RSpec.configure do |config| config.use_transactional_fixtures = true config.include ControllerMatchers, type: :controller + + config.around(:example, :de...
Add ActiveRecord debugging helper for RSpec
diff --git a/spec_support.gemspec b/spec_support.gemspec index abc1234..def5678 100644 --- a/spec_support.gemspec +++ b/spec_support.gemspec @@ -18,4 +18,8 @@ s.test_files = Dir["spec/**/*"] s.add_development_dependency "rspec" + + # to execute `rake release` from a jruby environment, uncomment line below + # ...
Add comment about dependency on "jruby-openssl" for `rake release` from JRuby env
diff --git a/Formula/brew-desc.rb b/Formula/brew-desc.rb index abc1234..def5678 100644 --- a/Formula/brew-desc.rb +++ b/Formula/brew-desc.rb @@ -0,0 +1,11 @@+require 'formula' + +class BrewDesc < Formula + url 'git://github.com/telemachus/brew-desc' + homepage 'https://github.com/telemachus/brew-desc' + version '0.0...
Add a formula for installation
diff --git a/lib/realm/messaging/message_type.rb b/lib/realm/messaging/message_type.rb index abc1234..def5678 100644 --- a/lib/realm/messaging/message_type.rb +++ b/lib/realm/messaging/message_type.rb @@ -1,7 +1,7 @@ module Realm module Messaging class MessageType - GENERIC_PROPERTIES = [ :message_type, :v...
Stop requiring UUIDs in messages to support commands as well as events
diff --git a/lib/rom/support/auto_curry.rb b/lib/rom/support/auto_curry.rb index abc1234..def5678 100644 --- a/lib/rom/support/auto_curry.rb +++ b/lib/rom/support/auto_curry.rb @@ -0,0 +1,28 @@+module ROM + module AutoCurry + def self.extended(klass) + busy = false + curried = klass.curried + + klass...
Make Relation lazy by default
diff --git a/lib/smartdown/engine/state.rb b/lib/smartdown/engine/state.rb index abc1234..def5678 100644 --- a/lib/smartdown/engine/state.rb +++ b/lib/smartdown/engine/state.rb @@ -51,7 +51,7 @@ if has_key?(key) @data.fetch(key.to_s) else - raise UndefinedValue + raise Unde...
Improve error message on undefined value
diff --git a/lib/uploadie/storage/file_system.rb b/lib/uploadie/storage/file_system.rb index abc1234..def5678 100644 --- a/lib/uploadie/storage/file_system.rb +++ b/lib/uploadie/storage/file_system.rb @@ -6,13 +6,15 @@ class Uploadie module Storage class FileSystem - attr_reader :directory, :subdirectory +...
Add :host option to FileSystem storage for CDNs
diff --git a/lib/torckapi/response/base.rb b/lib/torckapi/response/base.rb index abc1234..def5678 100644 --- a/lib/torckapi/response/base.rb +++ b/lib/torckapi/response/base.rb @@ -7,7 +7,7 @@ def self.bdecode_and_check(data, key) begin - bdecoded_data = BEncode.load(data) + bdecoded_...
Revert "Revert "Allow proper loading of failed Bencoded data"" This reverts commit 5262935bf43adf18d10be95c926df5d643f8b5d5.
diff --git a/lib/wingtips/configuration.rb b/lib/wingtips/configuration.rb index abc1234..def5678 100644 --- a/lib/wingtips/configuration.rb +++ b/lib/wingtips/configuration.rb @@ -3,21 +3,14 @@ attr_reader :slide_classes def initialize(path) - @allow_unnamed_slides = false - - path = File.expand_p...
Replace the parameter overwrite and extract the slide loading switch
diff --git a/app/views/crumbs/index.json.jbuilder b/app/views/crumbs/index.json.jbuilder index abc1234..def5678 100644 --- a/app/views/crumbs/index.json.jbuilder +++ b/app/views/crumbs/index.json.jbuilder @@ -1,4 +1,9 @@ json.array!(@crumbs) do |crumb| json.extract! crumb, :id, :latitude, :longitude, :user_id, :time...
Include author in JSON crumb response
diff --git a/Formula/phpdocumentor.rb b/Formula/phpdocumentor.rb index abc1234..def5678 100644 --- a/Formula/phpdocumentor.rb +++ b/Formula/phpdocumentor.rb @@ -0,0 +1,31 @@+require 'formula' +require File.expand_path("../../Requirements/php-meta-requirement", Pathname.new(__FILE__).realpath) +require File.expand_path(...
Add formula for PhpDocumentor 2
diff --git a/test_app/spec/unit/test_app/literal/command_spec.rb b/test_app/spec/unit/test_app/literal/command_spec.rb index abc1234..def5678 100644 --- a/test_app/spec/unit/test_app/literal/command_spec.rb +++ b/test_app/spec/unit/test_app/literal/command_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -RSpec.descri...
Use correct metadata for test app
diff --git a/lib/bipbip/plugin/monit.rb b/lib/bipbip/plugin/monit.rb index abc1234..def5678 100644 --- a/lib/bipbip/plugin/monit.rb +++ b/lib/bipbip/plugin/monit.rb @@ -1,6 +1,6 @@ require 'monit' -class MonitStatus < Monit::Status -end +#class MonitStatus < Monit::Status +#end module Bipbip @@ -14,7 +14,7 @@ ...
Remove hack class and explicit scope