id int64 393k 2.82B | repo stringclasses 68
values | title stringlengths 1 936 | body stringlengths 0 256k ⌀ | labels stringlengths 2 508 | priority stringclasses 3
values | severity stringclasses 3
values |
|---|---|---|---|---|---|---|
2,603,261,645 | flutter | Add FML utility to fetch page sizes. | There are multiple spots in the engine where using the notion of a page size is useful for allocations. But since there is no portable way of getting the page size from FML, 4096 is assumed. Add the portable page size retrieval method to FML. | c: new feature,P2,team-engine,triaged-engine | low | Minor |
2,603,266,351 | flutter | Pass --quiet to run_tests.py invocations. | For potentially easier to parse CI logs. | engine,P2,team-engine,triaged-engine | low | Minor |
2,603,268,741 | godot | Vulkan Validation Errors in Canvas2D on launch | ### Tested versions
4.4-master
### System information
Godot v4.4.dev (44fa552343722bb048e2d7c6d3661174a95a8a3c) - Ubuntu 24.04.1 LTS 24.04 on X11 - X11 display driver, Multi-window, 2 monitors - Vulkan (Mobile) - dedicated AMD Radeon RX 6800 XT (RADV NAVI21) - AMD Ryzen 9 5900X 12-Core Processor (24 threads)
### Issue description
Launching the editor with an empty project with Vulkan validation enabled (`--gpu-validation`) results in the following message spammed:
```
VUID-vkCmdDrawIndexed-None-06479(ERROR / SPEC): msgNum: 1397510317 - Validation Error: [ VUID-vkCmdDrawIndexed-None-06479 ] Object 0: handle = 0xf9a57300000043d5, name = RID:694113959674081, type = VK_OBJECT_TYPE_DESCRIPTOR_SET; Object 1: handle = 0x4baaca000000019b, name = RID:665719930899 View, type = VK_OBJECT_TYPE_IMAGE_VIEW; | MessageID = 0x534c50ad | vkCmdDrawIndexed(): the descriptor (VkDescriptorSet 0xf9a57300000043d5[RID:694113959674081], binding 4, index 0) has VkImageView 0x4baaca000000019b[RID:665719930899 View] with format of VK_FORMAT_R32_SFLOAT which doesn't support VK_FORMAT_FEATURE_2_SAMPLED_IMAGE_DEPTH_COMPARISON_BIT in.
i(supported features: VK_FORMAT_FEATURE_2_SAMPLED_IMAGE_BIT|VK_FORMAT_FEATURE_2_STORAGE_IMAGE_BIT|VK_FORMAT_FEATURE_2_STORAGE_IMAGE_ATOMIC_BIT|VK_FORMAT_FEATURE_2_COLOR_ATTACHMENT_BIT|VK_FORMAT_FEATURE_2_COLOR_ATTACHMENT_BLEND_BIT|VK_FORMAT_FEATURE_2_BLIT_SRC_BIT|VK_FORMAT_FEATURE_2_BLIT_DST_BIT|VK_FORMAT_FEATURE_2_SAMPLED_IMAGE_FILTER_LINEAR_BIT|VK_FORMAT_FEATURE_2_TRANSFER_SRC_BIT|VK_FORMAT_FEATURE_2_TRANSFER_DST_BIT|VK_FORMAT_FEATURE_2_SAMPLED_IMAGE_FILTER_MINMAX_BIT|VK_FORMAT_FEATURE_2_STORAGE_READ_WITHOUT_FORMAT_BIT|VK_FORMAT_FEATURE_2_STORAGE_WRITE_WITHOUT_FORMAT_BIT). The Vulkan spec states: If a VkImageView is sampled with depth comparison, the image view's format features must contain VK_FORMAT_FEATURE_2_SAMPLED_IMAGE_DEPTH_COMPARISON_BIT (https://vulkan.lunarg.com/doc/view/1.3.283.0/linux/1.3-extensions/vkspec.html#VUID-vkCmdDrawIndexed-None-06479)
```
Upon closer inspection the error is caused from:
1. canvas.glsl.gen.h
2. `layout(set = 0, binding = 4) uniform texture2D shadow_atlas_texture;`
3. This shader is used when rendering the dark-grey-blueish background of Godot's Editor.
I am not familiar enough with the Canvas2D renderer to fix it, but I gathered the following and I can suggest several solutions:
renderer_canvas_render_rd.cpp creates 2 textures for shadow rendering in `RendererCanvasRenderRD::_update_shadow_atlas`:
1. `state.shadow_texture` which is a "**colour**" R32_FLOAT texture (technically monochrome).
2. `state.shadow_depth_texture` which is a **depth** D32_FLOAT texture.
3. Both textures are combined as an FBO for rendering into it.
4. `state.shadow_texture` is the texture bound to `shadow_atlas_texture` for use during rendering. `state.shadow_depth_texture` is never bound.
If this were 3D rendering, most of the time the colour texture would be pointless (unless it's doing an advanced algorithm) and say there's a mistake and it should be the `D32_FLOAT` texture the one to be alone. But since I don't know how to even trigger 2D shadows in Godot, perhaps the colour texture is the one that should be bound.
## Possible Solution 1
Just get rid of the colour texture, leave the depth texture and bind that.
It is specially suspicious that the colour texture appears to contain depth information.
## Possible Solution 2
OK so let's assume the colour R32_FLOAT is needed.
The problem happens because Godot is relying on HW support to do bilinear PCF. This issue [affects D3D too](https://computergraphics.stackexchange.com/questions/8417/r16-float-samplecmp-and-checkformatsupport):
```glsl
vec4 light_shadow_compute(uint light_base, vec4 light_color, vec4 shadow_uv /*, ...*/ )
{
// ..
shadow += textureProjLod(sampler2DShadow(shadow_atlas_texture, shadow_sampler), shadow_uv - shadow_pixel_size * 2.0, 0.0).x;
// ..
}
```
We cannot do "sampler2DShadow(shadow_atlas_texture, shadow_sampler)" if unsupported for that pixel format.
The solution is to emulate the PCF:
```glsl
float emulatedPcf2x2( texture2D t, float4 uv, float2 uv_resolution )
{
float r00 = texture2D( sampler2D( t, SAMPLER_NEAREST_CLAMP ), uv.xy ).x;
float r10 = texture2D( sampler2D( t, SAMPLER_NEAREST_CLAMP ), uv.xy + float( 1/uv_resolution.x, 0 ) ).x;
float r01 = texture2D( sampler2D( t, SAMPLER_NEAREST_CLAMP ), uv.xy + float( 0, 1/uv_resolution.y ) ).x;
float r11 = texture2D( sampler2D( t, SAMPLER_NEAREST_CLAMP ), uv.xy + float( 1/uv_resolution ) ).x;
// Perform depth comparisons.
r00 = r00 > uv.w;
r10 = r10 > uv.w;
r01 = r01 > uv.w;
r11 = r11 > uv.w;
// Apply bilinear filtering to depth comparisons.
// WARNING: fract() will give the wrong value for negative values. This example code is not accounting for that. Or maybe the "wrong" value is the correct one we need. I haven't given thought about it.
float xyFract = fract( uv.xy * uv_resolution.xy );
float t = lerp( r00, r10, xyFract.x );
float s = lerp( r01, r11, xyFract.x );
return lerp( t, s, xyFract.y );
}
```
I wrote this out of memory, so it may have one or two syntax errors.
Of course this emulation requires 4 fetches, so it's far from ideal.
It could be optimized using Gather4 (which can fetch 4 texels in one sample). Last time I tried that (10 years ago!) I could not get the Gather4 version to run reliably because some drivers would be buggy or would scramble the order of the pixels (e.g. r10 and r01 were swapped, stuff like that).
## Possible Solution 3
Just perform a blit or compute copy from the R32_FLOAT to a D32_FLOAT texture and bind the D32_FLOAT instead.
### Steps to reproduce
1. Setup Vulkan Validation Layers
2. Launch an empty project with `-e --gpu-validation`
### Minimal reproduction project (MRP)
N / A | bug,topic:rendering,topic:2d | low | Critical |
2,603,281,358 | pytorch | Sequence Ops usage when exporting embedding bag into onnx | ### 🐛 Describe the bug
```
import torch
model = torch.nn.EmbeddingBag(num_embeddings=49157, embedding_dim=32, mode="sum")
a = torch.tensor([[39906]]).long()
example_args = (a,)
model_eval = model.eval()
torch.onnx.export(model_eval, example_args, "demo_embedding_bag_dynamo.onnx", dynamo=True)
```
Description:
I am exporting my model to onnx and trying to compile it with tensorrt. However I meet some problems in embedding bag layer.
If I export model to onnx in torchscript way, then there is some bug around tensorrt, which I submit an [issue](https://github.com/NVIDIA/TensorRT/issues/4210) to them
If I export model to onnx in dynamo way, then I see there are Sequence Ops like `SequenceEmpty`, `ConcatFromSequence` in the exported onnx graph as shown below. And those ops are not supported by tensorrt. As they mentioned, "but ideally the export should not contain sequence ops if it's only trying to concat/split tensors".
Questions:
1. are those Sequence Ops necessary when exporting embedding bag to onnx?
2. can we export embedding layer to onnx without those Sequence Ops?
<img width="720" alt="Screenshot 2024-10-21 at 10 39 31 AM" src="https://github.com/user-attachments/assets/788ef2cb-93ca-4ffc-ab0b-b83d51cfd868">
### Versions
Collecting environment information...
PyTorch version: 2.5.0+cu124
Is debug build: False
CUDA used to build PyTorch: 12.4
ROCM used to build PyTorch: N/A
OS: Ubuntu 24.04.1 LTS (x86_64)
GCC version: (Ubuntu 13.2.0-23ubuntu4) 13.2.0
Clang version: Could not collect
CMake version: Could not collect
Libc version: glibc-2.39
Python version: 3.11.9 (main, Oct 4 2024, 00:58:41) [GCC 13.2.0] (64-bit runtime)
Python platform: Linux-6.8.0-1015-gcp-x86_64-with-glibc2.39
Is CUDA available: True
CUDA runtime version: 12.6.77
CUDA_MODULE_LOADING set to: LAZY
GPU models and configuration: GPU 0: NVIDIA L4
Nvidia driver version: 560.35.03
cuDNN version: Probably one of the following:
/usr/lib/x86_64-linux-gnu/libcudnn.so.9.5.0
/usr/lib/x86_64-linux-gnu/libcudnn_adv.so.9.5.0
/usr/lib/x86_64-linux-gnu/libcudnn_cnn.so.9.5.0
/usr/lib/x86_64-linux-gnu/libcudnn_engines_precompiled.so.9.5.0
/usr/lib/x86_64-linux-gnu/libcudnn_engines_runtime_compiled.so.9.5.0
/usr/lib/x86_64-linux-gnu/libcudnn_graph.so.9.5.0
/usr/lib/x86_64-linux-gnu/libcudnn_heuristic.so.9.5.0
/usr/lib/x86_64-linux-gnu/libcudnn_ops.so.9.5.0
HIP runtime version: N/A
MIOpen runtime version: N/A
Is XNNPACK available: True
CPU:
Architecture: x86_64
CPU op-mode(s): 32-bit, 64-bit
Address sizes: 46 bits physical, 48 bits virtual
Byte Order: Little Endian
CPU(s): 16
On-line CPU(s) list: 0-15
Vendor ID: GenuineIntel
Model name: Intel(R) Xeon(R) CPU @ 2.20GHz
CPU family: 6
Model: 85
Thread(s) per core: 2
Core(s) per socket: 8
Socket(s): 1
Stepping: 7
BogoMIPS: 4400.41
Flags: fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush mmx fxsr sse sse2 ss ht syscall nx pdpe1gb rdtscp lm constant_tsc rep_good nopl xtopology nonstop_tsc cpuid tsc_known_freq pni pclmulqdq ssse3 fma cx16 pcid sse4_1 sse4_2 x2apic movbe popcnt aes xsave avx f16c rdrand hypervisor lahf_lm abm 3dnowprefetch ssbd ibrs ibpb stibp ibrs_enhanced fsgsbase tsc_adjust bmi1 hle avx2 smep bmi2 erms invpcid rtm mpx avx512f avx512dq rdseed adx smap clflushopt clwb avx512cd avx512bw avx512vl xsaveopt xsavec xgetbv1 xsaves arat avx512_vnni md_clear arch_capabilities
Hypervisor vendor: KVM
Virtualization type: full
L1d cache: 256 KiB (8 instances)
L1i cache: 256 KiB (8 instances)
L2 cache: 8 MiB (8 instances)
L3 cache: 38.5 MiB (1 instance)
NUMA node(s): 1
NUMA node0 CPU(s): 0-15
Vulnerability Gather data sampling: Not affected
Vulnerability Itlb multihit: Not affected
Vulnerability L1tf: Not affected
Vulnerability Mds: Not affected
Vulnerability Meltdown: Not affected
Vulnerability Mmio stale data: Vulnerable: Clear CPU buffers attempted, no microcode; SMT Host state unknown
Vulnerability Reg file data sampling: Not affected
Vulnerability Retbleed: Mitigation; Enhanced IBRS
Vulnerability Spec rstack overflow: Not affected
Vulnerability Spec store bypass: Mitigation; Speculative Store Bypass disabled via prctl
Vulnerability Spectre v1: Mitigation; usercopy/swapgs barriers and __user pointer sanitization
Vulnerability Spectre v2: Mitigation; Enhanced / Automatic IBRS; IBPB conditional; RSB filling; PBRSB-eIBRS SW sequence; BHI SW loop, KVM SW loop
Vulnerability Srbds: Not affected
Vulnerability Tsx async abort: Vulnerable: Clear CPU buffers attempted, no microcode; SMT Host state unknown
Versions of relevant libraries:
[pip3] mypy-extensions==1.0.0
[pip3] numpy==1.25.0
[pip3] nvidia-cublas-cu12==12.4.5.8
[pip3] nvidia-cuda-cupti-cu12==12.4.127
[pip3] nvidia-cuda-nvrtc-cu12==12.4.127
[pip3] nvidia-cuda-runtime-cu12==12.4.127
[pip3] nvidia-cudnn-cu12==9.1.0.70
[pip3] nvidia-cufft-cu12==11.2.1.3
[pip3] nvidia-curand-cu12==10.3.5.147
[pip3] nvidia-cusolver-cu12==11.6.1.9
[pip3] nvidia-cusparse-cu12==12.3.1.170
[pip3] nvidia-nccl-cu12==2.21.5
[pip3] nvidia-nvjitlink-cu12==12.4.127
[pip3] nvidia-nvtx-cu12==12.4.127
[pip3] onnx==1.17.0
[pip3] onnxscript==0.1.0.dev20241016
[pip3] pytorch-lightning==2.0.2
[pip3] sk2torch==1.2.0
[pip3] torch==2.5.0
[pip3] torchaudio==2.5.0
[pip3] torchmetrics==0.11.0
[pip3] torchvision==0.20.0
[pip3] triton==3.1.0
[conda] Could not collect | module: onnx,triaged,module: embedding | low | Critical |
2,603,310,790 | kubernetes | Feature Request: Generate a Kubernetes Release Artifact On Releases That Lists Feature Gate Default Enalbed/Disabled status | ### What would you like to be added?
This issue requests adding a new release artifact that lists the feature gates in a release and whether they are enabled / disabled by default.
If we had this, it would help k/website code verify that the machine readable feature gate metadata are correct - see https://github.com/kubernetes/website/tree/main/content/en/docs/reference/command-line-tools-reference/feature-gates.
Additionally a release artifact that is properly the "source of truth" for what feature gates in a release are enabled /disabled could additionally be used for Kubernetes feature: Compatibility Versions related testing (ex: https://github.com/kubernetes/kubernetes/issues/127947)
Related comment: https://github.com/kubernetes/kubernetes/pull/128138#issuecomment-2423882866
### Why is this needed?
A release artifact that lists the feature gates in a release and whether they are enabled / disabled by default is needed because currently the k/website which tracks what feature gates are enabled at each version is updated in a bespoke manual way and could use a published release artifact for correctness validation. The current approach can lead to deltas and missed updates if things are changed but not updated pre/post release. Here is an issue for example that notes some feature gates deltas from k8s releases vs k/website:
https://github.com/kubernetes/website/issues/47996
By creating a release artifact for each version, the k/website could use this artifact to verify and ensure correctness
/cc @sftim
/assign @aaron-prindle | sig/api-machinery,kind/feature,sig/release,triage/accepted | low | Major |
2,603,353,609 | opencv | OBJECT FILE PROTOBUF is not built in static link with the 3rdparty libs | ### System Information
Hi, I am building opencv with these options:
`cmake ..
-D CMAKE_TOOLCHAIN_FILE=../platforms/linux/rockship.toolchain.cmake
-D CMAKE_VERBOSE_MAKEFILE=ON
-D CMAKE_GENERATE_PKGCONFIG=YES
-DBUILD_LIST=core,highgui,improc,video,photo,features2d,videoio,imgcodecs
-D BUILD_SHARED_LIBS=OFF
-D WITH_PROTOBUF=ON`
In the folder `/build/3rdparty/protobuf/` , strangely there's no source files.
`>> make install` generates no `liblibprotobuf.o`
After running the install command, in the CMakeList of the install folder we can read this :
```
foreach(_cmake_expected_target IN ITEMS zlib libjpeg-turbo libtiff libwebp
libopenjp2 libpng **libprotobuf** tegra_hal ittnotify ade opencv_core opencv_imgproc opencv_photo opencv_video opencv_features2d opencv_imgcodecs ocv.3rdparty.v4l ocv.3rdparty.obsensor opencv_videoio opencv_highgui)
```
or even this :
```
set_target_properties(libprotobuf PROPERTIES
IMPORTED_LINK_INTERFACE_LANGUAGES_RELEASE "CXX"
IMPORTED_LOCATION_RELEASE "${_IMPORT_PREFIX}/lib/opencv4/3rdparty/liblibprotobuf.a"
)
```
It's expecting to find the `liblibprotobuf.a` but I think it has been statically linked to the opencv object files.
I am getting a CMake error : liblibprotobuf.o is missed, when I use the install folder in another project with the trace :
```
CMake Error at lib/cmake/opencv4/OpenCVModules.cmake:194 (message):
The imported target "libprotobuf" references the file
"/home/mac/luckfox_pico_rknn_example/lib/opencv4/3rdparty/liblibprotobuf.a"
but this file does not exist. Possible reasons include:
* The file was deleted, renamed, or moved to another location.
* An install or uninstall procedure did not complete successfully.
* The installation package was faulty and contained
"/home/mac/luckfox_pico_rknn_example/lib/cmake/opencv4/OpenCVModules.cmake"
but not all the files it references.
Call Stack (most recent call first):
lib/cmake/opencv4/OpenCVConfig.cmake:126 (include)
CMakeLists.txt:66 (find_package)
```
Here's a screenshoot of the error
I removed all the refeences to `libprotobuf` in the install CMakeList (not sure it's the solution), but now I am having the same error for the `libade.a`, may be I am doing something wrong from the beginning ! | bug,question (invalid tracker),category: build/install | low | Critical |
2,603,356,914 | electron | Electron apps stop redrawing | ### Preflight Checklist
- [x] I have read the [Contributing Guidelines](https://github.com/electron/electron/blob/main/CONTRIBUTING.md) for this project.
- [x] I agree to follow the [Code of Conduct](https://github.com/electron/electron/blob/main/CODE_OF_CONDUCT.md) that this project adheres to.
- [x] I have searched the [issue tracker](https://www.github.com/electron/electron/issues) for a bug report that matches the one I want to file, without success.
### Electron Version
30.3.1
### What operating system(s) are you using?
Other Linux
### Operating System Version
postmarketOS v24.06 based on Alpine 3.20.3
### What arch are you using?
arm64 (including Apple Silicon)
### Last Known Working Electron version
_No response_
### Expected Behavior
See #27889 where the issue was already filed, but it was closed. I am still seeing this in the latest electron version. I suggest to reopen that issue (and close this one).
### Actual Behavior
See #27889 or here:
https://github.com/user-attachments/assets/40bc9998-01d1-4a41-b5ae-02ff7d008820
### Testcase Gist URL
_No response_
### Additional Information
_No response_ | platform/linux,bug :beetle:,30-x-y | medium | Critical |
2,603,364,163 | go | x/telemetry: consolidate uploading and merging time horizons | Right now, we have a nightly job that produces merged reports (those available at telemetry.go.dev/data) for the last 8 days. Yet the client may upload data for the last 21 days.
This has a few problems:
- 21 days is too ~short~long. ~We typically care about "28 day users", so should probably accept uploads up to 28 days old.~ **we should limit to a shorter time period, for example 8 days**
- We should produce merged summaries for all the uploads we get, even if they are older than 8 days.
- We should reject reports on the server if they are too old, so that we don't store uploads that won't ever be merged. | NeedsFix,telemetry | low | Minor |
2,603,424,394 | go | proposal: net/http: non-seekable analogue to ServeContent | ### Proposal Details
The function `net/http.ServeContent` requires its `content` parameter to implement the `Seek` method. However, most of the functionality of `ServeContent` does not require `Seek` functionality.
I've recently had to serve some non-seekable streams, and I've had to reimplement much of the functionality of `ServeContent`, most notably the conditional request logic (`If-None-Match` and friends). It would have been helpful if `ServeContent` could take a non-seekable stream.
Unfortunately, `ServeContent` cannot be modified to take an `io.Reader` for backwards compatibility reasons (please correct me if I'm wrong). I therefore propose a new function
```
func ServeStream(w ResponseWriter, req *Request, name string, modtime time.Time, content io.Reader)
```
which works just like `ServeContent` except that:
1. the last argument does not need to implement `Seek`;
2. all range headers in the request (`Range` and `If-Range`) are ignored;
3. a `Content-Length` header is not automatically generated, if one is required, then the caller must set it before the call.
The function obeys the `If-Modified-Since` header if the `modTime` parameter is set. It obeys all other conditional headers (`If-None-Match` and friends) if the `ETag` header is set on the reply. I also suggest that `ServeStream` should transparently call `ServeContent` if its last argument is an `io.ReadSeeker`.
| Proposal | low | Major |
2,603,485,640 | Python | Avoid log(0) in KL divergence | ### Repository commit
03a42510b01c574292ca9c6525cbf0572ff5a2a5
### Python version (python --version)
Python 3.10.15
### Dependencies version (pip freeze)
absl-py==2.1.0
astunparse==1.6.3
beautifulsoup4==4.12.3
certifi==2024.8.30
charset-normalizer==3.4.0
contourpy==1.3.0
cycler==0.12.1
dill==0.3.9
dom_toml==2.0.0
domdf-python-tools==3.9.0
fake-useragent==1.5.1
flatbuffers==24.3.25
fonttools==4.54.1
gast==0.6.0
google-pasta==0.2.0
grpcio==1.67.0
h5py==3.12.1
idna==3.10
imageio==2.36.0
joblib==1.4.2
keras==3.6.0
kiwisolver==1.4.7
libclang==18.1.1
lxml==5.3.0
Markdown==3.7
markdown-it-py==3.0.0
MarkupSafe==3.0.2
matplotlib==3.9.2
mdurl==0.1.2
ml-dtypes==0.3.2
mpmath==1.3.0
namex==0.0.8
natsort==8.4.0
numpy==1.26.4
oauthlib==3.2.2
opencv-python==4.10.0.84
opt_einsum==3.4.0
optree==0.13.0
packaging==24.1
pandas==2.2.3
patsy==0.5.6
pbr==6.1.0
pillow==11.0.0
pip==24.2
protobuf==4.25.5
psutil==6.1.0
Pygments==2.18.0
pyparsing==3.2.0
python-dateutil==2.9.0.post0
pytz==2024.2
qiskit==1.2.4
qiskit-aer==0.15.1
requests==2.32.3
requests-oauthlib==1.3.1
rich==13.9.2
rustworkx==0.15.1
scikit-learn==1.5.2
scipy==1.14.1
setuptools==74.1.2
six==1.16.0
soupsieve==2.6
sphinx-pyproject==0.3.0
statsmodels==0.14.4
stevedore==5.3.0
symengine==0.13.0
sympy==1.13.3
tensorboard==2.16.2
tensorboard-data-server==0.7.2
tensorflow==2.16.2
tensorflow-io-gcs-filesystem==0.37.1
termcolor==2.5.0
threadpoolctl==3.5.0
tomli==2.0.2
tweepy==4.14.0
typing_extensions==4.12.2
tzdata==2024.2
urllib3==2.2.3
Werkzeug==3.0.4
wheel==0.44.0
wrapt==1.16.0
xgboost==2.1.1
### Expected behavior
The entries where `y_true` is `0` should be ignored in the summation (see Actual behavior)
### Actual behavior
In https://github.com/TheAlgorithms/Python/blob/03a42510b01c574292ca9c6525cbf0572ff5a2a5/machine_learning/loss_functions.py#L662-L663 if any entry of `y_true` is `0`, the output of `np.log` would become `-inf` and thus the method returns `nan`.
Maybe it would be better to exclude those entries where `y_true` is `0`? | bug | low | Major |
2,603,490,216 | svelte | Snippet doesn't satisfy the Snippet type, apparently | ### Describe the bug
In a class, I have the following overload:
```typescript
show(content: string | Snippet): void;
```
This is a SvelteKit project that produces an NPM library package. When the project is built, the `dist` folder contains:
```typescript
show(content: string | Snippet): void;
```
Great so far. Now the class is imported in a Vite + Svelte project by importing it from the built NPM package. The importer declares the following snippet:
```svelte
{#snippet overlay()}
<Spinner text="Loading..." variant="primary" />
{/snippet}
```
Then, this snippet is used in a call to `show()`:
```typescript
systemOverlay.show(overlay);
```
TypeScript is now unhappy. The word "overlay" has the squiggly red line and the error says:
> Overload 1 of 3, '(content: string | Snippet<[]>): void', gave the following error.
> Argument of type '() => ReturnType<import("svelte").Snippet>' is not assignable to parameter of type 'string | Snippet<[]>'.
> Type '() => ReturnType<import("svelte").Snippet>' is not assignable to type 'Snippet<[]>'.
So the snippet `overlay` is typed as a function whose return type is the return type of the `Snippet` type from `svelte`, instead of just being a snippet.
### Reproduction
Hopefully the above information is enough to reproduce? Do let me know, though.
### Logs
_No response_
### System Info
```shell
System:
OS: Windows 11 10.0.22631
CPU: (8) x64 Intel(R) Core(TM) i7-10610U CPU @ 1.80GHz
Memory: 16.62 GB / 39.73 GB
Binaries:
Node: 20.17.0 - C:\Program Files\nodejs\node.EXE
npm: 10.8.2 - C:\Program Files\nodejs\npm.CMD
Browsers:
Edge: Chromium (127.0.2651.105)
Internet Explorer: 11.0.22621.3527
npmPackages:
svelte: ^5.0.5 => 5.0.5
```
### Severity
blocking an upgrade | types / typescript | low | Critical |
2,603,494,953 | godot | Editor UI Does not Update | ### Tested versions
- Reproducible in v4.3.stable.official [77dcf97d8]
### System information
Godot v4.3.stable - Windows 10.0.22631 - GLES3 (Compatibility) - NVIDIA RTX A500 Laptop GPU (NVIDIA; 31.0.15.3878) - 13th Gen Intel(R) Core(TM) i7-1370P (20 Threads)
### Issue description
Most of the UI does not update. The top "Scene Project Debug Editor Help" menus work.
Everything else seems to work "behind the scenes" but I can't see what I'm doing.
If I click on the X button of the active scene tab, I can see the window title change to indicate the scene was closed.
Tooltips show up, as well as right-click context menus. The cursor changes to indicate drag borders, and text input fields, and the version code at the bottom right is clickable as well.
I noticed the UI is also stuck when I'm browsing the file system to open a new project with no project currently opened.
### Steps to reproduce
Open the project and select a few things for a couple of minutes until the UI stops updating.
### Minimal reproduction project (MRP)
[test.zip](https://github.com/user-attachments/files/17466220/test.zip)
| bug,topic:editor,needs testing | low | Critical |
2,603,536,269 | vscode | Chat Scroll Down button has no visible text in light theme | 
| bug,panel-chat | low | Minor |
2,603,540,421 | vscode | Multiline cursor using ALT-Up and Down on number pad causes character to display after releasing keys |
Type: <b>Bug</b>
If you use ALT-Down or Alt-Up on number pad to create a multi-line cursor, the editor displays an alt character for each line that the cursor extends into once the keys are relased. This only occurs when you use the number pad arrow keys. It does not occur when you use the dedicated arrow keys on the keyboard.
VS Code version: Code 1.94.2 (384ff7382de624fb94dbaf6da11977bba1ecd427, 2024-10-09T16:08:44.566Z)
OS version: Windows_NT x64 10.0.19045
Modes:
<details>
<summary>System Info</summary>
|Item|Value|
|---|---|
|CPUs|Intel(R) Core(TM) i7-10850H CPU @ 2.70GHz (6 x 2712)|
|GPU Status|2d_canvas: unavailable_software<br>canvas_oop_rasterization: disabled_off<br>direct_rendering_display_compositor: disabled_off_ok<br>gpu_compositing: disabled_software<br>multiple_raster_threads: enabled_on<br>opengl: disabled_off<br>rasterization: disabled_software<br>raw_draw: disabled_off_ok<br>skia_graphite: disabled_off<br>video_decode: disabled_software<br>video_encode: disabled_software<br>vulkan: disabled_off<br>webgl: unavailable_software<br>webgl2: unavailable_software<br>webgpu: unavailable_software<br>webnn: disabled_off|
|Load (avg)|undefined|
|Memory (System)|8.00GB (4.23GB free)|
|Process Argv|--crash-reporter-id e98ffc5f-fa12-4a99-b5c3-44bae2bcdf58|
|Screen Reader|no|
|VM|100%|
</details><details><summary>Extensions (67)</summary>
Extension|Author (truncated)|Version
---|---|---
markdown-wysiwyg|ada|0.7.10
Bookmarks|ale|13.5.0
project-manager|ale|12.8.0
cpp-helper|ami|0.3.4
gitignore|cod|0.9.0
doxdocgen|csc|1.4.0
arm|dan|1.7.4
xslt-xpath|del|1.5.15
groovy-guru|Don|0.6.0
jenkins-extension-pack|Don|0.1.1
xml|Dot|2.5.1
gitlens|eam|15.6.2
vscode-html-css|ecm|2.0.10
cpp-reference-and-documentation|Fed|0.0.5
githd|hui|2.5.3
jenkinsfile-support|ivo|1.1.0
jenkins-pipeline-linter-connector|jan|1.2.0
plantuml|jeb|2.18.1
vscode-ext-import-export|jos|0.0.9
git-lfs-file-locking|kin|0.0.3
jenkins-doc|Maa|1.7.0
git-graph|mhu|1.30.0
csharp|ms-|2.50.27
vscode-dotnet-runtime|ms-|2.2.0
debugpy|ms-|2024.12.0
isort|ms-|2023.10.1
python|ms-|2024.16.1
vscode-pylance|ms-|2024.10.1
jupyter|ms-|2024.9.1
jupyter-keymap|ms-|1.1.2
vscode-jupyter-cell-tags|ms-|0.1.9
vscode-jupyter-slideshow|ms-|0.1.6
remote-containers|ms-|0.388.0
remote-ssh|ms-|0.115.0
remote-ssh-edit|ms-|0.87.0
remote-wsl|ms-|0.88.4
cmake-tools|ms-|1.19.52
cpptools|ms-|1.22.9
cpptools-extension-pack|ms-|1.3.0
hexeditor|ms-|1.10.0
makefile-tools|ms-|0.11.13
powershell|ms-|2024.2.2
remote-explorer|ms-|0.4.3
vs-keybindings|ms-|0.2.1
vsliveshare|ms-|1.0.5941
idl|myt|0.3.1
stash-tabs|paz|0.0.9
java|red|1.35.1
vscode-yaml|red|1.15.0
vscode-xml-complete|rog|0.3.0
annotator|ryu|1.0.0
online-help|sal|0.2.8
code-spell-checker|str|3.0.1
cmake|twx|0.0.17
vscode-counter|uct|3.6.1
intellicode-api-usage-examples|Vis|0.2.8
vscodeintellicode|Vis|1.3.1
vscode-gradle|vsc|3.16.4
vscode-java-debug|vsc|0.58.0
vscode-java-dependency|vsc|0.24.0
vscode-java-pack|vsc|0.29.0
vscode-java-test|vsc|0.42.0
vscode-maven|vsc|0.44.0
gitblame|wad|11.1.1
crs-al-language-extension|wal|1.5.33
markdown-all-in-one|yzh|3.6.2
vscode-open-in-github|ziy|1.3.6
(1 theme extensions excluded)
</details><details>
<summary>A/B Experiments</summary>
```
vsliv368:30146709
vspor879:30202332
vspor708:30202333
vspor363:30204092
vswsl492cf:30256860
vscod805cf:30301675
binariesv615:30325510
vsaa593cf:30376535
py29gd2263:31024239
c4g48928:30535728
azure-dev_surveyone:30548225
962ge761:30959799
pythongtdpath:30769146
pythonnoceb:30805159
asynctok:30898717
pythonmypyd1:30879173
h48ei257:31000450
pythontbext0:30879054
accentitlementsc:30995553
cppperfnew:31000557
dsvsc020:30976470
pythonait:31006305
dsvsc021:30996838
01bff139:31013167
dvdeprecation:31068756
dwnewjupyter:31046869
newcmakeconfigv2:31071590
impr_priority:31102340
nativerepl2:31139839
refactort:31108082
pythonrstrctxt:31112756
wkspc-onlycs-t:31132770
nativeloc2:31134642
wkspc-ranged-t:31151552
cf971741:31144450
defaultse:31146405
iacca1:31156133
notype1cf:31157160
controlgs:31153265
5fd0e150:31155592
dwcopilotcf:31162479
icondisabled:31158250
```
</details>
<!-- generated by issue reporter --> | bug,editor-multicursor | low | Critical |
2,603,562,386 | pytorch | Contribution Proposal: ScatterND Implementation for PyTorch | ### 🚀 The feature, motivation and pitch
Hey everyone, I’m Ali, a software engineer from Nuro, and we’ve been working on migrating a lot of vision models from tensorflow to pytorch. One particularly critical operation for these vision models is tf.tensor_scatter_nd_update , and its reduction counterparts (e.g. tf.tensor_scatter_nd_min, tf.tensor_scatter_nd_max , etc).
We’ve implemented this operation in-house and have been using it successfully for a while now. There have been a few requests for an official pytorch implementation for this operation for a while now (e.g. [here](https://discuss.pytorch.org/t/how-to-implement-tf-scatter-nd-function-of-tensorflow-in-pytorch/18358), [here](https://discuss.pytorch.org/t/how-to-achieve-tf-scatter-nd-in-pytorch-project-for-copynet/4688), etc), so we’d like to offer to set this up.
It's a super robust implementation:
* Uses only native torch layers, and is fully statically shaped
* Supports batching with torch.vmap if desired
* Really performant when used with torch.compile & torch-xla
I've attached sample implementations in the 'Additional context section'.
### Alternatives
There are a few scatter_nd implementations scattered (pardon the pun) around the web but none seem to be perfect.
* https://github.com/rusty1s/pytorch_scatter, this one uses custom CUDA kernels which isn't easy to use or maintain
* https://gist.github.com/airalcorn2/c7846d6fcb58a30b25ea6d97e16fe025, this implementation has a bug
* https://gist.github.com/Ending2015a/b034ebbedc55fec1d8ec3b7230a95f1e, doesn't support batching, or have static shapes which is important for torch.compile/torch-xla
### Additional context
Forum post: https://discuss.pytorch.org/t/contribution-proposal-scatternd-implementation-for-pytorch/211874/1
(sample implementation) https://gist.github.com/boubezariali/2e3d9650461f302a541235e33d7cded2
(simple test) https://gist.github.com/boubezariali/a4a22736a14414404b45b17f62da9c2d
We also have extensive testing implemented that we're willing to contribute. | feature,triaged,needs design,module: scatter & gather ops | low | Critical |
2,603,573,916 | storybook | [Bug]: Investigate Next.js v15 features and limitations | ### Describe the bug
Next.js 15 is now stable.
Investigate the following topics:
- [x] Bug: https://github.com/storybookjs/storybook/issues/29582
- [x] Bug: https://github.com/storybookjs/storybook/issues/29380
- [ ] I am concerned that people would like to use the [React Compiler](https://nextjs.org/blog/next-15#react-compiler-experimental) and will therefore opt-in for babel and opt-out from Next.js’ custom SWC compiler. The experimental-nextjs-vite framework currently only supports SWC, and not babel. It wouldn’t be hard to add babel support, though.
- [ ] https://nextjs.org/blog/next-15#executing-code-after-a-response-with-unstable_after-experimental will very likely not work out of the box in Storybook.
- [ ] https://nextjs.org/blog/next-15#support-for-nextconfigts might not work out of the box in Storybook
- [ ] [Breaking] Disallow using ssr: false option with next/dynamic in Server Components - could break usage of `next/dynamic` in Storybook | bug,nextjs | medium | Critical |
2,603,651,933 | flutter | [go_router_builder] Embedding a TypedStatefulShellRoute inside another does not preserve the route states. | ### What package does this bug report belong to?
go_router_builder
### What target platforms are you seeing this bug on?
Android, iOS
### Have you already upgraded your packages?
Yes
### Dependency versions
<details><summary>pubspec.lock</summary>
```lock
[Paste file content here]
```
</details>
### Steps to reproduce
Follow the next code snippet to generate some nested routes
```dart
@TypedStatefulShellRoute<AdminShellRoute>(
branches: [
/// Parent TypedStatefulShellRoute
TypedStatefulShellBranch(
routes: [
TypedGoRoute<HomeRoute>(
path: HomeRoute.path,
),
],
),
TypedStatefulShellBranch(
routes: [
// Nested TypedStatefulShellRoute
TypedStatefulShellRoute<TablesNestedShellRoute>(
branches: [
TypedStatefulShellBranch(
routes: [
TypedGoRoute<MembersRoute>(
path: MembersRoute.path,
),
TypedGoRoute<PaymentsRoute>(
path: PaymentsRoute.path,
),
TypedGoRoute<ExpensesRoute>(
path: ExpensesRoute.path,
),
TypedGoRoute<BankTransfersRoute>(
path: BankTransfersRoute.path,
),
],
),
],
),
],
),
TypedStatefulShellBranch(
routes: [
TypedGoRoute<ElectronicInvoicingRoute>(
path: ElectronicInvoicingRoute.path,
),
],
),
TypedStatefulShellBranch(
routes: [
TypedGoRoute<NotesRoute>(
path: NotesRoute.path,
),
],
),
TypedStatefulShellBranch(
routes: [
TypedGoRoute<VirtualTrainerRoute>(
path: VirtualTrainerRoute.path,
),
],
),
],
)
```
Now I have a StatelessWidget that I use as the nested tables content with buttons to navigate to MembersRoute, PaymentsRoute , ExpensesRoute and BankTransfersRoute
```dart
class NestedTablesContainer extends StatelessWidget {
const NestedTablesContainer({super.key, required this.state, required this.navigationShell});
final GoRouterState state;
/// The navigation shell and container for the branch Navigators.
final StatefulNavigationShell navigationShell;
@override
Widget build(BuildContext context) {
final items = <_Tab>[
(
path: MembersRoute.path,
text: 'Miembros',
),
(
path: PaymentsRoute.path,
text: 'Pagos',
),
(
path: ExpensesRoute.path,
text: 'Gastos',
),
(
path: BankTransfersRoute.path,
text: 'Transferencias Bancarias',
),
];
final path = state.uri.path;
return Padding(
padding: const EdgeInsets.symmetric(horizontal: 10),
child: Column(
crossAxisAlignment: CrossAxisAlignment.start,
children: [
Row(
children: List.generate(
items.length,
(index) {
final item = items[index];
final active = path.startsWith(item.path);
return TabButton(
onTap: ()=> context.go(item.path),
item:item, active: active,
);
},
),
),
Expanded(
child: navigationShell,
),
],
),
);
}
}
```
### Expected results
In the nested TypedStatefulShellRoute the state of each route must be maintained.
### Actual results
As you can see the Side Bar menu keep the nested routes state but the tab bar route does not keep the state of its nested routes.
### Code sample
<details open><summary>Code sample</summary>
```dart
[Paste your code here]
```
</details>
### Screenshots or Videos
<details open>
<summary>Screenshots / Video demonstration</summary>
https://github.com/user-attachments/assets/ebe7429f-9498-432b-b13f-90a36041e45c
</details>
### Logs
<details open><summary>Logs</summary>
```console
[Paste your logs here]
```
</details>
### Flutter Doctor output
<details open><summary>Doctor output</summary>
```console
[✓] Flutter (Channel stable, 3.24.1, on macOS 15.0.1 24A348 darwin-arm64, locale es-EC)
• Flutter version 3.24.1 on channel stable at /Users/darwin/development/flutter
• Upstream repository https://github.com/flutter/flutter.git
• Framework revision 5874a72aa4 (9 weeks ago), 2024-08-20 16:46:00 -0500
• Engine revision c9b9d5780d
• Dart version 3.5.1
• DevTools version 2.37.2
[✓] Android toolchain - develop for Android devices (Android SDK version 34.0.0)
• Android SDK at /Users/darwin/Library/Android/sdk
• Platform android-34, build-tools 34.0.0
• Java binary at: /Applications/Android Studio.app/Contents/jbr/Contents/Home/bin/java
• Java version OpenJDK Runtime Environment (build 17.0.10+0-17.0.10b1087.21-11609105)
• All Android licenses accepted.
[✓] Xcode - develop for iOS and macOS (Xcode 16.0)
• Xcode at /Applications/Xcode.app/Contents/Developer
• Build 16A242d
• CocoaPods version 1.15.2
[✓] Chrome - develop for the web
• Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome
[✓] Android Studio (version 2024.1)
• Android Studio at /Applications/Android Studio.app/Contents
• Flutter plugin can be installed from:
🔨 https://plugins.jetbrains.com/plugin/9212-flutter
• Dart plugin can be installed from:
🔨 https://plugins.jetbrains.com/plugin/6351-dart
• Java version OpenJDK Runtime Environment (build 17.0.10+0-17.0.10b1087.21-11609105)
[✓] VS Code (version 1.94.2)
• VS Code at /Applications/Visual Studio Code.app/Contents
• Flutter extension version 3.98.0
[✓] Connected device (5 available)
• iPhone 14 pro max de Darwin (mobile) • 00008120-00064DA92633401E • ios • iOS 18.0.1 22A3370
• iPad Air 11-inch (M2) (mobile) • 6D883E13-F8DC-4262-8BAC-25A15B05F13B • ios •
com.apple.CoreSimulator.SimRuntime.iOS-17-5 (simulator)
• macOS (desktop) • macos • darwin-arm64 • macOS 15.0.1 24A348
darwin-arm64
• Mac Designed for iPad (desktop) • mac-designed-for-ipad • darwin • macOS 15.0.1 24A348
darwin-arm64
• Chrome (web) • chrome • web-javascript • Google Chrome
129.0.6668.101
[✓] Network resources
• All expected network resources are available.
• No issues found!
```
</details>
| package,has reproducible steps,P2,p: go_router_builder,team-go_router,triaged-go_router,found in release: 3.24,found in release: 3.27 | low | Critical |
2,603,680,350 | go | x/crypto/ssh/test: TestDialTCP failures | ```
#!watchflakes
default <- pkg == "golang.org/x/crypto/ssh/test" && test == "TestDialTCP"
```
Issue created automatically to collect these failures.
Example ([log](https://ci.chromium.org/b/8733939750140183825)):
=== RUN TestDialTCP
dial_unix_test.go:57: Dial: EOF
test_unix_test.go:246: sshd:
Error reading managed configuration (2: No such file or directory). Proceeding with default configuration.
/Users/swarming/.swarming/w/ir/x/t/sshtest2658011716/sshd_config line 10: Deprecated option KeyRegenerationInterval
/Users/swarming/.swarming/w/ir/x/t/sshtest2658011716/sshd_config line 11: Deprecated option ServerKeyBits
/Users/swarming/.swarming/w/ir/x/t/sshtest2658011716/sshd_config line 17: Deprecated option RSAAuthentication
/Users/swarming/.swarming/w/ir/x/t/sshtest2658011716/sshd_config line 22: Deprecated option RhostsRSAAuthentication
debug1: inetd sockets after dupping: 4, 5
BSM audit: getaddrinfo failed for UNKNOWN: nodename nor servname provided, or not known
...
debug1: auth_activate_options: setting new authentication options
Accepted publickey for swarming from UNKNOWN port 65535 ssh2: ECDSA SHA256:DbuSF5a8c3JMmpZ5WiK8oLAx97Uu8zIAFReb/NyTPuo
debug1: monitor_child_preauth: user swarming authenticated by privileged process
debug1: auth_activate_options: setting new authentication options [preauth]
debug2: userauth_pubkey: authenticated 1 pkalg ecdsa-sha2-nistp256 [preauth]
debug1: monitor_read_log: child log fd closed
BSM audit: bsm_audit_session_setup: setaudit_addr failed: Invalid argument
Could not create new audit session
debug1: do_cleanup
--- FAIL: TestDialTCP (0.17s)
— [watchflakes](https://go.dev/wiki/Watchflakes)
| NeedsInvestigation | low | Critical |
2,603,689,585 | go | x/telemetry: consolidate gopls's cmd/stacks with watchflakes | This issue is following up on a team discussion. Filing to make sure we capture context.
We've been using [golang.org/x/tools/gopls/internal/telemetry/cmd/stacks](https://pkg.go.dev/golang.org/x/tools/gopls/internal/telemetry/cmd/stacks) to produce and de-dupe the issues filed under the [gopls/telemetry-wins](https://github.com/golang/go/issues?q=is%3Aissue+is%3Aopen+label%3Agopls%2Ftelemetry-wins) label.
This command parses, formats, linkifies, and de-dupes stack traces appearing in telemetry data. For "new" stacks, it pops open a window to file a github issue. Recently, @adonovan added predicate-based [deduplication](https://go.dev/cl/613215), similar to watchflakes.
Now we have stacks coming from more than just gopls: the `compile/bug` stack counter has been appearing in recent data ([example](https://storage.googleapis.com/prod-telemetry-merged/2024-10-10.json)).
We should generalize the stacks command. It has been suggested to merge it with watchflakes, since the two serve similar functionality.
Here are some barriers to this automation:
1. The stacks command does git-clone and build of the various executables as that's the only way to get the correct pclntab required to map the symbol-relative line numbers into absolute CodeSearch URLs
2. Running the command sometimes results in errors in which two issues "claim" the same stack due to overlapping rules. In this case one or both of the rules should be updated and the tool re-run.
3. When no existing issue claims the stack, the command opens a browser tab with a populated "New issue" form. At this point the triageur is expected to see if it looks like a real new issue or a dup. If a dup, the existing issue's rule should be updated and the tool re-run. If not, then the user should submit the form to create the new issue.
4. when creating the new issue, it's a good idea to choose a more specific title and to copy some of the surrounding code (e.g. the call to bug.Report) into the issue body. I suppose that could be done later by the triageur. Or automated with better heuristics and logic. | NeedsFix,telemetry,Friction | low | Critical |
2,603,715,178 | PowerToys | Peek Configuration Documentation and Perceived Types | ### Provide a description of requested docs changes
I haven't been able to find anything in the Peek documentation, but I wonder if I am overlooking some key information:
If I want File Explorer -- specifically, Preview Pane -- to handle new file types/extensions as text-encoded when displaying a preview for that particular extension, I can find the entry in the Registry for a given extension and add a perceived type value of `text`. By contrast, the same registry value (that has worked consistently in File Explorer) does **not** control Peek's behavior.
Could someone please shed some light on whether a similar solution is available for Peek? Is there a value that can be added/modified in the respective JSON settings file to achieve the same result? So many file extensions that are really just plain text files, cannot be previewied in Peek unless the file extension is changed to txt (or some other extension Peek recognizes as a text-encoded filetype). | Issue-Docs,Needs-Triage | low | Minor |
2,603,774,643 | flutter | MouseRegion not hit tested outside its parent | ### Steps to reproduce
Run https://dartpad.dev/?id=a408077b04f6090d4b2138c60b5b34bd (both web/windows confirmed)
### Expected results
Hovering any part of the box makes it turn orange.
### Actual results
Box not turning orange on hover anywhere outside the non-offset coordinates, unless the `DecoratedBox` widget is removed.
### Code sample
<details open><summary>Code sample</summary>
```dart
import 'package:flutter/material.dart';
void main() {
runApp(const MainApp());
}
class MainApp extends StatelessWidget {
const MainApp({super.key});
@override
Widget build(BuildContext context) {
return MaterialApp(
home: Scaffold(
backgroundColor: Colors.grey.shade800,
body: Center(child: HoverBox()),
),
);
}
}
class HoverBox extends StatefulWidget {
const HoverBox({super.key});
@override
State<HoverBox> createState() => _HoverBoxState();
}
class _HoverBoxState extends State<HoverBox> {
bool _hovered = false;
@override
Widget build(BuildContext context) {
return DecoratedBox(
decoration: BoxDecoration(border: Border.all()),
child: Transform.translate(
offset: Offset(100, 0),
child: SizedBox.square(
dimension: 200,
child: MouseRegion(
onEnter: (_) => setState(() => _hovered = true),
onExit: (_) => setState(() => _hovered = false),
child: ColoredBox(
color: _hovered ? Colors.orange : Colors.blue.withAlpha(100),
),
),
),
),
);
}
}
```
</details>
### Screenshots or Video
_No response_
### Logs
_No response_
### Flutter Doctor output
<details open><summary>Doctor output</summary>
```console
[√] Flutter (Channel master, 3.26.0-1.0.pre.223, on Microsoft Windows [Version 10.0.22631.4317], locale en-US)
• Flutter version 3.26.0-1.0.pre.223 on channel master at C:\Users\postd\fvm\versions\master
• Upstream repository https://github.com/flutter/flutter.git
• Framework revision 8925e1ffdf (4 weeks ago), 2024-09-26 11:52:53 +1200
• Engine revision d6d5fdba6a
• Dart version 3.6.0 (build 3.6.0-278.0.dev)
• DevTools version 2.40.0-dev.1
[√] Windows Version (Installed version of Windows is version 10 or higher)
[√] Android toolchain - develop for Android devices (Android SDK version 35.0.0)
• Android SDK at C:\Users\postd\AppData\Local\Android\Sdk
• Platform android-35, build-tools 35.0.0
• Java binary at: C:\Users\postd\.jdks\jbr17_0_12\bin\java
• Java version OpenJDK Runtime Environment JBR-17.0.12+1-1087.25-nomod (build 17.0.12+1-b1087.25)
• All Android licenses accepted.
[√] Chrome - develop for the web
• Chrome at C:\Program Files\Google\Chrome\Application\chrome.exe
[√] Visual Studio - develop Windows apps (Visual Studio Community 2022 17.11.5)
• Visual Studio at C:\Program Files\Microsoft Visual Studio\2022\Community
• Visual Studio Community 2022 version 17.11.35327.3
• Windows 10 SDK version 10.0.22621.0
[!] Android Studio (not installed)
• Android Studio not found; download from https://developer.android.com/studio/index.html
(or visit https://flutter.dev/to/windows-android-setup for detailed instructions).
[√] IntelliJ IDEA Ultimate Edition (version 2024.2)
• IntelliJ at C:\Users\postd\AppData\Local\Programs\IntelliJ IDEA Ultimate 3
• Flutter plugin can be installed from:
https://plugins.jetbrains.com/plugin/9212-flutter
• Dart plugin can be installed from:
https://plugins.jetbrains.com/plugin/6351-dart
[√] VS Code, 64-bit edition (version 1.94.2)
• VS Code at C:\Program Files\Microsoft VS Code
• Flutter extension version 3.99.20240930
[√] Connected device (3 available)
• Windows (desktop) • windows • windows-x64 • Microsoft Windows [Version 10.0.22631.4317]
• Chrome (web) • chrome • web-javascript • Google Chrome 129.0.6668.103
• Edge (web) • edge • web-javascript • Microsoft Edge 129.0.2792.89
[√] Network resources
• All expected network resources are available.
! Doctor found issues in 1 category.
```
</details>
| framework,a: desktop,a: mouse,has reproducible steps,P2,team-framework,triaged-framework,found in release: 3.24,found in release: 3.27 | low | Minor |
2,603,774,988 | godot | Shader compile error and subsequent crash on Radeon 3000 | ### Tested versions
Reproducible in Godot 4.3 stable
Not Reproducible Godot 3.6 stable
### System information
Windows 10 - Godot 4.3 stable - OpenGL Compatibility - Athlon II 260 with integrated ATI Radeon 3000
### Issue description
Just running Godot 4.3 logs shader compile errors then crashes:
Ran from cmd prompt and copy and pasted output to godot_cmd.log:
[godot_cmd.log](https://github.com/user-attachments/files/17467358/godot_cmd.log)
At the very least it would be nice for the user to get the error message that says to try updating drivers. I submitted that as a Godot Proposal: https://github.com/godotengine/godot-proposals/issues/11008
### Steps to reproduce
1. Download Godot x86_64 4.3 for Windows
2. Run in cmd prompt
3. A black window briefly shows and then disappears
### Minimal reproduction project (MRP)
No project needed, just try to run Godot 4.3 | bug,platform:windows,topic:core,topic:rendering,topic:thirdparty | low | Critical |
2,603,775,375 | go | cmd/cgo/internal/test: unrecognized failures [consistent failure] | ```
#!watchflakes
default <- pkg == "cmd/cgo/internal/test" && test == ""
```
Issue created automatically to collect these failures.
Example ([log](https://ci.chromium.org/b/8733445799417074081)):
FAIL cmd/cgo/internal/test [build failed]
— [watchflakes](https://go.dev/wiki/Watchflakes)
| NeedsInvestigation | medium | Critical |
2,603,775,409 | go | cmd/cgo/internal/testerrors: TestPointerChecks failures | ```
#!watchflakes
default <- pkg == "cmd/cgo/internal/testerrors" && test == "TestPointerChecks"
```
Issue created automatically to collect these failures.
Example ([log](https://ci.chromium.org/b/8733443699298031025)):
=== RUN TestPointerChecks
ptr_test.go:619: go build: exit status 1
# ptrtest
/opt/golang/swarm/.swarming/w/ir/x/w/goroot/pkg/tool/solaris_amd64/link: running gcc failed: exit status 1
/usr/bin/gcc -m64 -Wl,--build-id=0x5c0bc9f5b8a0cc1596219e4a9b290d7941bd0d78 -o $WORK/b001/exe/a.out -rdynamic -Wl,--compress-debug-sections=zlib /opt/golang/swarm/.swarming/w/ir/x/t/go-link-1131729686/go.o /opt/golang/swarm/.swarming/w/ir/x/t/go-link-1131729686/000000.o /opt/golang/swarm/.swarming/w/ir/x/t/go-link-1131729686/000001.o /opt/golang/swarm/.swarming/w/ir/x/t/go-link-1131729686/000002.o /opt/golang/swarm/.swarming/w/ir/x/t/go-link-1131729686/000003.o /opt/golang/swarm/.swarming/w/ir/x/t/go-link-1131729686/000004.o /opt/golang/swarm/.swarming/w/ir/x/t/go-link-1131729686/000005.o /opt/golang/swarm/.swarming/w/ir/x/t/go-link-1131729686/000006.o /opt/golang/swarm/.swarming/w/ir/x/t/go-link-1131729686/000007.o /opt/golang/swarm/.swarming/w/ir/x/t/go-link-1131729686/000008.o /opt/golang/swarm/.swarming/w/ir/x/t/go-link-1131729686/000009.o /opt/golang/swarm/.swarming/w/ir/x/t/go-link-1131729686/000010.o /opt/golang/swarm/.swarming/w/ir/x/t/go-link-1131729686/000011.o /opt/golang/swarm/.swarming/w/ir/x/t/go-link-1131729686/000012.o -O2 -g -O2 -g -lxnet -lsocket -lsendfile -no-pie
ld: fatal: unrecognized option --build-id=0x5c0bc9f5b8a0cc1596219e4a9b290d7941bd0d78
ld: fatal: use the '-z help' option for usage information
collect2: error: ld returned 1 exit status
--- FAIL: TestPointerChecks (3.84s)
— [watchflakes](https://go.dev/wiki/Watchflakes)
| NeedsInvestigation | low | Critical |
2,603,775,446 | go | cmd/cgo/internal/testerrors: TestReportsTypeErrors failures | ```
#!watchflakes
default <- pkg == "cmd/cgo/internal/testerrors" && test == "TestReportsTypeErrors"
```
Issue created automatically to collect these failures.
Example ([log](https://ci.chromium.org/b/8733438446787498161)):
=== RUN TestReportsTypeErrors
errors_test.go:111: `go run testdata/long_double_size.go`: exit status 1:
# command-line-arguments
/opt/golang/swarm/.swarming/w/ir/x/w/goroot/pkg/tool/solaris_amd64/link: running gcc failed: exit status 1
/usr/bin/gcc -m64 -s -Wl,--build-id=0x129c1ba039253aeae23c5cb5cf1383785c1453fb -o $WORK/b001/exe/long_double_size -rdynamic -Wl,--compress-debug-sections=zlib /opt/golang/swarm/.swarming/w/ir/x/t/go-link-2106502879/go.o /opt/golang/swarm/.swarming/w/ir/x/t/go-link-2106502879/000000.o /opt/golang/swarm/.swarming/w/ir/x/t/go-link-2106502879/000001.o /opt/golang/swarm/.swarming/w/ir/x/t/go-link-2106502879/000002.o /opt/golang/swarm/.swarming/w/ir/x/t/go-link-2106502879/000003.o /opt/golang/swarm/.swarming/w/ir/x/t/go-link-2106502879/000004.o /opt/golang/swarm/.swarming/w/ir/x/t/go-link-2106502879/000005.o /opt/golang/swarm/.swarming/w/ir/x/t/go-link-2106502879/000006.o /opt/golang/swarm/.swarming/w/ir/x/t/go-link-2106502879/000007.o /opt/golang/swarm/.swarming/w/ir/x/t/go-link-2106502879/000008.o /opt/golang/swarm/.swarming/w/ir/x/t/go-link-2106502879/000009.o /opt/golang/swarm/.swarming/w/ir/x/t/go-link-2106502879/000010.o /opt/golang/swarm/.swarming/w/ir/x/t/go-link-2106502879/000011.o -O2 -g -O2 -g -lxnet -lsocket -lsendfile -no-pie
ld: fatal: unrecognized option --build-id=0x129c1ba039253aeae23c5cb5cf1383785c1453fb
ld: fatal: use the '-z help' option for usage information
collect2: error: ld returned 1 exit status
--- FAIL: TestReportsTypeErrors (1.85s)
— [watchflakes](https://go.dev/wiki/Watchflakes)
| NeedsInvestigation | medium | Critical |
2,603,775,479 | go | cmd/cgo/internal/testfortran: TestFortran failures | ```
#!watchflakes
default <- pkg == "cmd/cgo/internal/testfortran" && test == "TestFortran"
```
Issue created automatically to collect these failures.
Example ([log](https://ci.chromium.org/b/8733434853156215457)):
=== RUN TestFortran
fortran_test.go:63: CGO_LDFLAGS= -L /usr/gcc/11/lib/amd64 -Wl,-rpath,/usr/gcc/11/lib/amd64
fortran_test.go:70: /usr/bin/gfortran [testdata/helloworld/helloworld.f90 -o /dev/null]
fortran_test.go:76: go run ./testdata/testprog
fortran_test.go:82: /opt/golang/swarm/.swarming/w/ir/x/w/goroot/bin/go run ./testdata/testprog
fortran_test.go:84: stderr:
# cmd/cgo/internal/testfortran/testdata/testprog
/opt/golang/swarm/.swarming/w/ir/x/w/goroot/pkg/tool/solaris_amd64/link: running gcc failed: exit status 1
/usr/bin/gcc -m64 -s -Wl,--build-id=0x614d1abbf20fce211b9d95e98d2b6500b2ea031d -o $WORK/b001/exe/testprog -rdynamic -Wl,--compress-debug-sections=zlib /opt/golang/swarm/.swarming/w/ir/x/t/go-link-3193556920/go.o /opt/golang/swarm/.swarming/w/ir/x/t/go-link-3193556920/000000.o /opt/golang/swarm/.swarming/w/ir/x/t/go-link-3193556920/000001.o /opt/golang/swarm/.swarming/w/ir/x/t/go-link-3193556920/000002.o /opt/golang/swarm/.swarming/w/ir/x/t/go-link-3193556920/000003.o /opt/golang/swarm/.swarming/w/ir/x/t/go-link-3193556920/000004.o /opt/golang/swarm/.swarming/w/ir/x/t/go-link-3193556920/000005.o /opt/golang/swarm/.swarming/w/ir/x/t/go-link-3193556920/000006.o /opt/golang/swarm/.swarming/w/ir/x/t/go-link-3193556920/000007.o /opt/golang/swarm/.swarming/w/ir/x/t/go-link-3193556920/000008.o /opt/golang/swarm/.swarming/w/ir/x/t/go-link-3193556920/000009.o /opt/golang/swarm/.swarming/w/ir/x/t/go-link-3193556920/000010.o /opt/golang/swarm/.swarming/w/ir/x/t/go-link-3193556920/000011.o /opt/golang/swarm/.swarming/w/ir/x/t/go-link-3193556920/000012.o -L /usr/gcc/11/lib/amd64 -Wl,-rpath,/usr/gcc/11/lib/amd64 -lgfortran -L /usr/gcc/11/lib/amd64 -Wl,-rpath,/usr/gcc/11/lib/amd64 -lxnet -lsocket -lsendfile -no-pie
ld: fatal: unrecognized option --build-id=0x614d1abbf20fce211b9d95e98d2b6500b2ea031d
ld: fatal: use the '-z help' option for usage information
collect2: error: ld returned 1 exit status
fortran_test.go:87: exit status 1
--- FAIL: TestFortran (4.73s)
— [watchflakes](https://go.dev/wiki/Watchflakes)
| NeedsInvestigation | medium | Critical |
2,603,896,742 | rust | Unmerged stack slots under Windows | ERROR: type should be string, got "https://godbolt.org/z/1foPhW5PT\n\nRelevant bits:\n```asm\nexample::write_characteristics::hd20ef966b954cd90:\n sub rsp, 200\n```\n```llvm\ndefine void @example::write_characteristics::hd20ef966b954cd90(i16 noundef %c) unnamed_addr {\nstart:\n %0 = alloca [16 x i8], align 8\n %1 = alloca [16 x i8], align 8\n %2 = alloca [16 x i8], align 8\n %3 = alloca [16 x i8], align 8\n %4 = alloca [16 x i8], align 8\n %5 = alloca [16 x i8], align 8\n %6 = alloca [16 x i8], align 8\n %7 = alloca [16 x i8], align 8\n %8 = alloca [16 x i8], align 8\n %9 = alloca [16 x i8], align 8\n```\n\nI think all the allocas should've been merged in one, or be able to pass a pointer to a global const with the slice." | A-LLVM,A-codegen,T-compiler,O-windows-msvc,I-heavy,C-optimization | low | Major |
2,603,899,013 | ui | [bug]: Label for disabled RadioGroupItem not showing as disabled | ### Describe the bug
The "peer" class is missing for `RadioGroupPrimitive.Item` in `RadioGroupItem` for this to work like the checkbox.
Last radio group item is modified with the "peer" class. The others are as is.
### Affected component/components
RadioGroupItem
### How to reproduce
1. go to https://ui.shadcn.com/docs/components/radio-group
2. look at code for manual installation
3. notice that "peer" class is missing :shrug
### Codesandbox/StackBlitz link
_No response_
### Logs
_No response_
### System Info
```bash
-
```
### Before submitting
- [X] I've made research efforts and searched the documentation
- [X] I've searched for existing issues | bug | low | Critical |
2,603,899,294 | vscode | enable the edit > show writing tools menu for editor | <!-- ⚠️⚠️ Do Not Delete This! feature_request_template ⚠️⚠️ -->
<!-- Please read our Rules of Conduct: https://opensource.microsoft.com/codeofconduct/ -->
<!-- Please search existing issues to avoid creating duplicates. -->
<!-- Describe the feature you'd like. -->
On macOS with Apple Intelligence enabled, most third-party applications display the "Writing Tools" menu option in the edit menu, providing writing suggestions and proofreading options. For those writing documentations in vscode, enabling this menu could prove beneficial.
e.g. here's the menu in google chrome,
| bug,macos,electron | low | Major |
2,603,924,201 | pytorch | SDPA: CUDNN backend error w/ q_seq_len = 1 | ## Summary
Repro script
``` Python
import torch
import torch.nn as nn
import torch.nn.functional as F
q = torch.randn(1, 16, 1, 64, device="cuda", dtype=torch.bfloat16, requires_grad=True)
k = torch.randn(1, 16, 2**16, 64, device="cuda", dtype=torch.bfloat16, requires_grad=True)
v = torch.randn(1, 16, 2**16, 64, device="cuda", dtype=torch.bfloat16, requires_grad=True)
from torch.nn.attention import sdpa_kernel, SDPBackend
with sdpa_kernel(SDPBackend.CUDNN_ATTENTION):
out = F.scaled_dot_product_attention(q, k, v)
out.backward(torch.ones_like(out))
```
Error:
``` Shell
/home/drisspg/meta/pytorch/torch/autograd/graph.py:825: UserWarning: cuDNN SDPA backward got an innermost stride of 0 in grad_out, which is unsupported. Materializing a contiguous tensor which will increase memory usage... (Triggered internally at /home/drisspg/meta/pytorch/aten/src/ATen/native/cudnn/MHA.cpp:664.)
return Variable._execution_engine.run_backward( # Calls into the C++ engine to run the backward pass
Traceback (most recent call last):
File "/home/drisspg/meta/scripts/sdpa/repro_gqa.py", line 15, in <module>
out.sum().backward()
File "/home/drisspg/meta/pytorch/torch/_tensor.py", line 624, in backward
torch.autograd.backward(
File "/home/drisspg/meta/pytorch/torch/autograd/__init__.py", line 347, in backward
_engine_run_backward(
File "/home/drisspg/meta/pytorch/torch/autograd/graph.py", line 825, in _engine_run_backward
return Variable._execution_engine.run_backward( # Calls into the C++ engine to run the backward pass
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
RuntimeError: cuDNN Frontend error: [cudnn_frontend] Error: No execution plans support the graph.
```
cc @ptrblck @msaroufim @eqy @mikaylagawarecki | module: cuda,triaged,module: sdpa | low | Critical |
2,603,938,725 | godot | Export variables don't start filled on Instantiate | ### Tested versions
## Tested versions
Reproducible in: v4.3.stable.mono.official
### System information
Godot v4.3.stable.mono - Windows 10.0.22631 - GLES3 (Compatibility) - AMD Radeon RX 6600 (Advanced Micro Devices, Inc.; 32.0.12011.1036) - AMD Ryzen 7 5700X 8-Core Processor (16 Threads)
### Issue description
I have this scene with a RigidBody2D. In its script I exported a RigidBody2D and assign the very same RigidBody2D (yeah, the way I have implemented that script need to be done in that way). In **another script** I Instantiate this **IceAndFireFx** via code (C#), but the exported RigidtBody2D variable starts null.
I saw this thread #87837 but it was closed without any solution. Looks like it was closed coz the admin missunderstood the problem. But now I'm facing the same issue.
### Steps to reproduce
- Create a Scene
- Attach a C# script with a Exported variable
- Attatch the script owner to the Exported variable
- Instantiate via code the scene with the Exported variable filled
- Get a null exported variable after instantiate.
### Minimal reproduction project (MRP)
[bugreport.zip](https://github.com/user-attachments/files/17468193/bugreport.zip)
| topic:core,needs testing | low | Critical |
2,603,944,599 | bitcoin | getblockchaininfo `verificationprogress` never reaches 1.0 | In the output of `bitcoin-cli getblockchaininfo`, `verificationprogress` sometimes never reaches 1.0, and fluctuates around 0.99999.
```
{
...
"verificationprogress": 0.9999945316157191,
...
}
```
This was reported in #26433, and closed because `verificationprogress` is only an estimate. I would have commented in that issue, but it's locked. The rationale for closing the issue was because the OP in the issue wanted to use `verificationprogress` to check if the chain is synced, and the field is only an estimate, and shouldn't be relied on as exact.
This makes sense, however, however, I think it still should be fixed so that, at the chain tip, `verificationprogress` is 1.0, just for UX reasons. Many a time I've looked at the output of `getblockchaininfo` and been confused because it isn't at 1.0. | RPC/REST/ZMQ | low | Minor |
2,603,954,046 | rust | rustc 1.82.0 doesn't add LIBPATH when invoking link.exe | Rust-to-rust dynamic linking (through import library) on Windows fails with toolchain version 1.82.0.
The build log shows that 1.82.0 is not adding any /LIBPATH arguments when invoking link.exe.
I tried this code: [nandin-borjigin/rustc-1.82.0-repro](https://github.com/nandin-borjigin/rustc-1.82.0-repro)
I expected to see this happen: *Successful build*
Instead, this happened: *LINK : fatal error LNK1181: cannot open input file 'mylib.dll.lib'*
### Meta
<!--
If you're using the stable version of the compiler, you should also check if the
bug also exists in the beta or nightly versions.
-->
`rustc --version --verbose`:
```
rustc 1.82.0 (f6e511eec 2024-10-15)
binary: rustc
commit-hash: f6e511eec7342f59a25f7c0534f1dbea00d01b14
commit-date: 2024-10-15
host: x86_64-pc-windows-msvc
release: 1.82.0
LLVM version: 19.1.1
```
<!--
Include a backtrace in the code block by setting `RUST_BACKTRACE=1` in your
environment. E.g. `RUST_BACKTRACE=1 cargo build`.
-->
<details><summary>Backtrace</summary>
<p>
</p>
</details>
### Possibly related
- #131995 | A-linkage,T-compiler,O-windows-msvc,C-discussion | low | Critical |
2,604,103,396 | kubernetes | Enhancement for ExecAction in Pod Lifecycle | ### What would you like to be added?
Currently the the ExecAction in Pod Lifecycle does not support timeout and the hardcode when run in the container. Suggest adding a timeout param fo ExecAction.
* https://github.com/kubernetes/kubernetes/blob/master/api/openapi-spec/swagger.json
```
"io.k8s.api.core.v1.ExecAction": {
"description": "ExecAction describes a \"run in container\" action.",
"properties": {
"command": {
"description": "Command is the command line to execute inside the container, the working directory for the command is root ('/') in the container's filesystem. The command is simply exec'd, it is not run inside a shell, so traditional shell instructions ('|', etc) won't work. To use a shell, you need to explicitly call out to that shell. Exit status of 0 is treated as live/healthy and non-zero is unhealthy.",
"items": {
"type": "string"
},
"type": "array",
"x-kubernetes-list-type": "atomic"
}
},
"type": "object"
}
```
* https://github.com/kubernetes/kubernetes/blob/9d967ff97332a024b8ae5ba89c83c239474f42fd/pkg/kubelet/lifecycle/handlers.go#L72-L80
### Why is this needed?
If PostStart uses ExecAction and exec hangs during execution, the container call will hang. If the timeout is supported, users can force-stop the container based on the timeout.
### Labels:
/sig sig-api-machinery
/wg wg-api-expression | sig/node,kind/feature,needs-triage | low | Major |
2,604,140,401 | excalidraw | Uncaught SyntaxError: Invalid Regular expression | > excalidraw.production.js:2 Uncaught SyntaxError: Invalid regular expression: /^[^A-Za-zÀ-ÖØ-öø-ʸ̀-Öà €-á¿¿â°€-﬜﷾-﹯﻽-ï¿¿]*[Ö‘-ß¿ï¬-﷽ﹰ-ﻼ]/: Range out of order in character class
I am trying to use the production library in a chrome browser extension but I am getting this error when the extension loads. | bug | low | Critical |
2,604,140,835 | TypeScript | Seeking Guidance: Significant performance regression within editor when upgrading typescript versions in large monorepo | ### Acknowledgement
- [x] I acknowledge that issues using this template may be closed without further explanation at the maintainer's discretion.
### Comment
### **Context**
Upon upgrading from typescript version `5.4.2` to `5.5.2` we are seeing a large performance regression within our local editor (vscode). We are seeking guidance on what might be causing this regression and how we can find a solution to allow us to proceed with the upgrade. We are not seeing any performance impact when running the actual typescript compilation build (e.g. running `tsc -b project-references.tsconfig.json`).
We have tested this in multiple versions, such as `5.6.0` and `5.7.0`, and are still seeing the same regression. I have also tested typescript version `5.4.5` and have not experienced any regressions, which makes me believe the regression occurred somewhere between `5.4.5` and `5.5.2`.
### **Typescript settings**
We are using the same typescript settings mentioned in a previous ticket that we opened (https://github.com/microsoft/TypeScript/issues/59780).
### **Regression**
We are seeing this regression locally within our IDEs (we predominately use vscode). Our monorepo has many sub-packages that are separate TS projects. We have tooling in place that randomly selects and tests the elapsed time it takes a TS project to show type definitions (by looking at the `updateOpen` elapsed time). For simplicity's sake, I will focus on a single TS project where we are seeing a large regression.
| Typescript Version 5.4.2 | Typescript Version 5.5.2 | Percentage Increase |
|--------|--------|--------|
| 74.29ms | 136.64ms | +84% |
> updateOpen: elapsed time (in milliseconds)
**Typescript Version 5.4.2**
updateOpen: elapsed time (in milliseconds) (mean average): 74.29.
Running `tsc -p projectDir/tsconfig.json --extendedDiagnostics` produces:
```
Files: 28110
Lines of Library: 38866
Lines of Definitions: 814186
Lines of TypeScript: 1834871
Lines of JavaScript: 0
Lines of JSON: 4507
Lines of Other: 0
Identifiers: 2834483
Symbols: 7353123
Types: 2044340
Instantiations: 14039604
Memory used: 6912809K
Assignability cache size: 2807267
Identity cache size: 844956
Subtype cache size: 158977
Strict subtype cache size: 235064
I/O Read time: 10.16s
Parse time: 4.05s
ResolveModule time: 8.68s
ResolveTypeReference time: 0.02s
ResolveLibrary time: 0.01s
Program time: 24.66s
Bind time: 2.32s
Check time: 116.29s
printTime time: 0.73s
Emit time: 0.84s
transformTime time: 0.06s
commentTime time: 0.00s
I/O Write time: 0.02s
Total time: 144.11s
```
The below are snippets taken from the TS Server logs in vscode:
```
Info 0 [13:51:34.806] Starting TS Server
Info 40 [13:51:34.941] Starting updateGraphWorker: Project: projectDir/tsconfig.json
Info 54126 [13:52:25.108] Finishing updateGraphWorker: Project: projectDir/tsconfig.json projectStateVersion: 1 projectProgramVersion: 0 structureChanged: true structureIsReused:: Not Elapsed: 50167.559082984924ms
Info 54197 [13:52:28.218] Starting updateGraphWorker: Project: projectDir/tsconfig.json
Info 83985[13:52:48.329] Finishing updateGraphWorker: Project: projectDir/tsconfig.json projectStateVersion: 1 projectProgramVersion: 0 structureChanged: true structureIsReused:: Not Elapsed: 20111.59362500906ms
Perf 83993[13:52:51.013] 2::updateOpen: elapsed time (in milliseconds) 76179.5956
```
The below screenshot is from running `tsc -p projectDir/tsconfig.json --generateTrace`
**Typescript Version 5.5.2**
updateOpen: elapsed time (in milliseconds) (mean average): 136.64
Running `tsc -p projectDir/tsconfig.json --extendedDiagnostics` produces:
```
Files: 28246
Lines of Library: 39135
Lines of Definitions: 820870
Lines of TypeScript: 1834871
Lines of JavaScript: 0
Lines of JSON: 4507
Lines of Other: 0
Identifiers: 2843999
Symbols: 7100120
Types: 1952998
Instantiations: 15389105
Memory used: 6624656K
Assignability cache size: 2762165
Identity cache size: 845019
Subtype cache size: 158941
Strict subtype cache size: 217035
I/O Read time: 11.47s
Parse time: 7.54s
ResolveModule time: 12.34s
ResolveTypeReference time: 0.02s
ResolveLibrary time: 0.02s
Program time: 34.61s
Bind time: 3.01s
Check time: 108.32s
I/O Write time: 0.01s
printTime time: 0.49s
Emit time: 0.49s
Total time: 146.43s
```
The below are snippets taken from the TS Server logs in vscode:
```
Info 0 [14:06:01.540] Starting TS Server
Info 48 [14:06:01.705] Starting updateGraphWorker: Project: projectDir/tsconfig.json
Info 12837[14:07:14.662] Finishing updateGraphWorker: Project: projectDir/tsconfig.json projectStateVersion: 1 projectProgramVersion: 0 structureChanged: true structureIsReused:: Not Elapsed: 72938.59612500668ms
Info 12850[14:07:17.960] Starting updateGraphWorker: Project: projectDir/tsconfig.json
Info 18115[14:08:07.940] Finishing updateGraphWorker: Project: projectDir/tsconfig.json projectStateVersion: 1 projectProgramVersion: 0 structureChanged: true structureIsReused:: Not Elapsed: 49968.97329199314ms
Perf 18116[14:08:10.834] 2::updateOpen: elapsed time (in milliseconds) 129234.7819
```
The below screenshot is from running `tsc -p projectDir/tsconfig.json --generateTrace`
_____
If you require any additional info, please let me know and I will work on getting it for you | Needs Investigation | low | Major |
2,604,185,132 | material-ui | AvatarGroup +n icon's default colors do not meet minimum contrast ratio threshold for accessibility | ### Steps to reproduce
Link to live example: (required)
Every (+n) avatar on https://mui.com/material-ui/react-avatar/
Steps:
1. Visit the link above.
2. Run the axe Devtools chrome extension accessibility scan on that page.
3. Every (+n) avatar on the page gets flagged as not meeting the contrast ratio (in both light and dark mode, though I have screenshotted light mode for this particular example):
<img width="1690" alt="image" src="https://github.com/user-attachments/assets/4caeb893-4df7-41a2-8cfb-209acce5ee2c">
### Current behavior
Axe devtools highlights all the (+n) avatars, with the message: Element has insufficient color contrast of 1.87 (foreground color: #ffffff, background color: #bdbdbd, font size: 15.0pt (20px), font weight: normal). Expected contrast ratio of 4.5:1
### Expected behavior
The default colors on (+n) avatars should have a high enough contrast ratio to pass the accessibility scan.
### Context
I am trying to fix accessibility issues on my site, and while I could override the avatar colors on my own, it seems worthwhile to make the default colors pass accessibility tests out of the box.
### Your environment
<details>
<summary><code>npx @mui/envinfo</code></summary>
```
System:
OS: macOS 12.7.6
Binaries:
Node: 20.11.0 - ~/.nvm/versions/node/v20.11.0/bin/node
npm: 10.2.4 - ~/.nvm/versions/node/v20.11.0/bin/npm
pnpm: Not Found
Browsers:
Chrome: 130.0.6723.59
```
</details>
This bug is likely system agnostic though since it is a default colors accessibility issue that can be seen on the mui website.
**Search keywords**: avatargroup default colors accessibility | accessibility,component: avatar,enhancement | low | Critical |
2,604,214,819 | material-ui | Uncaught TypeError: SvgIcon_default is undefined with vite in dev mode after @mui/icons-material@6.1.0+ | ### Steps to reproduce
Link to live example: (required) https://github.com/cmdcolin/mui-icons-material-error-repro
Steps:
1. clone the repo
2. run yarn
3. run yarn dev
4. observe dev tools error "Uncaught TypeError: SvgIcon_default is undefined"
5. you can optionally checkout the commit HEAD~1 (at which i made a commit message "works") to show that it actually works in a case depending on order of the import of @mui/icons-material/Menu. you can additionally optionally apply a yarn resolution to get @mui/icons-material@6.0.2 to make it work.
### Current behavior
The app fails to run in dev mode in vite due to a fatal error, and it appears to be related to the inclusion of our library and is sensitive to the order of import of the @mui/icons-material/Menu component.
### Expected behavior
ideally we should be able to use our library, and not have sensitivity to order of imports.
### Context
See the README in https://github.com/cmdcolin/mui-icons-material-error-repro for some technical context
The repro is a minimal "App" that only renders a single `<Menu/>` from @mui/icons-material/Menu, but it includes a function from our library also. I am using yarn v1 as a package manager and latest vite.
The error seems to appear only when our NPM package @jbrowse/react-linear-genome-view is used, and it is sensitive to the order of @mui/icons-material imports. our library uses @mui/material v6 including @mui/icons-material v6 as well. I found that @mui/icons-material@6.1.0+ introduced the above error. I saw that https://github.com/mui/material-ui/issues/31835 could be related (xref also https://github.com/mui/material-ui/pull/43624)
ideally, that PR should be a positive for helping most people but it seems to have caused issues with using our library in vite. I am not aware of anything particularly weird that @jbrowse/react-linear-genome-view does regarding imports, we always import from the full path e.g. '@mui/icons-material/Menu' not the barrel style {Menu} from '@mui/icons-material', but wasn't able to create a more minimal repro just yet. our library is not pure ESM.
if it seems like fixing this or hunting this down would be too complex, or making a proper fix would compromise other peoples setups more, then you can ignore this or wontfix it, i won't be upset :)
### Your environment
<details>
<summary><code>npx @mui/envinfo</code></summary>
System:
OS: Linux 6.11 Ubuntu 24.10 24.10 (Oracular Oriole)
Binaries:
Node: 22.8.0 - /run/user/1001/fnm_multishells/17235_1729569485832/bin/node
npm: 10.8.2 - /run/user/1001/fnm_multishells/17235_1729569485832/bin/npm
pnpm: Not Found
Browsers:
Chrome: 127.0.6533.72
npmPackages:
@emotion/react: 11.13.3
@emotion/styled: 11.13.0
@mui/core-downloads-tracker: 6.1.4
@mui/icons-material: 6.1.4
@mui/material: 6.1.4
@mui/private-theming: 6.1.4
@mui/styled-engine: 6.1.4
@mui/system: 6.1.4
@mui/types: 7.2.18
@mui/utils: 6.1.4
@mui/x-charts-vendor: 7.20.0
@mui/x-data-grid: 7.21.0
@mui/x-internals: 7.21.0
@types/react: ^18.0.26 => 18.3.11
react: ^18.2.0 => 18.3.1
react-dom: ^18.2.0 => 18.3.1
typescript: ^5.1.6 => 5.6.3
I also used Firefox but chrome is the same (chrome makes the slightly different error message 'Cannot read properties of undefined (reading 'muiName')')
</details>
**Search keywords**: esbuild, vite, @mui/icons-material | bug 🐛,package: icons | low | Critical |
2,604,221,151 | rust | Hide nonlocal doc(hidden) types and impls from "the following other types implement trait" | ### Code
```rust
// types/src/lib.rs
pub trait Trait {}
pub struct Public;
impl Trait for Public {}
#[doc(hidden)]
pub struct HiddenStruct;
impl Trait for HiddenStruct {}
pub struct HiddenImpl;
#[doc(hidden)]
impl Trait for HiddenImpl {}
#[doc(hidden)]
pub mod private {
pub struct HiddenModule;
impl crate::Trait for HiddenModule {}
}
```
```rust
// src/main.rs
fn require_trait<T: types::Trait>() {}
fn main() {
require_trait::<u8>();
}
```
### Current output
```console
error[E0277]: the trait bound `u8: Trait` is not satisfied
--> src/main.rs:4:21
|
4 | require_trait::<u8>();
| ^^ the trait `Trait` is not implemented for `u8`
|
= help: the following other types implement trait `Trait`:
HiddenImpl
HiddenModule
HiddenStruct
Public
note: required by a bound in `require_trait`
--> src/main.rs:1:21
|
1 | fn require_trait<T: types::Trait>() {}
| ^^^^^^^^^^^^ required by this bound in `require_trait`
```
### Desired output
```diff
- = help: the following other types implement trait `Trait`:
- HiddenImpl
- HiddenModule
- HiddenStruct
- Public
+ = help: the trait `Trait` is implemented for `Public`
```
### Rationale and extra context
`HiddenStruct` should not be volunteered to the user in an error message because that type is `doc(hidden)`.
`HiddenImpl` should not be volunteered as implementing `Trait` because its `impl Trait for HiddenImpl` is `doc(hidden)`.
`HiddenModule` is also not public, although indirectly.
Context: this came up in https://github.com/serde-rs/serde/pull/2558#issuecomment-2428102654.
### Rust Version
```console
rustc 1.84.0-nightly (439284741 2024-10-21)
binary: rustc
commit-hash: 4392847410ddd67f6734dd9845f9742ff9e85c83
commit-date: 2024-10-21
host: x86_64-unknown-linux-gnu
release: 1.84.0-nightly
LLVM version: 19.1.1
```
### Anything else?
There is longstanding precedent for `#[doc(hidden)]` affecting what suggestions rustc tries to make.
For example when suggesting imports. See https://github.com/rust-lang/rust/pull/119151 and https://github.com/rust-lang/rust/blob/814df6e50eaf89b90793e7d9618bb60f1f18377a/tests/ui/suggestions/dont-suggest-foreign-doc-hidden.rs.
Also when suggesting struct fields. See https://github.com/rust-lang/rust/pull/93214 and https://github.com/rust-lang/rust/blob/814df6e50eaf89b90793e7d9618bb60f1f18377a/tests/ui/did_you_mean/dont-suggest-doc-hidden-fields.rs. | A-diagnostics,T-compiler | low | Critical |
2,604,249,659 | yt-dlp | Add support for https://ani.gamer.com.tw | ### DO NOT REMOVE OR SKIP THE ISSUE TEMPLATE
- [X] I understand that I will be **blocked** if I *intentionally* remove or skip any mandatory\* field
### Checklist
- [X] I'm reporting a new site support request
- [X] I've verified that I have **updated yt-dlp to nightly or master** ([update instructions](https://github.com/yt-dlp/yt-dlp#update-channels))
- [X] I've checked that all provided URLs are playable in a browser with the same IP and same login details
- [X] I've checked that none of provided URLs [violate any copyrights](https://github.com/yt-dlp/yt-dlp/blob/master/CONTRIBUTING.md#is-the-website-primarily-used-for-piracy) or contain any [DRM](https://en.wikipedia.org/wiki/Digital_rights_management) to the best of my knowledge
- [X] I've searched [known issues](https://github.com/yt-dlp/yt-dlp/issues/3766) and the [bugtracker](https://github.com/yt-dlp/yt-dlp/issues?q=) for similar issues **including closed ones**. DO NOT post duplicates
- [X] I've read the [guidelines for opening an issue](https://github.com/yt-dlp/yt-dlp/blob/master/CONTRIBUTING.md#opening-an-issue)
- [X] I've read about [sharing account credentials](https://github.com/yt-dlp/yt-dlp/blob/master/CONTRIBUTING.md#are-you-willing-to-share-account-details-if-needed) and am willing to share it if required
### Region
Taiwan
### Example URLs
- Single video: https://ani.gamer.com.tw/animeVideo.php?sn=40137
- Single video: https://ani.gamer.com.tw/animeVideo.php?sn=38861
### Provide a description that is worded well enough to be understood
I hope yt-dlp can support this anime site.
### Provide verbose output that clearly demonstrates the problem
- [X] Run **your** yt-dlp command with **-vU** flag added (`yt-dlp -vU <your command line>`)
- [X] If using API, add `'verbose': True` to `YoutubeDL` params instead
- [X] Copy the WHOLE output (starting with `[debug] Command-line config`) and insert it below
### Complete Verbose Output
```shell
[debug] Command-line config: ['-vU', 'https://ani.gamer.com.tw/animeVideo.php?sn=38861']
[debug] Encodings: locale UTF-8, fs utf-8, pref UTF-8, out utf-8, error utf-8, screen utf-8
[debug] yt-dlp version stable@2024.10.07 from yt-dlp/yt-dlp [1a176d874]
[debug] Python 3.12.7 (CPython x86_64 64bit) - Linux-6.11.4-zen2-1-zen-x86_64-with-glibc2.40 (OpenSSL 3.3.2 3 Sep 2024, glibc 2.40)
[debug] exe versions: ffmpeg 7.0.2 (setts), ffprobe 7.0.2, rtmpdump 2.4
[debug] Optional libraries: certifi-2024.08.30, pycrypto-3.21.0, requests-2.32.3, sqlite3-3.46.1, urllib3-1.26.20
[debug] Proxy map: {}
[debug] Request Handlers: urllib, requests
[debug] Loaded 1838 extractors
[debug] Fetching release info: https://api.github.com/repos/yt-dlp/yt-dlp/releases/latest
Latest version: stable@2024.10.07 from yt-dlp/yt-dlp
yt-dlp is up to date (stable@2024.10.07 from yt-dlp/yt-dlp)
[generic] Extracting URL: https://ani.gamer.com.tw/animeVideo.php?sn=38861
[generic] animeVideo: Downloading webpage
WARNING: [generic] Falling back on generic information extractor
[generic] animeVideo: Extracting information
[debug] Looking for embeds
ERROR: Unsupported URL: https://ani.gamer.com.tw/animeVideo.php?sn=38861
Traceback (most recent call last):
File "/usr/lib/python3.12/site-packages/yt_dlp/YoutubeDL.py", line 1626, in wrapper
return func(self, *args, **kwargs)
^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/lib/python3.12/site-packages/yt_dlp/YoutubeDL.py", line 1761, in __extract_info
ie_result = ie.extract(url)
^^^^^^^^^^^^^^^
File "/usr/lib/python3.12/site-packages/yt_dlp/extractor/common.py", line 741, in extract
ie_result = self._real_extract(url)
^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/lib/python3.12/site-packages/yt_dlp/extractor/generic.py", line 2526, in _real_extract
raise UnsupportedError(url)
yt_dlp.utils.UnsupportedError: Unsupported URL: https://ani.gamer.com.tw/animeVideo.php?sn=38861
```
| site-request,geo-blocked,triage | medium | Critical |
2,604,261,800 | react-native | Swipe / scroll actions on Flatlist gets registered as click event | ### Description
I have a my page like this :
<FlatlistComponent>
<Pressable>
{children}
</Pressable>
</FlatlistComponent>
Sometimes while user scrolls /swipes to. go back. the click event gets triggered( navigating to a screen)
I read few issues , the only solution i got so far is to track the scroll with handlePressIn & handlePressOut , then calculate the pageX,pageY difference do decide whether its a drag or click action.
Adding this affects my scroll performance , (large list of products).
Any solution to this, without compromising the app performance?
### Steps to reproduce
n/a
### React Native Version
0.75.4
### Affected Platforms
Runtime - iOS
### Output of `npx react-native info`
```text
System:
OS: macOS 15.0.1
CPU: (8) arm64 Apple M3
Memory: 107.28 MB / 16.00 GB
Shell:
version: "5.9"
path: /bin/zsh
Binaries:
Node:
version: 18.20.2
path: ~/.nvm/versions/node/v18.20.2/bin/node
Yarn:
version: 3.6.4
path: ~/.nvm/versions/node/v18.20.2/bin/yarn
npm:
version: 10.5.0
path: ~/.nvm/versions/node/v18.20.2/bin/npm
Watchman:
version: 2024.05.06.00
path: /opt/homebrew/bin/watchman
Managers:
CocoaPods:
version: 1.15.2
path: /opt/homebrew/bin/pod
SDKs:
iOS SDK:
Platforms:
- DriverKit 24.0
- iOS 18.0
- macOS 15.0
- tvOS 18.0
- visionOS 2.0
- watchOS 11.0
Android SDK: Not Found
IDEs:
Android Studio: 2024.1 AI-241.15989.150.2411.11948838
Xcode:
version: 16.0/16A242d
path: /usr/bin/xcodebuild
Languages:
Java:
version: 17.0.11
path: /usr/bin/javac
Ruby:
version: 2.6.10
path: /usr/bin/ruby
npmPackages:
"@react-native-community/cli": Not Found
react:
installed: 18.3.1
wanted: 18.3.1
react-native:
installed: 0.75.4
wanted: 0.75.4
react-native-macos: Not Found
npmGlobalPackages:
"*react-native*": Not Found
Android:
hermesEnabled: true
newArchEnabled: false
iOS:
hermesEnabled: true
newArchEnabled: false
```
### Stacktrace or Logs
```text
N/A
```
### Reproducer
[snack.expo.dev/@srimarajexpo/delicious-violet-ramen](https://snack.expo.dev/@srimarajexpo/delicious-violet-ramen)
### Screenshots and Videos
_No response_ | Issue: Author Provided Repro,Component: FlatList,Needs: Repro,Needs: Attention | low | Major |
2,604,267,524 | next.js | Instrumentation in NextJS using custom library + altering RSC payload at Proxy layer | ### Link to the code that reproduces this issue
https://github.com/soniankur948/RN-flicker (please note that it's very early version of code and library/complete app is on internal company codebase)
### To Reproduce
1. I've custom library to capture error, latency and count for an API/activity and trying to collect server side instrumentation for app route (next 14) but with the fact that page and layout renders in parallel it does not work.
2. Similarly in our company we keep red data in encrypted form and only deccrypt that at closed layer to browser (which comes one layer up than Next Layer like Proxy Layer->Next). But it ends up altering the data in RSC payload which creates hydration issues in browser
### Current vs. Expected behavior
For
1. I see two feasible options - i. use custom server ii. calculate metrics for page and layout separately. Is there any other alternative or way to put interceptor to trace the request ?
2. Is there any way to mark the data for which hydration does not fail for RSC data alternation?
### Provide environment information
```bash
next info does not work due to internal npm dependencies. The setup is on node 20.x and uses next 14.
```
### Which area(s) are affected? (Select all that apply)
Instrumentation
### Which stage(s) are affected? (Select all that apply)
Other (Deployed)
### Additional context
The application is deployed on ECS Fargate server. The next standalone gets copied on server and assets are served through CDN. We uses middleware for authentication hence all requests pass through that for app routes and route handlers. Instrumentation using the library works perfectly for route handler instrumentation and client side instrumentation. | Output (export/standalone),Instrumentation | low | Critical |
2,604,330,071 | pytorch | The default setting of PyTorch should show warning always. | ### 🐛 Describe the bug
PyTorch shows warning once by default as shown below. *I reported it to [JupyterLab](https://github.com/jupyterlab/jupyterlab/issues/16825) but it seems like it's a PyTorch problem because it happens on not just JupterLab but also Colab:
```python
import torch
from torch import nn
tensor1 = torch.tensor([[8., -3., 0., 1.]])
tensor2 = torch.tensor([[5., 9., -4., 8.],
[-2., 7., 3., 6.]])
torch.manual_seed(42)
tran = nn.Transformer(d_model=4, nhead=2) # Warning
```
> UserWarning: enable_nested_tensor is True, but self.use_nested_tensor is False because encoder_layer.self_attn.batch_first was not True(use batch_first for better inference performance)
warnings.warn(f"enable_nested_tensor is True, but self.use_nested_tensor is False because {why_not_sparsity_fast_path}")
But the default setting of showing warning once is problematic because some people including me will think warning is solved.
So, I suggest that the default setting should show warning always.
### Versions
```python
import torch
torch.__version__ # 2.4.1+cu121
```
cc @albanD @mruberry @jbschlosser @walterddr @mikaylagawarecki @cpuhrsch @bhosmer @drisspg @soulitzer @davidberard98 @YuqingJ @erichan1 | module: nn,triaged,module: nestedtensor | low | Critical |
2,604,368,210 | next.js | Can't override headers via middleware | ### Link to the code that reproduces this issue
https://codesandbox.io/p/devbox/great-elbakyan-jty6yh
### To Reproduce
Start the application and inspect the headers. You'll see that new headers can be added, but existing headers can't be modified.
### Current vs. Expected behavior
We should be able to replace or remove headers when rewriting.
### Provide environment information
```bash
Operating System:
Platform: darwin
Arch: arm64
Version: Darwin Kernel Version 23.6.0: Wed Jul 31 20:50:54 PDT 2024; root:xnu-10063.141.1.700.5~1/RELEASE_ARM64_T8122
Available memory (MB): 24576
Available CPU cores: 8
Binaries:
Node: 20.14.0
npm: 10.7.0
Yarn: N/A
pnpm: 9.12.2
Relevant Packages:
next: 15.0.0 // Latest available version is detected (15.0.0).
eslint-config-next: N/A
react: 19.0.0-rc-65a56d0e-20241020
react-dom: 19.0.0-rc-65a56d0e-20241020
typescript: 5.6.3
Next.js Config:
output: N/A
```
### Which area(s) are affected? (Select all that apply)
Middleware
### Which stage(s) are affected? (Select all that apply)
next dev (local)
### Additional context
We have a small Next.js app that is designed to proxy between two other apps sharing a single domain.
These apps have headers that we want to modify/remove when their pages are served via the proxy.
We can add headers, but we are not able to modify or remove headers. | bug,Middleware | low | Minor |
2,604,402,628 | tauri | [docs] how to open tauri in Xcode and attach process | I'm experiencing a crash which produces no output before the app crashes. I have the apple crash file (.ips) however without a UI it's impossible to understand where it is crashing.
Is there anyway to generate the macOS .xcodeproj so that Tauri can be launched from Xcode and it catches the crash? | type: documentation | low | Critical |
2,604,417,537 | pytorch | FlexAttention result deviates with torch.compile() and torch.set_float32_matmul_precision('high') | ### 🐛 Describe the bug
Hi, I was testing FlexAttention by comparing its output with that of `nn.MultiheadAttention` and `torch.nn.functional.scaled_dot_product_attention`. In the end, I tracked down the discrepancy to the minimum test below:
```python
import argparse
import itertools
import torch
import torch.nn as nn
import torch.nn.functional as F
from torch.nn.attention import flex_attention
parser = argparse.ArgumentParser(description='Minimum MHA / SDPA / Flex Attention mask test')
parser.add_argument('--test-flex-attention', action='store_true',
help='assert_close for the flex attention output to the rest.')
parser.add_argument('--mask', action='store_true',
help='Test with a simple attention mask.')
parser.add_argument('--compile', action='store_true',
help='Compile the model.')
parser.add_argument('--high-precision', action='store_true',
help='Set float32 matmul precision to "high" (instead of "highest").')
def apply_attn_in(input, in_w, in_b, num_heads, head_dim):
b, s, d = input.shape
qkv = F.linear(input, in_w, in_b)
qkv = qkv.reshape((b, s, 3, num_heads, head_dim))
# (b, s, 3, nh, hd) -> (3, b, nh, s, hd)
return qkv.permute(2, 0, 3, 1, 4)
def apply_attn_out(out, out_w, out_b):
# (b, nh, s, hd) -> (b, s, nh, hd)
out = out.transpose(1, 2)
b, s, nh, hd = out.shape
out = out.reshape((b, s, nh * hd))
return F.linear(out, out_w, out_b)
def apply_attention(input, in_w, in_b, out_w, out_b, num_heads, head_dim, attn_mask, block_mask):
q, k, v = apply_attn_in(input, in_w, in_b, num_heads, head_dim)
out = F.scaled_dot_product_attention(q, k, v, attn_mask=attn_mask)
sdpa_out = apply_attn_out(out, out_w, out_b)
out = flex_attention.flex_attention(q, k, v, block_mask=block_mask)
flex_out = apply_attn_out(out, out_w, out_b)
return sdpa_out, flex_out
class ThreeAttention(nn.Module):
def __init__(
self,
hidden_dim: int,
num_heads: int,
attn_mask,
block_mask,
test_flex_attention,
):
super().__init__()
self.hidden_dim = hidden_dim
self.num_heads = num_heads
self.mha = nn.MultiheadAttention(hidden_dim, num_heads, batch_first=True)
self.attn_mask = attn_mask
self.block_mask = block_mask
self.test_flex_attention = test_flex_attention
def forward(self, x):
sdpa_out, flex_out = apply_attention(
x, self.mha.in_proj_weight,
self.mha.in_proj_bias,
self.mha.out_proj.weight,
self.mha.out_proj.bias,
self.num_heads,
self.hidden_dim // self.num_heads,
self.attn_mask, self.block_mask)
if self.test_flex_attention:
torch.testing.assert_close(sdpa_out, flex_out)
mha_out, _ = self.mha(x, x, x, need_weights=False, attn_mask=None if self.attn_mask is None else ~self.attn_mask)
torch.testing.assert_close(sdpa_out, mha_out)
return mha_out
def main():
args = parser.parse_args()
for args.test_flex_attention, args.mask, args.compile, args.high_precision in itertools.product((False, True), repeat=4):
try:
if args.high_precision:
torch.set_float32_matmul_precision('high')
else:
torch.set_float32_matmul_precision('highest')
hidden_dim = 16
num_heads = 1
seq_length = 2
attn_mask = block_mask = None
if args.mask:
attn_mask = torch.eye(seq_length, dtype=torch.bool).cuda()
def mask_mod(b, h, q_idx, kv_idx):
return attn_mask[q_idx][kv_idx]
block_mask = flex_attention.create_block_mask(
mask_mod, B=None, H=None, Q_LEN=seq_length, KV_LEN=seq_length, BLOCK_SIZE=seq_length)
attn = ThreeAttention(hidden_dim, num_heads, attn_mask, block_mask, args.test_flex_attention).cuda()
if args.compile:
attn = torch.compile(attn)
batch_size = 1
x = torch.randn(batch_size, seq_length, hidden_dim).cuda()
attn(x)
except Exception as ex:
print(f"{args.test_flex_attention=}, {args.mask=}, {args.compile=}, {args.high_precision=} FAILED!")
print(ex)
if __name__ == "__main__":
main()
```
Here is one of the raw test output (username redacted):
```bash
$ python minimum_test.py
/home/████/.local/lib/python3.12/site-packages/torch/_inductor/compile_fx.py:167: UserWarning: TensorFloat32 tensor cores for float32 matrix multiplication available but not enabled. Consider setting `torch.set_float32_matmul_precision('high')` for better performance.
warnings.warn(
args.test_flex_attention=True, args.mask=False, args.compile=True, args.high_precision=True FAILED!
Tensor-likes are not close!
Mismatched elements: 29 / 32 (90.6%)
Greatest absolute difference: 0.0002556145191192627 at index (0, 0, 2) (up to 1e-05 allowed)
Greatest relative difference: 0.024009626358747482 at index (0, 0, 12) (up to 1.3e-06 allowed)
args.test_flex_attention=True, args.mask=True, args.compile=True, args.high_precision=True FAILED!
Tensor-likes are not close!
Mismatched elements: 28 / 32 (87.5%)
Greatest absolute difference: 0.00046330690383911133 at index (0, 0, 5) (up to 1e-05 allowed)
Greatest relative difference: 0.11991884559392929 at index (0, 0, 6) (up to 1.3e-06 allowed)
```
The absolute and relative difference...well, differs in each run, but AFAICT these two cases always fail.
It seems that FlexAttention gives a significantly different result from that of MHA / SDPA when compiled and `torch.set_float32_matmul_precision('high')` whether a mask is applied or not, while everything else is robust. I am not particularly versed in numerical methods or CUDA kernels, but >0.1 of relative difference seems unusual even if 19-bit "TF32" is used here.
I have also tried running `minimum_test.py` above with the current nightly `torch==2.6.0.dev20241021+cu121`. `args.test_flex_attention=True, args.mask=False, args.compile=True, args.high_precision=True` still fails while `args.test_flex_attention=True, args.mask=True, args.compile=True, args.high_precision=False / True` hits a separate error:
```bash
$ python minimum_test.py
args.test_flex_attention=True, args.mask=False, args.compile=True, args.high_precision=True FAILED!
Tensor-likes are not close!
Mismatched elements: 32 / 32 (100.0%)
Greatest absolute difference: 0.00021606683731079102 at index (0, 0, 0) (up to 1e-05 allowed)
Greatest relative difference: 0.004445451311767101 at index (0, 0, 8) (up to 1.3e-06 allowed)
/home/████/.local/lib/python3.12/site-packages/torch/_inductor/compile_fx.py:183: UserWarning: TensorFloat32 tensor cores for float32 matrix multiplication available but not enabled. Consider setting `torch.set_float32_matmul_precision('high')` for better performance.
warnings.warn(
args.test_flex_attention=True, args.mask=True, args.compile=True, args.high_precision=False FAILED!
backend='inductor' raised:
LoweringException: NoValidChoicesError: No choices to select, please consider adding ATEN into max_autotune_gemm_backends config (defined in torch/_inductor/config.py) to allow at least one choice.
# (...)
args.test_flex_attention=True, args.mask=True, args.compile=True, args.high_precision=True FAILED!
backend='inductor' raised:
LoweringException: NoValidChoicesError: No choices to select, please consider adding ATEN into max_autotune_gemm_backends config (defined in torch/_inductor/config.py) to allow at least one choice.
# (...)
```
(https://github.com/pytorch/pytorch/issues/135161 *might* be related...? But that one is about the gradient, not the forward pass...)
### Versions
```bash
$ python collect_env.py
Collecting environment information...
PyTorch version: 2.5.0+cu121
Is debug build: False
CUDA used to build PyTorch: 12.1
ROCM used to build PyTorch: N/A
OS: Ubuntu 24.04.1 LTS (x86_64)
GCC version: (Ubuntu 13.2.0-23ubuntu4) 13.2.0
Clang version: Could not collect
CMake version: Could not collect
Libc version: glibc-2.39
Python version: 3.12.3 (main, Sep 11 2024, 14:17:37) [GCC 13.2.0] (64-bit runtime)
Python platform: Linux-6.8.0-47-generic-x86_64-with-glibc2.39
Is CUDA available: True
CUDA runtime version: 12.0.140
CUDA_MODULE_LOADING set to: LAZY
GPU models and configuration: GPU 0: NVIDIA GeForce RTX 3080 Laptop GPU
Nvidia driver version: 535.183.01
cuDNN version: Probably one of the following:
/usr/lib/x86_64-linux-gnu/libcudnn.so.8.6.0
/usr/lib/x86_64-linux-gnu/libcudnn_adv_infer.so.8.6.0
/usr/lib/x86_64-linux-gnu/libcudnn_adv_train.so.8.6.0
/usr/lib/x86_64-linux-gnu/libcudnn_cnn_infer.so.8.6.0
/usr/lib/x86_64-linux-gnu/libcudnn_cnn_train.so.8.6.0
/usr/lib/x86_64-linux-gnu/libcudnn_ops_infer.so.8.6.0
/usr/lib/x86_64-linux-gnu/libcudnn_ops_train.so.8.6.0
HIP runtime version: N/A
MIOpen runtime version: N/A
Is XNNPACK available: True
CPU:
Architecture: x86_64
CPU op-mode(s): 32-bit, 64-bit
Address sizes: 39 bits physical, 48 bits virtual
Byte Order: Little Endian
CPU(s): 16
On-line CPU(s) list: 0-15
Vendor ID: GenuineIntel
Model name: 11th Gen Intel(R) Core(TM) i7-11800H @ 2.30GHz
CPU family: 6
Model: 141
Thread(s) per core: 2
Core(s) per socket: 8
Socket(s): 1
Stepping: 1
CPU(s) scaling MHz: 21%
CPU max MHz: 4600.0000
CPU min MHz: 800.0000
BogoMIPS: 4608.00
Flags: fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush dts acpi mmx fxsr sse sse2 ss ht tm pbe syscall nx pdpe1gb rdtscp lm constant_tsc art arch_perfmon pebs bts rep_good nopl xtopology nonstop_tsc cpuid aperfmperf tsc_known_freq pni pclmulqdq dtes64 monitor ds_cpl vmx est tm2 ssse3 sdbg fma cx16 xtpr pdcm pcid sse4_1 sse4_2 x2apic movbe popcnt tsc_deadline_timer aes xsave avx f16c rdrand lahf_lm abm 3dnowprefetch cpuid_fault epb cat_l2 cdp_l2 ssbd ibrs ibpb stibp ibrs_enhanced tpr_shadow flexpriority ept vpid ept_ad fsgsbase tsc_adjust bmi1 avx2 smep bmi2 erms invpcid rdt_a avx512f avx512dq rdseed adx smap avx512ifma clflushopt clwb intel_pt avx512cd sha_ni avx512bw avx512vl xsaveopt xsavec xgetbv1 xsaves split_lock_detect user_shstk dtherm ida arat pln pts hwp hwp_notify hwp_act_window hwp_epp hwp_pkg_req vnmi avx512vbmi umip pku ospke avx512_vbmi2 gfni vaes vpclmulqdq avx512_vnni avx512_bitalg avx512_vpopcntdq rdpid movdiri movdir64b fsrm avx512_vp2intersect md_clear ibt flush_l1d arch_capabilities
Virtualization: VT-x
L1d cache: 384 KiB (8 instances)
L1i cache: 256 KiB (8 instances)
L2 cache: 10 MiB (8 instances)
L3 cache: 24 MiB (1 instance)
NUMA node(s): 1
NUMA node0 CPU(s): 0-15
Vulnerability Gather data sampling: Mitigation; Microcode
Vulnerability Itlb multihit: Not affected
Vulnerability L1tf: Not affected
Vulnerability Mds: Not affected
Vulnerability Meltdown: Not affected
Vulnerability Mmio stale data: Not affected
Vulnerability Reg file data sampling: Not affected
Vulnerability Retbleed: Not affected
Vulnerability Spec rstack overflow: Not affected
Vulnerability Spec store bypass: Mitigation; Speculative Store Bypass disabled via prctl
Vulnerability Spectre v1: Mitigation; usercopy/swapgs barriers and __user pointer sanitization
Vulnerability Spectre v2: Mitigation; Enhanced / Automatic IBRS; IBPB conditional; RSB filling; PBRSB-eIBRS SW sequence; BHI SW loop, KVM SW loop
Vulnerability Srbds: Not affected
Vulnerability Tsx async abort: Not affected
Versions of relevant libraries:
[pip3] flake8==7.0.0
[pip3] numpy==1.26.3
[pip3] nvidia-cublas-cu12==12.1.3.1
[pip3] nvidia-cuda-cupti-cu12==12.1.105
[pip3] nvidia-cuda-nvrtc-cu12==12.1.105
[pip3] nvidia-cuda-runtime-cu12==12.1.105
[pip3] nvidia-cudnn-cu12==9.1.0.70
[pip3] nvidia-cufft-cu12==11.0.2.54
[pip3] nvidia-curand-cu12==10.3.2.106
[pip3] nvidia-cusolver-cu12==11.4.5.107
[pip3] nvidia-cusparse-cu12==12.1.0.106
[pip3] nvidia-nccl-cu12==2.21.5
[pip3] nvidia-nvjitlink-cu12==12.1.105
[pip3] nvidia-nvtx-cu12==12.1.105
[pip3] pytorch-triton==3.1.0+cf34004b8a
[pip3] torch==2.5.0+cu121
[pip3] torchaudio==2.5.0+cu121
[pip3] torchvision==0.20.0+cu121
[pip3] triton==3.1.0
[pip3] types-flake8-2020==1.8
[pip3] types-flake8-bugbear==23.9.16
[pip3] types-flake8-builtins==2.2
[pip3] types-flake8-docstrings==1.7
[pip3] types-flake8-plugin-utils==1.3
[pip3] types-flake8-rst-docstrings==0.3
[pip3] types-flake8-simplify==0.21
[pip3] types-flake8-typing-imports==1.15
[pip3] types-mypy-extensions==1.0
[conda] Could not collect
```
cc @ezyang @chauhang @penguinwu @zou3519 @ydwu4 @bdhirsh @yf225 @Chillee @drisspg @yanboliang @BoyuanFeng | triaged,oncall: pt2,module: higher order operators,module: pt2-dispatcher,module: flex attention | low | Critical |
2,604,428,084 | pytorch | DISABLED test_record_stream_cuda_float32 (__main__.TestNestedTensorSubclassCUDA) | Platforms: linux
This test was disabled because it is failing in CI. See [recent examples](https://hud.pytorch.org/flakytest?name=test_record_stream_cuda_float32&suite=TestNestedTensorSubclassCUDA&limit=100) and the most recent trunk [workflow logs](https://github.com/pytorch/pytorch/runs/31860766496).
Over the past 3 hours, it has been determined flaky in 5 workflow(s) with 6 failures and 5 successes.
**Debugging instructions (after clicking on the recent samples link):**
DO NOT ASSUME THINGS ARE OKAY IF THE CI IS GREEN. We now shield flaky tests from developers so CI will thus be green but it will be harder to parse the logs.
To find relevant log snippets:
1. Click on the workflow logs linked above
2. Click on the Test step of the job so that it is expanded. Otherwise, the grepping will not work.
3. Grep for `test_record_stream_cuda_float32`
4. There should be several instances run (as flaky tests are rerun in CI) from which you can study the logs.
<details><summary>Sample error message</summary>
```
Traceback (most recent call last):
File "/var/lib/jenkins/workspace/test/test_nestedtensor.py", line 4271, in test_record_stream
self.assertEqual(len(data_ptrs.intersection(nt_data_ptrs)), 0)
File "/opt/conda/envs/py_3.10/lib/python3.10/site-packages/torch/testing/_internal/common_utils.py", line 3901, in assertEqual
raise error_metas.pop()[0].to_error(
AssertionError: Scalars are not equal!
Expected 0 but got 1.
Absolute difference: 1
Relative difference: inf
To execute this test, run the following from the base repo dir:
python test/test_nestedtensor.py TestNestedTensorSubclassCUDA.test_record_stream_cuda_float32
This message can be suppressed by setting PYTORCH_PRINT_REPRO_ON_FAILURE=0
```
</details>
Test file path: `test_nestedtensor.py`
ConnectionTimeoutError: Connect timeout for 5000ms, GET https://raw.githubusercontent.com/pytorch/pytorch/main/test/test_nestedtensor.py -2 (connected: false, keepalive socket: false, socketHandledRequests: 1, socketHandledResponses: 0)
headers: {}
cc @clee2000 @cpuhrsch @jbschlosser @bhosmer @drisspg @soulitzer @davidberard98 @YuqingJ | triaged,module: flaky-tests,module: nestedtensor,skipped | low | Critical |
2,604,487,758 | angular | Client-side hydration renders content before the app is stable | ### Which @angular/* package(s) are the source of the bug?
core
### Is this a regression?
No
### Description
When client hydration is enabled, I expected the app to use the SSR view until it's stable, then switch over to the client-rendered view. If there are pending network requests or anything else blocking stabilisation on the client side, it shouldn't show any loading states or similar. Instead, any loading states render on top of the SSR view, which causes flickers on the page.
This is consistently replicable when making any network requests `withNoHttpTransferCache()`, or when making uncacheable requests (eg. POST requests before they were supported).
Is this the expected behaviour? It is possible to work around via making sure everything does get cached properly, but it seemed a bit strange. I was used to the way (pre-hydration) Preboot only replaced the page after everything loaded and this has resulted in a behaviour change under some circumstances.
### Please provide a link to a minimal reproduction of the bug
https://github.com/henry-alakazhang/hydration-stable-flicker
### Please provide the exception or error you saw
Expected: page renders smoothly, ie. content is hidden until stable or it's rendered separately to the SSR content.
Actual: page flickers while frontend is updating state.
Note that, depending on how certain things are implemented, this can happen even when the `HttpTransferCache` is enabled. If the template depends on an asynchronous function that doesn't emit on first tick, the flicker can occur (just shorter) even if the request is cached (or the state is transferred via `TransferState`)
### Please provide the environment you discovered this bug in (run `ng version`)
```
Angular CLI: 18.2.9
Node: 18.20.3
Package Manager: yarn 1.22.22
OS: darwin arm64
Angular: 18.2.8
... animations, common, compiler, compiler-cli, core, forms
... platform-browser, platform-browser-dynamic, platform-server
... router
Package Version
---------------------------------------------------------
@angular-devkit/architect 0.1802.9
@angular-devkit/build-angular 18.2.9
@angular-devkit/core 18.2.9
@angular-devkit/schematics 18.2.9
@angular/cli 18.2.9
@angular/ssr 18.2.9
@schematics/angular 18.2.9
rxjs 7.8.1
typescript 5.5.4
zone.js 0.14.10
```
### Anything else?
_No response_ | area: core,area: server,core: hydration | low | Critical |
2,604,500,630 | ui | [bug]: Calendar does not work properly with default form values | ### Describe the bug
When using the datepicker in a form and setting values or default values, the default value cannot properly be de-selected. When clicking on the same date, the regular behavior would be for the date to be de-selected however in this case, the date gets set back to the default value.
### Affected component/components
DatePicker
### How to reproduce
This can be recreated using the default form setup from the site, but adding a default value. When selecting any other value than the default, then reclicking that value to deselect it, the datepicker once again shows the default value that was set.
```
const FormSchema = z.object({
dob: z.date({
required_error: "A date of birth is required.",
}),
})
export function DatePickerForm() {
const form = useForm<z.infer<typeof FormSchema>>({
resolver: zodResolver(FormSchema),
defaultValues: {
dob: new Date();
}
})
function onSubmit(data: z.infer<typeof FormSchema>) {
toast({
title: "You submitted the following values:",
description: (
<pre className="mt-2 w-[340px] rounded-md bg-slate-950 p-4">
<code className="text-white">{JSON.stringify(data, null, 2)}</code>
</pre>
),
})
}
return (
<Form {...form}>
<form onSubmit={form.handleSubmit(onSubmit)} className="space-y-8">
<FormField
control={form.control}
name="dob"
render={({ field }) => (
<FormItem className="flex flex-col">
<FormLabel>Date of birth</FormLabel>
<Popover>
<PopoverTrigger asChild>
<FormControl>
<Button
variant={"outline"}
className={cn(
"w-[240px] pl-3 text-left font-normal",
!field.value && "text-muted-foreground"
)}
>
{field.value ? (
format(field.value, "PPP")
) : (
<span>Pick a date</span>
)}
<CalendarIcon className="ml-auto h-4 w-4 opacity-50" />
</Button>
</FormControl>
</PopoverTrigger>
<PopoverContent className="w-auto p-0" align="start">
<Calendar
mode="single"
selected={field.value}
onSelect={field.onChange}
disabled={(date) =>
date > new Date() || date < new Date("1900-01-01")
}
initialFocus
/>
</PopoverContent>
</Popover>
<FormDescription>
Your date of birth is used to calculate your age.
</FormDescription>
<FormMessage />
</FormItem>
)}
/>
<Button type="submit">Submit</Button>
</form>
</Form>
)
}
```
### Codesandbox/StackBlitz link
_No response_
### Logs
_No response_
### System Info
```bash
Runs the same in local and online environments.
```
### Before submitting
- [X] I've made research efforts and searched the documentation
- [X] I've searched for existing issues | bug | low | Critical |
2,604,504,101 | next.js | Unable to process favicon | ### Link to the code that reproduces this issue
https://codesandbox.io/p/devbox/romantic-ace-vn6rqz
### To Reproduce
1. Place in the app folder the specific favicon.ico I have provided in the codesandbox
2. Run dev with turbo enabled
3. Receive the following error:
```
⨯ ./app/favicon.ico
Processing image failed
unable to decode image data
Caused by:
- failed to fill whole buffer
```
### Current vs. Expected behavior
Would expect the following the favicon to render:
but instead get:
### Provide environment information
```bash
Operating System:
Platform: linux
Arch: x64
Version: #1 SMP PREEMPT_DYNAMIC Sun Aug 6 20:05:33 UTC 2023
Available memory (MB): 4102
Available CPU cores: 2
Binaries:
Node: 20.9.0
npm: 9.8.1
Yarn: 1.22.19
pnpm: 8.10.2
Relevant Packages:
next: 15.0.0 // Latest available version is detected (15.0.0).
eslint-config-next: N/A
react: 18.3.1
react-dom: 18.3.1
typescript: N/A
Next.js Config:
output: N/A
```
### Which area(s) are affected? (Select all that apply)
Turbopack
### Which stage(s) are affected? (Select all that apply)
next dev (local)
### Additional context
This error started occuring on `next@15.0.0-rc.1` and persists on `next@15.0.0`. It was not occuring on `next@15.0.0-rc.0`. | bug,Turbopack,linear: turbopack | low | Critical |
2,604,518,316 | ant-design | 服务端渲染-整体导出样式不生效 + 使用插件会造成浏览器崩溃 | ### Reproduction link
[https://github.com/BruceCham/antd-ssr](https://github.com/BruceCham/antd-ssr)
### Steps to reproduce
npm install && npm run dev
### What is expected?
自定义样式生效
### What is actually happening?
1、自定义样式不生效
2、chrome安装有第三方插件时候，会报ssr异常，比如【Mokku 2.0.11、 Highlight This】
Cannot read properties of null (reading 'children')
| Environment | Info |
| --- | --- |
| antd | 5.21.5 |
| React | 18.2.0 |
| System | mac pro |
| Browser | chrome lts |
<!-- generated by ant-design-issue-helper. DO NOT REMOVE --> | Inactive | low | Major |
2,604,539,858 | rust | Silent failure of std::sync::Once when in const variable | I tried this code [playground link](https://play.rust-lang.org/?version=stable&mode=debug&edition=2018&gist=e872d18e2c2ee6a806f7872052fbd744):
```rust
use std::sync::Once;
const INIT: Once = Once::new();
fn main() {
INIT.call_once(|| {
println!("Global Once::call_once first call");
});
INIT.call_once(|| {
println!("Global Once::call_once second call");
});
}
```
The problem is that my Once is in a `const` and not a `static`. However, I would expect a compile error or a runtime error instead of broken behavior here. The same behavior is exhibited in `std::sync::LazyLock` and probably `std::sync::OnceLock`, due to using a Once internally.
Thanks for considering this!
### Meta
Checked on 1.82.0 and on nightly. | A-lints,T-compiler,C-bug | low | Critical |
2,604,582,359 | pytorch | [CI] Continuous spam of PyTorch CI build status notifications in fork | Ever since forking the PyTorch repo, in just a month I have received over 200+ notifications from the CI build status. Such notifications should only be triggered for the specific changes the author made (say when opening a PR) just like other repos.
GitHub's global CI notifications option turns off all, so that isn't quite the solution.
cc @seemethere @malfet @pytorch/pytorch-dev-infra | module: ci,triaged,actionable | low | Major |
2,604,592,126 | langchain | DOC: outdated documentation for Playwright tool, introducing the Agents | ### URL
https://python.langchain.com/docs/integrations/tools/playwright/
### Checklist
- [X] I added a very descriptive title to this issue.
- [X] I included a link to the documentation page I am referring to (if applicable).
### Issue with current documentation:
The current documentation for using agents with LangChain offers an incorrect or incomplete flow. Specifically, the following examples fail:
` from langchain.agents import AgentType, initialize_agent
from langchain_anthropic import ChatAnthropic
llm = ChatAnthropic(
model_name="claude-3-haiku-20240307", temperature=0
) # or any other LLM, e.g., ChatOpenAI(), OpenAI()
agent_chain = initialize_agent(
tools,
llm,
agent=AgentType.STRUCTURED_CHAT_ZERO_SHOT_REACT_DESCRIPTION,
verbose=True,
) `
**While the documentation suggests ChatOpenAI() and OpenAI() are supported, the functionality fails when using these LLMs, even with the updated agent initialisation:**
`
agent_chain = create_structured_chat_agent(
llm=llm,
tools=tools,
prompt=chat_prompt
)
`
**Error encounter:**
`Traceback (most recent call last):
File "/path/to/file.py", line 58, in <module>
agent_chain = create_structured_chat_agent(
File "/path/to/langchain/structured_chat/base.py", line 283, in create_structured_chat_agent
tools=tools_renderer(list(tools)),
File "/path/to/langchain_core/tools/render.py", line 58, in render_text_description_and_args
args_schema = str(tool.args)
File "/path/to/pydantic/main.py", line 853, in __getattr__
return super().__getattribute__(item) # Raises AttributeError if appropriate
File "/path/to/langchain_core/tools/base.py", line 446, in args
return self.get_input_schema().model_json_schema()["properties"]
File "/path/to/pydantic/json_schema.py", line 2277, in model_json_schema
raise AttributeError('model_json_schema() must be called on a subclass of BaseModel, not BaseModel itself.')
AttributeError: model_json_schema() must be called on a subclass of BaseModel, not BaseModel itself.
`
Observations:
The issue seems to stem from tool.args and how it handles the schema with Pydantic. The error is raised when model_json_schema() is called on an object that isn't a subclass of BaseModel.
This problem occurs regardless of using initialize_agent or create_structured_chat_agent. The provided tools are not handled correctly in either approach.
Expected Behavior:
The agent should be able to use tools, and their arguments should be processed correctly without raising schema-related errors.
### Idea or request for content:
the documentation needs the update | 🤖:docs,stale | low | Critical |
2,604,720,029 | react-native | ListMetricsAggregator must be notified of list content layout before resolving offsets | ### Description
We are receiving this crash on Android devices, observed it on Firebase Crashlytics but It does not contain any logs. We could not reproduced this crash and would not find any similar bug.
### Steps to reproduce
-
### React Native Version
0.74.5
### Affected Platforms
Runtime - Android
### Output of `npx react-native info`
```text
System:
OS: macOS 14.3.1
CPU: (8) arm64 Apple M3
Memory: 49.61 MB / 16.00 GB
Shell:
version: 3.2.57
path: /bin/bash
Binaries:
Node:
version: 18.19.1
path: ~/.nvm/versions/node/v18.19.1/bin/node
Yarn:
version: 1.22.22
path: ~/.nvm/versions/node/v18.19.1/bin/yarn
npm:
version: 10.2.4
path: ~/.nvm/versions/node/v18.19.1/bin/npm
Watchman:
version: 2024.07.29.00
path: /opt/homebrew/bin/watchman
Managers:
CocoaPods:
version: 1.15.2
path: /Users/alpaye/.rbenv/shims/pod
SDKs:
iOS SDK:
Platforms:
- DriverKit 23.2
- iOS 17.2
- macOS 14.2
- tvOS 17.2
- visionOS 1.0
- watchOS 10.2
Android SDK: Not Found
IDEs:
Android Studio: 2023.1 AI-231.9392.1.2311.11330709
Xcode:
version: 15.2/15C500b
path: /usr/bin/xcodebuild
Languages:
Java:
version: 17.0.10
path: /usr/bin/javac
Ruby:
version: 2.7.8
path: /Users/alpaye/.rbenv/shims/ruby
npmPackages:
"@react-native-community/cli": Not Found
react:
installed: 18.2.0
wanted: 18.2.0
react-native:
installed: 0.74.5
wanted: 0.74.5
react-native-macos: Not Found
npmGlobalPackages:
"*react-native*": Not Found
Android:
hermesEnabled: true
newArchEnabled: false
iOS:
hermesEnabled: true
newArchEnabled: false
```
### Stacktrace or Logs
```text
Fatal Exception: com.facebook.react.common.JavascriptException: Invariant Violation: ListMetricsAggregator must be notified of list content layout before resolving offsets, js engine: hermes, stack:
invariant@1:139225
flowRelativeOffset@1:605334
notifyCellLayout@1:604441
anonymous@1:587750
anonymous@1:611095
invokeGuardedCallbackImpl@1:409136
invokeGuardedCallback@1:409193
invokeGuardedCallbackAndCatchFirstError@1:409225
executeDispatch@1:409354
executeDispatchesAndReleaseTopLevel@1:412758
forEachAccumulated@1:410830
anonymous@1:413121
batchedUpdatesImpl@1:481191
batchedUpdates$1@1:412674
_receiveRootNodeIDEvent@1:412959
receiveEvent@1:475781
__callFunction@1:134915
anonymous@1:133217
__guard@1:134175
callFunctionReturnFlushedQueue@1:133175
at com.facebook.react.modules.core.ExceptionsManagerModule.reportException(ExceptionsManagerModule.java:65)
at java.lang.reflect.Method.invoke(Method.java)
at com.facebook.react.bridge.JavaMethodWrapper.invoke(JavaMethodWrapper.java:372)
at com.facebook.react.bridge.JavaModuleWrapper.invoke(JavaModuleWrapper.java:146)
at com.facebook.jni.NativeRunnable.run(NativeRunnable.java)
at android.os.Handler.handleCallback(Handler.java:958)
at android.os.Handler.dispatchMessage(Handler.java:99)
at com.facebook.react.bridge.queue.MessageQueueThreadHandler.dispatchMessage(MessageQueueThreadHandler.java:27)
at android.os.Looper.loopOnce(Looper.java:230)
at android.os.Looper.loop(Looper.java:319)
at com.facebook.react.bridge.queue.MessageQueueThreadImpl$4.run(MessageQueueThreadImpl.java:233)
at java.lang.Thread.run(Thread.java:1012)
```
### Reproducer
-
### Screenshots and Videos
_No response_ | Needs: Author Feedback,Needs: Repro,Newer Patch Available | low | Critical |
2,604,723,809 | rust | rustc doesn't finish stuck at rustc_trait_selection::traits::normalize::normalize_with_depth_to | <!--
Thank you for filing a bug report! 🐛 Please provide a short summary of the bug,
along with any information you feel relevant to replicating the bug.
-->
After a re factoring, moving some structs into different crates the build won't finish.
[Raphtory](https://github.com/Pometry/Raphtory/tree/memstorage)
These finish
```
cargo check -p raphtory-api
cargo check -p raphtory-memstorage
```
This doesn't
```
cargo check -p raphtory
```
I need some help to track down what causes this?
I suspect our use of traits is the cause of this but I don't know how to find out which ones are causing this issue.
I expected to see this happen: **cargo would finish compiling**
Instead, this happened: **cargo doesn't finish compiling**
### Meta
<!--
If you're using the stable version of the compiler, you should also check if the
bug also exists in the beta or nightly versions.
-->
`rustc --version --verbose`:
```
rustc 1.82.0 (f6e511eec 2024-10-15)
binary: rustc
commit-hash: f6e511eec7342f59a25f7c0534f1dbea00d01b14
commit-date: 2024-10-15
host: x86_64-unknown-linux-gnu
release: 1.82.0
LLVM version: 19.1.1
```
<!--
Include a backtrace in the code block by setting `RUST_BACKTRACE=1` in your
environment. E.g. `RUST_BACKTRACE=1 cargo build`.
-->
<details><summary>The end of Rustc LOG where depth seems to degenerate</summary>
<p>
```
rustc_trait_selection::traits::normalize::normalize_with_depth_to depth=0, value=ImplHeader { impl_def_id: DefId(2:2820 ~ core[d898]::ptr::{impl#0}), impl_args: [?0t], self
_ty: ?0t, trait_ref: Some(<_ as std::cmp::PartialEq>), predicates: [Binder { value: TraitPredicate(<_ as std::marker::Sized>, polarity:Positive), bound_vars: [] }, Binder {
value: TraitPredicate(<_ as std::marker::FnPtr>, polarity:Positive), bound_vars: [] }] }
rustc_trait_selection::traits::normalize::normalize_with_depth_to depth=0, value=ImplHeader { impl_def_id: DefId(0:5278 ~ raphtory[29e2]::db::graph::graph::{impl#1}), impl_
args: ['?0, ?1t], self_ty: raphtory_memstorage::db::graph::views::graph::Graph, trait_ref: Some(<raphtory_memstorage::db::graph::views::graph::Graph as std::cmp::PartialEq<_
>>), predicates: [Binder { value: TraitPredicate(<_ as std::marker::Sized>, polarity:Positive), bound_vars: [] }, Binder { value: TraitPredicate(<_ as db::api::view::graph::
GraphViewOps<'_>>, polarity:Positive), bound_vars: [] }, Binder { value: OutlivesPredicate(raphtory_memstorage::db::graph::views::graph::Graph, '?0), bound_vars: [] }] }
rustc_trait_selection::traits::normalize::normalize_with_depth_to depth=1, value=<_ as db::api::view::graph::GraphViewOps<'_>>
rustc_trait_selection::traits::normalize::normalize_with_depth_to depth=1, value=<_ as db::api::view::graph::GraphViewOps<'_>>
rustc_trait_selection::traits::normalize::normalize_with_depth_to depth=1, value=Binder { value: TraitPredicate(<_ as std::marker::Sized>, polarity:Positive), bound_vars: [
] }
rustc_trait_selection::traits::normalize::normalize_with_depth_to depth=1, value=Binder { value: TraitPredicate(<_ as db::api::view::internal::BoxableGraphView>, polarity:P
ositive), bound_vars: [] }
rustc_trait_selection::traits::normalize::normalize_with_depth_to depth=1, value=Binder { value: TraitPredicate(<_ as std::clone::Clone>, polarity:Positive), bound_vars: []
}
rustc_trait_selection::traits::normalize::normalize_with_depth_to depth=1, value=Binder { value: OutlivesPredicate(?2t, '?1), bound_vars: [] }
rustc_trait_selection::traits::normalize::normalize_with_depth_to depth=1, value=Binder { value: OutlivesPredicate(?2t, '?1), bound_vars: [] }
rustc_trait_selection::traits::normalize::normalize_with_depth_to depth=3, value=<_ as db::api::view::internal::BoxableGraphView>
rustc_trait_selection::traits::normalize::normalize_with_depth_to depth=3, value=<_ as db::api::view::internal::BoxableGraphView>
...
rustc_trait_selection::traits::normalize::normalize_with_depth_to depth=66, value=Binder { value: TraitPredicate(<alloc::raw_vec::RawVecInner as std::marker::Sync>, polarity:Positive), bound_vars: [] }
rustc_trait_selection::traits::normalize::normalize_with_depth_to depth=66, value=std::ptr::Unique<u8>
rustc_trait_selection::traits::normalize::normalize_with_depth_to depth=66, value=alloc::raw_vec::Cap
rustc_trait_selection::traits::normalize::normalize_with_depth_to depth=66, value=std::alloc::Global
rustc_trait_selection::traits::normalize::normalize_with_depth_to depth=67, value=<std::ptr::Unique<_> as std::marker::Sync>
rustc_trait_selection::traits::normalize::normalize_with_depth_to depth=67, value=<std::ptr::Unique<_> as std::marker::Sync>
rustc_trait_selection::traits::normalize::normalize_with_depth_to depth=67, value=Binder { value: TraitPredicate(<_ as std::marker::Sync>, polarity:Positive), bound_vars: [] }
rustc_trait_selection::traits::normalize::normalize_with_depth_to depth=68, value=Binder { value: TraitPredicate(<u8 as std::marker::Sync>, polarity:Positive), bound_vars: [] }
rustc_trait_selection::traits::normalize::normalize_with_depth_to depth=67, value=Binder { value: TraitPredicate(<alloc::raw_vec::Cap as std::marker::Sync>, polarity:Positive), bound_vars: [] }
rustc_trait_selection::traits::normalize::normalize_with_depth_to depth=67, value=usize
rustc_trait_selection::traits::normalize::normalize_with_depth_to depth=68, value=Binder { value: TraitPredicate(<usize as std::marker::Sync>, polarity:Positive), bound_vars: [] }
rustc_trait_selection::traits::normalize::normalize_with_depth_to depth=67, value=Binder { value: TraitPredicate(<std::alloc::Global as std::marker::Sync>, polarity:Positive), bound_vars: [] }
rustc_trait_selection::traits::normalize::normalize_with_depth_to depth=66, value=Binder { value: TraitPredicate(<std::marker::PhantomData<u8> as std::marker::Sync>, polarity:Positive), bound_vars: [] }
```
</p>
</details>
| A-trait-system,T-compiler,C-bug,I-hang,E-needs-mcve | low | Critical |
2,604,724,955 | godot | Parser bug when a script declaring a class has a reference to a scene with that class | ### Tested versions
Reproducible in 4.3 stable, 4.4 dev3
### System information
Godot v4.4.dev3 - Windows 10.0.19045 - Multi-window, 1 monitor - OpenGL 3 (Compatibility) - NVIDIA GeForce RTX 4070 Laptop GPU (NVIDIA; 32.0.15.5612) - 13th Gen Intel(R) Core(TM) i7-13620H (16 threads)
### Issue description
In a script which declares a class, having a reference to the scene of the class it declares causes a parser error in 4.4 dev3 and a run-time error (could not resolve class) in 4.3 stable.
### Steps to reproduce
For minimal reproduction project:
1: open project
2: click run project
3: you get either a parser error on 4.4 dev3 or a could not resolve class on 4.3 stable
### Minimal reproduction project (MRP)
[min reproducible bug - Copy.zip](https://github.com/user-attachments/files/17473006/min.reproducible.bug.-.Copy.zip) | bug,topic:gdscript | low | Critical |
2,604,734,034 | next.js | Calling revalidateTag() in an action causes the page to be rerendered even if it doesn't use the tag | ### Link to the code that reproduces this issue
https://codesandbox.io/p/devbox/n9sttx
### To Reproduce
The sandbox above will not work because I've hidden the api for security purposes, but If you have an api that does those 2 requests you can replicate the issue.
1. Click on the block/unblock button
### Current vs. Expected behavior
Following the steps you'll see the revalidateTag will work even though there is no tag associated with that request.
Based on the documentation, revalidateTag revalidates only a specific tag that you put as an argument, but in this case it's refetching the rsc even though the tag doesn't exist.
### Provide environment information
```bash
Operating System:
Platform: linux
Arch: x64
Version: #1 SMP PREEMPT_DYNAMIC Sun Aug 6 20:05:33 UTC 2023
Available memory (MB): 4102
Available CPU cores: 2
Binaries:
Node: 20.11.1
npm: 10.2.4
Yarn: 1.22.19
pnpm: 8.15.4
Relevant Packages:
next: 14.2.1 // An outdated version detected (latest is 15.0.0), upgrade is highly recommended!
eslint-config-next: 14.2.1
react: 18.2.0
react-dom: 18.2.0
typescript: 5.4.5
Next.js Config:
output: N/A
⚠ An outdated version detected (latest is 15.0.0), upgrade is highly recommended!
Please try the latest canary version (`npm install next@canary`) to confirm the issue still exists before creating a new issue.
Read more - https://nextjs.org/docs/messages/opening-an-issue
```
### Which area(s) are affected? (Select all that apply)
Not sure
### Which stage(s) are affected? (Select all that apply)
next dev (local), next start (local)
### Additional context
I tested this in a fresh next 15 setup and it acted the same.
Here's the discord issue link as well https://discord.com/channels/752553802359505017/1297903434808430612 | bug | low | Minor |
2,604,747,394 | PowerToys | Preview Pane Supports for LibreOffice - File Explorer add-ons | ### Description of the new feature / enhancement
I wish that PowerToys will extended to have Preview Pane Supports for LibreOffice (6x files extensions):
1. Text Document (*.docx)
2. Spreadsheet (*.ods)
3. Drawing (*.odg)
4. Presentation (.odp)
6. Formula (*.odf)
7. Database (*.odb)
NB: If Office is installed on the PC, File Explorer (Win 11) is able to preview 1 and 2
Many Thanks
### Scenario when this would be used?
LibreOffice is very popular and it will increase productivity to large number of users
### Supporting information
https://ask.libreoffice.org/t/how-can-i-activate-the-preview-feature-for-libre-office-writer/32113/2
ask.libreoffice.org/t/is-there-a-way-to-preview-a-libre-doc-or-spreadsheet-in-the-windows-explorer-preview-pane/16902 | Needs-Triage | low | Minor |
2,604,750,759 | pytorch | `torch.std_mean` returns `NaN` as mean of an `inf` array. | ### 🐛 Describe the bug
`torch.std_mean` returns `nan` when input is an array containing only `inf`. This behavior is not consistent with `torch.mean`.
```python
import numpy as np
import torch
input = torch.tensor([np.inf, np.inf], dtype=torch.float32)
out = torch.std_mean(input, None)
print(out[1]) # tensor(nan) actual, inf expected.
out = torch.mean(input)
print(out) # tensor(inf)
"""
torch.std_mean seems to return `inf` if the input array
contains also normal number.
"""
input = torch.tensor([1.0, np.inf], dtype=torch.float32)
out = torch.std_mean(input)
print(out[1]) # tensor(inf)
```
### Versions
```
Collecting environment information...
PyTorch version: 2.4.1+cu121
Is debug build: False
CUDA used to build PyTorch: 12.1
ROCM used to build PyTorch: N/A
OS: AlmaLinux 9.4 (Seafoam Ocelot) (x86_64)
GCC version: (GCC) 11.4.1 20231218 (Red Hat 11.4.1-3)
Clang version: 16.0.1 (https://github.com/llvm/llvm-project.git cd89023f797900e4492da58b7bed36f702120011)
CMake version: version 3.23.2
Libc version: glibc-2.34
Python version: 3.9.18 (main, Aug 23 2024, 00:00:00) [GCC 11.4.1 20231218 (Red Hat 11.4.1-3)] (64-bit runtime)
Python platform: Linux-5.14.0-427.37.1.el9_4.x86_64-x86_64-with-glibc2.34
Is CUDA available: True
CUDA runtime version: 11.2.67
CUDA_MODULE_LOADING set to: LAZY
GPU models and configuration:
GPU 0: NVIDIA GeForce RTX 2080 Ti
GPU 1: NVIDIA TITAN RTX
GPU 2: NVIDIA GeForce RTX 2080 Ti
Nvidia driver version: 555.42.02
cuDNN version: Could not collect
HIP runtime version: N/A
MIOpen runtime version: N/A
Is XNNPACK available: True
CPU:
Architecture: x86_64
CPU op-mode(s): 32-bit, 64-bit
Address sizes: 46 bits physical, 48 bits virtual
Byte Order: Little Endian
CPU(s): 36
On-line CPU(s) list: 0-35
Vendor ID: GenuineIntel
Model name: Intel(R) Core(TM) i9-10980XE CPU @ 3.00GHz
CPU family: 6
Model: 85
Thread(s) per core: 2
Core(s) per socket: 18
Socket(s): 1
Stepping: 7
CPU(s) scaling MHz: 92%
CPU max MHz: 4800.0000
CPU min MHz: 1200.0000
BogoMIPS: 6000.00
Flags: fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush dts acpi mmx fxsr sse sse2 ss ht tm pbe syscall nx pdpe1gb rdtscp lm constant_tsc art arch_perfmon pebs bts rep_good nopl xtopology nonstop_tsc cpuid aperfmperf pni pclmulqdq dtes64 monitor ds_cpl vmx est tm2 ssse3 sdbg fma cx16 xtpr pdcm pcid dca sse4_1 sse4_2 x2apic movbe popcnt tsc_deadline_timer aes xsave avx f16c rdrand lahf_lm abm 3dnowprefetch cpuid_fault epb cat_l3 cdp_l3 ssbd mba ibrs ibpb stibp ibrs_enhanced tpr_shadow flexpriority ept vpid ept_ad fsgsbase tsc_adjust bmi1 avx2 smep bmi2 erms invpcid cqm mpx rdt_a avx512f avx512dq rdseed adx smap clflushopt clwb intel_pt avx512cd avx512bw avx512vl xsaveopt xsavec xgetbv1 xsaves cqm_llc cqm_occup_llc cqm_mbm_total cqm_mbm_local dtherm ida arat pln pts hwp hwp_act_window hwp_epp hwp_pkg_req vnmi avx512_vnni md_clear flush_l1d arch_capabilities
Virtualization: VT-x
L1d cache: 576 KiB (18 instances)
L1i cache: 576 KiB (18 instances)
L2 cache: 18 MiB (18 instances)
L3 cache: 24.8 MiB (1 instance)
NUMA node(s): 1
NUMA node0 CPU(s): 0-35
Vulnerability Gather data sampling: Mitigation; Microcode
Vulnerability Itlb multihit: KVM: Mitigation: VMX disabled
Vulnerability L1tf: Not affected
Vulnerability Mds: Not affected
Vulnerability Meltdown: Not affected
Vulnerability Mmio stale data: Mitigation; Clear CPU buffers; SMT vulnerable
Vulnerability Retbleed: Mitigation; Enhanced IBRS
Vulnerability Spec rstack overflow: Not affected
Vulnerability Spec store bypass: Mitigation; Speculative Store Bypass disabled via prctl
Vulnerability Spectre v1: Mitigation; usercopy/swapgs barriers and __user pointer sanitization
Vulnerability Spectre v2: Mitigation; Enhanced / Automatic IBRS, IBPB conditional, RSB filling, PBRSB-eIBRS SW sequence
Vulnerability Srbds: Not affected
Vulnerability Tsx async abort: Mitigation; TSX disabled
Versions of relevant libraries:
[pip3] numpy==1.26.4
[pip3] optree==0.13.0
[pip3] torch==2.4.1
[pip3] triton==3.0.0
[conda] Could not collect
```
cc @albanD @jbschlosser | triaged,module: NaNs and Infs,module: python frontend | low | Critical |
2,604,862,885 | ui | [bug]: Sidebar icon size is not taken in consideration | ### Describe the bug
When I set the `size=lg` to the `<SidebarMenuButton>`component, only the spacing between rows is updated.
By default, Icons have a size of 16px. In my case, i'm looking for bigger icons like 20 or 24px.
The size=`lg`does not work as expected.
### Affected component/components
Sidebar
### How to reproduce
1. relay on the default icon size:
```
<SidebarMenuItem key={item.title}>
<SidebarMenuButton asChild>
<a href={item.url}>
<item.icon width="8" height="8" />
<span>{item.title}</span>
</a>
</SidebarMenuButton>
```
2. update the size of each SidebarMenuItem:
```
<SidebarMenuItem key={item.title}>
<SidebarMenuButton asChild size="lg">
<a href={item.url}>
<item.icon width="8" height="8" />
<span>{item.title}</span>
</a>
</SidebarMenuButton>
```
3. Analyse the difference
The icon size are the same
### Codesandbox/StackBlitz link
_No response_
### Logs
_No response_
### System Info
```bash
macOS 15.0.1
Latest Chrome
NextJS 14
latest Shadcn
```
### Before submitting
- [X] I've made research efforts and searched the documentation
- [X] I've searched for existing issues | bug | medium | Critical |
2,604,868,639 | excalidraw | Snapping when drawing a line to another existing line | > Is there an option to turn on snaping to existing lines (on ends) when I'm drawing another line? It seems there is only possibility for snapping when i draw 2 lines and then move one around. This would be huge for me to be able to snap to existing objects while drawing a new line.
https://github.com/excalidraw/excalidraw/discussions/8466 | enhancement | low | Minor |
2,604,903,503 | next.js | Custom not-found.js page is not rendering in i18n-app-dir | ### Verify canary release
- [X] I verified that the issue exists in the latest Next.js canary release
### Provide environment information
```bash
Node.js v20.14.0
Operating System:
Platform: linux
Arch: x64
Version: #132~20.04.1-Ubuntu SMP Fri Aug 30 15:50:07 UTC 2024
Available memory (MB): 15734
Available CPU cores: 12
Binaries:
Node: 20.14.0
npm: 10.7.0
Yarn: 1.22.22
pnpm: N/A
Relevant Packages:
next: 14.2.6 // An outdated version detected (latest is 15.0.0), upgrade is highly recommended!
eslint-config-next: N/A
react: 18.3.1
react-dom: 18.3.1
typescript: N/A
Next.js Config:
output: standalone
⚠ An outdated version detected (latest is 15.0.0), upgrade is highly recommended!
Please try the latest canary version (`npm install next@canary`) to confirm the issue still exists before creating a new issue.
Read more - https://nextjs.org/docs/messages/opening-an-issue
```
### Which example does this report relate to?
app-dir-i18n-routing
### What browser are you using? (if relevant)
_No response_
### How are you deploying your application? (if relevant)
_No response_
### Describe the Bug
When I create a custom not-found.js in [lang] folder and hit a non-existent page from browser I get a nextjs default 404 page and not my custom not-found.js page.
### Expected Behavior
I must be getting my custom not-found.js page.
### To Reproduce
Just create a not-found.js page in [lang] folder and hit a non-existent page from this example link: https://stackblitz.com/github/vercel/next.js/tree/canary/examples/app-dir-i18n-routing | examples | low | Critical |
2,604,917,344 | deno | "compile" permissions for FFI-related ops | As some testing has revealed, quite some overhead in the FFI ops go into checking the permissions and most specifically into function `borrow_mut` from GothamState.
Would it be possible to somehow "compile" permissions (either at runtime initialization or for `deno compile`), so that I can produce a more efficient runtime? | perf,permissions | low | Minor |
2,604,929,190 | excalidraw | Configure grid step | Converted from #8553.
I'm integrating Excalidraw into a browser-based application and want to change the default grid step to 1.
Here's my current configuration:
```
const options = {
langCode: 'ja-JP',
name: name,
initialData: {
libraryItems: library.libraryItems,
elements: [imageElement, ...elements],
files: files,
appState: {
...scene.appState,
...appStateDefault(),
currentItemFontFamily: 2,
gridSize: 20, // Controls the grid box size
},
},
};
```
I've tried adding 'gridStep: 1' to the appState to change it to a 1x1 grid, but the gridstep still defaults to a 5x5.
How can I correctly change the default grid step to 1x1 instead of the default 5x5? Which part of the code should I update to ensure this works? | bug | low | Minor |
2,604,949,726 | transformers | Initializing via AutoImageProcessor before AutoProcessor is imported causes `AttributeError` | ### System Info
- `transformers` version: 4.45.2
- Platform: Linux-4.18.0-513.18.1.el8_9.x86_64-x86_64-with-glibc2.28
- Python version: 3.10.4
- Huggingface_hub version: 0.24.5
- Safetensors version: 0.4.4
- Accelerate version: 0.33.0
- Accelerate config: not found
- PyTorch version (GPU?): 2.4.0+cu121 (False)
- Tensorflow version (GPU?): not installed (NA)
- Flax version (CPU?/GPU?/TPU?): not installed (NA)
- Jax version: not installed
- JaxLib version: not installed
- Using distributed or parallel set-up in script?: No
### Who can help?
Probably @zucchini-nlp @amyeroberts, and @qubvel
### Information
- [ ] The official example scripts
- [X] My own modified scripts
### Tasks
- [ ] An officially supported task in the `examples` folder (such as GLUE/SQuAD, ...)
- [ ] My own task or dataset (give details below)
### Reproduction
There seems to be an edge-case in the loading behavior that can sometimes be hit if something is initialized with `from_pretrained` through `AutoImageProcessor` before `AutoProcessor` is imported, and then `from_pretrained` is used on `AutoProcessor`.
Repro case - this works as expected
```python
model_name = "microsoft/Phi-3.5-vision-instruct"
from transformers import AutoImageProcessor
from transformers import AutoProcessor
AutoImageProcessor.from_pretrained(model_name, trust_remote_code=True)
AutoProcessor.from_pretrained(model_name, trust_remote_code=True)
```
But this breaks:
```python
model_name = "microsoft/Phi-3.5-vision-instruct"
from transformers import AutoImageProcessor
AutoImageProcessor.from_pretrained(model_name, trust_remote_code=True)
from transformers import AutoProcessor
AutoProcessor.from_pretrained(model_name, trust_remote_code=True)
```
with `AttributeError: module transformers has no attribute Phi3VImageProcessor`.
I've tried to reproduce this with a few other models, but haven't been able to yet. It is also probably worth noting that the `AutoProcessor` doesn't return the same class as `AutoImageProcessor` for this model, which might matter
### Expected behavior
`AutoImageProcessor` / `AutoProcessor ` `from_pretrained` should have the same behavior if possible, regardless of import and invocation order | WIP,bug | medium | Critical |
2,604,989,584 | excalidraw | Context Menu Placement Issues on Right and Bottom Edges when Embedding Excalidraw in a Modal | **Description:**
I’m trying to embed Excalidraw as a modal in my application, but I’ve encountered a couple of issues with the behavior of the context menu near the window edges:
1. **Right edge:**
When left-clicking near the right edge, the context menu should open towards the left, but it still opens towards the right, causing it to be hidden off-screen.
2. **Bottom edge:**
When left-clicking near the bottom edge, the menu generally opens correctly upwards, but in some spots, it opens downwards, which causes the window to scroll unnecessarily.
I’ve recorded a video demonstrating the behavior and created a CodeSandbox where the issue can be reproduced. I’ve also noticed that this occurs in Excalidraw’s own documentation.
**Additional resources:**
- https://github.com/user-attachments/assets/2adf5113-330f-42a5-8b7c-1f640136787c
- [codesandbox/modal](https://codesandbox.io/p/sandbox/cs6wch)
| bug | low | Minor |
2,605,053,575 | vscode | Tools declaration still supports `toolReferenceName` | When declaring a tool in package.json I can still define `toolReferenceName` which should
* not exist?
* be combined with the `canBeReferencedInPrompt` property | api,debt | low | Minor |
2,605,104,750 | next.js | Hot reload doesn't work inside Docker container | ### Link to the code that reproduces this issue
https://github.com/ArtoszBart/next-issue
### To Reproduce
1. `docker-compose up`
2. make change in page.tsx
3. save changes
### Current vs. Expected behavior
Hot reload should reload the page to show changes, but changes is not visible in the browser
### Provide environment information
```bash
Physical PC:
Operating System:
Platform: win32
Arch: x64
Version: Windows 10 Education
Available memory (MB): 16319
Available CPU cores: 16
Binaries:
Node: 20.18.0
npm: N/A
Yarn: N/A
pnpm: N/A
Relevant Packages:
next: 15.0.0 // Latest available version is detected (15.0.0).
eslint-config-next: 15.0.0
react: 19.0.0-rc-65a56d0e-20241020
react-dom: 19.0.0-rc-65a56d0e-20241020
typescript: 5.6.3
Next.js Config:
output: N/A
Container:
Operating System:
Platform: linux
Arch: x64
Version: #1 SMP Fri Mar 29 23:14:13 UTC 2024
Available memory (MB): 7911
Available CPU cores: 16
Binaries:
Node: 20.18.0
npm: 10.8.2
Yarn: 1.22.22
pnpm: N/A
Relevant Packages:
next: 15.0.0 // Latest available version is detected (15.0.0).
eslint-config-next: 15.0.0
react: 19.0.0-rc-65a56d0e-20241020
react-dom: 19.0.0-rc-65a56d0e-20241020
typescript: 5.6.3
Next.js Config:
output: N/A
```
### Which area(s) are affected? (Select all that apply)
Developer Experience
### Which stage(s) are affected? (Select all that apply)
next dev (local)
### Additional context
After saving changes in page.tsx on the PC, the .next/server/chunks/ssr on PC is updated same as page.tsx in container. However .next/server/chunks/ssr in container remains not updated. | bug | low | Major |
2,605,150,551 | next.js | Global `not-found` page interferes with static rendering | ### Link to the code that reproduces this issue
https://github.com/amannn/nextjs-bug-repro-not-found
### To Reproduce
1. Clone https://github.com/amannn/nextjs-bug-repro-not-found
2. Run `pnpm i`
3. Run `pnpm build`
### Current vs. Expected behavior
This commit outlines the issue: [f5cbf18](https://github.com/amannn/nextjs-bug-repro-not-found/commit/f5cbf185d225f921d9b87877c3305f04fcc97809)
The `not-found` page is dynamic, while `/` is expected to render statically. However, somehow the global not found page is rendered as part of `/`.
**Output:**
```
▲ Next.js 15.0.1-canary.1
Creating an optimized production build ...
warn - No utility classes were detected in your source files. If this is unexpected, double-check the `content` option in your Tailwind CSS configuration.
warn - https://tailwindcss.com/docs/content-configuration
✓ Compiled successfully
✓ Linting and checking validity of types
✓ Collecting page data
Generating static pages (0/4) [== ]
Error occurred prerendering page "/". Read more: https://nextjs.org/docs/messages/prerender-error
Error: Route / with `dynamic = "error"` couldn't be rendered statically because it used `headers`. See more info here: https://nextjs.org/docs/app/building-your-application/rendering/static-and-dynamic#dynamic-rendering
Export encountered an error on /page: /, exiting the build.
⨯ Static worker exited with code: 1 and signal: null
Generating static pages (1/4) [ ] ELIFECYCLE Command failed with exit code 1.
```
I'd expect the 404 page to be dynamic while the home page is static.
### Provide environment information
```bash
Operating System:
Platform: darwin
Arch: x64
Version: Darwin Kernel Version 23.6.0: Mon Jul 29 21:13:00 PDT 2024; root:xnu-10063.141.2~1/RELEASE_X86_64
Available memory (MB): 16384
Available CPU cores: 12
Binaries:
Node: 20.11.1
npm: 10.2.4
Yarn: 1.22.22
pnpm: 9.12.2
Relevant Packages:
next: 15.0.1-canary.1 // Latest available version is detected (15.0.1-canary.1).
eslint-config-next: 15.0.1-canary.1
react: 19.0.0-rc-69d4b800-20241021
react-dom: 19.0.0-rc-69d4b800-20241021
typescript: 5.6.3
Next.js Config:
output: N/A
```
### Which area(s) are affected? (Select all that apply)
Output (export/standalone), Runtime
### Which stage(s) are affected? (Select all that apply)
next build (local)
### Additional context
_No response_ | Output (export/standalone),Runtime,linear: next | low | Critical |
2,605,164,819 | PowerToys | PowerToys Failing on WMWare Win10 guest under Win10 host | ### Microsoft PowerToys version
0.85.1
### Installation method
Microsoft Store
### Running as admin
Yes
### Area(s) with issue?
General
### Steps to reproduce
Powertoys fails when using keyboard or mouse.
### ✔️ Expected Behavior
Use Keyboar or mouse in VM without Powertoys failing and restarting.
### ❌ Actual Behavior
Powertoys fails, restarts, hangs the machine for a while, rinse and repeat.
See attached error logs.
### Other Software
[PowerToysReport_2024-10-22-13-13-43.zip](https://github.com/user-attachments/files/17475292/PowerToysReport_2024-10-22-13-13-43.zip)
[PowerToysReport_2024-10-22-13-00-24.zip](https://github.com/user-attachments/files/17475291/PowerToysReport_2024-10-22-13-00-24.zip)
[PowerToysReport_2024-10-22-12-59-15.zip](https://github.com/user-attachments/files/17475293/PowerToysReport_2024-10-22-12-59-15.zip)
[PowerToysReport_2024-10-22-12-58-13.zip](https://github.com/user-attachments/files/17475294/PowerToysReport_2024-10-22-12-58-13.zip)
| Issue-Bug,Needs-Triage | low | Critical |
2,605,221,902 | angular | Same FormControl of a FromGroup use on Multiple Input and auto sync updated value. | ### Which @angular/* package(s) are relevant/related to the feature request?
forms
### Description
I want to use same from control of my angular formGroup on multiple input. and when i just change one of any input value it change all of input value of same formcontrol.
*CODE*
myForm!: FormGroup;
constructor(private fb: FormBuilder,
) { }
ngOnInit() {
this.myForm = this.fb.group({
sharedControl: ['', Validators.required] // Replace with your desired validation
});
}
<form [formGroup]="myForm">
<div class="form-group">
<label for="input1">Input 1:</label>
<input type="text" class="form-control" id="input1" formControlName="sharedControl">
</div>
<div class="form-group">
<label for="input2">Input 2:</label>
<input type="text" class="form-control" id="input2" formControlName="sharedControl">
</div>
<button type="submit" [disabled]="myForm.invalid">Submit</button>
</form>
here when i change of input1 value input2 value need to be also change on show on UI. it auto sync.
### Proposed solution
Patch all of same control value same.
### Alternatives considered
.. | feature,area: forms,P3 | low | Minor |
2,605,266,258 | tauri | [feat] Need to use multiple invoke_handlers | ### Describe the problem
Only one invoke_handler will take effect. How do I want to be able to register other regular functions directly while using a customized invoke_handler?
```rust
#[cfg_attr(mobile, tauri::mobile_entry_point)]
pub fn run() {
tauri::Builder::default()
.plugin(tauri_plugin_shell::init())
// First
.invoke_handler(my_invoke_handler)
// Second
.invoke_handler(tauri::generate_handler![greet, println])
.run(tauri::generate_context!())
.expect("error while running tauri application");
}
```
### Describe the solution you'd like
Need to use multiple invoke_handlers
### Additional context
Version: tauri 2.0 | type: feature request | low | Critical |
2,605,294,664 | excalidraw | Pasting multiple paragraphs creates overflowing text | **Repro steps**
- Copy some larger text, like the one below
- Paste into the editor
**Actual result**
Pasted text elements overflow each other.
```
Building Excalidraw's P2P Collaboration Feature
March 29, 2020, by [idlewinn](https://twitter.com/edwinlin1987)
The problem was that Excalidraw was built to be a fundamentally single-player experience. However, we ([@idlewinn](https://twitter.com/edwinlin1987) and [@floydophone](https://twitter.com/floydophone)) were able to quickly add basic multiplayer support over a long weekend, and are continuing to make improvements to it every day.
The requirements
We wanted to be able to use this in our day jobs. In order to do that, it had to support [end-to-end encryption](https://blog.excalidraw.com/end-to-end-encryption/).
We did not want to store anything server-side. Therefore, we opted for a pseudo-P2P model, where a central server relays end-to-end encrypted messages to all the peers in the room, but does no centralized coordination.
Excalidraw’s single-player architecture
Originally, Excalidraw kept an array of all the different drawn shapes — called ExcalidrawElements — in Z-index order. The ExcalidrawElement interface looked something like this:
interface ExcalidrawElement {
id: string;
type: "square" | "circle" | "arrow";
width: number;
height: number;
// ... other fields describing the shape ...
canvas: HTMLCanvasElement;
isSelected: boolean;
}
This architecture was very easy to use client-side, but as we’ll see, presented some challenges as we moved to multiplayer.
Moving to multiplayer
We actually had two parallel multiplayer implementations. One was built on top of [Firebase](https://firebase.com/), the other on top of [Socket.io](https://socket.io/). We ended up going with Socket.io, but both implementations developed the same set of bugs, and the mitigations we applied in one branch were easily ported to the other.
Conceptually, we want to share the array of ExcalidrawElements amongst multiple players. The first step was to refactor ExcalidrawElement to remove any state specific to a single player. This meant pulling out canvas and isSelected properties and storing them in a different data structure, as an HTMLCanvasElement can’t be shared over the network, and every player will have a different selection state. Once we had these properties moved out, we started sharing the ExcalidrawElement array between peers.
``` | bug | low | Critical |
2,605,303,605 | excalidraw | Lazy load font face definitions for our fallback fonts | For fallback fonts like Xiaolai, our font face definitions are > 100 kB.
Given it might not be used at all, we might consider lazy loading it. | performance ⚡️,font | low | Minor |
2,605,340,198 | next.js | Next.js fails to find/load native node modules compiled as a separate package in a (pnpm) workspace | ### Link to the code that reproduces this issue
https://github.com/daanboer/next-load-native-module
### To Reproduce
Install dependencies.
```bash
pnpm i
```
Build the `rust-lib` package (needs a working rust installation).
```bash
pnpm -C packages/rust-lib build
```
Try to build the `web-app` package.
```bash
pnpm -C packages/web-app build
```
### Current vs. Expected behavior
I expect the `greet` function from the `rust-lib` package to be imported and called. Instead the `web-app` build process throws the following error: `[cause]: Error: Cannot find module '../rust-lib/dist/index.node'`.
<details>
<summary>Full build logs</summary>
```
> web-app@0.1.0 build /home/daan/git/next-load-native-module/packages/web-app
> next build
▲ Next.js 15.0.0
Creating an optimized production build ...
✓ Compiled successfully
✓ Linting and checking validity of types
Collecting page data .Error: Failed to collect configuration for /
at /home/daan/git/next-load-native-module/node_modules/.pnpm/next@15.0.0_react-dom@19.0.0-rc-65a56d0e-20241020_react@19.0.0-rc-65a56d0e-20241020__react@19.0.0-rc-65a56d0e-20241020/node_modules/next/dist/build/utils.js:1130:23
at process.processTicksAndRejections (node:internal/process/task_queues:105:5)
at async Span.traceAsyncFn (/home/daan/git/next-load-native-module/node_modules/.pnpm/next@15.0.0_react-dom@19.0.0-rc-65a56d0e-20241020_react@19.0.0-rc-65a56d0e-20241020__react@19.0.0-rc-65a56d0e-20241020/node_modules/next/dist/trace/trace.js:157:20) {
[cause]: Error: Cannot find module '../rust-lib/dist/index.node'
Require stack:
- /home/daan/git/next-load-native-module/packages/web-app/.next/server/app/page.js
- /home/daan/git/next-load-native-module/node_modules/.pnpm/next@15.0.0_react-dom@19.0.0-rc-65a56d0e-20241020_react@19.0.0-rc-65a56d0e-20241020__react@19.0.0-rc-65a56d0e-20241020/node_modules/next/dist/server/require.js
- /home/daan/git/next-load-native-module/node_modules/.pnpm/next@15.0.0_react-dom@19.0.0-rc-65a56d0e-20241020_react@19.0.0-rc-65a56d0e-20241020__react@19.0.0-rc-65a56d0e-20241020/node_modules/next/dist/server/load-components.js
- /home/daan/git/next-load-native-module/node_modules/.pnpm/next@15.0.0_react-dom@19.0.0-rc-65a56d0e-20241020_react@19.0.0-rc-65a56d0e-20241020__react@19.0.0-rc-65a56d0e-20241020/node_modules/next/dist/build/utils.js
- /home/daan/git/next-load-native-module/node_modules/.pnpm/next@15.0.0_react-dom@19.0.0-rc-65a56d0e-20241020_react@19.0.0-rc-65a56d0e-20241020__react@19.0.0-rc-65a56d0e-20241020/node_modules/next/dist/build/worker.js
- /home/daan/git/next-load-native-module/node_modules/.pnpm/next@15.0.0_react-dom@19.0.0-rc-65a56d0e-20241020_react@19.0.0-rc-65a56d0e-20241020__react@19.0.0-rc-65a56d0e-20241020/node_modules/next/dist/compiled/jest-worker/processChild.js
at Module._resolveFilename (node:internal/modules/cjs/loader:1248:15)
at /home/daan/git/next-load-native-module/node_modules/.pnpm/next@15.0.0_react-dom@19.0.0-rc-65a56d0e-20241020_react@19.0.0-rc-65a56d0e-20241020__react@19.0.0-rc-65a56d0e-20241020/node_modules/next/dist/server/require-hook.js:55:36
at Module._load (node:internal/modules/cjs/loader:1074:27)
at TracingChannel.traceSync (node:diagnostics_channel:315:14)
at wrapModuleLoad (node:internal/modules/cjs/loader:217:24)
at Module.require (node:internal/modules/cjs/loader:1339:12)
at mod.require (/home/daan/git/next-load-native-module/node_modules/.pnpm/next@15.0.0_react-dom@19.0.0-rc-65a56d0e-20241020_react@19.0.0-rc-65a56d0e-20241020__react@19.0.0-rc-65a56d0e-20241020/node_modules/next/dist/server/require-hook.js:65:28)
at require (node:internal/modules/helpers:135:16)
at 7215 (/home/daan/git/next-load-native-module/packages/web-app/.next/server/app/page.js:1:31238)
at t (/home/daan/git/next-load-native-module/packages/web-app/.next/server/webpack-runtime.js:1:127) {
code: 'MODULE_NOT_FOUND',
requireStack: [
'/home/daan/git/next-load-native-module/packages/web-app/.next/server/app/page.js',
'/home/daan/git/next-load-native-module/node_modules/.pnpm/next@15.0.0_react-dom@19.0.0-rc-65a56d0e-20241020_react@19.0.0-rc-65a56d0e-20241020__react@19.0.0-rc-65a56d0e-20241020/node_modules/next/dist/server/require.js',
'/home/daan/git/next-load-native-module/node_modules/.pnpm/next@15.0.0_react-dom@19.0.0-rc-65a56d0e-20241020_react@19.0.0-rc-65a56d0e-20241020__react@19.0.0-rc-65a56d0e-20241020/node_modules/next/dist/server/load-components.js',
'/home/daan/git/next-load-native-module/node_modules/.pnpm/next@15.0.0_react-dom@19.0.0-rc-65a56d0e-20241020_react@19.0.0-rc-65a56d0e-20241020__react@19.0.0-rc-65a56d0e-20241020/node_modules/next/dist/build/utils.js',
'/home/daan/git/next-load-native-module/node_modules/.pnpm/next@15.0.0_react-dom@19.0.0-rc-65a56d0e-20241020_react@19.0.0-rc-65a56d0e-20241020__react@19.0.0-rc-65a56d0e-20241020/node_modules/next/dist/build/worker.js',
'/home/daan/git/next-load-native-module/node_modules/.pnpm/next@15.0.0_react-dom@19.0.0-rc-65a56d0e-20241020_react@19.0.0-rc-65a56d0e-20241020__react@19.0.0-rc-65a56d0e-20241020/node_modules/next/dist/compiled/jest-worker/processChild.js'
]
}
}
> Build error occurred
Error: Failed to collect page data for /
at /home/daan/git/next-load-native-module/node_modules/.pnpm/next@15.0.0_react-dom@19.0.0-rc-65a56d0e-20241020_react@19.0.0-rc-65a56d0e-20241020__react@19.0.0-rc-65a56d0e-20241020/node_modules/next/dist/build/utils.js:1233:15
at process.processTicksAndRejections (node:internal/process/task_queues:105:5) {
type: 'Error'
}
Collecting page data . ELIFECYCLE Command failed with exit code 1.
```
</details>
### Provide environment information
```bash
Operating System:
Platform: linux
Arch: x64
Version: #1-NixOS SMP PREEMPT_DYNAMIC Thu Aug 29 15:33:59 UTC 2024
Available memory (MB): 31938
Available CPU cores: 20
Binaries:
Node: 22.8.0
npm: N/A
Yarn: N/A
pnpm: 9.10.0
Relevant Packages:
next: 15.0.0 // Latest available version is detected (15.0.0).
eslint-config-next: N/A
react: 18.3.1
react-dom: 18.3.1
typescript: 5.6.2
Next.js Config:
output: N/A
```
### Which area(s) are affected? (Select all that apply)
Not sure
### Which stage(s) are affected? (Select all that apply)
next dev (local), next build (local)
### Additional context
The same setup compiles when using Next.js `v14.2.13` for `web-app`. It seems that the bug is introduced in `v14.2.14`. | bug | low | Critical |
2,605,341,300 | vscode | [Linux] Open file or Open folder creates dialog behind active window | <!-- ⚠️⚠️ Do Not Delete This! bug_report_template ⚠️⚠️ -->
<!-- Please read our Rules of Conduct: https://opensource.microsoft.com/codeofconduct/ -->
<!-- 🕮 Read our guide about submitting issues: https://github.com/microsoft/vscode/wiki/Submitting-Bugs-and-Suggestions -->
<!-- 🔎 Search existing issues to avoid creating duplicates. -->
<!-- 🧪 Test using the latest Insiders build to see if your issue has already been fixed: https://code.visualstudio.com/insiders/ -->
<!-- 💡 Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. -->
<!-- 🔧 Launch with `code --disable-extensions` to check. -->
Does this issue occur when all extensions are disabled?: Yes/No
<!-- 🪓 If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. -->
<!-- 📣 Issues caused by an extension need to be reported directly to the extension publisher. The 'Help > Report Issue' dialog can assist with this. -->
- VS Code Version:
- OS Version:
Steps to Reproduce:
menu -> File -> Open File
same as issue #146422
system details:
Version: 1.81.1
Commit: 6c3e3dba23e8fadc360aed75ce363ba185c49794
Date: 2023-08-09T22:18:39.991Z
Electron: 22.3.18
ElectronBuildId: 22689846
Chromium: 108.0.5359.215
Node.js: 16.17.1
V8: 10.8.168.25-electron.0
OS: Linux x64 6.8.0-47-generic
| info-needed | low | Critical |
2,605,349,279 | ui | [feat]: Will it be possible in the future to have Unocss compatibility instead of Tailwind? | ### Feature description
Will it be possible in the future to have Unocss compatibility instead of Tailwind?
Unocss has better performance and optimization compared to Tailwind, and its writing style is similar to Tailwind. Simply understand that Unocss is a superset of Tailwind. After using Unocss, I have never used Tailwind CSS again.
If it is compatible with Unocss, it will be the best component library.
https://unocss.dev/
### Affected component/components
_No response_
### Additional Context
Additional details here...
### Before submitting
- [X] I've made research efforts and searched the documentation
- [X] I've searched for existing issues and PRs | area: request | low | Major |
2,605,364,525 | deno | authentication within @kubernetes/client-node is not working as expected | Version: Deno 2.0.1
i tried to use the library: @kubernetes/client-node with deno and i wasnt able to authenticate with the provided examples here:
[@kubernetes/client-node](https://github.com/kubernetes-client/javascript/blob/master/README.md)
i switched back with the same code and configs to nodejs and it was working as expected
| bug,node compat | low | Minor |
2,605,408,927 | material-ui | [Radio] Radio's `ButtonBase` has `role="button"` when using styled-components | ### Steps to reproduce
Link to live example: https://codesandbox.io/p/devbox/nervous-oskar-xx7s2l
Steps:
1. Use mui together with styled-components (i.e. aliasing `@mui/styled-engine` with `@mui/styled-engine-sc`)
2. Use a `<Radio />` component
### Current behavior
The radio's ButtonBase has a `role="button"`. This leads to an accessibility violation since there is a radio inside of a button.
The HTML basically looks like this:
```html
<span
class="MuiButtonBase-root MuiRadio-root [...]"
role="button">
<input class="sc-egkSDF jccrsl PrivateSwitchBase-input" type="radio">
<span class="sc-fAUdSK cyWAma">
<svg>[...]</svg>
</span>
<span class="MuiTouchRipple-root-hfoSaC iZusHU MuiTouchRipple-root"></span>
</span>
```
Note that there is a `role="button"` on the outermost `<span>`. This should not be there and is in fact not there if you use the "regular" emotion adapter for `@mui/styled-engine`.
### Expected behavior
There is no `role="button"` on the `ButtonBase` for a `<Radio />`.
### Context
I think the problem is that `<SwitchBase />` passes `role={undefined}` to the `<SwitchBaseRoot />` (which is a styled `<ButtonBase />`) here: https://github.com/mui/material-ui/blob/master/packages/mui-material/src/internal/SwitchBase.js#L177
And I guess that styled-components just swallows properties with `undefined` values (since version 6?).
It used to work with mui v5 and styled-components v5.
This bug also affects other components that use `<SwitchBase />` (like `<Checkbox />` or `<Switch />`).
### Your environment
<details>
<summary><code>npx @mui/envinfo</code></summary>
```
System:
OS: Linux 6.1 Debian GNU/Linux 11 (bullseye) 11 (bullseye)
Binaries:
Node: 20.11.0 - /usr/local/bin/node
npm: 10.2.4 - /usr/local/bin/npm
pnpm: 8.15.1 - /usr/local/share/npm-global/bin/pnpm
Browsers:
Chrome: Not Found
npmPackages:
@mui/core-downloads-tracker: 6.1.5
@mui/envinfo: 2.0.28 => 2.0.28
@mui/material: ^6.1.5 => 6.1.5
@mui/private-theming: 6.1.5
@mui/styled-engine: 6.1.5
@mui/styled-engine-sc: ^6.1.5 => 6.1.5
@mui/system: 6.1.5
@mui/types: 7.2.18
@mui/utils: 6.1.5
@types/react: 18.3.11 => 18.3.11
react: 18.3.1 => 18.3.1
react-dom: 18.3.1 => 18.3.1
styled-components: ^6.1.13 => 6.1.13
```
</details>
**Search keywords**: radio styled-components button | external dependency,component: radio,component: ButtonBase,package: styled-engine-sc | low | Critical |
2,605,479,529 | vscode | Let's consider to use a concrete type for `toolInvocationToken` | I have seen @isidorn pass a cancellation token as `toolInvocationToken` when calling `invoke`. I guess this is because of "looks like a token must be a token" thinking. We could rename the field or (my favourite) use a concrete type (class with private ctor) for this so that using a cancellation token or anything else yields a compile error | feature-request,api | low | Critical |
2,605,499,085 | PowerToys | Outlook LOG preview error: This file cannot be previewed because there is no previewer installed for it | ### Microsoft PowerToys version
0.85.1
### Installation method
Microsoft Store
### Running as admin
No
### Area(s) with issue?
File Explorer: Preview Pane, File Explorer: Thumbnail preview
### Steps to reproduce
1. Open regedit
2. Navigate to [HKEY_CLASSES_ROOT\.txt\shellex\
3. If the key {8895b1c6-b41f-4c1c-a562-0d564250836f} exist, delete it
4. Open Notepad/Editor and create an text file with the ending .txt
5. Copy the the file and change the extension to .log
6. Open Microsoft Outlook
7. Create a new E-Mail to yourself, attach both the .txt and .log file and send it to yourself
8. Open the E-Mail and click on the attachment, to display the preview of both files
9. Do you confirm that for both files the preview is displayed?
10. Open Microsoft Store
11. Search for PowerToys
12. Install [PowerToys](https://apps.microsoft.com/store/detail/XP89DCGQ3K6VLD?ocid=pdpshare)
13. PowerToys starts automatic after installation
14. In regedit hit the F5 key to refresh
15. The key {8895b1c6-b41f-4c1c-a562-0d564250836f} has been created
16. In Outlook display the preview of both files
17. Do you confirm that only the .txt file is displayed?
18. In regedit delete the key {8895b1c6-b41f-4c1c-a562-0d564250836f}
19. Open the E-Mail and click on the attachment, to display the preview of both files
20. Do you confirm that for both files the preview is displayed?
### ✔️ Expected Behavior
Either Microsoft PowerToys should not create the registry key:
`[HKEY_CLASSES_ROOT\.txt\shellex\{8895b1c6-b41f-4c1c-a562-0d564250836f}]`
Or Outlook should be able to display the preview of these files, too.
With the actual behavior I have either preview in File Explorer or in Outlook, except for .txt.
### ❌ Actual Behavior
After installing/updating Microsoft PowerToys (and starting it), it creates the registry key:
`[HKEY_CLASSES_ROOT\.txt\shellex\{8895b1c6-b41f-4c1c-a562-0d564250836f}]`
```
Windows Registry Editor Version 5.00
[HKEY_CLASSES_ROOT\.log]
@="txtfilelegacy"
"Content Type"="text/plain"
"PerceivedType"="text"
[HKEY_CLASSES_ROOT\.log\OpenWithProgids]
"AppX4ztfk9wxr86nxmzzq47px0nh0e58b8fw"=hex(0):
[HKEY_CLASSES_ROOT\.log\shellex]
[HKEY_CLASSES_ROOT\.log\shellex\{8895b1c6-b41f-4c1c-a562-0d564250836f}]
@="{D8034CFA-F34B-41FE-AD45-62FCBB52A6DA}"
```
This has the side effect, that Microsoft Outlook (365) no longer shows the Preview for attached .log files. Instead it shows the Error:
`This file cannot be previewed because there is no previewer installed for it. `
After deleting the key, Outlook show the Preview of .log files:
```
Windows Registry Editor Version 5.00
[HKEY_CLASSES_ROOT\.log]
@="txtfilelegacy"
"Content Type"="text/plain"
"PerceivedType"="text"
[HKEY_CLASSES_ROOT\.log\OpenWithProgids]
"AppX4ztfk9wxr86nxmzzq47px0nh0e58b8fw"=hex(0):
[HKEY_CLASSES_ROOT\.log\shellex]
```
### Other Software
_No response_
### Additional Information
#### 1.
On [How to Register a Preview Handler - Win32 apps | Microsoft Learn](https://learn.microsoft.com/en-us/windows/win32/shell/how-to-register-a-preview-handler) I can read the following under **Step 1:**
> Each preview handler ProgID subkey contains a subkey named shellex that contains a subkey always named {8895b1c6-b41f-4c1c-a562-0d564250836f}. The presence of that subkey tells the system that the handler is a preview handler.
#### 2.
On [Outlook PDF preview error: This file cannot be previewed because there is no previewer installed for it - Microsoft Support](https://support.microsoft.com/en-us/office/outlook-pdf-preview-error-this-file-cannot-be-previewed-because-there-is-no-previewer-installed-for-it-b78bfe24-ba13-44bd-8289-1919ece7ded2) I can read under **Issue 2:**
> [Microsoft PowerToys](https://docs.microsoft.com/windows/powertoys/?msclkid=92c6173aa63411ecbceeb3798168ad87) is installed and has overridden the PDF Preview setting.
> From the Windows Start Menu, search for PowerToys App and open it. Select File Explorer Add-ons and disable Enable PDF (.pdf) preview.
I checked this setting and `Enable PDF (.pdf) preview` is disabled, now and after installation.
#### 3.
I searched the registry for `{D8034CFA-F34B-41FE-AD45-62FCBB52A6DA}` and found the following key:
```
Windows Registry Editor Version 5.00
[HKEY_CLASSES_ROOT\CLSID\{D8034CFA-F34B-41FE-AD45-62FCBB52A6DA}]
"DisplayName"="Monaco Preview Handler"
@="MonacoPreviewHandler"
"AppID"="{6d2b5079-2f0b-48dd-ab7f-97cec514d30b}"
[HKEY_CLASSES_ROOT\CLSID\{D8034CFA-F34B-41FE-AD45-62FCBB52A6DA}\InprocServer32]
@="C:\\Users\\blueicehaller\\AppData\\Local\\PowerToys\\PowerToys.MonacoPreviewHandlerCpp.dll"
"Assembly"="PowerToys.MonacoPreviewHandler, Version=v0.85.1.0, Culture=neutral"
"Class"="MonacoPreviewHandler"
"ThreadingModel"="Apartment"
```
When I disable under [File Explorer add-ons](https://learn.microsoft.com/en-us/windows/powertoys/file-explorer) the [Preview Pane](https://learn.microsoft.com/en-us/windows/powertoys/file-explorer#preview-pane-previewers) for [Source code files (Monaco)](https://learn.microsoft.com/en-us/windows/powertoys/file-explorer#settings-for-source-code-files-previewer), it deletes the key:
```
[HKEY_CLASSES_ROOT\.log\shellex\{8895b1c6-b41f-4c1c-a562-0d564250836f}]
@="{D8034CFA-F34B-41FE-AD45-62FCBB52A6DA}
```
It deletes further keys for source code files like .txt:
```
[HKEY_CLASSES_ROOT\.txt\shellex\{8895b1c6-b41f-4c1c-a562-0d564250836f}]
@="{D8034CFA-F34B-41FE-AD45-62FCBB52A6DA}"
``` | Issue-Bug,Needs-Triage | low | Critical |
2,605,521,470 | godot | Tree dropdown buttons disappear when Base Spacing is low | ### Tested versions
4.3 stable
### System information
Godot v4.3.stable - Windows 10.0.19045 - GLES3 (Compatibility) - Radeon RX 560 Series (Advanced Micro Devices, Inc.; 31.0.14001.45012) - Intel(R) Core(TM) i5-4570 CPU @ 3.20GHz (4 Threads)
### Issue description
If you change the Base Spacing value to <2 in the editor settings in the Theme section, the buttons that open the Tree on the left side disappear. This does not happen with the right side.
Base Spacing = 4
Base Spacing = 0
### Steps to reproduce
1. Open the editor settings and go to the Theme section
2. change the Base Spacing value to 0 or 1
### Minimal reproduction project (MRP)
N/A | bug,topic:gui | low | Minor |
2,605,534,805 | ant-design | Add a prop for disabling click propagation for the Popover / Tooltip when the trigger is "click" | ### What problem does this feature solve?
Currently whenever a Popover component is opened using `trigger="click"`, a user can click outside of the popover component to close the component. However, some users don't consider the fact that if they click outside of the popover component it might trigger the event for the element they did click on. For example if a Popover component is rendered inside of a Modal. Clicking on the outside mask of the modal while the popover is open, will close both the Popover and the modal.
See this in action on this [codesandbox](https://codesandbox.io/p/sandbox/antd-reproduction-template-forked-w7k5lj)
### What does the proposed API look like?
Preferably I would like to have a prop for the Tooltip / Popover component that would stop the propagation of this event like
```ts
stopOutsideClickPropagation: boolean
```
Else adding in the clickEvent to the `onOpenChange` function like:
```ts
(open: boolean, event: React.MouseEvent<HTMLElement>) => void
```
<!-- generated by ant-design-issue-helper. DO NOT REMOVE --> | Inactive | low | Minor |
2,605,536,619 | yt-dlp | [SharePoint] Video downloaded is actually an HTML file (access denied) | ### DO NOT REMOVE OR SKIP THE ISSUE TEMPLATE
- [X] I understand that I will be **blocked** if I *intentionally* remove or skip any mandatory\* field
### Checklist
- [X] I'm reporting that yt-dlp is broken on a **supported** site
- [X] I've verified that I have **updated yt-dlp to nightly or master** ([update instructions](https://github.com/yt-dlp/yt-dlp#update-channels))
- [X] I've checked that all provided URLs are playable in a browser with the same IP and same login details
- [X] I've checked that all URLs and arguments with special characters are [properly quoted or escaped](https://github.com/yt-dlp/yt-dlp/wiki/FAQ#video-url-contains-an-ampersand--and-im-getting-some-strange-output-1-2839-or-v-is-not-recognized-as-an-internal-or-external-command)
- [X] I've searched [known issues](https://github.com/yt-dlp/yt-dlp/issues/3766) and the [bugtracker](https://github.com/yt-dlp/yt-dlp/issues?q=) for similar issues **including closed ones**. DO NOT post duplicates
- [X] I've read the [guidelines for opening an issue](https://github.com/yt-dlp/yt-dlp/blob/master/CONTRIBUTING.md#opening-an-issue)
- [ ] I've read about [sharing account credentials](https://github.com/yt-dlp/yt-dlp/blob/master/CONTRIBUTING.md#are-you-willing-to-share-account-details-if-needed) and I'm willing to share it if required
### Region
France
### Provide a description that is worded well enough to be understood
I am trying to download a video that was shared with me on SharePoint. Unfortunately, the downloaded video is not a video, but rather an HTML document "access denied"
I can give the URL, but unfortunately, it's a private video with a required login.
### Provide verbose output that clearly demonstrates the problem
- [X] Run **your** yt-dlp command with **-vU** flag added (`yt-dlp -vU <your command line>`)
- [ ] If using API, add `'verbose': True` to `YoutubeDL` params instead
- [X] Copy the WHOLE output (starting with `[debug] Command-line config`) and insert it below
### Complete Verbose Output
```shell
[debug] Command-line config: ['-vU', "https://temtsp-my.sharepoint.com/personal/xxxxxxxxxxx/_layouts/15/stream.aspx?id=%2Fpersonal%2Fxxxxxxxxxxx%2FDocuments%2FEnregistrements%2FRéunion d'Information des Maîtres d'apprentissage-20241016_142513-Enregistrement de la réunion.mp4&nav=eyJyZWZlcnJhbEluZm8iOnsicmVmZXJyYWxBcHAiOiJTdHJlYW1XZWJBcHAiLCJyZWZlcnJhbFZpZXciOiJTaGFyZURpYWxvZy1MaW5rIiwicmVmZXJyYWxBcHBQbGF0Zm9ybSI6IldlYiIsInJlZmVycmFsTW9kZSI6InZpZXcifX0%3D&referrer=StreamWebApp.Web&referrerScenario=AddressBarCopied.view.7b0e8398-6bce-4863-a523-66d35fc3ebbb", '--cookies', '/Users/arthur/Downloads/cookies.txt', '--user-agent', 'Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:132.0) Gecko/20100101 Firefox/132.0']
[debug] Encodings: locale UTF-8, fs utf-8, pref UTF-8, out utf-8, error utf-8, screen utf-8
[debug] yt-dlp version stable@2024.10.22 from yt-dlp/yt-dlp [67adeb7ba] (pip)
[debug] Python 3.12.5 (CPython arm64 64bit) - macOS-14.7-arm64-arm-64bit (OpenSSL 3.3.2 3 Sep 2024)
[debug] exe versions: ffmpeg 7.1 (setts), ffprobe 7.1, rtmpdump 2.4
[debug] Optional libraries: Cryptodome-3.20.0, brotli-1.1.0, certifi-2024.08.30, mutagen-1.47.0, requests-2.32.3, sqlite3-3.43.2, urllib3-2.2.2, websockets-13.1
[debug] Proxy map: {}
[debug] Request Handlers: urllib, requests, websockets
[debug] Loaded 1839 extractors
[debug] Fetching release info: https://api.github.com/repos/yt-dlp/yt-dlp/releases/latest
Latest version: stable@2024.10.22 from yt-dlp/yt-dlp
yt-dlp is up to date (stable@2024.10.22 from yt-dlp/yt-dlp)
[SharePoint] Extracting URL: https://temtsp-my.sharepoint.com/personal/xxxxxxxxxxx/_layouts/15/stream.aspx?id=%2Fpersonal%2Fxxxxxxxxxxx%2FDocuments%2FEnregistrements%2FRéunion d'Information des Maîtres d'apprentissage-20241016_142513-Enregistrement de la réunion.mp4&nav=eyJyZWZlcnJhbEluZm8iOnsicmVmZXJyYWxBcHAiOiJTdHJlYW1XZWJBcHAiLCJyZWZlcnJhbFZpZXciOiJTaGFyZURpYWxvZy1MaW5rIiwicmVmZXJyYWxBcHBQbGF0Zm9ybSI6IldlYiIsInJlZmVycmFsTW9kZSI6InZpZXcifX0%3D&referrer=StreamWebApp.Web&referrerScenario=AddressBarCopied.view.7b0e8398-6bce-4863-a523-66d35fc3ebbb
[SharePoint] /personal/xxxxxxxxxxx/Documents/Enregistrements/Réunion d'Information des Maîtres d'apprentissage-20241016_142513-Enregistrement de la réunion.mp4: Downloading webpage
[SharePoint] 01S7Q3B7XLKIJCSSMR2ZF2X2MIRMVM67WJ: Downloading MPD manifest
[SharePoint] 01S7Q3B7XLKIJCSSMR2ZF2X2MIRMVM67WJ: Downloading m3u8 information
[SharePoint] 01S7Q3B7XLKIJCSSMR2ZF2X2MIRMVM67WJ: Downloading m3u8 information
[debug] Formats sorted by: hasvid, ie_pref, lang, quality, res, fps, hdr:12(7), vcodec:vp9.2(10), channels, acodec, size, br, asr, proto, vext, aext, hasaud, source, id
[debug] Default format spec: bestvideo*+bestaudio/best
[info] 01S7Q3B7XLKIJCSSMR2ZF2X2MIRMVM67WJ: Downloading 1 format(s): source
[debug] Invoking http downloader on "https://temtsp-my.sharepoint.com/personal/xxxxxxxxxxx/_layouts/15/download.aspx?UniqueId=291252eb-9149-4bd6-abe9-888b2acf7ec9&Translate=false&tempauth=v1.eyJzaXRlaWQiOiJhODU4MWNjNy1iZmY3LTRmN2ItOGY0ZC04NGJmNGFhMDE3OWEiLCJhdWQiOiIwMDAwMDAwMy0wMDAwLTBmZjEtY2UwMC0wMDAwMDAwMDAwMDAvdGVtdHNwLW15LnNoYXJlcG9pbnQuY29tQDJiMWJlMjE1LTVjZjEtNDNkZS04YmM3LTk0NmJkZjU3ZjljZCIsImV4cCI6IjE3Mjk2MDg3NTkifQ.CgoKBHNuaWQSAjQzEgsI6vqgt9qquT0QBRoPMTU3LjE1OS4xMzcuMTEzIhRtaWNyb3NvZnQuc2hhcmVwb2ludCosWVg4cnFBc2lyMWU1MThXNkhWNFRZVVlxVFEwNlYzalJuUVU1bnVRVGMrYz0wpQE4AUIQoVxq0icwAKA9HnGL6ASjWEoQaGFzaGVkcHJvb2Z0b2tlblIIWyJrbXNpIl1iBHRydWVqJDI4NTQzNTRhLTM1N2EtNGYwYi04MjY5LTU1ZDJjNzcyOTg2NXIpMGguZnxtZW1iZXJzaGlwfDEwMDMyMDAwZmQ2OGVhY2JAbGl2ZS5jb216ATDCATEwIy5mfG1lbWJlcnNoaXB8YXJ0aHVyLmpvdmFydEB0ZWxlY29tLXN1ZHBhcmlzLmV1yAEB.rN_6Z_KRbAPSR_sgyAglUf3bjB0Y5CZUWutIW_Ci0CI"
[download] Destination: Réunion d'Information des Maîtres d'apprentissage [01S7Q3B7XLKIJCSSMR2ZF2X2MIRMVM67WJ].mp4
[download] 100% of 258.32KiB in 00:00:00 at 666.03KiB/s
```
| incomplete,site-bug,triage | low | Critical |
2,605,545,464 | transformers | speed up whisper compile time | ### Feature request
after torch compiling the whisper.text_decoder model, the inference time is crazy low !. Thank you for the work !
however the warm up time is very long since it needs to go through all logits (at a maximum of 448)
how can reduce this time ?
(i have looked into storing the compiled model with pytorch but it does not seem supported)
(i have tried compiling torch_tensorrt but i have the error EncoderDecoderCache encountered in the dynamo_compile input parsing)
### Motivation
the start up time of the model can take around 10m for a large model
### Your contribution
happy to do a pr but need guidance | Feature request | low | Critical |
2,605,606,811 | ui | [bug]: The CSS variable `--sidebar-width-mobile` is not being used | ### Describe the bug
The documentations says:
<img width="746" alt="Screenshot 2024-10-22 at 11 15 54" src="https://github.com/user-attachments/assets/ea089b2e-8599-470c-bb41-c692281b011b">
Link: https://ui.shadcn.com/docs/components/sidebar#width
But the CSS variable `--sidebar-width-mobile` is not being used anywhere in the code. So, changing it doesn't cause any effects.
### Affected component/components
Sidebar
### How to reproduce
Try to do this and see if the sidebar changed its width in mobile:
```
<SidebarProvider
style={{
"--sidebar-width": "20rem",
"--sidebar-width-mobile": "2rem", // Very small sidebar
}}
>
<Sidebar />
</SidebarProvider>
```
### Codesandbox/StackBlitz link
_No response_
### Logs
_No response_
### System Info
```bash
macOS Sonoma 14.5 (23F79)
Arc Browser Version 1.65.0 (54911)
```
### Before submitting
- [X] I've made research efforts and searched the documentation
- [X] I've searched for existing issues | bug | low | Critical |
2,605,608,993 | create-react-app | error that occur in vs code that i cann't run program: |
PS C:\Users\Hp\Documents\New react project> npm start
npm error Missing script: "start"
npm error
npm error Did you mean one of these?
npm error npm star # Mark your favorite packages
npm error npm stars # View packages marked as favorites
npm error
npm error To see a list of scripts, run:
npm error npm run
npm error A complete log of this run can be found in: C:\Users\Hp\AppData\Local\npm-cache\_logs\2024-10-22T14_14_21_973Z-debug-0.log
| needs triage,issue: bug report | low | Critical |
2,605,641,268 | rustdesk | Privacy Mode 1: Failed to get hwnd after started | ### Bug Description
On some of our devices running Windows 10, we cannot enable Privacy Mode 1 (the gray screen one), as it fails with one of the following errors:
- "No privacy window created"
- "Failed to get hwnd after started"
Unclear if there are any error logs that we can provide.
Also, we're using RustDesk Server Pro.
### How to Reproduce
1. Connect to a device running Windows 10
1. Enable Privacy Mode 1
### Expected Behavior
Privacy Mode is enabled successfully and hides the sensitive tasks we have to perform.
### Operating system(s) on local side and remote side
Windows 11 -> Windows 10
### RustDesk Version(s) on local side and remote side
1.3.1 -> 1.3.1 (Custom Client)
### Screenshots
### Additional Context
We can consistently reproduce this issue on some machines running Windows 10, but not all.
Is there any hardware / windows version requirements for using Privacy Mode?
<!-- POLAR PLEDGE BADGE START -->
## Upvote & Fund
- We're using [Polar.sh](https://polar.sh/rustdesk) so you can upvote and help fund this issue.
- We receive the funding once the issue is completed & confirmed by you.
- Thank you in advance for helping prioritize & fund our backlog.
<a href="https://polar.sh/rustdesk/rustdesk/issues/9720">
<picture>
<source media="(prefers-color-scheme: dark)" srcset="https://polar.sh/api/github/rustdesk/rustdesk/issues/9720/pledge.svg?darkmode=1">
<img alt="Fund with Polar" src="https://polar.sh/api/github/rustdesk/rustdesk/issues/9720/pledge.svg">
</picture>
</a>
<!-- POLAR PLEDGE BADGE END -->
| bug,Fund | medium | Critical |
2,605,644,738 | stable-diffusion-webui | [Feature Request]: folder subpath in config rather than command line for reverse proxy | ### Is there an existing issue for this?
- [X] I have searched the existing issues and checked the recent builds/commits
### What would your feature do ?
It would be nice if you could configure a subpath in the config for reverse proxy, even if it required a restart for the underlying engine.
I use a docker host (adbarho) and it would be nice if this didn't require command line overrides.
Something like the following:
### Proposed workflow
1. Go to settings
2. Press configure 'reverse proxy'
3. enter details
### Additional information
_No response_ | enhancement | low | Minor |
2,605,650,994 | TypeScript | Mixin with abstract class infers wrong type for super | ### 🔎 Search Terms
"mixin abstract super", "mixin abstract super type", "mixin abstract constructor super", "mixin abstract constructor super type", "mixin Abstract method cannot be accessed via super expression"
### 🕗 Version & Regression Information
- This is the behavior in every version I tried, and I reviewed the FAQ for entries about "super"
### ⏯ Playground Link
https://www.typescriptlang.org/play/?ts=5.7.0-dev.20241022#code/IYIwzgLgTsDGEAJYBthjAgsgTwILmjggGFV0EBvAKAQQAcBXEZAS1gVEhngQHMBTCADlgAW34AKAJQAuBFxYA7XgG4qAXypUAZg0XwWAe0UJRLAB5KA6iwgALfFyKk0YADwAVAEJp+CfuYQ-IoAJhiK-ADuCBIAdPHAULxgcsCK2ADaALpSCAC8AHxYeATcJGRgBRIA+iC+ct6+udQ0SBVYFkou5AFBoRi1vpRatLSMzGx8giLi0nIKysOjo1CCDFAmYAx0-FCxAsJiklIqCAD0ZwgAolBQhlByAESOhDzi9oYhCADkBzP83wQSjarh+OBeZW6YEBsDSikMiBAfjgsH46H4XwAbixgPJtrt-OY6Kt0EZFLFHq1aJpqSMEKsIOsTJhOoooWpNFoqEoglBtHA-DgAJKKXn81FLKaHWayeTQJSqDRaXT6CBk0ysmz2EVigWeHxgPy9YJhBARaJxBJJFIcdLZXKFYo63bi-hVQaGhoG-jNOkoUEsyxs9rG-oID1+FrLcasdh-I5zOVQBWS5YMpl4nZ7eMy04XBCRe4AazAVIQNPLdPTGw6QfZGiAA
### 💻 Code
```ts
abstract class MyAbstractClass {
public abstract getName(): string;
}
function mixinWithAbstractClass<TBase extends new (...args: any[]) => MyAbstractClass>(_base: TBase) {
class MixinClass extends _base {
public getName(): string {
return super.getName(); // Error: "Abstract method 'getName' in class 'MyAbstractClass' cannot be accessed via super expression."
}
}
return MixinClass;
}
interface MyInterface {
getName(): string;
}
function mixinWithInterface<TBase extends new (...args: any[]) => MyInterface>(_base: TBase) {
class MixinClass extends _base {
public getName(): string {
return super.getName(); // works as expected
}
}
return MixinClass;
}
```
### 🙁 Actual behavior
`mixinWithAbstractClass` fails because the compiler infers that `super` is of the exact type `class MyAbstractClass`.
### 🙂 Expected behavior
I expected `mixinWithAbstractClass` to compile like `mixinWithInterface` does. The constraint `TBase extends new (...args: any[]) => MyAbstractClass` specifies that `TBase` extends a concrete constructor, which returns instances that conform to `MyAbstractClass`. Since the constructor is concrete, we can infer that `TBase` (the superclass) already implements the abstract methods.
### Additional information about the issue
_No response_ | Bug,Help Wanted | low | Critical |
2,605,703,409 | angular | @angular/elements uses (internal) property name for custom element properties, but template name for attributes | ## Angular edit
Angular elements defines (`Object.defineProperty`) a property for each input of an element's component, as well as an HTML attribute which feeds into each property. Each input is thus represented by a property/attribute pair, as in the real DOM.
However, the way we name these things differs. `createCustomElement` uses the template name of the input for the attribute API, but the property name of the input for the DOM/property API. This was likely done intentionally as it makes _some_ sense - property name for properties - but it doesn't consider that the property name is meant to be an implementation detail of a component and shouldn't end up on its public API.
Fixing this would be a breaking change.
## Original Issue
When declaring an input with alias inside of a component and use `createCustomElement` of that component.
ex.
```
readonly name = input<string>(
'name',
{ alias: 'customName' },
);
```
On the actual web-component there are no such attribute as `customName`, only `name` will exist and work.
Looks like that `ComponentFactory` at method `resolveComponentFactory` which returns `inputs` array with `propName` of each input is not actually aliased name.
https://github.com/angular/angular/blob/main/packages/elements/src/component-factory-strategy.ts#L46 | area: elements,P3,bug,cross-cutting: signals | low | Major |
2,605,725,286 | pytorch | Diffusers import change breaking newly built (non-cached) test-infra dockers. | > NOTE: Remember to label this issue with "`ci: sev`"
<!-- uncomment the below line if you don't want this SEV to block merges -->
<!-- **MERGE BLOCKING** -->
## Current Status
*Status could be: preemptive, ongoing, mitigated, closed. Also tell people if they need to take action to fix it (i.e. rebase)*.
* When trying to update dockers, diffusers inductor tests start breaking due to an import change between diffusers and hf hub. I can't figure out where diffusers / hf_hub versions are pinned.
## Error looks like
*Provide some way users can tell that this SEV is causing their issue.*
* Building new dockers / updating docker-ci requirements seem to cause stable diffustion tests to start failing
```
from huggingface_hub import HfFolder, cached_download, hf_hub_download, model_info
ImportError: cannot import name 'cached_download' from 'huggingface_hub' (/opt/conda/envs/py_3.10/lib/python3.10/site-packages/huggingface_hub/__init__.py)
```
## Incident timeline (all times pacific)
*Include when the incident began, when it was detected, mitigated, root caused, and finally closed.*
* Atleast since yesterday
## User impact
*How does this affect users of PyTorch CI?*
* Can't update docker requirements without breaking tests
## Root cause
*What was the root cause of this issue?*
* Import change from diffusers _ hf_hub
## Mitigation
*How did we mitigate the issue?*
* Better pin dependencies for inductor tests perhaps? Discovered in upgrade here: https://github.com/pytorch/pytorch/pull/133814
## Prevention/followups
*How do we prevent issues like this in the future?*
cc @seemethere @malfet @osalpekar @atalman @pytorch/pytorch-dev-infra | module: ci,triaged,module: docker | low | Critical |
2,605,725,303 | godot | `EditorUndoRedoManager`: Inconsistent `add_do_property` behavior | ### Tested versions
Reproducible in:
- v4.4.dev.gh [b3bcb2dc1]
- v4.3.stable.official [77dcf97d8]
- v4.0.stable.official [92bee43ad]
### System information
Windows 10.0.22631 - Vulkan (Forward+) - dedicated NVIDIA GeForce GTX 980 Ti (NVIDIA; 32.0.15.6094) - 13th Gen Intel(R) Core(TM) i7-13700K (24 Threads)
### Issue description
Modifying a source `Array` or other collection when using `EditorUndoRedoManager.add_do_property` causes inconsistent redo behaviour, even when deep copy duplicates are used. Specifically, the modification to the source collection is sometimes applied during redo actions instead of the value that is provided to the `add_do_property` function.
I have tested to find that this inconsistent behaviour happens with `Array`, `Array[int]`, `Array[String]`, `PackedInt64Array`, and `PackedStringArray`. It may affect other collections types.
I have not tested with the `UndoRedo` class, but it's possible this reproduces with that class as well.
### Steps to reproduce
``` GDScript
# Example property:
var my_array: Array
var my_array_prop: Array:
get:
return my_array
set(value):
my_array = value
# Example of problematic redo behaviour:
var old_array: Array = my_array.duplicate(true) # deep or not doesn't matter
var new_array: Array = my_array.duplicate(true) # deep or not doesn't matter
new_array[0] = 42
my_array[0] = 99 # This line causes inconsistent redo behaviour
undo_redo.create_action("Action: Set array to " + str(new_array[0]))
undo_redo.add_do_property(self, &"my_array_prop", new_array)
undo_redo.add_undo_property(self, &"my_array_prop", old_array)
undo_redo.commit_action()
```
If the problematic line that modifies the source array is removed, undo and redo behaviour works fine. When this line is added as shown above, performing the redo action will sometimes apply the value that was assigned to `my_array` instead of the value of `new_array` provided to the `add_do_property` function.
### Minimal reproduction project (MRP)
[undo-redo-bug-mrp.zip](https://github.com/user-attachments/files/17478063/undo-redo-bug-mrp.zip)
The following `EditorPlugin` demonstrates the inconsistency:
``` GDScript
@tool
extends EditorPlugin
var my_int: int
var my_int_prop: int:
get:
print("getting int: " + JSON.stringify(my_int))
return my_int
set(value):
my_int = value
print("setting int: " + JSON.stringify(my_int))
var my_array: Array
var my_array_prop: Array:
get:
print("getting array: " + JSON.stringify(my_array))
return my_array
set(value):
my_array = value
print("setting array: " + JSON.stringify(my_array))
static var count: int = 0
func _enter_tree() -> void:
my_int = 0
my_array.push_back(0)
add_tool_menu_item("Undo Redo Test: Commit Action", test)
func _exit_tree() -> void:
remove_tool_menu_item("Undo Redo Test: Commit Action")
func test() -> void:
for i in range(3):
count += 1
var undo_redo: EditorUndoRedoManager = get_undo_redo()
var old_int: int = my_int
var new_int: int = count
my_int = count + 10
undo_redo.create_action("Action: Set int to " + str(new_int))
undo_redo.add_do_property(self, &"my_int_prop", new_int)
undo_redo.add_undo_property(self, &"my_int_prop", old_int)
undo_redo.commit_action()
var old_array: Array = my_array.duplicate(true) # deep or not doesn't matter
var new_array: Array = my_array.duplicate(true) # deep or not doesn't matter
new_array[0] = count
my_array[0] = count + 10 # This line causes inconsistent redo behaviour
undo_redo.create_action("Action: Set array to " + str(new_array[0]))
undo_redo.add_do_property(self, &"my_array_prop", new_array)
undo_redo.add_undo_property(self, &"my_array_prop", old_array)
undo_redo.commit_action()
```
After running the tool, then undoing and redoing all actions, the console shows the following (I've added arrows to highlight the inconsistency):
```
Action: Set int to 1
Action: Set array to 1
Action: Set int to 2
Action: Set array to 2
Action: Set int to 3
Action: Set array to 3
setting int: 1
setting array: [1]
setting int: 2
setting array: [2]
setting int: 3
setting array: [3]
Global Undo: Action: Set array to 3
setting array: [2]
Global Undo: Action: Set int to 3
setting int: 2
Global Undo: Action: Set array to 2
setting array: [1]
Global Undo: Action: Set int to 2
setting int: 1
Global Undo: Action: Set array to 1
setting array: [0]
Global Undo: Action: Set int to 1
setting int: 0
Global Redo: Action: Set int to 1
setting int: 1
Global Redo: Action: Set array to 1
setting array: [12] <-------------------
Global Redo: Action: Set int to 2
setting int: 2
Global Redo: Action: Set array to 2
setting array: [13] <-------------------
Global Redo: Action: Set int to 3
setting int: 3
Global Redo: Action: Set array to 3
setting array: [3]
``` | bug,topic:editor,needs testing | low | Critical |
2,605,732,529 | svelte | docs: FAQ section "does svelte scale" is outdated | ### Describe the bug
The svelte docs section "FAQ" has the same "[Does svelte scale](https://svelte.dev/docs/svelte/faq#Does-Svelte-scale)" section as the version for svelte 4 has. But, as mentioned in #2546 , this is no longer up to date with svelte 5.
### Severity
annoyance | documentation | low | Critical |
2,605,743,452 | angular | Allow reactive values for the disabled state of FormControls | ### Which @angular/* package(s) are relevant/related to the feature request?
forms
### Description
When initializing new FormControls, we currently can only pass a value and an optional disabled state.
However, when the disabled state depends on other reactive flows, we need to manually implement a change listener, like this:
```typescript
someControl = new FormControl({ value: '', disabled: false });
constructor() {
this.shouldBeDisabled$.pipe(takeUntilDestroyed()).subscribe((disabled) => {
if(disabled){
this.someControl.disable();
}else{
this.someControl.enable();
}
});
}
```
While this approach is valid, it feels a bit clunky nowadays—especially with the introduction of newer reactive concepts like signals.
It would feel more intuitive if the disabled state could also accept a signal or observable of type `boolean`, allowing it to automatically re-evaluate whenever the value changes. While I'm unsure if observables would be as intuitive in this context, I believe using signals would be much more readable.
For example, we could write something like this:
```typescript
someControl = new FormControl({ value: '', disabled: toSignal(this.shouldBeDisabled$) });
```
This approach would also synergize well with template-driven forms, where we can already pass a signal to the disabled state of a form control. Having the same capability in reactive forms would create a more consistent developer experience for both form implementation approaches, template-driven and reactive.
### Proposed solution
allow disabled property to accept signals and/or observables
### Alternatives considered
Manually subscriptions | feature,area: forms,forms: disabling controls | low | Minor |
2,605,762,859 | flutter | TwoDimensionalScrollView caches only when scrolling down | ### Steps to reproduce
1. Run the provided sample
2. Scroll up and down with repaint borders enabled
3. Experience the bug
### Expected results
When scrolling upwards on a TwoDimensionalScrolView, the specific elements shouldn't be repainted, if they are cached (what should be the case for a small amount of grids).
### Actual results
The widgets are rebuild when scrolling up, even if they should be cached (according to the cache extent). Strangely, this does not occur while scrolling down, the widgets aren't rebuild as expected.
### Code sample
<details open><summary>Code sample</summary>
```dart
import 'dart:math' as math;
import 'package:flutter/foundation.dart';
import 'package:flutter/gestures.dart';
import 'package:flutter/material.dart';
import 'package:flutter/rendering.dart';
void main() => runApp(const MyApp());
class MyApp extends StatelessWidget {
const MyApp({super.key});
@override
Widget build(BuildContext context) {
return MaterialApp(
title: 'Flutter Demo',
theme: ThemeData(
colorScheme: ColorScheme.fromSeed(seedColor: Colors.deepPurple),
useMaterial3: true,
),
debugShowCheckedModeBanner: false,
home: const MyHomePage(title: 'Flutter Demo Home Page'),
);
}
}
class MyHomePage extends StatefulWidget {
final String title;
const MyHomePage({
super.key,
required this.title,
});
@override
State<MyHomePage> createState() => _MyHomePageState();
}
class _MyHomePageState extends State<MyHomePage> {
final ScrollController _horizontalController = ScrollController();
final ScrollController _verticalController = ScrollController();
final ValueNotifier<bool> _viewLockedListenable = ValueNotifier(false);
@override
Widget build(BuildContext context) {
return Scaffold(
appBar: AppBar(
title: Text(widget.title),
actions: [
IconButton(
icon: ValueListenableBuilder(
valueListenable: _viewLockedListenable,
builder: (context, locked, _) {
return Icon(
locked ? Icons.lock_outline_rounded : Icons.lock_open_rounded,
);
}),
onPressed: () => _viewLockedListenable.value = !_viewLockedListenable.value,
)
],
),
body: Scrollbar(
controller: _verticalController,
child: Scrollbar(
controller: _horizontalController,
child: ValueListenableBuilder(
valueListenable: _viewLockedListenable,
builder: (BuildContext context, bool locked, _) {
return ScrollConfiguration(
behavior: const MaterialScrollBehavior().copyWith(
dragDevices: locked ? {} : PointerDeviceKind.values.toSet(),
),
child: TwoDimensionalGridView(
horizontalDetails: ScrollableDetails.horizontal(
controller: _horizontalController,
),
verticalDetails: ScrollableDetails.vertical(
controller: _verticalController,
),
diagonalDragBehavior: locked ? DiagonalDragBehavior.none : DiagonalDragBehavior.free,
delegate: TwoDimensionalChildBuilderDelegate(
maxXIndex: 9,
maxYIndex: 9,
builder: (BuildContext context, ChildVicinity vicinity) {
return Container(
color: vicinity.xIndex.isEven && vicinity.yIndex.isEven
? Colors.blueGrey[200]
: (vicinity.xIndex.isOdd && vicinity.yIndex.isOdd ? Colors.purple[200] : Colors.blueGrey[200]),
height: 200,
width: 200,
child: Center(
child: Text(
'Row ${vicinity.yIndex}: Column ${vicinity.xIndex}',
),
),
);
},
),
),
);
},
),
),
),
);
}
}
class TwoDimensionalGridView extends TwoDimensionalScrollView {
const TwoDimensionalGridView({
super.key,
super.primary,
super.mainAxis = Axis.vertical,
super.verticalDetails = const ScrollableDetails.vertical(),
super.horizontalDetails = const ScrollableDetails.horizontal(),
required TwoDimensionalChildBuilderDelegate delegate,
super.cacheExtent,
super.diagonalDragBehavior = DiagonalDragBehavior.none,
super.dragStartBehavior = DragStartBehavior.start,
super.keyboardDismissBehavior = ScrollViewKeyboardDismissBehavior.manual,
super.clipBehavior = Clip.hardEdge,
}) : super(delegate: delegate);
@override
Widget buildViewport(
BuildContext context,
ViewportOffset verticalOffset,
ViewportOffset horizontalOffset,
) {
return TwoDimensionalGridViewport(
horizontalOffset: horizontalOffset,
horizontalAxisDirection: horizontalDetails.direction,
verticalOffset: verticalOffset,
verticalAxisDirection: verticalDetails.direction,
mainAxis: mainAxis,
delegate: delegate as TwoDimensionalChildBuilderDelegate,
cacheExtent: cacheExtent,
clipBehavior: clipBehavior,
);
}
}
class TwoDimensionalGridViewport extends TwoDimensionalViewport {
const TwoDimensionalGridViewport({
super.key,
required super.verticalOffset,
required super.verticalAxisDirection,
required super.horizontalOffset,
required super.horizontalAxisDirection,
required TwoDimensionalChildBuilderDelegate super.delegate,
required super.mainAxis,
super.cacheExtent,
super.clipBehavior = Clip.hardEdge,
});
@override
RenderTwoDimensionalViewport createRenderObject(BuildContext context) {
return RenderTwoDimensionalGridViewport(
horizontalOffset: horizontalOffset,
horizontalAxisDirection: horizontalAxisDirection,
verticalOffset: verticalOffset,
verticalAxisDirection: verticalAxisDirection,
mainAxis: mainAxis,
delegate: delegate as TwoDimensionalChildBuilderDelegate,
childManager: context as TwoDimensionalChildManager,
cacheExtent: cacheExtent,
clipBehavior: clipBehavior,
);
}
@override
void updateRenderObject(
BuildContext context,
RenderTwoDimensionalGridViewport renderObject,
) {
renderObject
..horizontalOffset = horizontalOffset
..horizontalAxisDirection = horizontalAxisDirection
..verticalOffset = verticalOffset
..verticalAxisDirection = verticalAxisDirection
..mainAxis = mainAxis
..delegate = delegate
..cacheExtent = cacheExtent
..clipBehavior = clipBehavior;
}
}
class RenderTwoDimensionalGridViewport extends RenderTwoDimensionalViewport {
RenderTwoDimensionalGridViewport({
required super.horizontalOffset,
required super.horizontalAxisDirection,
required super.verticalOffset,
required super.verticalAxisDirection,
required TwoDimensionalChildBuilderDelegate delegate,
required super.mainAxis,
required super.childManager,
super.cacheExtent,
super.clipBehavior = Clip.hardEdge,
}) : super(delegate: delegate);
@override
void layoutChildSequence() {
final double horizontalPixels = horizontalOffset.pixels;
final double verticalPixels = verticalOffset.pixels;
final double viewportWidth = viewportDimension.width + cacheExtent;
final double viewportHeight = viewportDimension.height + cacheExtent;
final TwoDimensionalChildBuilderDelegate builderDelegate = delegate as TwoDimensionalChildBuilderDelegate;
final int maxRowIndex = builderDelegate.maxYIndex!;
final int maxColumnIndex = builderDelegate.maxXIndex!;
final int leadingColumn = math.max((horizontalPixels / 200).floor(), 0);
final int leadingRow = math.max((verticalPixels / 200).floor(), 0);
final int trailingColumn = math.min(
((horizontalPixels + viewportWidth) / 200).ceil(),
maxColumnIndex,
);
final int trailingRow = math.min(
((verticalPixels + viewportHeight) / 200).ceil(),
maxRowIndex,
);
double xLayoutOffset = (leadingColumn * 200) - horizontalOffset.pixels;
for (int column = leadingColumn; column <= trailingColumn; column++) {
double yLayoutOffset = (leadingRow * 200) - verticalOffset.pixels;
for (int row = leadingRow; row <= trailingRow; row++) {
final ChildVicinity vicinity = ChildVicinity(xIndex: column, yIndex: row);
final RenderBox child = buildOrObtainChildFor(vicinity)!;
child.layout(constraints.loosen());
parentDataOf(child).layoutOffset = Offset(xLayoutOffset, yLayoutOffset);
yLayoutOffset += 200;
}
xLayoutOffset += 200;
}
final double verticalExtent = 200 * (maxRowIndex + 1);
verticalOffset.applyContentDimensions(
0.0,
clampDouble(verticalExtent - viewportDimension.height, 0.0, double.infinity),
);
final double horizontalExtent = 200 * (maxColumnIndex + 1);
horizontalOffset.applyContentDimensions(
0.0,
clampDouble(horizontalExtent - viewportDimension.width, 0.0, double.infinity),
);
}
}
```
</details>
### Screenshots or Video
<details open>
<summary>Screenshots / Video demonstration</summary>
https://github.com/user-attachments/assets/04003416-5f9d-4ef6-a9ea-ca915782a922
</details>
### Logs
_No response_
### Flutter Doctor output
<details open><summary>Doctor output</summary>
```console
[✓] Flutter (Channel stable, 3.24.3, on Fedora Linux 41 (Workstation Edition) 6.11.4-300.fc41.x86_64, locale de_DE.UTF-8)
• Flutter version 3.24.3 on channel stable at ~/.local/share/flutter
• Upstream repository https://github.com/flutter/flutter.git
• Framework revision 2663184aa7 (6 weeks ago), 2024-09-11 16:27:48 -0500
• Engine revision 36335019a8
• Dart version 3.5.3
• DevTools version 2.37.3
[✓] Android toolchain - develop for Android devices (Android SDK version 33.0.2)
• Android SDK at ~/.local/share/android-sdk
• Platform android-34, build-tools 33.0.2
• ANDROID_HOME = ~/.local/share/android-sdk/
• Java binary at: /usr/bin/java
• Java version OpenJDK Runtime Environment (Red_Hat-17.0.12.0.7-2) (build 17.0.12+7)
• All Android licenses accepted.
[✗] Chrome - develop for the web (Cannot find Chrome executable at google-chrome)
! Cannot find Chrome. Try setting CHROME_EXECUTABLE to a Chrome executable.
[✓] Linux toolchain - develop for Linux desktop
• clang version 19.1.0 (Fedora 19.1.0-1.fc41)
• cmake version 3.28.3
• ninja version 1.12.1
• pkg-config version 2.3.0
[!] Android Studio (not installed)
• Android Studio not found; download from https://developer.android.com/studio/index.html
(or visit https://flutter.dev/to/linux-android-setup for detailed instructions).
[✓] Connected device (1 available)
• Linux (desktop) • linux • linux-x64 • Fedora Linux 41 (Workstation Edition) 6.11.4-300.fc41.x86_64
[✓] Network resources
• All expected network resources are available.
! Doctor found issues in 2 categories.
```
</details>
| framework,f: scrolling,has reproducible steps,P2,team-framework,triaged-framework,found in release: 3.24,found in release: 3.27 | low | Critical |
2,605,773,587 | TypeScript | JSDoc `@import` no longer works correctly with default exports | ### 🔎 Search Terms
jsdoc import @import
### 🕗 Version & Regression Information
This changed between versions 5.5.4 and 5.6.3.
### ⏯ Playground Link
_No response_
### 💻 Code
```js
/** @import Foo from "my-app/foo" */
/** @return {Foo} */
function getFoo() {
return myFoo;
}
```
`tsconfig.json` excerpt:
```json
{
"compilerOptions": {
"baseUrl": ".",
"paths": {
"my-app/*": ["src/*"]
}
}
}
```
### 🙁 Actual behavior
In TypeScript 5.5 the above worked correctly with `getFoo` returning `Foo`. As of TypeScript 5.6 this now returns an `any`. This workaround resolves the problem but feels like it is not what is intended.
```js
/** @import { default as Foo } from "my-app/foo" */
/** @return {Foo} */
function getFoo() {
return myFoo;
}
```
### 🙂 Expected behavior
I expected default exports to work with `@import` in JSDoc.
### Additional information about the issue
_No response_ | Needs More Info,Needs Investigation | low | Minor |
2,605,831,866 | TypeScript | Type discrimination by static readonly symbol | ### 🔍 Search Terms
"type discrimination", "discrimination", "symbol discriminator"
### ✅ Viability Checklist
- [x] This wouldn't be a breaking change in existing TypeScript/JavaScript code
- [x] This wouldn't change the runtime behavior of existing JavaScript code
- [x] This could be implemented without emitting different JS based on the types of the expressions
- [x] This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, new syntax sugar for JS, etc.)
- [x] This isn't a request to add a new utility type: https://github.com/microsoft/TypeScript/wiki/No-New-Utility-Types
- [x] This feature would agree with the rest of our Design Goals: https://github.com/Microsoft/TypeScript/wiki/TypeScript-Design-Goals
### ⭐ Suggestion
AFAIK it is impossible to discriminate types by a static symbol like this:
```ts
class Animal {
public static readonly symbol = Symbol()
}
if (obj[Animal.symbol] === something) {
// here types are not deduced correctly
}
```
In contrast, code like this works fine:
```ts
const animal_symbol = Symbol()
if (obj[animal_symbol] === something) {
// here types are not deduced correctly
}
```
Not sure if this is a bug or just not implemented due to some complications.
### 📃 Motivating Example
By using `unique symbol` in a class I can discriminate objects like this:
```ts
class Cat {
public static readonly symbol = Symbol(`Cat.symbol`)
public get symbol() : typeof Cat.symbol {
return Cat.symbol
}
public meow() {}
}
class Dog {
public static readonly symbol = Symbol(`Dog.symbol`)
public get symbol() : typeof Dog.symbol {
return Dog.symbol
}
public woof() {}
}
type AnimalUnion = Cat | Dog
function take_animal(animal : AnimalUnion) {
if (animal.symbol === Cat.symbol) animal.meow()
else if (animal.symbol === Dog.symbol) animal.woof()
else assert_never(animal, new Error)
}
function assert_never(never : never, error : Error) : never {
throw error
}
```
The main focus here is inside `take_animal`: we can know that `animal` has `meow()` method if `animal.symbol === Cat.symbol`.
In this particular case I used `symbol` key to store the symbol. But what if key is also a symbol?
Like this:
```ts
const animal_symbol = Symbol(`Animal.symbol`)
class Cat {
public static readonly [animal_symbol] = Symbol(`Cat.symbol`)
public get [animal_symbol]() : typeof Cat[typeof animal_symbol] {
return Cat[animal_symbol]
}
public meow() {}
}
class Dog {
public static readonly [animal_symbol] = Symbol(`Dog.symbol`)
public get [animal_symbol]() : typeof Dog[typeof animal_symbol] {
return Dog[animal_symbol]
}
public woof() {}
}
type AnimalUnion = Cat | Dog
function take_animal(animal : AnimalUnion) {
if (animal[animal_symbol] === Cat[animal_symbol]) animal.meow()
else if (animal[animal_symbol] === Dog[animal_symbol]) animal.woof()
else assert_never(animal, new Error)
}
function assert_never(never : never, error : Error) : never {
throw error
}
```
This example works fine and guarantee no name collisions between string key `symbol` and possible field in derived class.
But for some reason if I try to put `animal_symbol` in a `static readonly` property;
```ts
class Animal {
public static readonly symbol = Symbol(`Animal.symbol`)
}
class Cat {
public static readonly [Animal.symbol] = Symbol(`Cat.symbol`)
public get [Animal.symbol]() : typeof Cat[typeof Animal.symbol] {
return Cat[Animal.symbol]
}
public meow() {}
}
class Dog {
public static readonly [Animal.symbol] = Symbol(`Dog.symbol`)
public get [Animal.symbol]() : typeof Dog[typeof Animal.symbol] {
return Dog[Animal.symbol]
}
public woof() {}
}
type AnimalUnion = Cat | Dog
function take_animal(animal : AnimalUnion) {
if (animal[Animal.symbol] === Cat[Animal.symbol]) animal.meow()
else if (animal[Animal.symbol] === Dog[Animal.symbol]) animal.woof()
else assert_never(animal, new Error)
}
function assert_never(never : never, error : Error) : never {
throw error
}
```
The trick doesn't work anymore. Now `take_animal()` can't deduce `meow()` from `animal[Animal.symbol] === Cat[Animal.symbol]`.
But I think it should.
### 💻 Use Cases
1. What do you want to use this for?
I want to use this to introduce segregation not by string key, but by a symbol key stored as `static readonly`.
3. What shortcomings exist with current approaches?
It cannot use `static readonly` symbols.
5. What workarounds are you using in the meantime?
I have to use symbols as global variables. | Suggestion,Awaiting More Feedback | low | Critical |
2,605,847,054 | ui | [feat]: Using `next/image` for Avatar as radix doest use next/image | ### Feature description
Want next/image optimisation on AvatarImage
### Affected component/components
AvatarImage
### Additional Context
I have remade the radix Avatar with next/image so would like to use it instead of radix Components for Avatar, a drop in replacement, but small changes are required in `ui/avatar`, there might be few improvements that can be done please do let me know,
> Changes in `ui/avatar`
> Add className `object-cover` to AvatarPrimitive.Image
> Add `fill={props.fill || !props.width || !props.height}` to AvatarPrimitive.Image
> Create the other file of the radix replacement and use the new import instead of the `radix`
> Check & update if you have missed to add `alt` values anywhere while using it, as `next/image` `alt` is a required prop
```tsx
"use client";
import * as React from "react";
import * as AvatarPrimitive from "./extension/new-avatar";
import { cn } from "@/utils/cn";
const Avatar = React.forwardRef<
React.ElementRef<typeof AvatarPrimitive.Root>,
React.ComponentPropsWithoutRef<typeof AvatarPrimitive.Root>
>(({ className, ...props }, ref) => (
<AvatarPrimitive.Root
ref={ref}
className={cn(
"relative flex h-10 w-10 shrink-0 overflow-hidden rounded-full",
className,
)}
{...props}
/>
));
Avatar.displayName = AvatarPrimitive.Root.displayName;
const AvatarImage = React.forwardRef<
React.ElementRef<typeof AvatarPrimitive.Image>,
React.ComponentPropsWithoutRef<typeof AvatarPrimitive.Image>
>(({ className, ...props }, ref) => (
<AvatarPrimitive.Image
ref={ref}
className={cn("aspect-square h-full w-full object-cover", className)} // Add object-cover
fill={props.fill || !props.width || !props.height} // And a fill like this
{...props}
/>
));
AvatarImage.displayName = AvatarPrimitive.Image.displayName;
const AvatarFallback = React.forwardRef<
React.ElementRef<typeof AvatarPrimitive.Fallback>,
React.ComponentPropsWithoutRef<typeof AvatarPrimitive.Fallback>
>(({ className, ...props }, ref) => (
<AvatarPrimitive.Fallback
ref={ref}
className={cn(
"flex h-full w-full items-center justify-center rounded-full bg-muted",
className,
)}
{...props}
/>
));
AvatarFallback.displayName = AvatarPrimitive.Fallback.displayName;
export { Avatar, AvatarFallback, AvatarImage };
```
> Make a new file `new-avatar.tsx' and use this
```tsx
"use client";
import * as X from "next/image";
import * as React from "react";
const NextImage = X.default;
/* -------------------------------------------------------------------------------------------------
* Avatar
* -----------------------------------------------------------------------------------------------*/
const AVATAR_NAME = "Avatar";
// Create a context for the Avatar
const AvatarContext = React.createContext<AvatarContextValue | undefined>(
undefined,
);
type ImageLoadingStatus = "idle" | "loading" | "loaded" | "error";
type AvatarContextValue = {
imageLoadingStatus: ImageLoadingStatus;
onImageLoadingStatusChange: (status: ImageLoadingStatus) => void;
};
type AvatarProps = React.ComponentPropsWithoutRef<"span">;
const Avatar = React.forwardRef<HTMLSpanElement, AvatarProps>(
(props, forwardedRef) => {
const [imageLoadingStatus, setImageLoadingStatus] =
React.useState<ImageLoadingStatus>("idle");
const value = {
imageLoadingStatus,
onImageLoadingStatusChange: setImageLoadingStatus,
};
return (
<AvatarContext.Provider value={value}>
<span {...props} ref={forwardedRef} />
</AvatarContext.Provider>
);
},
);
Avatar.displayName = AVATAR_NAME;
/* -------------------------------------------------------------------------------------------------
* AvatarImage
* -----------------------------------------------------------------------------------------------*/
const IMAGE_NAME = "AvatarImage";
type AvatarImageProps = React.ComponentPropsWithoutRef<typeof NextImage> & {
onLoadingStatusChange?: (status: ImageLoadingStatus) => void;
};
const AvatarImage = React.forwardRef<HTMLImageElement, AvatarImageProps>(
(props, forwardedRef) => {
const { src, onLoadingStatusChange = () => {}, ...imageProps } = props;
const context = React.useContext(AvatarContext);
const imageLoadingStatus = useImageLoadingStatus(
src,
imageProps.referrerPolicy,
);
React.useEffect(() => {
if (context) {
if (imageLoadingStatus !== "idle") {
onLoadingStatusChange(imageLoadingStatus);
context.onImageLoadingStatusChange(imageLoadingStatus);
}
}
}, [imageLoadingStatus, context, onLoadingStatusChange]);
return imageLoadingStatus === "loaded" ? (
<NextImage {...imageProps} ref={forwardedRef} src={src} alt="" />
) : null;
},
);
AvatarImage.displayName = IMAGE_NAME;
/* -------------------------------------------------------------------------------------------------
* AvatarFallback
* -----------------------------------------------------------------------------------------------*/
const FALLBACK_NAME = "AvatarFallback";
type AvatarFallbackProps = React.ComponentPropsWithoutRef<"span"> & {
delayMs?: number;
};
const AvatarFallback = React.forwardRef<HTMLSpanElement, AvatarFallbackProps>(
(props, forwardedRef) => {
const { delayMs, ...fallbackProps } = props;
const context = React.useContext(AvatarContext);
const [canRender, setCanRender] = React.useState(delayMs === undefined);
React.useEffect(() => {
if (delayMs !== undefined) {
const timerId = window.setTimeout(() => setCanRender(true), delayMs);
return () => window.clearTimeout(timerId);
}
}, [delayMs]);
return canRender && context?.imageLoadingStatus !== "loaded" ? (
<span {...fallbackProps} ref={forwardedRef} />
) : null;
},
);
AvatarFallback.displayName = FALLBACK_NAME;
/* -----------------------------------------------------------------------------------------------*/
function useImageLoadingStatus(
src?: AvatarImageProps["src"],
referrerPolicy?: React.HTMLAttributeReferrerPolicy,
) {
const [loadingStatus, setLoadingStatus] =
React.useState<ImageLoadingStatus>("idle");
React.useEffect(() => {
if (!src) {
setLoadingStatus("error");
return;
}
let isMounted = true;
const image = new window.Image();
const updateStatus = (status: ImageLoadingStatus) => () => {
if (!isMounted) return;
setLoadingStatus(status);
};
setLoadingStatus("loading");
image.onload = updateStatus("loaded");
image.onerror = updateStatus("error");
image.src = src as string;
if (referrerPolicy) {
image.referrerPolicy = referrerPolicy;
}
return () => {
isMounted = false;
};
}, [src, referrerPolicy]);
return loadingStatus;
}
const Root = Avatar;
const Image = AvatarImage;
const Fallback = AvatarFallback;
export { Avatar, AvatarFallback, AvatarImage, Fallback, Image, Root };
export type { AvatarFallbackProps, AvatarImageProps, AvatarProps };
```
### Before submitting
- [X] I've made research efforts and searched the documentation
- [X] I've searched for existing issues and PRs | area: request | low | Critical |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.