id int64 393k 2.82B | repo stringclasses 68
values | title stringlengths 1 936 | body stringlengths 0 256k ⌀ | labels stringlengths 2 508 | priority stringclasses 3
values | severity stringclasses 3
values |
|---|---|---|---|---|---|---|
2,630,225,509 | godot | Function _exit_tree() is not called properly in editor mode | ### Tested versions
v4.3.stable
### System information
Godot v4.3.stable (77dcf97d8) - Windows 10.0.22621 - Vulkan (Mobile) - dedicated NVIDIA GeForce RTX 4070 Ti (NVIDIA; 32.0.15.6094) - 13th Gen Intel(R) Core(TM) i5-13600KF (20 Threads)
### Issue description
```gdscript
extends Node2D
func _enter_tree() -> void:
print("_enter_tree")
pass
# Called when the node enters the scene tree for the first time.
func _ready() -> void:
print("_ready")
pass # Replace with function body.
func _exit_tree() -> void:
print("_exit_tree")
pass
```
I expect the print result:
```gdscript
_enter_tree
_ready
_exit_tree
```
But currently the print result:
```gdscript
_enter_tree
_ready
```
### Steps to reproduce
Run the project in the editor and close the window.
Check the print results.
### Minimal reproduction project (MRP)
[bugtest.zip](https://github.com/user-attachments/files/17605660/bugtest.zip) | bug,topic:core | low | Critical |
2,630,236,797 | neovim | `nvim_get_autocmd()` should return filepath and line-number | ### Problem
`nvim_get_autocmd()` unlike `autocmd [group]` doesnt return the line number and the filepath, which it should
### Expected behavior
running `nvim_get_autocmd()` should return the filepath and line number | enhancement,api,events | low | Minor |
2,630,252,329 | ui | [bug]: Popover doesn't work on firefox | ### Describe the bug
popover doesn't work on firefox browsers
### Affected component/components
popover
### How to reproduce
1.open app on firefox browsers
2.create popover and add trigger on button
### Codesandbox/StackBlitz link
_No response_
### Logs
_No response_
### System Info
```bash
Ubuntu 24.04.1,firefox developer edition 133.0b3, firefox 132.0,next 14.2.15, react 18
```
### Before submitting
- [X] I've made research efforts and searched the documentation
- [X] I've searched for existing issues | bug | low | Critical |
2,630,256,963 | ollama | [Model request] The First-Ever Comprehensive Benchmark for Multimodal Large Language Models in Industrial Anomaly Detection | https://github.com/jam-cc/MMAD
The First-Ever Comprehensive Benchmark for Multimodal Large Language Models in Industrial Anomaly Detection | model request | low | Minor |
2,630,289,011 | svelte | Docs: Playground snippet demo not showing letters in dark mode | ### Describe the bug
As you can see in the following screenshot, it is hard to read letters in the table when using a darkmode.
### Reproduction
[Demo](https://svelte.dev/playground/untitled?version=5.1.9#H4sIAAAAAAAAE41Sy27bMBD8lYVcwHYrW4kBXxRFaP-htzgHSqQsojLJkuu2BqF_74qUrfhxCHQRh7MzO9z1SSM74ZL8zSeKHUSSJz-MSdIET2Y4uD-iQ0Fnp4-2HpDC1VYaLHdqh_JgtEX4yapOQGP1AebrLJzWsXD-QjQi1lo5JMZRooNXeBuwHXoYLHOYM2OoiXkKv_GUwzYFY2VNFxvo0xtqxRR9F-7z04X8fE-uW2GtnJQ3E_tpvYV-oL9Ti0U2hVJFjMMZslcfW-5DWj9zShojEFrBuLCLZR_9CmzLQCwy-psw8rxBgvkNhhpZd8F8NppE7Stbq_8u-GTKS8_XQ9Keqnl5BZP1AzTYP2bDV7i7_9hLEeda0iocNJeNFDzJ0R5Fn142JzA-uzsdBfLhldPxPdMhIPS0H1-M1cYtlnejwdBDfBXZjHXTFOg4BhuOtvTfrVDEmAZG2ew5ezYV-Ew2fVzVAivNTyPHzwSr29AlMAe8f6g-zuWDts-GusAmdBSkv3P7qnB4GpMEEHwsRPEPV6yTe5VDJxp8iXClLRmtnGG1VHva3oCPHQd9QJsrbFd1Kzu-2Khvz8uzZsXqX3urj4rnMBNCXNUG83zf6Yp1C2yXKdxA_KJjGOfRfb0Vh7MKDShEuV-M9_4_nq6svF4EAAA=)
### Logs
_No response_
### System Info
```shell
N/A
```
### Severity
annoyance | documentation | low | Critical |
2,630,295,415 | transformers | when model.generate with num_beams=2 and num_return_sequences=2,the output seqs are different from input_ids of stopping_criteria | ### System Info
- `transformers` version: 4.45.2
- Platform: Linux-5.10.134-13.an8.x86_64-x86_64-with-glibc2.35
- Python version: 3.10.12
- Huggingface_hub version: 0.24.6
- Safetensors version: 0.4.4
- Accelerate version: 1.0.0
- Accelerate config: not found
- PyTorch version (GPU?): 2.5.0a0+872d972e41.nv24.08 (True)
- Tensorflow version (GPU?): not installed (NA)
- Flax version (CPU?/GPU?/TPU?): not installed (NA)
- Jax version: not installed
- JaxLib version: not installed
- Using distributed or parallel set-up in script?: <fill in>
- Using GPU in script?: <fill in>
- GPU type: NVIDIA H800
### Who can help?
?
### Information
- [ ] The official example scripts
- [X] My own modified scripts
### Tasks
- [ ] An officially supported task in the `examples` folder (such as GLUE/SQuAD, ...)
- [ ] My own task or dataset (give details below)
### Reproduction
code:
```python
from transformers import AutoConfig, AutoModel,AutoModelForSequenceClassification,AutoModelForCausalLM,AutoTokenizer
import sys
import torch
import json
from transformers import StoppingCriteria, StoppingCriteriaList
token_ids = []
class StopOnToken(StoppingCriteria):
def __init__(self, stop_token_ids):
self.stop_token_ids = stop_token_ids
def __call__(self, input_ids, scores, **kwargs):
token_ids.append(input_ids[:,-1])
return any([inp[-1].item() in self.stop_token_ids for inp in input_ids])
model_name_or_path = "Qwen/Qwen2.5-3B-Instruct"
model = AutoModelForCausalLM.from_pretrained(model_name_or_path,trust_remote_code=True,device_map="cuda")
tokenizer = AutoTokenizer.from_pretrained(model_name_or_path,trust_remote_code=True, use_fast=False)
tokenizer.padding_side = "left"
with torch.no_grad():
text = "A regular polygon has exterior angles each measuring 15 degrees. How many sides does the polygon have?Think step by step:"
text = [tokenizer.apply_chat_template([{"role":"user","content":text}],tokenize=False,add_generation_prompt=True)]
print("========>text:",text)
tokenizerd = tokenizer(text,return_tensors="pt",padding=True,add_special_tokens=False).to(device="cuda")
stopping_criteria = StoppingCriteriaList([StopOnToken([tokenizer.eos_token_id])])
output = model.generate(**tokenizerd,num_beams=2,max_new_tokens=20,num_return_sequences=2,stopping_criteria=stopping_criteria)
output = output[:,tokenizerd["input_ids"].shape[1]:]
print(output)
ans = tokenizer.batch_decode(output, skip_special_tokens=False)
print("=================ans======================")
for i,ans_i in enumerate(ans):
print(f"ans [{i}]:",json.dumps(ans_i,ensure_ascii=False))
print("output ids:",output)
token_ids = torch.stack(token_ids,dim=1)
print("stopping_criteria output ids:",token_ids)
ans = tokenizer.batch_decode(token_ids, skip_special_tokens=False)
print("=================stopping_criteria ans======================")
for i,ans_i in enumerate(ans):
print(f"ans [{i}]:",json.dumps(ans_i,ensure_ascii=False))
```
### Expected behavior
logs
```
========>text: ['<|im_start|>system\nYou are Qwen, created by Alibaba Cloud. You are a helpful assistant.<|im_end|>\n<|im_start|>user\nA regular polygon has exterior angles each measuring 15 degrees. How many sides does the polygon have?Think step by step:<|im_end|>\n<|im_start|>assistant\n']
Starting from v4.46, the `logits` model output will have the same type as the model (except at train time, where it will always be FP32)
tensor([[ 1249, 8253, 279, 1372, 315, 11067, 315, 264, 5792, 29372,
2661, 429, 1817, 27263, 9210, 10953, 220, 16, 20, 12348],
[ 1249, 8253, 279, 1372, 315, 11067, 315, 264, 5792, 29372,
1380, 1817, 27263, 9210, 10953, 220, 16, 20, 12348, 11]],
device='cuda:0')
=================ans======================
ans [0]: "To determine the number of sides of a regular polygon given that each exterior angle measures 15 degrees"
ans [1]: "To determine the number of sides of a regular polygon where each exterior angle measures 15 degrees,"
output ids: tensor([[ 1249, 8253, 279, 1372, 315, 11067, 315, 264, 5792, 29372,
2661, 429, 1817, 27263, 9210, 10953, 220, 16, 20, 12348],
[ 1249, 8253, 279, 1372, 315, 11067, 315, 264, 5792, 29372,
1380, 1817, 27263, 9210, 10953, 220, 16, 20, 12348, 11]],
device='cuda:0')
stopping_criteria output ids: tensor([[ 1249, 8253, 279, 1372, 315, 11067, 315, 264, 5792, 29372,
2661, 429, 1817, 27263, 9210, 10953, 220, 16, 20, 12348],
[39814, 1477, 279, 1372, 315, 11067, 315, 264, 5792, 29372,
1380, 1817, 27263, 9210, 10953, 220, 16, 20, 12348, 11]],
device='cuda:0')
=================stopping_criteria ans======================
ans [0]: "To determine the number of sides of a regular polygon given that each exterior angle measures 15 degrees"
ans [1]: "Sure find the number of sides of a regular polygon where each exterior angle measures 15 degrees,"
```
we can find the output tokens of generate return 2nd seq are different from tokens of StopOnToken get from input_ids 2nd seq .
why? or bugs? | WIP,bug,Generation | low | Critical |
2,630,324,983 | PowerToys | Transparent screensaver/screenlock | ### Description of the new feature / enhancement
Would be nice to have a transparent screensaver. Computer is locked but can see everything on the screen. Very helpful for people who observing datas. The opacity should be adjustable from 0-100%. Unlock the screensaver with the current user password, a lokal password, or better with the members of an Active Directory group.
### Scenario when this would be used?
In all offices where people have to observe screens/dashboards. Like in OPS centres.
### Supporting information
_No response_ | Needs-Triage | low | Minor |
2,630,328,080 | godot | Popup windows that are opened with popup_centered will open at the top left corner on linux when started visible | ### Tested versions
Reproducible in v4.4.dev3.official [f4af8201b], v4.3.stable.official [77dcf97d8], v4.2.1.stable.official [b09f793f5], v4.1.stable.official [970459615]
Not reproducible in v4.0.4.stable.official [fc0b241c9]
Not reproducible on Windows, only linux
Reproducible on both X11 and Wayland
### System information
Godot v4.3.stable - Linux Mint 22 (Wilma) - X11 - Vulkan (Forward+) - dedicated NVIDIA GeForce GTX 960 (nvidia; 550.120) - AMD FX(tm)-6300 Six-Core Processor (6 Threads)
### Issue description
On linux, when you call popup_centered on a visible window it appears at the top left of the screen. It looks like it has the correct position for a frame or two, but then snaps to the corner.
Here is a video of the bug happening on 4.4.dev3:
https://github.com/user-attachments/assets/3e9ddb60-70db-4944-9582-7ac23fb19c30
You can see that both visible and not visible have a few frames in the beginning where it appears in a different place. It's even happening on the main game window. I suspect these are the same bug.
Here is what it looks like on 4.0.4:
https://github.com/user-attachments/assets/d4fdaf5a-0a7b-44d6-8727-957557d25572
This also happens in other places, like the "Export" and "Export All" window.
https://github.com/user-attachments/assets/791437fc-8fd1-4136-8f7e-21ef88f16aef
I had a look at the source code and in the ProjectExportDialog::_export_all_dialog method, it looks like it's calling the "show" method. Commenting this out resulted in the same behavior as in the first video, where not showing it made it open at the center but with the wrong position for a frame.
### Steps to reproduce
1. Open the editor on linux
2. Go to Project > Export
3. Set up an export, then click "Export All"
4. The dialog will open in the top left corner
Alternatively:
1. Open the example project
2. Run the game with window.tscn's visibility off, it opens at the center.
3. Run the game with window.tscn's visibility on, it opens at the top left corner.
### Minimal reproduction project (MRP)
[popup test.zip](https://github.com/user-attachments/files/17606275/popup.test.zip) | bug,topic:gui | low | Critical |
2,630,353,863 | deno | deno_terminal: ansi color does not be handled correctly in file | Steps to reproduce:
```sh
deno install --log-level trace npm:zustand
```
Ansi color displays correctly in terminal.
But with this:
```
deno install --log-level trace npm:zustand &> log
```
Ansi color does not be handled correctly, I think it should be stripped.
If I use npm cli, ansi color displays correctly in terminal, and it is stripped in file.
| bug,needs info,dx | low | Minor |
2,630,356,739 | flutter | Stop pinning dependencies | ### Use case
One of the biggest pain points for package authors (and probably app developers too) that have been brought up during the Dart & Flutter Package Ecosystem Summits is that Flutter has pinned versions of its dependencies.
Why do we not want pinned dependencies? Because it leads to a lot trickier dependency version resolution than it needs to be for the end user. I would say almost all Flutter developers have at some point ended up in dependency resolution hell, before they realize that some dependencies needs to be treated with special care.
Since all of the pinned dependencies are controlled by Google it should be fairly straight forward to set up a process so that they all have some tests towards Flutter before doing a new non-breaking release or doing deprecations.
The main ones are: intl, meta, collection path, vector_math and async.
The Flutter team’s rationale for using pinned versions is outlined in [this document](https://github.com/dart-lang/sdk/blob/main/docs/Flutter-Pinned-Packages.md) but **I have been told that removing the dependency pinning is on the radar, so I just want to open this so that we can track it somewhere.**
### Proposal
Things that needs to be solved:
- [ ] Flutter builds should be hermetic.
- [ ] When dependencies bump their versions they should not be able to break Flutter.
For the first one I'm thinking that it could be solved with a lock file that isn't shipped with Flutter, but used for the builds.
For the second one my suggestion is that we introduce CI checks that needs to run before releasing a new version of the dependencies to make sure that they don't break anything in Flutter. Deprecations have to be taken into consideration here too, since they are not counted as breaking in semver. | customer: crowd,team-infra,P2,triaged-infra | low | Critical |
2,630,376,796 | rust | Tracking issue for release notes of #130660: Tracking Issue for `const_char_encode_utf16` |
This issue tracks the release notes text for #130660.
### Steps
- [ ] Proposed text is drafted by PR author (or team) making the noteworthy change.
- [ ] Issue is nominated for release team review of clarity for wider audience.
- [ ] Release team includes text in release notes/blog posts.
### Release notes text
The responsible team for the underlying change should edit this section to replace the automatically generated link with a succinct description of what changed, drawing upon text proposed by the author (either in discussion or through direct editing).
````markdown
# Category (e.g. Language, Compiler, Libraries, Compatibility notes, ...)
- [Tracking Issue for `const_char_encode_utf16`](https://github.com/rust-lang/rust/issues/130660)
````
> [!TIP]
> Use the [previous releases](https://doc.rust-lang.org/nightly/releases.html) categories to help choose which one(s) to use.
> The category will be de-duplicated with all the other ones by the release team.
>
> *More than one section can be included if needed.*
### Release blog section
If the change is notable enough for inclusion in the blog post, the responsible team should add content to this section.
*Otherwise leave it empty.*
````markdown
````
cc @bjoernager -- origin issue/PR authors and assignees for starting to draft text
| T-libs-api,relnotes,relnotes-tracking-issue | low | Minor |
2,630,400,836 | neovim | kitty keyboard protocol + shifted keys; qwertz keyboard not handling c-] | ### Problem
Alacritty 0.14 released with a [kitty keyboard protocol fix](https://github.com/alacritty/alacritty/pull/7993) that causes key combinations like `c-]` with a qwertz keyboard layout to be interpreted as `<c-9>` of `c-]` within nvim.
~I'm not entirely sure if that's a alacritty regression, or if the kitty keyboard support in neovim is the problem. In vim the same works.~ Fairly sure it's a neovim kitty keyboard protocol issue, other terminals like ghostty have the same problem
### Steps to reproduce
- Install alacritty 0.14 and setup qwertz keyboard layout
- nvim --clean
- Enter insert mode
- Type `c-v` followed by `c-]` (or try to use tagfunc)
In case it matters: This is on linux with sway.
### Expected behavior
Inserts `^]` instead of `<c-9>`
### Nvim version (nvim -v)
NVIM v0.11.0-dev-1082+g3688a33354
### Vim (not Nvim) behaves the same?
No
### Operating system/version
Archlinux
### Terminal name/version
alacritty 0.14
### $TERM environment variable
alacritty
### Installation
CMAKE_BUILD_TYPE=RelWithDebInfo make | bug,tui,input | low | Major |
2,630,409,667 | TypeScript | [Regression] Failed to assign to a discriminated union class property when its type is inferred from constructor | ### 🔎 Search Terms
property infer constructor discriminated
### 🕗 Version & Regression Information
- This changed between versions 4.3.5 and 4.4.4 (also in latest)
### ⏯ Playground Link
https://www.typescriptlang.org/play/?ts=4.4.4#code/C4TwDgpgBAysCGxoF4oG8qkgLigcgCcBXAOxIEsSBzPAGigGdIIATXEogWwCMICoAvlAA+6TOAi48DYAHswkFnkEBuAFBqAxgBt4DBlACCmufzRqolqGALkAbomgzH6q1AD07t1YB6Afg03TVkSGWITWQIACgBKdAtvS2AAC3IGADpnJChUDCxJfBl5RWUhPVgEJFcrAUCrYhIopghWdi5eAjjzRKTUjKyUMXypBopqOkZmFkEEy1qBIA
### 💻 Code
```ts
type State = { type: 'running', speed: number } | { type: 'stopped' };
class Actor {
private state;
// ^? Actor.state: State
constructor() {
this.state = { type: 'stopped' } as State;
}
run(speed: number) {
this.state = { type: 'running', speed }
}
}
```
### 🙁 Actual behavior
`Type 'string' is not assignable to type '"running" | "stopped"'.(2322)`
### 🙂 Expected behavior
No error, as in 4.3.5.
### Additional information about the issue
If the property's type is explicitly declared as `private state: State` the error is gone. | Bug,Help Wanted | low | Critical |
2,630,422,625 | yt-dlp | [youtube] livestream download is often interrupted | ### DO NOT REMOVE OR SKIP THE ISSUE TEMPLATE
- [X] I understand that I will be **blocked** if I *intentionally* remove or skip any mandatory\* field
### Checklist
- [X] I'm asking a question and **not** reporting a bug or requesting a feature
- [X] I've looked through the [README](https://github.com/yt-dlp/yt-dlp#readme)
- [X] I've verified that I have **updated yt-dlp to nightly or master** ([update instructions](https://github.com/yt-dlp/yt-dlp#update-channels))
- [X] I've searched [known issues](https://github.com/yt-dlp/yt-dlp/issues/3766) and the [bugtracker](https://github.com/yt-dlp/yt-dlp/issues?q=) for similar questions **including closed ones**. DO NOT post duplicates
- [X] I've read the [guidelines for opening an issue](https://github.com/yt-dlp/yt-dlp/blob/master/CONTRIBUTING.md#opening-an-issue)
### Please make sure the question is worded well enough to be understood
I've noticed that the stream download is often interrupted and I have to run the same command again:
`yt-dlp --no-live-from-start https://www.youtube.com/@.../live -o "1.%(ext)s"`
```
[out#0/mpegts @ 0000012fc6fb8040] video:29377kB audio:2038kB subtitle:0kB other streams:0kB global headers:0kB muxing overhead: 5.421512%
size= 33118kB time=00:02:07.97 bitrate=2120.0kbits/s speed=0.955x
[download] 100% of 32.34MiB in 00:02:15 at 244.46KiB/s
[FixupM3u8] Fixing MPEG-TS in MP4 container of "1.mp4"
```
Is there anything I can do about this?
### Provide verbose output that clearly demonstrates the problem
- [ ] Run **your** yt-dlp command with **-vU** flag added (`yt-dlp -vU <your command line>`)
- [ ] If using API, add `'verbose': True` to `YoutubeDL` params instead
- [ ] Copy the WHOLE output (starting with `[debug] Command-line config`) and insert it below
### Complete Verbose Output
_No response_ | question,external issue,site:youtube | low | Critical |
2,630,430,975 | rust | ICE: `When translating generic parameters from DefId, the expected specialization failed to hold` | <!--
[31mICE[0m: Rustc ./a.rs '' 'error: internal compiler error: compiler/rustc_trait_selection/src/traits/specialize/mod.rs:127:21: When translating generic parameters from DefId(0:9 ~ a[e72b]::{impl#1}) to DefId(0:5 ~ a[e72b]::{impl#0}), the expected specialization failed to hold', 'error: internal compiler error: compiler/rustc_trait_selection/src/traits/specialize/mod.rs:127:21: When translating generic parameters from DefId(0:9 ~ a[e72b]::{impl#1}) to DefId(0:5 ~ a[e72b]::{impl#0}), the expected specialization failed to hold'
File: /tmp/im/a.rs
-->
auto-reduced (treereduce-rust):
````rust
#![feature(specialization)]
trait Spec {
type Assoc;
}
default impl<T, U> Spec for T
where
T: IntoIterator<Item = U>,
{
type Assoc = U;
}
impl<T> Spec for [T; 0] {}
fn main() {
let x: <[_; 0] as Spec>::Assoc = 1;
}
````
original:
````rust
//@ revisions: current next
//@ ignore-compare-mode-next-solver (explicit revisions)
//@[next] compile-flags: -Znext-solver
//@[next] check-pass
//@[current] known-bug: unknown
//@[current] failure-status: 101
//~^ ERROR defaults for generic parameters are not allowed in `for<...>` binders
// Tests that rebasing from the concrete impl to the default impl also processes the
// `[u32; 0]: IntoIterator<Item = ?U>` predicate to constrain the `?U` impl arg.
// This test also makes sure that we don't do anything weird when rebasing the args
// is ambiguous.
#![feature(specialization)]
//[next]~^ WARN the feature `specialization` is incomplete
trait Spec {
type Assoc;
}
default impl<T, U> Spec for T where T: IntoIterator<Item = U> {
type Assoc = U;
}
impl<T> Spec for [T; 0] {}
fn main() {
let x: <[_; 0] as Spec>::Assoc = 1;
}
````
Version information
````
rustc 1.84.0-nightly (ef972a346 2024-11-02)
binary: rustc
commit-hash: ef972a346668ed4234d1a43ed4ad7ca4e9c58d51
commit-date: 2024-11-02
host: x86_64-unknown-linux-gnu
release: 1.84.0-nightly
LLVM version: 19.1.1
````
Possibly related line of code:
https://github.com/rust-lang/rust/blob/ef972a346668ed4234d1a43ed4ad7ca4e9c58d51/compiler/rustc_trait_selection/src/traits/specialize/mod.rs#L121-L133
Command:
`/home/matthias/.rustup/toolchains/master/bin/rustc `
<details><summary><strong>Program output</strong></summary>
<p>
```
warning: the feature `specialization` is incomplete and may not be safe to use and/or cause compiler crashes
--> /tmp/icemaker_global_tempdir.jxbDO1GMyC8v/rustc_testrunner_tmpdir_reporting.X0a6Q55Ph3Zn/mvce.rs:1:12
|
1 | #![feature(specialization)]
| ^^^^^^^^^^^^^^
|
= note: see issue #31844 <https://github.com/rust-lang/rust/issues/31844> for more information
= help: consider using `min_specialization` instead, which is more stable and complete
= note: `#[warn(incomplete_features)]` on by default
error: internal compiler error: compiler/rustc_trait_selection/src/traits/specialize/mod.rs:127:21: When translating generic parameters from DefId(0:9 ~ mvce[4f49]::{impl#1}) to DefId(0:5 ~ mvce[4f49]::{impl#0}), the expected specialization failed to hold
thread 'rustc' panicked at compiler/rustc_trait_selection/src/traits/specialize/mod.rs:127:21:
Box<dyn Any>
stack backtrace:
0: 0x7737134584aa - <std::sys::backtrace::BacktraceLock::print::DisplayBacktrace as core::fmt::Display>::fmt::hce429173f4835cf6
1: 0x773713c040ca - core::fmt::write::hd474fbdfe63c8008
2: 0x77371507b011 - std::io::Write::write_fmt::ha6b1be51a74d6c82
3: 0x773713458302 - std::sys::backtrace::BacktraceLock::print::h9a37e75f7192ac21
4: 0x77371345a806 - std::panicking::default_hook::{{closure}}::hd9ac8cf20a0b7897
5: 0x77371345a650 - std::panicking::default_hook::hdde16dcfa738c4aa
6: 0x7737124ddb49 - std[85c38ff02e03f0e6]::panicking::update_hook::<alloc[39d8aefd6e9d2d6]::boxed::Box<rustc_driver_impl[8ea1370c87ac4c52]::install_ice_hook::{closure#0}>>::{closure#0}
7: 0x77371345af18 - std::panicking::rust_panic_with_hook::h6eef9cc88a2d4e79
8: 0x773712517231 - std[85c38ff02e03f0e6]::panicking::begin_panic::<rustc_errors[a3358f633eebb703]::ExplicitBug>::{closure#0}
9: 0x77371250a206 - std[85c38ff02e03f0e6]::sys::backtrace::__rust_end_short_backtrace::<std[85c38ff02e03f0e6]::panicking::begin_panic<rustc_errors[a3358f633eebb703]::ExplicitBug>::{closure#0}, !>
10: 0x773712505829 - std[85c38ff02e03f0e6]::panicking::begin_panic::<rustc_errors[a3358f633eebb703]::ExplicitBug>
11: 0x773712520e01 - <rustc_errors[a3358f633eebb703]::diagnostic::BugAbort as rustc_errors[a3358f633eebb703]::diagnostic::EmissionGuarantee>::emit_producing_guarantee
12: 0x773712b9a363 - rustc_middle[b16c40c3cb132ea9]::util::bug::opt_span_bug_fmt::<rustc_span[94bdfa138cad1541]::span_encoding::Span>::{closure#0}
13: 0x773712b8095a - rustc_middle[b16c40c3cb132ea9]::ty::context::tls::with_opt::<rustc_middle[b16c40c3cb132ea9]::util::bug::opt_span_bug_fmt<rustc_span[94bdfa138cad1541]::span_encoding::Span>::{closure#0}, !>::{closure#0}
14: 0x773712b807eb - rustc_middle[b16c40c3cb132ea9]::ty::context::tls::with_context_opt::<rustc_middle[b16c40c3cb132ea9]::ty::context::tls::with_opt<rustc_middle[b16c40c3cb132ea9]::util::bug::opt_span_bug_fmt<rustc_span[94bdfa138cad1541]::span_encoding::Span>::{closure#0}, !>::{closure#0}, !>
15: 0x773710ccf260 - rustc_middle[b16c40c3cb132ea9]::util::bug::bug_fmt
16: 0x773713c65283 - rustc_trait_selection[7d6948a7a05ac95]::traits::specialize::translate_args_with_cause::<rustc_trait_selection[7d6948a7a05ac95]::traits::specialize::translate_args::{closure#0}>
17: 0x77371469a013 - rustc_trait_selection[7d6948a7a05ac95]::traits::project::opt_normalize_projection_term
18: 0x7737146931df - <rustc_trait_selection[7d6948a7a05ac95]::traits::normalize::AssocTypeNormalizer as rustc_type_ir[45f01c5603667543]::fold::TypeFolder<rustc_middle[b16c40c3cb132ea9]::ty::context::TyCtxt>>::fold_ty
19: 0x773713f06b53 - <rustc_hir_typeck[643602d1ca0da9fa]::fn_ctxt::FnCtxt>::normalize::<rustc_middle[b16c40c3cb132ea9]::ty::Ty>
20: 0x7737145c13fb - <dyn rustc_hir_analysis[614b5c894f29c678]::hir_ty_lowering::HirTyLowerer>::lower_ty
21: 0x7737147b4fa9 - <rustc_hir_typeck[643602d1ca0da9fa]::gather_locals::GatherLocalsVisitor>::declare
22: 0x773713f2336d - <rustc_hir_typeck[643602d1ca0da9fa]::gather_locals::GatherLocalsVisitor as rustc_hir[885137f5f5b6a9f]::intravisit::Visitor>::visit_expr
23: 0x773713f24f19 - rustc_hir_typeck[643602d1ca0da9fa]::check::check_fn
24: 0x773713f1b2f5 - rustc_hir_typeck[643602d1ca0da9fa]::typeck
25: 0x773713f1ac93 - rustc_query_impl[c0318c643aee4f05]::plumbing::__rust_begin_short_backtrace::<rustc_query_impl[c0318c643aee4f05]::query_impl::typeck::dynamic_query::{closure#2}::{closure#0}, rustc_middle[b16c40c3cb132ea9]::query::erase::Erased<[u8; 8usize]>>
26: 0x773714321d81 - rustc_query_system[708ef94f36d60214]::query::plumbing::try_execute_query::<rustc_query_impl[c0318c643aee4f05]::DynamicConfig<rustc_query_system[708ef94f36d60214]::query::caches::VecCache<rustc_span[94bdfa138cad1541]::def_id::LocalDefId, rustc_middle[b16c40c3cb132ea9]::query::erase::Erased<[u8; 8usize]>>, false, false, false>, rustc_query_impl[c0318c643aee4f05]::plumbing::QueryCtxt, false>
27: 0x77371432024d - rustc_query_impl[c0318c643aee4f05]::query_impl::typeck::get_query_non_incr::__rust_end_short_backtrace
28: 0x77371431fec7 - <rustc_middle[b16c40c3cb132ea9]::hir::map::Map>::par_body_owners::<rustc_hir_analysis[614b5c894f29c678]::check_crate::{closure#4}>::{closure#0}
29: 0x77371431de99 - rustc_hir_analysis[614b5c894f29c678]::check_crate
30: 0x7737140e384a - rustc_interface[46946d42a40348f7]::passes::run_required_analyses
31: 0x7737147d451e - rustc_interface[46946d42a40348f7]::passes::analysis
32: 0x7737147d44ef - rustc_query_impl[c0318c643aee4f05]::plumbing::__rust_begin_short_backtrace::<rustc_query_impl[c0318c643aee4f05]::query_impl::analysis::dynamic_query::{closure#2}::{closure#0}, rustc_middle[b16c40c3cb132ea9]::query::erase::Erased<[u8; 1usize]>>
33: 0x773714ba1bae - rustc_query_system[708ef94f36d60214]::query::plumbing::try_execute_query::<rustc_query_impl[c0318c643aee4f05]::DynamicConfig<rustc_query_system[708ef94f36d60214]::query::caches::SingleCache<rustc_middle[b16c40c3cb132ea9]::query::erase::Erased<[u8; 1usize]>>, false, false, false>, rustc_query_impl[c0318c643aee4f05]::plumbing::QueryCtxt, false>
34: 0x773714ba188e - rustc_query_impl[c0318c643aee4f05]::query_impl::analysis::get_query_non_incr::__rust_end_short_backtrace
35: 0x773714a65292 - rustc_interface[46946d42a40348f7]::interface::run_compiler::<core[d9ceb9bc2a384707]::result::Result<(), rustc_span[94bdfa138cad1541]::ErrorGuaranteed>, rustc_driver_impl[8ea1370c87ac4c52]::run_compiler::{closure#0}>::{closure#1}
36: 0x773714af0590 - std[85c38ff02e03f0e6]::sys::backtrace::__rust_begin_short_backtrace::<rustc_interface[46946d42a40348f7]::util::run_in_thread_with_globals<rustc_interface[46946d42a40348f7]::util::run_in_thread_pool_with_globals<rustc_interface[46946d42a40348f7]::interface::run_compiler<core[d9ceb9bc2a384707]::result::Result<(), rustc_span[94bdfa138cad1541]::ErrorGuaranteed>, rustc_driver_impl[8ea1370c87ac4c52]::run_compiler::{closure#0}>::{closure#1}, core[d9ceb9bc2a384707]::result::Result<(), rustc_span[94bdfa138cad1541]::ErrorGuaranteed>>::{closure#0}, core[d9ceb9bc2a384707]::result::Result<(), rustc_span[94bdfa138cad1541]::ErrorGuaranteed>>::{closure#0}::{closure#0}, core[d9ceb9bc2a384707]::result::Result<(), rustc_span[94bdfa138cad1541]::ErrorGuaranteed>>
37: 0x773714af09ab - <<std[85c38ff02e03f0e6]::thread::Builder>::spawn_unchecked_<rustc_interface[46946d42a40348f7]::util::run_in_thread_with_globals<rustc_interface[46946d42a40348f7]::util::run_in_thread_pool_with_globals<rustc_interface[46946d42a40348f7]::interface::run_compiler<core[d9ceb9bc2a384707]::result::Result<(), rustc_span[94bdfa138cad1541]::ErrorGuaranteed>, rustc_driver_impl[8ea1370c87ac4c52]::run_compiler::{closure#0}>::{closure#1}, core[d9ceb9bc2a384707]::result::Result<(), rustc_span[94bdfa138cad1541]::ErrorGuaranteed>>::{closure#0}, core[d9ceb9bc2a384707]::result::Result<(), rustc_span[94bdfa138cad1541]::ErrorGuaranteed>>::{closure#0}::{closure#0}, core[d9ceb9bc2a384707]::result::Result<(), rustc_span[94bdfa138cad1541]::ErrorGuaranteed>>::{closure#1} as core[d9ceb9bc2a384707]::ops::function::FnOnce<()>>::call_once::{shim:vtable#0}
38: 0x773714af1479 - std::sys::pal::unix::thread::Thread::new::thread_start::h00969398ad9e9953
39: 0x77371631139d - <unknown>
40: 0x77371639649c - <unknown>
41: 0x0 - <unknown>
note: we would appreciate a bug report: https://github.com/rust-lang/rust/issues/new?labels=C-bug%2C+I-ICE%2C+T-compiler&template=ice.md
note: please make sure that you have updated to the latest nightly
note: rustc 1.84.0-nightly (ef972a346 2024-11-02) running on x86_64-unknown-linux-gnu
query stack during panic:
#0 [typeck] type-checking `main`
#1 [analysis] running analysis passes on this crate
end of query stack
error: aborting due to 1 previous error; 1 warning emitted
```
</p>
</details>
<!--
query stack:
#0 [typeck] type-checking `main`
#1 [analysis] running analysis passes on this crate
-->
@rustbot label +F-specialization | I-ICE,T-compiler,C-bug,F-specialization,S-has-mcve,S-bug-has-test,requires-incomplete-features | low | Critical |
2,630,431,068 | ui | [bug]: Prevent back navigation when Drawer or sheet is open | ### Describe the bug
When the drawer or sheet component is open the back button in browser ( or any button or gesture which leads to navigate back for ios and android devices ) makes the router navigate back which i think the expected behavior is to prevent the user from navigating back or just close the drawer/sheet which is opened.
### Affected component/components
Drawer, sheet
### How to reproduce
In the shadcn website , use the drawer example and just hit the browser back button.
### Codesandbox/StackBlitz link
_No response_
### Logs
_No response_
### System Info
```bash
Any browser on any device
```
### Before submitting
- [X] I've made research efforts and searched the documentation
- [X] I've searched for existing issues | bug | low | Critical |
2,630,432,973 | PowerToys | Implement a toy that saves the position of the Windows "Run" Dialogbox | ### Description of the new feature / enhancement
Currently when you open the Windows "Run" command (Windows Key + R) it always opens in the lower left corner. This behavior does not change when you change the position of the start menu from left to center.
From a usability perspective it would be great if the run command dialog box would follow the start menu setting. But it doesn't. A feedback item for this also exists, but obviously nobody cares... https://aka.ms/AAdcnh4
Maybe the powertoys team could implement a feature to "save" the position of the run dialog box or let use configure a default, etc.
### Scenario when this would be used?
Everytime a user changes the position of the start menu. The run dialog box should follow the setting.
### Supporting information
_No response_ | Idea-New PowerToy,Product-Window Manager | low | Minor |
2,630,433,508 | PowerToys | A feature for the user to decide whether Fancyzones will ignore or preserve space for the taskbar | ### Description of the new feature / enhancement
Adding an option that will allow the user to change if Fancyzones takes into account the space for the taskbar irrespective of the "Automatically hide the taskbar" setting.
### Scenario when this would be used?
Some people are getting a bug where the window snaps behind the taskbar, hiding a part of the window, which was fixed but apparently is again being encountered by some people.
I personally want the snapped window to be behind the taskbar because I use other mods like RoundedTB and TranslucentTB and there is extra space that I can use for the window plus the program is not particularly happy when "Automatically hide the taskbar" is enabled.
### Supporting information
[This is the bug I was talking about](https://www.reddit.com/r/PowerToys/comments/1e28v4c/fancyzones_doesnt_care_about_the_taskbar_how_to/)
Plus there are many old threads in the repository's issues section like [this](https://github.com/microsoft/PowerToys/issues/19066) and [this](https://github.com/microsoft/PowerToys/issues/19946) | Needs-Triage | low | Critical |
2,630,452,397 | godot | SpinBox with inner LineEdit having "expand_to_text_length = true" does not tell the parent container to sort its children when the SpinBox's size changes | ### Tested versions
- Reproducible in: v4.3.stable.official [77dcf97d8]
### System information
Godot v4.3.stable - Windows 10.0.19045 - Vulkan (Forward+) - dedicated NVIDIA GeForce RTX 4070 Ti SUPER (NVIDIA; 32.0.15.6094) - 13th Gen Intel(R) Core(TM) i5-13600K (20 Threads)
### Issue description
SpinBox and LineEdit show inconsistent behaviour inside a container when `expand_to_text_length` is `true`, like an HBoxContainer:
The SpinBox does not make its parent HBoxContainer sort its children, so it clips into the label which is placed after it. The LineEdit correctly makes its parent HBoxContainer sort its children, so the Label is moved and does not overlap with the LineEdit.
I expect SpinBox to work like LineEdit in this case.
### Steps to reproduce
1. Load and run the minimal reproduction project.
2. Type a sufficiently long number into the SpinBox such that the size expands.
3. Type the same text into the LineEdit.
### Minimal reproduction project (MRP)
[spin-box-in-container.zip](https://github.com/user-attachments/files/17607056/spin-box-in-container.zip)
| bug,topic:gui | low | Minor |
2,630,454,798 | PowerToys | Fancy zones - zone focus | ### Description of the new feature / enhancement
Make it so that you can focus specific zones with a keyboard shortcut instead of alt+tab for a specific window. I think this would be a great combo with the existing win+pgUp / win +pgDown. For example let's say (just an example, I'm not sure if the shortcut would interfere with something else) Alt + Tab + 1 would focus the first window in zone 1.
### Scenario when this would be used?
Let's say I'm using zone 1, and want to quickly take a note in an app that is in zone 2. Without Alt + Tab and browsing my 10-15 tabs, I could use a shortcut to trigger zone 2, and shift window focus to it, without using a mouse.
### Supporting information
No supporting information to submit. | Needs-Triage | low | Minor |
2,630,478,853 | pytorch | Bug in conversion to mps with non_blocking=True | ### 🐛 Describe the bug
The following code fails:
```python
import torch
a = torch.tensor([0, 1, 2, 3, 4, 5, 6, 7, 8, 9])
a = a.to("mps", non_blocking=True)
print(a)
```
Resulting tensor has random values here and there, something like
```
tensor([ 6, 1, 2, 3,
4, 5, 6, 7,
8, 1688849860263945], device='mps:0')
```
### Versions
PyTorch version: 2.5.1
Is debug build: False
CUDA used to build PyTorch: None
ROCM used to build PyTorch: N/A
OS: macOS 14.7.1 (arm64)
GCC version: Could not collect
Clang version: 16.0.0 (clang-1600.0.26.4)
CMake version: version 3.30.5
Libc version: N/A
Python version: 3.10.15 (main, Oct 3 2024, 02:24:49) [Clang 14.0.6 ] (64-bit runtime)
Python platform: macOS-14.7.1-arm64-arm-64bit
Is CUDA available: False
CUDA runtime version: No CUDA
CUDA_MODULE_LOADING set to: N/A
GPU models and configuration: No CUDA
Nvidia driver version: No CUDA
cuDNN version: No CUDA
HIP runtime version: N/A
MIOpen runtime version: N/A
Is XNNPACK available: True
CPU:
Apple M3 Max
Versions of relevant libraries:
[pip3] numpy==1.26.4
[pip3] torch==2.5.1
[pip3] torchvision==0.20.1
[conda] numpy 1.26.4 pypi_0 pypi
[conda] torch 2.5.1 pypi_0 pypi
[conda] torchvision 0.20.1 pypi_0 pypi
cc @ezyang @gchanan @zou3519 @kadeng @msaroufim @kulinseth @albanD @malfet @DenisVieriu97 @jhavukainen | high priority,triaged,module: correctness (silent),module: mps | low | Critical |
2,630,488,760 | rust | rustc accepts types requiring a greater-than-48-bit address space | <!--
Thank you for filing a regression report! 🐛 A regression is something that changed between versions of Rust but was not supposed to.
Please provide a short summary of the regression, along with any information you feel is relevant to replicate it.
-->
### Code
I tried this code:
```rust
use std::mem::size_of;
pub fn main() {
assert_eq!(size_of::<[u8; (31 << 47) - 1]>(), (1 << 47) - 1);
}
```
I expected to see this happen: *rustc rejects the code*
Instead, this happened: *rustc-nightly accepts it.*
### Version it worked on
It most recently worked on: Rust 1.82
```console
% rustc test.rs
error[E0080]: evaluation of constant value failed
--> /rustc/f6e511eec7342f59a25f7c0534f1dbea00d01b14/library/core/src/mem/mod.rs:309:5
|
= note: values of the type `[u8; 4362862139015167]` are too big for the current architecture
|
note: inside `std::mem::size_of::<[u8; 4362862139015167]>`
--> /rustc/f6e511eec7342f59a25f7c0534f1dbea00d01b14/library/core/src/mem/mod.rs:309:5
note: inside `main`
--> src/main.rs:10:16
|
10 | assert_eq!(size_of::<[u8; (31 << 47) - 1]>(), (1 << 47) - 1);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
note: erroneous constant encountered
--> src/main.rs:10:5
|
10 | assert_eq!(size_of::<[u8; (31 << 47) - 1]>(), (1 << 47) - 1);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= note: this note originates in the macro `assert_eq` (in Nightly builds, run with -Z macro-backtrace for more info)
error: aborting due to 1 previous error
For more information about this error, try `rustc --explain E0080`.
%
% rustc --version --verbose
rustc 1.82.0 (f6e511eec 2024-10-15)
binary: rustc
commit-hash: f6e511eec7342f59a25f7c0534f1dbea00d01b14
commit-date: 2024-10-15
host: x86_64-unknown-linux-gnu
release: 1.82.0
LLVM version: 19.1.1
%
```
### Version with regression
```console
% rustc test.rs
%
% rustc --version --verbose
rustc 1.84.0-nightly (a0d98ff0e 2024-10-31)
binary: rustc
commit-hash: a0d98ff0e5b6e1f2c63fd26f68484792621b235c
commit-date: 2024-10-31
host: x86_64-unknown-linux-gnu
release: 1.84.0-nightly
LLVM version: 19.1.1
%
```
| T-compiler,A-layout,C-discussion | low | Critical |
2,630,498,805 | PowerToys | Keyboard Manager - Remap a shortcut fails | ### Microsoft PowerToys version
0.85.1
### Installation method
PowerToys auto-update
### Running as admin
Yes
### Area(s) with issue?
Keyboard Manager
### Steps to reproduce
Remap a key works great.
Remap a shortcut fails many times
Was not able to successfully setup a shortcut for run a program Edge browser
Was not able to successfully setup a shortcut for run a program MS VS Code
Was successful to setup by right clicking shortcut icon on taskbar so it is possible just not possible in Remap a shortcut in powertoys
### ✔️ Expected Behavior
Press shortcut combo and activate program
### ❌ Actual Behavior
Mouse indicates hourglass for a little bit then nothing
### Other Software
_No response_ | Issue-Bug,Needs-Triage | low | Minor |
2,630,510,742 | go | cmd/compile: declare and assign of function literal escapes to heap | ### Go version
1.23.2
### Output of `go env` in your module/workspace:
```shell
go env
GO111MODULE='on'
GOARCH='arm64'
GOBIN=''
GOCACHE='/Users/user/Library/Caches/go-build'
GOENV='/Users/user/Library/Application Support/go/env'
GOEXE=''
GOEXPERIMENT=''
GOFLAGS=''
GOHOSTARCH='arm64'
GOHOSTOS='darwin'
GOINSECURE=''
GOMODCACHE='/Users/user/go/pkg/mod'
GONOPROXY=''
GONOSUMDB=''
GOOS='darwin'
GOPATH='/Users/user/go'
GOPRIVATE=''
GOPROXY='https://goproxy.cn,direct'
GOROOT='/opt/homebrew/opt/go/libexec'
GOSUMDB='sum.golang.org'
GOTMPDIR=''
GOTOOLCHAIN='local'
GOTOOLDIR='/opt/homebrew/opt/go/libexec/pkg/tool/darwin_arm64'
GOVCS=''
GOVERSION='go1.23.2'
GODEBUG=''
GOTELEMETRY='local'
GOTELEMETRYDIR='/Users/user//Library/Application Support/go/telemetry'
GCCGO='gccgo'
GOARM64='v8.0'
AR='ar'
CC='cc'
CXX='c++'
CGO_ENABLED='1'
GOMOD='/Users/uesr/github/gorecycler/go.mod'
GOWORK=''
CGO_CFLAGS='-O2 -g'
CGO_CPPFLAGS=''
CGO_CXXFLAGS='-O2 -g'
CGO_FFLAGS='-O2 -g'
CGO_LDFLAGS='-O2 -g'
PKG_CONFIG='pkg-config'
GOGCCFLAGS='-fPIC -arch arm64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -ffile-prefix-map=/var/folders/5b/483w2_yd7wn5x962q5hvrzkc0000gn/T/go-build271930357=/tmp/go-build -gno-record-gcc-switches -fno-common'
```
### What did you do?
when declare an closure and assign in separate lines the local variable escape:
```go
var someFunc func(assignF func())
someFunc = func(assignF func()) {
assignF()
}
num := testing.AllocsPerRun(1, func() {
i := 0 // i escaped
someFunc(func() {
x := i
if x < 0 {
// do nothing, just make x valid
}
})
})
```
but when declare the closure in one statement, it does not escape:
```go
var someFunc = func(assignF func()) {
assignF()
}
num := testing.AllocsPerRun(1, func() {
i := 0 // i does not escaped
someFunc(func() {
x := i
if x < 0 {
// do nothing, just make x valid
}
})
})
```
escape : https://go.dev/play/p/r36WtbRaJtf
not escape: https://go.dev/play/p/2u-ydl00_0i
### What did you see happen?
The local variable i does not escape in one code block but escaped in another code block.
### What did you expect to see?
The variable `i` should not escape in both code blocks. | Performance,NeedsInvestigation,compiler/runtime | low | Critical |
2,630,540,818 | yt-dlp | [tango.me] Support for live streaming website tango.me | ### DO NOT REMOVE OR SKIP THE ISSUE TEMPLATE
- [X] I understand that I will be **blocked** if I *intentionally* remove or skip any mandatory\* field
### Checklist
- [X] I'm reporting a new site support request
- [X] I've verified that I have **updated yt-dlp to nightly or master** ([update instructions](https://github.com/yt-dlp/yt-dlp#update-channels))
- [X] I've checked that all provided URLs are playable in a browser with the same IP and same login details
- [X] I've checked that none of provided URLs [violate any copyrights](https://github.com/yt-dlp/yt-dlp/blob/master/CONTRIBUTING.md#is-the-website-primarily-used-for-piracy) or contain any [DRM](https://en.wikipedia.org/wiki/Digital_rights_management) to the best of my knowledge
- [X] I've searched [known issues](https://github.com/yt-dlp/yt-dlp/issues/3766) and the [bugtracker](https://github.com/yt-dlp/yt-dlp/issues?q=) for similar issues **including closed ones**. DO NOT post duplicates
- [X] I've read the [guidelines for opening an issue](https://github.com/yt-dlp/yt-dlp/blob/master/CONTRIBUTING.md#opening-an-issue)
- [ ] I've read about [sharing account credentials](https://github.com/yt-dlp/yt-dlp/blob/master/CONTRIBUTING.md#are-you-willing-to-share-account-details-if-needed) and am willing to share it if required
### Region
Canada
### Example URLs
- Single video: https://tango.me/stream/NbZIryrYlvvAC01RCV8dcw
- Single video: https://tango.me/immm11
### Provide a description that is worded well enough to be understood
It says unsupoprted URL because it's redirecting to tango.me/stream/noscript.html. I even tried with cookies too.
### Provide verbose output that clearly demonstrates the problem
- [X] Run **your** yt-dlp command with **-vU** flag added (`yt-dlp -vU <your command line>`)
- [ ] If using API, add `'verbose': True` to `YoutubeDL` params instead
- [X] Copy the WHOLE output (starting with `[debug] Command-line config`) and insert it below
### Complete Verbose Output
```shell
yt-dlp --cookies-from-browser firefox https://tango.me/stream/NbZIryrYlvvAC01RCV8dcw -vU
[debug] Command-line config: ['--cookies-from-browser', 'firefox', 'https://tango.me/stream/NbZIryrYlvvAC01RCV8dcw', '-vU']
[debug] Encodings: locale UTF-8, fs utf-8, pref UTF-8, out utf-8, error utf-8, screen utf-8
[debug] yt-dlp version stable@2024.08.06 from yt-dlp/yt-dlp [4d9231208] (pip)
[debug] Python 3.12.7 (CPython x86_64 64bit) - Linux-6.11.5-arch1-1-x86_64-with-glibc2.40 (OpenSSL 3.4.0 22 Oct 2024, glibc 2.40)
[debug] exe versions: ffmpeg 7.0.2 (setts), ffprobe 7.0.2
[debug] Optional libraries: Cryptodome-3.20.0, brotli-1.1.0, certifi-2024.07.04, mutagen-1.47.0, requests-2.32.3, sqlite3-3.46.1, urllib3-2.2.2, websockets-12.0
[debug] Proxy map: {}
Extracting cookies from firefox
[debug] Extracting cookies from: "/home/$USER/.mozilla/firefox/cl8j9z4o.default-release/cookies.sqlite"
Extracted 3071 cookies from firefox
[debug] Request Handlers: urllib, requests, websockets
[debug] Loaded 1830 extractors
[debug] Fetching release info: https://api.github.com/repos/yt-dlp/yt-dlp/releases/latest
[debug] Downloading _update_spec from https://github.com/yt-dlp/yt-dlp/releases/latest/download/_update_spec
Current version: stable@2024.08.06 from yt-dlp/yt-dlp
Latest version: stable@2024.10.22 from yt-dlp/yt-dlp
ERROR: You installed yt-dlp with pip or using the wheel from PyPi; Use that to update
[generic] Extracting URL: https://tango.me/stream/NbZIryrYlvvAC01RCV8dcw
[generic] NbZIryrYlvvAC01RCV8dcw: Downloading webpage
WARNING: [generic] Falling back on generic information extractor
[generic] NbZIryrYlvvAC01RCV8dcw: Extracting information
[debug] Looking for embeds
[redirect] Following redirect to https://tango.me/stream/noscript.html
[generic] Extracting URL: https://tango.me/stream/noscript.html
[generic] noscript: Downloading webpage
WARNING: [generic] Falling back on generic information extractor
[generic] noscript: Extracting information
[debug] Looking for embeds
ERROR: Unsupported URL: https://tango.me/stream/noscript.html
Traceback (most recent call last):
File "/home/$USER/.local/share/pipx/venvs/yt-dlp/lib/python3.12/site-packages/yt_dlp/YoutubeDL.py", line 1626, in wrapper
return func(self, *args, **kwargs)
^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/home/$USER/.local/share/pipx/venvs/yt-dlp/lib/python3.12/site-packages/yt_dlp/YoutubeDL.py", line 1761, in __extract_info
ie_result = ie.extract(url)
^^^^^^^^^^^^^^^
File "/home/$USER/.local/share/pipx/venvs/yt-dlp/lib/python3.12/site-packages/yt_dlp/extractor/common.py", line 740, in extract
ie_result = self._real_extract(url)
^^^^^^^^^^^^^^^^^^^^^^^
File "/home/$USER/.local/share/pipx/venvs/yt-dlp/lib/python3.12/site-packages/yt_dlp/extractor/generic.py", line 2526, in _real_extract
raise UnsupportedError(url)
yt_dlp.utils.UnsupportedError: Unsupported URL: https://tango.me/stream/noscript.html
```
| site-request,account-needed,triage,can-share-account | low | Critical |
2,630,548,472 | PowerToys | Use common source (databinding) for both Settings and OOBE Nav | ### Description of the new feature / enhancement
Let's use one source for the data to build the Navigation in both the Settings window and the OOBE window.
See examples in <a href="winui3gallery://item/NavigationView">WinUI Gallery</a> or https://learn.microsoft.com/windows/apps/design/controls/navigationview
### Scenario when this would be used?
Consistent, centralized code and consistent UX
### Supporting information
Also think of the UI strings: with one source, we can use one and the same string for every **MenuItem**. This will prevent new issues with translations or possibly different strings for the same item. Related to #32479 | Area-User Interface | low | Minor |
2,630,564,219 | go | x/tools/gopls: high cpu usage all the time | ### gopls version
0.16.2
### go env
```shell
GO111MODULE=''
GOARCH='arm64'
GOBIN='/Users/matthew/.local/share/mise/installs/go/1.22.3/bin'
GOCACHE='/Users/matthew/Library/Caches/go-build'
GOENV='/Users/matthew/Library/Application Support/go/env'
GOEXE=''
GOEXPERIMENT=''
GOFLAGS='-buildvcs=false'
GOHOSTARCH='arm64'
GOHOSTOS='darwin'
GOINSECURE=''
GOMODCACHE='/Users/matthew/go/pkg/mod'
GONOPROXY='github.com/customerio/*'
GONOSUMDB='github.com/customerio/*'
GOOS='darwin'
GOPATH='/Users/matthew/go'
GOPRIVATE='github.com/customerio/*'
GOPROXY='https://proxy.golang.org,direct'
GOROOT='/Users/matthew/.local/share/mise/installs/go/1.22.3'
GOSUMDB='sum.golang.org'
GOTMPDIR=''
GOTOOLCHAIN='auto'
GOTOOLDIR='/Users/matthew/.local/share/mise/installs/go/1.22.3/pkg/tool/darwin_arm64'
GOVCS=''
GOVERSION='go1.22.3'
GCCGO='gccgo'
AR='ar'
CC='clang'
CXX='clang++'
CGO_ENABLED='1'
GOMOD='/Users/matthew/services/go.mod'
GOWORK=''
CGO_CFLAGS='-I/Users/matthew/.local/lib/foundationdb/7.3.26/usr/local/include'
CGO_CPPFLAGS='-I/Users/matthew/.local/lib/foundationdb/7.3.26/usr/local/include'
CGO_CXXFLAGS='-O2 -g'
CGO_FFLAGS='-O2 -g'
CGO_LDFLAGS='-L/Users/matthew/.local/lib/foundationdb/7.3.26/usr/local/lib'
PKG_CONFIG='/opt/homebrew/bin/pkg-config'
GOGCCFLAGS='-fPIC -arch arm64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -ffile-prefix-map=/var/folders/md/zrgmx7p53159906_lsrbfykc0000gn/T/go-build2676139738=/tmp/go-build -gno-record-gcc-switches -fno-common'
```
### What did you do?
open cursor on a go project. goplus is constantly at 200-400% cpu, even if I'm not doing anything.
### What did you see happen?
high cpu usage.
### What did you expect to see?
not high cpu usage.
### Editor and settings
_No response_
### Logs
_No response_ | NeedsInvestigation,gopls,Tools,gopls/imports | medium | Major |
2,630,568,430 | vscode | VS Code Installer Stops Interacting With Windows (Hangs) on Windows 11 24H2 (Reproducible Every Single Time At-Will) | Does this issue occur when all extensions are disabled?: Not Applicable (N\A)
VS Code Version: 1.93 or after (Same result if attempt to install VS Code via Microsoft Store or winget; installs fail)
Edition Windows 11 Pro
Version 24H2
Installed on 9/6/2024
OS build 26100.2033
Experience Windows Feature Experience Pack 1000.26100.23.0
**Steps to Reproduce:**
Clean install Windows 11 24H2 on system or use production Windows 11 24H2 system (do NOT use Virtual Machine)
Download VS Code installer (beginning with version 1.93.1 and thru current 1.95.1) to test or production system
Execute VS Code installer
VS Code installer hangs at "Preparing to Install: Setup is preparing to install..."
Cannot cancel install; selecting Cancel button does not work - must terminate install via End Task in Task Manager
Windows 11 24H2 generates WER
Repeat test by attempting install via Microsoft Store and winget; VS Code install hangs and fails with Windows Error Reports
Partial snippet of Windows Error Report (WER):
FriendlyEventName=Stopped responding and was closed
ConsentKey=AppHangXProcB1
AppName=Setup//Uninstall
AppPath=C:\Users<user>\AppData\Local\Temp\is-B0ENK.tmp\VSCodeSetup-x64-1.95.1.tmp
ReportDescription=A problem caused this program to stop interacting with Windows. | bug,install-update,windows | low | Critical |
2,630,569,551 | electron | GTK CSD: CSS rules are not properly applied to titlebar on wayland GNOME (ozone wayland backend) | ### Preflight Checklist
- [x] I have read the [Contributing Guidelines](https://github.com/electron/electron/blob/main/CONTRIBUTING.md) for this project.
- [x] I agree to follow the [Code of Conduct](https://github.com/electron/electron/blob/main/CODE_OF_CONDUCT.md) that this project adheres to.
- [x] I have searched the [issue tracker](https://www.github.com/electron/electron/issues) for a bug report that matches the one I want to file, without success.
### Electron Version
33.0.0
### What operating system(s) are you using?
Other Linux
### Operating System Version
Linux DESKTOP-IJK2GUG 6.11.5 #1-NixOS SMP PREEMPT_DYNAMIC Tue Oct 22 13:51:37 UTC 2024 x86_64 GNU/Linux
### What arch are you using?
x64
### Last Known Working Electron version
_No response_
### Expected Behavior
Electron correctly uses ~/.config/gtk3/gtk.css and/or ~/.config/gtk4/gtk.css files when rendering wayland CSD titlebar using libgtk on GNOME.
High-level "expected behavior": [unite-shell](https://github.com/hardpixel/unite-shell/) extension properly hides titlebar when configured.
### Actual Behavior
CSS files are read, parsed, but incorrectly matched and applied.
High-level "actual behavior": [unite-shell](https://github.com/hardpixel/unite-shell/) extension cannot remove titlebar.
This extension uses negative margin (which does not work too) to remove titlebar when needed (it is configurable; for example, titlebars can be shown when not maximised and hidden when window is maximised).
### Testcase Gist URL
_No response_
### Additional Information
This issue is encountered here https://github.com/hardpixel/unite-shell/issues/371. I copied all relevant info below, you don't need to read it.
This issue is seen on GNOME 45, 46, and probably 44. Arch Linux was affected too (can't test - migrated from arch to nix).
As GNOME does not support SSD, this extention uses [CSS rules](https://github.com/hardpixel/unite-shell/tree/master/unite%40hardpixel.eu/styles) to remove titlebars on GTK windows.
Below is a simple demo of incorrect property applying:
Contents of ~/.config/gtk-3.0/gtk.css:
```css
/* UNITE windowDecorations */
/*@import url('/run/current-system/sw/share/gnome-shell/extensions/unite@hardpixel.eu/styles/gtk3/buttons-right/maximized.css');*/
/* windowDecorations UNITE */
.titlebar {
color: rgba(1,0,0,1);
}
```
No matter what I set for RGB, it is always black. Alpha channel works:
alpha=0
alpha=0.2
And even if I change `.titlebar` to `.title`, the behavior is the same.
Object tree, for reference (from GTK_DEBUG=interactive):
And also a test for invalid matching:
```css
.maximized .titlebar.default-decoration {
margin: -200px 0 0;
opacity: 0;
}
```
Does not work at all, despite titlebar having default-decoration class too.
But something like that:
```css
.maximized .titlebar {
margin: -200px 0 0;
opacity: 0;
}
```
Actually triggers and properties are applied, but margin is ignored, while titlebar is transparent:
Open this image in gThumb or simply browser with light/dark theme to see that it is transparent. Also same behavior is seen on plain electron (`electron --ozone-platform-hint=auto`), it is not discord/vesktop bug. | platform/linux,bug :beetle:,has-repro-comment,33-x-y | low | Critical |
2,630,570,907 | langchain | Replicate LLM - api token passed in constructor is not used to access the service. | ### Checked other resources
- [X] I added a very descriptive title to this issue.
- [X] I searched the LangChain documentation with the integrated search.
- [X] I used the GitHub search to find a similar question and didn't find it.
- [X] I am sure that this is a bug in LangChain rather than my code.
- [X] The bug is not resolved by updating to the latest stable version of LangChain (or the specific integration package).
### Example Code
```
from langchain_community.llms.replicate import Replicate
import os
TEST_MODEL_HELLO = (
"replicate/hello-world:"
+ "5c7d5dc6dd8bf75c1acaa8565735e7986bc5b66206b55cca93cb72c9bf15ccaa"
)
# Grab the api token from the environment variable.
api_token = os.getenv("REPLICATE_API_TOKEN")
# Reset the environment variable to ensure it's not available.
os.environ["REPLICATE_API_TOKEN"] = "yo"
# Pass the api token into the model.
llm = Replicate(model=TEST_MODEL_HELLO, replicate_api_token=api_token)
output = llm.invoke("What is a duck?")
```
### Error Message and Stack Trace (if applicable)
```
resp = <Response [401 Unauthorized]>
def _raise_for_status(resp: httpx.Response) -> None:
if 400 <= resp.status_code < 600:
> raise ReplicateError.from_response(resp)
E replicate.exceptions.ReplicateError: ReplicateError Details:
E title: Unauthenticated
E status: 401
E detail: You did not pass a valid authentication token
../../../../../.venv/lib/python3.10/site-packages/replicate/client.py:393: ReplicateError
```
### Description
I am passing an api token explicitly into the Replicate LLM model client constructor, without setting the token as an environment variable. I would like that token to be used for all access to the Replicate service.
When making requests to the service for things like the model version, instead of using this api key, the Replicate model uses the default Client, which gets its token from the env var.
Please ensure the api token that is used to construct the Replicate model client is used for all service access.
### System Info
% python -m langchain_core.sys_info
```
System Information
------------------
> OS: Darwin
> OS Version: Darwin Kernel Version 23.6.0: Mon Jul 29 21:14:46 PDT 2024; root:xnu-10063.141.2~1/RELEASE_ARM64_T6031
> Python Version: 3.10.15 (main, Sep 11 2024, 20:50:01) [Clang 12.0.0 (clang-1200.0.32.29)]
Package Information
-------------------
> langchain_core: 0.3.15
> langchain: 0.3.7
> langchain_community: 0.3.5
> langsmith: 0.1.139
> langchain_text_splitters: 0.3.2
Optional packages not installed
-------------------------------
> langgraph
> langserve
Other Dependencies
------------------
> aiohttp: 3.10.10
> async-timeout: 4.0.3
> dataclasses-json: 0.6.7
> httpx: 0.27.2
> httpx-sse: 0.4.0
> jsonpatch: 1.33
> numpy: 1.26.4
> orjson: 3.10.11
> packaging: 24.1
> pydantic: 2.9.2
> pydantic-settings: 2.6.1
> PyYAML: 6.0.2
> requests: 2.32.3
> requests-toolbelt: 1.0.0
> SQLAlchemy: 2.0.35
> tenacity: 9.0.0
> typing-extensions: 4.12.2
``` | 🤖:bug | low | Critical |
2,630,575,555 | yt-dlp | Support for Livestream website Parti | ### DO NOT REMOVE OR SKIP THE ISSUE TEMPLATE
- [X] I understand that I will be **blocked** if I *intentionally* remove or skip any mandatory\* field
### Checklist
- [X] I'm reporting a new site support request
- [X] I've verified that I have **updated yt-dlp to nightly or master** ([update instructions](https://github.com/yt-dlp/yt-dlp#update-channels))
- [X] I've checked that all provided URLs are playable in a browser with the same IP and same login details
- [X] I've checked that none of provided URLs [violate any copyrights](https://github.com/yt-dlp/yt-dlp/blob/master/CONTRIBUTING.md#is-the-website-primarily-used-for-piracy) or contain any [DRM](https://en.wikipedia.org/wiki/Digital_rights_management) to the best of my knowledge
- [X] I've searched [known issues](https://github.com/yt-dlp/yt-dlp/issues/3766) and the [bugtracker](https://github.com/yt-dlp/yt-dlp/issues?q=) for similar issues **including closed ones**. DO NOT post duplicates
- [X] I've read the [guidelines for opening an issue](https://github.com/yt-dlp/yt-dlp/blob/master/CONTRIBUTING.md#opening-an-issue)
- [ ] I've read about [sharing account credentials](https://github.com/yt-dlp/yt-dlp/blob/master/CONTRIBUTING.md#are-you-willing-to-share-account-details-if-needed) and am willing to share it if required
### Region
_No response_
### Example URLs
Single video: https://parti.com/video/3121
Single video: https://parti.com/video/3160
### Provide a description that is worded well enough to be understood
This is a newer livestream platform for content creators. You can watch past broadcasts as listed above without signing in. When I put the link in yt-dlp, it defaults to the generic extractor which fails.
### Provide verbose output that clearly demonstrates the problem
- [X] Run **your** yt-dlp command with **-vU** flag added (`yt-dlp -vU <your command line>`)
- [ ] If using API, add `'verbose': True` to `YoutubeDL` params instead
- [X] Copy the WHOLE output (starting with `[debug] Command-line config`) and insert it below
### Complete Verbose Output
```shell
[gtaxl@jetstream:youtube]./yt-dlp -F -vU https://parti.com/video/3121
[debug] Command-line config: ['-F', '-vU', 'https://parti.com/video/3121']
[debug] Encodings: locale UTF-8, fs utf-8, pref UTF-8, out utf-8, error utf-8, screen utf-8
[debug] yt-dlp version stable@2024.10.22 from yt-dlp/yt-dlp [67adeb7ba] (zip)
[debug] Python 3.9.2 (CPython x86_64 64bit) - Linux-5.10.0-32-amd64-x86_64-with-glibc2.31 (OpenSSL 1.1.1w 11 Sep 2023, glibc 2.31)
[debug] exe versions: ffmpeg 4.3.7-0, ffprobe 4.3.7-0
[debug] Optional libraries: certifi-2020.06.20, requests-2.25.1, sqlite3-3.34.1, urllib3-1.26.5
[debug] Proxy map: {}
[debug] Request Handlers: urllib
[debug] Loaded 1839 extractors
[debug] Fetching release info: https://api.github.com/repos/yt-dlp/yt-dlp/releases/latest
Latest version: stable@2024.10.22 from yt-dlp/yt-dlp
yt-dlp is up to date (stable@2024.10.22 from yt-dlp/yt-dlp)
[generic] Extracting URL: https://parti.com/video/3121
[generic] 3121: Downloading webpage
WARNING: [generic] Falling back on generic information extractor
[generic] 3121: Extracting information
[debug] Looking for embeds
ERROR: Unsupported URL: https://parti.com/video/3121
Traceback (most recent call last):
File "/home/gtaxl/youtube/./yt-dlp/yt_dlp/YoutubeDL.py", line 1625, in wrapper
return func(self, *args, **kwargs)
File "/home/gtaxl/youtube/./yt-dlp/yt_dlp/YoutubeDL.py", line 1760, in __extract_info
ie_result = ie.extract(url)
File "/home/gtaxl/youtube/./yt-dlp/yt_dlp/extractor/common.py", line 741, in extract
ie_result = self._real_extract(url)
File "/home/gtaxl/youtube/./yt-dlp/yt_dlp/extractor/generic.py", line 2533, in _real_extract
raise UnsupportedError(url)
yt_dlp.utils.UnsupportedError: Unsupported URL: https://parti.com/video/3121
[gtaxl@jetstream:youtube]
```
| site-request,triage | low | Critical |
2,630,590,229 | deno | All npm packages aren't working properly on Deno | Deno terminates process when page.jsx file content is deleted in Next.js app | I'm developing a Next.js application using Deno, and I’ve encountered a consistent issue. If I accidentally delete all content in the page.jsx file—including the default export function—by pressing backspace, Deno immediately terminates the process. This requires me to restart the server each time using deno run dev.
I've replicated the issue multiple times, and each time the result is the same. Interestingly, when I switch to using npm, the application continues running without interruption, and Next.js logs an error indicating that there's no default export in page.jsx, but it doesn’t halt the application.
I’d be happy to provide further details, and I can share a video if that would help illustrate the issue more clearly.
Steps to Reproduce:
1 . Start the Next.js app with Deno.
2. Open any page.jsx and write something. then show the preview in the browser.
3. Delete all content in the file, including the default export function.
4. Observe that Deno terminates the process instead of handling the error gracefully. | needs investigation,node compat | low | Critical |
2,630,595,458 | godot | Particles jitter in a SubViewport with "snap 2D transforms to pixel" enabled | ### Tested versions
- reproduced in: 4.3 stable, 4.2.2 stable, 4.2.1 stable
### System information
macOS, any renderer
### Issue description
Our game uses a "low res game, high res UI" setup, so the game is in a SubViewport with "snap 2D transforms to pixel" enabled. Any particles in this viewport (CPU or GPU) will jitter if moving by non-integer values and local coords is off. The transform snap setting is the culprit, and there is no jitter with vertex snapping enabled instead.
https://github.com/user-attachments/assets/4be4e573-5561-474c-9d38-484cc8f2b61f
### Steps to reproduce
Add a particles node inside a SubViewportContainer -> SubViewport, enable transform snap on the viewport. Move the particles by a non-integer amount each frame, and jitter will occur.
In MRP I've set stretch shrink to 3 to make jitter more obvious, and because we use this in our game, but it's not needed.
### Minimal reproduction project (MRP)
[viewport-particle-jitter.zip](https://github.com/user-attachments/files/17607567/viewport-particle-jitter.zip)
| bug,needs testing,topic:2d,topic:particles | low | Minor |
2,630,596,137 | opencv | [Feature flags]Seeking Guidance on OpenCV Feature Flag Design and Best Practices | ### Describe the feature and motivation
I’d like to learn from OpenCV’s experience in designing feature flags to enable custom implementation. Could you help me resolve the following questions, or provide related resources for my reference:
* 1. How does OpenCV design feature flags? What principles does it follow?
* 2. How should feature flags be used in the source code to prevent interference among them? Are there specific rules, constraints, or even clever techniques?
* 3. In testing, how can one ensure that all combinations of feature flags do not introduce bugs? Does it require testing every possible combination, or are there alternative assurances?
Thx a lot 🆘
### Additional context
_No response_ | feature | low | Critical |
2,630,624,910 | vscode | VS Code Insiders (zipped) ignoring Portable Mode | <!--<!-- ⚠️⚠️ Do Not Delete This! bug_report_template ⚠️⚠️ -->
<!-- Please read our Rules of Conduct: https://opensource.microsoft.com/codeofconduct/ -->
<!-- 🕮 Read our guide about submitting issues: https://github.com/microsoft/vscode/wiki/Submitting-Bugs-and-Suggestions -->
<!-- 🔎 Search existing issues to avoid creating duplicates. -->
<!-- 🧪 Test using the latest Insiders build to see if your issue has already been fixed: https://code.visualstudio.com/insiders/ -->
<!-- 💡 Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. -->
<!-- 🔧 Launch with `code --disable-extensions` to check. -->
Does this issue occur when all extensions are disabled?: Yes/No
<!-- 🪓 If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. -->
<!-- 📣 Issues caused by an extension need to be reported directly to the extension publisher. The 'Help > Report Issue' dialog can assist with this. -->
- VS Code Version: 1.96.0-insider
Commit: 19fabc20e35c89915c772116503a079554166a3f
Date: 2024-11-01T16:46:43.216Z
Electron: 32.2.1
ElectronBuildId: 10427718
Chromium: 128.0.6613.186
Node.js: 20.18.0
V8: 12.8.374.38-electron.0
OS: Windows_NT x64 10.0.22631
- OS Version: Windows 1 1 Enterprise 64-bit
OS build: 22631.4317
### Steps to Reproduce:
1. Download zip version of VS Code Insiders. **(Downloaded @ 11:30 AM CST 11/02/2024)**
2. Unzip and immediately create data folder inside of the unzipped folder's root directory.
3. Create a tmp folder inside of the data folder
4. Run Code.
Results:
| under-discussion,portable-mode | low | Critical |
2,630,627,042 | react | [Compiler Bug]: Compiler doesn't catch ref access in render | ### What kind of issue is this?
- [X] React Compiler core (the JS output is incorrect, or your app works incorrectly after optimization)
- [ ] babel-plugin-react-compiler (build issue installing or using the Babel plugin)
- [ ] eslint-plugin-react-compiler (build issue installing or using the eslint plugin)
- [ ] react-compiler-healthcheck (build issue installing or using the healthcheck script)
### Link to repro
https://playground.react.dev/#N4Igzg9grgTgxgUxALhAegFQYDoDsAEG+AKgBYCWY+l+Y5AtuQDYCGM+ALhPlGAgMocWHBABp8AIygdqMlkyYQA7lQDmCDh3K5VnUgnysRYGSeEGEANwS48hSQgBmEGAY77aQkflIsqEhBseAAcAE3NQyQBPfFcWOA4AOjsMNDwEAA9glxlHKFwE8ggCXgEogsFzAAptci15AEp8YDt8OGKTfABtcT4OADV5KAQAXXwAXh4+SpEa3DryRoBuVvbcTtdHCamEACUnOYXl1tcOWAIu1vx8KqbxgD5Yp0S4WFdcDlErm8shhDvHi0CNcQeQtlVNi83jYZABCcaTX5MYZNIEg9FPRxQmDvGSIv4rYEY2gaQbIhBVJEownEgC+31pX2BI0J9NsuEwOAIRAAgj4IBAANacbiCwLBTgweLCiBbdwWUJ1FgSJgGMzeWV6AzaYLSZLc-AAOQg3ncwnwSgMuECkS4PhYuFCqvwLDa0GCzs1CFC6jafgQYGQKXwAEZEm76IwZPQWDEAn6FN7qAR5bQWPQDO9Qgh2IoIBK-CFwiIAKKKgZ-YMAJnDUDC5jLdTJw3wMbjBjg8lVkRYjhE7Hakbq1ConcToWDZADBjYBlCLbtqcc8RkZpkhqg9ACMAAkrhdTJpMxyAAvAOyKjKAjqhAAWgk-onBqpBjrxfPDsig6jyfwLmz7B2sEObODA9BujiCAJPgoExpo2iqPqhBpNaWQ5DB+SFMUOyNkIKoUmif64AAwr4OhiK0xQAELIjATLXHEoQAPK4EwMSTMuTB8PR+AvjxxSkQ66h7gezYUcCAkOogTA8dmy5QEwHC4Qh2ycdxeC0qiqwdDIXTqBW5JUQgCG4d6vSkn8RkmeW3pjJMpT8OUcAzBS3xySwClKeWKkAPzNLxfz4LS+DIPguAKTJrQNIS2nrDI37DpMtwTIC3xrJ0L5WTopmRJM+liVlqg5bcNKguCmXGdlNmRPCkzhQo+AAGSNQFhmVUV1WJC++C1a1KLNN81wCWR6g+YklKWe1OVdX80UMt8fQFVN1VVPVTBzUSRE0bAY0la0tIxcC6XxVJCBMNsyUPANm2LZN1l1N6q0RRt6LDUJCAidIYm7S+L0gpJBRnbtf1Dbg20wMDpUHXgsWdDCOa4S5F0Atd6JgjcsKMSxbFaZt1y3W190iKEVTAH1BiaaV1xstTh3XMdRYNuWYkXdaShiSjhGg4J5GfQZwy7WzHNU26cXk4VOXbPld1VQ9JMg9Q5Uyx1ctNS1FVE96M3kj1CJhQg7OzajGIE8MEsrWTL6hULgWUwy+BnXwxvomgaAkBQVA0I45CuD2fY5hGUa9Nww5gKQ0BMJEqjcCYUrkKopCrtwb3kYN+Cu-gADqM5gGAm5uL4MjDkozDnda1jsPG3u+w4oEWB8CPli54jh5aFdIRiKejeNNvkgrNNBXTosZcrkt5RZhOy8Te3Aqc5zO+ToUa1PSZ+cvKvE9rLZL38PHXJQyk6Dvk8b0mvVrWrPVY6xUR74HdR352gORZt8MwIjXjieib5M02u-7RpPAIBaRAA
### Repro steps
Hi! I'm hoping the React compiler catches this invalid ref access and bails out of optimizing code like this, but I understand that catching this kind of issue is probably a bigger undertaking than normal.
Our team's codebase has some dubious core library hooks which break React's rules, or at least make it easy to break React's rules without knowing what you're doing. Here, `useSyncState` advertises itself as a cooler `useState` that lets you see the freshest state, even before React does! (But after memoization, this just means you see stale state). This leads to it being used incorrectly in `useEditable`, when we call `getValueBeingEdited()` inside of a render.
When I installed the compiler on our codebase, many E2E tests started failing. One of the tests showed us that when we update one EditableCell, the state change doesn't propagate to another cell like it was supposed to. The test passed after I added `'use no memo'` to *either* `useSyncState.ts` *or* `useEditable.ts`. For now, I'm going to add `'use no memo'` to both of these files, but my understanding is that every time I add `'use no memo'`, you'd like to see why I had to do so.
### How often does this bug happen?
Every time
### What version of React are you using?
Playground
### What version of React Compiler are you using?
Playground | Type: Bug,Status: Unconfirmed,Component: Optimizing Compiler | medium | Critical |
2,630,632,541 | pytorch | [JIT] ModuleList getitem error when saving and loading with torchscript | ### 🐛 Describe the bug
The problem occurs when using modulelist with torchscript. When scripting the model everything works okey, but when saving and loding the model the following error pops out:
```python
a = torch.nn.ModuleList([torch.nn.Linear(20, 10), torch.nn.Linear(30, 10)])
print(a[0])
a_scripted = torch.jit.script(a)
a_scripted.save("a.pt")
print(a_scripted[0])
a_loaded = torch.jit.load("a.pt")
print(a_loaded[0])
```
```
Traceback (most recent call last):
File "/home/user/envs/env/lib/python3.11/site-packages/torch/jit/_script.py", line 876, in __getitem__
return self.forward_magic_method("__getitem__", idx)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/home/user/envs/env/lib/python3.11/site-packages/torch/jit/_script.py", line 869, in forward_magic_method
raise NotImplementedError
NotImplementedError
```
### Versions
Collecting environment information...
PyTorch version: 2.4.0+cu121
Is debug build: False
CUDA used to build PyTorch: 12.1
ROCM used to build PyTorch: N/A
OS: Ubuntu 20.04.6 LTS (x86_64)
Python version: 3.11.9 | packaged by conda-forge | (main, Apr 19 2024, 18:36:13) [GCC 12.3.0] (64-bit runtime)
CPU:
Architecture: x86_64
Versions of relevant libraries:
[pip3] flake8==7.1.1
[pip3] mypy==1.1.1
[pip3] mypy-boto3-s3==1.26.62
[pip3] mypy-extensions==1.0.0
[pip3] numpy==2.0.1
[pip3] nvidia-cublas-cu12==12.1.3.1
[pip3] nvidia-cuda-cupti-cu12==12.1.105
[pip3] nvidia-cuda-nvrtc-cu12==12.1.105
[pip3] nvidia-cuda-runtime-cu12==12.1.105
[pip3] nvidia-cudnn-cu12==9.1.0.70
[pip3] nvidia-cufft-cu12==11.0.2.54
[pip3] nvidia-curand-cu12==10.3.2.106
[pip3] nvidia-cusolver-cu12==11.4.5.107
[pip3] nvidia-cusparse-cu12==12.1.0.106
[pip3] nvidia-nccl-cu12==2.20.5
[pip3] nvidia-nvjitlink-cu12==12.6.77
[pip3] nvidia-nvtx-cu12==12.1.105
[pip3] torch==2.4.0
[pip3] torch_cluster==1.6.3+pt24cu121
[pip3] torch_geometric==2.3.1
[pip3] torch_scatter==2.1.2+pt24cu121
[pip3] torch_sparse==0.6.18+pt24cu121
[pip3] torch_spline_conv==1.2.2+pt24cu121
[pip3] torch-tb-profiler==0.4.3
[pip3] triton==3.0.0
[conda] No relevant packages
cc @EikanWang @jgong5 @wenzhe-nrv @sanchitintel | oncall: jit | low | Critical |
2,630,641,287 | react | [Compiler Bug]: `'Unused 'use no memo' directive'` lint warning even though the directive is used | ### What kind of issue is this?
- [ ] React Compiler core (the JS output is incorrect, or your app works incorrectly after optimization)
- [ ] babel-plugin-react-compiler (build issue installing or using the Babel plugin)
- [X] eslint-plugin-react-compiler (build issue installing or using the eslint plugin)
- [ ] react-compiler-healthcheck (build issue installing or using the healthcheck script)
### Link to repro
https://playground.react.dev/#N4Igzg9grgTgxgUxALhAegFQYDoDsAEG+AKgBYCWY+l+Y5AtuQDYCGM+ALhPlGAgMocWHBABp8AIygdqMlkyYQA7lQDmCDh3K5VnUgnysRYGSeEGEANwS48hSQgBmEGAY77aQkflIsqEhBseAAcAE3NQyQBPfFcWOA4AOjsMNDwEAA9glxlHKFwE8ggCXgEogsFzAAptci15AEp8YDt8AHJS-FxuegR6CDbWuGKTfABtcT4OADV5KAQAXXwAXh4+SpEa3DryRoBuIZGZV0cVtYQAJSctnf3W1w5YAjHW-HwqpuWAPlinRLhYK5cBxRK93pY5ghPj8WgQ3vDyKcqid-oCbDIAITLVYQpjzJqw+FE36OVEwIEyHGQg5w4m0DSzPEIKq4-E0ukAXzBHNBcIWNK5tlwmBwBCIAEEfBAIABrTjcGWBYKcGDxOUQU7uCyhOosCRMAxmbwavQGbTBaTJMX4AByEG87mE+CUBlwgUiXB8LFwoQN+BY+GGUGCfpNCFC6kDfgQYGQKXwAEZEoGIPRGDJ6CwYgEowpw9QCFraCxer8fQh2IoIMq-CFwiIAKI6maQ+MAJmTwfrCCbdUZ83wmezBjg8gNkRYjhE7GGabq1Coo7zoXjZBjBjYBlCA89Rcc8RkjpkNqg9ACMAAkrgLTJpMxyAAvGOyKjKAhGhAAWgk0ZX1tZBhduYVDepEs7pgW+AuKEFbyvgwQVs4MD0Cm5IIAk+BIZmmjaKoVqEGkbpZDkmH5IUxTnL2Qj6syhJQbgADCvg6GIrTFAAQniMC8m8cShAA8rgTAxKs+5MHwPH4ABknFEx3rqFeN79qxcKyd6iBMJJMH7lATAcFRuFnGJEl4ByBKtB0fBdD0fQDIcuCjGM6gtky7EILhVHhpMDKQm5HnNuGSyrKU-DlHAGzMmC2ksLp+nNoZAD8zRSZC+AcvgyBdLpmmtA0NL2aM4HzqsHwrDCYLDA5MgAX5OieZEqzOcptWqPVHzsgiSI1e5dUBZEWKrLg2X4AAZCNKWuT1rV9YkAH4ANE34s0YJvLJzHqAliQsr5U31bNkJ5dyYJTM1u19VUQ0KIdtL0ZxsCbe1rQcvlcKVYV6kIEwZyld8y03SdO3+XU4YXdl11Emt8kIIp0jKQ9AHg-CakFJ9D2I6tuB3TAaMdc9eAFTI6IVlREXfdCf1Eoi7wYnxgnCeZN1vADk1AyIoRVMAi0GGZHVvIKfMvW8b23mE5hUcp31ukoynk3RGNySxMMufMD1SzLvMplVXMtfVZxNYDvXA+z6PUF1BvTUbo3jd1rPhvtTLzdiXQINLB0U8SzPzDr52cwBmVq6lPPcvgn1WXL8JoGgJAUFQNCOOQrgTlOsFFSCtDcPOYCkNATCRKo3AmKq5CqKQh7cJDLErfgkf4AA6huYBgKebi+DI85KMwX1utY7A5vHicOEhFjAsTzYReI2cuj3+HEhXG1bQHTIm-zaWC5row24bbN6z5LNbyDiMPE87tvH72tnZbSWbxbbP2wOmXSWClAGToD-m7rC2XV9Y3zbTQlRJJIWqZ0yAKjCjHKN0iYwBJl4FSRIgKNmbMpSSgpBQgA5EAA
### Repro steps
`useSyncState` and `useEditable` break when the React Compiler runs on it. So I added `'use no memo'` to the top of `useSyncState` and `useEditable`. In both these places, `eslint-plugin-react-compiler` reports that the `'use no memo'` directive is unused. Even though this directive is the only difference between a passing E2E test and a failing one!
<img width="561" alt="image" src="https://github.com/user-attachments/assets/fa72f31a-2d00-4d2a-8f90-b39db1c69185">
* Related to https://github.com/facebook/react/issues/31406, where I report that the compiler should ideally bail out on these hooks so the `'use no memo'` directive becomes unnecessary.
### How often does this bug happen?
Every time
### What version of React are you using?
18.3.1
### What version of React Compiler are you using?
19.0.0-beta-6fc168f-20241025 | Type: Bug,Status: Unconfirmed,Component: Optimizing Compiler | low | Critical |
2,630,642,065 | rust | Add a few more commits to `.git-blame-ignore-rev` | When I was doing git archaeology in the `tests/` repo, I noticed there's a couple of commits that probably should be added to `.git-blame-ignore-rev` because they're like moving tests around and things. | C-cleanup,A-testsuite,A-meta | low | Minor |
2,630,725,806 | rust | Recursive const stability checks do not apply in const items | All stable `const fn` in core/alloc/std are checked to ensure that they, transitively, do not use any unstable const features.
However, the same is not the case for const items. A stable `fn` can use array lengths, and a stable trait can have associated const, that use arbitrary unstable const features. That seems bad? I'm not entirely sure how to fix that though -- these items don't themselves have any stability, after all. They are just use in a large function (that may not even be a `const fn`).
One example where we are actually doing this is here:
https://github.com/rust-lang/rust/blob/7f74c894b0e31f370b5321d94f2ca2830e1d30fd/library/std/src/sys/pal/unix/process/process_unix.rs#L813
`CMSG_SPACE` is a `const fn` defined in libc. It is not subject to any recursive const stability checks.
Cc @rust-lang/wg-const-eval @compiler-errors | A-stability,T-compiler,C-bug,A-const-eval,WG-const-eval | low | Critical |
2,630,728,572 | pytorch | [Compile] Inform about hard shape guards | ### 🚀 The feature, motivation and pitch
Dynamic shapes tracing is the way to avoid recompilations of functions when input tensors' shapes change. However, it is not guaranteed that the compiler will be able to trace the shapes correctly.
One of the obvious ways to tell that the trace was not successful is presence of hard guards aka `L['x'].size(0) == 120`. We can check if such guards have appeared for the input tensors' shapes and provide verbose report of the origin to make debugging dynamic compilation easier
### Alternatives
Alternative to that is to scrutinize complicated dynamo compilation logs in search of the _breaking_ guard origin
### Additional context
The proposition is motivated by the recent release of FlashAttention that is not able to work properly with dynamic shapes, and now I'm debugging it myself, painfully searching for hard guars' origins
cc @ezyang @chauhang @penguinwu @bobrenjc93 | triaged,oncall: pt2,module: dynamic shapes | low | Critical |
2,630,735,850 | PowerToys | AI Autocomplete | ### Description of the new feature / enhancement
Hi, I suggest adding this feature called **AI Autocomplete** to PowerToys. What I mean by this is that in ANY part of the computer, it may be the **File Explorer**, or **Chrome** or any other program, to add this one functionality where AI can predict your next word and you can press TAB to Autocomplete. In the PowerToys app, you could change the Tone, Language, and Exclusions, for this feature. (Bonus: Make an option for this feature in the PowerToys app so that for any word AI Suggests should be rewritten to display 3 synonyms of that word.)
### Scenario when this would be used?
I would use this while writing an email or messages or making portfolio websites.
### Supporting information
_No response_ | Needs-Triage | low | Minor |
2,630,750,598 | ui | [bug]: Charrts - Label missplaced on iPhone | ### Describe the bug
The label have an undesirable offset on high res phones like iPhone 12.
### Affected component/components
Charts
### How to reproduce
1. Go to https://ui.shadcn.com/charts#radial-chart with your iphone on Chrome
### Codesandbox/StackBlitz link
_No response_
### Logs
_No response_
### System Info
```bash
iPhone 12
iOS 18
Chrome latest version
```
### Before submitting
- [X] I've made research efforts and searched the documentation
- [X] I've searched for existing issues | bug | low | Critical |
2,630,773,432 | storybook | indexer documentation is lacking | I'd like to call my storybook file `Widget.demo.tsx` instead of `Widget.stories.tsx`. This is possible with [custom indexers](https://storybook.js.org/docs/api/main-config/main-config-indexers); in fact, the docs specifically say
> Unless your indexer is doing something relatively trivial (e.g. [indexing stories with a different naming convention](https://storybook.js.org/docs/configure/user-interface/sidebar-and-urls#story-indexers)), in addition to indexing the file ...
But that link just takes me in circles -- nowhere does it tell me what that trivial indexer actually looks like. Digging into the [API reference](https://storybook.js.org/docs/api/main-config/main-config-indexers), the examples all seem to elide critical parts of the actual code:
```
// Read file and generate entries ...
```
Could the docs be updated to show some real working examples of indexers, including a simple "noop" indexer that just picks up a different filename than the convention? | documentation,story index | low | Minor |
2,630,798,133 | godot | Godot can't find the Node above when the node is part of the inherited scene | ### Tested versions
v4.3.stable.official [77dcf97d8]
### System information
mac Mini M1 with newest MacOS
### Issue description
I am trying to connect a signal to a function of a parent node in an inherited scene.
But, I am getting an error:
"Cannot get path of node as it is not in a scene tree."
### Steps to reproduce
Download the mrp and open the room 1 scene.
There will be a timer as a child of the "base component" node.
Try to connect the timer's timeout() signal to the parent's function "quick_check()".
An error will be printed.
You can also go to room 2 node and try to add the timer from the beginning and connect it to the parent's "quick_check()" function and the same error will appear.
Once launched, the game works as expected, at least for now…
https://github.com/user-attachments/assets/774b98d0-e804-4b06-b16b-0c8f55295944
### Minimal reproduction project (MRP)
[cant-find-the-node-above.zip](https://github.com/user-attachments/files/17608397/cant-find-the-node-above.zip) | bug,topic:core | low | Critical |
2,630,806,905 | godot | Cannot infer type when using unknown field | ### Tested versions
Godot Version: v4.3.stable.official [77dcf97d8]
### System information
Godot v4.3.stable - Windows 10.0.22631 - GLES3 (Compatibility) - NVIDIA GeForce RTX 3080 (NVIDIA; 31.0.15.5241) - 12th Gen Intel(R) Core(TM) i7-12700KF (20 Threads)
### Issue description
When using 'unknown' fields, the parser can't infer the type of variables.
While the type `a` is correctly inferred, the parser throws an error for `b` and `c`.
```gdscript
var a := event is InputEventMouseButton and (event as InputEventMouseButton).button_index == MOUSE_BUTTON_LEFT
var b := event is InputEventMouseButton and event.button_index == MOUSE_BUTTON_LEFT
var c := event is InputEventMouseButton and event.get('button_index') == MOUSE_BUTTON_LEFT
```
For `b` it's reasonable that the type can't be inferred, since that expression throws an exception when the accessed field doesn't exist.
(for example with a typo: `event.button_indexx`)
But the parser should be able to infer the type of `c` since the expression is always `boolean`.
(regardless whether the value exists or what the value is)
### Steps to reproduce
1. Create `Area2D` scene
2. Add a rectangular `CollisionShape2D`
* optional: use a sprite to visualize it
3. Add a script to the scene
4. Add the `_input_event` function to the script
5. Add the variables to the function
```gdscript
var a := event is InputEventMouseButton and (event as InputEventMouseButton).button_index == MOUSE_BUTTON_LEFT
# type shouldn't be inferred (since it can cause a runtime exception)
var b := event is InputEventMouseButton and event.button_index == MOUSE_BUTTON_LEFT
# type should be inferred
var c := event is InputEventMouseButton and event.get('button_index') == MOUSE_BUTTON_LEFT
```
7. Currently only the type of `a` is inferred
### Minimal reproduction project (MRP)
[infer-test.zip](https://github.com/user-attachments/files/17610518/infer-test.zip) | bug,discussion,topic:gdscript | low | Critical |
2,630,817,008 | neovim | API: get UI client-capabilities/implemented-features | ### Problem
I'm working on "a_project" that uses `&mousemoveevent`. This feature is not widely implemented in `gui`s. If someone uses a feature in "a_project" that depends in this working in the `gui`, an error should be given rather than randomly failing. To give a meaningful error, whether or not `&mousemoveevent` is supported by the `gui` needes to be determined.
This issue is about a general way to get information about `gui` clients.
I'm relatively new to `neovim`, and have just started looking at `gui`s. I don't know how much is only selectively or partially implemented. If `&mousemoveevent` is the only `neovim` feature not implemented by `gui`s, then this is less of a problem...
Note: `neovide` has `client`, but `client.attributes` is nil. `goneovim` does not even have `client`, so not even the `name` is available.
### Expected behavior
A way to find out what features are available/implemented in a `gui`. Maybe the things laid out in `ui.txt` are a good starting point; but I see that `&mousemoveevent` is not in there; maybe there's lower level features that need to be mentioned.
@justinmk https://github.com/neovim/neovim/issues/27949 may be loosely related. In particular, "simplify remote plugins", could include the retrieval of information about the `gui`/plugin.
Wondering about a script that determines what features are available. Hmm, maybe derived from the tests. | enhancement,api,ui-extensibility | medium | Critical |
2,630,819,226 | material-ui | [cssVariables] Creating variables for typography with responsive incorrectly and not work | ### Steps to reproduce
When create theme with typography with h1 include responsive:
```tsx
const theme = createTheme({
...
typography: {
fontFamily: roboto.style.fontFamily,
h1: {
fontSize: '2.8rem',
color: 'red',
fontWeight: 'bold',
'@media (min-width:300px)': {
fontSize: '3rem',
},
'@media (min-width:400px)': {
fontSize: '4rem',
},
},
...
},
...
},
});
```
### Current behavior
```tsx
This variable appears to be non-existent or malformed
// output:
'@media (min-width:400px)': {
fontSize: var(--typography-h1-@media (min-width:400px)-fontSize)
},
```
https://stackblitz.com/edit/github-emurbz?file=src%2Ftheme.ts,src%2Fapp%2Fpage.tsx,src%2Fcomponents%2FProTip.tsx,src%2Fcomponents%2FCopyright.tsx
### Expected behavior
Generate variables that match media keys (300px, 400px...) and accept these values.
### Context
_No response_
### Your environment
_No response_
**Search keywords**: cssVariables typography responsive | new feature,component: Typography,customization: theme | low | Minor |
2,630,821,386 | deno | Deno fails when a package in a monorepo uses a `./*` export | Deno version
```
$ deno --version
deno 2.0.4 (stable, release, x86_64-unknown-linux-gnu)
v8 12.9.202.13-rusty
typescript 5.6.2
```
To demonstrate the issue I created the following mono-repo
```
$ tree
.
├── a
│ ├── deno.json
│ └── src
│ └── index.ts
├── deno.json
└── index.ts
```
The root `deno.json` just specifies the `a` package
```
$ cat deno.json
{
"workspace": ["./a"]
}
```
The `a` package has a single export
```
$ cat a/src/index.ts
export const foo = 42;
```
and a minimal `deno.json`
```
$ cat a/deno.json
{
"name": "@github-issue-example/a",
"exports": {
".": "./src/index.ts",
"./*": "./src/*"
}
}
```
finally, the root module `index.ts` files contains a single export
```
$ cat index.ts
import { foo } from "@github-issue-example/a/index.ts";
```
This sort of set up worked fine with node but deno is not happy about this import
```
$ deno run index.ts
error: Relative import path "@github-issue-example/a/index.ts" not prefixed with / or ./ or ../ and not in import map from "file:///home/michael/github-issue-demos/deno-monorepo/index.ts"
at file:///home/michael/github-issue-demos/deno-monorepo/index.ts:1:21
```
If I change the `export` map in `a/deno.json` to explicitly list `index` everything works fine, i.e.
```
$ cat a/deno.json
{
"name": "@github-issue-example/a",
"exports": {
".": "./src/index.ts",
"./index.ts": "./src/index.ts"
}
}
```
This would seem to be a bug to me but it might be a feature request, I can't quite tell from the documentation. Any advise or help greatly appreciated. Thanks.
---
This issues looks similar to https://github.com/denoland/deno/issues/20513 but I thought it different enough to warrant a separate issue. | needs investigation,publish,triage required 👀 | low | Critical |
2,630,829,448 | opencv | medianBlur() gives (-215:Assertion failed) when ksize > 256 | ### System Information
OpenCV versions from 3.4.1 to OpenCV(4.10.0-dev)
### Detailed description
on https://docs.opencv.org/4.x/dd/d6a/tutorial_js_filtering.html
i tried `cv.medianBlur(src, dst, 257);`
Exception: OpenCV(4.10.0-dev) /build/precommit_docs/4.x/opencv/modules/imgproc/src/median_blur.simd.hpp:241: error: (-215:Assertion failed) k < 16 in function 'medianBlur_8u_O1'
### Steps to reproduce
on https://docs.opencv.org/4.x/dd/d6a/tutorial_js_filtering.html
```
let src = cv.imread('canvasInput');
let dst = new cv.Mat();
// You can try more different parameters
cv.medianBlur(src, dst, 257);
cv.imshow('canvasOutput', dst);
src.delete(); dst.delete();
```
### Issue submission checklist
- [X] I report the issue, it's not a question
- [X] I checked the problem with documentation, FAQ, open issues, forum.opencv.org, Stack Overflow, etc and have not found any solution
- [X] I updated to the latest OpenCV version and the issue is still there
- [X] There is reproducer code and related data files (videos, images, onnx, etc) | bug,category: imgproc | low | Critical |
2,630,830,763 | vscode | when opening a folder file manager suggests to unmount root |
Type: <b>Bug</b>
After recent update every time I open a file or folder in vscode I see the "unmount" button next to the root, the boot and my home partitions. It doesnt affect my workflow, but since vscode appears to be the only app with such behavior I thought its necessary to report. I use Ubuntu 24.04 LTS with Gnome desktop.
VS Code version: Code 1.95.1 (65edc4939843c90c34d61f4ce11704f09d3e5cb6, 2024-10-31T05:14:54.222Z)
OS version: Linux x64 6.8.0-48-generic snap
Modes:
<details>
<summary>System Info</summary>
|Item|Value|
|---|---|
|CPUs|13th Gen Intel(R) Core(TM) i9-13900HX (32 x 4935)|
|GPU Status|2d_canvas: unavailable_software<br>canvas_oop_rasterization: disabled_off<br>direct_rendering_display_compositor: disabled_off_ok<br>gpu_compositing: disabled_software<br>multiple_raster_threads: enabled_on<br>opengl: disabled_off<br>rasterization: disabled_software<br>raw_draw: disabled_off_ok<br>skia_graphite: disabled_off<br>video_decode: disabled_software<br>video_encode: disabled_software<br>vulkan: disabled_off<br>webgl: unavailable_software<br>webgl2: unavailable_software<br>webgpu: disabled_off<br>webnn: unavailable_software|
|Load (avg)|1, 1, 1|
|Memory (System)|94.03GB (87.56GB free)|
|Process Argv|--no-sandbox --disable-extensions --crash-reporter-id 1ee9bd70-6103-4ee7-b66c-928b85453563|
|Screen Reader|no|
|VM|0%|
|DESKTOP_SESSION|ubuntu-wayland|
|XDG_CURRENT_DESKTOP|Unity|
|XDG_SESSION_DESKTOP|ubuntu-wayland|
|XDG_SESSION_TYPE|wayland|
</details>Extensions disabled<details>
<summary>A/B Experiments</summary>
```
vsliv368cf:30146710
vspor879:30202332
vspor708:30202333
vspor363:30204092
vscod805cf:30301675
binariesv615:30325510
vsaa593:30376534
py29gd2263:31024239
c4g48928:30535728
azure-dev_surveyone:30548225
962ge761:30959799
pythongtdpath:30769146
pythonnoceb:30805159
asynctok:30898717
pythonmypyd1:30879173
2e7ec940:31000449
pythontbext0:30879054
cppperfnew:31000557
dsvsc020:30976470
pythonait:31006305
dsvsc021:30996838
da93g388:31013173
dvdeprecation:31068756
dwnewjupytercf:31046870
2f103344:31071589
impr_priority:31102340
nativerepl2:31139839
refactort:31108082
pythonrstrctxt:31112756
cf971741:31144450
iacca1:31171482
notype1:31157159
5fd0e150:31155592
dwcopilot:31170013
```
</details>
<!-- generated by issue reporter --> | linux,native-file-dialog | low | Critical |
2,630,867,960 | deno | [deno doc] Support JSDoc `@event` | I am trying to use `deno doc` (and the JSR docs) to document a class I'm writing. This class is a subclass of `EventTarget`, and can fire a few events.
I was looking at the best way to document those events, and so far the best I came up with was to define a type for `addEventListener` with a few overloads. I then noticed that JSDoc has something for this: `@event` (https://jsdoc.app/tags-event). It'd be nice to have `deno doc` support for it. | docs,suggestion | low | Minor |
2,630,875,269 | angular | [language-server] TypeScript interface for element definitions (including for custom elements) | Wasn't sure if this belongs here or in https://github.com/angular/vscode-ng-language-service
### Which @angular/* package(s) are relevant/related to the feature request?
`@angular/language-service`
### Description
This is not a duplicate of
- https://github.com/angular/angular/issues/12045
Instead, this asks for an interface that we can easily augment to add type definitions for elements (built-in or custom, i.e. regardless if element names have hyphens or not).
Today Custom Elements (a.k.a Web Components) are more prevalent than ever, and they can be used in many major frameworks with type checking (React, Preact, Vue, Svelte, Solid.js) and other frameworks without type checking (Angular, etc).
In this day and age, we need to be able to easily add type definitions for elements, especially custom elements, but it can be useful to be able to extend built-in element types too in case Angular definitions are not caught up with new elements landing in browsers.
### Proposed solution
Allow a TypeScript interface to be augmented, where the defintion of an element name to element type can be provided.
The proposal in
- https://github.com/angular/angular/issues/12045
could map schemas to a TypeScript type for TypeScript users specifically (and to other types in other languages), but at least TypeScript users would have a cleaner simpler way to get moving. Implementing a cross-language schema is more difficult, plus JavaScript/TypeScript is what most people are using (I don't know if other language support even exists).
Angular is the only remaining major framework to not have the ability for a specific TypeScript interface to be augmented:
- **Solid.js**: augment `solid-js` module's `JSX.IntrinsicElements`
- **Vue**: augment `vue` module's `GlobalComponents`
- **Svelte**: augment the global `svelteHTML.IntrinsicElements` or augment `svelte/elements` module's `SvelteHTMLElements`
- **React**: augment `react` module's `JSX.IntrinsicElements`
- **Preact**: augment `preact` module's `JSX.IntrinsicElements` with the same definition as for react with react compat enabled
- **Angular**: n/a
The usage could look this,
```ts
// `angular` module
export type GlobalCSSValues = 'inherit' | 'initial' | 'etc'
// augmentable interface
export interface CSSProperties {
visibility: 'hidden' | 'visible' | 'collapse' | GlobalCSSValues
display: 'none' | 'block' | 'inline' | 'etc' | GlobalCSSValues
// ... etc ...
}
// augmentable interface
export interface IntrinsicElements {
div: { /* ... */ }
button: : { /* ... */ }
// ... etc ...
}
```
```ts
// user code
declare module 'angular' {
// user adds additional element definitions
interface IntrinsicElements {
'my-element': {
// this covers type checking for `[foo]=` property bindings
foo?: number
// this covers type checking for `[attr.foo]=` attribute bindings
'attr.foo'?: `${number}` | number
// this covers type checking for `(some-event)=` event bindings
'on.some-event'?: SomeEvent
}
// plus generic types for Angular's special bindings can be provided out of the box (insead of the user writing them here):
& type Obj = {
// [class.foo]= bindings
[K in `class.${string}`]?: boolean
} & {
// [style.known]= bindings
[K in keyof CSSProperties as `style.${keyof CSSProperties}`]?: CSSProperties[K]
} & {
// [style.unknown]= bindings
[K in `style.${string}`]?: string
}
}
}
class SomeEvent extends Event { /* ... */ }
```
or similar.
Here's an example of the special `style.` and `class.` binding types in TypeScript playground:
[TypeScript playground](https://www.typescriptlang.org/play/?#code/C4TwDgpgBA4gNgewEYEM4GEDKmBqaCuEAzlALxQDkAlgHYAWEATlcBVAD6W0tVpucUIwAMYUAUGID0kqCnwBzALYQawFEjjRawJgDMUwiGO16D0LJgAKjBJEbAqxKAG8xASABuVIlSRU4LCAAXJR0VAAm4Sr8lF4+GhAxFMIIcHAoYESJHLCIqBjYeHCERO7h3mDpwZQ0CDTZAhoIwgDWSbQB9UlCojnwyGgWRSXu0lAAdJNQPROTYgC+EqCQUADySABWZC6jMgDawulEROO6CAgAuuR+NOU08qVuewDSULRQAAaHKMfjACTOIjAZj3eYfC4AfhCSHOmhQNAWUAAZDsoFAxnsgSBNKdzlcoDc7g8xGiXm8aFAWhAQAhdFALNZbEwHE4fp8sTiAVSaXSGTY7CyiGDISE+Uz7I4iC8LgsJCkaECoAgAIwhdZbciuNxnBAhZUAJgAzAAadEyJg2RhQAAU8nO4QAlLKxPLFQh9WrNtstckjicdRQ9UbTWMLQgrbb7U7Fi66m7DZ6NTs3L6fv7zoGoMDCCGZAgWs7XcAlQAWRPe9yp34BkL6OBZXNKgsxotKgCs5c1lY5EFxCEzFA0KDoFEbYYjdoQjsLceLCAAbJ3kxQe+NykRKigQAOhyOx4xLTbJ9OW7OlQB2Jc+1frzfbkKDxCtUdmpsLIA)
The generic `style.` and `class.` stuff can be provided as a default with a helper from `angular`, for example:
```ts
// user code
import type {IntrinsicBindings} from 'angular'
declare module 'angular' {
// user adds additional element definitions
interface IntrinsicElements {
'my-element': IntrinsicBindings & {
// this covers type checking for `[foo]=` property bindings
foo?: number
// this covers type checking for `[attr.foo]=` attribute bindings
'attr.foo'?: `${number}` | number
// this covers type checking for `(some-event)=` event bindings
'on.some-event'?: SomeEvent
}
}
}
class SomeEvent extends Event { /* ... */ }
```
Heck, you could even require the syntax to match, for sake of consistency with template syntax, and it is possible thanks to TypeScript template string types:
```ts
// user code
import type {IntrinsicBindings} from 'angular'
declare module 'angular' {
// user adds additional element definitions
interface IntrinsicElements {
'my-element': IntrinsicBindings & {
// this covers type checking for `[foo]=` property bindings
foo?: number
// this covers type checking for `[attr.foo]=` attribute bindings
'[attr.foo]'?: `${number}` | number
// this covers type checking for `(some-event)=` event bindings
'(some-event)'?: SomeEvent
}
}
}
class SomeEvent extends Event { /* ... */ }
```
```ts
// and similar for the builtin props:
export type IntrinsicBindings = {
// [class.foo]= bindings
[K in `[class.${string}]`]?: boolean
} & {
// [style.known]= bindings
[K in keyof CSSProperties as `[style.${keyof CSSProperties}]`]?: CSSProperties[K]
} & {
// [style.unknown]= bindings
[K in `[style.${string}]`]?: string
}
```
Library authors making custom element libraries can then make their own mapped-type helpers to map their element class properties, for example, to property, attribute, and event types, and they can even expand the `class.` and `style.` types if needed.
For example, given a class like this:
```js
import {attribute, element, event} from 'some-lib' // For example, https://github.com/lume/element
export
@element('my-element')
class MyElement extends HTMLElement {
@attribute foo: "foo" | "bar" = "foo" // the initial value when no foo attribute is set (or foo attribute is removed)
@event 'onsome-event': ((event: SomeEvent) => void) | null = null
// ... implementation omitted ...
}
class SomeEvent extends Event { /* ... */ }
```
then a custom element author can define their own mapped type (as they already will be doing for React, Preact, Solid, Vue, Svelte, and others) to make it easy to define element types for their specific custom element library:
```ts
import type {ElementAttributesForAngular} from 'some-lib/angular-types'
declare module 'angular' {
interface IntrinsicElements {
// pick the properties to be used for Angular template types (any not listed are omitted from template type checking)
'my-element': ElementAttributesForAngular<MyEl, 'foo' | 'onsome-event'>
}
}
```
### Alternatives considered
Implement a schema, and the tooling needed to map that to TypeScript (and other language) definitions like in #12045? Good luck! I imagine that's why #12045 has been open for 8 years since 2016.
A TypeScript interface would much easier to provide because TypeScript is the current foundation, and it would be immediately usable by a large amount of web developers.
People can also use TypeScript definitions as a source for mapping to other languages, so even having just TypeScript support would be a better starting point than a more difficult schema idea.
There are already tools like [TypeScript-to-Flow](https://transform.tools/typescript-to-flow) converters, so starting with a TypeScript interface right now, would be valuable a lot more quickly than #12045. | area: language-service | medium | Major |
2,630,876,546 | opencv | so-called 'default' CI builder, a.k.a. pullrequest.opencv.org is always 'red' | ### System Information
all platforms
### Detailed description
Unfortunately, CI status of many submitted and even merged PRs is misleading, because 'default' builder very often fails in the Linux builder, on 'videoio' and 'g-api' tests. It's suggested to temporarily remove those 2 test executables (or run them with proper `--gtest_filter` to exclude problematic tests).
### Steps to reproduce
submit any PR to 5.x and probably to 4.x branch or just look at the existing PRs
### Issue submission checklist
- [X] I report the issue, it's not a question
- [X] I checked the problem with documentation, FAQ, open issues, forum.opencv.org, Stack Overflow, etc and have not found any solution
- [X] I updated to the latest OpenCV version and the issue is still there
- [X] There is reproducer code and related data files (videos, images, onnx, etc) | bug | low | Minor |
2,630,902,511 | godot | Not all CameraAttributesPhysical or CameraAttributesPractical resource properties emit the 'Changed' signal | ### Tested versions
Reproducible in: `4.3.stable` and `4.4.dev3`.
### System information
Arch Linux - Godot v4.3.stable
### Issue description
Connecting the `changed` signal from a resource that inherits from `CameraAttribute`, i.e `CameraAttributePhysical` and `CameraAttributePractical`, only gets emitted when changing `CameraAttributes` specific properties.
E.g. `exposure_sensitivity` and `auto_exposure_enabled` will emit the `changed` signal, whereas changing properties like `frustum_far` (`CameraAttributesPhysical`) or `dof_blur_amount` (`CameraAttributesPractical`) do not.
Expected all resource properties to emit the `changed` signal.
### Steps to reproduce
1. Add a `Camera3D` to a scene
2. Apply either a `CameraAttributesPhysical` or `CameraAttributesPractical` resource to the `Camera3D`'s `Attribute` property
3. Add a script and function that connects the `changed` signal of `Camera3D`'s `Attributes` property that outputs something
5. Run the scene and change `Attributes` values
6. Observe that only properties defined in the base `CameraAttribute` resource emit the `changed` signal
**Sample script**
```gdscript
extends Node3D
@onready var camera: Camera3D = %Camera3D
func _ready() -> void:
if camera.attributes:
if not camera.attributes.changed.is_connected(_attributes_changed):
camera.attributes.changed.connect(_attributes_changed)
func _attributes_changed() -> void:
print("Changing Camera Attributes")
```
### Minimal reproduction project (MRP)
[camera-attributes-changed-signal.zip](https://github.com/user-attachments/files/17608843/camera-attributes-changed-signal.zip)
| bug,confirmed,topic:3d | low | Minor |
2,630,911,193 | next.js | Next 15 | Build fails: Can't resolve `next/dist/server/route-modules/app-page/vendored/contexts/html-context` | ### Link to the code that reproduces this issue
https://github.com/tonightpass/kitchn/pull/749
### To Reproduce
1. Install dependencies with `pnpm install`
2. Run `pnpm build`
3. Observe the build failure with the above error
### Current vs. Expected behavior
The build should complete successfully without any module resolution errors.
### Provide environment information
```bash
Operating System:
Platform: darwin
Arch: x64
Version: Darwin Kernel Version 22.6.0: Wed Jul 31 21:42:48 PDT 2024; root:xnu-8796.141.3.707.4~1/RELEASE_X86_64
Available memory (MB): 16384
Available CPU cores: 8
Binaries:
Node: 18.19.0
npm: 10.2.3
Yarn: N/A
pnpm: 9.12.3
Relevant Packages:
next: 15.0.2 // Latest available version is detected (15.0.2).
eslint-config-next: 15.0.2
react: 18.3.1
react-dom: 18.3.1
typescript: 5.6.2
Next.js Config:
output: N/A
```
### Which area(s) are affected? (Select all that apply)
Pages Router
### Which stage(s) are affected? (Select all that apply)
next build (local)
### Additional context
When trying to build my Next.js project using `next build`, I'm encountering a module resolution error. The build process fails with the following error:
```
Failed to compile.
../node_modules/.pnpm/next@15.0.2_@[babel+core@7.26.0_react-dom](mailto:babel+core@7.26.0_react-dom)@[18.3.1_react@18.3.1__react](mailto:18.3.1_react@18.3.1__react)@18.3.1/node_modules/next/dist/pages/_document.js
Module not found: Can't resolve 'next/dist/server/route-modules/app-page/vendored/contexts/html-context'
[https://nextjs.org/docs/messages/module-not-found](https://nextjs.org/docs/messages/module-not-found)
Import trace for requested module:
../node_modules/.pnpm/next@15.0.2_@[babel+core@7.26.0_react-dom](mailto:babel+core@7.26.0_react-dom)@[18.3.1_react@18.3.1__react](mailto:18.3.1_react@18.3.1__react)@18.3.1/node_modules/next/dist/api/document.js
../packages/kitchn/dist/next/index.esm.js
> Build failed because of webpack errors
```
Any assistance or guidance on resolving this issue would be greatly appreciated. Thank you! | bug,Pages Router | low | Critical |
2,630,924,078 | godot | NOTIFICATION_APPLICATION_FOCUS_IN and NOTIFICATION_APPLICATION_FOCUS_OUT Cause Engine Freeze/Stutter with Large Scene Trees | ### Tested versions
4.3, 4.2.2, 4.1.3, 4.0
### System information
Godot v4.3.stable.mono (97f0c76f2) - Ubuntu 24.04.1 LTS 24.04 - X11 - Vulkan (Forward+) - dedicated NVIDIA GeForce RTX 2080 Ti (nvidia; 560.35.03) - AMD Ryzen 9 3900X 12-Core Processor (24 Threads)
### Issue description
When the `NOTIFICATION_APPLICATION_FOCUS_IN` and `NOTIFICATION_APPLICATION_FOCUS_OUT` notifications are triggered, the Godot engine freezes or stutters noticeably if there are many nodes in the scene tree. This issue affects the engine's performance, especially in scenes with large hierarchies.
### Steps to reproduce
1. Create or open a project with a scene that contains a large number of nodes in the scene tree.
2. Run the project.
3. Switch the application focus away from the engine (e.g., by clicking on another window).
4. Switch the application focus back to the engine.
5. Observe the engine's performance during these focus changes.
### Minimal reproduction project (MRP)
[MRP.zip](https://github.com/user-attachments/files/17609013/MRP.zip) | bug,topic:core,needs testing,performance | low | Major |
2,630,938,869 | next.js | ReferenceError: e is not defined error occurs when running next dev --turbo | ### Link to the code that reproduces this issue
https://github.com/y-hsgw/with-urql
### To Reproduce
When using` next dev --turbo` with a Next.js application, the following error message appears:
```sh
ReferenceError: e is not defined
at Module.Kind (/path/to/.next/server/chunks/ssr/node_modules_xyz.js:1376:18)
at Kind (turbopack://[project]/node_modules/@urql/core/src/gql.ts:84:30)
...
```
The application works without issues when running the `next dev` command.
### Current vs. Expected behavior
bug screenshot:
### Provide environment information
```bash
Operating System:
Platform: darwin
Arch: arm64
Version: Darwin Kernel Version 24.0.0: Tue Sep 24 23:36:26 PDT 2024; root:xnu-11215.1.12~1/RELEASE_ARM64_T8103
Available memory (MB): 8192
Available CPU cores: 8
Binaries:
Node: 22.10.0
npm: 10.9.0
Yarn: 4.5.1
pnpm: N/A
Relevant Packages:
next: 15.0.2 // Latest available version is detected (15.0.2).
eslint-config-next: N/A
react: 18.3.1
react-dom: 18.3.1
typescript: 5.6.3
Next.js Config:
output: N/A
```
### Which area(s) are affected? (Select all that apply)
Turbopack
### Which stage(s) are affected? (Select all that apply)
next dev (local)
### Additional context
I also submitted an issue to urql, but they responded that it was an issue on the Next.js side.
https://github.com/urql-graphql/urql/issues/3704 | Turbopack,linear: turbopack | medium | Critical |
2,630,970,628 | ui | [bug]: Combobox on Dialog | ### Describe the bug
Cannot focus search input on combobox on a dialog.
### Affected component/components
Combobox, dialog
### How to reproduce
1
### Codesandbox/StackBlitz link
please add a reproduction
### Logs
_No response_
### System Info
```bash
browsers
```
### Before submitting
- [X] I've made research efforts and searched the documentation
- [X] I've searched for existing issues | bug | low | Critical |
2,630,979,918 | vscode | workbench.files.action.createFileFromExplorer is not triggered via keybinding |
Type: <b>Bug</b>
- In the file explorer, right click the new file icon and click "Configure Keybinding..."
- Choose a keybinding (ex: "a")
- Focus the file explorer and press "a"
Nothing happens... Same thing for folders.
VS Code version: Code 1.95.1 (Universal) (65edc4939843c90c34d61f4ce11704f09d3e5cb6, 2024-10-31T05:14:54.222Z)
OS version: Darwin arm64 24.0.0
Modes:
<details>
<summary>System Info</summary>
|Item|Value|
|---|---|
|CPUs|Apple M3 Pro (12 x 2400)|
|GPU Status|2d_canvas: enabled<br>canvas_oop_rasterization: enabled_on<br>direct_rendering_display_compositor: disabled_off_ok<br>gpu_compositing: enabled<br>multiple_raster_threads: enabled_on<br>opengl: enabled_on<br>rasterization: enabled<br>raw_draw: disabled_off_ok<br>skia_graphite: disabled_off<br>video_decode: enabled<br>video_encode: enabled<br>webgl: enabled<br>webgl2: enabled<br>webgpu: enabled<br>webnn: disabled_off|
|Load (avg)|2, 2, 2|
|Memory (System)|18.00GB (0.49GB free)|
|Process Argv|--crash-reporter-id 017f1800-639a-42c1-9793-a3b7fb84cf32|
|Screen Reader|no|
|VM|0%|
</details><details><summary>Extensions (59)</summary>
Extension|Author (truncated)|Version
---|---|---
better-comments|aar|3.0.2
vscode-sql-formatter|adp|1.4.4
copy-relative-path|ale|0.0.2
jest-snippets|and|1.9.1
azurite|Azu|3.33.0
catppuccin-vsc|Cat|3.15.2
catppuccin-vsc-icons|Cat|1.17.0
js-auto-backticks|cha|1.2.0
path-intellisense|chr|2.9.0
dart-code|Dar|3.100.0
flutter|Dar|3.100.0
vscode-markdownlint|Dav|0.56.0
vscode-eslint|dba|3.0.10
xml|Dot|2.5.1
gitlens|eam|15.6.2
EditorConfig|Edi|0.16.4
vsc-material-theme|Equ|34.7.7
vsc-material-theme-icons|equ|3.8.8
prettier-vscode|esb|11.0.0
flutter-find-unused-assets-and-dart-files|ese|1.0.2
vscode-jest-runner|fir|0.4.74
copilot|Git|1.243.0
copilot-chat|Git|0.22.1
vscode-pull-request-github|Git|0.100.0
git-worktrees|Git|2.2.0
vscode-graphql|Gra|0.12.1
vscode-graphql-syntax|Gra|1.3.8
vscode-references-plus|hap|0.0.14
terraform|has|2.33.0
vscode-test-explorer|hbe|2.22.1
vscode-power-mode|hoo|3.0.2
elixir-ls|Jak|0.24.2
svg|joc|1.5.4
vscode-commitizen|Kni|1.1.0
git-graph|mhu|1.30.0
vscode-antlr4|mik|2.4.7
dotenv|mik|1.0.1
azure-pipelines|ms-|1.247.2
test-adapter-converter|ms-|0.2.0
awesome-flutter-snippets|Nas|4.0.1
color-highlight|nau|2.8.0
vscode-versionlens|pfl|1.14.2
material-icon-theme|PKi|5.12.0
vscode-yaml|red|1.15.0
vscode-sort-json|ric|1.20.0
flutter-riverpod-snippets|rob|1.2.2
gitmoji-vscode|sea|1.2.5
rewrap|stk|1.16.3
code-spell-checker|str|3.0.1
vscode-editor-group-minimizer|suh|1.3.2
open-in-browser|tec|2.0.0
lazygit-vscode|Tom|0.1.9
errorlens|use|3.20.0
vscode-lldb|vad|1.11.0
learn-vim|vin|0.0.28
explorer|vit|1.6.6
vim|vsc|1.28.1
vscode-surround|yat|1.5.0
markdown-all-in-one|yzh|3.6.2
</details><details>
<summary>A/B Experiments</summary>
```
vsliv368:30146709
vspor879:30202332
vspor708:30202333
vspor363:30204092
vscod805cf:30301675
binariesv615:30325510
vsaa593cf:30376535
py29gd2263:31024239
vscaat:30438848
c4g48928:30535728
azure-dev_surveyone:30548225
962ge761:30959799
pythongtdpath:30769146
pythonnoceb:30805159
asynctok:30898717
pythonmypyd1:30879173
h48ei257:31000450
pythontbext0:30879054
cppperfnew:31000557
dsvsc020:30976470
pythonait:31006305
dsvsc021:30996838
jg8ic977:31013176
dvdeprecation:31068756
dwnewjupyter:31046869
2f103344:31071589
impr_priority:31102340
nativerepl2:31139839
refactort:31108082
pythonrstrctxt:31112756
cf971741:31144450
iacca1:31171482
notype1:31157159
5fd0e150:31155592
dwcopilot:31170013
```
</details>
<!-- generated by issue reporter --> | bug,keybindings,file-explorer | low | Critical |
2,631,028,131 | godot | Sub-window does not capture mouse_entered() / mouse_exited() events on Area2D | ### Tested versions
- Reproducible in 4.0-stable (did not check further back)
### System information
Godot v4.3.stable (77dcf97d8) - Windows 10.0.19045 - Vulkan (Forward+) - dedicated NVIDIA GeForce RTX 3070 (NVIDIA; 32.0.15.6094) - AMD Ryzen 5 5600X 6-Core Processor (12 Threads)
### Issue description
With Area2D nodes correctly configured in both the main window and sub-window...
**Expected**
Area2D's `mouse_entered` & `mouse_exited` signals should fire when the mouse enters/exits the collision shape in both the main window and sub-window.
**Actual**
The `mouse_entered` & `mouse_exited` signals do not fire in the sub-window.
### Steps to reproduce
* Create a main scene with a Node2D
* Add a Window child node
* Set size to 256 x 256
* (Optional) Set initial position to Center of Primary Screen
* Add a Node2D as a child of Window
* Under both the top-level Node2D and the Node2D child of the Window...
* Add an Area2D
* Set Position to `(100px, 100px)`
* Add a Sprite2D under the Area2D; set the Texture to the default `icon.svg`
* Add a CollisionShape2D under the Area2D; set the Shape to a RectangleShape2D; set the Rectangle size to 128 x 128
* Attach the following GDScript script to the Area2D
```gdscript
extends Area2D
func _on_mouse_entered() -> void:
self.modulate = Color.RED
func _on_mouse_exited() -> void:
self.modulate = Color.BLUE
```
* Connect the `mouse_entered` and `mouse_exited` signals from the Area2D to the respective GDScript functions
* Save scene and run project
* Move cursor over each sprite and observe the color change (or lack thereof)
### Minimal reproduction project (MRP)
[SubWindowMouseBug.zip](https://github.com/user-attachments/files/17609667/SubWindowMouseBug.zip)
| documentation,topic:input,topic:2d | low | Critical |
2,631,032,690 | vscode | Cannot read properties of undefined (reading 'getViewLineMinColumn') | ```javascript
TypeError: Cannot read properties of undefined (reading 'getViewLineMinColumn')
at rLi.getViewLineMinColumn in src/vs/editor/common/viewModel/viewModelLines.ts:735:62
at dLi.getLineMinColumn in src/vs/editor/common/viewModel/viewModelImpl.ts:687:22
at dLi.getCompletelyVisibleViewRange in src/vs/editor/common/viewModel/viewModelImpl.ts:598:30
at dLi.getVisibleRanges in src/vs/editor/common/viewModel/viewModelImpl.ts:539:33
at Va.getVisibleRanges in out-vscode/vs/editor/browser/widget/codeEditor/vs/editor/browser/widget/codeEditor/codeEditorWidget.ts:530:36
at oae.c in src/vs/workbench/contrib/chat/browser/contrib/chatImplicitContext.ts:56:39
at vZ.value in src/vs/workbench/contrib/chat/browser/contrib/chatImplicitContext.ts:36:121
at x.B in src/vs/base/common/event.ts:1243:13
at x.fire in src/vs/base/common/event.ts:1274:9
at Vs in src/vs/base/common/event.ts:286:16
```
[Go to Errors Site](https://errors.code.visualstudio.com/card?ch=912bb683695358a54ae0c670461738984cbb5b95&bH=8a460736-fddc-7e15-787c-e8bedef384c4) | error-telemetry | low | Critical |
2,631,057,768 | transformers | Saving checkpoints *only* on improvement | ### Feature request
When using the Hugging Face Trainer, I would like to save a checkpoint only if my objective metric has improved.
### Motivation
Currently, I am using eval_steps=100,save_steps=100, save_limit=1 and load_best_model_at_end=True which means that every 100 steps, the latest checkpoint is getting written and then the previous checkpoint is getting deleted unless it is the best checkpoint.
This has done approximately 2TB of wear to my SSD in only a few days due to an excessive amount of checkpointing. I really don’t need to resume from the latest checkpoint, I just need the best checkpoint to be saved, and I’m not concerned about the run crashing, so in this case, there is really no need to be saving every 100 steps.
Additionally, it is not feasible to wait until the end of the run and load the best state because I am manually early stopping my runs. I do not wish to automate the early stopping either.
I’m happy to monkey patch my build of transformers if anyone is aware of the culprit lines I can comment out or modify.
### Your contribution
N/A | Feature request | low | Critical |
2,631,065,683 | three.js | Feature Proposal: `PointerNode` | ### Description
Can we consider adding a `PointerNode`, similar to `ScreenNode`, to make a pointer node accessible in both compute and render shaders?
This could simplify and optimize pointer-based interactions and we could potentially offer built-in raycasting support as an option.
The `webgpu_compute_geometry.html` example would be a great use case to test and demonstrate this feature.
Potential API:
```js
pointer = // normalized
pointerViewport = // pixels
// potential API
pointer(sceneToRaycast)
pointer.xy // coordinates
pointer.z // depth of intersection
pointer.w.greaterThan(0) // raycast is hitting
```
/cc @sunag @Mugen87 | Suggestion | low | Minor |
2,631,083,489 | pytorch | There is a bug when training SwinIR model in pychram and running it | RuntimeError: use_libuv was requested but PyTorch was build without libuv support
torch version = '2.5.1'
cc @H-Huang @awgu @kwen2501 @wanchaol @fegin @fduwjj @wz337 @wconstab @d4l3k @c-p-i-o | needs reproduction,oncall: distributed | low | Critical |
2,631,088,146 | node | tools: lint TypeScript files | ### What is the problem this feature will solve?
Since `--experimental-typescript-support` landed there are more and more TypeScript file in the codebase (especially in the test folder).
Currently those are ignored by the `make lint` job.
### What is the feature you are proposing to solve the problem?
Add the eslint typescript plugin, so we can have linting for TypeScript files.
### What alternatives have you considered?
Manually format 😿 | feature request,tools,strip-types | low | Minor |
2,631,103,361 | svelte | Svelte 5 won't allow `:global(@page)` | ### Describe the bug
Svelte 5 doesn't seem to like this:
```
:global(@page) {
size: A4;
margin: 0cm;
margin-top: 16mm;
margin-bottom: 16mm;
}
```
REPL: https://svelte.dev/playground/e771e2916c484705aa2c144cb6127119?version=5.1.9
(related to this on MDN: https://developer.mozilla.org/en-US/docs/Web/CSS/@page)
### Reproduction
See code above or REPL link
### Logs
_No response_
### System Info
```shell
System:
OS: Linux 6.11 Arch Linux
CPU: (24) x64 AMD Ryzen 9 5900X 12-Core Processor
Memory: 48.31 GB / 62.71 GB
Container: Yes
Shell: 5.9 - /usr/bin/zsh
Binaries:
Node: 23.1.0 - /usr/bin/node
Yarn: 1.22.22 - /usr/bin/yarn
npm: 10.9.0 - /usr/bin/npm
pnpm: 9.12.2 - /usr/bin/pnpm
bun: 1.1.30 - ~/bin/bun
Browsers:
Brave Browser: 130.1.71.118
Chromium: 130.0.6723.69
```
### Severity
blocking an upgrade | css | low | Critical |
2,631,139,422 | opencv | OpenCV 5 Removing deprecated functions | ### Describe the feature and motivation
Related : #25001
`logPolar` is deprecated This function produces same result as `warpPolar(src, dst, src.size(), center, maxRadius, flags+WARP_POLAR_LOG)`
`linearPolar` is deprecated This function produces same result as `warpPolar(src, dst, src.size(), center, maxRadius, flags)`
### Additional context
_No response_ | feature,category: imgproc | low | Minor |
2,631,141,382 | godot | iOS workflow jobs downloading MoltenVK "Latest" caused issues in production | ### Tested versions
Any new CI builds using this commit: https://github.com/godotengine/godot/commit/74df6f192a5d123d291a90519805fd340282b97b
I mean it was already there before however the latest release of the VulkanSDK is causing problems with iPhones of "X" family. XS, XR and X
### System information
MacOS/iOS
### Issue description
So we have our custom Godot build which we use to package and ship our games. It's a mix of 4.3-stable with around 3 small changes and we use our internal CI to build it.
The latest build fetched version 1.3.296 build of Vulkan from here: https://vulkan.lunarg.com/sdk/home which caused iphones from X family to crash when using Vulkan renderer. Rolling back to 1.3.290 fixed the issue and I'm now fixing this version in the CI build not to unintentionally update it again.
### Steps to reproduce
Build an editor and ios template with latest CI jobs that will fetch this vulkan sdk version and it will crash in iphones from x family.
### Minimal reproduction project (MRP)
not applicable.
| bug,platform:ios,topic:buildsystem,topic:rendering,needs testing,crash,topic:export | low | Critical |
2,631,141,764 | PowerToys | Keyboard Manager bug on Lenovo X1 Carbon 20KGS0JW00 | ### Microsoft PowerToys version
0.85.1
### Installation method
PowerToys auto-update
### Running as admin
Yes
### Area(s) with issue?
Keyboard Manager
### Steps to reproduce
i try to remap three keys that is considered "Not defined" which are : the two keys at the right of my space (two Japanese key) and the third is the button on the left of my "Backspace" (the yen currency button).
i went through keyboard manager, remap key and add remapping with select so i can press the desired key to remap.
note that I use ENG interface in windows with French keyboard layout, as my default keyboard is QWERTY with Japanese layout. I am acquainted with AZERTY layout so i added and extra "sticker" on top of each keys for better visibility to match the AZERTY layout within my system.
### ✔️ Expected Behavior
Recognised key
### ❌ Actual Behavior
Undefined Key
### Other Software
OS : Microsoft Windows 11 Professional (x64) Build 22631.4317 (23H2)
LENOVO 20KGS0JW00
| Issue-Bug,Needs-Triage | low | Critical |
2,631,147,517 | neovim | gj/gk will move the view that fits the next/prev entire multi virtual line | ### Problem
When you copy some text file that has many long lines, after enable line-wraping, gj/gk will not move the view point by one virtual-line per keystroke but one entire line per keystroke, despite that cursor moves by one virtual-line per keystroke (that's what gj/gk aims for).
vscode-neovim does not suffer from this.
### Steps to reproduce
nvim -clean
set wrap
set scrolloff=6
paste some long lines
fire some gj
notice view point of last line jumps a few lines above depends on how many virtual lines needs to fit into screen at once.
https://github.com/user-attachments/assets/b1c3e69b-bff9-4e0a-b115-6882ee449f7b
### Expected behavior
one gj/gk should only move view point one line.
### Nvim version (nvim -v)
NVIM v0.11.0-dev-229+g6311a7fe4-dirty Build type: Release LuaJIT 2.1.1716656478 Run "nvim -V1 -v" for more inf
### Vim (not Nvim) behaves the same?
yes
### Operating system/version
macOS 11
### Terminal name/version
kitty
### $TERM environment variable
xterm-kitty
### Installation
build from source | enhancement,needs:vim-patch | low | Minor |
2,631,172,329 | godot | [3.x] Layout saving does not include the width specified in the tile viewer. | ### Tested versions
v3.6.stable.official [de2f0f147]
### System information
w10 64
### Issue description
Layout options do not include tile viewer spacing.
When you upload a layout, you will need to customize the tile viewer width again.
### Steps to reproduce
Sets a size for the width of the tile viewer.
Saves the layout.
Resizes the tile viewer.
Loads the layout.
The tile viewer does not return to the size it had when the layout was saved.
### Minimal reproduction project (MRP)
... | bug,topic:editor,usability | high | Minor |
2,631,181,442 | rust | Counter in slice iter fails to eliminate bounds check | The following code (somewhat extracted from #126425) includes an unreachable bounds check panic
```rs
pub fn getnonzero(buf: &[u8; 128]) -> &[u8] {
let mut curr = 0;
for n in buf.iter() {
if *n == 0 { break; }
curr += 1;
}
&buf[..curr]
}
```
https://godbolt.org/z/vzooGexnj
This bounds check can be eliminated: [Alive2](https://alive2.llvm.org/ce/z/_WGaJM)
This also occurs with reverse iteration (like in the original) and iterating `0..buf.len()` instead of direct slice iteration. Lowering the slice length to the point where the loop is fully unrolled does eliminate this, but the exact number depends on the specific code. | A-LLVM,I-slow,T-compiler,C-optimization | low | Minor |
2,631,184,211 | excalidraw | Unable to align frames | "Align" menu is empty when multiple frames are selected
This means currently one can align elements such as text, but not frames
| enhancement | low | Minor |
2,631,185,962 | excalidraw | Feature request: predefined frame sizes | Not sure if there is a better place for feature requests - if there is, please let me know so I can move this there!
## Predefined frame sizes
It would be great to be able to create frames at predefined sizes and proportions, such as 16:9 1080p or 4k
Basically allowing us to select a ratio and a size in pixels for frames.
## Auto align
A feature I also feel is missing is the ability to align elements while dragging them around the canvas.
In similar software, lines show up indicating alignment between close elements while dragging.
I feel this is critical for most use cases, from sketching UIs (where things will certainly be aligned) to graphs and all other kinds of canvases I can imagine wanting to build.
I basically don't think I'd ever want not to align things. | enhancement | low | Major |
2,631,199,426 | rust | Exponentially expanding type causes monomorphization in compiler to panic or run "forever" | The below code causes the compiler to panic or run forever, depending on how large the compiler `recursion_limit` setting is.
Here's a summary of code below: I have a trait `S` with associated type `S::Child: S`, and I define a struct `A: S` with `A::Child = (A,A)`, and I define `(X,X)::Child = (X::Child, X::Child)`. I define a function `uhoh<T: S>(x:T)` that recurses on `uhoh::<T::Child>`, and so trying to call `uhoh::<A>` results in the compiler needing to monomorphize at type `A`, `A::Child = (A,A)`, `A::Child::Child = ((A,A),(A,A))` etc, ad infinitum. Instead of giving an error as I would expect, the compiler panics or runs forever, depending on how large `recursion_limit` is.
The below code is a minimal reproduction of a real problem I ran into into a private code base.
<!--
Thank you for finding an Internal Compiler Error! 🧊 If possible, try to provide
a minimal verifiable example. You can read "Rust Bug Minimization Patterns" for
how to create smaller examples.
http://blog.pnkfx.org/blog/2019/11/18/rust-bug-minimization-patterns/
-->
### Code
Single file reproduction, just run with `cargo run`:
```Rust
// Outcomes of running `cargo run` for different recursion limits:
//
// 20 => panics quickly.
// 30 => panics after 2 minutes.
// default => runs for hours until I kill it.
#![recursion_limit = "20"]
trait S {
type Child: S;
fn children(&self) -> Vec<Self::Child>;
}
impl<X: S> S for (X, X) {
type Child = (X::Child, X::Child);
fn children(&self) -> Vec<Self::Child> {
vec![]
}
}
impl<X: S> S for Option<Box<X>> {
type Child = X;
fn children(&self) -> Vec<Self::Child> {
vec![]
}
}
type Data = Option<Box<(A, A)>>;
struct A {
data: Data,
}
impl S for A {
// When the recursion limit is set to 20, manually expanding the `Data::Child`
// type here makes the compilation fail with a "reached the recursion limit" error,
// as it should. But with the default recursion limit, the compilation hangs whether
// I manually expand the type here or not.
//
//type Child = (A, A);
type Child = <Data as S>::Child;
fn children(&self) -> Vec<Self::Child> {
self.data.children()
}
}
// The problem: this function can't be monomorphized when called with an
// argument of type `A`, because it recurses heterogenously on `A::Child =
// (A,A)`, which induces monomorphization at the type `(A,A)`, which recurses on
// `(A,A)::Child = ((A,A),(A,A))`, and so on, ad infinitum.
fn uhoh<T: S>(x: &T) {
let children = x.children();
println!("{}", children.len());
for child in &children {
uhoh(child);
}
}
fn main() {
let a = A { data: None };
uhoh(&a);
}
```
### Meta
<!--
If you're using the stable version of the compiler, you should also check if the
bug also exists in the beta or nightly versions.
-->
I encountered the real problem on 1.80.1, and tested the minimal reproduction above on 1.80.1, 1.82.0, and 1.84.0-nightly. I.e.
`rustc --version --verbose`:
```
rustc 1.80.1 (3f5fd8dd4 2024-08-06)
binary: rustc
commit-hash: 3f5fd8dd41153bc5fdca9427e9e05be2c767ba23
commit-date: 2024-08-06
host: x86_64-unknown-linux-gnu
release: 1.80.1
LLVM version: 18.1.7
```
and
```
rustc 1.82.0 (f6e511eec 2024-10-15)
binary: rustc
commit-hash: f6e511eec7342f59a25f7c0534f1dbea00d01b14
commit-date: 2024-10-15
host: x86_64-unknown-linux-gnu
release: 1.82.0
LLVM version: 19.1.1
```
and
```
rustc 1.84.0-nightly (b3f75cc87 2024-11-02)
binary: rustc
commit-hash: b3f75cc872cfd306860c3ad76a239e719015f855
commit-date: 2024-11-02
host: x86_64-unknown-linux-gnu
release: 1.84.0-nightly
LLVM version: 19.1.3
```
### Error output
Here's the output of `cargo build` on 1.84.0-nightly, with backtrace and huge type elided:
```
thread 'rustc' panicked at /rustc/b3f75cc872cfd306860c3ad76a239e719015f855/compiler/rustc_type_ir/src/ty_kind.rs:797:17:
type variables should not be hashed: ?0t
stack backtrace:
[backtrace, see below]
query stack during panic:
#0 [try_normalize_generic_arg_after_erasing_regions] normalizing `alloc::vec::Vec<<((((((((((((((((((((A, [a lot of `A`s and parens elided ...] as S>::Child>::len
#1 [collect_and_partition_mono_items] collect_and_partition_mono_items
end of query stack
```
Panic message asked me to attach this:
[rustc-ice-2024-11-03T12_59_37-2130395.txt](https://github.com/user-attachments/files/17610521/rustc-ice-2024-11-03T12_59_37-2130395.txt)
<!--
Include a backtrace in the code block by setting `RUST_BACKTRACE=1` in your
environment. E.g. `RUST_BACKTRACE=1 cargo build`.
-->
<details><summary><strong>Backtrace</strong></summary>
<p>
```
stack backtrace:
0: rust_begin_unwind
1: core::panicking::panic_fmt
2: <rustc_type_ir::ty_info::WithCachedTypeInfo<rustc_type_ir::ty_kind::TyKind<rustc_middle::ty::context::TyCtxt>> as rustc_data_structures::stable_hasher::HashStable<rustc_query_system::ich::hcx::StableHashingContext>>::hash_stable
3: <&rustc_middle::ty::list::RawList<(), rustc_middle::ty::Ty> as rustc_data_structures::stable_hasher::HashStable<rustc_query_system::ich::hcx::StableHashingContext>>::hash_stable
4: <rustc_type_ir::ty_info::WithCachedTypeInfo<rustc_type_ir::ty_kind::TyKind<rustc_middle::ty::context::TyCtxt>> as rustc_data_structures::stable_hasher::HashStable<rustc_query_system::ich::hcx::StableHashingContext>>::hash_stable
5: <&rustc_middle::ty::list::RawList<(), rustc_middle::ty::Ty> as rustc_data_structures::stable_hasher::HashStable<rustc_query_system::ich::hcx::StableHashingContext>>::hash_stable
6: <rustc_type_ir::ty_info::WithCachedTypeInfo<rustc_type_ir::ty_kind::TyKind<rustc_middle::ty::context::TyCtxt>> as rustc_data_structures::stable_hasher::HashStable<rustc_query_system::ich::hcx::StableHashingContext>>::hash_stable
7: <&rustc_middle::ty::list::RawList<(), rustc_middle::ty::Ty> as rustc_data_structures::stable_hasher::HashStable<rustc_query_system::ich::hcx::StableHashingContext>>::hash_stable
8: <rustc_type_ir::ty_info::WithCachedTypeInfo<rustc_type_ir::ty_kind::TyKind<rustc_middle::ty::context::TyCtxt>> as rustc_data_structures::stable_hasher::HashStable<rustc_query_system::ich::hcx::StableHashingContext>>::hash_stable
9: <&rustc_middle::ty::list::RawList<(), rustc_middle::ty::Ty> as rustc_data_structures::stable_hasher::HashStable<rustc_query_system::ich::hcx::StableHashingContext>>::hash_stable
10: <rustc_type_ir::ty_info::WithCachedTypeInfo<rustc_type_ir::ty_kind::TyKind<rustc_middle::ty::context::TyCtxt>> as rustc_data_structures::stable_hasher::HashStable<rustc_query_system::ich::hcx::StableHashingContext>>::hash_stable
11: <&rustc_middle::ty::list::RawList<(), rustc_middle::ty::Ty> as rustc_data_structures::stable_hasher::HashStable<rustc_query_system::ich::hcx::StableHashingContext>>::hash_stable
12: <rustc_type_ir::ty_info::WithCachedTypeInfo<rustc_type_ir::ty_kind::TyKind<rustc_middle::ty::context::TyCtxt>> as rustc_data_structures::stable_hasher::HashStable<rustc_query_system::ich::hcx::StableHashingContext>>::hash_stable
13: <&rustc_middle::ty::list::RawList<(), rustc_middle::ty::Ty> as rustc_data_structures::stable_hasher::HashStable<rustc_query_system::ich::hcx::StableHashingContext>>::hash_stable
14: <rustc_type_ir::ty_info::WithCachedTypeInfo<rustc_type_ir::ty_kind::TyKind<rustc_middle::ty::context::TyCtxt>> as rustc_data_structures::stable_hasher::HashStable<rustc_query_system::ich::hcx::StableHashingContext>>::hash_stable
15: <&rustc_middle::ty::list::RawList<(), rustc_middle::ty::Ty> as rustc_data_structures::stable_hasher::HashStable<rustc_query_system::ich::hcx::StableHashingContext>>::hash_stable
16: <rustc_type_ir::ty_info::WithCachedTypeInfo<rustc_type_ir::ty_kind::TyKind<rustc_middle::ty::context::TyCtxt>> as rustc_data_structures::stable_hasher::HashStable<rustc_query_system::ich::hcx::StableHashingContext>>::hash_stable
17: <&rustc_middle::ty::list::RawList<(), rustc_middle::ty::Ty> as rustc_data_structures::stable_hasher::HashStable<rustc_query_system::ich::hcx::StableHashingContext>>::hash_stable
18: <rustc_type_ir::ty_info::WithCachedTypeInfo<rustc_type_ir::ty_kind::TyKind<rustc_middle::ty::context::TyCtxt>> as rustc_data_structures::stable_hasher::HashStable<rustc_query_system::ich::hcx::StableHashingContext>>::hash_stable
19: <&rustc_middle::ty::list::RawList<(), rustc_middle::ty::Ty> as rustc_data_structures::stable_hasher::HashStable<rustc_query_system::ich::hcx::StableHashingContext>>::hash_stable
20: <rustc_type_ir::ty_info::WithCachedTypeInfo<rustc_type_ir::ty_kind::TyKind<rustc_middle::ty::context::TyCtxt>> as rustc_data_structures::stable_hasher::HashStable<rustc_query_system::ich::hcx::StableHashingContext>>::hash_stable
21: <&rustc_middle::ty::list::RawList<(), rustc_middle::ty::Ty> as rustc_data_structures::stable_hasher::HashStable<rustc_query_system::ich::hcx::StableHashingContext>>::hash_stable
22: <rustc_type_ir::ty_info::WithCachedTypeInfo<rustc_type_ir::ty_kind::TyKind<rustc_middle::ty::context::TyCtxt>> as rustc_data_structures::stable_hasher::HashStable<rustc_query_system::ich::hcx::StableHashingContext>>::hash_stable
23: <&rustc_middle::ty::list::RawList<(), rustc_middle::ty::Ty> as rustc_data_structures::stable_hasher::HashStable<rustc_query_system::ich::hcx::StableHashingContext>>::hash_stable
24: <rustc_type_ir::ty_info::WithCachedTypeInfo<rustc_type_ir::ty_kind::TyKind<rustc_middle::ty::context::TyCtxt>> as rustc_data_structures::stable_hasher::HashStable<rustc_query_system::ich::hcx::StableHashingContext>>::hash_stable
25: <&rustc_middle::ty::list::RawList<(), rustc_middle::ty::Ty> as rustc_data_structures::stable_hasher::HashStable<rustc_query_system::ich::hcx::StableHashingContext>>::hash_stable
26: <rustc_type_ir::ty_info::WithCachedTypeInfo<rustc_type_ir::ty_kind::TyKind<rustc_middle::ty::context::TyCtxt>> as rustc_data_structures::stable_hasher::HashStable<rustc_query_system::ich::hcx::StableHashingContext>>::hash_stable
27: <&rustc_middle::ty::list::RawList<(), rustc_middle::ty::Ty> as rustc_data_structures::stable_hasher::HashStable<rustc_query_system::ich::hcx::StableHashingContext>>::hash_stable
28: <rustc_type_ir::ty_info::WithCachedTypeInfo<rustc_type_ir::ty_kind::TyKind<rustc_middle::ty::context::TyCtxt>> as rustc_data_structures::stable_hasher::HashStable<rustc_query_system::ich::hcx::StableHashingContext>>::hash_stable
29: <&rustc_middle::ty::list::RawList<(), rustc_middle::ty::Ty> as rustc_data_structures::stable_hasher::HashStable<rustc_query_system::ich::hcx::StableHashingContext>>::hash_stable
30: <rustc_type_ir::ty_info::WithCachedTypeInfo<rustc_type_ir::ty_kind::TyKind<rustc_middle::ty::context::TyCtxt>> as rustc_data_structures::stable_hasher::HashStable<rustc_query_system::ich::hcx::StableHashingContext>>::hash_stable
31: <&rustc_middle::ty::list::RawList<(), rustc_middle::ty::Ty> as rustc_data_structures::stable_hasher::HashStable<rustc_query_system::ich::hcx::StableHashingContext>>::hash_stable
32: <rustc_type_ir::ty_info::WithCachedTypeInfo<rustc_type_ir::ty_kind::TyKind<rustc_middle::ty::context::TyCtxt>> as rustc_data_structures::stable_hasher::HashStable<rustc_query_system::ich::hcx::StableHashingContext>>::hash_stable
33: <&rustc_middle::ty::list::RawList<(), rustc_middle::ty::Ty> as rustc_data_structures::stable_hasher::HashStable<rustc_query_system::ich::hcx::StableHashingContext>>::hash_stable
34: <rustc_type_ir::ty_info::WithCachedTypeInfo<rustc_type_ir::ty_kind::TyKind<rustc_middle::ty::context::TyCtxt>> as rustc_data_structures::stable_hasher::HashStable<rustc_query_system::ich::hcx::StableHashingContext>>::hash_stable
35: <&rustc_middle::ty::list::RawList<(), rustc_middle::ty::Ty> as rustc_data_structures::stable_hasher::HashStable<rustc_query_system::ich::hcx::StableHashingContext>>::hash_stable
36: <rustc_type_ir::ty_info::WithCachedTypeInfo<rustc_type_ir::ty_kind::TyKind<rustc_middle::ty::context::TyCtxt>> as rustc_data_structures::stable_hasher::HashStable<rustc_query_system::ich::hcx::StableHashingContext>>::hash_stable
37: <&rustc_middle::ty::list::RawList<(), rustc_middle::ty::Ty> as rustc_data_structures::stable_hasher::HashStable<rustc_query_system::ich::hcx::StableHashingContext>>::hash_stable
38: <rustc_type_ir::ty_info::WithCachedTypeInfo<rustc_type_ir::ty_kind::TyKind<rustc_middle::ty::context::TyCtxt>> as rustc_data_structures::stable_hasher::HashStable<rustc_query_system::ich::hcx::StableHashingContext>>::hash_stable
39: <&rustc_middle::ty::list::RawList<(), rustc_middle::ty::Ty> as rustc_data_structures::stable_hasher::HashStable<rustc_query_system::ich::hcx::StableHashingContext>>::hash_stable
40: <rustc_type_ir::ty_info::WithCachedTypeInfo<rustc_type_ir::ty_kind::TyKind<rustc_middle::ty::context::TyCtxt>> as rustc_data_structures::stable_hasher::HashStable<rustc_query_system::ich::hcx::StableHashingContext>>::hash_stable
41: <&rustc_middle::ty::list::RawList<(), rustc_middle::ty::Ty> as rustc_data_structures::stable_hasher::HashStable<rustc_query_system::ich::hcx::StableHashingContext>>::hash_stable
42: <rustc_type_ir::ty_info::WithCachedTypeInfo<rustc_type_ir::ty_kind::TyKind<rustc_middle::ty::context::TyCtxt>> as rustc_data_structures::stable_hasher::HashStable<rustc_query_system::ich::hcx::StableHashingContext>>::hash_stable
43: <rustc_type_ir::ty_info::WithCachedTypeInfo<rustc_type_ir::ty_kind::TyKind<rustc_middle::ty::context::TyCtxt>> as rustc_data_structures::stable_hasher::HashStable<rustc_query_system::ich::hcx::StableHashingContext>>::hash_stable
44: <rustc_query_impl::query_impl::try_normalize_generic_arg_after_erasing_regions::dynamic_query::{closure#7} as core::ops::function::FnOnce<(&mut rustc_query_system::ich::hcx::StableHashingContext, &rustc_middle::query::erase::Erased<[u8; 8]>)>>::call_once
45: rustc_query_system::query::plumbing::try_execute_query::<rustc_query_impl::DynamicConfig<rustc_query_system::query::caches::DefaultCache<rustc_middle::ty::ParamEnvAnd<rustc_middle::ty::generic_args::GenericArg>, rustc_middle::query::erase::Erased<[u8; 8]>>, false, false, false>, rustc_query_impl::plumbing::QueryCtxt, true>
46: <rustc_middle::ty::normalize_erasing_regions::NormalizeAfterErasingRegionsFolder as rustc_type_ir::fold::TypeFolder<rustc_middle::ty::context::TyCtxt>>::fold_ty
47: rustc_monomorphize::collector::collect_items_rec::{closure#0}
48: rustc_monomorphize::collector::collect_items_rec
49: rustc_monomorphize::collector::collect_items_rec
50: rustc_monomorphize::collector::collect_items_rec
51: rustc_monomorphize::collector::collect_items_rec
52: rustc_monomorphize::collector::collect_items_rec
53: rustc_monomorphize::collector::collect_items_rec
54: rustc_monomorphize::collector::collect_items_rec
55: rustc_monomorphize::collector::collect_items_rec
56: rustc_monomorphize::collector::collect_items_rec
57: rustc_monomorphize::collector::collect_items_rec
58: rustc_monomorphize::collector::collect_items_rec
59: rustc_monomorphize::collector::collect_items_rec
60: rustc_monomorphize::collector::collect_items_rec
61: rustc_monomorphize::collector::collect_items_rec
62: rustc_monomorphize::collector::collect_items_rec
63: rustc_monomorphize::collector::collect_items_rec
64: rustc_monomorphize::collector::collect_items_rec
65: rustc_monomorphize::collector::collect_items_rec
66: rustc_monomorphize::collector::collect_items_rec
67: rustc_monomorphize::collector::collect_items_rec
68: rustc_monomorphize::collector::collect_items_rec
69: rustc_monomorphize::collector::collect_items_rec
70: rustc_monomorphize::partitioning::collect_and_partition_mono_items
[... omitted 2 frames ...]
71: <rustc_codegen_llvm::LlvmCodegenBackend as rustc_codegen_ssa::traits::backend::CodegenBackend>::codegen_crate
72: <rustc_interface::queries::Linker>::codegen_and_build_linker
73: rustc_interface::interface::run_compiler::<core::result::Result<(), rustc_span::ErrorGuaranteed>, rustc_driver_impl::run_compiler::{closure#0}>::{closure#1}
note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace.
```
</p>
</details>
| I-ICE,T-compiler,C-bug,I-monomorphization,A-monomorphization | low | Critical |
2,631,229,070 | PowerToys | Workspaces and game launchers | ### Microsoft PowerToys version
0.85.1
### Installation method
PowerToys auto-update
### Running as admin
Yes
### Area(s) with issue?
Workspaces
### Steps to reproduce
I log in daily to some MMOs to perform quick tasks. I open all of their launchers along with a txt file with pws for a couple and then log into each in turn. The games are The Elder Scrolls Online, Guild Wars 2, Lord of the Rings Online and Star Wars The Old Republic. 3 of the 4 are on Steam (only GW2 is not). I was hoping to make this a one-click process with Workspaces.
When I try to create a workspace with these - either by opening them first or during the Create Workspace process, none of them are recognized as open programs. Workspaces only sees notepad with the txt file. Keep in mind that these are just the launchers, not the games themselves (even I am not dumb enough to try to run 4 games at once). But still, they are running exes with icons in the dock.
Hoping there is an explanation or perhaps a fix in the works. I did not find anything after searching in Github, although I could easily have missed it.
### ✔️ Expected Behavior
I was expecting them to appear in Workspaces as running programs. Alas, they did not.
### ❌ Actual Behavior
Nothing happened and therein lies the problem. The Chrome instance on the left, in which I am writing this bug report, is on a second screen. You see notepad on the main screen but none of the launchers as shown in the provided image.
### Other Software
_No response_ | Issue-Bug,Needs-Triage,Product-Workspaces | low | Critical |
2,631,237,987 | pytorch | Suggestion : enable one to adjust the interval between calls to the pytorch NCCL watchdog thread via env variable | ### 🚀 The feature, motivation and pitch
While looking at sources of performance variability for multi-node training jobs, we have found that one mechanism is associated with activity of the pytorch NCCL watchdog thread. From profiles gathered with NVIDIA's NSight Systems (nsys profile) we see that the watchdog thread does some checking every 100 msec. The watchdog thread can introduce a small timing delay in launching the next NCCL kernels. Although the delay is small, the net watchdog activity can be noticeable because watchdog disturbances occur in a pseudo-random manner across process distributed over many nodes. Perhaps it is not necessary to have the watchdog check every 100 msec. A possible mechanism to provide some user control would be to add a TORCH_NCCL_ env variable to set the interval between calls, with reasonable limits such as every 100 - 1000 msec. This would enable one to reduce the impact of watchdog threads on timing variations.
### Alternatives
_No response_
### Additional context
_No response_
cc @H-Huang @awgu @kwen2501 @wanchaol @fegin @fduwjj @wz337 @wconstab @d4l3k @c-p-i-o | oncall: distributed | low | Major |
2,631,258,282 | ollama | HIP_VISIBLE_DEVICES vs ROCR_VISIBLE_DEVICES | ### What is the issue?
I have 8 AMD 7900XTX cards in llama.cpp to limit access to certain GPUs, I use the HIP_VISIBLE_DEVICES command and it works correctly. However, if I want to limit GPU access for Ollama, I get an error with llama3.2-vision. To make it work correctly, I have to give it access to all GPUs and then limit access via ROCR_VISIBLE_DEVICES.
### OS
Linux
### GPU
AMD
### CPU
AMD
### Ollama version
0.4.0-pre | bug,amd,needs more info | low | Critical |
2,631,279,295 | tauri | [bug] Issue with app.handle().exit(0) Not Working When Running as Windows Service | ### Describe the bug
I am currently running my Tauri app as a Windows service (without a window), and I am encountering an issue when trying to close the app using the app.handle().exit(0) command.
### Reproduction
https://github.com/arihav/tauri-app-example
### Expected behavior
The app should exit successfully without any issues.
### Full `tauri info` output
```text
[✔] Environment
- OS: Windows 10.0.22631 x86_64 (X64)
✔ WebView2: 130.0.2849.56
✔ MSVC: Visual Studio Build Tools 2022
✔ rustc: 1.79.0 (129f3b996 2024-06-10)
✔ cargo: 1.79.0 (ffa9cf99a 2024-06-03)
✔ rustup: 1.27.1 (54dd3d00f 2024-04-24)
✔ Rust toolchain: stable-x86_64-pc-windows-msvc (environment override by RUSTUP_TOOLCHAIN)
- node: 21.1.0
- yarn: 1.22.22
- npm: 10.2.0
[-] Packages
- tauri 🦀: git+https://github.com/tauri-apps/tauri?rev=ae024b829972609ac565e54bf4b03d4e4b5e2524#ae024b829972609ac565e54bf4b03d4e4b5e2524 (2.0.6)
- tauri-build 🦀: No version detected
- wry 🦀: 0.46.3
- tao 🦀: 0.30.3
- tauri-cli 🦀: 2.0.4
- @tauri-apps/api : 1.6.0 (outdated, latest: 2.0.3)
- @tauri-apps/cli : 2.0.4
[-] Plugins
- tauri-plugin-log 🦀: 2.0.1
- @tauri-apps/plugin-log : 2.0.0
- tauri-plugin-autostart 🦀: 2.0.1
- @tauri-apps/plugin-autostart : 2.0.0
- tauri-plugin-localhost 🦀: 2.0.1
- @tauri-apps/plugin-localhost : not installed!
[-] App
- build-type: bundle
- CSP: unset
- frontendDist: ../out
- devUrl: http://localhost:3002/
- framework: React (Next.js)
- bundler: Webpack
```
### Stack trace
_No response_
### Additional context
The exit process should trigger two events: RunEvent::ExitRequested and RunEvent::Exit. Currently, RunEvent::ExitRequested is called, but RunEvent::Exit is not. I think the issue might be occurring within the event loop of TAO. | type: bug,platform: Windows,status: needs triage | low | Critical |
2,631,287,708 | PowerToys | EXR and HDR Thumbnail Support | ### Description of the new feature / enhancement
Is there anyone who contributes that could add EXR and HDR image thumbnail support to PowerToys? Perhaps there are more 32bit image filetypes that could be integrated also.
I feel like this is something that has been requested to Microsoft for quite some time without any result.
### Scenario when this would be used?
In File Explorer it would be great to see preview thumbnails of .exr files. And perhaps .hdr image files too. These are image file formats often used by VFX professionals but thumbnails for these are not native supported in Windows 11 - despite EXR being an open source file format (as far as I am aware).
### Supporting information
_No response_ | Needs-Triage | low | Minor |
2,631,289,516 | bitcoin | guix: Linux and macOS builds are not cross-arch reproducible with powerpc64le build arch | ### Is there an existing issue for this?
- [X] I have searched the existing issues
### Current behaviour
The Guix output hashes for Windows and the source tarball match between my powerpc64le build machine and the official binaries, but the hashes for macOS and Linux do not match.
This seems to be a partial regression from 27.1, where Windows, Linux, and the source tarball all matched for me. macOS did not even build without errors for 27.1 on powerpc64le (that is at least fixed in 28.0), so I have nothing to compare there.
It is not clear to me whether the root cause might be the same as the converse problem referenced in https://github.com/bitcoin/bitcoin/pull/27897 (powerpc64le hashes didn't match between x86_64 and aarch64 build machines).
(Maybe I've done something stupid here, but I definitely can't tell what I would have done wrong, and the different behavior from 27.1 certainly *seems* like I've hit a real bug.)
### Expected behaviour
All Guix output hashes should match between my powerpc64le build machine and the official binaries.
### Steps to reproduce
1. Build Bitcoin Core via `./contrib/guix/guix-build`
2. Compare results against the `guix-sigs` repo (I used pinheadmz's Guix sigs as a reference).
### Relevant log output
Hashes from my powerpc64le build machine:
```
3908cbe1339fc10a220e9634629b6937dba77de926bf8dd618283fd090c61f5e bitcoin-28.0-aarch64-linux-gnu-debug.tar.gz
1e58898a1b48296fd7e31ddf96c248a0a45c07709d980e3dadfd66ab9e5d2845 bitcoin-28.0-aarch64-linux-gnu.tar.gz
dbbb90b05c2e390ba6130cac074135a52c83dcc762a28257de1abfe89d69675f bitcoin-28.0-arm-linux-gnueabihf-debug.tar.gz
54a30faa5a61f628d890f464c48def63858eca9b655873f1e60c4e220af41c2e bitcoin-28.0-arm-linux-gnueabihf.tar.gz
da85a7758d272ca5ea345a2b549147acfbbdf61c556c98dc4f49e8f7a27af30d bitcoin-28.0-arm64-apple-darwin-unsigned.tar.gz
c24ff655b0cbbdc116b19474fa621b1c803e3af25f3e540ea10d53a9ba9c4a2d bitcoin-28.0-arm64-apple-darwin-unsigned.zip
17033ff17cb91c09cf27fefb42801a584844385b2c6c50902ae63cebb7fc632e bitcoin-28.0-arm64-apple-darwin.tar.gz
700ae2d1e204602eb07f2779a6e6669893bc96c0dca290593f80ff8e102ff37f bitcoin-28.0.tar.gz
a182b39beb4603c3cad55f9f45eaae730eaa1a8c5ee26718707a35554d28654a bitcoin-28.0-powerpc64-linux-gnu-debug.tar.gz
252a1e89b369ce1895a58ae4425c765e6c654214550e14245f6bdb84ec161c2b bitcoin-28.0-powerpc64-linux-gnu.tar.gz
cf4cbfa876142bfdb4c781271cd9a1a5410e6cb6e7f0e3996eb67bf08909d4ef bitcoin-28.0-riscv64-linux-gnu-debug.tar.gz
fd91dee4518444891549d41f995ef007ae81a426cc5914a4767f1d4410eb1103 bitcoin-28.0-riscv64-linux-gnu.tar.gz
a98b0fdddcd71fdc16d29d3c4cc95baf408cc2210e23aa96fa1b808267a25387 bitcoin-28.0-x86_64-apple-darwin-unsigned.tar.gz
898f790d4941e106158ba2c38f8cb439a6e1e4f58cad8c9cd86dd0ddff08d117 bitcoin-28.0-x86_64-apple-darwin-unsigned.zip
d2c74eebfa6ac1e7ce64b986cbbd28e4838bd8abf2de70493d971b373d559044 bitcoin-28.0-x86_64-apple-darwin.tar.gz
3b5808f3070e88b5f6eee25678d80f4159827ea391abb0ee25ba96af2a598f75 bitcoin-28.0-x86_64-linux-gnu-debug.tar.gz
ffa78c8e87ea20f13780e780589351484fd22defdabb6aa3234d48f9518104a1 bitcoin-28.0-x86_64-linux-gnu.tar.gz
8990def2e611323d4c7a8cf17187a138dca64f98fc0ecebda0a3e999dbdd083d bitcoin-28.0-win64-debug.zip
d8170c342ac049fab953f87841cbbba6c0e3f277703ddc29c678b6ab93dae966 bitcoin-28.0-win64-setup-unsigned.exe
8ec39e7bf66ea419ea79e5f1b7bee1b03a28b51ddd1daa6e167bff6abac0a5d2 bitcoin-28.0-win64-unsigned.tar.gz
85282f4ec1bcb0cfe8db0f195e8e0f6fb77cfbe89242a81fff2bc2e9292f7acf bitcoin-28.0-win64.zip
```
For comparison, see https://github.com/bitcoin-core/guix.sigs/blob/main/28.0/pinheadmz/noncodesigned.SHA256SUMS
I would be happy to upload my binaries and/or run diffoscope on request. I would also be happy to run Guix builds of additional commits on my powerpc64le machine if there are commits that seem likely to be the culprit.
### How did you obtain Bitcoin Core
Compiled from source
### What version of Bitcoin Core are you using?
v28.0
### Operating system and version
Debian 12.7 running inside KVM; host is also Debian 12.7
### Machine specifications
powerpc64le; HDD; wired network on residential Internet connection. | Build system | low | Critical |
2,631,293,002 | pytorch | nn.LSTM documentation | ### 📚 The doc issue
Hi. Could you please check if there are any inaccuracies in the documentation of [nn.LSTM](https://pytorch.org/docs/stable/generated/torch.nn.LSTM.html#torch.nn.LSTM) related to the main description and output:
### **main description**:
> If `proj_size > 0` is specified, LSTM with projections will be used. This changes the LSTM cell in the following way. First, the dimension of $h_{t}$ will be changed from `hidden_size` to `proj_size` (dimensions of $W_{hi}$ will be changed accordingly).
Second, the output hidden state of each layer will be multiplied by a learnable projection matrix: $h_{t}=W_{hr}h_{t}$.
From the description it may seem that the projection applies only to output hidden state (after the last step), but in fact, judging by the size of **output**, it is applied after each step.
Also it is probably necessary to indicate that the dimensions also change for matrices **W_hf|W_hg|W_ho|W_ii|W_if|W_ig|W_io** (not only for $W_{hi}$) as can be seen from the description **weight_ih_l[k]** и **weight_hh_l[k]**.
the description should probably be:
> If `proj_size > 0` is specified, LSTM with projections will be used. This changes the LSTM cell in the following way.
The dimension of hidden state of each step of each layer will be changed from `hidden_size` to `proj_size` by multiplying by a learnable projection matrix: $h_{t}=W_{hr}h_{t}$ (dimensions of other matrices will be changed accordingly).
### **h_0**, **c_0**:
> tensor of shape ... for unbatched input or ... containing the final hidden state for each element in the sequence.
In fact, it does not contain a hidden state for each element of the sequence (only for the last element, that is, the last step).
> When bidirectional=True, h_n will contain a concatenation of the final forward and reverse hidden states, respectively.
Perhaps it would be better to clarify that the concatenation is along the 1st axis so that it is not analogous to the concatenation for `output` where the output directions are concatenated for each step.
Or remove word 'concatenation' since it doesn't actually happen (the hidden vectors of the forward and backward passes are simply enumerated along the 1st axis)
### Suggest a potential alternative/fix
_No response_
cc @albanD @mruberry @jbschlosser @walterddr @mikaylagawarecki | module: nn,triaged,topic: docs | low | Minor |
2,631,341,857 | node | napi_threadsafe_function is very hard to use safely | ### Version
v22.10.0
### Platform
```text
Linux s7 5.15.0-69-generic #76-Ubuntu SMP Fri Mar 17 17:19:29 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
```
### Subsystem
node-api
### What steps will reproduce the bug?
The handle obtained with `napi_create_threadsafe_function` is supposed to be usable by arbitrary threads.
In particular, the following operations should be safe to call from arbitrary threads (until that thread calls `napi_release_threadsafe_function` or receives `napi_closing` from `napi_call_threadsafe_function`):
`napi_get_threadsafe_function_context`, `napi_call_threadsafe_function`, `napi_acquire_threadsafe_function`, and `napi_release_threadsafe_function`.
However, this is currently not the case.
In particular, in the face of Node.js environment shutdown there are data races and use-after-frees that occur when threads call any of these functions during or after the cleanup that happens when the Node.js environment shuts down.
There are two main issues I already found:
- During finalization, the queue is accessed without holding its mutex [here](https://github.com/nodejs/node/blob/b38e3124862f7623fd8e8f0a9b738065d9296a74/src/node_api.cc#L300)
- If another thread calls `napi_call_threadsafe_function` concurrently, this leads to a data race on the queue internals [here](https://github.com/nodejs/node/blob/b38e3124862f7623fd8e8f0a9b738065d9296a74/src/node_api.cc#L243)
- At the end of finalization, the whole internal state is just deleted [here](https://github.com/nodejs/node/blob/4f5db8b26d906f1cbe9f6a9ac2028b0f7ad88c91/src/node_api.cc#L303) even if there are still threads holding handles to the tsnf.
- Afterwards each use of any of the above-mentioned functions is a use-after-free bug
See https://github.com/mika-fischer/node-bug-napi-tsfn for a detailed reproduction of the issue on Linux using valgrind
While working around this is technically possible (see [src/run/fixed.hpp](https://github.com/mika-fischer/node-bug-napi-tsfn/blob/main/src/run_fixed.hpp)) it involves attaching a finalizer in order to track the finalization state in an external flag, whose lifetime must be managed via a shared_ptr or similar and all access to the TSFN must be protected by another mutex (or read-write-lock). This makes the whole thing very unergonomic to use and I'm pretty sure nobody will jump through these hoops.
It should also be relatively easy to fix and not break API or ABI
### How often does it reproduce? Is there a required condition?
Always
### What is the expected behavior? Why is that the expected behavior?
- Finalization should lock the mutex to make concurrent calls safe.
- Finalization should put the TSFN into a state where all its resources are released, but *only* delete the actual TSFN object if there are no more handles to it. Otherwise the actual deletion should be deferred until one of `napi_release_threadsafe_function` or `napi_call_threadsafe_function` decreases the thread_count to zero.
- In this finalized-but-not-yet deleted state, the operations mentioned above should work as follows:
- `napi_get_threadsafe_function_context` should return the stored context pointer as usual
- `napi_call_threadsafe_function` should return `napi_closing`, decrease the thread_count and if it falls to zero delete the TSFN
- `napi_acquire_threadsafe_function` should return `napi_closing`
- `napi_release_threadsafe_function` should return `napi_ok`, decrease the thread_count and if it falls to zero delete the TSFN
### What do you see instead?
data races & use-after-frees leading to crashes
### Additional information
_No response_ | node-api | low | Critical |
2,631,372,790 | TypeScript | The error for allowImportingTsExtensions does not reference rewriteRelativeImportExtensions | ### 🔎 Search Terms
- error TS5096
- allowImportingTsExtensions
- rewriteRelativeImportExtensions
- tsconfig
- diagnostics
- intellisense
### 🕗 Version & Regression Information
- This changed between versions N/A and 5.7.0-beta
- This changed in commit or PR https://github.com/microsoft/TypeScript/pull/59767
- This is the behavior in every version I tried, and I reviewed the FAQ for entries for `allowImportingTsExtensions` and `rewriteRelativeImportExtensions`
- I was unable to test this on prior versions because it was only introduced in 5.7
### ⏯ Playground Link
_No response_
### 💻 Code
tsconfig.json with diagnostic error:
```json
{
"compilerOptions": {
"module": "Node16",
"moduleResolution": "Node16",
"allowImportingTsExtensions": true,
}
}
```
### 🙁 Actual behavior
When specifying `allowImportingTsExtensions` as above, I get an error, as intended:
```
tsconfig.json:5:35 - error TS5096: Option 'allowImportingTsExtensions' can only be used when either 'noEmit' or 'emitDeclarationOnly' is set.
```
However, if I add `"rewriteRelativeImportExtensions": true` to the same tsconfig, the error goes away, which is contrary to the error message.
The _behavior_ seems correct, but the error message seems incomplete or inconsistent.
---
At the same time, intellisense for `allowImportingTsExtensions` in VSCode reports:
> Allow imports to include TypeScript file extensions. Requires '--moduleResolution bundler' and either '--noEmit' or '--emitDeclarationOnly' to be set.
This is only mentioned as a requirement in intellisense, but not in the error message.
### 🙂 Expected behavior
I would expect the message to reference `rewriteRelativeImportExtensions` as one of the conditions that allow for `allowImportingTsExtensions`.
I am not sure whether `--moduleResolution bundler` is required, but at least unifying the intellisense and diagnostic would be good.
The combination of factors seems to be "`noEmit` or `emitDeclarationOnly` or `rewriteRelativeImportExtensions`", but I am not sure what the exact new diagnostic message should be 😅
(I don't mean to be nitpicky! I tend to learn best from intellisense and the diagnostics errors, so I was on the lookout for them when trying out the `5.7.0-beta` and `rewriteRelativeImportExtensions` 😌)
### Additional information about the issue
_No response_ | Suggestion,Help Wanted | low | Critical |
2,631,376,785 | neovim | Treesitter `on_changedtree` has no changes if lines are dropped | ### Problem
The `on_changedtree` callback gets called, but the table of ranges if empty if lines were removed. If the lines were instead changed or new ones added there will be ranges.
### Steps to reproduce
Take this `init.lua` file:
```lua
local ts = vim.treesitter
local parser = ts.get_parser(0, 'lua')
parser:register_cbs {
on_changedtree = function(changes, tree)
print(vim.inspect(changes), vim.inspect(tree))
end
}
vim.treesitter.start()
```
Now open this Lua file:
```lua
print {
{
},
{
},
}
```
Execute this command: `%s/\v\{\n\s+/{` to remove the line break after the opening brace. The callback will print `{}, <userdata 1>`. On the other hand, if we add an extra line break (`%s/\v\{\n\s+/{\r\r`) or even a space (`%s/\v\{/{ ` note the trailing space) we do get ranges.
### Expected behavior
Something should be reported since we are not merely deleting lines. In my example the existing lines do change, so I would expect to at least get ranges for them.
### Nvim version (nvim -v)
NVIM v0.10.2
### Vim (not Nvim) behaves the same?
N/A
### Operating system/version
Void Linux
### Terminal name/version
alacritty 0.14.0
### $TERM environment variable
alacritty
### Installation
Void repos | bug,treesitter | low | Minor |
2,631,403,242 | next.js | next dev with --turbo flag bug with "paths": {"*": ["types/*.d.ts"]} in tsconfig.json | ### Link to the code that reproduces this issue
https://github.com/Yohannfra/turbo-bug-reproduction-repo
### To Reproduce
1. Clone the linked repository
2. pnpm install && pnpm run dev
3. open localhost:3000
You will see this error message
```
✓ Ready in 679ms
⨯ src/i18n/routing.ts (8:24) @ [project]/src/i18n/routing.ts [middleware] (ecmascript)
⨯ Error: defineRouting is not defined
at <unknown> ([project]/src/i18n/routing.ts [middleware] (ecmascript) (./src/i18n/routing.ts:8:24)
at <unknown> (./[turbopack]/browser/runtime/base/dev-base.ts:205:21)
at runModuleExecutionHooks (./[turbopack]/browser/runtime/base/dev-base.ts:264:5)
at instantiateModule (./[turbopack]/browser/runtime/base/dev-base.ts:203:5)
at getOrInstantiateModuleFromParent (./[turbopack]/browser/runtime/base/dev-base.ts:132:10)
at esmImport (./[turbopack]/shared/runtime-utils.ts:214:18)
at <unknown> ([project]/src/middleware.ts [middleware] (ecmascript) (./src/middleware.ts:3:1)
at <unknown> (./[turbopack]/browser/runtime/base/dev-base.ts:205:21)
at runModuleExecutionHooks (./[turbopack]/browser/runtime/base/dev-base.ts:264:5)
at instantiateModule (./[turbopack]/browser/runtime/base/dev-base.ts:203:5) {
digest: undefined
}
6 | export const locales: LocaleType[] = ['fr', 'en', 'es', 'it', 'nl', 'de']
7 |
> 8 | export const routing = defineRouting({
| ^
9 | // A list of all locales that are supported
10 | locales: locales,
11 |
✓ Compiled /_error in 401ms
GET / 404 in 2ms
○ Compiling /_not-found/page ...
✓ Compiled /_not-found/page in 701ms
⨯ src/i18n/routing.ts (8:24) @ [project]/src/i18n/routing.ts [middleware] (ecmascript)
⨯ Error: defineRouting is not defined
at <unknown> ([project]/src/i18n/routing.ts [middleware] (ecmascript) (./src/i18n/routing.ts:8:24)
at <unknown> (./[turbopack]/browser/runtime/base/dev-base.ts:205:21)
at runModuleExecutionHooks (./[turbopack]/browser/runtime/base/dev-base.ts:264:5)
at instantiateModule (./[turbopack]/browser/runtime/base/dev-base.ts:203:5)
at getOrInstantiateModuleFromParent (./[turbopack]/browser/runtime/base/dev-base.ts:132:10)
at esmImport (./[turbopack]/shared/runtime-utils.ts:214:18)
at <unknown> ([project]/src/middleware.ts [middleware] (ecmascript) (./src/middleware.ts:3:1)
at <unknown> (./[turbopack]/browser/runtime/base/dev-base.ts:205:21)
at runModuleExecutionHooks (./[turbopack]/browser/runtime/base/dev-base.ts:264:5)
at instantiateModule (./[turbopack]/browser/runtime/base/dev-base.ts:203:5) {
digest: undefined
}
6 | export const locales: LocaleType[] = ['fr', 'en', 'es', 'it', 'nl', 'de']
7 |
> 8 | export const routing = defineRouting({
| ^
9 | // A list of all locales that are supported
10 | locales: locales,
11 |
GET /en 404 in 2ms
```
### Current vs. Expected behavior
This error doesn't exists without **--turbo** and the project run as expected.
Also after a *long* debugging session to find where this came from I found that this line in my tsconfig.json was causing it:
```json
"paths": {"*": ["types/*.d.ts"]}
```
### Provide environment information
```bash
Operating System:
Platform: darwin
Arch: arm64
Version: Darwin Kernel Version 23.6.0: Mon Jul 29 21:13:04 PDT 2024; root:xnu-10063.141.2~1/RELEASE_ARM64_T6020
Available memory (MB): 16384
Available CPU cores: 10
Binaries:
Node: 20.18.0
npm: 10.8.2
Yarn: N/A
pnpm: 9.12.1
Relevant Packages:
next: 15.0.2 // Latest available version is detected (15.0.2).
eslint-config-next: N/A
react: 19.0.0-rc.0
react-dom: 19.0.0-rc.0
typescript: 5.6.3
Next.js Config:
output: N/A
-----
I also have the exact same bug on a my laptop running Ubuntu 22 and my intel Mac so I don't think the platform matters
```
### Which area(s) are affected? (Select all that apply)
Turbopack
### Which stage(s) are affected? (Select all that apply)
next dev (local)
### Additional context
_No response_ | bug,Turbopack | low | Critical |
2,631,408,206 | next.js | Webpack hydration freeze and debug. | ### Link to the code that reproduces this issue
https://github.com/ItzzLincler/next-bug
### To Reproduce
create a new next app 14@latest / 15.0.2
run 'full stack debug'
`UPDATE: while I was creating a new project to upload for the reproduction of the bug. I managed to deduce that my hydration problem only occurres when there is a breakpoint on the client side (even though VS-code shows it isn't binding).
maybe my vs-code is borked, I tried uninstalling a bunch of extensions but that didn't solve it either...
`
I don't know what else used to work fine in the past. I haven't touched next in a few months. v14 used to work fine on my PC.
I have no idea if you can reproduce it, but I don't know what to do at this point. I wasted so much time trying to play with the packge/launch.json to get it to work but to no avail....
### Current vs. Expected behavior
When you run dev mode without turbo next is extremely slow at compiling a page and when you go to the page is stuck at hydration and is not responding to any input.
When you run it with turbo next works as expected but client-side debugging doesn't work from VS-Code, It only works when you place a breakpoint in the developers tab of the browser.
### Provide environment information
```bash
OS:
Win10 - 19045
X64 AMD 5800x
32GB DDR4
packge.json:
{
"name": "my-next-app",
"version": "0.1.0",
"private": true,
"scripts": {
"dev": "next dev",
"build": "next build",
"start": "next start",
"lint": "next lint"
},
"dependencies": {
"@radix-ui/react-icons": "^1.3.1",
"@radix-ui/react-slot": "^1.1.0",
"@radix-ui/react-tabs": "^1.1.1",
"class-variance-authority": "^0.7.0",
"clsx": "^2.1.1",
"dotenv": "^16.4.5",
"drizzle-orm": "^0.36.0",
"lucide-react": "^0.454.0",
"next": "14.2.16",
"pg": "^8.13.1",
"react": "^18",
"react-dom": "^18",
"tailwind-merge": "^2.5.4",
"tailwindcss-animate": "^1.0.7"
},
"devDependencies": {
"@types/node": "^20",
"@types/pg": "^8.11.10",
"@types/react": "^18",
"@types/react-dom": "^18",
"drizzle-kit": "^0.27.1",
"postcss": "^8",
"tailwindcss": "^3.4.1",
"tsx": "^4.19.2",
"typescript": "^5"
}
}
launch.json:
{
"version": "0.2.0",
"configurations": [
{
"name": "Next.js: debug server-side",
"type": "node-terminal",
"request": "launch",
"command": "npm run dev"
},
{
"name": "Next.js: debug client-side",
"type": "chrome",
"request": "launch",
"url": "http://localhost:3000"
},
{
"name": "Next.js: debug full stack",
"type": "node-terminal",
"request": "launch",
"command": "npm run dev",
"serverReadyAction": {
"pattern": "- Local:.+(https?://.+)",
"uriFormat": "%s",
"action": "debugWithChrome"
}
}
]
}
```
### Which area(s) are affected? (Select all that apply)
Developer Experience, Turbopack, Webpack
### Which stage(s) are affected? (Select all that apply)
next dev (local)
### Additional context
_No response_ | bug,Webpack,Turbopack | low | Critical |
2,631,451,471 | rust | Tracking issue for release notes of #129347: #[inline(never)] does not work for async functions |
This issue tracks the release notes text for #129347.
### Steps
- [ ] Proposed text is drafted by PR author (or team) making the noteworthy change.
- [ ] Issue is nominated for release team review of clarity for wider audience.
- [ ] Release team includes text in release notes/blog posts.
### Release notes text
The responsible team for the underlying change should edit this section to replace the automatically generated link with a succinct description of what changed, drawing upon text proposed by the author (either in discussion or through direct editing).
````markdown
# Category (e.g. Language, Compiler, Libraries, Compatibility notes, ...)
- [#[inline(never)] does not work for async functions](https://github.com/rust-lang/rust/issues/129347)
````
> [!TIP]
> Use the [previous releases](https://doc.rust-lang.org/nightly/releases.html) categories to help choose which one(s) to use.
> The category will be de-duplicated with all the other ones by the release team.
>
> *More than one section can be included if needed.*
### Release blog section
If the change is notable enough for inclusion in the blog post, the responsible team should add content to this section.
*Otherwise leave it empty.*
````markdown
````
cc @michaelwoerister -- origin issue/PR authors and assignees for starting to draft text
| A-LLVM,A-codegen,T-lang,relnotes,A-async-await,relnotes-tracking-issue | low | Minor |
2,631,469,130 | rust | tweak search result order | a search for [`Result::Ok`](https://doc.rust-lang.org/nightly/std/index.html?search=Result%3A%3AOk) will show first the method `result::Result::ok`, then several aliases such as `io::Result::Ok`, then `result::Result::Ok`, then more aliases.
there are two changes required to present a more logical order:
* [ ] prioritize variants over methods (inspired by [this discussion](https://github.com/rust-lang/rust/pull/132569#issuecomment-2453571537))
* [ ] de-prioritize type aliases and variants/fields thereof.
| T-rustdoc,C-enhancement,A-rustdoc-search | low | Minor |
2,631,483,303 | rust | temporary value dropped while borrowed | ### Code
I tried this code:
```rust
pub const fn concat(_x: &[u8], _y: &[u8]) -> [u8; 1024] {
[0u8; 1024]
}
const _: &[u8] = &concat(
if b"".len() > 0 {
&concat(b"", b"")
} else {
b""
},
b""
);
```
I expected to see this happen: compiles
Instead, this happened: fails to compile with the following error:
```
error[E0716]: temporary value dropped while borrowed
--> <source>:7:10
|
5 | const _: &[u8] = &concat(
| ------ borrow later used by call
6 | if b"".len() > 0 {
7 | &concat(b"", b"")
| ^^^^^^^^^^^^^^^^ creates a temporary value which is freed while still in use
8 | } else {
| - temporary value is freed at the end of this statement
|
= note: consider using a `let` binding to create a longer lived value
```
### Version it worked on
It most recently worked on: 1.78.0
### Version with regression
<!--
Provide the version you are using that has the regression.
-->
`rustc --version --verbose`:
```
rustc 1.79.0 (129f3b996 2024-06-10)
```
@rustbot modify labels: +regression-from-stable-to-stable -regression-untriaged
| T-compiler,regression-from-stable-to-stable,C-bug,WG-const-eval | low | Critical |
2,631,494,257 | excalidraw | Change keybind for panning | The 3 ways of panning I am aware of are h, middle mouse, and spacebar.
I have a split keyboard and the spacebar and h key are located on the right keyboard and mouse is accessible with my right hand only. This means I can't pan without putting my stylus down and either pushing the spacebar, h key, or mouse with my right hand.
Other keybinds work in combination with a stylus because they are located on the left side of the keyboard: text is on t, brush is on x, eraser is on e, arrow is on a.
I looked at another issue and it doesn't seem like keyboard shortcuts will be added soon, but I want to open this issue to potentially get a better keybind for panning specifically that is located on the left side of the keyboard. | keyboard | low | Minor |
2,631,505,523 | godot | WebRTCMultiplayerPeer reports as server when initialized with create_client | ### Tested versions
- Reproduced in v4.3.stable.official [77dcf97d8]
### System information
Godot v4.3.stable - macOS 15.0.0 - GLES3 (Compatibility) - Intel(R) Iris(TM) Plus Graphics OpenGL Engine - Intel(R) Core(TM) i7-1068NG7 CPU @ 2.30GHz (8 Threads)
### Issue description
**tldr**: When using `WebRTCMultiplayerPeer` initialized with `create_client`, the `multiplayer.is_server()` call can return true after the connection to the server is closed.
This seems to happen if a client-server connection is established, and then the server is disconnected. [`WebRTCMultiplayerPeer::get_unique_id()` will return 1, regardless of the network mode](https://github.com/godotengine/godot/blob/1bffd6c73b44b85e5889f54e14b2193940cf5bb1/modules/webrtc/webrtc_multiplayer_peer.cpp#L256). Before the disconnect, `multiplayer.is_server()` will return `false`. When a disconnect happens, it will start returning `true` ( [because it compares the result of `get_unique_id` to 1](https://github.com/godotengine/godot/blob/1bffd6c73b44b85e5889f54e14b2193940cf5bb1/scene/main/multiplayer_api.h#L76) )
Two issues with this are:
- this is undocumented
- there seems to be an inconsistency in behaviour with other multiplayer peers (e.g. [WebSocketMultiplayerPeer](https://github.com/godotengine/godot/blob/1bffd6c73b44b85e5889f54e14b2193940cf5bb1/modules/websocket/websocket_multiplayer_peer.cpp#L173) will never flip; [ENetMultiplayerPeer](https://github.com/godotengine/godot/blob/1bffd6c73b44b85e5889f54e14b2193940cf5bb1/modules/enet/enet_multiplayer_peer.cpp#L439) I think would flip in the opposite direction when inactive)
I spotted this because I was relying on `multiplayer.is_server()` to determine when to make some RPC calls, or which signals to subscribe to. There is an error message about the disconnect state, but it was not obvious that it would affect the network mode reporting.
While this seems like a bug to me, I don't know enough about Godot or WebRTC to be confident this needs a change. If you think this is not an issue, I'm happy to open a godot-docs PR to clarify this behaviour.
### Steps to reproduce
- Create a new multiplayer peer: `var rtc_mp = WebRTCMultiplayerPeer.new()`
- Initialize as a client: `rtc_mp.create_client(2)`
- Assign to multiplayer `multiplayer.multiplayer_peer = rtc_mp`
- `multiplayer.is_server()` will return `false` until the server disconnects
- Disconnect server
- Verify that `multiplayer.is_server()` returns `true` (but it should return `false`, because we initialized with `create_client`)
There is an attached MRP, which you can just run and wait a few seconds, and see the console output.
### Minimal reproduction project (MRP)
[webrtcrepro.zip](https://github.com/user-attachments/files/17612222/webrtcrepro.zip)
To run this locally you might need the [webrtc-native](https://github.com/godotengine/webrtc-native) extension. I'm not including it in the MRP cause it's ~300 mb with all the libs. | bug,topic:multiplayer | low | Critical |
2,631,513,162 | electron | Linux - Provide window borders and title bar buttons approprate for the user's desktop environment | ### Preflight Checklist
- [x] I have read the [Contributing Guidelines](https://github.com/electron/electron/blob/main/CONTRIBUTING.md) for this project.
- [x] I agree to follow the [Code of Conduct](https://github.com/electron/electron/blob/main/CODE_OF_CONDUCT.md) that this project adheres to.
- [x] I have searched the [issue tracker](https://www.github.com/electron/electron/issues) for a feature request that matches the one I want to file, without success.
### Problem Description
It is my understanding that Windows and macOS impose window border shapes and appearances through their respective window managers. These operating systems also provide native title bar buttons upon request or overlay them automatically.
In contrast, Linux platforms delegate the responsibility for border styles, title bar buttons, their positioning, appearance, and quantity to the Electron application itself.
This approach shifts the burden of proper desktop integration to the application developer. Often, developers opt for a simplified solution: an undrawn square border with three generic buttons (minimize, maximize, and close) positioned in the top-right corner. However, this generic approach may not align with user preferences or conform to the conventions of the current desktop environment.
### Proposed Solution
Electron should provide a platform-specific window border and apply two sets of title bar buttons (left and right) to the application upon request.
This system could support multiple desktop environments with unique title bar styling, including but not limited to:
* GNOME
* KDE
* Elementary
* COSMIC
While the extent of matching user preferences may vary, this approach would require exposing a generic interface to the underlying application. This interface would automatically apply the correct title bar button styling and appearance using a strategy pattern.
### Alternatives Considered
I've explored the possibility of developing a Web Components library that would provide three key components:
1. A window wrapper component:
- Implements the correct border (and shadow, if necessary) for the platform
- Optionally includes a simple title bar
2. A component for the left bank of title bar buttons
3. A component for the right bank of title bar buttons
This approach would enable developers to incorporate environment-specific window controls without the need to create custom solutions specifically for the Linux platform.
### Additional Information
_No response_ | enhancement :sparkles: | low | Minor |
2,631,517,264 | terminal | [Terminal Chat] The LLM receives confusing information about shell | ### Windows Terminal version
1.23.3061.0
### Windows build number
10.0.22631.0
### Other Software
- Ubuntu 22.04.5 LTS - installed as the default Ubuntu distribution in WLS2, then gradually updated
- GNU bash, version 5.1.16(1)-release (x86_64-pc-linux-gnu)
- GitHub Copilot
### Steps to reproduce
1. Use the default Ubuntu distribution in WSL.
2. Open a terminal for it.
3. Start a Terminal Chat.
4. After few interactions it could mention that it has information that I am using a shell named `ubuntu.exe`.
5. It seems that a sequence of these two user messages lead to responses like below: `Hello`, `Please explain the error.`
### Expected Behavior
The chatbot should not behave is if it received wrong information about the shell being used. It should either have information that I am using Ubuntu distribution of Linux (and maybe version) or that I am using Bash shell in Ubuntu Linux.
It should probably be allowed to modify parts of the initial prompt including information about the shell and operating system. This setting should be per profile.
### Actual Behavior
The Terminal Chat probably receives confusing information about the shell in the terminal window in its preconfigured initial prompt.
When I am using the default Ubuntu WSL distribution with the default `bash` shell the GitHub Copilot responds as if it received information that I am using shell named `ubuntu.exe`:
With Ubuntu 24.04 GitHub Copilot is confused even more:
 | Issue-Bug,Product-Terminal,Needs-Tag-Fix,Area-Chat | low | Critical |
2,631,521,074 | next.js | Turbopack fails to pack css.modules with utf8-bom encoding | ### Link to the code that reproduces this issue
https://github.com/Martinii89/nextjs-turbo-bom-bug
### To Reproduce
1. Start the application in dev mode using the --turbo option
2. The one page uses two identical css classes from two different css module files. One is encoded with utf8. The other with utf8-bom
3. Only the css module with utf8 encoding is applied correctly
Screenshot of the css styles in the devtools of chrome shows a error on one of the styles
### Current vs. Expected behavior
Expected behaviour is that the css modules with utf8-bom encoding does not fail to apply. Currently the first selector will become invalid when utf8-bom is used.
### Provide environment information
```bash
Operating System:
Platform: win32
Arch: x64
Version: Windows 11 Home
Available memory (MB): 16222
Available CPU cores: 12
Binaries:
Node: 20.13.1
npm: N/A
Yarn: N/A
pnpm: N/A
Relevant Packages:
next: 15.0.3-canary.4 // Latest available version is detected (15.0.3-canary.4).
eslint-config-next: N/A
react: 19.0.0-rc-7c8e5e7a-20241101
react-dom: 19.0.0-rc-7c8e5e7a-20241101
typescript: 5.3.3
Next.js Config:
output: N/A
```
### Which area(s) are affected? (Select all that apply)
Turbopack
### Which stage(s) are affected? (Select all that apply)
next dev (local)
### Additional context
_No response_ | bug,Turbopack,linear: turbopack | low | Critical |
2,631,540,082 | yt-dlp | On MAC: On the same call, when providing the update and arguments to download the video, the download fails | ### DO NOT REMOVE OR SKIP THE ISSUE TEMPLATE
- [X] I understand that I will be **blocked** if I *intentionally* remove or skip any mandatory\* field
### Checklist
- [X] I'm asking a question and **not** reporting a bug or requesting a feature
- [X] I've looked through the [README](https://github.com/yt-dlp/yt-dlp#readme)
- [X] I've verified that I have **updated yt-dlp to nightly or master** ([update instructions](https://github.com/yt-dlp/yt-dlp#update-channels))
- [X] I've searched [known issues](https://github.com/yt-dlp/yt-dlp/issues/3766) and the [bugtracker](https://github.com/yt-dlp/yt-dlp/issues?q=) for similar questions **including closed ones**. DO NOT post duplicates
- [X] I've read the [guidelines for opening an issue](https://github.com/yt-dlp/yt-dlp/blob/master/CONTRIBUTING.md#opening-an-issue)
### Please make sure the question is worded well enough to be understood
by calling yt-dlp in mac, I got this issue and upfront to open a bug report, i wanna be sure.
This happens only on MAC. On Windows and Linux it works fine.
On the same call, when providing the update and arguments to download the video, the download fails
example
`yt-dlp --update-to master -S vcodec:h264,res,acodec:aac <URL_of_the_video> -P "F:/Videos/" -o "My Title.mp4"`
- it checks for the update
- if founded:
-- it updates itself then
-- it stops without re-run itself and going ahead to execute the arguments given to download the video.
- if not founded:
-- it goes ahead normally by downloading the video as requested
### Provide verbose output that clearly demonstrates the problem
- [X] Run **your** yt-dlp command with **-vU** flag added (`yt-dlp -vU <your command line>`)
- [X] If using API, add `'verbose': True` to `YoutubeDL` params instead
- [X] Copy the WHOLE output (starting with `[debug] Command-line config`) and insert it below
### Complete Verbose Output
_No response_ | bug,cant-reproduce | high | Critical |
2,631,546,225 | ollama | Invalid prompt generation when the request message exceeds the context size | ### What is the issue?
Hello! You're doing a great job! Thank you so much!
Probably I found a bug when the user message exceedes the `num_ctx` value in the API server.
I started the server in the debug mode: `OLLAMA_ORIGINS=* OLLAMA_DEBUG=1 ollama serve`
The below JS script works correctly with the `x/llama3.2-vision:latest` model.
```ts
async function test() {
const r = await fetch('http://127.0.0.1:11434/v1/chat/completions', {
method: 'POST',
headers: {
Accept: 'application/json',
'Content-Type': 'application/json'
},
body: JSON.stringify({
model: 'x/llama3.2-vision:latest',
messages: [
{
role: 'user',
content: [
{
type: 'text',
text: 'describe the image.',
},
{
type: 'image_url',
image_url: {
url: IMAGE_BASE64
}
}
]
}
]
}),
});
const j = await r.json();
console.log(j);
}
```
In the console I can see:
```
time=2024-11-03T23:59:41.397+01:00 level=DEBUG source=routes.go:1453 msg="chat request" images=1 prompt="<|start_header_id|>user<|end_header_id|>\n\ndescribe the image\n\n[img-0]<|image|><|eot_id|><|start_header_id|>assistant<|end_header_id|>\n\n"
```
In this case the generated sequence looks correctly. But if I change in my script `text: 'describe the image.',` => `text: 'describe the image.'.repeat(200),` then I see in the console:
```
time=2024-11-04T00:04:30.828+01:00 level=DEBUG source=routes.go:1453 msg="chat request" images=1 prompt="<|start_header_id|>user<|end_header_id|>\n\n[img-0]<|image|><|eot_id|><|start_header_id|>assistant<|end_header_id|>\n\n"
```
So by some reason now the content after `<|start_header_id|>user<|end_header_id|>\n\n` has disappeared. The problem here is that the API returns a response generated without the queried message.
When I increase the `num_ctx` value then it starts work again.
**Expected behavior**: I think the API should return an error stating that the request contains a message that is too long.
### OS
macOS
### GPU
Apple
### CPU
Apple
### Ollama version
0.4.0-rc6 | bug | low | Critical |
2,631,549,779 | flutter | Flutter web apps not working on older versions of Safari and WebKit (pretty important and urgent for us!) | ### Steps to reproduce
I don't know if this fits the bug category, but not of the offered issue categories to choose don't fit better with the problem I'd like to report…
Flutter web crashes on Safari and WKWebKit with `WebAssembly.compileStreaming is undefined`
The problem is that flutter web apps don't work on older versions of Safari and WebKit, which I still need to support. For example, I need to support Safari 14.1.3 on macOS 11.1.17 and flutter application stops working when sending request to www.gstatic.com and trying to load file `canvaskit.wasm` from there.
Web console reports the following errors:
```
[Error] Unhandled Promise Rejection: TypeError: WebAssembly.compileStreaming is not a function. (In 'WebAssembly.compileStreaming(fetch(s))', 'WebAssembly.compileStreaming' is undefined)
g (flutter_bootstrap.js:4:5026)
(anonymous function) (flutter_bootstrap.js:4:5585)
asyncFunctionResume
(anonymous function) (flutter_bootstrap.js:4:5719)
I (flutter_bootstrap.js:4:5720)
(anonymous function) (flutter_bootstrap.js:4:7435)
asyncFunctionResume
Global Code (flutter_bootstrap.js:20)
[Error] Unhandled Promise Rejection: null
(anonymous function) (flutter_bootstrap.js:36)
asyncFunctionResume
(anonymous function)
promiseReactionJobWithoutPromise
promiseReactionJob
```
We use flutter on web both for our store, available on the web, but also in the WKWebView in one of our applications. Everything works fine in newer versions of Safari and WebKit, but fails on older versions. It used to work on older versions as well, but it stopped working after some flutter update (we regularly update our code with each new flutter release). I don't have clear track when it happened.
Some of the web app I refer to:
https://store.cocoatech.io
https://deckr.surf
The current situation is that flutter apps on web are useless for anyone using older Mac/macOS and there still are many such people (and many in our user base).
I wonder if there's something we can do about it from our side? Any way we can modify or patch flutter default behaviour? I wonder if we could patch the javascript `if (wasmstuff exists) {}` (assuming that would solve the problem)?
Thanks a lot for looking into this and for providing any explanation, insight and solution, as it's really very important to us, and it's pretty urgent.
### Expected results
Please see the description of the problem above.
### Actual results
Please see the description of the problem above.
### Code sample
N/A
### Screenshots or Video
N/A
### Logs
N/A
### Flutter Doctor output
```
[✓] Flutter (Channel stable, 3.24.4, on macOS 14.7.1 23H222 darwin-arm64, locale en-US)
• Flutter version 3.24.4 on channel stable at /Users/milke/Developer/flutter
• Upstream repository https://github.com/flutter/flutter.git
• Framework revision 603104015d (10 days ago), 2024-10-24 08:01:25 -0700
• Engine revision db49896cf2
• Dart version 3.5.4
• DevTools version 2.37.3
[✗] Android toolchain - develop for Android devices
✗ Unable to locate Android SDK.
Install Android Studio from: https://developer.android.com/studio/index.html
On first launch it will assist you in installing the Android SDK components.
(or visit https://flutter.dev/to/macos-android-setup for detailed instructions).
If the Android SDK has been installed to a custom location, please use
`flutter config --android-sdk` to update to that location.
[✓] Xcode - develop for iOS and macOS (Xcode 15.3)
• Xcode at /Applications/Xcode.app/Contents/Developer
• Build 15E204a
• CocoaPods version 1.15.0
[✓] Chrome - develop for the web
• Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome
[!] Android Studio (not installed)
• Android Studio not found; download from https://developer.android.com/studio/index.html
(or visit https://flutter.dev/to/macos-android-setup for detailed instructions).
[✓] Connected device (3 available)
• macOS (desktop) • macos • darwin-arm64 • macOS 14.7.1 23H222 darwin-arm64
• Mac Designed for iPad (desktop) • mac-designed-for-ipad • darwin • macOS 14.7.1 23H222 darwin-arm64
• Chrome (web) • chrome • web-javascript • Google Chrome 130.0.6723.71
[✓] Network resources
• All expected network resources are available.
! Doctor found issues in 2 categories.
``` | engine,platform-web,browser: safari-macos,P2,team-web,triaged-web | low | Critical |
2,631,552,481 | pytorch | [CuDNN Attention] Performance Grouped Query Attention | # Summary
We recently landed support for grouped query attention via use `enable_gqa` on sdpa, however this is only enabled on the flash attention backend. This leads to a weird situation where it could have been more beneficial for a user to have not used the enable GQA flag and called repeat interleave prior to calling SDPA in order to use the CUDNN net backend.
It looks Like there is explicit support for the GQA situation in the CUDI and NAPI, we should add support for this.
https://docs.nvidia.com/deeplearning/cudnn/latest/api/cudnn-graph-library.html#cudnn-backend-operation-reduction-descriptor
cc @msaroufim @mikaylagawarecki @jainapurva, @eqy, @Skylion007 | module: performance,triaged,module: sdpa | low | Major |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.