id int64 393k 2.82B | repo stringclasses 68
values | title stringlengths 1 936 | body stringlengths 0 256k ⌀ | labels stringlengths 2 508 | priority stringclasses 3
values | severity stringclasses 3
values |
|---|---|---|---|---|---|---|
51,288,402 | go | x/pkgsite: support company-specific doc annotations | <pre>Google internally runs a godoc server serving docs for the standard library + all of
Google $GOPATH (all internal Google Go code).
In many cases, we'd like to mention the Google-specific libraries or ways of doing
things from the standard library docs.
It would be nice if there were a file we could maintain that... | NeedsInvestigation | low | Minor |
51,288,455 | go | runtime: don't allocate for non-escaping conversions to interface{} | <pre>fmt.Fprintf("%d", 8)
Since all interface data fields are now pointers, an int must be allocated and
initialized to 8 so that it can be put in an interface{} to pass to Fprintf.
Since we know the 8 doesn't escape, we could instead allocate that 8 on the stack and
have the interface data word point to th... | Performance | high | Critical |
51,288,473 | go | runtime: make GC runtime stats test run on GCE | <pre>In <a href="https://code.google.com/p/go/source/detail?r=ec6629ef3dae19">https://code.google.com/p/go/source/detail?r=ec6629ef3dae19</a> I removed part of a test
that Dmitry liked because it doesn't run on GCE (which only has ~1ms timers apparently).
This bug is about restoring the test somehow. We could make it ... | NeedsInvestigation | low | Critical |
51,288,477 | go | x/tools/imports: Removes comments if it doesn't see "package" | <pre>$ printf '// i am precious\n' >i.go && goimports -d i.go
diff i.go gofmt/i.go
--- /home/tv/tmp/gofmt524290255 2014-09-03 11:33:53.118042810 -0700
+++ /home/tv/tmp/gofmt219767778 2014-09-03 11:33:53.118042810 -0700
@@ -1 +1 @@
-// i am precious
+
$ gofmt -d i.go
i.go:1:18: expected 'package', found 'EOF... | NeedsInvestigation | low | Critical |
51,288,516 | go | cmd/compile: In struct literals, type check outside in rather than inside out. | <pre>When constructing a struct literal, the types appear to be checked from the "inside
out", that is, it appears that the last thing checked is that the variable type
matches the struct field. This leads to <a href="http://play.golang.org/p/vwvF9uNyhU">http://play.golang.org/p/vwvF9uNyhU</a>, where the
erro... | NeedsInvestigation | low | Critical |
51,288,598 | go | cmd/compile: random performance fluctuations after unrelated changes | <pre>We see constant performance fluctuations after unrelated changes on the perf dashboard.
For example:
<a href="http://build.golang.org/perfdetail?commit=96c713ab6c6f2a4b2a8a0bb2e8d674637b6ce596&">http://build.golang.org/perfdetail?commit=96c713ab6c6f2a4b2a8a0bb2e8d674637b6ce596&</a>;commit0=fee5fcd5f87e75235d... | Performance,NeedsFix | low | Critical |
51,288,599 | go | go/types: constant values should reported as machine values for concrete types | <pre>Feature request: The reported values of constants should be the respective machine
values (perhaps in addition to the precise values) if the constant type is not an
untyped type.</pre>
| NeedsInvestigation | low | Minor |
51,288,624 | go | runtime,sync/atomic: unify API for runtime/internal/atomic and sync/atomic | <pre>We need to unify interface of atomic operations between runtime package and sync/atomic
package. And then teach gc to replace functions in both packages with intrinsics where
possible.
This is followup to <a href="https://golang.org/issue/4947">https://golang.org/issue/4947</a> which was about
atomic intrinsics f... | Performance | low | Major |
51,288,625 | go | cmd/compile: merge temporaries more aggressively | <pre>CL 12829043 added a compiler pass that merges temporary variables with equal types and
non-overlapping lifetimes.
I believe that "equal types" is sufficient but not necessary and that
"equivalent w.r.t. GC" is both necessary and sufficient. (Please correct me if
I am wrong!) This should allow ... | Performance,NeedsFix | low | Major |
51,288,626 | go | testing: measure coverage inside boolean expressions | <pre>Test coverage works on basic blocks. It could be extended to short-circuiting boolean
expressions like f() && g().
Approach:
func GoCoverBool(ret bool, n int) bool {
GoCover.Count[n] = 1
return ret
}
Rewrite f() && g() to f() && GoCoverBool(true, 5) && g() and f()
|| g() to f... | help wanted | low | Minor |
51,288,651 | go | x/sys/unix: Sysctl doesn't supporting writing values | <pre>Hello,
This is not really reporting defects but more like a feature request.
In syscall package, or go.sys package, Sysctl is defined as:
func Sysctl(name string) (value string, err error)
It provides a way to read values through sysctl, but makes it impossible to write/update
values. Internally, it uses &quo... | NeedsInvestigation | low | Critical |
51,288,652 | go | runtime: shrink stacks more aggressively on explicit GC | <pre>If the user calls runtime.GC or debug.FreeOSMemory, shrink stacks even if they are >
1/4 full. That way we can reclaim more space (at the expense of incurring runtime cost
when those goroutines start back up).
Maybe also if gp.blockedsince shows the goroutine has been blocked for a long time.</pre>
| NeedsInvestigation | low | Critical |
51,288,658 | go | html/template: provide a way to specify the initial escaping context (JS or CSS) when parsing | <pre>There is currently no way (that I am aware of) to specify the initial escaping context
(JS or CSS, or other?) when parsing a template using html/template.
The use case where this would be useful is when treating JS or CSS files as templates.
In these cases, it would seem to make sense to be able to call Template... | NeedsInvestigation | low | Minor |
51,288,659 | go | go/types: need way to get from function type to function decl | <pre>From a mail conversation:
On Fri, Sep 12, 2014 at 12:09 PM, Peter Collingbourne <pcc@google.com> wrote:
This information is significant for name mangling and is therefore needed. If there were
a convenient way to ask a named type for its enclosing function, I think it would be
possible to get rid of this tr... | Thinking | low | Minor |
51,288,681 | go | encoding/gob: should report if a name is registered or not. | by **brady@orchestrate.io**:
<pre>It would be nice to have a logical function to go with gob.Register() that reports back
if an object is actually registered. This would help establish if encoding of a given
object is actually going to be readable on the other end or not.
I attached a terrible, poorly written and com... | NeedsInvestigation | low | Minor |
51,288,723 | go | cmd/cgo: C streams are not flushed at program exit | by **kalyanakrishna**:
<pre>What does 'go version' print?
go version go1.3.1 linux/amd64
What steps reproduce the problem?
Take the first example on this page:
<a href="https://code.google.com/p/go-wiki/wiki/cgo">https://code.google.com/p/go-wiki/wiki/cgo</a>
Add
func main() { Example() }
remove "\n" fro... | NeedsInvestigation | low | Minor |
51,288,773 | go | cmd/link: invalid dwarf frames | <pre>What does 'go version' print?
go version go1.3 darwin/amd64
What steps reproduce the problem?
If possible, include a link to a program on play.golang.org.
1. Compile test.go <a href="http://play.golang.org/p/8G9JQFMlmY">http://play.golang.org/p/8G9JQFMlmY</a>
2. Run lldb test
3. b main.foo
4. run
What happened?... | NeedsInvestigation | low | Major |
51,288,786 | go | cmd/go: when compiling with gccgo uses go tool's ReleaseTags, not gccgo's | <pre>What steps reproduce the problem?
1. Install a version of go (such as 1.3) and a version of gccgo that implements a
different version of the language (such as gccgo 4.9, which implements go 1.2)
2. Try to build a package that uses the go1.3 build tag to conditionally support go 1.3
features (for example, <a href=... | NeedsInvestigation | low | Major |
51,288,788 | go | cmd/compile: confusing error messages when a type is repeated | <pre>Code:
<a href="http://play.golang.org/p/MoahP8X1aD">http://play.golang.org/p/MoahP8X1aD</a>
If a type is defined twice in a given package, this can lead to unfortunate interface
assignment errors. As an example, in the code above, "type Foo int" exists
twice. The error message is
prog.go:9: Foo redecla... | Suggested | low | Critical |
51,288,795 | go | crypto/x509: no support for parsing encrypted PKCS8 private keys | by **alex.gaynor**:
<pre>Right now only un-encrypted keys are supported, it would be good if encrypted ones were
as well.</pre>
| FeatureRequest | medium | Critical |
51,288,807 | go | time: mockable time support | <pre>With <a href="https://github.com/jmhodges/clock">https://github.com/jmhodges/clock</a> and the broader <a href="https://github.com/benbjohnson/clock">https://github.com/benbjohnson/clock</a> API,
there's a desire for the timing systems in Go to be fakeable[1]. Using a fake clock
instead of time.Now directly is use... | NeedsInvestigation | medium | Critical |
51,288,816 | go | net: support for android without cgo | It is possible to build Android OS binaries (not apps) without cgo. Those apps will fail
because the Android OS does not define /etc/resolve.conf. Some more details on #8020 and
the linked CL.
| help wanted,OS-Android | medium | Major |
51,288,817 | go | os/user: android support | <pre>Android OS does not support getpwuid_r. There does not appear to be a C/C++ interface
for this, we may have to call into Java to get some notion of users.
As most apps don't make heavy use of OS-level user information, this is a low priority.</pre>
| OS-Android | low | Minor |
51,288,825 | go | runtime: consider using SetFileIoOverlappedRange | <pre>SetFileIoOverlappedRange should improve performance/scalability of networking apps on
windows:
<a href="http://msdn.microsoft.com/en-us/library/windows/desktop/aa365540(v=vs.85).aspx">http://msdn.microsoft.com/en-us/library/windows/desktop/aa365540(v=vs.85).aspx</a>
I have a prototype patch:
<a href="https://golan... | Performance,OS-Windows | low | Major |
51,288,826 | go | runtime: efficient access to thread-local data | <pre>Currently we have 3 performance issues with accesses to thread-local data (g/m/p):
1. Accesses require non-inlinable function calls.
2. The only thread-local var is now g, while most frequently accesses data is in m. So
most of the accesses has an additional indirection.
3. We do lots of duplicate loads of g/m.
W... | Performance | low | Major |
51,288,828 | go | runtime: don't pass *Type to new | <pre>Currently we pass a pointer to Type descriptor to new. It preserves alive all methods of
allocated types, as Type contains Method array. So linker can't strip them.
We should pass a special object that contains only necessary information to new:
1. size
2. size class (needs to be ignored for arrays with more than ... | Performance | low | Minor |
51,288,829 | go | runtime: don't do unnecessary loads on malloc fast path | <pre>Currently we load runtime.memstats.heap_alloc and runtime.MemProfileRate on every
malloc. Both are not strictly necessary and bring 2 unnecessary cache lines into cache.
Here are proof-of-concept CLs:
<a href="https://golang.org/cl/129810043/">https://golang.org/cl/129810043/</a>
<a href="https://golang.org/cl/12... | Performance | low | Minor |
51,288,836 | go | runtime: remove unnecessary allocations in convT2E | <pre>This was at lengths discussed in:
<a href="https://golang.org/issue/8405">https://golang.org/issue/8405</a>
and previously on golang-dev:
<a href="https://groups.google.com/d/msg/golang-dev/pwUh0BVFpY0/zqJInvU3NkQJ">https://groups.google.com/d/msg/golang-dev/pwUh0BVFpY0/zqJInvU3NkQJ</a>
Namely, we should allocate... | Performance | low | Major |
51,288,838 | go | cmd/go: critical path scheduling | <pre>Currently go tool schedules work in topological order, this leads to suboptimal
parallelization. It's possible that towards end, very few work items are available
leading to idle processors.
Critical path scheduling gives much better results in this respect:
<a href="http://en.wikipedia.org/wiki/Critical_path_met... | ToolSpeed | medium | Critical |
51,288,840 | go | cmd/compile: recognize case <-time.After(x) | <pre>Compiler can recognize the common:
case <-time.After(x):
construct and lower it into:
runtime.selectrecvafter(x)
Runtime can handle this case much more efficiently: no need to create Timer, chan and
arm timers; it just needs to do a timed park of the goroutine until x. As a bonus, the
timer does not leak.... | Performance,compiler/runtime | low | Major |
51,288,841 | go | runtime: fine-grained locking in select | <pre>Fine-grained locking in select provides substantial speedups:
benchmark old ns/op new ns/op delta
BenchmarkSelectUncontended 213 188 -11.74%
BenchmarkSelectUncontended-2 110 97.2 -11.64%
BenchmarkSelectUncontended-4 ... | Performance,early-in-cycle,Scalability | medium | Critical |
51,288,844 | go | runtime: lock-free channels | <pre>Here is design doc:
<a href="https://docs.google.com/document/d/1yIAYmbvL3JxOKOjuCyon7JhW4cSv1wy5hC0ApeGMV9s/pub">https://docs.google.com/document/d/1yIAYmbvL3JxOKOjuCyon7JhW4cSv1wy5hC0ApeGMV9s/pub</a>
Here is the implementation:
<a href="https://golang.org/cl/12544043/">https://golang.org/cl/12544043/</a>
I've ... | Performance | high | Critical |
51,288,845 | go | runtime: throttle goroutines on async chans | <pre>There is a common trick for reduction of contention on sync primitives. Unfortunately it
does not have a common name, but see mutexWaiterShift handling in sync/mutex.go for an
example. We can use it for async channels to reduce contention as well. Namely:
- add a waiterAwake flag to Hchan
- when a goroutine sends... | Performance | low | Minor |
51,288,846 | go | runtime: squeeze Hchan into 64 bytes | <pre>Currently Hchan is 12 words (on 64-bit machine). It would be nice to squeeze it into 8
words. First it's just memory consumption reduction, and second it will be exactly cache
line (and due to malloc alignment, it will be also cache line aligned) which will
speedup contented synchronization - ping-pong only one li... | Performance | low | Minor |
51,288,847 | go | runtime: special case chan struct{} | <pre>chan struct{} is commonly used for semaphores.
We can special case it in runtime as atomic counter. Then common case (of no work
limiting) will be just atomicinc/atomicdec.</pre>
| Performance | low | Minor |
51,288,849 | go | runtime: make chan-based generators faster | <pre>In some cases parallelism is not needed/desirable -- fine-grained chan-based
generators/iterators, or "coroutine-like" approach when you have several
independent stacks and manually switch between them.
Sync channels substantially limit parallelism, to the point where pipeline-like
parallelization does n... | Performance | low | Critical |
51,288,860 | go | cmd/link: implement external linking support for ppc64/linux | <pre>We need to fix the 9l linker to provide external linking support, so that
-linkmode=external works on power64.
This code is currently on the dev.power64 branch and should come into tip after the 1.4
release is out. This means writing elfreloc1, elfsetupplt, adddynsym, adddynrela, etc.,
in cmd/9l/asm.c and doing ... | NeedsInvestigation | low | Minor |
51,288,861 | go | math, crypto, hash: Write power64 versions of assembler routines where applicable | <pre>We want to write power64 versions of the assembler routines in the math package, in
several crypto packages, and in the hash/crc32 package. For each of those packages
where we have .s files, we should either write a power64 version or determine that the
Go version is as good as we can write in assembler.</pre>
| NeedsInvestigation | low | Minor |
51,288,933 | go | go/types: expose interface satisfaction constraints | <pre>The type checker goes to very great lengths to be robust and precise even for ill-typed
inputs, and it is very hard to match this level of robustness in other passes over the
(typed) AST. As a result, the refactor/lexical and refactor/satisfy packages, both of
which recompute information computed but not exposed ... | Refactoring | low | Critical |
51,288,937 | go | cmd/gofmt: two dimensional slice/array formatting | by **mrekucci**:
<pre>go version go1.3.1 darwin/amd64
Try to format next code snippet: <a href="http://play.golang.org/p/b0tIzdvp9i">http://play.golang.org/p/b0tIzdvp9i</a>
In my opinion the code should be formatted in a way how it looks like
before formatting i.e. columns aligned to comma.</pre>
| Thinking | low | Minor |
51,288,947 | go | cmd/compile: package type name collision with built-in types in compiler error messages | by **sedevelopers01**:
<pre>v1.3.3
Thread on go-nuts:
<a href="https://groups.google.com/forum/#">https://groups.google.com/forum/#</a>!topic/golang-nuts/Ed3gU3EjbaI
Problem:
When you define a package level "error" type (lower-case) it shadows the built-in error type and causes error messages lik... | NeedsFix | low | Critical |
51,288,974 | go | crypto/sha512: Arm Optimizations not implemented | by **jeromyj**:
<pre>sha family hash functions on ARM architectures are quite slow, there is an
implementation of sha512 (and sha1) in libgcrypt that has assembly optimized code for
ARM Neon. It would be really nice to have something similar implemented into the Go
standard library.</pre>
| Performance | low | Major |
51,288,982 | go | x/tools/present: .play snippet don't handle inserted newlines when using the Enter key. | by **smyrman**:
<pre>Before filing a bug, please check whether it has been fixed since the
latest release. Search the issue tracker and check that you're running the
latest version of Go:
Run "go version" and compare against
<a href="http://golang.org/doc/devel/release.html">http://golang.org/doc/devel/rel... | NeedsInvestigation | low | Critical |
51,289,031 | go | io: no easy way to fan out to multiple readers | by **recv@awesam.de**:
<pre>There is currently no good way to fan out from an io.Reader to multiple readers. A
use-case we commonly encounter is piping data from one reader to another, and doing some
calculation over the piped data on the side in a goroutine.
io.TeeReader gets you only half the way, and we found a ni... | NeedsInvestigation | low | Major |
51,289,035 | go | x/text/unicode/norm: LastBoundary is inconsistent | <pre>The LastBoundary methods seems inconsistent as to
where it reports a boundary. When called with a string
containing a single (non-combining) character, the boundary
is sometimes reported at the start of the string
and sometimes at the end:
This code:
fmt.Printf("%d\n", norm.NFD.LastBoundary([]byte(... | NeedsInvestigation | low | Minor |
51,289,037 | go | go/build: Import(".", ".", 0) fails to resolve the full package path relative to GOPATH while build.Import(".", <cwd>, 0) works | <pre>What does 'go version' print?
go version go1.3.3 linux/amd64
What steps reproduce the problem?
1. mkdir $HOME/src2
2. mkdir $HOME/src2/golang
3. export GOPATH=$HOME/src2/golang
4. mkdir -p $GOPATH/src/foo
5. Put the content of <a href="http://play.golang.org/p/gzOX-Obb75">http://play.golang.org/p/gzOX-Obb75</a> i... | NeedsInvestigation | low | Minor |
51,289,118 | go | cmd/link: include $a and $t symbols in arm final link | <pre>The host objdump -d doesn't work correctly on 5l-linked binaries. 5l does not add $a
(arm) and $t (thumb) symbols to the output, and thus objdump doesn't know how to
disassemble the code. It ends up disassembling as .word directives instead of actual
disassembly.
objdump can be forced to disassemble correctly u... | NeedsInvestigation | low | Minor |
51,289,121 | go | runtime: remove implementation restriction on channel element size | <pre>It appears that gc and the runtime currently disable channel elements to be over 64kB:
<a href="http://play.golang.org/p/_aVWt-qiud">http://play.golang.org/p/_aVWt-qiud</a>
But I see nothing about this (allowed?) implementation restriction in the spec, despite
the spec calling out a number of other implement... | NeedsInvestigation | medium | Major |
51,289,128 | go | net/http: DialTLS is not used w/ proxy (by design) | by **joshua.boelter**:
<pre>What does 'go version' print?
go version go1.4rc1 [windows/amd64 | linux/amd64]
What steps reproduce the problem?
transport.DialTLS not used when an HTTPS connection is proxied.
<a href="http://play.golang.org/p/hSZy5-Sg0I">http://play.golang.org/p/hSZy5-Sg0I</a>
Equally concerned devel... | NeedsInvestigation | low | Critical |
51,289,131 | go | runtime: support parallel cache-oblivious algorithms | <pre>Cache-oblivious algorithms automatically take advantage of all levels of caches present
in the system (register set, L1/L2/L2, disk) by recursively sub-dividing the problem
into smaller parts:
<a href="http://en.wikipedia.org/wiki/Cache-oblivious_algorithm">http://en.wikipedia.org/wiki/Cache-oblivious_algorithm</a... | Performance | low | Major |
51,289,147 | go | math/big: print and parse in different bases | <pre>Feature request.
The math/big types Int and Rat do not provide facilities analogous to strconv that allow
printing and parsing numbers in arbitrary bases. This would be nice to have.</pre>
| NeedsInvestigation | low | Minor |
51,289,217 | go | x/pkgsite: "const" declarations with type on right are not grouped with the type | <pre>Run the godoc tool on a file such as <a href="http://play.golang.org/p/fnp9JT3Ki_">http://play.golang.org/p/fnp9JT3Ki_</a>.
The constants with types on the left of "=" are grouped with the type. The
equivalent constants with types on the right are not.
Since the two styles of declaration produce equiv... | NeedsInvestigation | low | Minor |
51,289,219 | go | x/tools/cmd/goimports: Handle ambiguous import properly | by **cnyegle**:
<pre>Before filing a bug, please check whether it has been fixed since the
latest release. Search the issue tracker and check that you're running the
latest version of Go:
Run "go version" and compare against
<a href="http://golang.org/doc/devel/release.html">http://golang.org/doc/devel/rele... | NeedsInvestigation | low | Critical |
51,289,226 | go | html/template: add support for template strings (backticks) | by **opennota**:
<pre>ES6 specifies a new language feature called "Template Strings" (often also
referred to as "Quasi Literals" alongside multi-line strings and others). This
allows to execute arbitrary JavaScript code without using parenthesis but
back-ticks instead. Inside back-tick delimited st... | NeedsDecision,FeatureRequest | medium | Critical |
51,289,227 | go | proposal: sync/v2: prohibit unlocking mutex in a different goroutine | sync.Mutex allows lock/unlock in different goroutines:
<a href="http://golang.org/pkg/sync/#Mutex.Unlock">http://golang.org/pkg/sync/#Mutex.Unlock</a>
"A locked Mutex is not associated with a particular goroutine. It is allowed for
one goroutine to lock a Mutex and then arrange for another goroutine to unlock... | v2,Proposal | medium | Critical |
51,289,244 | go | runtime: reduce StackGuard | <pre>We raised it to 512 in the run up to Go 1.4 and I'm raising it to 640 now for
Windows/amd64 + write barriers. I'd like to get it back down to something like 256.</pre>
| NeedsFix | low | Minor |
51,289,249 | go | x/sys/unix: Seteuid/Setegid for linux | by **dustin@criticalstack.com**:
<pre>Missing syscall.Seteuid/Setegid for linux_amd64 and linux_386 syscall packages.</pre>
| NeedsInvestigation | low | Minor |
51,497,475 | rust | fat-ptr-transmutes lint doesn't work | ``` rust
#![deny(fat_ptr_transmutes)]
use std::mem;
fn main() {
let x: [u8, ..8] = [0, ..8];
let y: [u8, ..16] = unsafe {
mem::transmute(x.as_slice())
};
println!("{}", y.as_slice());
}
```
compiles and runs with no warnings. The problem is that `trans::intrinsic::check_intrinsics` [calls `S... | A-lints,T-compiler,C-bug | low | Major |
51,502,427 | go | build: redeclaration errors after switching branches | I had to revert to go1.4 yesterday because cross-compiling was (or is) broken, and now master won't build, revealing that we might be .gitignoring too many files.
git status shows I have a clean tree at tip, but the build suggests otherwise:
```
mac:go bradfitz$ git status
On branch master
Your branch is up-to-date w... | NeedsInvestigation | medium | Critical |
51,546,253 | nvm | Modifying a file when .bashrc and .zshrc are present | I just switched to zsh so still there's .bashrc and .zshrc present in my ~ . However, it's choosing .bashrc over the one I'm actually using, so I copied it by hand. I know it's a particular problem, but maybe the script could check the current shell and modify whatever file suits it?
| shell: zsh,installing nvm: profile detection,pull request wanted | low | Major |
51,600,921 | go | math/big: improve assembly cores: alignment and unrolling | Suggestions from Torbjörn Granlund (personal e-mail):
"Aligning:
Consider aligning loops to at least a 0 mod 16 address.
Same for function start.
Tail code after unrolling:
Setting up a loop which runs 0-3 iterations is quite expensive.
It should be better to follow the pattern:
```
test $2, Rcount
... | NeedsInvestigation | low | Minor |
51,601,084 | go | math/big: better multiply primitives | Suggestions from Torbjörn Granlund (personal e-mail):
"
The multiply primitives, in particular addMulVVW surely deserves more
attention:
Offset the pointers so that you can index with a counter register
which goes from -n to 0, saving the CMPQ.
Unroll. You can save most of the ADCQ $0, R that way. Basically,... | Performance,NeedsFix | low | Major |
51,862,202 | go | x/review/git-codereview: add change -d | We should have a change -d command that you run at the same time you click Abandon in the web UI. Or maybe it even does the Abandon for you too. It's too hard to back everything out by hand.
@griesemer ran into this with the peano change. @adg
| NeedsInvestigation,FeatureRequest | low | Major |
51,897,075 | go | x/mobile/app: support all-Go app development on windows | The http://golang.org/x/mobile/app package lets you run all-Go apps on desktop darwin and linux with nothing more than the stock Go build. Just `go get` and you're programming. This is done via cgo: we ask for a window, get an OpenGL context, and map mouse events to touch events.
We should do the same for Windows. The... | OS-Windows,mobile | medium | Critical |
51,948,673 | rust | Poor performance returning enums larged than a word. Possibly poor code generation? | I've discovered an issue with `IoError`, and really returning any enums that are larger than 1 word, are running an order of magnitude slower than returning an error enum that's 1 word size. Here's my test case:
``` rust
extern crate test;
use std::mem;
use std::vec;
use std::io;
const BUFFER_SIZE: uint = 128;
////... | I-slow,T-compiler,C-bug | medium | Critical |
52,030,432 | go | x/mobile/gl/gles3: OpenGL ES 3 bindings | OpenGL ES 3 is a large extension to ES 2, offering a large number of new features. Eventually we should have support for it.
I propose we do so by having a new package that contains the extra enum values and functions, which can be used in conjunction with the existing gl package.
This is a very low priority item as ... | mobile | low | Minor |
52,061,725 | go | proposal: net/v2: Listen is unfriendly to multiple address families, endpoints and subflows | The following example program:
``` go
package main
import (
"net"
)
func main() {
net.Listen("tcp", "localhost:8080")
select{}
}
```
Currently yields this result:
```
$ netstat -nl | grep 8080
tcp 0 0 127.0.0.1:8080 0.0.0.0:* LISTEN
```
While the followin... | v2,Proposal | medium | Critical |
52,073,087 | go | cmd/compile: enhancements to the gc inliner and optimizer | **Background**
I recently tried optimizing some hash functions in Go to find out what is possible without resorting to using assembler. I knew gc had an "inliner" but I didn't have any experience with it. I spent some time reading the "inl.c" code.
**Summary**
Go's inliner seems to work well and I got speed increase o... | compiler/runtime | medium | Major |
52,158,076 | TypeScript | Find references for shorthand properties | ``` ts
interface A {
foo();
}
function foo() { }
var a: A = { foo };
a.foo(); // find references on call to foo
```
If you find references on the call to foo, it should also turn up the actual function definition. But the function definition seems to be excluded.
| Bug | low | Major |
52,177,406 | rust | Unboxed closure types look weird in error messages | ``` rust
fn main() {
let x: () = |:| {}; // error: mismatched types: expected `()`, found `closure[<anon>:2:17: 2:23]` (expected (), found closure)
}
```
It looks like d258d68 might have changed this for debugging purposes, but forgot to change it back.
| C-enhancement,A-diagnostics,T-compiler,WG-diagnostics | low | Critical |
52,191,348 | neovim | License for docs | Migrated from https://github.com/neovim/docs/issues/29 (which was deleted).
---
@ZyX-I suggested CC license for docs. We should implement that so we can have a clear license going forward. https://github.com/neovim/neovim/issues/878#issuecomment-46810685
Existing Vim docs are licensed under http://www.opencontent.or... | documentation,runtime,project-management | low | Major |
52,193,121 | go | proposal: net: should provide an interface for dialing | net.Dialer sounds like it's close to making transports pluggable the way e.g. http.Client / http.Transport behave, but reading further one realizes that net.Dialer is hardcoded to basically be net.Dial with timeouts. This makes e.g. crypto/tls DialWithDialer less useful; I can't just easily replace the whole transport ... | Proposal,NeedsInvestigation | medium | Major |
52,196,972 | go | x/mobile/event: keyboard support | Both android and iOS provide OS software onscreen keyboards. The event package needs a common API for activating both, and needs to adjust the reported screen space appropriately.
There are some curious complications for those of us used to traditional keyboards, but nothing impossible:
- there are various ways to sug... | mobile | low | Minor |
52,342,109 | go | x/review/git-codereview: doesn't set upstream to origin/master | We need to set upstream to master like below.
```
$ git checkout -b fix-windows-readlink
$ vim foo.go
$ git change
git rev-parse --abbrev-ref fix-windows-readlink@{u}
error: No upstream branch found for 'fix-windows-readlink'
error: No upstream branch found for 'fix-windows-readlink'
fatal: ambiguous argument 'fix-win... | NeedsInvestigation | medium | Critical |
52,380,018 | kubernetes | REST api - 'kind' property not always exists on entities | 'kind' property exists only on the outer entity in REST api hence providing not aligned behavior for REST api consumers.
Example: when querying for all services (/api/v1beta1/services) there's an attribute
"kind": "ServiceList" on the collection, but in the "items" section with the actual services - none of the servic... | priority/backlog,area/api,area/usability,sig/api-machinery,lifecycle/frozen,triage/accepted | medium | Critical |
52,422,688 | go | x/review/git-codereview: commit-msg hook doesn't play well with Signed-off-by lines | For example, git commit -s will generate this log message:
```
test: test commit
Signed-off-by: Shenghou Ma <minux@golang.org>
Change-Id: I3545610fc076ab9da46bb5ed571a49730a5075dc
```
However, it should look this instead, which is generated by the official gerrit commit-msg hook:
```
test: test com... | NeedsInvestigation | low | Minor |
52,441,097 | go | net: LookupSRV and search domains when name is empty | Using Go 1.4 on Linux x86_64 (Ubuntu).
I called the lookupSRV function in the "net" package, with
`lookupSRV("service", "tcp", "")` (empty name).
I expected this to lookup using my search domains ("_service._tcp.my.search.domain"), but it potentially seems to have queried it with an extra "." ("_service._tcp..my.sea... | NeedsInvestigation | low | Major |
52,441,857 | TypeScript | Add "sealed" key word to mark some public/protected methods not be overriden | From https://github.com/Microsoft/TypeScript/issues/1524, I see that the default method are all "virtual", but sometimes I don't wanna some public method to be overidden. Would you invent a mechasim to force the users that they cannot override a public method (with the key word, something like "sealed")?
Thanks!
| Suggestion,Needs Proposal | medium | Critical |
52,442,654 | rust | Spurious test out-of-stack test failure on Android | See https://gist.github.com/aturon/6c03914f968084548cd6 for an example. @alexcrichton dug into this and found strange behavior but wasn't able to make sense of it.
The test is going to be marked ignore on android for the time being.
| A-codegen,O-android,T-compiler,C-bug,I-flaky-test | low | Critical |
52,469,027 | rust | Permit impl methods whose bounds cannot be satisfied to have no body | There is a curious case with where clauses where sometimes we can show that a method in an impl could not possibly be called. This is because the impl has more precise information than the trait. Here is an example:
``` rust
trait MyTrait<T> {
fn method(&self, t: &T) where T : Eq;
}
struct Foo;
... | A-trait-system,T-lang,E-medium,C-feature-request | medium | Major |
52,509,518 | youtube-dl | youtube-dl -U exit status | I disable networking and run
simon@falcon:~$ youtube-dl --version
2014.12.17.2
simon@falcon:~$ youtube-dl -U
ERROR: can't find the current version. Please try again later.
simon@falcon:~$ echo $?
0
Why not set an non-zero exit status and print the message to STDERR?
best regards
| request | low | Critical |
52,522,748 | rust | Parse and accept type equality constraints in where clauses | Implement the missing type equality constraint specified in [RFC 135](https://github.com/rust-lang/rfcs/pull/135).
### Examples
```rs
fn sum<I: Iterator>(_: I) -> i32
where
I::Item == i32 // or `I::Item = i32`
{
// ...
}
```
| A-type-system,T-lang,C-tracking-issue,A-lazy-normalization,S-tracking-unimplemented,S-tracking-design-concerns,T-types | high | Critical |
52,537,653 | neovim | remove 'imcmdline', 'imdisable', 'imsearch' | These options were effectively disabled in https://github.com/neovim/neovim/pull/1568. Need to investigate if they should be removed.
Related:
- vscode Nvim GUI: https://github.com/vscode-neovim/vscode-neovim/issues/1370
| compatibility | medium | Major |
52,555,417 | rust | Fully generalize cmp instances | With [cmp/ops reform](https://github.com/rust-lang/rfcs/pull/439), all of the comparison traits allow the types of the two sides to differ. However, the traits provide a _default_ type for the right-hand size that is the same as the left-hand side. Thus, an impl like:
``` rust
impl<T: PartialEq> PartialEq for Rc<T> { ... | T-libs-api,C-feature-request | medium | Major |
52,579,174 | go | x/review/git-codereview: can't run git change | git-codereview is confused and thinks I'm on some other branch:
```
ba12:oauth2 bradfitz$ go get -u -v golang.org/x/review/git-codereview
Fetching https://golang.org/x/review/git-codereview?go-get=1
Parsing meta tags from https://golang.org/x/review/git-codereview?go-get=1 (status code 200)
get "golang.org/x/review/gi... | NeedsInvestigation | low | Minor |
52,612,986 | go | x/mobile: allow api users to decide when to SwapBuffers. | While fixing app on x11/egl and porting it to x11/glx I found some need for a redesign.
See https://go-review.googlesource.com/#/c/1851 for some discussion.
Right now the idea is to always vsync on back buffer swap.
This will make any app run at the display devices (probably) fixed refresh rate.
An app that takes 1.1 ... | mobile | low | Major |
52,628,066 | youtube-dl | [site request] CollegeRama | Some big universities in Holland are running a presentation site for their lectures. Technical University Delft (TUD) offer great content to many thousands of regular visitors on: http://collegeramacolleges.tudelft.nl/online/faculties/all-faculties/public-lectures/
Basically, a video of the professor/lecturer speakin... | site-support-request | low | Minor |
52,672,194 | go | cmd/vet: flag unkeyed struct literals when a struct has two fields of the same type | Suggested in #9409.
Note that vet already flags all unkeyed composite struct literals when the type comes from a different package. This would extend checks to same-package types, but with more stringent criteria.
@bradfitz @alandonovan @shurcooL
| Analysis | low | Minor |
52,696,459 | go | net/http: document errors more (*Transport, Client's wrapper errors, etc), how to check canceled, ... | I've been doing some experimenting with Go HTTP clients and servers under load.
One of the curious things I've discovered is that calls to (*http.Client).Get occasionally return unusual errors.
The documentation at http://golang.org/pkg/net/http/#Client says:
"An error is returned if the Client's CheckRedirect functio... | Documentation,help wanted,Proposal,Proposal-Accepted,NeedsFix | medium | Critical |
52,772,696 | go | go/doc: confusing types displayed for mixed exported/unexported consts | Given:
``` go
const (
a, _, c = T, iota, int
D, E, f
J, k = iota, T
L, M
)
```
godoc outputs:
```
const (
_ = T, iota, int
D, E
J = iota, T
L, M
)
```
It is not clear from the output what the type of `D`, `E`, `L`, or `M` is.
I came across this while working on a follow-up to #539... | NeedsInvestigation | low | Minor |
52,823,240 | go | x/mobile/gl: Mismatch in Uniform and Attrib Value types | Hi,
I noticed that the `Value` field of the `Attrib` and `Uniform` types is of different type - `uint` and `int32` respectively.
[http://godoc.org/golang.org/x/mobile/gl#Attrib](http://godoc.org/golang.org/x/mobile/gl#Attrib)
[http://godoc.org/golang.org/x/mobile/gl#Uniform](http://godoc.org/golang.org/x/mobile/gl#Uni... | mobile | low | Minor |
52,832,165 | go | cmd/vet: "could not import" warning message not visible without -v. | Using Go 1.4 and latest tools subrepo:
```
~ $ go version
go version go1.4 darwin/amd64
~ $ gostatus -v ...cmd/vet
golang.org/x/tools/...
```
By default, `vet` is supposed to detect "Suspicious calls to functions in the Printf family." I've noticed that it sometimes did not do that reliably (it would detect some... | Analysis | low | Major |
52,947,588 | go | proposal: spec: add support for int128 and uint128 | LanguageChange,Proposal,LanguageChangeReview | high | Critical | |
52,964,827 | go | cmd/gofmt: moves comment in for | On playground (and elsewhere), [this code](http://play.golang.org/p/0kv0J7re1b)
``` go
package main
func main() {
for i := 0; i < 1 /* 9000 */ ; i++ {
_ = i
}
}
```
is transformed by gofmt into [this code](http://play.golang.org/p/0kv0J7re1b):
``` go
package main
func main() {
f... | NeedsInvestigation | low | Minor |
52,970,987 | rust | Conditional compilation based on crate_type | Ideally we should be able to do something like this:
Cargo.toml:
```
.....
[lib]
path = "src/lib.rs"
crate-type = ["rlib","dylib"]
.....
```
src/lib.rs:
```
....
#[no_mangle]
#[cfg(crate_type="dylib")]
pub unsafe extern "C" fn .....
```
To allow only exporting the c api in the dylib or perhaps in the dylib and stat... | A-driver,A-attributes,T-lang,C-feature-request | medium | Critical |
52,975,813 | rust | Use of `ty` macro non-terminal in trait bounds | ```
macro_rules! impl_somethingable {
($Base: ty, $Block:ty) => {
impl<'a, T> Somethingable for $Block where T: $Base {
}
}
}
impl_somethingable!(ATrait, A);
```
```
<anon>:15:52: 15:60 error: each predicate in a `where` clause must have at least one bound in it
<anon>:15 impl<'a, T> S... | A-grammar,T-lang,C-feature-request | low | Critical |
52,978,732 | youtube-dl | Add support for peer-stream.com | Hi,
could you add support for peer-stream.com so it is possible to use it without adobe flash.
```
$ youtube-dl "http://peer-stream.com/api/embedplayer.php?controlbar=none&width=100%25&height=100%25&prog=onlinetv&groupspec=G:0101010c050e3373617400"
[generic] embedplayer: Requesting header
WARNING: Falling back on gen... | site-support-request | low | Critical |
53,026,095 | youtube-dl | Add support for nintendo.com | Hello,
Could you please add support for videos on nintendo.com?
Here are some examples:
http://www.nintendo.com/games/detail/yEiAzhU2eQI1KZ7wOHhngFoAHc1FpHwj
http://www.nintendo.com/wiiu/videos/#all/Why_You_Want_Wii_U
http://www.nintendo.com/nintendo-direct/04-30-2014/#/video-ndirect
```
$ youtube-dl "http://www.nin... | site-support-request | low | Critical |
53,046,383 | rust | cache the results of type projection and normalization | Both in trans and in typeck. Must be somewhat careful around type parameters and so forth. Probably we want to introduce a cache onto the fulfillment context to use for normalization as well.
| C-cleanup,I-compiletime,A-associated-items,T-compiler | low | Major |
53,064,490 | go | testing/iotest: add two new readers | Just in case there is interest, here are two other badly-behaved reader types that might make useful additions to `testing/iotest`:
``` go
// ZeroNilReader returns 0, nil on every second read. Other calls to read succeed.
func ZeroNilReader(r io.Reader) io.Reader
// CorruptingReader returns a Reader that modifies an... | FeatureRequest | low | Major |
Subsets and Splits
GitHub Issues Containing Next.js References
Filters training data to find examples mentioning "next.js", providing basic keyword search capability but offering limited analytical value beyond simple retrieval.