id
int64
393k
2.82B
repo
stringclasses
68 values
title
stringlengths
1
936
body
stringlengths
0
256k
labels
stringlengths
2
508
priority
stringclasses
3 values
severity
stringclasses
3 values
58,408,710
nvm
Install node 32bits in Ubuntu 64bits
Is there a way to install an specific node arch (32|64) with nvm, in a 64 bits OS?
installing node,feature requests,pull request wanted
low
Major
58,448,555
nvm
ls-remote output is deceiving when one of nodejs.org and iojs.org is not accessible
I recently installed nvm on a new server that did not have the Thawte root certificate used by nodejs.org configured as a trusted root certificate in OpenSSL. The AddTrust root certificate used by iojs.org was configured as a trusted root cert. The result of this was that when I ran `nvm ls-remote` it only displayed ...
installing node,SSL issue,pull request wanted
low
Major
58,478,303
rust
Deref coercion from `String` to `&str` doesn't seem to always work
This code compiles fine: ``` rust fn main() { let x = "a".to_string(); let y: String = ["b", &x[..], "c"].concat(); println!("{}", y); } ``` but this code doesn't ``` rust fn main() { let x = "a".to_string(); // Doesn't work let y: String = ["b", &x, "c"].concat(); println!("{}", y); } ``` error outpu...
A-type-system,T-compiler,C-bug,T-types
medium
Critical
58,488,339
react
Optimizing Compiler: Tagging ReactElements
We can make more optimized reconciliation by tagging ReactElements with the "hidden class" of their props. For example, this is guaranteed to always have three props: `className`, `width`, `children`. ``` javascript <div className="foo" style={{ width: w, height: 100 }}>{c}</div> ``` If we could tag every element wi...
Component: Optimizing Compiler,Resolution: Backlog,React Core Team
low
Major
58,499,987
rust
Extend #[bench] with memory usage
It would be nice to be able to see memory usage (and memory leak) in `#[bench]` tests to detect regressions. I guess jemalloc can do that with something like `je_malloc_stats_print`. cc #14119 cc #14875 cc #19776
T-libs-api,C-feature-accepted
medium
Major
58,630,551
neovim
:! (with no arguments) should pipe the buffer to &shell
Most (all?) shells can [execute stdin](http://stackoverflow.com/a/9966150/152142). E.g.: ``` echo ls | bash ``` Yet in Vim, if I have a buffer with these contents: ``` ls ``` and then execute any of these: ``` :%! :%w ! :%r ! ``` nothing happens. The buffer contents should pipe to `&shell` if `:!` has no argument...
enhancement,terminal
low
Major
58,655,738
youtube-dl
Custom filename transformations (was: Filename: I want to restrict characters, but permit spaces)
Right now, restricting filenames to reasonable characters also prevents spaces. Yea, I know, most unix scripts/etc. can't handle spaces, but most modern GUI tools can.
request
medium
Major
58,775,371
youtube-dl
add support for 'app passwd'
my understanding is that 2-step authentication is not supported. but i couldn't find anything about app specific passwd here. this should work with netrc just like regular passwd but i doesn't.
request
low
Major
58,785,281
go
x/mobile/cmd/gomobile: icon support in gomobile
There are some useful defaults we could have for app icons. Place an icon in <pkg>/assets/icon.png, and it gets used. But it turns out there are many icons. Android has an arbitrary number of potential sizes, depending on the DPI of the screen. iOS has a series of fixed sizes. Both also have much larger store icons (1...
mobile
low
Major
58,920,223
TypeScript
SourceFileObject.getNamedDeclarations is missing declarations before methods
I'm doing a SourceFileObject.getNamedDeclarations on the following code snippet: ``` javascript module Mankala { export class Rectangle { x: number; y: number; width: number; height: number; square() { } } } ``` This returns an array that is missing the property 'height'. The problem is i...
Bug,Help Wanted,API
low
Major
58,943,086
You-Dont-Know-JS
"async & performance": Document unhandled rejection hooks
In async & performance you mention promise rejections and debuggability with error handling. A patch has landed in io.js in 1.4 which is released tomorrow with native promises that lets you do something similar to your example: Your example syntax: ``` var p = Promise.reject( "Oops" ).defer(); var p2 = Promise.reject...
for second edition
low
Critical
58,944,257
kubernetes
Efficient lookup by label selection, reverse label selection, uid, and IP addresses
In a discussion I had yesterday with @bgrant0607 and @lavalamp it came up the need of indexing labels and probably ip addresses. Reference: https://github.com/GoogleCloudPlatform/kubernetes/pull/4482 > We'll still want to do the label indexing, reverse label indexing, lookup by IP address, specification of query URLs ...
sig/scalability,area/api,area/usability,priority/awaiting-more-evidence,sig/api-machinery,kind/feature,lifecycle/frozen
medium
Major
58,996,043
go
proposal: spec: reconsider rule disallowing div-0 by constants
http://play.golang.org/p/flvr-MFRgR is a perfectly reasonable program that doesn't compile. Perhaps the spec rule (which admittedly, I advocated) was a mistake after all. We could reconsider this since permitting it would be backward-compatible. (See also #10004 for context.)
LanguageChange,Proposal,LanguageChangeReview
low
Major
59,077,545
TypeScript
Contextual intellisense in Visual Studio
Hi, The most obvious case is for enums: ``` typescript enum Foo { bar, allBarOne } function f(foo: Foo) { foo === // list Foo members here } ``` Should also work for `boolean` (although such comparisons are not very common). Another case is for `typeof` in the context of union types: ``` typescript f...
Suggestion,Help Wanted,API
low
Minor
59,105,523
neovim
configure ";" and "," to repeat more motions
The ";" key is real nice to repeat f,t and T,F motions and save keystrokes. ### Problematic In real life, us english is not the only spoken language and in many keyboard layouts, you have to leave aside keys like "[", "]", "`" and even sometimes ";" in favor of direct acces to dead keys or accentuated characters such ...
enhancement,needs:design
low
Major
59,136,942
You-Dont-Know-JS
"async & performance": keep an eye on SharedArrayBuffer proposals
May solidify into something that the second edition of "async & performance" should cover. https://blog.mozilla.org/javascript/2015/02/26/the-path-to-parallel-javascript/ +@dherman
for second edition
medium
Major
59,308,054
rust
Comparison operators have higher precedence than range operator `..`
This has the effect of causing parse errors and other weirdness when trying to use a range literal in a comparison. ``` rust 1..2 == 1..2 ``` gives us > ``` > <input>:1:10: 1:12 error: expected one of `.`, `;`, `<eof>`, or an operator, found `..` > <input>:1 1..2 == 1..2 > ``` Huh? Okay, what about this? ``` rus...
E-hard,A-parser,P-low,I-needs-decision,T-lang,C-feature-request
low
Critical
59,419,745
You-Dont-Know-JS
"this & object prototypes": editorial review (about chapter 6)
Per Kyle's request, I'm posting what I find to be the serious issues with chapter 6 as they now stand; of course I'm open to being persuaded that I may have missed something. This is mostly from an Amazon review. I'll do my best to translate to second person, but forgive me if a few third person references to you sur...
for second edition,editorial
low
Critical
59,458,421
go
liblink, cmd/ld: don't encode the instruction being relocated in Reloc.add
When I first implemented cgo for ARM, I made the wrong precedence to encode the instruction itself in the relocation's addend field. It makes everything harder: liblink must stuff the real addend into the instruction, put it in reloc.add, and then in the linker, it must get the real addend out from the instruction, ca...
NeedsInvestigation
low
Major
59,589,304
rust
Consider using `llvm.invariant.*` intrinsics for immutable memory
Non-mutable memory that doesn't contain `UnsafeCell` can be marked `invariant`: http://llvm.org/docs/LangRef.html#llvm-invariant-start-intrinsic http://llvm.org/docs/Frontend/PerformanceTips.html
A-LLVM,I-slow,C-enhancement,A-codegen,T-compiler
low
Major
59,601,605
youtube-dl
Add support for yahoo sub domains
Pls. add support for following yahoo sub domains. https://hk.movies.yahoo.net/ https://tw.movies.yahoo.com http://special.movies.yahoo.co.jp/detail/20150303380294/ http://movies.yahoo.co.jp/movie/%E3%82%B7%E3%82%A7%E3%83%95%E3%80%80%E4%B8%89%E3%83%84%E6%98%9F%E3%83%95%E3%83%BC%E3%83%89%E3%83%88%E3%83%A9%E3%83%83%E3%82%...
site-support-request
low
Minor
59,605,273
go
runtime: GC behavior in non-steady mode
Currently GC allows heap to grow to 2x of live memory during the previous GC. This can play badly with spiky memory usage. Consider that in steady state program has live set X. GC will allow heap to grow to 2X and then collect it back to X, and so on. Now consider that there is a 1.5X spike in memory usage. If GC happe...
compiler/runtime
low
Major
59,692,531
nvm
sha1sum surprise
Unmet dependency on OSX. ``` -bash: sha1sum: command not found ``` Easy solve in the usual way. ``` brew install md5sha1sum ``` Perhaps a note in the readme?
installing node: checksums,shell alias clobbering,pull request wanted
low
Major
59,737,940
go
syscall: Syscall9 for darwin/{arm,arm64} actually grubs up to 7 arguments
But a few system calls require 8 or 9 arguments. ``` // Actually Syscall7. TEXT ·Syscall9(SB),NOSPLIT,$0-52 ```
OS-Darwin
low
Minor
59,741,263
rust
Incorrect / Inconsistent behavior of deref coercion with {}
In this code, the commented-out lines fail to compile. ``` rust struct Foo; fn f(_: &Foo) {} fn g(_: &&Foo) {} fn main() { let x: &Foo = &Box::new(Foo); f(x); f(&Box::new(Foo)); f(&(Box::new(Foo))); //f(&{Box::new(Foo)}); let y: &Foo = &Box::new(Foo); g(&y); //g(&&Box::new(Foo)); ...
A-type-system,T-compiler,C-bug,T-types
low
Major
59,817,082
go
x/build: trybot status shouldn't show FAIL for temp failures
The trybot status page shows "FAIL" even for temporary failures, like going over the quota. It should have a different state, or just show idle instead. Example screenshot: ![fail-quota](https://cloud.githubusercontent.com/assets/2621/6487003/87c77e3c-c243-11e4-9d40-d34f1767bd96.png) /cc @adg
Builders
low
Critical
60,021,414
TypeScript
Assignment of string literal indexed enum member passes compilation but results in invalid javascript
The following TypeScript: ``` const enum MyEnum {This,That}; MyEnum["That"] = 1; ``` compiles down to the following javascript: ``` ; 1 /* "That" */ = 1; ``` This holds true for standard `enum`s as well, a `const enum` was just a more succinct example. While I'm not sure why anyone would want to do this, it does se...
Bug,Help Wanted
low
Critical
60,112,796
TypeScript
Allow different syntactic elements have different indentation
Original issue: [[st3] keeps indenting by 4 ws when typing](https://github.com/Microsoft/ngconf2015demo/issues/2)
Suggestion,Help Wanted
low
Minor
60,188,037
go
cmd/pprof: duplicate listings in weblist report
When using the interactive "weblist" command, pprof generates multiple reports, one per source file, even though each report contains the same data accumulated across all sources. E.g., ``` go build -gcflags="-cpuprofile=$PWD/cpuprofile.1" -a runtime cp cpuprofile.1 cpuprofile.2 go tool pprof $(go env GOTOOLDIR)/6g c...
compiler/runtime
low
Minor
60,247,213
youtube-dl
Ustream not download
C:\Distribute\Soft\youtube-d>youtube-dl -o test.flv "http://www.ustream.tv/ embed/18742830?v=3&wmode=direct" --verbose [debug] System config: [] [debug] User config: [] [debug] Command-line args: ['-o', 'test.flv', 'http://www.ustream.tv/embed/ 18742830?v=3&wmode=direct', '--verbose'] [debug] Encodings: locale cp1251, ...
bug
low
Critical
60,263,802
go
cmd/internal/obj/arm64: moves that use C_BITCON and C_ADDCON don't work
Replaces 4ad/go#68. Issue #10108 is related.
NeedsInvestigation
low
Minor
60,264,039
go
cmd/internal/obj/arm64: floating point immediates are loaded through indirection
ARM64 is 64 bit, we gain nothing by coalescing float immediates as addresses are 64-bit. Related to issue #10108 and issue #10112. Replaces 4ad/go#49.
NeedsInvestigation
low
Minor
60,568,519
neovim
suspend/resume: check changed files
In vim, when I suspend with ctrl+z, change something, and then come back, vim will offer me options about reloading files. Neovim simply does not; I have to do :e to reload a file. Is this a bug?
bug
medium
Critical
60,667,040
go
x/mobile: font.Default cannot be parsed by freetype-go
font.Default loads kCTFontSystemFontType, which does not parse with the error: ``` freetype: unsupported TrueType feature: cmap encoding ``` The Monospace font (kCTFontUserFixedPitchFontType) works.
mobile
low
Critical
60,737,791
TypeScript
Support for tabs in language service formatter.
The formatter described in the link below currently doesn't seem to offer a way to indent by using tabs. https://github.com/Microsoft/TypeScript/wiki/Using-the-Compiler-API#pretty-printer-using-the-ls-formatter Could that be added? Thanks!
Suggestion,Help Wanted,API
low
Major
60,741,498
You-Dont-Know-JS
"async & performance": slim down general explanations of iterators/generators
Now that "ES6 & Beyond" is going to fully cover iterators and generators, perhaps it'd be appropriate to slim down ch4 a fair bit. For example, we could strip out some of the nuances around `yield *`, error propagation, etc.These are all interesting and useful details, but they're not entirely needed to understand usi...
for second edition
medium
Critical
60,761,118
go
x/tools/cmd/eg: support ... package expansion
``` bash $ eg -w -t t.go cmd/... cannot find package "cmd/..." in any of: ``` It'd be nice if eg supported `...` the way that the `go` tool does. I'm happy to do the legwork if desired.
NeedsInvestigation
low
Minor
60,761,657
go
x/tools/cmd/eg: allow multiple refactorings in a single template
While working on `Node` refactoring leading up to [CL 7360](https://go.dev/cl/7360), I found myself applying 8 different templates (one per relevant field) sequentially. It would be nicer to use--and I think faster to execute--to apply them all in a single pass. The template could look like a sequence of alternating p...
NeedsInvestigation
low
Critical
60,788,560
youtube-dl
https://www.tvnz.co.nz/worlds-worst/s1-ep1-video-6251831 fails to download
I'm happy to run more tests if need be. Would be nice to have tvnz.co.nz videos work with ytdl :) $ TZ="NZST" youtube-dl 'https://www.tvnz.co.nz/worlds-worst/s1-ep1-video-6251831' --verbose [debug] System config: [] [debug] User config: [] [debug] Command-line args: ['https://www.tvnz.co.nz/worlds-worst/s1-ep1-video-6...
site-support-request
low
Critical
61,556,815
youtube-dl
Please add support for godvine.com
Can not download this video: http://www.godvine.com/Return-Of-Lost-Love-Letter-Brings-Tears-For-WWII-Vet-6931.html
site-support-request
low
Minor
61,640,625
youtube-dl
Unable to download gamingcx.com's streaming videos.
From http://www.gamingcx.com/ ... Example: $ youtube-dl -v http://www.gamingcx.com/2015/03/gamecenter-cx-episode-126-super-spy.html [debug] System config: [] [debug] User config: [] [debug] Command-line args: ['-v', 'http://www.gamingcx.com/2015/03/gamecenter-cx-episode-126-super-spy.html'] [debug] Encodings: locale U...
site-support-request
low
Critical
61,654,715
rust
Move metadata out of dylibs
Crate metadata constitute [a significant proportion](https://github.com/rust-lang/rust/issues/21482) of Rust dylibs. It's only needed for compilation; otherwise it just bloats up the size of Rust programs, and, unlike debug info, can't even be easily stripped. In the case of dylibs, we could move metadata out into a ...
C-enhancement,A-metadata
low
Critical
61,668,175
TypeScript
Allow wrapped values to be used in place of primitives.
``` ts class NumberWrapper { constructor(private value: number) {} valueOf(): number { return this.value; } } var x = new NumberWrapper(1); // The right-hand side of an arithmetic operation // must be of type 'any', 'number' or an enum type. console.log(2 + x); ``` It would be nice if an arithmetic operatio...
Suggestion,Needs Proposal
high
Critical
61,916,455
neovim
Multihead: multiple linked clients (like Emacs "frames", multitenancy)
Hi Everyone, I've got a few use-cases that I'm wondering if Neovim can solve. If I'm missing something just let me know. The main thing I'd like to do is to be able to have two or more **linked** Windows (using OS terminology, NOT vim windows, see emacs **frames** for a comparison) of Vim. The reason for this is that ...
enhancement,ui,ui-extensibility
high
Critical
63,006,517
go
test/fixedbugs: bug248 and bug369 fail when the absolute path contains a space
Go version: ``` go version devel +6ffed30 Wed Mar 18 15:14:37 2015 +0000 darwin/amd64 ``` I did: ``` cd ~/"Google Drive" git clone https://go.googlesource.com/go cd go/src ./all.bash ``` I expected to see a successful build and test. Instead I saw: ``` ... ##### ../test # go run run.go -- fixedbugs/bug248.go exit...
Testing
low
Critical
63,088,055
rust
unused-features only warns unused non-language features
For the following snippet, rustc only warns about `rustc_privat` being unused: ``` #![feature(rustc_private)] #![feature(box_syntax)] #![feature(trace_macros)] #![feature(slicing_syntax)] #![feature(log_syntax)] fn main() {} ``` According to the documentation, [check_unused_or_stable_features](https://github.com/rus...
C-enhancement,A-diagnostics,T-compiler
low
Minor
63,162,672
rust
Poor interaction between int fallback and other flow of type information
A reduced example: ``` rust use std::ops::Shl; struct Foo<T>(T); impl<T> Shl<usize> for Foo<T> { type Output = Foo<T>; fn shl(self, _: usize) -> Foo<T> { self } } impl<T> Shl<i32> for Foo<T> { type Output = Foo<T>; fn shl(self, _: i32) -> Foo<T> { self } } fn main() { let _ = Foo(0u32) << 2; //...
A-type-system,T-compiler,A-inference,C-bug,T-types
low
Critical
63,302,490
neovim
`set <key>={sequence}` is not implemented
Sorry if this has been addressed in docs, but I searched and couldn't find anything. in my vimrc I have ``` set <k0>=^[Op set <k1>=^[Oq set <k2>=^[Or set <k3>=^[Os set <k4>=^[Ot set <k5>=^[Ou set <k6>=^[Ov set <k7>=^[Ow set <k8>=^[Ox set <k9>=^[Oy " These '^[' are all \x1b ("escape") chars ``` This is mainly being...
bug,compatibility,tui,core,mappings
medium
Critical
63,386,995
rust
region-outlives obligations lead to uninformative/undecipherable region inference failures
Consider this program: ``` rust use std::cell::Cell; trait Foo { fn foo(&mut self); } struct Pair<'a,'b> { x: &'a Cell<u8>, y: &'b Cell<u8> } // This impl says it callers of `foo` on `Pair<'a,'b>` must ensure // that 'b outlives 'a. impl<'a, 'b:'a> Foo for Pair<'a, 'b> { fn foo(&mut self) { println!("pre ...
C-enhancement,A-diagnostics,A-borrow-checker,T-compiler,D-confusing
low
Critical
63,442,176
youtube-dl
Read config file from current directory for portable Windows installation
On Windows, [the config file is currently read](https://github.com/rg3/youtube-dl/blob/master/README.md#configuration) from locations outside where youtube-dl.exe resides.
request
low
Minor
63,548,933
rust
Variables bound with different modes in patterns
The following doesn't compile: ``` rust enum Test<'a> { A(&'a u64), B(u64), } fn foo(test: Test) { match test { Test::A(r) | Test::B(ref r) => println!("{}", r) } } fn main() { foo(Test::A(&0)); foo(Test::B(1)); } ``` failing with the following error: ``` text test.rs:7:30: 7:35 error...
A-borrow-checker,T-compiler,C-bug
low
Critical
64,023,384
neovim
Nvim calls many getcwd and epoll_wait syscall
@tarruda please watch this video (download it to your local machine because the preview quality is crap). https://www.dropbox.com/s/96ky8qb8xpkdc82/nvim_strace-2015-03-24_12.14.04.mkv?dl=0 That slowness is noticeable using `unite.vim` plugin.
performance
low
Major
64,332,900
rust
error: overflow evaluating the requirement `<_ as core::iter::Iterator>::Item`
``` src/lib.rs:1:1: 1:1 error: overflow evaluating the requirement `<_ as core::iter::Iterator>::Item` [E0275 src/lib.rs:1 //! ^ ...
C-enhancement,T-compiler
medium
Critical
64,396,329
go
x/tools/cmd/eg: embedded fields are mishandled
$GOPATH/src/egbug/x.go: ``` go package egbug type T struct { *E E2 *E } type E struct { Next *T } func main() { var t *T t.Next = new(T) } ``` Template: ``` go package p import "egbug" func before(t *egbug.T) *egbug.T { return t.Next } func after(t *egbug.T) *egbug.T { return t.E2.Next } ``...
NeedsInvestigation
low
Critical
64,451,549
rust
Type inferencer probably could figure this case out (associated types)
``` rust trait Async { type Value; type Error; } enum Result<T, E> { Ok(T), Err(E), } impl<T, E> Result<T, E> { fn reduce<F, U>(self, init: U::Value, action: F) -> U::Value where F: Fn(U::Value, T) -> U, U: Async<Error=E> { unimplemented!(); } } impl Asyn...
A-type-system,C-enhancement,T-compiler,A-inference,T-types
low
Critical
64,505,138
go
x/tools/cmd/eg: needs package documentation
I pointed someone to https://golang.org/x/tools/cmd/eg, which unhelpfully says "For documentation, run the command , or see Help in golang.org/x/tools/refactor/eg". The command cannot be run on mobile, so they following the unclickable link (with some effort) to discover a Help that is not helpful: `const Help = "" /*...
Refactoring
low
Minor
64,652,293
rust
Order of operands to equality expression matters when inferring a AsRef implementation
This may be related to or the same as #23673, but I wanted to file it anyway as it seems to have a slightly different flavor. ``` rust #![feature(convert)] struct Container { i: u8, b: bool, } impl AsRef<u8> for Container { fn as_ref(&self) -> &u8 { &self.i } } // A second implementation to ...
A-type-system,P-low,I-needs-decision,T-compiler,A-inference,C-bug,T-types
low
Minor
64,747,765
go
runtime/cgo: test signal from foreign thread before cgo call
A C++ program can trigger the Go signal handler from a global constructor before any cgo calls are made. As badsignal uses cgocallback, this requires an extra M be initialized. This was done for #10207, as it appears to sometimes happen with the os/signal tests on darwin/arm. It needs a robust test. There also needs ...
compiler/runtime
low
Major
64,993,609
You-Dont-Know-JS
"async & performance": revise "TCO" discussion
- Move TCO from Chapter 6 to Chapter 5 - Slim it down - Refer to TCO in "ES6 & Beyond"
for second edition
medium
Major
65,085,737
neovim
:terminal should not use &shell
I use fish as a default shell, but sh as my shell for vim scripts because many of the plugins I use assume the standard sh syntax. fish does work, actually very well, with `:terminal`. According to [one SO answer](http://stackoverflow.com/questions/11059067/what-is-the-nix-command-to-view-a-users-default-login-shell),...
terminal
medium
Critical
65,337,979
electron
Support click-through of transparency
As commented here, https://github.com/atom/atom-shell/pull/949#issuecomment-87087841 - transparent windows unfortunately are of limited use unless you can click through the transparent area. I noticed that in the [documentation](https://github.com/atom/atom-shell/blob/master/docs/api/frameless-window.md#limitations) i...
enhancement :sparkles:,component/transparent
high
Critical
65,338,263
go
cmd/compile: inline function calls that return a closure
ERROR: type should be string, got "https://go-review.googlesource.com/#/c/8200/ added a benchmark to the strings package that shows strings.Trim and its variants allocate memory. The allocation is caused by the call to makeCutsetFunc <a href=\"https://github.com/golang/go/blob/master/src/strings/strings.go#L625\">here</a>. Inlining this call removes the allocation and provides a nice performance boost to Trim. You can see the effect on the benchmark using Go Tip (commit 6262192cd0fb98d6bb80752de70ae33fc10dc33e) below:\n\n```\nbenchmark old ns/op new ns/op delta\nBenchmarkTrim 3204 2323 -27.50%\n\nbenchmark old allocs new allocs delta\nBenchmarkTrim 11 0 -100.00%\n\nbenchmark old bytes new bytes delta\nBenchmarkTrim 352 0 -100.00%\n```\n\nmakeCutsetFunc is a pretty simple function (all it does is return a closure), and it was pointed out in review that it might be nice to inline functions like it in the compiler rather than changing strings.Trim explicitly. \n"
Performance,NeedsInvestigation,compiler/runtime
low
Major
65,410,337
javascript
Please include the "Why" in your styleguide
Hi there As your styleguide is getting popular I just wanted to express some concerns I have with it. I'm generally for styleguides, however, I believe that things are always depending on a context and if you're classifying something as bad / good you should always include a "why" and reason about your decision. There...
enhancement
medium
Critical
65,419,677
TypeScript
Suggestion: allow instantiation of type aliases
Currently a type aliased class [cannot be instantiated](https://github.com/Microsoft/TypeScript/issues/2552). Also there is no way to alias a [type with type parameters](https://github.com/Microsoft/TypeScript/issues/1616). Please consider making type aliases as capable as the types that they represent, basically captu...
Suggestion,Needs Proposal
medium
Critical
65,606,788
neovim
clipboard=autoselect
It will be convenient if neovim can automatically send visual selection to clipboard (without yanking).
clipboard,has:workaround
medium
Critical
65,778,995
youtube-dl
Can not download video
Hello. There is a university site here in Vienna. It has embedded flash player. I can watch the video in the browser (firefox) fine. But I want to save it locally too, because I want to watch it offline too - sometimes my internet connection is not up. Here is what I did - keep in mind that --password xxx is not my...
site-support-request,account-needed
low
Critical
65,949,492
nvm
Test failure
On master, `npm run test/fast` fails for me: ``` $ npm run test/fast > nvm@0.24.0 test/fast /home/ubuntu/src/nvm > shell=$(basename -- $(ps -o comm= $(ps -o ppid= -p $PPID)) | sed 's/^-//'); make TEST_SUITE=fast test-$shell Running tests in bash Running tests at 2015-04-02T15:15:03 test/fast ... Listing v...
testing,pull request wanted
low
Critical
65,970,808
go
debug/dwarf: No method to lookup type by type signature
The dwarf package internally has support for finding type entries by type signature, but it does not expose this to users of the dwarf package. (*Data).Type takes an "info" offset of a type entry and understands internally how to follow AttrType fields within that type that reference other types by signature. But AttrT...
compiler/runtime
low
Critical
66,008,931
rust
Coherence error messages can be inscrutable
In particular, when the overlap check fails, it doesn't give much clarity, particularly when the overlap is between impls in different crates. It should tell you: 1. Precisely what type overlaps 2. For each case of negative reasoning it was not able to make, why it was not able to make it. #2 might be a bit tricky to d...
E-hard,A-diagnostics,P-medium,T-compiler,C-bug
low
Critical
66,058,140
go
x/tools/cmd/eg: take better care with pointers, maintain addressability of expressions
Given this package: ``` go package egbug var Imap = map[*T]int{} type T struct { I int } func main() { var t T p := &t.I _ = p } ``` and this template: ``` go package p import "egbug" func before(t *egbug.T) int { return t.I } func after(t *egbug.T) int { return egbug.Imap[t] } ``` applying eg...
NeedsInvestigation
low
Critical
66,064,332
go
x/mobile/app: detect device orientation
A function that returns the device's current orientation would be handy to switch between portrait- and landscape-optimized user interfaces. ``` go const ( OrientationLandscape = iota OrientationPortrait // ... ) func Orientation() int ``` Thoughts? cc/ @crawshaw @hyangah
mobile
low
Major
66,087,891
go
x/mobile/exp/audio: support audio streaming
Currently, the audio player has a naive OpenAL backend that buffers the entire source into the memory to prepare the media. We currently can only recommend the audio player to play small audio files such as sound effects. In order to relax this restriction we should limit the generation of OpenAL buffers and reuse the...
mobile
low
Minor
66,139,313
TypeScript
Generic decorators - could they receive some default type arguments?
A decorator can receive arguments, by being defined as a function that accepts parameters and then returns a normal decorator function: ``` function computed(evaluator: (obj: any) => any) { return (obj: any, key: string) => { Object.defineProperty(obj, key, { get() { return evaluator(obj); } ...
Suggestion,In Discussion,Domain: Decorators
medium
Critical
66,322,347
rust
Trait impls from where clauses (`ParamEnv`) take precedence over freestanding trait impls
I stumbled upon this trying to write a function that generically takes a range (or something else with which `str` can be indexed), and slices a str with that range. I got that to work, this bug comes into play when the str is produced by slicing another string with a `RangeFrom` or another concrete type (in the same f...
A-trait-system,T-compiler,C-bug,T-types
low
Critical
66,382,673
go
net: File method of Conn on Windows
I am writing something that requires access to the file descriptor of a socket created by net.Dial (which returns a net.conn) and then recast as net.TCPConn so that I can use net.TCPConn.File().Fd(). However, (as the error message says), "dup is not supported on windows". for my purposes, I don't "need" the dup() and...
help wanted,OS-Windows
medium
Critical
66,488,441
nvm
Write tests for bare `nvm run X`
In order to test this, I'd need to figure out some way to intercept the call to `nvm-exec`, or, to intercept its call to `exec`. From #625.
testing,pull request wanted
low
Minor
66,677,821
nvm
Dash tests fail on my system
``` $ npm run test/fast > nvm@0.24.1 test/fast /home/ubuntu/src/nvm > shell=$(basename -- $(ps -o comm= $(ps -o ppid= -p $PPID)) | sed 's/^-//'); make TEST_SUITE=fast test-$shell Running tests in dash Running tests at 2015-04-06T18:49:59 test/fast Aliases ✗ Running "nvm alias <aliasname> <target>" again sh...
testing,pull request wanted
low
Major
66,679,535
rust
Numeric fallbacks don't work when inherent methods are involved
I would expect `2.0.sqrt()` to return sqrt(2) as a f64. Instead, ``` <anon>:9:13: 9:19 error: type `_` does not implement any method in scope named `sqrt` <anon>:9 2.0.sqrt() <anon>:9:19: 9:19 help: methods from traits can only be called if the trait is in scope; the following traits are implemented but not i...
A-type-system,T-lang,T-compiler,A-inference,C-bug,T-types
low
Critical
66,871,436
neovim
Terminal buffers don't respect `bufhidden` when not `hide` or `delete`
With a master build from a few days ago, terminal buffers seem to be deleted when the windows showing them is closed. This seems to contradict the usual usage patterns where buffers live until they are explicitly deleted by the user. Moreover, I'd like to be able to use a terminal session for some time, put it into the...
terminal
low
Major
66,884,431
go
cmd/compile: assigning large values does not use memmove
Consider this piece of code ``` package main import "fmt" func main() { f() } func f() { var a [200]int var b [200]int a = b b = a fmt.Println(&a, &b) } ``` The assignments of `a = b` or `b = a` where the size of `a` or `b` is above the DUFFCOPY limit of 128 words ...
compiler/runtime
low
Major
67,149,514
rust
regression: dead heap allocations aren't optimized out anymore
#22159 was closed after a llvm update (#22526). It used to work (I remember I tried it out). Now it doesn't work anymore. ``` rust fn main() { let _ = Box::new(42); } ``` http://is.gd/Wekr7w LLVM-IR: ``` llvm ; ModuleID = 'rust_out.0.rs' target datalayout = "e-i64:64-f80:128-n8:16:32:64-S128" target triple = "x...
A-LLVM,I-slow,C-enhancement,A-codegen,P-medium,T-compiler,C-optimization
medium
Critical
67,182,736
go
cmd/compile: use conditional execution in place of branches for small blocks on arm
For example, consider max: ``` go func max(a, b int) int { if a > b { return a } return b } ``` This compiles roughly to: ``` MOVW "".a(FP), R3 MOVW "".b+4(FP), R2 CMP R2, R3 BLE a MOVW R3, "".~r2+8(FP) RET a: MOVW R2, "".~r2+8(FP) RET ``` But it could be: ``` MOVW "".a(FP), R3 M...
NeedsInvestigation
low
Major
67,193,607
go
x/review/git-codereview: give an error if the Change-Id: line is deleted
I think this is the reason why some CLs have more than one Gerrit CL. Given that using the same change to open a fresh new gerrit CL is rarely needed, I think git-codereview should error out if the user deletes the Change-Id: line (with git change). And we can add a -f option to override the error (I'm also fine with...
NeedsInvestigation
low
Critical
67,361,885
youtube-dl
add bbc archive
hi, could you add support for bbc archive? thanks example page: http://www.bbc.co.uk/archive/whatwewore/5607.shtml ``` $ youtube-dl http://www.bbc.co.uk/archive/whatwewore/5607.shtml [generic] 5607: Requesting header WARNING: Falling back on generic information extractor. [generic] 5607: Downloading webpage [generic...
site-support-request
low
Critical
67,382,060
youtube-dl
Display speed and percentage when updating
request,build/update
low
Minor
67,462,206
TypeScript
Define assignability relation for primitive-constrained type parameters
The spec does not define any case in Assignment Compatibility where `S` is a type parameter constrained to a primitive type and `T` is that same primitive type. This leads to some weird errors, e.g. `T` is not assignable to `number` even though `T extends number`: ``` ts enum E { A, B, C } enum F { X, Y, Z } functio...
Suggestion,Help Wanted
low
Critical
67,490,520
go
gccgo: "incompatible type in initialization" is too vague
The error "incompatible type in initialization" is not very informative, here is a simple patch that of course could be better but shows the error. https://github.com/h4ck3rm1k3/gcc-1/commit/ba7845236966facf2a3a20e6a2c1817b59b9a913
NeedsInvestigation
low
Critical
67,564,470
javascript
Suggestion to set up Github Page
Maybe you want to set up a [GitHub Page](https://pages.github.com/) and get the custom domain [styleguide.js.org](http://dns.js.org) for free. (renaming the repo to `styleguide` would be required)
enhancement,question
low
Major
67,596,561
TypeScript
Flow type helpers
Flow offer some nice type helpers in his recent versions, while some of them are already addressed by typescript, some could perhaps be helpful. Here are extracted comments from flow source just for inspiration. - $Either<...T> is the union of types ...T - $All<...T> is the intersection of types ...T - $Supertype<T> ...
Suggestion,Needs Proposal
low
Major
67,613,789
neovim
Dynamically change `undofile()` / multiple undo trees per file
I often see that undofiles are not being taken into account anymore, which is likely to be caused by changing branches in Git etc, where the file contents then does not match anymore the expected contents - which then causes the undo information to be discarded. A good workaround for this might be to use additional in...
enhancement
low
Minor
67,621,596
rust
name-based comparison in new label-shadowing check has likely hygiene issues.
Spawned off of #24162. Our lifetimes only carry a `Name`, not an `Ident`, which means the comparisons for shadowing are only doing name based comparisons. But macros should be free to introduce labels, and have them be treated as independent due to hygiene. This bug is believed to only introduce issues where code wi...
P-low,A-macros,T-compiler,C-bug,A-hygiene
low
Critical
67,641,964
youtube-dl
add support for spoilertv.com
URL: http://www.spoilertv.com/2015/04/mr-robot-first-look-full-promo.html
site-support-request
low
Minor
67,653,448
neovim
perf: in_id_list()
When setting `cursorline` or `relativenumber` and opening a LaTeX file, the UI become sluggish and slow. This is a known problem in vim as well but I figured out maybe the UI refactoring that is going on makes it a good time to check it out. If it's not in its place, please let me know and I'll close.
performance,bug-vim,syntax
low
Major
67,690,282
rust
rustdoc: Pain points of reexports
There's a lot of pain points that come up over time about rustdoc and reexports, and there's a lot of open issues as well, so this is going to serve as a metabug connecting all of them: - [x] When a name is reexported across crates, the source crate does not show where it was reexported as (often the more canonical loc...
T-rustdoc,metabug,C-tracking-issue,A-cross-crate-reexports
low
Critical
67,706,794
go
x/build: automate testing "toolstash -cmp" with trybots
For cleanup CLs like https://go-review.googlesource.com/#/c/8762, it would be nice if the trybots could take care of building a toolchain at HEAD, toolstash saving it, rebuilding at HEAD+CL, and then running an appropriate "toolstash -cmp" build. Using toolstash/buildall, this only needs to be run once on a fast/cheap...
Builders,FeatureRequest
low
Minor
67,799,215
youtube-dl
Progress for --dump-json
Would it be possible to add a progress bar when fetching the data for a channel- or a playlist-json-dump (--dump-json)?
request
low
Major
67,914,531
youtube-dl
Automatically embed subtitles in mkv files
Since it's possible to embed subtitles in mp4 (in a hard coded way probably), is there a way to embed subtitles files with mkvmerge or with ffmpeg in the post-processing option ? (Maybe use the `--exec` command)
request,postprocessors
low
Minor
67,943,811
neovim
TagSearchPre/TagSearchPost Auto Commands
Commands and maps that require the presence of a tag file should emit TagSearchPre/TagSearchPost events. This would include: ``` :[count]ta[g][!] {ident} g<LeftMouse> <C-LeftMouse> CTRL-] {Visual}CTRL-] :ts[elect][!] [ident] :sts[elect][!] [ident] g] {Visual}g] :tj[ump][!] [ident] :stj[ump][!] [ident] g CTRL-] {Visual...
enhancement,events
low
Minor
67,962,340
youtube-dl
[Request] Would a %if(playlist)s tag be possible?
It would be very handy when used in a config.txt file: -o "D:\%(uploader)s-%(upload_date)s-(%if(playlist)s_%(playlist_index)s) - %(title)s.%(ext)s" Or even simplier, YDL could detect if the video is part of a playlist and automatically add which number the videos are in the playlist. Like: -o "D:\%(uploader)s-%(uploa...
request
low
Minor
67,966,709
youtube-dl
Variable line-break spacing in Vimeo descriptions not being detected
As seen in the description of https://vimeo.com/38644453, Vimeo appears to allow different amounts of spacing between paragraphs and line-breaks. (Some sentences have a larger vertical gap between the lines.) Looking at the source, a combination of `<p>` and `<br>` HTML tags are used to achieve this effect. These are n...
request
low
Critical