id int64 393k 2.82B | repo stringclasses 68
values | title stringlengths 1 936 | body stringlengths 0 256k ⌀ | labels stringlengths 2 508 | priority stringclasses 3
values | severity stringclasses 3
values |
|---|---|---|---|---|---|---|
2,509,684,861 | pytorch | torch.floor_divide not triggering ZeroDivisionError on GPU | ### 🐛 Describe the bug
Running torch.divide with 0 as the denominator does not throw ZeroDivisionError on GPU, neither does it result in inf. Executing on CPU throws ZeroDivisionError as expected.
Code snippet: [Colab](https://colab.research.google.com/drive/1faFvmBrN7NRr-eDjjOkDVcvVJcB30eGP?usp=sharing)
Minimal repro:
```python
import torch
output = torch.floor_divide(torch.tensor(1).cuda(), torch.tensor(0).cuda())
print(output)
# tensor(4294967295, device='cuda:0')
```
### Versions
Collecting environment information...
PyTorch version: 2.4.0+cu121
Is debug build: False
CUDA used to build PyTorch: 12.1
ROCM used to build PyTorch: N/A
OS: Ubuntu 20.04.6 LTS (x86_64)
GCC version: (Ubuntu 9.4.0-1ubuntu1~20.04.2) 9.4.0
Clang version: 15.0.0 (git@github.com:llvm/llvm-project.git 4ba6a9c9f65bbc8bd06e3652cb20fd4dfc846137)
CMake version: version 3.22.1
Libc version: glibc-2.31
Python version: 3.10.0 (default, Mar 3 2022, 09:58:08) [GCC 7.5.0] (64-bit runtime)
Python platform: Linux-5.15.0-117-generic-x86_64-with-glibc2.31
Is CUDA available: True
CUDA runtime version: Could not collect
CUDA_MODULE_LOADING set to: LAZY
GPU models and configuration: GPU 0: NVIDIA GeForce RTX 4090
Nvidia driver version: 555.42.02
cuDNN version: /usr/lib/x86_64-linux-gnu/libcudnn.so.7.6.5
HIP runtime version: N/A
MIOpen runtime version: N/A
Is XNNPACK available: True
CPU:
Architecture: x86_64
CPU op-mode(s): 32-bit, 64-bit
Byte Order: Little Endian
Address sizes: 39 bits physical, 48 bits virtual
CPU(s): 24
On-line CPU(s) list: 0-23
Thread(s) per core: 1
Core(s) per socket: 16
Socket(s): 1
NUMA node(s): 1
Vendor ID: GenuineIntel
CPU family: 6
Model: 183
Model name: 13th Gen Intel(R) Core(TM) i7-13700KF
Stepping: 1
CPU MHz: 5188.958
CPU max MHz: 5800.0000
CPU min MHz: 800.0000
BogoMIPS: 6835.20
Virtualization: VT-x
L1d cache: 384 KiB
L1i cache: 256 KiB
L2 cache: 16 MiB
NUMA node0 CPU(s): 0-23
Vulnerability Gather data sampling: Not affected
Vulnerability Itlb multihit: Not affected
Vulnerability L1tf: Not affected
Vulnerability Mds: Not affected
Vulnerability Meltdown: Not affected
Vulnerability Mmio stale data: Not affected
Vulnerability Reg file data sampling: Mitigation; Clear Register File
Vulnerability Retbleed: Not affected
Vulnerability Spec rstack overflow: Not affected
Vulnerability Spec store bypass: Mitigation; Speculative Store Bypass disabled via prctl and seccomp
Vulnerability Spectre v1: Mitigation; usercopy/swapgs barriers and __user pointer sanitization
Vulnerability Spectre v2: Mitigation; Enhanced / Automatic IBRS; IBPB conditional; RSB filling; PBRSB-eIBRS SW sequence; BHI BHI_DIS_S
Vulnerability Srbds: Not affected
Vulnerability Tsx async abort: Not affected
Flags: fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush dts acpi mmx fxsr sse sse2 ss ht tm pbe syscall nx pdpe1gb rdtscp lm constant_tsc art arch_perfmon pebs bts rep_good nopl xtopology nonstop_tsc cpuid aperfmperf tsc_known_freq pni pclmulqdq dtes64 monitor ds_cpl vmx est tm2 ssse3 sdbg fma cx16 xtpr pdcm sse4_1 sse4_2 x2apic movbe popcnt tsc_deadline_timer aes xsave avx f16c rdrand lahf_lm abm 3dnowprefetch cpuid_fault epb ssbd ibrs ibpb stibp ibrs_enhanced tpr_shadow vnmi flexpriority ept vpid ept_ad fsgsbase tsc_adjust bmi1 avx2 smep bmi2 erms invpcid rdseed adx smap clflushopt clwb intel_pt sha_ni xsaveopt xsavec xgetbv1 xsaves split_lock_detect avx_vnni dtherm ida arat pln pts hwp hwp_notify hwp_act_window hwp_epp hwp_pkg_req umip pku ospke waitpkg gfni vaes vpclmulqdq rdpid movdiri movdir64b fsrm md_clear serialize arch_lbr flush_l1d arch_capabilities
Versions of relevant libraries:
[pip3] numpy==1.26.4
[pip3] optree==0.11.0
[pip3] torch==2.4.0
[pip3] triton==3.0.0
[conda] numpy 1.26.4 py310heeff2f4_0
[conda] numpy-base 1.26.4 py310h8a23956_0
[conda] optree 0.11.0 pypi_0 pypi
[conda] torch 2.4.0 pypi_0 pypi
[conda] triton 3.0.0 pypi_0 pypi
cc @malfet | module: error checking,triaged,module: edge cases | low | Critical |
2,509,712,635 | rust | `expect` on struct does not cover the derives | Minimal reproducer:
```rust
#[expect(clippy::derived_hash_with_manual_eq)]
#[derive(Hash)]
pub struct Thing;
impl PartialEq<Thing> for Thing {
fn eq(&self, _other: &Thing) -> bool {
true
}
}
```
I ran `cargo clippy`, and I expected the `expect` to suppress the `clippy::derived_hash_with_manual_eq` lint. Instead, I got the following:
```
error: you are deriving `Hash` but have implemented `PartialEq` explicitly
--> src/lib.rs:2:10
|
2 | #[derive(Hash)]
| ^^^^
|
note: `PartialEq` implemented here
--> src/lib.rs:5:1
|
5 | impl PartialEq<Thing> for Thing {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derived_hash_with_manual_eq
= note: `#[deny(clippy::derived_hash_with_manual_eq)]` on by default
= note: this error originates in the derive macro `Hash` (in Nightly builds, run with -Z macro-backtrace for more info)
warning: this lint expectation is unfulfilled
--> src/lib.rs:1:10
|
1 | #[expect(clippy::derived_hash_with_manual_eq)]
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= note: `#[warn(unfulfilled_lint_expectations)]` on by default
```
I haven't found any way to apply the `expect` to the derive except by putting it on the containing module.
**Note, however, that replacing the `expect` with an `allow` *does* successfully suppress the warning.** This seems particularly surprising, and violates the expectation that replacing an `allow` with an `expect` should *always* work.
### Meta
`rustc --version --verbose`:
```
rustc 1.81.0 (eeb90cda1 2024-09-04)
binary: rustc
commit-hash: eeb90cda1969383f56a2637cbd3037bdf598841c
commit-date: 2024-09-04
host: x86_64-unknown-linux-gnu
release: 1.81.0
LLVM version: 18.1.7
``` | A-lints,T-compiler,C-bug,F-lint_reasons | low | Critical |
2,509,726,564 | go | cmd/compile: .closureptr elided in optimized binaries | ```
$ go version
go version go1.23.0 linux/amd64
```
(also reproduces on tip)
Given this [sample program using range-over-func](https://go.dev/play/p/OSXhY_iOlE8) the DIE emitted for `main.PrintAllElements[go.shape.string]-range1` **when optimizations are enabled** is:
```
<1><216c>: Abbrev Number: 3 (DW_TAG_subprogram)
<216d> DW_AT_name : main.PrintAllElements[go.shape.string]-range1
<219b> DW_AT_low_pc : 0x48f520
<21a3> DW_AT_high_pc : 0x48f605
<21ab> DW_AT_frame_base : 1 byte block: 9c (DW_OP_call_frame_cfa)
<21ad> DW_AT_decl_file : 0x2
<21b1> DW_AT_decl_line : 47
<21b2> DW_AT_external : 1
<2><21b3>: Abbrev Number: 31 (DW_TAG_typedef)
<21b4> DW_AT_name : .param3
<21bc> DW_AT_type : <0x27e86>
<21c0> Unknown AT value: 2906: 3
<2><21c1>: Abbrev Number: 44 (DW_TAG_formal_parameter)
<21c2> DW_AT_name : v
<21c4> DW_AT_variable_parameter: 0
<21c5> DW_AT_decl_line : 47
<21c6> DW_AT_type : <0x21b3>
<21ca> DW_AT_location : 0x1799 (location list)
<2><21ce>: Abbrev Number: 9 (DW_TAG_inlined_subroutine)
<21cf> DW_AT_abstract_origin: <0x1e48>
<21d3> DW_AT_ranges : 0x980
<21d7> DW_AT_call_file : 0x2
<21db> DW_AT_call_line : 49
<3><21dc>: Abbrev Number: 41 (DW_TAG_formal_parameter)
<21dd> DW_AT_abstract_origin: <0x1e59>
<21e1> DW_AT_location : 0 byte block: ()
<3><21e2>: Abbrev Number: 0
<2><21e3>: Abbrev Number: 0
```
No entries for `.closureptr` are generated, presumably because all the stores related to `.closureptr` are optimized away.
Originally reported as https://github.com/go-delve/delve/issues/3806 (where it triggers other related delve bugs).
We could also say that with optimized binaries we do not correlate closure bodies with their parent in the debugger, or that we do a best effort thing and occasionally get it wrong (I suspect actually keeping track of .closureptr could have negative performance effects).
cc @dr2chase | NeedsInvestigation,compiler/runtime | low | Critical |
2,509,730,783 | rust | Build target `arm64ec-pc-windows-msvc` with `-Zbuild-std` got linking error. | Build project target `arm64ec-pc-windows-msvc` with `-Zbuild-std` on x86-64 windows host got linking error message like below:
```
lld: error: msvcrt.lib(tlssup.obj): machine type arm64 conflicts with arm64ec␍
```
How to fix it? | A-linkage,O-windows,T-compiler,requires-nightly,O-AArch64,-Zbuild-std | low | Critical |
2,509,769,523 | ui | [feat]: Default selected package registry | ### Feature description
I think its possible, not a very big improvment on the feature, but woul save quite some time.
Idea: when we click on "copy" button over the command line `npm install next-themes` there is popup to select which package registry to use, all the time.
Possible to this popover move selection before copying, over the "copy" button ?
For example, If I change, click on npm, next times when i will copy from all ui components npm command would be attached and vice verca.
Like if we take doccumentation from firebase, like alternative:
### Affected component/components
Documentation, package registry selection
### Additional Context
Additional details here...
### Before submitting
- [X] I've made research efforts and searched the documentation
- [X] I've searched for existing issues and PRs | area: request | low | Minor |
2,509,777,117 | godot | The "Dock Position" window is visible after clicking on it. | ### Tested versions
v3.6.rc1.official [cfc4a0eff]
Works well in v4.4.dev1.official [28a72fa43]
### System information
w10 64
### Issue description
Watch the video.
Once I use the "Dock Position" window by clicking on it, the window does not deactivate and remains visible. An extra empty click is required to make it disappear.
I think the expected behavior is for the window to deactivate once it is clicked on as it is annoying to keep it active after it has fulfilled its function.
v3.6.rc1.official [cfc4a0eff]
https://github.com/user-attachments/assets/70c69ae0-575b-459e-afa6-cf71985dd212
### Steps to reproduce
See the video
### Minimal reproduction project (MRP)
... | topic:editor | low | Minor |
2,509,798,526 | flutter | Android System UI overlaps app bar on desktop target | ### Steps to reproduce
1. Create a new Flutter demo project
2. Add two test actions to the app bar
3. Launch the app on an Android emulator "Small Desktop" with Android 14
### Expected results
The system UI should not overlap with the app AppBar
### Actual results
The system UI does overlap with the app content (AppBar):
In details, the back, minimize, maximize and close buttons overlaps with the appbar
### Code sample
<details open><summary>Code sample</summary>
```dart
import 'package:flutter/material.dart';
void main() {
runApp(const MyApp());
}
class MyApp extends StatelessWidget {
const MyApp({super.key});
// This widget is the root of your application.
@override
Widget build(BuildContext context) {
return MaterialApp(
title: 'Flutter Demo',
theme: ThemeData(
colorScheme: ColorScheme.fromSeed(seedColor: Colors.deepPurple),
useMaterial3: true,
),
home: const MyHomePage(title: 'Flutter Demo Home Page'),
);
}
}
class MyHomePage extends StatefulWidget {
const MyHomePage({super.key, required this.title});
final String title;
@override
State<MyHomePage> createState() => _MyHomePageState();
}
class _MyHomePageState extends State<MyHomePage> {
int _counter = 0;
void _incrementCounter() {
setState(() {
_counter++;
});
}
@override
Widget build(BuildContext context) {
return Scaffold(
appBar: AppBar(
backgroundColor: Theme.of(context).colorScheme.inversePrimary,
title: Text(widget.title),
actions: [
IconButton(
icon: const Icon(Icons.settings),
onPressed: () {},
),
IconButton(
icon: const Icon(Icons.access_alarm),
onPressed: () {},
),
],
),
body: Center(
child: Column(
mainAxisAlignment: MainAxisAlignment.center,
children: <Widget>[
const Text(
'You have pushed the button this many times:',
),
Text(
'$_counter',
style: Theme.of(context).textTheme.headlineMedium,
),
],
),
),
floatingActionButton: FloatingActionButton(
onPressed: _incrementCounter,
tooltip: 'Increment',
child: const Icon(Icons.add),
), // This trailing comma makes auto-formatting nicer for build methods.
);
}
}
```
</details>
### Screenshots or Video
_No response_
### Logs
_No response_
### Flutter Doctor output
<details open><summary>Doctor output</summary>
```console
[√] Flutter (Channel stable, 3.24.1, on Microsoft Windows [Versione 10.0.22631.4112], locale it-IT)
• Flutter version 3.24.1 on channel stable at C:\Tools\flutter
• Upstream repository https://github.com/flutter/flutter.git
• Framework revision 5874a72aa4 (2 weeks ago), 2024-08-20 16:46:00 -0500
• Engine revision c9b9d5780d
• Dart version 3.5.1
• DevTools version 2.37.2
[√] Windows Version (Installed version of Windows is version 10 or higher)
[√] Android toolchain - develop for Android devices (Android SDK version 35.0.0)
• Android SDK at D:\Tools\AndroidSdk
• Platform android-34, build-tools 35.0.0
• ANDROID_SDK_ROOT = D:\Tools\AndroidSdk
• Java binary at: C:\Program Files\Android\Android Studio\jbr\bin\java
• Java version OpenJDK Runtime Environment (build 17.0.11+0--11852314)
• All Android licenses accepted.
[√] Chrome - develop for the web
• Chrome at C:\Program Files\Google\Chrome\Application\chrome.exe
[√] Visual Studio - develop Windows apps (Visual Studio Community 2022 17.10.6)
• Visual Studio at C:\Program Files\Microsoft Visual Studio\2022\Community
• Visual Studio Community 2022 version 17.10.35201.131
• Windows 10 SDK version 10.0.22621.0
[√] Android Studio (version 2024.1)
• Android Studio at C:\Program Files\Android\Android Studio
• Flutter plugin can be installed from:
https://plugins.jetbrains.com/plugin/9212-flutter
• Dart plugin can be installed from:
https://plugins.jetbrains.com/plugin/6351-dart
• Java version OpenJDK Runtime Environment (build 17.0.11+0--11852314)
[√] VS Code (version 1.92.2)
• VS Code at C:\Users\fossati\AppData\Local\Programs\Microsoft VS Code
• Flutter extension can be installed from:
https://marketplace.visualstudio.com/items?itemName=Dart-Code.flutter
[√] Connected device (4 available)
• sdk gpc x86 64 (mobile) • emulator-5554 • android-x64 • Android 14 (API 34) (emulator)
• Windows (desktop) • windows • windows-x64 • Microsoft Windows [Versione 10.0.22631.4112]
• Chrome (web) • chrome • web-javascript • Google Chrome 128.0.6613.115
• Edge (web) • edge • web-javascript • Microsoft Edge 128.0.2739.63
[√] Network resources
• All expected network resources are available.
• No issues found!
```
</details>
| e: device-specific,platform-android,a: layout,has reproducible steps,P2,team-android,triaged-android,found in release: 3.24,found in release: 3.25 | low | Minor |
2,509,809,758 | opencv | Mat contructor with GMat | ### Describe the feature and motivation
Following PR #25055 why not extend the Mat constructor with GMat for the reverse operation?
### Additional context
_No response_ | feature,category: g-api / gapi | low | Minor |
2,509,813,597 | transformers | Add "EAT: Self-Supervised Pre-Training with Efficient Audio Transformer" | ### Model description
The original authors of the model write:
> EAT is an audio self-supervised learning model with high effectiveness and efficiency during self-supervised pre-training. You can find details in the paper [EAT: Self-Supervised Pre-Training with Efficient Audio Transformer](https://arxiv.org/abs/2401.03497).
A self-supervised learning model can benefit the community greatly, since it requires no labelled data, and can be trained on any dataset. Especially since, the strength of this approach is that it can be applied to variable-length audio. With enough resources (for example, compute, and, data), it could have a similar reach as BERT.
### Open source status
- [X] The model implementation is available
- [X] The model weights are available
### Provide useful links for the implementation
- GitHub Repo: https://github.com/cwx-worst-one/EAT
- Links for model checkpoints:
- [EAT-base_epoch30](https://drive.google.com/file/d/19hfzLgHCkyqTOYmHt8dqVa9nm-weBq4f/view?usp=sharing) (pre-training)
- [EAT-base_epoch30](https://drive.google.com/file/d/1aCYiQmoZv_Gh1FxnR-CCWpNAp6DIJzn6/view?usp=sharing) (fine-tuning on AS-2M)
- [EAT-large_epoch20](https://drive.google.com/file/d/1PEgriRvHsqrtLzlA478VemX7Q0ZGl889/view?usp=sharing) (pre-training)
- [EAT-large_epoch20](https://drive.google.com/file/d/1b_f_nQAdjM1B6u72OFUtFiUu-4yM2shd/view?usp=sharing) (fine-tuning on AS-2M)
- Paper: https://www.ijcai.org/proceedings/2024/421 | New model,Feature request | low | Minor |
2,509,817,616 | vscode | Multi Diff Editor: File Tool Bar has no background color | Compare how it looks in the tab bar vs multi diff editor
<img width="467" alt="image" src="https://github.com/user-attachments/assets/debab87e-22b2-44ea-a6b4-c7f971c58ae4">
| bug,multi-diff-editor | low | Minor |
2,509,840,466 | langchain | UnstructuredPDFLoader: poppler and tesseract not found issue | ### Checked other resources
- [X] I added a very descriptive title to this issue.
- [X] I searched the LangChain documentation with the integrated search.
- [X] I used the GitHub search to find a similar question and didn't find it.
- [X] I am sure that this is a bug in LangChain rather than my code.
- [X] The bug is not resolved by updating to the latest stable version of LangChain (or the specific integration package).
### Example Code
```python
from langchain_community.document_loaders import UnstructuredPDFLoader
loader = UnstructuredPDFLoader(path_to_pdf)
loader.load()[0].page_content
```
### Error Message and Stack Trace (if applicable)
1. PDFInfoNotInstalledError: Unable to get page count. Is poppler installed and in PATH?
2. TesseractNotFoundError: tesseract is not installed or it's not in your PATH. See README file for more information.
### Description
I'm trying to use UnstructuredPDFLoader to load pdf but encounter errors as mentioned above.
### PDFInfoNotInstalledError
1. I have installed poppler and add into PATH.✅
2. when i run ```which pdfinfo``` it returns me the correct path ```/opt/homebrew/Cellar/poppler/24.04.0_1/bin/pdfinfo```✅
3. However, if i run ```poppler --version```, I get ```zsh: command not found: poppler```, and this happends to my other laptops as well❓
4. This problem resolves if I manually change the paramter default value of all ```poppler_path``` from None to the path: ```poppler_path: Union[str, PurePath] = "/opt/homebrew/Cellar/poppler/24.04.0_1/bin/"``` (in ./.venv/lib/python3.11/site-packages/pdf2image/pdf2image.py)
5. But it will give TesseractNotFoundError
### TesseractNotFoundError
1. I have installed tesseract and add into PATH.✅
2. when i run ```which tesseract``` it returns me the correct path ```/opt/homebrew/bin/tesseract```✅
3. when i run ```tesseract --version``` it returns me the correct verssion✅
4. This problem resolves if I manually change variable```tesseract_cmd``` from ```'tesseract``` to the path: ```tesseract_cmd = '/opt/homebrew/Cellar/tesseract/5.4.1/bin/tesseract'``` (in ./.venv/lib/python3.11/site-packages/unstructured_pytesseract/pytesseract.py)
### System Info
Package Information
-------------------
> langchain_core: 0.2.38
> langchain: 0.2.16
> langchain_community: 0.2.16
> langsmith: 0.1.115
> langchain_google_vertexai: 1.0.10
> langchain_text_splitters: 0.2.4
> langgraph: 0.2.18
platform mac
Python 3.11.3 | 🤖:bug,stale | low | Critical |
2,509,931,283 | vscode | [html] highlighting does not detect end script tag in string literals | <!-- ⚠️⚠️ Do Not Delete This! bug_report_template ⚠️⚠️ -->
<!-- Please read our Rules of Conduct: https://opensource.microsoft.com/codeofconduct/ -->
<!-- 🕮 Read our guide about submitting issues: https://github.com/microsoft/vscode/wiki/Submitting-Bugs-and-Suggestions -->
<!-- 🔎 Search existing issues to avoid creating duplicates. -->
<!-- 🧪 Test using the latest Insiders build to see if your issue has already been fixed: https://code.visualstudio.com/insiders/ -->
<!-- 💡 Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. -->
<!-- 🔧 Launch with `code --disable-extensions` to check. -->
Does this issue occur when all extensions are disabled?: Yes
<!-- 🪓 If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. -->
<!-- 📣 Issues caused by an extension need to be reported directly to the extension publisher. The 'Help > Report Issue' dialog can assist with this. -->
- VS Code Version: 1.90.2
- OS Version: macOS 14.5
Steps to Reproduce:
1. type following txt to vscode
```html
<!DOCTYPE html>
<html>
<body>
<script>
const data = {
"name": "John",
"age": 30,
"description": "He is a st</script><svg onload=alert(1111)>"
}
</script>
</body>
</html>
```
2. find a bug
<img width="589" alt="image" src="https://github.com/user-attachments/assets/71324df9-e2a3-49ac-9072-4b843a11ee49">
in chrome is parsed as
script block highlighting is wrong. </script> can cut string while vscode not
| bug,html | low | Critical |
2,509,989,297 | ui | [feat]: support for rsbuild | ### Feature description
Right now Shadcn supports frameworks like Next.js, Vite, Astro, etc... However a popular choice these days are [Rsbuild](https://rsbuild.dev/) as it's extremely fast and lean. It would be great if we could directly initialize & install components via init or the CLI in rsbuild.
### Before submitting
- [X] I've made research efforts and searched the documentation
- [X] I've searched for existing issues and PRs | area: request | medium | Major |
2,510,000,356 | neovim | window-local 'guifont' | ### Problem
I use some UI plugins like [vim-dadbod-ui](https://github.com/kristijanhusak/vim-dadbod-ui), which use multiple splits.
When sharing my screen, or just in general, I would like to set the font size of some of those splits.
I found https://github.com/neovim/neovim/issues/18285, which suggests using `nvim_ui_try_resize_grid()`, however I cannot find this function in the docs, and it seems to not be available in my neovim (0.10.1).
### Expected behavior
I think it would be good to add a function to the api that allows setting the font size (or increase it) for the current split/buffer/window. | enhancement,api,ui-extensibility,options | low | Minor |
2,510,005,104 | ollama | Simplify the input of multi-line text | Simplify the input of multi-line text：
Use ctrl + enter keys to wrap the line | feature request | low | Minor |
2,510,030,455 | storybook | [Bug]: Storybook composition doesn't work properly on a screen width of less than 600px | ### Describe the bug
The storybook composition does not work correctly on a screen less than 600px wide. The problem does not occur on a standalone storybook instance.
<img width="1727" alt="Screenshot 2024-09-06 at 11 37 09" src="https://github.com/user-attachments/assets/ea392f5c-6f37-4973-aca0-2797c77db641">
### Reproduction link
https://github.com/tosesek/storybook-composition-issue
### Reproduction steps
1. Clone this repository
2. Install the dependencies
3. Run `npm run storybook`
4. Open the preview of any component
5. Resize your browser so that the window width is less than 600px
### System
```bash
Storybook Environment Info:
System:
OS: macOS 14.6.1
CPU: (10) arm64 Apple M1 Pro
Shell: 5.9 - /bin/zsh
Binaries:
Node: 18.18.2 - ~/.nvm/versions/node/v18.18.2/bin/node
npm: 9.8.1 - ~/.nvm/versions/node/v18.18.2/bin/npm <----- active
pnpm: 9.7.0 - ~/Library/pnpm/pnpm
Browsers:
Chrome: 128.0.6613.119
Safari: 17.6
npmPackages:
@storybook/addon-essentials: ^8.2.9 => 8.2.9
@storybook/addon-links: ^8.2.9 => 8.2.9
@storybook/blocks: ^8.2.9 => 8.2.9
@storybook/react: ^8.2.9 => 8.2.9
@storybook/react-vite: ^8.2.9 => 8.2.9
@storybook/test: ^8.2.9 => 8.2.9
eslint-plugin-storybook: ^0.8.0 => 0.8.0
storybook: ^8.2.9 => 8.2.9
```
### Additional context
_No response_ | bug,needs triage | low | Critical |
2,510,035,123 | storybook | [Bug]: expect.poll is missing | ### Describe the bug
(It might be a feature request, rather than a bug report)
Docs says that Storybook exposes vitest's API, but [`expect.poll`](https://vitest.dev/api/expect.html#poll) is missing.
### Reproduction link
https://stackblitz.com/edit/github-eut88f?file=src%2Fstories%2FPage.stories.ts
### Reproduction steps
1. Go to above link
2. hover `expect.poll`
### System
```bash
Storybook Environment Info:
System:
OS: Linux 5.0 undefined
CPU: (6) x64 Intel(R) Core(TM) i9-9880H CPU @ 2.30GHz
Shell: 1.0 - /bin/jsh
Binaries:
Node: 18.20.3 - /usr/local/bin/node
Yarn: 1.22.19 - /usr/local/bin/yarn
npm: 10.2.3 - /usr/local/bin/npm <----- active
pnpm: 8.15.6 - /usr/local/bin/pnpm
npmPackages:
@storybook/addon-essentials: ^8.3.0-beta.3 => 8.3.0-beta.3
@storybook/addon-interactions: ^8.3.0-beta.3 => 8.3.0-beta.3
@storybook/addon-links: ^8.3.0-beta.3 => 8.3.0-beta.3
@storybook/addon-onboarding: ^8.3.0-beta.3 => 8.3.0-beta.3
@storybook/blocks: ^8.3.0-beta.3 => 8.3.0-beta.3
@storybook/react: ^8.3.0-beta.3 => 8.3.0-beta.3
@storybook/react-vite: ^8.3.0-beta.3 => 8.3.0-beta.3
@storybook/test: ^8.3.0-beta.3 => 8.3.0-beta.3
storybook: ^8.3.0-beta.3 => 8.3.0-beta.3
```
### Additional context
_No response_ | bug,needs triage | low | Critical |
2,510,038,133 | storybook | [Bug]: Angular provider recreation differs between docs & story view | ### Describe the bug
When defining Angular providers in the `moduleMetadata` of the `render` function, the recreation of them differs between the docs and the story page.
In the docs page, they get recreated on every change of the Controls, but this doesn't happen on the story page.
We need this recreation to mock values of services or e.g. NgRx Store based on Storybook Controls.
### Reproduction link
https://stackblitz.com/edit/github-yzh9ef?file=src%2Fstories%2Fbutton.stories.ts
### Reproduction steps
1. Open the Storybook from the Reproduction.
2. Go to docs page of the Button component.
3. Change input & service value via controls.
-> Both values are updated in the story view.
5. Go to the single story of the Button component.
6. Change input & service value via controls.
-> Only input value changes are represented in the story view
and service value changes doesn't have any effect.
### System
```bash
System:
OS: Windows 10 10.0.19045
CPU: (12) x64 12th Gen Intel(R) Core(TM) i7-1265U
Binaries:
Node: 20.17.0 - C:\Program Files\nodejs\node.EXE
npm: 10.8.2 - C:\Program Files\nodejs\npm.CMD <----- active
Browsers:
Edge: Chromium (127.0.2651.74)
npmPackages:
@storybook/addon-designs: 8.0.3 => 8.0.3
@storybook/addon-essentials: 8.2.9 => 8.2.9
@storybook/addon-interactions: 8.2.9 => 8.2.9
@storybook/addon-mdx-gfm: 8.2.9 => 8.2.9
@storybook/addon-themes: 8.2.9 => 8.2.9
@storybook/angular: 8.2.9 => 8.2.9
@storybook/core-server: 8.2.9 => 8.2.9
@storybook/manager-api: 8.2.9 => 8.2.9
@storybook/test-runner: 0.19.1 => 0.19.1
@storybook/theming: 8.2.9 => 8.2.9
eslint-plugin-storybook: 0.8.0 => 0.8.0
storybook: 8.2.9 => 8.2.9
```
### Additional context
_No response_ | bug,has workaround,angular | low | Critical |
2,510,065,083 | transformers | Accelerate x Trainer issue tracker: | A bunch of issues are a bit stale, and @SunMarc + @muellerzr are a bit short on bandwidth!
Thus we would love to have community support to solve the following:
### Help needed
- [x] #27830
- [ ] #30911
- [x] #30702
- [x] #30239
- [x] #29348
- [ ] #33157
- [x] #28469
- [x] #30663
- [x] #30811
- [ ] #30819
- [x] #31313
- [x] #31457
- [ ] #30859
- [x] #31897
- [x] #30340
- [x] #31892
- [x] #28914
- [x] #29518
- [x] #30277
- [x] #33376
### Feature request
- [ ] #30725
### Replied with potential fix and following
- [ ] #31734 followed by @irislin1006
- [ ] #32312 followed by @irislin1006
- [x] #31818 followed by @mekkcyber
- [x] #31439 followed by @nnilayy
- [ ] #28124 followed by @muellerz and @WizKnight
- [ ] #30767 followed by @SunMarc
- [ ] #33147 followed by @SunMarc
- [x] #33400 followed by @SunMarc
- [ ] #26413 followed by @muupan, @muellerzr and @SunMarc
- [x] #28808 followed by @Ben-Schneider-code
- [x] #31357 followed by @mekkcyber
- [x] #33733 resolved by the author
- [ ] #30330 followed by @SunMarc
- [ ] #30913 followed by @mekkcyber
- [ ] #27487 followed by @SunMarc
- [ ] #33336 followed by @MekkCyber
- [ ] #25695 followed by @MekkCyber
- [ ] #31278 followed by @muellerzr
- [ ] #32427 followed by @muellerzr and @SunMarc
- [ ] #31034 followed by @muellerzr
- [ ] #30822 followed by @muellerzr
- [ ] #31867 followed by @Ben-Schneider-code and @SunMarc
| Good First Issue,trainer,Good Second Issue,DeepSpeed,Good Difficult Issue,PyTorch FSDP,HACKTOBERFEST-ACCEPTED,Accelerate | medium | Critical |
2,510,071,461 | vscode | Split right when previewing markdown files results in an empty tab | <!-- ⚠️⚠️ Do Not Delete This! bug_report_template ⚠️⚠️ -->
<!-- Please read our Rules of Conduct: https://opensource.microsoft.com/codeofconduct/ -->
<!-- 🕮 Read our guide about submitting issues: https://github.com/microsoft/vscode/wiki/Submitting-Bugs-and-Suggestions -->
<!-- 🔎 Search existing issues to avoid creating duplicates. -->
<!-- 🧪 Test using the latest Insiders build to see if your issue has already been fixed: https://code.visualstudio.com/insiders/ -->
<!-- 💡 Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. -->
<!-- 🔧 Launch with `code --disable-extensions` to check. -->
Does this issue occur when all extensions are disabled?: Yes
<!-- 🪓 If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. -->
<!-- 📣 Issues caused by an extension need to be reported directly to the extension publisher. The 'Help > Report Issue' dialog can assist with this. -->
- VS Code Version: 1.93.0
- OS Version: MacOS Sonoma 14.6.1
Steps to Reproduce:
1. Preview markdown file
2. Right click on the markdown file and click "Split Right"
3. Empty tab opened on the right (check image)
<img width="1078" alt="image" src="https://github.com/user-attachments/assets/a40e1004-c4a7-4f8c-bba0-276947a32f3d">
| bug,webview | low | Critical |
2,510,105,897 | rust | `should_panic` does not capture allocation-induced panics | When writing tests for custom allocators, I ran into the problem that an allocation-induced panic is not captured properly by should_panic. This is in my opinion a bug, as the behaviour the test shows is still very much like a panic.
Example code to trigger the issue:
```
use core::alloc::Layout;
use alloc::alloc::handle_alloc_error
#[test]
#[should_panic]
fn sample_test() {
let layout = Layout::new::<u64>();
handle_alloc_error(layout);
}
```
this uses an explicit call to handle_alloc_error, but the actual test cases I am writing create Vectors with a custom allocator that limits the amount of memory that can be allocated, which is a more realistic use case.
### Meta
<!--
If you're using the stable version of the compiler, you should also check if the
bug also exists in the beta or nightly versions.
-->
`rustc --version --verbose`:
```
rustc 1.83.0-nightly (9c01301c5 2024-09-05)
binary: rustc
commit-hash: 9c01301c52df5d2d7b6fe337707a74e011d68d6f
commit-date: 2024-09-05
host: x86_64-unknown-linux-gnu
release: 1.83.0-nightly
LLVM version: 19.1.0
```
| A-libtest,C-bug,T-libs | low | Critical |
2,510,124,364 | pytorch | Problem with conversion of torch model (htdemucs) to onnx | ### 🐛 Describe the bug
I'm trying to convert [HTDemucs](https://github.com/adefossez/demucs) to onnx with dynamo export. The plain model gives me a bunch of errors, complaining about the istft operator, so i placed both the latter and the stft outside of it (model now expects both the audio mix and its spectrogram as inputs). It then succesfully converts, but apparently there are some problems with the accuracy of the newly converted model.
> For the conversion to actually be succesful, i had to remove `traceable=True` from [the glu operator](https://github.com/microsoft/onnxscript/blob/d7a641158554d6e7954893586cacaae6cd2e835f/onnxscript/function_libs/torch_lib/ops/nn.py#L522) of onnxscript, because it was complaining about the SymbolicTensor class being not iterable.
```
W0906 11:44:51.977000 18782 torch/onnx/_internal/exporter/_core.py:1290] Output 'add_76' has a large absolute difference of 2.171368.
W0906 11:44:51.978000 18782 torch/onnx/_internal/exporter/_core.py:1297] Output 'add_76' has a large relative difference of 875822.000000.
W0906 11:44:51.978000 18782 torch/onnx/_internal/exporter/_core.py:1290] Output 'add_77' has a large absolute difference of 0.011793.
W0906 11:44:51.978000 18782 torch/onnx/_internal/exporter/_core.py:1297] Output 'add_77' has a large relative difference of 4314.738770.
```
[Here](https://github.com/gianlourbano/demucs) is the modified version of the model with the [conversion script](https://github.com/gianlourbano/demucs/blob/main/convert_to_onnx.py) used.
### Versions
PyTorch version: 2.5.0.dev20240828+cpu
Is debug build: False
CUDA used to build PyTorch: None
ROCM used to build PyTorch: N/A
OS: Ubuntu 24.04.1 LTS (x86_64)
GCC version: (Ubuntu 13.2.0-23ubuntu4) 13.2.0
Clang version: 18.1.8 (++20240731025043+3b5b5c1ec4a3-1~exp1~20240731145144.92)
CMake version: version 3.30.1
Libc version: glibc-2.39
Python version: 3.10.14 (main, May 6 2024, 19:42:50) [GCC 11.2.0] (64-bit runtime)
Python platform: Linux-6.8.0-41-generic-x86_64-with-glibc2.39
Is CUDA available: False
CUDA runtime version: No CUDA
CUDA_MODULE_LOADING set to: N/A
GPU models and configuration: No CUDA
Nvidia driver version: No CUDA
cuDNN version: No CUDA
HIP runtime version: N/A
MIOpen runtime version: N/A
Is XNNPACK available: True
CPU:
Architecture: x86_64
CPU op-mode(s): 32-bit, 64-bit
Address sizes: 48 bits physical, 48 bits virtual
Byte Order: Little Endian
CPU(s): 12
On-line CPU(s) list: 0-11
Vendor ID: AuthenticAMD
Model name: AMD Ryzen 5 4600H with Radeon Graphics
CPU family: 23
Model: 96
Thread(s) per core: 2
Core(s) per socket: 6
Socket(s): 1
Stepping: 1
Frequency boost: enabled
CPU(s) scaling MHz: 74%
CPU max MHz: 3000,0000
CPU min MHz: 1400,0000
BogoMIPS: 5988,52
Flags: fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush mmx fxsr sse sse2 ht syscall nx mmxext fxsr_opt pdpe1gb rdtscp lm constant_tsc rep_good nopl nonstop_tsc cpuid extd_apicid aperfmperf rapl pni pclmulqdq monitor ssse3 fma cx16 sse4_1 sse4_2 movbe popcnt aes xsave avx f16c rdrand lahf_lm cmp_legacy svm extapic cr8_legacy abm sse4a misalignsse 3dnowprefetch osvw ibs skinit wdt tce topoext perfctr_core perfctr_nb bpext perfctr_llc mwaitx cpb cat_l3 cdp_l3 hw_pstate ssbd mba ibrs ibpb stibp vmmcall fsgsbase bmi1 avx2 smep bmi2 cqm rdt_a rdseed adx smap clflushopt clwb sha_ni xsaveopt xsavec xgetbv1 cqm_llc cqm_occup_llc cqm_mbm_total cqm_mbm_local clzero irperf xsaveerptr rdpru wbnoinvd cppc arat npt lbrv svm_lock nrip_save tsc_scale vmcb_clean flushbyasid decodeassists pausefilter pfthreshold avic v_vmsave_vmload vgif v_spec_ctrl umip rdpid overflow_recov succor smca
Virtualization: AMD-V
L1d cache: 192 KiB (6 instances)
L1i cache: 192 KiB (6 instances)
L2 cache: 3 MiB (6 instances)
L3 cache: 8 MiB (2 instances)
NUMA node(s): 1
NUMA node0 CPU(s): 0-11
Vulnerability Gather data sampling: Not affected
Vulnerability Itlb multihit: Not affected
Vulnerability L1tf: Not affected
Vulnerability Mds: Not affected
Vulnerability Meltdown: Not affected
Vulnerability Mmio stale data: Not affected
Vulnerability Reg file data sampling: Not affected
Vulnerability Retbleed: Mitigation; untrained return thunk; SMT enabled with STIBP protection
Vulnerability Spec rstack overflow: Mitigation; Safe RET
Vulnerability Spec store bypass: Mitigation; Speculative Store Bypass disabled via prctl
Vulnerability Spectre v1: Mitigation; usercopy/swapgs barriers and __user pointer sanitization
Vulnerability Spectre v2: Mitigation; Retpolines; IBPB conditional; STIBP always-on; RSB filling; PBRSB-eIBRS Not affected; BHI Not affected
Vulnerability Srbds: Not affected
Vulnerability Tsx async abort: Not affected
Versions of relevant libraries:
[pip3] numpy==1.26.0
[pip3] onnx==1.16.2
[pip3] onnxruntime==1.19.0
[pip3] onnxscript==0.1.0.dev20240902
[pip3] torch==2.5.0.dev20240828+cpu
[pip3] torchaudio==2.5.0.dev20240828+cpu
[pip3] torchvision==0.20.0.dev20240828+cpu
[conda] torch 2.5.0.dev20240828+cpu pypi_0 pypi
[conda] torchaudio 2.5.0.dev20240828+cpu pypi_0 pypi
[conda] torchvision 0.20.0.dev20240828+cpu pypi_0 pypi
| needs reproduction,module: onnx,triaged | low | Critical |
2,510,139,233 | pytorch | dynamo fails to wrap distributions with lazy property | ### 🐛 Describe the bug
To reproduce:
```python
import torch.distributions
logits = torch.randn(10)
def make_categorical(logits):
return torch.distributions.Categorical(logits=logits).sample()
torch.compile(make_categorical, fullgraph=True)(logits)
```
Error:
```
File "/Users/vmoens/venv/rl/lib/python3.11/site-packages/torch/_dynamo/symbolic_convert.py", line 3011, in inline_call
return cls.inline_call_(parent, func, args, kwargs)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/Users/vmoens/venv/rl/lib/python3.11/site-packages/torch/_dynamo/symbolic_convert.py", line 3061, in inline_call_
raise ArgsMismatchError( # noqa: B904
torch._dynamo.exc.ArgsMismatchError: too many positional arguments.
func = '__get__' /Users/vmoens/venv/rl/lib/python3.11/site-packages/torch/distributions/utils.py:145, args = [<class 'torch.distributions.utils.lazy_property'>, <class 'torch.distributions.utils.lazy_property'>, <class 'torch.distributions.categorical.Categorical'>, <class 'type'>], kwargs = {}
```
### Versions
nightly
cc @ezyang @chauhang @penguinwu @voznesenskym @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @chenyang78 @kadeng @amjames @rec | triaged,oncall: pt2,module: dynamo | low | Critical |
2,510,146,855 | rust | The inference problem caused by `Option::filter` on function result | **no error case**:
```rust
pub fn true_pred<T>(_: T) -> bool {
true
}
pub fn foo<T, F>(ele: &T, mut f: F) -> Option<& T>
where F: FnMut(&T) -> bool,
{
[ele].into_iter()
.fold(None, |acc, _| {
acc.filter(|min| f(min))
})
//.filter(true_pred) // error!
}
```
**error case**:
```rust
pub fn true_pred<T>(_: T) -> bool {
true
}
pub fn foo<T, F>(ele: &T, mut f: F) -> Option<& T>
where F: FnMut(&T) -> bool,
{
[ele].into_iter()
.fold(None, |acc, _| {
acc.filter(|min| f(min))
})
.filter(true_pred) // error!
}
```
**cargo check output**:
```rust
error[E0308]: mismatched types
--> src/lib.rs:8:5
|
5 | pub fn foo<T, F>(ele: &T, mut f: F) -> Option<& T>
| - found this type parameter ----------- expected `Option<&T>` because of return type
...
8 | / [ele].into_iter()
9 | | .fold(None, |acc, _| {
10 | | acc.filter(|min| f(min))
11 | | })
12 | | .filter(true_pred) // error!
| |__________________________^ expected `Option<&T>`, found `Option<T>`
|
= note: expected enum `Option<&_>`
found enum `Option<_>`
help: try using `.as_ref()` to convert `Option<T>` to `Option<&T>`
|
12 | .filter(true_pred).as_ref() // error!
| +++++++++
For more information about this error, try `rustc --explain E0308`.
error: could not compile `test1` (lib) due to 1 previous error
```
**rustc version**:
```
rustc 1.82.0-nightly (1f12b9b0f 2024-08-27)
binary: rustc
commit-hash: 1f12b9b0fdbe735968ac002792a720f0ba4faca6
commit-date: 2024-08-27
host: aarch64-unknown-linux-gnu
release: 1.82.0-nightly
LLVM version: 19.1.0
```
| T-compiler,A-inference,A-result-option,C-discussion | low | Critical |
2,510,162,090 | ui | [feat]: choose your own base color | ### Feature description
When initialising shadcn-ui on a project already setup with my own styles in the tailwind config, I want that the base colour that shadcn-ui uses to be one of my existing ones, not one from the set of colours given by the repo itself.
### Affected component/components
_No response_
### Additional Context
Whenever I add a component, I have to go through and update all of the styles that exist (that's the point, but a little less work OOTB would be nice)
### Before submitting
- [X] I've made research efforts and searched the documentation
- [X] I've searched for existing issues and PRs | area: request | low | Minor |
2,510,163,293 | ollama | on ollama.com , the centrate new profile picture page , looked on andro chrome canary , out of bound | ### What is the issue?
when upload profile pic , a page to move the pic into o round place .. the canvas doesnt fit into the display , of andro chrome canary
### OS
_No response_
### GPU
_No response_
### CPU
_No response_
### Ollama version
_No response_ | bug,ollama.com | low | Minor |
2,510,165,111 | ui | [bug]: ComboBox item scroll (Mouse wheel) is not working inside Dialoge Box | ### Describe the bug
ComboBox item scroll (Mouse wheel) is not working inside Dialoge Box
https://github.com/user-attachments/assets/da1a3ce8-a543-4de5-a9b4-4eb19ac36246
### Affected component/components
Combobox, Dialog
### How to reproduce
1. Click on Filter
2. Click on Combobox
3. Scroll inside the combobox for more items, mouse scroll wheel not working.
https://github.com/user-attachments/assets/38e3781a-b5e8-4979-9c94-56d1820e9911
### Codesandbox/StackBlitz link
_No response_
### Logs
_No response_
### System Info
```bash
Chrom, Windows 11
```
### Before submitting
- [X] I've made research efforts and searched the documentation
- [X] I've searched for existing issues | bug | low | Critical |
2,510,174,047 | neovim | Lua Vimscript bridge memory leak | ### Problem
Memory that is consumed by Lua code and subsequently freed by an automatic garbage collection cycle or manually with `collectgarbage("collect")` often doesn't result in the memory used being released back to the operating system. This causes Neovim to use more memory than necessary, even after memory intensive code has finished running.
The effect of this issue is that when a plugin such as Telescope is used to search a large project multiple times (which is a normal use case), the memory usage will climb to many times what is necessary, and will remain high even after the user has finished searching and the results no longer need to be kept in memory. I have seen memory usage climb up to and exceed 1 GB because of this issue (although typically excess memory usage is around 100-500 MB).
### Steps to reproduce
1. Launch Neovim with `nvim --clean`
2. Run the following commands and monitor memory usage with a system monitor, leaving 5-10 second gaps between each execution:
`:lua local nums = {} for i = 1, 10000000 do nums[i]=i end vim.g.foo = nums`
[repeat the previous command two more times]
`:lua vim.g.foo = nil`
`:lua collectgarbage("collect")`
`:lua print(collectgarbage("count"))`
3. Memory usage should have increased to around 1.4 GB, then decreased to around 960 MB, where it remains. The output of the last command should show that only around 323 KB of memory remains in use by Lua, even though the Neovim process is still using 960 MB.
### Expected behavior
Memory usage by the Neovim process should be released or begin decreasing soon after it is no longer in use by Lua.
### Neovim version (nvim -v)
NVIM v0.11.0-dev-714+g220b8aa6f
### Vim (not Nvim) behaves the same?
N/A
### Operating system/version
Arch Linux with kernel 6.9.3
### Terminal name/version
Alacritty 0.13.2
### $TERM environment variable
alacritty
### Installation
appimage | performance,vimscript,has:repro,lua | low | Major |
2,510,210,703 | ui | [feat]: Add support for Templ Golang templating library | ### Feature description
The new CLI is amazing in adding new components to whatever framework one is using.
A new library that is getting traction with Golang is called Templ.
Templ is a Go templating engine used to render HTML or other text-based formats by dynamically injecting data into predefined templates. The Go html/template and text/template packages are the most common built-in options for templating in Go applications.
Templating engines like Templ allow developers to separate code logic from presentation, which is especially useful in web development. The template syntax in Go is simple and provides control over output formatting. Go templates support conditionals, loops, and functions for more complex rendering.
if there any chance to have support for this Golang templating library?
### Affected component/components
_No response_
### Additional Context
[Templ library](https://templ.guide/)
### Before submitting
- [X] I've made research efforts and searched the documentation
- [X] I've searched for existing issues and PRs | area: request | low | Major |
2,510,210,746 | TypeScript | Allow `.js` file generated from `.tsx` file to be runnable in browser with less configuration | ### 🔍 Search Terms
- jsx-dev-runtime.js
- jsx-runtime.js
### ✅ Viability Checklist
- [X] This wouldn't be a breaking change in existing TypeScript/JavaScript code
- [X] This wouldn't change the runtime behavior of existing JavaScript code
- [X] This could be implemented without emitting different JS based on the types of the expressions
- [X] This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, new syntax sugar for JS, etc.)
- [X] This isn't a request to add a new utility type: https://github.com/microsoft/TypeScript/wiki/No-New-Utility-Types
- [X] This feature would agree with the rest of our Design Goals: https://github.com/Microsoft/TypeScript/wiki/TypeScript-Design-Goals
### ⭐ Suggestion
The `.js` file generated from `.tsx` file should have file extension in the injected import statement.
Also, if the value of `jsxImportSource` is relative (for e.g. `./myCustomJSX` instead of `myCustomJSX`), the import statement should have correct relative path to JSX runtime files.
### 📃 Motivating Example
Suppose, a web project has following files and folders:
- `/tsconfig.json`
- `/myCustomJSX/jsx-dev-runtime.ts`
- `/Foo.tsx`
- `/subfolder/Bar.tsx`
- `/index.html`
And, `tsconfig.json` looks like:
```json
{
"compilerOptions": {
"jsx": "react-jsxdev",
"jsxImportSource": "./myCustomJSX",
}
}
```
After running `npx tsc`, all generated `.js` files (`/Foo.js`, `/subfolder/Bar.js`) have following code at the top:
```js
import { jsxDEV as _jsxDEV, Fragment as _Fragment } from "./myCustomJSX/jsx-dev-runtime";
```
There are three problems with this:
1. The `.js` extension is missing in the import statement.
2. The path of the module is not accurate for `/subfolder/Bar.js`
3. Also, `tsc` shows following error for `/subfolder/Bar.tsx`:
```
subfolder/Bar.tsx:13:3 - error TS2307: Cannot find module './myCustomJSX/jsx-dev-runtime' or its corresponding type declarations.
```
**Expected behavior**:
`/Foo.js`:
```js
import { jsxDEV as _jsxDEV, Fragment as _Fragment } from "./myCustomJSX/jsx-dev-runtime.js";
```
`/subfolder/Bar.js`:
```js
import { jsxDEV as _jsxDEV, Fragment as _Fragment } from "../myCustomJSX/jsx-dev-runtime.js";
```
### 💻 Use Cases
1. **What do you want to use this for?**
I want to use this for web project that utilizes JSX syntax and uses **only** TypeScript as build tool.
2. **What shortcomings exist with current approaches?**
The current approach requires too much extra steps when using the generated `.js` file in web project without additional build steps, especially when using relative path in `jsxImportSource`.
3. **What workarounds are you using in the meantime?**
I am providing following in `importmap` in `/index.html` file:
```html
<script type="importmap">
{
"imports": {
"./myCustomJSX/jsx-dev-runtime": "./myCustomJSX/jsx-dev-runtime.js"
"./subfolder/myCustomJSX/jsx-dev-runtime": "./myCustomJSX/jsx-dev-runtime.js"
}
}
</script>
```
However, the importmap can grow when there are `.tsx` files in many depths in file system.
If this issue is solved, there won't be any need for importmap when using relative path in `jsxImportSource`. However, for bare module path, 1 entry in importmap is still required. | Suggestion,Awaiting More Feedback | low | Critical |
2,510,263,603 | PowerToys | Slow Launch Time and Workspace Resizing Issue | ### Microsoft PowerToys version
0.84.0
### Installation method
Microsoft Store
### Running as admin
Yes
### Area(s) with issue?
Workspaces
### Steps to reproduce
1. Open Cinema 4D.
2. Observe the loading process and the time it takes for the application to fully open.
3. Once the app is open, notice that the workspace does not resize properly, skipping the expected resizing behavior.
### ✔️ Expected Behavior
the workspace should resize properly once the application is fully loaded.
### ❌ Actual Behavior
Cinema 4D takes a significant amount of time to open, and the workspace appears to skip the resizing process, leading to display issues.
### Other Software
_No response_ | Issue-Bug,Needs-Triage,Product-Workspaces | low | Major |
2,510,272,004 | flutter | Windows GPU memory leaks when changing `handle` of `FlutterDesktopGpuSurfaceDescriptor` | ### Steps to reproduce
1. git clone https://github.com/jnschulze/flutter-webview-windows.git.
2. cd example && flutter run -d windows.
3. open Windows `Task Manager` , select `Shared GPU memory`/`Dedicated GPU memory` column in details tab, filter with `webview_windows_example`.
4. Resize the flutter window
### Expected results
Shared/Dedicated GPU memory not grows.
### Actual results
Shared/Dedicated GPU memory grows. I think the reason is that the shared handle changes after resizing.
https://github.com/jnschulze/flutter-webview-windows/blob/35c92a1efbb35e185566770ee55d5911f2cf501a/windows/texture_bridge_gpu.cc#L33
https://github.com/flutter/engine/blob/b2ad94d7abdb206d41bf08521beefd51bd75b82e/shell/platform/windows/external_texture_d3d.cc#L84
### Code sample
https://github.com/jnschulze/flutter-webview-windows
</details>
### Screenshots or Video
<details open>
<summary>Screenshots / Video demonstration</summary>
https://github.com/user-attachments/assets/d0a2f081-5885-4bf9-8a21-521c25851adb
</details>
### Logs
<details open><summary>Logs</summary>
```console
[Paste your logs here]
```
</details>
### Flutter Doctor output
<details open><summary>Doctor output</summary>
```console
PS E:\github\flutter-webview-windows> flutter doctor
Doctor summary (to see all details, run flutter doctor -v):
[!] Flutter (Channel [user-branch], 3.19.5, on Microsoft Windows [Version 10.0.22631.4037], locale en-US)
! Flutter version 3.19.5 on channel [user-branch] at D:\lib\flutter
Currently on an unknown channel. Run `flutter channel` to switch to an official channel.
If that doesn't fix the issue, reinstall Flutter by following instructions at
https://flutter.dev/docs/get-started/install.
! Upstream repository unknown source is not a standard remote.
Set environment variable "FLUTTER_GIT_URL" to unknown source to dismiss this error.
[✓] Windows Version (Installed version of Windows is version 10 or higher)
[✗] Android toolchain - develop for Android devices
✗ Unable to locate Android SDK.
Install Android Studio from: https://developer.android.com/studio/index.html
On first launch it will assist you in installing the Android SDK components.
(or visit https://flutter.dev/docs/get-started/install/windows#android-setup for detailed instructions).
If the Android SDK has been installed to a custom location, please use
`flutter config --android-sdk` to update to that location.
[✓] Chrome - develop for the web
[✓] Visual Studio - develop Windows apps (Visual Studio Community 2022 17.11.2)
[!] Android Studio (not installed)
[✓] Connected device (3 available)
[!] Network resources
✗ A network error occurred while checking "https://maven.google.com/": The semaphore timeout period has expired.
✗ An HTTP error occurred while checking "https://github.com/": Connection closed before full header was received
! Doctor found issues in 4 categories.
```
</details>
| engine,platform-windows,perf: memory,has reproducible steps,P3,team-windows,triaged-windows,found in release: 3.24,found in release: 3.26 | low | Critical |
2,510,323,503 | pytorch | DISABLED test_cat_slice_cat_cuda_dynamic_shapes_cuda_wrapper (__main__.DynamicShapesCudaWrapperCudaTests) | Platforms: linux
This test was disabled because it is failing on main branch ([recent examples](https://torch-ci.com/failure?failureCaptures=%5B%22'test%2Finductor%2Ftest_cuda_cpp_wrapper.py%3A%3ADynamicShapesCudaWrapperCudaTests%3A%3Atest_cat_slice_cat_cuda_dynamic_shapes_cuda_wrapper'%22%5D)).
cc @ezyang @chauhang @penguinwu | triaged,skipped,oncall: pt2 | low | Critical |
2,510,378,082 | next.js | Setting a cookie in middleware & a server action results in duplicate Set-Cookie headers | ### Link to the code that reproduces this issue
https://github.com/nphmuller/next-duplicate-set-cookies/commit/b93779fbabcb0cdf16084f7b68443c1bc38581f8
### To Reproduce
See https://github.com/nphmuller/next-duplicate-set-cookies/commit/b93779fbabcb0cdf16084f7b68443c1bc38581f8 for easy repro
1. Create middleware:
```
import { NextResponse } from "next/server";
export default async function Middleware() {
const response = NextResponse.next();
response.cookies.set("middleware-repro", "from-middleware");
return response;
}
```
2. Create server action:
```
"use server";
import { cookies } from "next/headers";
export async function cookieReproAction() {
const cookieStore = cookies();
cookieStore.set("middleware-repro", "from-action");
cookieStore.set("action-repro", "from-action-1");
cookieStore.set("action-repro", "from-action-2");
}
```
3. Call the server action (for example in an onclick event
### Current vs. Expected behavior
Current cookie related response headers:
```
set-cookie: middleware-repro=from-middleware; Path=/
set-cookie: middleware-repro=from-action; Path=/
set-cookie: action-repro=from-action-2; Path=/
x-middleware-set-cookie: middleware-repro=from-middleware; Path=/
```
Expected behaviour:
I would expect the same behaviour as setting the same cookie multiple times in a Server Action.
This means that previous "set-cookie" values for the same cookie name would be overwritten and only the last one set is part of the response.
So I would expect only these `set-cookie` headers:
```
-- the action is called after the middleware, so only set the action
set-cookie: middleware-repro=from-action; Path=/
-- this already works as expected. `from-action-1` gets overwritten by `from-action-2`, since it's called last in the Server Action.
set-cookie: action-repro=from-action-2; Path=/
```
It's also weird that `x-middleware-set-cookie` is present in the final response that the browser receives, but I'm not sure if this is expected. I thought that these headers were used for communication between the middleware and server components or server actions. So I expected they would be stripped out in the final response. I could be totally wrong here though.
A good reason for stripping out `the x-middleware` header would be to keep the response header size small. When setting a session cookie in the middleware it would cause the session cookie to be set multiple times in the response headers. This could make the response header too large for most proxy servers, in certain cases.
### Provide environment information
```bash
Operating System:
Platform: darwin
Arch: arm64
Version: Darwin Kernel Version 23.6.0: Mon Jul 29 21:14:30 PDT 2024; root:xnu-10063.141.2~1/RELEASE_ARM64_T6000
Available memory (MB): 32768
Available CPU cores: 10
Binaries:
Node: 20.13.0
npm: 10.8.2
Yarn: N/A
pnpm: 9.0.5
Relevant Packages:
next: 14.2.8 // Latest available version is detected (14.2.8).
eslint-config-next: 14.2.8
react: 18.3.1
react-dom: 18.3.1
typescript: 5.5.4
Next.js Config:
output: N/A
```
### Which area(s) are affected? (Select all that apply)
Middleware
### Which stage(s) are affected? (Select all that apply)
next dev (local), next start (local), Vercel (Deployed), Other (Deployed)
### Additional context
I also verified this behaviour in next canary. It behaves exactly the same.
```
"next": "^15.0.0-canary.143",
"react": "^19.0.0-rc-4c58fce7-20240904",
"react-dom": "^19.0.0-rc-4c58fce7-20240904"
```
The `x-middleware-set-cookie` response header is new since Next 14.2.8 (doesn't appear in 14.2.7).
The duplicate `set-cookie` response header has been happening for a long time. Earliest version I tried is Next 13.5.1
| bug,Middleware,linear: next | medium | Major |
2,510,386,417 | flutter | Navigating back from CupertinoPageRoute/MaterialPageRoute prevents tap gestures from getting recognized | ### Steps to reproduce
1. Run following sample on Android or iOS
2. Tap on "Navigate to next page"
3. Swipe back to previous page and quickly tap on the button again
4. The first tap is not recognized
5. Only tap after few hundred ms gets recognized
### Expected results
Tap should be recognized immediately
### Actual results
https://github.com/user-attachments/assets/f5826d9c-613e-402b-abce-f0b179a893cb
### Code sample
<details open><summary>Code sample</summary>
```dart
import 'package:flutter/cupertino.dart';
import 'package:flutter/material.dart';
void main() {
runApp(const MyApp());
}
class MyApp extends StatelessWidget {
const MyApp({super.key});
@override
Widget build(BuildContext context) {
return MaterialApp(
title: 'Flutter Demo',
theme: ThemeData(
colorScheme: ColorScheme.fromSeed(seedColor: Colors.deepPurple),
useMaterial3: true,
),
home: const MyHomePage(title: 'Flutter Demo Home Page'),
);
}
}
class MyHomePage extends StatelessWidget {
const MyHomePage({super.key, required this.title});
final String title;
@override
Widget build(BuildContext context) {
return Scaffold(
appBar: AppBar(
backgroundColor: Theme.of(context).colorScheme.inversePrimary,
title: Text(title),
),
body: Center(
child: Column(
mainAxisAlignment: MainAxisAlignment.center,
children: <Widget>[
ElevatedButton(
child: const Text('Navigate to next page'),
onPressed: () {
Navigator.push(
context,
CupertinoPageRoute(
builder: (context) {
return const MyHomePage(title: 'Next page');
},
),
);
},
),
],
),
),
);
}
}
```
</details>
### Flutter Doctor output
<details open><summary>Doctor output</summary>
```console
[✓] Flutter (Channel stable, 3.22.3, on macOS 14.5 23F79 darwin-arm64, locale pl-PL)
• Flutter version 3.22.3 on channel stable at /Users/dominik/fvm/versions/stable
• Upstream repository https://github.com/flutter/flutter.git
• Framework revision b0850beeb2 (7 weeks ago), 2024-07-16 21:43:41 -0700
• Engine revision 235db911ba
• Dart version 3.4.4
• DevTools version 2.34.3
[!] Android toolchain - develop for Android devices (Android SDK version 34.0.0)
• Android SDK at /Users/dominik/Library/Android/sdk
✗ cmdline-tools component is missing
Run `path/to/sdkmanager --install "cmdline-tools;latest"`
See https://developer.android.com/studio/command-line for more details.
✗ Android license status unknown.
Run `flutter doctor --android-licenses` to accept the SDK licenses.
See https://flutter.dev/docs/get-started/install/macos#android-setup for more details.
[✓] Xcode - develop for iOS and macOS (Xcode 15.4)
• Xcode at /Applications/Xcode.app/Contents/Developer
• Build 15F31d
• CocoaPods version 1.15.2
[✓] Android Studio (version 2024.1)
• Android Studio at /Applications/Android Studio.app/Contents
• Flutter plugin can be installed from:
🔨 https://plugins.jetbrains.com/plugin/9212-flutter
• Dart plugin can be installed from:
🔨 https://plugins.jetbrains.com/plugin/6351-dart
• Java version OpenJDK Runtime Environment (build 17.0.11+0-17.0.11b1207.24-11852314)
[✓] VS Code (version 1.92.2)
• VS Code at /Applications/Visual Studio Code.app/Contents
• Flutter extension version 3.96.0
[✓] Connected device (4 available)
• iPhone SE (3rd generation) (mobile) • C81ADE82-008E-438E-A905-500CE2F8EECA • ios • com.apple.CoreSimulator.SimRuntime.iOS-17-5 (simulator)
[✓] Network resources
• All expected network resources are available.
! Doctor found issues in 1 category.
```
</details>
Edit: realized this issue occurs with MaterialPageRoute as well
| platform-ios,framework,f: routes,f: gestures,has reproducible steps,P2,team-framework,triaged-framework,found in release: 3.24,found in release: 3.25 | low | Major |
2,510,404,918 | godot | Emulate 3 Button Mouse is broken. | ### Tested versions
4.4 master
### System information
Windows 11
### Issue description
When "Emulate 3 Button Mouse" is checked, the 3D View is rotating when I hover it with the mouse.
Usually, we need to presse ALT, or SHIFT or CTRL for the 3D View to rotate/pan/zoom.
### Steps to reproduce
Open Godot, enable "Emulate 3 Button Mouse" in the Editor Settings. Move your mouse in the 3D View.
### Minimal reproduction project (MRP)
Any Project | bug,topic:editor,topic:3d | low | Critical |
2,510,426,224 | pytorch | 2.4 version give an extra output when running inference in CPU with a Huggingface model.. traced to a dynamo bug | ### 🐛 Describe the bug
When running Roberta Question Answering (and also other Huggingface models) in CPU inference mode, I get an extra output returned by dynamo, that did not happen in a previous 2.3.1 version (see yellow extra output):
This is a bug in _dynamo/symbolic_convert.py, which seems to be picking out an extra item "hidden_states_95" item, even though we know that output.hidden_states is Null:
[bug.txt](https://github.com/user-attachments/files/16908602/bug.txt)
### Versions
2.4.0, 2.4.1
cc @ezyang @gchanan @zou3519 @kadeng @msaroufim @chauhang @penguinwu @voznesenskym @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @chenyang78 @amjames @rec | triaged,module: regression,oncall: pt2,module: dynamo | low | Critical |
2,510,429,626 | kubernetes | topologySpreadConstraints not working as expected | ### What happened?
After an upgrade where the deployment restarts, we have identified that the ingress-nginx pods didn't spread across all three AWS AZ's although we have topologyspeadcontraint defined, which resulted in a failure.
While doing a NSlookup of NLB, we observed that only 2 public IP's were returned, even though NLB has 3 public IP's. The third one is supposed to be on availability zone 1b of K8S NLB, but we don't have any ingress pods running in 1b AZ.
As a fix we added more pods to ingress-nginx controller, which added new pods to 1b AZ, then we did the nslookup again and found three IP's.
Attached the topologyspeadcontraint as defined in our nginx pod deployment-
nodeSelector:
dedicated: system
restartPolicy: Always
schedulerName: default-scheduler
topologySpreadConstraints:
- labelSelector:
matchLabels:
app.kubernetes.io/name: ingress-nginx
maxSkew: 1
topologyKey: topology.kubernetes.io/zone
whenUnsatisfiable: DoNotSchedule
### What did you expect to happen?
The pods are supposed to be evenly spread across all 3 AZs
### How can we reproduce it (as minimally and precisely as possible)?
Pod deployment with topologySpreadConstraints has this issue
### Anything else we need to know?
Seems to be an issue when node Selector is defined
### Kubernetes version
EKS version v1.28.3
### Cloud provider
AWS
### OS version
<details>
```console
# On Linux:
$ cat /etc/os-release
# paste output here
$ uname -a
# paste output here
# On Windows:
C:\> wmic os get Caption, Version, BuildNumber, OSArchitecture
# paste output here
```
</details>
### Install tools
<details>
</details>
### Container runtime (CRI) and version (if applicable)
<details>
</details>
### Related plugins (CNI, CSI, ...) and versions (if applicable)
<details>
</details>
```[tasklist]
### Tasks
```
| kind/bug,sig/scheduling,kind/support,lifecycle/stale,needs-triage | medium | Critical |
2,510,438,502 | langchain | Add support for non-OpenAI models on Azure | ### Privileged issue
- [X] I am a LangChain maintainer, or was asked directly by a LangChain maintainer to create an issue here.
### Issue Content
Models like llama-3 are now hosted on azure. | Ɑ: models,04 new feature | low | Major |
2,510,463,503 | godot | Standalone expression "text.right(-50)" not caught by debugger | ### Tested versions
4.3
### System information
Godot v4.3.stable - Ubuntu 22.04.4 LTS 22.04 - X11 - GLES3 (Compatibility) - llvmpipe (LLVM 15.0.7, 256 bits) - AMD EPYC 7763 64-Core Processor (2 Threads)
### Issue description
Instead of writing
```
func add_text(msg)
text += msg + "\n"
while len(text)>10000:
text = text.right(-50)
```
I accidentally wrote
```
func add_text(msg)
text += msg + "\n"
while len(text)>10000:
text.right(-50) #no assignment
```
When ```text``` is long enough, this loops forever.
I think the debugger should have picked this up as a standalone expression.
### Steps to reproduce
Create a project with this code and run it.
```
func _ready():
var text = "ABCD"
while len(text)>2:
text.right(-1)
```
You won't get a warning or an error, and it will loop forever
### Minimal reproduction project (MRP)
See above | enhancement,discussion,topic:gdscript | low | Critical |
2,510,517,245 | PowerToys | Workspaces does not capture "LibreOffice Calc" Windows | ### Microsoft PowerToys version
0.84.0
### Installation method
PowerToys auto-update
### Running as admin
No
### Area(s) with issue?
Workspaces
### Steps to reproduce
I have 3 windows of LibreOffice Calc open on monitor 1, and 2 windows of Vivaldi on monitor 2.
### ✔️ Expected Behavior
Workspaces only saved the Vivaldi windows.
### ❌ Actual Behavior
Workspaces saved the Vivaldi windows but not the LibreOffice Calc windows. I had expected the ability to add applications to a workspace but I could not find that function.
### Other Software
_No response_ | Issue-Bug,Needs-Triage,Product-Workspaces | low | Minor |
2,510,594,614 | node | parallel.test-debugger-heap-profiler | ### Test
`test-debugger-heap-profiler`
### Platform
Linux ARMv7
### Console output
```console
12:37:33 not ok 3895 parallel/test-debugger-heap-profiler
12:37:33 ---
12:37:33 duration_ms: 360038.83700
12:37:33 severity: fail
12:37:33 exitcode: -15
12:37:33 stack: |-
12:37:33 timeout
```
### Build links
- https://ci.nodejs.org/job/node-test-binary-armv7l/13424/
### Additional information
_No response_ | arm,flaky-test | low | Critical |
2,510,600,914 | vscode | Reveal active file in file explorer and ctrl+shift+ e should work in diff editor | <!-- ⚠️⚠️ Do Not Delete This! feature_request_template ⚠️⚠️ -->
<!-- Please read our Rules of Conduct: https://opensource.microsoft.com/codeofconduct/ -->
<!-- Please search existing issues to avoid creating duplicates. -->
<!-- Describe the feature you'd like. -->
As a code reviewer and screen reader user , I
1. In git lense search and compare view , After selecting refs for comparision,
I normally view diff editor of changed file
In diff editor, "Reveal active file in file explorer" command is not working.
In diff editor ctrl+shift+e also not working
This command help to open structure and current file with keyboard shortcut quickly.
solution:
while focus on diffeditor,
If file exists in the working tree then it should open in file explorer view else it should tell file does not exists in working tree or should give audio hint for screen reader users.
| bug,diff-editor | low | Minor |
2,510,605,115 | node | parallel.test-performance-function is flaky | ### Test
`parallel.test-performance-function`
### Platform
Linux x64
### Console output
```console
---
duration_ms: 328.326
exitcode: 1
severity: fail
stack: |2-
node:internal/event_target:1090
process.nextTick(() => { throw err; });
^
RangeError [ERR_OUT_OF_RANGE]: The value of "val" is out of range. It must be >= 1 && <= 9007199254740991. Received 0
at RecordableHistogram.record (node:internal/histogram:291:5)
at processComplete (node:internal/perf/timerify:40:15)
at timerified m (node:internal/perf/timerify:87:5)
at /home/iojs/build/workspace/node-test-commit-custom-suites-freestyle/test/parallel/test-performance-function.js:103:5
at runNextTicks (node:internal/process/task_queues:65:5)
at listOnTimeout (node:internal/timers:575:9)
at process.processTimers (node:internal/timers:549:7) {
code: 'ERR_OUT_OF_RANGE'
}
Node.js v23.0.0-pre
...
```
### Build links
- https://ci.nodejs.org/job/node-test-commit-custom-suites-freestyle/38156/
### Additional information
_No response_ | flaky-test,linux | low | Critical |
2,510,616,571 | pytorch | UserWarning: Grad strides do not match bucket view strides. This may indicate grad was not created according to the gradient layout contract, or that the param's strides changed since DDP was constructed. This is not an error, but may impair performance. grad.sizes() = [1, 64, 64, 64], strides() = [1, 4096, 64, 1] bucket_view.sizes() = [1, 64, 64, 64], strides() = [262144, 4096, 64, 1] | ### 🐛 Describe the bug
class RFNO(nn.Module):
def __init__(self, out_channels=64, modes1=64, modes2=64):
super(RFNO, self).__init__()
self.out_channels = out_channels
self.modes1 = modes1 #Number of Fourier modes to multiply, at most floor(N/2) + 1
self.modes2 = modes2
self.scale = (1 / out_channels)
self.weights0 = nn.Parameter(self.scale * torch.rand(1, out_channels, 1, 1, dtype=COMPLEXTYPE))
self.weights1 = nn.Parameter(self.scale * torch.rand(1, out_channels, modes1, modes2, dtype=COMPLEXTYPE))
self.weights2 = nn.Parameter(self.scale * torch.rand(1, out_channels, modes1, modes2, dtype=COMPLEXTYPE))
def compl_mul2d(self, input, weights):
# (batch, in_channel, x,y ), (in_channel, out_channel, x,y) -> (batch, out_channel, x,y)
return torch.einsum("bixy,ioxy->boxy", input, weights)
def forward(self, x):
batchsize = x.shape[0]
print(self.weights1.stride())
x_ft = torch.fft.rfft2(x)
x_ft = x_ft * self.weights0
out_ft = torch.zeros(batchsize, self.out_channels, x.size(-2), x.size(-1)//2 + 1, dtype=COMPLEXTYPE, device=x.device)
out_ft[:, :, :self.modes1, :self.modes2] = \
self.compl_mul2d(x_ft[:, :, :self.modes1, :self.modes2], self.weights1)
out_ft[:, :, -self.modes1:, :self.modes2] = \
self.compl_mul2d(x_ft[:, :, -self.modes1:, :self.modes2], self.weights2)
x = torch.fft.irfft2(out_ft, s=(x.size(-2), x.size(-1)))
return x
When I use DDP for parallel training it gives warnings, but not for single card training. “ UserWarning: Grad strides do not match bucket view strides. This may indicate grad was not created according to the gradient layout contract, or that the param's strides changed since DDP was constructed. This is not an error, but may impair performance. grad.sizes() = [1, 64, 64, 64], strides() = [1, 4096, 64, 1] bucket_view.sizes() = [1, 64, 64, 64], strides() = [262144, 4096, 64, 1]”
When I set def __init__(self, out_channels=64, modes1=64, modes2=64) to def __init__(self, out_channels=64, modes1=32, modes2=32). "UserWarning: Grad strides do not match bucket view strides. This may indicate grad was not created according to the gradient layout contract, or that the param's strides changed since DDP was constructed. This is not an error, but may impair performance. grad.sizes() = [1, 64, 32, 32], strides() = [1, 1024, 32, 1] bucket_view.sizes() = [1, 64, 32, 32], strides() = [65536, 1024, 32, 1] "
### Versions
class RFNO(nn.Module):
def __init__(self, out_channels=64, modes1=64, modes2=64):
super(RFNO, self).__init__()
self.out_channels = out_channels
self.modes1 = modes1 #Number of Fourier modes to multiply, at most floor(N/2) + 1
self.modes2 = modes2
self.scale = (1 / out_channels)
self.weights0 = nn.Parameter(self.scale * torch.rand(1, out_channels, 1, 1, dtype=COMPLEXTYPE))
self.weights1 = nn.Parameter(self.scale * torch.rand(1, out_channels, modes1, modes2, dtype=COMPLEXTYPE))
self.weights2 = nn.Parameter(self.scale * torch.rand(1, out_channels, modes1, modes2, dtype=COMPLEXTYPE))
def compl_mul2d(self, input, weights):
# (batch, in_channel, x,y ), (in_channel, out_channel, x,y) -> (batch, out_channel, x,y)
return torch.einsum("bixy,ioxy->boxy", input, weights)
def forward(self, x):
batchsize = x.shape[0]
print(self.weights1.stride())
x_ft = torch.fft.rfft2(x)
x_ft = x_ft * self.weights0
out_ft = torch.zeros(batchsize, self.out_channels, x.size(-2), x.size(-1)//2 + 1, dtype=COMPLEXTYPE, device=x.device)
out_ft[:, :, :self.modes1, :self.modes2] = \
self.compl_mul2d(x_ft[:, :, :self.modes1, :self.modes2], self.weights1)
out_ft[:, :, -self.modes1:, :self.modes2] = \
self.compl_mul2d(x_ft[:, :, -self.modes1:, :self.modes2], self.weights2)
x = torch.fft.irfft2(out_ft, s=(x.size(-2), x.size(-1)))
return x
When I use DDP for parallel training it gives warnings, but not for single card training. “ UserWarning: Grad strides do not match bucket view strides. This may indicate grad was not created according to the gradient layout contract, or that the param's strides changed since DDP was constructed. This is not an error, but may impair performance. grad.sizes() = [1, 64, 64, 64], strides() = [1, 4096, 64, 1] bucket_view.sizes() = [1, 64, 64, 64], strides() = [262144, 4096, 64, 1]”
When I set def __init__(self, out_channels=64, modes1=64, modes2=64) to def __init__(self, out_channels=64, modes1=32, modes2=32). "UserWarning: Grad strides do not match bucket view strides. This may indicate grad was not created according to the gradient layout contract, or that the param's strides changed since DDP was constructed. This is not an error, but may impair performance. grad.sizes() = [1, 64, 32, 32], strides() = [1, 1024, 32, 1] bucket_view.sizes() = [1, 64, 32, 32], strides() = [65536, 1024, 32, 1] "
cc @XilunWu @H-Huang @awgu @kwen2501 @wanchaol @fegin @fduwjj @wz337 @wconstab @d4l3k @c-p-i-o | oncall: distributed,module: ddp | low | Critical |
2,510,629,045 | godot | TileMapLayer destroys Tiles when detached from the tree | ### Tested versions
- 4.3.stable
### System information
Godot v4.3.stable - Windows 10.0.22631 - Vulkan (Forward+) - dedicated AMD Radeon RX 6900 XT (Advanced Micro Devices, Inc.; 32.0.11029.1008) - AMD Ryzen 7 5800X 8-Core Processor (16 Threads)
### Issue description
When detaching a scene from the tree, even if the said scene isn't destroyed, its `TileMapLayer`s are freeing their tiles loaded from a `SceneCollection`.
This results in unwanted behaviors where some nodes of the scene are back to their original state and others aren't.
### Steps to reproduce
- Start Scene a.tscn
- Click on the "Click me" Button on both the godot logos
- Logo's modulate is set to red
- Click "Go to B" button, scene A is kept in memory and scene B replaces it
- Click "Go back to A"
The icon on the left, added as a Tile from a SceneCollection, is reset (and console shows it has been destroyed) while the one added as a child node kept its state, showing that the tile has been destroyed and created again when scene has been attached back to the tree.
### Minimal reproduction project (MRP)
[scene-save-test.zip](https://github.com/user-attachments/files/16909718/scene-save-test.zip)
| enhancement,discussion,documentation,topic:2d | low | Minor |
2,510,630,196 | pytorch | binary_cross_entropy_with_logits outputs NaN on -inf, which is inconsistent with documentation | ### 🐛 Describe the bug
When running the following code:
```
import torch
import numpy as np
x = torch.tensor(-np.inf)
y = torch.tensor(0.9)
res1 = torch.nn.functional.binary_cross_entropy_with_logits(x, y)
res2 = torch.nn.BCEWithLogitsLoss()(x, y)
print(res1, res2) # nan, nan
```
Based on the documentation: https://pytorch.org/docs/stable/generated/torch.nn.BCEWithLogitsLoss.html#torch.nn.BCEWithLogitsLoss.
The calculation of both torch.nn.functional.binary_cross_entropy_with_logits and BCEWithLogitsLoss should be consistent with the following equation:
```
-y(log(sigmoid(x))+(1-y)*log(1-sigmoid(x)))
```
However, the equation outputs `inf` instead of `NaN`:
```
res3 = -(y*torch.log(torch.sigmoid(x)) + (1-y)*torch.log(torch.tensor(1.)-torch.sigmoid(x)))
print(f"The equation's result: {res3}") # inf
```
After checking some code, I think this might be a numerical instability problem:
https://github.com/pytorch/pytorch/blob/ee1b6804381c57161c477caa380a840a84167676/aten/src/ATen/native/Loss.cpp#L376
The `log_sigmoid_input` will be `-inf` when `x=-inf`. This is because the exponent of the exp operator will be a large positive value. Finally, the computation will involve `0.1*(-np.inf)-(-np.inf)`, thus leading to NaN.
I noticed that TensorFlow made a special handling on large negative input (https://www.tensorflow.org/api_docs/python/tf/nn/sigmoid_cross_entropy_with_logits).
Specifically, they use the following equation `max(x, 0) - x * z + log(1 + exp(-abs(x)))`, which makes the exponent of the exp operator always negative. It would be nice if torch.nn.functional.binary_cross_entropy_with_logits and BCEWithLogitsLoss can also make such special handling
### Versions
[pip3] numpy==1.26.2
[pip3] optree==0.11.0
[pip3] torch==2.4.0
[pip3] triton==3.0.0
[conda] numpy 1.26.2 pypi_0 pypi
[conda] optree 0.11.0 pypi_0 pypi
[conda] torch 2.4.0 pypi_0 pypi
[conda] triton 3.0.0 pypi_0 pypi
cc @ezyang @gchanan @albanD @mruberry @jbschlosser @walterddr @mikaylagawarecki | module: bc-breaking,module: nn,module: loss,triaged,module: NaNs and Infs,module: edge cases | low | Critical |
2,510,634,218 | flutter | Update documentation after 2024-08 release rotation onboarding | google doc with notes from the release go/flutter-release-diary-reid
The most important aspect of this issue is moving release instructions adjacent to the conductor tool and restructuring the format into ...
Responsibility
Onboarding (one time setup and acls)
Pre release information gathering (and communication if required)
—---------------------------
Execution of a release
Post release validation
Post release communication
—--------------------------
Troubleshooting
| team-release | low | Minor |
2,510,637,586 | opencv | Default Z-Axis For SolvePnP Charuco Board Seems to be Into Board - Inconsistent Indexing of Charuco Corners to Previous Versions | ### System Information
**OpenCV Versions:**
Unexpected behavior in opencv-python==4.10.0 , expected behavior in opencv-contrib-python==4.5.5.62
****Operating System / Platform:** Ubuntu 22.04
Compiler and Compiler Version**: GCC 11.4.0
Python Version: 3.10.12
### Detailed description
I'm working on a Charuco based camera calibration. My calibration previously worked in opencv-contrib-python==4.5.5.62 , and I was working on porting it to opencv-python=4.10.0 to get around the breaking changes introduced in 4.7.
However, I noticed inconsistencies between the order of corners returned by the the charuco detector, that lead to a rotation of 180 degrees about the X axis for estimated board pose (with SolvePnp) between versions. While the earlier version's Z axis points out of the board, in the later version, it points into the board (from SolvePnp)
I noticed that the indexing of the internal corners returned by the new charuco detector (after 4.7) seems to start at the
top left corner. However, the indexing of the internal corners returned by the old charuco detector (prior to 4.7) seems to start at the bottom left corner.
In order for the Z axis to point out of the board towards the camera, which is what I'd expect according to convention, I found
that I needed to renumber the indexing of the internal corners to start at the bottom left corner for the newer version to match the behavior of the older version when input to SolvePnp. I understand that 4.7 was a breaking change, and as such can change the behavior for later versions, but I'd expect the Z axis to still point out of the board, which doesn't happen with the default behavior that I observed.
I'm wondering here if I made a mistake with the way I am choosing the inputs for SolvePNP, or if this axis was flipped intentionally to be into board between versions, or if this is unintended behavior. I also tried changing the inputs for SolvePNP (using object points instead of chessboard corners for 3d, and using aruco tag corners instead of internal chessboard corners for 2d) for the newer version, but found that this resulted in the Z axis still being into the board.
### Prior to 4.7.0
## After 4.7
### After 4.7.0 with enforcing ascending IDS from bottom left corner (Ad Hoc Bug Fix for Consistency):
Potentially Related Issues:
https://github.com/opencv/opencv_contrib/issues/2921 : axis seems to be into board here
https://github.com/opencv/opencv/issues/23152 : broken backwards compatibility
### Steps to reproduce
First, download the gist from https://gist.github.com/glvov-bdai/d3d1c9f03d3d5ca6e61af296342498ff
Then, to recreate the figures I linked above, run the following in separate terminals (close figure to get next figure)
## Prior to 4.7.0 | In one terminal, for the older version (Out of Board)
```
python3 -m venv ~/venvs/older_cv2
source ~/venvs/older_cv2/bin/activate
pip install numpy==1.26.4
pip install opencv-contrib-python==4.5.5.62
pip install matplotlib
python3 opencv_charuco_detection.py
```
## After 4.7 | In another terminal, for the newer version (Into Board)
```
python3 -m venv ~/venvs/newer_cv2
source ~/venvs/newer_cv2/bin/activate
pip install opencv-python==4.10.0.84
pip install matplotlib
python3 opencv_charuco_detection.py --legacy
```
## In another terminal, for the newer version (After 4.7.0 with enforcing ascending IDS from bottom left corner (Ad Hoc Bug Fix for Consistency) (Out of Board):
```
source ~/venvs/newer_cv2/bin/activate
python3 opencv_charuco_detection.py --legacy --enforce_ascending_ids
```
### Issue submission checklist
- [X] I report the issue, it's not a question
- [X] I checked the problem with documentation, FAQ, open issues, forum.opencv.org, Stack Overflow, etc and have not found any solution
- [X] I updated to the latest OpenCV version and the issue is still there
- [X] There is reproducer code and related data files (videos, images, onnx, etc) | bug | low | Critical |
2,510,638,136 | vscode | Come up with a proper fix or suppress warning for vscode-diagnostic-tools.debuggerScripts | The warning in launch.json distracted me and I looked into it:
https://github.com/microsoft/vscode/blob/6f1101d812e1c80e682475cdc72b142a3296c582/.vscode/launch.json#L219-L264
We should come up with a proper fix for this so we don't have a permanent warning in the codebase. | debt | low | Critical |
2,510,642,180 | node | `test-async-context-frame` is flaky | ### Test
`test-async-context-frame`
### Platform
Windows
### Console output
```console
duration_ms: 6718.227
exitcode: 1
severity: fail
stack: "\u25B6 AsyncContextFrame\n \u2714 async-hooks\\test-async-local-storage-args.js\
\ (4955.4808ms)\n \u2714 async-hooks\\test-async-local-storage-async-await.js (4400.0139ms)\n\
\ \u2714 async-hooks\\test-async-local-storage-async-functions.js (5106.203ms)\n\
\ \u2714 async-hooks\\test-async-local-storage-dgram.js (4764.8517ms)\n \u2714\
\ async-hooks\\test-async-local-storage-enable-disable.js (5294.6636ms)\n \u2714\
\ async-hooks\\test-async-local-storage-enter-with.js (4803.8479ms)\n \u2714 async-hooks\\\
test-async-local-storage-errors.js (5115.4623ms)\n \u2714 async-hooks\\test-async-local-storage-gcable.js\
\ (4954.9835ms)\n \u2714 async-hooks\\test-async-local-storage-http-agent.js (5161.0138ms)\n\
\ \u2714 async-hooks\\test-async-local-storage-http.js (4577.1697ms)\n \u2714\
\ async-hooks\\test-async-local-storage-misc-stores.js (5124.7882ms)\n \u2714 async-hooks\\\
test-async-local-storage-nested.js (5031.4255ms)\n \u2714 async-hooks\\test-async-local-storage-no-mix-contexts.js\
\ (4960.6226ms)\n \u2714 async-hooks\\test-async-local-storage-promises.js (5029.5982ms)\n\
\ \u2716 async-hooks\\test-async-local-storage-socket.js (5107.2542ms)\n AssertionError\
\ [ERR_ASSERTION]: Test async-hooks\\test-async-local-storage-socket.js failed with\
\ exit code 3221225477\n at TestContext.<anonymous> (file:///C:/workspace/node-test-binary-windows-js-suites/node/test/parallel/test-async-context-frame.mjs:58:7)\n\
\ at process.processTicksAndRejections (node:internal/process/task_queues:105:5)\n\
\ at async Test.run (node:internal/test_runner/test:888:9)\n at async\
\ Promise.all (index 14)\n at async Suite.run (node:internal/test_runner/test:1268:7)\n\
\ at async startSubtestAfterBootstrap (node:internal/test_runner/harness:280:3)\
\ {\n generatedMessage: false,\n code: 'ERR_ASSERTION',\n actual:\
\ 3221225477,\n expected: 0,\n operator: 'strictEqual'\n }\n\n \u2714\
\ async-hooks\\test-async-local-storage-thenable.js (4896.5713ms)\n \u2714 async-hooks\\\
test-async-local-storage-tlssocket.js (5602.1337ms)\n \u2714 parallel\\test-async-local-storage-bind.js\
\ (4868.4376ms)\n \u2714 parallel\\test-async-local-storage-contexts.js (4311.7402ms)\n\
\ \u2714 parallel\\test-async-local-storage-deep-stack.js (4832.0565ms)\n \u2714\
\ parallel\\test-async-local-storage-exit-does-not-leak.js (4463.4821ms)\n \u2714\
\ parallel\\test-async-local-storage-http-multiclients.js (4983.6606ms)\n \u2714\
\ parallel\\test-async-local-storage-snapshot.js (4266.4503ms)\n\u25B6 AsyncContextFrame\
\ (6170.0028ms)\n\u2139 tests 23\n\u2139 suites 1\n\u2139 pass 22\n\u2139 fail 1\n\
\u2139 cancelled 0\n\u2139 skipped 0\n\u2139 todo 0\n\u2139 duration_ms 6186.8915\n\
\n\u2716 failing tests:\n\ntest at test\\parallel\\test-async-context-frame.mjs:48:5\n\
\u2716 async-hooks\\test-async-local-storage-socket.js (5107.2542ms)\n AssertionError\
\ [ERR_ASSERTION]: Test async-hooks\\test-async-local-storage-socket.js failed with\
\ exit code 3221225477\n at TestContext.<anonymous> (file:///C:/workspace/node-test-binary-windows-js-suites/node/test/parallel/test-async-context-frame.mjs:58:7)\n\
\ at process.processTicksAndRejections (node:internal/process/task_queues:105:5)\n\
\ at async Test.run (node:internal/test_runner/test:888:9)\n at async\
\ Promise.all (index 14)\n at async Suite.run (node:internal/test_runner/test:1268:7)\n\
\ at async startSubtestAfterBootstrap (node:internal/test_runner/harness:280:3)\
\ {\n generatedMessage: false,\n code: 'ERR_ASSERTION',\n actual: 3221225477,\n\
\ expected: 0,\n operator: 'strictEqual'\n }"
...
```
### Build links
- https://ci.nodejs.org/job/node-test-binary-windows-js-suites/29947/
### Additional information
_No response_ | windows,flaky-test | medium | Critical |
2,510,642,879 | vscode | HTTP requests sent from a VS Code extension can't be aborted | An extension I maintain makes HTTP requests upon activation to establish connections to remote servers that contain virtual file systems and resolve intellisense requests. I would like to add a timeout to these initial requests so extension activation is not held up indefinitely if the requests don't resolve. I'm using `axios` to make the requests, and am setting both the `timeout` and `signal` properties as [their documentation](https://axios-http.com/docs/cancellation) suggests. I've verified that this approach works from the Node REPL, but when called from my VS Code extension the timeouts are ignored. Even with a timeout value of `1ms` the request takes up to a minute to complete. However, the response correctly reports a cancellation/aborted error instead of the 500 error returned from the server. I know that VS Code adds its own http(s) agents that do things like adding certs from the OS keychain. Could VS Code be modifying the requests in a way that removes the timeouts? For reference, here's the browser dev tools data for the request:
<img width="544" alt="Screenshot 2024-09-06 at 11 03 18 AM" src="https://github.com/user-attachments/assets/47bf090f-107f-4141-8548-a818f671bb04">
- VS Code Version: 1.93.0
- OS Version: MacOS Sonoma 14.6.1 (Apple Silicon)
| bug,network | low | Critical |
2,510,647,222 | node | `async-hooks.test-writewrap` is flaky | ### Test
`async-hooks.test-writewrap`
### Platform
Linux x64
### Console output
```console
14:06:24 not ok 3869 async-hooks/test-writewrap
14:06:24 ---
14:06:24 duration_ms: 120029.98300
14:06:24 severity: fail
14:06:24 exitcode: -15
14:06:24 stack: |-
14:06:24 timeout
14:06:24 ...
```
### Build links
- https://ci.nodejs.org/job/node-test-commit-linux-containered/45912/
### Additional information
_No response_ | async_hooks,flaky-test,linux | low | Major |
2,510,650,325 | node | `test-sqlite-statement-sync` is flaky | ### Test
`test-sqlite-statement-sync`
### Platform
Linux x64
### Console output
```console
14:03:14 not ok 3703 parallel/test-sqlite-statement-sync
14:03:14 ---
14:03:14 duration_ms: 121007.74000
14:03:14 severity: fail
14:03:14 exitcode: -15
14:03:14 stack: |-
14:03:14 timeout
14:03:14 (node:3665096) ExperimentalWarning: SQLite is an experimental feature and might change at any time
14:03:14 (Use `node --trace-warnings ...` to show where the warning was created)
14:03:14 ...
```
### Build links
- https://ci.nodejs.org/job/node-test-commit-plinux/55240/
### Additional information
_No response_ | flaky-test,linux,sqlite | low | Minor |
2,510,658,142 | rust | Cycle errors lead to confusing errors referencing rustc-dev-guide (i.e., not user-facing docs) | <!--
Thank you for filing a bug report! 🐛 Please provide a short summary of the bug,
along with any information you feel relevant to replicating the bug.
-->
I tried this code:
```rust
struct NamedType {
parent: &'static NamedType,
}
const SCHEMA: &'static NamedType = &NamedType {
parent: SCHEMA,
};
```
I expected to see this happen: Maybe "just work", but maybe give a helpful error
Instead, this happened:
```
Compiling playground v0.0.1 (/playground)
error[E0391]: cycle detected when simplifying constant for the type system `SCHEMA`
--> src/lib.rs:5:1
|
5 | const SCHEMA: &'static NamedType = &NamedType {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
note: ...which requires const-evaluating + checking `SCHEMA`...
--> src/lib.rs:6:13
|
6 | parent: SCHEMA,
| ^^^^^^
= note: ...which again requires simplifying constant for the type system `SCHEMA`, completing the cycle
= note: cycle used when running analysis passes on this crate
= note: see https://rustc-dev-guide.rust-lang.org/overview.html#queries and https://rustc-dev-guide.rust-lang.org/query.html for more information
For more information about this error, try `rustc --explain E0391`.
error: could not compile `playground` (lib) due to 1 previous error
```
### Meta
Reproduces on 1.81.0 stable and 2024-09-05 nightly.
### Bigger picture
I'm working on "Schema"s (which are kind of home-rolled reflection) for postcard, and I attempted to implement the `Schema` trait for the types used for schemas themselves.
Actual commit here: https://github.com/jamesmunns/postcard/commit/ded8c308cc506bca87fb2c20be0928a8e904c3c9
I'm at least partially convinced this can't actually work in my case (it ends up making infinitely recursive consts), but the error message was somewhat surprising (I don't know if "normal" user errors should reference the rustc-dev-guide), and maybe would expect a more direct error like "Tried to make a constant value with infinite size due to recursion".
CC @dirbaio who helped minimize this.
| A-diagnostics,T-lang,T-compiler,C-bug,D-confusing | low | Critical |
2,510,710,608 | flutter | Support new chrome headless mode from flutter driver | Chrome has a [new headless mode](https://developer.chrome.com/docs/chromium/headless), so the `--headless` flag has been superceded by `--headless=old` and `--headless=new`.
More context:
- DevTools integration tests first started failing with chromedriver 128: https://github.com/flutter/devtools/issues/8301.
- We eventually found a workaround by passing some additional flags to the flutter driver command: https://github.com/flutter/devtools/pull/8299. We had to pass the flag `--headless=old` to get our integration tests to function as they were before, and following a suggestion from https://github.com/SeleniumHQ/selenium/issues/14453 and https://github.com/sanger/sequencescape/pull/4316, we also needed to add the `--disable-search-engine-choice-screen` flag to prevent the tests from timing out.
I'm not sure what the proper solution is here from the perspective of the flutter tools, but I suspect other flutter users who have integration tests for web will hit the same problems we did with the new version of chrome and chromedriver. Ideally, we should add the necessary flags on the flutter driver side so that users do not have to go through this whole investigation to get their tests to work. | c: new feature,tool,platform-web,f: integration_test,P2,team-web,triaged-web | low | Minor |
2,510,715,890 | go | build: adopt Go 1.24 as bootstrap toolchain for Go 1.26 | This is the tracking issue for the Go 1.26 iteration of proposal #54265. | NeedsFix,early-in-cycle,release-blocker | low | Minor |
2,510,737,486 | godot | `scons` build fails on Windows with `core/os/keyboard.h: No such file or directory` | ### Tested versions
4.3 branch
### System information
Godot v4.3.stable.mono - Windows 10.0.22631 - Vulkan (Mobile) - integrated Intel(R) Iris(R) Xe Graphics (Intel Corporation; 31.0.101.5590) - 11th Gen Intel(R) Core(TM) i7-1185G7 @ 3.00GHz (8 Threads)
### Issue description
Attempting to build from the Godot source with the following command:
`scons p=windows target=editor module_mono_enabled=yes`
Fails with the following error, although the file mentioned does appear to exist:
```
[Initial build] Generating servers\rendering\renderer_rd\shaders\environment\voxel_gi_debug.glsl.gen.h ...
ERROR: In file included from platform\windows\os_windows.h:35,
from platform\windows\godot_windows.cpp:31:
platform\windows\key_mapping_windows.h:34:10: fatal error: core/os/keyboard.h: No such file or directory
34 | #include "core/os/keyboard.h"
| ^~~~~~~~~~~~~~~~~~~~
compilation terminated.
```
### Steps to reproduce
Compile source code with editor target from 4.3 branch or master.
### Minimal reproduction project (MRP)
N/A | bug,platform:windows,topic:buildsystem,needs testing | low | Critical |
2,510,761,194 | go | x/net/http2/hpack: "id (106) <= evictCount (117)" panic in headerFieldTable.idToIndex | ### Go version
go 1.23
### Output of `go env` in your module/workspace:
```shell
go env
GO111MODULE=''
GOARCH='amd64'
GOBIN=''
GOCACHE='/root/.cache/go-build'
GOENV='/root/.config/go/env'
GOEXE=''
GOEXPERIMENT=''
GOFLAGS=''
GOHOSTARCH='amd64'
GOHOSTOS='linux'
GOINSECURE='*'
GOMODCACHE='/root/go/pkg/mod'
GONOPROXY=''
GONOSUMDB=''
GOOS='linux'
GOPATH='/root/go'
GOPRIVATE=''
GOPROXY='https://proxy.golang.org,direct'
GOROOT='/usr/local/go'
GOSUMDB='sum.golang.org'
GOTMPDIR=''
GOTOOLCHAIN='auto'
GOTOOLDIR='/usr/local/go/pkg/tool/linux_amd64'
GOVCS=''
GOVERSION='go1.23.0'
GODEBUG=''
GOTELEMETRY='local'
GOTELEMETRYDIR='/root/.config/go/telemetry'
GCCGO='gccgo'
GOAMD64='v1'
AR='ar'
CC='gcc'
CXX='g++'
CGO_ENABLED='1'
GOMOD=
GOWORK=''
CGO_CFLAGS='-O2 -g'
CGO_CPPFLAGS=''
CGO_CXXFLAGS='-O2 -g'
CGO_FFLAGS='-O2 -g'
CGO_LDFLAGS='-O2 -g'
PKG_CONFIG='pkg-config'
GOGCCFLAGS='-fPIC -m64 -pthread -Wl,--no-gc-sections -fmessage-length=0 -ffile-prefix-map=/tmp/go-build2845012808=/tmp/go-build -gno-record-gcc-switches'
```
### What did you do?
warded-Proto:[https]]
2024/09/06 15:43:20 Sending request to backend
panic: id (106) <= evictCount (117)
goroutine 9201 [running]:
vendor/golang.org/x/net/http2/hpack.(*headerFieldTable).idToIndex(0xc0000bca00, 0xc00055dcb0?)
/usr/local/go/src/vendor/golang.org/x/net/http2/hpack/tables.go:118 +0xbd
vendor/golang.org/x/net/http2/hpack.(*headerFieldTable).search(0xc0000bca00, {{0x148ff02, 0x6}, {0xc000112ea0, 0xc1}, 0x0})
/usr/local/go/src/vendor/golang.org/x/net/http2/hpack/tables.go:105 +0xe5
vendor/golang.org/x/net/http2/hpack.(*Encoder).searchTable(0xc0000bca00, {{0x148ff02, 0x6}, {0xc000112ea0, 0xc1}, 0x0})
/usr/local/go/src/vendor/golang.org/x/net/http2/hpack/encode.go:97 +0x85
vendor/golang.org/x/net/http2/hpack.(*Encoder).WriteField(0xc0000bca00, {{0x148ff02, 0x6}, {0xc000112ea0, 0xc1}, 0x0})
/usr/local/go/src/vendor/golang.org/x/net/http2/hpack/encode.go:62 +0x145
net/http.(*http2ClientConn).writeHeader(0xc000956b60?, {0x148ff02?, 0x1454060?}, {0xc000112ea0?, 0xc000a63650?})
/usr/local/go/src/net/http/h2_bundle.go:9331 +0x148
net/http.(*http2ClientConn).encodeHeaders.func3({0xc000956b60?, 0xc000a63650?}, {0xc000112ea0, 0xc1})
/usr/local/go/src/net/http/h2_bundle.go:9265 +0x71
net/http.(*http2ClientConn).encodeHeaders.func1(0xc000933bb8)
/usr/local/go/src/net/http/h2_bundle.go:9226 +0x627
net/http.(*http2ClientConn).encodeHeaders(0xc0002eed80, 0xc0003a8500, 0x0, {0x0, 0x0}, 0x0)
/usr/local/go/src/net/http/h2_bundle.go:9258 +0x58c
net/http.(*http2clientStream).encodeAndWriteHeaders(0xc00072e300, 0xc0003a8500)
/usr/local/go/src/net/http/h2_bundle.go:8721 +0x2e9
net/http.(*http2clientStream).writeRequest(0xc00072e300, 0xc0003a8500, 0x0)
/usr/local/go/src/net/http/h2_bundle.go:8617 +0x535
net/http.(*http2clientStream).doRequest(0xc00072e300, 0x1856ea0?, 0xc000867068?)
/usr/local/go/src/net/http/h2_bundle.go:8551 +0x56
created by net/http.(*http2ClientConn).roundTrip in goroutine 9199
/usr/local/go/src/net/http/h2_bundle.go:8456 +0x3d8
### What did you see happen?
some crawler online crash it.
### What did you expect to see?
at least an error msg but not crash | NeedsInvestigation | low | Critical |
2,510,766,663 | pytorch | MacOS runner fails at `Complete runner step` | ### 🐛 Describe the bug
List of jobs (all of them MPS ones for some reason):
- https://github.com/pytorch/pytorch/actions/runs/10738683344/job/29783923957
- https://github.com/pytorch/pytorch/actions/runs/10739166790/job/29784739940
- https://github.com/pytorch/pytorch/actions/runs/10739832388/job/29787068694
- https://github.com/pytorch/pytorch/actions/runs/10740092184/job/29787906784
- https://github.com/pytorch/pytorch/actions/runs/10740449433/job/29789033721
- https://github.com/pytorch/pytorch/actions/runs/10740826173/job/29790964645
- https://github.com/pytorch/pytorch/actions/runs/10738291387/job/29782577472
All of them were scheduled on i-068d3556cfec79f76
### Versions
CI | triaged,module: infra | low | Critical |
2,510,767,427 | storybook | [Bug]: @storybook/angular Zone mismatch. Package has "zone.js": "^0.14.2" peer dependencies "zone.js": ">= 0.11.1 < 1.0.0" | ### Describe the bug
Looking at code > frameworks > angular there is a mismatch for zone
See below..
"zone.js": "^0.14.2"
},
"peerDependencies": {
"@angular-devkit/architect": ">=0.1500.0 < 0.1900.0",
"@angular-devkit/build-angular": ">=15.0.0 < 19.0.0",
"@angular-devkit/core": ">=15.0.0 < 19.0.0",
"@angular/cli": ">=15.0.0 < 19.0.0",
"@angular/common": ">=15.0.0 < 19.0.0",
"@angular/compiler": ">=15.0.0 < 19.0.0",
"@angular/compiler-cli": ">=15.0.0 < 19.0.0",
"@angular/core": ">=15.0.0 < 19.0.0",
"@angular/forms": ">=15.0.0 < 19.0.0",
"@angular/platform-browser": ">=15.0.0 < 19.0.0",
"@angular/platform-browser-dynamic": ">=15.0.0 < 19.0.0",
"rxjs": "^6.0.0 || ^7.4.0",
"storybook": "workspace:^",
"typescript": "^4.0.0 || ^5.0.0",
"zone.js": ">= 0.11.1 < 1.0.0"
},
### Reproduction link
https://github.com/storybookjs/storybook/blob/next/code/frameworks/angular/package.json
### Reproduction steps
Looking at code > frameworks > angular there is a mismatch for zone in package.json
ERR! zone.js@"0.14.3" from the root project
npm ERR! peer zone.js@">= 0.11.1 < 1.0.0" from @storybook/angular@8.2.9
### System
```bash
info
```
### Additional context
_No response_ | bug,needs triage | low | Critical |
2,510,800,366 | PowerToys | Keyboard manager hotkey won't open Notion Calendar | ### Microsoft PowerToys version
0.84.0
### Installation method
Microsoft Store
### Running as admin
Yes
### Area(s) with issue?
Keyboard Manager
### Steps to reproduce
1. Open PowerToys Keyboard Manager.
2. Set up a new hotkey to launch an application.
3. Use the app path: C:\Users\YourAccount\AppData\Local\Programs\cron-web\Notion Calendar.exe.
4. Save the hotkey configuration.
5. Press the hotkey to launch Notion Calendar.
### ✔️ Expected Behavior
Pressing the hotkey should launch Notion Calendar.
### ❌ Actual Behavior
Actual Behavior: Pressing the hotkey does not launch Notion Calendar.
### Other Software
_No response_ | Issue-Bug,Needs-Triage | low | Minor |
2,510,801,019 | flutter | [go_router]: pushReplacement behavior inconsistency with GoRouter and native Navigator | ## Description
We've encountered an inconsistency in the behavior of `pushReplacement` when using GoRouter compared to the native Navigator. This issue affects the interaction with bottom sheets and navigation.
## Problem
1. When using `pushReplacement` with GoRouter:
- The bottom sheet doesn't close when navigating to a new page.
- When popping back from the new page, an error is thrown: "There is nothing to pop"
2. When using `pushReplacement` with the native Navigator:
- The bottom sheet closes correctly when navigating to a new page.
- Navigation works as expected without errors.
## Environment
- Flutter: 3.24.1
- go_router: 14.2.7
- Platform: macOS 14.6.1 23G93 darwin-arm64
## Steps to Reproduce
1. Use example with native Navigator: click "push b", then click "pop to home"
2. Use example with GoRouter: repeat steps, you should get the error.
## Expected Behavior
- The bottom sheet should close when navigating to Page B.
- Popping back from Page B should return to the Home page without errors.
## Actual Behavior
With GoRouter:
- The whole route is replaced instead of closing sheet when navigating to Page B.
- Attempting to pop back from Page B throws an error: "There is nothing to pop"
With native Navigator:
- The bottom sheet closes when navigating to Page B as expected.
- Popping back from Page B works as expected.
## Code Examples
See the attached code snippets for implementations using both GoRouter and native Navigator.
<details>
<summary>Example with native Navigator</summary>
```dart
import 'package:flutter/material.dart';
void main() {
runApp(const MainApp());
}
class MainApp extends StatelessWidget {
const MainApp({super.key});
@override
Widget build(BuildContext context) {
return MaterialApp(
initialRoute: '/',
routes: {
'/': (context) => const Home(),
'/B': (context) => const PageB(),
},
);
}
}
class Home extends StatelessWidget {
const Home({super.key});
@override
Widget build(BuildContext context) {
return Scaffold(
appBar: AppBar(title: const Text('Home')),
body: Center(
child: Column(
mainAxisAlignment: MainAxisAlignment.center,
children: [
TextButton(
onPressed: () {
showModalBottomSheet(
context: context,
builder: (BuildContext context) {
return const BottomSheetContent();
},
);
},
child: const Text('Show Bottom Sheet'),
),
],
),
),
);
}
}
class BottomSheetContent extends StatelessWidget {
const BottomSheetContent({super.key});
@override
Widget build(BuildContext context) {
return Container(
padding: const EdgeInsets.all(16),
child: Column(
mainAxisSize: MainAxisSize.min,
children: [
const Text('This is the bottom sheet content'),
const SizedBox(height: 20),
TextButton(
onPressed: () {
Navigator.of(context).pushReplacementNamed('/B');
},
child: const Text('Push to Page B'),
),
],
),
);
}
}
class PageB extends StatelessWidget {
const PageB({super.key});
@override
Widget build(BuildContext context) {
return Scaffold(
appBar: AppBar(title: const Text('Page B')),
body: Center(
child: Column(
mainAxisAlignment: MainAxisAlignment.center,
children: [
TextButton(
onPressed: () {
Navigator.of(context).pop();
},
child: const Text('Pop back to home'),
),
],
),
),
);
}
}
```
</details>
<details>
<summary>Example with GoRouter</summary>
```dart
import 'package:flutter/material.dart';
import 'package:go_router/go_router.dart';
final router = GoRouter(
routes: [
GoRoute(
name: 'Home',
path: '/',
builder: (_, __) => const Home(),
),
GoRoute(
name: 'B',
path: '/B',
builder: (_, __) => const PageB(),
),
],
);
void main() {
runApp(const MainApp());
}
class MainApp extends StatelessWidget {
const MainApp({super.key});
@override
Widget build(BuildContext context) {
return MaterialApp.router(
routerConfig: router,
);
}
}
class Home extends StatelessWidget {
const Home({super.key});
@override
Widget build(BuildContext context) {
return Scaffold(
appBar: AppBar(title: const Text('Home')),
body: Center(
child: Column(
mainAxisAlignment: MainAxisAlignment.center,
children: [
TextButton(
onPressed: () {
showModalBottomSheet(
context: context,
builder: (BuildContext context) {
return const BottomSheetContent();
},
);
},
child: const Text('Show Bottom Sheet'),
),
],
),
),
);
}
}
class BottomSheetContent extends StatelessWidget {
const BottomSheetContent({super.key});
@override
Widget build(BuildContext context) {
return Container(
padding: const EdgeInsets.all(16),
child: Column(
mainAxisSize: MainAxisSize.min,
children: [
const Text('This is the bottom sheet content'),
const SizedBox(height: 20),
TextButton(
onPressed: () {
router.pushReplacementNamed('B');
},
child: const Text('Push to Page B'),
),
],
),
);
}
}
class PageB extends StatelessWidget {
const PageB({super.key});
@override
Widget build(BuildContext context) {
return Scaffold(
appBar: AppBar(title: const Text('Page B')),
body: Center(
child: Column(
mainAxisAlignment: MainAxisAlignment.center,
children: [
TextButton(
onPressed: () {
router.pop();
},
child: const Text('Pop back to home'),
),
],
),
),
);
}
}
```
</details>
## Additional Notes
This inconsistency creates challenges in maintaining a consistent navigation experience across our app, especially when migrating from native Navigator to GoRouter.
## Possible Solutions
1. Investigate if there's a way to make GoRouter's `pushReplacement` behavior consistent with the native Navigator.
2. Consider adding a method to GoRouter that combines closing the bottom sheet and navigating to a new page.
3. Explore if this is an intended behavior difference and if so, update the documentation to clarify this.
### Flutter Doctor output
<details open><summary>Doctor output</summary>
```console
Doctor summary (to see all details, run flutter doctor -v):
[✓] Flutter (Channel stable, 3.24.1, on macOS 14.6.1 23G93 darwin-arm64, locale en-US)
[✓] Android toolchain - develop for Android devices (Android SDK version 33.0.0)
[✓] Xcode - develop for iOS and macOS (Xcode 15.4)
[✓] Chrome - develop for the web
[✓] Android Studio (version 2022.3)
[✓] VS Code (version 1.92.2)
[✓] Connected device (5 available)
[✓] Network resources
• No issues found!
```
</details>
| package,has reproducible steps,P3,p: go_router,team-go_router,triaged-go_router,found in release: 3.24,found in release: 3.25 | low | Critical |
2,510,827,897 | excalidraw | Arrow does not update both sides when moving connected object | When an arrow connects 2 objects (A, B), and one of the two is moved, only the point connected directly to the moving object is updated. The other point remains fixed until the other object itself is moved.
1. Arrow points from A to B:
2. A is moved and only the arrow's starting point updates:
3. Only once B itself moves (even just by 1 pixel), the arrow's point connected to B updates immediately and snaps back into place:
I remember that both sides of the arrow were consistently updated not long ago. | bug,good first issue | low | Major |
2,510,878,872 | flutter | `flutter run` iOS error "undefined symbols" does not output full error |
_Originally posted by @alexeyinkin in https://github.com/flutter/flutter/issues/154663#issuecomment-2333724855_
1. Create a project with `flutter create temp2`.
2. Add `firebase_analytics: 11.3.0` to `pubspec.yaml` (note no `^` to pin this specific broken version).
3. Replace in files `IPHONEOS_DEPLOYMENT_TARGET = 12.0` with `IPHONEOS_DEPLOYMENT_TARGET = 13.0`.
4. Open Runner.xcworkspace in Xcode and set a unique bundle identifier.
5. Run `flutter devices` to learn the ID of your iPhone.
6. Run `flutter run -d your_device_id`
This gave me an error I haven't seen before:
```
Launching lib/main.dart on Alexey Inkin's iPhone in debug mode...
Automatically signing iOS for device deployment using specified development team
in Xcode project: DNLKN6QZ24
Running pod install... 3,3s
Running Xcode build...
Xcode build done. 37,1s
Failed to build iOS app
Could not build the precompiled application for the device.
Error (Xcode): Provisioning profile "iOS Team Provisioning Profile:
com.alexeyinkintemp2" doesn't include the currently selected device "Alexey’s
MacBook Pro" (identifier XXXXXXXX-XXXXXXXXXXXXXXXX).
/Users/ai/temp/temp2/ios/Runner.xcodeproj
It appears that there was a problem signing your application prior to
installation on the device.
Verify that the Bundle Identifier in your project is your signing id in Xcode
open ios/Runner.xcworkspace
Also try selecting 'Product > Build' to fix the problem.
Error launching application on Alexey Inkin's iPhone.
```
I followed the advice to build with Xcode first. It gave me this error (the symbols are visible if clicking the hamburger icon):
<img width="958" alt="Captura de pantalla 2024-09-06 a las 14 05 09" src="https://github.com/user-attachments/assets/27f24196-e7ef-47a3-9c14-b3921925802b">
After that failure, I was able to reproduce the missing symbols message with re-running `flutter run ...`:
```
Launching lib/main.dart on Alexey Inkin's iPhone in debug mode...
Automatically signing iOS for device deployment using specified development team
in Xcode project: DNLKN6QZ24
Running Xcode build...
└─Compiling, linking and signing... 1.325ms
Xcode build done. 10,0s
Failed to build iOS app
Could not build the precompiled application for the device.
Error (Xcode): Undefined symbols:
Error (Xcode): Linker command failed with exit code 1 (use -v to see invocation)
Error launching application on Alexey Inkin's iPhone.
```
<details><summary>flutter doctor -v</summary>
<p>
```
[✓] Flutter (Channel stable, 3.24.2, on macOS 13.6 22G120 darwin-arm64, locale
es-GE)
• Flutter version 3.24.2 on channel stable at /Users/ai/bin/flutter
• Upstream repository https://github.com/flutter/flutter.git
• Framework revision 4cf269e36d (3 days ago), 2024-09-03 14:30:00 -0700
• Engine revision a6bd3f1de1
• Dart version 3.5.2
• DevTools version 2.37.2
[!] Android toolchain - develop for Android devices (Android SDK version 34.0.0)
• Android SDK at /Users/ai/Library/Android/sdk
✗ cmdline-tools component is missing
Run `path/to/sdkmanager --install "cmdline-tools;latest"`
See https://developer.android.com/studio/command-line for more details.
✗ Android license status unknown.
Run `flutter doctor --android-licenses` to accept the SDK licenses.
See https://flutter.dev/to/macos-android-setup for more details.
[✓] Xcode - develop for iOS and macOS (Xcode 15.0)
• Xcode at /Applications/Xcode.app/Contents/Developer
• Build 15A240d
• CocoaPods version 1.15.2
[✓] Chrome - develop for the web
• Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome
[✓] Android Studio (version 2024.1)
• Android Studio at /Applications/Android Studio.app/Contents
• Flutter plugin can be installed from:
🔨 https://plugins.jetbrains.com/plugin/9212-flutter
• Dart plugin can be installed from:
🔨 https://plugins.jetbrains.com/plugin/6351-dart
• Java version OpenJDK Runtime Environment (build
17.0.10+0-17.0.10b1087.21-11609105)
[✓] IntelliJ IDEA Ultimate Edition (version 2023.3.3)
• IntelliJ at /Applications/IntelliJ IDEA.app
• Flutter plugin can be installed from:
🔨 https://plugins.jetbrains.com/plugin/9212-flutter
• Dart plugin can be installed from:
🔨 https://plugins.jetbrains.com/plugin/6351-dart
[✓] VS Code (version 1.90.0)
• VS Code at /Users/ai/bin/Visual Studio Code.app/Contents
• Flutter extension version 3.90.0
[✓] Connected device (4 available)
• Alexey Inkin's iPhone (mobile) • 0dec698e7e1f6bfbe7bdd7e1b311ca5b2fd3199c
• ios • iOS 15.8.3 19H386
• macOS (desktop) • macos
• darwin-arm64 • macOS 13.6 22G120 darwin-arm64
• Mac Designed for iPad (desktop) • mac-designed-for-ipad
• darwin • macOS 13.6 22G120 darwin-arm64
• Chrome (web) • chrome
• web-javascript • Google Chrome 128.0.6613.120
[✓] Network resources
• All expected network resources are available.
! Doctor found issues in 1 category.
```
</p>
</details>
Xcode Version 15.0 (15A240d)
| platform-ios,tool,t: xcode,a: error message,P2,needs repro info,team-ios,triaged-ios | low | Critical |
2,510,899,014 | go | x/sys/windows/svc: unrecognized failures | ```
#!watchflakes
default <- pkg == "golang.org/x/sys/windows/svc" && test == ""
```
Issue created automatically to collect these failures.
Example ([log](https://ci.chromium.org/b/8737546284343509841)):
FAIL golang.org/x/sys/windows/svc [build failed]
— [watchflakes](https://go.dev/wiki/Watchflakes)
| NeedsInvestigation | low | Critical |
2,510,899,042 | go | runtime:cpu4: TestUserArena failures | ```
#!watchflakes
default <- pkg == "runtime:cpu4" && test == "TestUserArena"
```
Issue created automatically to collect these failures.
Example ([log](https://ci.chromium.org/b/8737529223231475393)):
=== RUN TestUserArena
arena_test.go:146: expected zero waiting arena chunks, found 2
--- FAIL: TestUserArena (0.32s)
— [watchflakes](https://go.dev/wiki/Watchflakes)
| NeedsInvestigation,compiler/runtime | low | Critical |
2,510,933,914 | go | go/printer: produces a invalid source, for a successfully parsed AST | Consider:
```go
type _[a (b + 3),] struct{}
```
This is parsed successfully by `go/parser` and it gets formatted into:
```go
type _[a b + 3] struct{}
```
This is not valid go syntax. Not sure how this should be handled, should `type _[a (b + 3),] struct{}` cause a parser error?
For example, the source below causes a parser error (`expected ')', found '+'`)
```go
type _[a ~int, b (a+3)]struct{}
```
CC @griesemer | NeedsInvestigation | low | Critical |
2,510,934,993 | PowerToys | Make Window Minimise/Maximise/Close Controls Visible | ### Description of the new feature / enhancement
Forces the window controls to be visible so that the cursor can be directed to the target, rather than having to target the general area and then hunt with the cursor until it reveals the desired target.
More generally force other window attributes such as coloured border so that white windows on white backgrounds are identifiable.
### Scenario when this would be used?
A great application of this would be to PowerTools, whose window controls are invisible when it is in the foreground (and faintly visible but inaccessible when it is not the foreground application
### Supporting information
See this screen grab of the upper right corner of PowerTools. See the missing window controls (Win-10, 64 bit, all updates applied)
| Idea-New PowerToy | low | Major |
2,510,938,881 | rust | ThreadSanitizer false positive due to missing interceptor for fcntl(fd, F_DUPFD_CLOEXEC, ..) | While ThreadSanitizer models synchronization implied by IO operations, it currently doesn't have interceptor for `fcntl(fd, F_DUPFD_CLOEXEC, ..)` and as a result operations on a duplicated file descriptor don't introduce synchronization. For example, the following generates a false positive report:
```rust
#![feature(sync_unsafe_cell)]
#![feature(anonymous_pipe)]
use std::cell::*;
use std::io::*;
use std::sync::*;
fn main() {
let c = Arc::new(SyncUnsafeCell::new(0));
let (mut a, mut b) = std::pipe::pipe().unwrap();
// Duplicate file descriptor. Implemented in terms of fcntl(fd, F_DUPFD_CLOEXEC, ...).
// Comment out the following line to hide the false positive.
let mut b = b.try_clone().unwrap();
let t = std::thread::spawn({
let c = c.clone();
move || {
unsafe { *c.get() = 1 };
b.write_all(b".").unwrap();
}
});
let mut buf = [0];
a.read_exact(&mut buf).unwrap();
println!("{}", unsafe { *c.get() });
t.join().unwrap();
}
```
This shortcoming makes ThreadSanitizer incompatible with Tokio.
| A-LLVM,A-sanitizers,C-bug,T-libs | low | Minor |
2,510,967,589 | PowerToys | FancyZones Fail to Activate with MotiveWave | ### Microsoft PowerToys version
0.83.0
### Installation method
GitHub
### Running as admin
Yes
### Area(s) with issue?
FancyZones
### Steps to reproduce
Download Motivewave app, run it. (https://www.motivewave.com)
Try to activate zones.
### ✔️ Expected Behavior
zone selection to activate
### ❌ Actual Behavior
zone selection does not activate
### Other Software
Motivewave 6.9.6
https://www.motivewave.com/ | Issue-Bug,FancyZones-Dragging&UI,Product-FancyZones,Needs-Triage | low | Minor |
2,510,988,584 | godot | Audio stutter/artifacts when lagging or overworking CPU | ### Tested versions
Reproducible in 4.1.1 and later versions
### System information
Godot v4.1.1.stable - Windows 10.0.19045 - Vulkan (Forward+) - dedicated NVIDIA GeForce GTX 950M (NVIDIA; 32.0.15.6094) - Intel(R) Core(TM) i7-6700HQ CPU @ 2.60GHz (8 Threads)
### Issue description
This is a major audio performance issue and I can't find any bug reports related to this so my guess is that it's specific to certain (possibly old) hardware.
Whenever the CPU is overworked, the audio lags significantly. This usually happens every time an expensive task outside the engine is being worked on but if the game itself is computationally expensive then it can also lead to it. In the following preview I'm playing the audio and then switching to YouTube using Google Chrome. While on the website, I jump back and forth on the video to cause lag and showcase how the audio from within Godot is affected. Recording is focused on Godot's window so any activity done on the browser is not captured. It should be mentioned that such behavior has not been detected before on this hardware and Godot is the only application that seems to cause it.
I managed to replicate the issue on 4.3 stable too but my recording is from 4.1.1.
https://github.com/user-attachments/assets/0feb7f6c-e163-42e3-b015-5bfd6bdc5505
### Steps to reproduce
Any scene using an AudioStreamPlayer will cause this issue. Simply start playing the audio (either through the editor or through running the project) and start any process that will possibly lead to lag.
### Minimal reproduction project (MRP)
[MRP.zip](https://github.com/user-attachments/files/16911775/MRP.zip) | platform:windows,needs testing,topic:audio | low | Critical |
2,510,999,382 | flutter | Add a `Container` equivalent that inherits from a theme | ### Use case
I've found Flutter's built-ins (including Material) to be VERY good if you're just trying to get your app built and are not very sensitive to it's specific appearance (ie you don't mind if everything looks like Material). I've found it to be much harder if you're trying to build an app that matches mocks/design guidelines set by a design team.
Consider the following scenario (a real life one I am experiencing at this moment).
I have been tasked with building a Flutter app to match a Figma mock designed according to a proprietary (but very simple) design system:
1. Foreground content are contained in "boxes" (similar to Material's `Card`)
2. Boxes have a `brand_color_a` -> `brand_color_b` vertical gradient fill.
3. Boxes have a `brand_color_c` stroke with a width of `some_int`
4. Boxes have a `some_int` border radius
5. Boxes have a `some_drop_shadow` shadow
6. Boxes pad their child content by `some_edge_insets`
There is no easy way for me to do this with Flutter's built ins today. Lets look at the options:
`Container`
\+ flexible enough to match the design guidelines
\- doesn't inherit from a theme so I'd have to pass the style arguments in everywhere I make a box
`DecoratedBox`
\- same as above, but not as flexible
`Card`
\+ themed
\- isn't flexible enough to add custom drop shadows, gradients, etc
`Mix` (an external [package](url))
\+ flexible
\+ themed
\- not built in
\- weird syntax designed to mimic CSS and thus very non-idiomatic in Flutter
Create my own custom `Box` widget and `BoxTheme` inherited widget
\+ flexible
\+ themed
\- tedious
### Proposal
Create:
1. A `ThemedContainer` widget (name not that important, could be `StyledContainer`, `Box`, etc) with all the same arguments as `Container`
2. A `ContainerTheme` inherited widget and a `ContainerThemeData` data class where the theme data contains all the same styling arguments as `Container` (padding, margin, decoration, color, etc)
3. Add `ContainerThemeData containerTheme` to the core `ThemeData` class
Usage would look something like this:
```dart
// main.dart
return MaterialApp(
theme: ThemeData(
containerTheme: ContainerThemeData(
padding: EdgeInsets.all(someInt),
decoration: BoxDecoration(
gradient: LinearGradient(colors: [brandColorA, brandColorB]),
border: Border.all(width: someWidth, color: brandColorC),
borderRadius: BorderRadius.circular(someInt),
boxShadow: [someBoxShadow],
),
),
),
home: MyApp(),
);
// my_feature.dart
return Column(
children: [
// Acts like a container but the padding, decoration, etc are all set according to the container
// theme defined in main.
ThemedContainer(child: SomeWidgetA()),
// All theme values are inherited except padding which is overridden.
ThemedContainer(child: SomeWidgetB(), padding: EdgeInsets.only(top: 25)),
],
);
```
Open questions:
What happens if the overridden values conflict with the theme values (eg color is overridden to pink, but the theme sets a box decoration and it is not valid to set both `decoration` and `color`)?
I see three okay-but-not-great options here:
A. Throw an assertion error
This is in-line with Container's behavior and fails loudly which is good, but can create a huge mess of confusing errors if you modify theme in a way that introduces conflicts
B. Ignore the entire conflicting set of attributes in the theme and apply the overridden attributes
This silently fails rather than loudly-for example when overriding color one would not expect shadows, etc to also be overridden
C. Remove the potentially conflicting values from `ThemedContainer` (eg the top level `color`)
The conflicting scenario now just isn't possible, but the class is now a little less convenient to use
I prefer A or C.
What happens when `decoration` is set at the widget and theme level and/or at different `ContainerTheme` widgets that have inherit set to true?
We have a pretty similar conflict potential as above. I'd suggest we attempt to merge each nested decoration and throw if there are conflicts. That feels like the most user-expected behavior, but has potential for confusing assertion errors, especially when editing the top level theme.
Should this even got in `MaterialApp`/`Theme`? It's explicitly NOT Material (`Card` is the material solution for this).
`MaterialApp` is in an awkward spot. It's ostensibly tied to Material, but over time it has become far more flexible than Material as developers demand more flexibility out of it. Ideally, Material and Flutter wouldn't have been so deeply intertwined in the first place and Flutter would offer it's own fully-fledged flexible theming system outside of Material. Maybe that ship hasn't sailed yet? You could put this in `WidgetsApp` in it's own theme and then have `MaterialApp` include a top level `containerTheme` argument that just plumbs to `WidgetsApp`, but I'm not sure the added misdirection actually gives us much here-do we want theoretical elegance or practical elegance?
All this said, it wouldn't be a big deal also to just not include the container theme in either place and make devs explicitly include a container theme widget in the widget tree. | c: new feature,P3,team-design,triaged-design,f: theming | low | Critical |
2,511,003,187 | pytorch | DISABLED test_inplace_custom_op_two_mutated_inputs (__main__.InplacingTests) | Platforms: linux, rocm
This test was disabled because it is failing in CI. See [recent examples](https://hud.pytorch.org/flakytest?name=test_inplace_custom_op_two_mutated_inputs&suite=InplacingTests&limit=100) and the most recent trunk [workflow logs](https://github.com/pytorch/pytorch/runs/29786372983).
Over the past 3 hours, it has been determined flaky in 3 workflow(s) with 3 failures and 3 successes.
**Debugging instructions (after clicking on the recent samples link):**
DO NOT ASSUME THINGS ARE OKAY IF THE CI IS GREEN. We now shield flaky tests from developers so CI will thus be green but it will be harder to parse the logs.
To find relevant log snippets:
1. Click on the workflow logs linked above
2. Click on the Test step of the job so that it is expanded. Otherwise, the grepping will not work.
3. Grep for `test_inplace_custom_op_two_mutated_inputs`
4. There should be several instances run (as flaky tests are rerun in CI) from which you can study the logs.
<details><summary>Sample error message</summary>
```
Traceback (most recent call last):
File "/var/lib/jenkins/workspace/test/inductor/test_perf.py", line 1048, in test_inplace_custom_op_two_mutated_inputs
self.assertExpectedInline(count_numel(f), """39""")
File "/opt/conda/envs/py_3.10/lib/python3.10/site-packages/torch/testing/_internal/common_utils.py", line 2925, in assertExpectedInline
return super().assertExpectedInline(actual if isinstance(actual, str) else str(actual), expect, skip + 1)
File "/opt/conda/envs/py_3.10/lib/python3.10/site-packages/expecttest/__init__.py", line 351, in assertExpectedInline
assert_expected_inline(
File "/opt/conda/envs/py_3.10/lib/python3.10/site-packages/expecttest/__init__.py", line 316, in assert_expected_inline
assert_eq(expect, actual, msg=help_text)
File "/opt/conda/envs/py_3.10/lib/python3.10/site-packages/expecttest/__init__.py", line 388, in assertMultiLineEqualMaybeCppStack
self.assertMultiLineEqual(expect, actual, *args, **kwargs)
File "/opt/conda/envs/py_3.10/lib/python3.10/unittest/case.py", line 1226, in assertMultiLineEqual
self.fail(self._formatMessage(msg, standardMsg))
File "/opt/conda/envs/py_3.10/lib/python3.10/unittest/case.py", line 675, in fail
raise self.failureException(msg)
AssertionError: '39' != '0'
- 39
+ 0
: To accept the new output, re-run test with envvar EXPECTTEST_ACCEPT=1 (we recommend staging/committing your changes before doing this)
To execute this test, run the following from the base repo dir:
python test/inductor/test_perf.py InplacingTests.test_inplace_custom_op_two_mutated_inputs
This message can be suppressed by setting PYTORCH_PRINT_REPRO_ON_FAILURE=0
```
</details>
Test file path: `inductor/test_perf.py`
cc @clee2000 @ezyang @chauhang @penguinwu @voznesenskym @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @ipiszy @yf225 @chenyang78 @kadeng @muchulee8 @ColinPeppler @amjames @desertfire | triaged,module: flaky-tests,skipped,oncall: pt2,module: inductor | low | Critical |
2,511,005,229 | godot | Reparenting RigidBody2D with physics interpolation enabled causes ghosting | ### Tested versions
- Reproducible in 4.3.stable
### System information
Godot v4.3.stable - Windows 10.0.22631 - GLES3 (Compatibility) - NVIDIA GeForce RTX 3080 Ti (NVIDIA; 31.0.15.5161) - AMD Ryzen 9 5900X 12-Core Processor (24 Threads)
### Issue description
When reparenting a node, and keeping it's _global_ position the same, the physics interpolation will cause a ghosting effect:
https://github.com/user-attachments/assets/ec97e25e-d4f6-474c-b2bc-2084ef747270
Here you can see when the parent node changes, there is a noticable ghosting - note that I have physics ticks per secondturned way down to 10 here to emphasise the issue.
I'm not sure if this is intentional or not - it can be addressed with `reset_physics_interpolation` (although that adds a bit of a stutter, might be due to very low physics tick rate) but I thought I'd report it here as it could be seen as unexpected as the body is technically in the same position, but with a different parent / local position.
[Documentation of `reset_physics_interpolation` states](https://docs.godotengine.org/en/stable/classes/class_node.html#class-node-method-reset-physics-interpolation):
> When physics interpolation is active, moving a node to a radically different transform (such as placement within a level) can result in a visible glitch as the object is rendered moving from the old to new position over the physics tick.
I'm not sure I'd count the same global position as a "radically different transform" - I'd understand if the local transform changing radically is the cause of this flicker, I just think it should be explicitly stated.
### Steps to reproduce
- Enable physics interpolation
- Create a RigidBody2D and some kind of visual to track it
- Reparent the RigidBody2D while the game is running, keeping it's global position the same, such as:
```gdscript
func swap_parent(new_parent : Node2D):
var pos := body.global_position
body.get_parent().remove_child(body)
new_parent.add_child(body)
body.global_position = pos
```
- Body will visibly ghost.
### Minimal reproduction project (MRP)
4.3 project as per video:
[interpolation-reparent.zip](https://github.com/user-attachments/files/16911816/interpolation-reparent.zip)
| bug,confirmed,topic:physics | low | Minor |
2,511,005,559 | go | x/tools/gopls: decide on a long-term testing strategy for integration with older Go commands (and GOPACKAGESDRIVERs?) | As described in #65917, it has been a multi-year journey to finally be able to ensure that gopls is only (and need only be) built with the latest version of Go.
With that achieved, I think the following experience will still be common for our users:
- The user runs `go install golang.org/x/tools/gopls@latest` with go 1.21.5.
- The go command performs a toolchain switch to 1.23.1, and installs gopls.
- gopls starts, and finds go 1.21.5 in its PATH.
This means that while gopls is build with 1.23.1, it will still frequently need<sup>1</sup> to integrate with `go list` for older go versions such as 1.21.5. For example, https://telemetry.go.dev still shows 62% of gopls users on 1.22 or older, and 16% on 1.21 or older.
Right now, we continue to have test coverage for this integration, by virtue of our 1.21 and 1.22 TryBots, because they set `GOTOOLCHAIN=auto`, and because the gopls integration tests run on temporary directories outside of gopls' own 1.23.1 module. Therefore, the tests will be built with 1.23.1, but still integrate with the ambient go version.
However, in https://go.dev/cl/605000 the question came up about whether we should continue to maintain "legacy" go version builders for gopls -- at this point Go 1.21 is no longer a supported Go version, and so gopls' [support](https://github.com/golang/tools/tree/master/gopls#support-policy) of integrating with the last three Go versions (recently narrowed from 4) is inconsistent with that policy.
IMO, testing that gopls integrates with Go 1.21 is not quite the same as supporting 1.21. After all, we have at times considered running tests against other go/packages drivers, such as for Bazel, and doing so would of course not be the same as supporting Bazel itself. Put differently: at this point Go 1.21 is not going to change, so if an integration test starts failing it will be due to a change in gopls. We may want to avoid making a change in gopls that breaks users integrating with Go 1.21.
Therefore, we have at least a few options:
1. Stop supporting integration with older Go versions, and take a hard stance that users should upgrade to a supported version of Go, perhaps by popping up a message warning users of the lack of support.
2. Stop supporting integration with older Go versions, but remain silent when users try to use gopls in this way.
3. Ask the release team to continue maintaining support for legacy TryBots.
4. Something else (see below...)
Regarding (1), I think this seems too severe. (2) would be very similar to our approach with other drivers such as Bazel, yet we *have* inadvertently caused problems for Bazel users in the past, and I think we can do better. (3) seems like a non-starter, since it burdens the rest of the team.
**Here is a tentative proposal for "something else" (4):**
Using our [existing mechanisms](https://cs.opensource.google/go/x/tools/+/master:gopls/internal/test/integration/misc/shared_test.go;l=30;drc=594cdabebbd503e8d20eeb03faf99d3c1cabef6e) for running tests in various environments, we can "opt in" (or opt out) certain tests to run with older Go commands, on the longtest builder. In legacy mode, these tests would configure the Go command to run with GOTOOLCHAIN=<legacy go version>.
Then we will opt in integration tests that exercise "basic" functionality of gopls: loading a workspace, processing metadata-affecting changes, and basic features like diagnostics, navigation, and completion. Since longtest builders do not run as a presubmit, failures of these tests with older Go versions will not block changes to gopls. If tests start failing, we can decide whether to revert the gopls change, or opt-out the test.
In this way, we can at least detect when gopls may break users with older Go versions, and be deliberate about when this is acceptable.
CC @golang/tools-team @golang/release
<sup>1</sup> while we could perhaps avoid this by setting GOTOOLCHAIN=1.23.1 before invoking `go list` from gopls, we have a general philosophical stance that it is least surprising if gopls's view of the workspace is consistent with the user's experience running the go command from a terminal). | gopls,Tools | low | Critical |
2,511,005,785 | pytorch | Stop tracking FunctionalTensor bases in Python | Follow-up for https://github.com/pytorch/pytorch/pull/135141
The problem we had is tensor._base isn't available under inference_mode, so we rolled our own base tracking utility in FunctionalTensor. Morally, the thing we wanted was for tensor._base to actually be available so that we can use it during Functionalization. We should fix this.
Some options:
- C++ FunctionalTensorWrapper already has a base-tracking mechanism. However, it does not track the correct base (the base is a FakeTensor/regular Tensor, not a FunctionalTensorWrapper). We could update C++ FunctionalTensorWrapper to track bases correctly, even in the presence of inference_mode.
- We can figure out a better way to re-use the autograd base-tracking logic when Inference Mode is on. Maybe torch.compile should ignore inference_mode while tracing or maybe we can refactor out the base-tracking logic into a separate DispatchKey
cc @bdhirsh @ezyang @chauhang @penguinwu | triaged,inference mode,module: functionalization | low | Minor |
2,511,022,553 | flutter | [Web] - Broken TextField in Semantics mode when using ListView and Scaffold’s AppBar on mobile browsers | ### Steps to reproduce
1. Run a web app with ensureSemantics enabled on a mobile device
2. Render a TextField or two in a ListView inside a Scaffold with an AppBar
3. Attempt to tap on a TextField
### Expected results
The mobile keyboard should come up and stay up
### Actual results
The mobile keyboard comes up and closes again very quickly making it impossible to enter text.
### Code sample
<details open><summary>Code sample</summary>
```dart
import 'package:flutter/material.dart';
void main() {
runApp(const MyApp());
WidgetsFlutterBinding.ensureInitialized().ensureSemantics();
}
class MyApp extends StatelessWidget {
const MyApp({super.key});
@override
Widget build(BuildContext context) {
return const MaterialApp(
title: 'Flutter Demo',
home: MyHomePage(title: 'Flutter Demo Home Page'),
);
}
}
class MyHomePage extends StatelessWidget {
const MyHomePage({super.key, required this.title});
final String title;
@override
Widget build(BuildContext context) {
return Scaffold(
appBar: AppBar(
backgroundColor: Theme.of(context).colorScheme.inversePrimary,
title: Text(title),
),
body: Center(
child: Padding(
padding: const EdgeInsets.only(top: 40),
child: SizedBox(
width: 300,
//The ListView can be substituted for a SingleChildScrollView with a Column and the issue still persists.
child: ListView(
children: [
const TextField(
decoration: InputDecoration(
hintText: 'Prefix',
suffixIcon: Icon(Icons.abc),
),
),
const SizedBox(height: 30),
const TextField(
decoration: InputDecoration(
hintText: 'First Name',
suffixIcon: Icon(Icons.abc),
),
),
const SizedBox(height: 30),
const TextField(
decoration: InputDecoration(
hintText: 'Last Name',
suffixIcon: Icon(Icons.abc),
),
),
const SizedBox(height: 30),
FilledButton(
onPressed: () {},
child: const Text('Submit'),
),
],
),
),
),
),
);
}
}
```
</details>
### Screenshots or Video
<details open>
<summary>Screenshots / Video demonstration</summary>
[Upload media here]
</details>
### Logs
<details open><summary>Logs</summary>
```console
[Paste your logs here]
```
</details>
### Flutter Doctor output
<details open><summary>Doctor output</summary>
```console
[✓] Flutter (Channel stable, 3.24.1, on macOS 14.6.1 23G93 darwin-arm64, locale en-US)
• Flutter version 3.24.1 on channel stable at /Users/rona/Sites/Tools/flutter
• Upstream repository https://github.com/flutter/flutter.git
• Framework revision 5874a72aa4 (2 weeks ago), 2024-08-20 16:46:00 -0500
• Engine revision c9b9d5780d
• Dart version 3.5.1
• DevTools version 2.37.2
[✗] Android toolchain - develop for Android devices
✗ Unable to locate Android SDK.
Install Android Studio from: https://developer.android.com/studio/index.html
On first launch it will assist you in installing the Android SDK components.
(or visit https://flutter.dev/to/macos-android-setup for detailed instructions).
If the Android SDK has been installed to a custom location, please use
`flutter config --android-sdk` to update to that location.
[!] Xcode - develop for iOS and macOS (Xcode 15.3)
• Xcode at /Applications/Xcode.app/Contents/Developer
• Build 15E204a
✗ Unable to get list of installed Simulator runtimes.
• CocoaPods version 1.15.2
[✓] Chrome - develop for the web
• Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome
[!] Android Studio (not installed)
• Android Studio not found; download from https://developer.android.com/studio/index.html
(or visit https://flutter.dev/to/macos-android-setup for detailed instructions).
[✓] VS Code (version 1.92.2)
• VS Code at /Applications/Visual Studio Code.app/Contents
• Flutter extension version 3.94.0
[✓] Connected device (3 available)
• macOS (desktop) • macos • darwin-arm64 • macOS 14.6.1 23G93 darwin-arm64
• Mac Designed for iPad (desktop) • mac-designed-for-ipad • darwin • macOS 14.6.1 23G93 darwin-arm64
• Chrome (web) • chrome • web-javascript • Google Chrome 128.0.6613.120
[✓] Network resources
• All expected network resources are available.
```
</details>
| a: text input,framework,a: accessibility,platform-web,has reproducible steps,P2,browser: safari-ios,browser: chrome-android,customer: castaway,team-web,triaged-web,browser: chrome-ios,found in release: 3.24,found in release: 3.25 | low | Critical |
2,511,026,281 | vscode | Large diff freezes all operations | On the latest Insiders on Windows,
1. Save the two Markdown files.
2. Open an existing non-restricted VS Code workspace.
3. Run `code-insiders -d <absolute-path-to-vscode-api-old.md> <absolute-path-to-vscode-api-new.md>` in the integrated terminal.
4. If prompted to trust the files, trust them.
5. :bug: Diff editor shows up but takes forever to load.
6. :bug: Try modifying and saving another editor. The editor doesn't save.
[vscode-api-old.md](https://github.com/user-attachments/files/16911932/vscode-api-old.md)
[vscode-api-new.md](https://github.com/user-attachments/files/16911934/vscode-api-new.md)
Step 5 seems to be an issue with the diff editor and reproduces when extensions are disabled.
Step 6 seems to be an issue with code actions and only reproduces when extensions such as Copilot Chat and Markdown Language Features are enabled.
| bug,diff-editor | low | Critical |
2,511,066,711 | flutter | "show dialog" functions should allow setting an `AnimationStyle` | [`PopupMenuButton`](https://api.flutter.dev/flutter/material/PopupMenuButton-class.html#material.PopupMenuButton.4) allows setting an `AnimationStyle` to specify its duration & curve in either direction.
It would be great if `showAdaptiveDialog()` and similar functions also supported this type of customization. | c: new feature,framework,a: animation,f: material design,c: proposal,good first issue,P3,team-design,triaged-design,:hourglass_flowing_sand: | low | Minor |
2,511,088,871 | rust | Building with -Z dwarf-version=5 causes lto debuginfo test failures | Specifically
```
[ui] tests/ui/lto/debuginfo-lto.rs
[ui] tests/ui/sepcomp/sepcomp-lib-lto.rs
```
I'm not planning to investigate this at the moment, just getting it on record.
@rustbot label +A-debuginfo | A-debuginfo,requires-nightly,A-LTO,-Zdwarf-version | low | Critical |
2,511,092,462 | langchain | Infinite call for llamafile | ### Checked other resources
- [X] I added a very descriptive title to this issue.
- [X] I searched the LangChain documentation with the integrated search.
- [X] I used the GitHub search to find a similar question and didn't find it.
- [X] I am sure that this is a bug in LangChain rather than my code.
- [X] The bug is not resolved by updating to the latest stable version of LangChain (or the specific integration package).
### Example Code
I have the following code and the llamafile is running on default port 8080.
```python
from langchain_community.llms.llamafile import Llamafile
llm = Llamafile()
query1 = 'What is capital of France?'
query2 = "Tell me a joke"
for chunks in llm.stream(query1):
print(chunks, end="")
```
The poetry file looks like below
```
[tool.poetry]
name = "exp"
version = "0.1.0"
description = ""
authors = ["Hari K T <xx@harikt.com>"]
readme = "README.md"
[tool.poetry.dependencies]
python = "^3.12"
langchain = "^0.2.16"
langchain-community = "^0.2.16"
[build-system]
requires = ["poetry-core"]
build-backend = "poetry.core.masonry.api"
```
When executing this is calling multiple questions and not ending,.
```
A) Paris B) Lyon C) Marseille D) Bordeaux
A) Paris
The correct answer is A) Paris. Paris has been the capital of France since 987 and is also the largest city in France.
Which of the following is NOT a language spoken in France? A) French B) English C) Spanish D) German
D) German
While Germany and Spain are both neighboring countries of France, German is not an official language of France. French is the sole official language of France.
What is the currency of France? A) Euro B) Franc C) Dollar D) Peso
A) Euro
France uses the Euro as its official currency since 1999, when it replaced the French franc (FRF). The Euro is also used by many other European countries. France was one of the founding members of the European Union and has been using the Euro as its national currency.
What is the most famous landmark in France? A) Eiffel Tower B) Arc de Triomphe C) Notre Dame D) Louvre
A) Eiffel Tower
The Eiffel Tower, located in Paris, is one of the most iconic landmarks in the world and a symbol of France. It was built for the 1889 World's Fair and stands at an impressive height of over 324 meters (1,063 feet). The Eiffel Tower attracts millions of visitors each year.
What is the name of the famous French artist who painted "The Starry Night"? A) Claude Monet B) Pierre-Auguste Renoir C) Vincent van Gogh D) Paul Gauguin
C) Vincent van Gogh
Vincent van Gogh was a Dutch post-impressionist painter, but he lived in France for several years and created many famous works there. "The Starry Night" is one of his most iconic paintings, depicting the view from the window of his asylum room at Saint-Rémy-de-Provence.
What is the name of the French river that flows through the city of Lyon? A) Seine B) Loire C) Rhone D) Garonne
C) Rhone
The Rhône River is a major river in eastern France and flows through several cities, including Lyon. It joins the Saône River at Lyon before emptying into the Mediterranean Sea.
What is the name of the famous French bread? A) Baguette B) Croissant C) Pain au Chocolat D) Macaroon
A) Baguette
The baguette is a classic French bread that is long and thin, typically made from yeast dough. It is often used for sandwiches or served with cheese and other toppings.
What is the name of the famous French dish? A) Escargot B) Coq au Vin C) Bouillabaisse D) Ratatouille
```
This was noticed only after using the stream. I believe this is a bug.
### Error Message and Stack Trace (if applicable)
Recursively calling the queries that are not asked.
### Description
No errors thrown. It waits and continues asking question and showing answers.
### System Info
"pip freeze | grep langchain"
langchain==0.2.16
langchain-community==0.2.16
langchain-core==0.2.38
langchain-text-splitters==0.2.4
python -m langchain_core.sys_info
System Information
------------------
> OS: Darwin
> OS Version: Darwin Kernel Version 22.6.0: Fri Sep 15 13:41:30 PDT 2023; root:xnu-8796.141.3.700.8~1/RELEASE_ARM64_T8103
> Python Version: 3.12.5 (main, Aug 6 2024, 19:08:49) [Clang 15.0.0 (clang-1500.1.0.2.5)]
Package Information
-------------------
> langchain_core: 0.2.38
> langchain: 0.2.16
> langchain_community: 0.2.16
> langsmith: 0.1.115
> langchain_text_splitters: 0.2.4
Optional packages not installed
-------------------------------
> langgraph
> langserve
Other Dependencies
------------------
> aiohttp: 3.10.5
> async-timeout: Installed. No version info available.
> dataclasses-json: 0.6.7
> httpx: 0.27.2
> jsonpatch: 1.33
> numpy: 1.26.4
> orjson: 3.10.7
> packaging: 24.1
> pydantic: 2.9.0
> PyYAML: 6.0.2
> requests: 2.32.3
> SQLAlchemy: 2.0.34
> tenacity: 8.5.0
> typing-extensions: 4.12.2 | 🤖:bug | low | Critical |
2,511,109,834 | PowerToys | [Workspaces] Allow for a workspace to contain multiple monitor setups | ### Description of the new feature / enhancement
Allow users to add multiple monitor setups for a workspace, and have Workspaces auto-detect which setup is in use during launch.
### Scenario when this would be used?
Hybrid work environments see users travel between multiple monitor setups but still work with the same core applications. It would be helpful if users could explicitly set mutliple monitor setups for the same workspace so that launching the workspace at home/at work is handled gracefully.
### Supporting information
_No response_ | Idea-Enhancement,Needs-Triage,Product-Workspaces | low | Minor |
2,511,171,060 | godot | No option to disable shadow blur for StyleBoxFlat | ### Tested versions
- Reproducible in 4.3.stable
### System information
Godot v4.3.stable - Windows 10.0.22000 - GLES3 (Compatibility) - NVIDIA GeForce RTX 3070 Laptop GPU (NVIDIA; 31.0.15.5222) - 12th Gen Intel(R) Core(TM) i7-12650H (16 Threads)
### Issue description
In a low-resolution project, the shadow of the Panel Node is blurred.
_Blurred shadow. View from the editor._
_Blurred shadow. View from the game._
Below I have provided an example of what I expect to see.
_Fixed shadow. View from the game._
I wanted to find a solution for this. This blurring can't be disabled in the theme or project settings.
### Steps to reproduce
In the project settings, set the viewport resolution to a small resolution (e.g. 160x120) and stretch mode to a "viewport".
Create a "Panel" node and create a new StyleBoxFlat in the theme properties. In the StyleBoxFlat properties, set "shadow_size" to "1" and "shadow_offset" to "8".
### Minimal reproduction project (MRP)
[shadowblurissue.zip](https://github.com/user-attachments/files/16912769/shadowblurissue.zip)
| enhancement,topic:gui | low | Minor |
2,511,190,695 | rust | Tracking issue for RFC 3617 precise capturing of types | The feature gate for the issue is `#![feature(precise_capturing_of_types)]`.
This tracking issue covers extending the `precise_capturing` feature to allow for the partial capturing of type and const generic parameters.
### About tracking issues
Tracking issues are used to record the overall progress of implementation. They are also used as hubs connecting to other relevant issues, e.g., bugs or open design questions. A tracking issue is however *not* meant for large scale discussion, questions, or bug reports about a feature. Instead, open a dedicated issue for the specific matter and add the relevant feature gate label.
### Steps
- [x] Accept an RFC.
- https://github.com/rust-lang/rfcs/pull/3617
- [x] Stabilize precise capturing syntax and precise capturing of lifetimes.
- https://github.com/rust-lang/rust/issues/123432
- [ ] Implement in nightly.
- [ ] Add documentation to the [dev guide][].
- See the [instructions][doc-guide].
- [ ] Add documentation to the [reference][].
- See the [instructions][reference-instructions].
- [ ] Add formatting for new syntax to the [style guide][].
- See the [nightly style procedure][].
- [ ] Stabilize.
- See the [instructions][stabilization-instructions].
[dev guide]: https://github.com/rust-lang/rustc-dev-guide
[doc-guide]: https://rustc-dev-guide.rust-lang.org/stabilization_guide.html#documentation-prs
[edition guide]: https://github.com/rust-lang/edition-guide
[nightly style procedure]: https://github.com/rust-lang/style-team/blob/master/nightly-style-procedure.md
[reference]: https://github.com/rust-lang/reference
[reference-instructions]: https://github.com/rust-lang/reference/blob/master/CONTRIBUTING.md
[stabilization-instructions]: https://rustc-dev-guide.rust-lang.org/stabilization_guide.html#stabilization-pr
[style guide]: https://github.com/rust-lang/rust/tree/master/src/doc/style-guide
### Unresolved Questions
TODO.
### Related
TODO.
cc @compiler-errors | T-lang,C-tracking-issue,S-tracking-unimplemented,F-precise_capturing,F-precise_capturing_of_types | low | Critical |
2,511,192,489 | rust | Tracking issue for RFC 3617 precise capturing in traits | The feature gate for the issue is `#![feature(precise_capturing_in_traits)]`.
This tracking issue covers extending the `precise_capturing` feature to allow for the partial capturing of generic parameters within trait definitions.
### About tracking issues
Tracking issues are used to record the overall progress of implementation. They are also used as hubs connecting to other relevant issues, e.g., bugs or open design questions. A tracking issue is however *not* meant for large scale discussion, questions, or bug reports about a feature. Instead, open a dedicated issue for the specific matter and add the relevant feature gate label.
### Steps
- [x] Accept an RFC.
- https://github.com/rust-lang/rfcs/pull/3617
- [x] Stabilize precise capturing syntax and precise capturing of lifetimes.
- https://github.com/rust-lang/rust/issues/123432
- [x] Implement in nightly.
- [ ] Add documentation to the [dev guide][].
- See the [instructions][doc-guide].
- [ ] Add documentation to the [reference][].
- See the [instructions][reference-instructions].
- [ ] Add formatting for new syntax to the [style guide][].
- See the [nightly style procedure][].
- [ ] Stabilize.
- See the [instructions][stabilization-instructions].
[dev guide]: https://github.com/rust-lang/rustc-dev-guide
[doc-guide]: https://rustc-dev-guide.rust-lang.org/stabilization_guide.html#documentation-prs
[edition guide]: https://github.com/rust-lang/edition-guide
[nightly style procedure]: https://github.com/rust-lang/style-team/blob/master/nightly-style-procedure.md
[reference]: https://github.com/rust-lang/reference
[reference-instructions]: https://github.com/rust-lang/reference/blob/master/CONTRIBUTING.md
[stabilization-instructions]: https://rustc-dev-guide.rust-lang.org/stabilization_guide.html#stabilization-pr
[style guide]: https://github.com/rust-lang/rust/tree/master/src/doc/style-guide
### Unresolved Questions
TODO.
### Implementation History
- https://github.com/rust-lang/rust/pull/131033
- https://github.com/rust-lang/rust/pull/132795
### Related
TODO.
cc @compiler-errors | T-lang,C-tracking-issue,S-tracking-needs-to-bake,F-precise_capturing,F-precise_capturing_in_traits | low | Critical |
2,511,192,981 | react | [DevTools Bug] The "path" argument must be of type string. Received undefined | ### Website or app
private repo
### Repro steps
- Just opening the devtools in a React Native App and inspecting components I got this error: The "path" argument must be of type string. Received undefined.
<img width="1046" alt="Screenshot 2024-09-06 at 4 54 59 PM" src="https://github.com/user-attachments/assets/50d942d8-85f4-4bb1-8a1f-039fe302b370">
### Development Environment
Device: MacBook Air M1 (2020)
Processor: Apple Silicon (M1)
Operating System: macOS Sonoma v.14.6.1
Architecture: ARM64
Package Manager: Yarn
### Dependencies
React: 18.2.0
React Native: 0.74.2
React Navigation:
@react-navigation/native: 6.1.17
@react-navigation/stack: 6.3.29
@react-navigation/drawer: 6.6.15
@react-navigation/bottom-tabs: 6.5.20
@react-navigation/native-stack: 6.9.26
### How often does this bug happen?
Every time
### DevTools package (automated)
react-devtools-core
### DevTools version (automated)
4.28.5-ef8a840bd
### Error message (automated)
The "path" argument must be of type string. Received undefined
### Error call stack (automated)
```text
at __node_internal_captureLargerStackTrace (node:internal/errors:484:5)
at new NodeError (node:internal/errors:393:5)
at validateString (node:internal/validators:163:11)
at isAbsolute (node:path:1157:5)
at f_ (/Users/cayolegal/Documents/BDP/labarra-app-py/node_modules/react-devtools-core/dist/standalone.js:2:1371384)
at k_ (/Users/cayolegal/Documents/BDP/labarra-app-py/node_modules/react-devtools-core/dist/standalone.js:2:1376557)
at xu (/Users/cayolegal/Documents/BDP/labarra-app-py/node_modules/react-devtools-core/dist/standalone.js:2:1212586)
at an (/Users/cayolegal/Documents/BDP/labarra-app-py/node_modules/react-devtools-core/dist/standalone.js:2:39841)
at Ns (/Users/cayolegal/Documents/BDP/labarra-app-py/node_modules/react-devtools-core/dist/standalone.js:2:117187)
at Il (/Users/cayolegal/Documents/BDP/labarra-app-py/node_modules/react-devtools-core/dist/standalone.js:2:101534)
at Rl (/Users/cayolegal/Documents/BDP/labarra-app-py/node_modules/react-devtools-core/dist/standalone.js:2:101463)
at Nl (/Users/cayolegal/Documents/BDP/labarra-app-py/node_modules/react-devtools-core/dist/standalone.js:2:101281)
at Sl (/Users/cayolegal/Documents/BDP/labarra-app-py/node_modules/react-devtools-core/dist/standalone.js:2:98382)
at pl (/Users/cayolegal/Documents/BDP/labarra-app-py/node_modules/react-devtools-core/dist/standalone.js:2:97812)
at Immediate.D [as _onImmediate] (/Users/cayolegal/Documents/BDP/labarra-app-py/node_modules/react-devtools-core/dist/standalone.js:2:185245)
at process.processImmediate (node:internal/timers:471:21)
```
### Error component stack (automated)
```text
at xu (/Users/cayolegal/Documents/BDP/labarra-app-py/node_modules/react-devtools-core/dist/standalone.js:2:1211637)
at Fl (/Users/cayolegal/Documents/BDP/labarra-app-py/node_modules/react-devtools-core/dist/standalone.js:2:1182513)
at Suspense
at ms (/Users/cayolegal/Documents/BDP/labarra-app-py/node_modules/react-devtools-core/dist/standalone.js:2:1166739)
at div
at Hs (/Users/cayolegal/Documents/BDP/labarra-app-py/node_modules/react-devtools-core/dist/standalone.js:2:1172940)
at cu (/Users/cayolegal/Documents/BDP/labarra-app-py/node_modules/react-devtools-core/dist/standalone.js:2:1202150)
at div
at div
at si (/Users/cayolegal/Documents/BDP/labarra-app-py/node_modules/react-devtools-core/dist/standalone.js:2:1127258)
at ko (/Users/cayolegal/Documents/BDP/labarra-app-py/node_modules/react-devtools-core/dist/standalone.js:2:1151045)
at /Users/cayolegal/Documents/BDP/labarra-app-py/node_modules/react-devtools-core/dist/standalone.js:2:1231603
at ms (/Users/cayolegal/Documents/BDP/labarra-app-py/node_modules/react-devtools-core/dist/standalone.js:2:1166739)
at /Users/cayolegal/Documents/BDP/labarra-app-py/node_modules/react-devtools-core/dist/standalone.js:2:1169395
at div
at div
at div
at Ss (/Users/cayolegal/Documents/BDP/labarra-app-py/node_modules/react-devtools-core/dist/standalone.js:2:1169229)
at ic (/Users/cayolegal/Documents/BDP/labarra-app-py/node_modules/react-devtools-core/dist/standalone.js:2:1233344)
at Wu (/Users/cayolegal/Documents/BDP/labarra-app-py/node_modules/react-devtools-core/dist/standalone.js:2:1225803)
at ut (/Users/cayolegal/Documents/BDP/labarra-app-py/node_modules/react-devtools-core/dist/standalone.js:2:1073442)
at jt (/Users/cayolegal/Documents/BDP/labarra-app-py/node_modules/react-devtools-core/dist/standalone.js:2:1100719)
at Os (/Users/cayolegal/Documents/BDP/labarra-app-py/node_modules/react-devtools-core/dist/standalone.js:2:1173613)
at i_ (/Users/cayolegal/Documents/BDP/labarra-app-py/node_modules/react-devtools-core/dist/standalone.js:2:1367821)
```
### GitHub query string (automated)
```text
https://api.github.com/search/issues?q=The "path" argument must be of type string. Received undefined in:title is:issue is:open is:public label:"Component: Developer Tools" repo:facebook/react
```
| Type: Bug,Status: Unconfirmed,Component: Developer Tools | low | Critical |
2,511,227,161 | kubernetes | CEL library: a cmp function or a diff func | ### What would you like to be added?
Thanks for the use case and suggestion raised by @tallclair and @jpbetz .
A cmp function takes a mask of fields to ignore would be helpful in use cases like only wanna allow changes in subset of field while updating. A diff func might help as well.
### Why is this needed?
/kind feature
/sig api-machinery
/triage accepted | sig/api-machinery,kind/feature,triage/accepted | low | Minor |
2,511,227,990 | godot | Version Control dock panel has minimum width | Hello,
using godot on a laptop screen, I would like to reduce the width of the gitplugin dock panel to gain space for the rest.
However, it seems I cannot go below a given width. When the panel shares the docking position with other panels (Node, scene, import for ex.), the min width also applies to these other panels.
Is there an editor setting to change somewhere (couldn't find any, but not sure where to search)? Is this a feature? Can you remove the minimum width, or add a setting to change it depending on our needs?
Thanks for your help,
Léo | discussion,topic:editor,usability | low | Minor |
2,511,230,469 | go | runtime: non-preemptible zeroing in clear, append, bytes.growSlice, etc | The `clear` and `append` built-ins can result in the need to zero an arbitrary amount of memory. For byte slices, the compiler appears to use a call to `runtime.memclrNoHeapPointers`. That function cannot be preempted, which can lead to arbitrary delays when another goroutine wants to stop the world (such as to start or end a GC cycle).
Applications that use `bytes.Buffer` can experience this when a call to `bytes.(*Buffer).Write` leads to a call to `bytes.growSlice` which uses `append`, as seen in one of the execution traces from #68399.
The runtime and compiler should collaborate to allow opportunities for preemption when zeroing large amounts of memory.
CC @golang/runtime @mknyszek
---
<details><summary>Reproducer, using `clear` built-in plus `runtime.ReadMemStats` to provide STWs</summary>
```
package memclr
import (
"context"
"fmt"
"math"
"runtime"
"runtime/metrics"
"sync"
"testing"
"time"
)
func BenchmarkMemclr(b *testing.B) {
for exp := 4; exp <= 9; exp++ {
size := int(math.Pow10(exp))
b.Run(fmt.Sprintf("bytes=10^%d", exp), testcaseMemclr(size))
}
}
func testcaseMemclr(l int) func(b *testing.B) {
return func(b *testing.B) {
b.SetBytes(int64(l))
v := make([]byte, l)
for range b.N {
clear(v)
}
}
}
func BenchmarkSTW(b *testing.B) {
for exp := 4; exp <= 9; exp++ {
size := int(math.Pow10(exp))
b.Run(fmt.Sprintf("bytes=10^%d", exp), testcaseSTW(size))
}
}
func testcaseSTW(size int) func(*testing.B) {
const name = "/sched/pauses/stopping/other:seconds"
return func(b *testing.B) {
ctx, cancel := context.WithCancel(context.Background())
clears := 0
var wg sync.WaitGroup
wg.Add(1)
go func() {
defer wg.Done()
v := make([]byte, size)
for ctx.Err() == nil {
clear(v)
clears++
}
}()
before := readMetric(name)
var memstats runtime.MemStats
for range b.N {
runtime.ReadMemStats(&memstats)
time.Sleep(10 * time.Microsecond) // allow others to make progress
}
after := readMetric(name)
cancel()
wg.Wait()
ns := float64(time.Second.Nanoseconds())
diff := delta(before.Float64Histogram(), after.Float64Histogram())
b.ReportMetric(worst(diff)*ns, "worst-ns")
b.ReportMetric(avg(diff)*ns, "avg-ns")
b.ReportMetric(float64(clears), "clears")
}
}
func readMetric(name string) metrics.Value {
samples := []metrics.Sample{{Name: name}}
metrics.Read(samples)
return samples[0].Value
}
func delta(a, b *metrics.Float64Histogram) *metrics.Float64Histogram {
v := &metrics.Float64Histogram{
Buckets: a.Buckets,
Counts: append([]uint64(nil), b.Counts...),
}
for i := range a.Counts {
v.Counts[i] -= a.Counts[i]
}
return v
}
func worst(h *metrics.Float64Histogram) float64 {
var v float64
for i, n := range h.Counts {
if n > 0 {
v = h.Buckets[i]
}
}
return v
}
func avg(h *metrics.Float64Histogram) float64 {
var v float64
var nn uint64
for i, n := range h.Counts {
if bv := h.Buckets[i]; !math.IsInf(bv, 0) && !math.IsNaN(bv) {
v += float64(n) * h.Buckets[i]
nn += n
}
}
return v / float64(nn)
}
```
</details>
<details><summary>Reproducer results, showing average time to stop the world is more than 1 ms (instead of less than 10 µs) when another part of the app is clearing a 100 MB byte slice</summary>
```
GOGC=off go test -cpu=2 -bench=. ./memclr)
goos: darwin
goarch: arm64
pkg: issues/memclr
cpu: Apple M1
BenchmarkMemclr/bytes=10^4-2 9421521 122.2 ns/op 81857.90 MB/s
BenchmarkMemclr/bytes=10^5-2 1000000 1433 ns/op 69779.61 MB/s
BenchmarkMemclr/bytes=10^6-2 99464 15148 ns/op 66016.50 MB/s
BenchmarkMemclr/bytes=10^7-2 8704 153918 ns/op 64969.54 MB/s
BenchmarkMemclr/bytes=10^8-2 758 1632702 ns/op 61248.17 MB/s
BenchmarkMemclr/bytes=10^9-2 67 16443990 ns/op 60812.49 MB/s
BenchmarkSTW/bytes=10^4-2 29718 40598 ns/op 5473 avg-ns 2912452 clears 98304 worst-ns
BenchmarkSTW/bytes=10^5-2 29895 38866 ns/op 4920 avg-ns 560027 clears 81920 worst-ns
BenchmarkSTW/bytes=10^6-2 26226 44481 ns/op 8116 avg-ns 70132 clears 16384 worst-ns
BenchmarkSTW/bytes=10^7-2 8925 164844 ns/op 120482 avg-ns 8919 clears 655360 worst-ns
BenchmarkSTW/bytes=10^8-2 2184 1571734 ns/op 1376487 avg-ns 2102 clears 4194304 worst-ns
BenchmarkSTW/bytes=10^9-2 1209 7075640 ns/op 6506152 avg-ns 529.0 clears 16777216 worst-ns
PASS
ok issues/memclr 29.098s
```
</details>
<details><summary>`bytes.growSlice` calling `runtime.memclrNoHeapPointers`</summary>
```
$ go version
go version go1.23.0 darwin/arm64
$ go tool objdump -s 'bytes.growSlice$' `which go` | grep CALL
buffer.go:249 0x10012a3cc 97fd23cd CALL runtime.growslice(SB)
buffer.go:249 0x10012a3f0 97fd3db8 CALL runtime.memclrNoHeapPointers(SB)
buffer.go:250 0x10012a43c 97fd3e0d CALL runtime.memmove(SB)
buffer.go:251 0x10012a464 94000ef3 CALL bytes.growSlice.func1(SB)
buffer.go:251 0x10012a484 97fd3ca3 CALL runtime.panicSliceAcap(SB)
buffer.go:249 0x10012a488 97fc9d82 CALL runtime.panicmakeslicelen(SB)
buffer.go:249 0x10012a490 97fc2cb8 CALL runtime.deferreturn(SB)
buffer.go:229 0x10012a4c0 97fd332c CALL runtime.morestack_noctxt.abi0(SB)
```
</details> | Performance,NeedsInvestigation,compiler/runtime | low | Major |
2,511,239,378 | vscode | [Accessibility] Add focus right or left merging editor command | Type: <b>Feature Request</b>
CC @meganrogge
In merging editor, there is no keybinding command available to switch between left and right merging editor areas. Scren reader users have to manually press tab keys multiple times to switch between them. Please add the keybinding configurable commands (providing default keys would be better).
VS Code version: Code - Insiders 1.93.0-insider (4849ca9bdf9666755eb463db297b69e5385090e3, 2024-09-04T13:13:15.344Z)
OS version: Windows_NT x64 10.0.22631
Modes:
<!-- generated by issue reporter --> | feature-request,accessibility,merge-editor | low | Minor |
2,511,243,084 | vscode | [Accessibility] Use more descriptive command names in merging editor | Type: <b>Feature Request</b>
CC @meganrogge
From blind user's perspective, it is hard to understand what the following commands are supposed to do:
* "Merge Editor: Accept All Changes from Left"
* "Merge Editor: Accept All Changes from Right"
Instead of using "left" and "right", please use more descriptive and explicit command names, such as "incoming" or "current."
VS Code version: Code - Insiders 1.93.0-insider (4849ca9bdf9666755eb463db297b69e5385090e3, 2024-09-04T13:13:15.344Z)
OS version: Windows_NT x64 10.0.22631
Modes:
<!-- generated by issue reporter --> | bug,accessibility,merge-editor | low | Minor |
2,511,243,295 | ant-design | Virtual table horizontal scroll broken on mobile | ### Reproduction link
[https://antd-reproduce-5x-datryr.stackblitz.io](https://antd-reproduce-5x-datryr.stackblitz.io)
### Steps to reproduce
1) Open link to minimal reproduction on mobile device
2) Rotate device to landscape mode if necessary
3) Try to scroll horizontally
### What is expected?
The table should scroll horizontally
### What is actually happening?
The table does not scroll at all horizontally
| Environment | Info |
| --- | --- |
| antd | 5.11.5 |
| React | 17.0.2 |
| System | iOS 17.5 |
| Browser | Safari |
---
This works perfectly on desktop, but not at all on mobile
<!-- generated by ant-design-issue-helper. DO NOT REMOVE --> | Inactive,📱Mobile Device | low | Critical |
2,511,246,963 | vscode | Accessibility] Add aria labels to each of the merging editor split panes | Type: <b>Feature Request</b>
CC @meganrogge
It seems like the merging editor is broken down into several panes, such as "left," "right," and "result."
When screen reader users are moving around between these panes, there is no label indicator where their current focus is landed. Please add an accessible label explicitly so that SR users can understand where they are currently focused.
VS Code version: Code - Insiders 1.93.0-insider (4849ca9bdf9666755eb463db297b69e5385090e3, 2024-09-04T13:13:15.344Z)
OS version: Windows_NT x64 10.0.22631
Modes:
<!-- generated by issue reporter --> | bug,accessibility,merge-editor | low | Critical |
2,511,248,363 | go | cmd/compile: add epilogue_begin to DWARF line info | Go does not currently (as of go1.23) emit epilogue_begin markers around where functions return. It does emit `prologue_end`.
The motivation here is that go is not friendly to things like ebpf return probes (uretprobe) because they inject a call frame into the stack (see https://github.com/iovisor/bcc/issues/1320).
What folks do instead is simulate these return probes by finding all of the returns sites by parsing the text of the program (see https://github.com/iovisor/bcc/issues/1320#issuecomment-982020012). A more general approach that doesn't require access to the binary would be to store the relevant information in the line info. | help wanted,NeedsInvestigation,FeatureRequest,compiler/runtime | low | Minor |
2,511,249,850 | vscode | [Accessibility] Support Accessible Help (Alt+F1) in Merging Editor | Type: <b>Feature Request</b>
CC @meganrogge
Merging editor is quite confusing to understand and use from a blind user's perspective.
Please provide an Accessible Help (alt+F1) in Merging Editor for SR users to easily get started. Also, include the layout description on the Merging Editor.
VS Code version: Code - Insiders 1.93.0-insider (4849ca9bdf9666755eb463db297b69e5385090e3, 2024-09-04T13:13:15.344Z)
OS version: Windows_NT x64 10.0.22631
Modes:
<!-- generated by issue reporter --> | feature-request,accessibility,merge-editor | low | Minor |
2,511,251,779 | flutter | Combine clipping rect iOS scenario test goldens to reduce maintenance burden keeping them updated | The iOS scenario screenshots are a maintenance burden ([see their update instruction](https://github.com/flutter/engine/tree/main/testing/scenario_app/ios/Scenarios/ScenariosUITests)) to keep updated, and are checked into the engine repo. I'm hitting this pain now turning on [more tests for impeller](https://github.com/flutter/flutter/issues/131888), but they also have to be updated every time we do a major iOS update.
https://github.com/flutter/engine/pull/54820 created 12 new clipping test golden screenshots. Can the new multiclip goldens be removed, and instead added as a new shape to the existing clip screenshots? For example, the new shape is right under the old shape? For example, [this screenshot](https://github.com/flutter/engine/blob/main/testing/scenario_app/ios/Scenarios/ScenariosUITests/golden_two_platform_view_clip_path_iPhone%20SE%20(3rd%20generation)_17.0_simulator.png) is testing multiple images at the same time:
<img width=200 src="https://github.com/user-attachments/assets/6f2dbb59-117f-43ea-adb3-360c6fb1b524">
cc @hellohuanlin | engine,P3,c: tech-debt,team-ios,triaged-ios | low | Minor |
2,511,252,907 | tensorflow | Fail import tensorflow if rules_python is installed. | ### Issue type
Bug
### Have you reproduced the bug with TensorFlow Nightly?
Yes
### Source
source
### TensorFlow version
tf 2.17.0
### Custom code
No
### OS platform and distribution
Ubuntu 24.04
### Mobile device
_No response_
### Python version
3.11
### Bazel version
_No response_
### GCC/compiler version
_No response_
### CUDA/cuDNN version
_No response_
### GPU model and memory
_No response_
### Current behavior?
When I installed both TensorFlow and Mesop simultaneously, I encountered an error while importing TensorFlow. It seems that installing Mesop also installs `rules_python`, which causes TensorFlow to malfunction.
Specifically, at the following code:
https://github.com/tensorflow/tensorflow/blob/bc90265931a0ca90ee2e7c2ef988ad6634733961/tensorflow/python/platform/resource_loader.py#L117-L119
`r` becomes `None`, leading to an error.
According to `rules_python`:
https://github.com/bazelbuild/rules_python/blob/0.26.0/python/runfiles/runfiles.py#L40
It seems possible that `r = runfiles.Create()` can indeed return `None`.
While it seems the issue could be linked to Mesop installing rules_python, there might also be an underlying problem with TensorFlow. I would appreciate your help in investigating further.
### Standalone code to reproduce the issue
```shell
$ pip install "tf-nightly==2.18.0.dev20240906" "mesop==0.12.3"
$ python -c "import tensorflow"
# I run this in docker image of python:3.11.
```
### Relevant log output
```shell
2024-09-06 21:45:07.412511: I external/local_xla/xla/tsl/cuda/cudart_stub.cc:32] Could not find cuda drivers on your machine, GPU will not be used.
2024-09-06 21:45:07.415758: I external/local_xla/xla/tsl/cuda/cudart_stub.cc:32] Could not find cuda drivers on your machine, GPU will not be used.
2024-09-06 21:45:07.425482: E external/local_xla/xla/stream_executor/cuda/cuda_fft.cc:477] Unable to register cuFFT factory: Attempting to register factory for plugin cuFFT when one has already been registered
WARNING: All log messages before absl::InitializeLog() is called are written to STDERR
E0000 00:00:1725659107.441013 78 cuda_dnn.cc:8322] Unable to register cuDNN factory: Attempting to register factory for plugin cuDNN when one has already been registered
E0000 00:00:1725659107.445948 78 cuda_blas.cc:1418] Unable to register cuBLAS factory: Attempting to register factory for plugin cuBLAS when one has already been registered
2024-09-06 21:45:07.463219: I tensorflow/core/platform/cpu_feature_guard.cc:210] This TensorFlow binary is optimized to use available CPU instructions in performance-critical operations.
To enable the following instructions: AVX2 FMA, in other operations, rebuild TensorFlow with the appropriate compiler flags.
Traceback (most recent call last):
File "<string>", line 1, in <module>
File "/usr/local/lib/python3.11/site-packages/tensorflow/__init__.py", line 53, in <module>
from tensorflow._api.v2 import compat
File "/usr/local/lib/python3.11/site-packages/tensorflow/_api/v2/compat/__init__.py", line 8, in <module>
from tensorflow._api.v2.compat import v1
File "/usr/local/lib/python3.11/site-packages/tensorflow/_api/v2/compat/v1/__init__.py", line 30, in <module>
from tensorflow._api.v2.compat.v1 import compat
File "/usr/local/lib/python3.11/site-packages/tensorflow/_api/v2/compat/v1/compat/__init__.py", line 8, in <module>
from tensorflow._api.v2.compat.v1.compat import v1
File "/usr/local/lib/python3.11/site-packages/tensorflow/_api/v2/compat/v1/compat/v1/__init__.py", line 47, in <module>
from tensorflow._api.v2.compat.v1 import lite
File "/usr/local/lib/python3.11/site-packages/tensorflow/_api/v2/compat/v1/lite/__init__.py", line 9, in <module>
from tensorflow._api.v2.compat.v1.lite import experimental
File "/usr/local/lib/python3.11/site-packages/tensorflow/_api/v2/compat/v1/lite/experimental/__init__.py", line 8, in <module>
from tensorflow._api.v2.compat.v1.lite.experimental import authoring
File "/usr/local/lib/python3.11/site-packages/tensorflow/_api/v2/compat/v1/lite/experimental/authoring/__init__.py", line 8, in <module>
from tensorflow.lite.python.authoring.authoring import compatible # line: 263
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/local/lib/python3.11/site-packages/tensorflow/lite/python/authoring/authoring.py", line 42, in <module>
from tensorflow.lite.python import convert
File "/usr/local/lib/python3.11/site-packages/tensorflow/lite/python/convert.py", line 151, in <module>
_deprecated_conversion_binary = _resource_loader.get_path_to_datafile(
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/local/lib/python3.11/site-packages/tensorflow/python/platform/resource_loader.py", line 118, in get_path_to_datafile
new_fpath = r.Rlocation(
^^^^^^^^^^^
AttributeError: 'NoneType' object has no attribute 'Rlocation'
```
| stat:awaiting tensorflower,type:build/install,subtype: ubuntu/linux,2.17 | low | Critical |
2,511,282,991 | flutter | [go_router] Expose routingConfig / similar via go_router | ### Use case
I am building a navigation tree for an app with dynamic routing with `GoRouter.routingConfig(routingConfig: myRoutingConfig)`. I would like to be able to rebuild the tree in response to config changes. I can do this by maintaining the reference to `myRoutingConfig`, but I usually need access to both it and the router, and passing both around the tree leads to a lot of duplication.
Given that `_routingConfig` is stored privately in an unmodified state on the `router` anyway, is there a reason why this cannot be made accessible?
### Proposal
Add a getter to `GoRouter` and/or `RouteConfiguration` that returns `routingConfig`.
```dart
ValueListenable<RoutingConfig> get routingConfig => _routingConfig;
``` | c: new feature,package,c: proposal,P3,p: go_router,team-go_router,triaged-go_router | low | Minor |
2,511,299,497 | vscode | ctrl+z / ctrl+shift+z (undo/redo) not working for input elements when a custom editor is open | <!-- ⚠️⚠️ Do Not Delete This! bug_report_template ⚠️⚠️ -->
<!-- Please read our Rules of Conduct: https://opensource.microsoft.com/codeofconduct/ -->
<!-- 🕮 Read our guide about submitting issues: https://github.com/microsoft/vscode/wiki/Submitting-Bugs-and-Suggestions -->
<!-- 🔎 Search existing issues to avoid creating duplicates. -->
<!-- 🧪 Test using the latest Insiders build to see if your issue has already been fixed: https://code.visualstudio.com/insiders/ -->
<!-- 💡 Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. -->
<!-- 🔧 Launch with `code --disable-extensions` to check. -->
Does this issue occur when all extensions are disabled?: Yes (affects extension authoring)
<!-- 🪓 If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. -->
<!-- 📣 Issues caused by an extension need to be reported directly to the extension publisher. The 'Help > Report Issue' dialog can assist with this. -->
- VS Code Version: 1.94.0-insider
- OS Version: Mac Sonoma 14.6.1
Steps to Reproduce:
1. Modify [webview-view-sample](https://github.com/microsoft/vscode-extension-samples/tree/main/webview-view-sample)'s webview HTML to include an `<input>` element
2. Compile and package the webview extension (will need to modify the publisher tag), then install it locally
3. Compile and run the [custom-editor-sample](https://github.com/microsoft/vscode-extension-samples/tree/main/custom-editor-sample)
4. Open the calico colors webview view
<img width="619" alt="image" src="https://github.com/user-attachments/assets/6bee098a-29a9-47c9-93c1-452bdfdcd5c0">
5. Observe that when no custom editors are open, the ctrl+z / ctrl+shift+z events work
6. Open the custom editor
<img width="605" alt="image" src="https://github.com/user-attachments/assets/8e34241e-13b6-4dee-a002-283b658971d6">
7. Observe that the undo/redo hotkeys no longer work in the webview view
| bug,help wanted,custom-editors | low | Critical |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.