id
int64
393k
2.82B
repo
stringclasses
68 values
title
stringlengths
1
936
body
stringlengths
0
256k
labels
stringlengths
2
508
priority
stringclasses
3 values
severity
stringclasses
3 values
2,515,128,909
PowerToys
Workspaces does not detect NVIDIA Broadcast
### Microsoft PowerToys version 0.84.1 ### Installation method PowerToys auto-update, WinGet ### Running as admin Yes ### Area(s) with issue? Workspaces ### Steps to reproduce 1. Open Workspace Editor 2. "Create Workspace" 3. Have NVIDIA Broadcast open 4. Hit "Capture" ### ✔️ Expected Behavior See NVIDIA Broadcast on the Workspace Screen 1 list ### ❌ Actual Behavior App not found in the list ### Other Software NVIDIA Broadcast v1.4.0.29
Issue-Bug,Needs-Triage,Product-Workspaces
low
Minor
2,515,216,603
stable-diffusion-webui
[Bug]: Final render not generated
### Checklist - [ ] The issue exists after disabling all extensions - [ ] The issue exists on a clean installation of webui - [ ] The issue is caused by an extension, but I believe it is caused by a bug in the webui - [ ] The issue exists in the current version of the webui - [ ] The issue has not been reported before recently - [ ] The issue has been reported before but has not been fixed yet ### What happened? I see the live preview images. The final render doesn't show up, the image sections just becomes empty. ### Steps to reproduce the problem Any prompt and just generate ### What should have happened? The final image should have rendered ### What browsers do you use to access the UI ? Brave ### Sysinfo [sysinfo-2024-09-10-01-26.json](https://github.com/user-attachments/files/16938149/sysinfo-2024-09-10-01-26.json) ### Console logs ```Shell (sd) root@newphobos:/dockerx/stable-diffusion-webui# REQS_FILE='requirements.txt' python launch.py --upcast-sampling --skip-torch-cuda-test --listen Python 3.10.6 (main, Oct 24 2022, 16:07:47) [GCC 11.2.0] Version: v1.10.1 Commit hash: 82a973c04367123ae98bd9abdf80d9eda9b910e2 Launching Web UI with arguments: --upcast-sampling --skip-torch-cuda-test --listen /opt/conda/envs/sd/lib/python3.10/site-packages/kornia/feature/lightglue.py:44: FutureWarning: `torch.cuda.amp.custom_fwd(args...)` is deprecated. Please use `torch.amp.custom_fwd(args..., device_type='cuda')` instead. @torch.cuda.amp.custom_fwd(cast_inputs=torch.float32) WARNING:xformers:WARNING[XFORMERS]: xFormers can't load C++/CUDA extensions. xFormers was built for: PyTorch 2.1.2+cu121 with CUDA 1201 (you have 2.4.1+rocm6.1) Python 3.10.13 (you have 3.10.6) Please reinstall xformers (see https://github.com/facebookresearch/xformers#installing-xformers) Memory-efficient attention, SwiGLU, sparse and more won't be available. Set XFORMERS_MORE_DETAILS=1 for more details /opt/conda/envs/sd/lib/python3.10/site-packages/xformers/triton/softmax.py:30: FutureWarning: `torch.cuda.amp.custom_fwd(args...)` is deprecated. Please use `torch.amp.custom_fwd(args..., device_type='cuda')` instead. @custom_fwd(cast_inputs=torch.float16 if _triton_softmax_fp16_enabled else None) /opt/conda/envs/sd/lib/python3.10/site-packages/xformers/triton/softmax.py:87: FutureWarning: `torch.cuda.amp.custom_bwd(args...)` is deprecated. Please use `torch.amp.custom_bwd(args..., device_type='cuda')` instead. def backward( /opt/conda/envs/sd/lib/python3.10/site-packages/xformers/ops/swiglu_op.py:107: FutureWarning: `torch.cuda.amp.custom_fwd(args...)` is deprecated. Please use `torch.amp.custom_fwd(args..., device_type='cuda')` instead. def forward(cls, ctx, x, w1, b1, w2, b2, w3, b3): /opt/conda/envs/sd/lib/python3.10/site-packages/xformers/ops/swiglu_op.py:128: FutureWarning: `torch.cuda.amp.custom_bwd(args...)` is deprecated. Please use `torch.amp.custom_bwd(args..., device_type='cuda')` instead. def backward(cls, ctx, dx5): No module 'xformers'. Proceeding without it. Pytorch_lightning.distributed not found, attempting pytorch_lightning.rank_zero Loading weights [e6bb9ea85b] from /dockerx/stable-diffusion-webui/models/Stable-diffusion/sdXL_v10VAEFix.safetensors Running on local URL: http://0.0.0.0:7860 Thanks for being a Gradio user! If you have questions or feedback, please join our Discord server and chat with us: https://discord.gg/feTf9x3ZSB To create a public link, set `share=True` in `launch()`. Startup time: 6.1s (import torch: 1.7s, import gradio: 0.4s, setup paths: 3.1s, other imports: 0.4s, load scripts: 0.2s, create ui: 0.2s). Creating model from config: /dockerx/stable-diffusion-webui/repositories/generative-models/configs/inference/sd_xl_base.yaml /opt/conda/envs/sd/lib/python3.10/site-packages/huggingface_hub/file_download.py:1150: FutureWarning: `resume_download` is deprecated and will be removed in version 1.0.0. Downloads always resume when possible. If you want to force a new download, use `force_download=True`. warnings.warn( Applying attention optimization: Doggettx... done. Model loaded in 4.2s (load weights from disk: 0.5s, create model: 0.2s, apply weights to model: 3.2s, calculate empty prompt: 0.2s). 100%|██████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████| 20/20 [00:04<00:00, 4.69it/s] *** Error completing request███████████████████████████████████████████████████████████████████████████████████████████████████████████████| 20/20 [00:02<00:00, 9.20it/s] *** Arguments: ('task(akdfrcyzf4tbv7y)', <gradio.routes.Request object at 0x7fe3b7fbf880>, 'cat', '', [], 1, 1, 7, 512, 512, False, 0.7, 2, 'Latent', 0, 0, 0, 'Use same checkpoint', 'Use same sampler', 'Use same scheduler', '', '', [], 0, 20, 'DPM++ 2M', 'Automatic', False, '', 0.8, -1, False, -1, 0, 0, 0, False, False, 'positive', 'comma', 0, False, False, 'start', '', 1, '', [], 0, '', [], 0, '', [], True, False, False, False, False, False, False, 0, False) {} Traceback (most recent call last): File "/dockerx/stable-diffusion-webui/modules/call_queue.py", line 74, in f res = list(func(*args, **kwargs)) File "/dockerx/stable-diffusion-webui/modules/call_queue.py", line 53, in f res = func(*args, **kwargs) File "/dockerx/stable-diffusion-webui/modules/call_queue.py", line 37, in f res = func(*args, **kwargs) File "/dockerx/stable-diffusion-webui/modules/txt2img.py", line 109, in txt2img processed = processing.process_images(p) File "/dockerx/stable-diffusion-webui/modules/processing.py", line 847, in process_images res = process_images_inner(p) File "/dockerx/stable-diffusion-webui/modules/processing.py", line 1002, in process_images_inner x_samples_ddim = decode_latent_batch(p.sd_model, samples_ddim, target_device=devices.cpu, check_for_nans=True) File "/dockerx/stable-diffusion-webui/modules/processing.py", line 650, in decode_latent_batch raise e File "/dockerx/stable-diffusion-webui/modules/processing.py", line 637, in decode_latent_batch devices.test_for_nans(sample, "vae") File "/dockerx/stable-diffusion-webui/modules/devices.py", line 265, in test_for_nans raise NansException(message) modules.devices.NansException: A tensor with NaNs was produced in VAE. This could be because there's not enough precision to represent the picture. Try adding --no-half-vae commandline argument to fix this. Use --disable-nan-check commandline argument to disable this check. --- ``` ### Additional information A couple things of importance. 1. My command line with the above output was `REQS_FILE='requirements.txt' python launch.py --upcast-sampling --skip-torch-cuda-test --listen` 1.1 That error is gone when i append `--no-half-vae` 2. If i set my resolution at 512x512 the final image is rendered. 3. If i set the resolution to 1024x1024 **no final image is rendered** 4. GPU AMD 7900XT
bug-report
low
Critical
2,515,219,379
rust
1.81.0 not panic when running incorrect implementations of Ord
`<!--` Thank you for filing a bug report! 🐛 Please provide a short summary of the bug, along with any information you feel relevant to replicating the bug. --> I tried this code by running `rustup run 1.81.0 cargo run`: ```rust use std::cmp::Ordering; #[derive(Debug)] struct BadOrd(i32); impl PartialEq for BadOrd { fn eq(&self, other: &Self) -> bool { // Intentionally inconsistent equality self.0 % 2 == other.0 % 2 } } impl Eq for BadOrd {} impl PartialOrd for BadOrd { fn partial_cmp(&self, other: &Self) -> Option<Ordering> { // Violates consistency, transitivity, and duality if self.0 % 2 == 0 && other.0 % 2 != 0 { Some(Ordering::Less) } else if self.0 % 2 != 0 && other.0 % 2 == 0 { Some(Ordering::Greater) } else if self.0 == other.0 { Some(Ordering::Equal) } else { None } } } impl Ord for BadOrd { fn cmp(&self, other: &Self) -> Ordering { // Inconsistent with PartialOrd and violates total ordering if self.0 < other.0 { Ordering::Greater } else if self.0 > other.0 { Ordering::Less } else { Ordering::Equal } } } fn main() { let mut vec = vec![BadOrd(3), BadOrd(2), BadOrd(4), BadOrd(1)]; println!("Before sorting: {:?}", vec); vec.sort(); // This will likely panic due to inconsistent ordering println!("After sorting: {:?}", vec); // These assertions will fail, demonstrating incorrect ordering assert!(BadOrd(1) < BadOrd(2)); assert!(BadOrd(2) > BadOrd(1)); assert!(BadOrd(2) == BadOrd(2)); println!("All assertions passed!"); } ``` I expected to see this happen: *explanation* The program would panic on the line "vec.sort();" since "the new sort algorithms try to detect incorrect implementations of Ord that prevent them from being able to produce a meaningfully sorted result, and will now panic on such cases rather than returning effectively randomly arranged data.", according to the "New sort implementations" in https://blog.rust-lang.org/2024/09/05/Rust-1.81.0.html. Instead, this happened: *explanation* The program paniced on the line "assert!(BadOrd(1) < BadOrd(2));". Here is the output: Before sorting: [BadOrd(3), BadOrd(2), BadOrd(4), BadOrd(1)] After sorting: [BadOrd(2), BadOrd(4), BadOrd(3), BadOrd(1)] thread 'main' panicked at src/main.rs:53:5: assertion failed: BadOrd(1) < BadOrd(2) note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace ### Meta <!-- If you're using the stable version of the compiler, you should also check if the bug also exists in the beta or nightly versions. --> `rustc --version --verbose`: ``` rustc 1.81.0 (eeb90cda1 2024-09-04) binary: rustc commit-hash: eeb90cda1969383f56a2637cbd3037bdf598841c commit-date: 2024-09-04 host: aarch64-apple-darwin release: 1.81.0 LLVM version: 18.1.7 rustc 1.82.0-beta.2 (c7c49f44a 2024-09-04) binary: rustc commit-hash: c7c49f44a7bb561dd9317e14908a1e50fa478ce5 commit-date: 2024-09-04 host: aarch64-apple-darwin release: 1.82.0-beta.2 LLVM version: 19.1.0 rustc 1.83.0-nightly (c2f74c3f9 2024-09-09) binary: rustc commit-hash: c2f74c3f928aeb503f15b4e9ef5778e77f3058b8 commit-date: 2024-09-09 host: aarch64-apple-darwin release: 1.83.0-nightly LLVM version: 19.1.0 ``` <!-- Include a backtrace in the code block by setting `RUST_BACKTRACE=1` in your environment. E.g. `RUST_BACKTRACE=1 cargo build`. --> <details><summary>Backtrace</summary> <p> ``` RUST_BACKTRACE=1 rustup run 1.81.0 cargo run Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.16s Running `target/debug/new_sort_implementations_in_1_81_0_stable_rust` Before sorting: [BadOrd(3), BadOrd(2), BadOrd(4), BadOrd(1)] After sorting: [BadOrd(2), BadOrd(4), BadOrd(3), BadOrd(1)] thread 'main' panicked at src/main.rs:53:5: assertion failed: BadOrd(1) < BadOrd(2) stack backtrace: 0: rust_begin_unwind at /rustc/eeb90cda1969383f56a2637cbd3037bdf598841c/library/std/src/panicking.rs:665:5 1: core::panicking::panic_fmt at /rustc/eeb90cda1969383f56a2637cbd3037bdf598841c/library/core/src/panicking.rs:74:14 2: core::panicking::panic at /rustc/eeb90cda1969383f56a2637cbd3037bdf598841c/library/core/src/panicking.rs:148:5 3: new_sort_implementations_in_1_81_0_stable_rust::main at ./src/main.rs:53:5 4: core::ops::function::FnOnce::call_once at /rustc/eeb90cda1969383f56a2637cbd3037bdf598841c/library/core/src/ops/function.rs:250:5 note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace. ``` </p> </details>
T-libs,C-discussion
low
Critical
2,515,238,741
godot
[3.6] Setting OBJ to use .material file only works after manually re-importing.
### Tested versions - Reproducible in: 3.6 - Not reproducible in: 3.5.3 ### System information Linux Mint 22 ### Issue description For some reason starting from Godot 3.6, when an .obj file is imported as a scene, even if in the import options it is specified that there should be a separate .material file, the first time it is imported the .scn that is generated has the material built-in, and it does not reference the .material file *even though it exists*. Only after the .obj file is manually re-imported (or the `.import` folder is manually deleted), does the generated .scn file reference the .material file. This behaviour is affecting the output of `ResourceLoader.get_dependencies`, which is how I found this issue. Any help in figuring out what changed between 3.5.3 and 3.6 would be greatly appreciated! ### Steps to reproduce 1. Open the project. The .obj file should be imported as a mesh. 2. Switch the .obj file from being imported as a mesh, to being imported as a scene. 3. Restart the editor as prompted. 4. Once the editor is back, run the scene. The output shows an empty array `[]`, when it should be `[res://red_mat.material]`. 5. Manually re-import the .obj file, and run the scene again. Now the output is `[res://red_mat.material]`, as expected. ### Minimal reproduction project (MRP) [DependencyBug.zip](https://github.com/user-attachments/files/16938275/DependencyBug.zip)
bug,topic:core,regression
low
Critical
2,515,242,974
vscode
VS Code Installer Will Not Run as Administrator (System-Wide Install\All User Install) on Windows 11 24H2
<!-- ⚠️⚠️ Do Not Delete This! bug_report_template ⚠️⚠️ --> <!-- Please read our Rules of Conduct: https://opensource.microsoft.com/codeofconduct/ --> <!-- 🕮 Read our guide about submitting issues: https://github.com/microsoft/vscode/wiki/Submitting-Bugs-and-Suggestions --> <!-- 🔎 Search existing issues to avoid creating duplicates. --> <!-- 🧪 Test using the latest Insiders build to see if your issue has already been fixed: https://code.visualstudio.com/insiders/ --> <!-- 💡 Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --> <!-- 🔧 Launch with `code --disable-extensions` to check. --> Does this issue occur when all extensions are disabled?: Not Applicable (NA) <!-- 🪓 If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --> <!-- 📣 Issues caused by an extension need to be reported directly to the extension publisher. The 'Help > Report Issue' dialog can assist with this. --> - VS Code Version: 1.93, 192.2, 192.1, and earlier - OS Version: Windows 11 24H2 Steps to Reproduce: 1. Download VS Code 1.93, 192.2, 192.1, or earlier version installer 2. Right-Click > Run as Administrator 3. The installer will not Run as Administrator and generates a notification to the user to go to VS Code download page to download the "System Installer version of VS Code" ![image](https://github.com/user-attachments/assets/4ffc915b-366e-4efb-bdb5-4e63a0ec45e2) W̵̶̵h̵̶̵e̵̶̵r̵̶̵e̵̶̵ ̵̶̵i̵̶̵s̵̶̵ ̵̶̵t̵̶̵h̵̶̵e̵̶̵ ̵̶̵S̵̶̵y̵̶̵s̵̶̵t̵̶̵e̵̶̵m̵̶̵-̵̶̵W̵̶̵i̵̶̵d̵̶̵e̵̶̵ ̵̶̵(̵̶̵A̵̶̵l̵̶̵l̵̶̵ ̵̶̵U̵̶̵s̵̶̵e̵̶̵r̵̶̵s̵̶̵)̵̶̵ ̵̶̵i̵̶̵n̵̶̵s̵̶̵t̵̶̵a̵̶̵l̵̶̵l̵̶̵e̵̶̵r̵̶̵ ̵̶̵v̵̶̵e̵̶̵r̵̶̵s̵̶̵i̵̶̵o̵̶̵n̵̶̵ ̵̶̵o̵̶̵f̵̶̵ ̵̶̵V̵̶̵S̵̶̵ ̵̶̵C̵̶̵o̵̶̵d̵̶̵e̵̶̵?̵̶̵ (SOLVED) Where is the .msi installer for VS Code for enterprise deployments?
bug,install-update,windows
low
Critical
2,515,255,939
vscode
Cannot debug my extension, reaches breakpoint but hangs there.
<!-- ⚠️⚠️ Do Not Delete This! bug_report_template ⚠️⚠️ --> <!-- Please read our Rules of Conduct: https://opensource.microsoft.com/codeofconduct/ --> <!-- 🕮 Read our guide about submitting issues: https://github.com/microsoft/vscode/wiki/Submitting-Bugs-and-Suggestions --> <!-- 🔎 Search existing issues to avoid creating duplicates. --> <!-- 🧪 Test using the latest Insiders build to see if your issue has already been fixed: https://code.visualstudio.com/insiders/ --> <!-- 💡 Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --> <!-- 🔧 Launch with `code --disable-extensions` to check. --> Does this issue occur when all extensions are disabled?: Yes/No <!-- 🪓 If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --> <!-- 📣 Issues caused by an extension need to be reported directly to the extension publisher. The 'Help > Report Issue' dialog can assist with this. --> - Version: 1.93.0 (user setup) Commit: 4849ca9bdf9666755eb463db297b69e5385090e3 Date: 2024-09-04T13:02:38.431Z Electron: 30.4.0 ElectronBuildId: 10073054 Chromium: 124.0.6367.243 Node.js: 20.15.1 V8: 12.4.254.20-electron.0 OS: Windows_NT x64 10.0.19045 Steps to Reproduce: I'm developing an extension, I've noticed lately that when I set a breakpoint, it reaches the breakpoint but the js-debugger crashes. I'm getting this message in the window output : **[warning] UNRESPONSIVE extension host: 'ms-vscode.js-debug' took 100% of 5017.177ms, saved PROFILE here: 'file:///c%3A/Users/felix/AppData/Local/Temp/exthost-b274d0.cpuprofile'** Here's the profile zipped: [exthost-b274d0.zip](https://github.com/user-attachments/files/16938495/exthost-b274d0.zip) Here's a screenshot: ![image](https://github.com/user-attachments/assets/ec87e731-7b61-4318-bc4b-d5ec42e92a57)
bug,debug
low
Critical
2,515,266,349
kubernetes
Need better conntrack management for UDP services (especially DNS)
### What happened? I created deployments with hostname, subdomain and headless service. I had the pods query their DNS records and log the results. It typically took ~30 seconds for name resolution to be correct, though in some cases it could be much faster. Name resolution seems to fail occasionally returning NXDOMAIN. When the pod is deleted and recreated results are similar though the previous A record may also be returned. I initially ran very short duration tests that stopped after observing a single intermittent failure. I later ran some longer duration tests and observed that these intermittent failures continue to occur and vary in duration. ### First are some results of short duration tests after creating resources with reproducer-1.yml Fairly typical, took ~30 seconds for initial successful response. ``` + kubectl -n name-space logs --timestamps pod/example-9-85b9cf77c4-74dpb 2024-09-09T23:05:14.821639151Z ip address: 10.244.0.165 2024-09-09T23:05:46.613337669Z 10.244.0.165 example-9.headless.name-space.svc.cluster.local example-9.headless.name-space.svc.cluster.local example-9.headless 2024-09-09T23:05:46.613549795Z success 2024-09-09T23:06:45.000865071Z 10.244.0.165 example-9.headless.name-space.svc.cluster.local example-9.headless.name-space.svc.cluster.local example-9.headless 2024-09-09T23:06:45.001438197Z done ``` Note the intermittent failure nearly ~30 seconds after the pod started: ``` + kubectl -n name-space logs --timestamps pod/example-46-5f88d64f8f-fkkmf 2024-09-09T23:05:26.142870309Z ip address: 10.244.0.205 2024-09-09T23:05:56.156259513Z 10.244.0.205 example-46.headless.name-space.svc.cluster.local example-46.headless.name-space.svc.cluster.local example-46.headless 2024-09-09T23:05:56.156283138Z success 2024-09-09T23:05:56.159916727Z failure 2024-09-09T23:05:56.166636988Z 10.244.0.205 example-46.headless.name-space.svc.cluster.local example-46.headless.name-space.svc.cluster.local example-46.headless 2024-09-09T23:05:56.166718155Z success 2024-09-09T23:05:56.166743405Z done ``` Note the intermittent failure nearly ~60 seconds after the pod started: ``` + kubectl -n name-space logs --timestamps pod/example-8-7d65cf6595-5kgm8 2024-09-09T23:05:15.292906336Z ip address: 10.244.0.164 2024-09-09T23:05:45.299029486Z 10.244.0.164 example-8.headless.name-space.svc.cluster.local example-8.headless.name-space.svc.cluster.local example-8.headless 2024-09-09T23:05:45.299171153Z success 2024-09-09T23:06:12.934370064Z 10.244.0.164 example-8.headless.name-space.svc.cluster.local example-8.headless.name-space.svc.cluster.local example-8.headless 2024-09-09T23:06:12.934805231Z failure 2024-09-09T23:06:12.935585357Z 10.244.0.164 example-8.headless.name-space.svc.cluster.local example-8.headless.name-space.svc.cluster.local example-8.headless 2024-09-09T23:06:12.935622357Z success 2024-09-09T23:06:12.935626232Z done ``` Correct name resolution nearly ten times faster then the typical ~30 seconds. ``` + kubectl -n name-space logs --timestamps pod/example-50-5d7bd9f7dd-ldm9z 2024-09-09T23:05:25.994666234Z ip address: 10.244.0.203 2024-09-09T23:05:28.507822913Z 10.244.0.203 example-50.headless.name-space.svc.cluster.local example-50.headless.name-space.svc.cluster.local example-50.headless 2024-09-09T23:05:28.507850872Z success 2024-09-09T23:05:28.512090337Z failure 2024-09-09T23:05:28.517020845Z 10.244.0.203 example-50.headless.name-space.svc.cluster.local example-50.headless.name-space.svc.cluster.local example-50.headless 2024-09-09T23:05:28.517073470Z success 2024-09-09T23:05:28.517076387Z done ``` ### Next are some short duration examples after deleting the pod created with reproducer-1.yml Resolved to previous IP address until ~30 seconds when name resolution become correct. ``` + kubectl -n name-space logs --timestamps pod/example-32-94f578796-ggr5r 2024-09-09T23:28:58.365987901Z ip address: 10.244.0.189 2024-09-09T23:28:58.366879902Z 10.244.0.135 example-32.headless.name-space.svc.cluster.local example-32.headless.name-space.svc.cluster.local example-32.headless 2024-09-09T23:28:58.366941985Z success 2024-09-09T23:29:28.372333094Z 10.244.0.135 example-32.headless.name-space.svc.cluster.local example-32.headless.name-space.svc.cluster.local example-32.headless 2024-09-09T23:30:29.538217372Z 10.244.0.189 example-32.headless.name-space.svc.cluster.local example-32.headless.name-space.svc.cluster.local example-32.headless 2024-09-09T23:30:29.540434333Z done ``` In this case name resolution failed briefly ~90 seconds after pod started. ``` + kubectl -n name-space logs --timestamps pod/example-33-5c94568945-zwhk8 2024-09-09T23:28:56.224260600Z ip address: 10.244.0.177 2024-09-09T23:28:56.225344685Z 10.244.0.136 example-33.headless.name-space.svc.cluster.local example-33.headless.name-space.svc.cluster.local example-33.headless 2024-09-09T23:28:56.225403852Z success 2024-09-09T23:29:26.229834542Z 10.244.0.136 example-33.headless.name-space.svc.cluster.local example-33.headless.name-space.svc.cluster.local example-33.headless 2024-09-09T23:30:22.876064342Z 10.244.0.177 example-33.headless.name-space.svc.cluster.local example-33.headless.name-space.svc.cluster.local example-33.headless 2024-09-09T23:30:22.878206470Z failure 2024-09-09T23:30:22.881135099Z 10.244.0.177 example-33.headless.name-space.svc.cluster.local example-33.headless.name-space.svc.cluster.local example-33.headless 2024-09-09T23:30:22.881363766Z success 2024-09-09T23:30:22.881381516Z done ``` Here name resolution alternated between the old & new address, and failed briefly before correctly providing new address. ``` + kubectl -n name-space logs --timestamps pod/example-34-5f8cdcc9bb-zp2xj 2024-09-09T23:28:56.311666142Z ip address: 10.244.0.178 2024-09-09T23:28:58.814520539Z 10.244.0.178 example-34.headless.name-space.svc.cluster.local example-34.headless.name-space.svc.cluster.local example-34.headless 2024-09-09T23:28:58.814552873Z success 2024-09-09T23:28:58.816665626Z 10.244.0.178 example-34.headless.name-space.svc.cluster.local example-34.headless.name-space.svc.cluster.local example-34.headless 2024-09-09T23:28:58.845242167Z 10.244.0.146 example-34.headless.name-space.svc.cluster.local example-34.headless.name-space.svc.cluster.local example-34.headless 2024-09-09T23:28:58.845250417Z 10.244.0.178 example-34.headless.name-space.svc.cluster.local example-34.headless.name-space.svc.cluster.local example-34.headless 2024-09-09T23:28:58.845252042Z 10.244.0.146 example-34.headless.name-space.svc.cluster.local example-34.headless.name-space.svc.cluster.local example-34.headless 2024-09-09T23:28:58.845253708Z 10.244.0.178 example-34.headless.name-space.svc.cluster.local example-34.headless.name-space.svc.cluster.local example-34.headless 2024-09-09T23:28:58.845255333Z 10.244.0.146 example-34.headless.name-space.svc.cluster.local example-34.headless.name-space.svc.cluster.local example-34.headless 2024-09-09T23:28:58.845256750Z 10.244.0.178 example-34.headless.name-space.svc.cluster.local example-34.headless.name-space.svc.cluster.local example-34.headless 2024-09-09T23:28:58.845258125Z 10.244.0.146 example-34.headless.name-space.svc.cluster.local example-34.headless.name-space.svc.cluster.local example-34.headless 2024-09-09T23:29:03.874183954Z 10.244.0.178 example-34.headless.name-space.svc.cluster.local example-34.headless.name-space.svc.cluster.local example-34.headless 2024-09-09T23:29:03.874214370Z 10.244.0.146 example-34.headless.name-space.svc.cluster.local example-34.headless.name-space.svc.cluster.local example-34.headless 2024-09-09T23:29:03.874216745Z 10.244.0.178 example-34.headless.name-space.svc.cluster.local example-34.headless.name-space.svc.cluster.local example-34.headless 2024-09-09T23:29:03.874218495Z 10.244.0.146 example-34.headless.name-space.svc.cluster.local example-34.headless.name-space.svc.cluster.local example-34.headless ... 2024-09-09T23:29:28.801997330Z 10.244.0.178 example-34.headless.name-space.svc.cluster.local example-34.headless.name-space.svc.cluster.local example-34.headless 2024-09-09T23:29:28.801998872Z 10.244.0.146 example-34.headless.name-space.svc.cluster.local example-34.headless.name-space.svc.cluster.local example-34.headless 2024-09-09T23:29:28.802000372Z 10.244.0.178 example-34.headless.name-space.svc.cluster.local example-34.headless.name-space.svc.cluster.local example-34.headless 2024-09-09T23:29:28.802001830Z 10.244.0.146 example-34.headless.name-space.svc.cluster.local example-34.headless.name-space.svc.cluster.local example-34.headless 2024-09-09T23:30:04.697987578Z 10.244.0.178 example-34.headless.name-space.svc.cluster.local example-34.headless.name-space.svc.cluster.local example-34.headless 2024-09-09T23:30:04.698009453Z 10.244.0.146 example-34.headless.name-space.svc.cluster.local example-34.headless.name-space.svc.cluster.local example-34.headless 2024-09-09T23:30:04.698011870Z 10.244.0.178 example-34.headless.name-space.svc.cluster.local example-34.headless.name-space.svc.cluster.local example-34.headless 2024-09-09T23:30:04.698013661Z 10.244.0.146 example-34.headless.name-space.svc.cluster.local example-34.headless.name-space.svc.cluster.local example-34.headless 2024-09-09T23:30:04.698017411Z 10.244.0.178 example-34.headless.name-space.svc.cluster.local example-34.headless.name-space.svc.cluster.local example-34.headless 2024-09-09T23:30:04.699209288Z failure 2024-09-09T23:30:04.701096499Z 10.244.0.178 example-34.headless.name-space.svc.cluster.local example-34.headless.name-space.svc.cluster.local example-34.headless 2024-09-09T23:30:04.701108082Z success 2024-09-09T23:30:04.701110207Z done ``` ### Finally an example of a longer duration test with reproducer-2.yml Failures continue to occur and there appears to be a failure lasting ~5 seconds from 00:58:06-00:58:11. ``` + kubectl -n name-space logs --timestamps pod/example-44-7b4c6db795-jnpx4 2024-09-10T00:53:45.606690224Z ip address: 10.244.0.148 2024-09-10T00:54:15.645760871Z 10.244.0.148 example-44.headless.name-space.svc.cluster.local example-44.headless.name-space.svc.cluster.local example-44.headless 2024-09-10T00:54:15.645830788Z success 2024-09-10T00:54:21.547652384Z 10.244.0.148 example-44.headless.name-space.svc.cluster.local example-44.headless.name-space.svc.cluster.local example-44.headless 2024-09-10T00:54:21.549761139Z failure 2024-09-10T00:54:21.551739643Z 10.244.0.148 example-44.headless.name-space.svc.cluster.local example-44.headless.name-space.svc.cluster.local example-44.headless 2024-09-10T00:54:21.551747935Z success 2024-09-10T00:55:08.732400872Z 10.244.0.148 example-44.headless.name-space.svc.cluster.local example-44.headless.name-space.svc.cluster.local example-44.headless 2024-09-10T00:55:08.733033040Z failure 2024-09-10T00:55:08.733892585Z 10.244.0.148 example-44.headless.name-space.svc.cluster.local example-44.headless.name-space.svc.cluster.local example-44.headless 2024-09-10T00:55:08.733955002Z success 2024-09-10T00:55:13.974409562Z 10.244.0.148 example-44.headless.name-space.svc.cluster.local example-44.headless.name-space.svc.cluster.local example-44.headless 2024-09-10T00:55:13.974909230Z failure 2024-09-10T00:55:13.975787899Z 10.244.0.148 example-44.headless.name-space.svc.cluster.local example-44.headless.name-space.svc.cluster.local example-44.headless 2024-09-10T00:55:13.975875275Z success 2024-09-10T00:55:19.037338608Z 10.244.0.148 example-44.headless.name-space.svc.cluster.local example-44.headless.name-space.svc.cluster.local example-44.headless 2024-09-10T00:55:19.037842693Z failure 2024-09-10T00:55:19.038832488Z 10.244.0.148 example-44.headless.name-space.svc.cluster.local example-44.headless.name-space.svc.cluster.local example-44.headless 2024-09-10T00:55:19.038843155Z success 2024-09-10T00:55:29.117418683Z 10.244.0.148 example-44.headless.name-space.svc.cluster.local example-44.headless.name-space.svc.cluster.local example-44.headless 2024-09-10T00:55:29.117966018Z failure 2024-09-10T00:55:29.118763229Z 10.244.0.148 example-44.headless.name-space.svc.cluster.local example-44.headless.name-space.svc.cluster.local example-44.headless 2024-09-10T00:55:29.118802687Z success 2024-09-10T00:55:44.373593325Z 10.244.0.148 example-44.headless.name-space.svc.cluster.local example-44.headless.name-space.svc.cluster.local example-44.headless 2024-09-10T00:55:44.374101410Z failure 2024-09-10T00:55:44.374768245Z 10.244.0.148 example-44.headless.name-space.svc.cluster.local example-44.headless.name-space.svc.cluster.local example-44.headless 2024-09-10T00:55:44.374816787Z success 2024-09-10T00:57:10.127070908Z 10.244.0.148 example-44.headless.name-space.svc.cluster.local example-44.headless.name-space.svc.cluster.local example-44.headless 2024-09-10T00:57:10.128437322Z failure 2024-09-10T00:57:10.133007897Z 10.244.0.148 example-44.headless.name-space.svc.cluster.local example-44.headless.name-space.svc.cluster.local example-44.headless 2024-09-10T00:57:10.134041104Z success 2024-09-10T00:57:51.941566804Z 10.244.0.148 example-44.headless.name-space.svc.cluster.local example-44.headless.name-space.svc.cluster.local example-44.headless 2024-09-10T00:57:51.941980888Z failure 2024-09-10T00:57:51.942865181Z 10.244.0.148 example-44.headless.name-space.svc.cluster.local example-44.headless.name-space.svc.cluster.local example-44.headless 2024-09-10T00:57:51.942923889Z success 2024-09-10T00:58:06.189370517Z 10.244.0.148 example-44.headless.name-space.svc.cluster.local example-44.headless.name-space.svc.cluster.local example-44.headless 2024-09-10T00:58:06.189968810Z failure 2024-09-10T00:58:11.194641064Z 10.244.0.148 example-44.headless.name-space.svc.cluster.local example-44.headless.name-space.svc.cluster.local example-44.headless 2024-09-10T00:58:11.194660897Z success 2024-09-10T00:58:31.853444367Z 10.244.0.148 example-44.headless.name-space.svc.cluster.local example-44.headless.name-space.svc.cluster.local example-44.headless 2024-09-10T00:58:31.854188701Z failure 2024-09-10T00:58:31.855070078Z 10.244.0.148 example-44.headless.name-space.svc.cluster.local example-44.headless.name-space.svc.cluster.local example-44.headless 2024-09-10T00:58:31.855520870Z success 2024-09-10T01:00:14.012500903Z 10.244.0.148 example-44.headless.name-space.svc.cluster.local example-44.headless.name-space.svc.cluster.local example-44.headless 2024-09-10T01:00:14.013042733Z failure 2024-09-10T01:00:14.014231435Z 10.244.0.148 example-44.headless.name-space.svc.cluster.local example-44.headless.name-space.svc.cluster.local example-44.headless 2024-09-10T01:00:14.014433351Z success 2024-09-10T01:00:25.099501939Z 10.244.0.148 example-44.headless.name-space.svc.cluster.local example-44.headless.name-space.svc.cluster.local example-44.headless 2024-09-10T01:00:25.100104894Z failure 2024-09-10T01:00:25.101076931Z 10.244.0.148 example-44.headless.name-space.svc.cluster.local example-44.headless.name-space.svc.cluster.local example-44.headless 2024-09-10T01:00:25.101219472Z success 2024-09-10T01:01:28.106594377Z 10.244.0.148 example-44.headless.name-space.svc.cluster.local example-44.headless.name-space.svc.cluster.local example-44.headless 2024-09-10T01:01:28.108120337Z failure 2024-09-10T01:01:28.109668172Z 10.244.0.148 example-44.headless.name-space.svc.cluster.local example-44.headless.name-space.svc.cluster.local example-44.headless 2024-09-10T01:01:28.109720922Z success 2024-09-10T01:01:47.173618917Z 10.244.0.148 example-44.headless.name-space.svc.cluster.local example-44.headless.name-space.svc.cluster.local example-44.headless 2024-09-10T01:01:47.176251003Z failure 2024-09-10T01:01:47.178596298Z 10.244.0.148 example-44.headless.name-space.svc.cluster.local example-44.headless.name-space.svc.cluster.local example-44.headless 2024-09-10T01:01:47.178728923Z success 2024-09-10T01:02:34.829412651Z 10.244.0.148 example-44.headless.name-space.svc.cluster.local example-44.headless.name-space.svc.cluster.local example-44.headless 2024-09-10T01:02:34.829895652Z failure 2024-09-10T01:02:34.831115611Z 10.244.0.148 example-44.headless.name-space.svc.cluster.local example-44.headless.name-space.svc.cluster.local example-44.headless 2024-09-10T01:02:34.831143778Z success 2024-09-10T01:02:45.651782651Z 10.244.0.148 example-44.headless.name-space.svc.cluster.local example-44.headless.name-space.svc.cluster.local example-44.headless 2024-09-10T01:02:45.652329402Z failure 2024-09-10T01:02:45.653055861Z 10.244.0.148 example-44.headless.name-space.svc.cluster.local example-44.headless.name-space.svc.cluster.local example-44.headless 2024-09-10T01:02:45.653182319Z success ``` ### What did you expect to happen? I expected that once name resolution provided the correct address it would not fail intermittently or subsequently return the wrong (old) address. It would also be nice if it were possible that name resolution could start sooner more often, and ideally never return the wrong (old) address. ### How can we reproduce it (as minimally and precisely as possible)? I initially used this configuration and script: [reproducer-1.yml.txt](https://github.com/user-attachments/files/16938125/reproducer-1.yml.txt) [script-1.sh.txt](https://github.com/user-attachments/files/16938127/script-1.sh.txt) The script above stopped after the first failure, to see more failures I used these: [reproducer-2.yml.txt](https://github.com/user-attachments/files/16938137/reproducer-2.yml.txt) [script-2.sh.txt](https://github.com/user-attachments/files/16938138/script-2.sh.txt) ### Anything else we need to know? This may be related to some existing issues. The mostly ~30 second delay: https://github.com/kubernetes/kubernetes/issues/92559 The intermittent failures: https://github.com/coredns/coredns/issues/6518 Assuming I need to workaround the intermittent failure, are there any downsides to modifying the hosts file directly (not through HostAliases) other than losing changes when the container exits? ### Kubernetes version <details> ```console $ kubectl version Client Version: v1.30.0 Kustomize Version: v5.0.4-0.20230601165947-6ce0bf390ce3 Server Version: v1.29.2 ``` </details> ### Cloud provider <details> kind version 0.22.0 </details> ### OS version <details> ```console # On Linux: $ cat /etc/os-release NAME="Fedora Linux" VERSION="40.20240529.0 (Silverblue)" ID=fedora VERSION_ID=40 VERSION_CODENAME="" PLATFORM_ID="platform:f40" PRETTY_NAME="Fedora Linux 40.20240529.0 (Silverblue)" ANSI_COLOR="0;38;2;60;110;180" LOGO=fedora-logo-icon CPE_NAME="cpe:/o:fedoraproject:fedora:40" DEFAULT_HOSTNAME="fedora" HOME_URL="https://silverblue.fedoraproject.org" DOCUMENTATION_URL="https://docs.fedoraproject.org/en-US/fedora-silverblue/" SUPPORT_URL="https://ask.fedoraproject.org/" BUG_REPORT_URL="https://github.com/fedora-silverblue/issue-tracker/issues" REDHAT_BUGZILLA_PRODUCT="Fedora" REDHAT_BUGZILLA_PRODUCT_VERSION=40 REDHAT_SUPPORT_PRODUCT="Fedora" REDHAT_SUPPORT_PRODUCT_VERSION=40 SUPPORT_END=2025-05-13 VARIANT="Silverblue" VARIANT_ID=silverblue OSTREE_VERSION='40.20240529.0' $ uname -a Linux fedora 6.8.10-300.fc40.aarch64 #1 SMP PREEMPT_DYNAMIC Fri May 17 21:52:12 UTC 2024 aarch64 GNU/Linux # On Windows: C:\> wmic os get Caption, Version, BuildNumber, OSArchitecture # paste output here ``` </details> ### Install tools <details> </details> ### Container runtime (CRI) and version (if applicable) <details> </details> ### Related plugins (CNI, CSI, ...) and versions (if applicable) <details> </details>
kind/bug,sig/network,triage/accepted
medium
Critical
2,515,283,123
rust
Inference poisoned by presence of unrelated impl
The following code [compiles fine](https://play.rust-lang.org/?version=stable&mode=debug&edition=2021&gist=3a6815ef3678a02f350920f8d8c9c43c): ```rust extern crate serde; use std::borrow::Cow; pub fn dothing<'data, V>( ) -> Cow<'data, V> where V: ?Sized + ToOwned , for<'de> Box<V>: serde::Deserialize<'de>, { unimplemented!() } pub fn dothing_str<'data>( ) -> Cow<'data, str> where { dothing() } ``` Here, `dothing_str()` simply uses return type inference to resolve `dothing()` to `dothing::<str>()`. Quite straightforward, nothing fancy. However, if you [add in the following type](https://play.rust-lang.org/?version=stable&mode=debug&edition=2021&gist=ff402807449ed1478d46a718779aa670), inference gets poisoned: ```rust pub struct Poison<T: ?Sized> { x: T } impl<'de, T> serde::Deserialize<'de> for Box<Poison<T>> where T: ?Sized, Box<T>: serde::Deserialize<'de>, { fn deserialize<D>(deserializer: D) -> Result<Self, D::Error> where D: serde::Deserializer<'de>, { unimplemented!() } } ``` Instead of trying to resolve `Box<str>: Deserialize` (reasonable), it tries to resolve `Box<Poison<Poison<Poison<Poison<Poison<Poison<Poison<Poison<Poison<Poison<Poison<Poison<...>>>>>>>>>>>>>: Deserialize`. Note that this happens even if you replace the `for<'de> ... Deserialize<'de>` with `Deserialize<'static>`, this isn't Yet Another HRTB issue. <details><summary>Full error</summary> ``` error[E0275]: overflow evaluating the requirement `Box<[_]>: Deserialize<'_>` --> src/lib.rs:37:5 | 37 | dothing() | ^^^^^^^^^ | = help: consider increasing the recursion limit by adding a `#![recursion_limit = "256"]` attribute to your crate (`playground`) note: required for `Box<Poison<[_]>>` to implement `Deserialize<'_>` --> src/lib.rs:9:14 | 9 | impl<'de, T> serde::Deserialize<'de> for Box<Poison<T>> | ^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^ ... 12 | Box<T>: serde::Deserialize<'de>, | ----------------------- unsatisfied trait bound introduced here = note: 126 redundant requirements hidden = note: required for `Box<Poison<Poison<Poison<Poison<Poison<Poison<Poison<Poison<Poison<Poison<Poison<Poison<...>>>>>>>>>>>>>` to implement `for<'de> Deserialize<'de>` note: required by a bound in `dothing` --> src/lib.rs:27:22 | 23 | pub fn dothing<'data, V>( | ------- required by a bound in this function ... 27 | for<'de> Box<V>: serde::Deserialize<'de>, | ^^^^^^^^^^^^^^^^^^^^^^^ required by this bound in `dothing` = note: the full name for the type has been written to '/playground/target/debug/deps/playground-dd3320ba655b84a9.long-type-390055455354675765.txt' = note: consider using `--verbose` to print the full type name to the console ``` </details> The poisoning is fixed by explicitly invoking `dothing::<str>()`. It's the return type inference that's getting grossly misled here, and it's really unclear as to why.
A-trait-system,fixed-by-next-solver
low
Critical
2,515,292,984
transformers
A Trainer subclass for Decoder-Only LM with generation in evaluate()
### Feature request The main feature request involves a New Trainer Subclass, similar to Seq2SeqTrainer, but suitable for Decoder-Only LM. ### Motivation `Seq2SeqTrainer` provides a great abstraction for Encoder-Decoder LM, when we need to conduct generation during `evaluate()` But the current implementation of both `Trainer` and `Seq2SeqTrainer` seems to be not suitable for Decoder-Only LM due to the difference of `input_ids` and `labels` between teacher-forcing training and generation-involved evaluation. For example in instruction tuning: - During training (teacher-forcing) ```python input_ids = 'Translation the following texts: {Text in Chinese...} {Text in English...}' labels = 'Translation the following texts: {Text in Chinese...} {Text in English...}' ``` - During evaluation ```python input_ids = 'Translation the following texts: {Text in Chinese...}' labels = '{Text in English...}' ``` So we need to prepare two kinds of inputs_ids during evaluation for calculation of both `loss` and `bleu_metrics`. It leads to different columns in eval_dataset. However, `Trainer._remove_unused_columns()` will remove columns for both `eval_dataset` and `train_dataset` not accepted by `model.forward()`. During training, this behaviour is expected (we only need the teacher-forcing inputs). But it will make evaluation difficult. This feature is nearly identical across all CausalLM models when performing generation during evaluation, making it highly reusable. Given the increasing number of Decoder-only LMs (CausalLMs) in the community, I strongly recommend implementing a dedicated CausalTrainer to simplify deployments. I may have missed something. If there is already a simpler way to customize such a Trainer, please let me know. ### Your contribution I'm willing to help submit a PR. But I'm not familiar with some integrations such as fsdp and deepspeed. I may need someone to help me finish this feature.
trainer,Feature request
low
Minor
2,515,297,870
flutter
Give `AppBar` a `Scaffold` dependency
Giving AppBar a `const` constructor might be a nice performance boost, especially in those spots where suddenly the entire Scaffold and its body can be `const`! The current setup is sort of wonky—rather than directly having a dependency on the parent Scaffold, both [`didChangeDependencies`](https://github.com/flutter/flutter/blob/f49f2f5ca9fa3ed06b38a0f7d9da4e1c8638be48/packages/flutter/lib/src/material/app_bar.dart#L774-L785) and [`build`](https://github.com/flutter/flutter/blob/f49f2f5ca9fa3ed06b38a0f7d9da4e1c8638be48/packages/flutter/lib/src/material/app_bar.dart#L842) use `Scaffold.maybeOf(context)`, which calls `findAncestorStateOfType()` to obtain the ScaffoldState. We already have an inherited widget for Scaffold data (it's a private [`_ScaffoldScope`](https://github.com/flutter/flutter/blob/f49f2f5ca9fa3ed06b38a0f7d9da4e1c8638be48/packages/flutter/lib/src/material/scaffold.dart#L3325) class). A straightforward non-breaking change could be to store the ScaffoldState in the inherited widget, similar to what [`_ParentInkResponseProvider`](https://github.com/flutter/flutter/blob/ee89e9a56057969a1f78b8355973c576f196d381/packages/flutter/lib/src/material/ink_well.dart#L201-L215) does, and then `Scaffold.maybeOf` could be tweaked to optionally create a dependency, similar to [`Focus.maybeOf`](https://github.com/flutter/flutter/blob/ee89e9a56057969a1f78b8355973c576f196d381/packages/flutter/lib/src/widgets/focus_scope.dart#L446-L461): ```dart class Scaffold { static ScaffoldState? maybeOf(BuildContext context, {bool createDependency = false}) { if (createDependency) { return context.dependOnInheritedWidgetOfExactType<_ScaffoldScope>()?.state; } return context.findAncestorStateOfType<ScaffoldState>(); } } ```
f: material design,c: performance,P3,c: tech-debt,team-design,triaged-design
low
Major
2,515,322,877
PowerToys
Merge PDFs tool
### Description of the new feature / enhancement It would allow you to merge PDFs—honestly, just that. But being able to set the order and what pages to pick and choose would also be practical. ### Scenario when this would be used? Anytime you need to merge multiple PDFs. ### Supporting information Macbooks can do it. Insofar as PowerToys is a tool to make power users' lives more efficient and to facilitate productivity, this feature would do that.
Needs-Triage
low
Minor
2,515,352,286
PowerToys
Environment variables of dust path is missing when alacritty is started via Powertoys Run
### Microsoft PowerToys version 0.84.0 ### Installation method PowerToys auto-update ### Running as admin No ### Area(s) with issue? PowerToys Run ### Steps to reproduce Alacritty will miss the environment variable of dust path when launched by Powertoys Run, whereas windows terminal does not have this issue. If I launch Alacritty directly, Alacritty can use dust normally. I'm not sure if it's a issue with alacritty or with Powertoys Run. ### ✔️ Expected Behavior ![alacritty_DAU8ZlurLM](https://github.com/user-attachments/assets/2fad3ca9-f3d6-4aa4-a8f0-6b85cd0d4f79) ### ❌ Actual Behavior ![alacritty_1Ubhp2gjjL](https://github.com/user-attachments/assets/ccf42415-e46a-45ce-94d3-bccb403c747b) ### Other Software Alacritty 0.13.2 (installed via winget) dust 1.0.0 (installed via winget)
Issue-Bug,Needs-Triage
low
Minor
2,515,360,951
TypeScript
function object parameter destructure field without default value will be ignored
### 🔎 Search Terms js, function, parameter, destructure, required ### 🕗 Version & Regression Information - This changed between versions 5.6 and latest nightly - We use ts 5.5 no this issue, after upgrade this issue occur. ### ⏯ Playground Link - [ts playground](https://www.typescriptlang.org/dev/bug-workbench/?allowJs=true&ts=5.7.0-dev.20240904#code/PTAEAEEMBtoewO4CkDOAuUAXATgVwKYBQhIEAZgJbT4B2kAtvhrplSgHQBWKx+AHgAc42TKADGcGilEBzfJgCqKfNgAK2OJWoAhAJ5KVdRqAC8oABQBvQqFC5l2I-gA0N0AgqYAFgFF6kKlNQMhhlV1sPbwA5OFZKMUhWSQBleVYaGRQgkOgwwgBfIMt8gEpTAD5Qa1tseVxHKvyAbgKWkjBwLVoGJlB-Chp2TB5CCnohESrQOUUHdU0qfD0DRx7QQrINelAAcnZgFjYdtpmV+a7lhycrN3tDHowd6F0d11KmoA) - [stackblitz](https://stackblitz.com/edit/vitejs-vite-usm5mx ) ### 💻 Code ```js // utils.js export const getUserProfileByUsername = ({ username, withEmail = false, withNotificationSettings = false, } = {}) => { return {}; }; ``` ```ts // main.ts import { getUserProfileByUsername } from './utils'; getUserProfileByUsername({ username: 'ly', }); ``` ### 🙁 Actual behavior ```node src/main.ts:4:3 - error TS2353: Object literal may only specify known properties, and 'username' does not exist in type '{ withEmail?: boolean | undefined; withNotificationSettings?: boolean | undefined; }'. 4 username: 'ly', ~~~~~~~~ Found 1 error in src/main.ts:4 ``` ### 🙂 Expected behavior no ts validate error ### Additional information about the issue ts 5.x not this issue, must be introduced by 5.6
Bug
low
Critical
2,515,440,278
svelte
Svelte 5: using `bind:this` in `$derived`
### Describe the bug ```svelte <script lang="ts"> let a: HTMLParagraphElement; let b: HTMLParagraphElement | undefined = undefined; </script> <p bind:this={a} bind:this={b}></p> ``` ```ts // Variable 'a' is used before being assigned.ts(2454) const a2 = $derived(a.children); // Property 'children' does not exist on type 'never'.ts(2339) const b2 = $derived(b?.children); ``` ```ts // let a2: HTMLCollection $: a2 = a.children; // let b2: HTMLCollection | undefined $: b2 = b?.children; ``` ### Reproduction See above. ### Logs _No response_ ### System Info ```shell System: OS: macOS 14.6.1 CPU: (10) arm64 Apple M1 Pro Memory: 665.30 MB / 16.00 GB Shell: 5.9 - /bin/zsh Binaries: Node: 22.8.0 - ~/.local/state/fnm_multishells/8044_1725946328522/bin/node npm: 10.8.2 - ~/.local/state/fnm_multishells/8044_1725946328522/bin/npm pnpm: 9.9.0 - ~/.local/state/fnm_multishells/8044_1725946328522/bin/pnpm Browsers: Chrome: 128.0.6613.120 Edge: 128.0.2739.67 Safari: 17.6 npmPackages: svelte: 5.0.0-next.244 => 5.0.0-next.244 ``` ### Severity annoyance
documentation
low
Critical
2,515,447,407
flutter
RPCError: getVM: (-32000) Service connection disposed
Parent issue: https://github.com/flutter/flutter/issues/153471. Thrown by a `VMService.getVM` call from `FlutterDevice.initLogReader`. ## Stack traces (from version 3.24.2) ``` RPCError: getVM: (-32000) Service connection disposed at VmService._call(vm_service.dart:1769) at VmService.getVM(vm_service.dart:1245) at FlutterDevice.initLogReader(resident_runner.dart:428) at HotRunner.attach(run_hot.dart:266) at <asynchronous gap>(async) at RunCommand.runCommand(run.dart:867) at <asynchronous gap>(async) at FlutterCommand.run.<anonymous closure>(flutter_command.dart:1408) at <asynchronous gap>(async) at AppContext.run.<anonymous closure>(context.dart:153) at <asynchronous gap>(async) at CommandRunner.runCommand(command_runner.dart:212) at <asynchronous gap>(async) at FlutterCommandRunner.runCommand.<anonymous closure>(flutter_command_runner.dart:420) at <asynchronous gap>(async) at AppContext.run.<anonymous closure>(context.dart:153) at <asynchronous gap>(async) at FlutterCommandRunner.runCommand(flutter_command_runner.dart:364) at <asynchronous gap>(async) at run.<anonymous closure>.<anonymous closure>(runner.dart:130) at <asynchronous gap>(async) at AppContext.run.<anonymous closure>(context.dart:153) at <asynchronous gap>(async) at main(executable.dart:93) at <asynchronous gap>(async) ``` ``` RPCError: getVM: (-32000) Service connection disposed at new _OutstandingRequest(vm_service.dart:261) at VmService._call.<anonymous closure>(vm_service.dart:1778) at VmService._call(vm_service.dart:1790) at VmService.getVM(vm_service.dart:1245) at FlutterDevice.initLogReader(resident_runner.dart:428) at HotRunner.attach(run_hot.dart:266) at <asynchronous gap>(async) at RunCommand.runCommand(run.dart:867) at <asynchronous gap>(async) at FlutterCommand.run.<anonymous closure>(flutter_command.dart:1408) at <asynchronous gap>(async) at AppContext.run.<anonymous closure>(context.dart:153) at <asynchronous gap>(async) at CommandRunner.runCommand(command_runner.dart:212) at <asynchronous gap>(async) at FlutterCommandRunner.runCommand.<anonymous closure>(flutter_command_runner.dart:420) at <asynchronous gap>(async) at AppContext.run.<anonymous closure>(context.dart:153) at <asynchronous gap>(async) at FlutterCommandRunner.runCommand(flutter_command_runner.dart:364) at <asynchronous gap>(async) at run.<anonymous closure>.<anonymous closure>(runner.dart:130) at <asynchronous gap>(async) at AppContext.run.<anonymous closure>(context.dart:153) at <asynchronous gap>(async) at main(executable.dart:93) at <asynchronous gap>(async) ```
c: crash,P1,team-tool,triaged-tool
medium
Critical
2,515,479,129
vscode
ESM: restore support for ASAR
For ESM we have disabled ASAR but we should investigate bringing it back. We used to have this code to inject the lookup path: https://github.com/microsoft/vscode/blob/789c320a1c67bb0547cdef2b8b82634bf93929a3/src/bootstrap-node.js#L210-L233 But going forward, Electron should expose a way for us to enlist a path as ASAR path so that it can internally handle this as early as possible.
upstream,debt,electron,confirmed,ESM
low
Minor
2,515,484,125
flutter
RPCError: readyToResume: (-32000) Service connection disposed
Parent issue: https://github.com/flutter/flutter/issues/153471 ``` RPCError: readyToResume: (-32000) Service connection disposed at new _OutstandingRequest(vm_service.dart:261) at VmService._call.<anonymous closure>(vm_service.dart:1778) at VmService._call(vm_service.dart:1790) at VmService.callServiceExtension(vm_service.dart:1729) at VmService.callMethod(vm_service.dart:1712) at DdsExtension._callHelper(dds_service_extensions.dart:346) at DdsExtension.readyToResume(dds_service_extensions.dart:304) at <asynchronous gap>(async) at IsolateManager._readyToResume(isolate_manager.dart:409) at <asynchronous gap>(async) at IsolateManager.readyToResumeThread(isolate_manager.dart:301) at <asynchronous gap>(async) at IsolateManager._handlePause(isolate_manager.dart:646) at <asynchronous gap>(async) at IsolateManager.handleEvent(isolate_manager.dart:202) at <asynchronous gap>(async) at DartDebugAdapter.handleDebugEvent(dart.dart:2473) at <asynchronous gap>(async) at DartDebugAdapter._withErrorHandling(dart.dart:2821) at <asynchronous gap>(async) ``` ``` RPCError: readyToResume: (-32000) Service connection disposed at VmService._call(vm_service.dart:1769) at VmService.callServiceExtension(vm_service.dart:1729) at VmService.callMethod(vm_service.dart:1712) at DdsExtension._callHelper(dds_service_extensions.dart:346) at DdsExtension.readyToResume(dds_service_extensions.dart:304) at <asynchronous gap>(async) at IsolateManager._readyToResume(isolate_manager.dart:409) at <asynchronous gap>(async) at IsolateManager.readyToResumeThread(isolate_manager.dart:301) at <asynchronous gap>(async) at IsolateManager._handlePause(isolate_manager.dart:656) at <asynchronous gap>(async) at IsolateManager.handleEvent(isolate_manager.dart:202) at <asynchronous gap>(async) at DartDebugAdapter.handleDebugEvent(dart.dart:2473) at <asynchronous gap>(async) at DartDebugAdapter._withErrorHandling(dart.dart:2821) at <asynchronous gap>(async) ``` ``` RPCError: getIsolate: (-32000) Service connection disposed at new _OutstandingRequest(vm_service.dart:261) at VmService._call.<anonymous closure>(vm_service.dart:1778) at VmService._call(vm_service.dart:1790) at VmService.getIsolate(vm_service.dart:896) at IsolateManager._sendLibraryDebuggables(isolate_manager.dart:1030) at IsolateManager._configureIsolate(isolate_manager.dart:553) at IsolateManager._handlePause(isolate_manager.dart:645) at IsolateManager.handleEvent(isolate_manager.dart:202) at <asynchronous gap>(async) at DartDebugAdapter.handleDebugEvent(dart.dart:2473) at <asynchronous gap>(async) at DartDebugAdapter._withErrorHandling(dart.dart:2821) at <asynchronous gap>(async) ```
P1,team-tool,triaged-tool
medium
Critical
2,515,488,084
flutter
RPCError: getIsolate: (-32000) Service connection disposed
On 3.24.2 ``` RPCError: getIsolate: (-32000) Service connection disposed at new _OutstandingRequest(vm_service.dart:261) at VmService._call.<anonymous closure>(vm_service.dart:1778) at VmService._call(vm_service.dart:1790) at VmService.getIsolate(vm_service.dart:896) at IsolateManager._sendLibraryDebuggables(isolate_manager.dart:1030) at IsolateManager._configureIsolate(isolate_manager.dart:553) at IsolateManager.registerIsolate(isolate_manager.dart:246) at IsolateManager.handleEvent(isolate_manager.dart:189) at DartDebugAdapter.handleIsolateEvent(dart.dart:2504) at <asynchronous gap>(async) at DartDebugAdapter._withErrorHandling(dart.dart:2821) at <asynchronous gap>(async) ```
c: crash,P1,team-tool,triaged-tool
medium
Critical
2,515,506,580
ollama
Can you specify a graphics card in the ollama deployment model?
For example, qwen2 is in CUDA_VISIBLE_DEVICE=2 and glm4 is in CUDA_VISIBLE_DEVICE=4
feature request
low
Minor
2,515,516,850
transformers
The same situation as #31377 occurred when using Qwen/Qwen2-VL-7B-Instruct
### System Info - `transformers` version: 4.45.0.dev0 - Platform: macOS-14.6.1-arm64-arm-64bit - Python version: 3.12.4 - Huggingface_hub version: 0.24.6 - Safetensors version: 0.4.5 - Accelerate version: not installed - Accelerate config: not found - PyTorch version (GPU?): 2.4.1 (False) - Tensorflow version (GPU?): not installed (NA) - Flax version (CPU?/GPU?/TPU?): not installed (NA) - Jax version: not installed - JaxLib version: not installed - Using distributed or parallel set-up in script?: <fill in> ### Who can help? @zucchini-nlp @amyer ### Information - [X] The official example scripts - [ ] My own modified scripts ### Tasks - [X] An officially supported task in the `examples` folder (such as GLUE/SQuAD, ...) - [X] My own task or dataset (give details below) ### Reproduction Run this code after git clone with the hash I specified above and pip install ./transformers ``` from transformers import Qwen2VLForConditionalGeneration,AutoModel,AutoProcessor model_path=".models/Qwen/Qwen2-VL-7B-Instruct" model = Qwen2VLForConditionalGeneration.from_pretrained( model_path, torch_dtype=torch.bfloat16, #attn_implementation="default" ).to(self.device) #device="mps" min_pixels = 256*28*28 max_pixels = 1280*28*28 processor = AutoProcessor.from_pretrained(model_path, min_pixels=min_pixels, max_pixels=max_pixels ) messages = [ { "role": "user", "content": [ { "type": "image" }, { "type": "text", "text": "Extract text from pdf" } ] } ] base64_data = image_data.split(',')[1] # remove 'data:image/jpeg;base64,' image_bytes = base64.b64decode(base64_data) image = Image.open(io.BytesIO(image_bytes)) text = processor.apply_chat_template( messages, tokenize=False, add_generation_prompt=True ) inputs = processor( text=[text], images=[image], ).to(self.device)#device="mps" # Inference: Generation of the output generated_ids = model.generate(**inputs, max_new_tokens=128) generated_ids_trimmed = [ out_ids[len(in_ids) :] for in_ids, out_ids in zip(inputs.input_ids, generated_ids) ] output_text = processor.batch_decode( generated_ids_trimmed, skip_special_tokens=True, clean_up_tokenization_spaces=False ) return output_text # Dummy return ``` ### Expected behavior File "/Users/dev/products/dev/workspaces/mixparse/llm/model/modelmanager.py", line 429, in _run_safetensors_inference generated_ids = model.generate(**inputs, max_new_tokens=128) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/Users/dev/anaconda3/envs/all-parse/lib/python3.12/site-packages/torch/utils/_contextlib.py", line 116, in decorate_context return func(*args, **kwargs) ^^^^^^^^^^^^^^^^^^^^^ File "/Users/dev/anaconda3/envs/all-parse/lib/python3.12/site-packages/transformers/generation/utils.py", line 2015, in generate result = self._sample( ^^^^^^^^^^^^^ File "/Users/dev/anaconda3/envs/all-parse/lib/python3.12/site-packages/transformers/generation/utils.py", line 2965, in _sample outputs = self(**model_inputs, return_dict=True) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/Users/dev/anaconda3/envs/all-parse/lib/python3.12/site-packages/torch/nn/modules/module.py", line 1553, in _wrapped_call_impl return self._call_impl(*args, **kwargs) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/Users/dev/anaconda3/envs/all-parse/lib/python3.12/site-packages/torch/nn/modules/module.py", line 1562, in _call_impl return forward_call(*args, **kwargs) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/Users/dev/anaconda3/envs/all-parse/lib/python3.12/site-packages/transformers/models/qwen2_vl/modeling_qwen2_vl.py", line 1683, in forward inputs_embeds[image_mask] = image_embeds RuntimeError: shape mismatch: value tensor of shape [630, 3584] cannot be broadcast to indexing result of shape [0, 3584]
bug,Multimodal,Cache
medium
Critical
2,515,518,218
material-ui
[question] How to combine the two different Joy-UI themes.
### The problem in depth ``` const oneTheme: CssVarsThemeOptions = { colorSchemes: { light: { palette: { primary: { 500: '#1976d2', }, }, }, }, components: { JoyButton: { styleOverrides: { root: { borderRadius: '8px', }, }, }, }, }; // Second theme const twoTheme: CssVarsThemeOptions = { colorSchemes: { light: { palette: { secondary: { 500: '#dc004e', }, }, }, }, components: { JoyInput: { styleOverrides: { root: { backgroundColor: '#f0f0f0', }, }, }, }, }; const combinedThemes = extendTheme({ ...oneTheme, ...twoTheme, components: { ...oneTheme.components, ...twoTheme.components, }, } as Theme) ``` but I found that xxx.components cannot be recognized, Can you please help me solve it? I need to combine this two different theme together and also let the JoyButton and JoyInput working together as well ### Your environment next.js v14, typescript, Joy-Ui **Search keywords**: Joy-UI extendTheme **Order ID**: 97037 **Search keywords**:
on hold,support: question,package: material-ui,package: joy-ui,support: commercial
low
Major
2,515,535,443
pytorch
[inductor][cpu]AOT inductor performance regression and accuracy failure in 2024-09-04 nightly release
### 🐛 Describe the bug <p>AMP static shape default wrapper performance regression</p><table border="1" class="dataframe table"> <thead> <tr style="text-align: right;"> <th>suite</th> <th>name</th> <th>thread</th> <th>batch_size_new</th> <th>speed_up_new</th> <th>inductor_new</th> <th>eager_new</th> <th>compilation_latency_new</th> <th>batch_size_old</th> <th>speed_up_old</th> <th>inductor_old</th> <th>eager_old</th> <th>compilation_latency_old</th> <th>Ratio Speedup(New/old)</th> <th>Eager Ratio(old/new)</th> <th>Inductor Ratio(old/new)</th> <th>Compilation_latency_Ratio(old/new)</th> </tr> </thead> <tbody> <tr> <td>torchbench</td> <td>hf_T5_base</td> <td>multiple</td> <td>1</td> <td>1.238967</td> <td>0.838228385</td> <td>1.0385373074782949</td> <td>117.408291</td> <td>1</td> <td>1.895532</td> <td>0.543833995</td> <td>1.0308547402103398</td> <td>116.595872</td> <td>0.65</td> <td>0.99</td> <td>0.65</td> <td>0.99</td> </tr> <tr> <td>torchbench</td> <td>hf_T5_large</td> <td>multiple</td> <td>1</td> <td>1.242756</td> <td>0.318922536</td> <td>0.39634289514921595</td> <td>335.304479</td> <td>1</td> <td>1.432529</td> <td>0.27843835100000003</td> <td>0.39887101251967905</td> <td>326.659959</td> <td>0.87</td> <td>1.01</td> <td>0.87</td> <td>0.97</td> </tr> <tr> <td>huggingface</td> <td>MT5ForConditionalGeneration</td> <td>multiple</td> <td>16</td> <td>1.46969</td> <td>0.155681585</td> <td>0.22880366865865</td> <td>101.992322</td> <td>16</td> <td>1.821134</td> <td>0.121095646</td> <td>0.220531398182564</td> <td>102.407316</td> <td>0.81</td> <td>0.96</td> <td>0.78</td> <td>1.0</td> </tr> <tr> <td>torchbench</td> <td>hf_T5</td> <td>single</td> <td>1</td> <td>0.650519</td> <td>0.5984183120000001</td> <td>0.389282481903928</td> <td>62.38676</td> <td>1</td> <td>0.880377</td> <td>0.441144343</td> <td>0.388373333257311</td> <td>62.027646</td> <td>0.74</td> <td>1.0</td> <td>0.74</td> <td>0.99</td> </tr> <tr> <td>torchbench</td> <td>hf_T5_base</td> <td>single</td> <td>1</td> <td>0.589821</td> <td>23.711127984999997</td> <td>13.985321219240685</td> <td>63.229392</td> <td>1</td> <td>0.877813</td> <td>15.857589405</td> <td>13.919998128371265</td> <td>65.270571</td> <td>0.67</td> <td>1.0</td> <td>0.67</td> <td>1.03</td> </tr> <tr> <td>torchbench</td> <td>hf_T5_large</td> <td>single</td> <td>1</td> <td>0.747827</td> <td>5.337602142</td> <td>3.991602997045434</td> <td>312.96011</td> <td>1</td> <td>0.98226</td> <td>4.059179598</td> <td>3.98716975193148</td> <td>314.149114</td> <td>0.76</td> <td>1.0</td> <td>0.76</td> <td>1.0</td> </tr> <tr> <td>huggingface</td> <td>T5ForConditionalGeneration</td> <td>single</td> <td>1</td> <td>0.598922</td> <td>2.087471869</td> <td>1.2502328267252178</td> <td>59.535414</td> <td>1</td> <td>0.869239</td> <td>1.434526977</td> <td>1.2469467949605029</td> <td>59.678655</td> <td>0.69</td> <td>1.0</td> <td>0.69</td> <td>1.0</td> </tr> <tr> <td>huggingface</td> <td>T5Small</td> <td>single</td> <td>1</td> <td>0.597191</td> <td>2.0881833000000003</td> <td>1.2470442731103002</td> <td>59.967489</td> <td>1</td> <td>0.873677</td> <td>1.433874097</td> <td>1.252742819444669</td> <td>59.733762</td> <td>0.68</td> <td>1.0</td> <td>0.69</td> <td>1.0</td> </tr> </tbody> </table> <p>AMP static default wrapper accuracy failure</p><table border="1" class="dataframe table"> <thead> <tr style="text-align: right;"> <th>suite</th> <th>name</th> <th>thread</th> <th>accuracy</th> <th>perf</th> <th>reason(reference only)</th> </tr> </thead> <tbody> <tr> <td>timm_models</td> <td>levit_128</td> <td>multiple</td> <td>X</td> <td>√</td> <td>levit_128, NotImplementedError: Cannot copy out of meta tensor; no data!</td> </tr> <tr> <td>torchbench</td> <td>yolov3</td> <td>multiple</td> <td>X</td> <td>√</td> <td>yolov3, NotImplementedError: Cannot copy out of meta tensor; no data!</td> </tr> <tr> <td>timm_models</td> <td>levit_128</td> <td>single</td> <td>X</td> <td>√</td> <td>levit_128, NotImplementedError: Cannot copy out of meta tensor; no data!</td> </tr> <tr> <td>torchbench</td> <td>yolov3</td> <td>single</td> <td>X</td> <td>√</td> <td>yolov3, NotImplementedError: Cannot copy out of meta tensor; no data!</td> </tr> </tbody> </table> ### Versions </table><p>SW info</p><table border="1" class="dataframe table"> <thead> <tr style="text-align: right;"> <th>name</th> <th>target_branch</th> <th>target_commit</th> <th>refer_branch</th> <th>refer_commit</th> </tr> </thead> <tbody> <tr> <td>torchbench</td> <td>main</td> <td>23512dbe</td> <td>main</td> <td>23512dbe</td> </tr> <tr> <td>torch</td> <td>main</td> <td>e000cf0ad9</td> <td>main</td> <td>2553278bae</td> </tr> <tr> <td>torchvision</td> <td>main</td> <td>0.19.0a0+d23a6e1</td> <td>main</td> <td>0.19.0a0+d23a6e1</td> </tr> <tr> <td>torchtext</td> <td>main</td> <td>0.16.0a0+b0ebddc</td> <td>main</td> <td>0.16.0a0+b0ebddc</td> </tr> <tr> <td>torchaudio</td> <td>main</td> <td>2.5.0a0+97ed7b3</td> <td>main</td> <td>2.4.0a0+b3f6f51</td> </tr> <tr> <td>torchdata</td> <td>main</td> <td>0.7.0a0+11bb5b8</td> <td>main</td> <td>0.7.0a0+11bb5b8</td> </tr> <tr> <td>dynamo_benchmarks</td> <td>main</td> <td>nightly</td> <td>main</td> <td>nightly</td> </tr> </tbody> </table> </table> Repro: [inductor_single_run.sh](https://github.com/chuanqi129/inductor-tools/blob//weizhuoz/enable_max_autotune_for_guilty/scripts/modelbench/inductor_single_run.sh) bash inductor_single_run.sh multiple inference performance/accuracy **suite** **name** amp first static default 0 aot_inductor Suspected guilty commit: https://github.com/pytorch/pytorch/commit/387d3fc2968946cbce4b8fbd9315d9bec8b02c9e [torchbench-hf_T5_base-inference-amp-static-default-multiple-performance-drop_guilty_commit.log](https://github.com/user-attachments/files/16940490/torchbench-hf_T5_base-inference-amp-static-default-multiple-performance-drop_guilty_commit.log) [timm_models-levit_128-inference-amp-static-default-multiple-accuracy-crash_guilty_commit.log](https://github.com/user-attachments/files/16940496/timm_models-levit_128-inference-amp-static-default-multiple-accuracy-crash_guilty_commit.log) cc @ezyang @chauhang @penguinwu @WeizhuoZhang-intel @chuanqi129 @chunyuan-w
oncall: pt2,oncall: cpu inductor
low
Critical
2,515,557,225
next.js
Server-side request forgery (SSRF)
### Link to the code that reproduces this issue https://codesandbox.io/p/sandbox/next-js-forked-slktwp ### To Reproduce When start my application, my header is visible in the browser. This is causing the below vulnerability issue This application allows user-controlled URLs to be passed directly to HTTP client libraries. This can result in Server-Side Request Forgery (SSRF). SSRF refers to an attack where the attacker can abuse functionality on the server to force it to make requests to other internal systems within your infrastructure that are not directly exposed to the internet. This allows the attacker to access internal resources they do not have direct access to.\nSome risks of SSRF are:\n- Access and manipulation of internal databases, APIs, or administrative panels - Ability to scan internal network architecture and services - Can be used to pivot attacks into the internal network - Circumvent network segregation and firewall rules\nTo avoid this, try using hardcoded HTTP request calls or a whitelisting object to check whether the user input is trying to access allowed resources or not.\nHere is an example: ``` var whitelist = [\n "https://example.com", \n "https://example.com/sample"\n]\napp.get('/ssrf/node-ssrf/axios/safe/3', function (req, res) {\n if(whitelist.includes(req.query.url)){\n axios.get(url, {})\n .then(function (response) {\n console.log(response);\n })\n .catch(function (response) {\n console.log(response); \n })\n }\n}); ``` For more information on SSRF see OWASP: https://cheatsheetseries.owasp.org/cheatsheets/Server_Side_Request_Forgery_Prevention_Cheat_Sheet.html\n ### Current vs. Expected behavior Current behavior: vulnerability scan failed because of injection of headers in the URL Expected behavior: Vulnerability scan should pass ### Provide environment information ```bash Operating system :Windows 11 Binaries : Node : 20.11.1 npm : 10.2.4 Yarn : 1.22.19 Relevant packages next : 14.2.7 eslint-config-next : 14.1.0 react :18 react-dom:18 typescript : 5 ``` ### Which area(s) are affected? (Select all that apply) Instrumentation, Output (export/standalone) ### Which stage(s) are affected? (Select all that apply) next dev (local), next build (local), Other (Deployed) ### Additional context Getting critical issue for this
bug,Output (export/standalone),Instrumentation
low
Critical
2,515,574,038
PowerToys
Workspaces does not detect Thunderbird
### Microsoft PowerToys version 0.84.1 ### Installation method PowerToys auto-update ### Running as admin Yes ### Area(s) with issue? Workspaces ### Steps to reproduce Create workspace ### ✔️ Expected Behavior Thunderbird to be detected. ### ❌ Actual Behavior Thunderbird is now being incorrectly detected as Explorer (a step up from not being detected at all in 0.84.0). So when launching the workspace I get a file explorer window where Thunderbird should be. ### Other Software Thunderbird 115.14.0
Issue-Bug,Needs-Triage,Product-Workspaces
low
Minor
2,515,614,111
PowerToys
PowerRename not appearing in both context menus
### Microsoft PowerToys version 0.84.1 ### Installation method PowerToys auto-update ### Running as admin Yes ### Area(s) with issue? PowerRename ### Steps to reproduce _[This bug has been present for me for years but was gone in 0.84.0 - and then re-appeared in 0.84.1]_ Show PowerRename in: Standard and Extended context menu ![Skärmbild 2024-09-10 091430](https://github.com/user-attachments/assets/2854d0c7-ecb9-4326-97d6-b6fd376b03fd) [PowerToysReport_2024-09-10-09-14-56.zip](https://github.com/user-attachments/files/16940919/PowerToysReport_2024-09-10-09-14-56.zip) ### ✔️ Expected Behavior PowerRename should be visible in both Standard and Extended context menu. ### ❌ Actual Behavior PowerRename is only visible in Extended context menu. ### Other Software _No response_
Issue-Bug,Needs-Triage
low
Critical
2,515,650,300
opencv
Point within bounds of an image
We quite often need to check if a particular point lies within the bounds of an image. There are currently two ways to do it: - `cv::Rect{cv::Point{0, 0}, mat.size()}.contains(point)` - `point.x() >= 0 && point.x() < mat.cols && point.y() >= 0 && point.y() < mat.rows` Both are cumbersome to write, error prone and cause a lot of noise for such a trivial check. It would be obvious to add ``` bool cv::Size contains(const cv::Point& p) { return 0 <= p.x() && p.x() < width && 0 <= p.y() && p.y() < height; } ``` or maybe free functions with a shortcut to enter `cv::Mat` directly: ``` bool cv::contains(const cv::Mat&, const cv::Point&); bool cv::contains(const cv::Size&, const cv::Point&); ``` But I don't like the name, neither image nor size "contain" a point.
feature,category: core
low
Critical
2,515,678,149
kubernetes
[FG:InPlacePodVerticalScaling] Static CPU management policy alongside InPlacePodVerticalScaling
### What happened? Container CPUset allocations not updated for Guaranteed QoS Pod ( Integer CPU limits = CPU requests, after Inplace Pod updates with Static CPU Management policy alongside InPlacePodVerticalScaling. Static CPU management policy is not supported with this feature, known issue ( ref: https://kubernetes.io/blog/2023/05/12/in-place-pod-resize-alpha/#known-issues ) ### What did you expect to happen? Container CPU set container allocation to be updated if accepted ### How can we reproduce it (as minimally and precisely as possible)? From https://github.com/kubernetes/enhancements/issues/2838 Tested the changes being done as a part of KEP --> In Place update of Pod resources (https://github.com/kubernetes/enhancements/issues/1287) Added the below kubernetes flag before building k8s locally to the hack/local_cluster_up.sh script file. (Note i had created a vm machine with 8 cpus...) kuberneted flags :- "--topology-manager-policy=best-effort" "--cpu-manager-policy=static" "--reserved-cpus=0,1" I then created a pod with limit and cpu both assigned as 2.. the pod got successfully created. I then logged in the pod and then checked its cpu set...there it was showing cpu core 3-4 assigned to the pod.. which is fine/correct. Now i updated the pod limit and cpu to 3 each.. the pod got successfully updated as well...However cpuset assigned to the container was not updated in this case when i logged into the pod and verified..It was same as previous...Not sure if you have checked this thing at your end ?? Thanks & Regards, ANkit Nigam ### Anything else we need to know? As decided in SIG Node meeting, this issue replaces https://github.com/kubernetes/enhancements/issues/2838 ### Kubernetes version <details> Kubernetes versions with InPlacePodVerticalScaling > 1.27 </details> ### Cloud provider <details> Independent of Cloud provider </details> ### OS version <details> Independent of OS </details> ### Install tools <details> Independent of install tools </details>
kind/bug,sig/node,triage/accepted
low
Minor
2,515,684,938
ollama
MiniCPM3 support
[MiniCPM3-4B](https://huggingface.co/openbmb/MiniCPM3-4B) is the 3rd generation of MiniCPM series. The overall performance of MiniCPM3-4B surpasses Phi-3.5-mini-Instruct and GPT-3.5-Turbo-0125, being comparable with many recent 7B~9B models.
model request
low
Major
2,515,701,514
tauri
[feat] about Tauri support for RISC-V platform
### Describe the problem I am evaluating the possibility of using Tauri to build desktop applications for the RISC-V platform. I would like to know if Tauri currently supports the RISC-V architecture, and whether there are any success stories or documentation available that could help me compile Tauri applications for RISC-V? ### Describe the solution you'd like If there is any relevant information or advice, could you please share it? Thank you! ### Alternatives considered _No response_ ### Additional context _No response_
type: feature request
low
Major
2,515,711,284
storybook
[Bug]: Open in a new tab button don't load arguments
### Describe the bug I'm using Storybook.js on a Laravel/Inertia project with tailwind and ShadCN. Everything is working well except the "Open in new tab" button. For example, I have a button component which can have 2 sizes: default & small. I can change the size when on the component page but when I open it in a new tab the size is not the right one. I've checked in my URL and I have the params : https://my-app.io/storybook/iframe.html?args=size:small&id=components-button--success&viewMode=story I have the same problem on local and on production with builded assets. Here is my config file : ``` /** @type { import('@storybook/vue3-vite').StorybookConfig } */ const config = { stories: ['../resources/js/**/*.stories.@(js|jsx|mjs|ts|tsx|vue)'], addons: [ '@storybook/addon-onboarding', '@storybook/addon-links', '@storybook/addon-essentials', '@chromatic-com/storybook', '@storybook/addon-interactions', '@storybook/addon-styling-webpack' ], framework: { name: '@storybook/vue3-vite', options: { docgen: 'vue-component-meta', }, }, }; export default config; ``` And here is my component story : ``` import Button from './Button.vue'; export default { argTypes: { as: { control: { defaultValue: 'button', type: 'select' }, options: ['button', 'a', 'router-link'], }, class: { control: { type: 'text' }, defaultValue: '' }, iconRight: { control: { type: 'select' }, options: ['ri-skip-right-fill', 'ri-home-4-line', 'ri-question-answer-fill', null], }, size: { control: { defaultValue: 'default', type: 'select' }, options: ['small', 'default'], }, variant: { control: { defaultValue: 'default', type: 'select' }, options: [ 'danger', 'default', 'floating', 'ghost', 'outlined-light', 'outlined-strong', 'toggle', 'underlined', ], }, }, component: Button, tags: ['autodocs'], title: 'Components/Button', }; export const Default = { args: { default: 'Default', size: 'default', variant: 'default', }, }; export const Danger = { args: { default: 'Danger', size: 'default', variant: 'danger', }, }; ``` Did I missconfigured something or it's a problem with Laravel ? ### Reproduction link I'm using Inertia so it's hard to provide a new storybook for testing purposes ### Reproduction steps _No response_ ### System ```bash Storybook Environment Info: System: OS: macOS 14.5 CPU: (12) arm64 Apple M2 Pro Shell: 5.9 - /bin/zsh Binaries: Yarn: 1.22.19 - /opt/homebrew/bin/yarn npm: 10.8.2 - ~/Library/Application Support/Herd/config/nvm/versions/node/v21.7.3/bin/npm <----- active pnpm: 9.4.0 - ~/Library/Application Support/Herd/config/nvm/versions/node/v21.7.3/bin/pnpm Browsers: Chrome: 128.0.6613.120 Safari: 17.5 npmPackages: @storybook/addon-essentials: ^8.2.9 => 8.2.9 @storybook/addon-interactions: ^8.2.9 => 8.2.9 @storybook/addon-links: ^8.2.9 => 8.2.9 @storybook/addon-onboarding: ^8.2.9 => 8.2.9 @storybook/addon-styling-webpack: ^1.0.0 => 1.0.0 @storybook/blocks: ^8.2.9 => 8.2.9 @storybook/test: ^8.2.9 => 8.2.9 @storybook/vue3: ^8.2.9 => 8.2.9 @storybook/vue3-vite: ^8.2.9 => 8.2.9 eslint-plugin-storybook: ^0.8.0 => 0.8.0 storybook: ^8.2.9 => 8.2.9 ``` ### Additional context _No response_
bug,needs triage
low
Critical
2,515,785,668
godot
Unintentional code selection
### Tested versions v4.4.dev1.official [28a72fa43] v3.6.stable.official [de2f0f147] ### System information w10 64 ### Issue description Watch the video. Place the cursor at the top or in an area that leaves code to be able to reproduce the problem. Select the second digit of the code line. The caret moves to the bottom line and the text on the top line is selected v4.4.dev1.official [28a72fa43] https://github.com/user-attachments/assets/c5585171-2e98-4ed9-9e29-dc350ab36100 This also happens in 3.6 stable in a different way. In 3.6 stable, select the area where breakpoints are created. With the click held down, drag a little. v3.6.stable.official [de2f0f147] https://github.com/user-attachments/assets/33a8a367-354f-4c8f-a47f-6f98fc8b023f ### Steps to reproduce See the videos ### Minimal reproduction project (MRP) ...
bug,topic:gui
low
Minor
2,515,799,708
kubernetes
kube api audit log to a file
### What happened? Hello, Im configuring kube-apiserver to send the logs to the file so that I can see the audit events. But after adding the required details the kube-apiserver got restarted but the log was not created. Below are the rule I have added for logging ```yaml - --audit-policy-file=/etc/kubernetes/audit-policy.yaml - --audit-log-path=/var/log/kubernetes-apiserver.log - --audit-log-maxsize=100 - --audit-log-maxbackup=3 - --audit-log-format=json ``` I have added the policy as below ```yaml # Log all requests at the Metadata level. apiVersion: audit.k8s.io/v1 kind: Policy rules: - level: Metadata ``` After that pod git restarted but there is no log was writing into the file kubernetes version 1.29.8 ### What did you expect to happen? It was supposed to write audit events to the file specified in the kube-apiserver.yaml file but it is not happened ### How can we reproduce it (as minimally and precisely as possible)? To reproduce configure audit loggin with the kubernetes version 1.29.8 ### Anything else we need to know? When I tested the same configuration on 1.27.x version kubernetes it worked. ### Kubernetes version <details> ```console $ kubectl version Client Version: v1.29.8 Kustomize Version: v5.0.4-0.20230601165947-6ce0bf390ce3 Server Version: v1.29.8 ``` </details> ### Cloud provider <details> </details> ### OS version <details> ```console # On Linux: $ cat /etc/os-release RHEL8.8 $ uname -a 4.18.0-477.27.1.el8_8.x86_64 #1 SMP Thu Aug 31 10:29:22 EDT 2023 x86_64 x86_64 x86_64 GNU/Linux # On Windows: C:\> wmic os get Caption, Version, BuildNumber, OSArchitecture # paste output here ``` </details> ### Install tools <details> containerd </details> ### Container runtime (CRI) and version (if applicable) <details> </details> ### Related plugins (CNI, CSI, ...) and versions (if applicable) <details> </details>
kind/bug,kind/support,sig/api-machinery,help wanted,triage/accepted
low
Major
2,515,850,391
vscode
python is not running
Type: <b>Performance Issue</b> after a loop of reactivating terminal problem when it got fixed then my python code runner stopped working and shift+enter is also not working for the same VS Code version: Code 1.93.0 (4849ca9bdf9666755eb463db297b69e5385090e3, 2024-09-04T13:02:38.431Z) OS version: Windows_NT x64 10.0.19045 Modes: <details> <summary>System Info</summary> |Item|Value| |---|---| |CPUs|Intel(R) Core(TM) i5-10300H CPU @ 2.50GHz (8 x 2496)| |GPU Status|2d_canvas: enabled<br>canvas_oop_rasterization: enabled_on<br>direct_rendering_display_compositor: disabled_off_ok<br>gpu_compositing: enabled<br>multiple_raster_threads: enabled_on<br>opengl: enabled_on<br>rasterization: enabled<br>raw_draw: disabled_off_ok<br>skia_graphite: disabled_off<br>video_decode: enabled<br>video_encode: enabled<br>vulkan: disabled_off<br>webgl: enabled<br>webgl2: enabled<br>webgpu: enabled<br>webnn: disabled_off| |Load (avg)|undefined| |Memory (System)|23.91GB (19.33GB free)| |Process Argv|--crash-reporter-id d29636b5-32d9-42da-b2ae-7f789dcb9df7| |Screen Reader|no| |VM|0%| </details><details> <summary>Process Info</summary> ``` CPU % Mem MB PID Process 1 108 6376 code main 0 81 2172 fileWatcher [1] 1 92 2488 gpu-process 0 39 3280 utility-network-service 0 26 6664 crashpad-handler 0 99 8320 ptyHost 0 6 7880 conpty-agent 0 73 9108 C:\Windows\System32\WindowsPowerShell\v1.0\powershell.exe -noexit -command "try { . \"c:\Users\grimd\AppData\Local\Programs\Microsoft VS Code\resources\app\out\vs\workbench\contrib\terminal\browser\media\shellIntegration.ps1\" } catch {}" 0 6 12408 conpty-agent 0 74 15696 C:\Windows\System32\WindowsPowerShell\v1.0\powershell.exe -noexit -command "try { . \"c:\Users\grimd\AppData\Local\Programs\Microsoft VS Code\resources\app\out\vs\workbench\contrib\terminal\browser\media\shellIntegration.ps1\" } catch {}" 0 115 11624 shared-process 3 231 13352 window [1] (fifth_gauravnegi.py - DSA - Visual Studio Code) 0 219 15680 extensionHost [1] 0 6 14352 c:\Users\grimd\.vscode\extensions\ms-python.python-2024.14.0-win32-x64\python-env-tools\bin\pet.exe server 0 11 6216 C:\Windows\system32\conhost.exe 0x4 0 86 16208 "C:\Users\grimd\AppData\Local\Programs\Microsoft VS Code\Code.exe" "c:\Users\grimd\AppData\Local\Programs\Microsoft VS Code\resources\app\extensions\json-language-features\server\dist\node\jsonServerMain" --node-ipc --clientProcessId=15680 ``` </details> <details> <summary>Workspace Info</summary> ``` | Window (fifth_gauravnegi.py - DSA - Visual Studio Code) | Folder (DSA): 17 files | File types: py(15) json(1) | Conf files: settings.json(1); ``` </details> <details><summary>Extensions (18)</summary> Extension|Author (truncated)|Version ---|---|--- classroom|git|0.0.4 vscode-pull-request-github|Git|0.96.0 debugpy|ms-|2024.10.0 python|ms-|2024.14.0 vscode-pylance|ms-|2024.9.1 jupyter|ms-|2024.8.1 jupyter-keymap|ms-|1.1.2 jupyter-renderers|ms-|1.0.19 vscode-jupyter-cell-tags|ms-|0.1.9 vscode-jupyter-slideshow|ms-|0.1.6 cmake-tools|ms-|1.19.51 cpptools|ms-|1.21.6 cpptools-extension-pack|ms-|1.3.0 vsliveshare|ms-|1.0.5936 open-in-browser|tec|2.0.0 cmake|twx|0.0.17 classroomplugin|Whi|1.0.8 chat-gpt|zha|1.8.4 (3 theme extensions excluded) </details><details> <summary>A/B Experiments</summary> ``` vsliv368cf:30146710 vspor879:30202332 vspor708:30202333 vspor363:30204092 vscod805:30301674 binariesv615:30325510 vsaa593cf:30376535 py29gd2263:31024239 vscaat:30438848 c4g48928:30535728 azure-dev_surveyone:30548225 2i9eh265:30646982 962ge761:30959799 pythongtdpath:30769146 welcomedialog:30910333 pythonnoceb:30805159 asynctok:30898717 pythonmypyd1:30879173 h48ei257:31000450 pythontbext0:30879054 accentitlementsc:30995553 dsvsc016:30899300 dsvsc017:30899301 dsvsc018:30899302 cppperfnew:31000557 dsvsc020:30976470 pythonait:31006305 dsvsc021:30996838 9c06g630:31013171 a69g1124:31058053 dvdeprecation:31068756 dwnewjupytercf:31046870 newcmakeconfigv2:31071590 impr_priority:31102340 refactort:31108082 pythonrstrctxt:31112756 flightc:31134773 wkspc-onlycs-t:31132770 nativeloc1:31134641 wkspc-ranged-t:31125599 cf971741:31134768 fje88620:31121564 ``` </details> <!-- generated by issue reporter -->
under-discussion,python
medium
Critical
2,515,915,085
yt-dlp
ReverbNation artist playlist support
### DO NOT REMOVE OR SKIP THE ISSUE TEMPLATE - [X] I understand that I will be **blocked** if I *intentionally* remove or skip any mandatory\* field ### Checklist - [X] I'm reporting that yt-dlp is broken on a **supported** site - [X] I've verified that I have **updated yt-dlp to nightly or master** ([update instructions](https://github.com/yt-dlp/yt-dlp#update-channels)) - [X] I've checked that all provided URLs are playable in a browser with the same IP and same login details - [X] I've checked that all URLs and arguments with special characters are [properly quoted or escaped](https://github.com/yt-dlp/yt-dlp/wiki/FAQ#video-url-contains-an-ampersand--and-im-getting-some-strange-output-1-2839-or-v-is-not-recognized-as-an-internal-or-external-command) - [X] I've searched [known issues](https://github.com/yt-dlp/yt-dlp/issues/3766) and the [bugtracker](https://github.com/yt-dlp/yt-dlp/issues?q=) for similar issues **including closed ones**. DO NOT post duplicates - [X] I've read the [guidelines for opening an issue](https://github.com/yt-dlp/yt-dlp/blob/master/CONTRIBUTING.md#opening-an-issue) - [ ] I've read about [sharing account credentials](https://github.com/yt-dlp/yt-dlp/blob/master/CONTRIBUTING.md#are-you-willing-to-share-account-details-if-needed) and I'm willing to share it if required ### Region Europe ### Provide a description that is worded well enough to be understood ReverbNation is in the list at https://github.com/yt-dlp/yt-dlp/blob/master/supportedsites.md . Trying an artist who has a "Download Free MP3" button (that works with no login), and it still doesn't work. Initially tried with `-F`. And `-vU -F` yields the same output except of course the "Command-line config". ### Provide verbose output that clearly demonstrates the problem - [X] Run **your** yt-dlp command with **-vU** flag added (`yt-dlp -vU <your command line>`) - [ ] If using API, add `'verbose': True` to `YoutubeDL` params instead - [X] Copy the WHOLE output (starting with `[debug] Command-line config`) and insert it below ### Complete Verbose Output ```shell [debug] Command-line config: ['-vU', 'https://www.reverbnation.com/morganandersson'] [debug] Encodings: locale cp65001, fs utf-8, pref cp65001, out utf-8, error utf-8, screen utf-8 [debug] yt-dlp version nightly@2024.09.08.232909 from yt-dlp/yt-dlp-nightly-builds [d1c4d88b2] (win_exe) [debug] Python 3.8.10 (CPython AMD64 64bit) - Windows-10-10.0.26100-SP0 (OpenSSL 1.1.1k 25 Mar 2021) [debug] exe versions: ffmpeg 7.0.2-essentials_build-www.gyan.dev (setts), ffprobe 7.0.2-essentials_build-www.gyan.dev [debug] Optional libraries: Cryptodome-3.20.0, brotli-1.1.0, certifi-2024.08.30, curl_cffi-0.5.10, mutagen-1.47.0, requests-2.32.3, sqlite3-3.35.5, urllib3-2.2.2, websockets-13.0.1 [debug] Proxy map: {} [debug] Request Handlers: urllib, requests, websockets, curl_cffi [debug] Loaded 1832 extractors [debug] Fetching release info: https://api.github.com/repos/yt-dlp/yt-dlp-nightly-builds/releases/latest Latest version: nightly@2024.09.08.232909 from yt-dlp/yt-dlp-nightly-builds yt-dlp is up to date (nightly@2024.09.08.232909 from yt-dlp/yt-dlp-nightly-builds) [generic] Extracting URL: https://www.reverbnation.com/morganandersson [generic] morganandersson: Downloading webpage WARNING: [generic] Falling back on generic information extractor [generic] morganandersson: Extracting information [debug] Looking for embeds [debug] Identified a twitter:player iframe [generic] Extracting URL: https://www.reverbnation.com/widget_code/html_widget/artist_1078497?widget_id=55&client_id=t23vwef5f&pwc[autoplay]=1&pwc[included_songs]=1&context_type=playlist&id_unique=artist_1078497 [generic] artist_1078497?widget_id=55&client_id=t23vwef5f&pwc[autoplay]=1&pwc[included_songs]=1&context_type=playlist&id_unique=artist_1078497: Downloading webpage [redirect] Following redirect to https://www.reverbnation.com/widget_code/html_widget/artist_1078497?widget_id=55&client_id=t23vwef5f&pwc%5Bautoplay%5D=1&pwc%5Bincluded_songs%5D=1&context_type=playlist&id_unique=artist_1078497 [generic] Extracting URL: https://www.reverbnation.com/widget_code/html_widget/artist_1078497?widget_id=55&client_id=t23vwef5f&pwc%5Bautoplay%5D=1&pwc%5Bincluded_songs%5D=1&context_type=playlist&id_unique=artist_1078497 [generic] artist_1078497?widget_id=55&client_id=t23vwef5f&pwc[autoplay]=1&pwc[included_songs]=1&context_type=playlist&id_unique=artist_1078497: Downloading webpage WARNING: [generic] Falling back on generic information extractor [generic] artist_1078497?widget_id=55&client_id=t23vwef5f&pwc[autoplay]=1&pwc[included_songs]=1&context_type=playlist&id_unique=artist_1078497: Extracting information [debug] Looking for embeds ERROR: Unsupported URL: https://www.reverbnation.com/widget_code/html_widget/artist_1078497?widget_id=55&client_id=t23vwef5f&pwc%5Bautoplay%5D=1&pwc%5Bincluded_songs%5D=1&context_type=playlist&id_unique=artist_1078497 Traceback (most recent call last): File "yt_dlp\YoutubeDL.py", line 1626, in wrapper File "yt_dlp\YoutubeDL.py", line 1761, in __extract_info File "yt_dlp\extractor\common.py", line 740, in extract File "yt_dlp\extractor\generic.py", line 2526, in _real_extract yt_dlp.utils.UnsupportedError: Unsupported URL: https://www.reverbnation.com/widget_code/html_widget/artist_1078497?widget_id=55&client_id=t23vwef5f&pwc%5Bautoplay%5D=1&pwc%5Bincluded_songs%5D=1&context_type=playlist&id_unique=artist_1078497 ```
site-enhancement,triage
low
Critical
2,515,962,217
TypeScript
Template literal type derived from string is not a subtype of the TLT derived from any
### 🔎 Search Terms "template literal type", "any", "string", "mutually assignable types" ### 🕗 Version & Regression Information - This changed between versions 4.1.5 and 4.2.3 - This changed in commit or PR 411c6d04c6007cd3bb74ef0ce6cc11e8c699a2b5 (reported by every-ts) ### ⏯ Playground Link https://www.typescriptlang.org/play/?ts=4.2.3#code/C4TwDgpgBA4g9nAJgRigXigAwCQG8B2ArgLYBGEATgL6ZQQAewE+iAzlngIb4g1QD8UYBULQAXFABmnADasIAbigB6ZUJEQAUKEiwEiAEzoOuUgEsA5mfzA+DJi3Y5c3XrUHDRUCdLmKVap5aOtDwSADMxs6kCDIQ3HaMzGwmrnweGt5SsvJKquqi2uCh+gAsUXhEMjKJDinOae4F4tl+eYEaRbphiACsFbiELBCS1hCItclOXDzpzVm+uQHNml3QAEKcKAOswtYWk46ps01BCzn++WfWUKUAdMh3vQA0rfJQN-cGd+FrUJuGHZ7fAWKAAHygRDIlHBUHMVhssJicDi3FhVRksKGiBGYwmtHsU2ObgE8x8F3a80+Dyer0W0Gp31+mgAxnB8LsoHAANYSBonYwAcmQgqgnGmBBI5GomAUmnyAHluR98LcaS8oGziGAZJxrOxGT9WezOWZWKxRHyZiSMMLReKTLsKPsaHKgA ### 💻 Code ```ts type Good1 = `${number}` extends `${any}` ? true : false; // true type Good2 = `${bigint}` extends `${any}` ? true : false; // true type Good3 = `${boolean}` extends `${any}` ? true : false; // true type Good4 = `${null}` extends `${any}` ? true : false; // true type Good5 = `${undefined}` extends `${any}` ? true : false; // true type Bad1 = `${string}` extends `${any}` ? true : false; // true in 4.1.5, false in 4.2.3 type Bad2 = `${string | number | bigint | boolean | null | undefined}` extends `${any}` ? true : false; // true in 4.1.5, false in 4.2.3 const ok: `${any}` = '1' as `${number}`; // Ok in 4.1.5, complains in 4.2.3 const issue: `${any}` = '1' as `${string}`; ``` ### 🙁 Actual behavior Type 'string' is not assignable to type '`${any}`'.(2322) ### 🙂 Expected behavior Should compile with no errors, since `` `${any}` `` and `string` should be the same type (or at least mutually assignable). ### Additional information about the issue Proposed solution: simplify the type `` `${any}` `` to `string` like it is done with the `` `${string}` `` type. Rationale: for any type `X` that is either concrete or generic (with a restriction to valid arguments of a template literal type) the type `` `${string|X}` `` simplifies to `string`. Therefore, if TypeScript strives to any consistency, we would expect `` `${string|any}` `` (i.e. `` `${any}` ``) to also simplify to `string`. I have no idea why we currently have `` `${any}` extends `${number}` `` true (which could break with my suggestion if no other changes are made), but this bug report is not concerted with this. I'm leaving this up to the maintainers. Proposed solution 2: Just make `` string extends `${any}` `` and `` `${any}` extends string `` true.
Help Wanted,Possible Improvement
low
Critical
2,515,962,957
material-ui
[Stepper] Lacks accessibility
### Summary When navigating the [Stepper](https://mui.com/material-ui/react-stepper/#linear) component with voice assistant and keyboard-only navigation, it doesn't read out which step you're currently in when you go to the next step. It also doesn't hint the user how many steps there are in total. ### Examples _No response_ ### Motivation _No response_ **Search keywords**: Stepper lacks accessibility
accessibility,component: stepper,package: material-ui
low
Minor
2,515,994,962
deno
`FileHandle` missing methods
FileHandle class (in `node:fs/promises`) still misses the below methods: ref: https://nodejs.org/api/fs.html#class-filehandle - [ ] Event: 'close' - [ ] filehandle.appendFile(data[, options]) - [x] filehandle.chmod(mode) #27522 - [ ] filehandle.chown(uid, gid) #27638 - [x] filehandle.close() https://github.com/denoland/deno/pull/19357 - [ ] filehandle.createReadStream([options]) #27591 - [ ] filehandle.createWriteStream([options]) - [ ] filehandle.datasync() - [x] filehandle.fd - [x] filehandle.read(buffer, offset, length, position) #19359 - [x] filehandle.read([options]) #19359 - [x] filehandle.read(buffer[, options]) #19359 - [ ] filehandle.readableWebStream(options) - [x] filehandle.readFile(options) - [ ] filehandle.readLines([options]) - [ ] filehandle.readv(buffers[, position]) - [x] filehandle.stat([options]) #26719 - [ ] filehandle.sync() - [x] filehandle.truncate(len) #27389 - [x] filehandle.utimes(atime, mtime) #27582 - [x] filehandle.write(buffer, offset[, length[, position]]) #19385 - [x] filehandle.write(string[, position[, encoding]]) #19385 - [x] filehandle.writeFile(data, options) #25555 - [x] filehandle.writev(buffers[, position]) #27563 _Originally posted by @k-nasa in https://github.com/denoland/deno/issues/19165#issuecomment-1574509694_
bug,good first issue,node compat
low
Major
2,516,077,608
electron
[Bug]: SaveDialog is not treating Package as File when setting defaultPath to a file that already exists
### Preflight Checklist - [X] I have read the [Contributing Guidelines](https://github.com/electron/electron/blob/main/CONTRIBUTING.md) for this project. - [X] I agree to follow the [Code of Conduct](https://github.com/electron/electron/blob/main/CODE_OF_CONDUCT.md) that this project adheres to. - [X] I have searched the [issue tracker](https://www.github.com/electron/electron/issues) for a bug report that matches the one I want to file, without success. ### Electron Version 32.0.0 ### What operating system(s) are you using? macOS ### Operating System Version macOS Sonoma 14.6.1 ### What arch are you using? arm64 (including Apple Silicon) ### Last Known Working Electron version _No response_ ### Expected Behavior When using the saveDialog, if the path is set to an existing file (package) the the file should not be selectable and the "file already Existing" warning should appear instead. ### Actual Behavior To test this - you can point the saveDialog defaultPath to any existing package file (i.e. xcodeproj) `dialog.showSaveDialog({ defaultPath: YOUR_PATH_TO_EXISTING_PACKAGE_FILE.xcodeproj, properties: [], filters: { name: 'directories', extensions: [] }, // to prevent file selection properties: ['showOverwriteConfirmation'] })` You see that the dialog then selects the package (as if it was a directory) and shows its content. Also if the extension is removed, then it also does not detect it as a duplicate file. Any info or guidance to how to resolve is appreciated. ### Testcase Gist URL _No response_ ### Additional Information _No response_
platform/macOS,bug :beetle:,has-repro-gist,stale,32-x-y
low
Critical
2,516,117,140
flutter
[go_router] Different widget sizing behavior in ShellRoute
### Steps to reproduce The output of the UI differs depending on if I provide the Scaffolds body widget **directly** in the ShellRoute or via the **child** parameter from the **ShellRouteBuilder** method. 1. Run the example code with initialLocation set to **/page1**. 2. Run the example code with initialLocation set to **/page2**. 3. Run the example code with initialLocation set to **/page3**. 4. Run the example code with initialLocation set to **/page4**. ### Expected results I would expect that **/page1** would result the same UI as in **/page2** and **/page3** would result the same UI as in **/page4**. ### Actual results The UI differs in **/page1** taking the full size, but **/page2** it doesn't. **/page3** and **/page4** has the same UI as expected. ### Code sample <details open><summary>Code sample</summary> ```dart import 'package:flutter/material.dart'; import 'package:go_router/go_router.dart'; void main() { runApp(const MyApp()); } class MyApp extends StatelessWidget { const MyApp({super.key}); static final _config = GoRouter( initialLocation: '/page1', routes: [ // ShellRoute with AppBar and body set to child. ShellRoute( builder: (context, state, child) => Scaffold( appBar: AppBar( title: const Text('Example'), ), body: child, ), routes: [ GoRoute( path: '/page1', builder: (_, __) => const Card.filled(), ), ], ), // ShellRoute with AppBar and body set to Card.filled. ShellRoute( builder: (context, state, child) => Scaffold( appBar: AppBar( title: const Text('Example'), ), body: const Card.filled(), ), routes: [ GoRoute( path: '/page2', builder: (_, __) => const Card.filled(), ), ], ), // ShellRoute without AppBar and body set to child. ShellRoute( builder: (context, state, child) => Scaffold( body: child, ), routes: [ GoRoute( path: '/page3', builder: (_, __) => const Card.filled(), ), ], ), // ShellRoute without AppBar and body set to Card.filled. ShellRoute( builder: (context, state, child) => const Scaffold( body: Card.filled(), ), routes: [ GoRoute( path: '/page4', builder: (_, __) => const Card.filled(), ), ], ), ], ); @override Widget build(BuildContext context) { return MaterialApp.router( routerConfig: _config, ); } } ``` </details> ### Screenshots or Video <details open> <summary>Screenshots / Video demonstration</summary> # ShellRoute with AppBar and body set to child (/page1) <img src="https://github.com/user-attachments/assets/515ccca2-1fb1-4008-b5c7-6da8cedff737" height="500" /> # ShellRoute with AppBar and body set to Card.filled (/page2) <img src="https://github.com/user-attachments/assets/e3016eb5-d437-4ddb-aba6-bce25338dc02" height="500" /> # ShellRoute without AppBar and body set to child (/page3) <img src="https://github.com/user-attachments/assets/764e9668-b95a-4980-b707-fcaee7f7bd24" height="500" /> # ShellRoute with AppBar and body set to child (/page4) <img src="https://github.com/user-attachments/assets/63356fd3-e0b2-4d92-aef6-d9ee716a65f7" height="500" /> </details> ### Logs _No response_ ### Flutter Doctor output <details open><summary>Doctor output</summary> ```console [✓] Flutter (Channel stable, 3.24.2, on macOS 14.6.1 23G93 darwin-x64, locale de-DE) • Flutter version 3.24.2 on channel stable at /Users/huynh/.asdf/installs/flutter/3.24.2-stable • Upstream repository https://github.com/flutter/flutter.git • Framework revision 4cf269e36d (vor 7 Tagen), 2024-09-03 14:30:00 -0700 • Engine revision a6bd3f1de1 • Dart version 3.5.2 • DevTools version 2.37.2 [✓] Android toolchain - develop for Android devices (Android SDK version 34.0.0) • Android SDK at /Users/huynh/Library/Android/sdk • Platform android-34, build-tools 34.0.0 • ANDROID_HOME = /Users/huynh/Library/Android/sdk • Java binary at: /Users/huynh/Applications/Android Studio.app/Contents/jbr/Contents/Home/bin/java • Java version OpenJDK Runtime Environment (build 17.0.11+0-17.0.11b1207.24-11852314) • All Android licenses accepted. [✓] Xcode - develop for iOS and macOS (Xcode 15.4) • Xcode at /Applications/Xcode.app/Contents/Developer • Build 15F31d • CocoaPods version 1.15.2 [✓] Chrome - develop for the web • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome [✓] Android Studio (version 2024.1) • Android Studio at /Users/huynh/Applications/Android Studio.app/Contents • Flutter plugin can be installed from: 🔨 https://plugins.jetbrains.com/plugin/9212-flutter • Dart plugin can be installed from: 🔨 https://plugins.jetbrains.com/plugin/6351-dart • Java version OpenJDK Runtime Environment (build 17.0.11+0-17.0.11b1207.24-11852314) [✓] IntelliJ IDEA Ultimate Edition (version 2024.2.1) • IntelliJ at /Users/huynh/Applications/IntelliJ IDEA Ultimate.app • Flutter plugin version 81.1.3 • Dart plugin version 242.21829.3 [✓] VS Code (version 1.92.2) • VS Code at /Applications/Visual Studio Code.app/Contents • Flutter extension version 3.94.0 [✓] Connected device (3 available) • iPhone 13 mini (mobile) • 9EC9B697-54E5-49AB-9F44-4D997DFDBE20 • ios • com.apple.CoreSimulator.SimRuntime.iOS-17-5 (simulator) • macOS (desktop) • macos • darwin-x64 • macOS 14.6.1 23G93 darwin-x64 • Chrome (web) • chrome • web-javascript • Google Chrome 128.0.6613.120 ! Error: Browsing on the local area network for cosee iPhone 12 . Ensure the device is unlocked and attached with a cable or associated with the same local area network as this Mac. The device must be opted into Developer Mode to connect wirelessly. (code -27) [✓] Network resources • All expected network resources are available. • No issues found! ``` </details>
package,has reproducible steps,P2,p: go_router,team-go_router,triaged-go_router,found in release: 3.24,found in release: 3.25
low
Critical
2,516,164,232
terminal
[Windows Terminal]: Screen reader is just announcing a single character information while navigating using ctrl + left/right arrow keys in mark mode.
### Windows Terminal version 1.22.2362.0 ### Windows build number 27695.1000 ### Other Software Test Environment: OS: Windows 11 Version Dev (OS Build 27695.1000) App: Windows Terminal Preview Screen Reader: Narrator ### Steps to reproduce **Repro steps :** 1.Open Windows Terminal. 2.Navigate to the editor. 3.Turn on Narrator by pressing 'Ctrl + Windows + Enter' keys. 4.Now turn on mark mode by pressing 'Ctrl + Shift + M' keys. 5. Now navigate among words using 'Ctrl + Left/Right' keys. 6.Observe the screen reader narration here. **Observation using NVDA and JAWS screen reader:** Same issue repro with NVDA and JAWS screen reader also. **User Experience** Users who rely on screen reader may not get the info properly while navigating in mark mode. **WCAG Reference Link:** https://www.w3.org/WAI/WCAG21/Understanding/info-and-relationships **Attachment :** [Screen reader is not announcing full word information while navigating via ctrl + left_right arrow keys.zip](https://github.com/user-attachments/files/16943981/Screen.reader.is.not.announcing.full.word.information.while.navigating.via.ctrl.%2B.left_right.arrow.keys.zip) ### Expected Behavior Screen reader should narrate complete word information while navigating using ctrl + left/right arrow keys in mark mode. ### Actual Behavior Screen reader is just announcing a single character information while navigating using ctrl + left/right arrow keys in mark mode. For example: For word "Microsoft", screen reader is just announcing as 'M selected' when we navigate using 'Ctrl + Left' arrow key and announces as 't selected' using 'Ctrl + Right' arrow.
Issue-Bug,Area-Accessibility,Product-Terminal,In-PR,HCL-E+D,A11yWCAG,HCL-WindowsTerminal,A11ySev2
low
Major
2,516,269,155
TypeScript
Improve Iterator Helper Type Signatures
### ⚙ Compilation target ESNext ### ⚙ Library esnext.iterator.d.ts ### Missing / Incorrect Definition - [x] `Iterator.from(value: Iterator)` - PR #59927 - [x] ~`value` iterator argument with `TNext` other than `undefined` should be accepted;~ this is a bad idea; my mistake - [ ] Since `IteratorObject` instances (objects whose prototype is `Iterator.prototype`) are not wrapped by `Iterator.from`, we could add an `Iterator.from` overload to represent those cases and pass through all generic type parameters: `from<T, TReturn = any, TNext = any>(value: IteratorObject<T, TReturn, TNext>): IteratorObject<T, TReturn, TNext>;` - [x] `TReturn` type should be passed through from the argument to the return type - [x] Iterator helper intermediate operators (`filter`, `map` etc) do not propagate the return value of their source iterator and should have `TReturn` set to `undefined` - [x] This is already the case in the current declarations - [x] ~Iterator objects returned from `Iterator.from` and the other built-in iterators returned from `Array.values` etc always have a `return` method (built-in iterators returned from `Array.values` etc also always have a `throw` method)~ thanks to @bakkot for the clarification - [x] There is no way that I am aware of to express this behavior in TypeScript with the current definition of `IteratorObject` without also forcing user-defined classes extending from the javascript `Iterator` class to also implement the `return` method, which would be wrong. The impact on client code is minimal as the Iterator object's `return` method can always be called safely using the `return!()` notation. ### Sample Code ```TypeScript https://github.com/nikolaybotev/iteratorhelpersdemo ``` ### Documentation Link https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Iterator and https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Iteration_protocols
Needs Investigation
low
Major
2,516,276,229
rust
Deadlock when capturing a backtrace from allocator during panic with test output capturing enabled
I tried this code (minimized from a larger testcase): ```rust use std::alloc::{GlobalAlloc, Layout}; use std::cell::Cell; use std::backtrace::Backtrace; use std::thread_local; thread_local! { static CAN_ALLOCATE: Cell<bool> = const { Cell::new(true) }; } #[derive(Debug)] pub struct NoAllocate(std::alloc::System); unsafe impl GlobalAlloc for NoAllocate { unsafe fn alloc(&self, layout: Layout) -> *mut u8 { if !CAN_ALLOCATE.replace(true) { let _ = Backtrace::force_capture(); } self.0.alloc(layout) } unsafe fn dealloc(&self, ptr: *mut u8, layout: Layout) { self.0.dealloc(ptr, layout); } } #[global_allocator] static GLOBAL: NoAllocate = NoAllocate(std::alloc::System); #[test] #[should_panic] fn main() { CAN_ALLOCATE.set(false); panic!(); } ``` Compiled with `rustc --test main.rs`. I expected to see this happen: the test successfully panics and exits. Instead, this happened: the test deadlocks. Relevant section of backtrace: ``` ... #4 std::sync::mutex::Mutex::lock<()> () at std/src/sync/mutex.rs:317 #5 std::sys::backtrace::lock () at std/src/sys/backtrace.rs:18 #6 std::backtrace::Backtrace::create () at std/src/backtrace.rs:326 #7 0x0000555555585b25 in std::backtrace::Backtrace::force_capture () at std/src/backtrace.rs:312 #8 0x000055555556ab52 in <main::NoAllocate as core::alloc::global::GlobalAlloc>::alloc () #9 0x000055555556ac45 in __rust_alloc () ... #15 alloc::vec::Vec::reserve<u8, alloc::alloc::Global> () at alloc/src/vec/mod.rs:973 ... #22 0x00005555555879a3 in std::io::Write::write_fmt<alloc::vec::Vec<u8, alloc::alloc::Global>> () at std/src/io/mod.rs:1823 #23 0x000055555558aeb7 in std::panicking::default_hook::{closure#1} () at std/src/panicking.rs:256 ``` This is specifically related to output capturing from the test runner, running the same code as a non-test binary or with `--nocapture` works perfectly. ### Meta This worked in `1.80.1` and `nightly-2024-07-13`, it started failing in `1.81.0` and `nightly-2024-07-14`. The deadlock was introduced by https://github.com/rust-lang/rust/pull/127397 (cc @jyn514). The lock is first taken when starting to print from the default panic hook: https://github.com/rust-lang/rust/blob/26b2b8d162ff6cc399c7e8005230beea7eb12037/library/std/src/panicking.rs#L257 The first print to the output then happens: https://github.com/rust-lang/rust/blob/26b2b8d162ff6cc399c7e8005230beea7eb12037/library/std/src/panicking.rs#L258 For captured output this requires then reallocating the `Vec` storing the capture, so it calls into the allocator, hitting the `Backtrace::force_capture` because this is the first allocation in the test. This attempts to re-entrantly acquire the lock a second time, deadlocking: https://github.com/rust-lang/rust/blob/26b2b8d162ff6cc399c7e8005230beea7eb12037/library/std/src/backtrace.rs#L326
regression-from-stable-to-stable,C-bug,A-backtrace
low
Critical
2,516,284,759
rust
[discussion] `ErrorKind::FilesystemLoop` from `io_error_more`
@rustbot label C-discussion Main tracking issue: #86442 ## Background The [`io_error_more` feature](https://github.com/rust-lang/rust/issues/86442) introduced 21 new variants into [`ErrorKind`](https://doc.rust-lang.org/nightly/std/io/enum.ErrorKind.html). They were [FCP'd back in December 2022](https://github.com/rust-lang/rust/issues/86442#issuecomment-1368082102), but there appeared to be quite a lot of disagreement about 4 of the added variants, so the stabilization (#106375) got stalled for over twenty months. Thankfully, the 17 uncontroversial variants got stabilized in #128316, so now we just need to iron out a satisfactory design for the remaining 4 variants, and then they can be stabilized too. In order to not block any of the remaining variants on each other and to not intertwine the discussions, I've created 4 separate issues, which summarize the concerns & suggestions voiced up until this point and can serve as a place for further discussion. - `FilesystemLoop`: you are here - `FilesystemQuotaExceeded`: #130190 - `CrossesDevices`: #130191 - `InvalidFilename`: #130192 # `FilesystemLoop` Currently corresponds to `ELOOP` on Unix and ~nothing~ `ERROR_CANT_RESOLVE_FILENAME` on Windows. (https://github.com/rust-lang/rust/issues/86442#issuecomment-1235763183, #130207) Current docs description: > Loop in the filesystem or IO subsystem; often, too many levels of symbolic links. > > There was a loop (or excessively long chain) resolving a filesystem object or file IO object. > > On Unix this is usually the result of a symbolic link loop; or, of exceeding the system-specific limit on the depth of symlink traversal. ## ~Make it correspond to `ERROR_CANT_RESOLVE_FILENAME` on Windows~ Done in #130207 <details> <summary>Old description</summary> > for `ELOOP`, Windows appears to give `winapi::shared::winerror::ERROR_CANT_RESOLVE_FILENAME` in similar situations (e.g. symlink loops). Could we add that in, or perhaps generalise `FileSystemLoop` to the slightly more general case of being unable to resolve? _Originally posted by Robert Collins in https://github.com/rust-lang/rust/issues/86442#issuecomment-1328334824_ In https://github.com/rust-lang/rust/issues/86442#issuecomment-1360188402 Ian Jackson voices a concern that this might not be the only place where `ERROR_CANT_RESOLVE_FILENAME` appears. Chris Denton in https://github.com/rust-lang/rust/issues/86442#issuecomment-1360288630 and Robert Collins in https://github.com/rust-lang/rust/issues/86442#issuecomment-1367167550 confirm that this is the only place where Windows currently gives `ERROR_CANT_RESOLVE_FILENAME` and that there is a good correspondence with Unix's `ELOOP` (when it comes to symlikns, see below for the other usages of `ELOOP`). Ian Jackson agrees with them in https://github.com/rust-lang/rust/pull/106375#issuecomment-1369656136, but proposes this should be done separately from stabilization. There seems to be a consensus regarding this point. </details> ## Bikshed the name: be about loops in general, drop "filesystem" from the name Unix's `ELOOP` is not just for symlink loops (or too long symlink chains). > ELOOP itself isn't returned solely when loops are detected. Add to that list mount(2) returning ELOOP for move operations where the `target` is a child of the `source` - something that has absolutely nothing to do with symlinks, and `execve` returning ELOOP for exceeding recursion limits during recursive script execution (since Linux 3.8). > > * because OS errors are moving targets, we cannot assume Linux / BSD / others will not introduce a 5th or 6th meaning, and its clear to me at least that Linux doesn't treat ELOOP as a filesystem error but a more general error. > > I suggest renaming it to `LoopError`, but document that it means ELOOP on Linux and `ERROR_CANT_RESOLVE_FILENAME` on Windows, and either describe what we know right now, or provide breadcrumbs for readers to catch up. _Originally posted by Robert Collins in https://github.com/rust-lang/rust/issues/86442#issuecomment-1367167550_ > I have a mild preference for renaming `FilesystemLoop` to something that doesn't include `Filesystem`, for the same reason: OSes *do* use it for other errors. For instance, Linux also uses it for keyrings, BPF, network routing/filtering, vhost, and network bridges. _Originally posted by Josh Triplett in https://github.com/rust-lang/rust/issues/106375#issuecomment-1371870620_ > I disagree with renaming `FilesystemLoop`. > > It is true that Unix has a tendency to reuse errno values, so that any particular errno value can often mean a variety of things. Particularly, less-common (even, obscure) APIs and facilities (ab)use errno values. Attempting to represent all these obscure possibilities leads to descriptions and categorisations that are vague and overlapping. We generally haven't done that and I don't think we should start now. (All of this was discussed at length in the earlier conversations in the tracking issue.) > > The APIs available in std will produce this error for filesystem operations, not obscure other purposes. I think calling it `FilesystemLoop` is sensible. _Originally posted by Ian Jackson in https://github.com/rust-lang/rust/pull/106375#issuecomment-1372131054_ ## Bikeshed the name: be about symlink resolution failure in general, stop mentioning loops > some system calls on Linux also use `ELOOP` to mean "ELOOP A loop exists in symbolic links encountered during resolution of the path argument, or O_NOFOLLOW was specified and the path argument names a symbolic link." so I think interpreting it as "symlink loop or similar symlink resolve error was encountered" might be an accurate description, although (bike-shedding!) I don't know if `FilesystemLoop` is an accurate name then, and not something like `SymlinkResolutionFailed` or such... _Originally posted by Alain Emilia Anna Zscheile in https://github.com/rust-lang/rust/issues/86442#issuecomment-1360459049_
T-libs-api,C-discussion
low
Critical
2,516,292,213
rust
[rustdoc] type aliases in function signatures can be confusing
### Location https://doc.rust-lang.org/std/io/struct.Lines.html ### Summary https://doc.rust-lang.org/std/io/struct.Lines.html states that Lines::fmt has a return value of "Result" whereas https://doc.rust-lang.org/std/fmt/trait.Debug.html#tymethod.fmt says that fmt has a return value of "Result<(),E>"
T-rustdoc,C-discussion
low
Critical
2,516,323,737
storybook
[Bug]: Doc Blocks missing after using @storybook/angular:build-storybook
### Describe the bug Hello all. I have a bunch of stories with mdx files, and when running locally everything works as expected. I can browse the custom docs from mdx and stories for the components (I can see Docs in the menu under each components entry). Now when using @storybook/angular:build-storybook builder to get static assets, and hosting them on our server, the Docs entry is gone. It feels like mdx are ignored in the build. No concrete errors in the console. ### Reproduction link Not available ### Reproduction steps Not available as this is build and deployment related. ### System ```bash npmPackages: @storybook/addon-a11y: ^8.2.8 => 8.2.9 @storybook/addon-actions: ^8.2.8 => 8.2.9 @storybook/addon-designs: ^8.0.3 => 8.0.3 @storybook/addon-docs: ^8.2.8 => 8.2.9 @storybook/addon-essentials: ^8.2.8 => 8.2.9 @storybook/addon-interactions: ^8.2.8 => 8.2.9 @storybook/addon-links: ^8.2.8 => 8.2.9 @storybook/angular: ^8.2.8 => 8.2.9 @storybook/blocks: ^8.2.8 => 8.2.9 @storybook/preset-scss: ^1.0.3 => 1.0.3 @storybook/test: ^8.2.8 => 8.2.9 chromatic: ^11.3.1 => 11.7.0 eslint-plugin-storybook: ^0.8.0 => 0.8.0 storybook: ^8.2.8 => 8.2.9 @angular/common: 17.0.8, @angular/compiler: 17.0.8, @angular/core: 17.0.8, ``` ### Additional context Using angular v17 Build config **angular.json** ``` "build-storybook": { "builder": "@storybook/angular:build-storybook", "options": { "configDir": ".storybook", "browserTarget": "{mypage}:build", "outputDir": "dist/storybook/{mypage}" } }, ``` **main.js** storybook config ``` module.exports = { stories: ['../src/app/**/*.mdx', '../src/app/**/*.stories.@(js|jsx|ts|tsx)'], addons: [ '@storybook/addon-links', '@storybook/addon-essentials', '@storybook/addon-interactions', '@storybook/addon-a11y', '@storybook/addon-designs', '@storybook/preset-scss', '@storybook/addon-docs', ], framework: { name: '@storybook/angular', options: {}, }, features: { interactionsDebugger: true, }, test: { disableBlocks: false, disableMDXEntries: false, } }; ``` Example Story **badge.component.stories.ts**: ``` export default { title: 'Components/badge', component: BadgeComponent, decorators: [ moduleMetadata({ declarations: [IconComponent], }), ], parameters: { docs: { description: { component: 'Badge component', }, }, }, argTypes: { label: { control: { type: 'text', }, }, size: { options: [Sizes.sm, Sizes.md, Sizes.lg], control: { type: 'radio', }, }, color: { options: [ Colors.primary, Colors.light, Colors.green, Colors.red, Colors.grey, ], control: { type: 'radio', }, }, }, } as Meta<BadgeComponent>; export const Default: StoryObj<BadgeComponent> = { args: { icon: 'bell', label: 'Badge', size: 'md', }, }; ``` Example markdown file **badge.component.mdx** ``` import { Canvas, Controls, Description, Meta, Story, Subtitle, } from '@storybook/blocks'; import * as BadgeStories from './badge.component.stories.ts'; import { BadgeComponent } from './badge.component.ts'; <Meta of={BadgeStories} title='badge' component={HvBadgeComponent}/> <Subtitle>component: ___hv-badge.component.ts___ <br/>selector: ___app-hv-badge___</Subtitle> Badge component. <Controls /> ```
bug,needs triage
low
Critical
2,516,381,542
PowerToys
Workspaces can close software
### Description of the new feature / enhancement I would like workspaces to not only open software, but also close software. Sort of a "this is my programming workspace" or "This is my triage emails workspace" or "This is my, share my screen workspace" ### Scenario when this would be used? I could see this being used by people looking to increase productivity, share screens, in conference rooms, etc. I think the workspace idea is a great thing, and it just needs a little bit of features fleshed. Something I'm sure is inbound anyway as it _just_ released. Thanks! 😀 ### Supporting information Nothing specific really - just thought it would be nice to have
Idea-Enhancement,Needs-Triage,Product-Workspaces
low
Minor
2,516,395,641
flutter
[image_picker] Support option for already selected images in ImagePicker().pickMultiImage()
### Use case Currently, pickMultiImage() returns a [List] object with the Images that were picked. When selecting multiple Images, sometimes you might need to let the user preview the images before saving them in state. If the user wants to edit the selected images, calling the ImagePicker().pickMultiImage() function again does not save the previously selected images. This function should have an optional parameter for already selected images, so that when the new native Galery view is opened, the images that were selected from a previous state are marked with selected. ### Proposal Adding an optional parameter for selected images (maybe a [List<Object>] for already selected images should add more functionality to this flow.
c: new feature,p: image_picker,package,c: proposal,team-ecosystem,P3,triaged-ecosystem
low
Major
2,516,422,717
godot
`TileMapLayer` build-in navigation prints `navigation_map.is_null()` errors on builds with `disable_3d=true`
### Tested versions 4.3.stable.mono ### System information Godot v4.3.stable.mono - macOS 14.6.1 - GLES3 (Compatibility) - Apple M2 - Apple M2 (8 Threads) ### Issue description When running an iOS app built using a custom export template with disable_3d = "yes", the following errors appear in the Xcode output window: `ERROR: Condition "navigation_map.is_null()" is true. at: _navigation_update_cell (scene/2d/tile_map_layer.cpp:1031)` One message appears for every tile added to a TileMapLayer in a 2D Godot project. Although these errors do not appear to cause any problems, a lot of output is generated for projects with a large number of levels. ### Steps to reproduce Reproducible with a minimal Godot project. No code, just a TileMapLayer scene with a number of tiles added. ### Minimal reproduction project (MRP) N/A
bug,topic:navigation,topic:2d
low
Critical
2,516,442,580
rust
[discussion] `ErrorKind::InvalidFilename` from `io_error_more`
@rustbot label C-discussion Main tracking issue: #86442 ## Background The [`io_error_more` feature](https://github.com/rust-lang/rust/issues/86442) introduced 21 new variants into [`ErrorKind`](https://doc.rust-lang.org/nightly/std/io/enum.ErrorKind.html). They were [FCP'd back in December 2022](https://github.com/rust-lang/rust/issues/86442#issuecomment-1368082102), but there appeared to be quite a lot of disagreement about 4 of the added variants, so the stabilization (#106375) got stalled for over twenty months. Thankfully, the 17 uncontroversial variants got stabilized in #128316, so now we just need to iron out a satisfactory design for the remaining 4 variants, and then they can be stabilized too. In order to not block any of the remaining variants on each other and to not intertwine the discussions, I've created 4 separate issues, which summarize the concerns & suggestions voiced up until this point and can serve as a place for further discussion. - `FilesystemLoop`: #130188 - `FilesystemQuotaExceeded`: #130190 - `CrossesDevices`: #130191 - `InvalidFilename`: you are here # `InvalidFilename` Currently corresponds to `ENAMETOOLONG` on Unix, `ERROR_FILENAME_EXCED_RANGE` & `ERROR_INVALID_NAME` on Windows. (https://github.com/rust-lang/rust/issues/86442#issuecomment-1235763183) Current docs description: > A filename was invalid. > > This error can also cause if it exceeded the filename length limit. ## Docs I'm not sure "_This error can also cause if it exceeded the filename length limit._" is well-formed coherent English, but I'm not a native speaker. ## Name capitalization > std uses `file_name` in functions, rather than `filename`. It'd be odd to break correspondence between snake_case and CamelCase, so I think this should be `FileNameTooLong` to match. Same goes for `InvalidFileName`. _Originally posted by Kornel in https://github.com/rust-lang/rust/pull/79965#discussion_r1059215891_ ## Separate "the name is too long" case > I might be a little too late, but I'm not sure combining `ERROR_FILENAME_EXCED_RANGE` and `ERROR_INVALID_NAME` into `InvalidFilename` is a good idea. What was the reason behind this decision? > > For example if one is writing an unarchiver to extract files, if a filename is too long one could simply truncate the filename and tell the user this. But if the filename is invalid/reserved (eg. COM) then the name would have to be completely different. > > An app could guess which of the two it is, but it would be more straightforward if the two are distinguished from the start. _Originally posted by cktkw in https://github.com/rust-lang/rust/issues/86442#issuecomment-1441480697_ There is a long reply from Aritz Beobide-Cardinal in https://github.com/rust-lang/rust/issues/106375#issuecomment-1959633299 arguing against the separation. ## Map more raw os errors to this `ErrorKind` > I was speculating there might be an OS that returns "Invalid Filename" when the filename is too long. In which case, this decision will make sense. But otherwise, "Filename Too Long" is one of the few errors that seem to be consistent among platforms. > > With current PR, Unix doesn't have `InvalidFilename` mapped to anything else (at least from my quick skim through `sys/unix/mod.rs`). > However, UNIX-like OS fails with varying error when invalid UTF-8 filename is used to `open()` in C. > Mac APFS fails with `EILSEQ` (Illegal byte sequence). > Linux EXT4 (formatted with strict case-insensitive option `-O casefold -E encoding_flags=strict`, because otherwise any byte sequence is allowed) fails with `EINVAL`(invalid argument). > > In theory, I think these should be mapped to `InvalidFilename` in the context of `File::open()`, `File::create()`, etc. But I understand that that would need major rewrite. I don't know enough to say what would be the best way, but current use of `InvalidFilename` doesn't feel optimal. _Originally posted by cktkw in https://github.com/rust-lang/rust/issues/86442#issuecomment-1441709738_
T-libs-api,proposed-final-comment-period,disposition-merge,C-discussion
low
Critical
2,516,455,072
langchain
DOC: Description of `kwargs` in `langchain_core.prompts.chat.HumanMessagePromptTemplate.from_template_file()` misleading
### URL https://api.python.langchain.com/en/latest/prompts/langchain_core.prompts.chat.HumanMessagePromptTemplate.html ### Checklist - [X] I added a very descriptive title to this issue. - [X] I included a link to the documentation page I am referring to (if applicable). ### Issue with current documentation: The documentation for the class method `from_template_file()` for the class `langchain_core.prompts.chat.HumanMessagePromptTemplate` is misleading, since it states that `kwargs` are "keyword arguments to pass to the constructor". However this is not true. `kwargs` will be passed to `from_template()`, which means that `partial_variables` will **not** be passed to the constructor, but will be handled by `from_template`. ### Idea or request for content: The description "keyword arguments to pass to the constructor." should probably be changed to "keyword arguments to pass to `from_template`.". Note that there might be more alternative constructors that suffer from this problem.
🤖:docs
low
Major
2,516,460,020
go
runtime: crash when ending checkmarks
<!-- Please answer these questions before submitting your issue. Thanks! --> ### What version of Go are you using (`go version`)? <pre> $ go version go version devel go1.24-f3b0219 Tue Aug 27 21:02:02 2024 +0000 darwin/amd64 </pre> ### Does this issue reproduce with the latest release? ### What operating system and processor architecture are you using (`go env`)? <details><summary><code>go env</code> Output</summary><br><pre> $ go env GO111MODULE='' GOARCH='amd64' GOBIN='' GOCACHE='/Users/mm/Library/Caches/go-build' GOENV='/Users/mm/Library/Application Support/go/env' GOEXE='' GOEXPERIMENT='' GOFLAGS='' GOHOSTARCH='amd64' GOHOSTOS='darwin' GOINSECURE='' GOMODCACHE='/Users/mm/go/pkg/mod' GONOPROXY='' GONOSUMDB='' GOOS='darwin' GOPATH='/Users/mm/go' GOPRIVATE='' GOPROXY='https://proxy.golang.org,direct' GOROOT='/Users/mm/go/src/github.com/MikeMitchellWebDev/go_checkmark' GOSUMDB='sum.golang.org' GOTMPDIR='' GOTOOLCHAIN='auto' GOTOOLDIR='/Users/mm/go/src/github.com/MikeMitchellWebDev/go_checkmark/pkg/tool/darwin_amd64' GOVCS='' GOVERSION='devel go1.24-f3b0219 Tue Aug 27 21:02:02 2024 +0000' GODEBUG='' GOTELEMETRY='local' GOTELEMETRYDIR='/Users/mm/Library/Application Support/go/telemetry' GCCGO='gccgo' GOAMD64='v1' AR='ar' CC='/usr/bin/clang' CXX='clang++' CGO_ENABLED='1' GOMOD='/Users/mm/go/src/github.com/MikeMitchellWebDev/go_checkmark/src/go.mod' GOWORK='' CGO_CFLAGS='-O2 -g' CGO_CPPFLAGS='' CGO_CXXFLAGS='-O2 -g' CGO_FFLAGS='-O2 -g' CGO_LDFLAGS='-O2 -g' PKG_CONFIG='pkg-config' GOGCCFLAGS='-fPIC -arch x86_64 -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -ffile-prefix-map=/var/folders/5y/wtzzmjlj5v52pg7wr8ptbg_m0000gp/T/go-build641299882=/tmp/go-build -gno-record-gcc-switches -fno-common' GOROOT/bin/go version: go version devel go1.24-f3b0219 Tue Aug 27 21:02:02 2024 +0000 darwin/amd64 GOROOT/bin/go tool compile -V: compile version devel go1.24-f3b0219 Tue Aug 27 21:02:02 2024 +0000 uname -v: Darwin Kernel Version 20.6.0: Thu Jul 6 22:12:47 PDT 2023; root:xnu-7195.141.49.702.12~1/RELEASE_X86_64 ProductName: macOS ProductVersion: 11.7.10 BuildVersion: 20G1427 lldb --version: lldb-1300.0.42.3 Swift version 5.5.2-dev </pre></details> ### What did you do? <!-- If possible, provide a recipe for reproducing the error. A complete runnable program is good. A link on play.golang.org is best. --> ./GODEBUG=gccheckmark=1 ./gc_knobs ./gc_knobs_client -g 200 -s 1 -r 10 -p "/Users/mm/backbone" (both gc_knobs_client and gc_knobs are available on my github https://github.com/MikeMitchellWebDev/gc_knobs and https://github.com/MikeMitchellWebDev/gc_knobs_client) ### What did you expect to see? ### What did you see instead? see attached file [workbufs.txt](https://github.com/user-attachments/files/16945450/workbufs.txt)
NeedsInvestigation,compiler/runtime
low
Critical
2,516,471,113
go
runtime: checkmarks found unexpected unmarked object
<!-- Please answer these questions before submitting your issue. Thanks! --> ### What version of Go are you using (`go version`)? <pre> $ go version go version devel go1.24-f3b0219 Tue Aug 27 21:02:02 2024 +0000 darwin/amd64 </pre> ### Does this issue reproduce with the latest release? ### What operating system and processor architecture are you using (`go env`)? <details><summary><code>go env</code> Output</summary><br><pre> $ go env GO111MODULE='' GOARCH='amd64' GOBIN='' GOCACHE='/Users/mm/Library/Caches/go-build' GOENV='/Users/mm/Library/Application Support/go/env' GOEXE='' GOEXPERIMENT='' GOFLAGS='' GOHOSTARCH='amd64' GOHOSTOS='darwin' GOINSECURE='' GOMODCACHE='/Users/mm/go/pkg/mod' GONOPROXY='' GONOSUMDB='' GOOS='darwin' GOPATH='/Users/mm/go' GOPRIVATE='' GOPROXY='https://proxy.golang.org,direct' GOROOT='/Users/mm/go/src/github.com/MikeMitchellWebDev/go_checkmark' GOSUMDB='sum.golang.org' GOTMPDIR='' GOTOOLCHAIN='auto' GOTOOLDIR='/Users/mm/go/src/github.com/MikeMitchellWebDev/go_checkmark/pkg/tool/darwin_amd64' GOVCS='' GOVERSION='devel go1.24-f3b0219 Tue Aug 27 21:02:02 2024 +0000' GODEBUG='' GOTELEMETRY='local' GOTELEMETRYDIR='/Users/mm/Library/Application Support/go/telemetry' GCCGO='gccgo' GOAMD64='v1' AR='ar' CC='/usr/bin/clang' CXX='clang++' CGO_ENABLED='1' GOMOD='/Users/mm/go/src/github.com/MikeMitchellWebDev/go_checkmark/src/go.mod' GOWORK='' CGO_CFLAGS='-O2 -g' CGO_CPPFLAGS='' CGO_CXXFLAGS='-O2 -g' CGO_FFLAGS='-O2 -g' CGO_LDFLAGS='-O2 -g' PKG_CONFIG='pkg-config' GOGCCFLAGS='-fPIC -arch x86_64 -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -ffile-prefix-map=/var/folders/5y/wtzzmjlj5v52pg7wr8ptbg_m0000gp/T/go-build968457191=/tmp/go-build -gno-record-gcc-switches -fno-common' GOROOT/bin/go version: go version devel go1.24-f3b0219 Tue Aug 27 21:02:02 2024 +0000 darwin/amd64 GOROOT/bin/go tool compile -V: compile version devel go1.24-f3b0219 Tue Aug 27 21:02:02 2024 +0000 uname -v: Darwin Kernel Version 20.6.0: Thu Jul 6 22:12:47 PDT 2023; root:xnu-7195.141.49.702.12~1/RELEASE_X86_64 ProductName: macOS ProductVersion: 11.7.10 BuildVersion: 20G1427 lldb --version: lldb-1300.0.42.3 Swift version 5.5.2-dev </pre></details> ### What did you do? ./GODEBUG=gccheckmark=1 ./gc_knobs ./gc_knobs_client -g 200 -s 1 -r 10 -p "/Users/mm/backbone" (both gc_knobs_client and gc_knobs are available on my github) https://github.com/MikeMitchellWebDev/gc_knobs_client and https://github.com/MikeMitchellWebDev/gc_knobs <!-- If possible, provide a recipe for reproducing the error. A complete runnable program is good. A link on play.golang.org is best. --> ### What did you expect to see? ### What did you see instead? [unexpected_unmarked_object.txt](https://github.com/user-attachments/files/16945485/unexpected_unmarked_object.txt)
NeedsInvestigation,compiler/runtime
low
Critical
2,516,472,975
rust
Add more `ErrorKind`s
- A somewhat related tracking issue #86442 ## Misc UNIX Originally posted by zackw in https://github.com/rust-lang/rust/issues/79965#issuecomment-810468334 I am surprised to see `EMFILE`, `ENFILE`, `ENOMEM`, `ENOEXEC`, `EIO`, `ENOTTY`, `ENXIO`, `ENODEV`, `EOPNOTSUPP`, `ESRCH`, `ECHILD`, and `EINPROGRESS` dismissed as unlikely to occur, or only relevant to people doing highly Unix-specific tasks. They can all happen at least as easily as some of the other situations for which codes are being added. I'd recommend all of these be added, with the following friendly names and descriptions. Some of them should be lumped together, however. * `EIO`: `PhysicalIOError`, "Data could not be input or output due to a hardware failure, such as a bad disk sector." * `ESRCH` and `ECHILD`: `ProcessNotFound` (or lump with the existing `NotFound`). "A process was not found" seems too vague and short, but the existing description for `NotFound` is also vague and short, so :man_shrugging: * `EINPROGRESS`: `InProgress`. "An operation has begun, and will complete later. It is not yet known whether it will succeed." * `EMFILE` and `ENFILE`: `TooManyOpenFiles`. "The process cannot open any more files without closing some first, or the system as a whole cannot handle any more simultaneously open files." * `ENOMEM`: `NotEnoughMemory`. "The system does not have enough free memory to satisfy an allocation request. This can happen either because all of RAM is already allocated, or because the request was for more memory than the computer has." * `ENOEXEC`: `InvalidExecutable`. "A machine-language program is either corrupt or cannot be executed on this CPU (e.g. it is machine code for some other type of CPU)." * `ENOTTY`, `ENXIO`, `ENODEV`, `EOPNOTSUPP`: `NotOperable`, "This operation cannot be applied to this type of file or device. For example, changing terminal settings on something other than a terminal device." ## `EMFILE` specifically Was requested at least a couple of times - https://github.com/rust-lang/rust/issues/86442#issuecomment-1584846511 - https://github.com/rust-lang/rust/issues/86442#issuecomment-2163167135 (I was not even looking for those, just noticed the reoccurring request while gathering info for the few previous issues I've opened.)
T-libs-api,A-docs,C-tracking-issue,A-io
low
Critical
2,516,485,537
You-Dont-Know-JS
objects & classes: cover `Proxy`
Possibly in an appendix instead of its own chapter, as it's a rather niche metaprogramming technique (rarely used outside libraries/frameworks).
for second edition
medium
Minor
2,516,520,051
go
x/image/font: negative XHeight and CapHeight with M+ 1p Font
### Go version go version go1.22.6 darwin/arm64 ### Output of `go env` in your module/workspace: ```shell GO111MODULE='' GOARCH='arm64' GOBIN='' GOCACHE='/Users/hajimehoshi/Library/Caches/go-build' GOENV='/Users/hajimehoshi/Library/Application Support/go/env' GOEXE='' GOEXPERIMENT='' GOFLAGS='' GOHOSTARCH='arm64' GOHOSTOS='darwin' GOINSECURE='' GOMODCACHE='/Users/hajimehoshi/go/pkg/mod' GONOPROXY='' GONOSUMDB='' GOOS='darwin' GOPATH='/Users/hajimehoshi/go' GOPRIVATE='' GOPROXY='https://proxy.golang.org,direct' GOROOT='/usr/local/go' GOSUMDB='sum.golang.org' GOTMPDIR='' GOTOOLCHAIN='auto' GOTOOLDIR='/usr/local/go/pkg/tool/darwin_arm64' GOVCS='' GOVERSION='go1.22.6' GCCGO='gccgo' AR='ar' CC='clang' CXX='clang++' CGO_ENABLED='1' GOMOD='/Users/hajimehoshi/ebiten/go.mod' GOWORK='' CGO_CFLAGS='-O2 -g' CGO_CPPFLAGS='' CGO_CXXFLAGS='-O2 -g' CGO_FFLAGS='-O2 -g' CGO_LDFLAGS='-O2 -g' PKG_CONFIG='pkg-config' GOGCCFLAGS='-fPIC -arch arm64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -ffile-prefix-map=/var/folders/cj/73zbb35j0qx5t4b6rnqq0__h0000gn/T/go-build3402016389=/tmp/go-build -gno-record-gcc-switches -fno-common' ``` ### What did you do? 1. Download `MPLUS1p-Regular.ttf` at https://fonts.google.com/specimen/M+PLUS+1p 2. Run this program ```go package main import ( "fmt" "os" "golang.org/x/image/font/opentype" ) func showMetrics() error { file, err := os.ReadFile("MPLUS1p-Regular.ttf") if err != nil { return err } f, err := opentype.Parse(file) if err != nil { return err } face, err := opentype.NewFace(f, &opentype.FaceOptions{ Size: 12, DPI: 72, }) if err != nil { return err } m := face.Metrics() fmt.Printf("x-height: %s\n", m.XHeight.String()) fmt.Printf("cap-height: %s\n", m.CapHeight.String()) return nil } func main() { if err := showMetrics(); err != nil { fmt.Fprintln(os.Stderr, err) os.Exit(1) } } ``` ### What did you see happen? Negative values are shown ``` x-height: -6:15 cap-height: -8:49 ``` ### What did you expect to see? Positive values are shown
NeedsInvestigation
low
Critical
2,516,521,519
rust
Linker error when building dylib with "vectorcall" no_mangle fn on x86-64 Linux
Building this file... ```rust #![feature(abi_vectorcall)] #[no_mangle] #[inline(never)] pub extern "vectorcall" fn call_with_42(i: i32) { assert_eq!(i, 42); } ``` with `--crate-type=dylib` leads to a linker error on my system (x86_64-unknown-linux-gnu): ``` $ rustc $filename --crate-type=dylib error: linking with `cc` failed: exit status: 1 | = note: LC_ALL="C" PATH="/home/r/.rustup/toolchains/nightly-x86_64-unknown-linux-gnu/lib/rustlib/x86_64-unknown-linux-gnu/bin:/home/r/.rustup/toolchains/nightly-x86_64-unknown-linux-gnu/lib/rustlib/x86_64-unknown-linux-gnu/bin/self-contained:/home/r/.rustup/toolchains/nightly-x86_64-unknown-linux-gnu/lib/rustlib/x86_64-unknown-linux-gnu/bin:/home/r/.rustup/toolchains/nightly-x86_64-unknown-linux-gnu/lib/rustlib/x86_64-unknown-linux-gnu/bin/self-contained:/home/r/.rustup/toolchains/nightly-x86_64-unknown-linux-gnu/lib/rustlib/x86_64-unknown-linux-gnu/bin:/home/r/.rustup/toolchains/nightly-x86_64-unknown-linux-gnu/lib/rustlib/x86_64-unknown-linux-gnu/bin/self-contained:/home/r/.opam/coq-8.19/bin:/home/r/bin:/home/r/.cargo/bin:/home/r/.local/bin:/usr/local/bin:/usr/bin:/bin:/usr/local/games:/usr/games" VSLANG="1033" "cc" "-Wl,--version-script=/tmp/rustc54p2UM/list" "-Wl,--no-undefined-version" "-m64" "/tmp/rustc54p2UM/symbols.o" "foreign-vectorcall.foreign_vectorcall.e458723e0d9c0914-cgu.0.rcgu.o" "foreign-vectorcall.5inwzblfweptyphk6iy8ows5f.rcgu.rmeta" "foreign-vectorcall.bq1je05mopu28e8i624qzs0l3.rcgu.o" "-Wl,--as-needed" "-Wl,-Bstatic" "/home/r/.rustup/toolchains/nightly-x86_64-unknown-linux-gnu/lib/rustlib/x86_64-unknown-linux-gnu/lib/libstd-fa4c04b3e3e28f7e.rlib" "/home/r/.rustup/toolchains/nightly-x86_64-unknown-linux-gnu/lib/rustlib/x86_64-unknown-linux-gnu/lib/libpanic_unwind-eb97e423290e2a73.rlib" "/home/r/.rustup/toolchains/nightly-x86_64-unknown-linux-gnu/lib/rustlib/x86_64-unknown-linux-gnu/lib/libobject-6a3cbaef857276ba.rlib" "/home/r/.rustup/toolchains/nightly-x86_64-unknown-linux-gnu/lib/rustlib/x86_64-unknown-linux-gnu/lib/libmemchr-f14799023c8f2a27.rlib" "/home/r/.rustup/toolchains/nightly-x86_64-unknown-linux-gnu/lib/rustlib/x86_64-unknown-linux-gnu/lib/libaddr2line-ae67f58af1bc202d.rlib" "/home/r/.rustup/toolchains/nightly-x86_64-unknown-linux-gnu/lib/rustlib/x86_64-unknown-linux-gnu/lib/libgimli-07db6d7d16f60531.rlib" "/home/r/.rustup/toolchains/nightly-x86_64-unknown-linux-gnu/lib/rustlib/x86_64-unknown-linux-gnu/lib/librustc_demangle-af5f9e36062cdfaa.rlib" "/home/r/.rustup/toolchains/nightly-x86_64-unknown-linux-gnu/lib/rustlib/x86_64-unknown-linux-gnu/lib/libstd_detect-f753d0635143b03f.rlib" "/home/r/.rustup/toolchains/nightly-x86_64-unknown-linux-gnu/lib/rustlib/x86_64-unknown-linux-gnu/lib/libhashbrown-02716de7358d6620.rlib" "/home/r/.rustup/toolchains/nightly-x86_64-unknown-linux-gnu/lib/rustlib/x86_64-unknown-linux-gnu/lib/librustc_std_workspace_alloc-9099a438c5291bc6.rlib" "/home/r/.rustup/toolchains/nightly-x86_64-unknown-linux-gnu/lib/rustlib/x86_64-unknown-linux-gnu/lib/libminiz_oxide-4549192a05d95b2c.rlib" "/home/r/.rustup/toolchains/nightly-x86_64-unknown-linux-gnu/lib/rustlib/x86_64-unknown-linux-gnu/lib/libadler-017f0d0d69a7a874.rlib" "/home/r/.rustup/toolchains/nightly-x86_64-unknown-linux-gnu/lib/rustlib/x86_64-unknown-linux-gnu/lib/libunwind-ad6115df66a4cafe.rlib" "/home/r/.rustup/toolchains/nightly-x86_64-unknown-linux-gnu/lib/rustlib/x86_64-unknown-linux-gnu/lib/libcfg_if-203703a910c15888.rlib" "/home/r/.rustup/toolchains/nightly-x86_64-unknown-linux-gnu/lib/rustlib/x86_64-unknown-linux-gnu/lib/liblibc-fbe0149ad3765332.rlib" "/home/r/.rustup/toolchains/nightly-x86_64-unknown-linux-gnu/lib/rustlib/x86_64-unknown-linux-gnu/lib/liballoc-d2c56345f3127d00.rlib" "/home/r/.rustup/toolchains/nightly-x86_64-unknown-linux-gnu/lib/rustlib/x86_64-unknown-linux-gnu/lib/librustc_std_workspace_core-395a38b8e0851c9b.rlib" "/home/r/.rustup/toolchains/nightly-x86_64-unknown-linux-gnu/lib/rustlib/x86_64-unknown-linux-gnu/lib/libcore-d453bab70303062c.rlib" "/home/r/.rustup/toolchains/nightly-x86_64-unknown-linux-gnu/lib/rustlib/x86_64-unknown-linux-gnu/lib/libcompiler_builtins-d5e57876d7066b4c.rlib" "-Wl,-Bdynamic" "-lgcc_s" "-lutil" "-lrt" "-lpthread" "-lm" "-ldl" "-lc" "-B/home/r/.rustup/toolchains/nightly-x86_64-unknown-linux-gnu/lib/rustlib/x86_64-unknown-linux-gnu/bin/gcc-ld" "-B/home/r/.rustup/toolchains/nightly-x86_64-unknown-linux-gnu/lib/rustlib/x86_64-unknown-linux-gnu/bin/gcc-ld" "-B/home/r/.rustup/toolchains/nightly-x86_64-unknown-linux-gnu/lib/rustlib/x86_64-unknown-linux-gnu/bin/gcc-ld" "-fuse-ld=lld" "-Wl,--eh-frame-hdr" "-Wl,-z,noexecstack" "-L" "/home/r/.rustup/toolchains/nightly-x86_64-unknown-linux-gnu/lib/rustlib/x86_64-unknown-linux-gnu/lib" "-o" "libforeign_vectorcall.so" "-shared" "-Wl,-soname=libforeign_vectorcall.so" "-Wl,-z,relro,-z,now" "-nodefaultlibs" = note: rust-lld: error: foreign-vectorcall.foreign_vectorcall.e458723e0d9c0914-cgu.0.rcgu.o: symbol call_with_42@@8 has undefined version 8 collect2: error: ld returned 1 exit status ``` Cc https://github.com/rust-lang/rust/issues/124485
A-linkage,O-linux,T-compiler,C-bug
low
Critical
2,516,528,803
godot
Spotlight3D projection is not respected in VoxelGI
### Tested versions Reproduced in 4.3.stable ### System information Godot v4.3.stable - Windows 10.0.19045 - Vulkan (Forward+) - dedicated NVIDIA GeForce RTX 3080 (NVIDIA; 31.0.15.3623) - AMD Ryzen 7 3700X 8-Core Processor (16 Threads) ### Issue description I use a texture to define the spotlight shape. However that shape is not respected by Voxel GI. ![grafik](https://github.com/user-attachments/assets/2ca60be1-727d-4073-9081-a126e1199bfd) It shoud look more like this: ![grafik](https://github.com/user-attachments/assets/03befa22-5a04-4e34-9c29-198ab4c842de) ### Steps to reproduce 1. Open the scene 2. if the spotlight doesn't show up like in the screenshot, click the SpotLight3D once (or make it invisible/visible) Enabling or disabling the VoxelGI node triggers this also for me. ### Minimal reproduction project (MRP) [project.zip](https://github.com/user-attachments/files/16945778/project.zip)
topic:rendering,confirmed,topic:3d
low
Minor
2,516,539,993
ui
[bug]: Background accent on sidebar-01 block
### Describe the bug It look like an intentional background `bg-accent/50` is added on SidebarLayout when adding sidebar-01 block Here are previews of the bug: - [Theo - t3․gg | Last video on the CLI](https://youtu.be/c5OPn_dyNcc?t=541) - #4791 https://github.com/user-attachments/assets/616c0403-e68b-4629-93af-b43b7bf77954 [View in source code here](https://github.com/shadcn-ui/ui/blob/f4ca57a79cf2d56f9c55021242a55cf0e1018b72/apps/www/registry/default/block/sidebar-01/ui/sidebar.tsx#L57) ### Affected component/components Sidebar-01 block ### How to reproduce Just create a project with the sidebar-01 block : `npx shadcn@latest init sidebar-01 login-01 -d -f -y` ### Codesandbox/StackBlitz link https://github.com/QuentinFrc/shadcn-sidebar01-issue-repoduction ### Logs _No response_ ### System Info ```bash Nothing relevant. ``` ### Before submitting - [X] I've made research efforts and searched the documentation - [X] I've searched for existing issues
bug
low
Critical
2,516,547,220
ollama
Add alias of /quit and /exit for /bye.
For now it might be easier to add an alias in the program itself for /bye and allow the use of /quit and /exit as well. Or design a way for the user to have an .alias file to define their own aliases. Thanks! This is a great tool!
feature request
low
Major
2,516,550,404
PowerToys
Always on top persistent frame bug
### Microsoft PowerToys version 0.84.1 ### Installation method PowerToys auto-update, Microsoft Store ### Running as admin None ### Area(s) with issue? Always on Top ### Steps to reproduce While at least 2 different apps open and active, use always on top shortcut. At first it'll work properly but after the second or third time it'll became persistent and wont dissappear until a reboot. It usually happened to me while using brave at background. ### ✔️ Expected Behavior Using the shortcut for the second time, frame will be dissappear and pc can work properly ### ❌ Actual Behavior Using the shortcut for the second time, frame wont dissappear and became persistent both visually and functionally which cant interact with pc where was the frame appeared first. ### Other Software _No response_
Issue-Bug,Needs-Triage
low
Critical
2,516,553,934
ui
[bug]: Components refer to wrong "utils.ts" file after "utils.ts" file renamed and moved to different folder [Remix]
### Describe the bug when adding a new components for example `npx shadcn@latest add button`. usually the components importing the generated "utils" file, however, i rename the file to "cn.ts" and move it from `~/lib/utils` to `~/lib/utils/cn`. I also change the generated `components.json` file and refer the moved utils file to correct path. here's my `components.json` file: ```json { "$schema": "https://ui.shadcn.com/schema.json", "style": "default", "rsc": false, "tsx": true, "tailwind": { "config": "tailwind.config.ts", "css": "app/tailwind.css", "baseColor": "neutral", "cssVariables": false, "prefix": "" }, "aliases": { "components": "~/components", "utils": "~/lib/utils/cn", // before was ~/lib/utils "ui": "~/components/ui", "lib": "~/lib", "hooks": "~/hooks" } } ``` also my `tsconfig.json` file (i'm not changing anything): ```json { "include": [ "**/*.ts", "**/*.tsx", "**/.server/**/*.ts", "**/.server/**/*.tsx", "**/.client/**/*.ts", "**/.client/**/*.tsx" ], "compilerOptions": { "lib": ["DOM", "DOM.Iterable", "ES2022"], "types": ["@remix-run/node", "vite/client"], "isolatedModules": true, "esModuleInterop": true, "jsx": "react-jsx", "module": "ESNext", "moduleResolution": "Bundler", "resolveJsonModule": true, "target": "ES2022", "strict": true, "allowJs": true, "skipLibCheck": true, "forceConsistentCasingInFileNames": true, "baseUrl": ".", "paths": { "~/*": ["./app/*"] }, // Vite takes care of building everything, not tsc. "noEmit": true } } ``` I do the same thing when working with Nextjs project, and everything works fine, but in Remix, this happened. ### Affected component/components Probably all components, but i only try it on Button, Label, and Form ### How to reproduce 1. install shadcn ui in Remix project and follow all instruction. 2. create new folder inside `lib` folder named `utils` 3. move `utils.ts` to inside `utils` folder 4. rename `utils.ts` into `cn.ts` 5. in `components.json`, replace `"utils": "~/lib/utils",` to `"utils": "~/lib/utils/cn",` 6. add components like usual, for example `npx shadcn@latest add button` 7. after component installed, open `button.ts` 8. see that the components have an error `cannot find module ~/lib/utils` ### Codesandbox/StackBlitz link _No response_ ### Logs _No response_ ### System Info ```bash Nothing relevant ``` ### Before submitting - [X] I've made research efforts and searched the documentation - [X] I've searched for existing issues
bug
medium
Critical
2,516,558,610
neovim
Extmarks are not restored on redo
### Problem Extmarks are not restored properly on redo. ### Steps to reproduce Run this lua script to set up the buffer. ```lua vim.cmd "enew" vim.api.nvim_buf_set_lines(0, 0, -1, 1, {"foobar"}) local ns = vim.api.nvim_create_namespace("") vim.api.nvim_buf_set_extmark(0, ns, 0, 3, { end_col = 6, hl_group = "Error" }) ``` 1. Observe restoration works properly on undo 1. Source the provided lua script 2. Press `D` (delete "foobar") 3. Press `u`(undo deletion) 4. Observe that the highlighting is still present 2. Observe restoration does not work on redo 1. Source the provided lua script 2. Press `u` (undo "foobar") 3. Press `<C-r>` (redo "foobar") 4. Observe that the highlighting is absent ### Neovim version (nvim -v) 0.10.1
bug,has:repro,marks,editor-state
low
Critical
2,516,578,370
godot
Help codeblocks have wrong horizontal size
### Tested versions 4.3 and newer ### System information Windows 10.0.19045 - Vulkan (Forward+) - dedicated NVIDIA GeForce GTX 1060 (NVIDIA; 31.0.15.4633) - Intel(R) Core(TM) i7-7700HQ CPU @ 2.80GHz (8 Threads) ### Issue description In the inspector, scrollbars will overlap their content: ![image](https://github.com/user-attachments/assets/3d6bf2f0-ef2a-4f56-907c-0f14fcc4ffa0) In help the can be cut at the edges: https://github.com/user-attachments/assets/cedb2d89-ae23-4389-ae4a-6aa0089867c4 Horizontal scrolling is disabled. ### Steps to reproduce Hover property with codeblock in description (e.g `tooltip_text`). ### Minimal reproduction project (MRP) N/A
bug,topic:editor,usability,topic:gui
low
Minor
2,516,658,867
pytorch
Inconsistent results between libtorch and pytorch for model with shared weights
### 🐛 Describe the bug I created a simple model with shared weights between two linear layers, then script it and run in libtorch and pytorch. The results are different. Pytorch code (creates model and runs 5 iterations; NOTE: it has to be run before libtorch): ```python from torch import nn import torch torch.manual_seed(0) class Model(nn.Module): def __init__(self): super().__init__() self.n = nn.Linear(10, 10) self.m = nn.Linear(10, 10) self.n.bias = self.m.bias self.n.weight = self.m.weight def forward(self, x): x = self.n(x) x = self.m(x) return x.mean() model = Model() scripted_model = torch.jit.script(model) scripted_model.save("/home/vadim/work/tmp_python/tmp30/tmp.pt") model = torch.jit.load("/home/vadim/work/tmp_python/tmp30/tmp.pt") optimizer = torch.optim.SGD(model.parameters(), 0.001) x = torch.ones(size=(10, 10)) for _ in range(5): optimizer.zero_grad() loss = model(x) loss.backward() optimizer.step() print(loss) ``` Libtorch: ```cpp #include <torch/torch.h> #include <torch/script.h> #include <iostream> #include <fstream> int main() { torch::jit::script::Module model = torch::jit::load("tmp.pt"); std::vector<at::Tensor> parameters; for (const auto& param : model.parameters()) { parameters.push_back(param); } torch::optim::SGD optimizer(parameters, 0.001); torch::Tensor x = torch::ones({10, 10}); for (int i = 0; i < 5; ++i) { optimizer.zero_grad(); torch::Tensor loss = model.forward({ x }).toTensor(); loss.backward(); optimizer.step(); std::cout << "Loss: " << loss << std::endl; } return 0; } ``` Pytorch result: ```shell tensor(0.0285, grad_fn=<MeanBackward0>) tensor(0.0278, grad_fn=<DifferentiableGraphBackward>) tensor(0.0271, grad_fn=<DifferentiableGraphBackward>) tensor(0.0265, grad_fn=<DifferentiableGraphBackward>) tensor(0.0258, grad_fn=<DifferentiableGraphBackward>) ``` Libtorch result: ```shell Loss: 0.0284842 [ CPUFloatType{} ] Loss: 0.0271356 [ CPUFloatType{} ] Loss: 0.0257901 [ CPUFloatType{} ] Loss: 0.0244476 [ CPUFloatType{} ] Loss: 0.0231082 [ CPUFloatType{} ] ``` Only the first pair of results match. After some additional experiments: * For model without shared weights all results match for scripted model in libtorch, scripted model in pytorch and non-scripted (original) model in pytorch. * For model with shared weights only results for scripted model in pytorch and non-scripted (original) model in pytorch match. Moreover, results for scripted model with shared params in libtorch match results for scripted model without shared params in libtorch. Conclusion: In libtorch scripted model with shared parameters, that was exported from pytorch, loses the property of shared parameters (loss propagates as if no parameters are shared). ### Versions C++: * `libtorch 2.4.0` Python: * `torch==2.0.1+cu118` * `torchvision==0.15.2+cu118` cc @EikanWang @jgong5 @wenzhe-nrv @sanchitintel
oncall: jit
low
Critical
2,516,668,861
vscode
SCM Graph - Hover does not escape markdown in commit message
When a commit message includes markdown syntax such as `# First Commit`, the hover does not escape the `#` from the commit message and renders the commit message as a markdown header.
scm,under-discussion
low
Minor
2,516,674,614
stable-diffusion-webui
[Bug]: ValueError: Unknown scheme for proxy URL URL('socks://127.0.0.1:17897/')
### Checklist - [ ] The issue exists after disabling all extensions - [X] The issue exists on a clean installation of webui - [ ] The issue is caused by an extension, but I believe it is caused by a bug in the webui - [X] The issue exists in the current version of the webui - [X] The issue has not been reported before recently - [ ] The issue has been reported before but has not been fixed yet ### What happened? I run web.sh and report this ### Steps to reproduce the problem I run web.sh and report this Launching Web UI with arguments: Traceback (most recent call last): File "/home/1.worisur/1.tools/1.ai/01.sd/stable-diffusion-webui/launch.py", line 48, in <module> main() File "/home/1.worisur/1.tools/1.ai/01.sd/stable-diffusion-webui/launch.py", line 44, in main start() File "/home/1.worisur/1.tools/1.ai/01.sd/stable-diffusion-webui/modules/launch_utils.py", line 465, in start import webui File "/home/1.worisur/1.tools/1.ai/01.sd/stable-diffusion-webui/webui.py", line 13, in <module> initialize.imports() File "/home/1.worisur/1.tools/1.ai/01.sd/stable-diffusion-webui/modules/initialize.py", line 23, in imports import gradio # noqa: F401 File "/home/1.worisur/1.tools/1.ai/01.sd/stable-diffusion-webui/venv/lib/python3.10/site-packages/gradio/__init__.py", line 3, in <module> import gradio.components as components File "/home/1.worisur/1.tools/1.ai/01.sd/stable-diffusion-webui/venv/lib/python3.10/site-packages/gradio/components/__init__.py", line 1, in <module> from gradio.components.annotated_image import AnnotatedImage File "/home/1.worisur/1.tools/1.ai/01.sd/stable-diffusion-webui/venv/lib/python3.10/site-packages/gradio/components/annotated_image.py", line 12, in <module> from gradio import utils File "/home/1.worisur/1.tools/1.ai/01.sd/stable-diffusion-webui/venv/lib/python3.10/site-packages/gradio/utils.py", line 353, in <module> class AsyncRequest: File "/home/1.worisur/1.tools/1.ai/01.sd/stable-diffusion-webui/venv/lib/python3.10/site-packages/gradio/utils.py", line 372, in AsyncRequest client = httpx.AsyncClient() File "/home/1.worisur/1.tools/1.ai/01.sd/stable-diffusion-webui/venv/lib/python3.10/site-packages/httpx/_client.py", line 1395, in __init__ proxy_map = self._get_proxy_map(proxies, allow_env_proxies) File "/home/1.worisur/1.tools/1.ai/01.sd/stable-diffusion-webui/venv/lib/python3.10/site-packages/httpx/_client.py", line 216, in _get_proxy_map return { File "/home/1.worisur/1.tools/1.ai/01.sd/stable-diffusion-webui/venv/lib/python3.10/site-packages/httpx/_client.py", line 217, in <dictcomp> key: None if url is None else Proxy(url=url) File "/home/1.worisur/1.tools/1.ai/01.sd/stable-diffusion-webui/venv/lib/python3.10/site-packages/httpx/_config.py", line 336, in __init__ raise ValueError(f"Unknown scheme for proxy URL {url!r}") ValueError: Unknown scheme for proxy URL URL('socks://127.0.0.1:17897/') ### What should have happened? unknown ### What browsers do you use to access the UI ? Google Chrome ### Sysinfo # 系统详情报告 --- ## 报告详情 - **生成日期:** 2024-09-10 22:41:35 ## 硬件信息: - **硬件型号:** ASUS ROG CROSSHAIR X670E HERO - **内存:** 64.0 GiB - **处理器:** AMD Ryzen™ 9 7950X × 32 - **显卡:** NVIDIA GeForce RTX™ 4080 SUPER - **磁盘容量:** 6.0 TB ## 软件信息: - **固件版本:** 1415 - **操作系统名称:** Arch Linux - **操作系统内部版本:** rolling - **操作系统类型:** 64 位 - **GNOME 版本:** 46 - **窗口系统:** Wayland - **内核版本:** Linux 6.10.8-arch1-1 ### Console logs ```Shell ################################################################ Install script for stable-diffusion + Web UI Tested on Debian 11 (Bullseye), Fedora 34+ and openSUSE Leap 15.4 or newer. ################################################################ ################################################################ Running on lux user ################################################################ ################################################################ Create and activate python venv ################################################################ ################################################################ Launching launch.py... ################################################################ glibc version is 2.40 Check TCMalloc: libtcmalloc_minimal.so.4 libtcmalloc_minimal.so.4 is linked with libc.so,execute LD_PRELOAD=/usr/lib/libtcmalloc_minimal.so.4 Python 3.10.14 (main, Sep 4 2024, 12:07:11) [GCC 14.2.1 20240805] Version: v1.10.1 Commit hash: 82a973c04367123ae98bd9abdf80d9eda9b910e2 Launching Web UI with arguments: Traceback (most recent call last): File "/home/1.worisur/1.tools/1.ai/01.sd/stable-diffusion-webui/launch.py", line 48, in <module> main() File "/home/1.worisur/1.tools/1.ai/01.sd/stable-diffusion-webui/launch.py", line 44, in main start() File "/home/1.worisur/1.tools/1.ai/01.sd/stable-diffusion-webui/modules/launch_utils.py", line 465, in start import webui File "/home/1.worisur/1.tools/1.ai/01.sd/stable-diffusion-webui/webui.py", line 13, in <module> initialize.imports() File "/home/1.worisur/1.tools/1.ai/01.sd/stable-diffusion-webui/modules/initialize.py", line 23, in imports import gradio # noqa: F401 File "/home/1.worisur/1.tools/1.ai/01.sd/stable-diffusion-webui/venv/lib/python3.10/site-packages/gradio/__init__.py", line 3, in <module> import gradio.components as components File "/home/1.worisur/1.tools/1.ai/01.sd/stable-diffusion-webui/venv/lib/python3.10/site-packages/gradio/components/__init__.py", line 1, in <module> from gradio.components.annotated_image import AnnotatedImage File "/home/1.worisur/1.tools/1.ai/01.sd/stable-diffusion-webui/venv/lib/python3.10/site-packages/gradio/components/annotated_image.py", line 12, in <module> from gradio import utils File "/home/1.worisur/1.tools/1.ai/01.sd/stable-diffusion-webui/venv/lib/python3.10/site-packages/gradio/utils.py", line 353, in <module> class AsyncRequest: File "/home/1.worisur/1.tools/1.ai/01.sd/stable-diffusion-webui/venv/lib/python3.10/site-packages/gradio/utils.py", line 372, in AsyncRequest client = httpx.AsyncClient() File "/home/1.worisur/1.tools/1.ai/01.sd/stable-diffusion-webui/venv/lib/python3.10/site-packages/httpx/_client.py", line 1395, in __init__ proxy_map = self._get_proxy_map(proxies, allow_env_proxies) File "/home/1.worisur/1.tools/1.ai/01.sd/stable-diffusion-webui/venv/lib/python3.10/site-packages/httpx/_client.py", line 216, in _get_proxy_map return { File "/home/1.worisur/1.tools/1.ai/01.sd/stable-diffusion-webui/venv/lib/python3.10/site-packages/httpx/_client.py", line 217, in <dictcomp> key: None if url is None else Proxy(url=url) File "/home/1.worisur/1.tools/1.ai/01.sd/stable-diffusion-webui/venv/lib/python3.10/site-packages/httpx/_config.py", line 336, in __init__ raise ValueError(f"Unknown scheme for proxy URL {url!r}") ValueError: Unknown scheme for proxy URL URL('socks://127.0.0.1:17897/') ``` ### Additional information _No response_
bug-report
low
Critical
2,516,678,680
go
x/tools/gopls: resolve comment links to unimported package-qualified symbols such as [net/http.Request]
Reported by @mvdan in slack: while the doc comment [spec](https://golang.org/doc/comment#doclinks) allows for qualified doc links such as `[net/http.Request]`, it looks like the support for these links added in golang/go#64648 does not implement this support. I've run into this as well; we should add this support.
FeatureRequest,gopls,Tools
low
Minor
2,516,681,584
vscode
the placeholder container is too narrow, it looks like it allocates space for the vertical scrollbar
> Next problem: the placeholder container is too narrow, it looks like it allocates space for the vertical scrollbar, but there is no vertical scrollbar > > > > ![Image](https://github.com/user-attachments/assets/21bcf7d2-0c34-4fe7-ba07-59d2048af6c8) > > _Originally posted by @roblourens in [#214472](https://github.com/microsoft/vscode/issues/214472#issuecomment-2327485616)_
polish,editor-core
low
Minor
2,516,684,987
node
HTTP2 download of parallel requests is slower than HTTP1.1
### Version v20.17.0 ### Platform ```text MacOS Sonoma 14.5, 2,3 GHz Quad-Core Intel Core i7 ``` ### Subsystem _No response_ ### What steps will reproduce the bug? Define an http2 and http1.1 clients and fetch some data in parallel. You can use the script below. If you run it using the following command, it will send 25 parallel requests using HTTP1.1 ```sh node client.js ``` or you can run this command and it will send 25 parallel requests using HTTP2: ```sh node client.js http2 ``` <details> <summary>client.js</summary> <p> ```javascript import http2 from 'node:http2'; import https from 'node:https'; const isHttp2 = process.argv[2] === 'http2'; const MB = 1024 * 1024; const WINDOW_SIZE = 32 * MB; const url = new URL('https://nodejs.org/dist/v17.1.0/node-v17.1.0-x64.msi'); const client = http2.connect(url, { settings: { initialWindowSize: WINDOW_SIZE, }, }); client.on('connect', () => { client.setLocalWindowSize(WINDOW_SIZE); }); const fetchHttp1 = (id) => { return new Promise((resolve) => { const req = https.request({ host: url.host, path: url.pathname, headers: { connection: 'keep-alive', }, }, (res) => { res.on('data', () => {}); res.on('end', () => { console.log(`Complete request with id: ${id}`); resolve(); }); }, ); req.end(); }); }; const fetchHttp2 = (id) => { return new Promise((resolve) => { const req = client.request({ ':path': url.pathname, }); req.on('data', () => {}); req.on('end', () => { console.log(`Complete request with id: ${id}`); resolve(); }); req.end(); }); }; const main = async () => { console.log(`Starting requests using HTTP${isHttp2 ? '2' : '1.1'} protocol.`); const startTime = Date.now(); await Promise.all( Array.from({ length: 25 }) .fill(null) .map((_, index) => isHttp2 ? fetchHttp2(index) : fetchHttp1(index)), ); console.log(`Requests complete. Completion time: ${(Date.now() - startTime) / 1000}s`); }; main(); ``` </p> </details> ### How often does it reproduce? Is there a required condition? It's not quite stable, because sometimes http2 has the same performance or even better performance. ### What is the expected behavior? Why is that the expected behavior? I expect http2 to be faster or at least have the same performance as http1.1. ### What do you see instead? Instead, I often see that http1.1 requests are faster. Most of the times http2 took 25s to complete while http1.1 took 20s. There's a problem, though, because those results are not consistent when using the URL I provided in the example. But, the results are consistent with some internal APIs I'm working with. First, I thought there might be a problem with our internal APIs, but making 25 parallel requests to our internal APIs using `curl` has consistently the same performance on both http 1.1 and http2. I ran curl with the following command: ```sh curl --config ./config.txt --parallel --parallel-max 25 --http2 ``` where config.txt looked like this: ```txt url = "our-internal-api" output = "/dev/null" // repeated 25 times ``` ### Additional information I was thinking the reason for such slowness would be TCP stall because http2 uses only 1 tcp connection, so I checked in wireshark how many tcp connections creates node vs curl when using http2, and both created only 1 tcp connection. Also, I noticed node receives first 10 http2 requests randomly, but then sequentially, while http1 requests are all received randomly. http2: <img width="405" alt="image" src="https://github.com/user-attachments/assets/7b1b155e-656b-4266-aca9-64cb009f02cd"> --- http1: <img width="424" alt="image" src="https://github.com/user-attachments/assets/f317b751-ed98-44aa-b562-1854ccc88835">
http2
low
Critical
2,516,697,625
vscode
Editor GPU: Use a Map over object for TwoKeyMap and FourKeyMap
null
bug,perf,editor-gpu
low
Minor
2,516,733,816
PowerToys
Workspaces does not detect Quicken Medical Expense Manager
### Microsoft PowerToys version 0.84.1 ### Installation method WinGet ### Running as admin None ### Area(s) with issue? Workspaces ### Steps to reproduce [Filing this issue from Learn docs feedback - likely related to .NET Winforms problems reported in #34681] Try to capture workspace that includes Quicken Medical Expense Manager. It will not be detected. ### ✔️ Expected Behavior Quicken Medical Expense Manager is captured and properly launches as expected on workspace launch. ### ❌ Actual Behavior Quicken Medical Expense Manager is not detected and cannot be saved as part of a workspace. ### Other Software _No response_
Issue-Bug,Needs-Triage,Product-Workspaces
low
Minor
2,516,738,198
angular
docs(docs-infra): Text legibility and accessibility
### Describe the problem that you experienced The new Angular Docs site could do with some improvements in accessibility related to text rendering. I could not find a single instance of text using subpixel rendering properly (which makes small text look really bad, _especially_ if it isn't max contrast), and there are way too many instances of gradient filled text at small sizes. Don't get me wrong, the new site _does_ look really cool, but in its current state it looks more like an ad for Angular than actual documentation. ### Describe what you want to experience that would fix the problem - No gradient fills on \<code\>, period. - No gradient fills on text smaller than 16px - Reduce over-reliance on CSS transforms across the site so that the browser can do subpixel rendering ### Add a screenshot if that helps illustrate the problem Some examples of "bad" text rendering here: ![image](https://github.com/user-attachments/assets/178fbf90-256f-4d3d-8285-1696b18943b3) (some of the letters here look really blocky. also, unnecessary gradient.) ![image](https://github.com/user-attachments/assets/9f87f48e-9e9e-49b7-95fe-26f1c92ad770) (completely unnecessary gradient that looks bad on small text) ![image](https://github.com/user-attachments/assets/b088ddf6-c72b-4986-b274-e0601b39815e) (contrast could be better here. also, gradient on critical information.) ### Provide any additional information here in as much as detail as you can - The entire site seems to have some global CSS transform applied to it at the moment, which means **nothing** can subpixel render. Deleting the second \<style\> element in the site's \<head\> via DevTools seems to get rid of this and actually allows a decent amount of text to subpixel render all by itself, but there's still a lot it doesn't fix—gradient fill text in particular. - The lack of subpixel rendering is a lot worse for small text in dark theme specifically. ### Am I nitpicking? Probably, but the v17 site doesn't have these issues. It actually feels like documentation, and _not_ an ad for Angular.
P3,area: docs
low
Minor
2,516,744,420
neovim
g:rust_recommended_style default (sometimes) overrides expandtab against explicit .editorconfig setting
### Problem I use .editorconfig to set the tab behavior of my projects. Neovim's built-in Rust runtime overwrites this in the Rust plugin. Here is the relevant code: (`runtime/ftplugin/rust.vim` line 43) ```vim if !exists("g:rust_recommended_style") || g:rust_recommended_style != 0 setlocal tabstop=4 shiftwidth=4 softtabstop=4 expandtab setlocal textwidth=99 endif ``` Earlier reported on the editorconfig plugin [here](https://github.com/editorconfig/editorconfig-vim/issues/157) and for LazyVim [here](https://github.com/LazyVim/LazyVim/issues/4388). ### Steps to reproduce It's weird because it's not consistent. When I start developing, the .editorconfig is adhered to. But after a while, idk what triggers it --it might be me navigating into a dependency source file using LSP hotkey or something-- and from that point on, the Rust runtime has overwritten the `expandtab` flag for all buffers. ### Expected behavior When an .editorconfig is present in the project root of a file, the formatting of .editorconfig is followed. ### Neovim version (nvim -v) 0.9.5 ### Vim (not Nvim) behaves the same? not sure ### Operating system/version NixOS latest ### Terminal name/version alacritty 0.12.3 ### $TERM environment variable alacritty ### Installation nixos nixpkgs
bug,bug-vim,needs:repro,complexity:low,needs:vim-patch,filetype,options,editorconfig
low
Minor
2,516,756,726
PowerToys
discord canary, ptb and developer not detected from workspaces
### Microsoft PowerToys version 0.84.1 ### Installation method PowerToys auto-update ### Running as admin None ### Area(s) with issue? Workspaces ### Steps to reproduce activate workspaces with one of the 3 active discords or all ### ✔️ Expected Behavior all are detected (i use discord canary mainly) ### ❌ Actual Behavior with a test I did none of the 3 are detected ### Other Software _No response_
Issue-Bug,Needs-Triage,Product-Workspaces
low
Minor
2,516,759,207
vscode
Perf telemetry for Code Actions from providers
<!-- ⚠️⚠️ Do Not Delete This! feature_request_template ⚠️⚠️ --> <!-- Please read our Rules of Conduct: https://opensource.microsoft.com/codeofconduct/ --> <!-- Please search existing issues to avoid creating duplicates. --> <!-- Describe the feature you'd like. --> We currently have telemetry on latency for Code Actions on save - it might be helpful to also add this telemetry for code actions from providers. Example use case - An extension provides a Code Action using Copilot for users, but only displays if the user has Copilot installed. Understanding the perf for this check could be helpful.
feature-request,telemetry,editor-code-actions
low
Minor
2,516,811,089
next.js
Nextjs 15: Importing git modules issue - 'Module not found: Can't resolve 'package-name'
### Link to the code that reproduces this issue https://github.com/moltco/simple-consumer-2 ### To Reproduce 1. Clone sample TypeScript module package: `git clone https://github.com/moltco/simple-package` 2. Clone NextJs@canary app boilerplate that imports the above package: `git clone https://github.com/moltco/simple-consumer-2` 3. `pnpm install && pnpm build` (or `pnpm dev` then visit http://localhost:3000/ to get it to compile) 4. Error raised by Nextjs: `'Module not found: Can't resolve 'simple-package'` ### Current vs. Expected behavior Expected: import to work Current: typescript intellisense etc works but cannot compile. ### Provide environment information ```bash OS: Win 10 Nodejs: v20.17.0 pnpm: 9.10.0 "next": "15.0.0-canary.148", "react": "19.0.0-rc-7771d3a7-20240827", "react-dom": "19.0.0-rc-7771d3a7-20240827", ``` ### Which area(s) are affected? (Select all that apply) Module Resolution ### Which stage(s) are affected? (Select all that apply) next dev (local), next build (local), next start (local) ### Additional context I tested agains canary 15.0.0-canary.56 and 15.0.0-canary.148 -> both seem to suffer from the same issue
bug,Module Resolution
low
Critical
2,516,903,932
angular
Angular effect throws "Unsubscription error" when signal is set in finalize operator
### Which @angular/* package(s) are the source of the bug? core ### Is this a regression? Yes ### Description I am getting an error when I use effect to call an http request whenever my input signal changes, the occurs when the input `search` changes before the current request is completed. After investigating, it appears to be happening because of setting `loading` signal to false inside the `finalize` operator. It is probably happening because the effect is triggered when the input is changing and then sets the loading to true, but at the same time the finalize from the previous request which got unsubscribed, sets the loading to false. ```ts constructor() { let sub$: Subscription; effect((onCleanup: EffectCleanupRegisterFn) => { const searchKey: string = this.search(); untracked(() => { sub$?.unsubscribe(); if (searchKey) { this.data.set(null); this.loading.set(true); sub$ = this.service.getData(searchKey).pipe( tap((data) => this.data.set(data)), finalize(() => this.loading.set(false)) ).subscribe(); } }); onCleanup(() => sub$?.unsubscribe()); }); } ``` **Runtime error is thrown:** ![image](https://github.com/user-attachments/assets/dfa0e58c-8a41-42f8-936a-06c448ddf456) ### Please provide a link to a minimal reproduction of the bug [Stackblitz reproduction](https://stackblitz.com/edit/stackblitz-starters-dexwge). Click the button to trigger a request, then click again after a second and you will get the error in the console ### Please provide the exception or error you saw ```true message: "1 errors occurred during unsubscription:\n1) Error: NG0600" name: "UnsubscriptionError" ``` ### Please provide the environment you discovered this bug in (run `ng version`) ```true Angular CLI: 17.3.8 Node: 20.2.0 Package Manager: npm 9.6.6 OS: win32 x64 Angular: 17.3.11 ... animations, common, compiler, compiler-cli, core, forms ... platform-browser, platform-browser-dynamic, router Package Version --------------------------------------------------------- @angular-devkit/architect 0.1703.8 @angular-devkit/build-angular 17.3.8 @angular-devkit/core 17.3.8 @angular-devkit/schematics 17.3.8 @angular/cdk 17.3.10 @angular/cli 17.3.8 @angular/material 17.3.10 @schematics/angular 17.3.8 rxjs 7.8.1 typescript 5.4.5 zone.js 0.14.7 ``` ### Anything else? When this error occurs, the effects in other components stop working.
area: core,P3,bug,core: reactivity,cross-cutting: signals
low
Critical
2,516,924,135
PowerToys
Workspaces does not detect MATLAB
### Microsoft PowerToys version 0.84.1 ### Installation method PowerToys auto-update ### Running as admin Yes ### Area(s) with issue? Workspaces ### Steps to reproduce Try to capture workspace that includes MATLAB. It will not be detected. ### ✔️ Expected Behavior MATLAB is captured and properly launches as expected on workspace launch. ### ❌ Actual Behavior MATLAB is not detected and cannot be saved as part of a workspace. ### Other Software _No response_
Issue-Bug,Needs-Triage,Product-Workspaces
low
Minor
2,516,926,640
kubernetes
pods are not coming up after deleted reporting context deadline timeout
### What happened? After master rebooted the applications urls are not reachable. when we check the pods under kube-system is unstable. if delete the api sever pod its not re-creating. after restarting the kubelet and rebooting the master node also its not coming up and not only the api server if delete any pod its not re-creating reporting context deadline timout . when we run critcl pods cmd form node its showing the pods are not ready we deleted the container also and restarted the kubelet still the new pods are wen to not ready state. (default) 70934df403a49 5 hours ago NotReady gpu-operator-1723364509-node-feature-discovery-worker-z6nlt gpu-operator 3 (default) 6c60ae65023f2 5 hours ago NotReady loki-stack-promtail-xqmcr lokistack 3 (default) 5f32987deed24 5 hours ago NotReady metallb-speaker-6j85w metallb 26 (default) 1ddd316d9c2c1 5 hours ago NotReady nodelocaldns-tw6bl kube-system 4 (default) 614d8465c94ea 5 hours ago NotReady kube-proxy-wzdmv kube-system 3 (default) 54c963840cf43 5 hours ago NotReady calico-node-ffqgd kube-system 3 (default) 70a663f5a2ffb 5 hours ago NotReady trident-csi-9xps8 trident 3 (default) 9b326b0a30131 5 hours ago NotReady kube-prometheus-stack-prometheus-node-exporter-nj6vs monitoring 27 (default) 620e58e06c8eb 5 hours ago NotReady kube-scheduler-kube01b kube-system 11 (default) 4660b6476b1a3 5 hours ago NotReady kube-apiserver-kube01b kube-system 11 (default) 1ff46a3e2157b 5 hours ago NotReady kube-controller-manager-kube01b kube-system 11 (default) kubernetes version :1.23 ### What did you expect to happen? the pod should be ready state and kubelet get pods will need to show the pods ### How can we reproduce it (as minimally and precisely as possible)? we are facing issue ### Anything else we need to know? _No response_ ### Kubernetes version <details> ```console $ kubectl version [y000435a@cnpdcmldatagw01b ~]$ kubectl version Client Version: version.Info{Major:"1", Minor:"23", GitVersion:"v1.23.5", GitCommit:"c285e781331a3785a7f436042c65c5641ce8a9e9", GitTreeState:"clean", BuildDate:"2022-03-16T15:58:47Z", GoVersion:"go1.17.8", Compiler:"gc", Platform:"linux/amd64"} Server Version: version.Info{Major:"1", Minor:"23", GitVersion:"v1.23.5", GitCommit:"c285e781331a3785a7f436042c65c5641ce8a9e9", GitTreeState:"clean", BuildDate:"2022-03-16T15:52:18Z", GoVersion:"go1.17.8", Compiler:"gc", Platform:"linux/amd64"} [y000435a@cnpdcmldatagw01b ~]$ </details> ### Cloud provider <details> </details> On premises ### OS version <details> ```console # On Linux: $ cat /etc/os-release [y000435a@cnpdcmlk8smas01b ~]$ cat /etc/os-release NAME="Red Hat Enterprise Linux" VERSION="8.9 (Ootpa)" ID="rhel" ID_LIKE="fedora" VERSION_ID="8.9" PLATFORM_ID="platform:el8" PRETTY_NAME="Red Hat Enterprise Linux 8.9 (Ootpa)" ANSI_COLOR="0;31" CPE_NAME="cpe:/o:redhat:enterprise_linux:8::baseos" HOME_URL="https://www.redhat.com/" DOCUMENTATION_URL="https://access.redhat.com/documentation/en-us/red_hat_enterprise_linux/8" BUG_REPORT_URL="https://bugzilla.redhat.com/" REDHAT_BUGZILLA_PRODUCT="Red Hat Enterprise Linux 8" REDHAT_BUGZILLA_PRODUCT_VERSION=8.9 REDHAT_SUPPORT_PRODUCT="Red Hat Enterprise Linux" REDHAT_SUPPORT_PRODUCT_VERSION="8.9" [y000435a@cnpdcmlk8smas01b ~]$ uname -a Linux cnpdcmlk8smas01b.thriveai.kp.org 4.18.0-513.24.1.el8_9.x86_64 #1 SMP Thu Mar 14 14:20:09 EDT 2024 x86_64 x86_64 x86_64 GNU/Linux [y000435a@cnpdcmlk8smas01b ~]$ $ uname -a Linux cnpdcmlk8smas01b.thriveai.kp.org 4.18.0-513.24.1.el8_9.x86_64 #1 SMP Thu Mar 14 14:20:09 EDT 2024 x86_64 x86_64 x86_64 GNU/Linux # On Windows: C:\> wmic os get Caption, Version, BuildNumber, OSArchitecture # paste output here ``` </details> ### Install tools <details> </details> ### Container runtime (CRI) and version (if applicable) <details> </details> ### Related plugins (CNI, CSI, ...) and versions (if applicable) <details> </details>
kind/support,sig/node,lifecycle/rotten,needs-triage
low
Critical
2,516,927,550
TypeScript
Missing Handbook Content
### Acknowledgement - [x] I acknowledge that issues using this template may be closed without further explanation at the maintainer's discretion. ### Comment Cleaned up from raw notes from @navya9singh: ### Handbook * [ ] Isolated declarations * [ ] Decorators * [ ] JSDOc: add `@overload` and `@import` to https://www.typescriptlang.org/docs/handbook/jsdoc-supported-types.html * [ ] Add `satisfies` next to `as` * [ ] Add instantiation expressions to Generic Functions https://www.typescriptlang.org/docs/handbook/release-notes/typescript-4-7.html#instantiation-expressions * [ ] Add [extends constraints on infer](https://www.typescriptlang.org/docs/handbook/release-notes/typescript-4-7.html#extends-constraints-on-infer-type-variables) to conditional types * [x] Variance annotations * [ ] Explain supported [dependent parameters](https://www.typescriptlang.org/docs/handbook/release-notes/typescript-4-6.html#control-flow-analysis-for-dependent-parameters) in CFA * [ ] Add `ts-ignore` and `ts-expect-error` to Basics * [ ] Add more on striter generators [here](https://www.typescriptlang.org/docs/handbook/iterators-and-generators.html#handbook-content) * [ ] [Assertion functions](https://www.typescriptlang.org/docs/handbook/release-notes/typescript-3-7.html#assertion-functions) * [ ] Discuss reverse inference of mapped types ### TSConfig * [ ] Make a TSConfig 101 page with a short list of options, put it in the Handbook main flow * [ ] `$configDir` [link](https://www.typescriptlang.org/docs/handbook/release-notes/typescript-5-5.html#the-configdir-template-variable-for-configuration-files) * [ ] Multiple `extends` https://www.typescriptlang.org/docs/handbook/release-notes/typescript-5-0.html#supporting-multiple-configuration-files-in-extends ### Modules Reference * [ ] Resolution Mode (4.7, 5.3) [link](https://www.typescriptlang.org/docs/handbook/release-notes/typescript-5-3.html#resolution-mode-supported-in-all-module-modes)
Docs
low
Critical
2,516,956,609
PowerToys
MWB Issues with windows open as another user
### Microsoft PowerToys version 0.84.1 ### Installation method PowerToys auto-update, Microsoft Store ### Running as admin No ### Area(s) with issue? Mouse Without Borders ### Steps to reproduce This is all done on a remote machine. Open a program such as Active Directory as another user. Try to click on the window or type. nothing happens. If the window is focused, no other window can be clicked on. Any input device connected to the remote machine work normally. It's only remote inputs that don't work. This used to work a month or so ago. Not sure if this was due to a Windows update (where you have to do an extra right-click on a taskbar icon before you can shift right-click to get the run as option.) or this program. ### ✔️ Expected Behavior _No response_ ### ❌ Actual Behavior _No response_ ### Other Software _No response_
Issue-Bug,Needs-Triage
low
Minor
2,516,957,871
deno
Deno.chdir() breaks --watch reloading
Version: Deno 1.46.3 When calling `Deno.chdir()` to any directory, and the code is reloaded using the `--watch` flag, the module will be looked for in the new directory, not in the original root directory. More broadly, `Deno.chdir()` is a global which affects how `Deno` runs, which doesn't seem right. Minimum example: `main.ts` ```ts import { sleep } from "https://deno.land/x/openai@v4.55.7/core.ts"; import { checkdir } from "./imported.ts"; console.log("Files reloaded"); Deno.mkdirSync("temp", { recursive: true }); Deno.chdir("temp"); for (let i = 0; i < 1000; i++) { await sleep(1000); checkdir(); } ``` `imported.ts` ```ts export function checkdir() { console.log("Deno.cwd(): ", Deno.cwd()); } ``` Run this with ```sh deno run --allow-all --watch ./main.ts main.ts ``` Now save the `main.ts` file. Expected output: ``` Watcher File change detected! Restarting! Files reloaded Deno.cwd(): /Users/user/test-watch-chdir ... ``` Actual output: ``` Watcher File change detected! Restarting! error: Module not found "file:///Users/user/test-watch-chdir/temp/main.ts". Watcher Process failed. Restarting on file change... ```
bug
low
Critical
2,516,983,727
godot
Node::set_name and Node::get_name have inconsistent types
### Tested versions - 4.3-stable ### System information - Windows 10 ### Issue description Node::set_name is expecting a String parameter, while Node::get_name returns a StringName. This is not an issue when using GDScript as the language can seamlessly use both, but it is for third party languages that can use properties. When generating bindings for the Kotlin language, the `name` property for Node doesn't compile because of the difference in type between getter and setter. The language doesn't have implicit conversion like C++ or GDScript. To bypass this, we use StringName for both and rely on the C++ Variant ability to cast it back to String when calling `MethodBind::call`, but soon we will switch to `MethodBind::ptrcall` for optimization purposes and I think this won't work anymore. ### Steps to reproduce - ### Minimal reproduction project (MRP) -
enhancement,topic:core
low
Minor
2,517,038,163
godot
Editor window title and some button titles turn black when custom formatted tooltips are shown using Mobile/Forward+ renderer
### Tested versions 4.3.stable ### System information macOS 14.6.1 ### Issue description When using the Mobile or Forward+ renderers the window title of the macOS editor window, (and unselected tab items to the left of the selected) turn black instead of white when the window loses focus. Interestingly, this also happens when you hover over FileSystem file items and get their tooltip popups (I guess these tooltips are implemented differently than other tooltips, causing the window to lose focus?). The issue does not happen using the Compatibility renderer, which is also strange. Expected appearance (compatibility renderer): ![Screenshot 2024-09-10 at 19 01 30](https://github.com/user-attachments/assets/d2ec79f9-d3db-4a9d-9f75-cf0d08cfb492) Mobile (same on Forward+): ![Screenshot 2024-09-10 at 19 02 20](https://github.com/user-attachments/assets/3434f35a-200f-40fe-8202-d40c2b5ae082) Hover tooltip discrepancy. Notice effect when hovering over a file: https://github.com/user-attachments/assets/ad464126-5de5-4ee8-b1c8-18160cab7bf1 ### Steps to reproduce - Run the Godot editor on macOS with a project using Mobile or Forward+. - Open the About Godot or Settings window, causing the main window to lose focus. - Or, try hovering a file in the file system. ### Minimal reproduction project (MRP) Just editor required.
bug,topic:rendering
low
Minor
2,517,046,328
pytorch
Discussion about the testing methods in test_transformers.py after math backend always uses fp32
### 🐛 Describe the bug The current method to estimate the numerical errors in test_transformers.py is based on the difference b/w results from current precision and higher precision tensors https://github.com/pytorch/pytorch/blob/bc1b8f094d24de27432f4c29f0729e85a6b5ba63/test/test_transformers.py#L3107-L3108 https://github.com/pytorch/pytorch/blob/bc1b8f094d24de27432f4c29f0729e85a6b5ba63/test/test_transformers.py#L3118-L3122 https://github.com/pytorch/pytorch/blob/bc1b8f094d24de27432f4c29f0729e85a6b5ba63/test/test_transformers.py#L132-L133 https://github.com/pytorch/pytorch/blob/bc1b8f094d24de27432f4c29f0729e85a6b5ba63/test/test_transformers.py#L141-L145 However, with [PR 128922](https://github.com/pytorch/pytorch/pull/128922), the math backend always casts the input tensors to fp32 from 16-bit datatypes for better accuracy: https://github.com/pytorch/pytorch/blob/bc1b8f094d24de27432f4c29f0729e85a6b5ba63/aten/src/ATen/native/transformers/attention.cpp#L787-L801 Although PR 128922 fixed the tests on NV GPUs by raising the fudge factors, the assumptions of current numerical error estimation method do not hold anymore because `ref` and `_lp` tensors are fundamentally doing the same computation, and the errors between the two tensors are probably not measuring something meaningful for the purpose of estimating the SDPA's numerical errors. More concretely. I have inspected the output tensors of UT `TestSDPACudaOnlyCUDA.test_flash_attention_vs_math_ref_grads_batch_size_8_seq_len_q_2048_seq_len_k_2048_head_dim_8_is_causal_False_dropout_p_0_0_float16_scale_l1_enable_gqa_False_n_heads1_cuda_float16` The difference b/w the gold and reference is `4.76837158203125e-07` for `grad_query`, and `3.0510127544403076e-05` for `grad_key`, which looks more like tolerances for float32 instead of float16. ## Potential Solution 1 Add a Python based SDPA function (something similar to https://pytorch.org/docs/stable/generated/torch.nn.functional.scaled_dot_product_attention.html) in `test_transformers.py`, without casting fp16/bf16 to fp32 ## Potential Solution 2 Add a debug flag to Math backend function to disable the casting behavior ## Potential Solution 3 Other method to estimate the numerical error? ### Versions ``` PyTorch version: 2.5.0a0+git735162e Is debug build: False CUDA used to build PyTorch: N/A ROCM used to build PyTorch: 6.2.41133-dd7f95766 OS: Ubuntu 20.04.6 LTS (x86_64) GCC version: (Ubuntu 9.4.0-1ubuntu1~20.04.2) 9.4.0 Clang version: Could not collect CMake version: version 3.26.4 Libc version: glibc-2.31 Python version: 3.9.19 (main, May 6 2024, 19:43:03) [GCC 11.2.0] (64-bit runtime) Python platform: Linux-6.5.0-35-generic-x86_64-with-glibc2.31 Is CUDA available: True CUDA runtime version: Could not collect CUDA_MODULE_LOADING set to: LAZY GPU models and configuration: AMD Instinct MI210 (gfx90a:sramecc+:xnack-) Nvidia driver version: Could not collect cuDNN version: Could not collect HIP runtime version: 6.2.41133 MIOpen runtime version: 3.2.0 Is XNNPACK available: True CPU: Architecture: x86_64 CPU op-mode(s): 32-bit, 64-bit Byte Order: Little Endian Address sizes: 43 bits physical, 48 bits virtual CPU(s): 128 On-line CPU(s) list: 0-127 Thread(s) per core: 2 Core(s) per socket: 32 Socket(s): 2 NUMA node(s): 2 Vendor ID: AuthenticAMD CPU family: 23 Model: 49 Model name: AMD EPYC 7542 32-Core Processor Stepping: 0 Frequency boost: enabled CPU MHz: 1500.000 CPU max MHz: 2900.0000 CPU min MHz: 1500.0000 BogoMIPS: 5800.24 Virtualization: AMD-V L1d cache: 2 MiB L1i cache: 2 MiB L2 cache: 32 MiB L3 cache: 256 MiB NUMA node0 CPU(s): 0-31,64-95 NUMA node1 CPU(s): 32-63,96-127 Vulnerability Gather data sampling: Not affected Vulnerability Itlb multihit: Not affected Vulnerability L1tf: Not affected Vulnerability Mds: Not affected Vulnerability Meltdown: Not affected Vulnerability Mmio stale data: Not affected Vulnerability Retbleed: Mitigation; untrained return thunk; SMT enabled with STIBP protection Vulnerability Spec rstack overflow: Mitigation; Safe RET Vulnerability Spec store bypass: Mitigation; Speculative Store Bypass disabled via prctl Vulnerability Spectre v1: Mitigation; usercopy/swapgs barriers and __user pointer sanitization Vulnerability Spectre v2: Mitigation; Retpolines; IBPB conditional; STIBP always-on; RSB filling; PBRSB-eIBRS Not affected; BHI Not affected Vulnerability Srbds: Not affected Vulnerability Tsx async abort: Not affected Flags: fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush mmx fxsr sse sse2 ht syscall nx mmxext fxsr_opt pdpe1gb rdtscp lm constant_tsc rep_good nopl nonstop_tsc cpuid extd_apicid aperfmperf rapl pni pclmulqdq monitor ssse3 fma cx16 sse4_1 sse4_2 movbe popcnt aes xsave avx f16c rdrand lahf_lm cmp_legacy svm extapic cr8_legacy abm sse4a misalignsse 3dnowprefetch osvw ibs skinit wdt tce topoext perfctr_core perfctr_ nb bpext perfctr_llc mwaitx cpb cat_l3 cdp_l3 hw_pstate ssbd mba ibrs ibpb stibp vmmcall fsgsbase bmi1 avx2 smep bmi2 cqm rdt_a rdseed adx smap clflushopt clwb sha_ni xsaveopt xsavec xgetbv1 cqm_llc cqm_occup_llc cqm_mbm_total cqm_mbm_loc al clzero irperf xsaveerptr rdpru wbnoinvd amd_ppin arat npt lbrv svm_lock nrip_save tsc_scale vmcb_clean flushbyasid decodeassists pausefilter pfthreshold avic v_vmsave_vmload vgif v_spec_ctrl umip rdpid overflow_recov succor smca sev se v_es Versions of relevant libraries: [pip3] flake8==6.1.0 [pip3] flake8-bugbear==23.3.23 [pip3] flake8-comprehensions==3.15.0 [pip3] flake8-executable==2.1.3 [pip3] flake8-logging-format==0.9.0 [pip3] flake8-pyi==23.3.1 [pip3] flake8-simplify==0.19.3 [pip3] mypy==1.10.0 [pip3] mypy-extensions==1.0.0 [pip3] numpy==1.26.0 [pip3] optree==0.12.1 [pip3] pytorch-triton-rocm==3.0.0 [pip3] torch==2.5.0a0+git2aca0ae [pip3] torchaudio==2.4.0+rocm6.1 [pip3] torchvision==0.19.0a0 [pip3] triton==3.0.0 [conda] mkl 2021.4.0 h06a4308_640 [conda] mkl-include 2021.4.0 h06a4308_640 [conda] numpy 1.20.3 pypi_0 pypi [conda] optree 0.11.0 pypi_0 pypi [conda] torch 2.4.0a0+git6b37b45 pypi_0 pypi [conda] torchvision 0.19.0a0+69e03db pypi_0 pypi [conda] triton 3.0.0 pypi_0 pypi ``` cc @jbschlosser @bhosmer @cpuhrsch @erichan1 @drisspg @mikaylagawarecki
triaged,module: sdpa
low
Critical
2,517,082,774
go
go/printer: CL 609077 causes unintended formatting changes
[go.dev/cl/609077](https://go.dev/cl/609077) causes a change in formatting. Reading the CL description and the test cases leads me to believe that this change is unintended. Reproducer: ``` package main import ( "bytes" "fmt" "go/parser" "go/printer" "go/token" ) const content = `package foo type S struct { //- comment Name *string }` func main() { fset := token.NewFileSet() file, err := parser.ParseFile(fset, "", content, parser.ParseComments) if err != nil { panic(err) } var out bytes.Buffer if err := (&printer.Config{Mode: printer.TabIndent | printer.UseSpaces, Tabwidth: 8}).Fprint(&out, fset, file); err != nil { panic(err) } fmt.Println(out.String()) } ``` Before go.dev/cl/609077, this printed: ``` package foo type S struct { // - comment Name *string } ``` After go.dev/cl/609077, this prints: ``` package foo type S struct { //- comment Name *string } ```
NeedsInvestigation
low
Major
2,517,085,704
ui
[bug]: Input field outline color is not displayed on focus
### Describe the bug When focusing on an input field, the outline color is not appearing as expected. This issue affects the visual feedback when users interact with input elements, making it less clear that the field is active. Feel free to add additional details, such as browser versions, operating system, or any steps to reproduce the issue, to make the report more comprehensive. **Note: For latest version shadcn** ### Affected component/components Input ### How to reproduce :root { --background: #ffffff; --foreground: #171717; } @media (prefers-color-scheme: dark) { :root { --background: #0a0a0a; --foreground: #ededed; } } The main bug is here..... please fix it if i use this :root { --foreground-rgb: 0, 0, 0; --background-start-rgb: 214, 219, 220; --background-end-rgb: 255, 255, 255; } @media (prefers-color-scheme: dark) { :root { --foreground-rgb: 255, 255, 255; --background-start-rgb: 0, 0, 0; --background-end-rgb: 0, 0, 0; } } My bug fix...
bug
low
Critical
2,517,093,949
opencv
Difference in saturation behavior between single-channel and multi-channel matrix operations
### System Information OpenCV version 4.9.0 Operating System / Platform: Windows 10 Compiler & compiler version: MSVC2019 ### Detailed description For a single channel matrix `m`, an integer `c` and a cv::Scalar `b`, the operation ``` m = c*(m - b) ``` results in saturation being applied only after the right-hand-side has been fully evaluated. But for a multi-channel image, saturation is applied to `c*m` before subtracting `c*b`. This leads to unexpected results. Let `c` be 4, let `m` be an 8-Bit 3-channel matrix (CV_8UC3) and have a value of 100 for all pixels and channels, and let `b` have a value of 70 for each channel. The result of `c*(m-b)` should be a matrix with values of `4*(100 - 70) = 120`. Instead it is a matrix of zeros because `4*100` was capped at 255 and after subtracting `4*70` we get -25 which becomes 0 after the final saturation operation. The accepted answer to this issue on SO (https://stackoverflow.com/a/78963620/5398144) traces this to `MatOp_AddEx::assign` in core/src/matrix_expressions.cpp (https://github.com/opencv/opencv/blob/4.x/modules/core/src/matrix_expressions.cpp#L1342). A 3-channel matrix operation, with the addition of a 3-channel scalar fall into the final `else` statement: ``` else { e.a.convertTo(dst, e.a.type(), e.alpha); cv::add(dst, e.s, dst); } ``` So the operations that are happening boil down to: ``` m.convertTo(dst, m.type(), c); // which applies saturation to c*m cv::add(dst, -c*b, dst); ``` ### Steps to reproduce ``` #include <iostream> #include <opencv2/core/core.hpp> int main() { std::cout << "c m1 m3" << std::endl; for (int c = 1; c <= 9; c++){ cv::Mat m1 = cv::Mat::zeros(1,1, CV_8UC1); cv::Mat m3 = cv::Mat::zeros(1,1, CV_8UC3); m1 += cv::Scalar(100); m3 += cv::Scalar(100,100,100); cv::Scalar b1 = cv::Scalar(70); cv::Scalar b3 = cv::Scalar(70,70,70); m1 = c*(m1 - b1); m3 = c*(m3 - b3); int m1_val = m1.at<uchar>(0,0); int m3_val = m3.at<cv::Vec3b>(0,0)[0]; std::cout << c << " " << m1_val << " " << m3_val << std::endl; } return 0; } ``` Output: ``` c m1 m3 1 30 30 2 60 60 3 90 45 // For multi-channel 3*100 gets capped at 255. After subtraction of 3*70, result is 45 4 120 0 // For multi-channel 4*100 gets capped at 255. After subtraction of 4*70, result is 0 5 150 0 6 180 0 7 210 0 8 240 0 9 255 0 // The single-channel result is only capped once c*(30) is greater than 255 ``` ### Issue submission checklist - [X] I report the issue, it's not a question - [X] I checked the problem with documentation, FAQ, open issues, forum.opencv.org, Stack Overflow, etc and have not found any solution - [ ] I updated to the latest OpenCV version and the issue is still there - [X] There is reproducer code and related data files (videos, images, onnx, etc)
bug,category: core
low
Minor
2,517,121,486
godot
`CSGShape3D` with collision but no visuals do not show gizmo
### Tested versions Reproducible in 4.3.stable and 4.4.dev ### System information Godot v4.3.stable - Windows 10.0.22631 - Vulkan (Forward+) - dedicated NVIDIA GeForce GTX 1660 SUPER (NVIDIA; 32.0.15.6081) - Intel(R) Core(TM) i7-10700F CPU @ 2.90GHz (16 Threads) ### Issue description A `CSGShape3D` with `Use Collision` enabled, but set to invisible will not show any gizmos, as the gizmo visibility is linked to node visibility. This makes it impossible to visualize CSGs that are meant purely for collision purposes. ![CSG_Gizmo_Visibility](https://github.com/user-attachments/assets/6031567c-2fa1-4625-838f-98ab0fcf09b6) The expected behaviour would be for all `CSGShape3D` gizmos to remain on if _either_ the `Use Collision` property _or_ `Visible` property are true. Note that this is a follow-up issue to a series of prior issues and fixes. You can find a summary of them here: #86699 ### Steps to reproduce - Make any `CSGShape3D` in any scene - Enable its `Use Collision` property - Toggle its `Visible` property. - Note that the gizmo disappears when `Visible` is false. ### Minimal reproduction project (MRP) N/A
bug,topic:editor,topic:3d
low
Minor
2,517,123,763
tauri
[bug] use BUN package manager to create a project report "Error: cannot find module ... ...cli\tauri.js"
### Describe the bug Same as the title ,additionally use npm can run normally. ### Reproduction _No response_ ### Expected behavior _No response_ ### Full `tauri info` output ```text f:\tauri\new\BunTtV2>bun tauri info $ tauri info node:internal/modules/cjs/loader:1148 throw err; ^ Error: Cannot find module 'F:\F:\tauri\new\BunTtV2\node_modules\@tauri-apps\cli\tauri.js' at Module._resolveFilename (node:internal/modules/cjs/loader:1145:15) at Module._load (node:internal/modules/cjs/loader:986:27) at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:174:12) at node:internal/main/run_main_module:28:49 { code: 'MODULE_NOT_FOUND', requireStack: [] } Node.js v20.14.0 error: script "tauri" exited with code 1 ``` ### Stack trace _No response_ ### Additional context _No response_
type: bug,status: needs triage
low
Critical
2,517,145,625
terminal
Introduce keyboard shortcut for Clear buffer command
# Description of the new feature/enhancement Introduce a default keyboard shortcut, such as Control + Shift + K, for the Clear buffer command to ease keyboard users clearing the buffer.
Issue-Feature,Area-Settings,Product-Terminal
low
Minor
2,517,149,552
svelte
Svelte 5 TS: `class` property in template literal causes Unterminated template / Unexpected token!
### Describe the bug [Optional chaining](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Operators/Optional_chaining) to a property named `class` inside a [template literal](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Template_literals) in a TypeScript script breaks the Svelte 5 parser. ### Reproduction ```svelte <script lang="ts"> const str = `${obj?.class}`; </script> ``` [Throws `Unterminated template`.](https://svelte-5-preview.vercel.app/#H4sIAAAAAAAAAyWMQQrCMBBFrzIMLkX3sa14DlNoTKcSSZOQmQoScndTunyf91_BxXliVM-CwayECh8p4Rnll3bgL3mhxhy3bPelY5tdEvAmvHuNwhoHHQBsDCzAkqGH6VTi63O_WG-Y63TTobset6a22BpntziaUUneqI71D9lEj0KHAAAA) ```svelte <script lang="ts"> const str = `${obj?.class} ${42}`; </script> ``` [Throws `Unexpected token`.](https://svelte-5-preview.vercel.app/#H4sIAAAAAAAAAyWMQQrCMBAAv7IsPYqCeIqt4juM0JhuJZImIbsVJOTvpnicgZmCs_PEqO4Fg1kIFd5Swh3KN23AH_JCjTmu2W6mZ5tdEvAmvAaNwhovOgDYGFiAJcMAY1fi833dW2-YK3TldKzjWYf-8I9b0JZLnNzsaEIleaX6qD_ecy3KjQAAAA==) ### Severity blocking an upgrade
bug
low
Critical
2,517,161,482
godot
Mouse enter & exit signals trigger falsely when viewport is scaled (canvas_items mode) and mouse input is manually triggered
### Tested versions - Reproducible in Godot 4.3 Mono. ### System information Windows 11 - Godot Engine v4.3.stable.mono.official ### Issue description This seems to have been fixed, but it may only have been for 2D? For a 3D project I had to use the manual position update when I move the camera to get mouse enter and exit to trigger: https://github.com/godotengine/godot/issues/69708 doing this I seem to get the same additional bug with 2D or 3D resulting from a few steps. So, when calling something like this to manually update the mouse position: ```gdscript var mouse_event = InputEventMouseMotion.new() mouse_event.position = get_viewport().get_mouse_position() Input.parse_input_event(mouse_event) ``` ### Mouse Enter & Mouse Exit Signals will fire on an object at a different location to the mouse position if the viewport has been scaled and the stretch mode is set to canvas_items. i.e. `get_viewport().get_mouse_position()` seems to be accurately produced, and you can draw things to the screen or make things follow to that mouse location and it works and produces the correct location and output, but somewhere in the processing of handling the simulated mouse input above, it will seemingly use a different or incorrect position value (maybe due to scale). This causes other objects with mouse enter and exit signals to trigger when the mouse is not over them, or flickering to occur on the object you are mousing over. I'm not sure if I'm doing something wrong, please let me know. Or in any case if there is a good workaround, please let me know. ### Steps to reproduce 1. Create a 2D scene 2. set Project Settings -> Display -> Window -> Stretch -> Mode to **canvas_items** 3. create a 2D node and give it these functions ```gdscript extends Node2D var mousePos = Vector2.ZERO; # Called every frame. 'delta' is the elapsed time since the previous frame. func _process(delta: float) -> void: var mouse_event = InputEventMouseMotion.new() mouse_event.position = get_viewport().get_mouse_position() Input.parse_input_event(mouse_event) mousePos = mouse_event.position print(mousePos) queue_redraw() pass func _draw(): draw_circle(mousePos,20.0,Color.ANTIQUE_WHITE) pass ``` 4. Create a staticbody2D, with a sprite and a collision shape 5. give the static body a script with these functions ```gdscript extends StaticBody2D @onready var sprite = $Sprite2D func _on_mouse_entered() -> void: print("hit") sprite.modulate = Color.BROWN pass # Replace with function body. func _on_mouse_exited() -> void: sprite.modulate = Color.WHITE pass # Replace with function body. ``` 6. Run the game 7. Observe the proper behavior (do not scale the viewport yet) 8. Scale the viewport any way you'd like 9. Observe flickering and false positives. https://github.com/user-attachments/assets/14fccba0-d70b-475d-9e46-5899931a7f77 ### Minimal reproduction project (MRP) [ScalingMouseEnter_MRP.zip](https://github.com/user-attachments/files/16948759/ScalingMouseEnter_MRP.zip)
documentation,topic:input,topic:2d
low
Critical
2,517,200,056
vscode
[Feature Request] "Selection Highlight" max characters setting (currently hard-coded at 200)
<!-- ⚠️⚠️ Do Not Delete This! feature_request_template ⚠️⚠️ --> <!-- Please read our Rules of Conduct: https://opensource.microsoft.com/codeofconduct/ --> <!-- Please search existing issues to avoid creating duplicates. --> <!-- Describe the feature you'd like. --> [This issue from Nov 2020](https://github.com/microsoft/vscode/issues/111002) describes very clearly that the `editor.selectionHighlight` functionality works only for 200 characters or less. Computers are always getting faster - maybe this can be a setting?
feature-request,editor-core
low
Minor
2,517,262,035
ui
[bug]: Combobox should have similar focus to select and other inputs
### Describe the bug Currently when you focus on the combobox there is no focus ring. However, if you tab to the combobox (using focus-visible) there is a ring. The goal should be to make the combobox work like the select regarding focus rings. The problem is that the trigger for the combobox is a button and buttons in shadcn don't have a ring on focus. The Combobox example does not have the correct classes on the trigger (Button). <img width="522" alt="image" src="https://github.com/user-attachments/assets/d509dd69-c1fe-475d-9d2f-f021190b2dfc"> The Select component has focus classes on the trigger (Button): <img width="958" alt="image" src="https://github.com/user-attachments/assets/dee2baf8-02f7-48be-9f70-3d0e451ed02c"> When I add the tailwind focus classes to my combobox it seems to work ok, but not quite the experience as the Select. ``` <Popover open={open} onOpenChange={setOpen}> <PopoverTrigger asChild> <Button variant="outline" role="combobox" aria-expanded={open} className="w-[200px] justify-between ring-offset-background focus:outline-none focus:ring-2 focus:ring-ring focus:ring-offset-2" > ``` <img width="329" alt="image" src="https://github.com/user-attachments/assets/3f8f4b68-ca67-4be0-acf2-f2fedd321f32"> but maybe you want to have more integrated solution. ### Affected component/components Combobox ### How to reproduce 1. Click on combobox, is no focus ring. 2. Tab to combobox, there is focus ring. 3. Click on select, there is focus ring. 4. Tab to select, there is focus ring. ### Codesandbox/StackBlitz link https://ui.shadcn.com/docs/components/combobox ### Logs _No response_ ### System Info ```bash Chrome latest Shadcn latest ``` ### Before submitting - [X] I've made research efforts and searched the documentation - [X] I've searched for existing issues
bug
low
Critical
2,517,293,784
pytorch
LLaMA v3.1 on MPS backend breaks in BinaryOp mps::add_sub_lerp_template
### 🐛 Describe the bug Error: `failed assertion `[MPSNDArray initWithDevice:descriptor:isTextureBacked:] Error: total bytes of NDArray > 2**32'` Requires similar tiling approach to BinaryOp that was done for the batch matmul op here: PR #133430 Reproduces with running LLaMA v3.1 on the current nightly PyTorch. Script to repro ```python import torch import transformers if not torch.backends.mps.is_available(): raise RuntimeError( "Please enable MPS on your machine. See https://pytorch.org/docs/stable/backends.html#torch-multiprocessing-mp" ) _TORCH_DEVICE = "mps" pipeline = transformers.pipeline( "text-generation", model="meta-llama/Meta-Llama-3.1-8B-Instruct", device=_TORCH_DEVICE, torch_dtype=torch.bfloat16 ) needle = "needle" hay = "hay" # 3 + 1 chars per element target_num_tokens_approximate = 20_000 haystack = [hay] * target_num_tokens_approximate test_index = 42 haystack[test_index] = needle haystack_list = list(haystack) prompt = f""" Please return the index of the needle in the haystack as an integer. Return only the integer number index. <BEGIN HAYSTACK> {" ".join(haystack_list)} <END HAYSTACK> """ messages = [ {"role": "system", "content": prompt}, ] result = pipeline( messages, max_new_tokens=200, ) messages = result[0]["generated_text"] completion = messages[-1]["content"] print("successful inference") print(f"completion: {completion}") print(f"test_index: {test_index}") ``` ### Versions Collecting environment information... PyTorch version: 2.5.0.dev20240909 Is debug build: False CUDA used to build PyTorch: None ROCM used to build PyTorch: N/A OS: macOS 15.0 (arm64) GCC version: Could not collect Clang version: 15.0.0 (clang-1500.3.9.4) CMake version: version 3.30.2 Libc version: N/A Python version: 3.11.9 (main, Apr 19 2024, 11:43:47) [Clang 14.0.6 ] (64-bit runtime) Python platform: macOS-14.6-arm64-arm-64bit Is CUDA available: False CUDA runtime version: No CUDA CUDA_MODULE_LOADING set to: N/A GPU models and configuration: No CUDA Nvidia driver version: No CUDA cuDNN version: No CUDA HIP runtime version: N/A MIOpen runtime version: N/A Is XNNPACK available: True CPU: Apple M1 Ultra Versions of relevant libraries: [pip3] numpy==2.0.1 [pip3] torch==2.5.0.dev20240909 [pip3] torchaudio==2.5.0.dev20240909 [pip3] torchvision==0.20.0.dev20240909 [conda] numpy 2.0.1 pypi_0 pypi [conda] torch 2.5.0.dev20240909 pypi_0 pypi [conda] torchaudio 2.5.0.dev20240909 pypi_0 pypi [conda] torchvision 0.20.0.dev20240909 pypi_0 papi cc @ezyang @gchanan @zou3519 @kadeng @msaroufim @kulinseth @albanD @malfet @DenisVieriu97
high priority,triaged,module: mps
low
Critical
2,517,329,984
vscode
High resource usage and file watcher creation on github.dev
``` Version: 1.94.0-insider Commit: 8b7eb51f54d7e1492d9baf70454ab6547a4ff9df Date: 2024-09-10T05:04:21.546Z Browser: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/128.0.0.0 Safari/537.36 Edg/128.0.0.0 ``` When I opened up https://github.dev/microsoft/TypeScript/pull/59688, I found that my language service wasn't working, and every hover showed up as `Loading...`. <details> <summary> When I turned TypeScript's log level to `Trace`, the output I saw was something like the text in this `<details>` pane. </summary> ``` 2024-09-10 11:04:36.525 [trace] Creating file watcher for review://github%2B7b2276223a312c22726566223a7b2274797065223a332c226964223a223539363838227d7d/microsoft/TypeScript/tests/baselines/reference/node_modules/%40types/typescript__lib-es2015 2024-09-10 11:04:36.527 [trace] Creating file watcher for review://github%2B7b2276223a312c22726566223a7b2274797065223a332c226964223a223539363838227d7d/microsoft/TypeScript/tests/baselines/node_modules/%40typescript/lib-es2015 2024-09-10 11:04:36.529 [trace] Creating file watcher for review://github%2B7b2276223a312c22726566223a7b2274797065223a332c226964223a223539363838227d7d/microsoft/TypeScript/tests/baselines/node_modules/%40types/typescript__lib-es2015 2024-09-10 11:04:36.532 [trace] Creating file watcher for review://github%2B7b2276223a312c22726566223a7b2274797065223a332c226964223a223539363838227d7d/microsoft/TypeScript/tests/node_modules/%40typescript/lib-es2015 ```2024-09-10 11:04:36.547 [trace] Creating file watcher for review://github%2B7b2276223a312c22726566223a7b2274797065223a332c226964223a223539363838227d7d/microsoft/TypeScript/tests/node_modules/%40types/typescript__lib-es2015 2024-09-10 11:04:36.550 [trace] Creating file watcher for review://github%2B7b2276223a312c22726566223a7b2274797065223a332c226964223a223539363838227d7d/microsoft/TypeScript/node_modules/%40typescript/lib-es2015 2024-09-10 11:04:36.554 [trace] Creating file watcher for review://github%2B7b2276223a312c22726566223a7b2274797065223a332c226964223a223539363838227d7d/microsoft/TypeScript/node_modules/%40types/typescript__lib-es2015 2024-09-10 11:04:36.557 [trace] Creating file watcher for review://github%2B7b2276223a312c22726566223a7b2274797065223a332c226964223a223539363838227d7d/microsoft/node_modules/%40typescript/lib-es2015 2024-09-10 11:04:36.559 [trace] Creating file watcher for review://github%2B7b2276223a312c22726566223a7b2274797065223a332c226964223a223539363838227d7d/microsoft/node_modules/%40types/typescript__lib-es2015 2024-09-10 11:04:36.847 [trace] Creating file watcher for review://github%2B7b2276223a312c22726566223a7b2274797065223a332c226964223a223539363838227d7d/microsoft/TypeScript/tests/baselines/reference/tsserver/fourslashServer/node_modules/%40typescript/lib-webworker 2024-09-10 11:04:36.850 [trace] Creating file watcher for review://github%2B7b2276223a312c22726566223a7b2274797065223a332c226964223a223539363838227d7d/microsoft/TypeScript/tests/baselines/reference/tsserver/fourslashServer/node_modules/%40types/typescript__lib-webworker 2024-09-10 11:04:36.854 [trace] Creating file watcher for review://github%2B7b2276223a312c22726566223a7b2274797065223a332c226964223a223539363838227d7d/microsoft/TypeScript/tests/baselines/reference/tsserver/node_modules/%40typescript/lib-webworker 2024-09-10 11:04:36.858 [trace] Creating file watcher for review://github%2B7b2276223a312c22726566223a7b2274797065223a332c226964223a223539363838227d7d/microsoft/TypeScript/tests/baselines/reference/tsserver/node_modules/%40types/typescript__lib-webworker 2024-09-10 11:04:36.861 [trace] Creating file watcher for review://github%2B7b2276223a312c22726566223a7b2274797065223a332c226964223a223539363838227d7d/microsoft/TypeScript/tests/baselines/reference/node_modules/%40typescript/lib-webworker 2024-09-10 11:04:36.864 [trace] Creating file watcher for review://github%2B7b2276223a312c22726566223a7b2274797065223a332c226964223a223539363838227d7d/microsoft/TypeScript/tests/baselines/reference/node_modules/%40types/typescript__lib-webworker 2024-09-10 11:04:36.882 [trace] Creating file watcher for review://github%2B7b2276223a312c22726566223a7b2274797065223a332c226964223a223539363838227d7d/microsoft/TypeScript/tests/baselines/node_modules/%40typescript/lib-webworker 2024-09-10 11:04:36.884 [trace] Creating file watcher for review://github%2B7b2276223a312c22726566223a7b2274797065223a332c226964223a223539363838227d7d/microsoft/TypeScript/tests/baselines/node_modules/%40types/typescript__lib-webworker 2024-09-10 11:04:36.889 [trace] Creating file watcher for review://github%2B7b2276223a312c22726566223a7b2274797065223a332c226964223a223539363838227d7d/microsoft/TypeScript/tests/node_modules/%40typescript/lib-webworker 2024-09-10 11:04:36.892 [trace] Creating file watcher for review://github%2B7b2276223a312c22726566223a7b2274797065223a332c226964223a223539363838227d7d/microsoft/TypeScript/tests/node_modules/%40types/typescript__lib-webworker 2024-09-10 11:04:36.894 [trace] Creating file watcher for review://github%2B7b2276223a312c22726566223a7b2274797065223a332c226964223a223539363838227d7d/microsoft/TypeScript/node_modules/%40typescript/lib-webworke ``` </details> With something like the following interspersed: ``` 2024-09-10 11:07:31.168 [trace] <diagnostics> Event received: configFileDiag (0). { "triggerFile": "/review/github+7b2276223a312c22726566223a7b2274797065223a332c226964223a223539363838227d7d/microsoft/TypeScript/tests/baselines/reference/tsserver/fourslashServer/pasteEdits_existingImports1.js", "configFile": "/review/github+7b2276223a312c22726566223a7b2274797065223a332c226964223a223539363838227d7d/microsoft/TypeScript/tests/baselines/reference/tsserver/fourslashServer/tsconfig.json", "diagnostics": [ { "text": "Cannot read file '/review/github+7b2276223a312c22726566223a7b2274797065223a332c226964223a223539363838227d7d/microsoft/TypeScript/tests/baselines/reference/tsserver/fourslashServer/tsconfig.json'.", "code": 5083, "category": "error" }, { "text": "No inputs were found in config file '/review/github+7b2276223a312c22726566223a7b2274797065223a332c226964223a223539363838227d7d/microsoft/TypeScript/tests/baselines/reference/tsserver/fourslashServer/tsconfig.json'. Specified 'include' paths were '[\"**/*\"]' and 'exclude' paths were '[]'.", "code": 18003, "category": "error" } ] } ``` My browser's diagnostic tools signaled the process was maxing out at least a few cores and that the process was pushing close to 1GB in memory usage.
bug,typescript,freeze-slow-crash-leak,web
low
Critical
2,517,403,588
pytorch
Generic BLAS provider incorrectly considered "found"
### 🐛 Describe the bug When the BLAS provider is configured to be `"Generic"` Torch's `Dependencies.cmake` executes [the following logic](https://github.com/pytorch/pytorch/blob/main/cmake/Dependencies.cmake#L236-L241): ``` find_library(BLAS_LIBRARIES NAMES ${GENERIC_BLAS}) message("-- Using BLAS: ${BLAS_LIBRARIES}") list(APPEND Caffe2_DEPENDENCY_LIBS ${BLAS_LIBRARIES}) set(GENERIC_BLAS_FOUND TRUE) set(BLAS_INFO "generic") set(BLAS_FOUND 1) ``` However, this does not take into consideration the case in which `find_library` does not actually find the BLAS library. In such as case the variable `BLAS_LIBRARIES` is set to `BLAS_LIBRARIES-NOTFOUND`. However, the above logic _always_ sets the status of BLAS detection to a positive result, meaning in this case we have a false positive. ``` list(APPEND Caffe2_DEPENDENCY_LIBS ${BLAS_LIBRARIES}) ``` Then incorporates the variable into the link interface. We can oberved output like ``` -- Using BLAS: BLAS_LIBRARIES-NOTFOUND ``` from the build and finally a generate time error like: ``` CMake Error: The following variables are used in this project, but they are set to NOTFOUND. Please set them or make sure they are set and tested correctly in the CMake files: BLAS_LIBRARIES linked by target "torch_cpu" in directory C:/spack/py-torch-2.4.1-xselqwv/spack-src/caffe2 linked by target "torch_cpu" in directory C:/spack/py-torch-2.4.1-xselqwv/spack-src/caffe2 ``` From [these lines (included inline below)](https://github.com/pytorch/pytorch/blob/main/cmake/Dependencies.cmake#L249-L251) ``` if(NOT (ATLAS_FOUND OR BLIS_FOUND OR GENERIC_BLAS_FOUND OR MKL_FOUND OR OpenBLAS_FOUND OR VECLIB_FOUND OR FlexiBLAS_FOUND OR NVPL_BLAS_FOUND)) message(WARNING "Preferred BLAS (" ${BLAS} ") cannot be found, now searching for a general BLAS library") find_package(BLAS) ``` It's clear that failing to find the generic provider should result in this fallback strategy being implemented. Instead, regardless of whether BLAS is found or not, we skip this logic, and wind up with an incomplete CMake run. ### Versions ``` PyTorch version: N/A Is debug build: N/A CUDA used to build PyTorch: N/A ROCM used to build PyTorch: N/A OS: Microsoft Windows 11 Pro GCC version: Could not collect Clang version: Could not collect CMake version: version 3.29.3 Libc version: N/A Python version: 3.11.3 (tags/v3.11.3:f3909b8, Apr 4 2023, 23:49:59) [MSC v.1934 64 bit (AMD64)] (64-bit runtime) Python platform: Windows-10-10.0.22631-SP0 Is CUDA available: N/A CUDA runtime version: 11.3.58 CUDA_MODULE_LOADING set to: N/A GPU models and configuration: GPU 0: Quadro T2000 Nvidia driver version: 555.99 cuDNN version: Could not collect HIP runtime version: N/A MIOpen runtime version: N/A Is XNNPACK available: N/A CPU: Architecture=9 CurrentClockSpeed=2304 DeviceID=CPU0 Family=207 L2CacheSize=2048 L2CacheSpeed= Manufacturer=GenuineIntel MaxClockSpeed=2304 Name=Intel(R) Core(TM) i9-9880H CPU @ 2.30GHz ProcessorType=3 Revision= Versions of relevant libraries: [pip3] flake8==6.1.0 [pip3] mypy==1.10.0 [pip3] mypy-extensions==1.0.0 [pip3] numpy==1.26.0 [conda] Could not collect ``` As this was a CMake failure, there's no built pytorch, and the MSVC version was irrelevant. FWIW this error was observed by the Spack project. cc @malfet @seemethere
module: build,triaged
low
Critical
2,517,429,288
PowerToys
Keyboard Manager support through RDP
### Description of the new feature / enhancement In a remote desktop session (specifically Windows), the keys typed follow the layout from the remote desktop's settings. It would be helpful for the custom key mapping made with Keyboard Manager to carry over to the remote desktop. ### Scenario when this would be used? I use the Colemak keyboard layout. This is not a Windows default, so I had to download and install a custom layout file for it. When I use an RDP, this layout setting on my host machine does not carry over, so I still type in QWERTY. I do not have the permissions to download things to some of the RDPs I use, so I have to look at my keyboard whenever I type. If I was able to have my host machine layout set to QWERTY, but use Keyboard Manager to remap the keys to Colemak, and then have that remapping still apply across an RDP session, that would be incredibly helpful. I could also imagine this would be helpful for anyone using custom shortcuts and not specifically 1-1 key remapping. ### Supporting information _No response_
Needs-Triage
low
Minor
2,517,487,815
svelte
Custom action event typings don't get picked up properly
### Describe the bug I just discovered that in a Svelte-TypeScript project, the typings of custom events that are sent from actions don't get picked up, unless `lang="ts"` is defined on the script tag. I can see that this might be an intended behaviour, but it caused me a few hours of headache, so I'd love to have a discussion about it and possibly a small note in the docs. ### Reproduction 1. Clone `https://github.com/adevien-solutions/svelte-appear-transition` 2. Install dependencies 3. Open `src/routes/+page.svelte` and see that it has no errors 4. Remove `lang="ts"` on line 1 5. See that TypeScript now throws errors on line 53-54 because it has no information about the events ### Logs _No response_ ### System Info ```shell System: OS: macOS 14.5 CPU: (10) arm64 Apple M1 Pro Memory: 124.31 MB / 16.00 GB Shell: 5.9 - /bin/zsh Binaries: Node: 22.2.0 - /opt/homebrew/bin/node Yarn: 1.22.19 - /opt/homebrew/bin/yarn npm: 10.7.0 - /opt/homebrew/bin/npm pnpm: 9.1.4 - ~/Library/pnpm/pnpm Browsers: Chrome: 128.0.6613.120 Safari: 17.5 npmPackages: svelte: 5.0.0-next.244 => 5.0.0-next.244 ``` ### Severity annoyance
types / typescript
low
Critical