text
stringlengths
1
5.2k
labels
listlengths
1
1
let us shoot for years at least
[ 0 ]
this script comes from package and very soon will be useless legacy
[ 0 ]
> Microsoft has shifted its focus to WinUI 3, give it up, rubbish WPF. Abandoned UI frameworks I am aware of since the introduction of WPF: - Silverlight - WinRT - WinPRT - Windows Universal Apps (for Windows 8) - UWP (WinUI 2) If you believe that WinUI 3 will stay alive for more than 2-3 years, then you haven't been paying attention.
[ 1 ]
identity uri and auth uri should be used instead of auth host auth port and auth protocol
[ 0 ]
just to be clear by a new fix coming up did you mean the monkey patching to eliminate true concurrency c ceilometer cli py
[ 0 ]
as per c eike wants rtl logfile context author killed without any replacement and yeah that probably makes sense could you adjust
[ 0 ]
the kb is an invaild hugepage size i would remove i e kb
[ 0 ]
this exception wrapping are pretty useless unless you plan to embed something in them or plan to inherit from some other exception
[ 0 ]
noinline getsubclass
[ 0 ]
trailing white spaces should be removed
[ 0 ]
as notify ha interfaces updated called again at l can we remove this here at l
[ 0 ]
All args need to be documented, even if its just going to refer to something else since that will at least prompt you to look at the reference vs. just wondering wtf it's doing.
[ 1 ]
nit i would remove the local variables and modify l like this openstack l ct l cg timestamp timestamp sp l cg pid pid
[ 0 ]
prefer to mock linux utils execute
[ 0 ]
nit i would like to keep some of the explanation reported by the original berrange s comment it is useful for ppl reading the code which are not aware of the stupid default logic in libvirt
[ 0 ]
yeah dumb to miss that one
[ 0 ]
new username uuid uuid hex
[ 0 ]
once the amphora has successfully started it is api it should start sending heartbeats to the controller
[ 0 ]
You know I'm a sucker for the consistency argument. Sounds like a plan.
[ 1 ]
Can you fix #9234 too? The number of regressions from that pr is getting a bit ridiculous now.
[ 1 ]
okay then why is not compile ovs run with true instead of false that is how plugin sh runs
[ 0 ]
Damn the naming! good catch
[ 1 ]
nit spaces around i e while pid waitpid status child
[ 0 ]
this will be an error prone build failure should be suppresswarnings deprecation lol
[ 0 ]
in fact port list uuid should be empty
[ 0 ]
completely unhelpful comment please be more specific about your objections
[ 0 ]
nit drop the sudo user var instead just have a sudo cmd array that is built up also checked tests and or expanded em
[ 0 ]
we should get rid of the noqa
[ 0 ]
this was a straight copy paste from laziness done
[ 0 ]
Just me being a pain in the ass about MW whitespacing conventions :-)
[ 1 ]
Ya it turns out it is, when I downloaded "fresh" files they came fucked up. I think reverting to the previous error would be smart:
[ 1 ]
> Bullshit , we have topic limited.
[ 1 ]
this sets dependency on opendaylight debian package so if apt get install opendaylight will be executed then automatically openjdk will be installed this is redundant because in puppet manifest we also require openjdk package to be installed but i left it here in case someone want install this deb file manually
[ 0 ]
As an afterthought i don't really know if this will effect anybody? Maybe everybody got at least a couple posts in the feed? Or maybe not, i got 4 items in my feed, and its just rubbish from you guys, so maybe every normal user has an empty feed.
[ 1 ]
can i go "i'll do this in a later pr"? this actually looks like a pain in the ass and would probably require a full refactor if i was to do it.
[ 1 ]
Something wacky is going on with functions that I need to fix ASAP. I believe this is the exact same cause of #1169.
[ 1 ]
Whoops, that's embarrassing. Fixed.
[ 1 ]
you could save the router here cls rot
[ 0 ]
can you not just move the call to update_drone_Hack to after the point the mob is put in? because this is gross as fuck
[ 1 ]
same docstring issue here
[ 0 ]
inherit from serverpasswordtestv then why create this use this one self fake req fakes httprequest blank
[ 0 ]
Damn I thought I had them all.
[ 1 ]
remove daterangepicker
[ 0 ]
we are not going to refer to other components using link type see line
[ 0 ]
I actually started with that- they have it plainly- but this futureproofs some shit. If i remkved the race check here its also work on disabled. This is just cleaner code that. I preferred
[ 1 ]
this command needs to be executed by another user dbadmin and not root
[ 0 ]
GpsDot is a bit of a weird case, since it needs to render when the actor is hidden.
[ 1 ]
God damn it, I left this in.
[ 1 ]
should really use getline instead of fgets fgets should burn forever
[ 0 ]
listing the related docstrings here seems silly as they are listed below why not just remove this section
[ 0 ]
> closing a PR for purely arbitrary reasons That's awful!
[ 1 ]
i think the superclass delete method should do this for you
[ 0 ]
thanks ian mark is addressing the case of special immediate values in left shifts on x here
[ 0 ]
weak equ
[ 0 ]
lock dir should be removed manually after the test
[ 0 ]
i would like to add two more tests test delete bay with name not found test delete multiple bay with name
[ 0 ]
Ya this is super dope, I've seen several instances where this code path can explode due to dev bugs and then an "active text edit" is till happening behind the scenes which exacerbates the issue.
[ 1 ]
runcommandcaptupreoutput cmd log stdout to file blah print cmd false
[ 0 ]
this should be find policy
[ 0 ]
these deps are not needed since we already install them in testenv above
[ 0 ]
Does this even log any other attack message? Or just "tried to knock you unconscious"? Because that's not very descriptive as to what the fuck is going on
[ 1 ]
you almost never want to clean up the way teardown works instead you probably want something like this at the end of setup def cleanup servers for i in self nova servers list self addcleanup cleanup servers the main reason is that teardown does not get called on failures
[ 0 ]
confuses with src.z, its deliberately so you cant fuck it up
[ 1 ]
nit tast
[ 0 ]
but why. c sharp always sucked. at least for web. no one ever used it. there's a reason iis has 10% share. everyone who had any real web apps went to php js ruby whatever. c sharp has never been anywhere on the web . why limit yourselves to ms crappy tools. crappy webservers
[ 1 ]
its a lower layer so its not at the top of the fucking mining lockers ree
[ 1 ]
ifdef config mtk iommu
[ 0 ]
This is really getting ridiculous! I created this PR in JULY and now is OCTOBER! How can it be that this small but very very important fix has not been merged within THREE Months?!
[ 1 ]
i think this should be a class property eg class basehostmanager host manager hostmanager property def host state cls self host node kwargs factory function property to create a new hoststate may be overridden in subclasses to extend functionality return nodestate host node kwargs
[ 0 ]
This reads a bit weird. Maybe "If a resource of type `R` already exists, its value will be overwritten."?
[ 1 ]
pdps can be nullptr here if pdoc haspivottable was false so that needs to be checked before dereferenced best executed all related new code only if pdps nullptr
[ 0 ]
PC load letter? What the hell does that mean??
[ 1 ]
Damn! I don't even know what I wrote...
[ 1 ]
whoops bad copying job on my part done
[ 0 ]
kill blank line
[ 0 ]
Damn it, I knew there was such a clean way to do it. Ty!
[ 1 ]
> Why do we even have this? It's nonsense. You're stuffing a car battery into a screwdriver or electric chainsaw? I see you requested changes, but I can't seem to view what those changes are. Would you rather remove the mod entirely?
[ 1 ]
sll halen should be rta payload rta not rta len fixed in ps
[ 0 ]
Oh damn, just searched the json and src folders. Properly deleting stuff is hard.
[ 1 ]
this means i have no fucking idea why i did that
[ 1 ]
you mean they're not? shit I fucked up
[ 1 ]
since the typos are fixed in py yaml and sh files could you change this to fix typos in kolla files
[ 0 ]
that s a typo i do this the whole time stupid bash messing with my mind fixed
[ 0 ]
due to autodoc bullshit, nodrop, undisarmability, etc, it's best this be at 18 force, same as a spear. give it a block_upgrade_walk 1, and block_flags = BLOCKING_ACTIVE | BLOCKING_NASTY
[ 1 ]
wait hold on, I asked fucking 4 times if looping sounds we a possible thing and no one said this? Regardless, this doesn't work when the loop consists of random sounds
[ 1 ]
....... ............................................................ what the hell is this
[ 1 ]
after testing the stop command would be more robust if it went ahead and deleted the tr api pid tr cond pid and tr tmgr pid similar to how stop deps is deleting all the pid files this would allow a user to debug individual trove services in screen and also still call redstack stop to kill them all and start to start them back up
[ 0 ]
seems that this should be in a utility for removing a child block
[ 0 ]
do you have already a potential fix from what you describe here i do not see a way out if we need to kill overlapping ips maybe let us just do that
[ 0 ]
this should go to a mixin from here and restore not in this patch though
[ 0 ]
make this a colon
[ 0 ]
Goddamnit I wish we had gas datums.
[ 1 ]
Yeah, who wouldn't have known to search for "screen rubbish" when looking for duplicates before posting an issue :/
[ 1 ]
wait I just realized THESE ARE ALL THE SAME FUCKING POSITION
[ 1 ]
i changed the sh c style back to the normal style but it seems that an empty double quoted string still needs escaping
[ 0 ]
my mistake here it should be set as side efect of server rebuild
[ 0 ]
i will leave them here for now we may move them when we polish the ui to better match the mocks
[ 0 ]
i was wondering if i needed that but none of the rc files in system core rootdir android mk seem to set it but even with that i get product copy files device generic brillo brilloemulator init brillo rc root init brillo rc ignored make entering directory derat android mnc brillo dev make no rule to make target system webservd webservd init webservd rc needed by out target product brilloemulator obj etc init webservd rc intermediates init webservd rc stop make waiting for unfinished jobs generate device generic brillo init template rc in out target product brilloemulator obj etc init firewalld rc intermediates init firewalld rc make leaving directory derat android mnc brillo dev
[ 0 ]
maybe make all the keys lowercased
[ 0 ]
this is worth more than a debug i think admins are going to want to know that all their memcache hosts are dead
[ 0 ]