text
stringlengths 1
5.2k
| labels
listlengths 1
1
|
|---|---|
if you omit the endpoints the delegation is useless
|
[
0
] |
can still improve it damnit, these comments are bad Comments are holy or what xD
|
[
1
] |
you should normalize power role and data role ie power role
|
[
0
] |
there is no firewall chain could you please generate example conf by executing tox egenconfig again
|
[
0
] |
did you mean x a fa f again consider x da fa f
|
[
0
] |
this dcheck is not needed as dereferencing nullptr will because a crash anyway
|
[
0
] |
nit self plugin get network info assert called once with also is this relevant to the test
|
[
0
] |
nit i would remove the local variables and modify l like this openstack l ct l cg timestamp timestamp sp l cg pid pid
|
[
0
] |
s wether whether fun fact wether is a castrated male sheep d
|
[
0
] |
+@dhowett as an fyi since I'll be on leave before I get to the root of this. I'd reckon it should be in 22000. I forget if there's something wacky we're doing to get mouse mode enabled by default (we might be)
|
[
1
] |
That is weird, Pylint should totally report this as an invalid name.
|
[
1
] |
looks like you are missing a newline here
|
[
0
] |
might go apeshit at 12pm, just use a spawn()
|
[
1
] |
> I also don't like the "solution" to simply not allow : in filenames just because Windows can't handle it. It's just stupid to get driven by the easiest way. :see_no_evil: :speak_no_evil: :hear_no_evil: This is not longer the case since 8.1 - https://github.com/owncloud/core/pull/14346
|
[
1
] |
the only difference here is diff vs show and commit vs head assuming commit is not already head you should extract those out
|
[
0
] |
It used to, something must have fucked it up at some point --- You can still modify it if you have DEBUG
|
[
1
] |
put the trailing space outside of trans please it is error prone for the translators and does not even have any meaning when translating
|
[
0
] |
Sorry for the ridiculous delay in coming back to this PR.... but at least I got back to it before Christmas! :christmas_tree:
|
[
1
] |
pls docstring
|
[
0
] |
please mock tempfile mkdtemp
|
[
0
] |
shit need to take another look at this
|
[
1
] |
babe? =))))))))))))
In ro: babe = grandmother =)))
|
[
1
] |
Also, side note: that comments broke things is ... ridiculous and amusing
|
[
1
] |
withparaminterface should be removed now
|
[
0
] |
oh darn, I overlooked that one
|
[
1
] |
alphabetized dbus client initialization
|
[
0
] |
oops I kind of got lazy due to spending fucking forever on the meme conflict
|
[
1
] |
this try except is redundant
|
[
0
] |
def file path self class file path end
|
[
0
] |
nit i think it would be clearer to use all targets inlined and one target inlined instead of one target not inlined and ont target inlined
|
[
0
] |
Do we know what this function is used for yet? Without that its going to be hard to guess what the variables are doing. I do the same approach for when I reverse, make a rubbish c version, clean it up, play with it until I can work out what each variable does, rewrite the function with correct names.
|
[
1
] |
literal ass similar line and
|
[
0
] |
I hate this, it's awful, can you not just use the same logic that dragging one bag onto another does?
|
[
1
] |
not forever the command will be killed at
|
[
0
] |
Code is AWFUL NONONO OH MY EYES
|
[
1
] |
this should be collapsed so that the lw is all in the log warning
|
[
0
] |
Just discovered more nonsense in mbstring, specifically in its implementation of HTML entities. Sigh. Details in the commit log messages on this PR.
|
[
1
] |
and lastly refactor this one for rmw ing mmacp i s bit resolution en
|
[
0
] |
I have removed beetroot and added heavenly berries and hellish berries.
|
[
1
] |
do you mean sqlalchemy orm sessionmaker here which is get maker
|
[
0
] |
these new mocks seem to be overly broad my understanding of this is that any object using time time not just the monasca common kafka producer will be effected by this mock is that your understanding if it is then this may work in the current case but seems dangerous for future development i would prefer to mock as specifically as possible to avoid unintentionally disabling functionality in objects
|
[
0
] |
Ah damn, I thought I'd fixed that. I don't suppose there's some way of specifying that an object has to be one type specifically, and not a subtype?
|
[
1
] |
This syntax is ugly. Don't return and assign something at the same time. Also, why are you changing the return value here?
|
[
1
] |
this conditional include should not be needed when all printfs are sal infos then
|
[
0
] |
Problem is "side effect" is too generic. Could be some weird optimization issue on some platform, could be even compiler bug.
|
[
1
] |
Really ugly to use a flag like this. I'd move all the sound effects inside the carousel instead, so you don't need to have weird logic like this.
|
[
1
] |
useless setup
|
[
0
] |
I'm gonna say this should probably be made a world message in userdanger spans so everyone knows "welp shit is fucked
|
[
1
] |
yes let me add the flag first after this cl i will update ios api py and remove use goma canary
|
[
0
] |
the json filter needs to die in a fire imho but not right now
|
[
0
] |
remove it is useless
|
[
0
] |
this seems a bit vague may be something like compute and record anchor element navigation overall score based on browser and renderer metrics or compute and record anchor element navigation overall score
|
[
0
] |
>release slimes you wot they release gold slime cores, not slimes, you fucking ass
|
[
1
] |
there should be a parameter types domain id
|
[
0
] |
why is this needed if fontlist is not holding references to svxfontnamebox impl anymore that is enough for the svxfontnamebox impl dtor to be called
|
[
0
] |
we had long lines for names before and personally i dislike split string literals especially when there are no spaces i will see what does not look horrible
|
[
0
] |
There are 3 definitions in 106 lines of code. WTF?
|
[
1
] |
don t need this because you are stubbing out readlink
|
[
0
] |
test case for failure of fsck is absent what do we expect in that case
|
[
0
] |
needs die the l does not hurt but it is redundant as explicit args get derefed by default
|
[
0
] |
> Very productive argument you guys had over that cost Kind of a dick way to say it's not enough silver but I get your point.
|
[
1
] |
Ah Use this shit then
|
[
1
] |
i believe should should be false since you do not care about descendents of this uri
|
[
0
] |
inherit from serverpasswordtestv then why create this use this one self fake req fakes httprequest blank
|
[
0
] |
remove these as you have pragma once already
|
[
0
] |
good question i think you could check the uma data for net quicsession connectionclose numopenstreams timedout which logs the number of open streams when a connection times out that should be a good reference point might be a good upper bound
|
[
0
] |
Damn. Looks like we need to support MacOS 10.14 at minimum for this to work. \U0001f61e
|
[
1
] |
The `var/` bit is implied, you can just do `mob/living/...` Also this is some weird typecasting, not that it matters here
|
[
1
] |
let s rename all activedirectory to dummy or something like this
|
[
0
] |
That's because in all my `vector`-related excitement I screwed up the caret function! Fixed.
|
[
1
] |
why adding delete methods in this class it is called swiftupload class
|
[
0
] |
OMG freaking autoformat.
|
[
1
] |
i will suggest to add networking huawei drivers dummy config config huawei dummy driver opts
|
[
0
] |
iife is malformed should be
|
[
0
] |
Damn! I seriously read the sentence like 20 times before I finally saw the word "as" and only now does it make sense. Ha! Sorry about that. Every day my BS in Linguistics gets a little more invalidated...
|
[
1
] |
Okay I assume this is hacky as fuck to make the build work for lastSpeakTime xD (maybe not, I don't know? I am no pro at this) If this is hack af, how the fuck could I fix this to work xD
|
[
1
] |
we can start fetching the image data only when webstate is valid but it does not matter if webstate is destroyed after calling this method would you prefer to use if webstate return instead of dcheck to make it safer
|
[
0
] |
Good point, that kind of sucks.
|
[
1
] |
the stopall should be used and this can be removed
|
[
0
] |
damn it, thought I'd gotten rid of that. ty
|
[
1
] |
missing signed off by you can both yours and mine git commit amend s will add yours automatically
|
[
0
] |
to be fair it is even more mad that you were returning something from decode that does not support being decoded i did not say you could not use binary object if you wanted to just that opcode as an interface was pointless i change binary decode because i want to be able to support compatibility shims that can decode old data but not re encode it makes total sense also given that i changed it a while ago there is not a single occurrence of a cast in our code base and you have not even noticed let alone been badly affected by it i stand by the decision
|
[
0
] |
this is a pointless gecos please put real info here or omit it
|
[
0
] |
don t you want to reset changes on this too otherwise it is left dirty
|
[
0
] |
nope see the comment we have to force callers to use crossthreadbind with crossthreadclosure
|
[
0
] |
to match the model this really belongs in the same structure that we have phy init in
|
[
0
] |
you updated sp edid blocks above so i think you should re run the checksum anyway and get rid of sp read edid flag
|
[
0
] |
this notificationtimer null
|
[
0
] |
yes you should check that you are actually not returning anything in the parent id field
|
[
0
] |
we have an escape hatch you can turn a field into a oneof backward compatibly
|
[
0
] |
again a little bit of prose in the commit description would be nice generally anything other than super trivial changes e g the one where you removed the useless variable should have some description in the commit message
|
[
0
] |
this sets dependency on opendaylight debian package so if apt get install opendaylight will be executed then automatically openjdk will be installed this is redundant because in puppet manifest we also require openjdk package to be installed but i left it here in case someone want install this deb file manually
|
[
0
] |
six itervalues then you do not need dummy variable
|
[
0
] |
indentation is fucked here
|
[
1
] |
last part should happen in finally block to restore file contents even if puppet failed you should restore file contents not dump new yaml into it you ll lose all comments and pretty formatting from user pov if safe dump fails for some reason file will end up empty use our atomic file updating approach
|
[
0
] |
OH GOD NO WHY OH FUCK JESUS HOLY SHIT WHY THE FUCK IS FLAVOR TEXT A DNA FEATURE THIS IS CURSED AS FUCK
|
[
1
] |
not a deal breaker but if you happen to upload another patchset please kill this trailing space
|
[
0
] |
this should be pulled into solum
|
[
0
] |
here it should say mytimeline mycurrentsamplerstrategy createdata
|
[
0
] |
bdms bdms
|
[
0
] |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.