showvikdbz/code-reviews · Datasets at Hugging Face

text stringlengths 1 5.2k	labels listlengths 1 1
remove the to visit above and just set with list here	[ 0 ]
can you use a constant for obj not found	[ 0 ]
hi steve yan yes we have to fake self network create network because it will be called in take action	[ 0 ]
you should use mocks fill udp checksum assert called once with	[ 0 ]
why include your whole path here if i wanted to use audit json why do i need to have a users praneshp code entropy why is it needed to specify an absolute path just specify it releative to the program aka audit audit json or something like that if u want others to use this code then need to get away from having things that reference your special home directories and such nobody wants to have that in config files	[ 0 ]
remove the gender shit	[ 1 ]
What a disgrace! We will never be free of these NRE while programmers insist in returning `null`.	[ 1 ]
remove all author tags	[ 0 ]
Did this aswell, seems to work very nicely. Also updated the admin window for pods (holy crap is that a gorgeous ui)	[ 1 ]
how the fuck did i miss these things i minored in english	[ 1 ]
i will nuke this for now	[ 0 ]
i think you should init flip work count to zero using atomic set at the same time you init the work queue	[ 0 ]
nit non nullable ie oobetypes languagedsc	[ 0 ]
b. If someone wants to vote for c), he should be ready to implement it himself. Voting for something "just to have it in the code just in case someone might need it somewhere in the future" is nonsense in software engieering. Please have a look at this article to get an understanding for that: http://www.joelonsoftware.com/items/2006/11/21.html	[ 1 ]
i think the challenge is that if the assert fails for whatever reason the person debugging will have to got to the source code to understand what failed i like your doc strings and would like to see something like that in the assertion method something like asserttrue int self delta get self ping timeout msg it took delta to have connectivity after live migrate expected timeout was timeout format delta self delta get timeout self ping timeout the goal here would be to make any failures clear to end users of the test	[ 0 ]
why would you call this PR like that oh my god	[ 1 ]
this should be marked for translation	[ 0 ]
Who writes column statistics into Glue for Iceberg tables?	[ 1 ]
hi ben pipefail is a bashism you must change from bin sh to bin bash	[ 0 ]
this should be moved to line no need to assign it here as the exception may be thrown below	[ 0 ]
an assignmenttype should never be instantiated so this does not do anything	[ 0 ]
this example is for ovs dpdk can you also add an exmaple for plain ovs case	[ 0 ]
nit stupid comment i would invert the arrow only address if you agree it is clearer and if you need to respin for any reason	[ 0 ]
The code was like that when I got it. Weird, it could be one of VS shenanigans.	[ 1 ]
small nit you load your args in the opposite order here	[ 0 ]
ahh good point maybe we should kill the renderer here we could probably do it with content bad message receivedbadmessage since we have the render process id i am ok to land this as is because i think it is safer to merge though killing the renderer in a follow up might be a good idea	[ 0 ]
no no, just shitty oldcoders	[ 1 ]
json dump f discovered data	[ 0 ]
this class has no point at all and is wrong i already wrote something about it but if it is just going to be about loading the driver just kill it and write a function get coordinator backend member id kwargs that does what init currently does the rest is just useless and inheriting from coordinationdriver if you are not a driver is wrong	[ 0 ]
need to add the secondary index vars otherwise puppet will complain so should add secondary index false secondary index type lucene	[ 0 ]
uh i am assuming these defaults are really just dummy values you should probably remove them	[ 0 ]
sean the test is correct please look at the unit tests for examples of how the condition works	[ 0 ]
i would rather use instead of here to make it look as a bullet list	[ 0 ]
nit remove extra space here	[ 0 ]
errr, nvm this includes vents fuck EDIT: Im not quite sure why vents are hidden and the pipes in atmos arent	[ 1 ]
when we get rid of the compat stuff then we pass in params i to te prep mem buffer which i think will make this cleaner	[ 0 ]
If an enum has an explicit raw type, we should probably ban having the RawRepresentable conformance using a different type. But that's technically source-breaking if anyone does something this wacky.	[ 1 ]
to quote the project's README: "that's disgusting".	[ 1 ]
you can just leave this uncommented it works with no thread safety analysis	[ 0 ]
why do not you return the entire replication driver data is replication volume ref enough	[ 0 ]
not a bug in sqlite just a gap in test case and me being an idiot and testing against wrong code the test case i added discovers this bug correctly	[ 0 ]
This will also pick up diagonals and potentially fuck up with 2 different direction but parallel conveyor lines.	[ 1 ]
a little risky but does work i will look to expose vid pid sid to client and refactor then	[ 0 ]
ah yes commit f d d a f a aa ae a f	[ 0 ]
And on 64-bit this seems totally ridiculous too.	[ 1 ]
Worth noting aswell that all conversion gamemodes just snowball 30 minutes in, having to stay 30 more minutes with no security while cult/clock cult keeps growing is going to be awful.	[ 1 ]
yeah i adjusted it so you wouldn't get a shitton of powers for succing one or two nerds	[ 1 ]
I did that already what the fuck!	[ 1 ]
no cros ec should be removed otherwise this is great	[ 0 ]
@dennisss Sorry for the late reply, I am receiving corrupted messages (I was able to print out the msgid and size, but the content was rubbish). I modified the code to send HIGHRES_IMU in the OSD mode. I am able to receive message less than 30 bytes, but rubbish if message is larger than 30. Hope this clarifies!	[ 1 ]
this will not work as i said in every call of create floating ips cls will be different instance we should make this method static to avoid misleading	[ 0 ]
if these are iscsi only should not they be in the iscsi driver seems like a lot of nops	[ 0 ]
It's only last years version! loads of people must be using it. How can you not be supporting it? That's ridiculous	[ 1 ]
remove white spaces please	[ 0 ]
Indentation is messed up	[ 1 ]
Weird for whatever reson the compiler thinks, that this variable is already declared... It is, but only in enclosed if statements...	[ 1 ]
You will need to clamp it though ad health percentage can be >100% in the case of adminbus or crappy mapping	[ 1 ]
you should rather nest the mocks that way with mock patch as a mock patch as b do	[ 0 ]
sdkconstants android home env	[ 0 ]
Why is GitHub's diff so shit You just moved this down a line, right? That's what it looks like. I'm just confused because the diff is being weird.	[ 1 ]
the following steps are a procedure and should be numbered	[ 0 ]
Under what circumstance would you actually want a backdrop of a popup to close the modal? This is ridiculous and if this is the case, then it should not be the default. IMO this is still a bug.	[ 1 ]
created at updated at deleted at should be nullable	[ 0 ]
5 grid sizes sounds kinda ridiculous.	[ 1 ]
i was suspicious because of the initializer must be a non empty brace enclosed comma separated list of initializers for the members emphasis on non empty but with a small test program seems to initialize int members to while i see garbage values if i do not perform any initialization so i think this seems to work at least when i build with g does the syntax because problems with some compilers	[ 0 ]
oh shit, cut and paste is bad	[ 1 ]
Same with chrome. This is pretty ridiculous.	[ 1 ]
@luigy: I know it sucks that you have to sign the CLA but we cannot pull it in unless you do. I can also pull it on my own name if you don't want to sign it. Please let me know what works best for you :)	[ 1 ]
haaaaaa, shame on my family, damn you're good	[ 1 ]
@rabbbit +1 for taking time to record his fix, I just spent like a week doing all kinds of crazy stuff like upgrading logstash to 1.5.1 and going crazy with the field data cache and breaker sizes and all other kinds of nonsense, which was all good for my education, but I just coulnd't understand why kibana3 was ok and kibana4 was not until reading. So, Thanks!	[ 1 ]
Ah, right, the destructor getting broken data. Damn. :(	[ 1 ]
you are missing a this condition will never be true	[ 0 ]
oh shit i forgot okay.	[ 1 ]
there is already dummy dummy in this file do not add your	[ 0 ]
uhhhhhhh i think you autofucked these by editing the file	[ 1 ]
Uninstalling my tex distribution and re-installing the full mactex distribution made this work for me, so I'm closing. Kinda sucks that you have to install a 5GB latex distribution in order to build the docs, but I guess that's the only (easy) option to build the latex examples.	[ 1 ]
yes i do not need a fk to any other tables	[ 0 ]
please get rid of the trailing space	[ 0 ]
i feel like it is a stupid question but what does it mean	[ 0 ]
I hate everything about this, and may just make an attack-generic function	[ 1 ]
note that this will need to be uploaded to the new cloud s glance service before we approve the change	[ 0 ]
recommend changing stucked stuck	[ 0 ]
trump is the reincarnation of jesus you stupid faggot	[ 1 ]
please get rid of blank line	[ 0 ]
hit these imports are broken apart correctly std rd party local	[ 0 ]
cols perhaps die on next line	[ 0 ]
better use elif for redhat os family	[ 0 ]
nothing about this code is there a better way to possibly extract arguments from a dict everything i found on stack overflow looked uglier than this	[ 0 ]
can we also clarify what exactly we are fixing	[ 0 ]
I didn't do that `Update snapshots` commit? wtf?	[ 1 ]
I have no idea why the hell thats there, let me delete that	[ 1 ]
are you sure that var run supervisor sock will be removed after killing supervisord or this is safe to leave it in place	[ 0 ]
Oh my god, how did i miss this....	[ 1 ]
WTF is up with this "strue" and "sfalse"? Why not just make it "1" : "0" instead?	[ 1 ]
me feels stupid the audio element needs to be added to the dom so that mutation observer callbacks are called you re right about the dcheck i will fix it thanks for the drive by review	[ 0 ]
I know the rest of this is shitcode but please don't add it to it, just use an event sub on another system.	[ 1 ]
oh man i completely misunderstood this issue removed entirely as it is no longer necessary per your comment	[ 0 ]
jesus christ what you're going to change the entire station to unsimulated turfs?	[ 1 ]
ya swift is goofy l	[ 0 ]
It's a goofy quirk in the Ubuntu 14 packaging. See https://github.com/aspnet/Microsoft.Data.Sqlite#ubuntu. I'll add this to the tutorial since Ubuntu 14 is one of the most popular Linux distros.	[ 1 ]

remove the to visit above and just set with list here

[ 0 ]

can you use a constant for obj not found

[ 0 ]

hi steve yan yes we have to fake self network create network because it will be called in take action

[ 0 ]

you should use mocks fill udp checksum assert called once with

[ 0 ]

why include your whole path here if i wanted to use audit json why do i need to have a users praneshp code entropy why is it needed to specify an absolute path just specify it releative to the program aka audit audit json or something like that if u want others to use this code then need to get away from having things that reference your special home directories and such nobody wants to have that in config files

[ 0 ]

remove the gender shit

[ 1 ]

What a disgrace! We will never be free of these NRE while programmers insist in returning `null`.

[ 1 ]

remove all author tags

[ 0 ]

Did this aswell, seems to work very nicely. Also updated the admin window for pods (holy crap is that a gorgeous ui)

[ 1 ]

how the fuck did i miss these things i minored in english

[ 1 ]

i will nuke this for now

[ 0 ]

i think you should init flip work count to zero using atomic set at the same time you init the work queue

[ 0 ]

nit non nullable ie oobetypes languagedsc

[ 0 ]

b. If someone wants to vote for c), he should be ready to implement it himself. Voting for something "just to have it in the code just in case someone might need it somewhere in the future" is nonsense in software engieering. Please have a look at this article to get an understanding for that: http://www.joelonsoftware.com/items/2006/11/21.html

[ 1 ]

i think the challenge is that if the assert fails for whatever reason the person debugging will have to got to the source code to understand what failed i like your doc strings and would like to see something like that in the assertion method something like asserttrue int self delta get self ping timeout msg it took delta to have connectivity after live migrate expected timeout was timeout format delta self delta get timeout self ping timeout the goal here would be to make any failures clear to end users of the test

[ 0 ]

why would you call this PR like that oh my god

[ 1 ]

this should be marked for translation

[ 0 ]

Who writes column statistics into Glue for Iceberg tables?

[ 1 ]

hi ben pipefail is a bashism you must change from bin sh to bin bash

[ 0 ]

this should be moved to line no need to assign it here as the exception may be thrown below

[ 0 ]

an assignmenttype should never be instantiated so this does not do anything

[ 0 ]

this example is for ovs dpdk can you also add an exmaple for plain ovs case

[ 0 ]

nit stupid comment i would invert the arrow only address if you agree it is clearer and if you need to respin for any reason

[ 0 ]

The code was like that when I got it. Weird, it could be one of VS shenanigans.

[ 1 ]

small nit you load your args in the opposite order here

[ 0 ]

ahh good point maybe we should kill the renderer here we could probably do it with content bad message receivedbadmessage since we have the render process id i am ok to land this as is because i think it is safer to merge though killing the renderer in a follow up might be a good idea

[ 0 ]

no no, just shitty oldcoders

[ 1 ]

json dump f discovered data

[ 0 ]

this class has no point at all and is wrong i already wrote something about it but if it is just going to be about loading the driver just kill it and write a function get coordinator backend member id kwargs that does what init currently does the rest is just useless and inheriting from coordinationdriver if you are not a driver is wrong

[ 0 ]

need to add the secondary index vars otherwise puppet will complain so should add secondary index false secondary index type lucene

[ 0 ]

uh i am assuming these defaults are really just dummy values you should probably remove them

[ 0 ]

sean the test is correct please look at the unit tests for examples of how the condition works

[ 0 ]

i would rather use instead of here to make it look as a bullet list

[ 0 ]

nit remove extra space here

[ 0 ]

errr, nvm this includes vents fuck EDIT: Im not quite sure why vents are hidden and the pipes in atmos arent

[ 1 ]

when we get rid of the compat stuff then we pass in params i to te prep mem buffer which i think will make this cleaner

[ 0 ]

If an enum has an explicit raw type, we should probably *ban* having the RawRepresentable conformance using a *different* type. But that's technically source-breaking if anyone does something this wacky.

[ 1 ]

to quote the project's README: "that's disgusting".

[ 1 ]

you can just leave this uncommented it works with no thread safety analysis

[ 0 ]

why do not you return the entire replication driver data is replication volume ref enough

[ 0 ]

not a bug in sqlite just a gap in test case and me being an idiot and testing against wrong code the test case i added discovers this bug correctly

[ 0 ]

This will also pick up diagonals and potentially fuck up with 2 different direction but parallel conveyor lines.

[ 1 ]

a little risky but does work i will look to expose vid pid sid to client and refactor then

[ 0 ]

ah yes commit f d d a f a aa ae a f

[ 0 ]

And on 64-bit this seems totally ridiculous too.

[ 1 ]

Worth noting aswell that all conversion gamemodes just snowball 30 minutes in, having to stay 30 more minutes with no security while cult/clock cult keeps growing is going to be awful.

[ 1 ]

yeah i adjusted it so you wouldn't get a shitton of powers for succing one or two nerds

[ 1 ]

I did that already what the fuck!

[ 1 ]

no cros ec should be removed otherwise this is great

[ 0 ]

@dennisss Sorry for the late reply, I am receiving corrupted messages (I was able to print out the msgid and size, but the content was rubbish). I modified the code to send HIGHRES_IMU in the OSD mode. I am able to receive message less than 30 bytes, but rubbish if message is larger than 30. Hope this clarifies!

[ 1 ]

this will not work as i said in every call of create floating ips cls will be different instance we should make this method static to avoid misleading

[ 0 ]

if these are iscsi only should not they be in the iscsi driver seems like a lot of nops

[ 0 ]

It's only last years version! loads of people must be using it. How can you not be supporting it? That's ridiculous

[ 1 ]

remove white spaces please

[ 0 ]

Indentation is messed up

[ 1 ]

Weird for whatever reson the compiler thinks, that this variable is already declared... It is, but only in enclosed if statements...

[ 1 ]

You will need to clamp it though ad health percentage can be >100% in the case of adminbus or crappy mapping

[ 1 ]

you should rather nest the mocks that way with mock patch as a mock patch as b do

[ 0 ]

sdkconstants android home env

[ 0 ]

Why is GitHub's diff so shit You just moved this down a line, right? That's what it looks like. I'm just confused because the diff is being weird.

[ 1 ]

the following steps are a procedure and should be numbered

[ 0 ]

Under what circumstance would you actually want a backdrop of a popup to close the modal? This is ridiculous and if this is the case, then it should not be the default. IMO this is still a bug.

[ 1 ]

created at updated at deleted at should be nullable

[ 0 ]

5 grid sizes sounds kinda ridiculous.

[ 1 ]

i was suspicious because of the initializer must be a non empty brace enclosed comma separated list of initializers for the members emphasis on non empty but with a small test program seems to initialize int members to while i see garbage values if i do not perform any initialization so i think this seems to work at least when i build with g does the syntax because problems with some compilers

[ 0 ]

oh shit, cut and paste is bad

[ 1 ]

Same with chrome. This is pretty ridiculous.

[ 1 ]

@luigy: I know it sucks that you have to sign the CLA but we cannot pull it in unless you do. I can also pull it on my own name if you don't want to sign it. Please let me know what works best for you :)

[ 1 ]

haaaaaa, shame on my family, damn you're good

[ 1 ]

@rabbbit +1 for taking time to record his fix, I just spent like a week doing all kinds of crazy stuff like upgrading logstash to 1.5.1 and going crazy with the field data cache and breaker sizes and all other kinds of nonsense, which was all good for my education, but I just coulnd't understand why kibana3 was ok and kibana4 was not until reading. So, Thanks!

[ 1 ]

Ah, right, the destructor getting broken data. Damn. :(

[ 1 ]

you are missing a this condition will never be true

[ 0 ]

oh shit i forgot okay.

[ 1 ]

there is already dummy dummy in this file do not add your

[ 0 ]

uhhhhhhh i think you autofucked these by editing the file

[ 1 ]

Uninstalling my tex distribution and re-installing the full mactex distribution made this work for me, so I'm closing. Kinda sucks that you have to install a 5GB latex distribution in order to build the docs, but I guess that's the only (easy) option to build the latex examples.

[ 1 ]

yes i do not need a fk to any other tables

[ 0 ]

please get rid of the trailing space

[ 0 ]

i feel like it is a stupid question but what does it mean

[ 0 ]

I hate everything about this, and may just make an attack-generic function

[ 1 ]

note that this will need to be uploaded to the new cloud s glance service before we approve the change

[ 0 ]

recommend changing stucked stuck

[ 0 ]

trump is the reincarnation of jesus you stupid faggot

[ 1 ]

please get rid of blank line

[ 0 ]

hit these imports are broken apart correctly std rd party local

[ 0 ]

cols perhaps die on next line

[ 0 ]

better use elif for redhat os family

[ 0 ]

nothing about this code is there a better way to possibly extract arguments from a dict everything i found on stack overflow looked uglier than this

[ 0 ]

can we also clarify what exactly we are fixing

[ 0 ]

I didn't do that `Update snapshots` commit? wtf?

[ 1 ]

I have no idea why the hell thats there, let me delete that

[ 1 ]

are you sure that var run supervisor sock will be removed after killing supervisord or this is safe to leave it in place

[ 0 ]

Oh my god, how did i miss this....

[ 1 ]

WTF is up with this "strue" and "sfalse"? Why not just make it "1" : "0" instead?

[ 1 ]

me feels stupid the audio element needs to be added to the dom so that mutation observer callbacks are called you re right about the dcheck i will fix it thanks for the drive by review

[ 0 ]

I know the rest of this is shitcode but please don't add it to it, just use an event sub on another system.

[ 1 ]

oh man i completely misunderstood this issue removed entirely as it is no longer necessary per your comment

[ 0 ]

jesus christ what you're going to change the entire station to unsimulated turfs?

[ 1 ]

ya swift is goofy l

[ 0 ]

It's a goofy quirk in the Ubuntu 14 packaging. See https://github.com/aspnet/Microsoft.Data.Sqlite#ubuntu. I'll add this to the tutorial since Ubuntu 14 is one of the most popular Linux distros.

[ 1 ]