showvikdbz/code-reviews · Datasets at Hugging Face

text stringlengths 1 5.2k	labels listlengths 1 1
Having fundamental issues such as text being cutoff in every single `<select>` is worth generating more noise about because its ridiculous that this hasn't been fixed yet.	[ 1 ]
Oh, I'm a doofus I figured it would just delete, let me fix that and turn it into an ice floor	[ 1 ]
default pasword needs to be removed	[ 0 ]
Related issues: #40772 #50155 God those custom scanner gates really suck.	[ 1 ]
another bogon dead	[ 0 ]
We have several bugs on file for various reasons why setup is ridiculously slow if you don't have a good connection, so I think that's covered.	[ 1 ]
i think it would be more logical not to store the results after runner abort because the user expects that the execution will stop after the first sla fail but okay i have removed this	[ 0 ]
Looks great, just a few nits. @jbhoosreddy Yeah, the previous mochitests were simply awful. Pulling everything out of the DOM and only checking it when needed allows us to write way simpler tests. The old tests were also written at a time where promises weren't even used.	[ 1 ]
dumb instinct tells me this should inherit from forbidden can you help me understand why that is not the case	[ 0 ]
Is this brainfuck :trollface: ?	[ 1 ]
change dumb member to dummy member	[ 0 ]
extra indentation should be removed here	[ 0 ]
you re killing me here	[ 0 ]
To clarify, I dislike this change and think that Space Asshole is better than genericising it	[ 1 ]
but you still have the data used as null terminated string below stringpiece data generally does not guarantee the terminator keep this as is we will deal with it later	[ 0 ]
add metadata only to docstring params	[ 0 ]
style nit local vars shoudn t be in all caps start esp num esp sectors	[ 0 ]
argh ok this was dumb will clean up	[ 0 ]
like really, what the fuck was this about?	[ 1 ]
port id returned obj floatingip get port id or original obj get port id if port id is none return	[ 0 ]
you are mistaken you mixed generate physnet vlan ranges output with generate physnet mtus output	[ 0 ]
i will remove them	[ 0 ]
missing delete net dev false run as root false	[ 0 ]
Damn yeah. you are right! how could I not see it.	[ 1 ]
inplace updates suck in rust. the borrow checker can't handle it.	[ 1 ]
oh SHIT ye. i copied the whole code from the detective one , and it seems i forgot about changing that	[ 1 ]
Grammar sucks and it sounds wrong just change it back Better language rules are first made by breaking the existing ones	[ 1 ]
no it seems no good to me if def heat self action flags params admin true fail ok is being used and as you say in previous comment then return self cmd with auth heat action flags params admin fail ok merge stderr true will no more remaining testcase dependent and for all tests it will set to true in future if you want to put some test cases with merge error value as false then it cannot be done	[ 0 ]
All the "coming soon" is also nonsense. None of that was ever on any roadmap ever :)	[ 1 ]
Why to port to C++? Would Lua be that sluggish?	[ 1 ]
probably disabling irq should be done after avp enters lp this would avoid races if there are any	[ 0 ]
the above lines are useless	[ 0 ]
i need a way to pass the compiler to the script let me know if this is too ugly	[ 0 ]
obviously you will want to erify that a call to objects computenode create inventory is called when the version is	[ 0 ]
please remove the white spaces	[ 0 ]
WTF? How did this work in testing???	[ 1 ]
Loving it, alas, no ideas on the personality name. unlikely to get addicted is too clumsy.	[ 1 ]
why do we keep propagating the usage of const char instead of using const std string this is especially weird since you do have std string which you have to call c str on to call these methods	[ 0 ]
as we should not be touching r on returning false anyway ditto below	[ 0 ]
This is absolutely awful, when is it getting merged? Also, do they have a limit on how many matriachs we can have like we do spider queens?	[ 1 ]
during first run when the sdk folder does not exist yet however in here we care at least as much about remote as local androidsdkdata was just acting as a dumb container for the remote sdk with this being the only client so i just moved it in here so we can do the remote stuff whether or not a local sdk exists	[ 0 ]
not needed afaict mmultiple is set on push back so mmultiple pids isempty	[ 0 ]
yes and no this is not supposed to be a generic session constructor it is supposed to be a bridge between the old parameters that were given to a client and the new ones that are given to the session i was trying to make it really obvious that this is an internal compatability function and not something people see as a cheap way to construct session i guess it does not matter because it is a util anyway it handles being given session arguments and it may be used in the transition of other clients	[ 0 ]
You should wrap this in if (HW_DMA12_CHCR & 0x01000000) if the hardware cancels the DMA and it fires an interrupt still, it'll get pissy.	[ 1 ]
this should not be needed get project raises projectnotfound for an invalid project id	[ 0 ]
Can we please stop having entire procs full of garbage var names? Just type a few extra characters so people reading don't have to keep double checking what things are, damn	[ 1 ]
What the fuck git. If you click view whole file. Its there.	[ 1 ]
whos the bastard that put in this #include manually so it would poison my diff	[ 1 ]
this include is a left over i will remove it same for string h and unistd h below	[ 0 ]
int index vector vector	[ 0 ]
resourcefoldermanager exploded aar	[ 0 ]
will do next time. right now bed time. no rhyme intended. I'm fucking wasted.	[ 1 ]
we execute only provisioning here kvm will be started by next step	[ 0 ]
Thanks for the feedback and that makes sense. I am still slightly confused though, I can cluster my points just fine in 0.15 but run out of memory in 0.16. Edit: I can see now why my second code example is 'rubbish'.	[ 1 ]
again i am asking why ambari needs them and if it really needs them why the ambari rpms are not requiring it otherwise this patch seems just a workaround	[ 0 ]
adapter host uuid instance and connection info should be removed	[ 0 ]
yup stupid mistake	[ 0 ]
those mocks were the reason the regression happened in the first place we needed to test that they are actually doing the right thing which we now do by looking at the mock array	[ 0 ]
ansible should be ansible	[ 0 ]
can you delete the whitespace here sorry to nitpick silly things but i did not notice it in the prior cl	[ 0 ]
ugh, this sucks :( necessarily evil I suppose.	[ 1 ]
renamed it to android app list model and replaced arc with android in all files in this cl as for picker i removed it in most places as well but still kept picker in some places where i felt it is important to note that it is a list of picker apps not general android apps	[ 0 ]
Damn, good call. Thanks for catching that.	[ 1 ]
i agree with you this code is duplicated and should be removed	[ 0 ]
bummer except for these lines this cl is entirely deletions you had to ruin it with a modification	[ 0 ]
floating ips needs to be bumped as well	[ 0 ]
This changelog has NO fucking reason to be this long	[ 1 ]
this dummy test adds seconds on each run in gates we do not have so much time in gates put here times	[ 0 ]
i was going to say this is badly in need of a comment there is a comment on the original in rbd utils could you please move it over too	[ 0 ]
That was an awful merge, I hope this is reverted posthaste.	[ 1 ]
maybe a silly question i am not sure what is the difference between eliminating the public ip address completely and avoiding a dedicating ip to the router	[ 0 ]
Wow, that's pretty wacky. Same in all backends I guess?	[ 1 ]
why are you preserving the noop jobs here they should be removed	[ 0 ]
Brain being a fuck here, I think I tried keeping it true to source because I wasn't sure of the use case for disabling these. Sounds a bit more logical that way so I'll fix it	[ 1 ]
could you remove a white space	[ 0 ]
If this code is going to screw up multiplayer, then the previous one was also screwing it up, so the quality of code does not degrade.	[ 1 ]
this noqa is redundant	[ 0 ]
git blame nkinder	[ 0 ]
i updated it to grab non aborted hqe s and if there are none use the created on time like before	[ 0 ]
Hmmm, if it is not too ugly, yeah. I don't really care about any/all, the reason for the big step is just that it is ridiculously fast in the first place, but small reduction speed up is likely interesting.	[ 1 ]
put it back, `fuck_you_dir` is a fan favourite var. that _I_ made!	[ 1 ]
preparation for a day when we do not abort but die gracefully if you want me to remove it	[ 0 ]
editedstyleitem item value instanceof editedstyleitem editedstyleitem value null	[ 0 ]
This comment is stupid, but I guess not your fault. I will live with leaving it alone, and accept this montonically-better patch as-is.	[ 1 ]
Ah, damn. I was deceived by 'SpriteComponents' but it is a Bundle. I always wondered why there was a trailing 's'. Now I know. Should be fine now. (hopefully)	[ 1 ]
we re still using the native awk on os x which is bsd and does not support include iirc and i am not sure but i believe gnu awk does not build on os x for some stupid reason i never wanted to debug if you can fix that and ensure that each darwin ndk release has a valid prebuilt darwin x bin awk program that could work and save some typing	[ 0 ]
But if you are clumsy enough, would you be able to actually craft anything to learn from? If using up too much materials is the problem, getting a popup informing the player of that or even graying the recipe out in the menu is a possibility.	[ 1 ]
so was that bogus in the presence of int immediates	[ 0 ]
where the hell did this come from...	[ 1 ]
Ah please don't apologize for it!!! It's a ridiculously hard problem, and your code is not the reason for it. Silly stupid Vertx for creating threads that never die	[ 1 ]
very tiny nit there are two spaces before if	[ 0 ]
> But... those functions are declared, in apps.h! Yeah... Except that declaration should be `int fileno_stdin(void);`. Yeah, it's essentially ridiculous...	[ 1 ]
fuck u non maintainer LAMO	[ 1 ]
If I made five PRs, you'd complain that this was too many PRs and I should make one. This is ridiculous.	[ 1 ]
don t need the v fake here	[ 0 ]
Faggot catcher was removed with commit https://github.com/posttwo/fjmod-extension/commit/b6fde34625d077f5a505cf784d3743fe7cf5cff7 but the button to enable it stayed	[ 1 ]
i believe abandon is not required here so needs to be removed	[ 0 ]
hmm you undef tegra device settings here do you think tegra device settings should not be tegra common	[ 0 ]
the indentation here is dodgy it may be worthwhile adding a comment that this is only applicable to ipv can you please add ina test for ipv showing that it works when there are zeros	[ 0 ]
this condition is not sufficient a cb pdu over umts could be anything from bytes to as discussed earlier we are missing a reliable way of determining the rat at this stage furthermore the ril spec says the data should be fixed size bytes hence suggesting it should be in gsm format	[ 0 ]

Having fundamental issues such as text being cutoff in every single `<select>` is worth generating more noise about because its ridiculous that this hasn't been fixed yet.

[ 1 ]

Oh, I'm a doofus I figured it would just delete, let me fix that and turn it into an ice floor

[ 1 ]

default pasword needs to be removed

[ 0 ]

Related issues: #40772 #50155 God those custom scanner gates really suck.

[ 1 ]

another bogon dead

[ 0 ]

We have several bugs on file for various reasons why setup is ridiculously slow if you don't have a good connection, so I think that's covered.

[ 1 ]

i think it would be more logical not to store the results after runner abort because the user expects that the execution will stop after the first sla fail but okay i have removed this

[ 0 ]

Looks great, just a few nits. @jbhoosreddy Yeah, the previous mochitests were simply awful. Pulling everything out of the DOM and only checking it when needed allows us to write way simpler tests. The old tests were also written at a time where promises weren't even used.

[ 1 ]

dumb instinct tells me this should inherit from forbidden can you help me understand why that is not the case

[ 0 ]

Is this brainfuck :trollface: ?

[ 1 ]

change dumb member to dummy member

[ 0 ]

extra indentation should be removed here

[ 0 ]

you re killing me here

[ 0 ]

To clarify, I dislike this change and think that Space Asshole is better than genericising it

[ 1 ]

but you still have the data used as null terminated string below stringpiece data generally does not guarantee the terminator keep this as is we will deal with it later

[ 0 ]

add metadata only to docstring params

[ 0 ]

style nit local vars shoudn t be in all caps start esp num esp sectors

[ 0 ]

argh ok this was dumb will clean up

[ 0 ]

like really, what the fuck was this about?

[ 1 ]

port id returned obj floatingip get port id or original obj get port id if port id is none return

[ 0 ]

you are mistaken you mixed generate physnet vlan ranges output with generate physnet mtus output

[ 0 ]

i will remove them

[ 0 ]

missing delete net dev false run as root false

[ 0 ]

Damn yeah. you are right! how could I not see it.

[ 1 ]

inplace updates suck in rust. the borrow checker can't handle it.

[ 1 ]

oh SHIT ye. i copied the whole code from the detective one , and it seems i forgot about changing that

[ 1 ]

Grammar sucks and it sounds wrong just change it back Better language rules are first made by breaking the existing ones

[ 1 ]

no it seems no good to me if def heat self action flags params admin true fail ok is being used and as you say in previous comment then return self cmd with auth heat action flags params admin fail ok merge stderr true will no more remaining testcase dependent and for all tests it will set to true in future if you want to put some test cases with merge error value as false then it cannot be done

[ 0 ]

All the "coming soon" is also nonsense. None of that was ever on any roadmap ever :)

[ 1 ]

Why to port to C++? Would Lua be that sluggish?

[ 1 ]

probably disabling irq should be done after avp enters lp this would avoid races if there are any

[ 0 ]

the above lines are useless

[ 0 ]

i need a way to pass the compiler to the script let me know if this is too ugly

[ 0 ]

obviously you will want to erify that a call to objects computenode create inventory is called when the version is

[ 0 ]

please remove the white spaces

[ 0 ]

WTF? How did this work in testing???

[ 1 ]

Loving it, alas, no ideas on the personality name. unlikely to get addicted is too clumsy.

[ 1 ]

why do we keep propagating the usage of const char instead of using const std string this is especially weird since you do have std string which you have to call c str on to call these methods

[ 0 ]

as we should not be touching r on returning false anyway ditto below

[ 0 ]

This is absolutely awful, when is it getting merged? Also, do they have a limit on how many matriachs we can have like we do spider queens?

[ 1 ]

during first run when the sdk folder does not exist yet however in here we care at least as much about remote as local androidsdkdata was just acting as a dumb container for the remote sdk with this being the only client so i just moved it in here so we can do the remote stuff whether or not a local sdk exists

[ 0 ]

not needed afaict mmultiple is set on push back so mmultiple pids isempty

[ 0 ]

yes and no this is not supposed to be a generic session constructor it is supposed to be a bridge between the old parameters that were given to a client and the new ones that are given to the session i was trying to make it really obvious that this is an internal compatability function and not something people see as a cheap way to construct session i guess it does not matter because it is a util anyway it handles being given session arguments and it may be used in the transition of other clients

[ 0 ]

You should wrap this in if (HW_DMA12_CHCR & 0x01000000) if the hardware cancels the DMA and it fires an interrupt still, it'll get pissy.

[ 1 ]

this should not be needed get project raises projectnotfound for an invalid project id

[ 0 ]

Can we please stop having entire procs full of garbage var names? Just type a few extra characters so people reading don't have to keep double checking what things are, damn

[ 1 ]

What the fuck git. If you click view whole file. Its there.

[ 1 ]

whos the bastard that put in this #include manually so it would poison my diff

[ 1 ]

this include is a left over i will remove it same for string h and unistd h below

[ 0 ]

int index vector vector

[ 0 ]

resourcefoldermanager exploded aar

[ 0 ]

will do next time. right now bed time. no rhyme intended. I'm fucking wasted.

[ 1 ]

we execute only provisioning here kvm will be started by next step

[ 0 ]

Thanks for the feedback and that makes sense. I am still slightly confused though, I can cluster my points just fine in 0.15 but run out of memory in 0.16. Edit: I can see now why my second code example is 'rubbish'.

[ 1 ]

again i am asking why ambari needs them and if it really needs them why the ambari rpms are not requiring it otherwise this patch seems just a workaround

[ 0 ]

adapter host uuid instance and connection info should be removed

[ 0 ]

yup stupid mistake

[ 0 ]

those mocks were the reason the regression happened in the first place we needed to test that they are actually doing the right thing which we now do by looking at the mock array

[ 0 ]

ansible should be ansible

[ 0 ]

can you delete the whitespace here sorry to nitpick silly things but i did not notice it in the prior cl

[ 0 ]

ugh, this sucks :( necessarily evil I suppose.

[ 1 ]

renamed it to android app list model and replaced arc with android in all files in this cl as for picker i removed it in most places as well but still kept picker in some places where i felt it is important to note that it is a list of picker apps not general android apps

[ 0 ]

Damn, good call. Thanks for catching that.

[ 1 ]

i agree with you this code is duplicated and should be removed

[ 0 ]

bummer except for these lines this cl is entirely deletions you had to ruin it with a modification

[ 0 ]

floating ips needs to be bumped as well

[ 0 ]

This changelog has NO fucking reason to be this long

[ 1 ]

this dummy test adds seconds on each run in gates we do not have so much time in gates put here times

[ 0 ]

i was going to say this is badly in need of a comment there is a comment on the original in rbd utils could you please move it over too

[ 0 ]

That was an awful merge, I hope this is reverted posthaste.

[ 1 ]

maybe a silly question i am not sure what is the difference between eliminating the public ip address completely and avoiding a dedicating ip to the router

[ 0 ]

Wow, that's pretty wacky. Same in all backends I guess?

[ 1 ]

why are you preserving the noop jobs here they should be removed

[ 0 ]

Brain being a fuck here, I think I tried keeping it true to source because I wasn't sure of the use case for disabling these. Sounds a bit more logical that way so I'll fix it

[ 1 ]

could you remove a white space

[ 0 ]

If this code is going to screw up multiplayer, then the previous one was also screwing it up, so the quality of code does not degrade.

[ 1 ]

this noqa is redundant

[ 0 ]

git blame nkinder

[ 0 ]

i updated it to grab non aborted hqe s and if there are none use the created on time like before

[ 0 ]

Hmmm, if it is not too ugly, yeah. I don't really care about any/all, the reason for the big step is just that it is ridiculously fast in the first place, but small reduction speed up is likely interesting.

[ 1 ]

put it back, `fuck_you_dir` is a fan favourite var. that _I_ made!

[ 1 ]

preparation for a day when we do not abort but die gracefully if you want me to remove it

[ 0 ]

editedstyleitem item value instanceof editedstyleitem editedstyleitem value null

[ 0 ]

This comment is stupid, but I guess not your fault. I will live with leaving it alone, and accept this montonically-better patch as-is.

[ 1 ]

Ah, damn. I was deceived by 'SpriteComponents' but it is a Bundle. I always wondered why there was a trailing 's'. Now I know. Should be fine now. (hopefully)

[ 1 ]

we re still using the native awk on os x which is bsd and does not support include iirc and i am not sure but i believe gnu awk does not build on os x for some stupid reason i never wanted to debug if you can fix that and ensure that each darwin ndk release has a valid prebuilt darwin x bin awk program that could work and save some typing

[ 0 ]

But if you are clumsy enough, would you be able to actually craft anything to learn from? If using up too much materials is the problem, getting a popup informing the player of that or even graying the recipe out in the menu is a possibility.

[ 1 ]

so was that bogus in the presence of int immediates

[ 0 ]

where the hell did this come from...

[ 1 ]

Ah please don't apologize for it!!! It's a ridiculously hard problem, and your code is not the reason for it. Silly stupid Vertx for creating threads that never die

[ 1 ]

very tiny nit there are two spaces before if

[ 0 ]

> But... those functions are declared, in apps.h! Yeah... Except that declaration should be `int fileno_stdin(void);`. Yeah, it's essentially ridiculous...

[ 1 ]

fuck u non maintainer LAMO

[ 1 ]

If I made five PRs, you'd complain that this was too many PRs and I should make one. This is ridiculous.

[ 1 ]

don t need the v fake here

[ 0 ]

Faggot catcher was removed with commit https://github.com/posttwo/fjmod-extension/commit/b6fde34625d077f5a505cf784d3743fe7cf5cff7 but the button to enable it stayed

[ 1 ]

i believe abandon is not required here so needs to be removed

[ 0 ]

hmm you undef tegra device settings here do you think tegra device settings should not be tegra common

[ 0 ]

the indentation here is dodgy it may be worthwhile adding a comment that this is only applicable to ipv can you please add ina test for ipv showing that it works when there are zeros

[ 0 ]

this condition is not sufficient a cb pdu over umts could be anything from bytes to as discussed earlier we are missing a reliable way of determining the rat at this stage furthermore the ril spec says the data should be fixed size bytes hence suggesting it should be in gsm format

[ 0 ]