showvikdbz/code-reviews · Datasets at Hugging Face

text stringlengths 1 5.2k	labels listlengths 1 1
Wait, darn, maybe this should've been dest not src. Doh. -[Unknown]	[ 1 ]
Really tried to sneak this shit in huh	[ 1 ]
weird, rider wasn't showing it.	[ 1 ]
this should be created and targeted for mitaka i took care of it	[ 0 ]
useless i think	[ 0 ]
well fuck that is supposed to be a max	[ 1 ]
ratelimitexceeded should be removed here	[ 0 ]
drop the die eapi does not need it w emake	[ 0 ]
i believe this should be inserted at the end or it will break setup base sh	[ 0 ]
Yes, the user wants it if they need it. The issue is we put them in that situation and the situation is seemingly ridiculous on its face. That's my concern, that we have no handle on this.	[ 1 ]
Temperature gun too because it's the fucking temperature gun, lmao	[ 1 ]
there are much better ways to recover from a frost sting. Poisoning yourself with a fuckload of plasma is not a good one. However, a compromisable solution is to make iron a catalyst.	[ 1 ]
just a nit pick and sorry if anybody thinks these are stupid but i think commit messages are critical for long term code maintainability you do not need to say this commit moves but just say move the example	[ 0 ]
this original code is valid and imo more readable than your list comprehension	[ 0 ]
useless comment at all	[ 0 ]
God. Damn. It. I literally change 1 number slightly before commiting and don't bother to test it because its a single var, and I fuck it up.	[ 1 ]
there is this `app.client` object that has some API for interaction with "what is on screen". But it felt rather clumsy (compared to cypress). Need to dive into it. I hope I can manage it after this fridays freeze.	[ 1 ]
use self msg	[ 0 ]
why do you need utils h in the oat file h i think it should be in oat file inl h	[ 0 ]
oh shit my bad, I'll fix it when i get back to my PC. Thanks.	[ 1 ]
ryan please set yourself as author it s your patch will figure out what stupidity i am doing sorry for this	[ 0 ]
the rdo package name for pymysql is python pymysql but there is also a metapackage python pymysql pymysql does not exist	[ 0 ]
yest they are pure virtuals	[ 0 ]
Hint: when you have to explain the crappy and complex control flow it's a good time to rewrite the proc. Might as well get it done if you're there already.	[ 1 ]
tuskar depends on heat on the same machine to install run	[ 0 ]
this is silly just do target x program prefix target	[ 0 ]
it should be down revision ace db	[ 0 ]
Damn that's a pretty ridiculous mistake X) EDIT: But I don't have that locally so it's pretty weird	[ 1 ]
I know it already exists but man s weird	[ 1 ]
can this be replaced by the below code will pcm htimestamp return the pipe errors when suspended	[ 0 ]
i think thats causing the failures here should just be cfg	[ 0 ]
probably an ignorant question but why is the metric being decremented by	[ 0 ]
Uggh... that sucks...	[ 1 ]
They all are vector images, but Godots importer sucks. I think, I am gonna push the other icons as svg as well. But we do need the PNGs for now.	[ 1 ]
so for nova baremetal and ironic config drive does not work does devstack cater for that or should we duplicate the logic perhaps in wrap sh	[ 0 ]
i do not know we use columns for all bionic code i believe the red dotted line is set to columns so you know when we violate it	[ 0 ]
copy start sh check sh just to be consistent with rest dockerfiles	[ 0 ]
you can set openstack image registry auth insecure true then let insecure node openstack image registry auth insecure	[ 0 ]
Apologies for the ridiculous amount of delay in updating this. I have hammered out some work on this here: https://github.com/saltstack/salt/pull/43583. Would love to hear your thoughts on the same.	[ 1 ]
Heh, this is quite a ridiculous amount of define magic, but it seems that's what it still takes to go cross platform in 2013.	[ 1 ]
Should DestroyTempBackBuffers not be called here? Or is it already safely done in Main at appropriate times, and would just fuck up if it was called here?	[ 1 ]
you should kill all pids at once rather than in for loop	[ 0 ]
todo implement qcow base	[ 0 ]
I think your indentation is screwed up here... Also wouldn't it be shorter to use array notation?	[ 1 ]
mark sorry but i am not completely understanding why the fact that testing with an instance object does not matter here to just dumb this down for my own sake are you saying that once i change conductor manager compute stop to handle instance as a dict instead of object this test becomes useful	[ 0 ]
No disrespect to IRL Muf, who I'm sure is a lovely cat, but I think we've all grown attached to the goofy `CatDog` name at this point and I think we should keep it. :)	[ 1 ]
this is useless anymore i thought	[ 0 ]
mostly nit but would be good to have a type check here otherwise someone can put ironic ramdisk type blah and it is going to work e g elif ironic ramdisk type dib then build ipa dib else die ramdisk type ironic ramdisk type not supported	[ 0 ]
can you use mock with side effect to call your fake methods	[ 0 ]
Not actually a change. hitsound is just glasshit. But I moved it to a var so the paper frames could have different sounds without having to copypasta.	[ 1 ]
this should be fake consistency group id	[ 0 ]
lock dir should be removed manually after the test	[ 0 ]
that comment is completely useless this whole file is about xls xlsx export	[ 0 ]
useless	[ 0 ]
per discussion with nikhil we need to move parent backup loading and validation before loading instance object to allow fast failing if verified data was corrupted	[ 0 ]
ok i will bite dumb question why do we want to mock these what calls them how are they being used	[ 0 ]
pet peeve of mine, cyber implant is terrible fucking name given that these are organs and not obj/item/weapon/implant.	[ 1 ]
i apologise if i am being blind stupid but what email thread	[ 0 ]
Alternatively, we can remove RTTI from it, since it only to print unreadable crap in logs for debugging purposes long forgotten.	[ 1 ]
same as above these docs are useless	[ 0 ]
Why does your code end in the middle of a function. Your diff is EXTREMELY screwed up, try again.	[ 1 ]
Or a better solution will be to multithread it a bit. Half an hour to get result is damn slow.	[ 1 ]
Notable stupid shit found in blob_act() Floors shouldn't have a blob act, because it'd only be called when attacking something dense above them.	[ 1 ]
nit use std unordered set if you do not care about ordering it will use less memory and be faster with simple types like eglnativewindowtype	[ 0 ]
Damn this is magical, this is so nice	[ 1 ]
Eh yeah I screwed up the branching. This is an extension of #1711.	[ 1 ]
i kinda agree with jakub that this check is worthless but i am ok ish to proceed landing it	[ 0 ]
Good shit lexorion.	[ 1 ]
look into ratelimiter when the th packet in the expression ctime self deque self time unit will always be true so the funtion will return false forever that is not what we want	[ 0 ]
commit message body should be wrapped at characters rather than	[ 0 ]
can you copy the original commit message from the first gerrit in as the commit message here when we submit this only this message will go into the git repository so should be self contained	[ 0 ]
also what the hell does that mean "reset starts"	[ 1 ]
keystone admin port	[ 0 ]
Its a black lump. Do you seriously want HD rocks?	[ 1 ]
import both on one line from neutron openstack common gettextutils import le li	[ 0 ]
useless trailing rand name already adds a	[ 0 ]
actually should get rid of format map py and just use trusttokenformatter token format rather than format map trust token prefix	[ 0 ]
> Not supporting this is frankly ridiculous. agree.	[ 1 ]
we need to eliminate the dependency of common db mixin	[ 0 ]
Did this actually happen when testing? This should only really occur when somebody fucks up.	[ 1 ]
if you look at the original cl that introduced the ssh host metric they want to track down dead hosts to kill it makes sense to leave around the ssh host creation metric using a dummy host so they know this attenuator host exists	[ 0 ]
are these dummy values for testing right now i mean certainly should not be hard coding us as the country say so in a comment somewhere	[ 0 ]
explicit tag is not required also why this cannot be written as externalrouterid null	[ 0 ]
you re absolutly right just my understanding of the whole idea of migration in releases was wrong now adressing the issue	[ 0 ]
you should probably use assertgreater here instead of an asserttrue	[ 0 ]
sweet great tutorial	[ 0 ]
@dotqurter If you don't finish this I might get around to it eventually @BenCat07 what's the nolerp fix do exactly? current nolerp sucks	[ 1 ]
I know Bauds already mentioned it but HOLY FUCK THAT'S TOO MUCH	[ 1 ]
i was thinking that if we have the show function but return the after mapping value say that is written in user space but we show the true register value it is kind of confusing so i just get rid of the show function maybe we do a reverse mapping to show the interval value if you think it is useful	[ 0 ]
test this outside the loop	[ 0 ]
Copy paste error. Damn	[ 1 ]
this was so fucking painful holy mother of god I AM A BELIEVER NOW	[ 1 ]
this is highly offensive to non christians i demand you remove it	[ 0 ]
i am not crazy about this error being here because this is parse root device hints not eg find device but i guess it can be cleaned up later	[ 0 ]
> How does samba depend on python3-markdown? that's ridiculous. No idea why samba packages drag in `python3-markdown` Curious indeed (-:	[ 1 ]
What the shit are you even talking about here	[ 1 ]
you need gpio h too	[ 0 ]
From a practical standpoint, the java.net.URL class dates from the earliest versions of Java and is rubbish, so I would say that in general java.net.URI is preferred regardless of whether the thing in question is really a URI or a URL. But in that case I think the method name and documentation should also say URI. Otherwise it will be confusing.	[ 1 ]
maybe add a comment here reminding the reader what the empty ssid is about	[ 0 ]
remove the white space here	[ 0 ]

Wait, darn, maybe this should've been dest not src. Doh. -[Unknown]

[ 1 ]

Really tried to sneak this shit in huh

[ 1 ]

weird, rider wasn't showing it.

[ 1 ]

this should be created and targeted for mitaka i took care of it

[ 0 ]

useless i think

[ 0 ]

well fuck that is supposed to be a max

[ 1 ]

ratelimitexceeded should be removed here

[ 0 ]

drop the die eapi does not need it w emake

[ 0 ]

i believe this should be inserted at the end or it will break setup base sh

[ 0 ]

Yes, the user wants it if they need it. The issue is we put them in that situation and the situation is seemingly ridiculous on its face. That's my concern, that we have no handle on this.

[ 1 ]

Temperature gun too because it's the fucking temperature gun, lmao

[ 1 ]

there are much better ways to recover from a frost sting. Poisoning yourself with a fuckload of plasma is not a good one. However, a compromisable solution is to make iron a catalyst.

[ 1 ]

just a nit pick and sorry if anybody thinks these are stupid but i think commit messages are critical for long term code maintainability you do not need to say this commit moves but just say move the example

[ 0 ]

this original code is valid and imo more readable than your list comprehension

[ 0 ]

useless comment at all

[ 0 ]

God. Damn. It. I literally change 1 number slightly before commiting and don't bother to test it because its a single var, and I fuck it up.

[ 1 ]

there is this `app.client` object that has some API for interaction with "what is on screen". But it felt rather clumsy (compared to cypress). Need to dive into it. I hope I can manage it after this fridays freeze.

[ 1 ]

use self msg

[ 0 ]

why do you need utils h in the oat file h i think it should be in oat file inl h

[ 0 ]

oh shit my bad, I'll fix it when i get back to my PC. Thanks.

[ 1 ]

ryan please set yourself as author it s your patch will figure out what stupidity i am doing sorry for this

[ 0 ]

the rdo package name for pymysql is python pymysql but there is also a metapackage python pymysql pymysql does not exist

[ 0 ]

yest they are pure virtuals

[ 0 ]

Hint: when you have to explain the crappy and complex control flow it's a good time to rewrite the proc. Might as well get it done if you're there already.

[ 1 ]

tuskar depends on heat on the same machine to install run

[ 0 ]

this is silly just do target x program prefix target

[ 0 ]

it should be down revision ace db

[ 0 ]

Damn that's a pretty ridiculous mistake X) EDIT: But I don't have that locally so it's pretty weird

[ 1 ]

I know it already exists but man s weird

[ 1 ]

can this be replaced by the below code will pcm htimestamp return the pipe errors when suspended

[ 0 ]

i think thats causing the failures here should just be cfg

[ 0 ]

probably an ignorant question but why is the metric being decremented by

[ 0 ]

Uggh... that sucks...

[ 1 ]

They all are vector images, but Godots importer sucks. I think, I am gonna push the other icons as svg as well. But we do need the PNGs for now.

[ 1 ]

so for nova baremetal and ironic config drive does not work does devstack cater for that or should we duplicate the logic perhaps in wrap sh

[ 0 ]

i do not know we use columns for all bionic code i believe the red dotted line is set to columns so you know when we violate it

[ 0 ]

copy start sh check sh just to be consistent with rest dockerfiles

[ 0 ]

you can set openstack image registry auth insecure true then let insecure node openstack image registry auth insecure

[ 0 ]

Apologies for the ridiculous amount of delay in updating this. I have hammered out some work on this here: https://github.com/saltstack/salt/pull/43583. Would love to hear your thoughts on the same.

[ 1 ]

Heh, this is quite a ridiculous amount of define magic, but it seems that's what it still takes to go cross platform in 2013.

[ 1 ]

Should DestroyTempBackBuffers not be called here? Or is it already safely done in Main at appropriate times, and would just fuck up if it was called here?

[ 1 ]

you should kill all pids at once rather than in for loop

[ 0 ]

todo implement qcow base

[ 0 ]

I think your indentation is screwed up here... Also wouldn't it be shorter to use array notation?

[ 1 ]

mark sorry but i am not completely understanding why the fact that testing with an instance object does not matter here to just dumb this down for my own sake are you saying that once i change conductor manager compute stop to handle instance as a dict instead of object this test becomes useful

[ 0 ]

No disrespect to IRL Muf, who I'm sure is a lovely cat, but I think we've all grown attached to the goofy `CatDog` name at this point and I think we should keep it. :)

[ 1 ]

this is useless anymore i thought

[ 0 ]

mostly nit but would be good to have a type check here otherwise someone can put ironic ramdisk type blah and it is going to work e g elif ironic ramdisk type dib then build ipa dib else die ramdisk type ironic ramdisk type not supported

[ 0 ]

can you use mock with side effect to call your fake methods

[ 0 ]

Not actually a change. hitsound is just glasshit. But I moved it to a var so the paper frames could have different sounds without having to copypasta.

[ 1 ]

this should be fake consistency group id

[ 0 ]

lock dir should be removed manually after the test

[ 0 ]

that comment is completely useless this whole file is about xls xlsx export

[ 0 ]

useless

[ 0 ]

per discussion with nikhil we need to move parent backup loading and validation before loading instance object to allow fast failing if verified data was corrupted

[ 0 ]

ok i will bite dumb question why do we want to mock these what calls them how are they being used

[ 0 ]

pet peeve of mine, cyber implant is terrible fucking name given that these are organs and not obj/item/weapon/implant.

[ 1 ]

i apologise if i am being blind stupid but what email thread

[ 0 ]

Alternatively, we can remove RTTI from it, since it only to print unreadable crap in logs for debugging purposes long forgotten.

[ 1 ]

same as above these docs are useless

[ 0 ]

Why does your code end in the middle of a function. Your diff is EXTREMELY screwed up, try again.

[ 1 ]

Or a better solution will be to multithread it a bit. Half an hour to get result is damn slow.

[ 1 ]

Notable stupid shit found in blob_act() Floors shouldn't have a blob act, because it'd only be called when attacking something dense above them.

[ 1 ]

nit use std unordered set if you do not care about ordering it will use less memory and be faster with simple types like eglnativewindowtype

[ 0 ]

Damn this is magical, this is so nice

[ 1 ]

Eh yeah I screwed up the branching. This is an extension of #1711.

[ 1 ]

i kinda agree with jakub that this check is worthless but i am ok ish to proceed landing it

[ 0 ]

Good shit lexorion.

[ 1 ]

look into ratelimiter when the th packet in the expression ctime self deque self time unit will always be true so the funtion will return false forever that is not what we want

[ 0 ]

commit message body should be wrapped at characters rather than

[ 0 ]

can you copy the original commit message from the first gerrit in as the commit message here when we submit this only this message will go into the git repository so should be self contained

[ 0 ]

also what the hell does that mean "reset starts"

[ 1 ]

keystone admin port

[ 0 ]

Its a black lump. Do you seriously want HD rocks?

[ 1 ]

import both on one line from neutron openstack common gettextutils import le li

[ 0 ]

useless trailing rand name already adds a

[ 0 ]

actually should get rid of format map py and just use trusttokenformatter token format rather than format map trust token prefix

[ 0 ]

> Not supporting this is frankly ridiculous. agree.

[ 1 ]

we need to eliminate the dependency of common db mixin

[ 0 ]

Did this actually happen when testing? This should only really occur when somebody fucks up.

[ 1 ]

if you look at the original cl that introduced the ssh host metric they want to track down dead hosts to kill it makes sense to leave around the ssh host creation metric using a dummy host so they know this attenuator host exists

[ 0 ]

are these dummy values for testing right now i mean certainly should not be hard coding us as the country say so in a comment somewhere

[ 0 ]

explicit tag is not required also why this cannot be written as externalrouterid null

[ 0 ]

you re absolutly right just my understanding of the whole idea of migration in releases was wrong now adressing the issue

[ 0 ]

you should probably use assertgreater here instead of an asserttrue

[ 0 ]

sweet great tutorial

[ 0 ]

@dotqurter If you don't finish this I might get around to it eventually @BenCat07 what's the nolerp fix do exactly? current nolerp sucks

[ 1 ]

I know Bauds already mentioned it but HOLY FUCK THAT'S TOO MUCH

[ 1 ]

i was thinking that if we have the show function but return the after mapping value say that is written in user space but we show the true register value it is kind of confusing so i just get rid of the show function maybe we do a reverse mapping to show the interval value if you think it is useful

[ 0 ]

test this outside the loop

[ 0 ]

Copy paste error. Damn

[ 1 ]

this was so fucking painful holy mother of god I AM A BELIEVER NOW

[ 1 ]

this is highly offensive to non christians i demand you remove it

[ 0 ]

i am not crazy about this error being here because this is parse root device hints not eg find device but i guess it can be cleaned up later

[ 0 ]

> How does samba depend on python3-markdown? that's ridiculous. No idea why samba packages drag in `python3-markdown` Curious indeed (-:

[ 1 ]

What the shit are you even talking about here

[ 1 ]

you need gpio h too

[ 0 ]

From a practical standpoint, the java.net.URL class dates from the earliest versions of Java and is rubbish, so I would say that in general java.net.URI is preferred regardless of whether the thing in question is really a URI or a URL. But in that case I think the method name and documentation should also say URI. Otherwise it will be confusing.

[ 1 ]

maybe add a comment here reminding the reader what the empty ssid is about

[ 0 ]

remove the white space here

[ 0 ]