showvikdbz/code-reviews · Datasets at Hugging Face

text stringlengths 1 5.2k	labels listlengths 1 1
@AndrewMcBurney I think that's fine. It looks like [Redis](http://www.rubydoc.info/gems/ddtrace/#Redis) and [Suckerpunch](http://www.rubydoc.info/gems/ddtrace/#SuckerPunch) are missing in that preview.	[ 1 ]
instancenotfound should be catched explicitly	[ 0 ]
i would like to add two more tests test delete bay with name not found test delete multiple bay with name	[ 0 ]
Yeah i need to fuck around and find some good numbers	[ 1 ]
what about ocf reskey crm meta timeout	[ 0 ]
die die die	[ 0 ]
hand code is disgusting.	[ 1 ]
How come we're not making this one abstract?	[ 1 ]
should this maybe be called rootwrap xenapi or rootwrap xen dom i am wondering if dom is not distinct enough to non xen for them to know to ignore this file	[ 0 ]
one small errata corrige test spawn nova net vif no vswitch exception uses mocks as well it fails for other reasons	[ 0 ]
this looks like useless also	[ 0 ]
somewhere somehow this cd command will get us into trouble it would be wise if this were executed in a subshell	[ 0 ]
remove all trailing white space	[ 0 ]
this is redundant maybe just run the galera install playbook using the galera bootstrap tag	[ 0 ]
That's a weird way to aggregate stream notes considering there is obvious distinction between streams and not-streams in `Speed`	[ 1 ]
Blobs is kinda screwed if they must always spawn this late. Rest seems fine though	[ 1 ]
this is a very critical issue, it is ridiculous to see the flutter team focusing on expanding to a variety of platforms while there are such critical issues.	[ 1 ]
Add a fucking grey square indicating the open hatch goddam is it really hard to do?	[ 1 ]
what you do not like spew that s going to be word of the year for just you wait	[ 0 ]
why the oustring oustring here ousting is a oustring already	[ 0 ]
The table in here sucked, so I rearranged this	[ 1 ]
Furthermore, Microsoft decided to hide behind their bot and close 6 or 7 other issues that arose from the "Santa Saga". I can't decide whether they are afraid of even more public backlash or they realised they got trolled and now they can't keep up with their own statement of honouring every single ofended person.	[ 1 ]
what if i gzipped g of zeros they certainly fit one chunk but when you decompress this chunk you will take g of memory	[ 0 ]
holy fuck, @ike709 are you crazy?	[ 1 ]
i know that this is on ps one trillion and you must be getting tired of idiot ic s but bear with me what do you think about encapsulating this bit of code in a method and targeting in a test i would just like to see the code in the exception handling executed right now we do not even know if it is syntactically correct i see you had tests in an earlier ps but removed them why is that	[ 0 ]
can probably just remove all of the really s	[ 0 ]
callbacks are issued on the ui thread so you need to poll it instead of the instrumentation thread alternatively can you use a semaphore instead of polling makes the code easier and gets rid of the ugly polling	[ 0 ]
these crappy for var/obj\|window\|doorwindow in obj loops are teh thing I was talking about with respect to a NEEDS_COMPLEX_PATH_CHECK flag on the turf	[ 1 ]
you should strip trailing newline here with	[ 0 ]
Change this to use current_cycle which is defined on all reagents. And then remove the cycle_count++ shit, /datum/reagent/on_mob_life() already increases current_cycle.	[ 1 ]
ovs db serice ovsdb serve ovs vswitch serice ovs vswitchd ovs db pid ovs dir ovs db serice pid	[ 0 ]
your fake client here needs to have a fake client container	[ 0 ]
consts oswl resource types vm	[ 0 ]
So this is weird. `Topic()` code implies the limit here is `4500`, while `receive_signal` implies `50 * ONE_ATMOSPHERE`. Move it to a constant either way.	[ 1 ]
this space needs to be removed	[ 0 ]
i think here you should use just for uuid in uuid list	[ 0 ]
Damn :man_facepalming:	[ 1 ]
eh why did not you define it as native python objects the same way it is done on lines	[ 0 ]
Yeah, down with bushcraft medicine. Most of them are straddling the line between being very optimistic and straight bullshit ~~which is of course on point for herbal medicine~~ so they could use a feasibility audit.	[ 1 ]
i would be very careful on raising the lock mode on read you might kill the throughput unnecessarily	[ 0 ]
ok so my comment above is not a real problem hostless job timeout will set aborted bit of all child jobs and shard client should sync the abort bit to shard db and abort all child jobs this cl should prevent master scheduler to set the is complete bit of child jobs running in shard as their aborted bit is set to true	[ 0 ]
somewhat awkward to have to specify m for every instantiation and that d has to be specified in terms of the naked u type when what it should represent is a value of the typed flags type	[ 0 ]
Yeah that's what I'm saying, wtf? Isn't `TRUE` & `FALSE` the standard that's being applied most everywhere else as we go through oldcode? Now I'm confused	[ 1 ]
aah crap. I totally forgot :sweat_smile:	[ 1 ]
nikhil do we need data migration	[ 0 ]
this could also go into the common method	[ 0 ]
@volker18xxdev Your company can't afford to acquire it. Minor 14 is at $120/share, meaning the company has to give you $240 of assets. It would need to give you 2 shares at $110 each and $20 of cash to make up the difference. Your company has $13, which is less than $20.	[ 1 ]
As ridiculous as it sounds in 2021, I removed my cookies and all was back to working as normal. If you're able to login in a different browser and/or in private/incognito mode, try clearing the cookies for your cockpit server. It worked for me.	[ 1 ]
this vim header should be removed	[ 0 ]
nullable false i think	[ 0 ]
local path libc better with include call all makefiles under local path call all makefiles under local path libc	[ 0 ]
since any app can connect to this we cannot trust any of the contents the pid from so peercred should be used here	[ 0 ]
with mocks you would have to add these return values which is what the fakes are doing	[ 0 ]
also, somebody please make these use switch cases. god fucking damn.	[ 1 ]
It is not possible to add `FILTHY` flag for `used_up_item` - this should be coded in C++.	[ 1 ]
uncuddle these dicts too	[ 0 ]
>admin accidentally spawns secway >deletes it >shit blows up \U0001f914	[ 1 ]
i prefer this test code reusing the difference of arguments ex and except is instance and type only so how about changing here to def test migrate server deals with expected exceptions self ex excep def test migrate server deals with expected exceptions self ex instance fake instance fake db instance uuid uuid vm state vm states active inst obj instance obj instance from db object class conductortasktestcase basetasktestcase test compute basetestcase self conductor utils exceptionhelper self conductor self assertraises excep self assertraises type ex self conductor migrate server self context inst obj host destination true false none block migration disk over commit class conductortasktestcase basetasktestcase test compute basetestcase disk over commit def test migrate server deals with destinationhypervisortold self ex exc destinationhypervisortold self test migrate server deals with expected exceptions ex ex ex exc destinationhypervisortold self test migrate server deals with expected exceptions ex def test migrate server deals with hypervisorunablailable self ex exc hypervisorunavailable self test migrate server deals with expected exceptions ex host dummy ex ex exc hypervisorunavailable host dummy self test migrate server deals with expected exceptions ex	[ 0 ]
initializing val will at least give you consistent data on a i c read failure	[ 0 ]
done i will include your suggestion in the next patchset	[ 0 ]
i do not know actually according to git history leecam or drewry are the best ones to ask i would ping one of them	[ 0 ]
insecure hash algorithms missing here	[ 0 ]
i think that is okay can you make a bug for fixing that later	[ 0 ]
you forgot a return and this is a shitty message	[ 1 ]
AWS, you're ridiculous, you know that? First-mover advantage is almost everything, apparently...	[ 1 ]
remove the backslash	[ 0 ]
this should be flavor id self flavor id	[ 0 ]
you culd remove the nd part of this comment only st part is relevant the content does not matter	[ 0 ]
useless too	[ 0 ]
bdms should probably be passed into reschedule or reraise instead of fetching it again	[ 0 ]
given the irc discussion i feel it is ok to leave that fk since the entries are short lived	[ 0 ]
if we are going to change this let us also remove bluetoothdevice take	[ 0 ]
el rey ha muerto viva el rey	[ 0 ]
s template key template id here qand everywhere else too please	[ 0 ]
you haven t initialized run at load what s it is value here are you sure	[ 0 ]
trove build dir and trove integration conf dir need to be removed here also	[ 0 ]
this line is probably leftover if so should be killed	[ 0 ]
actually i'm full of shit, just set idle_power_usage properly when it's charging	[ 1 ]
what is it a string a number a tuple	[ 0 ]
should be assert true since you dereference it later on	[ 0 ]
should the workinprogress acl be removed	[ 0 ]
oh fu cking jesus christ on a unicycle	[ 1 ]
wait you're not assigning to kf_map here. wtf?	[ 1 ]
Maybe this could be a mainlined mod like Filthy Clothing?So whoever wants to deal with this will do so, if you don't want to - just deactivate it	[ 1 ]
i will remove this in the next upload i hate it when i see something to change after i have already added a comment in gerrit	[ 0 ]
sort key should be inspection started at	[ 0 ]
silly nit but need a period at the end of one line doc strings here	[ 0 ]
such docstring are not useful	[ 0 ]
you could call me pain in the neck but there is no from we re not pushing anything from puppet master agent are polling so i think we need another preposition here	[ 0 ]
<details> <summary>Click me! @AnturK </summary> You suck. </details>	[ 1 ]
i think this is supposed to be novaclient api versions apiversion	[ 0 ]
Tbh this looks like a great way to screw up the quest, especially when you happen to put it into an auto-eat zone by accident or something. I would make it inedible like e.g flour is.	[ 1 ]
damn, I'll recheck all of the identations.	[ 1 ]
i asked for this because i like less coupling with the conf object	[ 0 ]
may be we could get rid of this splitting stdout from stderr in run command one day	[ 0 ]
this check is useless	[ 0 ]
Oh, actually this is basically a malformed query.. for this result to actually work, `id` would have to be a root query on the schema, which would be ridiculous.	[ 1 ]
I have downgraded to v0.12.1 and I'm still having the same problem. Wouldn't it be better if odoo bundled the right version with the release? Seems ridiculous to me that we have to manually compile a custom version of qt in order to use odoo.	[ 1 ]
Because English-language is trash	[ 1 ]
It's not a sleep don't worry BUTT I should really gut the code anyways, once the ling goes horror it should not go back to human	[ 1 ]

@AndrewMcBurney I think that's fine. It looks like [Redis](http://www.rubydoc.info/gems/ddtrace/#Redis) and [Suckerpunch](http://www.rubydoc.info/gems/ddtrace/#SuckerPunch) are missing in that preview.

[ 1 ]

instancenotfound should be catched explicitly

[ 0 ]

i would like to add two more tests test delete bay with name not found test delete multiple bay with name

[ 0 ]

Yeah i need to fuck around and find some good numbers

[ 1 ]

what about ocf reskey crm meta timeout

[ 0 ]

die die die

[ 0 ]

hand code is disgusting.

[ 1 ]

How come we're not making this one abstract?

[ 1 ]

should this maybe be called rootwrap xenapi or rootwrap xen dom i am wondering if dom is not distinct enough to non xen for them to know to ignore this file

[ 0 ]

one small errata corrige test spawn nova net vif no vswitch exception uses mocks as well it fails for other reasons

[ 0 ]

this looks like useless also

[ 0 ]

somewhere somehow this cd command will get us into trouble it would be wise if this were executed in a subshell

[ 0 ]

remove all trailing white space

[ 0 ]

this is redundant maybe just run the galera install playbook using the galera bootstrap tag

[ 0 ]

That's a weird way to aggregate stream notes considering there is obvious distinction between streams and not-streams in `Speed`

[ 1 ]

Blobs is kinda screwed if they must always spawn this late. Rest seems fine though

[ 1 ]

this is a very critical issue, it is ridiculous to see the flutter team focusing on expanding to a variety of platforms while there are such critical issues.

[ 1 ]

Add a fucking grey square indicating the open hatch goddam is it really hard to do?

[ 1 ]

what you do not like spew that s going to be word of the year for just you wait

[ 0 ]

why the oustring oustring here ousting is a oustring already

[ 0 ]

The table in here sucked, so I rearranged this

[ 1 ]

Furthermore, Microsoft decided to hide behind their bot and close 6 or 7 other issues that arose from the "Santa Saga". I can't decide whether they are afraid of even more public backlash or they realised they got trolled and now they can't keep up with their own statement of honouring every single ofended person.

[ 1 ]

what if i gzipped g of zeros they certainly fit one chunk but when you decompress this chunk you will take g of memory

[ 0 ]

holy fuck, @ike709 are you crazy?

[ 1 ]

i know that this is on ps one trillion and you must be getting tired of idiot ic s but bear with me what do you think about encapsulating this bit of code in a method and targeting in a test i would just like to see the code in the exception handling executed right now we do not even know if it is syntactically correct i see you had tests in an earlier ps but removed them why is that

[ 0 ]

can probably just remove all of the really s

[ 0 ]

callbacks are issued on the ui thread so you need to poll it instead of the instrumentation thread alternatively can you use a semaphore instead of polling makes the code easier and gets rid of the ugly polling

[ 0 ]

these crappy for var/obj|window|doorwindow in obj loops are teh thing I was talking about with respect to a NEEDS_COMPLEX_PATH_CHECK flag on the turf

[ 1 ]

you should strip trailing newline here with

[ 0 ]

Change this to use current_cycle which is defined on all reagents. And then remove the cycle_count++ shit, /datum/reagent/on_mob_life() already increases current_cycle.

[ 1 ]

ovs db serice ovsdb serve ovs vswitch serice ovs vswitchd ovs db pid ovs dir ovs db serice pid

[ 0 ]

your fake client here needs to have a fake client container

[ 0 ]

consts oswl resource types vm

[ 0 ]

So this is weird. `Topic()` code implies the limit here is `4500`, while `receive_signal` implies `50 * ONE_ATMOSPHERE`. Move it to a constant either way.

[ 1 ]

this space needs to be removed

[ 0 ]

i think here you should use just for uuid in uuid list

[ 0 ]

Damn :man_facepalming:

[ 1 ]

eh why did not you define it as native python objects the same way it is done on lines

[ 0 ]

Yeah, down with bushcraft medicine. Most of them are straddling the line between being *very* optimistic and straight bullshit ~~which is of course on point for herbal medicine~~ so they could use a feasibility audit.

[ 1 ]

i would be very careful on raising the lock mode on read you might kill the throughput unnecessarily

[ 0 ]

ok so my comment above is not a real problem hostless job timeout will set aborted bit of all child jobs and shard client should sync the abort bit to shard db and abort all child jobs this cl should prevent master scheduler to set the is complete bit of child jobs running in shard as their aborted bit is set to true

[ 0 ]

somewhat awkward to have to specify m for every instantiation and that d has to be specified in terms of the naked u type when what it should represent is a value of the typed flags type

[ 0 ]

Yeah that's what I'm saying, wtf? Isn't `TRUE` & `FALSE` the standard that's being applied most everywhere else as we go through oldcode? Now I'm confused

[ 1 ]

aah crap. I totally forgot :sweat_smile:

[ 1 ]

nikhil do we need data migration

[ 0 ]

this could also go into the common method

[ 0 ]

@volker18xxdev Your company can't afford to acquire it. Minor 14 is at $120/share, meaning the company has to give you $240 of assets. It would need to give you 2 shares at $110 each and $20 of cash to make up the difference. Your company has $13, which is less than $20.

[ 1 ]

As ridiculous as it sounds in 2021, I removed my cookies and all was back to working as normal. If you're able to login in a different browser and/or in private/incognito mode, try clearing the cookies for your cockpit server. It worked for me.

[ 1 ]

this vim header should be removed

[ 0 ]

nullable false i think

[ 0 ]

local path libc better with include call all makefiles under local path call all makefiles under local path libc

[ 0 ]

since any app can connect to this we cannot trust any of the contents the pid from so peercred should be used here

[ 0 ]

with mocks you would have to add these return values which is what the fakes are doing

[ 0 ]

also, somebody please make these use switch cases. god fucking damn.

[ 1 ]

It is not possible to add `FILTHY` flag for `used_up_item` - this should be coded in C++.

[ 1 ]

uncuddle these dicts too

[ 0 ]

>admin accidentally spawns secway >deletes it >shit blows up \U0001f914

[ 1 ]

i prefer this test code reusing the difference of arguments ex and except is instance and type only so how about changing here to def test migrate server deals with expected exceptions self ex excep def test migrate server deals with expected exceptions self ex instance fake instance fake db instance uuid uuid vm state vm states active inst obj instance obj instance from db object class conductortasktestcase basetasktestcase test compute basetestcase self conductor utils exceptionhelper self conductor self assertraises excep self assertraises type ex self conductor migrate server self context inst obj host destination true false none block migration disk over commit class conductortasktestcase basetasktestcase test compute basetestcase disk over commit def test migrate server deals with destinationhypervisortold self ex exc destinationhypervisortold self test migrate server deals with expected exceptions ex ex ex exc destinationhypervisortold self test migrate server deals with expected exceptions ex def test migrate server deals with hypervisorunablailable self ex exc hypervisorunavailable self test migrate server deals with expected exceptions ex host dummy ex ex exc hypervisorunavailable host dummy self test migrate server deals with expected exceptions ex

[ 0 ]

initializing val will at least give you consistent data on a i c read failure

[ 0 ]

done i will include your suggestion in the next patchset

[ 0 ]

i do not know actually according to git history leecam or drewry are the best ones to ask i would ping one of them

[ 0 ]

insecure hash algorithms missing here

[ 0 ]

i think that is okay can you make a bug for fixing that later

[ 0 ]

you forgot a return and this is a shitty message

[ 1 ]

AWS, you're ridiculous, you know that? First-mover advantage is almost everything, apparently...

[ 1 ]

remove the backslash

[ 0 ]

this should be flavor id self flavor id

[ 0 ]

you culd remove the nd part of this comment only st part is relevant the content does not matter

[ 0 ]

useless too

[ 0 ]

bdms should probably be passed into reschedule or reraise instead of fetching it again

[ 0 ]

given the irc discussion i feel it is ok to leave that fk since the entries are short lived

[ 0 ]

if we are going to change this let us also remove bluetoothdevice take

[ 0 ]

el rey ha muerto viva el rey

[ 0 ]

s template key template id here qand everywhere else too please

[ 0 ]

you haven t initialized run at load what s it is value here are you sure

[ 0 ]

trove build dir and trove integration conf dir need to be removed here also

[ 0 ]

this line is probably leftover if so should be killed

[ 0 ]

actually i'm full of shit, just set idle_power_usage properly when it's charging

[ 1 ]

what is it a string a number a tuple

[ 0 ]

should be assert true since you dereference it later on

[ 0 ]

should the workinprogress acl be removed

[ 0 ]

oh fu cking jesus christ on a unicycle

[ 1 ]

wait you're not assigning to kf_map here. wtf?

[ 1 ]

Maybe this could be a mainlined mod like Filthy Clothing?So whoever wants to deal with this will do so, if you don't want to - just deactivate it

[ 1 ]

i will remove this in the next upload i hate it when i see something to change after i have already added a comment in gerrit

[ 0 ]

sort key should be inspection started at

[ 0 ]

silly nit but need a period at the end of one line doc strings here

[ 0 ]

such docstring are not useful

[ 0 ]

you could call me pain in the neck but there is no from we re not pushing anything from puppet master agent are polling so i think we need another preposition here

[ 0 ]

<details> <summary>Click me! @AnturK </summary> You suck. </details>

[ 1 ]

i think this is supposed to be novaclient api versions apiversion

[ 0 ]

Tbh this looks like a great way to screw up the quest, especially when you happen to put it into an auto-eat zone by accident or something. I would make it inedible like e.g flour is.

[ 1 ]

damn, I'll recheck all of the identations.

[ 1 ]

i asked for this because i like less coupling with the conf object

[ 0 ]

may be we could get rid of this splitting stdout from stderr in run command one day

[ 0 ]

this check is useless

[ 0 ]

Oh, actually this is basically a malformed query.. for this result to actually work, `id` would have to be a root query on the schema, which would be ridiculous.

[ 1 ]

I have downgraded to v0.12.1 and I'm still having the same problem. Wouldn't it be better if odoo bundled the right version with the release? Seems ridiculous to me that we have to manually compile a custom version of qt in order to use odoo.

[ 1 ]

Because English-language is trash

[ 1 ]

It's not a sleep don't worry BUTT I should really gut the code anyways, once the ling goes horror it should not go back to human

[ 1 ]