text
stringlengths 1
5.2k
| labels
listlengths 1
1
|
|---|---|
rropriate should be removed
|
[
0
] |
this should not be needed get project raises projectnotfound for an invalid project id
|
[
0
] |
the parentheses here are causing the url to include them incorrectly and should be removed
|
[
0
] |
it should be project only false
|
[
0
] |
i think the cleanest style here would be to make this class linker iscompiledimagemethod m and then embed maybe into classlinker as iscompiledimagemethod it d be nice to avoid exposing the debugger to inner notions of oat files
|
[
0
] |
What do you mean? Ah, so you were bullying Robustin? Very bad behavior. RIP, you.
|
[
1
] |
I didn't find it in designer, only for options, not for buttons, which looks ugly. Will keep it as is for now, maybe refactor when return to map editor
|
[
1
] |
this can be suggested as a new spec when we get on to puppet biggest issue with it is we use splat and regex matching in node definitions i personally like an expressive site pp versus bludgeoning hiera into being an enc i also dislike the more magic of hiera data bindings that this would require
|
[
0
] |
Mixing tabs and spaces requires immediate banishment to the depths of hell, do not encourage this heathen behaviour
|
[
1
] |
useless trailing it s already part of the rand name method
|
[
0
] |
I made it piss yellow, you're welcome.
|
[
1
] |
private key keypair private key
|
[
0
] |
if name main
|
[
0
] |
these probably should not be nullable
|
[
0
] |
this override seems useless
|
[
0
] |
Why the -_- ? Still, I can only use the online version as my internet connection is so horrifically awful here, every time I tried cloning a local copy it froze at some point. Thank you very much for your help. Sorry for asking here.
|
[
1
] |
ic signal cellular bar this matches the ui mocks
|
[
0
] |
can you rebase this patch i think i got rid of stats type a while back
|
[
0
] |
fwiw all these elses should be removed
|
[
0
] |
does this need to be localized if not and this is just a dummy sentinel value does it need to be in english anyway
|
[
0
] |
this is not a pwm but i can guess where you stole this from
|
[
0
] |
what the fuck is all of this about.
|
[
1
] |
Yeah it sucks a bit that they have such a limited option of linux runners
|
[
1
] |
there is a spurious i at the end actually you can just nest the if inside the cflags
|
[
0
] |
this is polymer s templating system unfortunately the syntax does not allow expressions like index this is probably one of my single biggest gripes with polymer in litelement i look forward to moving to directly using javascript code for templating lit html s templating style feels kind of similar to jsx but with strings instead to avoid this sort of thing
|
[
0
] |
again raising self xenapi failure smells
|
[
0
] |
i think there is a race here with two threads could be executing this statement at teh same time when next method id kmaxmethodid
|
[
0
] |
you are not returning anything here you are raising a notimplemented exception
|
[
0
] |
Nich llease replacw this with a multiply and change the other procs accordingly because using add for this is FUCKING RETARDED
|
[
1
] |
This seems pretty horrid here but offhand I'm not sure where this would go. @deathbeam ?
|
[
1
] |
i would rather see this parameter removed there is only one option so it is useless anyway
|
[
0
] |
Silence disgusting carbon. I mean... Fellow disgusting carbon. Beep boop.
|
[
1
] |
nit ditto on using the appropriate amount of error i e us
|
[
0
] |
why not setting the custom policy file via cfg conf policy file then we will be able to kill that remaining argument for init making api as clean and dumb as possible
|
[
0
] |
struct net device ndev struct bcm cfg cfg null
|
[
0
] |
How does this fix a js error? Just eyeballing it the code looks the same. If there's some wacky/tricky reason this fixes something, leaving a comment might help prevent a regression in the future.
|
[
1
] |
nope, not happening. the Auto111 syntax is rubbish
|
[
1
] |
nit do you need this ui controller h is included above
|
[
0
] |
Yes, I m aware someone could make a bastard chain where this does not hold, but it will make our code nastier if we try to accommodate such things. My 2c is to drop this clause and always do VerifyEip1559Header
|
[
1
] |
please use the regexpfilter as commandfilter is the weakest of checks please see
|
[
0
] |
cookie self default cookie
|
[
0
] |
why not setting the custom policy file via cfg conf policy file then we will be able to kill that remaining argument for init making api as clean and dumb as possible
|
[
0
] |
would subtracting the tasksize and picking a second process to kill here make sense if we are still below the threshold
|
[
0
] |
kill the print
|
[
0
] |
i destroy dev priv wq on failure
|
[
0
] |
Yup - [JSCS overview](http://jscs.info/overview.html) has one too for sublime. If you use its Airbnb preset and suck in our `.jscsrc` included in the project it will make your life easier IMO. Totally up to you.
|
[
1
] |
department encryption keys part 2: holy fucking hell byondaloo
|
[
1
] |
it would be cool if extendable weapons were some sort of component or whatever so we dont have to copy paste tbaton shitcode every single time
|
[
1
] |
Is this different than the shapeshit image we have for the fox token?
|
[
1
] |
I know it's disgusting
|
[
1
] |
Any clue on why is this comment here in the first place? It is kind of scary.
|
[
1
] |
It's a gay server
|
[
1
] |
should this cancel be above if null block or does it not matter
|
[
0
] |
qos id qos db item id
|
[
0
] |
yes you do you have to specify which process and which signals you actually allow kill to interact with
|
[
0
] |
as noted below i think you need to assert what you support here right now if a user does rescue on an instance booted from volume it looks to me like the following will happen root vhd path will return a non existent path self vmutils detach vm disk will silently do nothing new disk with invalid path with be added this definitely will not work as the user intends as it is unsupported at the moment that is fine but it would be much nicer to the user to tell them that with a clear error message rather than leaving them wondering why their rescued instance does not work also i have not looked at the interaction with unrescue but it is critical that the above mess can be unwound with unrescue if it currently work it is presumably just luck tl dr not supporting everything is fine but i think you need to explicitly check that root vhd path exists and there is only disk if not you need to error out early this might be generally bad seems like the sort of thing you would want to know if it did not work separate issue though i do not know if this will explode or not
|
[
0
] |
I know but some shit has to go
|
[
1
] |
God damn I shouldn't code late at night You're right
|
[
1
] |
For some reason it didn't push my latist shit. Pushed again. fixed.
|
[
1
] |
gah i am an idiot thanks
|
[
0
] |
leave isexc and resetcc please
|
[
0
] |
Crap. What I get for not running rubocop :-(
|
[
1
] |
I'd rather wait 5 seconds for my shit game to die than have the good games die prematurely and potentially lose progress.
|
[
1
] |
missing space dir git
|
[
0
] |
Globals are shit and singletons are globals. It would be much better to hold a reference to `Game` wherever it's needed. But that's really because there's no difference in runtime.
|
[
1
] |
@bhollis and I talked about doing a lazy load at one point, but figured after the initial load it wouldn't be a problem, plus it makes it a lot easier when using the vendor items in the loadout builder, but 20s is just ridiculous.
|
[
1
] |
Did this accidentally get sucked in?
|
[
1
] |
maybe a dumb question but get boot device will call client list boot devices if drac boot devices is none so why bother doing this here instead of letting it be done in get boot device
|
[
0
] |
seems odd that you have to kill then restart should not restart be kill start
|
[
0
] |
this should be setup receiver pep
|
[
0
] |
accidentally put in init
|
[
0
] |
i would be a bit amazed if we did not already have a function that does this might want to do some checking around
|
[
0
] |
you should never set invalid capture format in the first place
|
[
0
] |
Seriously, `random` sucks so hard. BTW, is `bitmaskWithRejection` actually fastest? I'd guess `mod` is expensive, but `intMult` on amd64 should be really fast. Anyway, down with `randomR`.
|
[
1
] |
docstr is useless entirely redundant with function name
|
[
0
] |
The rest of the code surrounding this relating to UI on the SS is...weird! I would recommend the more common pattern of just creating a `/datum/pai_menu` or whatever per mob, and using that.
|
[
1
] |
Honestly just make RCDs check and break themselves instead, the way it is done currently is pretty much just shitcode(not your fault).
|
[
1
] |
if not self resource id also about similar behavior of delete for neutron resources i think will be better without this check other way it is adding this code to other delete functions
|
[
0
] |
I think this dust attack\uff0cthis project is really rubbish, the developer is responsible at all, my transfer transaction has never been able to be on the chain
|
[
1
] |
why do you suddenly switch from check dag here unless you require a certain ordering of lines inside the dump file you should always stick with check dag
|
[
0
] |
done ouch awfull mistake
|
[
0
] |
how awful PDA stuff is codewise? I wouldn't like to bloat this pull request with their crap
|
[
1
] |
you do not use self so that should be a staticmethod
|
[
0
] |
the dict only works for buildbot sorry for the confusion robbie s request is he wants to kill getactivemaster even if we have not migrated everything to luci yet to do that we need a dict to convert buildbot s mastername to perf dashboard machine group
|
[
0
] |
Looks like you fucked up line endings in this file
|
[
1
] |
trailing whitespaces should be removed
|
[
0
] |
This name and the description are not clear. The description is grammatically weird.
|
[
1
] |
fuck you ps. I saw no reason to re-invent the wheel with patch code when pill code did just fine
|
[
1
] |
let us use assignment i e scellstring acell mabasecell getstring pdoc which looks nicer
|
[
0
] |
useless
|
[
0
] |
Ah crap, that file wasn't supposed to have been committed. Is there any way to remove it now? Or do I have to cancel this pull request?
|
[
1
] |
Seriously, why do we need some wacky queuing thing? just pull the consistency checking out of the JSON loading and there's no issue whatsoever. It's only attached to the json loading because it was convinient at the time.
|
[
1
] |
i think you also need append here for response interface into response interfaces
|
[
0
] |
oof that sucks, aight no worries
|
[
1
] |
what i referred in the earlier comments was the second parameter here object since you are subclassing from vpc vpccontroller i do not see a reason to pass object anymore
|
[
0
] |
dead you want the port security bp
|
[
0
] |
Damn, `flow` is nice.
|
[
1
] |
Holy shit I just noticed how bad this is, the span does literally nothing
|
[
1
] |
I like how you can just tell where coders at some point just copy+pasted shit, because of small inconsistencies being copied over and over.
|
[
1
] |
kill the semicolon
|
[
0
] |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.