text
stringlengths
1
5.2k
labels
listlengths
1
1
this variable assignement is useless
[ 0 ]
remove jichen devstack here and the other prompts
[ 0 ]
... will this even work? Is byond/internet explorer really shit enough to not suppress white-spaces?
[ 1 ]
better move these mocks to test copy image to volume stream optimized
[ 0 ]
stolen code from kakhack atleast credit cazz fag
[ 1 ]
it s a pep error should be removed
[ 0 ]
ws to kill
[ 0 ]
nit i think this wants to return step odict returning an empty dict makes this inherently behave like dropexpectation
[ 0 ]
should probably be destroyhardwareresources mview instead
[ 0 ]
update engine is the daemon started at boot update engine client is a tool to communicate with the running daemon both programs are using d bus for ipc right now also note that update engine is using d bus now and we are planning to migrate off d bus so to avoid dbus te polluting external sepolicy i amend the update engine selinux policy c i suppose we do not need to label update engine client as it is only used from a shell or we can label it in the brillo specific selinux policy in
[ 0 ]
remove linebreak
[ 0 ]
no need for that basetestcase resets all mocks
[ 0 ]
i am using any hardcoded default values only in the params class so this goes to the params too even if it looks stupid
[ 0 ]
Does it even not work when you at ridiculous high values for Z offsets?
[ 1 ]
hi haomeng os kill pid sends signal which is basically are you running
[ 0 ]
flavor ids should be flavor ids here will fix
[ 0 ]
metaclass abcmeta
[ 0 ]
xiyuan is there a more direct way to check if running in a fake gaia env in autotest
[ 0 ]
Some text editors suck. They merge following spaces into the previous tabulator which makes it impossible to select the space character. Navigate to the first `Z`, clear all indents and re-indent.
[ 1 ]
@joshuajeschek This might sound ridiculous but it honestly hadn't occurred to me to do that. I'll merge this for now and look at copying them over in the future.
[ 1 ]
shouldn t this be if not self l policy is owned delete the policy otherwise do nothing
[ 0 ]
it was for some stupid wsgi stuff but it might have been a red herring ill remove and rerun tox
[ 0 ]
because this is a client it is a fake client class it responds like it interacts with a server that responds to api methods with pre canned responses
[ 0 ]
useless
[ 0 ]
done i will leave the other cases of iteritems in neutron to a future change however
[ 0 ]
You can't assing a value to a read-only variable, silly
[ 1 ]
that s interesting what was being misinterpreted and what did the linter pick up on
[ 0 ]
it is ok we will remove this script entirely soon
[ 0 ]
we should probably also maintain a drop count per pid so we can see in the tables which specifically chattiest pid s got hurt when the per uid spam filter kicked in
[ 0 ]
revenants are really fucking weird and the exception shouldnt influence the rule
[ 1 ]
i forgot to delete it yes i admit it i am dumb
[ 0 ]
put an empty line between normal imports and statics
[ 0 ]
maybe a dumb question and i am totally missing something here is not this code just testing the test code fake driver from up above in this file couldn t these unit test just assert that the proxy was called with the right params and return value and thats it ie validating behavior of the driver code and not test code
[ 0 ]
it may happen that a service die a service may die
[ 0 ]
this is a leftover and should be removed
[ 0 ]
should be using tags console instead of filename console html here so we can pickup grenade failures
[ 0 ]
oh yuck, I thought I did
[ 1 ]
nit neutron is a third party lib in fwaas so it belongs in the block with oslo sqlalchemy in all files
[ 0 ]
yeah fikou wtf. I think u should ban him for player references
[ 1 ]
Damn ... you're right, I forget to add them ... I'll add them.
[ 1 ]
s to dissapear to be removed
[ 0 ]
these static values should be put at the top i e default cipher
[ 0 ]
why do you need a mock can t you just set the state self lbm vxlan group rv
[ 0 ]
I tried using some dynamic constants (wtf?) but nah, won't work.
[ 1 ]
useless trailing rand name already adds a
[ 0 ]
BTW I hate method names that are a single letter + underscore. WTF? Python is not matlab... readability counts.
[ 1 ]
could we kill this line
[ 0 ]
Ok, if it is for readability then it is pretty annoying to read indeed.
[ 1 ]
set e would abort this you probably want if out then
[ 0 ]
should be x padraig or whatever
[ 0 ]
One hell of an inline
[ 1 ]
Crap, didn't realize that living also has get_active_hand.
[ 1 ]
no we cannot because we cannot write to that directory and hidden files in tmp are terrible
[ 0 ]
given this comment is correct i think that line should be removed we do not want to force migration to complete prior to migration start it s pointless is not it
[ 0 ]
please remove backslashes where possible
[ 0 ]
nit should we use kserviceworkerscriptmaxcacheage
[ 0 ]
thanks can you add a todo here to remove unittests after tests is ready along with a link to the bug it would also be good to explain this in the tast tests that run these executables
[ 0 ]
i would not put that comment there you will just curse yourself and it will most certainly happen as soon as you document it like that
[ 0 ]
WTF dude? Make this proc empty at the parent level; put all this code under `obj/machinery/atmospherics/components/returnPipenets()`
[ 1 ]
agree wholeheartedly with fungi
[ 0 ]
this should be moved to line no need to assign it here as the exception may be thrown below
[ 0 ]
Oh jesus christ, thats a random bad that I did.
[ 1 ]
still very new to the ndk so this is probably a dumb question don t we run both gcc and clang when i run this it prints gcc and i do not see an option in help that switches between the two or anything in run tests sh that would indicate an undocumented switch
[ 0 ]
i think it should be removed
[ 0 ]
Dang. You know your stuff! \U0001f64f
[ 1 ]
how did it work before w o open sorry probably roland would be the better reviewer than me because i will ask too many stupid rtfm questions
[ 0 ]
note to self to fix my shit
[ 1 ]
when vkcreatefoo foo fails the spec requires that vkcreatefoo not modify foo as a consequence when vkcreateimageview fails here vk image view remains unitialized memory and scopedvkimageview below gets initialized with garbage bits solution check the vkcreateimageview result before creating the scopedvkimageview
[ 0 ]
imports should be in the begging of the file
[ 0 ]
banging head on table thanks
[ 0 ]
Redid my whole branch after screwing up with git. Must have left it out. Will readd.
[ 1 ]
i have noticed this happening in GA aircraft since the patch, for what it's worth. also, autotrim is prone to going mad after the second takeoff, spiking to ridiculous levels causing stalls or nosedives.
[ 1 ]
I bet this is gonna make it into the game and some poor sod will be wondering which fucker they have to finish
[ 1 ]
Should really be "STOP TRYING TO EXPLOIT THE GAME YOU SHITLORD!" And then `gib()`.
[ 1 ]
false false null java fd ok
[ 0 ]
You don't really need named return parameters here, and this save the ridiculous `return` required by Go. ```suggestion \treturn strings.Split(cm.Data[osTypeImageListName[Windows]], imageListDelimiter), \t\tstrings.Split(cm.Data[osTypeImageListName[Linux]], imageListDelimiter) ```
[ 1 ]
i believe that you mean bashrc
[ 0 ]
silly typo
[ 0 ]
man we use `user.loc` twice in this for loop i think we could probably cache it beforehand so we don't have to keep doing fuckshit work for when people are sharding up the place
[ 1 ]
like wtf is that variable name
[ 1 ]
this is a little useless if the database port is not configure other service use that value will be empty too and crash so mariadb port database port is enought
[ 0 ]
Holy shit I never thought it'd be able to get away with telling people to use `!!` to make a value a strict bool because nitpicking and yet here you are you absolutely genius.
[ 1 ]
drop all puppet jobs
[ 0 ]
this is really ugly. at this point the track should be stored locally, not inside the button.
[ 1 ]
That's rather ridiculous that Microsoft is keeping it closed. Thank you for the link.
[ 1 ]
i would rather have rpc api param adopt stack data here instead
[ 0 ]
ditto uno freezepanesfirstcolumn and uno freezepanesfirstrow
[ 0 ]
You need to explain what is happening, the description is also confusing and I dont know what it is supposed to do. I know you are just saying that I am an idiot but if you want to succeed in this computer world you have to make these things much more user friendly with descent explanations. I have been to the explanation page before, but you seem to think I am just being stupid. Wake up.
[ 1 ]
make use of ceph data dir configurable
[ 0 ]
Did you just export them out of figma or what?
[ 1 ]
is this a libvirt only change
[ 0 ]
neutron should be lowercase also suggested to add a link to the graphic
[ 0 ]
you re not exiting so it is not fatal log error log warn
[ 0 ]
I'm killing the fuck out of it, because I've hated it for as long as I've known it was a thing.
[ 1 ]
please fix this fucking varname
[ 1 ]
couldn t we just dump it as yaml instead with open etc os net config mapping yaml w as f yaml safe dump interface mapping data node f default flow style false
[ 0 ]
nit validating a request body
[ 0 ]
i would put this after the exception field so it is close to the handle it manages
[ 0 ]
should kill this while you are here
[ 0 ]
fyi more of a fake than a mock uber nit perhaps create rather than get uber nit consider making assertions utility methods static to make it clear they only work on their arguments
[ 0 ]