text
stringlengths
1
5.2k
labels
listlengths
1
1
I'm starting to see the changes now, damn Github is bad at displaying this..
[ 1 ]
This is a good idea - helps to not leave rubbish share data after a scenario.
[ 1 ]
nitpick work a ro und
[ 0 ]
should be a boolopt instead of stropt
[ 0 ]
Damn, can't believe I missed one!
[ 1 ]
the more you know i am glad that base was not totally crazy when they did something like this can we currently feed weak ptr to base callback i remember that we used to use the hand rolled chrome version of weak ptr in that way
[ 0 ]
hell no that's even shorter
[ 1 ]
use xml to json rather than self xml to json
[ 0 ]
I saw that and shook my head as well. Why the fuck
[ 1 ]
bullshit (with love), you are just modifying the name
[ 1 ]
nit s ironic ironic per openstack guidelines here and below
[ 0 ]
vnic type portbindings vnic normal
[ 0 ]
wrong logic messed up by trying to put clienthaslogcredentials last or trying to do pre check of local copies of uid here is accurate but does not place clienthaslogcredentials last if header id log id security cred uid aid system cred uid aid root clienthaslogcredentials cli android log security here is kiss accurate dropping pre check if header id log id security android log security clienthaslogcredentials cli
[ 0 ]
What I'm not a fan of is `expect(result).to.not.be.checked.in.a.ridiculous('manner')` :P:P
[ 1 ]
i think you do not need to store those mocks you do not use those db api m attrs later
[ 0 ]
could you move the mock execute code into setup function for example p mock patch object self driver execute self execute p start self addcleanup p stop self execute assert called
[ 0 ]
no longer a draft methings
[ 0 ]
use zuul refname this will not work with zuul ref anymore
[ 0 ]
if the function fails in the middle this will not get executed and the connection will be left open and you will not be able to drop a db etc
[ 0 ]
numa topology get numa topology
[ 0 ]
wow those getslice s are ugly
[ 0 ]
The only line unchanged, and, bizarrely, the one I dislike the most. This name is crap! Is it a bool, is it a table/object?
[ 1 ]
white space change should be reverted
[ 0 ]
please remove white spaces
[ 0 ]
you already have mongo conf group see you need to use mongo conf device path
[ 0 ]
> round down to the nearest nice boundary? I dunno \u2013 I quite like the ridiculous specificity of 51795.
[ 1 ]
this symlink can die now since portage overlay is gone
[ 0 ]
it might be ask a stupid question but what will be the value of these fields if we are not setting them
[ 0 ]
Shit. That's in the original code too!
[ 1 ]
~~Wacky. We literally test for this:~~ N/M. This is a different feature. I will fix :)
[ 1 ]
Damn it, forgot to change it. I'll update it
[ 1 ]
should this die if args are passed i imagine people running sanity test py help
[ 0 ]
Ugh, this is ugly...
[ 1 ]
host state fakes fakehoststate host compute should probably be moved to setup as it is the same for all tests
[ 0 ]
killing stdout makes sense but not stderr since that is only die output so drop the
[ 0 ]
How do I expunge the `xsnap-native` nonsense that somehow got sucked into this PR? Rebasing didn't seem to do the trick.
[ 1 ]
nit i do not believe bools need to be in quotes
[ 0 ]
please convert these tabs into spaces
[ 0 ]
Repositioning sucks though. You won't ever manage to make it smooth, especially on phones, tablets and older pcs. I wish it wasn't implemented on tooltip at all https://github.com/angular/material2/issues/3413 it lags even my new MBP / chrome.
[ 1 ]
ur all gay, ur website doxes minors dumbass its available to the public
[ 1 ]
version number directory needs to be removed
[ 0 ]
I think this is almost more hassle than the config flag is worth. Like this is some serious shitcode if you ask me
[ 1 ]
will we eventually kill self root helper from linuxinterfacedriver
[ 0 ]
i would prefer this call be squashed into the existing install opendaylight
[ 0 ]
``` >it's maker ``` @9600bauds wow wtf
[ 1 ]
didn't know that, kind of sucks. Done
[ 1 ]
These prefabs, I swear the positioning I didn t touch. At least they look the same in-game. I added reference to the new script so needed to commit these bastards.
[ 1 ]
You're god damn right
[ 1 ]
this 100% has given me huge shit before
[ 1 ]
do fire damage, fuck plasma flooding.
[ 1 ]
I think it is ridiculous that non gui tests use wx code. All gui tests were already removed, right?
[ 1 ]
or perhaps std string dummy if error out nullptr error out dummy cleans up this function but still preserves the semantics
[ 0 ]
why status running is considered as a valid abort
[ 0 ]
you need the colon reps
[ 0 ]
According to this, the loudness of 8x40mm ammo is around 733 units. That is ridiculous, the games "safe" measurement is ~ < 150 units.
[ 1 ]
nit useless empty line before
[ 0 ]
hmm we do not have rollback live migration at source here in driver but it looks like we will need because of this logic or we will not if others agree that we do not need to remove copy file but it is a garbage
[ 0 ]
again let us get rid of the gotos c provides tools that make them largely unnecessary
[ 0 ]
instead of wrap delimiter utils wrap delimiter should be used for all wrap delimiter calls below they should be replaced by utils wrap delimiter
[ 0 ]
I'm a sucker for passive voice. :stuck_out_tongue: I've included all your suggestions.
[ 1 ]
fuck, i'll fix it later
[ 1 ]
wtf did i just read xd
[ 1 ]
really dude i didnt even make this frickin proc,,,
[ 1 ]
I disagree, the spec seems to indicate that `0` is the preferred way to specify the invalid date. Which makes sense, it's Unix start minus 1. I'm not in favour of hacks to support Microsoft's abomination known as IE. It's dead anyways.
[ 1 ]
This is ridiculous haha. I cannot believe we are asking people to do this.
[ 1 ]
it is actually an oslo config configopts object or just say configopts for short
[ 0 ]
Kek why are you gay?
[ 1 ]
wow that is really stinky thanks lucas
[ 0 ]
agree that use conf ldap user dn key
[ 0 ]
yep this is just a puppet resource name and it does not affect anything since we pass actual backend name via name parameter historically it is named keystone public i think renaming it is out of scope of this bugfix
[ 0 ]
make sence to me i will collaps them into single method then
[ 0 ]
Ok, life is too short for this nonsense. If anyone wants to try and figure out how to make this work be my guest
[ 1 ]
Don't forget the brackets on this or BYOND gets pissy. Also, `C` doesn't appear to actually be used anywhere.
[ 1 ]
performance is 12? damn was just kinda a ballpark number honestly
[ 1 ]
this is an idiom that might not be understood by people whose english is not their first language
[ 0 ]
good question that was a real head scratcher for me it looks very specific so i did not want to change it even though i agree we should probably clean up on any exception sounds like both of you would be in favor of that change and me would make three so i will fix that up
[ 0 ]
maybe worth having a directory for drivers would be intersting to know what others think
[ 0 ]
It's a regex, 'fr' means either "freakin' ridiculous" or just "ridiculous" (the 'f' is often silent in acronyms...)
[ 1 ]
was expecting to also see a removal of bt bluedroid
[ 0 ]
nullptr
[ 0 ]
gross
[ 0 ]
looks like you removed the use of this so you can kill it
[ 0 ]
why the hell are you pinging me about this you did this
[ 1 ]
these commends do not add anything useful you can remove them
[ 0 ]
Yes, but I was distracted by a giant Pikachu plush toy being delivered to my son. It's truly ridiculous. This now merged.
[ 1 ]
@1akshitha is this fixed?
[ 1 ]
yea i agree this kinda stinks since it not consistent
[ 0 ]
seriously it being this stupid texttopath stuff was awful and super difficult to work with/around YOU HAVE THE VAR JUST MAKE THE VAR A TYPE YOU SHITLORD
[ 1 ]
remove all exra spaces
[ 0 ]
Oups. Sure. Damn it, I should have found a name starting with an `A`
[ 1 ]
why is this device target id
[ 0 ]
That is a wacky test case and I would hope it never comes up in real life. Does it, though?
[ 1 ]
there is already dummy dummy in this file do not add your
[ 0 ]
this has nothing to do with the threading it just tests if eof was reached in webm guess framerate then actual calls to webm read frame does not return eof as well
[ 0 ]
self region name region name
[ 0 ]
Do we transvestite Docker ? As you may notice through the reading of my articles, I am no Docker expert.
[ 1 ]
nit the line should end with a colon
[ 0 ]
nit maybe we can use with translate exception entries x if not entries x else x here
[ 0 ]
odd grammer remove semi colon
[ 0 ]
should this be a webcontentsobserver the webcontents could die between calling getwebapplicationinfo and ondidgetwebapplicationinfo
[ 0 ]