showvikdbz/code-reviews · Datasets at Hugging Face

text stringlengths 1 5.2k	labels listlengths 1 1
i can make this an int t	[ 0 ]
pehaps you ment migration prefix and not migration prefix	[ 0 ]
i still do not see how the boot loader will be written to mbr boot sector just creating the boot partition will definitely not help the same needs to cleaned up if boot mode changes from localboot to netboot or else the node may get into issues is specific to grub but similar approach will be applicable to other boot loaders too	[ 0 ]
if you are stubbing out os readlink it should work fine without proc	[ 0 ]
Damn. Good point. Will fix.	[ 1 ]
useless state	[ 0 ]
i have to agree mike none will do besides we all know he is limited by technology it s not like he is a mutant or something	[ 0 ]
run the following command to install virtualenv as install venv py is not packaged run tempest sh u not exist tests	[ 0 ]
You should do a pilot check - You don't want your passenger shooting shit.	[ 1 ]
How the hell is that possible?	[ 1 ]
i think you probably want return code vendor rc err	[ 0 ]
because i am stupid	[ 0 ]
well technically you CAN have datums in the world... as a subtype of atom (parent_type fuckery) so it still works anyway.	[ 1 ]
The fuck is this no wonder it lags Mekhi where did you copy this nonsense from, the grav anomaly or something?	[ 1 ]
first line needs to be removed	[ 0 ]
yes you should mock pkg resources get distribution	[ 0 ]
nit i think you can return false here and below then return true at last use self is valid self validate device then	[ 0 ]
you should set tidylib to none here	[ 0 ]
we should be using our official git mirror git openstgack org	[ 0 ]
That's the worst English I've ever heard :P, latest or newer just sounds bloody weird. Tt's Windows 10 21H2 (1809) as a minimum for Qt, not 1803	[ 1 ]
Oh my god at this line.....	[ 1 ]
this error would go away per above	[ 0 ]
maybe a dumb question but do we need portmap isn t this just s portmap port uuid port local link connection	[ 0 ]
nit include unordered map and we probably should just use std map	[ 0 ]
That's one weird crash. AudioChannel::clear() is very straightforward. Feels like we have some memory corruption, maybe of "index"... But when? This is while we are running the global constructors for the PPSSPP retroarch library. Wacky.	[ 1 ]
could we kill this line	[ 0 ]
get rid of this docstring	[ 0 ]
better to make these `20`, `10` etc rather than `2` or `1` so we can have some granularity without changing a bunch of other shit	[ 1 ]
why is not this a nearlabel	[ 0 ]
this sounds dumb to comment on but good note here saves someone later asking why the code was commented out instead of removed	[ 0 ]
this is a qualcomm driver pulled in with commit a d e a just a couple of days ago are you sure we want it disabled here	[ 0 ]
nah, to hell with these -1's \U0001f605	[ 1 ]
you can use cluster id self fuel web get last created cluster for this case	[ 0 ]
Ah fuck copypaste spotter	[ 1 ]
ah i did test both and both pass looking at the test of course if first is already false when we start the test we never set visible to false and of course commit will be executed fixed	[ 0 ]
so that's why those darn messages aren't working	[ 1 ]
I've run into this problem. What makes it more annoying is that washing an entire go bag before dissassembly requires something like 48 detergent to accomplish, aka nearly two and a half whole boxes. This seems a little ridiculous to me.	[ 1 ]
this comment need to be removed	[ 0 ]
dumb question don t we have these meters from the rate of change transformers in case of libvirt too	[ 0 ]
probably it will be better to call this run devstack or devstacking or something else then start because it will be terrible finish start devstack or start start devstack	[ 0 ]
good catch should be removed	[ 0 ]
This is disgusting.	[ 1 ]
if you add expect fork here you can add i to the minijail line below and save a pid	[ 0 ]
delete this block catch the condition at the bottom of the function	[ 0 ]
Indentation is messed up. Please fix.	[ 1 ]
i think you should also add a bullet that says improve test coverage	[ 0 ]
DAMN, I remember looking at this project around 2018 November even back then they mostly showcasing the vscode plugin in all their talks. Today as write it's June 2021, almost 3 years has passed and the vscode plugin is still under development and not yet released	[ 1 ]
fucks me up that patches are still pathed under /pill, thought for a minute that you would just pop the nicotine patches in your mouth	[ 1 ]
Why does everybody bother getting angry at that idiot who raised the "Santa issue"? He's just an imbecile that should have been ignored or banned for wasting developer's time. It's people from the VS Code team like @kieferrm (replying instantly with oh we are so sorry we hurt your feelings and we're gonna delete that immediately) and @egamma that are the real problem.	[ 1 ]
is there any benefit in having non integer scaling e g etc seems resize accepts any number of x y pixels below	[ 0 ]
One hit stunlock convert that isn't counter able is shit.	[ 1 ]
Here's a reason: The recipe for the rock pot was nonsense.	[ 1 ]
Oh WTF, how could I miss that - I guess I only looked for ``pure`` because that's the one that's actually useful 99% of the time. ``const`` is better but is rarely ever applicable.	[ 1 ]
ugh the nested if else and ifdef else are a time bomb please simplify after your change you do not need any if else if else at all you are always using net pipe init tcp	[ 0 ]
it should work i confirmed that the following command worked ipmitool v i lanplus h host l administrator u id p pw sol activate	[ 0 ]
bad rebase	[ 0 ]
ok i will do something ugly to let this pass then de ugly on the next patch	[ 0 ]
so all that we will actually need to do is add the securecontext annotation on securecontext interface worklet namespace css securecontext attribute worklet paintworklet	[ 0 ]
i think you want a here	[ 0 ]
yeah looks dumb fixed now	[ 0 ]
this about a eoghan glynn question here c gnocchi carbonara py personnally i m not sure that gnocchi should handle this case	[ 0 ]
We could but all the code that's doing isn't trying to grab anything from the dev lime, just grabbing internal shit that the latest released lime version should work with	[ 1 ]
Things are wacky with this change now.	[ 1 ]
should this be under the live tests section how does running this compare with running tpm utility test with use tpm	[ 0 ]
if we chroot ever this one will have to die but it is fine for now	[ 0 ]
aha stupid me i will use the structure directly thanks dale	[ 0 ]
Fine, embedding images inside GPX (some base64 encoded tag) is nonsense, I like your proposed solution!	[ 1 ]
is not it simpler to use self vpnservice with do delete false and catch webob exc httpclienterror	[ 0 ]
so stupid i forgot to do the most important thing	[ 0 ]
As a human, it sucks that I only have a UID to figure out which Subscription this is.	[ 1 ]
The fuck-up was that on line 37 I had defined the variable wrong. Now I think this part will work.	[ 1 ]
Damn, really appreciate the patience. Let me try that one more time.	[ 1 ]
and as i say that changes what the fuck timeticks to just be an alias	[ 0 ]
nit you are initialising this as an empty tuple not a list as the comment suggests the type should be	[ 0 ]
Yup, that's some ugly code alright.	[ 1 ]
instead it could be data template f for f in fields if f in template	[ 0 ]
should this be atomic uint t can we document the intended semantics my guess is can be updated and reliably read by exclusive owner and is read occasionally by other for logging purposes in the latter case the result is only a hint and may occasionally be garbage	[ 0 ]
still loving this table i am kicking myself for not cleaning this up ages ago	[ 0 ]
feels like splitting hairs the point is we have precedent for telling devs if you want to develop against this driver have the driver present locally	[ 0 ]
use restart service knot	[ 0 ]
I'm not sure what you're doing but I think you've fucked up the click chain really bad.	[ 1 ]
You've never heard of statitics?	[ 1 ]
okay i will remove the hardcoding internalurl	[ 0 ]
@DanmakuDan's repository is like a library of Cataclysm DDA through the ages, because he has been with us for that long. He does C++, he does tiles, he compiles, he is on the IRC, and he is a great guy.	[ 1 ]
Postpone it to a 5.0.0 Milestone is a real bad thing for me. At the moment a empty migration will generate 10k lines of rubbish. If i have a real migration with updated columns, data etc. it will be horrible to find these real changes an double check if they are correct. So why will it fixed that late?	[ 1 ]
i am fine pulling this bit out and moving it over to a different bug just shoot me the new bug id	[ 0 ]
bad rebase all around	[ 0 ]
Have you ever wanted to be a bootyborg, but without being a borg? Now you can! With feminine, masculine(femboy) and intersex shape opitions!	[ 1 ]
uh "maintainers may close this PR at will" is kinda harsh and could be abused. this system should really be 70% nagging and 30% actual consequences.	[ 1 ]
Whether you're talking rubbish or not, @dot-asm, shouldn't stop this PR, IMHO. Keep the discussion alive (perhaps by recording an issue) or propose a change (in another PR) that enhances the display of these messages (I have some ideas of a better display of mem dumps, so there will be another PR related to what has been discussed here). I'll approve this PR, but I want to see a rebase and successful build first.	[ 1 ]
it should be ram id instead of ramdisk id	[ 0 ]
what the hell is this, why have you put it in brackets??	[ 1 ]
dumb question what standard are we following for the language codes i notice this change adds zh cn and ko kr but the previous entries are ja instead of ja jp and es instead of es es	[ 0 ]
i would still request that you remove it i think it makes the api unnecessarily dirty	[ 0 ]
should this step add keepalived notifiers also be hold off until ex gw added for dvr ri keepalived manager is initialized by process ha router added above	[ 0 ]
Holy crap. ... it's OPTION3.	[ 1 ]
hvmap is a dict contains hypervisor object	[ 0 ]
Your branch is fucked up	[ 1 ]
this impost should be below	[ 0 ]
maybe in another cl i am also tempted of just deleting the if and putting a dcheck	[ 0 ]

i can make this an int t

[ 0 ]

pehaps you ment migration prefix and not migration prefix

[ 0 ]

i still do not see how the boot loader will be written to mbr boot sector just creating the boot partition will definitely not help the same needs to cleaned up if boot mode changes from localboot to netboot or else the node may get into issues is specific to grub but similar approach will be applicable to other boot loaders too

[ 0 ]

if you are stubbing out os readlink it should work fine without proc

[ 0 ]

Damn. Good point. Will fix.

[ 1 ]

useless state

[ 0 ]

i have to agree mike none will do besides we all know he is limited by technology it s not like he is a mutant or something

[ 0 ]

run the following command to install virtualenv as install venv py is not packaged run tempest sh u not exist tests

[ 0 ]

You should do a pilot check - You don't want your passenger shooting shit.

[ 1 ]

How the hell is that possible?

[ 1 ]

i think you probably want return code vendor rc err

[ 0 ]

because i am stupid

[ 0 ]

well technically you CAN have datums in the world... as a subtype of atom (parent_type fuckery) so it still works anyway.

[ 1 ]

The fuck is this no wonder it lags Mekhi where did you copy this nonsense from, the grav anomaly or something?

[ 1 ]

first line needs to be removed

[ 0 ]

yes you should mock pkg resources get distribution

[ 0 ]

nit i think you can return false here and below then return true at last use self is valid self validate device then

[ 0 ]

you should set tidylib to none here

[ 0 ]

we should be using our official git mirror git openstgack org

[ 0 ]

That's the worst English I've ever heard :P, latest or newer just sounds bloody weird. Tt's Windows 10 21H2 (1809) as a minimum for Qt, not 1803

[ 1 ]

Oh my god at this line.....

[ 1 ]

this error would go away per above

[ 0 ]

maybe a dumb question but do we need portmap isn t this just s portmap port uuid port local link connection

[ 0 ]

nit include unordered map and we probably should just use std map

[ 0 ]

That's one weird crash. AudioChannel::clear() is very straightforward. Feels like we have some memory corruption, maybe of "index"... But when? This is while we are running the global constructors for the PPSSPP retroarch library. Wacky.

[ 1 ]

could we kill this line

[ 0 ]

get rid of this docstring

[ 0 ]

better to make these `20`, `10` etc rather than `2` or `1` so we can have some granularity without changing a bunch of other shit

[ 1 ]

why is not this a nearlabel

[ 0 ]

this sounds dumb to comment on but good note here saves someone later asking why the code was commented out instead of removed

[ 0 ]

this is a qualcomm driver pulled in with commit a d e a just a couple of days ago are you sure we want it disabled here

[ 0 ]

nah, to hell with these -1's \U0001f605

[ 1 ]

you can use cluster id self fuel web get last created cluster for this case

[ 0 ]

Ah fuck copypaste spotter

[ 1 ]

ah i did test both and both pass looking at the test of course if first is already false when we start the test we never set visible to false and of course commit will be executed fixed

[ 0 ]

so that's why those darn messages aren't working

[ 1 ]

I've run into this problem. What makes it more annoying is that washing an entire go bag before dissassembly requires something like 48 detergent to accomplish, aka nearly two and a half whole boxes. This seems a little ridiculous to me.

[ 1 ]

this comment need to be removed

[ 0 ]

dumb question don t we have these meters from the rate of change transformers in case of libvirt too

[ 0 ]

probably it will be better to call this run devstack or devstacking or something else then start because it will be terrible finish start devstack or start start devstack

[ 0 ]

good catch should be removed

[ 0 ]

This is disgusting.

[ 1 ]

if you add expect fork here you can add i to the minijail line below and save a pid

[ 0 ]

delete this block catch the condition at the bottom of the function

[ 0 ]

Indentation is messed up. Please fix.

[ 1 ]

i think you should also add a bullet that says improve test coverage

[ 0 ]

DAMN, I remember looking at this project around **2018** November even back then they mostly showcasing the vscode plugin in all their talks. Today as write it's June 2021, almost 3 years has passed and the vscode plugin is still under development and not yet released

[ 1 ]

fucks me up that patches are still pathed under /pill, thought for a minute that you would just pop the nicotine patches in your mouth

[ 1 ]

Why does everybody bother getting angry at that idiot who raised the "Santa issue"? He's just an imbecile that should have been ignored or banned for wasting developer's time. It's people from the VS Code team like @kieferrm (replying instantly with oh we are so sorry we hurt your feelings and we're gonna delete that immediately) and @egamma that are the real problem.

[ 1 ]

is there any benefit in having non integer scaling e g etc seems resize accepts any number of x y pixels below

[ 0 ]

One hit stunlock convert that isn't counter able is shit.

[ 1 ]

Here's a reason: The recipe for the rock pot was nonsense.

[ 1 ]

Oh WTF, how could I miss that - I guess I only looked for ``pure`` because that's the one that's actually useful 99% of the time. ``const`` is better but is rarely ever applicable.

[ 1 ]

ugh the nested if else and ifdef else are a time bomb please simplify after your change you do not need any if else if else at all you are always using net pipe init tcp

[ 0 ]

it should work i confirmed that the following command worked ipmitool v i lanplus h host l administrator u id p pw sol activate

[ 0 ]

bad rebase

[ 0 ]

ok i will do something ugly to let this pass then de ugly on the next patch

[ 0 ]

so all that we will actually need to do is add the securecontext annotation on securecontext interface worklet namespace css securecontext attribute worklet paintworklet

[ 0 ]

i think you want a here

[ 0 ]

yeah looks dumb fixed now

[ 0 ]

this about a eoghan glynn question here c gnocchi carbonara py personnally i m not sure that gnocchi should handle this case

[ 0 ]

We could but all the code that's doing isn't trying to grab anything from the dev lime, just grabbing internal shit that the latest released lime version should work with

[ 1 ]

Things are wacky with this change now.

[ 1 ]

should this be under the live tests section how does running this compare with running tpm utility test with use tpm

[ 0 ]

if we chroot ever this one will have to die but it is fine for now

[ 0 ]

aha stupid me i will use the structure directly thanks dale

[ 0 ]

Fine, embedding images inside GPX (some base64 encoded tag) is nonsense, I like your proposed solution!

[ 1 ]

is not it simpler to use self vpnservice with do delete false and catch webob exc httpclienterror

[ 0 ]

so stupid i forgot to do the most important thing

[ 0 ]

As a human, it sucks that I only have a UID to figure out which Subscription this is.

[ 1 ]

The fuck-up was that on line 37 I had defined the variable wrong. Now I think this part will work.

[ 1 ]

Damn, really appreciate the patience. Let me try that one more time.

[ 1 ]

and as i say that changes what the fuck timeticks to just be an alias

[ 0 ]

nit you are initialising this as an empty tuple not a list as the comment suggests the type should be

[ 0 ]

Yup, that's some ugly code alright.

[ 1 ]

instead it could be data template f for f in fields if f in template

[ 0 ]

should this be atomic uint t can we document the intended semantics my guess is can be updated and reliably read by exclusive owner and is read occasionally by other for logging purposes in the latter case the result is only a hint and may occasionally be garbage

[ 0 ]

still loving this table i am kicking myself for not cleaning this up ages ago

[ 0 ]

feels like splitting hairs the point is we have precedent for telling devs if you want to develop against this driver have the driver present locally

[ 0 ]

use restart service knot

[ 0 ]

I'm not sure what you're doing but I think you've fucked up the click chain really bad.

[ 1 ]

You've never heard of statitics?

[ 1 ]

okay i will remove the hardcoding internalurl

[ 0 ]

@DanmakuDan's repository is like a library of Cataclysm DDA through the ages, because he has been with us for that long. He does C++, he does tiles, he compiles, he is on the IRC, and he is a great guy.

[ 1 ]

Postpone it to a 5.0.0 Milestone is a real bad thing for me. At the moment a empty migration will generate 10k lines of rubbish. If i have a real migration with updated columns, data etc. it will be horrible to find these real changes an double check if they are correct. So why will it fixed that late?

[ 1 ]

i am fine pulling this bit out and moving it over to a different bug just shoot me the new bug id

[ 0 ]

bad rebase all around

[ 0 ]

Have you ever wanted to be a bootyborg, but without being a borg? Now you can! With feminine, masculine(femboy) and intersex shape opitions!

[ 1 ]

uh "maintainers may close this PR at will" is kinda harsh and could be abused. this system should really be 70% nagging and 30% actual consequences.

[ 1 ]

Whether you're talking rubbish or not, @dot-asm, shouldn't stop this PR, IMHO. Keep the discussion alive (perhaps by recording an issue) or propose a change (in another PR) that enhances the display of these messages (I have some ideas of a better display of mem dumps, so there *will* be another PR related to what has been discussed here). I'll approve this PR, but I want to see a rebase and successful build first.

[ 1 ]

it should be ram id instead of ramdisk id

[ 0 ]

what the hell is this, why have you put it in brackets??

[ 1 ]

dumb question what standard are we following for the language codes i notice this change adds zh cn and ko kr but the previous entries are ja instead of ja jp and es instead of es es

[ 0 ]

i would still request that you remove it i think it makes the api unnecessarily dirty

[ 0 ]

should this step add keepalived notifiers also be hold off until ex gw added for dvr ri keepalived manager is initialized by process ha router added above

[ 0 ]

Holy crap. ... it's OPTION3.

[ 1 ]

hvmap is a dict contains hypervisor object

[ 0 ]

Your branch is fucked up

[ 1 ]

this impost should be below

[ 0 ]

maybe in another cl i am also tempted of just deleting the if and putting a dcheck

[ 0 ]