text
stringlengths 1
5.2k
| labels
listlengths 1
1
|
|---|---|
who deletes this object i think you need to make renderthreadimpl hold a std unique ptr to the filter
|
[
0
] |
lgtm small thing is the update and delete needed to finish the crud
|
[
0
] |
imo useless variable self xml header you already have the constant
|
[
0
] |
maybe a dumb question if the last button is the one about to request tab should not it be reverse to focus the status area or am i missing something
|
[
0
] |
~~How dare you remove his title from our Supreme Leader of the First Unfettered Order?~~
|
[
1
] |
i am still not entirely sure if i want to move this class s methods into daemon and have daemon implement suspender delegate directly or move all of the suspend related code from daemon into this inner class but having these methods make calls to single line methods in daemon feels silly so i am at least moving that code into this class
|
[
0
] |
if tenant id and c conf cisco n k restrict network profiles
|
[
0
] |
this should probably be false not sure we want to support the idea of uprevving chrome on manifestversionsynced code should also be calling the helper as well i e this stages implementation can be return false
|
[
0
] |
these assert messages are pretty unhelpful if you do not want to lose the messages consider freememory was negative freemomory totalmemory and totalmemory maxmemory
|
[
0
] |
drop the die calls
|
[
0
] |
That's weird, because the 5.2 manual explicitly states that here: https://www.lua.org/manual/5.2/manual.html#3.4.10 If it's crashing like that, there may be a deeper problem...
|
[
1
] |
pluggableprotectionprovider
|
[
0
] |
No fucking idea. It's one of those things that have already been there that I dared not to touch.
|
[
1
] |
we need to assign a pid for this product done it is x
|
[
0
] |
This implementation kind of sucks to be honest, this should just make it impossible to change the cards access with a helper method
|
[
1
] |
please remove the white spaces
|
[
0
] |
This is a fixed width integer type, it guarantees to be an unsigned integer of at least 64 bits. I guess I can replace it with `unsigned long long` but goddamn that is LONG LONG.
|
[
1
] |
let s remove find configs and use openstackconfigcollection fulter by
|
[
0
] |
@Fox-McCloud their shit is so wacked out i ain't touchin it
|
[
1
] |
Of course the EM field shouldn't be the fucking thing putting power in the grid then
|
[
1
] |
this kind of comment is useless because the code is so obvious
|
[
0
] |
whatever exception vcnsbadrequest or vcnsapiexception raised in vcns update ipsec config func i expect the except exception would lead to status to error and reraise the specific exception does it satisfy my logic and what is the cons if exceptions are too board
|
[
0
] |
available values should be slugs
|
[
0
] |
yes there is a bug here thank you will fix in the first place i do not understand why it is pop here instead of get stupid cosmic rays
|
[
0
] |
hang on limits h should define pagesize to page size and include asm page h and i cannot reproduce your compilation error myself can you elaborate
|
[
0
] |
Is this a new requirement ? Who did this come from ?
|
[
1
] |
@rgommers, do you think there is any chance they'd withdraw it completely (along with any of the others you'd consider nonsense)? Also, I don't know if there's any good way of finding where they're coming from, but I can do some asking around
|
[
1
] |
No idea what the hell this is trying to do here but it doesn't make any sense. If any of these cases ever trigger something has gone very wrong.
|
[
1
] |
remove the white space here
|
[
0
] |
sorry for maybe stupid question but are you co author of your patch or there are two different nate johnstons
|
[
0
] |
i would vote for instead of using glance urls to make a first version that puts it directly into swift with a configurable ttl defaulting to a few days in the message to ironic instead of using a glance url pass a swift temporary url to ironic then you do not need to tackle all of the complexities of garbage collection in glance just let swift manage it with a ttl in the long run the storage would need to be plug able for different deployments but swift seems like a reasonable first stab
|
[
0
] |
ldflags should always be before the objects and libs you should also add cflags while you are here cc cflags ldflags o obj cm libs
|
[
0
] |
mpaudiotrack should be initialized
|
[
0
] |
agree with brandon logan that these comments are redundant and add no meaningful value so should be removed
|
[
0
] |
replaced with normal toxin, shitter juice is boring anyway
|
[
1
] |
more idiomatic might be printf die config update failed ret but this is fine too submitting as is since it is just a cherry pick after all
|
[
0
] |
same here use cfg conf set override
|
[
0
] |
i will remove them
|
[
0
] |
The parent for destroy already does all this shit anyway, invisibility density whatnot I think
|
[
1
] |
why are we saying chef roles is enough to drive salt puppet or chef
|
[
0
] |
more than these roles you re using them pretty generically
|
[
0
] |
useless
|
[
0
] |
isn t the db set up such that these deletes are not necessary i guess it does not hurt to be explicit about it here the waitforserverdeletion is necessary so we may as well do that and an explicit db delete too
|
[
0
] |
Please ditch this comment, the grouping looks ugly in Doxygen.
|
[
1
] |
this class is useless
|
[
0
] |
this uuid needs to be inserted into neutron db in order to avoid conflict and it should be hided from cloud user
|
[
0
] |
comment is screwed up.
|
[
1
] |
yeah, this was my concern, I'm pretty sure there is nothing at the mob level that will be fucked up by having a zone_selected
|
[
1
] |
for radvd kill seems to be the way to go
|
[
0
] |
why you are wrapping dict agan in dict
|
[
0
] |
and need to handle situation when request contains incorrect body name or release id are missed name is incorrect value release id is incorrect value empty body
|
[
0
] |
ack
|
[
0
] |
Too gay, This shit is way too gay. Plz hetero-ize it
|
[
1
] |
There shouldn't be any, the parent is all the way down in /obj/item/Initialize() and it doesn't do anything funky, and neither does this proc really.
|
[
1
] |
odd run tests sh p n did not pick that up moved down two lines
|
[
0
] |
get this shit out of my codebase's commit logs
|
[
1
] |
>Note The layout is in t I'd remove that note. It's normal info that doesn't need note chrome. As in remove the chrome and remote the text. I'd remove note text when you don't need it. Sometimes it's clumsy without `Note: xyz bla bla`
|
[
1
] |
shouldn t this line be uncommented
|
[
0
] |
this docstring needs to be revised you can just say do nothing here
|
[
0
] |
this also computes and discards the block size padding and margin doesn t look too expensive so probably not worrying about but worth to keep in mind at least
|
[
0
] |
if you are going to use sets you should probably just go whole hog and do caps set above and caps add x below
|
[
0
] |
cleaner return as soon as know you have to return action flow tuples self action flow tuples if not action flow tuples return self action flow tuples
|
[
0
] |
classic' bloody mary cocktail Makes more sense as a naming scheme to me. https://www.thedailymeal.com/bloody-mary-has-real-blood-it-3614
|
[
1
] |
you right i just do not like unretained it looks like a bug i will follow you
|
[
0
] |
can t you do that in the initializers and avoid the std unique ptr
|
[
0
] |
should this be uknownformfieldtypeexception or unknownformfieldtypeexception
|
[
0
] |
where are you initializing self online controller
|
[
0
] |
should this be a bullet item too
|
[
0
] |
i am not sure about this i think we need to follow the existing style most of factory tests includiung factory touchpad here have imports on separate lines maybe tammo can confirm
|
[
0
] |
i think i like the idea and while you are at it try killing dbus c i suspect this should not be needed by libchromeos
|
[
0
] |
i will satisfy your thirst for pedantry in the method s docstring
|
[
0
] |
Why noise nonsense? Have you actually tried what it does? Guess not
|
[
1
] |
servicebad should be a uuid as well
|
[
0
] |
Honestly why the fuck are you placing random ass comments.
|
[
1
] |
I recall this had problems associated with it, by doing this, because areas are kinda screwy in how they behave.
|
[
1
] |
This PR is not about getting the country iso code 2. I'm very clumsy with github and I won't try to retrieve #772 now that my code is PR'ed.
|
[
1
] |
changing this would break the api we should catch the httpbadrequest in the shell py call and raise the right exception from there also tbh i do not really mind the error to be there this code as much as i hate it is short circuiting a check that should happen server side to begin with
|
[
0
] |
new ones are disgusting old ones were confusing we need even newer ones
|
[
1
] |
creating a new fake client splits the actual and expected values across two different files instead just mock out self scenario admin clients with a mock and check for return values as appropriate that s what you will need to do once c merges anyway that will also let you get rid of all of the code you added in fakes py
|
[
0
] |
nit throw a fake network id or port id in here since that is what our api would provide as noted above
|
[
0
] |
Yea, I'd prefer recoding it. The current implementation was hot garbage.
|
[
1
] |
use mock engine return value run side effect
|
[
0
] |
Ah geez, really? Damn, sorry about that. One of these days I'll find time and look at that mess. I thought caught everything.
|
[
1
] |
i disagree the main problem here is that i am calling do node clean instead of do next clean step in continue node clean do node clean should be a one time shot per delete like tear down
|
[
0
] |
unique shit that may get you a life sentence for stealing it
|
[
1
] |
captitalize failed to execute hash grep curl tr s t cut d f or something like that
|
[
0
] |
remove nginx should be deleted
|
[
0
] |
you already have the instance so you do not need the instance uuid you do instance instance
|
[
0
] |
why is this change required eject virtual media ejects all the media that are inserted if only floppy is inserted it would skip cdrom and eject the floppy
|
[
0
] |
done who needs trybots when you are the eagle eyed reviewer
|
[
0
] |
ye you gave me shit for it in my stream so I thought you actually wanted me to take it out lol. a temp doesnt work
|
[
1
] |
nit not my codebase but it seems unusual that a getter function has side effects like this
|
[
0
] |
i think the default value should be an empty object
|
[
0
] |
this todo which says whitelisted extension id will be deprecated seems to be obsolete given your comments in do you think we can remove this as well
|
[
0
] |
Yeah, that's disgusting, but we are in a case where the repository is shared among two entities. I prefer doing that instead of duplicating the repository into two: here we should not have an entity at all.
|
[
1
] |
LMAO I'm so good fuck
|
[
1
] |
this comment is not really enough to explain why this is being done or at least it is late enough in the day and i am stupid enough to not get it
|
[
0
] |
please use here self resource def
|
[
0
] |
Any updates? This is a ridiculous memory leak, especially for a coin of this magnitude. I'm running geth on a dedicated server and it ended up eating 50GB of RAM. 
|
[
1
] |
Would rename to `mapHasHitsounds` to clarify intent. As is the `hasHitsound(hitObject) || (isLastObject && hasHitsounds)` check lower down reads a touch weird.
|
[
1
] |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.