text
stringlengths 1
5.2k
| labels
listlengths 1
1
|
|---|---|
I did it this way because it's stored and used by `FilterCriteria`, and having that store a "MenuItem" sounds even weirder imo.
|
[
1
] |
i think the follows willonce in mocks usually
|
[
0
] |
close i do not think projectspec is the right place i think keeping that dumb parsing based only on the schema is good this is yet another thing that i think would do well in a project class i think we have talked before about this a class that wraps the schema commands so the commands could basically do p project p buildimage etc for now i would lean towards getting it in but if we want to start that refactor now we could
|
[
0
] |
the hell of copy/paste
|
[
1
] |
i would prefer that the implementation of dvmcompilercacheflush was a nop than ifde fuck around the callers
|
[
0
] |
Yuck. :D Clippy and I disagree about this.
|
[
1
] |
oh damn. my bad. :disappointed:
|
[
1
] |
should eth be a replacable too
|
[
0
] |
this is not correct you should return true false if the function worked and set a the a bool is mtd argument with the result this hides errors
|
[
0
] |
Indentation's pretty messed up.
|
[
1
] |
add blank line after
|
[
0
] |
as i said dumb question i assume i was just too blind to see it
|
[
0
] |
is eligible agent is staticmethod should call by as db agentschedulerdbmixin is eligible agent
|
[
0
] |
calls for other mocks
|
[
0
] |
de gustibus non est disputandum
|
[
0
] |
should this be admin password same below
|
[
0
] |
nit removal of newline here is an unrelated change
|
[
0
] |
i am not agree with using db queries directly in api all operations with models should be incapsulated in objects
|
[
0
] |
dude self stub out
|
[
0
] |
this is useless if you use a boolean
|
[
0
] |
you re totally right that was dumb of me not to catch fixed
|
[
0
] |
crap. wish i saw this before.
|
[
1
] |
that reminds me i can never remember if i or you added support for view class com example myapp innerclass i used to find inner classes for custom views rather silly but with fragments it makes sense to do it that way
|
[
0
] |
wonder if it should be gateway fixed ps ip address
|
[
0
] |
these warnings are totally useless and are not doing what the author thought they would sigh
|
[
0
] |
combine with prior statement and kill extranaeous empty line
|
[
0
] |
This is ridiculous if true... :(
|
[
1
] |
Sigh... that was copy paste nonsense.
|
[
1
] |
can you reword this a little also the bug report itself is a little confusing
|
[
0
] |
apologies is this has been clarified in previous review cycles what would be the rational of this unusual approach to inheritance is that because you need to cherry pick only specific capabilities of the base class whereas in all the other case you would be ok with the dynamically built base classes
|
[
0
] |
not actually sure this is useful under what scenario would a developer not want to stop mock patchers on teardown
|
[
0
] |
needs die
|
[
0
] |
remove this comment the dumb buffers need not be aligned for mali since they are not written to by the gpu in fact the dumb buffers like the fbdev buffer need not be aligned at all unless the vop requires it
|
[
0
] |
that's not gramatically correct now dip ass, it should say role, mob or feature
|
[
1
] |
I get that nu-pAI is your baby, Kev, but for christ sake they SUCK dude.
|
[
1
] |
Hahaha I haven't heard the word PEMDAS since 7th grade! Please excuse my dear Aunt Sally!
|
[
1
] |
garbage collected
|
[
0
] |
always inline or trust the compiler inline is mostly meaningless
|
[
0
] |
I know it does not make sense. It is just ridiculously slow on Falcon with 4*36 processors. (I did not verify if number of processors can affect the time.)
|
[
1
] |
I've read the doc and liked what I read. This is just too good to be true seeing it in action. Bless you Deity.
|
[
1
] |
nit nullptr abortsignal
|
[
0
] |
how about this ugly construct while value check for power on event
|
[
0
] |
Clockcult 8? Holy shit.
|
[
1
] |
obviously you will want to erify that a call to objects computenode create inventory is called when the version is
|
[
0
] |
it should be added to both dumpers dumper and cdumper because there is not knowledge about what dumb er will be used in client code
|
[
0
] |
this notificationtimer null
|
[
0
] |
You dont have linux version. this discrimination. faggot
|
[
1
] |
i am not sure why you need to mock get location i do not even know what calls it
|
[
0
] |
oh i didnt reload the page shit
|
[
1
] |
please remove those white spaces
|
[
0
] |
fk to portprofile profile id
|
[
0
] |
since this is being added to opt kolla you can add after config external sh below
|
[
0
] |
Damn that is ugly haha! I didn't think of that ...
|
[
1
] |
"Finally, some good fucking fish."
|
[
1
] |
Yeah. This sucks. So much for me creating a modal (pop up) for records on the fly with js. Looks like I'll just have to have a modal for every record already on the page. It just makes the source code ugly and will make the page take longer to load for the user. Not a big deal. I forgot that assets are compiled.
|
[
1
] |
use ha queues if you change this option you must wipe the xx database
|
[
0
] |
in fact port list uuid should be empty
|
[
0
] |
nit you may use show resource here
|
[
0
] |
callbacks need to be removed in ondetachedfromwindow
|
[
0
] |
you better dcheck that global log lux has the right size first
|
[
0
] |
should be nullable false as in migration
|
[
0
] |
not sure how complicated it is to write unit tests with a mocked newblue but beware that over mocking could lead to unmaintainable code so you may sometimes want a fake or stub implementation over mocks
|
[
0
] |
massive slap on the wrist why are you inheriting from the neutrondbpluginv plugin i can understand why but you are better off just duplicating the logic or rewriting the logic yourself
|
[
0
] |
+1 because it is ridiculous to have to solve this with CSS
|
[
1
] |
owner id is the parent stack id is there user case for filter this
|
[
0
] |
noqa should be removed
|
[
0
] |
nit swap method order it s show then hide in the declarations and other spots above
|
[
0
] |
d oh in my head i was thinking it s best if this file remains correct but then it does not make a difference whether or not icu is in the list of shared libraries how stupid of me i will remove it
|
[
0
] |
Please provide complete minimal reproducer including input data. BTW, Avoid posting text information through screenshots - it is ridiculous.
|
[
1
] |
@NTaylorMullen the issue here is this and below: > However, Blazor .razor designer is blissfully unaware of this mindfuckery, so it happily highlights <FluentValidation.FluentValidator> in the VS IDE without squiggly reds.
|
[
1
] |
please remove indention of commit message
|
[
0
] |
no i am just an idiot i shall fix
|
[
0
] |
remove i n
|
[
0
] |
i made my own because android util mutableboolean is deprecated in p if you have any ideas for a similarly concise but less ugly way of letting tests know whether the loader decided to request a new seed umm i suppose you can subclass callbackhelper and pass whatever data you want from it i tried a few things but i will keep it as is if you do not object conceptually i want a future boolean testloaderresult object for which i can set the boolean value without unblocking the test thread in requestseedfromservice and then unblock it later in onbackgroundworkfinished basing such on object on callbackhelper might not be any better than what i have now i cannot explicitly protect the derived class boolean with callbackhelper s internal lock so the boolean field would need to be handled just as carefully as mutableboolean currently is basing the object on futuretask is confusing because the runnable callable has nothing to do i could use completablefuture or blockingqueue like a go channel but those makes it difficult to separate setting the boolean from unblocking the test thread
|
[
0
] |
Wacky. I repro this, but cannot explain it either. Will have to debug through.
|
[
1
] |
nit dying die
|
[
0
] |
but i will make this change right now so this at least still compiles for other lp architectures even if it rejects every elf file at runtime because it is ignorant of their relocation types
|
[
0
] |
keystone public port
|
[
0
] |
please learn a little of english language before using on top of that please learn a little of python before commiting the patches overall this docstring is bad and you should feel bad learning why this is a bad docstring is left for you as an exercise
|
[
0
] |
@axic Damn, too late :-).
|
[
1
] |
maybe a stupid question why are not you not using the decorator instead of the contextmanager given the current with statement encompasses all the method edit doh nevermind just saw good dan s point in ps
|
[
0
] |
okay i will nuke the fixme then
|
[
0
] |
I have to know who spelled it like this now. Sure I can't spell worth a damn either without spellcheck half the time but really. Who did this?
|
[
1
] |
> If you want to hide all buttons, just hide the toolbar completely (like done in modals). The new button is redundant anyway The tool bar looks crap without a New button and just nothing. I did consider hiding the whole tool bar. > If you add more to this PR, chances get lower that it gets merged soon. The more is in it, the more work is it to test and review. All the other changes are in a different PR - this PR is done and I plan no more changes here.
|
[
1
] |
this should probably be lower cased rbac policy
|
[
0
] |
can you verify this against the ri i am curious whether this is a hard runtime failure or should be thrown at the point of the invoke so e g verify error no class
|
[
0
] |
afaiu this should be removed as well here and in l settings additional components mongo value false
|
[
0
] |
damn, it didn't wrote the ~
|
[
1
] |
Yeah fuck off with that shit comments are for readability
|
[
1
] |
I bet your editor messed with this. :eyes:
|
[
1
] |
I have heard from Fedora contributor that he would be interested with packaging OBS for Fedora if it was Bootstrap, because Fedora uses Bootstrap a lot too (they are terrible at it, but they try their best I hope).
|
[
1
] |
But only for users all other items mentioned have more than one of them. This is a ridiculous amount of time being wasted over semantics. The brackets for languages should stay as it is correct in the context.
|
[
1
] |
zull zuul
|
[
0
] |
please get rid of warnings by storing gmc getinvokedexpression into a variable
|
[
0
] |
nit probably cleaner to return if allocation base is nullptr
|
[
0
] |
hmm would it be more clear if we renamed these decorators async passthru and sync passthru
|
[
0
] |
here s your pep error trailing whitespace
|
[
0
] |
might want to use reverse true here if the highest priority step needs to be executed first
|
[
0
] |
use self addcleanup client delete keypair keypair name delete params instead this would solve the concerns of the reviewers and kill some useless code
|
[
0
] |
nit alignment here is off project id should be lined up with nova fixtures above
|
[
0
] |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.