text
stringlengths 1
5.2k
| labels
listlengths 1
1
|
|---|---|
What the fuck is a typecache
|
[
1
] |
This `if` statement is now ridiculous :-) (and comment needs an update)
|
[
1
] |
Patching generated files (configure, config.h.in) seems awfully stupid anyway. This _has_ to break on every update!
|
[
1
] |
can sfc have a colon like everybody else
|
[
0
] |
i think the rockchip configure pd cnt should put in probe
|
[
0
] |
Damn, I did it again
|
[
1
] |
ah i did not know they are global thanks for the comment i better go and educate myself on stevedore before making silly comments
|
[
0
] |
again i am asking why ambari needs them and if it really needs them why the ambari rpms are not requiring it otherwise this patch seems just a workaround
|
[
0
] |
Fuck off you can see the \ right there
|
[
1
] |
tiny nit would rather have do soft delete on this line and just have the args start on the next line same for all of these reformattings
|
[
0
] |
it should be final allowed hosts please also add secure cookies false
|
[
0
] |
synchronize sesison false passed to delete should make the operation faster
|
[
0
] |
and to be honest I don't have time to test this crap all over again
|
[
1
] |
eliminate backslash
|
[
0
] |
it should be volumemetadataresponseparameters instead of volumemeatadataresponseparameters
|
[
0
] |
complain very loudly if this happens this file is machine generated and lives on a read only partition so if it is malformed then something terrible has happened
|
[
0
] |
Definitely. BTW at one point I tried to change this to the tier enum from the API, but it is *wacky* and does not line up with the words you'd actually use. We should probably create our own that lines up in value but not in name.
|
[
1
] |
useless braces
|
[
0
] |
these have the same problem as the parent review asserttrue asserts that the expression token is true and will only use the matcher as an error message if the assertion is false
|
[
0
] |
numa topology get numa topology
|
[
0
] |
perhaps a stupid question but what would the type of that pointer be afaict tasks init is an array of an unnamed struct i guess i was also assuming that the compiler would take care of this
|
[
0
] |
cheater fix it in the previous patch p
|
[
0
] |
Oh shit... thats a really back omission from #17503!
|
[
1
] |
last collection is next collection collection rate remove
|
[
0
] |
This is ridiculous, Framework 4.6.1 is not still supported by VSTest..what's the reason for it?
|
[
1
] |
Oh fuck it does 200 stamina damage if the drain is interrupted. Doesn't that just crush all your limbs?
|
[
1
] |
Ugh... wow... yeah, this is a doosey... I will see what I can dig into, but man this sucks... Good find, but not sure what a solution could be off hand. Will have to do some digging today to look into it.
|
[
1
] |
Blm femboy florida inc
|
[
1
] |
Oh weird I must have screwed this up when rebasing. Fix coming up!
|
[
1
] |
minor nit subnet misspelt
|
[
0
] |
this comment needs to be deleted apparently yuan forgot to kill it in change i f ea ef effae ec f e cd c i noticed that this patch does changes to the moved code so it is appropriate i think
|
[
0
] |
if you wanted to die you could just remove the ttyless sudo logic altogether and it will die below at the tty tickets must be disabled line if the user is on a machine with a broken sudo that does not support ttyless sudo tickets that s actually quite a reasonable suggestion note that cros sdk does not use the sudo keepalive daemon anymore so none of this discussion actually impacts cros sdk
|
[
0
] |
this comment is useless
|
[
0
] |
hmm these are basically cros workon localname if you walked that array it would be one less place to keep up to date you would have to add dummy stubs for common mk but i think that is an ok trade off similar statement for doing a loop in src test or add a multiplexer func platform multiplex local phase local out platform out local pkg for pkg in cros workon localname do platform phase pkg done then you can do src test platform multiplex test src install use platform platform multiplex install
|
[
0
] |
damn, today my mind is a vegetable, of course!
|
[
1
] |
I would personally expect this to be affected by the exact same option that covers switch statements. Having something called 'array_initializers' have an effect on switch expressions just seems super wacky
|
[
1
] |
these joins are crazy but that is the nature of the problem we are trying to solve no way around it we just need to test it heavily
|
[
0
] |
you can eliminate the migration variable entirely right try objects migration get by instance and status context elevated instance uuid status group hosts add migration source compute except exception migrationnotfoundbystatus pass
|
[
0
] |
sal info vbahelper ret is x std hex pret
|
[
0
] |
all this init are not needed anymore the base class takes kwargs
|
[
0
] |
Fucking operator spacing all over this file
|
[
1
] |
invalid indents you should put white spaces
|
[
0
] |
debug shit, will remove
|
[
1
] |
done created the coveragepattern class that contain both java lang string and java util regex pattern objects
|
[
0
] |
My experience with errorprone from Java repo is very negative. I hope it will not became such an annoying asshole as it is over there.
|
[
1
] |
gzip should be configurable
|
[
0
] |
it s so unrelated i would not use it we do not have a bug for kill all the nibs
|
[
0
] |
this previously used a testnavigationobserver but this no longer works for the filesystem url following mustafa s r because a top level filesystem url navigation will be blocked on the renderer side i wanted to keep this test uniformly handling both blob and filesystem urls so i tried to use waitforloadstop which just exits immediately if a navigation has not started yet however with blob urls that still did not work because that navigation is scheduled on the renderer side so the executescript that sets location above returns before we have received the beginnavigation from the renderer hence this ugly extra dummy executescript without it we performed the checks below too early and when gettextcontent below did a roundtrip to the renderer we actually received the beginnavigation and created a speculative rfh which caused getrenderframehostsforextension to fail alternatively i could wait for filesystem urls to fail with a console error similar to what mustafa did on line separately in light of mustafa s change once we are certain that it sticks we might want to kill the renderer if it actually sends us a beginnavigation with a top level filesystem url to handle the compromised renderer case and add a separate test for that
|
[
0
] |
m best place would be in ext create fs aux info to put this into aux info but then we have to deal with ext parse sb info
|
[
0
] |
you re overwriting w again after this without using it
|
[
0
] |
minor nit i dislike backslashes here and prefer to indent differently like that passes num projects max projects or project id in host state projects
|
[
0
] |
no need for that basetestcase resets all mocks
|
[
0
] |
Darn editors and auto-formatting
|
[
1
] |
As nice as that would be, we risk fucking with the docking port if we do that.
|
[
1
] |
yes we need exactly slaves
|
[
0
] |
actually shit I have no idea how this'll interact with eshields as they don't have a direction other than just the person's direction, use the double reflector code i guess.
|
[
1
] |
I'm guessing you don't need it any more, but since this issue came up in admins chat, I shared the rubbish bash script I wrote for the same bullet point: https://github.com/usegalaxy-eu/shared-data/blob/master/run.sh#L12-L26
|
[
1
] |
suggest making these public final and getting rid of the getters
|
[
0
] |
please remove indention of commit message
|
[
0
] |
This is getting quite ridiculous. Other than that, I'd suggest just merging those resolutions into a "custom" item, and have the value configurable in discrete steps as a wxSlider.
|
[
1
] |
gosh damn it, Bay. `loc.loc`
|
[
1
] |
is it suppose to be param req get param
|
[
0
] |
Just saying the static sound is pretty cool, and could sit as its own rare weird hallucination
|
[
1
] |
That's weird. Changelings are still one being, just with multiple faces. I guess they do get some of the previous memories of the person they suck. I must be missing something about changelings
|
[
1
] |
shit, that's flawed indeed
|
[
1
] |
silly typo i can fix that with an additional patch for the next stage of the arp fix
|
[
0
] |
retrievable
|
[
0
] |
oh crap thanks didn't see it! DUH! will change and commit in a while.
|
[
1
] |
gross
|
[
0
] |
killed the change with headshot
|
[
0
] |
fix comment style here and else where notifies
|
[
0
] |
consider typedef std vector uint t bytebuffer
|
[
0
] |
Focus on #8909 folks, this is ridiculous
|
[
1
] |
remove this useless line please
|
[
0
] |
fuck me.. lol, thank you for the catch
|
[
1
] |
or maybe put this text or appropriately edited close to bootstrap ansible sh message here above
|
[
0
] |
server name share server get backend details get share server name
|
[
0
] |
lol this one always made me sad i guess it is making similar behavior as the jsonutils one but man it feels slightly um stupid to do this for lack of better word
|
[
0
] |
again kill this
|
[
0
] |
You still have fucked up line endings
|
[
1
] |
imo new line with a backslash should be removed
|
[
0
] |
nit might be marginally more performant to do my pids extend get my pids if pid in my pids
|
[
0
] |
damn conflicts, and damn prisas, thanks!
|
[
1
] |
oops this should be removed
|
[
0
] |
use ssl hash public ssl hash service name service type resource type default value args fail if args length
|
[
0
] |
please do not mix whiteshapce and functional changes this newline is not necessary here
|
[
0
] |
add an ampersand so that the hyperlinking works e g rsparallelfor
|
[
0
] |
damn, thought I did that
|
[
1
] |
God I'm actually fucking blind: its `target.visible_message` not `user.visible_message`. Ignore me.
|
[
1
] |
What's your source for this? Anything less than 6 ingame sucks as much as improvised firearms.
|
[
1
] |
these all sound like they should be configurable set in wf config py
|
[
0
] |
how are you marking the release configs other than link release as important e g duck canary for example
|
[
0
] |
afaict git r cannot be used yet because it has depend dev vcs git but portage stable currently has dev vcs git git r ebuild
|
[
0
] |
sure however this slot cannot be arbitrarily reused since the key enums must be sequential
|
[
0
] |
for readability please have one blank on each side of the assignment operator i know there is already code that does not do so but it is ugly to read
|
[
0
] |
Damn. In the `swingset-runner` package with the modification shown above, `yarn lint` doesn't complain. It looks like it is only doing an eslint check, not a ts check. I only know about the typing problem because of vscode. This of course means it is missed in CI as well.
|
[
1
] |
yeah i has a dumb i somehow thought that this object was returned from the aggregate lookup and was being updated
|
[
0
] |
useless cachedir variable
|
[
0
] |
this test is useless sorry you should check that apply all tasks makes a proper exception handling before reraising e q check that error was logged
|
[
0
] |
Personally, I only generate a huge PNG for 400% DPI and let the system downscale for the rest, because otherwise those assets are 90% of my package size, which is plain ridiculous.
|
[
1
] |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.