showvikdbz/code-reviews · Datasets at Hugging Face

text stringlengths 1 5.2k	labels listlengths 1 1
> Does the tank being decoupled mean no more stuff like N2O throwers? If so, that is sucky. the original code only vented plasma anyway.	[ 1 ]
WHY DO MINERAL TURFS HAVE A CHECK THAT LETS SIMPLE MOBS KNOCK WALLS DOWN WHY DOES NOTHING USE THIS WHAT THE HELL	[ 1 ]
dumb question cipd server verifies that the instance s package inside it is manifest actually matches right i assume yes	[ 0 ]
I left some crap in your code	[ 1 ]
these are odd and useless but our code formatting tool seems to require it as soon as there are too many members	[ 0 ]
Damn, your binary doesn't work either. Now I'm really confused. Is my test setup flawed at the beginning? D:	[ 1 ]
all your class methods should be staticmethod	[ 0 ]
I'm in favor of splitting things up more or maybe going to @iwubcode's solution because things are getting a ridiculous in all senses. On my old laptop, I can't fit any of the windows.	[ 1 ]
stupid nit could you please add a longer description of why we are removing this	[ 0 ]
btw the ids starting with i are change ids you see in commit messages identifiers of changes within gerrit the real git commit ids are the ones you get when browsing git log prefixed with commit	[ 0 ]
silly me ordering is not important here since we are in a firewall defer apply block where the filter defer apply off will call in iptables firewall setup chains apply setup chain etc doing update ipset members and generate ipset rule args later on	[ 0 ]
shouldn t these mocks live up in test check can live migrate destination if do raise is true	[ 0 ]
whoops this is junk that i missed if we re not doing authenticated encryption then we do not need to choose an authentication function at all i am just going to take this line out	[ 0 ]
done v lol drive by	[ 0 ]
Whoa, that's goofy :)	[ 1 ]
my apologies for these silly errors	[ 0 ]
also do the equivalent check on e g path with dots	[ 0 ]
wow kwargs	[ 0 ]
> bit.ly links expire? Yuck. URL shorteners are such nonsense. Agreed on the nonsense. And unclear why the links now just return a 404. I believe they were still returning redirects a few days ago but what do I know about bit.ly operations...	[ 1 ]
this is a django setting it belongs in the next section	[ 0 ]
it seems that this lswitches is not being used	[ 0 ]
Why the fuck did i use and xD	[ 1 ]
host should be dest it is easy to predict so you do not need to use mock any here	[ 0 ]
blerg not sure i must have done some sort of copy and paste idiocy from a different commit version fixed this and the other instance i found of the same thing	[ 0 ]
see it was a dumb question cl description answered it	[ 0 ]
yes i hate this bit docs url would be much nicer imho but not in this cl	[ 0 ]
this is probably dumb but what do you regard as onboarding	[ 0 ]
I'm sure it's helpful. That doesn't change the fact that ten zombies committing ritual suicide on a rosebush is A: ridiculous and B: very much not intended behavior.	[ 1 ]
nit i think that we can kill everything after the comma now	[ 0 ]
it should be portpair destroy then a method name starts with a dot	[ 0 ]
typo s instance get by uui instance get by uuid	[ 0 ]
Fixed. Now resHit is a standard boolean with {0; 1} value.	[ 1 ]
use integerpropertyid to be able to change the value do the modification only if the decision to merge the approach is given	[ 0 ]
kill it and find out or did you want to do that in a later patch instead	[ 0 ]
silly typo	[ 0 ]
Oops, brain fart. Thanks for the catch!	[ 1 ]
ur a faggot XD	[ 1 ]
i would agree that a log warning should be thrown here	[ 0 ]
d oh that is awful english on my part fixing	[ 0 ]
This is also default item throwforce also it's a damn cheese wheel give it some HEFT	[ 1 ]
@tgstation/commit-access What is the final decision on this? Feels weird having reference to someone who was never part of our community and I feel like an asshole for saying it	[ 1 ]
on the existing servers with given credentials i think that it makes sense to show how to pass loclarc args otherwise this tutorial is useless	[ 0 ]
please remove backslashes where possible	[ 0 ]
stats nullptr	[ 0 ]
i think these two are simple enough and not re useable that they should be in lined into emit done signal	[ 0 ]
As long as Exited still gets called it should be fine. Still pretty crap it doesn't call the parent.	[ 1 ]
oh yes in the dicts below filter and raw can share the same mock object so v raw inst and v raw inst are useless i have removed them in the next patch	[ 0 ]
well shit. Guess it has to be "their" then.	[ 1 ]
that was supposed to be minutes but i am an idiot	[ 0 ]
I know, but gee give it a typepath like "wheelchair" or some shit.	[ 1 ]
nice catch some of checks are useless now since we do not create an instance of dynamicmodulecoordinator if we do not have correct intent to load a module	[ 0 ]
i agree those lines should be removed	[ 0 ]
I don't know shit about JS tbh, but couldn't this be a regex search? That way you don't need to exactly type the starting characters of your search.	[ 1 ]
The compiler sucks, then. `NOT_NULL(orb)` should shut it up, or `assume(orb != NULL);` before the return statement.	[ 1 ]
should we remove detectvalueboundfromvalue and inline the code here seems like valuebound create and valuebound detectvalueboundfromvalue are redundant	[ 0 ]
bordertype cv	[ 0 ]
this block should go after the mms entry below	[ 0 ]
remove self from here	[ 0 ]
Damn this formatting looks ugly :D	[ 1 ]
Whoops, I missed that	[ 1 ]
please do not use a normal space u but a no break space u a instead	[ 0 ]
why do not you use your system shell execute function to execute this and similar below	[ 0 ]
also test your damn code, this would make the singulo permanently impossible to posses, since it still has this flag	[ 1 ]
i think it is better to remove the here	[ 0 ]
assume i do neutron create net foo neutron create port foo get hold of port id neutron trunk create parent port id nova boot nic port id port id the question to answer is this would a trunk without subports function correctly i would think so as a guest i should be able to have my interface connection on my foo network just like any other regular port is it useful probably not as you would expect the the user to go and add subports later on so the other question is do we want to allow for a successful boot off a trunk with at least one subport if so then we should probably fail the binding process rather than hitting the agent	[ 0 ]
note this exec is not idempotent and it will execute dbsync for each puppet run on the undercloud is it expected	[ 0 ]
wanted to share it for the trusts tables so this refactoring is timely	[ 0 ]
Notable stupid shit found in blob_act() See above comment.	[ 1 ]
FWIW, this does ridiculously stupid things when combined with `pitch`, I gave up updating the vector tile fixtures in [mapbox-gl-test-suite](https://github.com/mapbox/mapbox-gl-test-suite) at that point.	[ 1 ]
this could also go into the common method	[ 0 ]
"Boss makes a dollar, you make a dime, so don't fucking ghost on company time."	[ 1 ]
useless var	[ 0 ]
that's kind of dumb i think i'd be pissed if I rolled catgrill skeleton when I could of rolled roman skeleton, since catgrill doesn't have any combat tools or armor	[ 1 ]
you can use wait true istead such hacks	[ 0 ]
why do not you initialize weak ptr factory as weak ptr factory this in the header file and remove this duplication from both constructors	[ 0 ]
nit insert step restart swift proxy server i knew to but noobs may forget could also be useful at this point to do a swift a u test tester k testing info to check two policies are reported in info	[ 0 ]
list of what public key ids list of strings i really think this attribute should be removed in favor of just including a link to the child collection instead	[ 0 ]
this should be marked for translation	[ 0 ]
I'm assuming it does, since this is what was used before. If it doesnt, then someone else fucked up and it hasn't really been an issue that anyone noticed. ever.	[ 1 ]
personally i do not think specifies is useful at all you can just put the interface type of disk	[ 0 ]
> But if they don't spawn some shitter can just take all glass from protolathe and vanish it in the void. Exactly, these are the consequences.	[ 1 ]
i think the deps are useless they are the same has the global testenv	[ 0 ]
remove i n	[ 0 ]
i could leave this test in general and just abort on unexpected libart	[ 0 ]
as per ie d affc d b cf ef a and i a e f cf c f a b f i believe self header is useless now	[ 0 ]
i m sorry if that is a dumb comment i wonder whether those really belong here should they be maintained in service repos instead	[ 0 ]
see dictionaries lists this one is preffered better to change all other	[ 0 ]
yes it is foolishly uploaded assuming i could make such a trivial change correctly ps is incoming	[ 0 ]
mock clients return value environment	[ 0 ]
i am ok with removing the die functions in a different cl	[ 0 ]
`suck as => such` as LOL	[ 1 ]
This is purely for human readability. If it's getting to ridiculous, it could be shortened.	[ 1 ]
could you remove these whitespaces	[ 0 ]
calling `Destroy` directly is something you should *never* do under any circumstances *ever*. This should probably just deal a crap ton of damage to them to break them.	[ 1 ]
Damn, that slipped in just annoyed me as VS kept outlining it.	[ 1 ]
with this named something more helpful we can possibly get rid of this comment now. at least to me its weird to single out the "hot in here" one, but idk	[ 1 ]
you have deleted prepare test	[ 0 ]
just interesting is this lib an official way to track this	[ 0 ]
nit forward declare app list internalapp instead	[ 0 ]
imo should be console info wtypes text wtypes text	[ 0 ]

> Does the tank being decoupled mean no more stuff like N2O throwers? If so, that is sucky. the original code only vented plasma anyway.

[ 1 ]

WHY DO MINERAL TURFS HAVE A CHECK THAT LETS SIMPLE MOBS KNOCK WALLS DOWN WHY DOES NOTHING USE THIS WHAT THE HELL

[ 1 ]

dumb question cipd server verifies that the instance s package inside it is manifest actually matches right i assume yes

[ 0 ]

I left some crap in your code

[ 1 ]

these are odd and useless but our code formatting tool seems to require it as soon as there are too many members

[ 0 ]

Damn, your binary doesn't work either. Now I'm really confused. Is my test setup flawed at the beginning? D:

[ 1 ]

all your class methods should be staticmethod

[ 0 ]

I'm in favor of splitting things up more or maybe going to @iwubcode's solution because things are getting a ridiculous in all senses. On my old laptop, I can't fit any of the windows.

[ 1 ]

stupid nit could you please add a longer description of why we are removing this

[ 0 ]

btw the ids starting with i are change ids you see in commit messages identifiers of changes within gerrit the real git commit ids are the ones you get when browsing git log prefixed with commit

[ 0 ]

silly me ordering is not important here since we are in a firewall defer apply block where the filter defer apply off will call in iptables firewall setup chains apply setup chain etc doing update ipset members and generate ipset rule args later on

[ 0 ]

shouldn t these mocks live up in test check can live migrate destination if do raise is true

[ 0 ]

whoops this is junk that i missed if we re not doing authenticated encryption then we do not need to choose an authentication function at all i am just going to take this line out

[ 0 ]

done v lol drive by

[ 0 ]

Whoa, that's goofy :)

[ 1 ]

my apologies for these silly errors

[ 0 ]

also do the equivalent check on e g path with dots

[ 0 ]

wow kwargs

[ 0 ]

> bit.ly links expire? Yuck. URL shorteners are such nonsense. Agreed on the nonsense. And unclear why the links now just return a 404. I believe they were still returning redirects a few days ago but what do I know about bit.ly operations...

[ 1 ]

this is a django setting it belongs in the next section

[ 0 ]

it seems that this lswitches is not being used

[ 0 ]

Why the fuck did i use and xD

[ 1 ]

host should be dest it is easy to predict so you do not need to use mock any here

[ 0 ]

blerg not sure i must have done some sort of copy and paste idiocy from a different commit version fixed this and the other instance i found of the same thing

[ 0 ]

see it was a dumb question cl description answered it

[ 0 ]

yes i hate this bit docs url would be much nicer imho but not in this cl

[ 0 ]

this is probably dumb but what do you regard as onboarding

[ 0 ]

I'm sure it's helpful. That doesn't change the fact that ten zombies committing ritual suicide on a rosebush is A: ridiculous and B: very much not intended behavior.

[ 1 ]

nit i think that we can kill everything after the comma now

[ 0 ]

it should be portpair destroy then a method name starts with a dot

[ 0 ]

typo s instance get by uui instance get by uuid

[ 0 ]

Fixed. Now resHit is a standard boolean with {0; 1} value.

[ 1 ]

use integerpropertyid to be able to change the value do the modification only if the decision to merge the approach is given

[ 0 ]

kill it and find out or did you want to do that in a later patch instead

[ 0 ]

silly typo

[ 0 ]

Oops, brain fart. Thanks for the catch!

[ 1 ]

ur a faggot XD

[ 1 ]

i would agree that a log warning should be thrown here

[ 0 ]

d oh that is awful english on my part fixing

[ 0 ]

This is also default item throwforce also it's a damn cheese wheel give it some HEFT

[ 1 ]

@tgstation/commit-access What is the final decision on this? Feels weird having reference to someone who was never part of our community and I feel like an asshole for saying it

[ 1 ]

on the existing servers with given credentials i think that it makes sense to show how to pass loclarc args otherwise this tutorial is useless

[ 0 ]

please remove backslashes where possible

[ 0 ]

stats nullptr

[ 0 ]

i think these two are simple enough and not re useable that they should be in lined into emit done signal

[ 0 ]

As long as Exited still gets called it should be fine. Still pretty crap it doesn't call the parent.

[ 1 ]

oh yes in the dicts below filter and raw can share the same mock object so v raw inst and v raw inst are useless i have removed them in the next patch

[ 0 ]

well shit. Guess it has to be "their" then.

[ 1 ]

that was supposed to be minutes but i am an idiot

[ 0 ]

I know, but gee give it a typepath like "wheelchair" or some shit.

[ 1 ]

nice catch some of checks are useless now since we do not create an instance of dynamicmodulecoordinator if we do not have correct intent to load a module

[ 0 ]

i agree those lines should be removed

[ 0 ]

I don't know shit about JS tbh, but couldn't this be a regex search? That way you don't need to exactly type the starting characters of your search.

[ 1 ]

The compiler sucks, then. `NOT_NULL(orb)` should shut it up, or `assume(orb != NULL);` before the return statement.

[ 1 ]

should we remove detectvalueboundfromvalue and inline the code here seems like valuebound create and valuebound detectvalueboundfromvalue are redundant

[ 0 ]

bordertype cv

[ 0 ]

this block should go after the mms entry below

[ 0 ]

remove self from here

[ 0 ]

Damn this formatting looks ugly :D

[ 1 ]

Whoops, I missed that

[ 1 ]

please do not use a normal space u but a no break space u a instead

[ 0 ]

why do not you use your system shell execute function to execute this and similar below

[ 0 ]

also test your damn code, this would make the singulo permanently impossible to posses, since it still has this flag

[ 1 ]

i think it is better to remove the here

[ 0 ]

assume i do neutron create net foo neutron create port foo get hold of port id neutron trunk create parent port id nova boot nic port id port id the question to answer is this would a trunk without subports function correctly i would think so as a guest i should be able to have my interface connection on my foo network just like any other regular port is it useful probably not as you would expect the the user to go and add subports later on so the other question is do we want to allow for a successful boot off a trunk with at least one subport if so then we should probably fail the binding process rather than hitting the agent

[ 0 ]

note this exec is not idempotent and it will execute dbsync for each puppet run on the undercloud is it expected

[ 0 ]

wanted to share it for the trusts tables so this refactoring is timely

[ 0 ]

Notable stupid shit found in blob_act() See above comment.

[ 1 ]

FWIW, this does ridiculously stupid things when combined with `pitch`, I gave up updating the vector tile fixtures in [mapbox-gl-test-suite](https://github.com/mapbox/mapbox-gl-test-suite) at that point.

[ 1 ]

this could also go into the common method

[ 0 ]

"Boss makes a dollar, you make a dime, so don't fucking ghost on company time."

[ 1 ]

useless var

[ 0 ]

that's kind of dumb i think i'd be pissed if I rolled catgrill skeleton when I could of rolled roman skeleton, since catgrill doesn't have any combat tools or armor

[ 1 ]

you can use wait true istead such hacks

[ 0 ]

why do not you initialize weak ptr factory as weak ptr factory this in the header file and remove this duplication from both constructors

[ 0 ]

nit insert step restart swift proxy server i knew to but noobs may forget could also be useful at this point to do a swift a u test tester k testing info to check two policies are reported in info

[ 0 ]

list of what public key ids list of strings i really think this attribute should be removed in favor of just including a link to the child collection instead

[ 0 ]

this should be marked for translation

[ 0 ]

I'm assuming it does, since this is what was used before. If it doesnt, then someone else fucked up and it hasn't really been an issue that anyone noticed. ever.

[ 1 ]

personally i do not think specifies is useful at all you can just put the interface type of disk

[ 0 ]

> But if they don't spawn some shitter can just take all glass from protolathe and vanish it in the void. Exactly, these are the consequences.

[ 1 ]

i think the deps are useless they are the same has the global testenv

[ 0 ]

remove i n

[ 0 ]

i could leave this test in general and just abort on unexpected libart

[ 0 ]

as per ie d affc d b cf ef a and i a e f cf c f a b f i believe self header is useless now

[ 0 ]

i m sorry if that is a dumb comment i wonder whether those really belong here should they be maintained in service repos instead

[ 0 ]

see dictionaries lists this one is preffered better to change all other

[ 0 ]

yes it is foolishly uploaded assuming i could make such a trivial change correctly ps is incoming

[ 0 ]

mock clients return value environment

[ 0 ]

i am ok with removing the die functions in a different cl

[ 0 ]

`suck as => such` as LOL

[ 1 ]

This is purely for human readability. If it's getting to ridiculous, it could be shortened.

[ 1 ]

could you remove these whitespaces

[ 0 ]

calling `Destroy` directly is something you should ***never*** do under any circumstances ***ever***. This should probably just deal a crap ton of damage to them to break them.

[ 1 ]

Damn, that slipped in just annoyed me as VS kept outlining it.

[ 1 ]

with this named something more helpful we can possibly get rid of this comment now. at least to me its weird to single out the "hot in here" one, but idk

[ 1 ]

you have deleted prepare test

[ 0 ]

just interesting is this lib an official way to track this

[ 0 ]

nit forward declare app list internalapp instead

[ 0 ]

imo should be console info wtypes text wtypes text

[ 0 ]