showvikdbz/code-reviews · Datasets at Hugging Face

text stringlengths 1 5.2k	labels listlengths 1 1
you have already mocked get default gateway linux	[ 0 ]
i would agree our rest api backends need it those warnings are annoying and useless	[ 0 ]
This conditional is a tad weird to read. To confirm, the goal is to play the sound even for off-screen columns up to a max of 5 to make the effect sound correct?	[ 1 ]
Because we can't have nice things and I'm shite at this whole well designed system thing. Feel free to replace it.	[ 1 ]
first line needs to be removed	[ 0 ]
whoops fat fingers fixed	[ 0 ]
that will look ugly because ordie is strange in case you are not create if absent it will not actually abort on a missing directory i felt the callers need to be inspected and then there can be a big cleanup i ll try my best	[ 0 ]
probably too late for me to be commenting about this but this docstring confuses me it looks like all it does is return the node associated with the instance where what is the validate part i know michael it has nothing to do with your changes	[ 0 ]
i think invalid nic argument s s can also be part of nic error and thus wud help u to get rid of err msg	[ 0 ]
would not it be better to keep this in a hiera sh	[ 0 ]
this tabbar use this one instead of cros factory tabbar	[ 0 ]
Darn, I missed that!	[ 1 ]
why not dereference the unique ptr at the caller i do not see you overwriting what the unique ptr stores	[ 0 ]
i do not see where this is used in this cl is it already in use but the import just missing	[ 0 ]
nits can we use space instand of tab in	[ 0 ]
So over $1000 to update the logo? That's a bit ridiculous. I paid over $1000 already.	[ 1 ]
Ok damn nevermind I realised that `makeCardPlayable` just adds a ContinuousEffect as well	[ 1 ]
balloon text aint runechat i just fucked up the name	[ 1 ]
is not this the only reference to persist sys localevar cannot you kill that one right now	[ 0 ]
nit not required driver info is always a dict	[ 0 ]
i do apologize for this i am a mess and i should be hanged upside down	[ 0 ]
debug thingy was having problems with shit not getting called, thats why there's the world check see: DNM	[ 1 ]
ridiculous thing, NOTHING got after two weeks. each day has 2T Plot adding.	[ 1 ]
wrap testr sh does not exist	[ 0 ]
Ah damn I missed that. CLion does this whenever I use the `add implementation` shortcut.	[ 1 ]
Crap, that wasn't supposed to happen. My bad. Will fix.	[ 1 ]
sergey this is value for saharaclient	[ 0 ]
hmm should be using nova dir i suppose	[ 0 ]
speedmerge that shit	[ 1 ]
the kb is an invaild hugepage size i would remove i e kb	[ 0 ]
I am not very sure how to create the live check stanza as\u2026 a. I am rubbish at regex, b. the application author has an odd way or organising the download in their repos (right now), the application is actually going fully open source in 2022, so this will be simpler\u2026 Sorry!	[ 1 ]
cbmem console p preram cbmem console	[ 0 ]
child here should be a plain cbb so bssl scopedcbb output cbb cbb child	[ 0 ]
why? if it's being added twice whoever did it fucked up.	[ 1 ]
why should this ever be false in this case	[ 0 ]
it s worth caching the correctly scaled image calculating it on every paint will create a lot of unnecessary garbage	[ 0 ]
hi kevin i am glad you have brought this up as i wanted your expertise on this i guess i am still not clear as to when to use one versus the other and would like to get an explanation from you on the subject looking at the code i thought that unless you have slaves to attach to one should always use a slavetemplate a leaner object i thought that one should use a mastertemplate if and only if you need to attach slavetemplates to please clarify thanks	[ 0 ]
i assume this exception is not used anymore so we should kill it	[ 0 ]
JUST FUCKING KEEP THIS AS IT	[ 1 ]
interesting stupid question but will not translators in the po files get a chance to put anything they want in the the msgstr field in other words why would an apostrophe whether used in a contraction or as a possessive matter	[ 0 ]
Some random shitty export datum fix got in. No harm done.	[ 1 ]
you have already mocked get default gateway linux	[ 0 ]
ephemeral word len ephemeral prefix len	[ 0 ]
CRA is [still on typescript@3](https://github.com/facebook/create-react-app/pull/9964) even though CRA@4 was supposed to upgrade to CRA@4. Either way, let's postpone this one until they upgrade as well.	[ 1 ]
Just saw this passing by on my off day, was curious, and thought I'd bitch about a typo in the site "zero". You're welcome.	[ 1 ]
Ack, I put [src] here but it reads "Your the magnetic gripper is empty". Damn the's ruining everything.	[ 1 ]
shitsec leaves defused bomb in armoury so smart syndie rearms it and saves tc, should make rearming a thing even the nuke has it	[ 1 ]
Blah, there's some mypy nonsense I don't want to deal with; closing this and will figure it out later.	[ 1 ]
style nit please use single quotes for string constants	[ 0 ]
nit better move inside trans	[ 0 ]
dumb question what standard are we following for the language codes i notice this change adds zh cn and ko kr but the previous entries are ja instead of ja jp and es instead of es es	[ 0 ]
as far as i know a fixed ip will always have a network id so this block seems unnecessary can anyone prove it is possible to have a fixed ip with no network id	[ 0 ]
get rid of stale white space here and below	[ 0 ]
yeah i noticed it in ps but d it because it is a nit	[ 0 ]
Yyyup. That goes on the monster spawning weirdness list.	[ 1 ]
this and the function above do not belong here they should be in code stub assembler h ideally we do not need them and can use unsigned directly	[ 0 ]
why not ceph mon hostname	[ 0 ]
I have no fucking idea, this is copied from blob health/power displays and I don't think there's another way to center it but I know nothing about this	[ 1 ]
if we handle the resource failure in handle resource failure and not in handle failure we can get rid of passing resource id here	[ 0 ]
aas is reserved for as a service so i guess you will have to use ass here	[ 0 ]
i am not a big fan of useless defines but other people are	[ 0 ]
adapter host uuid instance and connection info should be removed	[ 0 ]
damn. Good catch, it is not.	[ 1 ]
why is this an intptrconstant should it not just be an int constant	[ 0 ]
json content is a dict passed in by line looking at the rest of this function json to obj is really a dict to obj	[ 0 ]
look at those ridiculous double quotes!	[ 1 ]
what the fuck capdata cap to index n permitted	[ 0 ]
should be vif model image properties get hw vif model network model vif model e	[ 0 ]
`It looks kind of like ahn enormous wad of greyish tan bubblegum.`	[ 1 ]
also, held is a shit name as it also counts worn items, call it ```in_inventory```	[ 1 ]
vif type ovs	[ 0 ]
fat fingers	[ 0 ]
remove noqa	[ 0 ]
is it? do I really have to add all the pets manually fucking hell	[ 1 ]
this spontaneous qtdesigner change annoys me more	[ 0 ]
It's ugly, but I tried... think it's acceptable? this commit seems to have consolidated them.	[ 1 ]
mark histograms as obsolete do not delete them deleting histogram entries	[ 0 ]
Thanks! Must have gotten lost at some point as I had it working locally, darn internal names.	[ 1 ]
move opening on this line and get rid of	[ 0 ]
ugh i am an idiot this comment makes no sense because i did not see that lines were still part of this function please ignore sorry	[ 0 ]
given the test failures looks like you need to remove yourself as an observer in your destructor	[ 0 ]
Mild Alcohol. 10 boozepwr is the same as pure fucking ethanol.	[ 1 ]
@labkode The ideas was to do a sanity check. But while you're asking it is nonsense to do it only here and it is not really needed too. Therefore I removed it.	[ 1 ]
Maybe you could actually tell him the way? Being vague is a dick move.	[ 1 ]
obviously a typo it should be command instead of a dot e g ps ewwlo pid lwp comm cmd	[ 0 ]
rcomp targets strenghtenedrcomptarget	[ 0 ]
add notify heat services	[ 0 ]
Urgh how annoying its not supported by the compiler versions we are using. We will need to revert my commit and stick to the original code.	[ 1 ]
gosh that is much better	[ 0 ]
But don't you also have to compare with `> 0` because you don't expect any other arguments? Or is my logic screwed up here?	[ 1 ]
since v and v does not seem to differ in anything but the definte for max cpb size and it is already differentiated in v v variant structs buf size v and buf size v why not use one function and that	[ 0 ]
Hmmm... The last commits messed the Pull request with some unwanted commits with shity tests. I don't know how to remove them. Sorry for that.	[ 1 ]
lol why oh why does the ec api have to be so retard ed shouldn t this return a and not a	[ 0 ]
ai addrlen is a socklen t so i think that sizeof should be cast to that	[ 0 ]
you already have tast in the beginning of the name no need to put tast after the dot as well may i suggest tast runner narc bvt or similar to reflect the test exprs that you are passing that way it will be easier to distinguish different control files	[ 0 ]
die needs lineno as it is first arg die lineno message	[ 0 ]
the whole setup is inefficient i think you should just start with and rot rhs asregister register shifteroperand x f lsrs tmp rhs asregister register carry rhs x rsb tmp rot shifteroperand x al kcckeep preserve carry if is left b right cs else b right cc std swap rot tmp and exchange the rot and tmp in the right branch drop this mov the and below and both rsb below it would make sense to rename variables rot shift left tmp shift right	[ 0 ]
these names are not good leave this as flow spawn	[ 0 ]
Damn, I did not pay attention. This might break "GDI building captured." because in Dune 2000 it is "Atreides voice: building captured." and last entry in the Manifest gets prioritized.	[ 1 ]
Damn, my bad. You are absolutely right.	[ 1 ]

you have already mocked get default gateway linux

[ 0 ]

i would agree our rest api backends need it those warnings are annoying and useless

[ 0 ]

This conditional is a tad weird to read. To confirm, the goal is to play the sound even for off-screen columns up to a max of 5 to make the effect sound correct?

[ 1 ]

Because we can't have nice things and I'm shite at this whole well designed system thing. Feel free to replace it.

[ 1 ]

first line needs to be removed

[ 0 ]

whoops fat fingers fixed

[ 0 ]

that will look ugly because ordie is strange in case you are not create if absent it will not actually abort on a missing directory i felt the callers need to be inspected and then there can be a big cleanup i ll try my best

[ 0 ]

probably too late for me to be commenting about this but this docstring confuses me it looks like all it does is return the node associated with the instance where what is the validate part i know michael it has nothing to do with your changes

[ 0 ]

i think invalid nic argument s s can also be part of nic error and thus wud help u to get rid of err msg

[ 0 ]

would not it be better to keep this in a hiera sh

[ 0 ]

this tabbar use this one instead of cros factory tabbar

[ 0 ]

Darn, I missed that!

[ 1 ]

why not dereference the unique ptr at the caller i do not see you overwriting what the unique ptr stores

[ 0 ]

i do not see where this is used in this cl is it already in use but the import just missing

[ 0 ]

nits can we use space instand of tab in

[ 0 ]

So over $1000 to update the logo? That's a bit ridiculous. I paid over $1000 already.

[ 1 ]

Ok damn nevermind I realised that `makeCardPlayable` just adds a ContinuousEffect as well

[ 1 ]

balloon text aint runechat i just fucked up the name

[ 1 ]

is not this the only reference to persist sys localevar cannot you kill that one right now

[ 0 ]

nit not required driver info is always a dict

[ 0 ]

i do apologize for this i am a mess and i should be hanged upside down

[ 0 ]

debug thingy was having problems with shit not getting called, thats why there's the world check see: DNM

[ 1 ]

ridiculous thing, NOTHING got after two weeks. each day has 2T Plot adding.

[ 1 ]

wrap testr sh does not exist

[ 0 ]

Ah damn I missed that. CLion does this whenever I use the `add implementation` shortcut.

[ 1 ]

Crap, that wasn't supposed to happen. My bad. Will fix.

[ 1 ]

sergey this is value for saharaclient

[ 0 ]

hmm should be using nova dir i suppose

[ 0 ]

speedmerge that shit

[ 1 ]

the kb is an invaild hugepage size i would remove i e kb

[ 0 ]

I am not very sure how to create the live check stanza as\u2026 a. I am rubbish at regex, b. the application author has an odd way or organising the download in their repos (right now), the application is actually going fully open source in 2022, so this will be simpler\u2026 Sorry!

[ 1 ]

cbmem console p preram cbmem console

[ 0 ]

child here should be a plain cbb so bssl scopedcbb output cbb cbb child

[ 0 ]

why? if it's being added twice whoever did it fucked up.

[ 1 ]

why should this ever be false in this case

[ 0 ]

it s worth caching the correctly scaled image calculating it on every paint will create a lot of unnecessary garbage

[ 0 ]

hi kevin i am glad you have brought this up as i wanted your expertise on this i guess i am still not clear as to when to use one versus the other and would like to get an explanation from you on the subject looking at the code i thought that unless you have slaves to attach to one should always use a slavetemplate a leaner object i thought that one should use a mastertemplate if and only if you need to attach slavetemplates to please clarify thanks

[ 0 ]

i assume this exception is not used anymore so we should kill it

[ 0 ]

JUST FUCKING KEEP THIS AS IT

[ 1 ]

interesting stupid question but will not translators in the po files get a chance to put anything they want in the the msgstr field in other words why would an apostrophe whether used in a contraction or as a possessive matter

[ 0 ]

Some random shitty export datum fix got in. No harm done.

[ 1 ]

you have already mocked get default gateway linux

[ 0 ]

ephemeral word len ephemeral prefix len

[ 0 ]

CRA is [still on typescript@3](https://github.com/facebook/create-react-app/pull/9964) even though CRA@4 was supposed to upgrade to CRA@4. Either way, let's postpone this one until they upgrade as well.

[ 1 ]

Just saw this passing by on my off day, was curious, and thought I'd bitch about a typo in the site "zero". You're welcome.

[ 1 ]

Ack, I put [src] here but it reads "Your the magnetic gripper is empty". Damn the's ruining everything.

[ 1 ]

shitsec leaves defused bomb in armoury so smart syndie rearms it and saves tc, should make rearming a thing even the nuke has it

[ 1 ]

Blah, there's some mypy nonsense I don't want to deal with; closing this and will figure it out later.

[ 1 ]

style nit please use single quotes for string constants

[ 0 ]

nit better move inside trans

[ 0 ]

dumb question what standard are we following for the language codes i notice this change adds zh cn and ko kr but the previous entries are ja instead of ja jp and es instead of es es

[ 0 ]

as far as i know a fixed ip will always have a network id so this block seems unnecessary can anyone prove it is possible to have a fixed ip with no network id

[ 0 ]

get rid of stale white space here and below

[ 0 ]

yeah i noticed it in ps but d it because it is a nit

[ 0 ]

Yyyup. That goes on the monster spawning weirdness list.

[ 1 ]

this and the function above do not belong here they should be in code stub assembler h ideally we do not need them and can use unsigned directly

[ 0 ]

why not ceph mon hostname

[ 0 ]

I have no fucking idea, this is copied from blob health/power displays and I don't think there's another way to center it but I know nothing about this

[ 1 ]

if we handle the resource failure in handle resource failure and not in handle failure we can get rid of passing resource id here

[ 0 ]

aas is reserved for as a service so i guess you will have to use ass here

[ 0 ]

i am not a big fan of useless defines but other people are

[ 0 ]

adapter host uuid instance and connection info should be removed

[ 0 ]

damn. Good catch, it is not.

[ 1 ]

why is this an intptrconstant should it not just be an int constant

[ 0 ]

json content is a dict passed in by line looking at the rest of this function json to obj is really a dict to obj

[ 0 ]

look at those ridiculous double quotes!

[ 1 ]

what the fuck capdata cap to index n permitted

[ 0 ]

should be vif model image properties get hw vif model network model vif model e

[ 0 ]

`It looks kind of like ahn enormous wad of greyish tan bubblegum.`

[ 1 ]

also, held is a shit name as it also counts worn items, call it ```in_inventory```

[ 1 ]

vif type ovs

[ 0 ]

fat fingers

[ 0 ]

remove noqa

[ 0 ]

is it? do I really have to add all the pets manually fucking hell

[ 1 ]

this spontaneous qtdesigner change annoys me more

[ 0 ]

It's ugly, but I tried... think it's acceptable? this commit seems to have consolidated them.

[ 1 ]

mark histograms as obsolete do not delete them deleting histogram entries

[ 0 ]

Thanks! Must have gotten lost at some point as I had it working locally, darn internal names.

[ 1 ]

move opening on this line and get rid of

[ 0 ]

ugh i am an idiot this comment makes no sense because i did not see that lines were still part of this function please ignore sorry

[ 0 ]

given the test failures looks like you need to remove yourself as an observer in your destructor

[ 0 ]

Mild Alcohol. 10 boozepwr is the same as pure fucking ethanol.

[ 1 ]

@labkode The ideas was to do a sanity check. But while you're asking it is nonsense to do it only here and it is not really needed too. Therefore I removed it.

[ 1 ]

Maybe you could actually tell him the way? Being vague is a dick move.

[ 1 ]

obviously a typo it should be command instead of a dot e g ps ewwlo pid lwp comm cmd

[ 0 ]

rcomp targets strenghtenedrcomptarget

[ 0 ]

add notify heat services

[ 0 ]

Urgh how annoying its not supported by the compiler versions we are using. We will need to revert my commit and stick to the original code.

[ 1 ]

gosh that is much better

[ 0 ]

But don't you also have to compare with `> 0` because you don't expect any other arguments? Or is my logic screwed up here?

[ 1 ]

since v and v does not seem to differ in anything but the definte for max cpb size and it is already differentiated in v v variant structs buf size v and buf size v why not use one function and that

[ 0 ]

Hmmm... The last commits messed the Pull request with some unwanted commits with shity tests. I don't know how to remove them. Sorry for that.

[ 1 ]

lol why oh why does the ec api have to be so retard ed shouldn t this return a and not a

[ 0 ]

ai addrlen is a socklen t so i think that sizeof should be cast to that

[ 0 ]

you already have tast in the beginning of the name no need to put tast after the dot as well may i suggest tast runner narc bvt or similar to reflect the test exprs that you are passing that way it will be easier to distinguish different control files

[ 0 ]

die needs lineno as it is first arg die lineno message

[ 0 ]

the whole setup is inefficient i think you should just start with and rot rhs asregister register shifteroperand x f lsrs tmp rhs asregister register carry rhs x rsb tmp rot shifteroperand x al kcckeep preserve carry if is left b right cs else b right cc std swap rot tmp and exchange the rot and tmp in the right branch drop this mov the and below and both rsb below it would make sense to rename variables rot shift left tmp shift right

[ 0 ]

these names are not good leave this as flow spawn

[ 0 ]

Damn, I did not pay attention. This might break "GDI building captured." because in Dune 2000 it is "Atreides voice: building captured." and last entry in the Manifest gets prioritized.

[ 1 ]

Damn, my bad. You are absolutely right.

[ 1 ]