text
stringlengths 1
5.2k
| labels
listlengths 1
1
|
|---|---|
yep i will remove them i copy pasta d from the gspathtest function above which had them i will remove them from both
|
[
0
] |
nit put admin in backticks
|
[
0
] |
libqmi qmictl h
|
[
0
] |
not my change. see #11629 this is so i dont fuck over that change.
|
[
1
] |
btw do we want to kill chrome when presenter exits chrome pid and kill chrome pid in clean up
|
[
0
] |
so dumb question we had ironic qemu hook path before what if someone is using that and then upgrades to this it ll break their environment is this something we care about i m not sure since this is devstack and not our code
|
[
0
] |
they are actually there already so i removed these redundant dchecks also removed the redundant comments
|
[
0
] |
@weswigham Thanks for that solution, I had that in mind too, however it feels a little clumsy. Are there any disadvantages or technical issues with allowing the extension of type aliases?
|
[
1
] |
this is not a right place for a panic when a different method of error handling would do the job i e returning an err panic real library functions should avoid panic
|
[
0
] |
this should be moved to test hostops py as we are trying to completely remove test hypervapi py
|
[
0
] |
ick sure looks like configs that do not already set the bind port are just going to get a keyerror gross i was expecting something more along the lines of a logged warning that says in future swift releases the bind port will be required even if we can pull this off with out a warning deprecation we should at least get a better system exit than stack trace
|
[
0
] |
Unless it's been fixed recently, the invisible health stat can do the same thing, going into ridiculous negatives under some circumstances.
|
[
1
] |
THAT'S NOT TRUE, THERE ARE NULLS IN PEOPLES HAND INDEXES ALL THE FUCKING TIME
|
[
1
] |
@matklad, this is ridiculous, but yeah, I independently came to this conclusion in #3090
|
[
1
] |
use normal indentation you maniac
|
[
1
] |
Yup, As it's just a thing When you are in the zone and writing stuff, you anciently press `control + s` and that's sucks. AutoSave is cool though. But I wish, if not saving we can at least prevent the default event of saving the webpage. \U0001f914
|
[
1
] |
Oops, I did not check damn. You are right. @NilsWild can you please fix it
|
[
1
] |
this is a whitelist and should probably be removed everything goes to the tombstone
|
[
0
] |
i will give it a shot i was considering this a bit for the sake of not duplicating logic like you mention my main hesitation was that i am garbage at makefiles but i think it would be the better solution i will play around with it today
|
[
0
] |
self updated devices is not initialized in this class either initialize it or pass it in a param
|
[
0
] |
can this logic be a dcheck excessive callbacks are strange
|
[
0
] |
maybe we should add an `else` with a "wtf don't understand"-like message :)
|
[
1
] |
return values, motherfucker.
|
[
1
] |
what if i gzipped g of zeros they certainly fit one chunk but when you decompress this chunk you will take g of memory
|
[
0
] |
bug here self should be removed
|
[
0
] |
this reads a little odd why not just invert the if s and do this in the one block
|
[
0
] |
may be a dumb question but what if it is already attached is that possible
|
[
0
] |
assert also checks for a primary board corresponding to the variant you requested think the get should stay simple and stupid and the choose should error if a broken overlay is chosen
|
[
0
] |
errno ignore res strtol if errno barf
|
[
0
] |
strerror errno is almost always more useful than errno
|
[
0
] |
I always thought hooves were excellent, despite freezing in the cold, which is still ridiculous.
|
[
1
] |
you can add the following in line and you do not need to include venc h if h and and venc vp if h struct venc h handle struct venc vp handle then here you can use union venc h handle h e venc vp handle vp e h enc
|
[
0
] |
i believe this needs an abc abstractmethod
|
[
0
] |
i do not think so the whole point was to have something before ddr anything else can go later when we can actually get into c code i think i really do not want to encourage anyone to use these commands unless there is no other choice since they are ugly
|
[
0
] |
compiler does not like setting non primitives object or array on the prototype object these sorts of static objects should be on the static class
|
[
0
] |
dumb question where is this new mnoutlinelevel variable ever used
|
[
0
] |
would be better to get rid of this and other white spaces below
|
[
0
] |
this "tied" subtype's behavior is pretty weird and I think it should be explained more for example, what does hitting such a switch even do
|
[
1
] |
this is weird binding logic. make a local private bendable rather than binding two other classes' bindables
|
[
1
] |
Clang format messed this one up. Should be fixed now.
|
[
1
] |
OK, I still don't like this. Let me give it some thought - there should be a saner way to handle this crap.
|
[
1
] |
maybe provide an example of why recurse submodules is a solitaryallowconjoined
|
[
0
] |
Make it gender neutral you fuck
|
[
1
] |
fantastic
|
[
0
] |
srcmap
|
[
0
] |
kill it
|
[
0
] |
Don't do this, we're trying to convert things away from the overlays += string. Because Byond stores them in a weird way that fucks up bicon()
|
[
1
] |
We really need a comment explaining what the wtFs is for. It took me a while to understand this in local_store, a multi line comment explaining what this variable will do will be useful.
|
[
1
] |
Holy shit research points for big explosions? That's awesome. Can you build dopple arrays to put at mining?
|
[
1
] |
other assignment methods do not have hints either they are not really exposed to api query strings group ids should be removed from this method in favor of using list domains for groups below
|
[
0
] |
use vm mode hvm instead of hvm here
|
[
0
] |
could you add this check to run tests sh as well l
|
[
0
] |
"CLGT" has the same literal style as "WTF" while also containing a swear word in there as well
|
[
1
] |
@rjmccall 100 pushups for overloading `operator^` in a totally absurd way :)
|
[
1
] |
u to wrapped dict is more appropriate here
|
[
0
] |
Why the hell do these files keep popping up, random ass files that I have done nothing to
|
[
1
] |
hmm you are currently in chromite lib and importing without any extra are you adding something to the syspath elsewhere maybe should be chromite shell contextlib
|
[
0
] |
i love how you used mock to manipulate the space time continuum instead of a flux capacitor
|
[
0
] |
fat finger would be nice
|
[
0
] |
ditto re naked pointers
|
[
0
] |
That check on corp cards break at least casting call. Maybe others - hence did not do it. Thanks guys for reviews. Damn bracket creep..!
|
[
1
] |
i pulled a goofball hold on
|
[
1
] |
parameter name
|
[
0
] |
if you are killing the upgrade looks like you have got more code you could scrub
|
[
0
] |
Are we really the only users who find this approach for file-naming a bit... ridiculous? Surely it's not the intended functionality?
|
[
1
] |
why is this needed why not simply set get vm summary info to return fake info instead of attempting to make a mock behave like a dict
|
[
0
] |
i think the is admin is spurious and should be removed only leave the other check
|
[
0
] |
Oh crap this horrible thing was left in \U0001f916 EXTERMINATE \U0001f916
|
[
1
] |
url should be set for the intent filter follow other examples whether to add tailing
|
[
0
] |
How about calling it `Ray2.default()` or something like that? "empty" is too weird - how can a ray be empty?
|
[
1
] |
use oslo serialization jsonutils dumps for this
|
[
0
] |
Catgirl skellingtons? That's actually a terrifying image.
|
[
1
] |
nit kill after an extra s
|
[
0
] |
can you puppet lint arrows should be aligned
|
[
0
] |
Super wacky. Do we have a repro of the code involved here?
|
[
1
] |
nitpick parameter is not that long to type is parameter blank would sound better
|
[
0
] |
no action required code like this makes lisp s brackets look inviting one would hope that dicts as objects are going to die in a fire someday soon yes
|
[
0
] |
Shit. WIll fix it as soon as I fix my master repo.
|
[
1
] |
I have no problem with this if someone would just tell me what the damn button looks like to the end user, as I asked here: https://github.com/xbmc/xbmc/pull/9840#issuecomment-222884561 Take a picture with your phone and show me. It shouldn't be this hard to communicate online.
|
[
1
] |
addcleanup should be used instead of teardown
|
[
0
] |
i was looking at real au worker py which imports the local constants you are right that this module is importing chromite lib constants instead ugly i ll post a cl
|
[
0
] |
I agree as well, we should wait until the API is stable. Having a new major version released every couple weeks is ridiculous.
|
[
1
] |
Aha, MS' shitty implementation for array does not decay iterator to pointer. I wonder how they managed to do that
|
[
1
] |
robert do you or anyone know the reason for these ifndef i am keeping them as is i do not know if we should remove them or also comment out the new af mpls and af packet
|
[
0
] |
ack you ll also be killing blink mojom pagevisibilitystate too
|
[
0
] |
remove blankline
|
[
0
] |
this will be confusing it will read kill failed reason maybe plog error zygote kill init pid failed
|
[
0
] |
Damn, I accepted the wrong side of the merge...
|
[
1
] |
nit please move inside trans
|
[
0
] |
Notes for the review: 1. Changes in `array_method.c` are bug-fixes and simplifications in code that was practically unused and is not used for NumPy proper. 2. There is still `PyArray_DescrNew`, etc. C-API which will just do nonsense for new-style DTypes. There is a reason to call it experimental :).
|
[
1
] |
This is getting a little ridiculous - we need to have a normal review & release process for code going into fresh if we're going to depend on it for our core infrastructure. cc @lucacasonato @piscisaureus
|
[
1
] |
> You should be asking why is it a syndie item, or why is it so ridiculously expensive as a syndie item. It's ridiculously expensive because the Syndicate expects their agents to spend their TC on useful shit
|
[
1
] |
same question
|
[
0
] |
exceptions by utils execute should be handled
|
[
0
] |
it seems like the dumb method is useless in this test case
|
[
0
] |
is a thinko worst than a mere typo like someone actually thought about it first
|
[
0
] |
this also seems useless
|
[
0
] |
i would prefer you instantiate the attributeerror
|
[
0
] |
let us mention here the original test case not qa elf sh
|
[
0
] |
c eilometer
|
[
0
] |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.