showvikdbz/code-reviews · Datasets at Hugging Face

text stringlengths 1 5.2k	labels listlengths 1 1
i think you could also do it inline callback call keyguardmanager null keyguardmanager isdevicesecure false	[ 0 ]
Ahhhh I'm a moron. scuse me....	[ 1 ]
these names are not meaningful they should be called something like num volumes total size and volume size and there should be an additional one for num volumes per host	[ 0 ]
stupid question but why are we preserving newlines here optparse reformats to term widths last i knew this disables that	[ 0 ]
@veloraven this is ridiculous	[ 1 ]
if you are adding an addcleanup to handle the unrescue then you should remove this block	[ 0 ]
Cleaning guns. You should change the ratios around, there's no reason I can think of that cutting up soap would make it 20x better than just using soap. It could maybe be a little better, but 20x is pretty ridiculous.	[ 1 ]
Really if you're gonna "fix" (this is a bandaid) this in such a half assed way do it with the other holodeck items too.	[ 1 ]
>not even using `user` Also, a straight up gib is insane.	[ 1 ]
this is kinda ugly, not sure if it's better but you can iterate over visibility container and find hit error displays and bind the events and hit windows	[ 1 ]
i hate this name can we not use this it is not a size t anything it is a uint t	[ 0 ]
Damn, nevermind then ;) just keep it as-is	[ 1 ]
Yes, yes... was just enjoying a frosted barley pop after getting this terrible bastard running. Hope to take off [wip] soon :)	[ 1 ]
pls docstring	[ 0 ]
i would add that must be run over devstack	[ 0 ]
yeap totally took it as if it was sqlalchemy stuff sry for useless comment	[ 0 ]
I think my next fight is going to be trying to get FITS writing to not use such a ridiculous amount of memory... I'm trying to create a 2.5Gb file and running into issues (memory usage is 20Gb and climbing)	[ 1 ]
@dirk-thomas , thx. That tag is ridiculous. I'll delete it.	[ 1 ]
oops mistake only swift blah is correct as on l path is used in case of swift blah path is blah in case of swift blah it is empty string	[ 0 ]
damnit nightred also, oooooh, time to speedrun making a deathplague	[ 1 ]
WTH! I did escape...not sure why this got pushed up!! Also the $field_value should be escaped too..	[ 1 ]
this method is now useless i will remove it in another cl	[ 0 ]
scrow instead of sal uint if not scrow then at least a bit type	[ 0 ]
More of the `src.var = var` pattern here, please. Documentation with underscore-prefixed names is weird, and shows off the implementation detail.	[ 1 ]
yes i will remove them for now including empty functions below	[ 0 ]
better to deepcopy and put subnet atribute	[ 0 ]
can you include the output of ip a from the host machine where you are executing devtest sh	[ 0 ]
@aelred the title "WIP" stands for "Work in Progress". Rubbish must be expected. Also go make the graql side not rubbish!	[ 1 ]
please do not use cfgclient i would like to kill it please use lower level interface instead	[ 0 ]
i will need to remove from agent ucs driver which i am doing in the next patch	[ 0 ]
SDK acquisition is the path forward. In the meantime, it's more complicated than "nonsense duplication".	[ 1 ]
Fucking awful. Put each entry of the list on a newline when it's that long.	[ 1 ]
you can use cluster id self fuel web get last created cluster for this case	[ 0 ]
sk alphaopaque but the default fill color is opaque black this is a no op so you should not need this	[ 0 ]
then why does it exist wtf	[ 1 ]
nit consider validate not empty string	[ 0 ]
Welll considering I dont know shit about the fluff, I'm open to suggestions.	[ 1 ]
log error instead of log exception log exception should be used when you have a traceback	[ 0 ]
Mention moon talko's, they won't shut up! And keep beeing a deeply closeted gay man... I'm not gay!	[ 1 ]
actually they are both wrapped at the boundary set in the pcm s configuration this is important and i was ignoring it since i always set it to max as i have no use for it i will upload a new patch set the pulls the boundary from the pcm and does the wrapping correctly	[ 0 ]
referencetypeinfo new rti or should you just return a new referencetypeinfo instead	[ 0 ]
more kittens to die	[ 0 ]
oh i totally missed that this was in a static method of course my bad	[ 0 ]
yeah but we are all lazy wtoo busy trying to get stuff done to work out the minimal header we need since of folks shouldn t be using the hairy one it should have a name that says this is not the logging header you are looking for and ideally says to the hey this is where the hairy stuff you are looking for lives	[ 0 ]
woe betide to me for being pedantic with my remedial english but i think the google english style for possessive apostrophe is to put it before the s so user s toc apostrophes my last tech writer was a stickler for this kind of thing	[ 0 ]
now we should remove this because you removed buf type dmabuf	[ 0 ]
remove this white space error	[ 0 ]
Damn. :D `in any grid` of course xD	[ 1 ]
I forgot the second one, dang it.	[ 1 ]
net db id it will crash here	[ 0 ]
fortesting should be camel case if anything for consistency with above	[ 0 ]
nonsense, it is not fixed.	[ 1 ]
thanks for passing that to me, I'll update it (damn, 2 drug prs in an hour)	[ 1 ]
useless div suggest to follow condition style instead of ternary operator	[ 0 ]
Signed vs unsigned char is another of those wacky ARM differences that popped up in my head when I saw this issue again now..	[ 1 ]
gross	[ 0 ]
silly stuff spelling errors please replace all entries of servcie to service	[ 0 ]
They have the same label in music.yaml and exact same song length which is a bit irritating.	[ 1 ]
please wrap at chars git review should have whined at you	[ 0 ]
remove extra newline after the block or use in it is place	[ 0 ]
maybe a better name something like getinfobarcolors	[ 0 ]
testrunner cssmodel testrunner debuggermodel	[ 0 ]
neither of these imports are used anymore they should be removed	[ 0 ]
this actually needs to be removed completely only the go code should be built from this rule	[ 0 ]
self assertgreater or self assertnotequal	[ 0 ]
why the fuck did github change its format again	[ 1 ]
hang on thats rubbish ignore that idea i kinda think if we want conf image cache subdirectory name to mean the same for vmware and libvirt if possible if we added a conf vmware make cache folder unique that controlled if you add the my ip to the conf image cache subdirectory name it would be much simpler admins that want to share the folder then just set conf vmware make cache folder unique false then they configure the cache directly just like libvirt folks by configuring conf image cache subdirectory name	[ 0 ]
let use here id u id g	[ 0 ]
Spacing here seems wonky	[ 1 ]
should periodictasks be derived from object	[ 0 ]
i am not sure why we need to mock utils execute twice utils execute is mocked at l already	[ 0 ]
m sum note currently does not work for large objects	[ 0 ]
i would prefer you catch the most specific thing s possible otherwise you start accidentally catching accidental things in the future and it is hard to find the real bugs	[ 0 ]
i think it would be better to explicitly add lazy true here just so it is clear what that true is for	[ 0 ]
actually there is already a command for taht restore default command so i guess that is fine but at least add some comment below to explain the hack because that is really not obvious and in years a poor dev will stumble upon this and wonder what the fuck	[ 0 ]
should be end execute disksetup	[ 0 ]
oh, damn, rookie mistake there.. I even tested with non-basic lands specifically and didn't verify other card types \U0001f926... fixed	[ 1 ]
nit the line should end with a colon	[ 0 ]
both lines are useless here	[ 0 ]
removed the file from the cl	[ 0 ]
This will make it sleep, fucking shit up, i'll pr it to your branch the proper way to do this	[ 1 ]
right now i am waiting for more feed back on if the darn conditions are even working as intended right now.	[ 1 ]
useless	[ 0 ]
please use switch error for unknown arch type should be the default	[ 0 ]
nevermind i see they are still needed of course for both ipam backends my mistake i will restore them	[ 0 ]
this overwrites test content types assertvaliderrorresponse and is redundant with expected status below which uses assertresponsestatus anyway i believe this whole def can should be removed	[ 0 ]
observe that THE TABLES HAVE TURNED, and now you are in control of a devastating cocksucker artillery machine of your own8. go get like 8 more of them and have fun	[ 1 ]
Having the staff handle it requires a for loop or using locate so this is ~technically better~ even though it's weird	[ 1 ]
your prefs never blow up w o registering because runeviction seems to not be tested	[ 0 ]
C'mon guys, this is getting ridiculous.	[ 1 ]
it literally has the name of the machine and the id of the machine so you can look at chat log and see what you linked or unlinked to what incase you inevitably fuck up	[ 1 ]
agreed with paul that we should create a wrapper for the kill function to replace all the kill call in this file probably can do it in a separate cl maybe something like this bool killprocess int pid bool killed this will return true if signal is sent or the process is already killed false otherwise the caller can use the killed to check if the process has already exited	[ 0 ]
> That's how I know this test was never run. I don't see how I can be wrong about that. Are you calling me a liar? Did you run the test?	[ 1 ]
> Just wondering, what for real use cases should force you to put a script in the head of the page. The real world of mass-market CMS distribution. If you want to super optimise YOUR Joomla site then go for it, however a mass-market solution has to cater for everyone, from idiots to senior developers...	[ 1 ]
incompatible with python i think it is better to write something like this try import cpickle as pickle except import pickle	[ 0 ]
seems like if you do not need the inputs you could just lump them all together lambda a k self ensure transaction is closed	[ 0 ]
You already did. The fucked up characters were in master	[ 1 ]
thank you very much for your review this is really a stupid error due to my carelessness i will fix it in next patch	[ 0 ]
job labels job labels lstrip	[ 0 ]
This really looks like a pain in the ass to manage. Does VS do this automatically?	[ 1 ]

i think you could also do it inline callback call keyguardmanager null keyguardmanager isdevicesecure false

[ 0 ]

Ahhhh I'm a moron. scuse me....

[ 1 ]

these names are not meaningful they should be called something like num volumes total size and volume size and there should be an additional one for num volumes per host

[ 0 ]

stupid question but why are we preserving newlines here optparse reformats to term widths last i knew this disables that

[ 0 ]

@veloraven this is ridiculous

[ 1 ]

if you are adding an addcleanup to handle the unrescue then you should remove this block

[ 0 ]

Cleaning guns. You should change the ratios around, there's no reason I can think of that cutting up soap would make it 20x better than just using soap. It could maybe be a little better, but 20x is pretty ridiculous.

[ 1 ]

Really if you're gonna "fix" (this is a bandaid) this in such a half assed way do it with the other holodeck items too.

[ 1 ]

>not even using `user` Also, a straight up gib is insane.

[ 1 ]

this is kinda ugly, not sure if it's better but you can iterate over visibility container and find hit error displays and bind the events and hit windows

[ 1 ]

i hate this name can we not use this it is not a size t anything it is a uint t

[ 0 ]

Damn, nevermind then ;) just keep it as-is

[ 1 ]

Yes, yes... was just enjoying a frosted barley pop after getting this terrible bastard running. Hope to take off [wip] soon :)

[ 1 ]

pls docstring

[ 0 ]

i would add that must be run over devstack

[ 0 ]

yeap totally took it as if it was sqlalchemy stuff sry for useless comment

[ 0 ]

I think my next fight is going to be trying to get FITS writing to not use such a ridiculous amount of memory... I'm trying to *create* a 2.5Gb file and running into issues (memory usage is 20Gb and climbing)

[ 1 ]

@dirk-thomas , thx. That tag is ridiculous. I'll delete it.

[ 1 ]

oops mistake only swift blah is correct as on l path is used in case of swift blah path is blah in case of swift blah it is empty string

[ 0 ]

damnit nightred also, oooooh, time to speedrun making a deathplague

[ 1 ]

WTH! I did escape...not sure why this got pushed up!! Also the $field_value should be escaped too..

[ 1 ]

this method is now useless i will remove it in another cl

[ 0 ]

scrow instead of sal uint if not scrow then at least a bit type

[ 0 ]

More of the `src.var = var` pattern here, please. Documentation with underscore-prefixed names is weird, and shows off the implementation detail.

[ 1 ]

yes i will remove them for now including empty functions below

[ 0 ]

better to deepcopy and put subnet atribute

[ 0 ]

can you include the output of ip a from the host machine where you are executing devtest sh

[ 0 ]

@aelred the title "WIP" stands for "Work in Progress". Rubbish must be expected. Also go make the graql side not rubbish!

[ 1 ]

please do not use cfgclient i would like to kill it please use lower level interface instead

[ 0 ]

i will need to remove from agent ucs driver which i am doing in the next patch

[ 0 ]

SDK acquisition is the path forward. In the meantime, it's more complicated than "nonsense duplication".

[ 1 ]

Fucking awful. Put each entry of the list on a newline when it's that long.

[ 1 ]

you can use cluster id self fuel web get last created cluster for this case

[ 0 ]

sk alphaopaque but the default fill color is opaque black this is a no op so you should not need this

[ 0 ]

then why does it exist wtf

[ 1 ]

nit consider validate not empty string

[ 0 ]

Welll considering I dont know shit about the fluff, I'm open to suggestions.

[ 1 ]

log error instead of log exception log exception should be used when you have a traceback

[ 0 ]

Mention moon talko's, they won't shut up! And keep beeing a deeply closeted gay man... I'm not gay!

[ 1 ]

actually they are both wrapped at the boundary set in the pcm s configuration this is important and i was ignoring it since i always set it to max as i have no use for it i will upload a new patch set the pulls the boundary from the pcm and does the wrapping correctly

[ 0 ]

referencetypeinfo new rti or should you just return a new referencetypeinfo instead

[ 0 ]

more kittens to die

[ 0 ]

oh i totally missed that this was in a static method of course my bad

[ 0 ]

yeah but we are all lazy wtoo busy trying to get stuff done to work out the minimal header we need since of folks shouldn t be using the hairy one it should have a name that says this is not the logging header you are looking for and ideally says to the hey this is where the hairy stuff you are looking for lives

[ 0 ]

woe betide to me for being pedantic with my remedial english but i think the google english style for possessive apostrophe is to put it before the s so user s toc apostrophes my last tech writer was a stickler for this kind of thing

[ 0 ]

now we should remove this because you removed buf type dmabuf

[ 0 ]

remove this white space error

[ 0 ]

Damn. :D `in any grid` of course xD

[ 1 ]

I forgot the second one, dang it.

[ 1 ]

net db id it will crash here

[ 0 ]

fortesting should be camel case if anything for consistency with above

[ 0 ]

nonsense, it is not fixed.

[ 1 ]

thanks for passing that to me, I'll update it (damn, 2 drug prs in an hour)

[ 1 ]

useless div suggest to follow condition style instead of ternary operator

[ 0 ]

Signed vs unsigned char is another of those wacky ARM differences that popped up in my head when I saw this issue again now..

[ 1 ]

gross

[ 0 ]

silly stuff spelling errors please replace all entries of servcie to service

[ 0 ]

They have the same label in music.yaml and exact same song length which is a bit irritating.

[ 1 ]

please wrap at chars git review should have whined at you

[ 0 ]

remove extra newline after the block or use in it is place

[ 0 ]

maybe a better name something like getinfobarcolors

[ 0 ]

testrunner cssmodel testrunner debuggermodel

[ 0 ]

neither of these imports are used anymore they should be removed

[ 0 ]

this actually needs to be removed completely only the go code should be built from this rule

[ 0 ]

self assertgreater or self assertnotequal

[ 0 ]

why the fuck did github change its format again

[ 1 ]

hang on thats rubbish ignore that idea i kinda think if we want conf image cache subdirectory name to mean the same for vmware and libvirt if possible if we added a conf vmware make cache folder unique that controlled if you add the my ip to the conf image cache subdirectory name it would be much simpler admins that want to share the folder then just set conf vmware make cache folder unique false then they configure the cache directly just like libvirt folks by configuring conf image cache subdirectory name

[ 0 ]

let use here id u id g

[ 0 ]

Spacing here seems wonky

[ 1 ]

should periodictasks be derived from object

[ 0 ]

i am not sure why we need to mock utils execute twice utils execute is mocked at l already

[ 0 ]

m sum note currently does not work for large objects

[ 0 ]

i would prefer you catch the most specific thing s possible otherwise you start accidentally catching accidental things in the future and it is hard to find the real bugs

[ 0 ]

i think it would be better to explicitly add lazy true here just so it is clear what that true is for

[ 0 ]

actually there is already a command for taht restore default command so i guess that is fine but at least add some comment below to explain the hack because that is really not obvious and in years a poor dev will stumble upon this and wonder what the fuck

[ 0 ]

should be end execute disksetup

[ 0 ]

oh, damn, rookie mistake there.. I even tested with non-basic lands specifically and didn't verify other card types \U0001f926... fixed

[ 1 ]

nit the line should end with a colon

[ 0 ]

both lines are useless here

[ 0 ]

removed the file from the cl

[ 0 ]

This will make it sleep, fucking shit up, i'll pr it to your branch the proper way to do this

[ 1 ]

right now i am waiting for more feed back on if the darn conditions are even working as intended right now.

[ 1 ]

useless

[ 0 ]

please use switch error for unknown arch type should be the default

[ 0 ]

nevermind i see they are still needed of course for both ipam backends my mistake i will restore them

[ 0 ]

this overwrites test content types assertvaliderrorresponse and is redundant with expected status below which uses assertresponsestatus anyway i believe this whole def can should be removed

[ 0 ]

observe that THE TABLES HAVE TURNED, and now you are in control of a devastating cocksucker artillery machine of your own8. go get like 8 more of them and have fun

[ 1 ]

Having the staff handle it requires a for loop or using locate so this is ~technically better~ even though it's weird

[ 1 ]

your prefs never blow up w o registering because runeviction seems to not be tested

[ 0 ]

C'mon guys, this is getting ridiculous.

[ 1 ]

it literally has the name of the machine and the id of the machine so you can look at chat log and see what you linked or unlinked to what incase you inevitably fuck up

[ 1 ]

agreed with paul that we should create a wrapper for the kill function to replace all the kill call in this file probably can do it in a separate cl maybe something like this bool killprocess int pid bool killed this will return true if signal is sent or the process is already killed false otherwise the caller can use the killed to check if the process has already exited

[ 0 ]

> That's how I know this test was never run. I don't see how I can be wrong about that. Are you calling me a liar? Did you run the test?

[ 1 ]

> Just wondering, what for real use cases should force you to put a script in the head of the page. The real world of mass-market CMS distribution. If you want to super optimise YOUR Joomla site then go for it, however a mass-market solution has to cater for everyone, from idiots to senior developers...

[ 1 ]

incompatible with python i think it is better to write something like this try import cpickle as pickle except import pickle

[ 0 ]

seems like if you do not need the inputs you could just lump them all together lambda a k self ensure transaction is closed

[ 0 ]

You already did. The fucked up characters were in master

[ 1 ]

thank you very much for your review this is really a stupid error due to my carelessness i will fix it in next patch

[ 0 ]

job labels job labels lstrip

[ 0 ]

This really looks like a pain in the ass to manage. Does VS do this automatically?

[ 1 ]