text
stringlengths
1
5.2k
labels
listlengths
1
1
collateral damage from juggling branches i got rid of it
[ 0 ]
i think you can leave these two out they have to be included by their mocks
[ 0 ]
This is not about trig functions, also `s=series(S(1)/(1-x),n=99)` takes 4 seconds, which is ridiculous.
[ 1 ]
nit pid might be better also make sure that this gets refreshed properly
[ 0 ]
Oh baby, speak more dirty to me.
[ 1 ]
I think you really fucked up
[ 1 ]
i am not sure how useful this test really is i mean the call could return ok with a body of this is all junk and it would pass this test
[ 0 ]
i think gerrit will handle this correctly since signed off by is a git label all my commits are structured similar to this one from my gitconfig unless my configs have gone bonkers
[ 0 ]
args and kwargs are needless
[ 0 ]
what is f and s please give sensible names and why alert
[ 0 ]
One of these words is rotated, one is reversed It's fucked up
[ 1 ]
useless cross depends task rabbitmq already depends on primary rabbitmq
[ 0 ]
@amolpednekar I know it's slightly ridiculous for this PR, but can you confirm compliance with the Developer Certificate of Origin https://docs.corda.net/head/contributing.html#developer-certificate-of-origin ?
[ 1 ]
I mean, we retained the bastard sword in the code. I think they re conceptually neat, but maybe for specifically admemery.
[ 1 ]
use cros build lib die you can give a nice error message with that as well rather than dying silently
[ 0 ]
use base mac objccaststrict here or use base mac objccast and remove the call to iskindofclass since objccast does the check already bool isequal id object dialogconfigurationidentifier other base mac objccast dialogconfigurationidentifier object return other other uniqueid uniqueid
[ 0 ]
put a todo dbrazdil here we should get rid of this
[ 0 ]
should be an elif as device owner can only be a single value
[ 0 ]
that s not what this is for wouldn t it be simpler to browse the dir and dump it is content to a zipoutputstream
[ 0 ]
this will throw a typeerror since you are passing a bool to raise
[ 0 ]
they already do, we changed it to be like this so you can add squeak component to things at runtime and you wont have to fuck with their datum outputs list since it's all handled internally
[ 1 ]
this should be moved to test hostops py as we are trying to completely remove test hypervapi py
[ 0 ]
Hey faggot, this fixes the OP problem
[ 1 ]
I'm going to sound like a little shit here but we could document these since it may be the last time for another thousand years that we look at any of the variable documentation.
[ 1 ]
you dropped the fips configuration check out the functional tests failures
[ 0 ]
> there's a lot of arbitrarily hardcoded nonsense in arma's respawn system This. So much. The whole system is crap, but what can they do? Changing stuff now would break so many missions.
[ 1 ]
# GAMEMODE CODE EVERYONE! Isn't it fucking ~~atrocious~~ ~~blatantly ignoring all object oriented programming techniques~~ BEAUTIFUL?
[ 1 ]
It is not done automatically and I swear I lost almost the entire weekend trying to get it to work. It's a fucking nightmare.
[ 1 ]
If I do that it breaks the previews. It's a lot of fucking bullshit, but whatever. Theoretically i should actually change the skinbone sprite to skinbone_m_s for that one to work as well
[ 1 ]
blatantly obvious is not a downside if the crew dont validhunt your ass.
[ 1 ]
i prefer you fake instance with none value in the host field otherwise without your fix this unittest still can pass
[ 0 ]
you re absolutly right just my understanding of the whole idea of migration in releases was wrong now adressing the issue
[ 0 ]
Dear god. ![a36](https://cloud.githubusercontent.com/assets/250995/17300622/0e2c2ed0-57c8-11e6-93f4-ef6f77547223.jpg) Can we add some comments into how this horrific magic works?
[ 1 ]
this has to be the or else gerrit will not know to track the submodule also it is a stupid broken git ini file so i think it is supposed to have leading tabs
[ 0 ]
seems like one of logger or interface should die my money is on interface dying
[ 0 ]
we have to force the cpu voltage to be volt during svs initialization currently we relies on cpufreq driver doing this by changing opp voltage and limit opp during svs init the reason for late init is to make sure cpufreq driver is working when doing svs init this might be a dirty hack but there is no clean way to handle the dependency issue in mainline kernel as i know
[ 0 ]
can you please add a comment here to explain why we kick users into chrome for desktop pwas
[ 0 ]
I'm not stale, you're stale, old, busted
[ 1 ]
I've said it before but damn this is fucked up
[ 1 ]
The fuck is this, why is this needed?
[ 1 ]
this is unnecessarily exececuted if both mbnumeric and mbdatetime are false
[ 0 ]
nit pep for multiline docsting here and l
[ 0 ]
should this be const here and elsewhere or do we intend to pass by value
[ 0 ]
neutron should be lowercase also suggested to add a link to the graphic
[ 0 ]
the idea is to get output in a following way if report is not speaking for itself show reporter report else show only report with your suggestion we will again receive bunch of useless information and blank lines for lines like
[ 0 ]
you really should be using timeticks for times
[ 0 ]
oh this needs to be defensive i think kill the renderer if begin frame response valid is already true
[ 0 ]
i would change this to a die since we have no idea how to handle it
[ 0 ]
Huh, didn't notice how screwed up the indentation on the transform stuff got when I moved it.
[ 1 ]
:tada: Awesome! This will save a ridiculous amount of time (defaults are very important). :)
[ 1 ]
should be a boolopt
[ 0 ]
hmm are you reimplementing a worse i gem object get pages
[ 0 ]
i was wondering why do not we just make these three separate arguments then in setup write something like usbpd info self args usbpd port self args usbpd port prompt self args min millivolt if any usbpd info and not all usbpd info self fail if checking port voltage please include all of usbpd port usbpd port prompt min millivolt
[ 0 ]
oh look someone who was calling hash cleanup listdir with positional args
[ 0 ]
can t we run q bgp agt independently without the server part think of multi node scenario where one want to run q bgp agt on the compute node instead of the network node i might sound stupid but just wanted to express my thoughts
[ 0 ]
remove it btw do you use pycharm
[ 0 ]
Damn, eagle-eye Beech!
[ 1 ]
> docs I don't think this needs docs. It's more a "bug fix", if you so will, we simply reported rubbish for user services, and you are fixing tht.
[ 1 ]
i think you get the vlan id from conf directly cls vlan conf l gw vlan
[ 0 ]
am i being dumb here but does not this raise the gnocchi notimplementederror class as opposed to an instance of that class would it be more correct to instantiate raise gnocchi notimplementederror
[ 0 ]
yeah i intentionally want this script to be rather dumb and examine everything in the host table i think the buckets should be sufficient to partition those that we really care about from the mostly bogus ones
[ 0 ]
If you port fucking TG Suit, so mark it in PR, not just "Replacing Travis with Github actions"
[ 1 ]
inner loop py is great for development but consider something like gnumd lib py for landing this
[ 0 ]
URGENT LOOK AT THIS ,If you see this you're gay 8===>
[ 1 ]
lazy init l plugin
[ 0 ]
recommend net radio prop instead of system or radio prop
[ 0 ]
run tests sh does not use tox and nor should it imo because tox is a pain obviously i have mox installed but this could be very annoying for the average person checking out the code and running run tests sh for the first time
[ 0 ]
wtf? I can change SIZE_KNOWN_RULES to another size, but not RULES? shouldn't it be <code>SIZE_KNOWN_RULES = RULES.length</code>?
[ 1 ]
im sorry it wasn't me \U0001f614 damn tg ports
[ 1 ]
Seriously ? That is your explanation ? Do better.
[ 1 ]
i share your annoyance and would love to see that changed
[ 0 ]
silly me thanks abhishek
[ 0 ]
m do not think so i will kill it
[ 0 ]
That's why I run my Sanguino at 1Mbps. But you'd need FTDI transceiver, and I hear that RAMPS lacks it. Well, sucks to be a RAMPS owner ;) Still, adding as a feature that can be switched on/off would be sensible. As long as somebody wants to do it ;)
[ 1 ]
BZ isn't used because you'll get admins all up in your shit
[ 1 ]
this describe block should be collapsed into a single test
[ 0 ]
what the fuck why did this work to begin with
[ 1 ]
IMHO it would look uglier, since need to convert the std::string to c_str when used
[ 1 ]
log agent advanced usage sounds perfect
[ 0 ]
actually it should be snapshotnotfound which like shareresourcenotfound is a subclass of storageresourcenotfound
[ 0 ]
why do not you use utils add boolean argument
[ 0 ]
this is an useless summary line please say which class is being removed here
[ 0 ]
i would like to add two more tests test get multi by name test get zero by name
[ 0 ]
Disgusting copypaste
[ 1 ]
eliminate backslash for continuation
[ 0 ]
It's ridiculous that you aren't doing this. Not doing it defeats most of the purpose of having workspaces.
[ 1 ]
adesc aname adesc adescription
[ 0 ]
@ericdill don't mean to be hostile, but I really do not want to be sucked in to further discussion about licensing. The license is clear. Whether it is BSD or MIT is so unimportant that I feel like it's a waste of my time even to write this response. Really, not hostile about making a conda recipe, but I'm finished discussing the license.
[ 1 ]
will nuke them the cookiecutter template appears to be out of date for environments
[ 0 ]
i think this might be getting more complex than it needs to be you are only batching the port delete and update events which you have already converted into cheap operations that just mark a network as dirty so my suggestion is to get rid of this queue and get rid of the changes to everything except for the port update and delete then just have the update and delete methods mark the network as dirty and then have this helper reload the dirty networks that will essentially achieve the same reduction in reload calls without any queue management logic does that make sense
[ 0 ]
this file is missing i suppose
[ 0 ]
use assertisnone tgt instead
[ 0 ]
this limiter should be removed
[ 0 ]
It totally doesn't matter but I'm still annoyed that you made Sniper capitalized when everything else is lowercase ahhh
[ 1 ]
use commonclassnames java util list and java util array list
[ 0 ]
of course sorry i am such a dunce today
[ 0 ]
vipin that would exceed the character limit and be a pep violation
[ 0 ]
remove i n
[ 0 ]
still these useless spaces
[ 0 ]
it's damn fast either way, but you're right!
[ 1 ]