text
stringlengths 1
5.2k
| labels
listlengths 1
1
|
|---|---|
no, this is becoming ridiculous to have a proliferation of names like this that the kernel doesn't use, which forces users to copy/override files. This whole file is a mess - we don't want users to change defaults in an installed setup.
|
[
1
] |
hell/moon nazis are so much cooler than reenactors though
|
[
1
] |
Why not store the actual damn typepath and skip a step
|
[
1
] |
this raw is pretty ugly and we should probably add a define in a future cl yes that is my fault
|
[
0
] |
recommend pcre options pcre anchored
|
[
0
] |
we should indent these out to make it easier to read
|
[
0
] |
https://github.com/OpenRCT2/OpenRCT2/issues/5496 Reading this, I should say that I do have a copy that has both expansion packs, Time Twister and Wacky Worlds.
|
[
1
] |
these were dupes of includes up above and were removed
|
[
0
] |
ditto should reraise instancedeployfailure
|
[
0
] |
whimper i hate that autotest and pep cannot agree on this
|
[
0
] |
You're a life saver. This fix works great. It's a damn shame they wont roll it in, it's like pulling toe-nails with these people. They can be as stubborn as the clients who refuse to upgrade their browsers.
|
[
1
] |
Indentation. Also this `key1` nonsense is unreadable as hell. Use proper names.
|
[
1
] |
cool catch sounds sweet
|
[
0
] |
a suggestion here might be to have a single add cleanup with wait function instead of relying on the caller to call both addcleanup and then append wait might look something like this def add cleanup with wait self resource id delete callable wait resource error status error exc type nova exceptions notfound self addcleanup delete callable resource id wait dict self cleanup waits append wait dict and then called like so self add cleanup with wait server id server delete self compute client servers
|
[
0
] |
i think admin only can be removed
|
[
0
] |
femtonit return not needed
|
[
0
] |
Something screwed up when I checkout the code, I've never convert these back to C-style...
|
[
1
] |
derp last minute rename fail on my part
|
[
0
] |
Damn this Python 2 nonsense. How long are we going to have to support that archaic version? :stuck_out_tongue:
|
[
1
] |
And as long as you're okay reviewing rubbish PRs from incompetent people who don't really have a clue! :)
|
[
1
] |
this function is useless anymore
|
[
0
] |
Have you verified this works? From what I can read, it looks like the examine description will be fucked up
|
[
1
] |
probably a dumb question but what is the for
|
[
0
] |
I always knew nymphs were demonic.
|
[
1
] |
teardownclass could be removed if it only calls super teardownclass
|
[
0
] |
i find this comment a bit confusing the proxy does not own the delegate in fact it is usually the delegate that ends up owning the proxy if you change it to a const reference then all interface methods will need to be const
|
[
0
] |
need to distinguish with the insecure version because when it is made a pubic api ppl are not confused
|
[
0
] |
are you converting to be backward compatible if so that is not necessary
|
[
0
] |
but we are always going to ensureraredata on the next line if we hit these branches
|
[
0
] |
Why is this balloon alert so long WTF
|
[
1
] |
we want to remove run test sh c
|
[
0
] |
silly nit there needs to be a blank line here
|
[
0
] |
this one is also fc code and should be removed
|
[
0
] |
wtf is this doing, why is it only done when `IsFile` is null, and why is it done if `dto.Path` points to a file?
|
[
1
] |
no need to do this self node already uses fake driver with fake power interface
|
[
0
] |
wtf am i doing fix this
|
[
1
] |
this should be a portopt rather than an intopt
|
[
0
] |
Did you copy this block, because if you did you should make it a proc a la can_suck(user, target) or something of the sort.
|
[
1
] |
yeah ai's cant examine due to being a shitty camera
|
[
1
] |
Please, do not compare booleans to `true`. Ever. It is just ugly. Also, space before brace. ```suggestion if (isInvincible) { ```
|
[
1
] |
considering internals are Very Fuckin Important, may want to put this as the first thing in the list
|
[
1
] |
please give me a big fat readme to indicate my purpose and how i am supposed to be used
|
[
0
] |
oh, crap. missed this.
|
[
1
] |
i think l l is one command better use
|
[
0
] |
mauro rodrigues yeah i saw your comment and was puzzled so maybe ann and i are missing something would you point out exactly where is that tear down method that deletes the resources
|
[
0
] |
too many sent s here either the first sent should be removed or the is going to be sent should be removed
|
[
0
] |
colons are bad typecast that shit
|
[
1
] |
please change all stubbing out of new to stuboutclasswithmocks as explained above
|
[
0
] |
banging head on table thanks
|
[
0
] |
that initialization is useless
|
[
0
] |
it is harmless and we want them all dead anyway this will be called from unstack sh or clean sh and unfortunately localrc may have changed
|
[
0
] |
There seems to be a lot of this pattern. Wouldn't it be cleaner to move the QDEL_IN to a part of Beam(), so we don't end up fucking somebody up downline?
|
[
1
] |
i guess because we are not calling auth plugin get token anymore
|
[
0
] |
this looks fucking scary. Create a new variable and pass it to this function. It looks like you're passing multiple parameters.
|
[
1
] |
Damn, didn't see IStats.
|
[
1
] |
uploadartifact only supports uploading to self upload url
|
[
0
] |
Heh, brain fart. Will just do that.
|
[
1
] |
Decided to suck it up and go with mandibles. I can only hope all the other entomonerds in the audience can forgive me.
|
[
1
] |
Oh crap, you're right! Good catch
|
[
1
] |
ok this was c c from the transformationstep remove maybe we should clean them up
|
[
0
] |
all of these options are pretty bad maybe least bad while not breaking the build would be to add something to request i would actually stick with a dumb boolean or something instead of yet another interface having retrypolicy and newretrypolicy will be even more confusing if it is unclear that they are both actually used something like request setshouldretryservererrors boolean
|
[
0
] |
this should be die
|
[
0
] |
Damn that automatic indentation. Will fix!
|
[
1
] |
tl;dr fuck off with this shit celt
|
[
1
] |
Shit I pasted in the wrong thang.
|
[
1
] |
@distributedleetravis Sorry dude, can I ask for a re-review, I changed how this works to be less confusing and rubbish.
|
[
1
] |
And how the hell do you want me to host a site on that domain? Abusers, would I have to wait weeks for his ridiculous response? Abusers, you are fucking everyone you want with your software garbage. I'm going to denounce you everywhere I can.
|
[
1
] |
commit should be removed too
|
[
0
] |
the daemon should be responsible for exiting itself when the device goes away if you really need to rely on a signal then do it via a more reliable route like dbus or a named socket there is no guarantee that the pid stored in this file matches the daemon and you are not just randomly killing another process in the system you also need to consider the scenario that more than one usb device w this vid pid combo are plugged removed
|
[
0
] |
Okay just be aware unEquip updates icon states and puts it on the ground and shit.
|
[
1
] |
Captialization messed up.
|
[
1
] |
seems this belongs under the deprecations section rather than upgrade
|
[
0
] |
assert should be inserted before called once with
|
[
0
] |
@markturansky our templates include a PVC, it would be very clumsy to start over from the same template for a second, third time, without deleting the old PVC...
|
[
1
] |
damn mad my tests didn't catch that :-/
|
[
1
] |
put these at top and undefs on bottom of file. If you need to you can add yuck to clarify
|
[
1
] |
Is GitHub screwing with me or is this line indented twice?
|
[
1
] |
does that seriously not work? Fucking dm.
|
[
1
] |
Damn, I was so focused on the ones in IniReaderTest that I completely overlooked these :/
|
[
1
] |
> I'd recommend using an overlay rather than making separate icon_states for gold and normal wheelchairs. thx i dont know shit about dick in terms of spriting
|
[
1
] |
you should use processutils processexecutionerror instead
|
[
0
] |
Hurry up with the state hooks already @tylershuster this is ridiculous
|
[
1
] |
need a double colon here
|
[
0
] |
Oh, holy crap! I didn't know it made a copy! Yeah, I definitely see why that's better now. Thanks.
|
[
1
] |
Oh damn! This error message comes from gRPC: https://github.com/grpc/grpc/issues/11411 It's almost impossible to understand what is going under the hood (except there is some kind of connection issue between pusher and back)
|
[
1
] |
You read the title, didn't you, cocksucker?? Pretty self-explanatory.
|
[
1
] |
chris if we use smoke or here then we will have iteration on gates which is almost useless look at this result neutronnetworks create and list floating ips
|
[
0
] |
remove i n
|
[
0
] |
Why the hell is this in here?
|
[
1
] |
why spawn an external kill process rather than using os kill
|
[
0
] |
good lord. just put a telebeacon in space and suck people out of rooms
|
[
1
] |
this description is weird, since it's like, not broken at this point? it's literally perfectly fine.
|
[
1
] |
idkwid lol but LaysTerrain: Template: 671 TerrainTypes: Clear, DirtRoad, Rough, Road makes it actually show that one tile 671 has Give it 593 if you want to see 4 tiles as a temp solution It works but it feels like nonsense https://dl.dropboxusercontent.com/u/58357192/OpenRA/pavee.png \xaf_(\u30c4)_/\xaf
|
[
1
] |
yes this is rather dumb
|
[
0
] |
possibly because they suck at cutting anything other than bone or metal. Small aperture cant fit much flesh in it, rounded point, and awkward handles means it would take hours to effectively chew through a small animal like a dog
|
[
1
] |
api/faggots/login (or something similar)
|
[
1
] |
ditto as above consider create activate task
|
[
0
] |
you ignored my comments upstream in v that the config bootdata and the memcpy no longer really belong in the iomap function
|
[
0
] |
Oh Lordie. It was probably only supposed to be 6800, not 62000....
|
[
1
] |
lp moved to the next mu note should be removed
|
[
0
] |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.