text
stringlengths 1
5.2k
| labels
listlengths 1
1
|
|---|---|
should pass in a function and the id e g def delete credentials self id fn if id fn cr continue then call like self delete credentials project id lambda cr cr project id then do not need to have the complicated logic below
|
[
0
] |
yes kill edp for dp test and there is too many edp status okay the other one is at rk gru kevin dtsi
|
[
0
] |
doh silly docstrings
|
[
0
] |
damn, I thought I removed that s already...
|
[
1
] |
i am not sure we should stab function by invoking it
|
[
0
] |
i wonder why these are brought in multiple times admin password and admin tenant name and admin user are dupes
|
[
0
] |
my instnace should be my instance
|
[
0
] |
ipxe timeout should not be boolean better to use it as ipxe timeout
|
[
0
] |
check for suid sandbox i d also pass in the renderer pid to be explicit but your call
|
[
0
] |
Just move these shit to a single class. Make it clear
|
[
1
] |
bugger i missed one pep should actually complain if there is an extra indent here not sure why it is not
|
[
0
] |
same note as before about this pattern if the read fails you are writing garbage to the register maybe we do not care but then checking the tcpc read result is not useful either
|
[
0
] |
useless untested perf nit opinion basically we could actually do if if nova object name in db obj since it is a string which might be slightly better than doing full json loads twice
|
[
0
] |
call me stupid but i still do not know what a console proxy is what it is supposed to do after reading this i do not know if that is the intended purpose of these strings however
|
[
0
] |
drop all puppet jobs
|
[
0
] |
if vipportcount
|
[
0
] |
we do not need a binary blob if the egl loader or any other piece of code needs a binary blob we will create a version api function
|
[
0
] |
# this isn't a bug and YOU FUCKING KNOW IT, DON'T YOU FUCKING DARE SAY IT'S A FIX
|
[
1
] |
would be useless after applying suggestion below
|
[
0
] |
This is pretty shit senpai
|
[
1
] |
oh it looks better in my pc chrome i am interested in why i can see a useless indent in my ios edition
|
[
0
] |
that s a typo i do this the whole time stupid bash messing with my mind fixed
|
[
0
] |
Damn I thought you could typehint `resource` :disappointed_relieved:
|
[
1
] |
Apologies for being anal (hurr) but could you please use full pathnames? Bonus points for doing it to the rest of the file. i.e. /obj/item/trash/can
|
[
1
] |
Well, I am rather clumsy with git. I do not know how to handle this things.
|
[
1
] |
ah crap I missed that in the cleanup
|
[
1
] |
ok if this is just for shill client side then you need to use only dbusdaemon and not dbusservicedaemon
|
[
0
] |
When creating a new implementation it's the opportunity to get rid of baggage like that and enforce a style and not dragging old crap along.
|
[
1
] |
Yeah, usually xenobio antags go on phazon rampages or release slimes. It's usually a traitor miner that releases a shit load of monsters.
|
[
1
] |
perhaps in this case garbage collection is performed in the allocating thread
|
[
0
] |
call me a fool but i only sussed this thanks to sylain s comment using lstrip the item replace format from below or adding a comment would help here
|
[
0
] |
sus as hell on this but it seemed to work in game.
|
[
1
] |
this could be just return verify result line is useless
|
[
0
] |
maybe make all the keys lowercased
|
[
0
] |
Holy fuck it turned red, what magic is this
|
[
1
] |
If you know they should all be mobs, wouldn't this be more efficient, with not having to cast it? Or can it lead to some fucky behavior?
|
[
1
] |
omigod they suck. uuuugggh really hate calling this update
|
[
1
] |
this line of vws here breaks my mental parser i would keep the entire if block together
|
[
0
] |
these are cheap simple getters
|
[
0
] |
useless now is instance always here
|
[
0
] |
run tests sh does not use tox and nor should it imo because tox is a pain obviously i have mox installed but this could be very annoying for the average person checking out the code and running run tests sh for the first time
|
[
0
] |
use self msg
|
[
0
] |
kill whitespace
|
[
0
] |
Think I got it. PublishItemsOutputGroup doesn't depend on GeneratePublishDependencyFile in anyway. It never requires ComputeFilesToPublish. But the Worker and Web SDKs sorta change that up, resulting in it working.
|
[
1
] |
ok but try_cast should still be able to fix it aunt it needs more hints)
|
[
1
] |
actually should we kill native suffix and fix benchmarks android mk in the same way you already fixed tests android mk
|
[
0
] |
> I love the overall simplicity of this change, but it is a reminder that the way the navigation works in the site template is RIDICULOUS and complex. I'm getting familiar with templating here but generally agree - not too much flexibility there as well.
|
[
1
] |
this check useless here
|
[
0
] |
this methos these methods
|
[
0
] |
NO STOP FUCK GODDAMN IT # INSTEAD OF JUST PLACING SOME GROUNDING RODS YOU IGNORED ME BECAUSE LOL GOOFBALL AND COPYPASTED THE ENTIRETY OF THE FUCKING TESLA ZAP PROC
|
[
1
] |
also this file is using fake for these mocks so let us call this fake also
|
[
0
] |
ok but how about killing some of the other primaries to force the get to pass over the bad etag e g
|
[
0
] |
this is a discrimination against the only one subnet lonely subnet
|
[
0
] |
i think the caller should handle delete or have an arg delete on fail to control the behavior i thinking making this class very dumb to only do one thing per api would make it easier for it to become a generic library
|
[
0
] |
i suggest to remove sleeping it will affect the duration of the test execution you can leave method as it is or add logging for example
|
[
0
] |
pretty sure `TIME` gives you world timeofday, I'm only really interested in number of ticks, so I think `world.time` is the right call here unless it does some weirdass byond stuff I'm not aware of.
|
[
1
] |
precisely why the table with the fk must be dropped first
|
[
0
] |
@liggitt can you spot any dangerous url escaping nonsense this would cause if a ref could have a slash?
|
[
1
] |
can we kill the base classes too
|
[
0
] |
ok good well then now i finally know because everyone else gives me vague shit answers about it.
|
[
1
] |
should be ocf run kill
|
[
0
] |
why not changing is deadlock implementation indeed is deadlock returns false for postgres ha deadlocks
|
[
0
] |
yeah just kill those lines
|
[
0
] |
author should be removed
|
[
0
] |
sorry that was stupid
|
[
0
] |
make system metadata link to the section below s system metadata ref sysmeta
|
[
0
] |
add it here doc is a lint like job and those belong into pep
|
[
0
] |
remove user id none since that is the default
|
[
0
] |
i am using std function perhaps this include is not needed for it removed
|
[
0
] |
Ah shit that was a replace all
|
[
1
] |
should make sure admins can force this on/off if they fuck it up/succeed
|
[
1
] |
i like slaves and aleksey kasatkin too
|
[
0
] |
break should be removed only one node will be instantiated with break
|
[
0
] |
if this is the only one on the next line we probably only want one extra tab
|
[
0
] |
Faggot added. Of course it's facts
|
[
1
] |
if streaming will be handled in nova could you wrap the operation using zlib perhaps to compress the data sorry if this is a stupid question
|
[
0
] |
Looking at https://github.com/owncloud/user_ldap/pull/218, it seems some logic is already in place in but might not be consistent or is clumsy. Would be good to have this streamlined.
|
[
1
] |
set tag port id
|
[
0
] |
ha boy... what did you do?
|
[
1
] |
this use slave kwarg is not used anywhere not that i really understand what this slavery business is all about
|
[
0
] |
this at least looks odd are you sure about the roles of the reverse iterators
|
[
0
] |
why do you need a mock can t you just set the state self lbm vxlan group rv
|
[
0
] |
should these params be lined up the only reason i say should is b c it is such a pain
|
[
0
] |
Where was this intended? Its awful, nobody would want this. Clock cultists don't appear to have silent deconversion either. Cultists dont want it because having sec keep you hogtied because they arent sure is bad, and obviously sec doesn't want to sit around having to deal with "DID HE DECONVERT?" memes either. @ExcessiveUseOfCobblestone Obviously its the argument that decides whether deconversion gives the "_______ reverted to their old faith!" message.
|
[
1
] |
why we removed the access because it was a huge pain in the ass
|
[
1
] |
THEY and instead of absorbing make you eggs which grow into more THEY It's the fact it can all be ruined by one faggot holding a key That makes it horrible. if you make ORGANS controllable individually its better than the whole mob controlled by all leg pounces, claw hurts, tentacle grabs
|
[
1
] |
you might want to update that comment to reflect that when nofork is set you want to be pid
|
[
0
] |
Damn :( leftovers from a previous try... Thank you!
|
[
1
] |
is the executor going to initiate this kill
|
[
0
] |
I'll tweak and redo it properly with normal powershell later. I kinda rushed this and mostly copied from the bat file I made (that then didn't work because batch files are a bitch to make work)
|
[
1
] |
should this be a bullet item too
|
[
0
] |
if urldata must be destroyed before the urlindex then we should document that here also in tryinsert and probably in the urldata class
|
[
0
] |
thanks i did not even know about that interface done
|
[
0
] |
nit read only
|
[
0
] |
Isn't a runtime in here the only thing that led you to discover this bug? If you add these checks you will not know if someone fucked up again, if I'm understanding correctly.
|
[
1
] |
Remove faggot and lesbian smiles
|
[
1
] |
the modal id is the same for manageqosspecassociationview we should change it to something else
|
[
0
] |
@RyanCavanaugh I'm assuming this is a decision that was agreed by the whole team. In that case I feel I can't reason out how they came into this strange conclusion. It's one thing to feel disinterested or dis-motivated about a subject such that it doesn't "feel" like the right thing to do (which I suspect is the case here). It's another thing to scheme up a completely absurd line of reasoning and convince yourself and an entire group of people of it. I'm sorry but I feel like I'm wasting my time here. This doesn't sound very serious to me.
|
[
1
] |
yet another dbaccess
|
[
0
] |
hm as far as i can see you never reset requests request which imo is a bad thing a better way to accomplish what you want is by using mock patch in a context manager mock request mock mock mock request return value requests response mock request return value status code mock request return value headers x server management url blah com x auth token blah with mock patch requests request mock request instance authenticate mock request assert called once with mock any mock any timeout headers mock any verify mock any config mock any this will isolate the patch on requests request to just the call to instance authenticate i will also frequently use the decorator form of mock patch in this instance e g something like mock patch requests request return value requests response def test client with timeout self mock request mock request return value status code mock request return value headers instance authenticate mock request assert called once with
|
[
0
] |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.