showvikdbz/code-reviews · Datasets at Hugging Face

text stringlengths 1 5.2k	labels listlengths 1 1
this is unused and should be removed	[ 0 ]
this is rather unpleasant profiling info are collected during gc which means that the code below could race and end up using a invalid pointer	[ 0 ]
these min max are not needed for this controller i just delete them then	[ 0 ]
nit added braces because the body is longer than one line	[ 0 ]
wrong managejackclasspath putjackclasspathonpath	[ 0 ]
how about if opts mtargetapi opts mbitcodestorage bcst cpp code opts memit false if opts memit opts mbitcodestorage bcst java code	[ 0 ]
thanks dazhao i will remove all of these blanks	[ 0 ]
Won't this fuck with any other attack that knocks somebody down? Not that a lot of code uses knockdown.	[ 1 ]
since you are using kwargs it would help to know what the possible args are that you support i have discovered instance id key and value also it appears that either a metadata must be provided or b metadata key and instance id must be provided or c a key and a value must be provided but there is more i am curious why you chose kwargs for these three while you have named args for metadata and metadata key which are both defaulted to none why not this may be a dumb suggestion so my apologies if it is make the signature just init self context kwargs and glean the rest as you go	[ 0 ]
you mean testlbaasservice test main it seems like an example of useless tests	[ 0 ]
`if(idle_threatds.len > PU.max_idle_programs)` much simpler, no +1 fuckery.	[ 1 ]
Damn, I would have gone for that.	[ 1 ]
you cannot use math max this values just curious	[ 0 ]
Mech code is damn ancient and shitty at that. It predates qdel so it has 0 care to give about reference clearing.	[ 1 ]
i could put it into low energy constants h we can have something like a common uuids h later too	[ 0 ]
This feels dirty and pointless, we are always setting it to `msiVersionInfo()` one way or another.	[ 1 ]
Customization makes the interface clumsy, complex to support, and in many cases means that the UX is bad and should be tuned by customization instead of doing it right. There are not so many exceptions for useful customization.	[ 1 ]
> nope, not happening. the Auto111 syntax is rubbish Ha ha ha as much as I agree with you, it's becoming the defacto standard \U0001f600 I prefer your syntax too...	[ 1 ]
honestly i am happy to remove is parent i do not care much the only value it provides is an earlier failure to an end user without it creating the subport later would just fail instead i will drop it from the spec and see who gets upset	[ 0 ]
nit we d better use int digest size vb digest size vb hash sha here and the other two lines below as we do in calculatehash	[ 0 ]
grubby should be listed here	[ 0 ]
unfinished docstring	[ 0 ]
remove repo it is redundant	[ 0 ]
this probably indicates we need a common base class imo which would remove the duplication and avoid imho ugly hacks like this	[ 0 ]
why do not we use a common method execute cmd to execute all comands	[ 0 ]
this needs line wrapping to a normal git length cols	[ 0 ]
This is nonsense	[ 1 ]
probably should add some logging both in the case that you generate a core dump and in the case that you do not that way you can figure out why the code is not generating a core dump	[ 0 ]
and more constructively to avoid that you will want to also check syncservice issyncfeatureenabled	[ 0 ]
call destroy your body of your clear	[ 0 ]
this is gross is not there a thread safe way to do this like setting a static boolean guarded by a lock and waiting on the gate while it is false in the worker thread	[ 0 ]
its so much unneeded ugly code if I put it into code. whats the reason for no css?	[ 1 ]
Big Faggotthis fucking retarded extention breaks every fucking time i make a thread	[ 1 ]
these mocks should be done in test copy image to volume instead of here since they have no use here	[ 0 ]
catching exception so broadly bothers me it looks like in the cinder is down there is a connectexception that is raised which would be a more narrow catch it also seems like if we do have a catchall we should dump the details of here of the bdm to tell the admin that a resource was not cleaned up and might have leaked	[ 0 ]
CLA signed. It is a little ridiculous - fake signature, pdf form, need to sign anything in the first place.	[ 1 ]
please put the at the other side so sctokenarray ta and not sctokenarray ta	[ 0 ]
i am going to remove the rebuild action as this will abort the live migration	[ 0 ]
stack mock mock stack stack name stack complete stack mock mock complete stack stack name stack complete stack stack status create complete self mock orchestration stack get side effect stack stack complete stack this would provide the behavior you want right	[ 0 ]
you can use assertin and assertnotin	[ 0 ]
this fakeserver simulates contrail api server so this one act as backend for request api server	[ 0 ]
o o	[ 0 ]
should it be openstack openstack	[ 0 ]
you want not	[ 0 ]
Good news, I have came up with a more generic solution for all pointed spells, so this ugly specific check is no longer needed, more in the latest commit.	[ 1 ]
these names are not meaningful they should be called something like num volumes total size and volume size and there should be an additional one for num volumes per host	[ 0 ]
nit dies should dies should	[ 0 ]
stupid question does addentry delentry avoidance buy us less race conditions to minimize rdebug crashes or it is a performance optimization	[ 0 ]
youre unepic fuck you	[ 1 ]
wow i have only just realized all out db cols are utf what a waste	[ 0 ]
derp still does not work for cinder	[ 0 ]
that d get rid of silly things like this cast	[ 0 ]
Damn. What should I use in the meantime, then? 400, something higher...	[ 1 ]
This is gonna look ugly as hell, why we doing this?	[ 1 ]
i wonder why these are brought in multiple times admin password and admin tenant name and admin user are dupes	[ 0 ]
the cl does not delete it earlier making it a member means it is deleted at end of urlloaderfactoryimpltest scope and it being the first member means it is deleted last by c rules this is usually the paradigm for testbrowserthreadbundle make it the first member so it outlives everything explicitly managing it via unique ptr here merely resulted in it being destroyed before resourcemessagefilter which tries to post tasks in it is tear down	[ 0 ]
kirill you are wrong this command kills only parent process instead of killing all processes like pkill does	[ 0 ]
i think added fields self policy attrs self orig fields	[ 0 ]
this should be attrs none please rebase your patch set and you will see how other fakes handle this	[ 0 ]
Damn you, copy/paste! Good catch thanks.	[ 1 ]
Re: https://github.com/astropy/astropy/issues/11038#issuecomment-727070545 Thanks, @saimn ! Personally, I still find it ridiculous that Actions does not support that natively and we have to rely on third-party apps.	[ 1 ]
the lifetime of the expectations is equal to that of the mocks so they do not go away with the scope but in fact there is no need for the scoping removed	[ 0 ]
images dir should not be needed here	[ 0 ]
Why does this PR have a ridiculous number of reviewers? https://github.com/kubernetes/kubernetes/pull/60771	[ 1 ]
indeed mpu protect ram already did the same thing in commom system c i think this part is useless	[ 0 ]
no kevin say it is not so you like staticmethods	[ 0 ]
i think this message should be removed	[ 0 ]
Those are 'footprints' for wheelchairs. I'm talking about shit like gib1 and gib5, except much worse. I'll get you a picture from another codebase.	[ 1 ]
should self tenant name be self project name	[ 0 ]
boah you are seriously too picky	[ 1 ]
my fault i missed this one from previous review we should return empty list migrations when there is not any running migration and did i miss something we said on irc we return all type migration in this api the last sentence say we only return live migration at here	[ 0 ]
useless	[ 0 ]
Afraid to ask, what the hell is this? Tag check was so slow?	[ 1 ]
put a before openstack so you get openstack congress	[ 0 ]
remove this useless point	[ 0 ]
nitpick todo is supposed to be followed by a colon	[ 0 ]
this is wrong you want to essentially copy the implementation from stack task destroy task scheduler dependencytaskgroup self dependencies resource resource destroy reverse true	[ 0 ]
well this sucks, means it can't be used by the mobile clients :crying_cat_face:	[ 1 ]
what a beautiful brainfuck	[ 1 ]
die die die xml i would remove this hideous reminder of a long lost sad world	[ 0 ]
dumb idea in that case last first	[ 0 ]
not int sock opensocket if sock	[ 0 ]
Fuck I forgot to bracket it	[ 1 ]
fucking case sensitivity...	[ 1 ]
holy shit all of this is called per tick because of processing what the fuck is this code	[ 1 ]
this should be a uuid i think all id s here id volumeid serverid are uuids	[ 0 ]
Number of commits look wacky. Maybe rebase?	[ 1 ]
use mock thread instance mock magicmock isalive mock magicmock return value false remove l	[ 0 ]
this is a nice little use the data as is for formating hack	[ 0 ]
Let me check today if I get chance. The original work I did was outside this function and worked using the same method (and disgusting here-string!); I'm thinking I didn't remove the privilege before going back and testing this so it looked like it worked but hadn't done anything.	[ 1 ]
make it more pythonic self inactive ip self active ip self active ip self inactive ip	[ 0 ]
Exhaustive enum case handeling, like everywhere else so that we don't get a long ass compiler warning for every enum value not handled (monster mode does not just contain walk directions)	[ 1 ]
not if main plugin contrail	[ 0 ]
i will satisfy your thirst for pedantry in the method s docstring	[ 0 ]
this if statement if useless this check is already done in self assert data in result result msg	[ 0 ]
argh i really should get this into pep env	[ 0 ]
os brick is not usable in kilo so this comment should probably be removed	[ 0 ]
Honestly for ease of "remembering" what the hell is the name of the factory or graph of whatever. When using intelliJ I often do Shift-Shift followed by `GJGF` of `GFJ` when I am desperately trying to find the GrkanJanus thing. This makes is easier because I can just do GraTx.... and all the options will appear. I.e. Filipe dumb, autocomplete smart.	[ 1 ]
Oh daaaaamn That's from a change in the recent version I need to add a merge and roll out a patch 0_0	[ 1 ]
But this will fuck up day-long profile logs so badly	[ 1 ]

this is unused and should be removed

[ 0 ]

this is rather unpleasant profiling info are collected during gc which means that the code below could race and end up using a invalid pointer

[ 0 ]

these min max are not needed for this controller i just delete them then

[ 0 ]

nit added braces because the body is longer than one line

[ 0 ]

wrong managejackclasspath putjackclasspathonpath

[ 0 ]

how about if opts mtargetapi opts mbitcodestorage bcst cpp code opts memit false if opts memit opts mbitcodestorage bcst java code

[ 0 ]

thanks dazhao i will remove all of these blanks

[ 0 ]

Won't this fuck with any other attack that knocks somebody down? Not that a lot of code uses knockdown.

[ 1 ]

since you are using kwargs it would help to know what the possible args are that you support i have discovered instance id key and value also it appears that either a metadata must be provided or b metadata key and instance id must be provided or c a key and a value must be provided but there is more i am curious why you chose kwargs for these three while you have named args for metadata and metadata key which are both defaulted to none why not this may be a dumb suggestion so my apologies if it is make the signature just init self context kwargs and glean the rest as you go

[ 0 ]

you mean testlbaasservice test main it seems like an example of useless tests

[ 0 ]

`if(idle_threatds.len > PU.max_idle_programs)` much simpler, no +1 fuckery.

[ 1 ]

Damn, I would have gone for that.

[ 1 ]

you cannot use math max this values just curious

[ 0 ]

Mech code is damn ancient and shitty at that. It predates qdel so it has 0 care to give about reference clearing.

[ 1 ]

i could put it into low energy constants h we can have something like a common uuids h later too

[ 0 ]

This feels dirty and pointless, we are always setting it to `msiVersionInfo()` one way or another.

[ 1 ]

Customization makes the interface clumsy, complex to support, and in many cases means that the UX is bad and should be tuned by customization instead of doing it right. There are not so many exceptions for useful customization.

[ 1 ]

> nope, not happening. the Auto111 syntax is rubbish Ha ha ha as much as I agree with you, it's becoming the defacto standard \U0001f600 I prefer your syntax too...

[ 1 ]

honestly i am happy to remove is parent i do not care much the only value it provides is an earlier failure to an end user without it creating the subport later would just fail instead i will drop it from the spec and see who gets upset

[ 0 ]

nit we d better use int digest size vb digest size vb hash sha here and the other two lines below as we do in calculatehash

[ 0 ]

grubby should be listed here

[ 0 ]

unfinished docstring

[ 0 ]

remove repo it is redundant

[ 0 ]

this probably indicates we need a common base class imo which would remove the duplication and avoid imho ugly hacks like this

[ 0 ]

why do not we use a common method execute cmd to execute all comands

[ 0 ]

this needs line wrapping to a normal git length cols

[ 0 ]

This is nonsense

[ 1 ]

probably should add some logging both in the case that you generate a core dump and in the case that you do not that way you can figure out why the code is not generating a core dump

[ 0 ]

and more constructively to avoid that you will want to also check syncservice issyncfeatureenabled

[ 0 ]

call destroy your body of your clear

[ 0 ]

this is gross is not there a thread safe way to do this like setting a static boolean guarded by a lock and waiting on the gate while it is false in the worker thread

[ 0 ]

its so much unneeded ugly code if I put it into code. whats the reason for no css?

[ 1 ]

Big Faggotthis fucking retarded extention breaks every fucking time i make a thread

[ 1 ]

these mocks should be done in test copy image to volume instead of here since they have no use here

[ 0 ]

catching exception so broadly bothers me it looks like in the cinder is down there is a connectexception that is raised which would be a more narrow catch it also seems like if we do have a catchall we should dump the details of here of the bdm to tell the admin that a resource was not cleaned up and might have leaked

[ 0 ]

CLA signed. It is a little ridiculous - fake signature, pdf form, need to sign anything in the first place.

[ 1 ]

please put the at the other side so sctokenarray ta and not sctokenarray ta

[ 0 ]

i am going to remove the rebuild action as this will abort the live migration

[ 0 ]

stack mock mock stack stack name stack complete stack mock mock complete stack stack name stack complete stack stack status create complete self mock orchestration stack get side effect stack stack complete stack this would provide the behavior you want right

[ 0 ]

you can use assertin and assertnotin

[ 0 ]

this fakeserver simulates contrail api server so this one act as backend for request api server

[ 0 ]

o o

[ 0 ]

should it be openstack openstack

[ 0 ]

you want not

[ 0 ]

Good news, I have came up with a more generic solution for all pointed spells, so this ugly specific check is no longer needed, more in the latest commit.

[ 1 ]

these names are not meaningful they should be called something like num volumes total size and volume size and there should be an additional one for num volumes per host

[ 0 ]

nit dies should dies should

[ 0 ]

stupid question does addentry delentry avoidance buy us less race conditions to minimize rdebug crashes or it is a performance optimization

[ 0 ]

youre unepic fuck you

[ 1 ]

wow i have only just realized all out db cols are utf what a waste

[ 0 ]

derp still does not work for cinder

[ 0 ]

that d get rid of silly things like this cast

[ 0 ]

Damn. What should I use in the meantime, then? 400, something higher...

[ 1 ]

This is gonna look ugly as hell, why we doing this?

[ 1 ]

i wonder why these are brought in multiple times admin password and admin tenant name and admin user are dupes

[ 0 ]

the cl does not delete it earlier making it a member means it is deleted at end of urlloaderfactoryimpltest scope and it being the first member means it is deleted last by c rules this is usually the paradigm for testbrowserthreadbundle make it the first member so it outlives everything explicitly managing it via unique ptr here merely resulted in it being destroyed before resourcemessagefilter which tries to post tasks in it is tear down

[ 0 ]

kirill you are wrong this command kills only parent process instead of killing all processes like pkill does

[ 0 ]

i think added fields self policy attrs self orig fields

[ 0 ]

this should be attrs none please rebase your patch set and you will see how other fakes handle this

[ 0 ]

Damn you, copy/paste! Good catch thanks.

[ 1 ]

Re: https://github.com/astropy/astropy/issues/11038#issuecomment-727070545 Thanks, @saimn ! Personally, I still find it ridiculous that Actions does not support that natively and we have to rely on third-party apps.

[ 1 ]

the lifetime of the expectations is equal to that of the mocks so they do not go away with the scope but in fact there is no need for the scoping removed

[ 0 ]

images dir should not be needed here

[ 0 ]

Why does this PR have a ridiculous number of reviewers? https://github.com/kubernetes/kubernetes/pull/60771

[ 1 ]

indeed mpu protect ram already did the same thing in commom system c i think this part is useless

[ 0 ]

no kevin say it is not so you like staticmethods

[ 0 ]

i think this message should be removed

[ 0 ]

Those are 'footprints' for wheelchairs. I'm talking about shit like gib1 and gib5, except much worse. I'll get you a picture from another codebase.

[ 1 ]

should self tenant name be self project name

[ 0 ]

boah you are seriously too picky

[ 1 ]

my fault i missed this one from previous review we should return empty list migrations when there is not any running migration and did i miss something we said on irc we return all type migration in this api the last sentence say we only return live migration at here

[ 0 ]

useless

[ 0 ]

Afraid to ask, what the hell is this? Tag check was so slow?

[ 1 ]

put a before openstack so you get openstack congress

[ 0 ]

remove this useless point

[ 0 ]

nitpick todo is supposed to be followed by a colon

[ 0 ]

this is wrong you want to essentially copy the implementation from stack task destroy task scheduler dependencytaskgroup self dependencies resource resource destroy reverse true

[ 0 ]

well this sucks, means it can't be used by the mobile clients :crying_cat_face:

[ 1 ]

what a beautiful brainfuck

[ 1 ]

die die die xml i would remove this hideous reminder of a long lost sad world

[ 0 ]

dumb idea in that case last first

[ 0 ]

not int sock opensocket if sock

[ 0 ]

Fuck I forgot to bracket it

[ 1 ]

fucking case sensitivity...

[ 1 ]

holy shit all of this is called per tick because of processing what the fuck is this code

[ 1 ]

this should be a uuid i think all id s here id volumeid serverid are uuids

[ 0 ]

Number of commits look wacky. Maybe rebase?

[ 1 ]

use mock thread instance mock magicmock isalive mock magicmock return value false remove l

[ 0 ]

this is a nice little use the data as is for formating hack

[ 0 ]

Let me check today if I get chance. The original work I did was outside this function and worked using the same method (and disgusting here-string!); I'm thinking I didn't remove the privilege before going back and testing this so it looked like it worked but hadn't done anything.

[ 1 ]

make it more pythonic self inactive ip self active ip self active ip self inactive ip

[ 0 ]

Exhaustive enum case handeling, like everywhere else so that we don't get a long ass compiler warning for every enum value not handled (monster mode does not just contain walk directions)

[ 1 ]

not if main plugin contrail

[ 0 ]

i will satisfy your thirst for pedantry in the method s docstring

[ 0 ]

this if statement if useless this check is already done in self assert data in result result msg

[ 0 ]

argh i really should get this into pep env

[ 0 ]

os brick is not usable in kilo so this comment should probably be removed

[ 0 ]

Honestly for ease of "remembering" what the hell is the name of the factory or graph of whatever. When using intelliJ I often do Shift-Shift followed by `GJGF` of `GFJ` when I am desperately trying to find the GrkanJanus thing. This makes is easier because I can just do GraTx.... and all the options will appear. I.e. Filipe dumb, autocomplete smart.

[ 1 ]

Oh daaaaamn That's from a change in the recent version I need to add a merge and roll out a patch 0_0

[ 1 ]

But this will fuck up day-long profile logs so badly

[ 1 ]