showvikdbz/code-reviews · Datasets at Hugging Face

text stringlengths 1 5.2k	labels listlengths 1 1
remove the backslash	[ 0 ]
Joshu is the senior engineer giving advice to the junior engineer. The jr engineer is all like 'wtf did Joshu just say' and Joshu is all like 'so is what I asked for coded up yet?'.	[ 1 ]
this too should be moved into a src func	[ 0 ]
this sequence is to be executed on every node in the env	[ 0 ]
get rid of this enum it is useless and unclear it needs to match the length in the array below	[ 0 ]
I THOUGHT I DID IT WTF	[ 1 ]
Welp, think I fucked up rebase, because I do not know how this got here	[ 1 ]
maybe a dumb question but do we need portmap isn t this just s portmap port uuid port local link connection	[ 0 ]
nit useless blank	[ 0 ]
Damn, assuming no onClick on CompactSelect?	[ 1 ]
sleeping airlocks, again? fuck my life	[ 1 ]
i think it should be removed	[ 0 ]
initialize init pid to here so it does not have garbage in it	[ 0 ]
I have no idea this is a horrible mess of spaghetti code that I made mainly by copy and pasting shit that I didn't understand at all	[ 1 ]
initialization with none is strange do you really need this	[ 0 ]
all conf values should be dumped when we load quantum so printing it again here is unneeded	[ 0 ]
No spaces in file names please. It appears to work but we are dealing with BYOND here. Better safe than weird-ass unexpected BYOND bugs down the line.	[ 1 ]
can we remove widgetcreationtype and kwidgetcreationtypekey	[ 0 ]
this whole #if concept is crap, I [liked the old XF way much more to write platform specific code](https://learn.microsoft.com/en-us/xamarin/xamarin-forms/app-fundamentals/dependency-service/introduction).	[ 1 ]
Seems weird to export something that has an underscore? Either we need to rename this, or use something else.	[ 1 ]
perhaps browseractionscontainer main container nullptr	[ 0 ]
this was the shitcode, too. It was a little too hacked together for my tastes, even for our codebase.	[ 1 ]
> I get data back in a manner that seems to be absurd. The data seems to be repeating again, or be missing some values. If I had to guess, you're re-using a buffer when reading from the file so there is a race between you getting more data from the file and SignalR writing the given buffer to the wire. I recommend trying streaming with [`IAsyncEnumerable<T>`](https://docs.microsoft.com/aspnet/core/signalr/streaming?view=aspnetcore-6.0#server-to-client-streaming) as that's a pull based model and should avoid issues with you reusing the buffer before it's been consumed by SignalR.	[ 1 ]
it not completely breaks save format, just screws up bonuses	[ 1 ]
how about using socket gethostname if we run both the frontend and the dispatcher on the same host will not this always be localhost	[ 0 ]
this is redudant this should be removed or the one in conductors yml should be removed	[ 0 ]
i have some better code that i accidentally wiped out today ptal	[ 0 ]
While I like the additions, I feel that `FILTHY` flag is just too excessive for a rag or a cotton ball that were used to disinfect the wound.	[ 1 ]
are you missing httpretty activate to monkey patch sockets	[ 0 ]
Oh damn, didn't know procs also inherited, this one's gonna save me lots of space. Thanks for that one, I'll get it done in the next commit.	[ 1 ]
It's bizarre to me that the WTH thread got so many votes, and this has been open so long, but there has never been any dev assignment or interaction about the issue. Is there anything that can be done to at least get some attention?	[ 1 ]
Damn now I want to play StarCraft, good thing it works properly via Wine do I don't have to RE and port it first :D	[ 1 ]
They all just suck if translated literally	[ 1 ]
node uid and task id should be nullable false should not them	[ 0 ]
this makes no sense a enable opengl implies enable gltf	[ 0 ]
why do you convert dummy data to model collection here shouldn t we compare with clean dummy json here	[ 0 ]
in order for an environment var to be picked up it needs to be executed in a shell	[ 0 ]
This is some weird tasting pasta chef.	[ 1 ]
this negative logic is going to be tricky as we add states think about error vs failed i think as we add values this will fail can we select all the in progress states instead in fact i think we really only want to expose the live migrate ones to start with maybe just look for things in the status of running or do we want to include queued migrating and pre migrating and maybe post migrating is that enough	[ 0 ]
guys the robot mask doesnt make you a robot wtf	[ 1 ]
Nonsense empowering parasites.	[ 1 ]
call me a fool but i only sussed this thanks to sylain s comment using lstrip the item replace format from below or adding a comment would help here	[ 0 ]
Yeah I forgot that I lifted It from spurdo code which is shitcode	[ 1 ]
Why the heck is this starting at 1?! This isn't lua	[ 1 ]
this should end in a colon similar comment applies throughout	[ 0 ]
Weird that this instantly kills dogs at a certain tick threshold instead of just doing damage. Could even just apply the `poisoned` status which pugs use (right above this block, even).	[ 1 ]
check gateway in subnet should be a classmethod in order to use cls check subnet ip instead of neutrondbpluginv check subnet ip	[ 0 ]
probably a dumb question but what is server ip address dhcp server or	[ 0 ]
it seems the above lines should be removed	[ 0 ]
> There's wacky failure on one of the Travis builders that I can't really understand... Looks odd indeed, I restarted that build to make sure it's a real issue.	[ 1 ]
ar is a pretty shitty type name, use assault or something.	[ 1 ]
i killed the global since it was unused outside this function	[ 0 ]
Thx @drawkula but I want micropython implementation, no Arduino sketch rubbish ...	[ 1 ]
so do you want this here just these alphabetized or build alphabetized	[ 0 ]
This is just me being anal but I would put this line above the message_admins line since the actual part of your function that does stuff should probably run first just in case	[ 1 ]
Why is this a food wtf it's literally just canned drink with food reagents	[ 1 ]
I'm not really worried by any of those problems, because it's kind of nonsense to uniqfy a dict or a set, so nonsense in, nonsense out. The case of Tuple is special, because it should be like builtin tuple, but it really isn't, so the only way to get a sensible behavior is to convert it to a list before passing it to uniq().	[ 1 ]
first line of docstring should end in a period	[ 0 ]
please remove this solution should also be backwards compatible if the resource uri specifies the tenant id backward compatibility is not needed	[ 0 ]
this docstring needs to be moved under the class serverassociatedstate object line below	[ 0 ]
agree wholeheartedly with fungi	[ 0 ]
could you check the returned value of pos if pos pickle dump else	[ 0 ]
arggregate should really be aggregate here and below	[ 0 ]
oatlastword is supposed to be the end of the oat content seems like that should move here or we do not need oatbsslastword	[ 0 ]
remove redundant parentheses	[ 0 ]
@bigtimebuddy Damn, I hope you are not mad. Didn't know you were going to merge this now. The linter wasn't happy. Will split the line now	[ 1 ]
this div should be a child of appearancesettingsprimary	[ 0 ]
They aren't needed but the intention wasn't to nerf the wizard. Walking around without shoes because acid ate them away still sucks	[ 1 ]
somebody remindme that you can set furniture and terrain to the same symbol so you can dicate what terrain goes under what and thus not have to manually place the crap. Would have been awful nice to know before	[ 1 ]
should be using std unique ptr flag and let the destructor automatically destroy all these	[ 0 ]
should have tempest in here also	[ 0 ]
i do not think this field needs to be string i think is ok it will be dumps to string in self post json	[ 0 ]
each of the error in this could be die unless you plan on this being a func callable by other people	[ 0 ]
ok on not having build target board vendorsetup sh i still think that it is better to put the default lunch registrations there but given that they are going in envsetup sh this path is not necessary	[ 0 ]
Wow this is super ugly	[ 1 ]
organize this into a bullet list by prefixing with	[ 0 ]
either all of these configs are global or none of them are. What the heck is this	[ 1 ]
why not just dx dx dy dy	[ 0 ]
Yep, fuck those technomancers, always hated them too.	[ 1 ]
this blank line should be eliminated	[ 0 ]
hell even the comment stated this....	[ 1 ]
cros build lib die unknown value for cache crx s for s cache crx ids	[ 0 ]
yes, we do, but i don't want to fuck a traitor ai out the ability to control pingsky for the rest of the round because astar is being a meme	[ 1 ]
consts default bridges names br prv	[ 0 ]
const struct bo ops bo ops	[ 0 ]
consider indenting the wrapped lines of the bullets to fix restview syntax	[ 0 ]
also I know some of the names are goofy	[ 1 ]
it s a pep error should be removed	[ 0 ]
nit since you are here let us remove these const s and please use stringconstant	[ 0 ]
What a disgusting time value. Make it 7 SECONDS.	[ 1 ]
Crap I didn't think about that But yeah, it's already possible	[ 1 ]
obsolete comments now all vms are core	[ 0 ]
currently only wayland clients can put a window into the pip window state there is no public api like maximize which leads to this ugly hack wrt tabletmodewindowmanager i believe so i do not think there is any specific logic to make it not managed by it the bounds themselves are managed by the client however	[ 0 ]
useless	[ 0 ]
think that is what the condition above is trying to do and fails miserably could be wrong thou gnumeric about this p pf varx vary nx ny false false if p we need the other tail and p might not be very accurate p pf varx vary nx ny true false	[ 0 ]
int t is a typedef is not it most probably it is exactly the same as long long	[ 0 ]
No please don't do that, automatic line feed often makes ridiculous chop and reduce the readability. I also checked Syndesis checkstyle and PMD, no line length restriction found.	[ 1 ]
Fuck you faggot no one likes you go kill yourself this doesn't even work.	[ 1 ]
Oh damn! Will fix this	[ 1 ]
nit remove the white space	[ 0 ]

remove the backslash

[ 0 ]

Joshu is the senior engineer giving advice to the junior engineer. The jr engineer is all like 'wtf did Joshu just say' and Joshu is all like 'so is what I asked for coded up yet?'.

[ 1 ]

this too should be moved into a src func

[ 0 ]

this sequence is to be executed on every node in the env

[ 0 ]

get rid of this enum it is useless and unclear it needs to match the length in the array below

[ 0 ]

I THOUGHT I DID IT WTF

[ 1 ]

Welp, think I fucked up rebase, because I do not know how this got here

[ 1 ]

maybe a dumb question but do we need portmap isn t this just s portmap port uuid port local link connection

[ 0 ]

nit useless blank

[ 0 ]

Damn, assuming no onClick on CompactSelect?

[ 1 ]

sleeping airlocks, again? fuck my life

[ 1 ]

i think it should be removed

[ 0 ]

initialize init pid to here so it does not have garbage in it

[ 0 ]

I have no idea this is a horrible mess of spaghetti code that I made mainly by copy and pasting shit that I didn't understand at all

[ 1 ]

initialization with none is strange do you really need this

[ 0 ]

all conf values should be dumped when we load quantum so printing it again here is unneeded

[ 0 ]

No spaces in file names please. It appears to work but we are dealing with BYOND here. Better safe than weird-ass unexpected BYOND bugs down the line.

[ 1 ]

can we remove widgetcreationtype and kwidgetcreationtypekey

[ 0 ]

this whole #if concept is crap, I [liked the old XF way much more to write platform specific code](https://learn.microsoft.com/en-us/xamarin/xamarin-forms/app-fundamentals/dependency-service/introduction).

[ 1 ]

Seems weird to export something that has an underscore? Either we need to rename this, or use something else.

[ 1 ]

perhaps browseractionscontainer main container nullptr

[ 0 ]

this was the shitcode, too. It was a little too hacked together for my tastes, even for our codebase.

[ 1 ]

> I get data back in a manner that seems to be absurd. The data seems to be repeating again, or be missing some values. If I had to guess, you're re-using a buffer when reading from the file so there is a race between you getting more data from the file and SignalR writing the given buffer to the wire. I recommend trying streaming with [`IAsyncEnumerable<T>`](https://docs.microsoft.com/aspnet/core/signalr/streaming?view=aspnetcore-6.0#server-to-client-streaming) as that's a pull based model and should avoid issues with you reusing the buffer before it's been consumed by SignalR.

[ 1 ]

it not completely breaks save format, just screws up bonuses

[ 1 ]

how about using socket gethostname if we run both the frontend and the dispatcher on the same host will not this always be localhost

[ 0 ]

this is redudant this should be removed or the one in conductors yml should be removed

[ 0 ]

i have some better code that i accidentally wiped out today ptal

[ 0 ]

While I like the additions, I feel that `FILTHY` flag is just too excessive for a rag or a cotton ball that were used to disinfect the wound.

[ 1 ]

are you missing httpretty activate to monkey patch sockets

[ 0 ]

Oh damn, didn't know procs also inherited, this one's gonna save me lots of space. Thanks for that one, I'll get it done in the next commit.

[ 1 ]

It's bizarre to me that the WTH thread got so many votes, and this has been open so long, but there has never been any dev assignment or interaction about the issue. Is there anything that can be done to at least get some attention?

[ 1 ]

Damn now I want to play StarCraft, good thing it works properly via Wine do I don't have to RE and port it first :D

[ 1 ]

They all just suck if translated literally

[ 1 ]

node uid and task id should be nullable false should not them

[ 0 ]

this makes no sense a enable opengl implies enable gltf

[ 0 ]

why do you convert dummy data to model collection here shouldn t we compare with clean dummy json here

[ 0 ]

in order for an environment var to be picked up it needs to be executed in a shell

[ 0 ]

This is some weird tasting pasta chef.

[ 1 ]

this negative logic is going to be tricky as we add states think about error vs failed i think as we add values this will fail can we select all the in progress states instead in fact i think we really only want to expose the live migrate ones to start with maybe just look for things in the status of running or do we want to include queued migrating and pre migrating and maybe post migrating is that enough

[ 0 ]

guys the robot mask doesnt make you a robot wtf

[ 1 ]

Nonsense empowering parasites.

[ 1 ]

call me a fool but i only sussed this thanks to sylain s comment using lstrip the item replace format from below or adding a comment would help here

[ 0 ]

Yeah I forgot that I lifted It from spurdo code which is shitcode

[ 1 ]

Why the heck is this starting at 1?! This isn't lua

[ 1 ]

this should end in a colon similar comment applies throughout

[ 0 ]

Weird that this instantly kills dogs at a certain tick threshold instead of just doing damage. Could even just apply the `poisoned` status which pugs use (right above this block, even).

[ 1 ]

check gateway in subnet should be a classmethod in order to use cls check subnet ip instead of neutrondbpluginv check subnet ip

[ 0 ]

probably a dumb question but what is server ip address dhcp server or

[ 0 ]

it seems the above lines should be removed

[ 0 ]

> There's wacky failure on one of the Travis builders that I can't really understand... Looks odd indeed, I restarted that build to make sure it's a real issue.

[ 1 ]

ar is a pretty shitty type name, use assault or something.

[ 1 ]

i killed the global since it was unused outside this function

[ 0 ]

Thx @drawkula but I want micropython implementation, no Arduino sketch rubbish ...

[ 1 ]

so do you want this here just these alphabetized or build alphabetized

[ 0 ]

This is just me being anal but I would put this line above the message_admins line since the actual part of your function that does stuff should probably run first just in case

[ 1 ]

Why is this a food wtf it's literally just canned drink with food reagents

[ 1 ]

I'm not really worried by any of those problems, because it's kind of nonsense to uniqfy a dict or a set, so nonsense in, nonsense out. The case of Tuple is special, because it should be like builtin tuple, but it really isn't, so the only way to get a sensible behavior is to convert it to a list before passing it to uniq().

[ 1 ]

first line of docstring should end in a period

[ 0 ]

please remove this solution should also be backwards compatible if the resource uri specifies the tenant id backward compatibility is not needed

[ 0 ]

this docstring needs to be moved under the class serverassociatedstate object line below

[ 0 ]

agree wholeheartedly with fungi

[ 0 ]

could you check the returned value of pos if pos pickle dump else

[ 0 ]

arggregate should really be aggregate here and below

[ 0 ]

oatlastword is supposed to be the end of the oat content seems like that should move here or we do not need oatbsslastword

[ 0 ]

remove redundant parentheses

[ 0 ]

@bigtimebuddy Damn, I hope you are not mad. Didn't know you were going to merge this now. The linter wasn't happy. Will split the line now

[ 1 ]

this div should be a child of appearancesettingsprimary

[ 0 ]

They aren't needed but the intention wasn't to nerf the wizard. Walking around without shoes because acid ate them away still sucks

[ 1 ]

somebody remindme that you can set furniture and terrain to the same symbol so you can dicate what terrain goes under what and thus not have to manually place the crap. Would have been awful nice to know before

[ 1 ]

should be using std unique ptr flag and let the destructor automatically destroy all these

[ 0 ]

should have tempest in here also

[ 0 ]

i do not think this field needs to be string i think is ok it will be dumps to string in self post json

[ 0 ]

each of the error in this could be die unless you plan on this being a func callable by other people

[ 0 ]

ok on not having build target board vendorsetup sh i still think that it is better to put the default lunch registrations there but given that they are going in envsetup sh this path is not necessary

[ 0 ]

Wow this is super ugly

[ 1 ]

organize this into a bullet list by prefixing with

[ 0 ]

either all of these configs are global or none of them are. What the heck is this

[ 1 ]

why not just dx dx dy dy

[ 0 ]

Yep, fuck those technomancers, always hated them too.

[ 1 ]

this blank line should be eliminated

[ 0 ]

hell even the comment stated this....

[ 1 ]

cros build lib die unknown value for cache crx s for s cache crx ids

[ 0 ]

yes, we do, but i don't want to fuck a traitor ai out the ability to control pingsky for the rest of the round because astar is being a meme

[ 1 ]

consts default bridges names br prv

[ 0 ]

const struct bo ops bo ops

[ 0 ]

consider indenting the wrapped lines of the bullets to fix restview syntax

[ 0 ]

also I know some of the names are goofy

[ 1 ]

it s a pep error should be removed

[ 0 ]

nit since you are here let us remove these const s and please use stringconstant

[ 0 ]

What a disgusting time value. Make it 7 SECONDS.

[ 1 ]

Crap I didn't think about that But yeah, it's already possible

[ 1 ]

obsolete comments now all vms are core

[ 0 ]

currently only wayland clients can put a window into the pip window state there is no public api like maximize which leads to this ugly hack wrt tabletmodewindowmanager i believe so i do not think there is any specific logic to make it not managed by it the bounds themselves are managed by the client however

[ 0 ]

useless

[ 0 ]

think that is what the condition above is trying to do and fails miserably could be wrong thou gnumeric about this p pf varx vary nx ny false false if p we need the other tail and p might not be very accurate p pf varx vary nx ny true false

[ 0 ]

int t is a typedef is not it most probably it is exactly the same as long long

[ 0 ]

No please don't do that, automatic line feed often makes ridiculous chop and reduce the readability. I also checked Syndesis checkstyle and PMD, no line length restriction found.

[ 1 ]

Fuck you faggot no one likes you go kill yourself this doesn't even work.

[ 1 ]

Oh damn! Will fix this

[ 1 ]

nit remove the white space

[ 0 ]