text
stringlengths 1
5.2k
| labels
listlengths 1
1
|
|---|---|
damnit you're totally right
|
[
1
] |
This shit makes me so glad you did this and not me!
|
[
1
] |
kill this
|
[
0
] |
why are not you using actual filters instead of writing them by hand
|
[
0
] |
Dammit. Glad we haven't released just yet. (I merged this based on Kevin's not seeing any reason not to merge it; apologies for possible misinterpretation there.)
|
[
1
] |
noqa should be removed
|
[
0
] |
Clamp this to prevent negative numbers and zeros, you don't want division to fuck up
|
[
1
] |
"self_right_time = 60 SECONDS" fuck off
|
[
1
] |
our convention is to put then at the end of the if line
|
[
0
] |
what about rw handles imagereadhandle return value fake imagereadhandle
|
[
0
] |
that is still an accident waiting to happen and really ugly verbose code this kind of thing is what asprintf or since this is actually c and you need to string a bunch of these together anyway android base stringprintf and std string operator is for just say no to fixed length buffers
|
[
0
] |
This is also ugly bad non-OOP. Make method canMakeHelmet() on /obj/item/clothing/mask/gas, have it return a bool, and use that instead.
|
[
1
] |
this piece of code will be removed anyway
|
[
0
] |
seems like a bit useless now we have only dummy dummy benchmark scenario
|
[
0
] |
oh weird. I always use tabs. Not sure why it converted. Probably visual studio messed it up
|
[
1
] |
oh build native test must be doing this for you never mind
|
[
0
] |
can move this up and eliminate the white space
|
[
0
] |
i suppose i guess i was thinking it is a matter of expected vs unexpected failure how would you feel about something along the lines of failure true try failure false except expected finally if failure cleanup
|
[
0
] |
h multi line docstrings should end on a new line
|
[
0
] |
please get rid of the trailing space
|
[
0
] |
If you're referring to the Less section at http://getbootstrap.com/css/#less, I do plan on neutering that one quite a bit. The duplicity sucks and only serves to help a few folks out who don't want to look at the source code. The overhead just makes for easily out of date content.
|
[
1
] |
you ve already set new tgt name tgt alias on l
|
[
0
] |
sorry i meant documenting this in service api txt since that should be more convenient for chrome folks that our commit messages
|
[
0
] |
Oh shit, two of these have typos
|
[
1
] |
can you kill these spaces
|
[
0
] |
ah why am i so stupid thank you again
|
[
0
] |
This is totally wrong.
|
[
1
] |
empty list is an empty list and thus will be converted by the else block into an empty array
|
[
0
] |
are we sure about this an agent could manage hundreds of haproxy instances why log both to the agent and the haproxy specific log file this must be a stupid question but do not we just direct haproxy to log directly to a file and get rid of the unix domain socket and all of this complexity
|
[
0
] |
Seriously ??? Damn.
|
[
1
] |
we should be using mock instead of mox
|
[
0
] |
ha ha yeah this is stupid it s because if i put pragma no cover on the self fail line then it is more than characters i am thinking of using unittest assertraises as you suggest below and importing unittest for
|
[
0
] |
oh that was stupid i should do less multitasking
|
[
0
] |
Ugh. More spam from me (multitasking during a meeting. I suck): Orca was presenting the selection changes from the file explorer. When I hid that, I see the bug in insiders. And the bug is no events, so there's nothing Orca can do.
|
[
1
] |
i think the default value should be an empty object
|
[
0
] |
you cannot put it in a product makefile like brillo base mk you should put it in an android mk such as device generic birllo android mk
|
[
0
] |
Verify this is working correctly? I.e don't get slaughtered by demons in hell while watching cutscene in network lobby
|
[
1
] |
cinder volume drivers pure pureiscsidriver
|
[
0
] |
using a singular with is a bit ugly and it dislikes assignments this just looks better
|
[
0
] |
yes they are it s actually a way to shoot yourself in the foot setting framerate to will be different from we cannot do much about this
|
[
0
] |
it may be fine, github displays tabs in a weird way
|
[
1
] |
can you please use mock instead of mox if possible
|
[
0
] |
bus and addr should be removed as they are not used in a dt build
|
[
0
] |
network id empty
|
[
0
] |
Argh, that's a bummer.
|
[
1
] |
cleanup should only be called if it actually worked otherwise you are deleting objects you need for debugging
|
[
0
] |
please use and instead of textual keywords also other places in this cl i have not checked but i think the coding style disallows use the or and not keywords if not my view is that it should
|
[
0
] |
Ugh, will fix unwanted formatting nonsense.
|
[
1
] |
micro nit this does not belong here you are used to sneaking changes that are not strictly required
|
[
0
] |
should this be eql driver executing s for i time command total attempts attemps
|
[
0
] |
this accessor should still be a const layoutsize since it can never be null
|
[
0
] |
no need to this validator as there is no not supported match
|
[
0
] |
them should be removed
|
[
0
] |
i think you could populate both process info and thread info from the single ps ewwlo pid lwp comm cmd command run output
|
[
0
] |
God dammit. You're right.
|
[
1
] |
resize up enabled flavors config resize enabled if flavors config resize enabled is not none else flavors config resize enabled
|
[
0
] |
Leaning toward "too complex" here unless there are more compelling examples than Angular's wacky DI setup. Might be worth discussing if we had a proof-of-concept PR that didn't introduce too much complexity.
|
[
1
] |
the surgical drill is hotline miami as fuck, better to remove the stetho since it serves no real purpose (unless it does with your medical system)
|
[
1
] |
No need to have too long a discussion either, I think we should do this (and honestly it sucks that we haven't so far). Just a matter of timing. Now that we've shipped, I'll bring this up with the team and we'll try to do this soon.
|
[
1
] |
these sound awful where's aranclanos when you need him
|
[
1
] |
if i understand that correctly i think you should be character sequences min
|
[
0
] |
The occasional ToArray or ToList is okay (same with AsParallel()) but chaining a bunch allocates out the ass and often shows up on a profiler.
|
[
1
] |
how is it really a message queue it s just a dummy
|
[
0
] |
i think it will be better to put this block after instance destroy
|
[
0
] |
service catalog is a httpclient property so you can make it simpler by changing self auth ref service catalog region name to just self service catalog region name
|
[
0
] |
@Vedant-Tyagi it s been 3 weeks since Yanshi asked for the screenshot. Are you too busy, too ignorant, or just don t know how to add screenshot.
|
[
1
] |
Thx @dmitris Did you find time to sign the CLA? I know it's a bit ridiculous for just a typo fix, but hopefully you can contribute more things later and the CLA will be useful.
|
[
1
] |
This is some very weird formatting =)
|
[
1
] |
hmm something must not be right this code path should not be hit in the kmultideviceapi world so i would expect this entire method to be removed
|
[
0
] |
intellij npe warning
|
[
0
] |
you do not use kwargs below why do you need it
|
[
0
] |
do not need return here
|
[
0
] |
could we comment this as silently kill and destroy all untracked files and directories
|
[
0
] |
mostly nit but would be good to have a type check here otherwise someone can put ironic ramdisk type blah and it is going to work e g elif ironic ramdisk type dib then build ipa dib else die ramdisk type ironic ramdisk type not supported
|
[
0
] |
this actually changes nothing is it needed
|
[
0
] |
just friggin image tests that do not use warlock
|
[
0
] |
seems this belongs under the deprecations section rather than upgrade
|
[
0
] |
pmu irq handler calls pmu get ac in interrupt context so you cannot do an i c request here
|
[
0
] |
Bloody hell, I suck at spelling...
|
[
1
] |
Oh god it is isn't it?
|
[
1
] |
I'd like to add this as the only feature I've ever requested because it's frankly bizarre that it's not there, it's one of those basic things, not a fancy thing, I think.
|
[
1
] |
Damn I feel dumb. OK fixed.
|
[
1
] |
i have left the x push and pop so that you can just remove them all in your change rather than have an odd man out
|
[
0
] |
no it does not need to have two ports to be part of the chain will add text to clarify a device that will tap a traffic stream can be inserted in the chain
|
[
0
] |
fuck it, ill just make a content PR
|
[
1
] |
maybe add a todo and refer to an issue crosbug com
|
[
0
] |
as is visible in test code there are no leaked mocks and i have made consistent use of patch object for mocking so there should not be need of using trove testtools testcase
|
[
0
] |
from my understanding of the code you do not actually need a dictionary it appears that you just need to be able to set arbitrary attributes on a dummy object you could import userdict u userdict userdict u slavetoken slavetoken u slavetoken slavetoken
|
[
0
] |
Oh, shit, yeah. I'll fix that while I'm giving the default sprites a facelift
|
[
1
] |
Reinventing the wheel is for lunatics
|
[
1
] |
you could probably use an empty std string just fine
|
[
0
] |
It's just sucks.. but that's life :) When you play dangerous games.. Basically at the moment I'm backing up, committing my 3423 projects into GitHub making sure that 652TB of crap in Dropbox are synced and I'll be ready to clean the shit out of it... I wanted to do that for quite some time now.. so it looks like that day/night just arrived :)
|
[
1
] |
hell if I know, this is part of the code I was moving around and I didn't check if all of it made sense.
|
[
1
] |
Gah, the whole reason we left the templates as whole HTML files is so folks could yank them without running a server. Sucks we have these problems, but they're not unique to our situation. Do you think this is better than just a warning in the docs somewhere?
|
[
1
] |
vite looks like a horrible absurd bundler considering the number of issues and how childish and absurd those issues are. This vite nonsense is ruining the reputation of sveltekit. It's the only thing preventing the release of sveltekit. What a shame! svelte team made a terrible mistake by choosing an incompetent bundler.
|
[
1
] |
i also considered adding hide here but makefile ckati has no echo to say it is building something my other thought was to put either for showcommands or echo building for showcommands and using instead of to delay the evaluation of
|
[
0
] |
this should be kusebakerorbrooksreadbarrier from object h ifdef use baker or brooks read barrier uint t x rb ptr for the baker or brooks pointer endif
|
[
0
] |
1. Sending all these messages to `world` is a little weird 2. This needs to be renamed to something like `malfNukeCountdown()`
|
[
1
] |
make this another dcheck
|
[
0
] |
access mode should be removed as it is set in the manager
|
[
0
] |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.