showvikdbz/code-reviews · Datasets at Hugging Face

text stringlengths 1 5.2k	labels listlengths 1 1
i propose to change the sentence to if you do not want to install the metapackage you can run the following script to enable remote root access	[ 0 ]
the point of signals theres a crapton of them, one for each event that occurs (e.g. getting creamed, shooting yourself in the foot), that specifically makes them non-snowflake.,	[ 1 ]
bool skip first stack check false skip first stack check for readability another possibility would be to introduce flags with kskipfirststackcheck and kanalyzeenvironmentliveness	[ 0 ]
Believe it or not, I found something to bitch about	[ 1 ]
region needs to be set somewhere	[ 0 ]
you already assert the call count just make side effect raise timeout	[ 0 ]
are you sure that running run test sh will produce subunit log i tried that and it does not produce anything are you sure about that	[ 0 ]
`getUserTeamIds` is `User => Fu[List[TeamId]]` right? So should be `_ => fuccess(teams.map(_.id))`	[ 1 ]
Whoops, my dumb American brain didn't know this was a valid spelling \U0001f602	[ 1 ]
should be mock clients return value get only instances return value severs list	[ 0 ]
greenpool mock green pool return value	[ 0 ]
use osutils safemakedirs	[ 0 ]
drop the non ebuild the bots will do it for you	[ 0 ]
this might be a stupid question since i am not very familiar with how ipmi interoperates with ceilometer but is not resource id supposed to be id of the resource that the sample is about not the id of the sensor e g should not resource id here be simply node uuid just like cpu meter s resource id is the id of the vm	[ 0 ]
This is the same issue I have with the Customizer. The amount of code required to do the bare minimum is ridiculous.	[ 1 ]
put this in backticks keystoneauth	[ 0 ]
get rid of stackforge	[ 0 ]
Im happy enough with these current settings. The explosions of secubots tankbots and modded creatures were all equally ridiculous, and we could even add in an explosive death for hacks now	[ 1 ]
whatever s easiest for you is ok with me another cl would be easier for reviewing i suppose but if you would rather throw it in here or create the class now and make another cl later to convert other existing code i am fine with that as well	[ 0 ]
The new semi-transparent pink-on-black color scheme of the 3.12 UI is absolutely ridiculous. I still use Elementor but I use it in spite of, not because of, these so-called "improvements".	[ 1 ]
should these use kshelfdefaultbasecolor instead of separately hardcoding black	[ 0 ]
what about just putting them back on their old loc? eg: before `if(NewLoc)` put `var/oloc = loc` its less fucky for the player.	[ 1 ]
no i am just stupid runcon was done ages ago this is the last selinux command to switch	[ 0 ]
let us remove these as they make no sense here	[ 0 ]
@larsmans You obviously don't know the common way to indicate a joke when on the Internet. I expect you will get this closed without fixing but I contend that it doesn't significantly increase support overhead. (You can spare me the argument that "any increase is significant" as that is clearly nonsense.)	[ 1 ]
You can already make synthetic carp without even leaving medbay. I don't see how making weak skeletons like this is too powerful considering the other shit you can pull with chemistry.	[ 1 ]
Won't it be ugly this way?	[ 1 ]
A damn, a hasty miss by me. Youre right this doesn't make sense.	[ 1 ]
this afternoon s job is removing this and the pr set vma hack too	[ 0 ]
silly nit but need a period at the end of one line doc strings here	[ 0 ]
nit how about just kill hup dnsmasq threw s	[ 0 ]
Enough said. Tj's a faggot	[ 1 ]
i will remove it from here and the others above	[ 0 ]
Ah yup indeed that is US (and more common) spelling it looks like! :grin:	[ 1 ]
probably a dumb question but what is server ip address dhcp server or	[ 0 ]
this class needs a docstring	[ 0 ]
That's horrifying. Don't go randomly adding new parameters to singleton-ish objects, that's insane. Why couldn't two people export as XML at the same time?	[ 1 ]
i think you have moved to using self descriptor cache device type	[ 0 ]
need to kill off periph l regs here	[ 0 ]
isn t the note obsolete i see list qos policies and note say it is not	[ 0 ]
terminal based btw this is looking awesome omg i love this	[ 0 ]
Okay, you're here and I didn't ask you to go play in this space, but you did and so you get the cleanup. This is an awful function, it's still an awful function after the cleanup. 90% of this nonsense should be moved into `src/vehicle_use.cpp` as a separate function that map just calls the way the basecamp stuff is a call into the basecamp code. This CS 101 abstraction stuff. I've been meaning to do it for a while but keep getting busy, but you're touching the code so it's on you to clean it up.	[ 1 ]
Didn't work :/ It's ridiculous, in localhost I can see all the icons, but not when it's deployed	[ 1 ]
wacky. how does editor config play into that??	[ 1 ]
oh damn, I really like this, going to steal this for the ArithmeticVisitor	[ 1 ]
i would clean up the string a bit for use as a slug remote os remote os replace upper	[ 0 ]
This thing...was a piece of crap.	[ 1 ]
Just remove the dist line so we stay up to date and know when shit breaks	[ 1 ]
you can mock imagecache in the setup and have mock get cached image self vmops imagecache get cached image mock get cached image return value mock sentinel cached iso path	[ 0 ]
nit this is enough values that i wonder if it would be cleaner to keep these pulled into another object const responsecookiemodification cookie modifiers for auto modification cookie modifiers	[ 0 ]
please use die instead of rolling your own	[ 0 ]
This is totally ridiculous, and I agree appears to be something that never worked. :+1: to killing off abandoned experiments.	[ 1 ]
i think seamicro vendor pxe vendor should not be attributes of this class	[ 0 ]
this seems to do nothing and should be removed	[ 0 ]
As a developer, I DO NOT like the attitude of you don't need what you want to do, but then I am not paying for this so I just suck it up and move one. But yes it would be very nice to add the check box inside the form fields, because, well check boxes are on forms.	[ 1 ]
return join self dbaas client service url self configuration id	[ 0 ]
h git commit title fix sqlalchemy api to make instance destroy also delete system metadata should be under chars	[ 0 ]
wow elif should be removed at all with todo comment as it is now it skips all extra fk that was found	[ 0 ]
storage storage mgmt external internal api and tenant from pool yaml	[ 0 ]
> should probably be the least common thing instead of 85% chance like holy crap but then it wouldn't be the station-destroying round-ending singulo-parallel like i'm trying to make it be	[ 1 ]
Not sure. Is arm_reset the system entry point? It might be bad to start the system by pushing some nonsense onto the stack.	[ 1 ]
just why Knock, knock! Who's there? Impatient feminist. Impatient fem: WHY DON'T WE HAVE EQUAL PAY YET??	[ 1 ]
I'm sorry @giralte-ionic , but this is looking ridiculous now. Almost 3 months old and not even a code review.	[ 1 ]
nononono all that stuff should go away	[ 0 ]
You know? _"Maybe if we treat language associations just as "above-the-top-level" categories we can solve a lot of issues..."_ The more I think to this the more I feel I've just had a damn good bright idea. Myabe not for 3.4, but... Prove me wrong and I'll eat quite a lot of _"Humble pie"_...	[ 1 ]
perhaps neaten this up to reduce duplication something like function clone and checkout git clone depth cd git checkout cd clone and checkout builddir tmp tgt v clone and checkout builddir tmp qemu v	[ 0 ]
self client plugin is ok	[ 0 ]
done this gets ugly with a couple of casts i aliased the pair to referencekey for ease of use	[ 0 ]
btw why not just myfakescenario do it preprocessors preprocessors	[ 0 ]
maybe there should be a comment why do not you use clonedeep	[ 0 ]
lol this one always made me sad i guess it is making similar behavior as the jsonutils one but man it feels slightly um stupid to do this for lack of better word	[ 0 ]
Not getting a crash or anything as the labels suggest, but am getting the console spam. I'm using a pretty rubbish Oppo phone (CPH1725/A73) with Android 7.1.1 too - so it might just be an android version issue rather than anything sinister?	[ 1 ]
garbage	[ 0 ]
i dont love looping but i cant think of a better way to do that, it will be fine unless they paste some ridiculous string in there like "a a a a a a a a ...."	[ 1 ]
sshlink class name	[ 0 ]
> This is quite absurd. Blacklist is standard engineering terminology. Please read up on the etymology of the word before inserting your own misguided ideas into things. https://www.etymonline.com/word/blacklist Please do some extra reading.. e.g: https://tools.ietf.org/id/draft-knodel-terminology-01.html Maybe it will change your mind.	[ 1 ]
will love to have you on board	[ 0 ]
eh i muffed this this should be db node destroy called	[ 0 ]
I checked on numpy master and both examples now error instead of giving nonsense. Obviously, it would still be nicer if they returned the right thing, but at least this issue is solved, so I'll close it.	[ 1 ]
Are you seriously showcasing a Useless Use Of :cat: as an example?	[ 1 ]
@bgashler1 you do not have to do this in the last day of the sprint. It was always like this and is not a regression. Thus assigning to Brad and January. Just polish the shit out of high contrast debugging starting from next week :)	[ 1 ]
No, you need to not add more overlays because they are slow as fuck to initialize and delete.	[ 1 ]
Damn. I thought I got all of those.	[ 1 ]
should we also ass debounce to repo setting l l	[ 0 ]
This will make a fuck-huge list every single time it calls make_floors as those get added over and over	[ 1 ]
yes i feel very dumb now	[ 0 ]
This is a pretty bizzare error. Have you seen it more than once?	[ 1 ]
bouyah you just killed me	[ 0 ]
depende n cies	[ 0 ]
the plug vhostuser and unplug vhostuser methods are required by the vif driver interface for every vif type there need to be get config plug and unplug methods	[ 0 ]
useless line	[ 0 ]
use it does not re interpolate	[ 0 ]
thanks i trusted sed too much	[ 0 ]
die die die xml i would remove this hideous reminder of a long lost sad world	[ 0 ]
wow ... and it's not even a function call. seriously. wtf!?	[ 1 ]
this one is fucked up and honestly should have the `</span>` after the `</I>`	[ 1 ]
No notifications from the official CI system either though - looks like it needs some more kicking - unfortunately the process for testing is clumsy, the turnaround super long, and there is bugger all logging. :neutral_face:	[ 1 ]
let s rename all activedirectory to dummy or something like this	[ 0 ]
you should probably delete all these agent ones	[ 0 ]
ok conf interface driver value dumped	[ 0 ]

i propose to change the sentence to if you do not want to install the metapackage you can run the following script to enable remote root access

[ 0 ]

the point of signals theres a crapton of them, one for each event that occurs (e.g. getting creamed, shooting yourself in the foot), that specifically makes them non-snowflake.,

[ 1 ]

bool skip first stack check false skip first stack check for readability another possibility would be to introduce flags with kskipfirststackcheck and kanalyzeenvironmentliveness

[ 0 ]

Believe it or not, I found something to bitch about

[ 1 ]

region needs to be set somewhere

[ 0 ]

you already assert the call count just make side effect raise timeout

[ 0 ]

are you sure that running run test sh will produce subunit log i tried that and it does not produce anything are you sure about that

[ 0 ]

`getUserTeamIds` is `User => Fu[List[TeamId]]` right? So should be `_ => fuccess(teams.map(_.id))`

[ 1 ]

Whoops, my dumb American brain didn't know this was a valid spelling \U0001f602

[ 1 ]

should be mock clients return value get only instances return value severs list

[ 0 ]

greenpool mock green pool return value

[ 0 ]

use osutils safemakedirs

[ 0 ]

drop the non ebuild the bots will do it for you

[ 0 ]

this might be a stupid question since i am not very familiar with how ipmi interoperates with ceilometer but is not resource id supposed to be id of the resource that the sample is about not the id of the sensor e g should not resource id here be simply node uuid just like cpu meter s resource id is the id of the vm

[ 0 ]

This is the same issue I have with the Customizer. The amount of code required to do the bare minimum is ridiculous.

[ 1 ]

put this in backticks keystoneauth

[ 0 ]

get rid of stackforge

[ 0 ]

Im happy enough with these current settings. The explosions of secubots tankbots and modded creatures were all equally ridiculous, and we could even add in an explosive death for hacks now

[ 1 ]

whatever s easiest for you is ok with me another cl would be easier for reviewing i suppose but if you would rather throw it in here or create the class now and make another cl later to convert other existing code i am fine with that as well

[ 0 ]

The new semi-transparent pink-on-black color scheme of the 3.12 UI is absolutely ridiculous. I still use Elementor but I use it in spite of, not because of, these so-called "improvements".

[ 1 ]

should these use kshelfdefaultbasecolor instead of separately hardcoding black

[ 0 ]

what about just putting them back on their old loc? eg: before `if(NewLoc)` put `var/oloc = loc` its less fucky for the player.

[ 1 ]

no i am just stupid runcon was done ages ago this is the last selinux command to switch

[ 0 ]

let us remove these as they make no sense here

[ 0 ]

@larsmans You obviously don't know the common way to indicate a joke when on the Internet. I expect you will get this closed without fixing but I contend that it doesn't significantly increase support overhead. (You can spare me the argument that "any increase is significant" as that is clearly nonsense.)

[ 1 ]

You can already make synthetic carp without even leaving medbay. I don't see how making weak skeletons like this is too powerful considering the other shit you can pull with chemistry.

[ 1 ]

Won't it be ugly this way?

[ 1 ]

A damn, a hasty miss by me. Youre right this doesn't make sense.

[ 1 ]

this afternoon s job is removing this and the pr set vma hack too

[ 0 ]

silly nit but need a period at the end of one line doc strings here

[ 0 ]

nit how about just kill hup dnsmasq threw s

[ 0 ]

Enough said. Tj's a faggot

[ 1 ]

i will remove it from here and the others above

[ 0 ]

Ah yup indeed that is US (and more common) spelling it looks like! :grin:

[ 1 ]

probably a dumb question but what is server ip address dhcp server or

[ 0 ]

this class needs a docstring

[ 0 ]

That's horrifying. Don't go randomly adding new parameters to singleton-ish objects, that's insane. Why couldn't two people export as XML at the same time?

[ 1 ]

i think you have moved to using self descriptor cache device type

[ 0 ]

need to kill off periph l regs here

[ 0 ]

isn t the note obsolete i see list qos policies and note say it is not

[ 0 ]

terminal based btw this is looking awesome omg i love this

[ 0 ]

Okay, you're here and I didn't ask you to go play in this space, but you did and so you get the cleanup. This is an awful function, it's still an awful function after the cleanup. 90% of this nonsense should be moved into `src/vehicle_use.cpp` as a separate function that map just calls the way the basecamp stuff is a call into the basecamp code. This CS 101 abstraction stuff. I've been meaning to do it for a while but keep getting busy, but you're touching the code so it's on you to clean it up.

[ 1 ]

Didn't work :/ It's ridiculous, in localhost I can see all the icons, but not when it's deployed

[ 1 ]

wacky. how does editor config play into that??

[ 1 ]

oh damn, I really like this, going to steal this for the ArithmeticVisitor

[ 1 ]

i would clean up the string a bit for use as a slug remote os remote os replace upper

[ 0 ]

This thing...was a piece of crap.

[ 1 ]

Just remove the dist line so we stay up to date and know when shit breaks

[ 1 ]

you can mock imagecache in the setup and have mock get cached image self vmops imagecache get cached image mock get cached image return value mock sentinel cached iso path

[ 0 ]

nit this is enough values that i wonder if it would be cleaner to keep these pulled into another object const responsecookiemodification cookie modifiers for auto modification cookie modifiers

[ 0 ]

please use die instead of rolling your own

[ 0 ]

This is totally ridiculous, and I agree appears to be something that never worked. :+1: to killing off abandoned experiments.

[ 1 ]

i think seamicro vendor pxe vendor should not be attributes of this class

[ 0 ]

this seems to do nothing and should be removed

[ 0 ]

As a developer, I **DO NOT** like the attitude of you don't need what you want to do, but then I am not paying for this so I just suck it up and move one. But yes it would be very nice to add the check box inside the form fields, because, well check boxes are on forms.

[ 1 ]

return join self dbaas client service url self configuration id

[ 0 ]

h git commit title fix sqlalchemy api to make instance destroy also delete system metadata should be under chars

[ 0 ]

wow elif should be removed at all with todo comment as it is now it skips all extra fk that was found

[ 0 ]

storage storage mgmt external internal api and tenant from pool yaml

[ 0 ]

> should probably be the least common thing instead of 85% chance like holy crap but then it wouldn't be the station-destroying round-ending singulo-parallel like i'm trying to make it be

[ 1 ]

Not sure. Is arm_reset the system entry point? It might be bad to start the system by pushing some nonsense onto the stack.

[ 1 ]

just why Knock, knock! Who's there? Impatient feminist. Impatient fem: WHY DON'T WE HAVE EQUAL PAY YET??

[ 1 ]

I'm sorry @giralte-ionic , but this is looking ridiculous now. Almost 3 months old and not even a code review.

[ 1 ]

nononono all that stuff should go away

[ 0 ]

You know? _"Maybe if we treat language associations just as "above-the-top-level" categories we can solve a lot of issues..."_ The more I think to this the more I feel I've just had a damn good bright idea. Myabe not for 3.4, but... Prove me wrong and I'll eat quite a lot of _"Humble pie"_...

[ 1 ]

perhaps neaten this up to reduce duplication something like function clone and checkout git clone depth cd git checkout cd clone and checkout builddir tmp tgt v clone and checkout builddir tmp qemu v

[ 0 ]

self client plugin is ok

[ 0 ]

done this gets ugly with a couple of casts i aliased the pair to referencekey for ease of use

[ 0 ]

btw why not just myfakescenario do it preprocessors preprocessors

[ 0 ]

maybe there should be a comment why do not you use clonedeep

[ 0 ]

lol this one always made me sad i guess it is making similar behavior as the jsonutils one but man it feels slightly um stupid to do this for lack of better word

[ 0 ]

Not getting a crash or anything as the labels suggest, but am getting the console spam. I'm using a pretty rubbish Oppo phone (CPH1725/A73) with Android 7.1.1 too - so it might just be an android version issue rather than anything sinister?

[ 1 ]

garbage

[ 0 ]

i dont love looping but i cant think of a better way to do that, it will be fine unless they paste some ridiculous string in there like "a a a a a a a a ...."

[ 1 ]

sshlink class name

[ 0 ]

> This is quite absurd. Blacklist is standard engineering terminology. Please read up on the etymology of the word before inserting your own misguided ideas into things. https://www.etymonline.com/word/blacklist Please do some extra reading.. e.g: https://tools.ietf.org/id/draft-knodel-terminology-01.html Maybe it will change your mind.

[ 1 ]

will love to have you on board

[ 0 ]

eh i muffed this this should be db node destroy called

[ 0 ]

I checked on numpy master and both examples now error instead of giving nonsense. Obviously, it would still be nicer if they returned the right thing, but at least this issue is solved, so I'll close it.

[ 1 ]

Are you seriously showcasing a Useless Use Of :cat: as an example?

[ 1 ]

@bgashler1 you do not have to do this in the last day of the sprint. It was always like this and is not a regression. Thus assigning to Brad and January. Just polish the shit out of high contrast debugging starting from next week :)

[ 1 ]

No, you need to not add more overlays because they are slow as fuck to initialize and delete.

[ 1 ]

Damn. I thought I got all of those.

[ 1 ]

should we also ass debounce to repo setting l l

[ 0 ]

This will make a fuck-huge list every single time it calls make_floors as those get added over and over

[ 1 ]

yes i feel very dumb now

[ 0 ]

This is a pretty bizzare error. Have you seen it more than once?

[ 1 ]

bouyah you just killed me

[ 0 ]

depende n cies

[ 0 ]

the plug vhostuser and unplug vhostuser methods are required by the vif driver interface for every vif type there need to be get config plug and unplug methods

[ 0 ]

useless line

[ 0 ]

use it does not re interpolate

[ 0 ]

thanks i trusted sed too much

[ 0 ]

die die die xml i would remove this hideous reminder of a long lost sad world

[ 0 ]

wow ... and it's not even a function call. seriously. wtf!?

[ 1 ]

this one is fucked up and honestly should have the `</span>` after the `</I>`

[ 1 ]

No notifications from the official CI system either though - looks like it needs some more kicking - unfortunately the process for testing is clumsy, the turnaround super long, and there is bugger all logging. :neutral_face:

[ 1 ]

let s rename all activedirectory to dummy or something like this

[ 0 ]

you should probably delete all these agent ones

[ 0 ]

ok conf interface driver value dumped

[ 0 ]