showvikdbz/code-reviews · Datasets at Hugging Face

text stringlengths 1 5.2k	labels listlengths 1 1
you will assign temp zone temp zone if bat temp c or	[ 0 ]
Damn, beautiful code. Only a genius could write something as beautiful as this ;)	[ 1 ]
Seriously, can we just do like a double $$ and be done with it? This is getting ridiculous. I feel so dirty having to use Fn::Join with serverless.	[ 1 ]
is exact here and below	[ 0 ]
yeah, np :P yep, I can't do returns because it has to jump to that only return so I have to store the result in a variable then jump there, clunky as hell but that's how I got it bin exact :)	[ 1 ]
hi sorry for the stupid question but how come we do not have a name for this initfunction like the others eg horizon d piechart init function	[ 0 ]
damn how did this get here	[ 1 ]
seems virtual size should be nullable n	[ 0 ]
this should return a boolean success failure value dcheck dir name null	[ 0 ]
yes you are right there is a double free happening here god catch dumb mistake do you think that there must be symmetry why cannot something get a factory create and ordinary destruction	[ 0 ]
There is no data copy, i fucked up summary	[ 1 ]
get rid of fi elif echo config fi	[ 0 ]
This is complete bullshit. You can forget it :shameonme	[ 1 ]
not weird at all actually this test was just broken because i am dumb fixed now hopefully	[ 0 ]
reverse iterator i am like i pulled it off one of the how to c sites but i will change it up	[ 0 ]
umm, holy crap, this is beautiful??	[ 1 ]
disabld disabled	[ 0 ]
Yes I know :/ But it worked smooth in my maps folder with 157 maps. Also I did not want to mess up the code too much by writing crappy cache code. Might look at ddnet how they handled it.	[ 1 ]
please use e ne e ne info for my primary e mail in community	[ 0 ]
this is what is in the base test l there are ips meant to be assigned to the port the first from the subnet and the second a specific one test is kind of idiot ic	[ 0 ]
should we deprecate and kill needs reload then once tabloader logic is in lifecyclemanager as well the only client is session restore now iirc maybe add a comment with a todo and a bug for this	[ 0 ]
Horny femboy cums on his little panties	[ 1 ]
this naming convention is terrible since our documented header names here show these as arraystart array start array start numbering internally just means we are going to mess this up in the future	[ 0 ]
ditto above it probably makes sense to abort here	[ 0 ]
eutils and toolchain funcs are unused so just delete them	[ 0 ]
When do you think it would be works on Windows Phone? We started project, without knowledge that it does not work and this is a hugh problem for us now. Does any one know some solutions to fix this shit on WP?	[ 1 ]
I like that @mapk The separate blocks feel a bit clumsy.	[ 1 ]
> make the categories defines so you cant fuck up by doing a typo What's the best way to make them? Through #define or /datum/?	[ 1 ]
@mhegazy This is ridiculous, I've been telling our entire team that this bug will be fixed in TypeScript 2.4 and now you've pushed it to 2.5? This bug makes debugging TypeScript with async methods impossible! Please re-evaluate your priorities here.	[ 1 ]
thank you for addressing my idiocy	[ 0 ]
damn it, I am getting sloppy	[ 1 ]
Its a real bummer we can't use "normal" ints just to have lombok require them.	[ 1 ]
wow this is horrific boilerplate, not going to force you to change that here though	[ 1 ]
the commas at the end of these lines should be removed	[ 0 ]
I know this isn't your code but golly gee this is bad	[ 1 ]
all of the above should be local vars pypi mirror url below too	[ 0 ]
This code is ridiculous. First we get the total queue length and put it in the buffer. Then we rewind the buffer then we increment the buffer to the total queue length. Then we copy out the total queue length. How about we just use the total queue length directly!	[ 1 ]
you can double free the object i think if you set destroyed then the list empty will be true both here and in sync obj remove pt you are not holding any locks in either place at the time of comparison	[ 0 ]
setting loc directly is bad since it fucks with connect_loc, and allowing eyeobj's to be moved to non-turf locs is dicey. use SetLoc() and get_turf(src)	[ 1 ]
ah you have removed a real code here please put it back	[ 0 ]
wow that is pretty terrible i find it hard to believe that this was in here all these years thankfully i just copied the from somewhere else so i only need to be half deathly ashamed about this please refactor this out into an extra patch since it is a generic fix not directly related to mt	[ 0 ]
"flower" Apart from the typo, heartily approved. It's gonna be hell on Proboscis folks, but that's a downside of being an insect.	[ 1 ]
remove stackforge here	[ 0 ]
the noqa is not needed any longer i uploaded a patch to remove them all c	[ 0 ]
afaik we do not implement per rule subscriptions for now so those can be killed	[ 0 ]
I wasn't able to get line 3756 in this comment (fucking shithub) but this appears to be a door button- do airlock accesses work on buttons?	[ 1 ]
nit s there their aw matt you are usually so hot on commit message grammar p	[ 0 ]
you setup specific mocks but you never actually change check the values you might consider consolidating into one mock for quantum agent linux ip lib ipnetnscommand as a whole	[ 0 ]
Sorry about the delay (I know it's ridiculous). I promise to look at it by end of weekend.	[ 1 ]
Just make two test scenes at this point. Using a string like this is a bit weird.	[ 1 ]
nit how about just kill hup dnsmasq threw s	[ 0 ]
Ok fair enough, no i wasnt talking about an actual seperatory funnel like what you would use with a hexane wash, just the ceramic funnels with the slotted bottom in it to so the filter paper doesnt get sucked into the flask	[ 1 ]
dcheck that oat class null	[ 0 ]
this explains part of the size t int change but i think we might still want to stick with size t for the driver side for clarity i hate signed int being used to represent the length of something	[ 0 ]
remove the black space	[ 0 ]
it isnt supposed to be usefull you uncivilized powercreeper its a CONTRABRAND locker for contrabrand not for fucking guns you already have the whole fucking armoury	[ 1 ]
i think you need to os environ copy or else this is all your env will have in it	[ 0 ]
> such as frames with no series well that's just ridiculous, who would concoct such madness!? :D in any case, if you encounter any type of error handling code whatsoever, there's a good chance i didn't write it :sweat_smile:	[ 1 ]
What else do we have for "FUCK YOU, YOUR INPUTS DO NOT MATTER", that isn't also available to players somehow?	[ 1 ]
should this be primary account info account info	[ 0 ]
wtf is this formatting XD. we use spaces for that. Also, I think that spaces after the - would probably look nicer	[ 1 ]
maybe make this number a function parameter as well i am guessing this like n tries or n seeds or something	[ 0 ]
do not t you need change this webob exc httpbadreques to self bad request	[ 0 ]
I found this in VSCode issues: https://github.com/Microsoft/vscode/issues/58607 @alexandrudima states that "The clipboard reading/writing in VS Code uses currently DOM APIs" but it is still ridiculous that VSCode cannot interoperate with VS2017.	[ 1 ]
Can someone please fix this. The previous response of it performing as expected so it's fine is ridiculous. It makes any kind of debugging a nightmare. It can't be that hard to add a simple boolean option to turn this nonsense off.	[ 1 ]
subnet subnet or self subnet	[ 0 ]
welcome to the hardcore fields motherfucker	[ 1 ]
:thinking: Damn. PR on hold until I resolve this gamebreaking issue some time tonight. EDIT: I forgot and went to bed without taking care of this. I'll get it tonight (16/05/2017).	[ 1 ]
compiling boot image	[ 0 ]
> one tank bomb do you have any idea how fucking big those are?!	[ 1 ]
put oslo serialization one here as it is in the same category	[ 0 ]
should the default value be false rather than true that way camp is enabled as a conscious choice by an operator rather than as the default choice	[ 0 ]
this seems like dirty hack extensions shall be deterministic	[ 0 ]
Damn, thought I'd got them all	[ 1 ]
that looks dangerous or useless either the pll is the current system clock and this will kill your system early or it is likely off at cold boot for jumping to rw firmware we might need something like that but i doubt it is currently correct maybe just a bypass of the clock setting code	[ 0 ]
one small errata corrige test spawn nova net vif no vswitch exception uses mocks as well it fails for other reasons	[ 0 ]
what this is a end user message get a reporter and abort after	[ 0 ]
Annex B is an abomination, but we love it because it is a reflection of ourselves and a valuable reminder of human fallibility.	[ 1 ]
can you set these fake instance ids to uuids	[ 0 ]
I thought it was a fucking offset KEVINNNNNNNN	[ 1 ]
> It sucks that this overlay duration is hardcoded in the first place, but this PR doesn\u2019t care. Maybe un-hardcoding this feature is a task for a later PR. I don't think so. This is limiting an already existing feature. It should not be hardcoded.	[ 1 ]
How the heckin do I get thread-count then	[ 1 ]
nothing i am an idiot then why do we actually have this	[ 0 ]
need to be removed	[ 0 ]
a possibly dumb question will not this command remove also the basic flow entry for allowing the ovs instance to behave as a regular mac based forwarding switch	[ 0 ]
There must be SOME explanation for this and a "gaydar" is the one that works best while also explaining how it works on non-regulated animals like mice.	[ 1 ]
Pfff - damn *buntu hipsters. Let me summon another shitstorm over them ;-)	[ 1 ]
let us shoot for years at least	[ 0 ]
It used to be that a male character could have a hyper-feminine face without being classified as a dick-girl; but it's now impossible to have a boy with a hyper-feminine face that isn't classified as a girl with a dick. My character is still a boy, just with very feminine features! Can we please stop changing the gender title based on the masculine/feminine face score to avoid this in the future? I'd like to be able to play as a masculine looking girl who is still a girl or a feminine looking boy who is still a boy.	[ 1 ]
Darn it, why do I have to document what should have already been documented in other PRs? Sigh. Edit: Actually, it's already documented. Never mind.	[ 1 ]
@jean-philippe-martin That's horrifying and bizarre...the string it clobbered didn't even resemble a package name!	[ 1 ]
what about not bool deserializing bool name is xor	[ 0 ]
yeah just kill those lines	[ 0 ]
rv is unassigned	[ 0 ]
Look at all those javascript files embedded in the head. It's like an onion of awful.	[ 1 ]
yes i overlooked that this does not get flattened here whichg does happen in plain with items	[ 0 ]
I can do that for you! I love spiders n shit	[ 1 ]
download manager delegate nullptr	[ 0 ]
the portage trees are indexed by the sysroot path with a trailing agreed this is kind of ugly	[ 0 ]
Ah shit did I get the symptom count and symptom level backwards	[ 1 ]

you will assign temp zone temp zone if bat temp c or

[ 0 ]

Damn, beautiful code. Only a genius could write something as beautiful as this ;)

[ 1 ]

Seriously, can we just do like a double $$ and be done with it? This is getting ridiculous. I feel so dirty having to use Fn::Join with serverless.

[ 1 ]

is exact here and below

[ 0 ]

yeah, np :P yep, I can't do returns because it has to jump to that only return so I have to store the result in a variable then jump there, clunky as hell but that's how I got it bin exact :)

[ 1 ]

hi sorry for the stupid question but how come we do not have a name for this initfunction like the others eg horizon d piechart init function

[ 0 ]

damn how did this get here

[ 1 ]

seems virtual size should be nullable n

[ 0 ]

this should return a boolean success failure value dcheck dir name null

[ 0 ]

yes you are right there is a double free happening here god catch dumb mistake do you think that there must be symmetry why cannot something get a factory create and ordinary destruction

[ 0 ]

There is no data copy, i fucked up summary

[ 1 ]

get rid of fi elif echo config fi

[ 0 ]

This is complete bullshit. You can forget it :shameonme

[ 1 ]

not weird at all actually this test was just broken because i am dumb fixed now hopefully

[ 0 ]

reverse iterator i am like i pulled it off one of the how to c sites but i will change it up

[ 0 ]

umm, holy crap, this is beautiful??

[ 1 ]

disabld disabled

[ 0 ]

Yes I know :/ But it worked smooth in my maps folder with 157 maps. Also I did not want to mess up the code too much by writing crappy cache code. Might look at ddnet how they handled it.

[ 1 ]

please use e ne e ne info for my primary e mail in community

[ 0 ]

this is what is in the base test l there are ips meant to be assigned to the port the first from the subnet and the second a specific one test is kind of idiot ic

[ 0 ]

should we deprecate and kill needs reload then once tabloader logic is in lifecyclemanager as well the only client is session restore now iirc maybe add a comment with a todo and a bug for this

[ 0 ]

Horny femboy cums on his little panties

[ 1 ]

this naming convention is terrible since our documented header names here show these as arraystart array start array start numbering internally just means we are going to mess this up in the future

[ 0 ]

ditto above it probably makes sense to abort here

[ 0 ]

eutils and toolchain funcs are unused so just delete them

[ 0 ]

When do you think it would be works on Windows Phone? We started project, without knowledge that it does not work and this is a hugh problem for us now. Does any one know some solutions to fix this shit on WP?

[ 1 ]

I like that @mapk The separate blocks feel a bit clumsy.

[ 1 ]

> make the categories defines so you cant fuck up by doing a typo What's the best way to make them? Through #define or /datum/?

[ 1 ]

@mhegazy This is ridiculous, I've been telling our entire team that this bug will be fixed in TypeScript 2.4 and now you've pushed it to 2.5? This bug makes debugging TypeScript with async methods impossible! Please re-evaluate your priorities here.

[ 1 ]

thank you for addressing my idiocy

[ 0 ]

damn it, I am getting sloppy

[ 1 ]

Its a real bummer we can't use "normal" ints just to have lombok require them.

[ 1 ]

wow this is horrific boilerplate, not going to force you to change that here though

[ 1 ]

the commas at the end of these lines should be removed

[ 0 ]

I know this isn't your code but golly gee this is bad

[ 1 ]

all of the above should be local vars pypi mirror url below too

[ 0 ]

This code is ridiculous. First we get the total queue length and put it in the buffer. Then we rewind the buffer then we increment the buffer to the total queue length. Then we copy out the total queue length. How about we just use the total queue length directly!

[ 1 ]

you can double free the object i think if you set destroyed then the list empty will be true both here and in sync obj remove pt you are not holding any locks in either place at the time of comparison

[ 0 ]

setting loc directly is bad since it fucks with connect_loc, and allowing eyeobj's to be moved to non-turf locs is dicey. use SetLoc() and get_turf(src)

[ 1 ]

ah you have removed a real code here please put it back

[ 0 ]

wow that is pretty terrible i find it hard to believe that this was in here all these years thankfully i just copied the from somewhere else so i only need to be half deathly ashamed about this please refactor this out into an extra patch since it is a generic fix not directly related to mt

[ 0 ]

"flower" Apart from the typo, heartily approved. It's gonna be hell on Proboscis folks, but that's a downside of being an insect.

[ 1 ]

remove stackforge here

[ 0 ]

the noqa is not needed any longer i uploaded a patch to remove them all c

[ 0 ]

afaik we do not implement per rule subscriptions for now so those can be killed

[ 0 ]

I wasn't able to get line 3756 in this comment (fucking shithub) but this appears to be a door button- do airlock accesses work on buttons?

[ 1 ]

nit s there their aw matt you are usually so hot on commit message grammar p

[ 0 ]

you setup specific mocks but you never actually change check the values you might consider consolidating into one mock for quantum agent linux ip lib ipnetnscommand as a whole

[ 0 ]

Sorry about the delay (I know it's ridiculous). I promise to look at it by end of weekend.

[ 1 ]

Just make two test scenes at this point. Using a string like this is a bit weird.

[ 1 ]

nit how about just kill hup dnsmasq threw s

[ 0 ]

Ok fair enough, no i wasnt talking about an actual seperatory funnel like what you would use with a hexane wash, just the ceramic funnels with the slotted bottom in it to so the filter paper doesnt get sucked into the flask

[ 1 ]

dcheck that oat class null

[ 0 ]

this explains part of the size t int change but i think we might still want to stick with size t for the driver side for clarity i hate signed int being used to represent the length of something

[ 0 ]

remove the black space

[ 0 ]

it isnt supposed to be usefull you uncivilized powercreeper its a CONTRABRAND locker for contrabrand not for fucking guns you already have the whole fucking armoury

[ 1 ]

i think you need to os environ copy or else this is all your env will have in it

[ 0 ]

> such as frames with no series well that's just ridiculous, who would concoct such madness!? :D in any case, if you encounter any type of error handling code whatsoever, there's a good chance i didn't write it :sweat_smile:

[ 1 ]

What else do we have for "FUCK YOU, YOUR INPUTS DO NOT MATTER", that isn't also available to players somehow?

[ 1 ]

should this be primary account info account info

[ 0 ]

wtf is this formatting XD. we use spaces for that. Also, I think that spaces after the - would probably look nicer

[ 1 ]

maybe make this number a function parameter as well i am guessing this like n tries or n seeds or something

[ 0 ]

do not t you need change this webob exc httpbadreques to self bad request

[ 0 ]

I found this in VSCode issues: https://github.com/Microsoft/vscode/issues/58607 @alexandrudima states that "The clipboard reading/writing in VS Code uses currently DOM APIs" but it is still ridiculous that VSCode cannot interoperate with VS2017.

[ 1 ]

Can someone please fix this. The previous response of it performing as expected so it's fine is ridiculous. It makes any kind of debugging a nightmare. It can't be that hard to add a simple boolean option to turn this nonsense off.

[ 1 ]

subnet subnet or self subnet

[ 0 ]

welcome to the hardcore fields motherfucker

[ 1 ]

:thinking: Damn. PR on hold until I resolve this gamebreaking issue some time tonight. EDIT: I forgot and went to bed without taking care of this. I'll get it tonight (16/05/2017).

[ 1 ]

compiling boot image

[ 0 ]

> one tank bomb do you have any idea how fucking big those are?!

[ 1 ]

put oslo serialization one here as it is in the same category

[ 0 ]

should the default value be false rather than true that way camp is enabled as a conscious choice by an operator rather than as the default choice

[ 0 ]

this seems like dirty hack extensions shall be deterministic

[ 0 ]

Damn, thought I'd got them all

[ 1 ]

that looks dangerous or useless either the pll is the current system clock and this will kill your system early or it is likely off at cold boot for jumping to rw firmware we might need something like that but i doubt it is currently correct maybe just a bypass of the clock setting code

[ 0 ]

one small errata corrige test spawn nova net vif no vswitch exception uses mocks as well it fails for other reasons

[ 0 ]

what this is a end user message get a reporter and abort after

[ 0 ]

Annex B is an abomination, but we love it because it is a reflection of ourselves and a valuable reminder of human fallibility.

[ 1 ]

can you set these fake instance ids to uuids

[ 0 ]

I thought it was a fucking offset KEVINNNNNNNN

[ 1 ]

> It sucks that this overlay duration is hardcoded in the first place, but this PR doesn\u2019t care. Maybe un-hardcoding this feature is a task for a later PR. I don't think so. This is limiting an already existing feature. It should not be hardcoded.

[ 1 ]

How the heckin do I get thread-count then

[ 1 ]

nothing i am an idiot then why do we actually have this

[ 0 ]

need to be removed

[ 0 ]

a possibly dumb question will not this command remove also the basic flow entry for allowing the ovs instance to behave as a regular mac based forwarding switch

[ 0 ]

There must be SOME explanation for this and a "gaydar" is the one that works best while also explaining how it works on non-regulated animals like mice.

[ 1 ]

Pfff - damn *buntu hipsters. Let me summon another shitstorm over them ;-)

[ 1 ]

let us shoot for years at least

[ 0 ]

It used to be that a male character could have a hyper-feminine face without being classified as a dick-girl; but it's now impossible to have a boy with a hyper-feminine face that isn't classified as a girl with a dick. My character is still a boy, just with very feminine features! Can we please stop changing the gender title based on the masculine/feminine face score to avoid this in the future? I'd like to be able to play as a masculine looking girl who is still a girl or a feminine looking boy who is still a boy.

[ 1 ]

Darn it, why do I have to document what should have already been documented in other PRs? Sigh. Edit: Actually, it's already documented. Never mind.

[ 1 ]

@jean-philippe-martin That's horrifying and bizarre...the string it clobbered didn't even resemble a package name!

[ 1 ]

what about not bool deserializing bool name is xor

[ 0 ]

yeah just kill those lines

[ 0 ]

rv is unassigned

[ 0 ]

Look at all those javascript files embedded in the head. It's like an onion of awful.

[ 1 ]

yes i overlooked that this does not get flattened here whichg does happen in plain with items

[ 0 ]

I can do that for you! I love spiders n shit

[ 1 ]

download manager delegate nullptr

[ 0 ]

the portage trees are indexed by the sysroot path with a trailing agreed this is kind of ugly

[ 0 ]

Ah shit did I get the symptom count and symptom level backwards

[ 1 ]