text
stringlengths 1
5.2k
| labels
listlengths 1
1
|
|---|---|
Who told you that!? Did my mother tell you that?! She promised she wouldn't say that anymore.
|
[
1
] |
Colon cancer, typecast that shit
|
[
1
] |
this should be put in the plugin s hiera
|
[
0
] |
there could be exception drivernotinitialized exception volumesizeexceedsavailablequota exception snapshotlimitexceeded exception cinderexception and maybe other exceptions in taskflow are here i am not sure so just like volume manage i feel exception is better here
|
[
0
] |
remove useless comment
|
[
0
] |
Huh? It failed with different checksum now.. Have they changed something again? This is getting ridiculous. This was working for me definitely - tested the 2020.0
|
[
1
] |
curious as to why the caller is not also making use of a flat set
|
[
0
] |
Keep TEG gone it sucks
|
[
1
] |
you should initialize the fip q dict here
|
[
0
] |
better way would be make the mocks as setup and make these return values as self members
|
[
0
] |
nit what the fuck is not necessary ditto for the rest of the patch
|
[
0
] |
By the way, what the fuck was whoever wrote this thinking?
|
[
1
] |
is python virtualenv already python or do you require python virtualenv here otherwise python dev would be nonsense no
|
[
0
] |
Ideally we'd have a lint but our tools are not good enough for that (please do not fucking regex this)
|
[
1
] |
one thing that might confuse dumb people like me is that here we are talking about deprecation from a deployer perspective as we will migrate the same api over to the new repo and it will be consumed in the same way so perhaps make this dumb proof by stating specifically what you will deprecate
|
[
0
] |
use ostringbuffer to construct the string or at least drop the useless intermediate string vars
|
[
0
] |
This link is a bit weird.
|
[
1
] |
dumb question why do you need to put noqa at the end of this and also at line
|
[
0
] |
use executils save and reraise
|
[
0
] |
this one is dirty hack for avoiding cycle import agree with rewriting it later
|
[
0
] |
Damn it, though I found them all :sweat_smile:
|
[
1
] |
> That's pretty ridiculous if you look at it objectively, we should have !docker and docker, respectively. That is !not-ridiculous
|
[
1
] |
that kind of conflict resolution should make this a backport
|
[
0
] |
that race is already gone because we do not recurse into mkdirs
|
[
0
] |
tenant id should be removed
|
[
0
] |
these should be run through i n
|
[
0
] |
rather than doing this have you considered doing lazy joined on dns nameservers and host routes for reference see c having said that i am gonna make the same comment i made on a few other reviews i personally would like to get us to think about having rally scenarios accompany these types of patches ideally we would have a patch that introduces a rally scenario that sets a baseline and a dependent patch that shows the performance gain
|
[
0
] |
db express maybe what if tomorrow you have another db
|
[
0
] |
I tried but it caused shitcode. And I dont really think its needed here.
|
[
1
] |
Absolutely baffled that the best way to access filter vars is `:`. what the hell. No requested change I'm just mad in general
|
[
1
] |
i was actually meaning file there and being stupid the trace is what i want anyway the trace will now get logged and pass the same short error message up to the caller so i think this does the right thing now
|
[
0
] |
we can kill it if you want
|
[
0
] |
ugh do we really do a separate lua recovery job for each volume gross
|
[
0
] |
yeah toolbox might be better, originally i had a flimsy plastic one in my head but the sprite looked like shit so i'm making it bigger overall
|
[
1
] |
since check ports exist on l agent has been mocked to return a certain value just mock mock is enough to get subnet ids on router the same to l l l l
|
[
0
] |
Damn, didn't know this fact. Thanks!
|
[
1
] |
I'm thinking that application writers might want to be able to ask that question in code. Asking them to call `OpenSSL_version(OPENSSL_CFLAGS)` and parse it ('cause that's what I'm getting out of your suggestion, @mspncp) seems very clumsy to me.
|
[
1
] |
copying this all over the place does sound a waste wouldn t it be better to move it to neutron conf
|
[
0
] |
i will remove max retries
|
[
0
] |
amqp names amqp ipaddresses amqp ipaddresses amqp ipaddresses
|
[
0
] |
Damn. How did compile locally?
|
[
1
] |
Please try to reproduce without extensions. Otherwise I would have to blame this on the extensions. Also if it was something in the core others users would also complain as this is some basic rendering being screwed up.
|
[
1
] |
copying this all over the place does sound a waste wouldn t it be better to move it to neutron conf
|
[
0
] |
throw an illegalargumentexception when the thumb is null
|
[
0
] |
Can't be arsed to deal with the "you don't even play here lol" crowd every balance pr
|
[
1
] |
you do not use these jobs in zuul layout yaml you should either remove them from here or use them in zuul layout yaml
|
[
0
] |
Literally shitposting in the code.
|
[
1
] |
Not really. If you're expanding the functionality of something it's generally also expected that you take in account that we don't want the shitty code to become even worse.
|
[
1
] |
insecure hash algorithms missing here
|
[
0
] |
maybe a dumb question but will there ever be an extension in a connection url path that is do we need this part or could we simply path join path cell
|
[
0
] |
this looks the firewall rules table
|
[
0
] |
remove this image it is useless
|
[
0
] |
put this in the message body rather than the subject
|
[
0
] |
A briefcase is shitty anyways. Don't mind it getting a bonus. And the bonusses are not capped and get insane with a random amount of bling. (spawned some tuxedo's, fancy watches and top hats, got it up to 43).
|
[
1
] |
kill yet by then already terminated
|
[
0
] |
i would also mention agetty dmesg flock fsck getopt hexdump ionice logger there are also to a lesser degree hwclock fdisk losetup mkfs swapon swapoff some of these we will probably want to refine in the future but this is a good starting point
|
[
0
] |
looks like it is trash can we save only self cancel none here without log error
|
[
0
] |
DAMN! look at all that conditional logic
|
[
1
] |
why did this go from a handy konstant to hard coded
|
[
0
] |
should not this just be in the try block
|
[
0
] |
another bad function name isoperatorconciderednonroaming
|
[
0
] |
They can buy syndicate space suits and the elite hardsuits, but not their own? Seems a bit weird.
|
[
1
] |
i think the dust needs to settle before we add anything like this to the c library memset s would probably be a less bad idea all those annex k functions are ugly and unnecessarily awkward but they made it into a real standard so there is not much we can do to argue against them
|
[
0
] |
let s get rid of mock here
|
[
0
] |
rc eq is not needed here above we return from the function if rc ne
|
[
0
] |
well not for humans and walls and shit since they're made up of a bunch of MAs
|
[
1
] |
please clean up after this fails before returning
|
[
0
] |
this should be self qos driver delete
|
[
0
] |
this should be pulled into solum
|
[
0
] |
Seriously? Is there no better way?
|
[
1
] |
i guess the wrong value comes from the feed which has nonsense
|
[
1
] |
please add newline after colon
|
[
0
] |
well at this point the name is misleading so we need to change it too
|
[
0
] |
stupid question is aodh enabled by default in the overcloud
|
[
0
] |
this seems to me to be another id id problem did we ever decide the proper usage of id in the context of cloudcafe
|
[
0
] |
i think this message should be removed
|
[
0
] |
Maybe I am a little paranoid, but is it worth checking if `usr == src` here ? Can you fuck with winsets by typing something of the form `byond://[url that forces open a winser]` ?
|
[
1
] |
we send x kill to process in while loop why send one more we should return ocf err generic here if kill not killed our process pacemaker should move resource to unmanaged stonith should kill node in current approach we will hide problem from pacemaker user which can lead to strange galera behavior data loss but this dosent mean that problem disappears
|
[
0
] |
resize up enabled flavors config resize enabled if flavors config resize enabled is not none else flavors config resize enabled
|
[
0
] |
@KcHecKa Yeah, that would be something we get without any extra work. I've wanted that fixed for ages, too, exclusive fullscreen sucks!
|
[
1
] |
running abort from a trybot is going to be dangerous it could at least abort other trybot runs and potentially abort suggest just not running it
|
[
0
] |
Closing due lack community interest and not wanting to leave stale rubbish amongst all the proper bugs and feature requests in here :)
|
[
1
] |
why is it called no_deconstruct if it doesn't block deconstruction, what the hell
|
[
1
] |
per tom this sounds like it should be an h i am not sure if the h s that follow should in turn be h s
|
[
0
] |
nit lol garbage collect perhaps remove
|
[
0
] |
these ugly ass defines still exist? smh
|
[
1
] |
this should only be done if an existing cache is not there or if the deployer forces the rebuild of the cache
|
[
0
] |
I'm not 100% sure about this one given, "Please Excuse My Dear Aunt Sally" but it does make things a little easier to read so ????
|
[
1
] |
The amount of plumbing here is ridiculous. Here are the key files to look at, roughly in order: * `interfaces.go` * `config_local.go` * `keybase_service_base.go` * `tlf_handle_resolve.go` * `tlf_handle_test.go`
|
[
1
] |
really dumb nit two spaces after api
|
[
0
] |
Crap, mustve got lost in some rebase somehow.
|
[
1
] |
indention off
|
[
0
] |
Hm. Now I have a bizarre issue (might have been there before) where about 1 out of 4 times, when switching display resolution on my Nexus 5X, it renders tiny in the upper left corner... Damn this stuff is tricky.
|
[
1
] |
fdo to prevent the bugzilla notifications to misfire against the wrong bug
|
[
0
] |
kill renderer if this or begin frame response returns false
|
[
0
] |
i thought so but when i only used connection packstack was failing with the error in my wip comment or bz considering neutron server implementation it should be ok to just use connection and leave sql conection undef or false but well after few months with puppet everything is im possible unfortunately
|
[
0
] |
wont the figure become clumsy if we add the iso-f1 curves in the existing plots!??
|
[
1
] |
Indentation here is pretty messed up.
|
[
1
] |
you are so old school with argparse we the cool guys call it args unlike those dinosaurs using optparse done with dissimulated disconformity
|
[
0
] |
this describe block should be collapsed into a single test
|
[
0
] |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.