text
stringlengths 1
5.2k
| labels
listlengths 1
1
|
|---|---|
router id should be floatingip db router id please cover this piece of code with a unit test
|
[
0
] |
uint t ptemp src
|
[
0
] |
s dictionary dictionary should be removed after supported
|
[
0
] |
this backslash is unnecessary and should be eliminated
|
[
0
] |
Also I'm glad you brought up *lazy*. Adding *lazy* to the list **puts this at 5 seconds**, which is utterly ridiculous: <img src="Screen Shot 2018-01-29 at 4.39.57 PM.png" class="thumbnail" /> In *Swift 4.0* that still took less than 400ms.
|
[
1
] |
nit maybe directorynotwritable
|
[
0
] |
i think it should be squashed in previous requst
|
[
0
] |
you do not need the here you used as the delimiter already put a die at the end
|
[
0
] |
There's a version of the finale that spawns with crappy pistols and low level ammo, even those are gated behind reinforced glass. I've not done map JSON stuff yet, but I think I could definitely Surround it in reinforced glass. edit: That would be if I could find it. Isn't it supposed to be in lab_floorplans_finale1level? double edit:It's in one of the hardcoded mapgen.cpp files, not JSON. Will take me a fair bit longer.
|
[
1
] |
WHAT IS THAT WHAT THE FUCK IS THAT
|
[
1
] |
afaic this does not make sense
|
[
0
] |
looks like this should be arg to elements
|
[
0
] |
no it is not necessary if we leave the lazy load since it is a not a db sqla fk that we wonder if we should pull or not
|
[
0
] |
i hate you i hate your existence i wish you were never born and i wish you would burn in hell forever
|
[
1
] |
i think this is a great opportunity to port this to signal sigterm and os kill
|
[
0
] |
also kglobalvaluenumbering and kgvndeadcodeelimination
|
[
0
] |
you should have a launchpad bug here bzs are not appropriate for upstream work
|
[
0
] |
oh sh!t, that's some good stuff
|
[
1
] |
nit this check is testing what the fuck vector is initialized empty which is not needed here
|
[
0
] |
because I missed it, crap :P
|
[
1
] |
I went through the app and didn't notice any anomalies. But I guess it's up to our last line of defence, "the Testers"! You know what a sucker I am for quality refactorings, so gehen Sie geradeaus mit dem merge!
|
[
1
] |
get children will return empty list it children do not exist
|
[
0
] |
nit boolean values are trivial and following the musician s comment these should be dropped
|
[
0
] |
this will be so this is a useless printout
|
[
0
] |
i believe this god added by mistake
|
[
0
] |
agreed this annoyed me too but could not figure out an easy way to do it
|
[
0
] |
you should remove these whitespaces
|
[
0
] |
> @nashif I assume, with this, we will no longer need an abomination like the following, is that correct? yes
|
[
1
] |
module level variables should be defined at the top of the module
|
[
0
] |
please add a consistent prefix like bootstage to each of these
|
[
0
] |
should we assert anything here or that is already all done by findbyfilename
|
[
0
] |
Well, `VISIBLE_MAP` has an even less clearly talking name, but a fine Kdoc - so I went a middle ground. By the way - I do very much dislike those new all-caps names that popped up... :zany_face:
|
[
1
] |
Ohh, ... I thot it to be an english vs american thin. Getting comfortable with force push is dangerous. Almost messed up another PR but cathed it in time.
|
[
1
] |
ironic conductor utils node power action
|
[
0
] |
is this exec idempotent by removing the refreshonly this will be triggered on each puppet run what would be the impact
|
[
0
] |
i will rebase this patch and submit once the patch from intel goes in
|
[
0
] |
ok my concern is that would impact a lot more code and status is notorious for being kind of garbage on some services which is part of the systemd win that we will get on ubuntu in the next lts and be able to dump all these work arounds
|
[
0
] |
Airlocks shouldn't give any fucks if someone is in them. Oh you rather have your legs rather than have to breath? Tough, you don't have a choice
|
[
1
] |
Alert menus are pretty terrible, don't do this. A message and verb or HUD button somewhere to take over is better.
|
[
1
] |
it s should be flavorid done
|
[
0
] |
kmaxvalue invalid url
|
[
0
] |
whitespace
|
[
0
] |
okay this is stupid setting the read deleted attribute of the context a context which is shared by all periodic tasks within the same run is bad please ignore and i will be back with something that addresses hans comment
|
[
0
] |
Gee, look. Isn't it 454 new shiny lines of Odysseus mounted sleeper code made into freaking vore fetish?
|
[
1
] |
Why is it plasma Why do you get to bitch about UGH FREEON SO UNREALISTIC then immediately turn around and make Plasma do it
|
[
1
] |
can you generalise this what I assume is rotation/spinning shit into some helper procs please this wall of nested code makes me want to gouge out my eyes
|
[
1
] |
But the clean surface requirement for all butchery is ridiculous! it pretty much requires debugging in some kind of sheet and is unrealistic
|
[
1
] |
here and everywhere else add no silhouette next to false false no silhouette
|
[
0
] |
all std types will be migrated to what the fuck types once we move these classes from blink public to blink renderer once they have no dependents in content i do not think there is any value in temporarily moving this to webvector since it should be a what the fuck vector
|
[
0
] |
About that totally right, that line lengths gonna to kill me.. lol I dont really have the habit to use that lower ones. I'll fix them.
|
[
1
] |
this is honestly hilariously ridiculous
|
[
1
] |
this is comparator for std sort should behave like an opeartor
|
[
0
] |
just die
|
[
0
] |
you can remove this if statement attachments vol get volume attachment for attachment in attachments
|
[
0
] |
So the code that looked like complete nonsense was actually correct? It probably needs a comment to save the next person who looks at it from thinking it's crazy. The tests are nice. I sign off.
|
[
1
] |
why you are wrapping dict agan in dict
|
[
0
] |
why did you go for the pthread implementation over the spinlock implementation should we kill the spinlock implementation move the pthread implementation into the need quasiatomic block at the bottom and have non lrdex arm and mips and x all fall through to that my primary concern here is that i do not want two copies of this code in the same file but if i can kill the spinlock stuff at the same time that is even better actually i will do this for you
|
[
0
] |
allow put should be false as well as segmentation id and mac address
|
[
0
] |
I agree this is messed up because we use the icons for things we want the screen reader to read. I don't want screen readers to ignore my social icons but putting them in an i tag is ridiculous and inaccessible.
|
[
1
] |
remove all the coments too
|
[
0
] |
so what is the recommendation here still return false and just kill the error msg
|
[
0
] |
Damn i'm so used to adding spacing for other projects
|
[
1
] |
I hate typos. It's "it's" instead of "its".
|
[
1
] |
why not use a unique ptr this way you do not need to free it explicitely in onshutdown
|
[
0
] |
Yeah, all C++-casts I tried ended up in complaints. No objections, drop this shit alltogether.
|
[
1
] |
Everyone who goes against you commit a excuse. Do you have a idea of how absurd is you not being the creator of the PPSSPP and delegitimizing the other users issues? People comes here to make issues and wait the @hrydgard answer or not. If you agrees with my issue, you send a message and say something good. If you think that my idea sucks, just not respond and save your lifetimes. You live in society like this. Not saying that all that you don't like it's sucks directly to the people. Respect the others, instead saying that is just a excuse, or a sucks issue. It's the minimal that you can do to live in society.
|
[
1
] |
need it for sdhci lib otherwise see a compilation error
|
[
0
] |
can you add from keystone openstack common gettextutils import here there is a review to get rid of the builtin monkey patching c
|
[
0
] |
nit this and onassistantcontrollerdestroying should be moved down between onhighlighterenabledchanged and ondeeplinkreceived to match the declaration order in header
|
[
0
] |
Damnit. I still actually need to test the knockback stuff, haha.
|
[
1
] |
max mbr size mb let s keep the units
|
[
0
] |
Oh, darn. But please add a comment saying that, just on the line above.
|
[
1
] |
this should not be necessary since you are using scenariotestcase as a base
|
[
0
] |
oh lordy. did that trying to fix a merge conflict, aagh
|
[
1
] |
task action exs db api get action executions task execution id task ex id
|
[
0
] |
dev quickstart rst also needs verbose false
|
[
0
] |
@RPCS3sucks not their either They take donations, and that is only the _main_ devs. Others work for free. Grow up.
|
[
1
] |
Can we wrap this line? It's giant absurdly long :)
|
[
1
] |
why does it have to be an admin test i don t see any operation that needs to be executed as admin
|
[
0
] |
yea i will shoot for l
|
[
0
] |
Agree with some of the comments that this is a bug worthy of fixing because the workaround stated above is quite frankly untenable (and borderline ridiculous, as pointed out by @MrGadget1024 two years ago).
|
[
1
] |
want to make this lazy
|
[
0
] |
this is where i think we should have subclassed hostinfo to be numahostinfo or something and pass that into the connection here stabbing our data into it like below is less than desirable i think
|
[
0
] |
this one looks to be useless
|
[
0
] |
ugly. make Hidden a property and actually do this inside the beatmapGroup.
|
[
1
] |
private key keypair private key
|
[
0
] |
nit move to private since we do not want external code to call this
|
[
0
] |
let s move the bad mac check into wifi data provider mac since we are pretty sure it is a mac only issue then we can add a dcheck here to make sure we are getting valid data on all platforms that way if we run into the same issue on another platform we will find out about it instead of silently dropping the wifi data
|
[
0
] |
Who ever read this is gay
|
[
1
] |
it s better if we wrap such traversal into a function
|
[
0
] |
spelling ir relev a nt here and everywhere pls
|
[
0
] |
introduce static constexpr size t kmipsbitsperword kmipswordsize kbitsperbyte and use it instead of here and below
|
[
0
] |
put str split instead of str replace
|
[
0
] |
@fvigo It's a joke PR. I promise we aren't merging it lol. The code uses only built-ins and indexes to print hello world without using a string or a print statement. It's meant to be super bizarre ;)
|
[
1
] |
> calling a for loop every goddamn second > calling a view() every goddamn second too
|
[
1
] |
vcneter should be vcenter
|
[
0
] |
hrmhrmhrnrhrnr (i'm not gonna make you fix this but god dammit)
|
[
1
] |
done that was just for git cl lint complaining about sprintf vs s n printf nothing important
|
[
0
] |
this leads to a useless error message use this instead self assertthat links self matchers endswith revoked list url
|
[
0
] |
i think this red mark means extra space that should be removed
|
[
0
] |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.