showvikdbz/code-reviews · Datasets at Hugging Face

text stringlengths 1 5.2k	labels listlengths 1 1
maybe the value for this should be maintained from executing env if it exists	[ 0 ]
This bot is ridiculous - stop closing issues just because no-one has bothered to act on them	[ 1 ]
oh god oh fuck he's reviewing a closed pr	[ 1 ]
i recently added gating test section at line please delete it and move test fuel agent section here	[ 0 ]
with mocks you would have to add these return values which is what the fakes are doing	[ 0 ]
@pedrobaeza Tell us by what kind of authority you're here to decide what is nonsense and what is not. Clearly this is a feature many of us used in the previous versions. Who are you to decide for us what we would employ? This is a bit Microsoftish, isn't it? which makes you a good candidate for an Outlook team, lol not Odoo	[ 1 ]
This is pretty bad, leaves overridden functions invalid. Honestly i don't quite understand why you insist on adding it in attack, it just makes the whole thing more complicated.	[ 1 ]
God damn it you're right, don't move this comment and these defines tho, they should both be local to this file.	[ 1 ]
i do not think that is what you want probably something like the following instead grep v f symbol excludes grep f symbol includes sort u	[ 0 ]
I didn't remove any brain prefabs wtf going to see whats wrong with this	[ 1 ]
and volumes ceph images ceph and ephemeral ceph are all false	[ 0 ]
bgp speaker id should be bgpspeakernetworkbinding bgp speaker id and network id should bgpspeakernetworkbinding network id	[ 0 ]
This is ugly and prolly should be moved somewhere else..	[ 1 ]
this is ridiculous, you made a special case at the price of breaking a fundamental concept, what is a top type that can fit `o[k]` now?	[ 1 ]
nit s currenency concurrency	[ 0 ]
if you change these you need to change the places in the code that finds these objects by these ids	[ 0 ]
i mean it should be formatted as surface rect empty	[ 0 ]
i have the overall switch called out a few points down i will kill off enable step because yeah it is overkill on calling it out	[ 0 ]
farmoffortune.fortunehunters.space is very safe,people are doing this because of jealousy	[ 1 ]
ah are you serious i really dislike fixed names somewhere in tmp with absolutely unclear name	[ 0 ]
cell attributes tooltip dict get would be sufficient you do not need the get help text function	[ 0 ]
No, it should be flags, in a var on the component, instead of an arbitrary numbering system where if anything is bigger it's allowed (e.g. the byond invisibility system, which sucks)	[ 1 ]
Fucking hell did I forget to add them to the commit Yeah. Somehow.	[ 1 ]
fortunately we have only gdbserver in the subdirectories	[ 0 ]
Femboys holding anime books?,	[ 1 ]
why not just os setpgid on the process to detach it from parents and then keep the killpg to kill all children	[ 0 ]
ok let us kill it makes sense	[ 0 ]
how to validate a junk uuid let s assume user sends some junk value intentionally	[ 0 ]
in ceph health sh only health subcommand is used it does not look good to allow zabbix user to do anything except specified parameters also applies to the rest of permissions here	[ 0 ]
Damn pre-existing wording problems.....	[ 1 ]
just remove from self l agent and it should pass	[ 0 ]
opps will kill that	[ 0 ]
this should be group solum core without the project here is a good example	[ 0 ]
redundant init remove	[ 0 ]
it was added because in some cases method list user ids for project returns dumb member it s happened because sometimes members returning in the follow form member u cn dumb dc nonexistent u cn d a dbb bb d b c fddf ou users cn example cn com in this case member is dumb and i added this test and test list user ids for project dumb member to ensure that such members will be missed	[ 0 ]
please group these with oslo imports on l	[ 0 ]
whitespace is a little weird	[ 1 ]
Fuckin hell hahaha...	[ 1 ]
Ah, I see how it is. Shitcode like this (the original mouse code) makes me wish there was some way to call the grandparent's `New()`, skipping the parent entirely...	[ 1 ]
this is a nasty OD from just the O2 perspective (It does Tox damage so hard to use perf for this guy)	[ 1 ]
are useless	[ 0 ]
duplicate for pep should be removed	[ 0 ]
why is not it an ironicexception	[ 0 ]
this would be a case to use cros build lib die	[ 0 ]
`forced = "You son of a bitch, he's in."`	[ 1 ]
pls use cfg conf set override	[ 0 ]
Yes, I don't understand why the entire language has gone open source, but the spec hasn't been updated. Seems kind of ridiculous.	[ 1 ]
> Please note that I'm only talking about the 2 try-catches in For-Of loops. I'm not saying "you should encapsulate all try-catch"; that would be ridiculous. this is what i understand, maybe I mis-read.	[ 1 ]
sachi juno is end of life there should not be any project that you are touching that uses juno	[ 0 ]
haha damn, that's terrible	[ 1 ]
you are right it is useless now i would remove it	[ 0 ]
Agreed; This is a good idea. I use arel_table an awful lot in order to access predicates, and I find it rather clumsy to have to assign it first.	[ 1 ]
Yeah that would be much better, but the way ShaderData is right now really sucks and is due to a refactor (likely after @BastiaanOlij finished reorganizing code).	[ 1 ]
there should probably be a logcat entry if the errno enoent so filesystems problems can be spotted	[ 0 ]
i think yes because when deleting firewall policy all rules which is related the firewall policy should be removed	[ 0 ]
if remove self needs resync this func will not be needed	[ 0 ]
Well shit happens, lets try to keep it civil. Should I ditch the comment?	[ 1 ]
sorry fat fingers it s hoststate db updated compute update at hoststate updated	[ 0 ]
this should be wrapped in a try except block	[ 0 ]
Fucking faggot ghosts man i swear to god	[ 1 ]
one bogus function from util mach child port server cc and five bogus functions from util mach notify server cc gerrit is being absolutely awful but it looks like you did not actually remove the now unused stubs in the two other cc files do h they are sitting on my workstation unstaged i will send a follow up tomorrow	[ 0 ]
see my remarks on configure etcd sh	[ 0 ]
you mean just prepend to the head like add search path a add search path b add search path c result list head c b a	[ 0 ]
too bad it's the only way to do it without readding holding shit while resting	[ 1 ]
deleted data is garbage but update is a different story how do you propose to deal with out of date info in df db here	[ 0 ]
gyp files made by silly writers e g l	[ 0 ]
ugh i am an idiot this comment makes no sense because i did not see that lines were still part of this function please ignore sorry	[ 0 ]
small nit env dir need not be in brackets	[ 0 ]
these lines should be useless headers are string already so you can drop that	[ 0 ]
suggest to remove the loop just assign motion sensors addr and motion sensors addr individually	[ 0 ]
nit did you git cl format this seems longer than lines	[ 0 ]
gah they both did that	[ 0 ]
i would name this default session json file template so people will remember to give it an arg	[ 0 ]
looks right to me int futex int uaddr int op int val const struct timespec timeout int uaddr int val nr futex ftx op value timeout null bitset uaddr ftx op op val value timeout timeout uaddr null val bitset	[ 0 ]
bald is redefined above, so that's weird	[ 1 ]
i am not crazy about this error being here because this is parse root device hints not eg find device but i guess it can be cleaned up later	[ 0 ]
remove vmax	[ 0 ]
if you are looking for an execution thrown by clientconnectandhandshake it would be more correct to catch an executionexception here	[ 0 ]
is this a mistake in the test ie should we really be doing an assertin using estr to check the string returned from assertraises	[ 0 ]
Damn, thanks for the heads up	[ 1 ]
Hey man are you gay because you keep putting all these silly love hearts in your repositories it makes me think you are gay man...	[ 1 ]
it took me a ridiculously long time to realize you missed a c	[ 0 ]
has exception exc	[ 0 ]
Just a heads up that the coverage report is a bit rubbish as this changes a lot of code w/o changing downstream tests. I have pushed coverage up on #95 to compensate	[ 1 ]
Added a popover menu (see screenshot), it allows you to load a magnet quicker, you just click to open it, then you can type out the whole link if you're a faggot, or you already have it in your clipboard, in that case, you can add a manget just by double-clicking the icon.	[ 1 ]
if you go through with this kill these too	[ 0 ]
potentially stupid question didn t neutron use neutron db manage instead of db sync the same case is with heat i think they use heat manage db sync	[ 0 ]
Also, some of these jokes are pretty offensive (being yo momma jokes), I wonder if it's appropriate to have it on a chat bot... (We wouldn't want a [Tay ](https://en.wikipedia.org/wiki/Tay_(bot))fiasco :) )	[ 1 ]
propertymodel and onattachstatechangelistener are not needed anymore	[ 0 ]
use extra specs	[ 0 ]
No. Modify slurring handling in ethanol/on_mob_life() to suit your idea but don't add some shitty check here.	[ 1 ]
this now throws npe on null not iae	[ 0 ]
The hack is even a step uglier than for `@fluentui/dom-utilties` I needed to add a resolution because there is no major version under v8 that I can use for `@fluentui/utilities`	[ 1 ]
is there any reason you do not fail if this is not true seems like a mangled header would get by this check nit startswith may read cleaner	[ 0 ]
why do not you just use ifneq jack server false here	[ 0 ]
hmm this is pretty ugly i guess you are doing this to save the type and fold passes right	[ 0 ]
i think you did your math wrong i think it is bd value size char bit count i honestly do not know why we did it thus but this is something i did not change	[ 0 ]
should leave this at 50, engiborgs are supposed to have shitloads of wire for the solars	[ 1 ]
i think it should be qosbandwidthlimitrule not qosrule	[ 0 ]
Darn... shame on me for not doing enough research on how this works, thanks for the heads up! \U0001f605	[ 1 ]

maybe the value for this should be maintained from executing env if it exists

[ 0 ]

This bot is ridiculous - stop closing issues just because no-one has bothered to act on them

[ 1 ]

oh god oh fuck he's reviewing a closed pr

[ 1 ]

i recently added gating test section at line please delete it and move test fuel agent section here

[ 0 ]

with mocks you would have to add these return values which is what the fakes are doing

[ 0 ]

@pedrobaeza Tell us by what kind of authority you're here to decide what is nonsense and what is not. Clearly this is a feature many of us used in the previous versions. Who are you to decide for us what we would employ? This is a bit Microsoftish, isn't it? which makes you a good candidate for an Outlook team, lol not Odoo

[ 1 ]

This is pretty bad, leaves overridden functions invalid. Honestly i don't quite understand why you insist on adding it in attack, it just makes the whole thing more complicated.

[ 1 ]

God damn it you're right, don't move this comment and these defines tho, they should both be local to this file.

[ 1 ]

i do not think that is what you want probably something like the following instead grep v f symbol excludes grep f symbol includes sort u

[ 0 ]

I didn't remove any brain prefabs wtf going to see whats wrong with this

[ 1 ]

and volumes ceph images ceph and ephemeral ceph are all false

[ 0 ]

bgp speaker id should be bgpspeakernetworkbinding bgp speaker id and network id should bgpspeakernetworkbinding network id

[ 0 ]

This is ugly and prolly should be moved somewhere else..

[ 1 ]

this is ridiculous, you made a special case at the price of breaking a fundamental concept, what is a top type that can fit `o[k]` now?

[ 1 ]

nit s currenency concurrency

[ 0 ]

if you change these you need to change the places in the code that finds these objects by these ids

[ 0 ]

i mean it should be formatted as surface rect empty

[ 0 ]

i have the overall switch called out a few points down i will kill off enable step because yeah it is overkill on calling it out

[ 0 ]

farmoffortune.fortunehunters.space is very safe,people are doing this because of jealousy

[ 1 ]

ah are you serious i really dislike fixed names somewhere in tmp with absolutely unclear name

[ 0 ]

cell attributes tooltip dict get would be sufficient you do not need the get help text function

[ 0 ]

No, it should be flags, in a var on the component, instead of an arbitrary numbering system where if anything is bigger it's allowed (e.g. the byond invisibility system, which sucks)

[ 1 ]

Fucking hell did I forget to add them to the commit Yeah. Somehow.

[ 1 ]

fortunately we have only gdbserver in the subdirectories

[ 0 ]

Femboys holding anime books?,

[ 1 ]

why not just os setpgid on the process to detach it from parents and then keep the killpg to kill all children

[ 0 ]

ok let us kill it makes sense

[ 0 ]

how to validate a junk uuid let s assume user sends some junk value intentionally

[ 0 ]

in ceph health sh only health subcommand is used it does not look good to allow zabbix user to do anything except specified parameters also applies to the rest of permissions here

[ 0 ]

Damn pre-existing wording problems.....

[ 1 ]

just remove from self l agent and it should pass

[ 0 ]

opps will kill that

[ 0 ]

this should be group solum core without the project here is a good example

[ 0 ]

redundant init remove

[ 0 ]

it was added because in some cases method list user ids for project returns dumb member it s happened because sometimes members returning in the follow form member u cn dumb dc nonexistent u cn d a dbb bb d b c fddf ou users cn example cn com in this case member is dumb and i added this test and test list user ids for project dumb member to ensure that such members will be missed

[ 0 ]

please group these with oslo imports on l

[ 0 ]

whitespace is a little weird

[ 1 ]

Fuckin hell hahaha...

[ 1 ]

Ah, I see how it is. Shitcode like this (the original mouse code) makes me wish there was some way to call the grandparent's `New()`, skipping the parent entirely...

[ 1 ]

this is a nasty OD from just the O2 perspective (It does Tox damage so hard to use perf for this guy)

[ 1 ]

are useless

[ 0 ]

duplicate for pep should be removed

[ 0 ]

why is not it an ironicexception

[ 0 ]

this would be a case to use cros build lib die

[ 0 ]

`forced = "You son of a bitch, he's in."`

[ 1 ]

pls use cfg conf set override

[ 0 ]

Yes, I don't understand why the entire language has gone open source, but the spec hasn't been updated. Seems kind of ridiculous.

[ 1 ]

> Please note that I'm only talking about the 2 try-catches in For-Of loops. I'm not saying "you should encapsulate all try-catch"; that would be ridiculous. this is what i understand, maybe I mis-read.

[ 1 ]

sachi juno is end of life there should not be any project that you are touching that uses juno

[ 0 ]

haha damn, that's terrible

[ 1 ]

you are right it is useless now i would remove it

[ 0 ]

Agreed; This is a good idea. I use arel_table an awful lot in order to access predicates, and I find it rather clumsy to have to assign it first.

[ 1 ]

Yeah that would be much better, but the way ShaderData is right now really sucks and is due to a refactor (likely after @BastiaanOlij finished reorganizing code).

[ 1 ]

there should probably be a logcat entry if the errno enoent so filesystems problems can be spotted

[ 0 ]

i think yes because when deleting firewall policy all rules which is related the firewall policy should be removed

[ 0 ]

if remove self needs resync this func will not be needed

[ 0 ]

Well shit happens, lets try to keep it civil. Should I ditch the comment?

[ 1 ]

sorry fat fingers it s hoststate db updated compute update at hoststate updated

[ 0 ]

this should be wrapped in a try except block

[ 0 ]

Fucking faggot ghosts man i swear to god

[ 1 ]

one bogus function from util mach child port server cc and five bogus functions from util mach notify server cc gerrit is being absolutely awful but it looks like you did not actually remove the now unused stubs in the two other cc files do h they are sitting on my workstation unstaged i will send a follow up tomorrow

[ 0 ]

see my remarks on configure etcd sh

[ 0 ]

you mean just prepend to the head like add search path a add search path b add search path c result list head c b a

[ 0 ]

too bad it's the only way to do it without readding holding shit while resting

[ 1 ]

deleted data is garbage but update is a different story how do you propose to deal with out of date info in df db here

[ 0 ]

gyp files made by silly writers e g l

[ 0 ]

ugh i am an idiot this comment makes no sense because i did not see that lines were still part of this function please ignore sorry

[ 0 ]

small nit env dir need not be in brackets

[ 0 ]

these lines should be useless headers are string already so you can drop that

[ 0 ]

suggest to remove the loop just assign motion sensors addr and motion sensors addr individually

[ 0 ]

nit did you git cl format this seems longer than lines

[ 0 ]

gah they both did that

[ 0 ]

i would name this default session json file template so people will remember to give it an arg

[ 0 ]

looks right to me int futex int uaddr int op int val const struct timespec timeout int uaddr int val nr futex ftx op value timeout null bitset uaddr ftx op op val value timeout timeout uaddr null val bitset

[ 0 ]

bald is redefined above, so that's weird

[ 1 ]

i am not crazy about this error being here because this is parse root device hints not eg find device but i guess it can be cleaned up later

[ 0 ]

remove vmax

[ 0 ]

if you are looking for an execution thrown by clientconnectandhandshake it would be more correct to catch an executionexception here

[ 0 ]

is this a mistake in the test ie should we really be doing an assertin using estr to check the string returned from assertraises

[ 0 ]

Damn, thanks for the heads up

[ 1 ]

Hey man are you gay because you keep putting all these silly love hearts in your repositories it makes me think you are gay man...

[ 1 ]

it took me a ridiculously long time to realize you missed a c

[ 0 ]

has exception exc

[ 0 ]

Just a heads up that the coverage report is a bit rubbish as this changes a lot of code w/o changing downstream tests. I have pushed coverage up on #95 to compensate

[ 1 ]

Added a popover menu (see screenshot), it allows you to load a magnet quicker, you just click to open it, then you can type out the whole link if you're a faggot, or you already have it in your clipboard, in that case, you can add a manget just by double-clicking the icon.

[ 1 ]

if you go through with this kill these too

[ 0 ]

potentially stupid question didn t neutron use neutron db manage instead of db sync the same case is with heat i think they use heat manage db sync

[ 0 ]

Also, some of these jokes are pretty offensive (being yo momma jokes), I wonder if it's appropriate to have it on a chat bot... (We wouldn't want a [Tay ](https://en.wikipedia.org/wiki/Tay_(bot))fiasco :) )

[ 1 ]

propertymodel and onattachstatechangelistener are not needed anymore

[ 0 ]

use extra specs

[ 0 ]

No. Modify slurring handling in ethanol/on_mob_life() to suit your idea but don't add some shitty check here.

[ 1 ]

this now throws npe on null not iae

[ 0 ]

The hack is even a step uglier than for `@fluentui/dom-utilties` I needed to add a resolution because there is no major version under v8 that I can use for `@fluentui/utilities`

[ 1 ]

is there any reason you do not fail if this is not true seems like a mangled header would get by this check nit startswith may read cleaner

[ 0 ]

why do not you just use ifneq jack server false here

[ 0 ]

hmm this is pretty ugly i guess you are doing this to save the type and fold passes right

[ 0 ]

i think you did your math wrong i think it is bd value size char bit count i honestly do not know why we did it thus but this is something i did not change

[ 0 ]

should leave this at 50, engiborgs are supposed to have shitloads of wire for the solars

[ 1 ]

i think it should be qosbandwidthlimitrule not qosrule

[ 0 ]

Darn... shame on me for not doing enough research on how this works, thanks for the heads up! \U0001f605

[ 1 ]