showvikdbz/code-reviews · Datasets at Hugging Face

text stringlengths 1 5.2k	labels listlengths 1 1
im fairly sure it's valid gia. what with travis saying it compiled and all it looks weird and confusing though, so fix it! some randomness is fine, especially for a ghetto weapon like this.	[ 1 ]
the hostutils import must be removed	[ 0 ]
missing a title for edge vpn	[ 0 ]
Yes, exactly the kind of disgustingness I had in mind :)	[ 1 ]
i think this is too broad e g if you fat finger any of the code in that block you l be scratching your head think we should limit the exceptions we catch here and include the exception message in what we raise	[ 0 ]
Luxury, that you don't own yet... So I guess this is more common in the early game and then I'd say, hell yes it's more important. In the later game this will rarely happen anyways.	[ 1 ]
Are you trolling? I've :eye: :eye: but cannot spot any difference between `GetStorageProofByHash` and `GetStorageProof`?	[ 1 ]
whole string should be removed	[ 0 ]
Dear god look at all this tech	[ 1 ]
Some invariant violations leaves React in an unstable state at the moment so this is to be expected. AFAIK this is partly because catching and re-throwing errors is a crapshoot in many browsers and may also have significant performance impact on hot code-paths.	[ 1 ]
useless parens around vars here	[ 0 ]
this looks odd you might write it like this instead to clean it up a bit from setuptools command sdist import sdist sdist run self	[ 0 ]
Test failures were just the code 65 nonsense with some misleading compiler warnings sprinkled on top. I've finished work on this, it's ready for review.	[ 1 ]
what in the everloving hell is this, if you ever write this line of code it is a sign you are doing something massively stupid. Add an override var	[ 1 ]
getdefaultrelocationmodel and getforcedpicmodel are replaced by ispicdefault and ispicdefaultforced	[ 0 ]
sorry i am still not clear what different values might it return	[ 0 ]
i would like to see a lot of these mocks moved to tests mock mock file py	[ 0 ]
If hellbound is on the mind, does it need to be updated here?	[ 1 ]
wanna let me have a stab at this	[ 0 ]
nit still a instead of here	[ 0 ]
nitpick but it is actually not hard to make a jump table in python full cmc self full cmc request request type certificate meta not important but if you wanted to get rid of a big if block	[ 0 ]
done	[ 0 ]
this is useless just put return value foo keypair at line	[ 0 ]
style nit ec cb ec unused	[ 0 ]
these deps are not needed since we already install them in testenv above	[ 0 ]
m this is the kind of code that requires a comment so that later maintainers do not have to search the git log to understand exactly what is going on as far as i understand you could completely remove the defined stlp use exceptions here	[ 0 ]
Damn copy/paste :smile: I gave it 10 days.	[ 1 ]
It would require passing user too and looked really fucking ugly when I did it Think of it as a helper proc	[ 1 ]
interesting i wonder if fixing ensure not asan sh would allow us to get stop using this flag for other builds as well	[ 0 ]
@kamieniarz This is a glitch who exist since few days ! I have that too. I used 26 accs with 6K spawns before, and now i struggle to not be behing with 11K spawns and 130 accs.... ridiculous. Something has broke recently i think	[ 1 ]
Killer copy paste dude, totally tubular	[ 1 ]
it looks to me like this is always going to be hit see above	[ 0 ]
test show quotas subproject	[ 0 ]
mock it the same way you mock set service state	[ 0 ]
I am thinking of scrapping this part, then in a future pr I might flesh out the heck suit. I am a very inexperienced coder and I'd rather not take on more than I can chew	[ 1 ]
Currently what self resp is. Although this might fuck with the new crit maybe?	[ 1 ]
drop the die part as newer eapi handles this for you	[ 0 ]
i would prefer to remove these ivars and use settings directly if possible	[ 0 ]
nit one should be removed	[ 0 ]
goof fix your shit this isn't even the right thing	[ 1 ]
That darn find/replace tricked me again. Fixed	[ 1 ]
remove vboilerplate	[ 0 ]
another reason so if some fuck goes into cryo with them on the next detective isn't left out	[ 1 ]
remove content type	[ 0 ]
Isn't this actually a place where we can use a simplistic measure of "Do we lose conversions by removing the banner?"? If that is the case, it might push us harder to look for a better technical implementation e.g. rendering the banner server side, or only taking the person to the link after it's loaded (the later sounds rubbish).	[ 1 ]
yeah I will make all pickup_item procs across all these machines not loop through the turf and instead just suck up the 1 item that entered.	[ 1 ]
these configs should appear in etc ironic ironic conf sample to update that file do something like tools config generate sample sh b p ironic o etc ironic	[ 0 ]
oranges said to add it goddamnit oranges	[ 1 ]
exposing impl class names in this code is really bad practice the network object should contain all the data the vif drivers need if the bridge interface data is wrong we should correct it at the place where it is populated not ignore it in the vif driver	[ 0 ]
fucking why is a proc called "area burn" doing brute damage too ugh I need to come up with a better combat rune	[ 1 ]
err then you need to dump them do not you otherwise the user hit a failure and there is no way to find out what it was	[ 0 ]
god this is the best/worst snake case ever (not your fault, just wanted to point it out)	[ 1 ]
all those variables have horrible names it d be nice to switch to more meaningful ones	[ 0 ]
add deprecated use uicontroller getuicard instead	[ 0 ]
> being a moron about it Where was I a moron? you're the one being a dick, for literally no reason.	[ 1 ]
Damn, I squash it in the wrong patch...	[ 1 ]
why cannot you inject the mocks into the unique ptrs does the test fixture need to maintain ownership of them or something	[ 0 ]
I've addressed the nasty idle event nonsense - it is indeed much nicer if the GraphGadget just does the work. Less code, more reliable. I've disregarded the pedantry though, as the description is for the users...	[ 1 ]
service plugins service plugins	[ 0 ]
a dumb question for you when will the serio raw disconnect be called after kref decreased to zero or	[ 0 ]
sure. my point is that this we need to be C thingie is silly nonsense, it's of absolutely no value. yes, we use C to pass things but 1) C++11 has an abi, i 'm not at all worried about passing C++ symbols any longer 2) we use a C++ compiler 3) they use a C++ compiler 4) everybody uses a C++ compiler 5) vtables are completely transparent to C in any case 6) all interfaces are in files with C++ classes already 7) C++! 8) profit	[ 1 ]
for barbican enable plugin barbican	[ 0 ]
Why this complicated crap? Just `fread` once with the correct size and error out if it fails.	[ 1 ]
argh yeah thanks for spotting this i am an idiot was having a hallucination that this is just the bootstrap pathway but it really isn t so your comment applies for the changes below as well	[ 0 ]
just kill this	[ 0 ]
missing config keyboard boot keys for clarity	[ 0 ]
> @radotzki Have you heard about map data structure before? > Do not disgrace, close the ticket I think you tagged the wrong person \U0001f605	[ 1 ]
i will set magnum guest image url in gate hook sh	[ 0 ]
damn you Twitter API :D	[ 1 ]
so i may still be being dumb but let s say you have created a project with a parent id you then call update project to update the description it should be possible that the body is just i e you should only have to include the fields you are updating description my text however with the code as written that would not work since the code would claim you are changing the parent id if the code however was written like this if parent id in tenant and tenant get parent id parent id raise exception then such an update would work it would also ensure that if some one tried to explicitly set the parent id to none for a project that already had a parent id e g parent id none then this would fail as required	[ 0 ]
Dear before Aunt!	[ 1 ]
use utils startdaemonthread	[ 0 ]
not more than another adjustements	[ 0 ]
since you already modified this line you should remove six text type as well	[ 0 ]
@ZoeBijl This seems like a technicality bug (what we expect is not what happens) and I assume @psydwannabe meant a separate issue should be filed (alt text for images should be limited to some number of characters). That separate issue could also propose a feature (some way of linking semantic text to an image)-- something the bird site for example doesn't have (I've been using Pastebin and it sucks :/).	[ 1 ]
static constexpr const wchar t kmicrosoftimeguids	[ 0 ]
good idea done and added more detail about why thought it might smell like a layering violation	[ 0 ]
nit false is fullscreen	[ 0 ]
please wordwrap these commit messages	[ 0 ]
Nonsense. Did a quick hack look at this - it didn't speed things up at all. It's spending more time saving and storing caches than before - actually slower.	[ 1 ]
i will update it asap it should be removed	[ 0 ]
browser state nullptr	[ 0 ]
silly me ordering is not important here since we are in a firewall defer apply block where the filter defer apply off will call in iptables firewall setup chains apply setup chain etc doing update ipset members and generate ipset rule args later on	[ 0 ]
why are you preserving the noop jobs here they should be removed	[ 0 ]
this might be cleaner without p perhaps something like addr msgs buf block addr edid length buf msgs buf	[ 0 ]
i think this regexp will also match all the strings the next one can possibly match making the latter useless	[ 0 ]
oops missed a those pesky mocks will pass anything	[ 0 ]
this is useless anymore i thought	[ 0 ]
It you find "parts" to be clumsy would "side" be any cleaner?	[ 1 ]
wow you are totally right i will fix this asap	[ 0 ]
maybe say mock ssh channel files	[ 0 ]
Still wacky now and then. Will check and maybe find specifics	[ 1 ]
the leading should be removed	[ 0 ]
@sokra, I have a limit of 4Gb, increasing the memory limit to 8Gb is not really an option, and it's ridiculous that it needs 8Gb	[ 1 ]
oops missed a those pesky mocks will pass anything	[ 0 ]
What the heck? This new syntax is far out	[ 1 ]
it makes more sense to use trans rather than blocktrans	[ 0 ]
i just realized this is going to fail on rhel as ntpd is substituted by chronyd	[ 0 ]
remove useless comment	[ 0 ]
can you test without these special run bindmounts the above run run should pull in the entire run filesystem including run lvm and run lvmmetad pid	[ 0 ]

im fairly sure it's valid gia. what with travis saying it compiled and all it looks weird and confusing though, so fix it! some randomness is fine, especially for a ghetto weapon like this.

[ 1 ]

the hostutils import must be removed

[ 0 ]

missing a title for edge vpn

[ 0 ]

Yes, exactly the kind of disgustingness I had in mind :)

[ 1 ]

i think this is too broad e g if you fat finger any of the code in that block you l be scratching your head think we should limit the exceptions we catch here and include the exception message in what we raise

[ 0 ]

Luxury, that you don't own yet... So I guess this is more common in the early game and then I'd say, hell yes it's more important. In the later game this will rarely happen anyways.

[ 1 ]

Are you trolling? I've :eye: :eye: but cannot spot any difference between `GetStorageProofByHash` and `GetStorageProof`?

[ 1 ]

whole string should be removed

[ 0 ]

Dear god look at all this tech

[ 1 ]

Some invariant violations leaves React in an unstable state at the moment so this is to be expected. AFAIK this is partly because catching and re-throwing errors is a crapshoot in many browsers and may also have significant performance impact on hot code-paths.

[ 1 ]

useless parens around vars here

[ 0 ]

this looks odd you might write it like this instead to clean it up a bit from setuptools command sdist import sdist sdist run self

[ 0 ]

Test failures were just the code 65 nonsense with some misleading compiler warnings sprinkled on top. I've finished work on this, it's ready for review.

[ 1 ]

what in the everloving hell is this, if you ever write this line of code it is a sign you are doing something massively stupid. Add an override var

[ 1 ]

getdefaultrelocationmodel and getforcedpicmodel are replaced by ispicdefault and ispicdefaultforced

[ 0 ]

sorry i am still not clear what different values might it return

[ 0 ]

i would like to see a lot of these mocks moved to tests mock mock file py

[ 0 ]

If hellbound is on the mind, does it need to be updated here?

[ 1 ]

wanna let me have a stab at this

[ 0 ]

nit still a instead of here

[ 0 ]

nitpick but it is actually not hard to make a jump table in python full cmc self full cmc request request type certificate meta not important but if you wanted to get rid of a big if block

[ 0 ]

done

[ 0 ]

this is useless just put return value foo keypair at line

[ 0 ]

style nit ec cb ec unused

[ 0 ]

these deps are not needed since we already install them in testenv above

[ 0 ]

m this is the kind of code that requires a comment so that later maintainers do not have to search the git log to understand exactly what is going on as far as i understand you could completely remove the defined stlp use exceptions here

[ 0 ]

Damn copy/paste :smile: I gave it 10 days.

[ 1 ]

It would require passing user too and looked really fucking ugly when I did it Think of it as a helper proc

[ 1 ]

interesting i wonder if fixing ensure not asan sh would allow us to get stop using this flag for other builds as well

[ 0 ]

@kamieniarz This is a glitch who exist since few days ! I have that too. I used 26 accs with 6K spawns before, and now i struggle to not be behing with 11K spawns and 130 accs.... ridiculous. Something has broke recently i think

[ 1 ]

Killer copy paste dude, totally tubular

[ 1 ]

it looks to me like this is always going to be hit see above

[ 0 ]

test show quotas subproject

[ 0 ]

mock it the same way you mock set service state

[ 0 ]

I am thinking of scrapping this part, then in a future pr I might flesh out the heck suit. I am a very inexperienced coder and I'd rather not take on more than I can chew

[ 1 ]

Currently what self resp is. Although this might fuck with the new crit maybe?

[ 1 ]

drop the die part as newer eapi handles this for you

[ 0 ]

i would prefer to remove these ivars and use settings directly if possible

[ 0 ]

nit one should be removed

[ 0 ]

goof fix your shit this isn't even the right thing

[ 1 ]

That darn find/replace tricked me again. Fixed

[ 1 ]

remove vboilerplate

[ 0 ]

another reason so if some fuck goes into cryo with them on the next detective isn't left out

[ 1 ]

remove content type

[ 0 ]

Isn't this actually a place where we can use a simplistic measure of "Do we lose conversions by removing the banner?"? If that is the case, it might push us harder to look for a better technical implementation e.g. rendering the banner server side, or only taking the person to the link after it's loaded (the later sounds rubbish).

[ 1 ]

yeah I will make all pickup_item procs across all these machines not loop through the turf and instead just suck up the 1 item that entered.

[ 1 ]

these configs should appear in etc ironic ironic conf sample to update that file do something like tools config generate sample sh b p ironic o etc ironic

[ 0 ]

oranges said to add it goddamnit oranges

[ 1 ]

exposing impl class names in this code is really bad practice the network object should contain all the data the vif drivers need if the bridge interface data is wrong we should correct it at the place where it is populated not ignore it in the vif driver

[ 0 ]

fucking why is a proc called "area burn" doing brute damage too ugh I need to come up with a better combat rune

[ 1 ]

err then you need to dump them do not you otherwise the user hit a failure and there is no way to find out what it was

[ 0 ]

god this is the best/worst snake case ever (not your fault, just wanted to point it out)

[ 1 ]

all those variables have horrible names it d be nice to switch to more meaningful ones

[ 0 ]

add deprecated use uicontroller getuicard instead

[ 0 ]

> being a moron about it Where was I a moron? you're the one being a dick, for literally no reason.

[ 1 ]

Damn, I squash it in the wrong patch...

[ 1 ]

why cannot you inject the mocks into the unique ptrs does the test fixture need to maintain ownership of them or something

[ 0 ]

I've addressed the nasty idle event nonsense - it is indeed much nicer if the GraphGadget just does the work. Less code, more reliable. I've disregarded the pedantry though, as the description is for the users...

[ 1 ]

service plugins service plugins

[ 0 ]

a dumb question for you when will the serio raw disconnect be called after kref decreased to zero or

[ 0 ]

sure. my point is that this we need to be C thingie is silly nonsense, it's of absolutely no value. yes, we use C to pass things but 1) C++11 has an abi, i 'm not at all worried about passing C++ symbols any longer 2) we use a C++ compiler 3) they use a C++ compiler 4) everybody uses a C++ compiler 5) vtables are completely transparent to C in any case 6) all interfaces are in files with C++ classes already 7) C++! 8) profit

[ 1 ]

for barbican enable plugin barbican

[ 0 ]

Why this complicated crap? Just `fread` once with the correct size and error out if it fails.

[ 1 ]

argh yeah thanks for spotting this i am an idiot was having a hallucination that this is just the bootstrap pathway but it really isn t so your comment applies for the changes below as well

[ 0 ]

just kill this

[ 0 ]

missing config keyboard boot keys for clarity

[ 0 ]

> @radotzki Have you heard about **map** data structure before? > Do not disgrace, close the ticket I think you tagged the wrong person \U0001f605

[ 1 ]

i will set magnum guest image url in gate hook sh

[ 0 ]

damn you Twitter API :D

[ 1 ]

so i may still be being dumb but let s say you have created a project with a parent id you then call update project to update the description it should be possible that the body is just i e you should only have to include the fields you are updating description my text however with the code as written that would not work since the code would claim you are changing the parent id if the code however was written like this if parent id in tenant and tenant get parent id parent id raise exception then such an update would work it would also ensure that if some one tried to explicitly set the parent id to none for a project that already had a parent id e g parent id none then this would fail as required

[ 0 ]

Dear before Aunt!

[ 1 ]

use utils startdaemonthread

[ 0 ]

not more than another adjustements

[ 0 ]

since you already modified this line you should remove six text type as well

[ 0 ]

@ZoeBijl This seems like a technicality bug (what we expect is not what happens) and I assume @psydwannabe meant a separate issue should be filed (alt text for images should be limited to some number of characters). That separate issue could also propose a feature (some way of linking semantic text to an image)-- something the bird site for example doesn't have (I've been using Pastebin and it sucks :/).

[ 1 ]

static constexpr const wchar t kmicrosoftimeguids

[ 0 ]

good idea done and added more detail about why thought it might smell like a layering violation

[ 0 ]

nit false is fullscreen

[ 0 ]

please wordwrap these commit messages

[ 0 ]

Nonsense. Did a quick hack look at this - it didn't speed things up at all. It's spending more time saving and storing caches than before - actually slower.

[ 1 ]

i will update it asap it should be removed

[ 0 ]

browser state nullptr

[ 0 ]

silly me ordering is not important here since we are in a firewall defer apply block where the filter defer apply off will call in iptables firewall setup chains apply setup chain etc doing update ipset members and generate ipset rule args later on

[ 0 ]

why are you preserving the noop jobs here they should be removed

[ 0 ]

this might be cleaner without p perhaps something like addr msgs buf block addr edid length buf msgs buf

[ 0 ]

i think this regexp will also match all the strings the next one can possibly match making the latter useless

[ 0 ]

oops missed a those pesky mocks will pass anything

[ 0 ]

this is useless anymore i thought

[ 0 ]

It you find "parts" to be clumsy would "side" be any cleaner?

[ 1 ]

wow you are totally right i will fix this asap

[ 0 ]

maybe say mock ssh channel files

[ 0 ]

Still wacky now and then. Will check and maybe find specifics

[ 1 ]

the leading should be removed

[ 0 ]

@sokra, I have a limit of 4Gb, increasing the memory limit to 8Gb is not really an option, and it's ridiculous that it needs 8Gb

[ 1 ]

oops missed a those pesky mocks will pass anything

[ 0 ]

What the heck? This new syntax is far out

[ 1 ]

it makes more sense to use trans rather than blocktrans

[ 0 ]

i just realized this is going to fail on rhel as ntpd is substituted by chronyd

[ 0 ]

remove useless comment

[ 0 ]

can you test without these special run bindmounts the above run run should pull in the entire run filesystem including run lvm and run lvmmetad pid

[ 0 ]