id stringlengths 22 25 | commit_message stringlengths 137 6.96k | diffs listlengths 0 63 |
|---|---|---|
derby-DERBY-4224-8b8fe9f9 | DERBY-4312 SQLException XJ215 on insert with setCharacterStream() and autocommit off in mailjdbc test
DERBY-4224 Commit after setAsciiStream() makes execution fail with the client driver
Use of a stream after performing commit was incorrectly causing an exception. Also fixes setBinaryStream();
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@796020 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-4228-08b83a83 | DERBY-4228: Remove unused pre-i18n constructors in BatchUpdateException
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@774471 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/client/org/apache/derby/client/am/BatchUpdateException.java",
"hunks": [
{
"added": [],
"header": "@@ -21,7 +21,6 @@",
"removed": [
"import org.apache.derby.iapi.services.info.JVMInfo;"
]
},
{
"added": [],
"header": ... |
derby-DERBY-4230-53cbb534 | DERBY-4230 DatabaseMetaData.getColumns() returns extra column from view with group by and expression in SELECT list
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@777500 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/sql/compile/CreateViewNode.java",
"hunks": [
{
"added": [
"\t\t// System columns should only include visible columns DERBY-4230",
"\t\tcolInfos = new ColumnInfo[queryExpression.getResultColumns().visibleSize()];"
],
... |
derby-DERBY-4232-52acd5a8 | DERBY-4232: XAResource.setTransactionTimeout() makes XAResource.start() fail with the client driver
Only send the timeout property when start() is called with TMNOFLAGS,
as specified in DRDAv4 (volume 3, SYNCCTL, page 872).
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@788674 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-4239-731568d3 | DERBY-4239
In the case of inplace compress it is necessary to get a valid checkpoint
into the log file after any other log record for the table being compressed.
This insures that if redo recovery is run, it will not be applied to any
log record before the compress. This is necessary as compress will basically
destroy a page and redo recovery will get various errors if it tries to
apply a redo page operation at page version N against a new page.
Before this fix the requested checkpoint would not be executed if a checkpoint
was already in progress. The problem is that there is no way to tell if
the executing checkpoint is after all operations on the table. So the fix
in this case waits for the checkpoint to finish and starts a new one.
The changes also apply this new behavior to all calls to checkpoint which
previously had marked that the routine should wait until the checkpoint
finished. This will affect backup and checkpoints initiated by a user
calling the system procedure.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@780352 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/store/raw/RawStore.java",
"hunks": [
{
"added": [
" // checkpoint with \"wait\" = false. If set to true shutdown",
" // might loop forever if we are shutting down on a serious ",
" ... |
derby-DERBY-424-6d9c32af | DERBY-424: Basically, the problem is that, during the compile phase of views,
the reference to the view gets replaced by the view definition, which causes
us to loose the information that the view might have belonged in SESSION schema.
In order to fix this, during the bind phase in FromList, before the view gets
replaced by its definition, I find out if the view is from SESSION schema, If
yes, then I save this information in FromList and this gets used by FromList
when it is asked if it has any items referencing SESSION schema objects. This
information is again lost during the optimization and generate phase and hence
I moved the check for SESSION schema reference to right after the bind phase in
GenericStatement. If there is a reference to SESSION schema object,
GenericStatement will remove the statement from the cache.
Submitted by Mamta Satoor (msatoor@gmail.com)
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@326959 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/sql/GenericPreparedStatement.java",
"hunks": [
{
"added": [
"\t * Return true if the query node for this statement references SESSION schema",
"\t * tables/views.",
"\t * This method gets called at the very beginning of... |
derby-DERBY-4241-bde5241e | DERBY-4241: Improve transition from read-only to writable Clob representation
When a store stream Clob is going to be modified, it will be written out to the temporary area of Derby and represented as a TemporaryClob.
The transfer of the data is done in a sub-optimal manner for two reasons;
o for transfer of the complete Clob, the copy method operates on the byte level and we're not able to save the character length.
o for transfer of parts of the Clob (i.e. truncation), we have to first decode the UTF-8 encoding to find the byte count and then transfer the same bytes.
This fix addresses both issues by improving the length caching and by adding
a method that counts the charactes "on-the-fly" while copying raw bytes.
Patch file: derby-4241-2b-utf8AwareCopy.diff
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@958522 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/jdbc/LOBStreamControl.java",
"hunks": [
{
"added": [
"import java.io.UTFDataFormatException;",
"import org.apache.derby.iapi.services.i18n.MessageService;",
"import org.apache.derby.shared.common.reference.MessageId;"
... |
derby-DERBY-4241-dac5aed9 | DERBY-4241: Improve transition from read-only to writable Clob representation.
Added the new method InternalClob.getCharLengthIfKnown, which allows for
determining if the length of the Clob is known or not at the time of the method
invocation. If the length is unknown, it will not be calculated as this may be
an expensive operation.
This method was added to allow for performance optimizations, where the optimal
action depends on whether the character length is known or not.
Patch file: derby-4241-1a-InternalClob.getLengthIfKnown.diff
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@782600 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/jdbc/TemporaryClob.java",
"hunks": [
{
"added": [
" /**",
" * Returns the cached character count for the Clob, if any.",
" *",
" * @return The number of characters in the Clob, or {@code -1} if ... |
derby-DERBY-4244-9bfc704b | DERBY-4244: ALTER TABLE ASSERT in ADD COLUMN with autocommit off
This patch was contributed by Eranda Sooriyabandara (070468D at gmail dot com)
An ALTER TABLE ... ADD COLUMN statement which specifies to add a column to
a table may also include any column constraints which apply to that column.
For example, to add a column to a table and at the same time indicate that
the column should be the primary key of the table, this statement is used:
alter table t0 add column c2 int not null default 0 primary key;
If the table already contains a primary key, this statement fails, as the
table cannot have more than one primary key. However, the check for the
duplicate primary key was occurring at execution time, *after* the column
had already been added to the table. Then, during that same transaction,
subsequent ALTER TABLE statements affecting that table failed with internal
ASSERT messages because the data dictionary data structures were inconsistent.
This patch adds logic to the compilation processing of the ALTER TABLE
statement to check for a duplicate PRIMARY KEY constraint at compile
time, before the ALTER TABLE statement has begun execution. This way, when
such a duplicate constraint is rejected, the rejection occurs prior to
execution of the table, allowing for more straightforward cleanup.
The patch also re-enables a portion of the AlterTableTest, which had been
disabled due to this problem.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@795459 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/sql/compile/AlterTableNode.java",
"hunks": [
{
"added": [
"import org.apache.derby.iapi.sql.dictionary.ConstraintDescriptorList;"
],
"header": "@@ -32,6 +32,7 @@ import org.apache.derby.iapi.error.StandardException;",
... |
derby-DERBY-4245-0f92bc7c | DERBY-4245 (partial): Sorting a table containing a CLOB fails after upgrade to 10.5.
Fixes the NPE bug for both clean 10.5 databases and upgraded databases. Note
that there is a remaining bug for upgraded databases that will be fixed with a
subsequent patch under this issue.
Patch file: derby-4245-2a-sqlclob_fix.diff
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@784701 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/iapi/types/SQLClob.java",
"hunks": [
{
"added": [
" rewindStream(stream, csd.getDataOffset());",
" rewindStream(stream, 0);"
],
"header": "@@ -236,11 +236,11 @@ public class SQLClob",
... |
derby-DERBY-4245-250dbe6e | DERBY-4245: Sorting a table containing a CLOB fails after upgrade to 10.5.
Lowered the sort buffer to the minimum (through derby.storage.sortBufferMax),
and the number of rows inserted in the test.
Patch file: derby-4245-4a-adjust_sort_buffer_test.diff
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@790162 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-4245-ea2ac9f9 | DERBY-4245: Sorting a table containing a CLOB fails after upgrade to 10.5.
A regression test using LOBs in a sort. The sort should be external, but if the
test is run with a large enough JVM heap it won't be. There are two options to
fix that: reduce the heap size or increase the number of rows in the test table.
Patch file: derby-4245-1c-test.diff
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@785104 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-4246-dfbf41ee | DERBY-4246 .replicationTests.ReplicationRun_Local_3_p5).testReplication_Local_3_p5_DERBY_3878()' fails w/ "Could not perform operation 'stopSlave' because the database '...' has not been booted
Patch derby-4246-2 adds extra logic to the stop slave action after the
master is killed. This logic anticipates the slave's state changes
before its down. This logic was also present in
ReplicationRun_Local_StateTest_part1_1, so this patch factors this out
into a new method to stopSlave in ReplicationRun.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@785131 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-4249-3b4b552c | DERBY-4249 Create a simple store recovery test in JUnit
On failure print launched process error stream as well as ouput.
patch derby4249_showlaunchederr_diff.txt
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1159337 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-4249-8f56d99d | DERBY-4249 Create a simple store recovery test in JUnit
Contributed by Siddharth Srivastava
Simple test to verify recovery.
- Connect, create a table, commit and shutdown the database.
- fork a jvm, add one row, commit, add another row, exit the jvm.
- Reconnect with the first jvm and verify that the first row is there and the second is not.
Launches a junit method for forked jvm and reports any errors back.
Currently disabled for weme due to DERBY-4647.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1158949 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-4256-fecd96aa | DERBY-4256: Allow ALTER TABLE to increase the max size of BLOB or CLOB
This patch was contributed by Eranda Sooriyabandara (070468D at gmail dot com)
This patch enhances the Derby ALTER TABLE command so that it allows the
maximum length limit of a BLOB or CLOB column to be increased. The patch also
adds some new regression tests verifying the new functionality, and adjusts
the text of the ALTER TABLE error message to make it more clear that it is
legal to increase the length of a VARCHAR, BLOB, or CLOB column.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@802985 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-4260-a3e94cbe | DERBY-4260: Make derbynet/NetworkServerControlClientCommandTest run regardless of the locale
This patch was contributed by Houx Zhang (houxzhang @ gmail dot com).
This patch modifies the NetworkServerControlClientCommandTest to pass
-Dderby.ui.locale=en_US
when running the sub-commands of the test, to ensure that the test assertions,
which look for specific English language strings, find the expected values.
That way, the test will pass, even if run in a shell environment where the
locale is set to a non-English value.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1095247 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-4263-cf61371e | DERBY-4263: PropertySetter isn't able to recognize JDK without version number in path.
Added a new algorithm for detecting JDKs on the system. The root search
locations are the same as before, but instead of relying on version numbers in
the JDK directory, jar files and the sub directory structure of the directories
are examined. The new algorithm will try to select JDKs from the same vendor as
the running JVM if possible.
If the new algorithm fails for some reason, the old one will be used.
If both the new and the old algorithm fail, a last attempt will be made by
configuring the build with the running JVM only.
If the more "exotic" approaches are used, a warning message will be printed
to default out. As before, more information can be extracted by setting
printCompilerProperties=true when invoking ant.
Patch file: derby-4263-1b-jdk_detection_by_jars.diff
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@801924 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/build/org/apache/derbyPreBuild/PropertySetter.java",
"hunks": [
{
"added": [
"import java.io.FilenameFilter;",
"import java.io.IOException;",
"import java.util.Collections;",
"import java.util.jar.JarFile;",
"import java.util.ja... |
derby-DERBY-4269-1966619e | DERBY-5830: Make DoubleProperties.propertyNames() thread-safe
Don't store the property values in the intermediate Hashtable as they
are not needed. They may be null if the Properties instances are
modified after the recursive calls to Properties.propertyNames(), and
trying to store a null value in a Hashtable results in a
NullPointerException, causing issues such as DERBY-4269.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1353852 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/iapi/util/DoubleProperties.java",
"hunks": [
{
"added": [
"import java.util.Collections;",
"import java.util.HashSet;",
"import java.util.Properties;"
],
"header": "@@ -21,8 +21,10 @@",
"removed": [
... |
derby-DERBY-4269-2cd035c1 | DERBY-4269 Failover did not succeed in 2 min.: testReplication_Local_3_p6_autocommit_OK
Patch fix-ignored-runtime-exceptions-b
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1356766 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/db/SlaveDatabase.java",
"hunks": [
{
"added": [
"import org.apache.derby.iapi.reference.MessageId;",
"import org.apache.derby.impl.store.replication.ReplicationLogger;"
],
"header": "@@ -37,6 +37,8 @@ import org.a... |
derby-DERBY-4270-ccf708c8 | DERBY-4270 Make replication tests save derby.log and database when a failure occurs
Patch derby-4270-2 adds an overload of TestCase.runBare to
ReplicationRun which does this desired copying on the same pattern as
done for "normal" tests in BaseTestCase.runBare.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@785139 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-4273-66edb713 | DERBY-4273: A lock could not be obtained within the time requested error in testBTreeForwardScan_fetchRows_resumeAfterWait_nonUnique_split
Use DatabasePropertyTestSetup to set timeout in ResultSetMiscTest and
SetTransactionIsolationTest, so that the values are reset before
IndexSplitDeadlockTest starts.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@788968 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-4274-beaa0a43 | DERBY-4274: SYSCS_UPDATE_STATISTICS takes unnecessary table lock
Return just after the statistics have been updated to prevent the
generic ALTER TABLE code from locking the table exclusively.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@785570 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-4275-5a56eb0a | DERBY-4275: Query executions fail when compressing a table using SYSCS_UTIL.SYSCS_COMPRESS_TABLE
Move invalidation of dependent statements until the system tables have
been updated with information about the new conglomerates created by
compression or truncation. This is to prevent that statements
executing concurrently get recompiled too early and don't see the new
conglomerates (and therefore fail on subsequent executions because
they cannot find the old conglomerates).
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1142583 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/sql/execute/AlterTableConstantAction.java",
"hunks": [
{
"added": [
"\t\t/* Prepare all dependents to invalidate. (This is their chance"
],
"header": "@@ -388,7 +388,7 @@ class AlterTableConstantAction extends DDLSingleTab... |
derby-DERBY-4276-45f64ada | DERBY-4276 Update demo's to remove references to com.ibm.db2.jcc.DB2Driver
Contributed by Lily Wei (lilywei at yahoo dot com)
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@788105 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/demo/nserverdemo/NsSample.java",
"hunks": [
{
"added": [
" 2.\tloads the derby client JDBC driver"
],
"header": "@@ -41,8 +41,7 @@ import java.io.PrintWriter;",
"removed": [
" 2.\tloads the IBM DB2 JDBC Universal driver or derby clien... |
derby-DERBY-4277-f910400c | DERBY-4277: Replacing simple connect() with waitForConnect().
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@789601 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-4278-8f75194d | DERBY-4278: Batch inserts with Clobs fails with the embedded driver.
Explicitly set whether the Clob is written to a soft upgraded database or not,
as there isn't enough context at write time (run-time) to decide it then.
Patch file: derby-4278-1a-regression_test.diff, derby-4278-2a-fix.diff
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@790135 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/iapi/types/SQLClob.java",
"hunks": [
{
"added": [
" SQLClob clone = new SQLClob(getString());",
" // Copy the soft upgrade mode state.",
" clone.inSoftUpgradeMode = inSoftUpgradeMode;",
... |
derby-DERBY-4279-7fc54b9c | DERBY-4279: Statement cache deadlock
When requesting a recompile of a statement, don't wait for other
threads compiling the same statement, but instead create a new
instance of the statement.
Patch contributed by Brett Wooldridge <brett.wooldridge@gmail.com>.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@956504 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/sql/GenericPreparedStatement.java",
"hunks": [
{
"added": [
"\tpublic PreparedStatement rePrepare(LanguageConnectionContext lcc)",
"\t\t\treturn ps;",
"",
"\t\treturn this;"
],
"header": "@@ -2... |
derby-DERBY-4279-85132a2e | DERBY-4279: Statement cache deadlock
Backing out revision 956504 while investigating problems that appeared
after the change.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@958529 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/sql/GenericPreparedStatement.java",
"hunks": [
{
"added": [
"\tpublic void rePrepare(LanguageConnectionContext lcc) ",
"\t\t\tif (SanityManager.DEBUG)",
"\t\t\t\tSanityManager.ASSERT(ps == this, \"ps != this\");",
... |
derby-DERBY-4279-f52a901a | DERBY-4279: Statement cache deadlock
Modified ResultColumnList.generateHolderMethod to only take a lock when
obtaining row template(s) if the data dictionary is in DDL_MODE. The lock that
used to be obtained was a CIS lock/latch.
The purpose of this change is to avoid the deadlocks that have been observed in
some scenarios when statements are being compiled or recompiled.
Patch contributed by Brett Wooldridge (brett dot wooldridge at gmail dot com).
Patch file: patch4279_2.txt
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1365661 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/sql/compile/ResultColumnList.java",
"hunks": [
{
"added": [
"\t\t\t\tLanguageConnectionContext lcc = getLanguageConnectionContext();",
"\t\t\t\tDataDictionary dd = lcc.getDataDictionary();",
"\t\t\t\t",
"\t\t\... |
derby-DERBY-428-10e77784 | DERBY-428: PreparedStatement.executeBatch hangs if batch is too large
This patch contains a server-side change, a client-side change, and a test.
The server-side change is to call ensureLength() in DDMWriter.startDDM().
The DDMWriter working buffer is designed to dynamically grow to accomodate
the data being written; this dynamic growth is implemented using a coding
rule which requires that all DDMWriter internal routines must call
ensureLength to communicate the buffer size requirements prior to writing
bytes into the buffer. StartDDM was missing the call to ensureLength.
The client-side change is due to the fact that DRDA imposes a hard limit
of 65535 elements in a single correlated request because the correlation
identifier is a two byte unsigned integer. Prior to this change, the
correlation identifiers would wrap around when we added the 65536th
element into the batch, which breaks the DRDA protocol rule that requires
correlation IDs in a single request be always increasing. This change
causes the client to throw an exception if it is asked to execute a batch
containing more than 65534 elements. The reason for the number 65534,
rather than 65535, is that the value 0xFFFF is reserved for special use.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@387895 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-428-505bb8a1 | DERBY-1533: ArrayIndexOutOfBoundsException in DDMReader
DERBY-1533 follows in a series of bugs (DERBY-170, DERBY-428, DERBY-491,
DERBY-492, DERBY-614 among others) which have to do with the particulars of
the DRDA protocols used for handling long messages and large amounts of data.
In this particular issue, the problems involve the situation in which the
server is receiving a message which is segmented across multiple layer A
blocks using DSS continuations. This is a relatively unusual case, as
generally large amounts of data flow from the server to the client, not vice
versa.
This change contains two modifications to DDMReader, as well as some tests:
1) The Network Server method DDMReader.compressBLayerData was incorrect in
several respects. Rather than going through that code in detail, I noticed
that an almost identical version of this routine exists in the DerbyNetClient,
in the class Reply, and I am pretty confident that the client side code is
working, so I just wholesale modified the server's compressBLayerData method
so that it matched the client's method.
2) When the client is sending parameter data to the server, and the data to be
sent is a large array of bytes for a blob, the client, the client may send the
data inline as DRDA_TYPE_NVARBYTE, or it may externalize the data and send it
as DRDA_TYPE_NLOBBYTES. I believe that similar things happen with CLOB.
The client makes this decision based on the length of the data to be sent;
short values are sent inline, and long values are sent externalized.
When the server receives the data, it must decide whether it is reading an
inline string of bytes, or externalized data, and it, too, makes this decision
based on the length of the data. However, the server's code for this was
comparing the length of the byte string against the amount of data left in the
current segment, as opposed to comparing it against the constant threshold
value for switching from inline bytes to externalized bytes; hence if a long
byte string happened to start late in a buffer, and was then segmented
(continued) into a subsequent buffer, the server would mistakenly think the
byte string was being sent as externalized bytes, when in fact it was sent as
inline bytes.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@430077 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/drda/org/apache/derby/impl/drda/DDMReader.java",
"hunks": [
{
"added": [
"\t\tif (length < DssConstants.MAX_DSS_LENGTH)"
],
"header": "@@ -1321,7 +1321,7 @@ class DDMReader",
"removed": [
"\t\tif (length < dssLength)"
]
... |
derby-DERBY-4282-37f88617 | DERBY-4282: Strange behavior with "where current of" in CheckConstraintTest
This patch was contributed by Eranda Sooriyabandara (070468D at gmail dot com)
This patch addresses an issue involving the binding of check constraints
in queries which use the "where current of" construction to refer to the
current row of an open cursor. The update statement was failing with a
"column not found" error, complaining about the column referred to by the
check constraint.
The problem arises in the processing of ResultColumnList.expandToAll, which
is used to construct ResultColumn instances for the columns in the table;
these result column instances are then used when the check constraint
is bound. ResultColumnList.java was constructing the ResultColumn instances
as unnamed, which caused an internal name "SQLCOL1" to be generated, which
later then caused the check constraint binding to fail.
The solution is simply to ensure that the ResultColumn references that are
built by expandToAll are named according to the column names.
The patch also adds several new test cases.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@803336 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-4287-03e89c8c | DERBY-4287 call to System.getProperty in BCClass.java is not wrapped in a priv block so may fail when running under SecurityManager
Also wraps call to FileOutputStream
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@788436 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/services/bytecode/BCClass.java",
"hunks": [
{
"added": [
"import java.security.AccessController;"
],
"header": "@@ -40,6 +40,7 @@ import org.apache.derby.iapi.util.ByteArray;",
"removed": []
}
]
},
{
... |
derby-DERBY-4292-07e72c36 | DERBY-4292 creation of FileInputStream in org.apache.derby.impl.tools.ij.Main not wrapped in privilege block which can cause problems running under SecurityManager
Contributed by Tiago R. Espinha (tiago at espinhas dot net)
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@794112 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/tools/org/apache/derby/impl/tools/ij/Main.java",
"hunks": [
{
"added": [
"import java.security.PrivilegedActionException;",
"import java.security.PrivilegedExceptionAction;"
],
"header": "@@ -39,6 +39,8 @@ import java.io.IOException;",
... |
derby-DERBY-4293-23ecfcf9 | DERBY-4293: Mutable public static variables
Made more static variables final and/or private, and created accessor
method to prevent direct access to public static array.
Patch contributed by Sebb <sebb@apache.org>.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@789684 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/client/org/apache/derby/client/am/Configuration.java",
"hunks": [
{
"added": [
" public static final String jreLevel;// = \"1.3.0\"; // default level if unable to read",
" public static final int jreLevelMajor;// = 1;",
" public static fin... |
derby-DERBY-4297-93f457a6 | DERBY-4297: Removed method that was no longer used after the main fix
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@890448 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/sql/GenericStatement.java",
"hunks": [
{
"added": [],
"header": "@@ -615,18 +615,6 @@ public class GenericStatement",
"removed": [
"\tprivate static long getElapsedTimeMillis(long beginTime)",
"\t{",
"\t... |
derby-DERBY-4304-2f0f84fc | DERBY-4304
During server shutdown substeps, catch any exception thrown, print it to console along with stack trace and then move on to the next substep rather than re-throwing the exception after console printing.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@798742 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/drda/org/apache/derby/impl/drda/NetworkServerControlImpl.java",
"hunks": [
{
"added": [
" \tconsolePrintAndIgnore(\"DRDA_UnexpectedException.S\", exception, true);"
],
"header": "@@ -819,8 +819,7 @@ public final class NetworkServerControlImpl {"... |
derby-DERBY-4304-6a9299ae | DERBY-4304
When running in insane mode, the stack trace of the exception was not getting printed in the console log file logs/serverConsoleOutput.log The reason for this is that the code was
doing following
consolePropertyMessage("DRDA_UnexpectedException.S",
exception.getMessage());
consoleExceptionPrintTrace(exception);
That is, the stack trace printing was happening after the call to consolePropertyMessage. The call to consolePropertyMessage results into a call to consolePropertyMessageWork which may throw an exception back depending on the type of the error it is handling. If this method does throw an exception, then consoleExceptionPrintTrace does not get a chance to dump the stack trace into the logs/serverConsoleOutput. (Probably in sane mode, there is some other additional place where we do the stack trace printing and that is why we saw the stack trace despite consolePropertyMessage throwing an exception.) To fix the problem, I have switched the order of the 2 calls above and that makes sure that we do print the stack trace for debugging purpose.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@796316 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/drda/org/apache/derby/impl/drda/NetworkServerControlImpl.java",
"hunks": [
{
"added": [
" consoleExceptionPrintTrace(exception);"
],
"header": "@@ -819,9 +819,9 @@ public final class NetworkServerControlImpl {",
"removed": [
... |
derby-DERBY-4304-75134de4 | Backing out change 796316 for DERBY-4304 until I can figure out the cause of NPE in DerbyNetAutoStart
Starting test case 1.
java.lang.NullPointerException
at org.apache.derby.impl.services.jmx.JMXManagementService.unregisterMBean(JMXManagementService.java:286)
at org.apache.derby.impl.services.jmx.JMXManagementService.unregisterMBean(JMXManagementService.java:277)
at org.apache.derby.impl.drda.NetworkServerControlImpl.blockingStart(NetworkServerControlImpl.java:892)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:37)
at java.lang.reflect.Method.invoke(Method.java:599)
at org.apache.derby.iapi.jdbc.DRDAServerStarter.run(DRDAServerStarter.java:236)
at java.lang.Thread.run(Thread.java:735)
Starting test case 2.
java.lang.NullPointerException
at org.apache.derby.impl.services.jmx.JMXManagementService.unregisterMBean(JMXManagementService.java:286)
at org.apache.derby.impl.services.jmx.JMXManagementService.unregisterMBean(JMXManagementService.java:277)
at org.apache.derby.impl.drda.NetworkServerControlImpl.blockingStart(NetworkServerControlImpl.java:892)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:37)
at java.lang.reflect.Method.invoke(Method.java:599)
at org.apache.derby.iapi.jdbc.DRDAServerStarter.run(DRDAServerStarter.java:236)
at java.lang.Thread.run(Thread.java:735)
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@796372 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/drda/org/apache/derby/impl/drda/NetworkServerControlImpl.java",
"hunks": [
{
"added": [
" consoleExceptionPrintTrace(exception);"
],
"header": "@@ -819,9 +819,9 @@ public final class NetworkServerControlImpl {",
"removed": [
... |
derby-DERBY-4304-892eebf1 | DERBY-4304
During one of the server shutdown steps, DERBY-4306 was throwing a npe(we have fixed DERBY-4306 now) and the shutdown exception handling code was calling following method on that npe
consolePropertyMessage("DRDA_UnexpectedException.S", exception.getMessage());
consoleExceptionPrintTrace(exception);
but the call exception.getMessage() on npe was returning null and consolePropertyMessage is not written to handle null 2nd param for this call of consolePropertyMessage. But the work done by this particular type of consolePropertyMessage method is also done by the next call in the shutdown exception handling which is consoleExceptionPrintTrace. Because of this, I have replaced the consolePropertyMessage("DRDA_UnexpectedException.S", exception.getMessage()); call with consolePropertyMessage("DRDA_UnexpectedException.S", true); This change makes sure we do not run into npe when exception.getMessage() is null. I am not sure if we should enter a new jira entry to make consolePropertyMessage("DRDA_UnexpectedException.S", exception.getMessage()); handle a null 2nd param.
junit tests with this change ran into intermittent upgrade test failures.
One last step remaining is may be write a new method which is a subset of consolePropertyMessage because consolePropertyMessage handles the exception printing and then goes ahead and throws the exception again. For our purposes in this jira entry, we do not want the exception to be thrown back. instead, we want to move on to the next step in server shutdown.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@798347 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/drda/org/apache/derby/impl/drda/NetworkServerControlImpl.java",
"hunks": [
{
"added": [
" consolePropertyMessage(\"DRDA_UnexpectedException.S\", true);"
],
"header": "@@ -819,8 +819,7 @@ public final class NetworkServerControlImpl {",
... |
derby-DERBY-4304-d49d499c | DERBY-4304
Committing changes which puts a new try catch block around all of the server shutdown code in case if there is some exception being thrown which is not getting caught. The catch block will log into the log file but if that fails for some reason, it will also just dump the stack trace using ex.printStackTrace().
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@803548 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/drda/org/apache/derby/impl/drda/NetworkServerControlImpl.java",
"hunks": [
{
"added": [
"\t\ttry {",
"\t\t\t// wait until we are told to shutdown or someone sends an InterruptedException",
"\t synchronized(shutdownSync) {",
"\t ... |
derby-DERBY-4304-e01e5d79 | DERBY-4304
I have made changes to NetworkServerControlImpl.java so we handle the exceptions during different steps of server shutdown and continue with the next step in shutdown rather than bailing out after the first exception.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@794303 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/drda/org/apache/derby/impl/drda/NetworkServerControlImpl.java",
"hunks": [
{
"added": [
" try {",
" AccessController.doPrivileged(",
" new PrivilegedAction() {",
" public Object ... |
derby-DERBY-4305-c9868628 | DERBY-4305 - Make changes to test harness class j9_foundation 11 to support newer version of IBM's JSR169 implementation
committing the change to move to weme 6.2
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@795095 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/testing/org/apache/derbyTesting/functionTests/harness/j9_foundation11.java",
"hunks": [
{
"added": [
" <p>This class is for IBM's J9 jdk 1.3., foundation class library; v 2.4 (weme6.2)"
],
"header": "@@ -25,7 +25,7 @@ import java.util.StringTokenizer;... |
derby-DERBY-4306-892eebf1 | DERBY-4304
During one of the server shutdown steps, DERBY-4306 was throwing a npe(we have fixed DERBY-4306 now) and the shutdown exception handling code was calling following method on that npe
consolePropertyMessage("DRDA_UnexpectedException.S", exception.getMessage());
consoleExceptionPrintTrace(exception);
but the call exception.getMessage() on npe was returning null and consolePropertyMessage is not written to handle null 2nd param for this call of consolePropertyMessage. But the work done by this particular type of consolePropertyMessage method is also done by the next call in the shutdown exception handling which is consoleExceptionPrintTrace. Because of this, I have replaced the consolePropertyMessage("DRDA_UnexpectedException.S", exception.getMessage()); call with consolePropertyMessage("DRDA_UnexpectedException.S", true); This change makes sure we do not run into npe when exception.getMessage() is null. I am not sure if we should enter a new jira entry to make consolePropertyMessage("DRDA_UnexpectedException.S", exception.getMessage()); handle a null 2nd param.
junit tests with this change ran into intermittent upgrade test failures.
One last step remaining is may be write a new method which is a subset of consolePropertyMessage because consolePropertyMessage handles the exception printing and then goes ahead and throws the exception again. For our purposes in this jira entry, we do not want the exception to be thrown back. instead, we want to move on to the next step in server shutdown.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@798347 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/drda/org/apache/derby/impl/drda/NetworkServerControlImpl.java",
"hunks": [
{
"added": [
" consolePropertyMessage(\"DRDA_UnexpectedException.S\", true);"
],
"header": "@@ -819,8 +819,7 @@ public final class NetworkServerControlImpl {",
... |
derby-DERBY-4310-5b78c4e3 | DERBY-4310 jdbcapi.XATest passes but shows Table/View 'APP.FOO' does not exist. under logs/serverConsoleOutput.log
DERBY-4155 jdbcapi/XATest.java doesn't seem to be running anywhere
The problem was actually an embedded issue that close() tried to reprepare the statement which would fail if dependencies had been dropped. This caused a failur in proper shutdown of network server which could cause a hang after running XATest.
Contributed by Tiago Espinha (tiago at espinhas dot net)
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@800523 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-4311-d13a3acc | DERBY-4311: BaseJDBCTestCase.assertErrorCode() never fails
Removed the broken methods.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@795092 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-4312-8b8fe9f9 | DERBY-4312 SQLException XJ215 on insert with setCharacterStream() and autocommit off in mailjdbc test
DERBY-4224 Commit after setAsciiStream() makes execution fail with the client driver
Use of a stream after performing commit was incorrectly causing an exception. Also fixes setBinaryStream();
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@796020 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-4313-df7db9ea | DERBY-4313: JDBC.dropUsingDMD() may skip dropping objects
Only remove DDL statements from the list of statements to execute if
they were successful.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@796834 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/testing/org/apache/derbyTesting/junit/JDBC.java",
"hunks": [
{
"added": [
"\t\t\tif (result == Statement.EXECUTE_FAILED)",
"\t\t\telse if (result == Statement.SUCCESS_NO_INFO || result >= 0) {",
"\t\t\t\tddl.set(i, null);",
"\t\t\t}"
... |
derby-DERBY-4314-2f3d0522 | DERBY-4314 With derby client setTrasactionIsolation executes and commits even if isolation has not changed.
Contributed by Lily Wei (lilywei at yahoo dot com) and Kristian Waagan
setTransactionIsolation will no longer commit.
Piggybacking of the isolation level was implemented to avoid a performance impact.
There is specialized logic for XA Resume and Join to make sure the client isolation is in sync with the server.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@940620 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/client/org/apache/derby/client/am/Connection.java",
"hunks": [
{
"added": [
"import org.apache.derby.client.net.NetXAResource;"
],
"header": "@@ -26,6 +26,7 @@ import org.apache.derby.jdbc.ClientDataSource;",
"removed": []
},
{
... |
derby-DERBY-4314-45a82041 | DERBY-6066(Client should use a prepared statement rather than regular statement for Connection.getTransactionIsolation)
This commit has the client user a PreparedStatement rather than a Statement to get the current isolation level.
Additionally, we found while working on this issue, that the calls to get isolation level were not always getting sent to the server side. The research on this found following
The get transaction isolation call will be sent to the server on the wire in at least following 2 cases
1)When a newer client is working with the older versions of servers(ie server that do not have support for isolation level caching) - Server version 10.3 and earlier do not support isolation level caching and hence when a newer client(10.4 and higher) is talking to a 10.3 and earlier server, there will be no information available about the current isolation level on the client side and client will ask for the isolation level from the server by sending "VALUES CURRENT ISOLATION" over the wire.
For server versions 10.4 and above, there is a possibility that the current isolation level was already piggybacked to the client as part of some other client server communication and hence the current isolation level is already available to the client and there is no need to send "VALUES CURRENT ISOLATION" over the wire to the server.
2)Additionally, as per DERBY-4314 and write up on piggybacking at http://wiki.apache.org/db-derby/Derby3192Writeup, there might be cases, where even though server has support for isolation level caching, server has not had a chance to send the isolation level piggybacked to the client as part of some other communication between client and server and hence the client will actually need to send "VALUES CURRENT ISOLATION" to the server to get the current isolation level.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1450499 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/client/org/apache/derby/client/am/Connection.java",
"hunks": [
{
"added": [
" private PreparedStatement getTransactionIsolationPrepStmt = null;"
],
"header": "@@ -99,7 +99,7 @@ public abstract class Connection",
"removed": [
" p... |
derby-DERBY-4314-baab96fc | DERBY-4343 ASSERT FAILED calling setTransactionIsolation checking isolation_ == level on pooled connection
Contributed by Lily Wei lilywei at yahoo dot com
This is just the test case for this issue. The issue itself was actually fixed with DERBY-4314. Also included is one DERBY-4314 test case to make sure piggybacking works ok after statement execution.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@942908 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-4315-419a664d | DERBY-4315: Clean up error reporting when sending an InputStream from the client to the server.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1037716 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/client/org/apache/derby/client/net/Request.java",
"hunks": [
{
"added": [
"\t\t\t\t} catch (Exception e) {",
"\t\t\t\t\t\t\t\t\t\t\t\t\t\t\t\t\t new ClientMessageId(SQLState.NET_EXCEPTION_ON_READ),"
],
"header": "@@ -317,14 +317,14 @@ publi... |
derby-DERBY-4316-4e1fb4cc | DERBY-4316: Embedded and client don't agree on whether to continue after error in batch
Added a test case that shows the difference.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@795549 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-4319-17227cff | DERBY-4319 hang in suites.all with ibm 1.5 on AIX after ttestDefaultProperties
Make sure spawned network server process is destroyed if the hang occurs on SpawnedProcess.complete(). This does not address the core reason for the hang which is still not well understood and currently does not reproduce on the aix machine with the problem. DERBY-4319 will stay open while we wait for the problem to reappear.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1079548 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/testing/org/apache/derbyTesting/junit/SpawnedProcess.java",
"hunks": [
{
"added": [
" /*Complete the method",
" * @param destroy true to destroy it, false to wait indefinitely to complete ",
" */",
" public int complete(bool... |
derby-DERBY-4319-23a45382 | DERBY-4319 hang in suites.all with ibm 1.5 on AIX after ttestDefaultProperties
disable for now ttestDefaultProperties and ttestSetPortPriority on AIX IBM 1.5, which can make the test fail. This does not fix the issue.
Also add BaseTestCase.isPlatform(String) method and OsName class to faciltate platform exclusions from test runs.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1081494 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/testing/org/apache/derbyTesting/junit/OsName.java",
"hunks": [
{
"added": [
"/*",
" *",
" * Derby - Class org.apache.derbyTesting.junit.OsName",
" *",
" * Licensed to the Apache Software Foundation (ASF) under one or more",
... |
derby-DERBY-4322-cdf28110 | DERBY-4322 intermittent failure in runtimeinfo.
Contributed by Myrna van Lunteren.
The theory is that this failure is caused by a problem in the previous test DerbyNetAutostart which launches a process to start the server and can be left pinging if the check for the server in the launching process, does not allow enough time for the server to come up. The pings increment the session number as seen by runtimeinfo. So the changes are to DerbyNetAutoStart and are to
1) Make sure the server launching process retries enough times for the launched process comes up.
2) Make sure if something does go wrong, the launched process is destroyed
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@925377 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-4323-d34116da | DERBY-4323: test failure in lang.ErrorMessageTest with IBM iseries IBM 1.5
Make the two threads that race for locks do as little as possible in order
to reduce the risk of missing the two-second window for constructing the
deadlock. That is, move query compilation and thread startup out so that
the participating threads only perform query execution.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1402043 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/testing/org/apache/derbyTesting/functionTests/util/Barrier.java",
"hunks": [
{
"added": [
"/*",
" * Derby - Class org.apache.derbyTesting.functionTests.util.Barrier",
" *",
" * Licensed to the Apache Software Foundation (ASF) under one or... |
derby-DERBY-4326-c275ab3e | DERBY-4326
Rather than quiting out of ClientThread for InterruptedException and IOException, we should first check if the exceptions aree raised because of server being shutdown. If yes, then we should quit out of ClientThread. Otherwise, we should log the exception and close the client socket that got the exception and go back to the infinite loop waiting for next client connection.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@823659 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/drda/org/apache/derby/impl/drda/ClientThread.java",
"hunks": [
{
"added": [
" if (parent.getShutdown()) {",
" // This is a shutdown and we'll just exit the",
" // thread. NOTE: This i... |
derby-DERBY-4330-0a6a8464 | DERBY-4330 NullPointerException or assert failure when re-executing PreparedStatement after lock timeout
Patch derby-4330c fixes this issue. The problem is that when a timeout
happens (or a deadlock), the result set tree for prepared statements
for some queries is partically in a closed, partially in an open
state. (The issue was reported for a join query, but exists for others
queries as well). This causes problems when the result set tree is
being reused, i.e. when the prpared statement is attempted re-executed
after the timeout, since the tree is expected to be fully closed at
that time, cuasing the assert or NPE.
The fix ensures that the tree is left in a fully closed state in such
cases.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@804271 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-4331-397f968f | DERBY-4331
Fixes a number of sort avoidance bugs that were introduced by the fix
for DERBY-3926. This check in backs out the equi-join part of the DERBY-3926.
The changes for this were isolated and were the only changes to
FromBaseTable.java. Backing out only this part of the 3926 checkin fixes new
problems identified in DERBY-4331, and continues to fix the problem queries in
DERBY-3926. Knowledge of equijoin is no longer used as a factor for
sort avoidance.
Also included is an update to the wisconsin tests. A number of diffs
resulted from different join order to maintain a sort avoidance plan. 2
queries identified in DERBY-4339 no longer use sort avoidance.
The new test cases were reported as part of 4331 were added to the
OrderByAndSortAvoidance test.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@801481 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/sql/compile/FromBaseTable.java",
"hunks": [
{
"added": [],
"header": "@@ -462,13 +462,6 @@ public class FromBaseTable extends FromTable",
"removed": [
"\t\t\t\t\t//Check if the order by column has equijoin on another ",
... |
derby-DERBY-4336-adf7016c | DERBY-4336: Remove Blob and Clob interface methods from the list of unsupported methods in UnsupportedVetter.
Removed now implemented methods in the Blob/Clob JDBC interface from the list of unsupported methods in jdbc4.UnsupportedVetter.
Also removed the update[BC]lob-methods in the ResultSet interface.
Patch file: derby-4336-1a.diff
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@800799 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-4338-3392df81 | DERBY-4338 Network client raises error "executeQuery method can not be used for update" when sql is preceded by /* */ comments
This patch, derby-4338-d, fixes the seen bug, and also generalizes the
method used by the client driver to find the first significant
(non-comment) SQL statement identifier, i.e. a keyword. This is needed
by the client's statement classification logic. For certain input
strings the old method also gave wrong results, cf. the new test cases
added.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@809643 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/client/org/apache/derby/client/am/Statement.java",
"hunks": [
{
"added": [
" sqlUpdateMode_ = 0;",
" // See if the statement starts with one or more comments; if so, move",
" // past the comments and get the first token of the ... |
derby-DERBY-4339-397f968f | DERBY-4331
Fixes a number of sort avoidance bugs that were introduced by the fix
for DERBY-3926. This check in backs out the equi-join part of the DERBY-3926.
The changes for this were isolated and were the only changes to
FromBaseTable.java. Backing out only this part of the 3926 checkin fixes new
problems identified in DERBY-4331, and continues to fix the problem queries in
DERBY-3926. Knowledge of equijoin is no longer used as a factor for
sort avoidance.
Also included is an update to the wisconsin tests. A number of diffs
resulted from different join order to maintain a sort avoidance plan. 2
queries identified in DERBY-4339 no longer use sort avoidance.
The new test cases were reported as part of 4331 were added to the
OrderByAndSortAvoidance test.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@801481 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/sql/compile/FromBaseTable.java",
"hunks": [
{
"added": [],
"header": "@@ -462,13 +462,6 @@ public class FromBaseTable extends FromTable",
"removed": [
"\t\t\t\t\t//Check if the order by column has equijoin on another ",
... |
derby-DERBY-4342-7017a351 | DERBY-4342: SQLSTATE 38000 (NullPointerException) at inner self join and value(x1, x2...)
Override ValueNode.remapColumnReferencesToExpressions() in CoalesceFunctionNode
so that its arguments are properly remapped. The lack of remapping made the
generated code access the wrong result set, eventually causing the
NullPointerException.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@819006 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-4343-baab96fc | DERBY-4343 ASSERT FAILED calling setTransactionIsolation checking isolation_ == level on pooled connection
Contributed by Lily Wei lilywei at yahoo dot com
This is just the test case for this issue. The issue itself was actually fixed with DERBY-4314. Also included is one DERBY-4314 test case to make sure piggybacking works ok after statement execution.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@942908 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-4347-86ce4291 | DERBY-4347 ; Provide a property to increase network server start timeout for JUnit tests
This introduces the optional property 'derby.tests.networkServerStartTimeout'
which takes an int signifying the new wait time in seconds.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@814815 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/testing/org/apache/derbyTesting/junit/NetworkServerTestSetup.java",
"hunks": [
{
"added": [
" /** Setting maximum wait time to 40 seconds by default. On some platforms",
" * For even slower systems (or for faster systems) the default value can",
... |
derby-DERBY-4348-0b97566f | DERBY-4348: Copy table content with "INSERT INTO table SELECT FROM (...)" statement leads to corrupt data
NormalizeResultSet can in some cases replace a holder object in its
DataValueDescriptor cache with a holder object that's also used in
BulkTableScanResultSet's cache, and thereby corrupting
BulkTableScanResultSet's fetch buffer when the holder object is
modified. This patch makes NormalizeResultSet store the cached holder
objects in a separate data structure to prevent them from being
replaced.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@808850 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/iapi/types/DataTypeDescriptor.java",
"hunks": [
{
"added": [
" } else {",
" SanityManager.THROWASSERT(\"cachedDest is null\");",
" }"
],
"header": "@@ -627,7 +627,9 @@ pub... |
derby-DERBY-4356-bdbc3cb2 | DERBY-4356: Better insulate ManagementMBeanTest from environment left over from previous JUnit tests.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@807685 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-4357-38a34c2c | DERBY-4357: A couple more tests for restricted vtis.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@832423 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-4357-86f2ca10 | DERBY-4357: Add public api for restricted table functions.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@829078 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/vti/Restriction.java",
"hunks": [
{
"added": [
"/*",
"",
" Derby - Class org.apache.derby.vti.Restriction",
"",
" Licensed to the Apache Software Foundation (ASF) under one or more",
" con... |
derby-DERBY-4357-a2d08471 | DERBY-4357: Pass projections and restrictions through to RestrictedVTIs.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@831072 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/iapi/sql/execute/ResultSetFactory.java",
"hunks": [
{
"added": [
"\t\t@param erdNumber\t\tint for referenced column BitSet (so it can be turned back into an object)",
"\t\t@param optimizerEstimatedRowCount\tEstimated total # of rows b... |
derby-DERBY-4357-f6fa9429 | DERBY-4357: Check in logic to push restrictions into VTIs when the optimizer chooses to siphon the vti into a hash table.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@831454 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/sql/compile/FromVTI.java",
"hunks": [
{
"added": [
" void computeProjectionAndRestriction( PredicateList parentPredicates )",
" computeRestriction( parentPredicates, computeProjection( ) );",
" * Restricte... |
derby-DERBY-436-b690b7ae | DERBY-5847: Clean up IDE warnings in DRDAConnThread
DERBY-436: Clean up imports and static field references in DRDA classes
Changed in DRDAConnThread:
- Use class name to reference static fields
- Use direct references to constants in java.sql.ParameterMetaData
instead of JDBC30Translation
- Organize imports alphabetically
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1359559 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/drda/org/apache/derby/impl/drda/DRDAConnThread.java",
"hunks": [
{
"added": [
"import java.io.IOException;",
"import java.io.InputStreamReader;"
],
"header": "@@ -22,11 +22,11 @@ package org.apache.derby.impl.drda;",
"removed": [
... |
derby-DERBY-436-db4c9953 | DERBY-436: Clean up imports and static field references in DRDA classes
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1363662 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/drda/org/apache/derby/drda/NetworkServerControl.java",
"hunks": [
{
"added": [
"import java.net.InetAddress;"
],
"header": "@@ -22,8 +22,8 @@",
"removed": [
"import java.net.InetAddress;"
]
}
]
},
{
"file": "... |
derby-DERBY-4361-a505d5a3 | DERBY-4361
It was not enough to just the shutdown the database in Windows in order to be able to delete
the log file later. The engine needed to be brought down too. I added code in JDBCDataSource for shutting down the engine and used this new method from the ClassLoaderBootTest to shut the engine down.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@812669 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/testing/org/apache/derbyTesting/junit/JDBCDataSource.java",
"hunks": [
{
"added": [
"import javax.sql.DataSource;",
""
],
"header": "@@ -25,6 +25,8 @@ import java.sql.SQLException;",
"removed": []
},
{
"added": [
... |
derby-DERBY-4365-f8b521a5 | DERBY-4365
For JOIN, we were doing a no-op in the method bindUntypedNullsToResultColumns(ResultColumnList) rather than checking for untyped nulls for the left and right resultsets. The changes through this commit now checks for untyped nulls for joins. Added couple more tests (including where a CAST of NULL values should work fine). The derbyall and junit suites ran fine with the exception of known intermittent (DERBY-3757) 'ASSERT FAILED transaction table has null entry when running new StressMultiTest
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@833430 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-4367-6391648e | DERBY-4367: Replace Utils.min and Utils.max in the client driver with standard methods in java.lang.Math.
Removed methods min and max in Utils, as they duplicate standard methods in
java.lang.Math. Replaced all invocations.
Patch file: derby-4367-1a-remove_min_max.diff
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@810024 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/client/org/apache/derby/client/am/Utils.java",
"hunks": [
{
"added": [],
"header": "@@ -22,8 +22,6 @@",
"removed": [
"import org.apache.derby.iapi.types.SQLBit;",
"import org.apache.derby.shared.common.i18n.MessageUtil;"
]
}
... |
derby-DERBY-4372-c7c53056 | DERBY-4372: Wrong result for simple join when index is created
If the inner table in the join is restricted by an explicit or
implicit IN list on an indexed column, an index range scan is
performed between the smallest value and the greatest value in the IN
list.
If the first element in the IN list was NULL, the methods that
calculated the minimum and maximum values always returned NULL, which
resulted in a range scan between NULL and NULL, and no rows were
found. If some other element in the IN list was NULL, it was simply
ignored.
This patch makes the methods always return the min or max non-NULL
value, if such a value exists. Since the index scan is not supposed to
return the NULL values anyway, it is safe to ignore them. The edge
case where all the values are NULL still returns NULL for both min and
max. This makes the index scan return no rows, which is correct
because X IN (NULL, NULL) is never true, regardless of the actual
value of X.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@816531 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/sql/execute/BaseExpressionActivation.java",
"hunks": [
{
"added": [
"\t * <p>",
"\t * {@code null} for the unused parameters and place them at the end.",
"\t * If more than 4 input values, call this multiple times to",
... |
derby-DERBY-4373-7b429a31 | DERBY-3823 NullPointerException in stress.multi test
Adding a test case showing that in case of a network server, an open resulset's metadata can get changed underneath it but it is
not reflected in the metadata. The test creates a table with one of column as varchar(5). It inserts 1000 rows and then
opens a reulset on that table with varchar column as one of the columns. The test verifies that the reulset's metadata
at this point shows the length of the column as 5. Next, while the resulset is still open, the tests does an ALTER TABLE
to increase the varchar column's length to 8. In case of embedded mode, this fails because of the open resulset. In case
of network server, because of prefetching of rows, the ALTER TABLE is allowed but when the test gets the resulset's
metadata again and checks the length of varchar column, it still shows the length to be 5 rather than 8.
There are couple other jiras related to network server prefetching, namely, DERBY-3839 and DERBY-4373.
Once DERBY-3823 is fixed, we should see the change in metadata reflected in resultset's metadata. A fix for DERBY-3823 will
cause the following the test added here to fail. Right now, the new test accepts the incorrect metadata length obtained
through the resultset's metadata after ALTER TABLE has been performed in network server mode.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1182570 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-4376-5ce87314 | DERBY-4376: Simple select runs forever
A MultiProbeTableScanResultSet performes one index scan per distinct
element in the IN list. Changing the start and stop positions of the
underlying index scan, and moving to the next element in the IN list,
happens when the scan controller is reopened. However, the reopening
of the scan controller is controlled by TableScanResultSet, which
skips the reopening if the current start and stop positions are
guaranteed to make the scan return zero rows. Basically, if the
start/stop positions are initialized with NULLs, the scan is not
reopened, and we do not move to the next element of the IN list. We
therefore just keep on retrying at the same position in the IN list,
and the query execution is stuck forever.
This patch moves all the multi-probe logic out of TableScanResultSet
and into MultiProbeTableScanResultSet, and instead adds methods that
MPTSRS can override where different logic is needed. In short:
1) Initialization of the start/stop keys has been factored out of
TSRS.openCore()/TSRS.reopenCore() into a helper method
initStartAndStopKey().
2) MPTSRS overrides initStartAndStopKey() and updates the keys with
the actual probe value. This ensures that the keys now have the
correct values when TSRS.reopenCore() calls skipScan().
3) Methods in TSRS that take a probeValue argument have been removed,
since MPTSRS.initStartAndStopKey() now does all the work with
retrieving the probe value and updating the keys.
4) Since the next probe value is fetched earlier now
MPTSRS.reopenScanController() can no longer use the return value from
getNextProbeValue() to decide whether or not it should be a no-op (it
should be a no-op if the next probe value was null, which means that
the probe list has been exhausted). To ensure that we don't open scans
in those cases, set a flag in initStartAndStopKey() to indicate
whether or not the probe list was exhausted, and override skipScan()
to check that flag and return true if no new probe value was found.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@816536 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/sql/execute/MultiProbeTableScanResultSet.java",
"hunks": [
{
"added": [
"import org.apache.derby.iapi.sql.execute.ExecIndexRow;"
],
"header": "@@ -28,11 +28,11 @@ import org.apache.derby.iapi.services.loader.GeneratedMethod... |
derby-DERBY-4378-c95594cc | DERBY-4378: Create test cases for MultiProbeTableScanResultSet with duplicates in the probe list
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1507212 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-438-006805f8 | DERBY-438 (partial) Add testing of BLOBs in triggers with larger BLOB values.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@397315 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-438-19f33c64 | DERBY-438 (partial) Move ReaderToUTF8Stream.java from the JDBC implementation to the
types package so that it can be used directly by SQLCLob. This class converts from
a Reader (stream) format to the on-disk format for character types.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@393973 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/iapi/types/ReaderToUTF8Stream.java",
"hunks": [
{
"added": [
" Derby - Class org.apache.derby.iapi.types.ReaderToUTF8Stream"
],
"header": "@@ -1,6 +1,6 @@",
"removed": [
" Derby - Class org.apache.derby.imp... |
derby-DERBY-438-2c65d7cb | DERBY-438 Support statement triggers for BLOB and CLOB types. Change the trigger
virtual tables to implement PreparedStatement instead of ResultSet. This allows
the mechanism to use the java.sql.ResultSet generated from the language internal
ResultSet directly, rather than through a wrapper. The wrapper approach caused
issues when the wrapper's JDBC version does not match the version running in the
engine. BLOB/CLOB caused problems with statement triggers as the wrapper
only supported JDBC 1.2. Add tests for BLOB (will add CLOB in subsequent patch),
also add upgrade tests across release boundaries to ensure trigger modifications
in 10.2 do not break in soft upgrade mode.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@409422 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/catalog/TriggerNewTransitionRows.java",
"hunks": [
{
"added": [
"import org.apache.derby.iapi.reference.JDBC20Translation;",
""
],
"header": "@@ -22,6 +22,8 @@ package org.apache.derby.catalog;",
"removed": []
... |
derby-DERBY-438-40bcd6b2 | DERBY-438 (partial) Clarify by adding comments or re-naming variables the expected format
of stream values passed to internal data types. The internal data types always work in streams
that represent the on-disk format of the data type and not the application visible stream.
Some code in SQLBinary and SQLBLob is incorrect and will be fixed in a subsequent commit.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@393570 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/iapi/types/DataType.java",
"hunks": [
{
"added": [
"\tpublic void setValue(InputStream theStream, int valueLength) throws StandardException"
],
"header": "@@ -993,7 +993,7 @@ public abstract class DataType",
"removed": [... |
derby-DERBY-438-4dbb0ff3 | DERBY-438 (partial) Consolidate code around converting application character streams (Readers)
to the internal stored form (modified UTF8). Pushed handling of LimitReader into ReaderToUTF8Stream
to avoid duplicated code and ReaderToUTF8Stream having to make assumptions about the caller setting
up the LimitReader correctly. Added comments and clarifications to LimitReader and ReaderToUTF8Stream.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@397316 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/iapi/services/io/LimitReader.java",
"hunks": [
{
"added": [
"public final class LimitReader extends Reader implements Limit ",
"\tprivate int remainingCharacters;",
"\tprivate boolean limitInPlace;"
],
"heade... |
derby-DERBY-438-581dc2b8 | DERBY-438 (partial) Optimize Blob.length() to avoid reading the whole stream if the length
is encoded in the stream from the store or the length has already been obtained once.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@397313 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/jdbc/EmbedBlob.java",
"hunks": [
{
"added": [
" // blob is either bytes or stream",
" /*",
" * Length of the BLOB if known. Set to -1 if",
" * the current length of the BLOB is not known.",
... |
derby-DERBY-438-5c205222 | DERBY-438 (partial) Consistwnt handling of binary streams for updateXXX, namely check
the length correctly if it is greater than the 2Gb supported by Derby. Add some comments
to SQLBinary to clarify the format. Save the length when reading a binary stream from the
store into an application, will be used in a subsequent checkin. Ensure eof handling
when reading the binary value length in the on-disk format is handled correctly.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@393880 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/iapi/types/SQLBinary.java",
"hunks": [
{
"added": [
" Length is encoded to support Cloudscape 5.x databases where the length was stored as the number of bits.",
" The first bit of the first byte indicates if the format is an old (Cl... |
derby-DERBY-438-96b9662f | DERBY-438 (partial) Ensure internal conversions of JDBC objects to BLOBs provide the conversion
using RawToBinaryFormatStream from the raw binary stream to the on-disk format stream as required
by the data type api. Make RawToBinaryFormatStream encode the length of the value in the first
bytes as defined in the format described in SQLBinary. Ensure the code handles this encoded lenght correctly.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@394109 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/iapi/types/RawToBinaryFormatStream.java",
"hunks": [
{
"added": [
"\tlength of the value.",
" <P>",
" If the length of the stream is known then it is encoded",
" as the first bytes in the stream in the def... |
derby-DERBY-438-c56ecebc | DERBY-438 (partial) Move RawToBinaryStreamFormat.java from org.apache.derby.impl.jdbc to
org.apache.derby.iapi.types to allow its use in SQLBlob and SQLBinary (in a future commit).
This will allow the setting of the internal binary types from JDBC objects in a consistent manner.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@393579 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/iapi/types/RawToBinaryFormatStream.java",
"hunks": [
{
"added": [
" Derby - Class org.apache.derby.iapi.types.RawToBinaryFormatStream"
],
"header": "@@ -1,6 +1,6 @@",
"removed": [
" Derby - Class org.apache... |
derby-DERBY-438-ed90c539 | DERBY-438 (partial) Add statement trigger tests involving selecting large CLOB values.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@410702 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-4380-d491ea3c | DERBY-4380: Subqueries not allowed in ON clause
Removed the check that disallowed subqueries in ON clauses. Also
removed the double binding of the ON clause in JoinNode since it made
the query tree inconsistent for some kinds of subqueries.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@882106 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/sql/compile/JoinNode.java",
"hunks": [
{
"added": [],
"header": "@@ -799,40 +799,13 @@ public class JoinNode extends TableOperatorNode",
"removed": [
"\t\t\t/* First bind with all tables in the from clause, to detect ambigu... |
derby-DERBY-4381-894a72f1 | DERBY-4381; Connection to Derby database using jar subprotocol doesn't work if the path has round braket in it
adding a test and changing search for matching bracket to be from the last occurrence.
fix suggested by Rafael Soares (rafael dot enq at gmail dot com)
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1602054 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/io/JarStorageFactory.java",
"hunks": [
{
"added": [
"import org.apache.derby.iapi.services.info.JVMInfo;"
],
"header": "@@ -25,6 +25,7 @@ import java.io.File;",
"removed": []
}
]
}
] |
derby-DERBY-4381-d54c775b | DERBY-4381; Connection to Derby database using jar subprotocol doesn't work if the path has round bracket in it
fixing formatting, comments, and removing an unnecessary import
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1602232 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-4387-54d942e9 | DERBY-4387 Infinite loop in PredicateList.joinClauseTransitiveClosure()
This patch, derby-4387, fixes a corner case of the closure code in
which the outer and the inner table is the same. This led to adding
the same, new predicate twice to the same table, causing the infinite
loop. The patch also adds a test case, which, without the fix, shows
the infinite loop.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@887246 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-4388-f8d48a3c | DERBY-4388: NullPointerException in RIGHT JOIN with NOT BETWEEN
Clone the left operand when performing not-elimination in
BetweenOperatorNode to prevent ColumnReferences from being shared, as
they can be remapped during optimization.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@822289 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-4393-c4caf0a6 | DERBY-4393 - lang.SequenceTest fails w/ "Sequence 'ALPHA_SEQ' already exists." on phoneME/cvm.
Do cleanup in testcases to make the testcases independent of running order.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@822641 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-4397-2060c4a6 | DERBY-4397 Allow ORDER BY in subqueries
Patch derby-4397-2 which implements this functionality and also adds a
new test, OrderByInSubqueries. This patch also solves DERBY-4.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@891952 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/sql/compile/CreateViewNode.java",
"hunks": [
{
"added": [
"\tprivate OrderByList orderByList;"
],
"header": "@@ -68,7 +68,7 @@ public class CreateViewNode extends DDLStatementNode",
"removed": [
""
... |
derby-DERBY-4397-7b48c50b | DERBY-4397 Allow ORDER BY in subqueries
Patch derby-4397-sortavoidance-a, which makes sort avoidance work in
the simple case of a subquery with order by on a base table which has
a suitable index. The fix avoids the result columns assumed by the
order by list from changing after they have been bound, to include a
level of VCNs, which is not correct (this happened as a side effect of
copying result columns from the subquery up to the FromSubquery node).
A new test case the verify sort avoidance in this case has been added.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@899588 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/sql/compile/FromSubquery.java",
"hunks": [
{
"added": [
" /* NOTE: If the size of the derived column list is less than"
],
"header": "@@ -258,12 +258,7 @@ public class FromSubquery extends FromTable",
"remove... |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.