id stringlengths 22 25 | commit_message stringlengths 137 6.96k | diffs listlengths 0 63 |
|---|---|---|
derby-DERBY-4398-108305bc | DERBY-4398 Allow OFFSET/FETCH in subqueries
Patch derby-4398-3, which implements this feature, and also adds test
cases for this to the now renamed test
OrderByAndOffsetFetchInSubqueries and OffsetFetchNextTest.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@897934 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/sql/compile/CreateViewNode.java",
"hunks": [
{
"added": [
" private ValueNode offset;",
" private ValueNode fetchFirst;"
],
"header": "@@ -69,6 +69,8 @@ public class CreateViewNode extends DDLStatementNo... |
derby-DERBY-44-fc6efec2 | DERBY-1014: Make tests less sensitive to pre-fetching
Attached a patch (DERBY-1014-v1.diff) which modifies tests in
preparation for DERBY-822. There are two types of changes:
1) Invoke ResultSet.next() to expose error even when the driver
isn't pre-fetching data.
2) Filter out some of the run-time statistics before comparing with
the canon.
lang/wisconsin.java:
* Added patterns to the sed file. Cursor names and some of the
run-time statistics are filtered out.
* Canons for DerbyNet and DerbyNetClient were deleted since they are
no longer needed. Each of these files is 1.5M, so the diff is
huge.
lang/scrollCursors1.sql:
* Added patterns to the sed file. Number of rows seen and number of
reads from hash table will be filtered out.
jdbcapi/parameterMetaDataJdbc30.java:
* Added a call to ResultSet.next() to provoke an error in a test
case for DERBY-44 regardless of framework/pre-fetching.
jdbcapi/resultset.java:
* Don't print column headers until one row is successfully retrieved
(achieved by calling ResultSet.next() earlier).
jdbcapi/setTransactionIsolation.java:
* Added a call to ResultSet.next() to provoke a timeout regardless
of framework/pre-fetching.
* Added patterns to the sed file. Filtered out number of pages
visited, number of rows qualified/visited etc.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@387214 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-4402-97e996cf | DERBY-4402
Group by should not allow aggregates in it. We were able to detect "froup by (sum(j))" but not "group by (4+sum(j))". That's because we were not looking deep enough inside the group by column.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@881074 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-4405-7ff4f83f | DERBY-4405 Transformation to inner join not performed for certain three-way joins
Patch derby-4405-2, which extends the rewriting optimization of outer
join to inner join in the presence of a compound inner table which
itself a join. The existing analysis of null intolerant predicates,
which is a condition for the rewrite, failed to look into inner tables
that were not a simple base table.
The patch adds new test cases to verify that rewrite now takes place
for such cases.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@891015 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/sql/compile/HalfOuterJoinNode.java",
"hunks": [
{
"added": [],
"header": "@@ -566,7 +566,6 @@ public class HalfOuterJoinNode extends JoinNode",
"removed": [
"\t\tJBitSet innerMap = new JBitSet(numTables);"
]
}... |
derby-DERBY-4407-fe2341f8 | DERBY-4407: StringIndexOutOfBoundsException in ij when result has no columns
Raise a compile-time error if a query returns no columns.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@826616 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-441-93ab8302 | DERBY-441 - Progress on clean up of published javadoc.
- Remove some unused methods in client data sources.
- Add warnigns for connectionAttributes
- remove attributesAsPassword property for EmebeddedSimpleDataSource
git-svn-id: https://svn.apache.org/repos/asf/incubator/derby/code/trunk@209473 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/client/org/apache/derby/jdbc/ClientBaseDataSource.java",
"hunks": [
{
"added": [
" ClientBaseDataSource() {"
],
"header": "@@ -60,7 +60,7 @@ public abstract class ClientBaseDataSource implements Serializable, Referenceabl",
"removed": [
... |
derby-DERBY-4412-e7e328d6 | DERBY-4412: Make getNegation() abstract in BinaryComparisonOperatorNode and UnaryComparisonOperatorNode
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@827035 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/sql/compile/BinaryComparisonOperatorNode.java",
"hunks": [
{
"added": [],
"header": "@@ -33,8 +33,6 @@ import org.apache.derby.iapi.reference.SQLState;",
"removed": [
"import org.apache.derby.iapi.services.sanity.SanityMana... |
derby-DERBY-4413-9d24308d | DERBY-4413 INSERT from SELECT DISTINCT gives assertFailure (sane), or NPE (insane) in presence of generated columns
Patch DERBY-4413-2 makes sort accept columns that are null. In sane mode, it is checked that in such a case, the
empty column is not part of the sort key.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@829410 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/store/access/sort/MergeSort.java",
"hunks": [
{
"added": [
"",
"\t/**",
" Determine whether a column is used for ordering or not.",
"\t**/",
"\tprivate boolean isOrderingColumn[];",
""
... |
derby-DERBY-4413-e0ba78cc | DERBY-4413 INSERT from SELECT DISTINCT gives assertFailure (sane), or NPE (insane) in presence of generated columns
After DERBY-4442 went in, the exception to the ASSERT check we made in
the original fix for this issue should be rolled back, so as to
provide a better internal consistency check. Patch derby-4413-rollback
does this.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@885659 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/store/access/sort/MergeSort.java",
"hunks": [
{
"added": [],
"header": "@@ -126,12 +126,6 @@ class MergeSort implements Sort",
"removed": [
"",
"\t/**",
" Determine whether a column is used for orderi... |
derby-DERBY-4415-3ff5ce3d | DERBY-4415: Add ability to plug customized AST printers into the compiler.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@827760 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/iapi/sql/conn/LanguageConnectionContext.java",
"hunks": [
{
"added": [
"import org.apache.derby.iapi.sql.compile.ASTVisitor;"
],
"header": "@@ -32,6 +32,7 @@ import org.apache.derby.iapi.sql.dictionary.SchemaDescriptor;",
... |
derby-DERBY-4419-c6172435 | DERBY-4425: NPE with INSERT .. SELECT .. UNION and generated expressions
This patch adds a test which confirms that DERBY-4425 is fixed. The code
change which resolved DERBY-4425 was performed as part of fixing DERBY-4419,
since the same code change fixes both symptoms, so this is a test-only patch.
subversion revision 831304 contains the DERBY-4419 code change.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@831319 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-4420-7a27cabe | DERBY-4420: NullPointerException with INSERT INTO ... from EXCEPT/INTERSECT
The failing code in ResultSetNode.setTableConstructorTypes() was meant
to handle the case where the node represented a table constructor (aka
VALUES clause). UnionNode already had an override to make it a no-op
unless it actually represented a multi-row VALUES clause that had been
rewritten to a union of single-row VALUES clauses.
Since a VALUES clause is never rewritten to EXCEPT or INTERSECT, the
correct handling is to make setTableConstructorTypes() a no-op in
IntersectOrExceptNode. Rather than adding an empty override in
IntersectOrExceptNode, the code was moved from
ResultSetNode.setTableConstructorTypes() to
RowResultSetNode.setTableConstructorTypes(), and the default
implementation in ResultSetNode was left empty.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@832379 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/sql/compile/ResultSetNode.java",
"hunks": [
{
"added": [
"\t * Set the type of each parameter in the result column list if this node",
"\t * represents a table constructor (aka VALUES clause). Table constructors",
"\t *... |
derby-DERBY-4421-dd2f5a82 | DERBY-4421: Allow visitors to process the nodes bottom-up
Added the method visitChildrenFirst() to the Visitor interface to
allow the visitor to specify whether they should walk the tree
top-down or bottom-up. Implemented the method in all existing visitors
and made it return false to preserve the current behaviour with
top-down walking.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@830154 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/sql/compile/BinaryListOperatorNode.java",
"hunks": [
{
"added": [
"\t * Accept the visitor for all visitable children of this node.",
"\tvoid acceptChildren(Visitor v)",
"\t\tsuper.acceptChildren(v);"
],
... |
derby-DERBY-4425-c6172435 | DERBY-4425: NPE with INSERT .. SELECT .. UNION and generated expressions
This patch adds a test which confirms that DERBY-4425 is fixed. The code
change which resolved DERBY-4425 was performed as part of fixing DERBY-4419,
since the same code change fixes both symptoms, so this is a test-only patch.
subversion revision 831304 contains the DERBY-4419 code change.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@831319 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-4426-c341dc44 | DERBY-4426 With generated columns, INSERT with DEFAULT inside a VALUES clause inside a UNION fails
Patch derby-4426c, which fixes this issue. We ensure that DEFAULT is
only used in a top level VALUES clause, conformant with the standard.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@885595 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/sql/compile/ResultColumnList.java",
"hunks": [
{
"added": [
"\t * Replace any DEFAULTs with the associated tree for the default if",
"\t * allowed, or flag.",
" * @param allowDefaults true if allowed",
"\t... |
derby-DERBY-4428-18373c4f | DERBY-4428 (partial): Add proper delete mechanism for in-memory databases
Refactored code into getProtocolLeadIn()
Changed an ASSERT, as it expected equality between something that couldn't be
equal unless the default storage back end was used. It failed for the in-memory
back end, and would also fail for all other back ends. This code path hasn't
been enabled for other storage back ends before now (deleting the service root).
Patch file: derby-4428-3b-canonical_name_handling.diff
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@884105 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/services/monitor/StorageFactoryService.java",
"hunks": [
{
"added": [
" return getProtocolLeadIn() + (String) AccessController.doPrivileged("
],
"header": "@@ -639,15 +639,7 @@ final class StorageFactoryService i... |
derby-DERBY-4428-88e75e5b | DERBY-4436: Refactor existing in-memory back end tests and add new tests for dropping database.
Added a new utility class to deal with in-memory databases (convenience methods, much like BaseJDBCTestCase and friends).
Adjusted existing tests to use MemoryDbManager.
Added new test DropWhileConnectingTest to study the behavior of Derby when several threads connect and/or execute queries when the database is being shut down. Written primarily to test the upcoming feature for blocking new connections while certain operations are taking place (for instance database shutdown and drop).
Note: Some features have been disabled in the committed code, awaiting the drop database functionality (DERBY-4428). Some additional changes may also be required.
Patch file: derby-4436-1b-inmem_test_changes.diff
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@835334 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-4428-b36288fd | DERBY-4428 (partial): Add proper delete mechanism for in-memory databases
Added the code required in the in-memory back end storage factory.
Some logic is required to remove the data store from the list of databases when
a database is dropped. Note that this logic isn't fully general purpose - it is
partly dependent on how the monitor / StorageFactoryService works.
Patch file: derby-4428-1b-in_memory_specific_delete_code.diff
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@883297 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/io/VFMemoryStorageFactory.java",
"hunks": [
{
"added": [
" * <p>",
" * Note that data store deletion may happen inside one of two different methods;",
" * either in {@code shutdown} or in {@code init}. This is due to th... |
derby-DERBY-4428-c406220e | DERBY-4428: Add proper delete mechanism for in-memory databases
This patch adds the final pieces to enable the drop attribute for in-memory
databases. Usage: 'jdbc:derby:memory:myDB;drop=true[;user=...;password=...]'
If successful, an exception with SQL state 08006 is raised.
* EmbedConnection
Added parsing of the drop attribute. 'true' yields true, everything else
results in false (i.e. non-boolean values are accepted and silently ignored).
Added code to drop a database.
Introduced XJ048, raised when drop is combined with shutdown.
Added code to check for attribute conflicts (create, restore).
Added utility method to put the current thread to sleep.
* DatabaseContextImpl
Added a comment.
* Monitor
Added code to disallow dropping databases not using the in-memory back end.
* Attribute
Added constant for the 'drop' JDBC connection URL attribute.
* SQLState, messages.xml, lang.ErrorCodeTest
Added two new messages: 08006 (database dropped) and XJ048 (conflicting
boot attributes)
* Other tests
Enabled drop functionality and tests using it.
Patch file: derby-4428-2b-generic_db_drop.diff
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@884542 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/jdbc/EmbedConnection.java",
"hunks": [
{
"added": [
" final boolean dropDatabase = isDropDatabase(info);",
"",
" // Don't allow both the shutdown and the drop attribute.",
" if... |
derby-DERBY-4429-48229dfd | DERBY-4429 - Let StressMultiTest read Threads and Minutes to run as system property
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@832364 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-4432-b1a01b25 | DERBY-4432: Memory leak when attempting to boot non-existing database with the in-memory back end.
Fixed memory leak happening when trying to boot non-existing databases by using a dummy store to handle operations that don't require a proper store.
Added a regression test (must be run with a small Java heap).
Also changed the existing test by using a discarding log writer to avoid writing a huge log file to disk (a message is logged for each failed boot).
Patch file: derby-4432-1a-mem_leak_fix.diff
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@834418 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/io/VFMemoryStorageFactory.java",
"hunks": [
{
"added": [
" /**",
" * Dummy store used to carry out frequent operations that don't",
" * require a \"proper store\", for instance getting the canonical name",
... |
derby-DERBY-4433-a8db6658 | DERBY-4442: Default value and identity in an INSERT result set evaluated too early
Always add a ProjectRestrictNode on top of the source result set for an
insert if the source columns are not ordered the same way as the target
columns, or if inserting into a subset of the columns, and the source is not
a table constructor. Then the adding of default values to the source result
column list happens on top of the original source result node, and not
inside that node. This means that the source result is produced before the
default values are added, and the generation of the defaults happens at the
correct time.
As a side-effect, these other issues are fixed:
DERBY-3 Identity column not filled consecutively with "insert ... select distinct"
DERBY-4433 Cannot insert from EXCEPT/INTERSECT when target table has more columns than the source
Much of the added code is actually old code revived from the Subversion
history. Before DERBY-1644, we used to put a ProjectRestrictNode on top of
the source result if it was a SetOperatorNode. The code that inserted the
ProjectRestrictNode was added back and changed to operate on ResultSetNode
instead of SetOperatorNode.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@885421 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/sql/compile/InsertNode.java",
"hunks": [
{
"added": [
"\t\tresultSet = enhanceAndCheckForAutoincrement(resultSet, inOrder, colMap);"
],
"header": "@@ -411,9 +411,7 @@ public final class InsertNode extends DMLModStatementNod... |
derby-DERBY-4435-aa86a51f | DERBY-4435
collation[] object was not getting initialized and that was the cause of NPE. Fixed the problem by initializing the arrary correctly.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@834725 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/sql/execute/InsertResultSet.java",
"hunks": [
{
"added": [
" collation = new int[numIndexes][];"
],
"header": "@@ -2162,6 +2162,7 @@ class InsertResultSet extends DMLWriteResultSet implements TargetResultSet",
... |
derby-DERBY-4437-311ee54c | DERBY-4437: Make the allocation of sequence/identity ranges pluggable.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1138434 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/sql/catalog/SequenceGenerator.java",
"hunks": [
{
"added": [
"import org.apache.derby.catalog.SequencePreallocator;"
],
"header": "@@ -20,6 +20,7 @@",
"removed": []
},
{
"added": [],
"hea... |
derby-DERBY-4437-35067bf6 | DERBY-4437: Add more upgrade tests for the changes to the behavior of sequences/identities.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1142013 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-4437-365a7500 | DERBY-4437: Change default length of preallocated ranges for sequences and identities and make this default easy to configure.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1141567 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/sql/catalog/SequenceRange.java",
"hunks": [
{
"added": [
" * Default number of values to pre-allocate. This is the size of the preallocation range",
" * used by other databases. See DERBY-4437.",
" private st... |
derby-DERBY-4437-729be573 | DERBY-4437: Replace old identity generator with a new, pre-allocating sequence generator.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1135226 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/iapi/sql/dictionary/DataDictionary.java",
"hunks": [
{
"added": [],
"header": "@@ -1717,29 +1717,6 @@ public interface DataDictionary",
"removed": [
"\t/**",
"\t * getSetAutoincrementValue fetches the autoincrement val... |
derby-DERBY-4437-fe9e3d41 | DERBY-4437: Add tests for the generator-based identity columns: ALTER TABLE, bulk import, and deferred INSERT.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1135754 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-4441-54a04d34 | DERBY-4441 Change sysinfo to print out more specific JVM information
Contributed by lilywei at yahoo dot com
Show system properties java.runtime.version and java.fullversion with sysinfo to give more specific JVM information.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@935700 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/tools/org/apache/derby/impl/tools/sysinfo/Main.java",
"hunks": [
{
"added": [
"\tprintPropertyIfNotNull(localAW, \"java.runtime.version\");",
"\tprintPropertyIfNotNull(localAW, \"java.fullversion\");",
" * Print property only if not null",
... |
derby-DERBY-4442-a8db6658 | DERBY-4442: Default value and identity in an INSERT result set evaluated too early
Always add a ProjectRestrictNode on top of the source result set for an
insert if the source columns are not ordered the same way as the target
columns, or if inserting into a subset of the columns, and the source is not
a table constructor. Then the adding of default values to the source result
column list happens on top of the original source result node, and not
inside that node. This means that the source result is produced before the
default values are added, and the generation of the defaults happens at the
correct time.
As a side-effect, these other issues are fixed:
DERBY-3 Identity column not filled consecutively with "insert ... select distinct"
DERBY-4433 Cannot insert from EXCEPT/INTERSECT when target table has more columns than the source
Much of the added code is actually old code revived from the Subversion
history. Before DERBY-1644, we used to put a ProjectRestrictNode on top of
the source result if it was a SetOperatorNode. The code that inserted the
ProjectRestrictNode was added back and changed to operate on ResultSetNode
instead of SetOperatorNode.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@885421 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/sql/compile/InsertNode.java",
"hunks": [
{
"added": [
"\t\tresultSet = enhanceAndCheckForAutoincrement(resultSet, inOrder, colMap);"
],
"header": "@@ -411,9 +411,7 @@ public final class InsertNode extends DMLModStatementNod... |
derby-DERBY-4442-e0ba78cc | DERBY-4413 INSERT from SELECT DISTINCT gives assertFailure (sane), or NPE (insane) in presence of generated columns
After DERBY-4442 went in, the exception to the ASSERT check we made in
the original fix for this issue should be rolled back, so as to
provide a better internal consistency check. Patch derby-4413-rollback
does this.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@885659 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/store/access/sort/MergeSort.java",
"hunks": [
{
"added": [],
"header": "@@ -126,12 +126,6 @@ class MergeSort implements Sort",
"removed": [
"",
"\t/**",
" Determine whether a column is used for orderi... |
derby-DERBY-4443-7eebc809 | DERBY-4443: Wrap rollback in exception handlers in try-catch
This patch was contributed by Houx Zhang (houxzhang at gmail dot com)
The patch modifies the error handling in SystemProcedures.java so that
secondary exceptions during rollback are chained to the primary exception.
Also, EmbedSQLException's wrapping behavior is adjusted so that the
StandardException logic doesn't try to unwrap the chained exceptions.
A new test is added to the tools suite; it simulates rollback errors
using a special mock driver and mock connection, and verifies that
the exceptions are chained properly.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1096991 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/catalog/SystemProcedures.java",
"hunks": [
{
"added": [
"\t\t\trollBackAndThrowSQLException(conn, se);",
"\t",
" /**",
" * issue a rollback when SQLException se occurs. If SQLException ouccurs when rollback,... |
derby-DERBY-4448-47611b15 | DERBY-4451 ArrayIndexOutOfBoundsException or ASSERT FAILED when inserting generated columns out of order
This patch fixes this issue as well as DERBY-4448, since they share
the same underlying problem: the former way of checking for illegal
override of generated columns in the presence of an explicit target
column list failed to look below the top level UnionNode in a table
constructor.
This specialized treatment for the case of an explicit target column
list has been removed for INSERT (it was shared with logic for
UPDATE), so checking is now done by the code for the case of no
explicit targte column list.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@884163 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/sql/compile/UpdateNode.java",
"hunks": [
{
"added": [
" forbidGenerationOverrides( resultSet.getResultColumns(),",
"\t\t\t\t\t\t\t\t addedGeneratedColumns );"
],
"header": "@@ -374,7 +374,8 @@ public fina... |
derby-DERBY-4449-afbf89dc | DERBY-4449: ArrayIndexOutOfBoundsException when inserting DEFAULT into
unspecified column
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@951366 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-4450-dcd2b043 | DERBY-4450 GROUP BY in an IN-subquery inside HAVING clause whose select list is subset of group by columns, gives NPE
Patch derby-4450b + Knut's simplification of the autocommit call in GrooupByTest#testDerby4450.
This solves the problem seen in this issue, which was a regression
from DERBY-681. The crux of the problem is that a PRN is added in the
result set tree without adjusting a higher level reference so that
wrong code is generated. The solution here is to reuse the result
column list in the inserted PRN, so that reference from above will
point correctly even after the PRN insertion (more details in JIRA).
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@882732 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-4451-47611b15 | DERBY-4451 ArrayIndexOutOfBoundsException or ASSERT FAILED when inserting generated columns out of order
This patch fixes this issue as well as DERBY-4448, since they share
the same underlying problem: the former way of checking for illegal
override of generated columns in the presence of an explicit target
column list failed to look below the top level UnionNode in a table
constructor.
This specialized treatment for the case of an explicit target column
list has been removed for INSERT (it was shared with logic for
UPDATE), so checking is now done by the code for the case of no
explicit targte column list.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@884163 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/sql/compile/UpdateNode.java",
"hunks": [
{
"added": [
" forbidGenerationOverrides( resultSet.getResultColumns(),",
"\t\t\t\t\t\t\t\t addedGeneratedColumns );"
],
"header": "@@ -374,7 +374,8 @@ public fina... |
derby-DERBY-4455-992f56f1 | DERBY-4455: Prepared statement failure with CLOB: Stream has already been read and end-of-file reached and cannot be re-used.
Don't materialize streams when transferring data values from one statement to another.
The code causing the bug was/is only invoked when using XA.
Patch file: derby-4455-1c.diff
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@901760 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/sql/GenericParameterValueSet.java",
"hunks": [
{
"added": [
"import org.apache.derby.iapi.error.StandardException;",
"import org.apache.derby.iapi.services.sanity.SanityManager;",
"import org.apache.derby.iapi.reference... |
derby-DERBY-4457-646eea3c | DERBY-4457: 'Column value mismatch' in 'testDistinctInsertWithGeneratedColumn(...lang.DistinctTest)' on Jvm 1.5, 1.4, phoneME.
SELECT DISTINCT may return rows in different order on different JVMs. Made the test independent of the actual ordering.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@885726 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-4459-aec2537d | DERBY-4459: Eliminate optimization which caused verification error in nested function calls.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@964039 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-446-2fe796b2 | DERBY-446 Remove propertyKey_ constants from ClientbaseDataSOurce that were in place for
the old scheme to get the list of attributes.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@393003 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/client/org/apache/derby/client/am/LogWriter.java",
"hunks": [
{
"added": [
"import java.util.Enumeration;",
"import java.util.Properties;",
"",
"import javax.naming.NamingException;",
"import javax.naming.RefAddr;",
"i... |
derby-DERBY-446-62d2020e | DERBY-446 (partial) Make ClientDataSource use public setter and getter methods as standard
for its Java bean properties. Avoids security exceptions or requiring extreme security
permissions in order to create a Reference from the data source. Staged development, subsequent
commits will clean up some of the remants of the old code, by removing or moving the "propertyKey_*" fields.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@379536 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/client/org/apache/derby/client/ClientDataSourceFactory.java",
"hunks": [
{
"added": [
"import java.lang.reflect.Method;",
"import java.util.Enumeration;",
"",
"import javax.naming.RefAddr;",
"import javax.naming.Reference;",
... |
derby-DERBY-446-ceb72fea | DERBY-446 (partial) Copy Attribute.java to the java/shared reference area and add in constants
for the client JDBC attributes. Change the client code to use these constants as preparation to
removing these constants from the user visible classes.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@388687 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/client/org/apache/derby/jdbc/ClientBaseDataSource.java",
"hunks": [
{
"added": [
"import org.apache.derby.shared.common.reference.Attribute;"
],
"header": "@@ -41,6 +41,7 @@ import org.apache.derby.client.am.Connection;",
"removed": []
},... |
derby-DERBY-446-f86608b1 | DERBY-446 Remove holdability constants from ClientBaseDataSource and instead use
the identical values in JDBC30Translation.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@379565 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/client/org/apache/derby/client/am/DatabaseMetaData.java",
"hunks": [
{
"added": [
"import org.apache.derby.shared.common.reference.JDBC30Translation;"
],
"header": "@@ -24,7 +24,7 @@ import java.sql.SQLException;",
"removed": [
""
... |
derby-DERBY-4463-14ff5da5 | DERBY-4463 JMX test in nightly test suite failed with: JMXTest:clientjava.lang.InterruptedException:
Patch derby-4463-2, which now resets the interrupt flag for the server
threads also before the exception is propagated in the test. Followup
to derby-4463 patch.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@889875 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-4463-75bf63db | DERBY-4463; JMX test in nightly test suite failed with: JMXTest:clientjava.lang.InterruptedException
Causing the LockInterruptTest to be skipped with ibm 1.5 jvm unil SR13 is
available; this test caused a jvm bug in the handling of waitFor() to pop up.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1071640 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-4463-7f3c16bc | DERBY-4463 JMX test in nightly test suite failed with: JMXTest:clientjava.lang.InterruptedException:
Patch derby-4463.diff, which moves the clearing of the interrupted
flag in Derby151Test to the teardown method of the test so it will
always be performed.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@888881 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-4463-f24f53cb | DERBY-4463; JMX test in nightly test suite failed with: JMXTest:clientjava.lang.InterruptedException
DERBY-5028; InterruptResilienceTest passes with IBM 1.6 SR9 but creates javacore dumps
Adjusted the skipping of this test with ibm jvms to only skip with 1.5;
Added setting of derby.stream.error.extendedDiagSeverityLevel to 50000 to
prevent unnecessary javacore dump files.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1071545 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-4463-fc9859eb | DERBY-4463 JMX test in nightly test suite failed with: JMXTest:clientjava.lang.InterruptedException
Patch derby-4463-except-non-sun-vm disables this test for non-Sun
VMs. This is intended as a temporary measure until we understand why
the test is not working correctly on IBM VMs.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@892316 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-4469-30fa79be | DERBY-4469: Forbid implicit and explicit casts to and from UDTs.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@909190 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/sql/compile/BaseTypeCompiler.java",
"hunks": [
{
"added": [
" if ( otherType.getBaseTypeId().isAnsiUDT() ) { return false; }"
],
"header": "@@ -274,6 +274,7 @@ abstract class BaseTypeCompiler implements TypeCompiler"... |
derby-DERBY-4469-816219fa | DERBY-4469: Allow casting of nulls and ? parameters to UDTs.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@889975 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-447-b94443fd | DERBY-1184: registerOutParameter(int,int,String) should throw exception
Patch contributed by Kristian Waagan (Kristian.Waagan@Sun.com)
The method 'CallableStatement.registerOutParameter(int,int,String)'
does nothing in the client driver. As stated in DERBY-447, the method throws
a not-implemented exception in the embedded driver. The method should be
changed to do this on the client side as well.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@392304 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-4470-f2a56222 | DERBY-4470: Forbid ordering operations on UDTs.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@908635 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/iapi/types/TypeId.java",
"hunks": [
{
"added": [
" private static final TypeId[] ALL_BUILTIN_TYPE_IDS =",
" {",
" BOOLEAN_ID,",
" SMALLINT_ID,",
" INTEGER_ID,",
" ... |
derby-DERBY-4475-b8801c5d | DERBY-4475 roleName isn't trimmed as expected
Patch derby-4475, which contains a single line patch contributed by
dbrosius at mebigfatguy dot com, plus some extra test cases (mine).
The patch corrects a glitch in trimming white space around role name
when provided as strings.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@891350 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-4476-e96b5a28 | DERBY-4476: Use helper methods from IdUtil instead of TupleDescriptor.quoteProtectName()
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@890345 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/iapi/sql/dictionary/AliasDescriptor.java",
"hunks": [
{
"added": [
"import org.apache.derby.iapi.util.IdUtil;"
],
"header": "@@ -40,6 +40,7 @@ import\torg.apache.derby.catalog.DependableFinder;",
"removed": []
}
... |
derby-DERBY-4477-51826c3c | DERBY-4477 Selecting / projecting a column whose value is represented by a stream more than once fails
Follow-up patch for an intermittet bug caused by previous insert, due
to newly filed DERBY-4531: derby-4477-lowmem-followup.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@905621 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/testing/org/apache/derbyTesting/functionTests/util/streams/LoopingAlphabetReader.java",
"hunks": [
{
"added": [],
"header": "@@ -176,15 +176,6 @@ public class LoopingAlphabetReader",
"removed": [
" /**",
" * Reopen the stream.",
... |
derby-DERBY-4477-55bc97fc | DERBY-4477 Selecting / projecting a column whose value is represented by a stream more than once fails
Patch derby-4477-lowmem-2, which adds test cases to check that lobs
are not materialized when large, for the use cases covered by this
issue. The test cases are added to the lowmem suite, which is not not
part of the regular suites.All. This commit is preparatory in that the
lobs are still small, so these changes should be revisited to change
their sizes when the cloning handles materialization properly, cf
DERBY-3650 and DERBY-4520.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@904538 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/testing/org/apache/derbyTesting/functionTests/util/streams/LoopingAlphabetReader.java",
"hunks": [
{
"added": [
" /**",
" * Reopen the stream.",
" */",
" public void reopen()",
" throws IOException {",
... |
derby-DERBY-4478-99c48bc0 | DERBY-4478: Use AtomicLong for XactFactory.tranId
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1503157 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/store/raw/xact/XactFactory.java",
"hunks": [
{
"added": [
"import java.util.concurrent.atomic.AtomicLong;"
],
"header": "@@ -61,6 +61,7 @@ import org.apache.derby.iapi.error.StandardException;",
"removed": []
... |
derby-DERBY-4479-f1f66ff2 | DERBY-4479: RENAME TABLE needs to invalidate any cached CREATE TABLE statement
The problem involves a missing dependency between the CREATE TABLE statement
and the table that it is creating. For other types of statements, the
dependency of the statement on the table is generally registered during
compilation.
However, this isn't quite so easy with the CREATE TABLE statement, because
the table descriptor doesn't exist during compilation, since the table isn't
created until the statement is actually executed.
This change registers the dependency at execution time. At the very end of
CreateTableConstantAction.executeConstantAction, there is
some new code added to register a dependency from the CREATE TABLE
statement to the table we have just finished creating.
A new test is also added.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@909176 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-4480-7d6c180f | DERBY-4480: "No suitable driver found" when attempting to connect while other thread is auto-loading the driver
Add test case to verify that it does not affect Java 7 and newer.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1442937 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-4483-178ca0cf | DERBY-4483: Make toHexByte() private to discourage its use in new code
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@926520 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/jdbc/authentication/AuthenticationServiceBase.java",
"hunks": [
{
"added": [
" bytePasswd = toHexByte(plainTxtUserPassword);"
],
"header": "@@ -468,8 +468,7 @@ public abstract class AuthenticationServiceBase",
... |
derby-DERBY-4483-1eee3053 | DERBY-4602, DERBY-4483: Use SHA-1 for BUILTIN authentication if SHA-256 isn't supported
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@929715 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/sql/catalog/DataDictionaryImpl.java",
"hunks": [
{
"added": [
"import java.security.MessageDigest;",
"import java.security.NoSuchAlgorithmException;"
],
"header": "@@ -158,6 +158,8 @@ import java.util.LinkedList;"... |
derby-DERBY-4483-23f97a59 | DERBY-4483: Provide a way to change the hash algorithm used by BUILTIN authentication
Added more comments about the incompatibility between the configurable
hash scheme and strong password substitution.
Changed a symbol that still referred to the SHA-1 based authentication
scheme as the new scheme.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@924746 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/client/org/apache/derby/client/am/EncryptionManager.java",
"hunks": [
{
"added": [
" * This method generates a password substitute to send to the target"
],
"header": "@@ -525,7 +525,7 @@ public class EncryptionManager {",
"removed": [
... |
derby-DERBY-4483-60edeb0c | DERBY-4483: Provide a way to change the hash algorithm used by BUILTIN authentication
Added a database property, derby.authentication.builtin.algorithm,
that specifies which message digest algorithm to use when storing user
credentials in the database.
Added functional tests and upgrade tests.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@922304 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/jdbc/authentication/AuthenticationServiceBase.java",
"hunks": [
{
"added": [],
"header": "@@ -28,7 +28,6 @@ import org.apache.derby.iapi.jdbc.AuthenticationService;",
"removed": [
"import org.apache.derby.iapi.services.i18n... |
derby-DERBY-4483-8c305e2f | DERBY-4483: Provide a way to change the hash algorithm used by BUILTIN authentication
Make fresh databases use the new authentication scheme with SHA-256 by default.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@927368 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-4488-300bbebe | DERBY-4488: Nullpointer when performing INSERT INTO
Moved setting of the statement context's topResultSet to
NoRowsResultSetImpl.setup() to ensure that it's performed early enough
for all sub-classes (and for InsertResultSet in particular).
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@903108 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/sql/execute/DeleteResultSet.java",
"hunks": [
{
"added": [],
"header": "@@ -200,9 +200,6 @@ class DeleteResultSet extends DMLWriteResultSet",
"removed": [
"\t\t * NOTE: We need to set ourself as the top result set",
... |
derby-DERBY-4491-28e42550 | DERBY-4491: Disable test of parameter metadata on small platforms since PreparedStatement.getParameterMetaData() is not available on JSR-169 vms.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@901277 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-4491-2aa32e8a | DERBY-4491: Fix sealing violation which kills the AssertFailureTest on runs against insane jar files.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@899819 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/client/org/apache/derby/client/net/DynamicByteArrayOutputStream.java",
"hunks": [
{
"added": [
" Derby - Class org.apache.derby.client.net.DynamicByteArrayOutputStream"
],
"header": "@@ -1,6 +1,6 @@",
"removed": [
" Derby - Class ... |
derby-DERBY-4496-685cec96 | DERBY-4496 Column list size mismatch with ORDER BY in INSERT statement
Fixed this issue which was due to missed occurences of RCL.size() that
now (with ORDER BY in subqueries) need to be generalized to
RCL.visibleSize to be able to ignore synthesized columns. Added a new
test case for the failing repro. Also wired the OrderByInSubqueries
test into the regression suite.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@896388 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/sql/compile/ResultColumnList.java",
"hunks": [
{
"added": [
" if ( (! countMismatchAllowed) &&",
" visibleSize() != nameList.visibleSize() )",
" \", nameList.visibleSize()... |
derby-DERBY-4499-33bfdc00 | DERBY-4499: Fix bug which prevented us from using UDTs as output args in database procedures.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@909415 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/sql/compile/StaticMethodCallNode.java",
"hunks": [
{
"added": [
"\t\t\t\t\t\tboolean isAnsiUDT = paramdtd.getTypeId().getBaseTypeId().isAnsiUDT();"
],
"header": "@@ -1162,6 +1162,7 @@ public class StaticMethodCallNode exten... |
derby-DERBY-4502-58806b97 | DERBY-4502: Make it possible to declare views against system tables
when authorization is enabled.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@896146 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/iapi/sql/dictionary/SchemaDescriptor.java",
"hunks": [
{
"added": [
"\tprivate String\t\t\taid;"
],
"header": "@@ -155,7 +155,7 @@ public final class SchemaDescriptor extends TupleDescriptor",
"removed": [
"\tp... |
derby-DERBY-4512-9b450ec3 | DERBY-4512: Avoid unnecessary lookup in transaction table when adding transaction
The transaction table should not contain a transaction with the same
id as the one that's added with TransactionTable.add(). Therefore, put
the new transaction in the table unconditionally instead of checking
first whether there is an existing entry to reuse. This saves one
lookup in the transaction table per transaction.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@900714 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/store/raw/xact/TransactionTable.java",
"hunks": [
{
"added": [
" TransactionTableEntry newEntry = new TransactionTableEntry(",
" xact, id, 0, exclude ? TransactionTableEntry.EXCLUDE : 0);",
"",
... |
derby-DERBY-4513-e671fc78 | DERBY-4513: Prevent NEXT VALUE FOR expressions from being used in various contexts.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@908627 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/iapi/sql/compile/CompilerContext.java",
"hunks": [
{
"added": [
"import org.apache.derby.iapi.sql.dictionary.SequenceDescriptor;"
],
"header": "@@ -33,6 +33,7 @@ import org.apache.derby.iapi.sql.ParameterValueSet;",
"rem... |
derby-DERBY-4514-4deb9812 | DERBY-4514 - j2ME test failures relating to RuntimeStatisticsParser;
now using org.apache.derbyTesting.junit.Utilities.split for JSR169
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@898638 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/testing/org/apache/derbyTesting/junit/RuntimeStatisticsParser.java",
"hunks": [
{
"added": [
" if (JDBC.vmSupportsJSR169())",
" {",
" // do something else then split.",
" String [] start... |
derby-DERBY-4515-d4953ddd | DERBY-4515: Document and clarify the use of DataValueDescriptor.setValue(InputStream,int)
Clarified and improved documentation for the setValue method.
Added a constant to represent unknown length.
Rewrote code in EmbedPreparedStatement to remove an unnecessary variable.
Patch file: derby-4515-1a-setValue_stream_clarification.diff
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@901648 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/iapi/types/DataValueDescriptor.java",
"hunks": [
{
"added": [
" /**",
" * Constant indicating that the logical length of a value (i.e. chars for",
" * string types or bytes for binary types) is unknown.",
... |
derby-DERBY-4519-1d0c179d | DERBY-4519: Infinite loop in StreamFileContainer.writeColumn
Fixed two issues;
- swapped offset and length arguments (removed them for the read-case)
- bounded the transfer buffer size, becuause InputStream.available() can
return both zero and a very high value. Size bounded by [64, 8192].
Patch file: derby-4519-2a-infinite_loop_fixes.diff
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@901165 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/store/raw/data/StreamFileContainer.java",
"hunks": [
{
"added": [
" // Set a reasonable buffer size.",
" // To avoid extremely inefficient reads, and an infinite loop when",
" // InputSt... |
derby-DERBY-4520-04acfa56 | DERBY-4520: Refactor and extend data type cloning facilities
Changed the cloneValue methods for BLOB and CLOB.
Noteworthy information:
- made BasicSortObserver force materialization when cloning
(required because it closes the underlying source result set).
- java.sql.[BC]lob values are assumed to be "clone-safe"
(i.e. more than one SQL[BC]lob object can reference them).
- in some cases invoking cloneValue(false) will result in a stream being
matieralized, because we don't know how to clone the stream otherwise.
A better future solution might be to use temporary disk storage instead.
- there's a TODO for implementing an optimization for small streams, where
Derby could choose to materialize the streams if the length is known.
This is only important for a few use-cases, but it avoids decoding the
stream data more than once.
Patch file: derby-4520-7b-lob_clonevalue_methods.diff
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@907732 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/iapi/types/SQLBlob.java",
"hunks": [
{
"added": [
"import org.apache.derby.iapi.services.io.CloneableStream;",
"import org.apache.derby.shared.common.sanity.SanityManager;",
""
],
"header": "@@ -24,8 +24,11 @... |
derby-DERBY-4520-1b454a1f | DERBY-4520 (partial): Refactor and extend data type cloning facilities
Added functionality to clone store streams (without materialization).
Delayed filling the byte buffer in OverflowInputStream constructor and in
OverflowInputStream.resetStream.
Orginal patch contributed by Mike Matrigali (mikem_app at sbcglobal dot net) as
part of DERBY-3650, modified by Kristian Waagan (Kristian dot Waagan at Sun dot com).
Patch file: derby-4520-3b-CloneableStream_and_delayed_fill.diff
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@902742 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/iapi/services/io/FormatIdInputStream.java",
"hunks": [
{
"added": [],
"header": "@@ -26,7 +26,6 @@ import java.io.IOException;",
"removed": [
"import org.apache.derby.iapi.reference.SQLState;"
]
},
{
... |
derby-DERBY-4520-55bc97fc | DERBY-4477 Selecting / projecting a column whose value is represented by a stream more than once fails
Patch derby-4477-lowmem-2, which adds test cases to check that lobs
are not materialized when large, for the use cases covered by this
issue. The test cases are added to the lowmem suite, which is not not
part of the regular suites.All. This commit is preparatory in that the
lobs are still small, so these changes should be revisited to change
their sizes when the cloning handles materialization properly, cf
DERBY-3650 and DERBY-4520.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@904538 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/testing/org/apache/derbyTesting/functionTests/util/streams/LoopingAlphabetReader.java",
"hunks": [
{
"added": [
" /**",
" * Reopen the stream.",
" */",
" public void reopen()",
" throws IOException {",
... |
derby-DERBY-4520-854dd109 | DERBY-4520 (partial): Refactor and extend data type cloning facilities
Renamed getClone to cloneValue and added the boolean argument 'forceMaterialization', whose default has been set to false.
Removed special handling of RowLocation in ValueRow.getNewNullRow.
Made constructors used for cloning private in SQLSmallInt and SQLTinyInt.
Added argument in constructor used for cloning in XML (whether to force materialization or not).
Removed some unused imports.
Note that the actual cloning-methods haven't been changed yet (expect changes in SQLBlob and SQLClob in a follow-up patch).
Patch file: derby-4520-5a-getClone_renamed_cloneValue.diff
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@906595 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/iapi/types/SQLBinary.java",
"hunks": [
{
"added": [
" return cloneValue(false);"
],
"header": "@@ -616,7 +616,7 @@ abstract class SQLBinary",
"removed": [
" return getClone();"
]
... |
derby-DERBY-4520-9902f436 | DERBY-4520: Refactor and extend data type cloning facilities
Removed unhelpful assert statements.
Added @see tags to copy JavaDoc from the interfaces.
Patch file: n/a
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@902798 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/iapi/services/io/FormatIdInputStream.java",
"hunks": [
{
"added": [
" /** @see Resetable#resetStream() */",
" /** @see Resetable#initStream() */",
" /** @see Resetable#closeStream() */",
" /** @see Clon... |
derby-DERBY-4520-a8bc2170 | DERBY-4520 (partial): Refactor and extend data type cloning facilities
RowLocation doesn't need to be cloned using CloneableObject.cloneObject,
clone using DataValueDescriptor.getClone instead.
This is the first step in the process to remove CloneableObject completely.
Patch file: derby-4520-1a-RowLocation_cloning.diff
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@901642 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/iapi/types/RowLocation.java",
"hunks": [
{
"added": [],
"header": "@@ -21,7 +21,6 @@",
"removed": [
"import org.apache.derby.iapi.types.DataValueDescriptor;"
]
}
]
},
{
"file": "java/engine/org/apache/d... |
derby-DERBY-4520-b4e2eb78 | DERBY-4520 (partial): Refactor and extend data type cloning facilities
Moved the method cloneObject into DataValueDescriptor, removed the
CloneableObject interface.
Changed cloneObject return type from Object to DataValueDescriptor.
Removed some unused imports.
Rewrote a few comments.
Patch file: derby-4520-2a-remove_CloneableObject_iface.diff
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@902050 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/iapi/store/access/BackingStoreHashtable.java",
"hunks": [
{
"added": [],
"header": "@@ -21,13 +21,8 @@",
"removed": [
"import org.apache.derby.iapi.services.sanity.SanityManager;",
"",
"import org.apache.derb... |
derby-DERBY-4520-d7aa7617 | DERBY-4520: Refactor and extend data type cloning facilities
Renamed cloneObject to cloneHolder.
Restructured SQLBinary.cloneHolder (behavior unchanged).
Brushed up some comments.
Patch file: derby-4520-4a-cloneObject_renamed_cloneHolder.diff
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@903150 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/sql/execute/TemporaryRowHolderImpl.java",
"hunks": [
{
"added": [
" /* Avoid materializing a stream just because it goes through a temp table.",
" * It is OK to have a stream in the temp table (in memory or spilled to",
... |
derby-DERBY-4524-9556e964 | DERBY-4524: Incorrect DROP FUNCTION logic in AccessTest's tearDown() method
Removed the tearDown() method since it did not do anything (DROP
FUNCTION would always fail with no connection) and was not
needed (a CleanDatabaseTestSetup decorator already took care of
dropping the function).
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@902288 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-4526-db26d0a6 | DERBY--5445 (Enhance existing concurrency test to stress sequence generators to also stress identity columns)
DERBY-4565 added a concurrency test to stress sequence generation. I am making simple modifications to that test to add identity column stress testing. Based on a command line parameter, the test will either do sequence generation testing or identity column testing. If no parameter is specified, it will default to doing sequene generation testing.
The test already takes number of parameters. One of those parameters is load options parameter. Load option parameter is indicated by -load_opts on command line and it is followed by a comma separated list of sub-parameters. An eg of load option parameter is as follows
-load_opts debugging=1,numberOfGenerators=5,tablesPerGenerator=10,insertsPerTransaction=100
I am adding another pair to the comma separated sub-parameters,namely identityTest=aNumber. If identityTest is 1, then the test will do identity column stress testing. For any other value for identityTest, the test will do sequence generation testing. If the user doesn't specify identityTest in load options, the test will perform sequence generation testing.
eg of asking the test to do identity column testing
java org.apache.derbyTesting.perf.clients.Runner -driver org.apache.derby.jdbc.EmbeddedDriver -init -load seq_gen -load_opts debugging=1,numberOfGenerators=5,tablesPerGenerator=10,insertsPerTransaction=100,identityTest=1 -gen b2b -threads 10
Two possible way of asking the test to do sequence generation testing(identityTest set to a value other than 1 or identityTest is not specified)
java org.apache.derbyTesting.perf.clients.Runner -driver org.apache.derby.jdbc.EmbeddedDriver -init -load seq_gen -load_opts debugging=1,numberOfGenerators=5,tablesPerGenerator=10,insertsPerTransaction=100,identityTest=2 -gen b2b -threads 10
OR
java org.apache.derbyTesting.perf.clients.Runner -driver org.apache.derby.jdbc.EmbeddedDriver -init -load seq_gen -load_opts debugging=1,numberOfGenerators=5,tablesPerGenerator=10,insertsPerTransaction=100 -gen b2b -threads 10
When I run the test for identity columns, I can consistently see it running into derby lock time out with nested sequencec contention error while trying to get current identity value and advancing(this is what we want to achieve from the test ie that it is able to stress the functionality enough to run into contention while trying to get next range for identity columns.) Additionally, there are some lock time out errors raised by store while trying to update system catalog(this is expected too because of multiple threads simulataneously trying to do inserts into a table with identity column). I also in my codeline reverted to changes before DERBY-5426 (DERBY-4526 is Improve the error raised by too much contention on a sequence/identity.) was fixed and saw sequence contention errors (without the lock time out error encapsulation).
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1179374 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/testing/org/apache/derbyTesting/perf/clients/Runner.java",
"hunks": [
{
"added": [
" System.out.print(\"initializing database for \");",
" System.out.println((Runner.getLoadOpt( \"identityTest\", 0 ) == 1)?",
" \t\t... |
derby-DERBY-4527-81d947f3 | DERBY-4527; create org.apache.derbyTesting.functionTests.harness.ibm17 class
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@904235 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/testing/org/apache/derbyTesting/functionTests/harness/ibm17.java",
"hunks": [
{
"added": [
"/*",
"",
" Derby - Class org.apache.derbyTesting.functionTests.harness.ibm17",
"",
" Licensed to the Apache Software Foundation (ASF... |
derby-DERBY-453-48e8f30a | DERBY-453 - Second checkin to add BigDecimalHandler
Contributed by Deepa Remesh
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@265043 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/testing/org/apache/derbyTesting/functionTests/util/BigDecimalHandler.java",
"hunks": [
{
"added": [
"/*",
"",
"Derby - Class org.apache.derbyTesting.functionTests.util",
"",
"Copyright 2005 The Apache Software Foundation or its ... |
derby-DERBY-4531-188fc76d | DERBY-4531 Client setCharacterStream closes its Reader argument stream in finalizer
Patch derby-4531b, which makes the client behave like embedded in this
respect.
It also adds a new test which shows the clients divergent behavior
prior to the fix in EncodedInputStream. Since the test relies on
explicit gc, it is not guaranteed to show the presence of the bug,
though.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@987331 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-4531-51826c3c | DERBY-4477 Selecting / projecting a column whose value is represented by a stream more than once fails
Follow-up patch for an intermittet bug caused by previous insert, due
to newly filed DERBY-4531: derby-4477-lowmem-followup.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@905621 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/testing/org/apache/derbyTesting/functionTests/util/streams/LoopingAlphabetReader.java",
"hunks": [
{
"added": [],
"header": "@@ -176,15 +176,6 @@ public class LoopingAlphabetReader",
"removed": [
" /**",
" * Reopen the stream.",
... |
derby-DERBY-4531-a1b56d7d | DERBY-4531: Client setCharacterStream closes its Reader argument stream in finalizer
Added a work-around for the issue where the SQLState differs depending on
whether the finalizer has been run or not.
Can be removed when DERBY-4531 has been fixed properly.
Patch file: derby-4531-1a-test_workaround.diff
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@938972 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-4538-f246c9c6 | DERBY-4538
Committing patch DERBY4538_NoReferencingClause_diff_v2.txt attached to jira DERBY-4538(removed redundant ; as pointed by Knut).
This changes the UPDATE and DELETE statement codes to be little bit smarter when they decide what columns should be part of the read map. Currently, as soon as these 2 nodes find that there are relevant triggers on the table, we decide to read all the columns from the table. With the patch, we will check if all the relevant tiggers have missing REFERENCING clause. If yes, then do not need to read all the columns. Just the columns needed by the UPDATE/DELETE statement. This will get rid of OOM we run into when the table has LOB columns BUT only in the case when the UPDATE/DELETE statement does not reference the LOB column and all the triggers defined on them have missing REFERENCING clause. I have enabled the TriggerTests in lowmem suite with the missing REFERENCING clause cases enabled. For all the other test cases, I simply return from those test cases without actually testing it because we do not have fix for those cases yet. The lowmem suite does not get run regularly and when it is run, as the name indicates, it runs with limited heap. I wanted us to be able to run these tests with default heap as well. To achieve that, I am including the TriggerTests in lang suite too.
The INSERT table with INSERT triggers work fine already without my changes as long as the INSERT statement does not reference the LOB column.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@917771 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/sql/compile/DeleteNode.java",
"hunks": [
{
"added": [
"import org.apache.derby.iapi.sql.dictionary.TriggerDescriptor;"
],
"header": "@@ -33,6 +33,7 @@ import org.apache.derby.iapi.sql.dictionary.TableDescriptor;",
"... |
derby-DERBY-4539-3b77ab83 | DERBY-4539: Make it possible to state the optional clauses of the CREATE SEQUENCE statement in an order.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@909633 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-4540-c2118336 | DERBY-4540 AssertionFailedError in store.AccessTest.testCS4595B_UniqueIndex(AccessTest.java:1729)' on SUSE Linux / IBM JIT - r9
This change just adds some diagnostic print out to the assert that seems
to be intermittently failing. Next time we should see the number of pages
expected and the full dump of the statistics output the test is getting when
it gets this failure.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1233098 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-4542-b173580e | DERBY-4542: Avoid materialization where possible when cloning CollatorSQLClob
Made CollatorSQLClob able to clone itself without materializing the value
(doesn't apply in all cases, sometimes we are forced to materialize because
it is requested to do so, or because we don't know how to clone the underlying
value).
Patch file: derby-4542-1a-avoid_materialization.diff
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@910200 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/iapi/types/CollatorSQLClob.java",
"hunks": [
{
"added": [
" if (forceMaterialization) {",
" try {",
" return new CollatorSQLClob(getString(),",
" holderForCollati... |
derby-DERBY-4543-d92fa8c6 | DERBY-4543: CLOB values incorrectly stored on disk using the old header format
Aadded missing !-operator in EmbedPreparedStatement.
Replaced DD_VERSION_CURRENT with DD_VERSION_DERBY_10_5.
Renamed several methods and variables (stop using soft-upgrade mode term, use stream header format instead).
Patch file: derby-4543-1a-clob_hdr_format_fix.diff
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@908418 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/iapi/types/ClobStreamHeaderGenerator.java",
"hunks": [
{
"added": [
" * which header format should be used. This is currently only determined by",
" * consulting the data dictionary about the version."
],
"head... |
derby-DERBY-4544-961ecca2 | DERBY-4544: Don't use the SQLClob.getLength() optimization on non-resetable streams--this fixes a data corruption.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1091169 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-4545-36461a87 | DERBY-4545: Fix UDTTest to run cleanly on small devices.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@909123 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-4551-1eeea613 | DERBY-4551 Allow database user to execute stored procedures with same permissions as database owner and/or routine definer
Follow-up patch derby-4551-followup-1b (plus some small hygiene adjustments).
The problem is that the substatement executed as part of
ResultSet.{insertRow, updateRow,deleteRow} pushes a new statement
context. This statement context is consulted when constructing the
activation for the substatement, to see if the activation shall have a
parent activation (which is used to get the correct SQL session
context),
cf. GenericLanguageConnectionContext#getCurrentSQLSessionContext.
However, the newly pushed statement context was missing its parent's
activation, so the substatement instead get the top level session
context, whose current user is not the DEFINER bur rather the session
user. cf BaseActivation#setupSQLSessionContextForChildren, hence the
authorization error.
The patch makes sure the nested statement context initially gets the
(new) parent context set.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@999570 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/jdbc/EmbedResultSet.java",
"hunks": [
{
"added": [
" StatementContext currSC = lcc.getStatementContext();",
" Activation parentAct = null;",
"",
" if (currSC != nul... |
derby-DERBY-4551-9f601725 | DERBY-4551 Allow database user to execute stored procedures with same permissions as database owner and/or routine definer
Patch derby-4551-4, which implements the specification attached to
this issue for executing routines with definer's right, and also adds
tests for this feature. A separate issue has been filed for
documentation changes needed.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@952227 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/catalog/types/RoutineAliasInfo.java",
"hunks": [
{
"added": [
" /** Mask for the SECURITY INVOKER/DEFINER field */",
" private static final short SECURITY_DEFINER_MASK = (short) 0x20;",
""
],
"header": ... |
derby-DERBY-4553-574d8e1f | DERBY-4553: In ij GETCURRENTROWNUMBER directly writes its result to output
Patch contributed by Sylvain Leroux <sylvain@chicoree.fr>
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@911952 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/tools/org/apache/derby/impl/tools/ij/ijVectorResult.java",
"hunks": [
{
"added": [
" * This is an impl for a simple Vector of objects."
],
"header": "@@ -25,7 +25,7 @@ import java.util.Vector;",
"removed": [
" * This is an impl for a ... |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.