id stringlengths 22 25 | commit_message stringlengths 137 6.96k | diffs listlengths 0 63 |
|---|---|---|
derby-DERBY-5488-ff025760 | DERBY-5488: Make setObject( int, BigInteger ) rely on the existing setObject( int, BigDecimal ) logic.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1197172 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/jdbc/EmbedPreparedStatement20.java",
"hunks": [
{
"added": [
"import java.math.BigInteger;"
],
"header": "@@ -32,6 +32,7 @@ import org.apache.derby.iapi.reference.SQLState;",
"removed": []
}
]
}
] |
derby-DERBY-5489-bde7b3b8 | DERBY-5489: getBinary() returns incorrect data after getObject() call on BLOB column
o Added missing check to getObject on LOB columns in the client driver.
o Added new checks to getBytes/getString for LOB columns in both drivers,
which stands out from the rest of the getters because invoking them multiple
times on a LOB column is allowed (this is an exception to the rule).
o Added two new tests which verifies that the data return when invoking the
mentioned getters multiple times returns correct data, including when you
first invoke getBytes/getString and then invoke one of the other valid
getters for LOB columns. Some refactoring of LobRsGetterTest.
o Adjusted access pattern in UpdatableResultSetTest to comply with the rules.
At a later time it may be possible to lift this restriction on LOB columns.
Patch file: derby-5489-2b-fixes.diff
--This line, and tose below, will be ignored--
M java/testing/org/apache/derbyTesting/functionTests/tests/jdbcapi/LobRsGetterTest.java
M java/testing/org/apache/derbyTesting/functionTests/tests/jdbcapi/_Suite.java
M java/testing/org/apache/derbyTesting/functionTests/tests/lang/UpdatableResultSetTest.java
M java/client/org/apache/derby/client/am/ResultSet.java
M java/engine/org/apache/derby/impl/jdbc/EmbedResultSet.java
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1330681 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/client/org/apache/derby/client/am/ResultSet.java",
"hunks": [
{
"added": [
" int type = resultSetMetaData_.types_[column - 1];",
" if (type == Types.BLOB || type == Types.CLOB) {",
" checkLOBMultiCall(column);",... |
derby-DERBY-5489-f6c58c8c | DERBY-5489: getBinary() returns incorrect data after getObject() call on BLOB column
Added a test for the expected behavior of valid getters invoked on LOB columns.
A restriction has been put in place to allow for only one getter invocation on
a given field, with the possible exception of getBytes and getString (iff
invoked as the first getter on the field).
Patch file: derby-5489-1b-test.diff
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1329186 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-5490-514ee1dc | DERBY-5490: Fix the spawning of network servers on the OpenJDK 7 preview on Mac OS X.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1197563 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-5492-e8afaebf | DERBY-5492 Restrictive file permissions: permissions removed also for owner on NTFS if Acl does not contain explicit entry for owner
Patch derby-5492-2 which solves this issue plus make one other
adjustment, see item two below.
- Construct a new AclEntry for the owner with all rights, and removed
existing ones (NTFS). This should handle the error seen in Oracle's
regressions.
- For Solaris/ZFS and similar file systems which support both Posix
file attributes view and ACLs, don't touch the ACLs but stick to the
Posix flags.
For the latter my rationale is as follows: Principle of least
surprise: most users never touch the ACLs but use the more familiar
Posix file masks. It turned out the existing Derby implementation,
although protecting the file adequately, showed a "+" in the ls(1)
listing indicating that the settings could not be directly mapped
onto the Posix model. The reason was that we removed more permissions
than the plain read,write, and execute. Since ZFS internally builds
on ACLs, the ls(1) listing would should that Derby had been tinkering
with the non-mappable ACL permissions. I think it is better to stick
to the Posix permissions by default. If people are using ACL
functionality they are likely more than average concerned with
security and can run with default file permissions and take full
responsibility of the permissions fo created filed.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1199673 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/iapi/services/io/FileUtil.java",
"hunks": [
{
"added": [
"import java.util.Arrays;",
"import java.util.HashSet;",
"import java.util.Set;"
],
"header": "@@ -38,8 +38,10 @@ import org.apache.derby.io.StorageFil... |
derby-DERBY-5493-5705f5bf | DERBY-5494
Prior to this fix the nested user update transaction used by sequence updater
was doing a "lazy" commit, where the log record for the commit waw written
to the stream but not forced to disk. It would get forced to disk by any
subsequent user transaction commit.
Changed system to default doing a real commit for all nested user update
transactions, and those that don't need that behavior should use commitNoSync().
Changed identity columns to use the commitNoSync() to keep same performance
for those operations.
Includes the test contributed by rickh as part of DERBY-5493 change.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1327218 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/sql/execute/InsertResultSet.java",
"hunks": [
{
"added": [],
"header": "@@ -786,7 +786,6 @@ class InsertResultSet extends DMLWriteResultSet implements TargetResultSet",
"removed": [
""
]
},
{
"ad... |
derby-DERBY-5493-810f2b96 | DERBY-5493: Boost the size of preallocated sequence ranges from 20 to 100 in order to boost concurrency.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1327682 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-5493-8e352d60 | DERBY-5493: Fix correctness problem with sequences by introducing syscs_peek_at_sequence and simplifying the SequenceUpdater code.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1327471 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/sql/catalog/DataDictionaryImpl.java",
"hunks": [
{
"added": [
" private HashMap sequenceIDs;",
" "
],
"header": "@@ -418,7 +418,8 @@ public final class\tDataDictionaryImpl",
"removed": [
""... |
derby-DERBY-5494-5705f5bf | DERBY-5494
Prior to this fix the nested user update transaction used by sequence updater
was doing a "lazy" commit, where the log record for the commit waw written
to the stream but not forced to disk. It would get forced to disk by any
subsequent user transaction commit.
Changed system to default doing a real commit for all nested user update
transactions, and those that don't need that behavior should use commitNoSync().
Changed identity columns to use the commitNoSync() to keep same performance
for those operations.
Includes the test contributed by rickh as part of DERBY-5493 change.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1327218 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/sql/execute/InsertResultSet.java",
"hunks": [
{
"added": [],
"header": "@@ -786,7 +786,6 @@ class InsertResultSet extends DMLWriteResultSet implements TargetResultSet",
"removed": [
""
]
},
{
"ad... |
derby-DERBY-5494-ceaf7dfd | DERBY-5494 Same value returned by successive calls to a sequence generator flanking an unorderly shutdown.
DERBY-5780 identity column performance has degredated
The previous patch for DERBY-5494 had the unintended affect of forcing a
synchronous write for all nested user transactions at abort time. This
in turn caused identity column inserts to have one synchronous write per
insert as the nested user transaction is destroyed for each insert which
does an abort each time.
To solve this interfaces were changed so that calling code could set the
default commit sync behavior when the transaction was committed rather than
count on the "type" of transaction. Nested user transactions used for identity
columns have default set to not sync, and the rest of the nested user transactions
default to syncing. Behavior of other types of transactions should not
be affected. User transactions still sync by default and internal and ntt's still
default to not sync.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1344065 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/iapi/store/raw/RawStoreFactory.java",
"hunks": [
{
"added": [
" @param flush_log_on_xact_end By default should the transaction ",
" commit and abort be synced to the log. Normal usage should pick true, ",
"... |
derby-DERBY-5496-eddb67d3 | DERBY-5496: Compile the JUnit infrastructure package against the small device classpath, rather than the jdk 1.4 classpath.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1199234 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/testing/org/apache/derbyTesting/junit/JDBC.java",
"hunks": [
{
"added": [
"import java.lang.reflect.Method;"
],
"header": "@@ -20,6 +20,7 @@",
"removed": []
},
{
"added": [
" String tmpstr = (String)o;",... |
derby-DERBY-5498-abf8151c | DERBY-5498 ClosedByInterruptException in AuthenticationTest
Patch d5498b plugs a hole in the handling of NIO channel closures due
to interrupt in DirFile4#getExclusiveFileLock.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1200995 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/io/DirFile4.java",
"hunks": [
{
"added": [
"import java.nio.channels.AsynchronousCloseException;",
"import java.nio.channels.ClosedChannelException;",
"import org.apache.derby.iapi.util.InterruptStatus;"
],
... |
derby-DERBY-550-7d6219fc | - DERBY-1535 Trial 2 for DERBY-550, improve use of Engine from NetworkServer and reduce memory usage - Replacing call of setByte() to call of setBinaryInputStream(), which was room to improvement in DERBY-1559. - Patch by Tomohito Nakayama (tomonaka@basil.ocn.ne.jp)
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@465249 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/drda/org/apache/derby/impl/drda/DRDAConnThread.java",
"hunks": [
{
"added": [
"\t\t\t\t\t\t\t",
" if ( paramBytes==null ) {",
"\t\t\t\t\t\t\t\tps.setBytes(i+1, ",
" nul... |
derby-DERBY-5504-19a48ec5 | DERBY-5504: Prepare replication tests for spaces in path names
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1203605 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-5504-bdd8f6d6 | DERBY-5504: Use execJavaCmd() in SecureServerTest and Driver40UnbootedTest
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1203113 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-5507-006b542c | DERBY-5507: Orderly shutdown fails if you are using BUILTIN authentication and turn on derby.database.propertiesOnly
Make sure passwords are mapped to a hashed token before they are stored
in the database, also if the password is already defined in a system
property.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1220685 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/iapi/services/property/PropertyValidation.java",
"hunks": [
{
"added": [
"\t\t\t\t\tif (mappedValue == null)",
" \t\t\t\t\t\tmappedValue = psc.map(key, value, d);",
""
],
"header": "@@ -61,6 +61,9 @@ public c... |
derby-DERBY-5509-3f9d8123 | DERBY-5509; javadoc for NetServlet and NetworkServerControl are missing a few closing tags
adding the missing tags.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1204128 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/drda/org/apache/derby/drda/NetServlet.java",
"hunks": [
{
"added": [
"\t<LI><PRE>portNumber</PRE> - Port number to use. The default is 1527.</LI>",
"\t\t\tinitialization if 'true'.</LI>",
"\t<LI><PRE>tracingDirectory</PRE> - Directory for trace fil... |
derby-DERBY-551-cec114ad | DERBY-551 (partial) Adds more comments to InternalTriggerExecutionContext.validateStatement.
Patch submitted by Deepa Remesh
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@421920 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/sql/execute/InternalTriggerExecutionContext.java",
"hunks": [
{
"added": [
"\t\t// DDL statements are not allowed in triggers. Parser does not allow ",
"\t\t// DDL statements in a trigger's action statement. This runtime check",
... |
derby-DERBY-5514-dcfc481b | DERBY-5514 SecureServerTest (and others) don't play nice with EMMA: AccessControlException
Patch derby-5514-2:
- fixes the usa of String#contains,
- adds -Demma.verbosity.level=silent to RuntimeInfoTest
- adds the convenience method runsWithEmma to BaseTestCase
- adds fixes to NetworkServerTestSetup to
a) always use Emma verbosity silent when spawning a server in separate VM, and also
b) refrains from starting the server with the security manager when running with Emma since the default server policy doesn't contain permissions for Emma, and finally
- skips the assertion for the security manager being used in
SecureServerTest (it is not, see preceding item)
With patch d5514-emma-permissions-to-all, Emma now runs OK with "ant
emma-all" and suites.All.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1207471 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/testing/org/apache/derbyTesting/junit/NetworkServerTestSetup.java",
"hunks": [
{
"added": [
" al.add( \"-Demma.verbosity.level=silent\" );",
" // Loading from classes need to work-around the limitation of the",
" // default pol... |
derby-DERBY-5517-d109dede | DERBY-5517: testReplication_Local_3_p1_StateNegativeTests failed with connection refused
Make sure server processes in one test case have stopped before the next
test case is started.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1213251 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-552-5a159416 | DERBY-552 Fix fetching resources from an installed jar when the database itself is a jar file.
The old code did not handle the case when the length of the resource (jar) entry was unknown.
New code reads the resource from the JarInputStream into a local byte array and returns a
stream based upon that to the application. This also provides better isolation between
the application and derby, denying user code the ability to read the entire jar or
to prevent correct shutdown of the database. Added utilities to AccessibleByteArrayOutputStream
to enable copying an InputStream into a local array.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@483653 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/iapi/services/io/AccessibleByteArrayOutputStream.java",
"hunks": [
{
"added": [
"import java.io.IOException;",
"import java.io.InputStream;"
],
"header": "@@ -22,6 +22,8 @@",
"removed": []
}
]
},
... |
derby-DERBY-5521-81923add | DERBY-5521 JDBCMBeanTest#testAttributeDriverLevel uses Java assert in lieu of JUnit assert: no real testing happens
Patch derby-5521b which fixes this issue.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1211266 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-5526-c8afd4ff | DERBY-5526 on upgrade from 10.5 to 10.8.2 , getting ERROR XBM0A: The database directory 'C:\cygwin\home\debugfat\clientdb' exists.
However, it does not contain the expected 'service.properties' file.
Change to only throw this message if there is a seg0 directory so this looks
like a partially created database
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1212541 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-5530-f74cf7a6 | DERBY-5530: SQLChar.getCollationKey NPE in index-stat-thread
Propagate collation information to the new indexes on TRAUNCATE TABLE.
Patch file: derby-5530-1a-propagate_collation_info.diff (trivially modified)
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1243878 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/sql/execute/AlterTableConstantAction.java",
"hunks": [
{
"added": [],
"header": "@@ -86,7 +86,6 @@ import org.apache.derby.iapi.types.DataValueDescriptor;",
"removed": [
"import org.apache.derby.impl.sql.catalog.DDColumnDep... |
derby-DERBY-5531-66ed1016 | DERBY-5531 Assert failure when inserting NULL into indexed column with territory-based collation
At bind time of insert node, we go through the individual columns in the insert statement to determine if there is a need for normalization or not. In case if the insert resultset has all null values, we conclude that we do not need normalization. At execution time, as part of normalization, the data type conversion from datatypes like SQLVarchar to CollatorSQLVarchar will happen if we are dealing with territory based database. But this never happens if insert resultset has all null values and hence a later assert check in OpenBTree fails because the datatypes do not match(in the example given in this jira, SQLVarchar and CollatorSQLVarchar mismatch at runtime will cause an assert failure). Here is the relevant code in InsertNode.bindStatement()
/* Insert a NormalizeResultSetNode above the source if the source
* and target column types and lengths do not match.
*/
if (! resultColumnList.columnTypesAndLengthsMatch(
resultSet.getResultColumns()))
{
resultSet =
(ResultSetNode) getNodeFactory().getNode(
C_NodeTypes.NORMALIZE_RESULT_SET_NODE, resultSet,
resultColumnList, null, Boolean.FALSE,
getContextManager());
}
To fix this problem, we are changing OpenBTree.isIndexableRowConsistent to not throw an assert failure if dealing with null values. If the value is null, then we will not assert the column datatypes. As it is, this method is meaningful only in sane mode. Insane jars do not give any error for the test case provided in the jira because assertion only happens with sane jars.
In short, the fix is, if the row column's value is null, then don't worry about the data type match at execution time.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1378206 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-5534-841c8990 | DERBY-5546 ResultSet#updateBigDecimal on a REAL column does not do underflow checking
Patch derby-5546-2. For both Real and Double, check for underflow. For
Double underflow is currently detected but only because we didn't fix
DERBY-3398 yet, so we introduce the same check now as for Real. Once
DERBY-3398 it will no longer be redundant. The tests are still guarded
by a check for embedded until DERBY-5534 is fixed.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1447996 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/iapi/types/SQLDouble.java",
"hunks": [
{
"added": [
"import java.math.BigDecimal;"
],
"header": "@@ -36,6 +36,7 @@ import java.io.ObjectOutput;",
"removed": []
}
]
},
{
"file": "java/engine/org/apache/d... |
derby-DERBY-5535-2d622c69 | DERBY-5535 Remove unused methods from client's CrossConverters class
Patch derby-5535 removes the unused methods.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1214423 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/client/org/apache/derby/client/am/CrossConverters.java",
"hunks": [
{
"added": [],
"header": "@@ -973,10 +973,6 @@ final class CrossConverters {",
"removed": [
" final boolean getBooleanFromBigDecimal(java.math.BigDecimal source) throws SqlException... |
derby-DERBY-5536-34197480 | DERBY-5536 Client's ResultSet#getLong does not range check when converting from a DECIMAL column
Patch derby-5536-3, which fixes this issue and adds new tests. It
changes the implementation of am.Decimal#getLong to allow it to detect
overflow. If the number of digits indicate it can't happen, we use an
optimized path.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1229082 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/client/org/apache/derby/client/am/Cursor.java",
"hunks": [
{
"added": [
" private final long getLongFromDECIMAL(int column, String targetType) ",
" throws SqlException {",
" } catch (ArithmeticException e) {",
" ... |
derby-DERBY-5536-b40d7705 | DERBY-5536 Client's ResultSet#getLong does not range check when converting from a DECIMAL column
Followup patch "derby-5536-refactor" factors out the test cases for
DERBY-5536 into a separate fixture, adding "ORDER BY" to secure
correct row retrieval order.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1229481 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-5539-1ede0a8c | DERBY-5539: Harden password hashing in the builtin authentication service
Add random salt before hashing the credentials, and apply the hash
function multiple times.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1221666 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/jdbc/authentication/AuthenticationServiceBase.java",
"hunks": [
{
"added": [
"import java.security.SecureRandom;"
],
"header": "@@ -55,6 +55,7 @@ import java.security.NoSuchAlgorithmException;",
"removed": []
... |
derby-DERBY-5539-dcd69d38 | DERBY-5539: Harden password hashing in the builtin authentication service
Always generate a hashed token, also if there is no user with the
specified user name. This way, authentication failures take the same
amount of time regardless of the user's existence, which will make it
harder for attackers to tell whether a user exists.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1292704 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/jdbc/authentication/AuthenticationServiceBase.java",
"hunks": [
{
"added": [
" /**",
" * Get all the database properties.",
" * @return the database properties, or {@code null} if there is no",
" ... |
derby-DERBY-5540-379e4cc2 | DERBY-5540: Call initCause() and getCause() without reflection in BaseJDBCTestCase
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1220669 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-5541-c14b3d44 | DERBY-5541: Remove unnecessary field rwsOK in DirStorageFactory4
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1220670 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/io/DirFile4.java",
"hunks": [
{
"added": [
" DirFile4(String path)"
],
"header": "@@ -50,17 +50,14 @@ class DirFile4 extends DirFile",
"removed": [
"\tprivate final boolean rwsOK;",
"",
... |
derby-DERBY-5542-4e1ac797 | DERBY-5542: Remove checks for Java version being greater than or equal to 1.4
No older versions are supported.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1220671 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/jdbc/EmbedXAResource.java",
"hunks": [
{
"added": [],
"header": "@@ -36,7 +36,6 @@ import org.apache.derby.iapi.jdbc.ResourceAdapter;",
"removed": [
"import org.apache.derby.iapi.services.info.JVMInfo;"
]
}
]
... |
derby-DERBY-5546-841c8990 | DERBY-5546 ResultSet#updateBigDecimal on a REAL column does not do underflow checking
Patch derby-5546-2. For both Real and Double, check for underflow. For
Double underflow is currently detected but only because we didn't fix
DERBY-3398 yet, so we introduce the same check now as for Real. Once
DERBY-3398 it will no longer be redundant. The tests are still guarded
by a check for embedded until DERBY-5534 is fixed.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1447996 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/iapi/types/SQLDouble.java",
"hunks": [
{
"added": [
"import java.math.BigDecimal;"
],
"header": "@@ -36,6 +36,7 @@ import java.io.ObjectOutput;",
"removed": []
}
]
},
{
"file": "java/engine/org/apache/d... |
derby-DERBY-5547-65246387 | DERBY-5547: NSSecurityMechanismTest.testNetworkServerSecurityMechanism() fails intermittently
Wait for previous network server to stop before starting a new one.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1222155 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/testing/org/apache/derbyTesting/junit/NetworkServerTestSetup.java",
"hunks": [
{
"added": [
"import java.net.UnknownHostException;"
],
"header": "@@ -26,6 +26,7 @@ import java.io.FileOutputStream;",
"removed": []
},
{
"added... |
derby-DERBY-5552-3fe22817 | DERBY-5552 Derby threads hanging when using ClientXADataSource and a deadlock or lock timeout occurs
Code patch contributed by Brett Bergquist - brett at thebergquistfamily dot com
Derby will no longer null out the connection on lock timeout or deadlock.
I added test to verify proper behavior for the conneciton and transaction
state after the lock timeout occurs.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1293494 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/testing/org/apache/derbyTesting/junit/Utilities.java",
"hunks": [
{
"added": [
" } ",
" System.out.println(\"};\\n\");"
],
"header": "@@ -137,10 +137,9 @@ public class Utilities {",
"removed": [
" ... |
derby-DERBY-5553-537fdabe | DERBY-5553 System property for client tracing -Dderby.client.traceDirectory does not work with XADataSource
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1518766 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/client/org/apache/derby/jdbc/ClientBaseDataSourceRoot.java",
"hunks": [
{
"added": [
" if (traceDirectoryString == null && properties != null) {"
],
"header": "@@ -425,7 +425,7 @@ public abstract class ClientBaseDataSourceRoot implements",
... |
derby-DERBY-5554-01c7acbe | DERBY-5554: Add a trailing tableid column to the SPACE_TABLE vti.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1351714 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/diag/SpaceTable.java",
"hunks": [
{
"added": [
"\t<LI>TABLEID char(36) - not nullable. The UUID of the table.</LI>"
],
"header": "@@ -91,6 +91,7 @@ import org.apache.derby.vti.VTIEnvironment;",
"removed": []
},
... |
derby-DERBY-5554-271e7dd1 | DERBY-5554: Add 0-arg constructor to SPACE_TABLE vti.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1351795 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/diag/SpaceTable.java",
"hunks": [
{
"added": [
" public SpaceTable() {}"
],
"header": "@@ -116,6 +116,7 @@ public class SpaceTable extends VTITemplate implements VTICosting {",
"removed": []
}
]
},
{
... |
derby-DERBY-5554-3c065e9b | DERBY-5554: Forbid the joining of VTIs to one another in the FROM list.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1357692 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-5554-60dc440d | DERBY-5554: Allow multiple tables in FROM lists which join tables to VTI arguments.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1360306 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/sql/compile/FromVTI.java",
"hunks": [
{
"added": [
" // for remapping column references in VTI args at code generation time",
" private HashMap argSources = new HashMap();",
""
],
"header": "@@ -11... |
derby-DERBY-5559-5e1c7a74 | DERBY-5559 AssertFailures (7, or 8) with ibm 1.6 and 1.5 on Windows XP in lang.NativeAuthProcs fixture testAll
This change just adds explicit printout in the tests when the asserts fail,
it does not fix the test failures.
I added them to the 4 places I saw them failing in nightly runs as reported
in the apache nightly test run site for the following report:
http://people.apache.org/~myrnavl/derby_test_results/main/windows/testlog/ibm15/1227449-suites.All_diff.txt
All the problem areas are asserts based on timestamps and the tests seem to
be waiting for some time such that these asserts will be true. My guess is
that this methodology is not portable with the current values and may need to
be tuned more to work across all JVMs and hardware.
I am seeing errors on a XP laptop running ibm jvm 16.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1228537 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-5559-a1ac6747 | DERBY-5559 AssertFailures (7, or 8) with ibm 1.6 and 1.5 on Windows XP in lang.NativeAuthProcs fixture testAll
Adding longer waits and some additional waits to fix problems on my laptop with
this test. Before this change the test would expect the timestamp to have
moved forward after some password manipulation operations, but instead the
timestamp would be the same as before. I believe this is just a problem with
the known issue of JVM/machine caching of time, and not an actual problem
with the password mechanism.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1229835 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-5560-b4177107 | DERBY-5560 Java deadlock between LogicalConnection40 and ClientXAConnection40
Patch contributed by Brett Bergquist
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1513218 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/client/org/apache/derby/client/am/LogicalConnection.java",
"hunks": [
{
"added": [
" public void close() throws SQLException {",
" // The pooledConnection owns this LogicalConnection. To ensure that",
" // there is no deadlock wh... |
derby-DERBY-5561-06a9c554 | DERBY-5561: Race conditions in LogicalConnection checking for a null physical connection
Changes:
o converted docs to Javadoc
o removed stale doc
o corrected/improved some comments
o made physicalConnection_ package-private
o made checkForNullPhysicalConnection final
Patch file: derby-5561-2a-minor_cleanups.diff
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1334919 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/client/org/apache/derby/client/am/LogicalConnection.java",
"hunks": [
{
"added": [
"/**",
" * A simple delegation wrapper handle for a physical connection.",
" * <p>",
" * All methods of the {@code Connection} interface are forwarded to t... |
derby-DERBY-5561-5e39436e | DERBY-5561: Race conditions in LogicalConnection checking for a null physical connection
Made methods calling checkForNullPhysicalConnection synchronized.
Patch contributed by Brett Bergquist (brett at thebergquistfamily dot com).
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1333305 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/client/org/apache/derby/client/am/LogicalConnection.java",
"hunks": [
{
"added": [
" synchronized public String nativeSQL(String sql) throws SQLException {"
],
"header": "@@ -197,7 +197,7 @@ public class LogicalConnection implements java.sql.Connect... |
derby-DERBY-5562-152986e7 | DERBY-5562: A read-only XA transaction that has a timeout never has the timer canceled when the transaction is complete
Cancel the timer when a read-only transaction is prepared and implicitly committed.
Based on a fix contributed by Brett Bergquist.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1230480 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/jdbc/XATransactionState.java",
"hunks": [
{
"added": [
"import org.apache.derby.iapi.store.access.XATransactionController;"
],
"header": "@@ -33,6 +33,7 @@ import org.apache.derby.iapi.services.context.ContextImpl;",
"re... |
derby-DERBY-5564-c9ef1664 | DERBY-5564 Code does different things depending if derby.locks.deadlockTrace=true is set
original patch by Brett Bergquist, then modified by Mike Matrigali for submission.
Changes the code to always return 40XL1 as the SQL state when a lock timeout
occurs. Previous to this change if deadlock diagnostics were enabled then
40X02 would be returned. Internally multiple places in the code was not
expecting the second error code for a lock timeout. Also it was agreed that
it was confusing for user applications to have to code for both states in
case they wanted to turn diagnostics on and off.
Existing test cases were changed to match the new expected behavior.
The behavior in DDLConstantaction to immediately throw an error on first try
if a lock timeout is encounted with diagnostics enabled was preserved. The
error thrown now will be with sql state 40XL1 and not 40X02 as before.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1230100 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/iapi/sql/dictionary/SPSDescriptor.java",
"hunks": [
{
"added": [
"\t\t\t\t// First try compiling in a nested transaction so we can ",
" // release the locks after the compilation, and not have them",
" ... |
derby-DERBY-5565-b0902f14 | DERBY-5565 Network Server should reject client connections that are not Derby Network Client.
We now reject all PRDID's that do not start with DNC.
The protocol tests have been changed to use the DNC10090 PRDID instead of TST01000. This actually alters the code path where there is slightly different behavior in later derby client versions, so that we have to skip an additional dss on connect for the diagnostic information.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1336268 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/drda/org/apache/derby/impl/drda/AppRequester.java",
"hunks": [
{
"added": [
""
],
"header": "@@ -35,8 +35,7 @@ class AppRequester",
"removed": [
"\tprotected static final int JCC_CLIENT = 1;",
"\tprotected static final int C... |
derby-DERBY-5567-398a0430 | DERBY-5567 AlterTableTest#testDropColumn fails: drop view cannot be performed due to dependency
When a view (b) is defined on another view (a), dropping a column in
the base table can lead to both view being invalidated. This patch
(DERBY-5567-1) fixes a problem in the logic:
Depending on the order in which dependencies of the base table column
are registered, the invalidation will happen either view a or view b.
If it happens on view a first, this view in turn will try to
invalidate view b (since that depends on view a), but with the
DROP_VIEW action which fails. The patch changes this recursive
invalidation to use the original action, e.g. DROP_COLUMN which will
allow dropping the dependent view (dropping a column is allowed to
cause cascading drops of dependent views).
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1239898 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/iapi/sql/dictionary/ViewDescriptor.java",
"hunks": [
{
"added": [
"import org.apache.derby.impl.sql.depend.BasicDependencyManager;"
],
"header": "@@ -35,6 +35,7 @@ import org.apache.derby.iapi.services.sanity.SanityManager;",
... |
derby-DERBY-5568-3e52818d | DERBY-5568: AssertionFailedError: Should not hold locks after commit in ResultSetMiscTest
Wait for post-commit work to complete before checking lock table.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1229066 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-557-76ddb614 | DERBY-557 Added a test case for DERBY-557. Submitted by Knut Anders Hatlen
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@377998 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-557-90f16141 | DERBY-557
Client driver gets OutOfMemoryError when re-executing statement without closing ResultSet
Attached a patch which fixes the bug. The patch ensures that the ResultSets associated with a Statement/PreparedStatement are removed from CommitAndRollbackListeners_ in org.apache.derby.client.am.Connection when the statement is re-executed.
I have run derbyall with only one error (wrong length of encryption key, not related to the patch). I have also run the program in the problem description (both with Statement and PreparedStatement), and the memory usage doesn't increase over time.
Contributed by Knut Anders Hatlen
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@289539 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/client/org/apache/derby/client/am/ResultSet.java",
"hunks": [
{
"added": [
" markClosed(true);"
],
"header": "@@ -388,8 +388,7 @@ public abstract class ResultSet implements java.sql.ResultSet,",
"removed": [
" ma... |
derby-DERBY-557-cff2860a | DERBY-210 - Network Server will leak prepared statements if not explicitly closed by the user until the connection is closed
I am uploading a combined patch 'derby-210.diff' which solves the memory leak. As Bryan suggested, I am uploading this patch and will open jira issues for other optimizations. Patch does the following:
* Eliminates the below references to PreparedStatement objects by using WeakHashMap instead of LinkedList. When there are no other references to the keys in a WeakHashMap, they will get removed from the map and can thus get garbage-collected. They do not have to wait till the Connection object is collected.
- 'openStatements_' in org.apache.derby.client.am.Connection
- 'CommitAndRollbackListeners_' in org.apache.derby.client.am.Connection
* Removes the list 'RollbackOnlyListeners_' since this is not being used.
* Updates the following comment for openStatements_:
// Since DERBY prepared statements must be re-prepared after a commit,
// then we must traverse this list after a commit and notify statements
// that they are now in an un-prepared state.
final java.util.LinkedList openStatements_ = new java.util.LinkedList();
In the code, I did not see this list being traversed after a commit to re-prepare statements. Also, I think this is not needed since Derby does not require re-prepare of statements after a commit. Currently, this list is used to close all open statements when the originating connection is closed.
* Removes all ResultSets from HashTable 'positionedUpdateCursorNameToResultSet_' in SectionManager. Only result sets of positioned update statements were being removed from this hashtable whereas all result sets were added. Because of this, client driver was holding on to result sets and statements even after rs.close() was called.
* Adds a test 'derbyStress.java' to jdbcapi suite. This test is based on the repro for this patch. Without this patch, it fails when run with client driver. Kathey had suggested in another mail that tests for client memory leak problems (DERBY-557, DERBY-210) can be added to same test. I did not see an existing test. So I created this new test. If DERBY-557 does not have a test, I think it can be added to this new test.
* Excludes the new test from running with jcc because jcc gives out of memory error.
* Creates 'derbyStress_app.properties' with following property 'jvmflags=-Xmx64M' to guarantee the test fails on all machines.
Successfully ran derbyall with Sun JDK 1.4.2 on Windows XP. Please take a look at this patch.
Contributed by Deepa Remesh
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@369612 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/client/org/apache/derby/client/am/Connection.java",
"hunks": [
{
"added": [
" ",
" // WeakHashMap is used to store references so that the objects added to ",
" // the map can get garbage-collected without waiting for the Connection object.... |
derby-DERBY-5574-9e26acc4 | DERBY-5574 encryption test in encryption nightly suite test fails with ERROR XBM0S: Unable to rename file error
Catch errors on rename, and retry hoping that error is caused by some
temporary file system resource issue. Similar methodology that other
parts of the system uses on read and write errors. Worst case system
retries 5 times and still throws the error, best case a subsequent retry
succeeds and user application is never aware an error was encountered.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1236370 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/io/DirFile.java",
"hunks": [
{
"added": [
"import org.apache.derby.iapi.util.InterruptStatus;"
],
"header": "@@ -39,6 +39,7 @@ import java.net.URL;",
"removed": []
},
{
"added": [
" ... |
derby-DERBY-5578-4b4365a1 | DERBY-5578 Provide a way to invalidate stored prepared statements
Close the resultset in the helper methods as suggested by Knut.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1348520 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-5578-f448bbbd | DERBY-5578 Provide a way to invalidate stored prepared statements
Commiting changes for adding a new procedure(SYSCS_UTIL.SYSCS_INVALIDATE_STORED_STATEMENTS) which will allow users to invalidate all the stored statements inside SYS.SYSSTATEMENTS. At this point, there are only two types of stored statements in SYS.SYSSTATEMENTS system table - statements for metadata calls and statements for trigger action plans. I have also added test cases including the regression tests and upgrade tests. Upgrade tests show that this procedure is available only after hard upgrade. Regression test show how the procedure can be executed only by dba unless dba grants execute permission to other users. Additionally, it has test cases showing statements getting invalidated by the procedure call and subsequent execution of metadata call or trigger causing their corresponding statements to become valid.
Since these changes fiddle around with system tables, this jira can't be backported to released branches.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1348275 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/sql/catalog/DataDictionaryImpl.java",
"hunks": [
{
"added": [
"\t\tinvalidateAllSPSPlans(lcc);",
"\t}",
"",
"\t/**",
"\t * @see DataDictionary#invalidateAllSPSPlans",
"\t * @exception Stand... |
derby-DERBY-5580-35e7aba5 | DERBY-5580: NativeAuthenticationServiceTest fails to delete databases
Make sure the databases get shut down before attempting to delete them.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1235709 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-5582-1690ef63 | DERBY-5582 Access denied (java.lang.RuntimePermission modifyThreadGroup) in IndexStatisticsDaemonImpl.schedule()
Put index-stat thread in derby daemon group.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1236887 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/services/daemon/IndexStatisticsDaemonImpl.java",
"hunks": [
{
"added": [
"import org.apache.derby.iapi.services.monitor.Monitor;"
],
"header": "@@ -39,6 +39,7 @@ import org.apache.derby.iapi.services.property.PropertyUtil;"... |
derby-DERBY-5584-e3320c9c | DERBY-5584: distinct grouped aggregates can return wrong results
This change addresses a problem that can arise when a GroupedAggregateResultSet
that contains a distinct aggregate is processed multiple times in the
same query execution.
The problem involves this section of GroupedAggregateResultSet:
/*
** If there was a distinct aggregate, then that column
** was automatically included as the last column in
** the sort ordering. But we don't want it to be part
** of the ordering anymore, because we aren't grouping
** by that column, we just sorted it so that distinct
** aggregation would see the values in order.
*/
The solution that was implemented in GroupedAggregateResultSet prior to this
change was assuming that the result set was only opened and read once; it
physically removed the last column from the ordering columns as a side effect
of processing the result set.
However, during a query plan such as this cartesian product, the GROUP BY
subquery is created, then opened/read/closed, opened/read/closed, etc.,
once per row of the other side of the cartesian product.
In that case, we can't physically remove the last column each time, because
then the second and subsequent times that we read the result set, we are
sorting on the wrong columns and we produce the wrong results.
The solution is to have a better way of handling that extra invisible column,
so that we can consider it sometimes, and ignore it other times,
without doing something as destructive as physically removing it from the
ordering array, which is what we do now.
Note that Derby has had a limitation that there be at most one DISTINCT
aggregate in a query for a long time, probably ever since it was written.
See, for example, this link from the 10.2 docs:
http://db.apache.org/derby/docs/10.2/ref/rrefsqlj32693.html
Only one DISTINCT aggregate expression per SelectExpression is allowed.
For example, the following query is not valid:
SELECT AVG (DISTINCT flying_time), SUM (DISTINCT miles) FROM Flights
The GroupedAggregateResultSet implementation is aware of this limit, and knows
that there is at most one distinct aggregate in the result set. This change
neither increases that dependency nor lessens it; I'm just noting it here
for the record.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1292134 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/sql/execute/GroupedAggregateResultSet.java",
"hunks": [
{
"added": [
"\tprivate\tint numDistinctAggs = 0;"
],
"header": "@@ -88,6 +88,7 @@ class GroupedAggregateResultSet extends GenericAggregateResultSet",
"removed... |
derby-DERBY-5585-d07d421b | DERBY-5585: Improve error message when user function can't find class.
This patch was contributed by Danoja Dias (danojadias at gmail dot com)
Additional text is added to the 42x50 and 42x51 error messages suggesting
an additional possible cause of the error might be derby.database.classpath.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1754348 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-5603-78b8a9c8 | DERBY-5603: EmbedConnection.clearLOBMapping() incorrectly clears lobFiles causing a ConcurrentModificationException
Rewrote map iteration code.
Fixed incorrect comment.
Made getlobHMObj private.
Patch file: derby-5603-1a-avoid_concurrentmodification.diff
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1294512 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/jdbc/EmbedConnection.java",
"hunks": [
{
"added": [],
"header": "@@ -3262,8 +3262,6 @@ public abstract class EmbedConnection implements EngineConnection",
"removed": [
"\t\t//initialize the locator value to 0 and",
... |
derby-DERBY-5605-45a4a1da | DERBY-5605 Calling Blob/Clob free() explicitly after implicit free throws exception in client driver.
Changed stored procedures to noop if the locator is already freed.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1709431 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/jdbc/LOBStoredProcedure.java",
"hunks": [
{
"added": [
" // DERBY-5605. Do not throw exception if already freed.",
" return;"
],
"header": "@@ -56,7 +56,8 @@ public class LOBStoredProcedure {... |
derby-DERBY-5607-d94fffbd | DERBY-5607: Use InternalDriver rather than a JDBC DataSource in order to get a connection to the credentials db when creating a database with NATIVE authentication enabled.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1242105 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/jdbc/authentication/NativeAuthenticationServiceImpl.java",
"hunks": [
{
"added": [
"import org.apache.derby.jdbc.InternalDriver;"
],
"header": "@@ -49,6 +49,7 @@ import org.apache.derby.iapi.store.access.TransactionControll... |
derby-DERBY-5608-d96e3aa0 | DERBY-5608: BaseTestCase.readProcessOutput should read getInputStream() and getErrorStream() in separate threads
Use SpawnedProcess to read stdout/stderr from the subprocess, since it already
has code to do this in separate threads.
Patch file: derby-5608-1a-use_spawnedprocess.diff
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1242681 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/testing/org/apache/derbyTesting/junit/SpawnedProcess.java",
"hunks": [
{
"added": [
" private boolean suppressOutput;",
""
],
"header": "@@ -41,6 +41,8 @@ public final class SpawnedProcess {",
"removed": []
},
{
... |
derby-DERBY-5609-5a172c50 | DERBY-5609: Prepare old test harness for running tests on Java 8
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1242098 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/testing/org/apache/derbyTesting/functionTests/harness/jdk18.java",
"hunks": [
{
"added": [
"/*",
" ",
" Derby - Class org.apache.derbyTesting.functionTests.harness.jdk18",
" ",
" Licensed to the Apache Software Foundation (A... |
derby-DERBY-5610-d7582c6e | DERBY-5610 ServerPropertiesTest prints .java.net.SocketException: Connection reset to console but test passes
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1484507 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/drda/org/apache/derby/impl/drda/NetworkServerControlImpl.java",
"hunks": [
{
"added": [
" try {",
" writeCommandHeader(COMMAND_TESTCONNECTION);",
" writeLDString(database);",
" write... |
derby-DERBY-5613-5ed54d8c | DERBY-5613 Queries with group by column not included in the column list for JOIN(INNER or OUTER) with NATURAL or USING does not fail
The issue of join column getting associated with left or right table is getting tracked under DERBY-5613. This commit changes the comments in the test to refer to DERBY-5613
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1243784 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-5614-063dd554 | DERBY-5614: NullPointerException with INSERT INTO [global temporary table] SELECT ... FROM [VTI]
Disables bulk-insert for GTTs when selecting from a VTI.
Added a new test case.
Added SampleVTI, which is an incomplete (only supports a few getters) VTI
intended for basic testing.
Patch file: derby-5614-1b-disable_bulkinsert_gtt.diff
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1295085 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/testing/org/apache/derbyTesting/functionTests/util/SampleVTI.java",
"hunks": [
{
"added": [
"/*",
"",
" Derby - Class org.apache.derbyTesting.functionTests.util.SampleVTI",
"",
" Licensed to the Apache Software Foundation (A... |
derby-DERBY-5615-0f43aec7 | DERBY-5615: Permission problems with classpath subsubprotocol
Change the structure of CPFile.getInputStream() back to what it was
before the original fix for this issue (revision 1582655), but with
doPrivileged() calls around all operations that require privileges.
The restructuring in the original fix apparently prevented some
resources from being freed, so that DatabaseClassLoadingTest and
NativeAuthenticationServiceTest failed on Windows platforms because
they could not delete the jar file that contained the classpath
database.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1582754 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/io/CPFile.java",
"hunks": [
{
"added": [],
"header": "@@ -26,12 +26,9 @@ import org.apache.derby.io.StorageFile;",
"removed": [
"import java.io.IOException;",
"import java.security.PrivilegedActionException;",
... |
derby-DERBY-5615-9f1b3146 | DERBY-5615: Permission problems with classpath subsubprotocol
Wrap CPFile's privileged operations in doPrivileged() so that
classpath databases can be accessed with a security manager.
Make more of the test cases in DatabaseClassLoadingTest and
NativeAuthenticationServiceTest run with a security manager.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1582655 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/io/CPFile.java",
"hunks": [
{
"added": [
"import java.io.IOException;",
"import java.security.AccessController;",
"import java.security.PrivilegedAction;",
"import java.security.PrivilegedActionException;",
... |
derby-DERBY-5617-04846d11 | DERBY-5617: Improve process handling in SpawnedProcess
Added a mechanism to kill processes if they live for too long (currently
the threshold is 45 minutes, this may be too high).
Don't let interrupts abort waiting for or terminating a process.
Clean up the process properly when it has terminated.
Patch file: derby-5617-1a-spawnedprocess_improvements.diff
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1244444 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/testing/org/apache/derbyTesting/junit/NetworkServerTestSetup.java",
"hunks": [
{
"added": [
" spawnedServer.complete(2000);"
],
"header": "@@ -204,7 +204,7 @@ final public class NetworkServerTestSetup extends BaseTestSetup {",
... |
derby-DERBY-5618-4a08a159 | DERBY-2162/DERBY-5618: Close the URLClassLoader when tests are done
with it so that file handles are freed and the jar files can be
deleted.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1582220 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/testing/org/apache/derbyTesting/junit/ClasspathSetup.java",
"hunks": [
{
"added": [
"import java.io.Closeable;",
"import java.io.IOException;",
"import java.security.PrivilegedExceptionAction;"
],
"header": "@@ -19,10 +19,13 @@",
... |
derby-DERBY-562-ff049ad7 | fix of DERBY-562, committing patch for: Sunitha Kambhampati
This patch
- changes the error message thrown when the stream is either less or greater than the requested length to
'Input stream did not have exact amount of data as the requested length.'
- enhances the characterStreams.out test, to print out the nested sql exceptions to ensure that the proper error message is returned.
- updates to the master files.
I verified that we are testing for these two error cases (ie stream has less or more data than requested length), for the following supported stream related api - setCharacterStream, setAsciiStream, setBinaryStream on PreparedStatement. Derby does not support setUnicodeStream api that is deprecated in jdbc 3.0.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@292830 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/jdbc/RawToBinaryFormatStream.java",
"hunks": [
{
"added": [
"\t\t\tthrow new IOException(MessageService.getTextMessage(SQLState.SET_STREAM_INEXACT_LENGTH_DATA));"
],
"header": "@@ -79,7 +79,7 @@ class RawToBinaryFormatStrea... |
derby-DERBY-5620-ff005030 | DERBY-5620: Replace illegal characters from test name when creating the failure folder
Replace all non-alphanumeric, except '-' and '_', with '_'. TestCase.getName
returning null is not dealt with, as all test cases should be given a name.
Patch file: derby-5620-2a-alphanum.diff
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1291657 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/testing/org/apache/derbyTesting/junit/TestConfiguration.java",
"hunks": [
{
"added": [
" // DERBY-5620: Ensure valid file name.",
" char[] tmpName = test.getName().toCharArray();",
" for (int i=0; i < tmpName.length; i++) {",
... |
derby-DERBY-5622-49aa62a2 | DERBY-5622: Reduce chance for hash collisions when changing boot passwords.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1356749 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/services/jce/JCECipherFactory.java",
"hunks": [
{
"added": [
""
],
"header": "@@ -340,7 +340,7 @@ public final class JCECipherFactory implements CipherFactory, java.security.Priv",
"removed": [
"\t\t"
... |
derby-DERBY-5622-5c759ff9 | DERBY-2687 store/encryptDatabase.sql fails intermittently with ClassNotFoundException, Log Corrupted
Patch derby-2687-2 + removed an additional unused line. This converts
encryptDatabase.sql to JUnit and also makes the test ignore a hash
collision case: the stored two byte digest of the secret key can in can
1/2**16 cases match the the digest of bogus key gotten by decoding the
encrypted key using the wrong bootpassword, thus allowing boot to
proceed using a wrong encryption key, leading to a boot crash (the
"boot issue").
Another issue (less likely) can still make the test fail (the
"bootpassword change issue"), but cf. the improvement issue DERBY-5622
which would resolve that.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1292084 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/testing/org/apache/derbyTesting/junit/Decorator.java",
"hunks": [
{
"added": [
" {",
" return encryptedDatabaseBpw(test, getBootPhrase(16));",
" }",
"",
" /**",
" * Decorate a set of tests to use an... |
derby-DERBY-5623-7adbb9a9 | DERBY-5623: Loosen up synchronization in FileMonitor
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1292724 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/services/monitor/FileMonitor.java",
"hunks": [
{
"added": [],
"header": "@@ -21,7 +21,6 @@",
"removed": [
"import org.apache.derby.iapi.services.monitor.Monitor;"
]
},
{
"added": [
"imp... |
derby-DERBY-5624-056eff7c | DERBY-5624 System can run out of stack space while processing DropOnCommit requests.
Only run the testDERBY_5624 in largedata on windows until linux issue resolved.
Currently on linux with 1024 file descriptors per user this test fails.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1292595 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-5624-89c0bc38 | DERBY-5624 System can run out of stack space while processing DropOnCommit requests.
minor comment changes.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1292432 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-5624-f63124fd | DERBY-5624 System can run out of stack space while processing DropOnCommit requests.
forgot to svn add this file to last checkin.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1292096 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-5627-b9bd28c8 | DERBY-5627: Remove unused methods from the UUID classes
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1293147 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/services/uuid/BasicUUID.java",
"hunks": [
{
"added": [],
"header": "@@ -21,7 +21,6 @@",
"removed": [
"import org.apache.derby.iapi.services.io.FormatIdUtil;"
]
},
{
"added": [],
"header":... |
derby-DERBY-5630-a5a01336 | DERBY-5630; intermittent test failure in store/lockTableVTI.sql
fixing up javadoc, some comments, adjusting some exception class thrown
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1564635 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-5631-9414ec95 | DERBY-5631: Extend SecurityManagerSetup to add extra privileges to the set of default privileges (merge two policy files)
Added the capability to merge two policy files in SecurityManagerSetup. For now
the only merge allowed is to merge an additional policy resource with the
default test policy. The intended use-case is for tests requiring a few extra
permissions to be runnable in the test framework.
Refreshed class comment.
Made getDefaultPolicy() private.
Added a debug println stating which policy is installed by the decorator.
Patch file: derby-5631-1c-merge_policy_files.diff
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1295436 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/testing/org/apache/derbyTesting/junit/SecurityManagerSetup.java",
"hunks": [
{
"added": [
"import java.io.IOException;",
"import java.io.InputStream;",
"import java.io.OutputStream;",
"import java.security.PrivilegedActionException;"
... |
derby-DERBY-5631-b0ec63db | DERBY-5631: Extend SecurityManagerSetup to add extra privileges to the set of default privileges (merge two policy files)
Added missing privileged block in conversion from File -> URI -> URL -> String.
Replaced a block of code with an existing utility method.
Patch file: derby-5631-1f-merge_policy_files_fix-priv.diff
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1298787 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/testing/org/apache/derbyTesting/junit/SecurityManagerSetup.java",
"hunks": [
{
"added": [
"import java.security.PrivilegedAction;",
"import java.security.PrivilegedExceptionAction;"
],
"header": "@@ -27,7 +27,9 @@ import java.net.MalformedURL... |
derby-DERBY-5631-e1383165 | DERBY-5631: Extend SecurityManagerSetup to add extra privileges to the set of default privileges (merge two policy files)
The previous commit for this issue (revision 1295436) broke all test-cases
using no security policy ("<NONE>").
Fixed handling of NO_POLICY.
Patch file: derby-5631-1d-merge_policy_files-fix.diff
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1295507 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/testing/org/apache/derbyTesting/junit/SecurityManagerSetup.java",
"hunks": [
{
"added": [
" * @return The location of a policy resource, or {@linkplain #NO_POLICY}.",
" String resource = policy1;",
" if (!NO_POLICY.equals(resource... |
derby-DERBY-5631-e6ffa2a1 | DERBY-5631: Extend SecurityManagerSetup to add extra privileges to the set of default privileges (merge two policy files)
Introduced constant NO_POLICY for "<NONE>".
Corrected class name in license.
Fixed typo.
Patch file: derby-5631-2a-introduce_NO_POLICY_constant.diff
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1294088 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/testing/org/apache/derbyTesting/junit/SecurityManagerSetup.java",
"hunks": [
{
"added": [
" * Derby - Class org.apache.derbyTesting.junit.SecurityManagerSetup"
],
"header": "@@ -1,6 +1,6 @@",
"removed": [
" * Derby - Class org.apache.... |
derby-DERBY-5631-ed505d03 | DERBY-5631: Extend SecurityManagerSetup to add extra privileges to the set of default privileges (merge two policy files)
Deal with errors in the URL handling.
Patch file: derby-5631-1e-merge_policy_files-fix-url.diff
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1295609 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/testing/org/apache/derbyTesting/junit/SecurityManagerSetup.java",
"hunks": [
{
"added": [
"import java.net.MalformedURLException;"
],
"header": "@@ -23,6 +23,7 @@ import java.io.File;",
"removed": []
},
{
"added": [
... |
derby-DERBY-5632-fa87f1c0 | DERBY-5632: Logical deadlock happened when freezing/unfreezing the database
Stop using explicit synchronization on the conglomerate cache.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1456352 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/store/access/CacheableConglomerate.java",
"hunks": [
{
"added": [
"import org.apache.derby.iapi.store.raw.ContainerKey;"
],
"header": "@@ -25,6 +25,7 @@ import org.apache.derby.iapi.services.cache.Cacheable;",
"remo... |
derby-DERBY-5635-ca998af8 | DERBY-5635: Provide implementation for getMetaData() in VTITemplate
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1297396 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/vti/StringColumnVTI.java",
"hunks": [
{
"added": [],
"header": "@@ -28,7 +28,6 @@ import java.math.BigDecimal;",
"removed": [
"import java.sql.ResultSetMetaData;"
]
}
]
},
{
"file": "java/engine/org/apa... |
derby-DERBY-5638-3ce7ebd1 | DERBY-5638 intermittent test failure in test_05_ClobNegative when running full largedata._Suite; LobLimitsTestjava.sql.SQLException: Table/View 'BLOBTBL' already exists in Schema 'APP'.
Adding a new test fixture to LobLimitsTest.java which will shutdown the databases. This test fixture will be the last one to get executed in the suite since the tests are run in order in this particular suite. This shutdown will ensure that all the logs are applied to the database and hence there are no unapplied log files left at the end of the suite. Large data suite deals will large data objects which can cause us to have large log files and if the database is not shutdown at the end of the suite, the suite will finish successfully but will leave a database directory with large number of big log files. Nightly machines which run this suite on a regular basis can eventually run out of disk space if those machines do not delete the database directories from multiple runs.
I ran the large data suite on my machine and it ran with no problems. I checked the size of the database wombat after the suite finished and the size of the db was much smaller because of addition of shutdown databases fixture.
Another change made as part of the code changes is to do a truncate table after doing delete from table. TRUNCATE table will avoid post-commit work and shouldn't cause any concurrent locking to happen. We do not want to remove delete from table though because it exercises separate code path in Derby compared to TRUNCATE.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1303630 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-5641-92fee619 | DERBY-5641: Remove unused BaseDataFileFactory methods plus minor cleanups
Removed methods syncSideLog, pageToDirty and getTempDirectory.
Additional cleanups:
o removed unused imports
o removed unnecessary return statement
o made synchronization object freezeSemaphore final
o removed unused instance variable backupPath
o removed unused local variable (and exception instantiation)
multipleJBMSWarning
o replaces new Boolean with Boolean.valueOf
Patch file: derby-5641-1a-unused_methods_plus_cleanup.diff
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1298709 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/store/raw/data/BaseDataFileFactory.java",
"hunks": [
{
"added": [],
"header": "@@ -82,12 +82,10 @@ import java.util.Hashtable;",
"removed": [
"import java.io.FileNotFoundException;",
"import java.security.AccessCo... |
derby-DERBY-5642-b2dc02ce | DERBY-5642: OutOfMemoryError in OCRecoveryTest on phoneME
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1298765 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-5643-77fbd65a | DERBY-5643: Occasional hangs in replication tests on Linux
Make sure the forked processes have terminated completely before
starting the next test case.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1299573 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-5643-7d6ee2f4 | DERBY-5643: Occasional hangs in replication tests on Linux
Increase startup timeout to 4 minutes in NetworkServerTestSetup to work
around http://bugs.sun.com/view_bug.do?bug_id=6483406. Make replication
tests and compatibility tests use NetworkServerTestSetup's helper methods
to check if the server is up.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1300475 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/testing/org/apache/derbyTesting/junit/NetworkServerTestSetup.java",
"hunks": [
{
"added": [
" /**",
" * <p>",
" * Setting maximum wait time to 4 minutes by default. On some platforms",
" * it may take this long to start the... |
derby-DERBY-5648-b60a998f | DERBY-5648: Raise an error if NATIVE password maintenance is performed on a missing user.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1300248 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/catalog/SystemProcedures.java",
"hunks": [
{
"added": [
" checkLegalUser( dd, userName );",
" "
],
"header": "@@ -2132,6 +2132,8 @@ public class SystemProcedures {",
"removed": []
}... |
derby-DERBY-5649-2f326081 | DERBY-5649; make improvements to nstest so it's easier to run/analyze/debug
adjusting the test so it runs better when -Dderby.nstest.backupRestore=false
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1301290 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/testing/org/apache/derbyTesting/system/nstest/utils/MemCheck.java",
"hunks": [
{
"added": [
"import org.apache.derbyTesting.system.nstest.NsTest;",
""
],
"header": "@@ -23,6 +23,8 @@ package org.apache.derbyTesting.system.nstest.utils;",
... |
derby-DERBY-5649-e276048f | DERBY-5649; make improvements to nstest so it's easier to run/analyze/debug
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1300658 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/testing/org/apache/derbyTesting/system/nstest/init/Initializer.java",
"hunks": [
{
"added": [
"\t\t// point, we just need to get a connection to the database"
],
"header": "@@ -49,8 +49,7 @@ public class Initializer {",
"removed": [
"... |
derby-DERBY-5657-2489f473 | DERBY-5657: Split complex error message into 3 shorter messages.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1301064 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/jdbc/authentication/AuthenticationServiceBase.java",
"hunks": [
{
"added": [
" {",
" throw StandardException.newException( SQLState.PROPERTY_BAD_NATIVE_VALUE );",
" }",
" ... |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.