id stringlengths 22 25 | commit_message stringlengths 137 6.96k | diffs listlengths 0 63 |
|---|---|---|
derby-DERBY-5663-6a072f82 | DerbyDERBY-5663 Getting NPE when trying to set derby.language.logStatementText property to true inside a junit suite.
It is possible that the same instance of SystemPropertyTestSetup decorator is used more than once. In such a case, nulling out the oldValues in tearDown method can cause a null pointer exception in the subsequent use of the same SystemPropertyTestSetup. The right thing to do is to initialize oldValues to new Properties object everytime SystemPropertyTestSetup.setUp gets used. In order to do this, we are removing the initialization of oldValues from the constructor and putting it in setUp method.
Additionally, we do not want to null out newValues in tearDown method because the subsequent use of same SystemPropertyTestSetup instance will loose the new values requested by the user of the decorator. Because of this, we will not null newValues in tearDown anymore.
Existing junit All suite and derbyall ran fine with these changes.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1309244 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/testing/org/apache/derbyTesting/junit/SystemPropertyTestSetup.java",
"hunks": [
{
"added": [],
"header": "@@ -51,7 +51,6 @@ public class SystemPropertyTestSetup extends TestSetup {",
"removed": [
"\t\tthis.oldValues = new Properties();"
]
... |
derby-DERBY-5664-47bae99a | DERBY-5664: Include driver tests in jdbcapi suite
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1303693 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-5667-085b6e54 | DERBY-5667; testReadCommitted(org.apache.derbyTesting.functionTests.tests.store.UpdateLocksTest)junit.framework.AssertionFailedError: Missing rows in ResultSet
adding call to wait for post-commit work after deletes.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1330066 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-5667-b27d8ec1 | DERBY-5667; testReadCommitted(org.apache.derbyTesting.functionTests.tests.store.UpdateLocksTest)junit.framework.AssertionFailedError: Missing rows in ResultSet
Adding wait_for_post_commit calls after commits following updates;
changing JDBC.assertRSContains() to print out more details if there are missing rows.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1370058 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/testing/org/apache/derbyTesting/junit/JDBC.java",
"hunks": [
{
"added": [
" String message = \"Missing rows in ResultSet; \\n\\t expected rows: \\n\\t\\t\" ",
" + expected + \"\\n\\t actual result: \\n\\t\\t\" + actual;",
... |
derby-DERBY-5667-c748453a | DERBY-5667; testReadCommitted(org.apache.derbyTesting.functionTests.tests.store.UpdateLocksTest)junit.framework.AssertionFailedError: Missing rows in ResultSet
adjusting the test so every commit following a delete is followed in turn
by a call to wait for post-commit threads to finish.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1330482 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-567-6e7bbc8c | DERBY-688: Enhancements to XML functionality toward XPath/XQuery support
This revision contains d688_phase1_v3.patch.
This patch was contributed by Army Brown (qozinx@gmail.com).
Attaching a "phase 1" patch, d688_phase1_v1.patch, for this issue that does the following:
1. Reorganizes XML-specific code as follows:
- Moves all code that relies on JAXP and Xalan classes
out of XML.java and into a new class, SqlXmlUtil.java.
See comments at the beginning of SqlXmlUtil for an
explanation of why this was done.
- Creates a new class, SqlXmlExecutor, in the impl.sql.execute
package that serves as the class on which all XML operator
calls are generated. Ex. for XMLEXISTS, instead of
generating:
<xmlOperand>.XMLExists(<query-expr>, xmlOperand)
we now generate:
<SqlXmlExecutor>.XMLSerialize(<query-expr>, xmlOperand)
Along with making the code cleaner by allowing all
XML operator calls to be defined in the same class,
this new class has other benefits, as well--see
comments at the beginning of SqlXmlExecutor for
more of an explanation.
2. Changes implementation of XPath from XSLT processing to
the low-level Xalan API, which is faster, more flexible,
and better for implementation of the XMLQUERY operator
(the XMLQUERY operator will be coming in subsequent
phases). Note that as part of this change I've removed
the dependency on an explicit declaration of Xerces
as the parser; Derby will now pick up the parser from
the JVM (i.e. this patch resolves DERBY-567).
3. Makes a small change to the XMLEXISTS operator to bring
it more in line with SQL/XML spec. More specifically,
the query expression that is specified must now be a string
literal; parameters and other expressions are not allowed.
4. Updates the XML test and master files (lang/xml_general.sql
and lang/xmlBinding.java) to bring them in sync with the latest
Derby codeline. Since the XML tests are not (yet) run
as part of derbyall, the master files need to be updated
to reflect some client/server changes that have gone into
the codeline for 10.2 (for example, server pre-fetching
behavior).
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@429698 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/iapi/types/XML.java",
"hunks": [
{
"added": [],
"header": "@@ -46,28 +46,6 @@ import java.io.ObjectOutput;",
"removed": [
"import org.xml.sax.ErrorHandler;",
"import org.xml.sax.XMLReader;",
"import org.xml.s... |
derby-DERBY-5677-c1192c0b | DERBY-5677: ClassNotFoundException when running suites.All without derbynet.jar
Exclude tests that cannot run without derbynet.jar if the network server
classes are not available on the classpath.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1308434 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-5678-70bfa379 | DERBY-5678: LocalizedDisplayScriptTest fails on JVMs that don't support EUC_JP encoding
Skip the test on platforms that don't support EUC_JP.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1308436 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-5679-3abd440f | DERBY-5679: Fill nonexistent columns with NULLS during update of later column in the row.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1330877 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/store/raw/data/StoredPage.java",
"hunks": [
{
"added": [
" * COLUMN_CREATE_NULL - the column was recently added.",
" * it doesn't actually exist in the on-disk row yet.",
" * ... |
derby-DERBY-5679-76b75c3e | DERBY-5679: Add more test cases to verify correct behavior of rollback on rows with lots of columns and on long rows.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1331484 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-5680-7e333995 | DERBY-5680: indexStat daemon processing tables over an over even when there are no changes in the tables
Added functionality in the update statistics code to drop statistics considered
disposable; orphaned (i.e. the referenced index doesn't exist), or not
required (the optimizer doesn't need the statistics).
Disposable statistics are only dropped when the istat daemon kicks in, or
SYSCS_UPDATE_STATISTICS is run without specifying an index.
The functionality is not enabled for soft-upgraded databases.
Included a debug property to force the old behavior.
Patch file: derby-5680-1b-remove_disposable_stats.diff
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1340549 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/services/daemon/IndexStatisticsDaemonImpl.java",
"hunks": [
{
"added": [
"import java.util.List;"
],
"header": "@@ -23,6 +23,7 @@ package org.apache.derby.impl.services.daemon;",
"removed": []
},
{
... |
derby-DERBY-5680-a2f00b4a | DERBY-6283 indexStat daemon processing tables over and over even when there are no changes in the tables in soft upgraded database.
Changed system to always drop orphaned stats during update statistics call.
Without this change soft upgraded systems running on 10.8 or higher derby
software, that had an orphaned statistic would spin forever in the index
stat daemon due to the same problem fixed by DERBY-5680 for hard
upgraded databases.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1502319 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/services/daemon/IndexStatisticsDaemonImpl.java",
"hunks": [
{
"added": [
"",
" // can only properly identify disposable stats if cds == null, ",
" // which means we are processing all indexes on the conglo... |
derby-DERBY-5681-29a19ff9 | DERBY-5681 When a foreign key constraint on a table is dropped, the associated statistics row for the conglomerate is not removed
This problem happens because when two constraints share the same backing index, we conditionally dropped the statistics. Instead, this fix will make sure that the statistics are always dropped even if the underneath backing index is still valid(and hence won't be dropped and recreated) for other constraints. I ran derbyall and junit suite and they both ran fine with no errors.I have also dded few tests for the issue.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1329359 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-5681-a6a07338 | DERBY-4115 Provide a way to drop statistics information
The details of all the changes in this commit are listed below.
1)Added a new routine SYSCS_DROP_STATISTICS, with public access similar to SYSCS_UPDATE_STATISTICS. This happens in DataDictionaryImpl, where SYSCS_DROP_STATISTICS is added to the list of public access procedures in sysUtilProceduresWithPublicAccess
2)The new stored procedure implementation is similar to update statistics, ie allow the routine to go through ALTER TABLE where permission/privilege checking, table/schema/index name validations happen automatically and we implement the routine logic through extension of ALTER TABLE syntax. This new syntax for ALTER TABLE syntax(same as we did for update statistics) is an internal syntax only and won't be available to an end user directly.
3)This commit changes sqlgrammar.jj to recognize the following internal syntaxes for ALTER TABLE
a)ALTER TABLE tablename ALL DROP STATISTICS
The existing(corresponding syntax) for update statistics is as follows
ALTER TABLE tablename ALL UPDATE STATISTICS
b)ALTER TABLE tablename STATISTICS DROP indexname
The existing(corresponding syntax) for update statistics is as follows
ALTER TABLE tablename UPDATE STATISTICS indexname
Notice the two syntaxes for index level statistics are different for drop vs update.(the reason for the syntax difference is explained above)
4)After the statistics are dropped, we send invalidation signal to dependent statements so they would get recompiled when they are executed next time. This will make sure that they pick the correct plan given the statistics for the table.
5)The commit takes care of some of the test failures(expected failures because of the addition of a new system procedure).
6)The commit adds basic upgrade test for the new procedure. This test ensures that drop statistics procedure is available only after hard upgrade.
7)While writing the upgrade tests, I found that a meaningful test for drop statistics could only be written for Derby releases 10.5 and higher. We have found that when constraints end up sharing same backing index, Derby won't create statistics for them. This is issue DERBY-5702. But if we run update statistics on that constraint, we will be able to get the statistics for such a constraint. Later, when the constraint is dropped, because of DERBY-5681, the statistics row for such a constraint(one that shares it's backing index with another constraint) is never dropped. We can use drop statistics procedure introduced in this jira to take care of such hanging indexes. But since update statistics procedure is only available in 10.5 and higher, I couldn't demonstrate use of drop statistics to drop hanging statistics rows.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1338017 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/catalog/SystemProcedures.java",
"hunks": [
{
"added": [
"\t * @exception SQLException"
],
"header": "@@ -733,7 +733,7 @@ public class SystemProcedures {",
"removed": [
"\t * @exception StandardException Sta... |
derby-DERBY-5681-b0e73bc6 | DERBY-5681: When a foreign key constraint on a table is dropped, the associated statistics row for the conglomerate is not removed
Made test less sensitive to statistics created by other tests.
Patch file: derby-5681-3a-test.diff
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1341002 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-5681-c1e0f8ee | DERBY-4115/DERBY-5681: Provide a way to drop statistics information
Moved upgrade test from BasicSetup to Changes10_9.
Includes some simplifications that could be made because of the move.
Patch file: derby-4115-7a-move_test.diff
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1341059 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-5683-7840c516 | DERBY-5683: BaseJDBCTestCase.getDatabaseProperty() should close resources before returning
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1310413 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-5686-15097dd7 | DERBY-5686; multiple intermittent errors in nightly tests during DriverMgrAuthenticationTest test. reason: An SQL data change is not permitted for a read-only connection, user or database.
updating retry logic in DatabasePropertyTestSetup
also adding code to CleanDatabaseTestSetup to catch any test leaving a
connection in read-only mode and making it fail.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1336349 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/testing/org/apache/derbyTesting/junit/CleanDatabaseTestSetup.java",
"hunks": [
{
"added": [
" // See DERBY-5686 - perhaps there's a test that leaves a ",
" // connection in read-only state - let's check here and ",
" // if ther... |
derby-DERBY-5686-75e97c18 | DERBY-5686; multiple intermittent errors in nightly tests during DriverMgrAuthenticationTest test. reason: An SQL data change is not permitted for a read-only connection, user or database.
Another attempt to catch the error and print info - now if it happens in
DatabasePropertyTestSetup.setUp.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1332484 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/testing/org/apache/derbyTesting/junit/DatabasePropertyTestSetup.java",
"hunks": [
{
"added": [
" System.out.println(\"Apparently this is a read-only connection in teardown()? Get some data:\");"
],
"header": "@@ -292,7 +292,7 @@ public c... |
derby-DERBY-5686-7aa3f882 | DERBY-5686: multiple intermittent errors in nightly tests during DriverMgrAuthenticationTest test. reason: An SQL data change is not permitted for a read-only connection, user or database.
Make assertDirectoryDeleted accept if the root directory disappears under it
even if it couldn't delete all the files inside. The prime example is when
db.lck is the only file that can't be deleted. The reason is that Derby hasn't
shut down before the deletion of the database directory starts. Depending on
timing, assertDirectoryDeleted may be able to delete all files (including the
root directory) except the lock file, and the lock file is deleted by Derby
itself.
This patch doesn't fix this JIRA issue, it's a general improvement to the
deletion logic only.
Patch file: DERBY-5686_3.diff
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1334313 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-5686-eb472301 | DERBY-5686; multiple intermittent errors in nightly tests during DriverMgrAuthenticationTest test. reason: An SQL data change is not permitted for a read-only connection, user or database.
implementing a change that waits for completely shutting down of the database.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1346174 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/testing/org/apache/derbyTesting/junit/ConnectionPoolDataSourceConnector.java",
"hunks": [
{
"added": [
" getPooledConnection().getConnection();",
" config.waitForShutdownComplete(getDatabaseName());"
],
"header": "@@ -15... |
derby-DERBY-5686-f5bfd989 | DERBY-5686; multiple intermittent errors in nightly tests during DriverMgrAuthenticationTest test. reason: An SQL data change is not permitted for a read-only connection, user or database.
committing patch DERBY_5686_1.diff (after removing some unnecessary imports).
Hopefully this will give us at least some insight into what's happening when
this happens during teardown of the DatabasePropertyTestSetup.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1331601 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/testing/org/apache/derbyTesting/junit/DatabasePropertyTestSetup.java",
"hunks": [
{
"added": [
" clearProperties(conn);",
" // To try to prevent the error situation of DERBY-5686, which",
" // cascades to many test ... |
derby-DERBY-5687-c69fcab5 | DERBY-5687: Adjust the public api javadoc for SequencePreallocator so that it no longer refers to identity columns.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1311310 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/catalog/SequencePreallocator.java",
"hunks": [
{
"added": [
" * Logic to determine how many values to pre-allocate for a sequence.",
" * By default, Derby boosts concurrency by pre-allocating ranges of numbers for sequences.",
... |
derby-DERBY-5693-5d3b815a | DERBY-5693: BUILTIN should say passwords are hashed not encrypted
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1327910 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/jdbc/authentication/AuthenticationServiceBase.java",
"hunks": [
{
"added": [
" * User passwords are hashed using a message digest algorithm",
" * if they're stored in the database. They are not hashed",
" * The password... |
derby-DERBY-5701-673b7a79 | DERBY-5701: Make UpdatableResultSetTest less hungry on heap space
Close statements earlier.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1329148 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-5702-a6a07338 | DERBY-4115 Provide a way to drop statistics information
The details of all the changes in this commit are listed below.
1)Added a new routine SYSCS_DROP_STATISTICS, with public access similar to SYSCS_UPDATE_STATISTICS. This happens in DataDictionaryImpl, where SYSCS_DROP_STATISTICS is added to the list of public access procedures in sysUtilProceduresWithPublicAccess
2)The new stored procedure implementation is similar to update statistics, ie allow the routine to go through ALTER TABLE where permission/privilege checking, table/schema/index name validations happen automatically and we implement the routine logic through extension of ALTER TABLE syntax. This new syntax for ALTER TABLE syntax(same as we did for update statistics) is an internal syntax only and won't be available to an end user directly.
3)This commit changes sqlgrammar.jj to recognize the following internal syntaxes for ALTER TABLE
a)ALTER TABLE tablename ALL DROP STATISTICS
The existing(corresponding syntax) for update statistics is as follows
ALTER TABLE tablename ALL UPDATE STATISTICS
b)ALTER TABLE tablename STATISTICS DROP indexname
The existing(corresponding syntax) for update statistics is as follows
ALTER TABLE tablename UPDATE STATISTICS indexname
Notice the two syntaxes for index level statistics are different for drop vs update.(the reason for the syntax difference is explained above)
4)After the statistics are dropped, we send invalidation signal to dependent statements so they would get recompiled when they are executed next time. This will make sure that they pick the correct plan given the statistics for the table.
5)The commit takes care of some of the test failures(expected failures because of the addition of a new system procedure).
6)The commit adds basic upgrade test for the new procedure. This test ensures that drop statistics procedure is available only after hard upgrade.
7)While writing the upgrade tests, I found that a meaningful test for drop statistics could only be written for Derby releases 10.5 and higher. We have found that when constraints end up sharing same backing index, Derby won't create statistics for them. This is issue DERBY-5702. But if we run update statistics on that constraint, we will be able to get the statistics for such a constraint. Later, when the constraint is dropped, because of DERBY-5681, the statistics row for such a constraint(one that shares it's backing index with another constraint) is never dropped. We can use drop statistics procedure introduced in this jira to take care of such hanging indexes. But since update statistics procedure is only available in 10.5 and higher, I couldn't demonstrate use of drop statistics to drop hanging statistics rows.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1338017 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/catalog/SystemProcedures.java",
"hunks": [
{
"added": [
"\t * @exception SQLException"
],
"header": "@@ -733,7 +733,7 @@ public class SystemProcedures {",
"removed": [
"\t * @exception StandardException Sta... |
derby-DERBY-5704-6e35772a | DERBY-5704: Various cleanups in CoalesceTest
Remove the instance variables to make it easier to release resources.
Make sure negative test cases fail if no exception is thrown.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1330195 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-5705-fcaa724a | DERBY-5705: Authorization decorators don't null out connections when done
- Callers that override DatabasePropertyTestSetup.tearDown() with an
empty method are replaced by calls to getNoTeardownInstance().
- Make the tearDown() method in decorators returned by
getNoTeardownInstance() close and null out the reference to the
default connection.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1330196 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/testing/org/apache/derbyTesting/junit/TestConfiguration.java",
"hunks": [
{
"added": [
" Test setSQLAuthMode = DatabasePropertyTestSetup.getNoTeardownInstance(",
" test, sqlAuth, true);"
],
"header": "@@ -911,11 +911,8 @... |
derby-DERBY-5706-ce3737f7 | DERBY-5706: Clean up statements in CreateTableFromQueryTest
Stop storing the statement in an instance variable, so that it is
automatically closed and forgotten by the framework.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1329633 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-5707-980db345 | DERBY-5707: Clean up statements in CharUTF8Test
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1329686 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-5708-90b6f2f0 | DERBY-5708: simpleThread test doesn't release connection
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1330197 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-571-0e9ddda2 | DERBY-571 Fix SYSCS_INPLACE_COMPRESS_TABLE to ignore VTI tables, like it ignores views.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@345595 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/iapi/db/OnlineCompress.java",
"hunks": [
{
"added": [
" switch (td.getTableType())",
" /* Skip views and vti tables */",
" case TableDescriptor.VIEW_TYPE:",
" case TableD... |
derby-DERBY-571-ddc6f41f | DERBY-571 Virtual Table Mapping for no argument Diagnostic tables
Add code to map from a table definition to a vti constuctor at compile
time. Only supported for no-argument virtual tables and limited
to table driven set of diagnostic tables, lock_table, transaction_table,
statment_cache and error_messages. Initial step towards a more
generalized application defined virtual table solution.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@292876 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/iapi/sql/compile/NodeFactory.java",
"hunks": [
{
"added": [
"import java.util.Properties;",
"",
"import org.apache.derby.iapi.sql.dictionary.TableDescriptor;"
],
"header": "@@ -20,9 +20,12 @@",
"remov... |
derby-DERBY-5712-fd2f1f73 | DERBY-5712: CheckConstraintTest holds on to resources after completion
Use local variables instead of instance variables to prevent references from
being held after the test has finished.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1330199 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-5713-30158120 | DERBY-5713: AlterTableTest holds on to resources after completion
Use local variables instead of instance variables to prevent references from
being held after the test has finished.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1330200 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-5714-082f2ede | DERBY-5714: ColumnDefaultsTest holds on to resources after completion
Use local variables instead of instance variables to prevent references from
being held after the test has finished.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1330201 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-5715-a3b9db04 | DERBY-5715: InbetweenTest holds on to resources after completion
Use local variables instead of instance variables to prevent objects
from being held after the test completes.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1330206 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-5716-cbce5601 | DERBY-5716: TimestampArithTest keeps references to statements after completion
- Add tearDown() method that closes the statements and clears the
references to them
- Make the test data set static so that it is not cloned with one
identical set for every test case
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1330207 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-5718-6001ab60 | DERBY-5718: UniqueConstraintSetNullTest calls super.tearDown() too early
Call super.tearDown() last in tearDown(), and use framework helper methods
in setUp() and tearDown() to simplify and make resources freed automatically.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1330202 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-5719-8bc55f33 | DERBY-5719: UniqueConstraintMultiThreadedTest doesn't call super.tearDown()
- Call super.tearDown() from the override
- Use framework helper methods to simplify setUp() and tearDown()
- Eliminate the shared DataSource instance (use openDefaultConnection()
instead)
- Remove unused imports
- Fix some typos in javadoc comments
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1330203 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-5729-136610d8 | DERBY-5729: Replication tests keep references to connections after completion
- close connections in tearDown()
- null out references to connections, and to other objects that are no
longer needed, in tearDown()
- remove the fields masterServer and slaveServer since they are always
null
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1332133 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-573-2dc0b917 | DERBY-573: Add support for optimizer hints, provided by the user as SQL comments. Also add upgrade infrastructure for 10.2 release and support new optimizer mechanism to work correctly under soft-upgrade for databases at 10.1 level.
I have the patch for optimizer overrides support in Derby. Alongwith the patch, I have attached the updated functional spec to the JIRA entry DERBY-573.
Majority of the changes went into the sqlgrammar.jj because Derby engine already has support for them internally. It is the parser that needs to recognize these overrides and pass it on to through the query nodes. The parser now looks for character sequence -- DERBY-PROPERTIES (case insensitive and space between -- and D is optional) and once it finds that, it looks for propertyName=value pairs on that same comment line in parser's propertyList method. The parser does the basic check to make sure that the same property is not used more than once for a given table. The remaining checks on the properties like checking the existence of user specified index etc are done in the bind phase.
I also changed the metadata.properties file to use --DERBY-PROPERTIES rather than old PROPERTIES clause to supply optimizer overrides. In addition, added \n at the end of the optimier override comment lines to make sure the comment line does not get concatenated with the next line of the sql.
Import.java had to be changed to user --DERBY-PROPERTIES rather than PROPERTIES.
Added a new test optimizerOverrides.sql which runs in both embedded and network server mode.
Rerunning all the tests after syncing the codeline to make sure nothing has broken. An earlier run of the tests before the sync came out clean.
I plan to next work on exposing these overrides through runtime statistics so that user can verify that the optimizer overrides are getting used.
Submitted by Mamta Satoor (msatoor@gmail.com)
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@356562 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/iapi/sql/conn/LanguageConnectionContext.java",
"hunks": [
{
"added": [
" /**"
],
"header": "@@ -863,7 +863,7 @@ public interface LanguageConnectionContext extends Context {",
"removed": [
" /**"
... |
derby-DERBY-573-c7248d5e | DERBY-573: Enhance RUNSTAT output to show user specified optimizer hints are bing used.
Here is the checkin message from the contributor:
I have attached a patch named Derby573OptimizerOverridesAndRunTimeStatistics011206.txt to JIRA Derby573 Provide support for optimizer overrides in Derby. This patch enables users to see the optimizer overrides specified in the sql as part of runtime statistics info. This is achieved by changing the
generator so that these properties get passed from compile time to execute time. This change in generate phase can be found in FromBaseTable,
BaseJoinStrategy and JoinNode. The changes in the other classes is for returning the correct number of arguments to the scan. That change is in
getScanArgs method.
In addition, I have changed the existing lang/optimizerOverrides.sql to test this patch. derbyall suite has run fine on my Windows XP m/c with Sun's jdk14.
Submitted by Mamta Satoor (msatoor@google.com)
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@369619 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/iapi/sql/execute/ResultSetFactory.java",
"hunks": [
{
"added": [
"\t\t@param tableName\t\tThe full name of the table ",
"\t\t@param userSuppliedOptimizerOverrides\t\tOverrides specified by the user on the sql"
],
"head... |
derby-DERBY-5733-cc049626 | DERBY-5733: Source file for OrderByAndSortAvoidance contains characters not available in the C locale
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1332938 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-5734-73ff7eb9 | DERBY-5734: End transaction if CleanDatabaseTestSetup.decorateSQL fails
Make sure the transaction is ended even if decorateSQL, which can be
overridden to perform custom setup tasks, fails.
This patch also nulls out the reference to the default connection
(clearConnection() must be paired with getConnection())
Patch file: derby-5734-1b-end_transaction.diff
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1333360 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/testing/org/apache/derbyTesting/junit/CleanDatabaseTestSetup.java",
"hunks": [
{
"added": [
" try {",
" decorateSQL(s);",
" s.close();",
" conn.commit();",
" } finally {",
... |
derby-DERBY-5737-c44e39a9 | DERBY-5737: Remove GenericDescriptorList.elements and replace Enumerator usage with Iterator
Removed elements-methods and use of Enumerator in preparation of refactoring.
Patch file: derby-5737-1a-iterator.diff
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1333356 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/iapi/sql/dictionary/GenericDescriptorList.java",
"hunks": [
{
"added": [],
"header": "@@ -21,18 +21,6 @@",
"removed": [
"import org.apache.derby.iapi.error.StandardException;",
"import org.apache.derby.iapi.services.sa... |
derby-DERBY-5741-33605bd7 | DERBY-5741: Improve error reporting for missing UserAuthenticators.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1335010 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-5746-5db352a4 | DERBY-5746: Minor refactoring of DataDictionaryImpl.getSetAutoincrementValue
Dropped unused return value from the fetch-call.
Moved the instantiation/delcaration/modification of the bit set inside the code
block where it is actually used.
Patch file: derby-5746-1a-minor_refactoring.diff
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1338618 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/sql/catalog/DataDictionaryImpl.java",
"hunks": [
{
"added": [],
"header": "@@ -8843,9 +8843,6 @@ public final class\tDataDictionaryImpl",
"removed": [
"",
"\t\tFormatableBitSet columnToUpdate = new ",
" ... |
derby-DERBY-5746-94388c5a | DERBY-5746: Minor refactoring of DataDictionaryImpl.getSetAutoincrementValue
Add debug asserts for two cases where the return value of
ConglomerateController.fetch is ignored (primarily for consistency with other
cases).
Patch file: derby-5746-2a-assert_on_fetch.diff
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1339986 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/sql/catalog/DataDictionaryImpl.java",
"hunks": [
{
"added": [
" boolean baseRowExists =",
" heapCC.fetch(rl, row.getRowArray(), columnToRead, wait);",
" if (SanityManager.DEBUG) ... |
derby-DERBY-5749-eff91692 | DERBY-5749 Implicit cast of variable length values, e.g. as arguments to stored methods and generated columns values, silently truncate if too long
Patches derby-5749b (stored procedures and functions) and
derby-5749-2b (generated columns).
Quote from releaseNote.html attached to the issue:
Summary of Change
SQL now does correct checking of the length of variable strings in
these two cases:
Arguments to stored procedures and functions
Values assigned to generated columns
Previously, if the actual value was longer than the datatype of the
argument or column to which it was assigned, Derby would silently
truncate the value and ignore the truncation. The SQL standard
requires a truncation exception be thrown.
Derby now throws an SQLException with SQL state 22001 in these cases.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1339281 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/sql/compile/CastNode.java",
"hunks": [
{
"added": [
" /**",
" * Method calls:",
" * Argument type has the same semantics as assignment:",
" * Section 9.2 (Store assignment). There, General Rule"... |
derby-DERBY-575-03ea0985 | DERBY-575: Fix blobclob4BLOB, lobStreams, and ieptests on systems with non-ASCII
native encodings.
Committed for Myrna Van Lunteren <m.v.lunteren@gmail.com>
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@397028 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-5750-f6e9c212 | DERBY-5750 Sending an empty string as table name to compress table procedure or empty string as index name to update statistics procedure makes the parser throw an exception.
Committing changes for DERBY-5750 which will provide following functionality
a)if schema name is provided as an empty string, we will throw SQLState.LANG_SCHEMA_DOES_NOT_EXIST
b)if table name is provided as an empty string, we will throw SQLState.LANG_TABLE_NOT_FOUND
c)if index name is provided as an empty string(this is for update and drop statistics procedures), we will throw
SQLState.LANG_INDEX_NOT_FOUND
d)if schema name is null, we will use current schema to resolve the table name
e)if table name is null, we will throw SQLState.LANG_TABLE_NOT_FOUND
f)if index name is null, we will drop/update statisitcs for all the indexes for the given table.
I have added few test cases for each of these procedures.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1355552 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/catalog/SystemProcedures.java",
"hunks": [
{
"added": [
" * @param schemaname schema name of the table/index(es) whose ",
" * statistics will be updated. null will mean use",
" * ... |
derby-DERBY-5751-0881157e | DERBY-5751: Make TriggerTest less hungry on heap space
- Use LoopingAlphabetStream and LoopingAlphabetReader instead of
ByteArrayInputStream and CharArrayReader so that the input data
arrays don't need to be materialized in memory.
- Close statements and result sets earlier to allow gc of old
test data.
- Use shared helper methods BaseTestCase.assertEquals(Reader,Reader)
and BaseTestCase.assertEquals(InputStream,InputStream). These also
ensure that the readers and streams are closed.
- Added new helper methods to ByteAlphabet and CharAlphabet to make
it easier to create alphabets consisting of a single value.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1336527 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/testing/org/apache/derbyTesting/functionTests/util/streams/ByteAlphabet.java",
"hunks": [
{
"added": [
" /**",
" * Create an alphabet that consists of a single byte.",
" */",
" public static ByteAlphabet singleByte(byte b) {... |
derby-DERBY-5752-c2fe2805 | DERBY-5752: LOBStreamControl should materialize less aggressively
Only materialize LOBs that are smaller than 32 KB in memory.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1447722 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/jdbc/LOBStreamControl.java",
"hunks": [
{
"added": [
" * size is set to the size of the byte array supplied, but no larger than",
" * MAX_BUF_SIZE. If no initial data is supplied, or if the initial data size",
" * is le... |
derby-DERBY-5755-9f6c6783 | DERBY-5755: Minor cleanup of DataDictionaryImpl.getRoutineList()
Use java.util.Collections to create empty and single-element lists.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1338167 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/sql/catalog/DataDictionaryImpl.java",
"hunks": [
{
"added": [
" // We expect to find just a single function, since we currently",
" // don't support multiple routines with the same name, but use a",
... |
derby-DERBY-5759-5a72b2c2 | DERBY-5759: Add IndexStatsUtil.release(boolean closeConnection)
Made it possible to clean up the resources used by the utility without
closing the connection.
Patch file: derby-5759-1a-release_with_arg.diff
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1338068 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/testing/org/apache/derbyTesting/junit/IndexStatsUtil.java",
"hunks": [
{
"added": [
" * Releases resources and closes the associated connection.",
" release(true);",
" }",
"",
" /**",
" * Releases ... |
derby-DERBY-576-7c812c76 | DERBY-576 xaHelper in ij creates global id that is not the same across platforms
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@740048 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/tools/org/apache/derby/impl/tools/ij/xaHelper.java",
"hunks": [
{
"added": [
"",
"import java.io.UnsupportedEncodingException;"
],
"header": "@@ -22,6 +22,8 @@",
"removed": []
},
{
"added": [
"\t\ttry {",... |
derby-DERBY-5760-d349a1fb | DERBY-5760: Missing argument in some XJ022 errors
Use helper method that sets the argument automatically.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1341350 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/jdbc/EmbedBlob.java",
"hunks": [
{
"added": [
" throws StandardException, SQLException"
],
"header": "@@ -154,7 +154,7 @@ final class EmbedBlob extends ConnectionChild implements Blob, EngineLOB",
"removed": ... |
derby-DERBY-5762-5ea170fe | DERBY-5762: Normalize casing of username inside NATIVE procedures.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1338760 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/catalog/SystemProcedures.java",
"hunks": [
{
"added": [
" userName = normalizeUserName( userName );",
" "
],
"header": "@@ -2090,6 +2090,8 @@ public class SystemProcedures {",
"removed": []
... |
derby-DERBY-5764-720294ef | DERBY-5764: Make DatabaseMetaDataTest more robust wrt changes made by other tests
Use schema name in the queries to avoid "pollution" of the system tables from
other tests, specifically when run as part of the upgrade test. The schema name
is set to the user name, so to enable this feature wrap the test in a decorator
that changes the user.
Wrapped a ChangeUserDecorator around the tests from DatabaseMetaDataTest in the
upgrade tests.
Patch file: derby-5764-2a-specify_schema.diff
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1339240 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-5764-cde004ca | DERBY-5764: Make DatabaseMetaDataTest more robust wrt changes made by other tests
Minor cleanups: removed unused imports, removed final from static method,
renamed method, and converted comment to Javadoc.
Patch file: derby-5764-1a-upgraderun_cleanup.diff
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1339007 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-5764-fa3a4bc0 | DERBY-5764: Make DatabaseMetaDataTest more robust wrt changes made by other tests
Added some additional tests to test code paths where schema is set to null.
Added utility method JDBC.assertResultSetContains, used where the query may
return more rows due to data added by other tests but we still want to assert
that a specific subset of rows exists in the result.
Patch file: derby-5764-3b-add_test_case_schema_null.diff
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1351212 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/testing/org/apache/derbyTesting/junit/JDBC.java",
"hunks": [
{
"added": [
" assertRSContains(rs, expectedRows, asTrimmedStrings, true);",
" }",
"",
" /**",
" * Asserts that the {@code ResultSet} contains the row... |
derby-DERBY-5770-ebe46425 | DERBY-5770: Reduce window of opportunity for queries being compiled without statistics on istat update
Moved invalidation to after the new statistics have been written.
Patch file: derby-5770-1a-move_invalidation.diff
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1339999 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/services/daemon/IndexStatisticsDaemonImpl.java",
"hunks": [
{
"added": [
" if (!lcc.dataDictionaryInWriteMode()) {",
" dd.startWriting(lcc);",
" }",
" boolean conglomerateGone =... |
derby-DERBY-5774-387174c8 | DERBY-5774: Failures in UpdateStatisticsTest (order-dependent test cases)
Made asserts on statistics specific to the relevant table(s) in testUpdateAndDropStatistics.
Made testDisposableStatsEagerness drop the tables it creates.
Patch file: derby-5774-1a-focused_asserts.diff
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1341019 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-5779-34681435 | DERBY-5779: Prevent VTIS in FROM list subqueries from referencing other elements in the FROM list.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1362159 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/sql/compile/FromSubquery.java",
"hunks": [
{
"added": [
"import java.util.Enumeration;",
"import java.util.Vector;"
],
"header": "@@ -21,6 +21,8 @@",
"removed": []
}
]
},
{
"file": "java/... |
derby-DERBY-5779-8c3c7e88 | DERBY-5779: Add more tests for illegal joins of VTI/tableFunction args in <joined table> clauses.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1360846 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-5779-9495b40d | DERBY-5779: Forbid joining to VTI/tableFunction args in <joined table> clauses.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1360736 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-5779-a4c1c3a3 | DERBY-5779: Do not let table function parameters refer to other tables in the same FROM list.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1352631 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-578-fee55d87 | DERBY-578 - Grouped select from temporary table raises null pointer exception in byte code generator
DERBY-1464 - runtimestatistics can show that an index is being used even when it isn't
Contributed by Manish Khettry
The problem is simple enough-- we didn't have a conglomerate name for temporary tables. I fixed the code to behave more like what fillInScanArgs does.
Earlier, we would set the indexName field in DistinctScanResult to the conglomerate name (cd.getName()) used to scan the table. If the conglomerate was the base table itself then this was just plain wrong. The change, for this patch, passes null if no index is being used.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@418672 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/sql/compile/FromBaseTable.java",
"hunks": [
{
"added": [
"\t",
" /* helper method used by generateMaxSpecialResultSet and",
" * generateDistinctScan to return the name of the index if the ",
" ... |
derby-DERBY-5780-ceaf7dfd | DERBY-5494 Same value returned by successive calls to a sequence generator flanking an unorderly shutdown.
DERBY-5780 identity column performance has degredated
The previous patch for DERBY-5494 had the unintended affect of forcing a
synchronous write for all nested user transactions at abort time. This
in turn caused identity column inserts to have one synchronous write per
insert as the nested user transaction is destroyed for each insert which
does an abort each time.
To solve this interfaces were changed so that calling code could set the
default commit sync behavior when the transaction was committed rather than
count on the "type" of transaction. Nested user transactions used for identity
columns have default set to not sync, and the rest of the nested user transactions
default to syncing. Behavior of other types of transactions should not
be affected. User transactions still sync by default and internal and ntt's still
default to not sync.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1344065 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/iapi/store/raw/RawStoreFactory.java",
"hunks": [
{
"added": [
" @param flush_log_on_xact_end By default should the transaction ",
" commit and abort be synced to the log. Normal usage should pick true, ",
"... |
derby-DERBY-5783-02ac42ce | DERBY-5783: Remove duplicated code for starting remote processes in replication tests
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1344190 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-579-1373f5a6 | Fixes DERBY-579 by not storing the timeout value in the
GenericPreparedStatement class, just passing it through.
SetQueryTimeoutTest updated, now uses a server-side function to delay
queries. This gives predictability and because of that, the running
time of the test has been significantly reduced. Also, the test now
uses the same tables in multiple statements, in order to hit the
statement cache and check that the timeout affects only the right
statements.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@293585 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/iapi/sql/PreparedStatement.java",
"hunks": [
{
"added": [
" * @param timeoutMillis timeout value in milliseconds."
],
"header": "@@ -106,6 +106,7 @@ public interface PreparedStatement",
"removed": []
}
]
... |
derby-DERBY-5792-0a8f8408 | DERBY-5792: Make it possible to turn off encryption on an already encrypted database.
Simplified code removing old container files generated during encryption and
decryption of a database. There were two implementations, I removed one of them
and removed the parameter of EncryptOrDecryptData.removeOldVersionOfContainers
(and calling methods).
Patch file: derby-5792-5b-old_container_removal_cleanup.diff
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1394522 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/iapi/store/raw/data/DataFactory.java",
"hunks": [
{
"added": [],
"header": "@@ -32,7 +32,6 @@ import org.apache.derby.iapi.store.raw.ContainerHandle;",
"removed": [
"import org.apache.derby.iapi.store.raw.RecordHandle;"
... |
derby-DERBY-5792-86ebb44a | DERBY-5792: Make it possible to turn off encryption on an already encrypted database.
Added basic tests for database decryption, verifying that:
o core functionality works
o nothing is decrypted if the database is already booted
o conflicting attributes are detected
The test has not yet been enabled as part of the store suite.
Patch file: derby-5792-2a-decryptdatabasetest.diff
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1392856 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-5792-89a66256 | DERBY-5792: Make it possible to turn off encryption on an already encrypted database.
A set of changes made in preparation of adding database decryption support.
These modifications should not cause functional changes.
Description:
o DataFactory.setDatabaseEncrypted: introduced boolean flag to be able
to tell the data factory that encryption has been turned off.
Updated implementing method in BaseDataFileFactory
o setDatabaseEncrypted: introduced second boolean flag to be able to
tell the log factory that encryption has been turned off.
Updated implementing methods in LogToFile and ReadOnly.
o RawContainerHandle.encryptContainer: renamed to
encryptOrDecryptContainer, added boolean flag to control crypto
operation.
Updated implementing method in BaseContainerHandle
o BaseContainer.encryptContainer: renamed to encryptOrDecryptContainer,
added boolean flag to control crypto operation.
Updated implementing methods in RAFContainer and InputStreamContainer
o EncryptData: renamed to EncryptOrDecryptData, added method
decryptAllContainers, whitespace changes.
o RawStore:
- removed import
- removed instance variable encryptDatabase
- removed unused instance variable dataDirectory
- renamed databaseEncrypted to isEncryptedDatabase
- renamed configureDatabaseForEncryption to applyBulkCryptoOperation
- made setupEncryptionEngines return a boolean: whether or not
existing data must be transformed (applyBulkCryptoOperation)
- simplified parts of the logic in setupEncryptionEngines
- introduced isTrue/isSet for property sets
- removed unused method privList(File)
Patch file: derby-5792-1b-boilerplate_and_preparation.diff
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1390712 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/iapi/store/raw/log/LogFactory.java",
"hunks": [
{
"added": [],
"header": "@@ -28,12 +28,10 @@ import org.apache.derby.iapi.store.raw.data.DataFactory;",
"removed": [
"import org.apache.derby.iapi.store.raw.ScannedTransactionHand... |
derby-DERBY-5796-4d04d503 | DERBY-5796: Remove unused methods in client.am.DateTime
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1346320 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/client/org/apache/derby/client/am/DateTime.java",
"hunks": [
{
"added": [],
"header": "@@ -20,7 +20,6 @@",
"removed": [
"import org.apache.derby.shared.common.i18n.MessageUtil;"
]
},
{
"added": [],
"header": "@@ -645... |
derby-DERBY-5797-afe4dfdf | DERBY-5797: AssertionFailedError in functionTests.tests.lang.UpdateStatisticsTest.testDisposableStatsEagerness
Make the test sleep for at least one tick of the system timer to ensure the
comparison of statistics creation timestamps are valid in the normal case
(i.e. when there is no bug).
Added two utility methods to BaseTestCase:
o sleep(long ms)
o sleepAtLeastOneTick()
Removed two existing sleep-methods in test classes (note that the one taking
numbers of seconds as argument was unused).
Patch file: derby-5797-1a-sleep_a_tick.diff
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1347888 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-5801-b9e0e745 | DERBY-5801: Sub-processes should write EMMA coverage data to separate files
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1347667 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-5802-77ba1811 | DERBY-5802: Remove unused class ExecProcUtil
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1347885 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/testing/org/apache/derbyTesting/functionTests/util/ExecProcUtil.java",
"hunks": [
{
"added": [],
"header": "@@ -1,107 +0,0 @@",
"removed": [
"/*",
" ",
" Derby - Class org.apache.derbyTesting.functionTests.util.ExecProcUtil",
... |
derby-DERBY-5803-8ab3fa6d | DERBY-5803: Make error handling in xaHelper more explicit
Make error handling method return an execption and raise it explicitly.
Note that the method may still throw runtime exceptions.
Patch file: derby-5803-1a-explict_throw.diff
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1348818 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/tools/org/apache/derby/impl/tools/ij/xaHelper.java",
"hunks": [
{
"added": [],
"header": "@@ -30,14 +30,12 @@ import java.util.Locale;",
"removed": [
"import javax.transaction.xa.XAResource;",
"import org.apache.derby.iapi.services.info.JVMIn... |
derby-DERBY-5806-4bdaec20 | DERBY-5806: Fix parsing of empty string in DRDAConnThread. Set ClientStatement.sqlMode_ correctly for empty statements.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1537874 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/client/org/apache/derby/client/am/ClientStatement.java",
"hunks": [
{
"added": [
" sqlMode_ = executeType==executeQueryMethod__?isQuery__:isUpdate__;"
],
"header": "@@ -2259,6 +2259,7 @@ public class ClientStatement implements Statement, Stateme... |
derby-DERBY-5808-e437bc34 | DERBY-5808: Compatibility test should use BaseTestCase.execJavaCmd()
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1350133 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-5810-99028754 | DERBY-5810: Include emma.jar on classpath when running compatibility test with instrumented jars
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1350134 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-5814-afe6225b | DERBY-5814 Source cleanup in catalogs "impl.sql.catalog" and "impl.sql.compile"
Patch catalog-compile-cleaning-2, which:
a) removed unused private methods
b) removed unused local variables and members
c) cleaned up imports
d) remove unused formal arguments
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1350289 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/sql/catalog/DropDependencyFilter.java",
"hunks": [
{
"added": [
"import org.apache.derby.iapi.error.StandardException;",
"import org.apache.derby.iapi.services.monitor.Monitor;",
"import org.apache.derby.iapi.sql.execut... |
derby-DERBY-5817-273ad5f7 | DERBY-5817: Add support for the JaCoCo code coverage tool
Adds initial support for the JaCoCo code coverage tool.
Top-level ant targets:
o jacoco-complete: runs derbyall, suites.All, junit-lowmem and junit-pptesting
o jacoco-junit: runs suite.All
o jacoco-junit-single: runs test specified by the property
The report currently ends up under 'junit_{timestamp}/coverage-report'.
You need to install 'jacocoant.jar' and 'jacocoagent.jar' in 'tools/java/'
Refactored the ant target 'getsvnversion' (now also loads the version into the
property 'changenumber' and runs only if that property isn't already set).
Patch file: derby-5817-1c-jacoco_support.diff
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1352502 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-5819-f5c1abdc | DERBY-5819 Add logic to BaseTestCase to start subprocesses ready to be attached to from a Java debugger
Adds options to allow this capability for Oracle Java (properties below
ignored for other implementations):
derby.test.debugPortBase=<int> default 8800
derby.test.debugSubProcesses=<boolean> default false
derby.test.debugSuspend=<y|n> default 'y'
If several subprocesses are created, the port for subprocess two will be
debugPortBase + 1 (i.e. 8801 by default) etc.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1356457 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-5821-001ac634 | DERBY-5821: tools/derbyrunjartest.java doesn't use jvmflags
Add the test to the tools suite. Skip testing the server command on
J2ME platforms, where it's not supported.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1359068 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-5821-3919c525 | DERBY-5821: tools/derbyrunjartest.java doesn't use jvmflags
Converted the test to JUnit to allow it to use BaseTestCase's helper
methods for starting sub-processes.
Extended BaseTestCase's helper methods with support for running jar
files with java -jar.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1353862 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-5823-8f8881fd | DERBY-5823: Multi-row insert fails on table without generated keys with RETURN_GENERATED_KEYS
The fix contains two parts:
1. Don't collect generated keys if the statement does not actually
generate key values. (This is the fix for the reported problem.)
2. Cache the array of generated key columns between executions. In the
existing code, the array of key columns was created only on the
first execution. Since it wasn't cached, it was null on all
subsequent executions. When it is null, all columns are collected
into the temporary row holder, which wastes space. Now, only the
key columns are collected, also on re-execution.
The test case was contributed by Kristian Waagan.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1537888 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/sql/execute/InsertResultSet.java",
"hunks": [
{
"added": [
"import java.util.Arrays;"
],
"header": "@@ -21,6 +21,7 @@",
"removed": []
},
{
"added": [
" private int[] ... |
derby-DERBY-5824-2d7d37f1 | DERBY-5824: Disable OSReadOnlyTest when run as privileged user
When running the test as root, it is able to modify the database even
though all database files have been made read-only. Disable the test
in such environments.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1599544 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-5826-666ab8f5 | DERBY-5826: Remove unused methods in NetConnectionReply class
This patch was contributed by Mohamed Nufail (nufail56 at gmail dot com)
This change removes several unused methods from the NetConnectionReply
class. Code inspection of the NetConnectionReply class reveals that
the following methods are not used at all:
- verifyConnectReply(int codept)
- readDummyExchangeServerAttributes(Connection connection)
- checkRequiredObjects(boolean receivedFlag, boolean receivedFlag2, boolean receivedFlag3, boolean receivedFlag4, boolean receivedFlag5, boolean receivedFlag6)
- checkRequiredObjects(boolean receivedFlag, boolean receivedFlag2, boolean receivedFlag3, boolean receivedFlag4, boolean receivedFlag5, boolean receivedFlag6, boolean receivedFlag7)
The change also removes the method parseConnectError() which is being used
only by the removed method verifyConnectReply(int codept)
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1355959 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/client/org/apache/derby/client/net/NetConnectionReply.java",
"hunks": [
{
"added": [],
"header": "@@ -57,47 +57,6 @@ public class NetConnectionReply extends Reply",
"removed": [
" void verifyConnectReply(int codept) throws SqlException {",
... |
derby-DERBY-5827-f7066326 | DERBY-5827: Remove unused methods in NetStatementReply class
This patch was contributed by Mohamed Nufail (nufail56 at gmail dot com)
This change removes several unused methods from the NetStatementReply
class. Code inspection of the NetStatementReply class reveals that
the following methods are not used at all:
parseQRYPRCTYP()
parseSQLCSRHLD()
parseQRYATTSCR()
parseQRYATTSET()
parseQRYATTSNS()
parseQRYATTUPD()
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1356065 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/client/org/apache/derby/client/net/NetStatementReply.java",
"hunks": [
{
"added": [],
"header": "@@ -1648,17 +1648,6 @@ public class NetStatementReply extends NetPackageReply implements StatementReply",
"removed": [
" // Query Protocol type specifie... |
derby-DERBY-5828-29fe9b7f | DERBY-5828: Remove unused methods in NetPackageReply class
This patch was contributed by Mohamed Nufail (nufail56 at gmail dot com)
This change removes the unused parsePKGNAMCT method in NetPackageReply.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1356568 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/client/org/apache/derby/client/net/NetPackageReply.java",
"hunks": [
{
"added": [],
"header": "@@ -197,18 +197,4 @@ public class NetPackageReply extends NetConnectionReply {",
"removed": [
" // RDB Package Name and Consistency token Scalar Object sp... |
derby-DERBY-5830-1966619e | DERBY-5830: Make DoubleProperties.propertyNames() thread-safe
Don't store the property values in the intermediate Hashtable as they
are not needed. They may be null if the Properties instances are
modified after the recursive calls to Properties.propertyNames(), and
trying to store a null value in a Hashtable results in a
NullPointerException, causing issues such as DERBY-4269.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1353852 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/iapi/util/DoubleProperties.java",
"hunks": [
{
"added": [
"import java.util.Collections;",
"import java.util.HashSet;",
"import java.util.Properties;"
],
"header": "@@ -21,8 +21,10 @@",
"removed": [
... |
derby-DERBY-5833-ab750e37 | DERBY-5833: Remove unused methods in NetCallableStatement class
This patch was contributed by Mohamed Nufail (nufail56 at gmail dot com)
This change removes the following unused methods from the
NetCallableStatement class:
- resetNetCallableStatement(NetAgent netAgent, NetConnection netConnection, String sql, Section section)
- resetNetCallableStatement(NetAgent netAgent, NetConnection netConnection, String sql, Section section, ColumnMetaData parameterMetaData, ColumnMetaData resultSetMetaData)
I suspect that, of the two remaining overloads of the resetNetCallableStatement
method, the 3-argument variant could be made private, as it is called only
by the 6-argument variant. That might be a further improvement we could do
at some future time. For now, this change simply removes the two variants
that are wholly unused.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1356066 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/client/org/apache/derby/client/net/NetCallableStatement.java",
"hunks": [
{
"added": [],
"header": "@@ -91,22 +91,5 @@ public class NetCallableStatement extends NetPreparedStatement",
"removed": [
" void resetNetCallableStatement(NetAgent netAgent,"... |
derby-DERBY-5834-ca72f66a | DERBY-5834: Remove unused methods in NetPreparedStatement class
This patch was contributed by Mohamed Nufail (nufail56 at gmail dot com)
This change removes two unused overloads of the resetNetPreparedStatement
method in NetPreparedStatement.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1356573 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/client/org/apache/derby/client/net/NetPreparedStatement.java",
"hunks": [
{
"added": [],
"header": "@@ -141,24 +141,6 @@ public class NetPreparedStatement extends NetStatement",
"removed": [
" void resetNetPreparedStatement(NetAgent netAgent,",
... |
derby-DERBY-5838-31bea464 | DERBY-5838: Prevent users from changing the value of the DataDictionaryVersion property.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1356333 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/sql/LanguageDbPropertySetter.java",
"hunks": [
{
"added": [
"import org.apache.derby.iapi.sql.dictionary.DataDictionary;"
],
"header": "@@ -30,6 +30,7 @@ import org.apache.derby.iapi.services.sanity.SanityManager;",
... |
derby-DERBY-5839-f3ade652 | DERBY-5839 (dblook run on toursdb fails on triggers with java.lang.StringIndexOutOfBoundsException in dblook.log)
We document that SYSTRIGGERS.REFERENCEDCOLUMNS is not part of the public API and hence that allows Derby to change underneath the behavior of the column. Prior to 10.9, this column only had information about columns referenced by UPDATE trigger. But, with 10.9, we use this column to also hold information about the trigger columns being used inside trigger action plan. This enables Derby to read only necessary columns from trigger table. But because of this change, it is not enough in dblook to check if SYSTRIGGERS.REFERENCEDCOLUMNS.wasNull. We need to also check if the string representation of that column is "NULL". Making this change fixes DERBY-5839
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1370446 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/tools/org/apache/derby/impl/tools/dblook/DB_Trigger.java",
"hunks": [
{
"added": [
"\t\t\t\t\t\t//DERBY-5839 dblook run on toursdb fails on triggers",
"\t\t\t\t\t\t//\twith java.lang.StringIndexOutOfBoundsException in",
"\t\t\t\t\t\t//\tdblook.log"... |
derby-DERBY-584-0c186b3d | Add workaround in DatabaseMetaDataTest for DERBY-584 to stop DatabaseMetaDataTest failing.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@509420 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-5840-27fbf330 | DERBY-5840: Compile network server code with source and target level 1.5
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1361925 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/build/org/apache/derbyBuild/classlister.java",
"hunks": [
{
"added": [
"\t\t// they must be picked up from derby.jar and not put in"
],
"header": "@@ -491,7 +491,7 @@ public class classlister {",
"removed": [
"\t\t// they must be pick... |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.